SFC-213 SFC statistics dont always work

- The OpenFlow NodeId is not available on
  the SFF, so the statistics cant work.
- There's a race condition between when SFC
  creates the OVS bridge for an SFF and when
  we try to get the bridge DPID.

Change-Id: I05b2d0da61f8147ffea0a995b3efef38cbf05b31
Signed-off-by: Brady Johnson <[email protected]>

Refactor to change packages' names

sfc-ios-xe-renderer package is replaced by more canonical name:
org.opendaylight.sfc.renderers.iosxe

Change-Id: I86e9f2e355e86823300c4de7003d4133f1dfe95e
Signed-off-by: David Suarez <[email protected]>

Refactor sfc-vpp-renderer

- Migrate to use Blueprint
- Use Blueprint annotations
- Migrate listeners to use Genius' ones

Change-Id: Iaec54c9d59bb078e1e455fd10aff96155af9c042
Signed-off-by: David Suarez <[email protected]>

Minor change in .gitignore

Change-Id: Icb8095295dbb30eba28a624c608aaeb1b4a4fdda
Signed-off-by: David Suarez <[email protected]>

Fix sfc-104 demo issues

Change-Id: Idfd3cc4b3fdca31188c4a4c2132ee06ed3ebe3a1
JIRA: SFC-218
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

SFC-218: Fix sfc-scf-vpp wiring

Change-Id: I73ad125c433f145bba93ef8b0c56f0cfb344a30d
JIRA: SFC-218
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Remove binary jar and download when running test

Change-Id: I15bbbb8a56d2e208b472d096ed85c9e166132258
Signed-off-by: Brady Johnson <[email protected]>

Refactor to change packages' names

sfc_vpp_renderer package is replaced by more canonical name:
org.opendaylight.sfc.renderers.vpp

Change-Id: I08a361eb9aab2f692a2a125b4447a1fc3dd5c7ad
Signed-off-by: David Suarez <[email protected]>

SFC-214: Fix sb-rest wiring

Missing build plugin and incorrect bean naming was preventing the
blueprint wiring to actually happen. Fixed the SFF listener which
was missing the wiring annotations. Got rid also of the unnecessary
provider module.

Change-Id: Id3b6ef73cd274a108b07a50fedbe94eab6123cf3
JIRA: SFC-214
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

SFC-216: Fix exception message check for bad macs

The IllegalArgumentException message thrown when constructing a bad
MacAddress (or any IllegalArgumentException thrown for any yang type
value that fails a regex pattern check) changed with [1].

[1] https://git.opendaylight.org/gerrit/#/c/68461/

Change-Id: I5b6a73773cb6b4742d004b6bc6ac7ae6e38e4d66
JIRA: SFC-216
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Bump versions by x.(y+1).z for next dev cycle

Change-Id: Ie6a846caecb2cdec46cced1398dcf0c8ab11e42f
Signed-off-by: Anil Belur <[email protected]>

SFC-210: Remove config RSP on delete RSP rpc (II)

First patch did not really deal with the fact the previous behavior of
the RPC was to return once the operational RSP was already deleted.
This patch aligns the solution of the delete RPC to the one adopted
for the create RPC which respects previous behavior. And solves the
corresponding test case that fails in the basic SFC csit suite.

Change-Id: I7d21665c32f3358b083f43932da3285c11d7c1fe
JIRA: SFC-210
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Avoid exception on default scheduler handling

Default scheduler selection is handled through an exception that is
printed out in the logs and looks rather ugly. Replaced by a proper
cleaner log message.

Change-Id: I1fd8e6ffe91eaa45ef21a15942c58d12983a5f9d
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Fixes for mac chaining demo

- Fix the traffic  example given in the instructions
- Fix the demo not working with a remote ODL
- Set python output to unbuffered for dummy SFs and GW
  so that output is actually written while using the demo
- Fix ovs node id value although commented out for now as it has side
  effects: when set, some values are overwritten on OVS topology node,
  which changes the node's datapath id.
- Provided a vagrant file with a mininet environment

Change-Id: Ic001ff9ecd7a91ee6fc56b90fff1fe1d56565edb
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Fix openflow node mess in mac chaining classifier

Mac chaining SCF classifier was obtaining the openflow node
to write flows to through different ways on different places:
sometimes it would use the service node while others would
use the methods of SfcOvsUtils. Also it would sometimes try to
obtain the SFF from the openflow node when it already has it
readily available through a class property. So cleaned up this
which allowed also to clean up the ClassifierInterface a bit.

Change-Id: I8fe070e2a3a70a17b4520012de9358617b51d63f
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Fix NPEs and improved debugging in SCF classifier

Fixed some methods that would return null if some mandatory input data
was also null. Users of these methods were not prepared for this even
thought there were unit tests asserting this behavior.

As there is no good reason for that data to possibly be null, make them
fail with a controlled NPE and remove unit tests.

Change-Id: I16baa44d1ad6a844aef2a33cc7f3121be7f12c98
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

SFC-212: Fix scf rendering with no RSP metadata

Fixes a problem where the rendering of the classifier flows would fail
if the RSP did no include the optional NSH metadata.

Change-Id: Ib8c4bef199b704db202a3c71faee1a93dea77068
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

SFC-211: Fix service function path state not deleted

Change-Id: Icd413d85002cda4e51f4a003bb71260f266dc984
JIRA: SFC-211
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

SFC-210: Remove config RSP on delete RSP rpc

Change-Id: I6cf06398e6046dabcf3339ddeb1f68a910a8c882
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Fix lisp NPEs on Logical SFF and more

Change-Id: I95fabe89de7ca0b02aa64fe2191ca3c945e564ad
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

UT for SfcStatistics

Change-Id: Ib84e5ecfff1be0cc51cb78b9b5189cd23894d9f9
Signed-off-by: Brady Johnson <[email protected]>

SFC-208: Add hardening for create RSP RPC

Change-Id: I05125e0e3486572b98c756a9fed6d525ba57c529
JIRA: SFC-208
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Config data store listener for RSP creation

- Previous RSP creation via RPC is deprecated, but still supported.
- Now its possible to create RSPs with a write to the SFP config.
- SFP config creation will trigger an RSP config creation, which
  triggers an RSP oper creation.
- Deleting or modifying SFs/SFFs now deletes the SFP, not the RSP
- Still pending: Unit tests

Change-Id: I9cf947abdac6433d0e7d961c372f43f0f6d572c8
Signed-off-by: Brady Johnson <[email protected]>
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

RSP statistics feature

- RSP statistics are retrieved on-demand by calling an RPC
- To be completed next: Unit Tests

Change-Id: If90657ad339a77bc50e6809ccbb1425c5eb31872
Signed-off-by: Brady Johnson <[email protected]>

Refine affected RSP search on SFF update

Previously, any SFF locator update would cause the removal of any RSP
associated with that SFF. With this patch, in regards to a SFF locator
update, an associated RSP will be removed only if any of these
conditions are met:

* The SFF locator is used in a SF dictionary entry for an SF associated
with the RSP.

* The RSP is associated with more SFFs than the updated SFF so that the
updated locator could be used in a SFF-SFF hop.

This improvement is particularly meaningful for the logical SFF scenario
in combination with the changes introduced for the directional-dpl spec.
The logical SFF singleton is no longer an empty SFF and will be updated
frequently as paths are created or removed. It is fundamental that other
paths are not affected when they shouldn't.

The current data model does not allow for optimum processing and there
might be performance impacts on big SFFs, as the logical SFF most likely
will be. For a future release, there is the option to enhance the data
model to optimize this.

Change-Id: I16660e241779ff24bf644e4377e12965b12f695b
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Use directional dpls for openflow rendering

Change-Id: I36ceff0509d0d33d9e34e6cec4f30df100c3cd06
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Remove legacy sfc-test-consumer feature

- It hasnt been used for a long time

Change-Id: I1141abe111f9ea74e376aa2940ef575f292c8405
Signed-off-by: Brady Johnson <[email protected]>

Fix in the firewall mode of vxlan_tool

The firewall mode of vxlan_tool was not compatible with the ETH + NSH
encapsulation. This patch fixes that through offset which is different in the
two cases we support (the other one is ETH + IP + UDP + VXLAN + ETH + NSH)

Change-Id: Ib8d84bd8d4c06e91b146a68d1a749ecb3eb6070f
Signed-off-by: Manuel Buil <[email protected]>

Eliminate unnecessary explicit yangtools dependencies

Changed the sfc-parent pom to derive from bindng-parent so
yangtools version and dependencies comes from mdsal.

Change-Id: Idb649ef2367af82afd0fc3ed6ed4577aa7740f8b
Signed-off-by: Tom Pantelis <[email protected]>

Bump yangtools to 2.0.1

Change-Id: Iaf9d1af326a2fc11f48f211040efead95e178e8d
Signed-off-by: Luis Gomez <[email protected]>

Emergency path with odlparent/yangtools fixes

- Removed unecessary mandatory attributes. The mandatory
  attribute is now being enforced with the new yangtools.
- Fixed some UT that werent setting mandatory fields.
- Temporarily commented out broken IosXeRspProcessorTest

Change-Id: I22e96ce469fd12531b672faad61f158685e0bd7c
Signed-off-by: Brady Johnson <[email protected]>

Bump to yangtools-2.0.0 and odlparent-3.0.2

Change-Id: Ib2001a498f36ae3242a5f74b4fd729da91a0a359
Signed-off-by: Tom Pantelis <[email protected]>
Signed-off-by: Stephen Kitt <[email protected]>

Move the SFC OpenFlow flow names

- Moving the constants to a common util class so they can
  be easily accessed by other SFC entities, like the forth
  coming RSP statistics feature.
- The SFC OpenFlow renderer will use the statistics feature,
  but the statistics feature needs the SFC flow names, so
  this change will help avoid a cyclic feature dependency.

Change-Id: I69b35eb905aafca92f33149fbe24a4fad472040c
Signed-off-by: Brady Johnson <[email protected]>

Use centOS vault package repository for sfc-docker

Change-Id: Id07475d5cbc7978f97cd42abd45b65c20d7103d1
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Move local karaf to common directory

Most projects have elected to put the local distribution
in the "karaf" TLD.  For consistency sake, this moves
sfc-karaf to the "karaf" directory.

Change-Id: I7929c770459f77f9cf998c27298f4655c408b641
Signed-off-by: Ryan Goulding <[email protected]>

Bind to multiple logical interfaces of SF

Because of directional DPL, SF can have up to a pair of logical
interface locators. This patch adds support to bind/unbind to both
instead of just the one when the SF is included in a rendered path.

Even if the path is not symmetric and only one DPL is really used, there
is no problem binding to all the interfaces of the SF as long as its DPN
is initialized as a SFF, which happens when the SF intervenes in a RSP.

Current limitation is that all the SF interfaces must located on the
same DPN. To overcome this limitation, the logical SFF operational
information needs to be enhanced.

Change-Id: I911eeffa113e040eef9a1add20edcfb8534221ee
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Set reverse path flag on RSP

Change-Id: I1577f2c08c7fda55412239d0a73929d59a15e56b
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Fix odlparent 3 Checkstyle issues

Change-Id: I525c8a677032f9b1c874a9170223b2c63777887e
Signed-off-by: Tom Pantelis <[email protected]>

API changes for the rsp-config feature

- Modifying the "config: true/false" attribute on
  several of the RSP data model nodes.

Change-Id: If04109d12fe2226e3959a875237dfc41e7d6fd5b
Signed-off-by: Brady Johnson <[email protected]>

SFC Statistics RPC operations definitions

- API changes for the rsp_stats feature

Change-Id: Ie69642d46fc7ae2977f51cba987301d3997de64b
Signed-off-by: Brady Johnson <[email protected]>

Add yang model for directional data plane locators

Plus updated spec to align it to the latest model proposal.

Change-Id: I7984d8e55decdeb91cd5611ad396b8a14f3492de
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Spec for the new RSP statistics feature

Change-Id: I88299b00386b8805f9ca69f3023b373661483338
Signed-off-by: Brady Johnson <[email protected]>

Spec for directional data plane locators

Change-Id: Ie7cfa1ddea8a4c3be318abb57489000a8770ec74
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Refactor sfc-scf-vpp module

- Proper use of Blueprint to wire all the components: convert some
  classes into @Singleton, remove the SfcScfVppRenderer, use annotations
  instead of XML, remove some useless parameters.
- Clean up
- Migrate SfcScfVppDataListener to use Genius listeners.

Change-Id: Ie7c608fd76b3cef44989d2b0c6c926f2d47c6f25
Signed-off-by: David Suarez <[email protected]>

SFC-205: Fix wrong table when removing scf flows

Fixes SFC SCF classifier removing flows from incorrect table. Refactored
ClassifierInterface to provide the correct table numbers and for
MacChainingClassifier to also implement it.

Change-Id: I4383209ce24d0d3dce14f8f498c91abaf36b6c09
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

SFC-206: Fix no sfc-scf-openflow listeners @runtime

sfc-scf-openflow listeners were not being instantiated by blueprint
because their constructor parameters were not singletons that could be
injected. Introduced in b5fabe5.

Fixed by creating the listeners manually.

Bug: https://jira.opendaylight.org/browse/SFC-206
Change-Id: If3a01d691cbce8478537fd50cdead461d6740e9c
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Migrate sfc-ovs listeners to Genius' Listeners framework

Change-Id: I02019c49787c45cd45d3d27d089e5bc0a140416d
Signed-off-by: David Suarez <[email protected]>

Migrate sfc-pot-netconf-renderer to use Genius' Listeners framework

- Migrate the listeners to use the new framework available in Genius
- Replace Blueprint XML entries by the corresponding annotations
- Make some utilities and helpers proper singletons instantiated via BP
- Other minor changes and clean up

I'll rise a follow up patch to improve the design.

Change-Id: Ia343627fdb9cc4c93384a2499623faf040857316
Signed-off-by: David Suarez <[email protected]>

Annotate some parameters as @Nonnull

This allows to remove some checks.

Change-Id: I37125b35da5d37f9556d05223ad0cfe83070e0a1
Signed-off-by: David Suarez <[email protected]>

Annotate some parameters as @Nonnull

Change-Id: I1615fd920527f675243fe433289b7e66947eb8a8
Signed-off-by: David Suarez <[email protected]>

Fix broken formatting in rsp-config-datastore docs

"code-block" takes exactly one argument, the name of the language
contained by the code-block.  This fixes the formatting issue.

Change-Id: Ib7f4fc6727bd2fb4378c5c87eb46e4fda6f4015d
Signed-off-by: Ryan Goulding <[email protected]>

Updates to create RSPs via config data store

- deprecate RSP creation via RPC
- Update RSP data model changing "config false" fields.

Change-Id: Ifbc2e81b0fb56325f8a8c0e874d126e161a45ecb
Signed-off-by: Brady Johnson <[email protected]>

Remove trailing spaces and tabs in resource files

Remove trailing spaces to pass the checkstyle rules included in [1].

[1] https://git.opendaylight.org/gerrit/#/c/48710/

Change-Id: I5b67bc919be751bfab04f74b43ffdba88fdde010
Signed-off-by: David Suarez <[email protected]>

Spec for RSP creation in config data store

Change-Id: Ib6e25bd9424ae65a8a1b8bbc102978138d2f3c63
Signed-off-by: Brady Johnson <[email protected]>

Fix some checkstyle issues for the upcoming odlparent 3.0

Change-Id: If2e6542e28f50d1c80bc696250cd62f28c3f79f9
Signed-off-by: David Suarez <[email protected]>

Remove deploy-site.xml

With the javadoc jobs now available to generate javadoc it is time to
remove the maven-sites and related files.

Change-Id: Icc219da3bc0a3ac639692d041f651f85a086e5f5
Signed-off-by: Thanh Ha <[email protected]>

Refactor listeners in sfc-sb-rest module to remove off-loading twice

Change-Id: Ibf10e63fbed0366981dfd2f9c01d46f1f8626674
Signed-off-by: David Suarez <[email protected]>

Refactor listeners in sfc-ios-xe-renderer module

All listeners in this module have been migrated to use the new listener
framework from Genius. Taking advantage of this migration process they
now use BP annotations to be wired. Renderers have been migrated to use
BP as well, so the SfcIosXeRenderer component (in charge of wiring) is
not needed anymore.

Change-Id: Ib3f059900e9018d1fe91a2e447c78e20d6503970
Signed-off-by: David Suarez <[email protected]>

Migrate sfc-genius listeners

Change-Id: I2b29f8e0925be3235f746a879e8e587dbaae7a39
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Fix the broken build

Change-Id: I81461de5e14b17f0c29d0762d62159e667a48b04
Signed-off-by: David Suarez <[email protected]>

Refactor listeners in sfc-sb-rest module

- Use Genius Listeners Framework
- Use blueprint annotations so they can be directly handled by BP
- Some minor fixes
- Checkstyle

Change-Id: I3608e5c74a1b5a9af3d9e707d93c30b2bc4bd61b
Signed-off-by: David Suarez <[email protected]>

Refactor listeners in sfc-scf-openflow module

- Use Genius Listeners Framework
- Use blueprint annotations so they can be directly handled by BP
  instead of the SfcScfProcessor singleton class
- Some minor fixes
- Checkstyle

Change-Id: I0c8029e4c8db2f65c76006e838108deb57d33141
Signed-off-by: David Suarez <[email protected]>

Deprecate the abstract listeners included in sfc-provider

The AbstractClusteredDataTreeChangeListener and
AbstractDataTreeChangeListener are replaced by the classes present in
Genius' package org.opendaylight.genius.datastoreutils.listeners.

Change-Id: I2fcb0187e2b3f43b7ea9d872c50de1543e89f384
Signed-off-by: David Suarez <[email protected]>

Migrate the rest of the sfc-provider's listeners

Migrate the rest of the sfc-provider listener to use Genius' listeners

Change-Id: Idafd8020f1f7620ae22e7d894ac0c0a38e7285fb
Signed-off-by: David Suarez <[email protected]>

Migrate ServiceFunctionChainListener to Genius' Listeners

Change-Id: I26eaa162202c497fd286d1c028216c519997e69b
Signed-off-by: David Suarez <[email protected]>

Migrate ServiceFunctionForwarderListener to Genius' Listeners

Change-Id: Ie09ee0efe4fde576b366a95a85ff41cd55f87488
Signed-off-by: David Suarez <[email protected]>

Migrate ServiceFunctionListener listener to use the new Listeners FW

Migrate the ServiceFunctionListener listener to use the new Listeners
framework available since [1].

[1] https://git.opendaylight.org/gerrit/#/c/59177/

Change-Id: Ie7306de4cf4af48d88a645dd872a3143337be5c7
Signed-off-by: David Suarez <[email protected]>

Minor cleanup

More changes will follow.

Change-Id: Ib4a0a2adb59ea206fc7d27cf68201732653db508
Signed-off-by: David Suarez <[email protected]>

Minor cleanup

Change-Id: I5023ca7b29220611c4b5545ce800ea958cee111f
Signed-off-by: David Suarez <[email protected]>

Refactor sfc-pot to non-static

The pom.xml files both in sfc-pot and sfc-provider need to be changed
so they generate autowire.xml files properly.

Change-Id: I4363ebecaab832844561d74689719deeb31c1e60
Signed-off-by: David Suarez <[email protected]>

Move this service to use blueprint annotations

Move this service to use blueprint annotations instead of xml file.
Some simplifications.

Change-Id: Ic6937e5dab03c26097a4b6c3d1967187b64dc7b4
Signed-off-by: David Suarez <[email protected]>

Unbind SFC service when removing SFs

This prevents leftover SFC bindings when the SFs are removed quickly
after the RSPs.

Change-Id: Idf81d862111b054ecd4681de295973f2b01c2e9e
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Fix some NPEs related to logical SFF

Change-Id: I3d92cf53c61e86a693a0d68f08e9c23f05499186
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Fix checkstyle issues

These utility classes should be declared as final.

Change-Id: Iedacd1ecfcecf0a42a7d4d21879cf7ae98609dbd
Signed-off-by: David Suarez <[email protected]>

Fix checkstyle issues

These utility classes should be declared as final.

Change-Id: I6bcaeb367e0408289e5fca4e0640779fea4a0b98
Signed-off-by: David Suarez <[email protected]>

Fix checkstyle issues

These utility classes should be declared as final.

Change-Id: I06b193536f6eccadebb819c67916b6f489933cfc
Signed-off-by: David Suarez <[email protected]>

Fix checkstyle issues

These utility classes should be declared as final.

Change-Id: I7f94c771c0d9c5be05a0a8ccf13d1b8d4924cdfd
Signed-off-by: David Suarez <[email protected]>

Fix checkstyle issues

These utility classes should be declared as final.

Change-Id: I9f391df1c5582da2b0c554c2b395e3c22d41140a
Signed-off-by: David Suarez <[email protected]>

Fix checkstyle issues

These utility classes should be declared as final.

Change-Id: I321e5471146418858a291618d00cc15e914da139
Signed-off-by: David Suarez <[email protected]>

Fix checkstyle issues

These utility classes should be declared as final.

Change-Id: Ie907b638ef74eafc09fa75caf8020969a48285e9
Signed-off-by: David Suarez <[email protected]>

Fix checkstyle issues

These utility classes should be declared as final.

Change-Id: I1f69d03bfe5cb63c543ff33650975c7d25b7e385
Signed-off-by: David Suarez <[email protected]>

Clean up sfc-karaf module

Just remove unused properties section, commented out version, and
fix some typos.

Change-Id: I5cacd5f95f0b7328b79f59cc78f621a41946dbb9
Signed-off-by: Ryan Goulding <[email protected]>

Move findbugs plugin to parent pom

- Fix the issues in the sfc-test-consumer module
- Add an empty class to the sfc-ui-module module to prevent the
  findbugs plugin from failing when there is no code inside a module.

Change-Id: Ic7c4bc9e4667f5780743aa2dd8334925fb6fe07c
Signed-off-by: David Suarez <[email protected]>

Move checkstyle enforcement to parent pom

Now that all the SFC modules are checkstyle compliant we can move the
enforcement to parent pom.

Change-Id: I69ee963390eff9793458974bbcea0cb37f5c5a7c
Signed-off-by: David Suarez <[email protected]>

Make some improvements

- Proper declaration of constants
- Make private some variables and methods
- Remove redundant initializations
- Size()!=0 replaced by isEmpty()
- Simplification of stream filter

Change-Id: I5198f75352828c222c1f79ea99ad691adbee4b3d
Signed-off-by: David Suarez <[email protected]>

Fix findbugs/checkstyle/sonar violations in sfclisp

- Method parameters, caught exceptions and foreach variables should not be reassigned
- Field isn't final but should be
- Write to static field from instance method
- Possible null pointer dereference on branch that might be infeasible
- Field not initialized in constructor but dereferenced without null check
- Boxed value is unboxed and then immediately reboxed

Change-Id: I6ea1dbcd4fb87c96a712cf5579f7b774993eb7e2
Signed-off-by: Tom Pantelis <[email protected]>

BUG-9218: Fix odl-sfc-shell dependencies

This was found by analyzing features present in Nitrogen release,
odl-sfc-shell should depend on odl-sfc-provider rather than
packaging duplicates.

Change-Id: Ib057a546e8502b2ca23d61230f20b5caff88c812
Signed-off-by: Robert Varga <[email protected]>
(cherry picked from commit f13c04a917f5c447de94c18d11dd053f85e299e3)

vxlan_tool was checking only two bytes of the mac

When opening a raw sockets, the forwarded packets are also consumed. Therefore
we need a way to drop the generated packets so that they are not processed
again. The way to do this was by compating the interface's mac address and the
destination mac address of the packet, however, the comparison only checked
two bytes and thus there were situations in which the tool misbehaved. This
patch compares all the bytes of the mac

Change-Id: I151b7cc5d379e38f86d6583c6aad41ebe2e62011
Signed-off-by: Manuel Buil <[email protected]>

Make some improvements

- Simplify if-else statement
- Replace StringBuffer with String
- Remove unboxing
- Inline some variables

Change-Id: I71363c5a565d74e6d4577344acb7491eb18bea7c
Signed-off-by: David Suarez <[email protected]>

Fix issues for future checkstyle enforcement

- These issues will be detected by the new checkstyle rules.

Change-Id: Ib8259951806999012e7ee400d8a646dc631d5a7f
Signed-off-by: David Suarez <[email protected]>

Cleanup vpp-renderer

- Remove redundancies
- Replace two loops
- Remove unused parameters
- Remove redundant checks

Change-Id: I5b9b6a9ca5be187674604d9c87acc935e25b10c1
Signed-off-by: David Suarez <[email protected]>

Fix findbugs/checkstyle/sonar violations in sfc-vnfm-tacker

- Local variables should not shadow class fields
- May expose internal representation by returning reference to mutable object
- May expose internal representation by incorporating reference to mutable object
- Utility classes should not have public constructors

Change-Id: I2af6bc7576cd1f5c9bb3e09689c5a692f9241342
Signed-off-by: Tom Pantelis <[email protected]>

Fix findbugs/checkstyle/sonar violations in sfc-pot

- Load of known null value
- Unused private fields should be removed

Change-Id: I4b3716c1ba470d5384d0281ef46a9fcff433476c
Signed-off-by: Tom Pantelis <[email protected]>

Use shared executor for listeners

Each DataTreeChangeListener creates its own fixed thread pool
with 5-10 threads. A fixed thread pool prefers creating threads
over queueing and reusing an idle thread so each listener pool
will eventually create all its thread which will not be reclaimed
until the pool is shutdown. This can lead to a lot of idle
threads during normal periods of inactivity across all the
listeners.

It would be nore efficient to share a thread pool across all
the listeners since data change notifications should be relatively
infrequent. Also I think a cached thread pool which automatically
reclaims idle threads after a period of inactivity would be more
conducive than a fixed thread pool. Also using a bounded queue
would protect against potential memory exhaustion should there be
a heavy burst and/or possible long-lived tasks.

Change-Id: Id3da34cba7f7d98c599a09e8a82a3e36091796a4
Signed-off-by: Tom Pantelis <[email protected]>

Fix findbugs/checkstyle/sonar violations in sfc-netconf

- Unused private fields should be removed
- Incorrect lazy initialization and update of static field
- Write to static field from instance method
- Useless object created

In order to fix some of these issues I refactored the code a bit to
remove statics - comments in-line.

Change-Id: I4382aebdb4aab1a701bc68adbe9957021bb46d0e
Signed-off-by: Tom Pantelis <[email protected]>

Enable findbugs enforcement in sfc-vnfm-spi

No current violations to fix.

Change-Id: Ib93d6cccee85b9f3c129019bcc01ddaf0a7a6410
Signed-off-by: Tom Pantelis <[email protected]>

Enable findbugs enforcement in sfc-shell

No current violations to fix.

Change-Id: I86c98baaadcecf18578bc4a739292bcfe2e1d92b
Signed-off-by: Tom Pantelis <[email protected]>

Fix findbugs/sonar violations in sfc-openflow-utils

- Utility classes should not have public constructors
- Collapsible "if" statements should be merged
- Possible bad parsing of shift operation
- Unused private fields should be removed
- String.valueOf() should not be appended to a String

Change-Id: I28736bdd901bab31ac98c2b8643bddea32c3aa19
Signed-off-by: Tom Pantelis <[email protected]>

Bump sfc to use yangtools 1.2.0

Jira: releng-485

Change-Id: I08a6e4f7cde4cfa0ec1f984d8110b0d23df97703
Signed-off-by: Anil Belur <[email protected]>

Bump odlparent 2.0.4 to 2.0.5

Change-Id: I744350ce3067e475ef95eb96b0f40abb9419cf38
Signed-off-by: Stephen Kitt <[email protected]>