Robert Varga [Fri, 21 Sep 2018 12:04:07 +0000 (14:04 +0200)]
Speed up YangLibrarySchemaYangSourceProvider
We can potentially have a lot of schemas for a mount point, hence
we should be using an immutable map. Also do not use Map.contains()
before issuing a Map.get(), saving one lookup.
Change-Id: Ic80d2299fa5e67afcbb1578db5e43f999b1a96e5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 21 Sep 2018 11:48:25 +0000 (13:48 +0200)]
Cache SchemaPath for well-known netconf operations
Rather than invoking toPath(QName) on each invocation, allocate
a SchemaPath constant for common operations and reuse it across
invocations.
Change-Id: Iefd0b24ec3dd900ddfe54dc4f89baffa1eec91a1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Thanh Ha [Mon, 17 Sep 2018 16:41:56 +0000 (12:41 -0400)]
Migrate netconf docs to project repo
Issue: DOCS-69
Change-Id: I2941d5aa1ea90ee99c9ffe9269b118ea70648fcb
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Mon, 17 Sep 2018 16:38:37 +0000 (12:38 -0400)]
Bootstrap netconf documentation
Issue: DOCS-69
Change-Id: I131c540aca45c6ad742565193801204227554d43
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Jakub Tóth [Thu, 6 Sep 2018 09:23:38 +0000 (11:23 +0200)]
Fix missing support of actions in KeepaliveSalFacade
Change-Id: I1696a92d699debbd5d97219769f9beabc6ef8624
Signed-off-by: Jakub Tóth <jakub.toth@pantheon.tech>
(cherry picked from commit
332280c42305db34b1b1ca0b59f59964cb5e305f)
Robert Varga [Mon, 27 Aug 2018 10:43:27 +0000 (12:43 +0200)]
Do not instantiate NormalizedNodes for filter
Using ImmutableNodes.fromInstanceId() does not work for leaf nodes,
as we do not have a value, which violates LeafNode contract -- leading
to an IllegalStateException when a user attempts to read() a single
leaf via a transaction.
As it turns out, this is completely unnecessary, as all we are doing
is iterating through the temporary NormalizedNode and creating
NormalizedNodeStreamWriter events based on that.
This patch replicates ImmutableNodes.fromInstanceId() logic, but
simplifies it for this particular task, short-cutting NormalizedNode
creation and emitting events directly as we are iterating over
the YangInstanceIdentifier.
JIRA: NETCONF-563
Change-Id: I0781e81d812ee979deaafb9dfa811e143866f4af
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sun, 26 Aug 2018 20:14:00 +0000 (22:14 +0200)]
Do not allocate an AtomicBoolean
This is costing us an object and therefore a potential cache miss.
We can do better with an explicit AtomicFieldUpdater, saving 16-28
bytes per instance.
Change-Id: Ie5680fed2d6c20487d475621978cf455c492229b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 24 Aug 2018 15:29:05 +0000 (17:29 +0200)]
Optimize sal-netconf-connector translation
Use pre-computed filter type and notably NodeIdentifiers rather than
creating them from QName constants.
Change-Id: I388594484c09757b6f66f5f9e5120359658b02ca
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Marek Gradzki [Tue, 21 Aug 2018 13:47:45 +0000 (15:47 +0200)]
AbstractEdit: improve error message on missing schema node
Include node name in the error message.
Change-Id: Ife8f95cb333e2e1065c2c27d51acb406710cc375
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Jakub Morvay [Tue, 21 Aug 2018 09:15:53 +0000 (09:15 +0000)]
Merge "Add the ability to use schema-aware coding"
Jakub Morvay [Tue, 21 Aug 2018 09:15:07 +0000 (09:15 +0000)]
Merge "NETCONF-557: Add support for URL capability"
Robert Varga [Wed, 17 Jan 2018 18:43:52 +0000 (19:43 +0100)]
Add the ability to use schema-aware coding
With the switch to Exificient we can actually use schema-informed
encoding -- add basic support for that.
Change-Id: If24a418302d151114407ee647ec5e12c3d3b3e76
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 20 Aug 2018 17:20:30 +0000 (19:20 +0200)]
Return Set instead of Iterable in test setup
This allows us to define equality in superclass, hence return
proper Set.
Change-Id: I48c37054440e5983e5033a0ed927080a7d255e72
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 20 Aug 2018 10:29:30 +0000 (12:29 +0200)]
Fix argument strings
When logging an exception we should not have an explicit placeholder
and also we should properly constify arguments. This is pointed out
by updated findbugs.
Change-Id: I71a0b23b5510a36bfe9808dfe92c27717e24fbb3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 20 Aug 2018 10:45:14 +0000 (12:45 +0200)]
Fix checkstyle violations
Updated checkstyle is better at catching violations, fix them up
before upgrading.
Change-Id: I6a2e6f262dabbb753f905f12c1f2161c409a94ed
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Marek Gradzki [Thu, 9 Aug 2018 11:45:54 +0000 (13:45 +0200)]
NETCONF-557: Add support for URL capability
This patch brings support of URL capability
in <edit-config> and <copy-config> RPCs
to mdsal-netconf-connector.
Remote config upload is not supported.
Remote to remote operations are not supported.
The capability is advertised as:
urn:ietf:params:netconf:capability:url:1.0?scheme=file
but config download is also supported via http and https.
Change-Id: Idb5bae4e24ff2a098bc60bf24c36fb40113fd8f5
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Jakub Tóth [Mon, 6 Aug 2018 14:11:29 +0000 (16:11 +0200)]
Prepare netconf to support YANG 1.1 actions
This allows implementation of a factory for creating of DOMActionService
of a connected device. This service is going to be part of services provided
by the device's mountpoint.
Change-Id: I1c79b4bc8f1b1c63f7ffb2306f07ea9872f15882
Signed-off-by: Jakub Tóth <jakub.toth@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sat, 11 Aug 2018 12:53:26 +0000 (14:53 +0200)]
Bump argparse4j to 0.8.1
Major bump.
Change-Id: Ife645b9d0ec6aa07d24eb02bfe604ed87cb1c17e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sat, 11 Aug 2018 12:47:32 +0000 (14:47 +0200)]
Bump async-http-client to 1.9.40
Minor bump
Change-Id: I6f711a040efca3d01d3f4395e57ba6e77652fa80
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sat, 11 Aug 2018 07:40:14 +0000 (09:40 +0200)]
Remove references to mdsal-model-artifacts
This artifact is going away, migrate to mdsal-artifacts.
Change-Id: Ia36440d8428418e94fa9d79dd0a1a7ed2035b5d8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Anil Belur [Thu, 9 Aug 2018 12:40:15 +0000 (18:10 +0530)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: I2b6cfd51fe110a8a04b45a6c3101cc30d98c0245
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Robert Varga [Mon, 6 Aug 2018 15:45:12 +0000 (17:45 +0200)]
Bump yangtools to 2.0.10
This fixes an issue with actions, hence we need it in Fluorine.
Change-Id: Ic6b2c3e7f118512f04bce3d223b480e2ab784098
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Jakub Morvay [Mon, 6 Aug 2018 14:50:23 +0000 (14:50 +0000)]
Merge "NECONF-524 : Setting the netconf keepalive logic to be more proactive."
Jakub Morvay [Mon, 6 Aug 2018 08:01:19 +0000 (08:01 +0000)]
Merge "Improve error message on <validate> failure"
Robert Varga [Sat, 4 Aug 2018 01:14:22 +0000 (03:14 +0200)]
Use Controller's MappingCheckedFuture
This class is being moved from mdsal to controller, adjust for that.
Change-Id: I0b680405789a8bc230cfac54f8cf23ecde768494
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 3 Aug 2018 22:35:19 +0000 (00:35 +0200)]
Bump exificient to 1.0.1
https://github.com/EXIficient/exificient/compare/exificient-0.9.7...exificient-1.0.0
https://github.com/EXIficient/exificient/compare/exificient-1.0.0...exificient-1.0.1
https://github.com/EXIficient/exificient-core/compare/exificient-core-0.9.7...exificient-core-1.0.0
https://github.com/EXIficient/exificient-core/compare/exificient-core-1.0.0...exificient-core-1.0.1
Change-Id: Id811993f3232f6e96dd4c3c4da95c86db9038c24
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 3 Aug 2018 22:34:02 +0000 (00:34 +0200)]
Remove unneeded version declaration
We are getting aaa versions from dependencyManagement, do not repeat
them again.
Change-Id: I860d63075e5fb004518c1c5955cb96d88f24cc55
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Marek Gradzki [Fri, 3 Aug 2018 12:28:56 +0000 (14:28 +0200)]
Improve error message on <validate> failure
Change-Id: I1af1c918c0a21645380ce3ce55c608729365f140
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Robert Varga [Fri, 27 Jul 2018 12:09:39 +0000 (14:09 +0200)]
Bump yangtools to 2.0.9
This patch bumps yangtools to latest release.
Change-Id: I9b170a51f632a9ef059cdfd3a434c909d46d1cb2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Richard Kosegi [Fri, 27 Jul 2018 16:02:27 +0000 (18:02 +0200)]
NETCONF-551 : Invalid CSS URI in apidocs explorer
Change-Id: Iaabea829d3fa03be019075045ee86bdd233ed066
Signed-off-by: Richard Kosegi <richard.kosegi@gmail.com>
Jakub Morvay [Fri, 27 Jul 2018 14:27:16 +0000 (14:27 +0000)]
Merge "Simplify code using Java 8 features"
Stephen Kitt [Thu, 26 Jul 2018 08:35:02 +0000 (10:35 +0200)]
Simplify code using Java 8 features
* method references
* lambda expressions
* Map::computeIfAbsent
Change-Id: Icbfa5c0a76b5b6f2b4339dbbd49b8a44e7b14fb2
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 18 Jul 2018 16:06:41 +0000 (18:06 +0200)]
Bump to odlparent 3.1.3
Change-Id: I8e2d3a5dd33195daaf2884e2093a5720fd31a7f1
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Jakub Morvay [Wed, 25 Jul 2018 10:35:45 +0000 (10:35 +0000)]
Merge "Remove unused exceptions"
Jakub Morvay [Wed, 25 Jul 2018 10:35:34 +0000 (10:35 +0000)]
Merge "Remove netconf-it"
Tom Pantelis [Tue, 24 Jul 2018 17:01:12 +0000 (17:01 +0000)]
Merge "Use moved BindingReflections"
Robert Varga [Tue, 24 Jul 2018 16:43:12 +0000 (18:43 +0200)]
Remove netconf-it
This does not build and we are not using it. Remove it.
Change-Id: I2827d1b430036d2c41f44827cba0b66b0ad3ba7b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Tue, 24 Jul 2018 13:10:43 +0000 (15:10 +0200)]
Remove unused exceptions
This drops exception declarations which are never used. If nothing
else, it allows simplifying declarations in upstream projects too.
Change-Id: I692a50ebb43e76c15a3a57ad88138be53184ce7b
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Robert Varga [Tue, 24 Jul 2018 11:10:07 +0000 (13:10 +0200)]
Use moved BindingReflections
BindingReflections are being evacuated from yang-binding, use them
from their new location.
Change-Id: Icb0a53635dee002f14ed9ddfe779fde198db8fc8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 19 Jul 2018 08:33:02 +0000 (10:33 +0200)]
Use minimal ietf-topology
We do not need the examples, just the baseline topology.
Change-Id: I7f19c8fc5a6b20d2b8cc7c659edf4dea305756da
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 18 Jul 2018 17:10:19 +0000 (19:10 +0200)]
Use union's stringValue()
With the union codegen improvement we can use stringValue() to
directly bind to generated code.
JIRA: MDSAL-364
Change-Id: Ic210e2a86831ddc5b78601928cc02ac8e32cbbe5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 18 Jul 2018 11:11:39 +0000 (13:11 +0200)]
Remove use of powermock
Rather than mocking a static method setup the class properly.
Change-Id: Idfd4c0c655c708f5c0e8c83287051b77a4544774
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 16 Jul 2018 20:56:46 +0000 (22:56 +0200)]
odl-restconf-base should import odl-mdsal-model feature
Rather than re-packaging restconf here, use upstream feature.
Change-Id: I9c0b8789ef4b166f0b056193a5156871d888156f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 16 Jul 2018 20:08:59 +0000 (22:08 +0200)]
Depend on yanglib feature
yanglib is package upstream, use that packaging.
Change-Id: I260e9e213b964da7c839bc7ce904073cb5066af2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 16 Jul 2018 20:42:32 +0000 (22:42 +0200)]
odl-netconf-connector needs only clemm-ietf-topology
We do not need all mdsal models, only the topology model, express
that in a minimal dependency.
Change-Id: I30125a6b3f9e5be48948ddcd15fddf382ff7c145
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 16 Jul 2018 20:46:50 +0000 (22:46 +0200)]
odl-restconf-common requires ietf-yang-library only
Rather than depending on all models, pull it the bare minium
required so we can speed up startup.
Change-Id: I490343232ffd48c8112719a6008f44ce6ca162f7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 16 Jul 2018 18:46:54 +0000 (20:46 +0200)]
Do not package jars multiple times
odl-restconf-nb-rfc8040 has a dependency on netconf-api, use
odl-netconf-api to resolve that (and other) dependencies.
Change-Id: If9fe9600f13838af229c7f5f7c2587e0d863fa22
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Tom Pantelis [Mon, 25 Jun 2018 03:37:10 +0000 (23:37 -0400)]
Use ConcurrentDataBrokerTestCustomizer in UTs
... to do the DataBroker wiring.
Change-Id: I32060a8d17343a6b3818cab3ec9caf03e7f0bb09
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Robert Varga [Wed, 11 Jul 2018 13:44:37 +0000 (15:44 +0200)]
Use DOMExtensibleService.getExtensions()
getExtensions() provides a better return value, so we can arrive
at individual extensions in a type-safe manner.
Change-Id: If52c0d9c5a05a70953fd17e27c3f2af155fcb3ee
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Jakub Morvay [Thu, 12 Jul 2018 08:24:47 +0000 (08:24 +0000)]
Merge "Remove netconf-node-inventory"
Jakub Morvay [Thu, 12 Jul 2018 08:14:31 +0000 (08:14 +0000)]
Merge "Add explicit getExtensions()"
Jakub Morvay [Thu, 12 Jul 2018 08:12:59 +0000 (08:12 +0000)]
Merge changes from topic 'no-chararray'
* changes:
Rely in ietf-inet-util to convert IpAddress to string
Do not rely on union char[] values
Robert Varga [Wed, 11 Jul 2018 22:23:11 +0000 (00:23 +0200)]
Add explicit getExtensions()
getExtensions() will become a mandatory method, make sure we are
ready for that.
Change-Id: Idca41be7d2a14c836345ea5d4b77857f6bbeca76
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 11 Jul 2018 15:43:29 +0000 (17:43 +0200)]
Remove netconf-node-inventory
This model is not used anywhere, remove it and simplify RemoteDeviceId
so that it is purely topology-based.
Change-Id: Ia4d6738ceab8c1ed9864dd0f6277ea462377e584
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 11 Jul 2018 18:48:42 +0000 (20:48 +0200)]
Rely in ietf-inet-util to convert IpAddress to string
Union-based getValue() is char[]-based for JMX, do not use it.
Change-Id: I67f913e01ee06e26714eaf6554ec2623391cf1b8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 11 Jul 2018 18:47:21 +0000 (20:47 +0200)]
Do not rely on union char[] values
This removes the dependency on synthetic getValue() and the union
constructor for JMX.
Change-Id: I46eaa2922e8cc83505a3198a9b29561f8ab1b32a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Jakub Morvay [Wed, 11 Jul 2018 17:30:36 +0000 (17:30 +0000)]
Merge "Remove redundant code constructs"
Jakub Morvay [Wed, 11 Jul 2018 10:36:00 +0000 (12:36 +0200)]
Remove redundant code constructs
- Remove redundant type arguments
- Remove redundant type casts
Change-Id: I943060df1f465ff019b62abd5e72bc9ff7bc8ef9
Signed-off-by: Jakub Morvay <jmorvay@frinx.io>
Robert Varga [Tue, 10 Jul 2018 18:03:32 +0000 (20:03 +0200)]
Migrate sal.core.api.mount.MountProvisionListener users
DOMMountPointListener is the replacement interface, use it.
Change-Id: I51222f1f2bc133d90dd59a029fe538826dde48c0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Balaji Varadaraju [Thu, 15 Feb 2018 07:53:20 +0000 (01:53 -0600)]
NECONF-524 : Setting the netconf keepalive logic to be more proactive.
https://jira.opendaylight.org/browse/NETCONF-524
When a NETCONF device loses connection with the controller in exceptional
conditions such as the management interface going down, underlying TCP
connection would not be closed as there will be no fin packet exchange or
reset. At this point NETCONF state will be set as connected until the
underlying OS determines the connection is stale which can happen after
considerable amount of time. This fix makes the Keepalive packets more
proactive to determine such conditions.This fix also sets the listener
properly which is required for this fix as well.
Change-Id: I781469ae7865e949e9f2c55e53240341f0b10bdd
Signed-off-by: Balaji Varadaraju <bvaradar@luminanetworks.com>
Robert Varga [Mon, 9 Jul 2018 10:53:50 +0000 (12:53 +0200)]
Remove unneeded check
The size of the collection is checked before we allocate
the transaction, hence conditional commit does not make sense.
Change-Id: Iada5db72f2fcf51528c8b1791f2b5ae9d7f51c6a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 9 Jul 2018 10:52:02 +0000 (12:52 +0200)]
Migrate netconf users of submit() to commit()
This is the next round of conversions, covering most of netconf.
Change-Id: Ic3caa8ed0879ad547940ff09d034adb5d6d6f687
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 9 Jul 2018 10:47:09 +0000 (12:47 +0200)]
Fix warnings in mdsal-netconf-connector
- potentially-static methods
- deprecated use of Throwables.propagate()
- raw use of NormalizedNode
Change-Id: I06bc1f56c90d7c4fddce262ef2c63eec72492274
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 9 Jul 2018 10:42:41 +0000 (12:42 +0200)]
Add serialVersionUIDs
Exceptions are serializable and should therefore define
serialVersionUID. This patch adds backwards-compatible generated
values.
Change-Id: I742e123df5b694b2ec132a6e48a73f3a501dde66
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 4 Jul 2018 17:06:54 +0000 (19:06 +0200)]
Eliminate use of SchemaService
SchemaService has been deprecated in favor of DOMSchemaService,
migrate to it.
Change-Id: If1b6d3c9d821c6c5bea1476c08a61ed0c320b8ac
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 4 Jul 2018 15:06:27 +0000 (17:06 +0200)]
Convert users from submit() to commit()
This gets rid of CheckedFutures and allows us to use FluentFuture
features.
Change-Id: Ie95bb9ce0d0bb6195f9c6355e644a8563165a953
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 4 Jul 2018 16:42:42 +0000 (18:42 +0200)]
Migrate shell components to new APIs
Karaf has refactored its shell-related APIs, this patch updates
netconf-console to use them.
Change-Id: I8669c19c874d3e851379301712987ada626ef086
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 4 Jul 2018 15:36:06 +0000 (17:36 +0200)]
Eliminate implicit boxing
There is no need to box values, use Boolean.TRUE/FALSE as needed.
Change-Id: I2a71106d7281f5b22e5d14f893f5a67c913e49f3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 4 Jul 2018 14:32:34 +0000 (16:32 +0200)]
Remove unneeded use of CheckedFuture
These callsites can live with ListenableFuture, so use that to
reduce clutter.
Change-Id: I4bea70e8f62b06cfdc1d7a3dfa5d7552178fa4c4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 4 Jul 2018 15:28:39 +0000 (17:28 +0200)]
Fix ScaleUtil warnings
Callable is a generic type, use it accordingly.
Change-Id: I5f947fc4cce9ef4244684013f5980dde439baf64
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 4 Jul 2018 14:39:21 +0000 (16:39 +0200)]
Make methods static
These methods are private without touching object state,
make them static.
Change-Id: I01d675a02098426917e019fb66761b13cacf3d4a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 4 Jul 2018 14:40:35 +0000 (16:40 +0200)]
Migrate to UntypedAbstractActor
UntypedActor has been deprecated, migrate to the replacement
bridge UntypedAbstractActor.
Change-Id: Ie4dd16101707a70442bd66bafd4b22190f73d06e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 4 Jul 2018 14:39:59 +0000 (16:39 +0200)]
Fix raw type warnings
Using IdentifiableItem as a raw type does not make sense here,
add type qualifiers and ditch the warnings.
Change-Id: Ifcbd41b53f0c5989e6fad9fd35ce66e115996224
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 2 Jul 2018 15:16:56 +0000 (17:16 +0200)]
Adopt netconf-node-inventory
This model used to be hosted in controller, but it really should
be hosted in netconf.
Change-Id: I54a6cd90c8e182ade53cba08fdaa301a64a677d5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 2 Jul 2018 18:43:55 +0000 (20:43 +0200)]
Cache topology path
Instead of creating base InstanceIdentifier over and over, cache
it in a field.
Change-Id: I54d1bb7555a94fc20c5cf406f6f6f6dd69d7fc5d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 2 Jul 2018 18:20:40 +0000 (20:20 +0200)]
Fix netconf-node-topology
Topology types augmentation should be a presence container,
fix that.
Change-Id: Iaef6fd18f590767069a91cada2036f9b02ffa167
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 2 Jul 2018 13:23:59 +0000 (15:23 +0200)]
Bump ietf-network(-topology) revision
This bumps the revision to RFC8345 versions.
Change-Id: I75748b45af4f91294eebe553f631cd0c23897035
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
JakubToth [Sun, 1 Jul 2018 08:03:24 +0000 (08:03 +0000)]
Merge "Guard against multiple web registration attempts"
Tom Pantelis [Wed, 27 Jun 2018 16:35:57 +0000 (12:35 -0400)]
Guard against multiple web registration attempts
If both restconf-auth and noath features are installed, both
try to register the web context and PAX web fails and renders
restconf unusable.
JIRA: CONTROLLER-1844
Change-Id: Ie488c792d849616efa806e82121883fe73fb9c6e
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Stephen Kitt [Tue, 26 Jun 2018 16:10:47 +0000 (18:10 +0200)]
Bump to yangtools 2.0.7
Change-Id: Ie48b991bc023cce78a3147371a9a33a627bc8ba1
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Robert Varga [Thu, 28 Jun 2018 09:32:35 +0000 (11:32 +0200)]
Remove duplicate ietf-yang-library models
ietf-yang-library is provided by MD-SAL, along with bridge utilities
to work with that model.
Remove the two versions hosted in netconf and consume the version from
mdsal.
Change-Id: If43f159ebac4fedbb267a85fd9df6d46897a5330
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 28 Jun 2018 10:51:24 +0000 (12:51 +0200)]
Cleanup NetconfStateSchemasResolverImpl
We are using a constant QName in lookups, use a constant for that.
Also mark a FIXME for netconf-monitoring/yang-library preference.
Change-Id: Ia30ece91868b55e811e734b817ffaa71d86da0a0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Wed, 30 May 2018 13:44:44 +0000 (15:44 +0200)]
Bump odlparent to 3.1.2
Change-Id: Id85c9aa0038633cbec58f747841121fd31067eab
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Tom Pantelis [Sun, 24 Jun 2018 21:58:33 +0000 (17:58 -0400)]
Reference BindingNormalizedNodeSerializer in MountPointEndToEndTest
... instead of referencing BindingToNormalizedNodeCodec
Change-Id: Idc4db9f7c35271ec5c458248727b0f3387fa373f
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Marek Gradzki [Fri, 15 Jun 2018 11:54:41 +0000 (13:54 +0200)]
Advertise :validate:1.0 capability if DOMDataTransactionValidator is supported
Change-Id: I193ba007f32114aa1d43375bfdc6772be173db7c
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Tom Pantelis [Fri, 15 Jun 2018 01:52:32 +0000 (01:52 +0000)]
Merge "Remove CSS yang reference from UT"
Tom Pantelis [Fri, 15 Jun 2018 00:59:29 +0000 (20:59 -0400)]
Remove CSS yang reference from UT
CSS is being removed...
Change-Id: I0e7ad682ed0f7ad1dc815af4b35afe7baa57c5bd
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Marek Gradzki [Wed, 13 Jun 2018 19:12:16 +0000 (21:12 +0200)]
Make RuntimeRpc revision aware
Do not use SchemaContext.findModule(URI),
which looks for a module instance with specified namespace
and no revision.
Such lookup fails for modules with revision defined.
Instead (as already done in AbstractEdit)
use SchemaContext.findModules and take the newest module
if more than one module with the same namespace is found.
Change-Id: I7b6bdcb9156669645e19a6395e1b74995328154d
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
(cherry picked from commit
69c92b2bee54681ebb5c0bfaf89d269877e0b747)
Tom Pantelis [Mon, 30 Apr 2018 14:39:23 +0000 (10:39 -0400)]
Remove AsyncWriteTransaction.submit() impls
The submit() method is now defaulted in the interface
so implementations don't need to implement it.
Change-Id: Ibdb988739df9ea309c2debd9c31dc1b9bf18e83d
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Fri, 8 Jun 2018 18:08:30 +0000 (14:08 -0400)]
Remove unused references to BindingAwareBroker
Change-Id: I2a6d5e06f9b357737b37779b7e294731f79ba833
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Fri, 8 Jun 2018 02:45:55 +0000 (22:45 -0400)]
Fix default schema cache failures
We've these seen intermittent failures on jenkins:
Caused by: java.lang.IllegalArgumentException: Unable to create cache directory at cache/schema
at com.google.common.base.Preconditions.checkArgument(Preconditions.java:210)
at org.opendaylight.yangtools.yang.model.repo.util.FilesystemSchemaSourceCache.<init>(FilesystemSchemaSourceCache.java:74)
at org.opendaylight.netconf.topology.AbstractNetconfTopology.<clinit>(AbstractNetconfTopology.java:149)
In FilesystemSchemaSourceCache"
if (!storageDirectory.exists()) {
checkArgument(storageDirectory.mkdirs(), "Unable to create cache directory at %s",
storageDirectory);
}
mkdirs returns false if the dir/file already exists - this seems the likely reason
in this case even though it checks exists() just prior. This scenario could happen
if there's a race where some other component interleaves and creates the dir in
between the exists and mkdirs calls.
To protect against this sceniario, AbstractNetconfTopology and NetconfTopologyUtils
were changed to retry if FilesystemSchemaSourceCache throws an IAE. Also they no
longer fail class initialization on failure.
Change-Id: I9f7ec134e7fd817aa753f0db175bf5620cc52ff4
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Robert Varga [Mon, 28 May 2018 10:16:53 +0000 (12:16 +0200)]
Bump yangtools to 2.0.5
This includes latest fixes.
Change-Id: Ib91a42e74323a99ce378744114071c7268fec3a2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Jakub Morvay [Tue, 5 Jun 2018 15:34:09 +0000 (15:34 +0000)]
Merge "Convert ProxyDOMDataBroker tx creation to async"
Tom Pantelis [Mon, 4 Jun 2018 15:13:32 +0000 (11:13 -0400)]
Remove sal-dom-config dependency
It's not needed and is going away.
Change-Id: I2fb0ed7ddca920756a07ba61f900fdff47715e67
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 2 Jun 2018 11:20:33 +0000 (07:20 -0400)]
Remove config features from protocol-framework feature
CSS remnants that aren't needed.
Change-Id: I1e510da5c07c0dddfb602a5abbbc46349288f5eb
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Mon, 21 May 2018 14:28:52 +0000 (10:28 -0400)]
Convert ProxyDOMDataBroker tx creation to async
ProxyReadWriteTransaction was modified to take the ActorRef
Future from the tx creation message and add a callback when
complete. Transaction operations prior to completion are
queued and replayed to a ProxyTransactionFacade instance
once the Future is complete. For successful completion, an
ActorProxyTransactionFacade is created that interfaces
with the master ActorRef. On failed Future, a
FailedProxyTransactionFacade is created that returns a
failed Future for read, exists and commit operations.
The ProxyReadAdapter and ProxyWriteAdapter were removed
in lieu of ProxyTransactionFacade which combines the
read/write operations for simplicity.
Some simple actor response messages,
eg NewWriteTransactionReply, were removed in lieu of
returning the payload or exception via
akka.actor.Status.Success or akka.actor.Status.Failure.
This simplifies caller response handling as akka
automatically unwraps Success and Failure in callbacks
and synchronous await.
UTs were added, modified and removed corresponding to
the changes.
Change-Id: I0bd2a931d91ded97ebba7ccc207d51bd6474a41c
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Mon, 4 Jun 2018 16:58:06 +0000 (16:58 +0000)]
Merge "Fixup Augmentable and Identifiable methods changing"
Jakub Morvay [Mon, 4 Jun 2018 15:43:24 +0000 (15:43 +0000)]
Merge "Use requested media type in RestconfDocumentedExceptionMapper"
Robert Varga [Tue, 24 Apr 2018 13:30:01 +0000 (15:30 +0200)]
Fixup Augmentable and Identifiable methods changing
This is a fixup of the change in binding codegen, adjusting:
- getKey() -> key()
- setKey() -> withKey()
- getAugmentation() -> augmentation()
Change-Id: I7533bd17bcd4a742862576d38f76991162845f4b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
miroslav.kovac [Tue, 29 May 2018 18:09:24 +0000 (20:09 +0200)]
NETCONF-542: PUT request return 500 if operational data are used
* Cherry-pick
Change-Id: I5e45b0276e39c3a6af647b6632b67b3f96751464
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>