BUG-8275: Close ReadOnly transaction

PCEPStatefulPeerProposal needs to
close ReadOnlyTransaction created
after use it

Change-Id: I1515f09028c9e6bd8403d6ea2851196511d4da24
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit b85554f565b2e03d2c8237b160ac055907b86b23)

BUG-8202: Fix Conflict Modification on odl-programming

Instruction DS configuration only should be written
on Leader when instatiateService.

Change-Id: I9acf17c8a19d8b22d83e62b315fdadf9494783f2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8198: Fix InferenceException

Add presence statement under graceful-restart-capability.

Change-Id: Idc98f74661d4dea4f440d178da868ec83f896370
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit 187428a5c597c78c625ca2b1baa1a920108a979f)

BUG-8252 Fix IP prefix length util

The byte representing IP prefix length is a unsigned byte.
The length should be converted to an unsigned int explicitly.

Change-Id: I0c1df171822858825da69f39c91de9ed332865f8
Signed-off-by: Kevin Wang <kevixw@gmail.com>

BUG-8213: Add missing mandatory attribute on tests

Add missing origin attribute on tests

Change-Id: I125437e187286a7a949e26191e66f19ded123274
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bump versions by x.(y+1).z for next dev cycle

Change-Id: I4d89069222217139eceba9eac78cefc1234c3304
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Improve synchronization under BMP

Improve synchronization under BMP whenever
transaction chain is created and submitted.

Change-Id: If7a61c394218bd7c78c6021ee19ba42f4276560a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Restrict dependencies scope to test

Restrict various dependencies scope to test

Change-Id: I23cef78c244454d2059311c0d56af753f695c02f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-4491: Race condition under PCEP Topology Provider

Race condition under PCEP Topology Provider when
instace is reconfigured, since closeInstance under CSS
is nonbloking, it can race the delete with the writing
of the new instance when restarting.

Fix by calling first closeServiceInstance(blocking)
on topology instance and once it gets done call close.

Change-Id: If79bf34f77223bc56424a57e4e600fdb17ddd154
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8021: Race between Peer structure creation and route init.

There is a possibility of race between Peer structure
creation and route initialization/advertizement.

Fix by introducing a flag, which indicates whether
peer's structure has been created and is able to be updated.

Change-Id: Ia9515d2017cb5213ce286e463712092c87764e10
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7976: Race between peer removal and routes update

There is a race condition when we are advertizing routes,
and a session peer goes down which will end in
removing the peer from DS.
Since advertizement and removal are done by 2 different tx,
we need to do it blocking mode, and not route should be
advertized until peer is removed and vice versa, peer
should not be removed until routes are advertized.
Otherwise toure update will try to update a peer/path which
is not longer present.
Fix by rework PeerExportGroup & ExportPolicyPeerTracker,
now instead of generate PeerExportGroup each time a peer
is reg/unreg,  we make PeerExportGroup work as a
blocking registry to solve previous issue.

Change-Id: I46a27871bfa2aa2a632e3bfb76061105c62bb6d2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix sonar complains

- Remove unused imports
- Throw exception
- Name convention
- Comparison
- private constructor on util
- replace explicit type per <>
- migrate to java stream api

Change-Id: I224eb8dfe776130b0f45468be4791239daf878af
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix BmpDispatcherImplTest intermitent failure

-Use CheckUtil under test.
-Use mockito timeout.

Change-Id: I2e6c77de1324dc079375271bd7c2e2d028a9fc4f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6975: Integrate Topology Provider with CS Service

Integrate Topology Provider with CS Service

Change-Id: I0e9c42aa3538e0936b74120535fee369db1ad9d5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6973: Implement test for InstructionDeployer

Cover InstructionDeployer with test

Change-Id: I8ed071a8a11dd0d9183fe6c5b45ae7616f6ce5f9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Rework CheckUtil Test

Change-Id: Icada2980901bea076b061b933d8ba42876d0e5f5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Correct XSD pattern

YANG patterns are XSD regexes, so they have implicit ^/$
anchors. Fix this up.

Change-Id: I911ca3d3bd286c0f77bccfb4f3e9a3ef8fc8dbdb
Signed-off-by: Robert Varga <rovarga@cisco.com>

Code clean Up

Classes missing final

Change-Id: Ie260d9f4a48290b492171f79f94f7f8ee53ccbde
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Code Clean Up

Fix instance fields not accessed with this

Change-Id: Iec1520fa728ea21098dd5a79dbfa25837b117e1c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Code Clean Up

Anonymous type replaced by lambda

Change-Id: Idd81b1e43866e5d960ec2dfa777b66bae3e53da9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6973: Wire topology-provider with BP

-Wire topology-provider with BP
-Preserve backwards compatibility

Change-Id: Ibc459117b1656a0efe5e34365b9fc131479bdaea
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7960: Fix AssertionError under AppPeerBenchmarkTest

Use CheckUtil.readData for check DS update.

Change-Id: Iae77923c4b8fe0e3a87ffeff0b5c4d00815bf88d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Code clean up

Remove unnecesaries imports

Change-Id: I0ecf1894c1be211f9ffd7ed0d98a3c80ae9a6025
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7964: IllegalStateException under testReconectClient test

Fix by wait until channel is closed before retry to connect.

Change-Id: If1c7889b7988ce5cab3e11f73b6134ad2af182c7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit 7b48d57ba01775ff48b1686ea8093b009df2ee3c)

Fix NPE under TopologyProviderTest test

Fix by check reportedLsps is not null.

Change-Id: I18878db061ab5816ac5f13e5cdac21107df86aa1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove deprecated class AbstractDataBrokerTest

Remove deprecated class AbstractDataBrokerTest under
programming and data-change-counter tests
Perform some code clean up

Change-Id: I2ff02760338d8774c3908d107ff76de433acba2a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7946: Fix  SomeModifiersUnresolvedException

SomeModifiersUnresolvedException under ConfigLoaderImplTest
Fix by remove duplicated schema.

Change-Id: I1200e21e76e6da0d35a10932eede27df4a410aa0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7894: Fix ConcurrentModificationException under test

-Fix ConcurrentModificationException under
testSessionTriggeredFullDBReSync test
-Perform some code clean up

Change-Id: I8e4652f273ea994efa5b9477f8af59239e92dd08
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove pcep-service.yang.disabled

Remove pcep-service.yang.disabled

Change-Id: Ib862326a5cd976c6cc9fb714892c8064915a3cfb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove deprecated class AbstractDataBrokerTest under BGP

Remove deprecated class AbstractDataBrokerTest on tests.
Perform some code clean up under tests.

Change-Id: I64b120bdbbf59db4df0e4d4e2d769eac22738c33
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7937: Fix BGPTerminationReason

When closing the session because of some error
2 Notify messages are sent. One containing the
reason and other with CEASE.
Fix by dont send CEASE Termination Notification
if already other termination notification has
been sent.

Change-Id: Ibfabd7cfb038bef7a452a7458cd5cc1e6fa4b9a7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7003: Remove sleeping from Tests

Remove sleeping from test whenever possible.
Clean up some tests.

Change-Id: I734ca5721090669c75f09d107ee4c5ea1e3d14ee
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7505: Conflict Modification

When closing Peer and Rib, can cause
race condition between the removal
of the peer and the rib when updating DS.
Fix by close peers on blocking mode, and once
they are closed proceed with rib.
Same its applied in case that peer/rib is updated.
First we close it and then once DS is updated
we proceed with creating the new instance.

Change-Id: Ibe70e0324ae12bcbb88b2e7f039671141447ddb1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove deprecated class AbstractDataBrokerTest under PCEP

-Remove deprecated class AbstractDataBrokerTest on tests.
-Perform some code clean up under tests.

Change-Id: Iee8bdb1e190c80aa0ae883e52963afb6b29cc4f0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Programming Clean up

Migrate deprecated classes
Code clean up

Change-Id: I06551491a30499d81d4c0dc7f0e1dbe68dc04eab
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6975:  Integrate Programming with Cluster Singleton Service

Integrate Programming with Cluster Singleton Service

Change-Id: I95e3c8c1dc1e596c060256d3f59fec9cfe882456
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6973: Implement Programming config via DS

-Expose programming's configuration in config DS
-Allow multiple programming configuration

Change-Id: Ib6de3355dae6533367890ef87c504edbdca04654
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6973: Wire Programming with BP

-Wire Programming with BP
-Preserve backwards compatibility

Change-Id: I750fdb86a6c22d3b1a90e7466466ab7c5426d729
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bug 6859 - Binding generator v1 refactoring

Based on transfer of Binding generator v1 from
Yangtools project to MDSAL in past, we need to finalize
this process by refactoring package naming:
org.opendaylight.yangtools -> org.mdsal.binding
org.opendaylight.yangtools.sal -> org.mdsal.binding

Refactoring changes in MDSAL, see:
https://git.opendaylight.org/gerrit/#/c/52107

By using of Binding generator v1, this change needs to be addressed in
Bgpcep project.

- refactoring itself

Change-Id: Iccb2af9806db18a3e5bf98092ca70ae9b350dabf
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Improve Singleton Service Logs

Improve Singleton Service Logs

Change-Id: Ie09d2e00e7159539dcecc520ef0e9cd39ca4e02f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bug-7614: LocRibWriter does not recover well from transaction chain failure

If transaction chain associated with LocRibWriter fails, create a
new transaction chain and re-initialize it with the new chain.

Change-Id: Ibbb60c41594ad6b3602cabac18f5e4bccaa093bb
Signed-off-by: Ajay <ajayl.bro@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7768 Fix missing registration

In previous BUG-7768 fix, pcep topology registration was
missing. This patch adds it back. It also adds several debug
logging and unit test.

Change-Id: I4c82a7fcd9cb1ed7371817ffabc52fdf927ab51e
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Add CheckUtil coverage

Add CheckUtil coverage

Change-Id: I90524766fa989c97ab2e10d7fbe08904e269770c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7222: Make BGP DS clean up asynchronous

Close of the service must be done async, otherwise
will bock the thread.
Fix by make BGP DS clean up asynchronous

Change-Id: Icb19ef7b7f118fbc6b07407d1df2cb5f6cffc0fb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Clean up check tests and  util tests

Remove duplicated code on check utils for tests.
Clean up PCC mock tests

Change-Id: I1347f6561cb4ede6c8f4147680d92c3a84f92520
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-4808: remove reference to IdentityHashMap

Class documentation is misleading, as the internal cache is implemented
by a weak key/weak value equivalent.

Change-Id: Ie0d08ee990b725c5ed1a52cb074b6f72eff2a26f
Signed-off-by: Robert Varga <rovarga@cisco.com>

Code clean up

Remove redundant cast/type argument

Change-Id: I446cb24bdbcb5156136899798eb6d3d607291e62
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Remove unused test class

Remove unused test class MockPCE

Change-Id: If0afe1e8f78beca02dd397c9e18f3da408a939bf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove no longer required pcepdump

Remove no longer required pcepdump.py

Change-Id: I662f6971c3b0e210e4c692402a23617d6e473939
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7768 Synchronize ServerSessionManager for PCEP

Add the check so that session manager can only be closed once
and becomes unusable after closing.

A java.util.ConcurrentModificationException is possible to happen
due to the close() method of ServerSessionManager is not synchronized.
The situation mostly likely will happen during a controller reboot.
It may also happen when a PCEP config is updated. The ServerSessionManager
is being restarted while all the PCEP negotiation is still happening.

Change-Id: I0e0d387add046a4fe9ec5ac74a85f8350e238d60
Signed-off-by: Kevin Wang <kevixw@gmail.com>
(cherry picked from commit 7a866eee4dec5dc368ef11c90473b3c2a256f281)

BUG-7550: Implement CSS under Operational State

Implement Cluster singleton service under
Operational State.

Change-Id: Iaea4d97948b8c260fb38172107a155a298fd889e
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Code clean up

replace long literal 'l' by 'L'

Change-Id: I9d8bffb3559887336299e84d77db82fdf7e5f379
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7776 Fix Test

Change-Id: I86bafac12ceada82f18b27bb7adeeaa4ca6783c3
Signed-off-by: Kevin Wang <kevixw@gmail.com>

BUG-7706: Fix ServiceUnavailableException

Reconfigure BGP Server durin a session, will produce
ServiceUnavailableException at the moment session is
closed and tries to remove peer from StrictRegistry.
Fix by put aside registry from Peer Acceptor, therefore
when BP container is restarted reference wont be lost.

Change-Id: I4eb018a24e5c5ea2a4b479cba61d94cb3658f583
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <rovarga@cisco.com>

Code clean up

Migrate test from junit 3 to junit 4

Change-Id: I88e78739de6acf531154e2238e569ad5abd2f0da
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7512: BMP features migration to karaf 4

BMP features migration to karaf 4

Change-Id: Iee8a60c7831cb8a5af791b297b2052648e21b26e
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-7510: BGP features migration to karaf 4

BGP features migration to karaf 4

Change-Id: I78156ba3da5a5da396d8b98bc77f79e16ae8d2c7
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7739: Fix ParserToSalTest/Topology Tests

Fix ParserToSalTest/Topology failing test

Change-Id: I01cec1b9ab83c14cec8674465ed690e77d820adc
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bug-7708: Invalid Route Distinguisher error while processing withdraw update containing VPN route

 - RFC 3107 says that label value in withdraw message should be 0x800000
   ref. https://tools.ietf.org/html/rfc3107#section-3
 - Changed code to correctly handle this value in withdraw message received from peer.
   Also ODL will now use this value when sending withdraw message to its peer
 - Updated unit-tests accordingly

Change-Id: Ie9d90779c32e9141f953a18b07a86d0624eaee5c
Signed-off-by: Ajay <ajayl.bro@gmail.com>
(cherry picked from commit 16e0aa31e782252f25860556bd3eb4fd59431789)

Pull in osgi.core explicitly

Inherited scope runtime is not sufficient, as something
in the dependecies is causing us to compile against 4.3,
which does not have generics.

Change-Id: I7a4fda07f10859698892414b43ba64cbb6e5f3fb
Signed-off-by: Robert Varga <rovarga@cisco.com>

Code clean up

replace asList by singletonList

Change-Id: Ie3235ce8e7c7df527765e69183a52a1d56f30d70
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Switch to using odl-netty-4

odl-netty is deprecated by odlparent, the new name is odl-netty-4
and shares odlparent's version.

Change-Id: Ib07fea42952d9c9a157fb8d3c9fa7f6a2ce7128c
Signed-off-by: Robert Varga <rovarga@cisco.com>

Code clean up

Remove unnecessary semicolon

Change-Id: I1fae14a786876bdb5da830a31d64987498bd18ca
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7511: PCEP features migration to karaf 4

PCEP features migration to karaf 4

Change-Id: I490f7504c078cf21642d9fd527d2bd4ac9dd83bd
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-7514: Extras features migration to karaf 4

Extras features migration to karaf 4

Change-Id: Ie5f459a45ab74baa17b3544cba101beaadaabf12
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove duplicate code for test utilities

Remove duplicate code for test Utilities

Change-Id: I8d7d2652cd5159af106d439a6b62767a73296e87
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7732: Improve BGPDeployer synchronization

Improve BGPDeployer synchronization

Change-Id: I0a4c321ac36efefea473d0e2557588c6d687d5d3
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7723 Change BGP connection failure log level

Change the BGP connection failure log level from DEBUG to WARN.

Change-Id: I68766d8849a7ce246959534b5fc80aa2eaf8fc3c
Signed-off-by: Kevin Wang <kevixw@gmail.com>

BUG-7251: Remove pcepy

Remove pcepy folder

Change-Id: I571c9f8f646c0b8207a203a06a49a47649a59c83
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Fix missing relativePath

odlparent-lite is outside of bgpcep project, hence
it should have an empty relativePath

Change-Id: If40a1eed870c69bb71290cd19139681fafa18e4e
Signed-off-by: Robert Varga <rovarga@cisco.com>

Add relativePath to RSVP4-features

Add feature-repo-parent as relativePath

Change-Id: I91167632297b629a023b49a019a4fad99dda4ac2
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7364: BGP Peer Acceptor Rework

- Decouple BGP Peer acceptor from BGPAcceptorConfig
- Add missing destroy method close to BP

Change-Id: I3aeaa9923f02466255cf98bc50dca9b06b7959f2
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7513: RSVP features migration to karaf 4

RSVP features migration to karaf 4

Change-Id: Ic37f898e73a56ac76526ebd92ef0068a9fc95908
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Remove deprecated Interfaces/Methods

Remove deprecated Interfaces/Methods

Change-Id: Ia543c2e6afd09c753c0a662d4811cb7a4ce1fcc5
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

\BUG-7386 Remove blocking gracefulshutdown

Remove blocking gracefulshutdown for EventLoopGroup

Change-Id: I03fd04cd77d613ce4b8c83f1f48deb3142227bfb
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7673: Improve synchonization under BGP/PCEP Session

- Improve synchonization under BGP/PCEP Session
- Code clean up

Change-Id: I93851323232fa9df0c23e1e23751320cdf578031
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7351: Update IRO reference

IRO is compliant of rfc7896 therefore we
update the reference.

Change-Id: Ia31d2e5c59ba68b966a53f92482dad56380c809b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Replace FindBugs :jsr305 by full :annotation (Bug 7663)

Change-Id: Ic036e549569cc5eb02958bc22702266eaaed7ff5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

BUG-7673: Fix PCC Mock test failures

Fix PCC Pcep test failures by passing missing executor
Fix annotations
Fix warns for keepAlive size

Change-Id: I0013af17e01d2d8afa136a16d6315719e0aac3fd
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-5032: Implement BGP Operational State test

BGP Operational State test implementation

Change-Id: I88805d83c55b20661619da091c69025af1413f81
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-5032: BGP Openconfig State Impl test

Test implementation for check of BGP Openconfig State Imp

Change-Id: I86d58892a30dc995898b637d903bec2b606d60c1
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7558: BGP SingleFeatureTest Failure

BGP SingleFeatureTest Failure fix by
create an specific feature for all
config-file and added as a dependency
for Config-loader feature.

Change-Id: Ifb79c898ea8cba4e68fdd257c2d8c3498ebb559b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-5032: BGP Operational State

Implement BGP Operational State per
Global and Neighbor.
Operational State per PeerGroup is also
implemented and will need to be plug in
once Peer Group is supported.

Change-Id: Ic1a75348e370bdd06777267c153b924acc3b4c15
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Rework Openconfig State Features dependencies

Openconfig State Features should depend on rib-impl
feature and not the other way around

Change-Id: Id40c99a637b670d6d4591c090321f77ecab39a8f
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Prepare upgrade to Netty 4.1

We need to widen the range of allowed versions for odl-netty.

Change-Id: Ib2340ef08a41dcb6508afccbb420b52f94be6051
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG-5032: BGP Openconfig State Implementation

Introduce service on charge of store
BGP Operational State as an Openconfig
Operational State format.
Introduce Utilities to convert BGP Operational
State to Openconfig State.

Intruce a cache TableType-AfiSafi under
BGPTableTypeRegistry. Table type will be stored
as they are required.

Change-Id: I3cb546f7f332e7f9eb7bba0a45d366fca0c4d0e5
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-5032: Implement BGP State Collector

BGP State Collector act as a provider of
all BGP Rib States.

Change-Id: I4d4919d10d168561c087b742fcd76dfbe9b6912b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-5032: Introduce BGP Operational State

Introduce interfaces for expose BGP Operational State for:
-RIB
-PeerGroup
-Neighbor
-BGPState Collector

Change-Id: Ib6b053f4e7e734eb3f4525f7de4643c9b89c9a31
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Replace UnsignedInt32Counter by LongAdder

Replace UnsignedInt32Counter, which is not
efficient and only provides of logs which are of
not use for a more suitable counter(LongAdder).

Change-Id: Iaad4879c9c3a783ac45f21d47f3379b22f22e3e4
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Fix invalid YANG 1.0 leafrefs

Two YANG 1.0 models contain leafrefs with require-instance substatements
which is not valid for YANG 1.0 version. Comment out these substatements
for now. In the future, when YANG 1.1 support for such substatements
will be available, they can be uncommented.

Change-Id: I59cc7bd8f3fdcd14d96ee672fbceaf1d48f5836d
Signed-off-by: Igor Foltin <ifoltin@cisco.com>

BUG-7251: Remove pcepy

remove no longer required pcepy code

Change-Id: Ib99682fc221b33b17ef972f1309dab43506cfa08
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

BUG-7159: eliminate use of CrossSourceStatementReactor

We have YangParserTestUtils which are more convenient, use them
instead.

Change-Id: Ia7810aec6f7a6c66a71a1523993b45d274c57606
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix Sonar complains

Fix naming convention, etc..

Change-Id: I2048e319bcef7bf41c47631413e0e9c9468c499d
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7215: Fix App Peer ModifiedNodeDoesNotExistException

If Rib is reconfigured with different Family than the
previous supported one, application peer will be
reconfigured. In the case there are some routes or,
family table configured on Config DS, when restarting
App peer with new configuration will end on
ModifiedNodeDoesNotExistException.

Fix by:
   -Make Application peer more defensiveness by ingore changes
 on config DS for non supported Families.
   - Register Change Listener once AdjRibIn has been
 succesfully initialized.

Change-Id: I25b08b057fad02df365070c0a6d5177b9e0392a0
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7028: Migrate BGP Benchmark App to BP wiring

Migrate BGP Benchmark App to BP wiring

Change-Id: I5632a5ec3afde41862004e172e451fc358c53eab
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7222: Fix clustering BGPPeer NPE

Fix NPE: Any call to rib should be done
during singleton service instantiation or after.
Any call before can cause a NPE since RIB might be
on undefined status yet.

Change-Id: Ia1ebbc334f07362f325ac599f39f9d601e717321
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Pcepy: Address pep8 violations

Newer libraries used in verification are more sensitive to
"E305 expected 2 blank lines after class or function definition".

Change-Id: I3f94115bb70b069f3eb417429bbc457c73048a7a
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

BUG-7003: Remove Thread.sleep() calls in tests

Partial improvement under Additional Paths tests.
The time spent has been reduced.

Change-Id: I8ebfd19af9147a10f1d5856b5478501f2ab890ab
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Misspelled method name correction

Change-Id: Ic6d803b6853324efa9e7868d142cf184fda47f58
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BUG-7006: Unit-tests sometimes hangs during execution

Fix sporadically hangs during unit-tests execution

Change-Id: Ia339af6d9181a7be8e4b3e6335bba250aaecd822
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>