Fix license header violations in snmp4sdn

Change-Id: I37ca4f9366c5301ba367beba5da3822c1143ad9b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Incrementing versions by 0.1.0 for post-Lithium master branch

Change-Id: Ic9822bcd9a228d0461c8e4b9c1c42507875f376c
Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Temp bug fix: remove feature odl-adsal-northbound from feature odl-snmp4sdn-snmp4sdn to skip installing failure

Change-Id: Ib235a0fbca1e965cf6d41e6dadda65f5a2602dfe
Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Upgrade yangtool and Karaf-related dependencies version.

Change-Id: I1ed52807a6f217308ab54813b4e39c76ecdd07c4
Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

New SNMP4SDN code.

Main differences with previous code:
(1) Flaw or bug fixes.
(2) New services: ACL configuration, FDB configuration, some special configuration.
(3) VLAN service is exposed via MD-SAL now.
(4) For each service in (2) and (3), a testing bundle for it (in mdsal/caller/)
(5) Karaf shell command change (for topology discovery)

Change-Id: I602e98ae26aafb34aa8898a704c76ad6829dd117
Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Revert "Clear all code (prepare to push new code)"

This reverts commit 1e79b35b9a1dfd5199b5b3eaecce4fd02a11b764.

Change-Id: Ie09a6f6302f809b56ed633296e2b36ff60b0908d
Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Clear all code (prepare to push new code)

Change-Id: I10ee5ae2248b743625b7b961efc2d6c6748fc709
Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Migrate to odlparent-provided features test

Artifact provided by yangtools is going away, migrate to the
replacement.

Change-Id: Iefa528a41385e4b16a52c29682660f615471948e
Signed-off-by: Robert Varga <rovarga@cisco.com>

Add pointer to odlparent

This patch adds odlparent to commons/parent, so that any common
third-party dependency definitions are picked up from there.

Change-Id: Ifaf7f3b9e83f251dec9ec2ac9aaade5353e1451c
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove <repositories> and <pluginRepositories> sections

It is recommended that developers and servers configure this locally via
settings.xml.

https://lists.opendaylight.org/pipermail/discuss/2015-January/004482.html

Change-Id: I54c29e0b2cd9f5f93a7b6c0a6ce061ed9a83f71c
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Set root pom.xml <name> for Sonar.

As mentioned on the mailing list Sonar uses the <name> field of the
pom.xml that is passed to the mvn command as the name of the project in
Sonar. In most cases this is the root pom.xml file in a project. This
patch sets the name to the project shortname.

https://lists.opendaylight.org/pipermail/discuss/2014-November/004024.html

Change-Id: I93b6db7bfc5d578231d9926cb19894151b4ce394
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix Maven warning for missing versions

Fix the 2 Maven build warnings about missing version numbers for the
maven-resources-plugin and build-helper-maven-plugin.

[WARNING] 'build.plugins.plugin.version' for
org.codehaus.mojo:build-helper-maven-plugin is missing. @ line 161,
column 24
[WARNING] 'build.plugins.plugin.version' for
org.apache.maven.plugins:maven-resources-plugin is missing. @ line 148,
column 25

Change-Id: I2a80df56ea9d3be09cc7a3ecda5cf2aa40b9762a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Revert "wqExpose ConfigService with MD-SAL (1) ConfigService configures STP and ARP Table (2) For testing purpose, a bundle which calls ConfigService is provided (i.e. mdsal/caller/configmanager) (3) bug fix (no relation with ConfigService): remove an non-existin"

This reverts commit af572b75044f8b687317923d7d813f8fa6c7bd7d.

Change-Id: Ia9299d20499360fb1259a081c63801d45d3654c1
Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

wqExpose ConfigService with MD-SAL
(1) ConfigService configures STP and ARP Table
(2) For testing purpose, a bundle which calls ConfigService is provided (i.e. mdsal/caller/configmanager)
(3) bug fix (no relation with ConfigService): remove an non-existing import from VLANService.java

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Add a method to get HostAddress in snmpj library

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Incrementing versions by 0.1.0 for post-Helium master branch

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Add Karaf commands for Flow configuration

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Bug fix: VLAN of ID 1 can't be seen in the result of getVLANTable()

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Bug fixes: (1) VLANTable.toString() has flaw, (2) InventoryService.init() has flaw and cause null pointer error message.

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Just clean code and improve logger message

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Bug 1986 fix:
(1) Using interface ICore containing all Karaf commands is not proper and brings failure, so seperate into two interfaces, IKarafCore and IKarafVLANService.
(IKarafCore is implemented in Controller.java, IKarafVLANService is implmented in VLANService.java)
(2) In blueprint.xml, the <property> can't be correctly referenced in Karaf, so solve by alternative approach -- in the doExecute(), get IKarafXXX interface to call)

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Bug fix: Karaf CLI provided by snmp4sdn can't be seen due to snmp4sdn plugin's Activator.java miss to set the required interface.

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Bring commons-io version into alignment with odlparent

Change-Id: I31496e08ee0fc9d0ab43d12bbc2fe8dd1bb5a2e2
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Bug 1909: fix maven-bundle-plugin version

Note: maven-bundle-plugin version 2.3.6 was *not* including
java.net and java.math in the MANIFEST.MF file.  Version 2.4.0
*is*, but that is causing load errors.  Thus I've clipped it out here.

Change-Id: I63a3305e95269813697289e8f06bfbdb22113e13
Signed-off-by: Ed Warnicke <eaw@cisco.com>

First pass at fixing features

Change-Id: I55cbd19fec9c13f585a18a221403ad05b94d8569
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Bug fix: For the pervious commit 'Change MD-SAL bundle's artifactId', miss to update features.xml

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Change MD-SAL bundle's artifactId from 'org.opendaylight.snmp4sdn.md' to 'org.opendaylight.snmp4sdn' (For consistency that all other snmp4sdn's bundles use this artifactId)

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Features update: add VLAN configuration's MD-SAL model

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Add MD-SAL for VLAN configuration

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Correct the list in <repositories> and <pluginRepositories> in commons/snmp4sdn/pom.xml

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Fixing missing dependency breaking integration

Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Add Karaf CLI for (1) read switch list, (2) topology discovery, and (3) VLAN configuration

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Fixed the TestContainerException for Karaf testing

Change-Id: Iae0b59448a89f38786486755dc360f05a5d51de0
Signed-off-by: george zhao <george.y.zhao@huawei.com>

Merge "Fix: to fix the "Too many TestContainer implementations" when bulding, occured in the testing after building (as shown in https://git.opendaylight.org/gerrit/#/c/10700/). Exclusion for pax exam native is added in each dependency in the pom.xml."

Fix: to fix the "Too many TestContainer implementations" when bulding, occured in the testing after building
(as shown in https://git.opendaylight.org/gerrit/#/c/10700/).
Exclusion for pax exam native is added in each dependency in the pom.xml.

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Bug fix: to support Karaf, but missed to add 'features' to build in root pom.xml

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

To support Karaf

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

A sequence of modifications due to that upper layer (org.opendaylight.controller.flows.web.Flows) would need InventoryServiceShim to provide "SupportedFlowActions" instead of just "Actions" which is used in earlier

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Bug-1285- Removing all the unwanted code that was commented out as part of the port from Openflow.
There are still some references to OpenFlow that need to be reworked especially in the statistics.
Making changes suggested by code review.
Change-Id: I51d49d37e0c474c0e9fa85f74f86ca3fbcf8a5d1
Signed-off-by: rgowrishankar <ramkumar.gowrishankar@gmail.com>

Bug fix: VLANTable's toString() method had redundant comma

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Add "delete VLAN" to OSGi CLI

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

correct message typo

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Enable snmp4sdn plugin to support VLAN configuration (add VLAN and ports to a switch; show VLANTable of a switch)

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Added .gitreview file

Good reference :
http://www.mediawiki.org/wiki/Gerrit/git-review

Change-Id: Ib9c4f3235de191af931134b035ffb0b7ccb9b134
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Fix that snmpj didn't provide method to close socket, and cause snmp listening port can't be free.

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

just correct copyright typo

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

[maven-release-plugin] prepare for next development iteration

[maven-release-plugin] prepare release master-tagforprepareonly-snmp4sdn-bulk-release-3

Merge "Updating Jackson library to 2.3.0 to be in sync with Controller and other Opendaylight projects"

[maven-release-plugin] prepare for next development iteration

[maven-release-plugin] prepare release master-tagforprepareonly-snmp4sdn-bulk-release-2

[maven-release-plugin] prepare for next development iteration

[maven-release-plugin] prepare release master-tagforprepareonly-snmp4sdn-bulk-release-1

update root pom.xml with parents as modules

With out, prepping for a release hits this Error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.3.2:prepare (default-cli) on project snmp4sdn_distribution: Can't release project due to non released dependencies :
[ERROR] org.opendaylight.snmp4sdn:commons.snmp4sdn:pom:0.1.0-SNAPSHOT
[ERROR] in project 'snmp4sdn' (org.opendaylight.snmp4sdn:snmp4sdn:bundle:0.1.0-SNAPSHOT)

Adding parents as modules fixes that issue.

Change-Id: I48c07fa3afeabcc3955b405f78ee8507a366d3f1
Signed-off-by: Chris Wright <chrisw@sous-sol.org>

Remove yang in POMs (currently MD-SAL is not used in snmp4sdn)

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

commons.snmp4sdn: update dependencies to released artifacts

We missed the dependencies whose versions are set by a property.
Fixup yangtools.version and relevant yang models.

Change-Id: If1df6f8b759e43def9761ffdec01de5600798986
Signed-off-by: Chris Wright <chrisw@sous-sol.org>

update openflowj dependency in snmp4sdn artifact

Currently it's 1.0.3-SNAPSHOT, let's bring it back to the last released
artifact in prepartion for snmp4sdn release.

Change-Id: I142fc3f06631726685ef7002eb3db1233a6ad952
Signed-off-by: Chris Wright <chrisw@sous-sol.org>

Update to new version of the artifacts proposed by jenkins-snmp4sdn-version-changes-8

Change-Id: I365789c360c00f906487dcd610265bf9f9df5b45
Signed-off-by: jenkins-snmp4sdn <jekins-snmp4sdn@opendaylight.org>

Remove the directories whose development not completed(model/ and integrationtest/)

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Revert the changes to pom which was made by incorrect jenkins job setting

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

[maven-release-plugin] prepare for next development iteration

[maven-release-plugin] prepare release master-tagforprepareonly-snmp4sdn-bulk-release-prepare-only-7

expect4j: use slf4j-api version 1.7.2

Currently using 1.7.5 (as the github project does), and this
gives us a dependency skew from the rest of snmp4sdn and the
controller which use 1.7.2.

Change-Id: I3db7faf0e8db8f9fc76bb585d03d8718b1e9fcd3
Signed-off-by: Chris Wright <chrisw@sous-sol.org>

Fix that topologyDiscover() didn't clear existing switches first

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Just rename "constructNetwork()" as "topologyDiscover()", and add a OSGi console command for it.

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

User can manually specify the DB file's location in OSGi console. (DB file: the switch list)

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Replace the use of "System.out.exit()" with "return"

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Just shutdown the warning of reuest time out. (tempararily)

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Just remove useless lines in SNMPHandler.java

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Update pom and readme files:
1. Add copyright/license header to pom files and readme file
2. Add <scm> section to pom files
3. Add maven-release-plugin to the plugin management section of ./commons/snmp4sdn/pom.xml

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

1. Abandon the bug fix of gerrit 4442 because root cause is not there
2. Add a _constructNetwork() for toplogy resolving by OSGi CLI. This is a temporary solution for the bug: too early to construct subnet topology (i.e. constructNetwork() is called too early), before other related modules are ready.

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Fix bug: Too early to construct subnet topology (i.e. constructNetwork() is called too early), before other related modules are ready.

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Add copyright/license header

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Replace 'System.out.println()' with 'Logger'

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Expect4j's source uses repositories provided by SpringSource, and now we change to use ODL's nexus repo (SpringSource is now cached to ODL nexus)

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

1. In pom.xml, some dependencies (SAL and openflowj) is upgraded to the latest version.
2. SAL adds a new API in IPluginInInventoryService, so snmp4sdn's InventoryService is added with the new API.

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Updating Jackson library to 2.3.0 to be in sync with Controller and other Opendaylight projects

Please refer to https://git.opendaylight.org/gerrit/#/c/3905 for the corresponding Controller changes.

Change-Id: If6ab9eb1c057bee30138242098d285549ca6449d
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>

The mechanism of detecting a new switch is by receiving snmp trap of warmstart/coldstart is canceled.
Therefore:
(1) SNMPListener does not deal with the snmp trap of warmstart/coldstart.
(2) Due to (1), it is the Controller module (Controller.java) to proactively requests CmethUtil to know the list of all switches, then probes the switches for their ports, to construct the subnet topology.
(3) In InventoryServiceShim's swithAdded(), DiscoveryService's doEthSwDiscovery() only needs to be called once in total.

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

In the modified files:
1. Activator.java is updated due to 2 and 3 below.
2. NodeFactory and NodeConnectorFactory are used for creating Node and NodeConnector of type 'SNMP'.
3. Other files are updated that they implement the interface 'IContainerAware' defined by SAL.

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Remove expect4j from pom
(Unit tests with expect4j enabled are successful, but currently loading expect4j in OSGi has problem)

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Reorganize the code archtecture of Config Service (proposed API extensions)
(a) IConfigService: defines the APIs
(b) ConfigService: implements IConfigService, transform the inputted Node and NodeConnector to pure parameters such as IP_address and port_number, then call CLIHandler with the parameters
(c) CLIHandler: depends on vendor-specific CLI command format, generate command string and then call ExpectHandler to execute the command
(d) ExpectHandler: a wrapper of Expect4j, provides general functions for CLIHandler to use

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Just update README.txt

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Test: artifacts commons.snmp4sdn and commons.parent are put to ODL repo, now no need to build them in root pom

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

To build the artifact commons.parent so that this artifact would be in ODL repo

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

To build the artifact commons.snmp4sdn so that this artifact would be in ODL repo

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Merge "Correct the parent version typo in commons/integrationtest/pom.xml"

Correct the parent version typo in commons/integrationtest/pom.xml

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Fix the typo of NodeConnectorIDType("SNMP", Long.class, "SNMP") to ("SNMP", Short.class, "SNMP")

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

The implementation example for IConfigService, and the test for it.

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

1. Add the code for processing SNMP link-up trap to know the new port
2. Activator.java is updated as well

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Fix the typo of
(a) new Node(NodeIDType.OPENFLOW) to new Node(NodeIDType.SNMP)
(b) NodeConnectorIDType("SNMP", Long.class, "SNMP") to ("SNMP", Short.class, "SNMP")

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

1. In PortConverter.java and SNMPHandler.java, replace the custom function, createNodeConnector() for creating SNMP nodeConnector, with OpenDaylight existing function NodeConnectorCreate.createNodeConnector()
2. In PortStatisticsConverter.java, a custom function createSnmpNode() to create SNMP node

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Change snmp4sdn's artifact version from 0.0.1 to 0.1.0 (including pom in the directories of ./commons, ./snmp4sdn, and root)

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Remove useless code (commons/checkstyle/ and /commons/parent/README)

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Due to expec4j packeage error when building the code, here (1) remove expec4j in pom (2) remove the files dependent on expect4j

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Revert "Due to expec4j packeage error when building the code, here (1) remove expec4j in pom (2) remove the files dependent on expect4j"

This reverts commit 1df443095213a14dbd287881298ed349729e983e.

Change-Id: I1fa0934a6e424caee96c0ea4b6ef5250ce2eeb96
Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Due to expec4j packeage error when building the code, here (1) remove expec4j in pom (2) remove the files dependent on expect4j

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Fix the bug.
Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Merge "a test"

a test

Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>