Fixed Subtree typo

Change-Id: I5d4be5257deb9441ff8a64d4a3f25c220fad8559
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Added SFs, EP handling, Resolved Policy for IOVisorRenderer

- Cleaned up some core utils and IidFactory
- adding addition of IOVisor Module entry when Endpoint Aug is present

Change-Id: If8c952cc9b6f891eca7b88ccd63d6378bb2be6c9
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Merge "Directions and flow creation for symmetric chain corrected"

Fix for PolicyResolver multi-writer problem

Problem:
There was a listener per Tenant. Listeners tried to store resolved-policies
to datastore concurrently.

Fix:
Only one listener is registered for wildcard tenant. The listener handles all changes
in tenants.

Signed-off-by: Martin Sunal <msunal@cisco.com>

Fix for Neutron NB change 31324

Change-Id: I5600f4f853f4edc215bea24ef4aee936515d6f43
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Directions and flow creation for symmetric chain corrected

Signed-off-by: Vladimir Lavor.com <vladimir.lavor@pantheon.sk>
Change-Id: I9a2efbb3355936c3e974becd4062bfc92f2c5cb2

Merge "registration of action validators for to gbp-base"

Merge "Bug 3424 use MAC from external node connector"

Merge "Add missing license headers"

Merge "Clean up permissions on demo"

registration of action validators for to gbp-base

Change-Id: I062305d5c22493eb1d0040244f09134129723947
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>

Bug 3424 use MAC from external node connector

Change-Id: I909cca7631eff92fa60d0c1375fde738956b8f0b
Signed-off-by: Martin Sunal <msunal@cisco.com>

Merge "Tenant name changed to be consistent with CSIT."

Add missing license headers

Change-Id: I6ebb47e4c9335682f16bff606108031770a61968
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Registered simple classifier-instance validators

- classifier-instance validators based on renderer's capabilities
- this simple classifier-instance validators are registerd automaticly
if PolicyValidatorRegistry is available

Change-Id: Ie418fb7cebbd38fc25fdb7daed4f6745ac0fbe98
Signed-off-by: Martin Sunal <msunal@cisco.com>

making service for PolicyResolver and EndpointRpcRegistry

Change-Id: Ieb489292492a87be72800dde7841330eb1b3db9b
Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.sk>
Signed-off-by: Vladimir Lavor <vladimir.lavor@pantheon.sk>

Clean up permissions on demo

Change-Id: I5a05811790026028da02a0cc04a8af5e49c5f973
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Fix .gitignore

renderers/ofoverlay/src/test/java/org/opendaylight/groupbasedpolicy/resolver/ should
not be ignored.

Change-Id: Ia7d0e24c948bb160fda0549fcb9686df81e0ae9a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 4724 added containers to tenant

Change-Id: Ibec940580f8ef9f741cdc4b4adf3f01bbf477e51
Signed-off-by: Martin Sunal <msunal@cisco.com>

Tenant name changed to be consistent with CSIT.

Change-Id: I582919e11a262f743512115a8a71cc90ec9c3cc3
Signed-off-by: Dileep <dileep.ranganathan@intel.com>

added .gitignore for demos

Signed-off-by: Martin Sunal <msunal@cisco.com>

added demos to the repo

Signed-off-by: Martin Sunal <msunal@cisco.com>

Moving of classes between packages in groupbasedpolicy

- classes are in packages based on type
- introduced EpRendererAugmentationRegistrar, PolicyValidatorRegistrar

Change-Id: Ia603624eeebd52821802f30f0adb2f18c5a59627
Signed-off-by: Martin Sunal <msunal@cisco.com>

Removed PolicyListener and PolicyResolver methods

- renderer should listen on resolved-policy from resolved-policy.yang
- removed public methods from PolicyResolver

Change-Id: Ife1e165b7264910a5be2f859b72f2b454dd04027
Signed-off-by: Martin Sunal <msunal@cisco.com>

Added interests to renderer.yang

Signed-off-by: Martin Sunal <msunal@cisco.com>

Add a REST APIs support for IOVIsor module

- provide aaa authentication
- path is: /controller/sb/iovisor/{SERVICE}

For now we have one service being: /policies
Through this one we will POST a list of policies for the
IOVisor module to GET.

To play with thee REST interface, you can use this
postman collection: https://www.getpostman.com/collections/3b1fe6ef1ec0ead72ee7

Another patch will implement the POST correctly

Change-Id: I5186df6b5d0501dca8b244bfd04e22dd54649b40
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Removed mocks from unit tests

removed mocks breaking API contracts

Change-Id: Ie18f75c213d78c053102722f29450ed209ddb492
Signed-off-by: Martin Sunal <msunal@cisco.com>

Add IovisorModule manager and listener

Change-Id: Icf4cef2e03ef42c085aabca8a0bd0a984bb3e687
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Merge "Simplifying validators"

Simplifying validators

Complicated validation code made simpler.
Added methods for registering classif instance validator.

Change-Id: I428f5d13b07bd1d0d40dff02c29334e329e7fb04
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Use odlparent-lite as artifacts parent

We created odlparent-lite to provide a minimal pom which allows projects
to publish to the correct server. Without this ${project}-artifacts may
fail to deploy to Nexus.

Change-Id: I23b0fbf52425b638f4c86fd089062e5d1150c799
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Rework IOVisor model and validate IovisorModuleInstance on Endpoint created events"

Merge "Update IidFactoryTest to use non-deprecated function"

Merge "Add endpointIid(EndpointKey enpointKey) in IidFactory"

Rework IOVisor model and validate IovisorModuleInstance on Endpoint created events

Change-Id: Id80f1b58e3b837ce6d17f0ffbf29b999ce1e7b58
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Update IidFactoryTest to use non-deprecated function

firstKeyOf(Class, Class) was deprecated in favor of firstKeyOf(Class)

Change-Id: I6543565db3bf4963a691703aad72faab203ef60b
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Add endpointIid(EndpointKey enpointKey) in IidFactory

Get the Endpoint InstanceIdentifier using the EndpointKey

Change-Id: I5e9442c01848260e8ccdbd9d1d751b714ba93937
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Fix for incorrect RspName from SfpName

- added Tenant ID for unique RSP

Change-Id: I882c43e5d6856eaa51f8e408a7353ee8878fe826
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Fixed issues with registration point for renderers

- missing keys in instance-identifiers
- wrong params in supported classifier defs
- added action definition and action capabilities

Change-Id: I2878d92ec6f17777fe6438825fac60e14e204fc4
Signed-off-by: Martin Sunal <msunal@cisco.com>

UUIDs be gone.

Change-Id: I6b846a6778d1b963e9a3b369e49f57801ea6431d
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

removed need for getInterfaces call

Change-Id: I9b7f3b32f0fb4265981dfaee9e47cf6f13bae26a
Signed-off-by: Matej Perina <matej.perina@pantheon.sk>

EndpointRpc provider in groupbasedpolicy

EndpointRpcService is changed to be created by groupbasedpolicy modul
and renderers only register their EpRendererAugmentation implementation

Change-Id: I223346b6d89b82e05fe83935b0e90bfe1b9cb0e8
Signed-off-by: Matej Perina <matej.perina@pantheon.sk>

Registration point for renderer capabilities

Change-Id: Ifa5db51b89c499926c088deafec454e81e7b3fbc
Signed-off-by: Martin Sunal <msunal@cisco.com>
Signed-off-by: Konstantin Blagov <kblagov@cisco.com>

Move definitions of classifiers and actions to
groupbasedpolicy module

Change-Id: Ifa612dee83f9c6b7d8bf20d0707dbd58a3e8ead4
Signed-off-by: Peter Palmar <peter.palmar@pantheon.sk>
Signed-off-by: Konstantin Blagov <kblagov@cisco.com>
Signed-off-by: Martin Sunal <msunal@cisco.com>

Merge changes from topic 'iovisor-renderer'

* changes:
  Instantiate IovisorRenderer in the IovisorProviderModule
  Add Endpoint Manager and Listener

Merge "Add IOVisor module location augmentation"

Instantiate IovisorRenderer in the IovisorProviderModule

Change-Id: I74b30556026a5b83427df9a806802528a5289468
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Add Endpoint Manager and Listener

Change-Id: Ia24206237751b2035cbf2206a6d67ff6e5543b78
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Add IOVisor module location augmentation

Change-Id: Ib9240de94cd95c38cb299d607c791736c7186030
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Merge "Added new tests for EndPointRpcRegistry"

Added new tests for EndPointRpcRegistry

Signed-off-by: Igor Bartak <ibartak@cisco.com>
Change-Id: I7304196e2ca83d71a5c0cc5eaf84129817021d99

Fix wrong package name

Change-Id: I45a31449a7a0ff5d9885d121b088acb1493ddb44
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Remove duplicate dependency declaration

Maven complains about it, remove it.

Change-Id: I8c77c38ffddbdc4e9af75ac425f1bf011112462f
Signed-off-by: Robert Varga <rovarga@cisco.com>

Adding mgmt traffic to Network Services

Change-Id: Ie32822871499a12556094d2abb40007e22171b29
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Merge "New features"

New features

- IOVisor renderer
- OVSSFC renderer
- Netconf renderer

Change-Id: Ie061a9dd99bd4fa6c1c77399e9616c9f9bb3eff3
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Bug 4106 - tunnel output in group mods

Added tunnel output on local node to remote nodes on which endpoints
  - are in the same flood domain as local endpoint
  - have resolved policy with a local endpoint
E.g. endpoint wants to communicate with DHCP server which is in
diferent EPG and on different node (vSwitch), but in the same flood domain.

Change-Id: Idd322f1b4b143cd2149caa82823d44a5e31d77b6
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Clean up pom file - part 2

- remove jaccoco plugin definition to use the one from odlparent

Change-Id: Iadfa794589aa96411b416799b7ba0983c2ea24fe
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Changes for SFC project features

Relies on https://git.opendaylight.org/gerrit/#/c/29169/

Change-Id: I61d19c9cd63262785ef7997ea5a6848e32cb2fb2
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Clean up pom files

Change-Id: I31eb3d576d92639b8fca269e76fb5759366074fd
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Move config file under src/main/config

Instead have having a seperate bundle for the config file, let's use the src/main/config
source package and the config-parent parent from controller project

This patch also fixes:

- header violation
- proper .gitignore entry for maven-metadata-local.xml

Change-Id: I738e592f8d7e559d9609b8c8f1d4cf9102311367
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Fix copyright header

Change-Id: I6bb5f24c3ffd70be7c4e36eea7c5e1384fa33a05
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Add yang generated packages in .gitignore

Change-Id: I1bd4365d9379ea8ba1de6981eef511be5f56774a
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Getting FAAS renderer started

This prepares the code structure for the FAAS renderer so that it can
be integrated with the Fabric As A Service (FAAS) project.
For more info about FAAS, Please see
https://wiki.opendaylight.org/view/FaaS:Main

Change-Id: Ie05739b4a9b68dad9c94d6639b3254a2bf0735a9
Signed-off-by: Khaldoon Al-zoubi <khalAlzoubi@gmail.com>

Typedef changes in SFC project

Change-Id: I54d60ee5d0d55150e371ef2e804dd792e921c7be
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Added revisions into imports in yang

Signed-off-by: Martin Sunal <msunal@cisco.com>

Bug 4487 fixing of NPE and moved creation of infrastructure

- Network Service EPG and Client Epg are created on neutronNetworkCreated

Change-Id: I85b805f327e73f41f81ce3c42846c55fa32cd641
Signed-off-by: Martin Sunal <msunal@cisco.com>

Removed tests based on changes in neutron

- commit [1] introduced UUID format check so we got errors in negative tests

[1] https://git.opendaylight.org/gerrit/#/c/28365/1

Signed-off-by: Martin Sunal <msunal@cisco.com>

Merge "Gbp coverage increased in ./neutron/mapper/infrastructure"

Merge "Gbp coverage increased in ./neutron/mapper/util"

Gbp coverage increased in ./neutron/mapper/mapping/rule

- NeutronSecurityRuleAware.java (+35%, 87% overall)

Signed-off-by: Vladimir Lavor <vladimir.lavor@pantheon.sk>
Change-Id: Iecdf2dc507d76d9e58b253d7ee9ada50b3aed70c

Gbp coverage increased in ./neutron/mapper/util

- MappingUtils.java (94%)
- NeutronMapperIidFactory (100%)

Signed-off-by: Vladimir Lavor <vladimir.lavor@pantheon.sk>
Change-Id: I18918e1df68b87f768ad57284ed0573d379d89f6

Gbp coverage increased in ./neutron/mapper/infrastructure

- NetworkClient.java (100%)
- NetworkService.java (100%)
- Router (100%)
- Utils.java updated

Signed-off-by: Vladimir Lavor <vladimir.lavor@pantheon.sk>
Change-Id: Idaf4215f384d95ea6cd136913ea9825cffa9cf92

Merge "Bug 4195 - UT - GBP - NeutronMapper - groupbasedpolicy.neutron.gbp.util     NeutronGbpIidFactoryTest.java(98.3%)"

Bug 4195 - UT - GBP - NeutronMapper - groupbasedpolicy.neutron.gbp.util
    NeutronGbpIidFactoryTest.java(98.3%)

Change-Id: I26a87c83adb0387726a02792e8514b6ea9471404
Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>

Test cases added to neutron-mapper and implementation improved:

Test cases relate to packages:
- org.opendaylight.groupbasedpolicy.neutron.mapper.mapping.group
- org.opendaylight.groupbasedpolicy.neutron.mapper.mapping.rule

Implementation improvement:
- <intra-group-policy>require-contract</intra-group-policy> is added for each endpoint group being added.
- Deleting a provider named selector from an endpoint group is added to a transaction only if it exists.

Change-Id: I91de3f130b78c6e456428702f053400999099fc3
Signed-off-by: Peter Palmar <peter.palmar@pantheon.sk>

Write resolved-policy.yang into Datastore, allowing renderers to listen to it.

Change-Id: I5316a680641293bd6394b1620a73c5c8e835049e
Signed-off-by: Khaldoon Al-zoubi <khalAlzoubi@gmail.com>

Merge "Version tag removal"

Merge "OpFlex removed from master"

Merge "Bug 3655: Endpoint location is now updated when OVS is disconnected/removed"

Version tag removal

Fix for: "'version' contains an expression but should be a constant"

Change-Id: I2c62963ecae899d024be6cb14cea444371ba070f
Signed-off-by: Daniel Malachovsky <dmalacho@cisco.com>

OpFlex removed from master

Will not be released in Beryllium 2.It is out of date
with the LibOpFlex project and it is impacting UT targets
for no benefit.

Signed-off-by: Vladimir Lavor <vladimir.lavor@pantheon.sk>

Feature uses features-parent as parent

- features-parent is used from odlparent as parent for features-groupbasedpolicy
- groupbasedpolicy-artifacs dependency management pom is created in artifacts
  folder
- removed dependency on features-sfc-netconf

Change-Id: I7bd5f9542a44c7f01e8ea38c922760d5754f44d3
Signed-off-by: Martin Sunal <msunal@cisco.com>

Bug 3655: Endpoint location is now updated when OVS is disconnected/removed

Signed-off-by: Vladimir Lavor <vladimir.lavor@pantheon.sk>
Change-Id: I8efe7428cc2c8ffbf63ca4a8180cf7ae4292037f

Merge "Improved naming and usage of groupings"

Merge "Storing resolved PolicyInfo in Datastore"

Improved naming and usage of groupings

- naming of yang elements was changed
- created more groupings for better reusability
- improved descriptions
- renaming of yang module

Signed-off-by: Martin Sunal <msunal@cisco.com>

Storing resolved PolicyInfo in Datastore

Change-Id: Id8b14fe25595275f3342e558b7a65549af593a3a
Signed-off-by: Khaldoon Al-zoubi <khalAlzoubi@gmail.com>

Fix for bug 4287 and bug 4302

Change-Id: I1d4d82ab4b39b92f3116db5c3bc50a188ff0b3b4
Signed-off-by: Peter Palmar <peter.palmar@pantheon.sk>

Fix for compilation error introduced in merged bugfix

compilation error in
https://git.opendaylight.org/gerrit/#/c/27285/1

Signed-off-by: Martin Sunal <msunal@cisco.com>

Merge "Use odlparent configuration for jacoco"

Merge "Bug 3693 - UT GBP - 4 - Ofoverlay-renderer - renderer/ofoverlay"

Bug 4341: Lifecycle Management of Endpoint Registry state

- add endpoint rpc registration to OfOverlayL3NatAug class
- classes OfOverlayAug and OfOverlayL3NatAug are autocloseable now

Signed-off-by: Vladimir Lavor <vladimir.lavor@pantheon.sk>
Change-Id: I32aa6a9eed4fbed0f6d3d4eb318a89ea89db4aa4

Remove unused adsal dependencies

Change-Id: I9bf62049e99b176bd88dd09b655cd12983c202a1
Signed-off-by: Ed Warnicke <hagbard@gmail.com>

Bug 4098 - ofoverlay-renderer failure in jdk8

Modified Javadoc comments for jdk 8 compatibility
Formatted whitespaces/tabs
  - VxlanTunnelType.java
  - VxlanGpeTunnelType.java
  - AbstractTunnelType.java

Change-Id: I34f0722f8982424eae77aa7be97722e0dfc226d2
Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>

Bug 3693 - UT GBP - 4 - Ofoverlay-renderer - renderer/ofoverlay

- SfcManager(42.9%)
- PolicyManager(73.3%)

Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>
Signed-off-by: Peter Palmar <peter.palmar@pantheon.sk>
Change-Id: If1e0f0f98c80319108e0d8202f01141183b56e0d

Bug 3302: fix for GroupTable

Change-Id: I38065618e28e0ff88fc50cd3c950549049cf04eb
Signed-off-by: Konstantin Blagov <kblagov@cisco.com>

Correction of uncomplet cherry-pick

Diff in IngressNatMapperTest.java
https://git.opendaylight.org/gerrit/#/c/24151/4
https://git.opendaylight.org/gerrit/#/c/24204/4

Diff in all files
https://git.opendaylight.org/gerrit/#/c/22454/8
https://git.opendaylight.org/gerrit/#/c/22812/2

Signed-off-by: Martin Sunal <msunal@cisco.com>

Bug 3240 3613: Asymetric policy in neutron

bug 3613
naming is more user-friendly because is composed from classifiers and actions

bug 3240
Assymetrical policy can occur when using neutron remote-security-group in rule.
Analysis showed that problem is caused by ANY endpoint-group
Fix of this bug is removing of ANY endpoint-group.

Basicly neutron Security Group Rule (SecRule) is translated to one Contract containing
one Subject with one Rule.

Change-Id: I8724c9eaa0244182ab26e2870399630c74b842df
Signed-off-by: Martin Sunal <msunal@cisco.com>
(cherry picked from commit 3bdadfae6e60e8ac58dd8572786da340f21b14ab)

Use odlparent configuration for jacoco

Change-Id: I4e46f59270716d5cea218d0e65e94f785583229c
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>