Bug 3822: Improve error reporting for restconf PUT

A runtime exception can be emitted by the netconf mount point which
should be reported to the user, otherwise you get a 500 response with
no error info which isn't very helpful.

Also the fucntionality to output the error-info field was ommitted with
the conversion from CompositeNode to NormalizedNode so I re-implemeneted
it. It was originally ommitted with a TODO b/c the
NormalizedNodeStreamWriters validate against the schema and error-info
is defined as an empty container in the restconf yang. So there's no way
to create a ContainerNode to represent the error-info data that conforms
to the schema. To work around this, I created a leaf node and special-cased
error-info in the stream writer to elide schema validation.

I also added a regression unit test for the case where the URL contains
an identityref.

Change-Id: I93b4aea25c829af1232d539180f02dd61e252d50
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Signed-off-by: JMorvay <jmorvay@cisco.com>

Merge changes Iad68eda5,Ie962aa4b

* changes:
  BUG-865: use new JSONNormalizedNodeStreamWriter methods
  BUG-865: remove use of yang.model.util.repo

Fixed features-netconf to use feature test and correct versions

Previous patches were assuming that single feature test was working
for features-netconf, which is was not - test was commented out
due to controller - aaa - netconf cycle dance.

- Reenabled single feature test
- fixed version of odl-netconf-mdsal

Change-Id: I47f5a52b96b07f94e8823968b90934b435aa5a2b
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

BUG-865: use new JSONNormalizedNodeStreamWriter methods

JSONNormalizedNodeStreamWriter.create() family of methods is deprecated,
do not use it.

Change-Id: Iad68eda5efcd191e7cba03785b7ef9e2e550dd9a
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-865: remove use of yang.model.util.repo

This package is deprecated and about to be removed. Remove all
references to it.

Change-Id: Ie962aa4bdc6400b70def7f2486356b123ff19eb4
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 4306: Refer to the correct version of features-netconf-connector

features-netconf-connector's POM inherits netconf-features-parent's
version, 1.0.0-SNAPSHOT; but netconf-artifact's POM uses
${mdsal.version} for features-netconf-connector (1.3.0-SNAPSHOT).

This patch uses ${project.version} instead, which is 1.0.0-SNAPSHOT.

Without this sfc fails to build in a clean environment.

Change-Id: Icad267d3e502233243eb10b4a7274b23feff0c31
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Migration to use MD-SAL Project

Change-Id: Iafdfbcf553978717be7ec80b488f94b64f688eea
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Ignore failing tests

These tests are relying on ordering of hash-based objects,
ignoring for now to prevent job failures.

Change-Id: Ie467c1f06924a6699e20ace71baa5825cbb48198
Signed-off-by: Tomas Cere <tcere@cisco.com>

Merge "Add .gitreview"

Merge "MD-SAL netconf northbound now relies on AAA for authentication"

Merge "Rename netconf-ssh test packages"

MD-SAL netconf northbound now relies on AAA for authentication

Change-Id: I58ff18fbcc230c7391617c435897673169052aa9
Signed-off-by: Tomas Cere <tcere@cisco.com>

Rename netconf-ssh test packages

Change-Id: I0a19631cdb4ce567f6d8a2f222b49b38641751a9
Signed-off-by: Tomas Cere <tcere@cisco.com>

BUG 4010:Reintroduce inventory code into sal-netconf-connector

Change-Id: I946907d9ef835d3e5ffdd198d1ec39158ff91feb
Signed-off-by: Tomas Cere <tcere@cisco.com>

Fix integration tests imports and checkstyle violations

Change-Id: Id016e581f0018c2aa47f6fc371fb85f6ad341950
Signed-off-by: Tomas Cere <tcere@cisco.com>

Merge "Enable authn on odl-restconf feature"

Merge "Make test-tool advertise candidate capability"

Merge "Bug 4276 - restconf-artifacts is missing restconf-features xml"

Bug 4276 - restconf-artifacts is missing restconf-features xml

Add features classifier, xml type and runtime scope to features-restconf
artifact in restconf-artifacts

Change-Id: If264169f0c584aace07b925aecaae219f91dff77
Signed-off-by: JMorvay <jmorvay@cisco.com>

Use NodeIdentifier.create()

For pre-computed constants it is beneficial to have them shared across
the system, such that when they meet we end up sharing them.

Change-Id: Ic81a350c94010450540868a9281d2994f4e08f2a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Enable authn on odl-restconf feature

Uncommented odl-aaa-authn that was left commented out,
probably due to version bump.

Change-Id: Iae8b83b13c5d2593923ad54c10dfc0efb285b0df
Signed-off-by: Tomas Cere <tcere@cisco.com>

Add .gitreview

Change-Id: I0853775fd893085abde3a0aa3601b65794ef04d8
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BUG-4259: fix config artifact references

This got broken in the migration where netconf moved from
org.opendaylight.controller namespace.

Also fixes netconf-it module being configured to build twice. The root
pom as well as the netconf parent both had a profile to build netconf-it
only one is needed.

Change-Id: I5dce4e9802f08efdcc866c9992b3bae9f49190ac
Also-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Make test-tool advertise candidate capability

Change-Id: I97a627147434c5417043e589039097cf03c1c4b9
Signed-off-by: JMorvay <jmorvay@cisco.com>

Merge "Use migrated restconf artifacts in restconf features project dependencies"

Use migrated restconf artifacts in restconf features project dependencies

Change-Id: Ia68483053c4f77c89c450f69df6022b9c98de38b
Signed-off-by: JMorvay <jmorvay@cisco.com>

Merge "Implement md-sal datastore into netconf test-tool"

Merge "Add aaa-authn-odl-plugin"

Add aaa-authn-odl-plugin

Move in aaa-authn-odl-plugin to prevent cyclic dependency between
aaa and netconf.

Change-Id: Ibb89231b229664bbc9ae6d97c098f637de764448
Signed-off-by: Tomas Cere <tcere@cisco.com>

Implement md-sal datastore into netconf test-tool

Change-Id: I2dd627b57ddac33a77878a7c07f5565e4eb5b841
Signed-off-by: JMorvay <jmorvay@cisco.com>

Merge "Make sal-netconf-connector fail, if connecting to device, that does not advertise :candidate or :writtable-running capability"

Merge "Add features-restconf to restconf-artifacts"

Add features-restconf to restconf-artifacts

Change-Id: Iac9c0600a3be644abf9e6021f109612494f5b765
Signed-off-by: Tomas Cere <tcere@cisco.com>

Fix exchanged added and deleted capabilities in capabilities notification

Change-Id: I56286f6973dae3a8d0b35f8abbf6a77c02deacd2
Signed-off-by: JMorvay <jmorvay@cisco.com>

Make sal-netconf-connector fail, if connecting to
device, that does not advertise :candidate or
:writtable-running capability

Change-Id: Ieabbc8f2833df914db9b10b65b7b9f8ca04e1e95
Signed-off-by: JMorvay <jmorvay@cisco.com>

Merge "Rename restconf packages to org.opendaylight.netconf"

Merge "Rename tools packages to org.opendaylight.netconf"

Merge "Rename netconf-util packages to org.opendaylight.netconf"

Merge "Rename netconf-ssh/tcp packages to org.opendaylight.netconf"

Merge "Rename netconf-notifications packages to org.opendaylight.netconf"

Merge "Rename netconf-netty-util packages to org.opendaylight.netconf"

Merge "Rename netconf-monitoring packages to org.opendaylight.netconf"

Merge "Rename netconf-mapping-api packages to org.opendaylight.netconf"

Merge "Rename netconf-impl packages to org.opendaylight.netconf"

Merge "Rename netconf-client packages to org.opendaylight.netconf"

Merge "Rename netconf-auth packages to org.opendaylight.netconf"

Merge "Rename netconf-api packages to org.opendaylight.netconf"

Merge changes I98276170,I77b1d470

* changes:
  Rename messagebus-netconf packages to org.opendaylight.netconf
  Rename mdsal-netconf-monitoring packages to org.opendaylight.netconf

Merge "Rename mdsal-netconf-connector packages to org.opendaylight.netconf"

Merge "Rename config-netconf-connector packages to org.opendaylight.netconf"

Merge "Fix sal-netconf-connector feature version"

Rename restconf packages to org.opendaylight.netconf

Change-Id: I4d6ffc2e164a251e2b1878dcf77809f8c50b7b5a
Signed-off-by: Tomas Cere <tcere@cisco.com>

Rename tools packages to org.opendaylight.netconf

Change-Id: I1f9bae490ce4770a733185a0f540ded774c8dff3
Signed-off-by: Tomas Cere <tcere@cisco.com>

Rename netconf-util packages to org.opendaylight.netconf

Change-Id: Icf89e7f6da84722faff34b86bf5b7ac6e0cb61ee
Signed-off-by: Tomas Cere <tcere@cisco.com>

Rename netconf-ssh/tcp packages to org.opendaylight.netconf

Change-Id: Ie76bac58fa32c7acb4b580eeb697c9402d87f147
Signed-off-by: Tomas Cere <tcere@cisco.com>

Rename netconf-notifications packages to org.opendaylight.netconf

Change-Id: Idca977c5e4355f26679600f75d6de42f2035f324
Signed-off-by: Tomas Cere <tcere@cisco.com>

Rename netconf-netty-util packages to org.opendaylight.netconf

Change-Id: I4ccbba062080f0e677b7054ee2026fb1d61c69dc
Signed-off-by: Tomas Cere <tcere@cisco.com>

Rename netconf-monitoring packages to org.opendaylight.netconf

Change-Id: Idf9c0f3d807384089aa719890437c8b9ef602c72
Signed-off-by: Tomas Cere <tcere@cisco.com>

Rename netconf-mapping-api packages to org.opendaylight.netconf

Change-Id: I0abed7fd91d1f8fd0b1d99899440127aac086beb
Signed-off-by: Tomas Cere <tcere@cisco.com>

Rename netconf-impl packages to org.opendaylight.netconf

Change-Id: I8dad162c0f519420a80fc58099b6f6f4a92f819b
Signed-off-by: Tomas Cere <tcere@cisco.com>

Rename netconf-client packages to org.opendaylight.netconf

Change-Id: I6c7a99491200c1c41098a83cd1aed02f33d3840d
Signed-off-by: Tomas Cere <tcere@cisco.com>

Rename netconf-auth packages to org.opendaylight.netconf

Change-Id: Ibd646282c633dbed92ec003cf7b1b0f0517e283b
Signed-off-by: Tomas Cere <tcere@cisco.com>

Rename netconf-api packages to org.opendaylight.netconf

Change-Id: I396100af615b71f3f1cae49fc9a418d27dac5a7f
Signed-off-by: Tomas Cere <tcere@cisco.com>

Rename messagebus-netconf packages to org.opendaylight.netconf

Change-Id: I9827617094c847cb5206eaa65d70d9f47c37c591
Signed-off-by: Tomas Cere <tcere@cisco.com>

Rename mdsal-netconf-monitoring packages to org.opendaylight.netconf

Change-Id: I77b1d4704d19650091ae25c44b60b5814cda91c6
Signed-off-by: Tomas Cere <tcere@cisco.com>

Rename mdsal-netconf-connector packages to org.opendaylight.netconf

Change-Id: Ib5b3dace1dc9bb568b36e5d895966fdc2eb0b35a
Signed-off-by: Tomas Cere <tcere@cisco.com>

Rename config-netconf-connector packages to org.opendaylight.netconf

Change-Id: I960ca48cd1942a2e101c12238630a06a39ff0f82
Signed-off-by: Tomas Cere <tcere@cisco.com>

Fix sal-netconf-connector feature version

Make sal-netconf-connector preserve md-sal version.
Make features-netconf-connector inherit netconf project version

Change-Id: Iae701ee92912eb3229c586a0293ac15467b33fa6
Signed-off-by: Tomas Cere <tcere@cisco.com>

Change karaf groupId and version

Change-Id: I0f3840267c8374cc8bce1b5c9858d1801222395d
Signed-off-by: Tomas Cere <tcere@cisco.com>

Add missing odl-config-netty feature into odl-netconf-mdsal

Change-Id: Ifd077a881311517471cb0f39b24db4a6d11ea08c
Signed-off-by: Tomas Cere <tcere@cisco.com>

Add karaf distribution

Change-Id: I8e451d76741ab60f05082ab1e3d7d71285b0a11a
Signed-off-by: Tomas Cere <tcere@cisco.com>

Create restconf-artifacts

Change-Id: I7aa99cd8ab914e4c9a96822b7b893dbda5a3fc1b
Signed-off-by: Tomas Cere <tcere@cisco.com>

Fix license header violation

Change-Id: I1606a869c0e10cdc8f289492a83668421df50831
Signed-off-by: Tomas Cere <tcere@cisco.com>

Add rest connector config

sal-rest-connector-config was forgotten in controller

Change-Id: Id4004d02325ea306b29b4b51e7f85cf1217ce0e2
Signed-off-by: Tomas Cere <tcere@cisco.com>

Change groupId and versions of netconf artifacts

Change-Id: Id961c524aa338d0c1d553b6c3937b0e0a8c7d0f4
Signed-off-by: Tomas Cere <tcere@cisco.com>

Add restconf features

Unify netconf/restconf features into single directory

Change-Id: Ia92659b3de2af9df0764181f309f32a0c96f2456
Signed-off-by: Tomas Cere <tcere@cisco.com>

Cleanup project structure and dependencies

Add restconf-parent pom
Add parent dependencies/build plugins and properties to restconf/netconf parent poms
Rename md-sal dir to restconf since restconf is no longer part of md-sal

Change-Id: I3874d514ec969c1710b2fe173db4c53781387d4f
Signed-off-by: Tomas Cere <tcere@cisco.com>

Add .gitignore

Change-Id: I9a1435c847ea3a563afa9f29f743bb91a7c419e9
Signed-off-by: Tomas Cere <tcere@cisco.com>

Add base netconf pom

Cleanup bad imports that were failing checkstyle

Change-Id: I5026d2075426ccea415e31a7ef913668a7a4a10e
Signed-off-by: Tomas Cere <tcere@cisco.com>

Decouple message bus from netconf connector

Change-Id: I6a143e868adc1e5c7a9b114798e7009bb6ef8675
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Signed-off-by: Tomas Cere <tcere@cisco.com>

Decouple config and netconf subsystems.

Extract a common mapping for config pusher and config subsystem netconf
Add a ConfigPersisterFacade for XML that allows reads/writes from/to config
subsystem using XML format
Push notifications from YangStoreService to NetconfNotificationManager instead
of using custom listeners
Migrate netconf features from controller features, untangle features

Change-Id: I71e4ca6e0258e0b1f0d6c19119f93eb9d68b7bca
Signed-off-by: Tomas Cere <tcere@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Signed-off-by: Ed Warnicke <hagbard@gmail.com>

Fix license header violations in sal-rest-docgen

Change-Id: I03c4b7ef9397224d649e9387ed895bca74672ec9
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix license header violations in sal-rest-connector

Change-Id: I2dfda9fe6b3185d20386cc9f6078c0b53f7be40b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix license header violations in netconf

Change-Id: Ie5c541b03a342bec33257b13b985b89e9ca835a0
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Clean up pom.xml file

- Remove unnecessary commented code

Change-Id: Id4ceca0174ba5883059c52cbcee11aafb67c74ea
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add config subsystem binding to netconf-auth API

Change-Id: Ie04d9a7cb72bfcbeae6c7ca7dc0dbb2bdeadef0d
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Bug 2358 - Remove tests cnsn to json and add tests nn to json

Tests of codecs are included in codecs yangtools yang-data-codec-gson and yang-data-impl but
we test codec on input data and also with presentation of Rest path.

* remove CnSnToJsonNotExistingLeafTypeTest.java test
* add NnToJsonNotExistingLeafTypeTest.java to nn/to/json/test/
  * test with not existing leaf type

Change-Id: Id7a1256b42a3a754e13343613dcad7059a2316c4
Signed-off-by: Jakub Toth <jatoth@cisco.com>
(cherry picked from commit 1fa839d51563b9588bf7502e86a5e9c2425fab2f)

Bug 2358 - Remove tests cnsn to json and add tests nn to json

Tests of codecs are included in codecs yangtools yang-data-codec-gson and yang-data-impl but
we test codec on input data and also with presentation of Rest path.

* remove CnSnToJsonWithAugmentTest test
* add NnToJsonWithAugmentTest to nn/to/json/test/
  * positive test for test augmented elements

Change-Id: I4c8b92e828ade1d43a5af5384ec7938854fda9ce
Signed-off-by: Jakub Toth <jatoth@cisco.com>
(cherry picked from commit 6b97753fc17bb2d9d73047038105754fcebe029d)

Bug 2358 - Remove tests json to cnsn and add tests json to nn

Tests of codecs are included in codecs yangtools yang-data-codec-gson and yang-data-impl but
we test codec on input data and also with presentation of Rest path.

* remove all tests json to composite node and simple node
* rewrite json leafref input tests from comp and simple node to normalized node
  * we're testing REST provider URI path translator with payload
* add test for test data in json with identityref to normalized node
  * positive test
  * test data in builded normalized node with data in json
    * used identityref type to reference an existing identity
* add test for test data in json with leafref to normalized node
  * positive test
  * test data in builded normalized node with data in json
    * used leafref type to reference particular leaf instance in the data tree
* add test for test data in json with more type of nodes and values
  * positive tests
    * test normalized node from json with:
      * simple data in list
      * simple data in container
      * multiple items in leaf-list
      * multiple items in list
      * empty leaf
      * augmented data
  * negative tests
    * test fail on bad top level elements
      * contains 3 situations
    * test fail for null data
      * empty leaf-list
      * leaf without any value
    * test on build normalized node with blank json
    * test fail with different namespaces
    * test fail because of unsupported format of json
    * test on invalid URI character

Change-Id: Icb5ff5d11843123c79859a0c75d7df7bad8a0b44
Signed-off-by: Jakub Toth <jatoth@cisco.com>
(cherry picked from commit a3fd2b66c8121a8603d684b97c1fb7076d933d99)

Remove deprecated constructors from RemoteDeviceId

Change-Id: I26d48930a16213d2264de964f60103e67f80b9bd
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Improve performance of notification emitting in netconf testtool

- pre-parse all notifications beforehand
- remove unwanted outputs

Change-Id: I6dd823786fd0d5f9ab04943633f8aa3b61a540e8
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
(cherry picked from commit 7392728edfe0b150833c7af47c3bc8d4b0ce101a)

Bug 3887 - Autogenerated API documentation doesn't show application/xml
as an option for RPC operations

* added xml input option for rpcs, put and post methods

Change-Id: I1f73bcb7d1127e4b4324d779aec40907ca627073
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
(cherry picked from commit e57d9461b79dedd8ef9edf8f249b066540fd0e9d)

BUG-3963 Remove netconf-usermanager

This way of authentication relied on AD-SAL and thats deprecated/removed now
from ODL.

Change-Id: I0daeee09ff88b1c4677206c1b7216e972d34f01c
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Bug 1500 - Null pointer exception when using mounted resources tab to
see the operations on mount point

* added check for when revision is null in modules comparator

Change-Id: I3bdc4ed798297d31ea25001d25918e298c8124bb
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>

Add netconf-mapping-api test for HandlingPriority

Change-Id: I29a6fdaab266acd42c5355101769bb82c14135fc
Signed-off-by: Tomas Cere <tcere@cisco.com>

Add discardChanges branch to unit test

Add service instance deletion to NetconfMappingTest

Change-Id: I25d1ebefde86050c42a2d43ec445feaf8d5889de
Signed-off-by: Tomas Cere <tcere@cisco.com>

Remove yang-data-operations dependencies

Not used anymore

Change-Id: I692bdbc00efb38bb29d7f5c18ca042bc10eeb11f
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Bug 868 - Continuous: remove deprecated APIs

* removed deprecated API from Bug3595Test

Change-Id: Ic8f987aeb000cfb150286ad44e478771e8a52384
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
(cherry picked from commit e1b79358817f1202c50f7410b92746b0777d0642)

Bug 2358 - Remove tests cnsn to json and add tests nn to json

Tests of codecs are included in codecs yangtools yang-data-codec-gson and yang-data-impl but
we test codec on input data and also with presentation of Rest path.

* add test NnToJsonLeafrefType to nn/to/json/test
  * positive tests of leafref
    * absolut path
    * relative path
    * leafref to not leaf
    * from leaflist to leaf
    * from leafref to leafref
  * negative tests of leafref
    * non existing Leaf

Change-Id: I652204071d874d6c7a2a65e100dd68c16a12af8f
Signed-off-by: Jakub Toth <jatoth@cisco.com>
(cherry picked from commit 1f4b4062cbdd0cfadcf61e60bce9ee9e951c975c)

Bug 2358 - Remove tests cnsn to json and add tests nn to json

Tests of codecs are included in codecs yangtools yang-data-codec-gson and yang-data-impl but
we test codec on input data and also with presentation of Rest path.

* remove CnSnJsonChoiceCaseTest test
* add NnJsonChoiceCaseTest to nn/to/json/test/
  * positive and negative tests for choice statement

Change-Id: I83d351bf0de9bb4a1c649c5851209ae472aaaa24
Signed-off-by: Jakub Toth <jatoth@cisco.com>
(cherry picked from commit 33657892ea175d459184732b0fbc08eb7589e787)