Martin Bobak [Mon, 30 Mar 2015 14:41:04 +0000 (16:41 +0200)]
unifying statistics manager api packages
Change-Id: I29b495fd26c45ce50e73b96c9d23380eeb09f4c1
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Michal Rehak [Fri, 27 Mar 2015 18:43:14 +0000 (19:43 +0100)]
Fixed (de)serialization issue
- fixed: TunnelIdValue -> TunIdValue (model misuse)
- fixed: removed masks from setField (SetDlSrc, SetDlDst)
Change-Id: I96e4f9e3eda0cb26b455f68c9453441e07133c3a
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
michal rehak [Fri, 27 Mar 2015 14:05:41 +0000 (14:05 +0000)]
Merge "Feature/Bug#2774: Decrease verbosity of flow hash duplicate."
michal rehak [Fri, 27 Mar 2015 13:50:19 +0000 (13:50 +0000)]
Merge "added yang file describing openflowplugin-impl as CoSS module"
Keith Burns (alagalah) [Wed, 18 Mar 2015 04:37:04 +0000 (21:37 -0700)]
Feature/Bug#2774: Decrease verbosity of flow hash duplicate.
Patch set 3: Add more info on code path when debug is enabled.
Change-Id: Ifd722e7e427c1ebca53636d371dcf6187911b95b
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
michal rehak [Fri, 27 Mar 2015 13:18:53 +0000 (13:18 +0000)]
Merge "separation of api and impl - crated openflowplugin types yang"
Martin Bobak [Fri, 27 Mar 2015 11:29:44 +0000 (12:29 +0100)]
added yang file describing openflowplugin-impl as CoSS module
Change-Id: I0ed0158e4815516e9255301c89f9bf31f460e82a
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Fri, 27 Mar 2015 11:55:59 +0000 (12:55 +0100)]
separation of api and impl - crated openflowplugin types yang
Change-Id: Iebcd7659a9d76d53c2dada234d0f8d466da87281
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Timotej Kubas [Fri, 27 Mar 2015 09:26:53 +0000 (10:26 +0100)]
Implemented DeviceContext.hookRequest and DeviceContext.processReply
Change-Id: I7f440dd8623f051e071e923636c7d3d3835d9f14
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
Jozef Gloncak [Fri, 27 Mar 2015 09:27:37 +0000 (10:27 +0100)]
Added type parameteris.
Class type parameter was added to all classes in this change.
Change-Id: I7cd27edef23b7b52bcc2d32d42f7feac3e7a9b4c
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Martin Bobak [Fri, 27 Mar 2015 08:36:32 +0000 (09:36 +0100)]
Statistics services implementation and cleanup
Change-Id: I550fb3666d021283c283398c07a95d12330c6eb3
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Jozef Gloncak [Thu, 26 Mar 2015 15:10:02 +0000 (16:10 +0100)]
Implementation of services Sal*Service and PacketProcessing
Implementation of:
- SalFlowService
- SalGroupService
- SalMeterService
- SalPortService
- SalTableService
- PacketProcessingService
Picking common functionality to ServiceCallProcessingUtil.
Change-Id: I071280e2d5cab7ea201c8ea829f89ca4a300b178
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Martin Bobak [Thu, 26 Mar 2015 15:38:46 +0000 (16:38 +0100)]
implementation of GroupStatisticsService
Change-Id: Idb7ce9a185ae88a3216ead053d487034d7ed541b
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Thu, 26 Mar 2015 14:26:51 +0000 (15:26 +0100)]
implementation of FlowStatisticsService and FlowTableStatisticsService
- introduced RequestInputUtils
Change-Id: I71490ef9e65039b0c8d3d41357af7227d155508e
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Thu, 26 Mar 2015 14:07:26 +0000 (15:07 +0100)]
implementation of FlowStatisticsServiceImpl
Change-Id: Icde601bd22d662de777304b3feba5177e5268d3b
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Thu, 26 Mar 2015 09:03:21 +0000 (10:03 +0100)]
implementation of NodeConfigService
- introduced RpcResultConvertor for converting OFJava future to requestContext's future
- RpcResultConvertor used in SalFlowServiceImpl
Change-Id: I11dc0e6f15920dab3323128749a877532a0486f8
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Thu, 26 Mar 2015 09:14:58 +0000 (10:14 +0100)]
auxiliary connections stored in DeviceContext
Change-Id: I41ccc99e797cb0419d9d4655998573478af79551
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Wed, 25 Mar 2015 10:19:09 +0000 (11:19 +0100)]
SalFlowServiceImpl - implementing methods
Contains pattern implementation (service call + handling of exceptional states)
for all ramaining services.
Change-Id: Ic7a4b16bd79347e63b742ea7ec393f36ba01a6e6
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Wed, 25 Mar 2015 16:01:29 +0000 (17:01 +0100)]
Implementation of services
Change-Id: I408a6360ffd31d2b04682ee1bc47c60a58f1df93
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Thu, 26 Mar 2015 09:01:25 +0000 (10:01 +0100)]
Static methods on XidGenerator changed to non-static
Change-Id: I9d626793db7158a88eb287f3a180422271679167
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Wed, 25 Mar 2015 10:37:24 +0000 (11:37 +0100)]
creation of settable future extracted to separate interface
- creation of settable future was extracted from RequestContext
to separate interface RequestFutureContext
Change-Id: I9ff7f7a074f33f8e8863f63362c933ec47dac89d
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 24 Mar 2015 12:03:50 +0000 (13:03 +0100)]
RpcContext and RequestContext implementation
- implementation used in SalFlowServiceImpl
Change-Id: I3b000526d9a1102464ca5ab8b81af00e5f98f2bb
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 24 Mar 2015 12:25:06 +0000 (13:25 +0100)]
XID holds only long value doesn't generate new values
Change-Id: Ia1ee8c8510840f1fdf33b7d52ec0c38147a70c40
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 24 Mar 2015 13:57:58 +0000 (14:57 +0100)]
API changes in RequestCtx and DeviceCtx
Change-Id: Id671b7782cdc2133b3c108416fa8d7def03d3670
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Wed, 25 Mar 2015 15:16:20 +0000 (16:16 +0100)]
Implementation of Rpc interfaces
Implementation classes were created for interfaces RequestContext, RpcContext, RpcManager.
MdSalRegistrationUtils class for registration of services
Change-Id: I8f1f7e7342e04f94f74f7900eeaede3515b37f73
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 24 Mar 2015 12:03:50 +0000 (13:03 +0100)]
RequestContext implementation
Change-Id: I566ff0168e061d15271d931fda61e0b193b74139
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 24 Mar 2015 12:01:24 +0000 (13:01 +0100)]
RpcContext and RequestContext API fine tuning
Change-Id: Ib9ffa744b2b0e483ced2dbe07cf5fb6dd439b5cb
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 24 Mar 2015 10:57:10 +0000 (11:57 +0100)]
evolved API
- device context offers primary and auxiliary connection contexts
- RpcContext and RequestContext offers generic way of invoking rpc call
Change-Id: Icafafdb7c64e5c43a0d4675ee360e177d8f0d69e
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 24 Mar 2015 09:57:44 +0000 (10:57 +0100)]
package naming cleanup
Change-Id: I4dfd1d0a09260220ff56c23cf57a72da1b7b46f2
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Mon, 23 Mar 2015 06:43:32 +0000 (07:43 +0100)]
Rpc
adding RpcContextImpl and RpcManagerImpl
Change-Id: I57ba3d71f3b3bddcf40b6527fe76b34d97eb376e
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Mon, 23 Mar 2015 15:11:45 +0000 (16:11 +0100)]
Refined Request Context and RpcContext API
- addRequest method moved from RequestContext to RpcContext
- returning value of addNewRequest was changed to Future
- request quota counter moved to RpcContext
- removed setter for deviceContext from RequestContext
Change-Id: I87c99b584622a58284f96acc2171ce87946ce704
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 24 Mar 2015 16:18:39 +0000 (17:18 +0100)]
MultiMsgCollector for Multipart response messaging
Note: OF device could return Multipart msg response for a requests.
So we would like to have one-to-one contract for request-to-CollectionResponse
and we will able to identify differences between actualState and
a future state.
* MultiMsgCollector interface - a definition
* MultiMsgCollectorImpl class - implementation of definition with
internal Cache for collecting MultipartResponseMessages
* MultiMsgCollectorImplTest - test suite for testing basic
functionality
Change-Id: I920e2ee69929ed874304116da6711ab3f2dfb159
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 24 Mar 2015 13:26:21 +0000 (14:26 +0100)]
DeviceContext proposal
- initial test
Change-Id: I21c7d49bc2ac6a41fbdef2c7f994195a7141cee0
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 24 Mar 2015 13:14:07 +0000 (14:14 +0100)]
ConnectionManager proposal
- created impl for new proposal
- connection manager and friends
- timeout in test
Change-Id: Ice0f4b4655be5c933d429cd9b74898a4fd326fe6
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Wed, 25 Mar 2015 23:36:25 +0000 (00:36 +0100)]
fix log loop
- set scope of all slf4j-log4j12 dependencies to test in order not to
mix up feature tests where log4j-over-sl4j is active
Change-Id: I51d47e9884d328d6bef528e0ce655e10fe8269b8
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Michal Rehak [Wed, 4 Mar 2015 10:24:33 +0000 (11:24 +0100)]
External api proposal
- barrier renamed, cleaned
- flow-basic cleanup: port, queue
- added external API description
- worked in API cleanup changes
- flow-statistics cleaned
- added echo rpc
Change-Id: Ibb8fd26909001c8a0c9e5690f9f182f39c78c9d9
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Timotej Kubas [Tue, 17 Mar 2015 15:23:18 +0000 (16:23 +0100)]
BUG-2794: incorporate ofjava instruction changes
- https://git.opendaylight.org/gerrit/#/c/16039/3
Change-Id: I3a8dd0b9666a91ba438bbced8e2c9e45aeb2a59e
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
Timotej Kubas [Thu, 12 Mar 2015 15:20:44 +0000 (16:20 +0100)]
BUG-2794: Incorporated model Action api changes in OFJava to openflowplugin
- incorporated model changes from OFJava
- https://git.opendaylight.org/gerrit/#/c/15932
Change-Id: I199b1f39c172652a82806879e135652fb9a7e06d
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
Timotej Kubas [Tue, 17 Mar 2015 15:22:26 +0000 (16:22 +0100)]
BUG-2794: incorporate openflowjava api changes to openflowplugin
- rebased
Change-Id: I92f8ad211859c5f03c388fa1a32f28484b63efd1
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Robert Varga [Sun, 22 Mar 2015 14:19:09 +0000 (15:19 +0100)]
Use BigInteger.valueOf()
This is faster than parsing a string.
Change-Id: I7dc07dcf97fbb99ec2c6f5696048054e3c45d346
Signed-off-by: Robert Varga <rovarga@cisco.com>
Michal Rehak [Tue, 24 Mar 2015 14:50:18 +0000 (14:50 +0000)]
Merge "BUG-837: it unstable (added missing bundles)"
Michal Rehak [Tue, 24 Mar 2015 14:02:56 +0000 (15:02 +0100)]
BUG-837: it unstable (added missing bundles)
- added missing bundles (md-sal impls)
Change-Id: I7f6227ca7781abcdb0e2bf61f4c7c7e9e39a9a84
Signed-off-by: Michal Rehak <mirehak@cisco.com>
michal rehak [Tue, 24 Mar 2015 11:56:45 +0000 (11:56 +0000)]
Merge "Bug 2753 - 4 managers api proposal."
Michal Rehak [Tue, 24 Mar 2015 10:00:26 +0000 (11:00 +0100)]
BUG-837: it unstable (timeout to 60s)
- changed timeout for resolving services to 60s
Change-Id: I8b9796f22cd5bdaef580875c6ff3661b26e99130
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Jozef Gloncak [Mon, 23 Mar 2015 12:31:38 +0000 (13:31 +0100)]
Bug 2753 - 4 managers api proposal.
- proposal for new API manager
- HandshakeManager code cleanup
- added handshakeContext
- minor cleanup in connectionContext
- added features to connectionContext
Change-Id: Iba6b90247c54affa3be326f98f93b00d763b5402
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Michal Rehak [Mon, 23 Mar 2015 19:32:38 +0000 (20:32 +0100)]
BUG-837: it unstable
- added additional timeout for resolving bindingAwareBroker
Change-Id: If838b5d0446303a13c6c7a1fe35dd98c26fda571
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Tony Tkacik [Thu, 19 Mar 2015 13:04:57 +0000 (14:04 +0100)]
Bug 868: Removed test code-duplicated from MD-SAL
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Keith Burns (alagalah) [Wed, 18 Mar 2015 02:58:10 +0000 (19:58 -0700)]
Fix for bug#2861: areObjectsEqual doesn't check if storedMatch==null.
Change-Id: I86b337a6280d044f17bf9f87bdaf1672f3e15673
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
michal rehak [Tue, 17 Mar 2015 14:45:44 +0000 (14:45 +0000)]
Merge "BUG-2608: LLDP packet-out for link learning should use OFP_NO_BUFFER"
Jamo Luhrsen [Tue, 17 Mar 2015 04:53:26 +0000 (21:53 -0700)]
BUG-2608: LLDP packet-out for link learning should use OFP_NO_BUFFER
Signed-off-by: Jamo Luhrsen <james.luhrsen@hp.com>
Jozef Gloncak [Tue, 17 Mar 2015 09:57:38 +0000 (10:57 +0100)]
installation of rest in karaf openflowplugin distribution
Change-Id: I2bceb097ecd7d83977fc2ad3572bef8c2b5b0858
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Martin Bobak [Mon, 1 Dec 2014 13:36:16 +0000 (14:36 +0100)]
Bug-2827: role switch proposal
- stub for entry point where propagation of role change should start
- logic for pushing role to device with failover
- added tests
- role change logic wired to openflowpluginprovider
(change can by invoked via configsubsystem)
- added max retry limit
- comments worked in
- rebased
- comments worked in (whitespace, 1 method rename)
- worked-in configSubsystem change
Change-Id: I942d4b0e297543324c5fa0495f078834bee44899
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Michal Rehak [Fri, 13 Mar 2015 13:33:55 +0000 (14:33 +0100)]
Fix of port-number model
- reason: default union builder changed name (caused by generators change)
(avoiding anonymous inner type is safer way)
- fix:
- promoted port-number inner type to typedef
- renamed type in order to avoid name collisions (with leaf name and inet type)
Change-Id: I30b0532b5c74d52aa74b334e5f6d017cc116915f
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Fri, 31 Oct 2014 13:37:21 +0000 (14:37 +0100)]
BUG-2315: Remove dependency to OFJava-impl
- removed ofjava-impl deps (except distributions)
Change-Id: I75d4ef4e64b134322b9e7dae8d9b79ca4bba5c7f
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Ed Warnicke [Thu, 12 Mar 2015 21:37:24 +0000 (21:37 +0000)]
Revert "Bug-2827: role switch proposal"
This seems to be causing an NPE:
https://bugs.opendaylight.org/show_bug.cgi?id=2827#c2
Reverting to unblock downstream.
This reverts commit
9dd9664db32bd7fa972bd414fb4e02ec83ad8e83.
This reverts gerrithttps://git.opendaylight.org/gerrit/#/c/12644/
Change-Id: Iad8f2d5c840b203a04fa67d2be999bc74fc13d18
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Martin Bobak [Mon, 1 Dec 2014 13:36:16 +0000 (14:36 +0100)]
Bug-2827: role switch proposal
- stub for entry point where propagation of role change should start
- logic for pushing role to device with failover
- added tests
- role change logic wired to openflowpluginprovider
(change can by invoked via configsubsystem)
- added max retry limit
- comments worked in
- rebased
- comments worked in (whitespace, 1 method rename)
Change-Id: I6f43401821310c22a1b8b42c280e67f01ec9ed8f
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Thu, 12 Mar 2015 13:06:39 +0000 (14:06 +0100)]
squashed test fix
- remove import of non existing ForwardedBackwardsCompatibleDataBroker
- fixed broken integration tests
Change-Id: Ia896dc5391624f4571f043abaf372536393e8751
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
michal rehak [Mon, 9 Mar 2015 09:30:24 +0000 (09:30 +0000)]
Merge "BUG-2382: OutputActionBuilder.setOutputNodeConnector"
michal rehak [Mon, 9 Mar 2015 08:49:39 +0000 (08:49 +0000)]
Merge "BUG 2757 - %s in logger."
michal rehak [Mon, 9 Mar 2015 08:44:25 +0000 (08:44 +0000)]
Merge "BUG 2750 - remove of migrated class"
michal rehak [Mon, 9 Mar 2015 08:40:23 +0000 (08:40 +0000)]
Merge "BUG-2661: Sonar issues for ofp-extension-api"
Jozef Gloncak [Thu, 5 Mar 2015 07:04:49 +0000 (08:04 +0100)]
BUG 2757 - %s in logger.
%s was added to logger by mistake.
Change-Id: Iff37fcbba2508a8f15635d6cea4bc116da457a85
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Fri, 27 Feb 2015 09:34:55 +0000 (10:34 +0100)]
BUG 2750 - remove of migrated class
REMARK:
can be merged after patch https://git.opendaylight.org/gerrit/#/c/15660/ (movement of functionality) will be merged.
Change-Id: Ibce31fe57ec53ffa566dcbad81706060c7c4a3a0
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Michal Rehak [Fri, 6 Mar 2015 15:24:51 +0000 (16:24 +0100)]
Removal of obsolete distributions
- distribution/base and distribution/cbench were based
on controller's distribution/opendaylight which is already
history.
Change-Id: Ia0df26094961d9b9f37268b56fea25ccbdac417e
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Timotej Kubas [Fri, 27 Feb 2015 12:57:10 +0000 (13:57 +0100)]
BUG-2382: OutputActionBuilder.setOutputNodeConnector
- use of OutputActionBuilder.setOutputNodeConnector in openflowplugin changed
to proper form
Change-Id: I930aba68293a7498d0b2be61bf9a2c155637427a
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
Jozef Gloncak [Thu, 5 Mar 2015 12:55:18 +0000 (13:55 +0100)]
BUG 2757 - repeating logging of warning.
Fixes repeating logging of warnings - "flow hashing hit a duplicate for"
Change-Id: I810def7f5c181ac962a18ec1544d2c6b2257ed35
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
michal rehak [Thu, 5 Mar 2015 13:53:50 +0000 (13:53 +0000)]
Merge "BUG 2661 - sonar issues in openflowplugin artifact - anonymous class2."
michal rehak [Thu, 5 Mar 2015 13:53:45 +0000 (13:53 +0000)]
Merge "BUG 2661 - sonar issues in openflowplugin artifact - anonymous class."
Jozef Gloncak [Thu, 5 Mar 2015 13:23:47 +0000 (14:23 +0100)]
BUG 2661 - sonar issues in openflowplugin artifact - anonymous class2.
Annonymous class was replaced with named inner class.
REMARK: it is possible that this commit will be reverted.
Change-Id: I57dc5f5e67497168b55e8b9da2d6eb49450303b8
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Thu, 5 Mar 2015 13:19:31 +0000 (14:19 +0100)]
BUG 2661 - sonar issues in openflowplugin artifact - anonymous class.
Annonymous class was replaced with named inner class.
REMARK: it is possible that this commit will be reverted.
Change-Id: Ice30fbe21ae160ec6b1004644d1c1397ac0bec56
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Fri, 20 Feb 2015 13:20:37 +0000 (14:20 +0100)]
BUG 2661 - sonar issues in openflowplugin artifact2
Some of sonar issues in openflowplugin artifact in package org.opendaylight.openflowplugin.openflow.md.core were solved.
Change-Id: Id2731f16cd5c026245cd6c3894dc1ca90b13c787
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Mon, 16 Feb 2015 11:44:56 +0000 (12:44 +0100)]
BUG 2661 - sonar issues in statistics-manager
Fixing mistakes in
bd6bb42d1998d417581c5ffc28812ad3d9386320.
Breake FlowComparator class to:
- MatchComparatorFactory
- MatchComparatorFactory
- SimpleComparator
- FlowComparatorHelper
- FlowComparator
Adding unit tests which cover new static methods created during breakage mentioned above.
Change-Id: I42aa8c1cc8bd88deef0d0591551508df7ad40e7a
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Michal Rehak [Mon, 2 Mar 2015 17:31:19 +0000 (18:31 +0100)]
BUG-2776: Mac Address masks in FlowRemovedTranslaton fails
- replaced local join code with guava's BaseEncoding implementation
Change-Id: Iabb0b9b3820a92b922115f82763939457a10ea30
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Mon, 2 Mar 2015 12:39:38 +0000 (13:39 +0100)]
Use odlparent:features-test instead of yangtools:features-test.
- forgotten reference in surefire plugin configuration
Change-Id: Idb6144ea7dcb2f70c184c9cce7a1d6a598de529e
Signed-off-by: Michal Rehak <mirehak@cisco.com>
michal rehak [Mon, 2 Mar 2015 12:27:14 +0000 (12:27 +0000)]
Merge "BUG 2754 - unit test cover for FlowComparator.StrIpToIntIp()"
Jozef Gloncak [Tue, 24 Feb 2015 13:00:56 +0000 (14:00 +0100)]
Bug 2750 - migrate drop-test to drop-test-karaf.
Move methods _showDropStats(....) and _clearDropStats(....) from drop-test artifact to drop-test-karaf artifact.
Change-Id: Iaaa5cab7fd6f3774784a0121c7a98bbe3dbdfaae
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Wed, 25 Feb 2015 09:17:38 +0000 (10:17 +0100)]
BUG 2754 - unit test cover for FlowComparator.StrIpToIntIp()
Cover FlowComparator.StrIpToIntIp() method with direct unit test in statistics-manager artifact.
Change-Id: I7b603fc036cfb89c41cf7e5533d2832c368c82c9
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
michal rehak [Fri, 27 Feb 2015 13:24:37 +0000 (13:24 +0000)]
Merge "Bug 2753 : interface HandshakeManager moved to openflow-api"
Martin Bobak [Thu, 26 Feb 2015 10:06:58 +0000 (11:06 +0100)]
Bug 2753 : interface HandshakeManager moved to openflow-api
Change-Id: Ib7274bf53477435ac8b0c7b43e6fbc0be757c7b0
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Timotej Kubas [Mon, 23 Feb 2015 15:10:46 +0000 (16:10 +0100)]
BUG 2661: Sonar issues for drop-test
- solving some technical debts in drop-test artifact
Change-Id: I3d6e42be72b9454b2f952b801d52938ef013fa69
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
michal rehak [Fri, 27 Feb 2015 09:23:48 +0000 (09:23 +0000)]
Merge "Bug 2661 - method name should start with lower case letter"
michal rehak [Thu, 26 Feb 2015 13:34:52 +0000 (13:34 +0000)]
Merge "BUG-1563 added default mac address and mac address for non-OF infrastructure to config"
ary [Wed, 25 Feb 2015 13:41:35 +0000 (14:41 +0100)]
BUG-1563 added default mac address and mac address for non-OF infrastructure to config
Signed-off-by: ary <jatoth@cisco.com>
Change-Id: I7872fb2801f88ce06db6240c1000eab89a7f4efe
Michal Rehak [Wed, 25 Feb 2015 14:07:48 +0000 (15:07 +0100)]
Use odlparent:features-test instead of yangtools:features-test.
Change-Id: I8c6471cd980393e0f679ad007e521164c3a0cd41
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Timotej Kubas [Tue, 24 Feb 2015 13:45:42 +0000 (14:45 +0100)]
BUG-2661: Sonar issues for ofp-extension-api
- some technical debts in artifact ofp-extension-api solved
Change-Id: I356bbf05b813d146d9e06afcd28cec82dd8a762b
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
Jozef Gloncak [Mon, 16 Feb 2015 11:44:56 +0000 (12:44 +0100)]
BUG 2661 - sonar issues in statistics-manager
Removed some of sonar issues from statistics-manager artifact.
Change-Id: Ia69a3f37d0be625fc9003834dc25fc8a916816a0
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Mon, 2 Feb 2015 12:05:09 +0000 (13:05 +0100)]
Bug 2661 - method name should start with lower case letter
Method names started with underscore
Change-Id: I650bc9b11b280a62bad270c30c681ce3c59483e9
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
michal rehak [Tue, 24 Feb 2015 12:04:28 +0000 (12:04 +0000)]
Merge "BUG 2661 - sonar issues in openflowplugin-api"
Jozef Gloncak [Thu, 19 Feb 2015 07:50:35 +0000 (08:50 +0100)]
BUG 2661 - sonar issues in openflowplugin artifact.
Some of sonar issues in openflowplugin artifact in package
src.main.java.org.opendaylight.openflowplugin.openflow.md.core.sal.convertor
were solved
Change-Id: Ic795acae9159a7b67945f2db6d89b7918361b0ba
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Tue, 17 Feb 2015 12:38:37 +0000 (13:38 +0100)]
BUG 2661 - sonar issues in openflowplugin-api
Some of sonar issues in openflowplugin-api artifact
Change-Id: I8f4c04b6c5e1937e48986d40dda49c2a3544a2e1
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Michal Rehak [Mon, 23 Feb 2015 21:49:32 +0000 (22:49 +0100)]
BUG-837: IT fix
- increased wait after handshake
Change-Id: I079d9798c42b15e76b95c440b5cbccb827fd49bd
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Fri, 23 Jan 2015 19:50:01 +0000 (20:50 +0100)]
BUG-2637: Create features for migrated apps
- created features
- replaced old md-sal flow* models
- this change depends on disabling of apps and models in their
old place in md-sal
- fixed outdated dirty dependencies of features
- added sal-compatibility
- rebased
- redirected features and IT to local models
see controller: https://git.opendaylight.org/gerrit/#/c/14464/
Change-Id: I6d7d4f1461bc7200e31736462a284ff94ed3b8f6
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Ed Warnicke [Sat, 21 Feb 2015 16:53:09 +0000 (09:53 -0700)]
Re-enable running of SingleFeaturesTest
For reasons I have not yet figured out, depending on the
yangtools version of features-test causes features tests
to no longer run. This patch changes controller
to depending on the features-tests from odlparent
Change-Id: I70d6a8ea24d9b0546d9f9e94b65a0008f8a05708
Signed-off-by: Ed Warnicke <eaw@cisco.com>
michal rehak [Wed, 18 Feb 2015 15:26:35 +0000 (15:26 +0000)]
Merge "Remove repository and pluginRepository sections"
Jozef Gloncak [Wed, 18 Feb 2015 07:24:35 +0000 (08:24 +0100)]
BUG 2661 - sonar issues in learning-switch
Some of sonar issues in learning-switch artifact were solved.
Change-Id: I423136cb503c8d9922eb7064ab2bd3eddd24d411
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
ary [Thu, 12 Feb 2015 12:54:24 +0000 (13:54 +0100)]
bug 2446 - High priority (control) queue stop reading from channel if is full
this patch depends on https://git.opendaylight.org/gerrit/#/c/14438/
Signed-off-by: ary <jatoth@cisco.com>
Change-Id: Ie990b1987d2210ec520648e081bb250588f4f342
Robert Varga [Fri, 13 Feb 2015 20:41:07 +0000 (21:41 +0100)]
Remove repository and pluginRepository sections
These sections have been moved to settings.xml, no need to carry them
here.
Change-Id: Idf669790957f7b9488f8e09c0c79bf56baa22f37
Signed-off-by: Robert Varga <rovarga@cisco.com>
michal rehak [Fri, 13 Feb 2015 17:13:43 +0000 (17:13 +0000)]
Merge "BUG-2661: Sonar issue"
michal rehak [Fri, 13 Feb 2015 17:13:18 +0000 (17:13 +0000)]
Merge "BUG 2661 - sonar issues in test-common artifact"
michal rehak [Fri, 13 Feb 2015 16:54:14 +0000 (16:54 +0000)]
Merge "BUG-2661:Sonar issue"
Code Review / openflowplugin.git / log