openflowplugin.git
9 years agoBUG 2661 - sonar issues in learning-switch 54/15454/2
Jozef Gloncak [Wed, 18 Feb 2015 07:24:35 +0000 (08:24 +0100)]
BUG 2661 - sonar issues in learning-switch

Some of sonar issues in learning-switch artifact were solved.

Change-Id: I423136cb503c8d9922eb7064ab2bd3eddd24d411
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agobug 2446 - High priority (control) queue stop reading from channel if is full 95/15195/4
ary [Thu, 12 Feb 2015 12:54:24 +0000 (13:54 +0100)]
bug 2446 - High priority (control) queue stop reading from channel if is full

this patch depends on https://git.opendaylight.org/gerrit/#/c/14438/

Signed-off-by: ary <jatoth@cisco.com>
Change-Id: Ie990b1987d2210ec520648e081bb250588f4f342

9 years agoMerge "BUG-2661: Sonar issue"
michal rehak [Fri, 13 Feb 2015 17:13:43 +0000 (17:13 +0000)]
Merge "BUG-2661: Sonar issue"

9 years agoMerge "BUG 2661 - sonar issues in test-common artifact"
michal rehak [Fri, 13 Feb 2015 17:13:18 +0000 (17:13 +0000)]
Merge "BUG 2661 - sonar issues in test-common artifact"

9 years agoMerge "BUG-2661:Sonar issue"
michal rehak [Fri, 13 Feb 2015 16:54:14 +0000 (16:54 +0000)]
Merge "BUG-2661:Sonar issue"

9 years agoMerge "BUG-2706: Processing of messages from device starts too late"
michal rehak [Fri, 13 Feb 2015 16:53:45 +0000 (16:53 +0000)]
Merge "BUG-2706: Processing of messages from device starts too late"

9 years agoBUG 2661 - sonar issues in test-common artifact 80/14680/3
Jozef Gloncak [Mon, 2 Feb 2015 13:33:11 +0000 (14:33 +0100)]
BUG 2661 - sonar issues in test-common artifact

 - fixed atomic field updaters

Change-Id: Icdab410e12db4d1571e3d822dd9a796e0bcc5ff1
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoMerge "Remove ganymed dependency"
michal rehak [Fri, 13 Feb 2015 16:48:09 +0000 (16:48 +0000)]
Merge "Remove ganymed dependency"

9 years agoMerge "Remove unused version declarations"
michal rehak [Fri, 13 Feb 2015 16:48:00 +0000 (16:48 +0000)]
Merge "Remove unused version declarations"

9 years agoMerge "BUG-837: IT unstable"
Anil Vishnoi [Fri, 13 Feb 2015 16:25:05 +0000 (16:25 +0000)]
Merge "BUG-837: IT unstable"

9 years agoBug 2661 - printStackTrace() method call 73/14673/3
Jozef Gloncak [Mon, 2 Feb 2015 10:06:48 +0000 (11:06 +0100)]
Bug 2661 - printStackTrace() method call

Critical bug from sonar - printStackTrace() used. It was replaced with logger.

Change-Id: Id9aeb13c39f3cc659e267b472ca3886f7794e5fd
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoMerge "BUG 2280 - mac address mask translation."
michal rehak [Fri, 13 Feb 2015 15:00:04 +0000 (15:00 +0000)]
Merge "BUG 2280 - mac address mask translation."

9 years agoBUG-2661: Sonar issue 03/15203/1
Timotej Kubas [Thu, 12 Feb 2015 15:34:48 +0000 (16:34 +0100)]
BUG-2661: Sonar issue

- solving technical depth

Change-Id: Ic9b92f38d4aa52f091c84648da009e482b3eb101
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
9 years agoBUG-2661:Sonar issue 02/15202/1
Timotej Kubas [Thu, 12 Feb 2015 14:42:40 +0000 (15:42 +0100)]
BUG-2661:Sonar issue

- introducing integration test for flow as a preparation for reducing complexity
  of test-provider

Change-Id: Ic87a91697f55dbd461517de4c79ff9fb11bc254a
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
9 years agoBUG-2706: Processing of messages from device starts too late 98/15198/1
Timotej Kubas [Thu, 12 Feb 2015 12:32:00 +0000 (13:32 +0100)]
BUG-2706: Processing of messages from device starts too late

Change-Id: I60a1f70db1bfaa00d69a0b40965d8c7f5f730e88
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
9 years agoRemove ganymed dependency 57/15057/1
Robert Varga [Mon, 9 Feb 2015 10:23:32 +0000 (11:23 +0100)]
Remove ganymed dependency

Ganymed is no longer used in Helium, so remove it from dependency tree.

Change-Id: I6b35d5e72c21b91bb71ba8f0dc2cba21cbec09b0
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoRemove unused version declarations 07/14907/1
Robert Varga [Thu, 5 Feb 2015 10:00:04 +0000 (11:00 +0100)]
Remove unused version declarations

These versions are not referenced anywhere -- remove them.

Change-Id: Ic6616bb2b7efde2eefbdd3c9c60cb2f43785c85f
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-2665: jacoco configuration 76/14776/2
Michal Rehak [Tue, 3 Feb 2015 12:27:16 +0000 (13:27 +0100)]
BUG-2665: jacoco configuration

 - removed experimental excludes
 - added global include configuration covering all packages from
   org.opendaylight.openflowplugin.*

Change-Id: Ic19d74766eebbedd963be40289f008e89c8b4be6
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBUG-837: IT unstable 18/13618/2
Michal Rehak [Sun, 14 Dec 2014 09:27:46 +0000 (10:27 +0100)]
BUG-837: IT unstable

  - fixed threading and waiting for scenario execution
  - pulled simulator logic into common assistant class

Change-Id: Ic3373607033700179ed4a6097bd95c541e7c62f1
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoMerge "DO-NOT-MERGE-YET: Port description is not getting udpated when port removed...
Abhijit Kumbhare [Mon, 2 Feb 2015 13:09:40 +0000 (13:09 +0000)]
Merge "DO-NOT-MERGE-YET: Port description is not getting udpated when port removed from openflow switch"

9 years agoBug 2245 - OFJava corresponding change (package cycles decreased) 33/14633/2
Martin Uhlir [Fri, 30 Jan 2015 13:45:36 +0000 (14:45 +0100)]
Bug 2245 - OFJava corresponding change (package cycles decreased)

DO NOT MERGE UNTIL: https://git.opendaylight.org/gerrit/#/c/12321/ is merged
- decrease packages cycles

Change-Id: Ie9df1338e9ca77f085d002956f2aed716fea578a
Signed-off-by: Martin Uhlir <martin.uhlir@pantheon.sk>
9 years agoMerge "Bug 2245 - OFJava corresponding change (Sonar technical debt)"
michal rehak [Mon, 2 Feb 2015 09:59:20 +0000 (09:59 +0000)]
Merge "Bug 2245 - OFJava corresponding change (Sonar technical debt)"

9 years agoDO-NOT-MERGE-YET: Port description is not getting udpated when port removed from... 71/14671/1
Anil Vishnoi [Mon, 2 Feb 2015 08:26:40 +0000 (00:26 -0800)]
DO-NOT-MERGE-YET: Port description is not getting udpated when port removed from openflow switch

If user removed port from openflow switch, it generated port status message with reason - DELETE
But this message is not properly hooked to onNodeUpdateRemoved notification defined in inventory
models. This patch fixes the issue.

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
9 years ago BUG-2636: Wire sal-compatibility to local models 40/14640/1
Michal Rehak [Fri, 30 Jan 2015 17:44:17 +0000 (18:44 +0100)]
 BUG-2636: Wire sal-compatibility to local models

     - changed model version to match ofplugin
     - switched to local models
     - used temporary profile with dependencyManagement
       for migrated apps
     - temporary dependencyManagement moved to root pom

Change-Id: I7509dbe0718aaf38681cdc6ef3d3b6322b5eb1ff
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBUG-2659: Changes package names to ofPlugin naming strucuture 31/14631/2
Timotej Kubas [Thu, 29 Jan 2015 15:53:20 +0000 (16:53 +0100)]
BUG-2659: Changes package names to ofPlugin naming strucuture

Change-Id: I43a5b6b11b0e31fa7506f30c633bb7cd55622629
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
9 years agoBUG-2613: Migrating sal-compatibility from controller project to openflowplugin 30/14630/2
Timotej Kubas [Thu, 29 Jan 2015 15:45:03 +0000 (16:45 +0100)]
BUG-2613: Migrating sal-compatibility from controller project to openflowplugin
          project

Following changes are done:
    *.* Moved all the bundle to openflowplugin/legacy directory
    *.* Fixed all the relavent pom files to successfully build the projects
    *.* Did not change bundle version of any of the project, just to avoid breaking any dependent project
    *.* Instead changed the bundle version in application pom.xml to 1.2.0 from 0.1.0, because all the
    dependenct child project is offset two bundles.
    Todo:
    *.* Change the package name of models and source code according to new location
    *.* Adapt downstream project in order to use these model projects
    *.* remove models from controller repository

    As of now all the bundles moved to openflowplugin contains all the commit that is pushed till
    following commit
    $ git log -1
    commit 6340a32c44b6a423d52fd98ce3c66bc480ab9246
    Merge: 94d7e66 4c90ff7
    Author: Tony Tkacik <ttkacik@cisco.com>
    Date:   Fri Jan 16 12:50:26 2015 +0000

        Merge "Fixed missing dependencies in netconf-netty-util."

Change-Id: I7e99e324d64cde29e01832c265341abd23ceb53e
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBug 2245 - OFJava corresponding change (Sonar technical debt) 67/14567/1
Martin Uhlir [Wed, 28 Jan 2015 14:07:35 +0000 (15:07 +0100)]
Bug 2245 - OFJava corresponding change (Sonar technical debt)

DO NOT MERGE UNTIL: https://git.opendaylight.org/gerrit/#/c/14496/ is merged
- Synchronized Stack data structure replaced by unsynchornized Deque

Change-Id: Idaf3e9f563d5a569aca6a2ec73cbe0dbd773cc72
Signed-off-by: Martin Uhlir <martin.uhlir@pantheon.sk>
9 years agoBUG 2280 - mac address mask translation. 45/14545/2
Jozef Gloncak [Tue, 27 Jan 2015 16:32:38 +0000 (17:32 +0100)]
BUG 2280 - mac address mask translation.

Added ODL to SAL mac addres mask translation.

Change-Id: I6288e5dfa4b9fe77b98f39549e95b9e56e944ab1
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoMerge "BUG-2363: Wire NSF apps to local models"
Anil Vishnoi [Tue, 27 Jan 2015 17:51:37 +0000 (17:51 +0000)]
Merge "BUG-2363: Wire NSF apps to local models"

9 years agoMerge "BUG 2281 - Incorrect IP address conversion"
michal rehak [Tue, 27 Jan 2015 17:19:47 +0000 (17:19 +0000)]
Merge "BUG 2281 - Incorrect IP address conversion"

9 years agoBUG 2281 - Incorrect IP address conversion 43/14543/1
Jozef Gloncak [Tue, 27 Jan 2015 14:28:17 +0000 (15:28 +0100)]
BUG 2281 - Incorrect IP address conversion

It looks like reported problem (do not cut the ip mask off) was fixed. Test is passing after uncommenting commented parts.

Change-Id: If81e4f675ac2bae25d57a18a14cf3e3802faecea
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoBUG 2280 - mask check in laye3Match. 82/14482/3
Jozef Gloncak [Mon, 26 Jan 2015 13:04:42 +0000 (14:04 +0100)]
BUG 2280 - mask check in laye3Match.

Only commented part of testing code was uncommented.

Change-Id: I2eb90e91d5bf1eeb52b071c2bac9a063e6092ab8
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoBUG-2363: Wire NSF apps to local models 57/14457/3
Michal Rehak [Fri, 23 Jan 2015 17:24:38 +0000 (18:24 +0100)]
BUG-2363: Wire NSF apps to local models

 - changed model version to match ofplugin
 - switched apps to local models
 - introduced temporary profile with dependencyManagement
   for migrated apps

Change-Id: Ia8f43fc3e140cdcd1ef6359772b94a28c2abab63
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBUG-2645: Unit test failing 29/14529/1
Michal Rehak [Mon, 26 Jan 2015 17:45:03 +0000 (18:45 +0100)]
BUG-2645: Unit test failing

 - changed assertEquals to assertArrayEquals

Change-Id: I08a18f216c24e70d1594299481e5778e63b97073
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoMerge "BUG-2621: Change project/package names of migrated statistics-manager"
Anil Vishnoi [Fri, 23 Jan 2015 00:07:37 +0000 (00:07 +0000)]
Merge "BUG-2621: Change project/package names of migrated statistics-manager"

9 years agoMerge "BUG-2622: Change project/package names of migrated inventory-manager"
Anil Vishnoi [Thu, 22 Jan 2015 23:36:37 +0000 (23:36 +0000)]
Merge "BUG-2622: Change project/package names of migrated inventory-manager"

9 years agoBUG-2622: Change project/package names of migrated inventory-manager 97/14397/1
Michal Rehak [Thu, 22 Jan 2015 18:39:39 +0000 (19:39 +0100)]
BUG-2622: Change project/package names of migrated inventory-manager

  - changed package names to ofPlugin naming structure

Change-Id: Ifafe1caf3a81d70cb51fd8b79ed4395fbbdb5c63
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBUG-2621: Change project/package names of migrated statistics-manager 93/14393/1
Michal Rehak [Thu, 22 Jan 2015 17:20:26 +0000 (18:20 +0100)]
BUG-2621: Change project/package names of migrated statistics-manager

  - changed package names to ofPlugin naming structure
  - includes statistics-manager-config

Change-Id: I50b5c0736a9f69789a93f3ba63e5b488db9f88f8
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBUG-2620: Change project/package names of migrated topoogy-manager 83/14383/1
Jozef Gloncak [Thu, 22 Jan 2015 14:58:51 +0000 (15:58 +0100)]
BUG-2620: Change project/package names of migrated topoogy-manager

  - changed package names to ofPlugin naming structure
  - includes topology-lldp-discovery

Change-Id: I2a28616e003ea24042cc64af8dcd2fc31c12bde9
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoBUG-2615: Change project/package names of migrated FRM 79/14379/1
Martin Bobak [Thu, 22 Jan 2015 13:04:44 +0000 (14:04 +0100)]
BUG-2615: Change project/package names of migrated FRM

 - changed package names to ofPlugin naming structure

Change-Id: I2d27816dd1222219b0e8dea4e35dedc1f26e7751
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBUG-2613: Migrating Openflow Specific nsf-apps from controller project to openflowplu... 53/14353/2
Michal Rehak [Wed, 21 Jan 2015 19:05:18 +0000 (20:05 +0100)]
BUG-2613: Migrating Openflow Specific nsf-apps from controller project to openflowplugin project

    Following changes are done:
    *.* Moved all the bundle to openflowplugin/applications directory
    *.* Fixed all the relavent pom files to successfully build the projects

    Also minor cleanup was performed on poms of existing apps (remove duplicates, unifying).

    As of now all the bundles moved to openflowplugin contains all the commit that is pushed till
    following commit
    $ git log -1
    commit 6340a32c44b6a423d52fd98ce3c66bc480ab9246
    Merge: 94d7e66 4c90ff7
    Author: Tony Tkacik <ttkacik@cisco.com>
    Date:   Fri Jan 16 12:50:26 2015 +0000

Change-Id: I600f947e846cc0eadfcb8a9bc33cfc6b70addf4b
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBUG-2613: Migrating Openflow Specific models from controller project to openflowplugi... 44/14344/2
Jozef Gloncak [Wed, 21 Jan 2015 15:57:35 +0000 (16:57 +0100)]
BUG-2613: Migrating Openflow Specific models from controller project to openflowplugin project

    Following changes are done:
    *.* Moved all the bundle to openflowplugin/model directory
    *.* Fixed all the relavent pom files to successfully build the projects
    *.* Did not change bundle version of any of the project, just to avoid breaking any dependent project
    changed model to model-parent under the same group as underlying models

    As of now all the bundles moved to openflowplugin contains all the commit that is pushed till
    following commit
    $ git log -1
    commit 6340a32c44b6a423d52fd98ce3c66bc480ab9246
    Merge: 94d7e66 4c90ff7
    Author: Tony Tkacik <ttkacik@cisco.com>
    Date:   Fri Jan 16 12:50:26 2015 +0000

Change-Id: If689af7878164bf460115d53691bb8dbae490c04
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agobug 2493 - eliminate the use of xtend and remove dependecies 38/13738/3
ary [Wed, 17 Dec 2014 16:19:07 +0000 (11:19 -0500)]
bug 2493 - eliminate the use of xtend and remove dependecies

Signed-off-by: ary <jatoth@cisco.com>
Change-Id: I2b2c49d93daf90c90e024d3af727f87957a8427e

9 years agoMerge "Revert "BUG-2613: Migrating Openflow Specific NSF from controller project...
michal rehak [Wed, 21 Jan 2015 09:39:58 +0000 (09:39 +0000)]
Merge "Revert "BUG-2613: Migrating Openflow Specific NSF from controller project to openflowplugin project""

9 years agoRevert "BUG-2613: Migrating Openflow Specific NSF from controller project to openflow... 23/14323/1
Ed Warnicke [Wed, 21 Jan 2015 08:34:06 +0000 (08:34 +0000)]
Revert "BUG-2613: Migrating Openflow Specific NSF from controller project to openflowplugin project"

This reverts commit 7508539dcab1db1d5476baaf0200a322df7596b6.

Change-Id: I6068036341c51b110674080b2f56eed70916e319
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoMerge "BUG-2613: Migrating Openflow Specific NSF from controller project to openflowp...
michal rehak [Tue, 20 Jan 2015 21:46:02 +0000 (21:46 +0000)]
Merge "BUG-2613: Migrating Openflow Specific NSF from controller project to openflowplugin project"

9 years agoBUG-2613: Migrating Openflow Specific NSF from controller project to openflowplugin... 09/14209/3
Anil Vishnoi [Sun, 28 Dec 2014 17:16:52 +0000 (22:46 +0530)]
BUG-2613: Migrating Openflow Specific NSF from controller project to openflowplugin project

Following changes are done:
*.* Moved all the bundle to openflowplugin/application directory
*.* Fixed all the relavent pom files to successfully build the projects
*.* Did not change bundle version of any of the project, just to avoid breaking any dependent project
*.* Instead changed the bundle version in application pom.xml to 1.2.0 from 0.1.0, because all the
dependenct child project is offset two bundles.
Todo:
*.* Change the package name of models and source code according to new location
*.* Adapt downstream project in order to use these model projects
*.* remove models from controller repository

As of now all the bundles moved to openflowplugin contains all the commit that is pushed till
following commit
$ git log -1
commit 6340a32c44b6a423d52fd98ce3c66bc480ab9246
Merge: 94d7e66 4c90ff7
Author: Tony Tkacik <ttkacik@cisco.com>
Date:   Fri Jan 16 12:50:26 2015 +0000

    Merge "Fixed missing dependencies in netconf-netty-util."

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
9 years agoMerge "Adding feature odl-openflowplugin-nxm-extensions and configs."
Ed Warnicke [Tue, 20 Jan 2015 18:33:49 +0000 (18:33 +0000)]
Merge "Adding feature odl-openflowplugin-nxm-extensions and configs."

9 years agoAdding feature odl-openflowplugin-nxm-extensions and configs. 34/13234/6
Srini Seetharaman [Sun, 30 Nov 2014 05:29:10 +0000 (21:29 -0800)]
Adding feature odl-openflowplugin-nxm-extensions and configs.

This is part of the effort to move of-extensions from
ovsdb project to the openflowplugin project.

 - moved nicira extensions into seaparate fatures depending on
   ofplugin features
 - renamed openflowplugin-extension-config to
   openflowplugin-extension-nicira-config
 - cleaned unused dependencies in ofplugin features
 - suqashed configSubsystem config files into one

Change-Id: I1f11f0dc87fef340f13e9e012e003fbda3124b04
Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoThe high priority queue containing control messages is processed first(before data... 90/14290/1
ary [Tue, 20 Jan 2015 13:06:11 +0000 (14:06 +0100)]
The high priority queue containing control messages is processed first(before data queue) in PollableQueuesPriorityZipper, if it is not queue with high priority then is used addSource in PollableQueuesPriorityZipper for use the PollableQueuesZipper.

Signed-off-by: ary <jatoth@cisco.com>
9 years agoMerge "BUG2608: Using the right buffer id for no buffer"
Prasanna Huddar [Tue, 20 Jan 2015 05:06:09 +0000 (05:06 +0000)]
Merge "BUG2608: Using the right buffer id for no buffer"

9 years agoBUG2608: Using the right buffer id for no buffer 53/14253/2
Colin Dixon [Mon, 19 Jan 2015 15:34:26 +0000 (09:34 -0600)]
BUG2608: Using the right buffer id for no buffer

Using OFConstants.OFP_NO_BUFFER everywhere I could find. Also, fixing
some whitespace issues where I encountered them.

Change-Id: I0a1447d460981941ebce8a5f9db697eec7599b58
Signed-off-by: Colin Dixon <colin@colindixon.com>
9 years agoAdding Nicira actions and match for NSH Index and path fields. 18/12418/3
Srini Seetharaman [Fri, 31 Oct 2014 17:01:23 +0000 (10:01 -0700)]
Adding Nicira actions and match for NSH Index and path fields.
match.nsi, match.nsp, action.set_nsi and action.set_nsp.
This is part of the consolidation of Nicira OF extensions from
the OVSDB project.

Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>
9 years agoPorting over the Nicira extension actions MULTIPATH and RESUBMIT from 17/12417/4
Srini Seetharaman [Thu, 30 Oct 2014 18:00:53 +0000 (11:00 -0700)]
Porting over the Nicira extension actions MULTIPATH and RESUBMIT from
the OVSDB project of-extensions folder to the OpenFlowPlugin project.
This is part of a consolidation effort.

Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>
9 years agoBug 868: Replaced use of toInstance() for build(). 88/14188/1
Tony Tkacik [Fri, 16 Jan 2015 09:21:59 +0000 (10:21 +0100)]
Bug 868: Replaced use of toInstance() for build().

Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoRemove deprecated BindingAwareProvider methods 24/14124/1
Ed Warnicke [Tue, 13 Jan 2015 15:09:48 +0000 (09:09 -0600)]
Remove deprecated BindingAwareProvider methods

https://git.opendaylight.org/gerrit/#/c/13806/

will remove deprecated BindingAwareProvider methods.
This patch simply removes them from openflowplugins
implmementation of that interface so when 13806 is
merged we can merge this to fix OFplugin.

Change-Id: I968d8df6f04732b84e1f93a7610394433547756b
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoSet root pom.xml <name> for Sonar 48/14048/1
Thanh Ha [Fri, 9 Jan 2015 20:49:05 +0000 (15:49 -0500)]
Set root pom.xml <name> for Sonar

As mentioned on the mailing list Sonar uses the <name> field of the
pom.xml that is passed to the mvn command as the name of the project in
Sonar. In most cases this is the root pom.xml file in a project. This
patch sets the name to the project shortname.

https://lists.opendaylight.org/pipermail/discuss/2014-November/004024.html

Change-Id: I3a2f8d9cbc32decaed710aa55fa98f0df94c2b9f
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
9 years agoMerge "Bug 2525 : remove zombie registrations of notification listener"
michal rehak [Thu, 8 Jan 2015 14:38:04 +0000 (14:38 +0000)]
Merge "Bug 2525 : remove zombie registrations of notification listener"

9 years agoBug 2280 - MatchConvertorImpl bugs found during test creation 50/13450/5
Martin Bobak [Mon, 8 Dec 2014 13:35:00 +0000 (14:35 +0100)]
Bug 2280 - MatchConvertorImpl bugs found during test creation

- changed PbbIsid mask byte[] legnth to 3

Change-Id: I7f6eb71bc9a2ea03778835f8232f8f5057a93296
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 2394 - ConnectionConductorImpl and HandshakeManagerImpl leak threads on exception... 39/13739/2
Martin Bobak [Thu, 18 Dec 2014 15:38:56 +0000 (16:38 +0100)]
Bug 2394 - ConnectionConductorImpl and HandshakeManagerImpl leak threads on exception paths

- added onHandshakeFailure method for proper handshake failure handling
- conductor's threadpool is shut down on handshake failure
- conductor's state changed to RIP on handshake failure
- introduced close method to handle necessary closing operations

Change-Id: I2fb19c5021620e3f3f4f98f7efec1d63120c11b4
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 2525 : remove zombie registrations of notification listener 33/13733/3
Martin Bobak [Wed, 17 Dec 2014 08:22:42 +0000 (09:22 +0100)]
Bug 2525 : remove zombie registrations of notification listener

Change-Id: I2863fa74cd7b287d760cf55e190dbceb4df629f4
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 2552 - Fix statistics manager log messages 12/13912/1
Anil Vishnoi [Mon, 5 Jan 2015 10:45:24 +0000 (16:15 +0530)]
Bug 2552 - Fix statistics manager log messages

Changed following log message :
org.opendaylight.openflowplugin - 0.1.0.SNAPSHOT | Session for the cookie null is invalid

To:
org.opendaylight.openflowplugin - 0.1.0.SNAPSHOT | No valid connection found for the node [datapath-id : [XXXX]]

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
9 years agoFix bug 1941 - Deleting of flows very slow with large number of flows 66/13566/2
Vaclav Demcak [Tue, 9 Dec 2014 16:44:30 +0000 (17:44 +0100)]
Fix bug 1941 - Deleting of flows very slow with large number of flows
in data store and controller connected to the network

Flow mod flag OFPFF_SEND_FLOW_REM (send flow removed msg when flow
expires or is deleted) can not be set to "false" without this patch.
Old way to set flow mod flags contains value (e.g. _sENDFLOWREM=true)
but new implementation checks only a flag occurrence for set boolean
value to true. No occurence means false but FlowConventor set a defalut
true value without explicit own value.

+ patch2 - fix FlowModFlags TESTS
+ fixed FlowConvertorTest

(cherry picked from commit 0fa45756d6ef2810a42b08fef917a36509f1bfd8)
Change-Id: I777eceefe64535825ac258d9ab52d7bee3f83a0c
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBug 2407 - learning switch fails to install learnt flows 99/13299/1
Martin Bobak [Tue, 2 Dec 2014 10:14:16 +0000 (11:14 +0100)]
Bug 2407 - learning switch fails to install learnt flows

Change-Id: Ifdc121ffd9fa01bec2e6ce56c4054435a316e8d5
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 2452 - Topology incomplete (half of the links) 47/13247/1
Martin Bobak [Mon, 1 Dec 2014 09:29:26 +0000 (10:29 +0100)]
Bug 2452 - Topology incomplete (half of the links)

- initial operational status set to RUN

Change-Id: I22ff6863391405348b5937efa997fb7248809b23
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 2442 - UDP matching flow adds a match on dst port=0 (only occurs with OF10) 12/13212/1
Anil Vishnoi [Fri, 28 Nov 2014 21:23:15 +0000 (02:53 +0530)]
Bug 2442 - UDP matching flow adds a match on dst port=0 (only occurs with OF10)
Existing code was incorrectly setting the wildcard flag for source port and destination port.
It was setting the flag if user specified source/destination IP address in match, so even if
user did not specified source/destination port, flag is getting set and thats why switch
thinks that port is not wildcarded and it set the port to default short value (0).

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
9 years agoBug 2428 - add rpc method for LLDP speaker to configure its operational status 44/13044/8
Martin Bobak [Fri, 21 Nov 2014 10:13:42 +0000 (11:13 +0100)]
Bug 2428 - add rpc method for LLDP speaker to configure its operational status

Change-Id: I91e0246b47ad74e94b2bd3c14ed521b29607d43d
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 2369: Fixed NPE in update-flow RPC. 89/12789/4
Shigeru Yasuda [Wed, 12 Nov 2014 17:13:25 +0000 (02:13 +0900)]
Bug 2369: Fixed NPE in update-flow RPC.

  - Need to check whether match in update-flow input is null.
  - Interpret null priority in update-flow input as default priority.
  - Original flow should be removed if any of the following fields is
    changed.
    - idle-timeout
    - hard-timeout
    - flags
    - cookie

Change-Id: I64c4ff66ce4965cbd8c9e9a608082ef2b5a84439
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
9 years agoBug 1953 - fix of this bugs impact on OFP 47/13147/2
Martin Bobak [Wed, 26 Nov 2014 14:59:14 +0000 (15:59 +0100)]
Bug 1953 - fix of this bugs impact on OFP

- fixed errors where Ipv4Prefix was instantiated without mask
- fixed errors where Ipv4Address was instantiated using mask
- fixed failing tests

Change-Id: I3a9270fc75128ab5fa7ee12bf92ad9a1cb324fc0
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agofix broken build 76/13076/1
Martin Bobak [Mon, 24 Nov 2014 14:52:42 +0000 (15:52 +0100)]
fix broken build

- updated config subsystem configuration for integration tests

Change-Id: I70054caaad8a91d1e676a6332ff40c24f84fde6a
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 2388: Set node reference into OFPT_ERROR notification. 36/12836/2
Shigeru Yasuda [Fri, 14 Nov 2014 07:48:49 +0000 (16:48 +0900)]
Bug 2388: Set node reference into OFPT_ERROR notification.

Change-Id: I5b7f23c4029e8cf2c6458086c6cadc5ff22912ed
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
9 years agoBUG 2392 - learning switch listener registration fix 19/12819/3
Martin Bobak [Tue, 11 Nov 2014 01:09:09 +0000 (02:09 +0100)]
BUG 2392 - learning switch listener registration fix

- WakeUpNode has to listen for operationl datastore changes

Change-Id: I5130c232fe52e688e6dbb007fa84d975a4d17c01
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agolearning switch shifted to new data broker API 84/12784/1
Martin Bobak [Sun, 9 Nov 2014 20:27:39 +0000 (21:27 +0100)]
learning switch shifted to new data broker API

Change-Id: Ib74861c69490a5dc259bfe94c2c03c10ec91cb57
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agobug-2242: separating ofp applications 99/12599/5
Michal Rehak [Fri, 7 Nov 2014 11:49:29 +0000 (12:49 +0100)]
bug-2242: separating ofp applications

- created feature per app
  (of-switch-config-pusher, lldp-speaker, tableMissEnforcer)
- added essential apps to odl-openflowplugin-flow-service
  (of-switch-config-pusher, lldp-speaker)

Change-Id: I25f6595b9e6af47cf12ae05c7d4c76b0469222fa
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBUG-1764: default config for OF switch - fix 98/12598/2
Michal Rehak [Fri, 7 Nov 2014 11:41:13 +0000 (12:41 +0100)]
BUG-1764: default config for OF switch - fix

- added routed registration
- added missing version property

Change-Id: I1ddfaa08672b7f9492b3951a44ab22513074c925
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBUG-2315: Remove dependency to OFJava-impl 56/12456/3
Marian Adamjak [Mon, 3 Nov 2014 09:26:18 +0000 (10:26 +0100)]
BUG-2315: Remove dependency to OFJava-impl

- PacketInV10TranslatorTest switched to mocks
- code tidyup

Change-Id: I448d5354300f1b2e85503c9cc7445968ea2c8a4e
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBUG-2242: separate apps 90/12490/1
Michal Rehak [Tue, 4 Nov 2014 14:16:02 +0000 (15:16 +0100)]
BUG-2242: separate apps

- added missing dependencies to config subsystem xml files
  (type=xml, classifier=config)

Change-Id: I0b12fac8bc490983bc20b667bdf898abe64e31f4
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBug 2181: Switches now properly populate IP addresses 33/11933/5
Colin Dixon [Mon, 13 Oct 2014 23:47:47 +0000 (18:47 -0500)]
Bug 2181: Switches now properly populate IP addresses

- removed session validity check when reading address
    (session validity should be relevant for consumers and
    not for internal processes)
- added unit test
- replaced deprecated ListenerRegistry class
- fixed imports, rebased

We now mark the switch context as valid <s>before</s>after notifying people.

Change-Id: I743b430c0d55e007f0ab18326f149ac46b3d4f66
Signed-off-by: Colin Dixon <colin@colindixon.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBUG-2242: LLDP speaker as separate application. 40/11740/8
Anton Frolov [Sat, 4 Oct 2014 15:02:12 +0000 (19:02 +0400)]
BUG-2242: LLDP speaker as separate application.

 * Remove LLDPSpeaker and all related classes and methods from openflowplugin
 * Create separate LLDPSpeaker application
 * Replace usage of Timer with ScheduledExecutorService which use monotonic
   timer for delays instead of system time.
 * Decomposed LLDPSpeaker into several classes to improve unit testabilty
 * added lldp app to base distro

Change-Id: I997c74203af7461840c1c711355120b415995c06
Signed-off-by: Anton Frolov <anton.frolov@pacnet.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBug 2065 - Unset fields in MeterStatsResponseConvertor 82/12382/4
Martin Bobak [Thu, 30 Oct 2014 12:50:05 +0000 (13:50 +0100)]
Bug 2065 -  Unset fields in MeterStatsResponseConvertor

- this commit needs this one to be merged https://git.opendaylight.org/gerrit/12381

Change-Id: Idb01266d87c45d9894b513b6299d9c1da07a5615
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBUG-837: IT unstable 26/12326/2
Michal Rehak [Wed, 29 Oct 2014 17:36:17 +0000 (18:36 +0100)]
BUG-837: IT unstable

IT keep running forever because of change in OFJava + old change in OFPlugin-IT.

- fixed scenario for 2 hello handshake test (OFPluginToLibraryTest)
- fixed threading for scenario execution

Change-Id: I5af8248fd9c92f3bc2e02cac169c4f34599519d7
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBUG-1491: handle SET_TP_SRC/SET_TP_DST actions 71/11371/10
Timotej Kubas [Fri, 19 Sep 2014 15:37:36 +0000 (17:37 +0200)]
BUG-1491: handle SET_TP_SRC/SET_TP_DST actions
 -  set_tp_src/set_tp_dst action corrected for setting of different protocols
   (UDP,TCP, ICMPv4, ICMPv6)
 - fixed tests

Change-Id: Ia53caaccc57b13d05d9a4ce18e4bf9354e81b69b
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBug 1764 - fixed features configuration for os-switch-config-pusher 90/12190/1
Martin Bobak [Thu, 23 Oct 2014 10:42:49 +0000 (12:42 +0200)]
Bug 1764 - fixed features configuration for os-switch-config-pusher

Change-Id: Iaa1d0af3b2b8d5f5e9ec3ea8ef535ce084922155
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBUG-1254: fix concurrent add/remove session test 24/12024/5
Michal Rehak [Thu, 16 Oct 2014 10:54:00 +0000 (12:54 +0200)]
BUG-1254: fix concurrent add/remove session test

 - replaced executor service with logging impl
 - mock tidy up
 - ipaddress mockery added
 - feature replaced for real object
 - introduced action waiting mechanism based on future results
 - added cleanUp of sessionManager singletons (SalRegistrationManagerTest)
 - extended close functionality of SalRegistrationManagerOFImpl
 - rebased

Change-Id: I2e3c26eb37b8f80f85a79b8fed63933eb62ccb96
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBug 1764 - added karaf settings for os-switch-config-pusher 22/12022/3
Martin Bobak [Thu, 16 Oct 2014 11:51:20 +0000 (13:51 +0200)]
Bug 1764 - added karaf settings for os-switch-config-pusher

Change-Id: I1d2739329ae346c58cb0d9370c01fe57fc926b08
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1764 - implementation of default config pusher 21/12021/3
Martin Bobak [Wed, 15 Oct 2014 08:32:36 +0000 (10:32 +0200)]
Bug 1764 - implementation of default config pusher

Change-Id: I6f910c3b68f6e50fb3de2e12b01fc33bb28eb80c
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1764 - moved Session related interfaces to openflowplugin-api 20/12020/3
Martin Bobak [Tue, 14 Oct 2014 12:35:38 +0000 (14:35 +0200)]
Bug 1764 - moved Session related interfaces to openflowplugin-api

- session related interfaces moved from implementation to api
- Extension related methods erradicated from SessionManager and
  moved to extension-api's ExtensionSessionManager
- openflowplugin-api SessionManager and openflowplugin-extension-api ExtensionSessionManager
  joined for openflowplugin neeeds in ConjuctSessionManager to provide functionality
  of both apis

Change-Id: I947a59714900cb7e6d2fb7376c4d743e1764ac7b
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1764 - created new bundle responsible for default OF switch configuration 19/12019/2
Martin Bobak [Tue, 14 Oct 2014 11:44:59 +0000 (13:44 +0200)]
Bug 1764 - created new bundle responsible for default OF switch configuration

Change-Id: Ie8f987be79dad4263d1e597efad2635e1460451a
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - corrected path for jacoco excluded classes 46/11946/2
Martin Bobak [Tue, 14 Oct 2014 11:47:43 +0000 (13:47 +0200)]
Bug 1254 - corrected path for jacoco excluded classes

Change-Id: I1784235a516489b26c37423c9e0f6a50b7ee04e1
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBUG-1680: default table-miss-entry feature 04/11804/2
Michal Rehak [Tue, 7 Oct 2014 14:53:44 +0000 (16:53 +0200)]
BUG-1680: default table-miss-entry feature

- added table-miss-entry-enforcer to features in order to have
  it accessible in karaf

Change-Id: I5d58aad04d991d0a110cef0cd9b436ba9933d9d8
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBug 1254 - removed unused utility class 17/11917/2
Martin Bobak [Mon, 13 Oct 2014 07:13:01 +0000 (09:13 +0200)]
Bug 1254 - removed unused utility class

Change-Id: Iebcf340c09061251026a6357719d383de599c4d1
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - Added unit tests for FlowConvertor, NotificationQueueWrapper and OpenflowP... 73/11773/2
Michal Polkorab [Tue, 7 Oct 2014 09:41:58 +0000 (11:41 +0200)]
Bug 1254 - Added unit tests for FlowConvertor, NotificationQueueWrapper and OpenflowPluginProvider

 - also fixed OFToMDSalFlowConvertorTest - instruction type in testToSALInstruction()
   was not set correctly

Change-Id: I3fb7a1a4d3c94d3c01ebf707d0d0d9431f56a17b
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
9 years agoBug 1254 - Added unit tests for ActionConvertor 21/11721/2
Michal Polkorab [Fri, 3 Oct 2014 12:03:48 +0000 (14:03 +0200)]
Bug 1254 - Added unit tests for ActionConvertor

 - contains FIXME for SetNwSrc and SetNwDst ip address translation

Change-Id: If6c617e5b2d5452ca19c92b9a7dd632e07cda932
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
9 years agoBug 1254 - enhanced InventoryDataServiceUtilTest 74/11774/3
Martin Bobak [Tue, 7 Oct 2014 11:21:51 +0000 (13:21 +0200)]
Bug 1254 - enhanced InventoryDataServiceUtilTest

Change-Id: I1b5833d6d2f02c6357e1ced4fef567a0e1bbd7ea
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug-2098- Multipart Request flow was not set to the flow case 55/11655/4
Kamal Rameshan [Mon, 29 Sep 2014 04:22:01 +0000 (21:22 -0700)]
Bug-2098- Multipart Request flow was not set to the flow case

Change-Id: I64e286fb6a23c9c11966cc0287f85bc1c5192526
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
9 years agoBug 1254 - added test method for AbstractErrorTranslator#translate 59/11759/2
Martin Bobak [Mon, 6 Oct 2014 11:50:24 +0000 (13:50 +0200)]
Bug 1254 - added test method for AbstractErrorTranslator#translate

Change-Id: I90d8a79051417b085827b7cdfc033826218927c9
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - added test of basic funcionality for ErrorHandlerSimpleImpl 58/11758/2
Martin Bobak [Mon, 6 Oct 2014 10:52:12 +0000 (12:52 +0200)]
Bug 1254 - added test of basic funcionality for ErrorHandlerSimpleImpl

Change-Id: Ide8c121d0bef3807aa707eafa36a8de156fe7522
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - added basic functionality test for OFRpcTaskUtil 57/11757/2
Martin Bobak [Tue, 30 Sep 2014 07:33:43 +0000 (09:33 +0200)]
Bug 1254 - added basic functionality test for OFRpcTaskUtil

- removed unused method OFRpcTaskUtil#wrapBarrierErrors

Change-Id: I6ad9cfdf22f12fd00fd6d8727e8cad730d788dae
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - added basic functionality test for TableFeaturesConvertor 11/11611/4
Martin Bobak [Fri, 26 Sep 2014 08:56:59 +0000 (10:56 +0200)]
Bug 1254 - added basic functionality test for TableFeaturesConvertor

Change-Id: Idd990ad4e479f4f67945e053a77ecc2de0ffe261
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBUG 1254 - test for PacketInV10Translator.java 46/11746/2
Jakub [Fri, 3 Oct 2014 19:20:08 +0000 (21:20 +0200)]
BUG 1254 - test for PacketInV10Translator.java

Signed-off-by: Jakub <jatoth@cisco.com>