Tomas Slusny [Tue, 12 Jul 2016 11:59:50 +0000 (13:59 +0200)]
Bug 5540 - Remove ConvertorManager singleton
- Removed singleton from ConvertorManager
- Added ConvertorManagerFactory
- Now ConvertorManager lookup is also based on Openflow version
- New test for ConvertorManager
Change-Id: Ib23fa304143d6e2fb7f09781acc1fd0c6a3be5e8
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Tomas Slusny [Tue, 12 Jul 2016 11:27:11 +0000 (13:27 +0200)]
Bug 5540 - Multiple convert types for one convertor
- Now convertor can specify multiple source types to convert
- Changed previous method of getting multiple source types from
single source type to throw warning when it is used
Change-Id: If1e4cc9087f71dd5a0a38c10b053f7239de78998
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Tomas Slusny [Mon, 11 Jul 2016 07:26:38 +0000 (09:26 +0200)]
Bug 5540 - ConvertorManager DataContainer source, one Convertor interface
- Changed source type for Convertor interface and ConvertorManager to must extend
YANG DataContainer
- Started using getImplementedInterface() to get source type
Change-Id: Ic229c278516074f42218b45a5040d3601b386bd7
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Tomas Slusny [Fri, 8 Jul 2016 09:38:47 +0000 (11:38 +0200)]
Bug 5540 - ConvertorProcessor DataContainer source, optimization
- Changed source type for ConvertorProcessor to must extend
YANG DataContainer
- Removed double lookups
- Changed map with conversions to concurrent hash map
- Stopped using reflection for getting source type,
instead use getImplementedInterface() from DataContainer
Change-Id: I82e4ded70526a9219125340e5dbf3b6f05d77296
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Tomas Slusny [Fri, 8 Jul 2016 07:03:02 +0000 (09:03 +0200)]
Bug 5540 - ConvertorManager optimization, concurrency
- Split ConvertorManager functionality to interfaces ConvertorRegistrator and
ConvertorExecutor
- Changed convertor maps to concurrent hash maps
- registerConvertor now returns old convertor if already registered instead of boolean
- Better type extraction from collections
- Removed duplicate map lookups
- Better log messages
Change-Id: I38c6bc119861fef844535c50740c65fa7ae43192
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Tomas Slusny [Wed, 29 Jun 2016 07:08:38 +0000 (09:08 +0200)]
Bug 5540 - FlowConvertor, FlowStatsResponseConvertor, FlowInstructionResponseConvertor
- Reworked FlowConvertor, FlowStatsResponseConvertor to use new ConvertorManager design
- Added FlowInstructionResponseConvertor (moved some loic from FlowStatsResponseConvertor)
- Updated tests and usages accordingly
Change-Id: Iff2dc752aab73473adb955394cf852d7524fddd9
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Tomas Slusny [Wed, 29 Jun 2016 06:54:36 +0000 (08:54 +0200)]
Bug 5540 - PacketOutConvertor
- Reworked PacketOutConvertor to use new ConvertorManager design
- Updated tests and usage of PacketOutConvertor accordingly
Change-Id: I9df612a7d9c3b9604c8119f86d2266723066e68a
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Tomas Slusny [Tue, 28 Jun 2016 13:59:50 +0000 (15:59 +0200)]
Bug 5540 - GroupConvertor, GroupStatsConvertor, GroupDescStatsConvertor
- Reworked GroupConvertor and GroupStatsConvertor to new ConvertorManager design
- Added GroupDescStatsConvertor (moved some logic from GroupStatsConvertor)
- Updated (and fixed) tests, and updated usages accordingly
Change-Id: Iabae7191ceeefeb208487ab5cf0280e8f8186c3e
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Tomas Slusny [Tue, 28 Jun 2016 12:55:02 +0000 (14:55 +0200)]
Bug 5540 - ActionConvertor, ActionResponseConvertor
- Reworked ActionConvertor to use new ConvertorManager desing
- Added new ActionResponseConvertor (moved a bit of logic from ActionConvertor)
- Updated tests and usages accordingly
Change-Id: I76a9b345942272dc555e4d75766968931ee4ecdb
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Tomas Slusny [Mon, 27 Jun 2016 14:10:40 +0000 (16:10 +0200)]
Bug 5540 - PortConvertor, MatchConvertor
- Reworked MatchConvertorImpl and MatchConvertorV10Impl (extracted some logic from it)
- Added MatchResponseConvertor and MatchV10ResponseConvertor
- Updated and added new tests, and updated usage of match convertors
- Reworked PortConvertor to use new ConvertorManager design
- Updated tests and usage of PortConvertor accordingly
Change-Id: If53d7c521bf4a718a466ec7cd11d28e57d8cf4bd
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Tomas Slusny [Mon, 27 Jun 2016 13:49:27 +0000 (15:49 +0200)]
Bug 5540 - MeterStatsResponseConvertor, MeterConfigStatsResponseConvertor
- Reworked MeterStatsResponseConvertor to use new ConvertorManager desing
- Moved part of logic of MeterStatsResponseConvertor to new
MeterConfigStatsResponseConvertor
- Updated tests and usage of MeterStatsResponseConvertor and
MeterConfigStatsResponseConvertor accordingly
Change-Id: I5555fae748fd8d3c2e0baa8d2b56ee450fe4697b
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Tomas Slusny [Mon, 27 Jun 2016 13:17:39 +0000 (15:17 +0200)]
Bug 5540 - MeterConvertor
- Reworked MeterConvertor to use new ConvertorManager design
- Updated tests and usage of TableFeaturesConvertor accordingly
Change-Id: Icaf9a28d569ae76e396427d79241401f6517a46c
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Tomas Slusny [Mon, 27 Jun 2016 12:52:17 +0000 (14:52 +0200)]
Bug 5540 - TableFeaturesResponseConvertor
- Reworked TableFeaturesReplyConvertor (renamed to TableFeaturesResponseConvertor) to
use new ConvertorManager desing
- Updated tests and usage of TableFeaturesReplyConvertor/TableFeaturesResponseConvertor
Change-Id: Ifc48f3228ba09d6ee8cf87d902178957c3a67f7d
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Tomas Slusny [Mon, 27 Jun 2016 12:24:11 +0000 (14:24 +0200)]
Bug 5540 - TableFeaturesConvertor
- Reworked TableFeaturesConvertor to use new ConvertorManager design
- Updated tests and usage of TableFeaturesConvertor accordingly
Change-Id: Ic2430412edac4cc0658f1fa7ccdecb5ebf937eef
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Tomas Slusny [Mon, 27 Jun 2016 11:36:16 +0000 (13:36 +0200)]
Bug 5540 - ConvertorManager base
- Added base for ConvertorManager
- Removed datapathId from Convertor interface (as it was not needed anymore)
- Updated usages and tests accordingly
- Moved IPProtocols and IPConversionUtil to package
org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.common
Change-Id: I22940403495be5f0398682cab4e3377ee86ce7be
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Anil Vishnoi [Wed, 27 Jul 2016 10:59:27 +0000 (03:59 -0700)]
Bug 5895 - Support of Ext109 openflow tcp flag matching in openflowplugin
Flow matching based on TCP FLAGs is now ONF approved
extension for OpenFlow Spec 1.3.X. OVS also support this
extension as well as it's own version of Nicira Extension.
Depends-On: https://git.opendaylight.org/gerrit/#/c/42954/2
Change-Id: I23c1e9956112e72b28d24a088b375f2732e5523c
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Shuva Kar [Tue, 19 Apr 2016 02:52:27 +0000 (08:22 +0530)]
BUG:6058 - Currently the Operational Datastore does not get cleaned up and the switch
continues to persist if the node that is connected to the switch goes
down. The patch addresses it
Change-Id: I0e8a65c8f38ac9d4de1def65be1daf7afbab5d18
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Andrej Leitner [Thu, 28 Jul 2016 16:41:25 +0000 (18:41 +0200)]
Added feature for forwardingrules-sync app
Change-Id: Ia9a65769e9a5466a536dd79802214f45f149a0ec
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
Abhijit Kumbhare [Thu, 28 Jul 2016 20:34:37 +0000 (20:34 +0000)]
Merge "Bug 6146 - Some Flows not found in DeviceFlowRegistry"
Andrej Leitner [Thu, 28 Jul 2016 09:53:36 +0000 (11:53 +0200)]
FRS - sonar issues and repackage
- forwarders moved to strategy package
- functions converted to labmdas
- simplified statements
- remove comments
Change-Id: I103d02f0dab3234ca9338f207a4102d814da2019
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
Andrej Leitner [Tue, 26 Jul 2016 08:59:35 +0000 (10:59 +0200)]
Use SyncupEntry in syncup method (Bug 6170 cleaning)
- used wrapper object SyncupEntry instead of two
FCN objects in syncup (enriched with source DS types)
- fixed skipping Config/Operational change in retry
decorator with using SyncupEntry
- made updateCompressionState more comprehensible
- updated junit tests & improved logging
Change-Id: Iedcc94e9ce806c425e47f719e391cf7110ddb2c3
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
Andrej Leitner [Wed, 13 Jul 2016 07:47:43 +0000 (09:47 +0200)]
Bug 6170 + Bug 5919 - made FRS cluster-aware
- NodeListener changed to clustered DTCL
- added ClusterRegistration per connected device
with corresponding actions (on mastership change)
- added ClusterServiceManager to register services
at the provider and keep these registrations
- added ClusterDecorator to skip modifications
if device is not currently mastered
- added and updated tests
Change-Id: I4fd9459e67cc5127f7eacca93adbd456a34fab0f
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
Andrej Leitner [Fri, 8 Jul 2016 12:50:06 +0000 (14:50 +0200)]
Cleaning and preparation before bug 6170
- refactored name RetryRegistry -> ReconciliationRegistry
- merged operational listener w/ retry subclass (since not needed)
- extracted Modification util methods into new class
- moved SwitchFlowId to utils
- added some finals, lambdas and fixed typos
- removed dead code
Change-Id: I4d62c157a39490e14be198e3757d206f3b780558
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
Jozef Bacigal [Tue, 26 Jul 2016 06:52:50 +0000 (06:52 +0000)]
Merge "Move empty match constant into OFConstants"
Jozef Bacigal [Tue, 26 Jul 2016 06:47:34 +0000 (06:47 +0000)]
Merge "SONAR TD - SinglePurposeMultipartReplyTranslator - CC"
Jozef Bacigal [Tue, 26 Jul 2016 06:46:14 +0000 (06:46 +0000)]
Merge "SONAR TD - DeviceFlowRegistryImpl, FlowDescriptorFactory, FlowRegistryKeyFactory"
Jozef Bacigal [Tue, 26 Jul 2016 06:44:51 +0000 (06:44 +0000)]
Merge "Topology manager small sonar issues (+ optimized imports)"
Anil Vishnoi [Mon, 25 Jul 2016 20:18:14 +0000 (13:18 -0700)]
Bug 6146 - Some Flows not found in DeviceFlowRegistry
Hook in the custom comparator code from Helium design
that will bring in the custom flow-match constructs
comparison and address all the regression scenario
poped up because of the hashcode/equals based matching.
Default equals/hashcode approach won't work for flow matching,
because flows match contructs (e.g ip/mac) are not normalized
and also because of the extension augmentation.
This hook don't change the default behavior, it will trigger
only if the flow is not found in the flowRegistry, so as far
as user installs flow with the normalized values, custom
comparator is not required.
Change-Id: Ibeba9693d1c4dc0092fa9a11c8acd0ce7cf7a15d
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Andrej Leitner [Mon, 25 Jul 2016 09:43:22 +0000 (11:43 +0200)]
Move empty match constant into OFConstants
Change-Id: Iee2666f3b2b92e371b9f085849502ec5f22c5650
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
Andrej Leitner [Thu, 21 Jul 2016 09:31:51 +0000 (11:31 +0200)]
Topology manager small sonar issues
(+ optimized imports)
Change-Id: I123ebdc38a6955b6a8677c78dda97a396108d29c
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
Sai MarapaReddy [Tue, 12 Jul 2016 01:31:32 +0000 (18:31 -0700)]
Bug 5390 - Adding Ipv6 L3ArbitraryBitMask feature support.
project:- openflowplugin; sub project:- applications
For Stable/Beryllium corresponding patch of subproject
openflowplugin is https://git.opendaylight.org/gerrit/#/c/41686/
Sample Payload Input:
<ipv6-source-address-no-mask>2070:2070:2001:2001:2001:0471:0471:0471
</ipv6-source-address-no-mask>
<ipv6-source-arbitrary-bitmask>FFFF::0471</ipv6-source-arbitrary-bitmask>
<ipv6-destination-address-no-mask>2001:2001:2001:2001:2001:0471:0471:0471
</ipv6-destination-address-no-mask>
<ipv6-destination-arbitrary-bitmask>FFFF:FFFF::FFFF
</ipv6-destination-arbitrary-bitmask>
Author: Eleftherios Koxias <elkoks@intracom-telecom.com>
Author: Sai MarapaReddy <sai.marapareddy@gmail.com>
Change-Id: I179526fdf8bb1b536f10d851698e1b0a63a70a7d
Signed-off-by: Sai MarapaReddy <sai.marapareddy@gmail.com>
Sai MarapaReddy [Tue, 12 Jul 2016 00:20:08 +0000 (17:20 -0700)]
Bug 5390 - Adding Ipv6 L3ArbitraryBitMask feature support.
New yang file is created to accomodate the introduction of
ipv6 L3ArbitraryBitMask feature. It includes unit test coverage.
Sample Payload Input:
<ipv6-source-address-no-mask>2070:2070:2001:2001:2001:0471:0471:0471
</ipv6-source-address-no-mask>
<ipv6-source-arbitrary-bitmask>FFFF::0471</ipv6-source-arbitrary-bitmask>
<ipv6-destination-address-no-mask>2001:2001:2001:2001:2001:0471:0471:0471
</ipv6-destination-address-no-mask>
<ipv6-destination-arbitrary-bitmask>FFFF:FFFF::FFFF
</ipv6-destination-arbitrary-bitmask>
Change-Id: I901bd17b716fafbb44a5e0a1d7237764b14fd23c
Signed-off-by: Sai MarapaReddy <sai.marapareddy@gmail.com>
Author: Eleftherios Koxias <elkoks@intracom-telecom.com>
Author: Sai MarapaReddy <sai.marapareddy@gmail.com>
Anil Vishnoi [Sun, 24 Jul 2016 04:26:59 +0000 (04:26 +0000)]
Merge "Bug 6073: Wait for completion of add-group RPCs as needed."
Thanh Ha [Sat, 23 Jul 2016 02:03:16 +0000 (22:03 -0400)]
Add missing license headers
Change-Id: I55ddbc065dba438b595b1d080ac1943b2ee547af
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Shigeru Yasuda [Thu, 16 Jun 2016 06:58:53 +0000 (15:58 +0900)]
Bug 6073: Wait for completion of add-group RPCs as needed.
We need to wait for completion of add-group RPCs that install groups
referenced from other flows/groups.
Additional changes:
* Fixed NPE in group reconciliation caused by null buckets.
Change-Id: Iad9bdf62ecdb189fe5e6080085f2ab7cc3131396
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Shuva Kar [Tue, 7 Jun 2016 17:46:22 +0000 (23:16 +0530)]
BUG-4117: Adding Retries during DTCL registration
Change-Id: I38427b63e4047895dcbcd976f02d57e2981d3518
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Tomas Slusny [Mon, 18 Jul 2016 10:52:27 +0000 (12:52 +0200)]
SONAR TD - DeviceFlowRegistryImpl, FlowDescriptorFactory, FlowRegistryKeyFactory
- Removed DeviceFlowRegistryImpl dependency on FlowUtil (moved FlowUtil.createAlienFlowId
to DeviceFlowRegistryImpl, adjusted SalFlowServiceImpl to use methods from
DeviceFlowRegistry to manage flow ids)
- Created private constructors for FlowDescriptorFactory, FlowRegistryKeyFactory
- Created private constructors for FlowDescriptorDto, FlowRegistryKeyDto
Change-Id: I94d38df3c42251274366441b55b1f727e1170bca
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Jozef Bacigal [Wed, 20 Jul 2016 12:15:46 +0000 (12:15 +0000)]
Merge "Create empty match only once"
Jozef Bacigal [Wed, 20 Jul 2016 12:13:37 +0000 (12:13 +0000)]
Merge "Optimized imports in frm"
Jozef Bacigal [Wed, 20 Jul 2016 12:00:25 +0000 (12:00 +0000)]
Merge "Bug 4148: Fixed the log level."
Jozef Bacigal [Wed, 20 Jul 2016 09:38:34 +0000 (11:38 +0200)]
Revert "Merge "Bug 6235 - Cookie compare in FlowRegistryKeyFactory""
This reverts commit
9f162b87886b2bb3917fb5aa8aa3b37f49215516, reversing
changes made to
7fa33fd58abd5d38788581d9207e972dfd3eb592.
Change-Id: Icbc0738d392e0d270f033b3efb9b90cd33824fac
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>
miroslav.macko [Wed, 20 Jul 2016 09:28:02 +0000 (11:28 +0200)]
Optimized imports in frm
Change-Id: I96545bca8ef2a01aef974b2223961717ccb62866
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Andrej Leitner [Wed, 20 Jul 2016 08:44:24 +0000 (10:44 +0200)]
Bug 4148: Fixed the log level.
- changed to debug as it was agreed in ch-p on Be branch
to prevent log flooding
Change-Id: If2cbc0d5ab4c6678b7c1a9a62cdb152ea1e554e5
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
Andrej Leitner [Wed, 20 Jul 2016 08:14:56 +0000 (10:14 +0200)]
Create empty match only once
Change-Id: I206a588303c563d42c173cf2062501c92159dcc4
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
Jozef Bacigal [Wed, 20 Jul 2016 08:14:38 +0000 (08:14 +0000)]
Merge "Bug 6235 - Cookie compare in FlowRegistryKeyFactory"
Jozef Bacigal [Wed, 20 Jul 2016 08:11:14 +0000 (08:11 +0000)]
Merge "Bug 6193 - Change in length of DatapathId of a switch"
michal rehak [Wed, 20 Jul 2016 08:07:53 +0000 (08:07 +0000)]
Merge "Sonar major issues."
Anil Vishnoi [Wed, 20 Jul 2016 08:01:17 +0000 (08:01 +0000)]
Merge "BUG-6059: Moving Statistics Manager to DTCL"
Jozef Bacigal [Wed, 20 Jul 2016 07:55:15 +0000 (07:55 +0000)]
Merge "Technical Debt part 2"
Jozef Bacigal [Wed, 20 Jul 2016 07:52:12 +0000 (07:52 +0000)]
Merge "Technical Debt part 1"
Tom Pantelis [Wed, 20 Jul 2016 01:51:37 +0000 (21:51 -0400)]
Fix He plugin config push failure
The 42-openflowplugin.xml referenced the distributed-entity-ownership
config module as a required capability but this config module was
recently removed. However it should never have referenced this module in the
first place as it's an implementation module.
Change-Id: I6e4236fab3ab6a7e878dcb996dc386250cee5159
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Sai MarapaReddy [Tue, 19 Jul 2016 20:37:21 +0000 (13:37 -0700)]
Bug 6193 - Change in length of DatapathId of a switch
Dpid can go out of the Long range which results in NumberFormatException.
Hence the need to use BigInteger to hold the Dpid
Current patch accomodates Dpid to be of type BigInteger.
Change-Id: Id10a6afb09ee6da04faad6a0bcfaa960f32e93b7
Signed-off-by: Sai MarapaReddy <sai.marapareddy@gmail.com>
Author: Sai MarapaReddy <sai.marapareddy@gmail.com>
Jozef Bacigal [Tue, 19 Jul 2016 14:45:44 +0000 (14:45 +0000)]
Merge "BUG 6179 - Turning off flow removed notification"
Tomas Slusny [Tue, 19 Jul 2016 12:19:14 +0000 (14:19 +0200)]
SONAR TD - SinglePurposeMultipartReplyTranslator - CC
- Reduced cyclomatic complexity of method
SinglePurposeMultipartReplyTranslator.translate
Change-Id: Ib410f51d646ec39f3795f344c5e3199fd912eae4
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
miroslav.macko [Thu, 7 Jul 2016 07:06:22 +0000 (09:06 +0200)]
BUG 6179 - Turning off flow removed notification
- created notification-flow-removed-off switch
in openflow-provider-config.yang with default value false
- added managed-properties to openflowplugin.xml
Change-Id: Id657e0b995a40eee3beda85794fbe81fc15c6875
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Tomas Slusny [Tue, 19 Jul 2016 10:37:16 +0000 (12:37 +0200)]
Bug 6235 - Cookie compare in FlowRegistryKeyFactory
- Comparing by cookie was missing, so updated equals() and
hashCode() methods
Change-Id: I373ec09b2ab1089ec23fdb44a8b5dd0bf9ee4296
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
miroslav.macko [Wed, 13 Jul 2016 09:56:10 +0000 (11:56 +0200)]
Technical Debt part 2
- NodeStaticReplyTranslatorUtil
- Cyclomatic Complexity "nodeGroupFeatureTranslator"
- SystemNotificationsListenerImpl
- Cyclomatic Complexity "onSwitchIdleEvent"
- Reduce lambda expression number of lines
Change-Id: Id042ceba0155f6aa33a49fe1950c2d68b50b2853
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
miroslav.macko [Wed, 13 Jul 2016 07:43:13 +0000 (09:43 +0200)]
Technical Debt part 1
- MultipartRequestInputFactory
- added switch default case, removed unused method
- ConnectionManagerImpl
- BITMAP_NEGOTIATION_ENABLED constant
- HandshakeListenerImpl
- more readable changes
- log error
Change-Id: I8a52f1db824ca261e9b3da2aa1c7ca7999e7a745
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Shuva Kar [Sun, 12 Jun 2016 10:11:38 +0000 (15:41 +0530)]
BUG-6059: Moving Statistics Manager to DTCL
Change-Id: Icd82a0be1c905ffa7039575bf668ba00ece736e7
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Jozef Bacigal [Thu, 14 Jul 2016 16:28:40 +0000 (18:28 +0200)]
Sonar major issues.
Change-Id: I514bc07d4bb2f86aeab7e67a4cca6e0482debc5c
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>
Tomas Slusny [Thu, 14 Jul 2016 14:01:54 +0000 (16:01 +0200)]
Fix DeviceFlowRegistry filling
- Fixed double filling of DeviceFlowRegistry
- Moved nodeInstanceIdentifier parameter from DeviceFlowRegistry.fill
to it's constructor
Change-Id: I11be668a80b98f40e0b9aaa863d616fe669c0921
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Jozef Bacigal [Thu, 14 Jul 2016 06:47:43 +0000 (06:47 +0000)]
Merge "Bug 6181 - DeviceFlowRegistry performance issue when reading from datastore"
Thanh Ha [Wed, 13 Jul 2016 15:39:49 +0000 (15:39 +0000)]
Merge "Upgrade ietf-{inet,yang}-types to 2013-07-15"
Tomas Slusny [Fri, 8 Jul 2016 05:55:24 +0000 (07:55 +0200)]
Bug 6181 - DeviceFlowRegistry performance issue when reading from datastore
- Moved DeviceFlowRegistry.fill() to separate thread
- Chained statistics scheduling to start after DeviceFlowRegistry
initialization
- Changed DeviceFlowRegistry.retrieveIdForFlow(FlowRegistryKey) to not
generate alien flow ids
- Now DeviceFlowRegistry is properly cleaned after device becomes slave
Change-Id: Icf8445dbc7b2140c412d66b463f31d72cf43f3ba
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Andrej Leitner [Mon, 27 Jun 2016 09:53:52 +0000 (11:53 +0200)]
Bug 5572 update features.xml
- added new feature for FRM (odl-openflowplugin-app-forwardingrules-manager)
- features lldp-speaker, topology-lldp-discovery and topology-manager merged
into new feature (odl-openflowplugin-app-topology)
- odl-openflowplugin-flow-services starts standard apps (config, FRM, topology)
then southbound API for them
- removed feature odl-openflowplugin-nsf-services (not needed)
- removed feature odl-openflowplugin-all (not needed)
- made feature odl-openflowplugin-app-notifications dependent on soutbound
Change-Id: Ia680f391ffeb74d5ec41271b582be9f85dab8451
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
Lorand Jakab [Wed, 6 Jul 2016 15:20:26 +0000 (10:20 -0500)]
Upgrade ietf-{inet,yang}-types to 2013-07-15
Change-Id: Iffaa4ae8127e59eb507dadd02830382059ca5122
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
Josh [Sun, 3 Jul 2016 15:32:58 +0000 (17:32 +0200)]
BUG-6145 Flows rm'ed from DeviceFlowRegistry after being updated
Fixed this by implementing an actual update
instead of delete+add.
Changes:
DeviceFlowRegistry: no changes required since the
store method overwrites whatever was previously there.
SalFlowServiceImpl: Reworked logic to support update
and add
ItemLifecycleListener: added update methods.
Change-Id: I2bab85020656c0d19c3db3d029c86cd699cb65b9
Signed-off-by: Josh <jhershbe@redhat.com>
Jozef Bacigal [Mon, 11 Jul 2016 09:59:57 +0000 (09:59 +0000)]
Merge "BUG-6109: Having a null match field is totally fine."
Shuva Kar [Sat, 9 Jul 2016 01:55:51 +0000 (07:25 +0530)]
BUG-6109: Having a null match field is totally fine.
The ofplugin flow registry being modified to handle it in the newer
version of the ofplugin
Change-Id: I07c9b9941bcac2bd5cb82d84898b732bbfc21968
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Anil Vishnoi [Fri, 8 Jul 2016 20:44:45 +0000 (20:44 +0000)]
Merge "BUG-5888: moving the reconciliation process into a different thread to prevent holding on to DTCL thread while provisioning bulk flows/groups."
Shuva Kar [Tue, 7 Jun 2016 18:28:01 +0000 (23:58 +0530)]
BUG-5888: moving the reconciliation process into a different thread to
prevent holding on to DTCL thread while provisioning bulk flows/groups.
Change-Id: I1ee14e6899fdf9d373634de0260a09ab86303e7f
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Jozef Bacigal [Fri, 8 Jul 2016 11:14:46 +0000 (11:14 +0000)]
Merge "Added createEmptyRpcBatchResultFuture method"
michal rehak [Fri, 8 Jul 2016 07:20:00 +0000 (07:20 +0000)]
Merge "Cyclomatic complexity more than 10"
michal rehak [Fri, 8 Jul 2016 07:08:39 +0000 (07:08 +0000)]
Merge "Bug 6161 - PrintStackTrace replaced with logger"
Anil Vishnoi [Fri, 8 Jul 2016 05:52:34 +0000 (05:52 +0000)]
Merge "Fixed debug log messages."
Andrej Leitner [Thu, 7 Jul 2016 14:59:48 +0000 (16:59 +0200)]
Added createEmptyRpcBatchResultFuture method
- duplicated creation replaced by util method
Change-Id: I1dcf8a15c294f0810112c4c9b1bf25dccb0f105c
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
Jozef Bacigal [Wed, 6 Jul 2016 10:17:06 +0000 (12:17 +0200)]
Bug 6161 - PrintStackTrace replaced with logger
Change-Id: I3ce83e9a65d5b6249733338f86f8e3aca24d5412
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>
Jozef Bacigal [Wed, 6 Jul 2016 11:48:19 +0000 (13:48 +0200)]
Cyclomatic complexity more than 10
- Lifecycle conductor changes, more readable
- Connection context small changes
- MDSalRegistrationUtils simplify
Change-Id: Ief4b28dc6a994741bb43aa9a3acf1c7c749ad85e
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>
michal rehak [Thu, 7 Jul 2016 12:11:02 +0000 (12:11 +0000)]
Merge "Bug 6162 Using generic Exceptions"
Jozef Bacigal [Wed, 6 Jul 2016 10:41:30 +0000 (12:41 +0200)]
Bug 6162 Using generic Exceptions
Change-Id: I4a2eccf82799f304beb543b4ef6e026cbfe8da6c
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>
Andrej Leitner [Wed, 6 Jul 2016 07:53:44 +0000 (09:53 +0200)]
Bug 5578 Improve frsync (cleaning)
- method for RPC results merge moved into utils
- updated tests
- renamed methods according to functionality changes
- improved comments
Change-Id: I705941d48e7f459cea9df61487b6a4392480b54f
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
Andrej Leitner [Tue, 28 Jun 2016 16:49:57 +0000 (18:49 +0200)]
Bug 5578 Improve frsync (barriers)
- edit batch futures chaining to wait for barrier
only when it is necessary/planned
Change-Id: I29f18939682c0344e2a23925f6643c9b43463ffe
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
Jozef Bacigal [Wed, 6 Jul 2016 06:11:33 +0000 (06:11 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_13"
Jozef Bacigal [Wed, 6 Jul 2016 06:11:28 +0000 (06:11 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_12"
Jozef Bacigal [Wed, 6 Jul 2016 06:11:23 +0000 (06:11 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_11"
Jozef Bacigal [Wed, 6 Jul 2016 06:11:17 +0000 (06:11 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_10"
Jozef Bacigal [Wed, 6 Jul 2016 06:11:10 +0000 (06:11 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_9"
Jozef Bacigal [Wed, 6 Jul 2016 06:11:04 +0000 (06:11 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_8"
Jozef Bacigal [Wed, 6 Jul 2016 06:10:58 +0000 (06:10 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_7"
Jozef Bacigal [Wed, 6 Jul 2016 06:10:51 +0000 (06:10 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_6"
Jozef Bacigal [Wed, 6 Jul 2016 06:10:45 +0000 (06:10 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_5"
Jozef Bacigal [Wed, 6 Jul 2016 06:10:39 +0000 (06:10 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_4"
Jozef Bacigal [Fri, 1 Jul 2016 11:06:23 +0000 (11:06 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_3"
Jozef Bacigal [Fri, 1 Jul 2016 10:33:54 +0000 (10:33 +0000)]
Merge "Bug 5578 Improve frsync (threadpool)"
Jozef Bacigal [Fri, 1 Jul 2016 10:16:01 +0000 (10:16 +0000)]
Merge "BUG-4117: Migrating notification-supplier from DCN to DTCN"
Jozef Bacigal [Fri, 1 Jul 2016 10:10:33 +0000 (10:10 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_2"
miroslav.macko [Wed, 22 Jun 2016 11:51:14 +0000 (13:51 +0200)]
Bug-5543 - Bo: Update JUnit tests part 11
Added tests for openflowplugin-extension-nicira
Change-Id: I3f77e2bb41f17b6ae1a29572241ca549830781ad
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
miroslav.macko [Wed, 22 Jun 2016 13:49:04 +0000 (15:49 +0200)]
Bug 5543 - Bo: Update JUnit tests part_13
- Added tests for openflowjava-extension-nicira
Change-Id: Ia5af62c8569515a4fa0a3ce80fba5daf76b219b1
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
miroslav.macko [Wed, 22 Jun 2016 13:47:55 +0000 (15:47 +0200)]
Bug 5543 - Bo: Update JUnit tests part_12
- Added tests for openflowjava-extension-nicira
Change-Id: I1b400e3f15f0cb5ac5da647844f1abc613a4848a
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
miroslav.macko [Wed, 22 Jun 2016 13:31:41 +0000 (15:31 +0200)]
Bug 5543 - Bo: Update JUnit tests part_11
- Added tests for openflowjava-extension-nicira
Change-Id: I6fb6f864655c69db933c4d1ebe2adde9189221ab
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>