Release notes for 4.0.8

Change-Id: Iab9e444ceb3b397600081a62c22ac0c6f991841e
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Revert "Bump SpotBugs 3.1.9 → 3.1.10"

This reverts commit 8119cd6455c1c4524671eb69c6274b0780f8cc4d. The
stricter NP_METHOD_PARAMETER_TIGHTENS_ANNOTATION check causes build
failures in other ODL projects.

Change-Id: I333e5e9a9870e1756462520dcba86b89a4a77972
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump commons-fileupload 1.3.3 → 1.4

Release notes:
http://www.apache.org/dist/commons/fileupload/RELEASE-NOTES.txt

Change-Id: If828c54b89dca8dcfb0a7cf51ab97e59c563fd24
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add SLF4J dependency for SpotBugs

The SpotBugs Maven plugin is built with SLF4J 1.8 beta 2, so we need
to give it the appropriate SLF4J implementation (our 1.7 doesn’t work
with it).

JIRA: ODLPARENT-184
Change-Id: I1693928f1a15217aa7a7592e03a81634009ab0b1
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Revert to Immutables 2.7.3

Release 2.7.4 produces invalid Javadocs which break our build (see
https://github.com/immutables/immutables/issues/890 for one example).
This patch reverts to 2.7.3 which produces valid Javadocs. Release
2.7.5 should also be usable; the current snapshot works fine.

Change-Id: Idae6f726080e00197753e2ac93fc062b66670c1c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Avoid pulling old versions

This uses karaf-plugin’s ability to resolve patched features to
upgrade the versions of javax.mail, commons-beanutils, commons-codec
and aries.util pulled in by Karaf and Pax.

We need to change the order of steps in karaf4-parent so that the
Karaf assembly is processed first, then the resources overwritten with
our versions, before karaf-plugin resolves the dependencies.

JIRA: ODLPARENT-189
Change-Id: Id78d7301bd402bc6872fe8a696af9ddc734cbe8d
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Prefer local features

PopulateLocalRepoMojo should prefer features from the local repository
(the Karaf installation repository, typically) to those in the system
repositories: this allows features to be patched, and the patches
taken into account when resolving dependencies.

(Adding the local repository to Aether’s repositories doesn’t have the
intended effect, because the feature dependencies have generally
already been resolved, and are resolved again from the cache when
PopulateLocalRepoMojo runs.)

JIRA: ODLPARENT-189
Change-Id: I232115e0fcdef1ae17c22a17028021f825573e31
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

bump git-commit-id-plugin from 2.2.5 to 2.2.6

Bumps [git-commit-id-plugin](https://github.com/ktoso/maven-git-commit-id-plugin) from 2.2.5 to 2.2.6.
- [Release notes](https://github.com/ktoso/maven-git-commit-id-plugin/releases)
- [Commits](https://github.com/ktoso/maven-git-commit-id-plugin/compare/v2.2.5...v2.2.6)

Change-Id: I2ebaad17d469e3bb6afe09eee113c489be4d5054
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump dependency-check-maven from 4.0.0 to 4.0.2

Bumps [dependency-check-maven](https://github.com/jeremylong/DependencyCheck) from 4.0.0 to 4.0.2.
- [Release notes](https://github.com/jeremylong/DependencyCheck/releases)
- [Changelog](https://github.com/jeremylong/DependencyCheck/blob/master/RELEASE_NOTES.md)
- [Commits](https://github.com/jeremylong/DependencyCheck/compare/v4.0.0...v4.0.2)

Change-Id: Ibc164b047e723ed9caa3fb11d5452376012fb564
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add enunciate-maven-plugin declaration

maven-enunciate-plugin is dead, this patch adds the declaration
for its replacement enunciate-maven-plugin.

Also remove superfluous copy&paste annotation exclusion and mark
old annotations and plugin for removal.

Change-Id: Iee3131019893c5dfad4718d4ed35628cd60ede39
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add odl-dropwizard-metrics

This adds dependency declaration for io.dropwizard.metrics-4.0.5
and also a basic wrapper feature, which provides core, JMX reporter,
healthcheck support and JVM metrics.

Change-Id: If0356b4d6746f95824f30d19323ca286aa7fe857
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rework BouncyCastle/OSGi integration

We are packaging BC jars twice, once in lib/boot for the purposes
of having the provider set by karaf's Main class and second time
to expose them to OSGi world via startup.properties as normal bundles.

This is required because the boot classpath is not exposed directly
into OSGi world and thus bundles linking to BC would not be able
to find correct exports.

An alternative would be to specify all the packages through
org.osgi.framework.system.packages.extra, but that has the downside
of being static and requiring maintentance.

This patch takes the route of Framework Extension Bundles, where
it provides two fragment bundles, which attach to system.bundle,
which itself has access to the boot class loader -- hence they
can themselves contain appropriate Export-Package instructions.

We generate these instructions from upstream bundles by unpacking
their manifest and retaining only Export-Package instruction (via a
simplistic maven plugin) and feeding this as input into
maven-bundle-plugin.

JIRA: ODLPARENT-185
Change-Id: I5cbfc9a499aa117581004585f4fa5283f65a5a38
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove obsolete patched dependencies

karaf4-parent pulls in a number of dependencies which we used to patch
in the underlying feature files; but the upstream features have since
been updated and we no longer patch them, which means we no longer
need to manually depend on these artifacts.

Change-Id: I67c5d7377b5ac85d51b5934e83adc8d90f0d0233
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Enable SpotBugs

Change-Id: Ic8c3237c2f3cda75387af6d2220d401d1c357de6
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Warn on duplicate feature dependencies

When PopulateLocalRepoMojo encounters multiple versions for the
dependencies pulled in through features, it now warns about them.

JIRA: ODLPARENT-189
Change-Id: I916e3dc47e109da9f727eff27b530796649a0218
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Checkstyle 8.15 → 8.16

Release notes: https://checkstyle.org/releasenotes.html#Release_8.16

Change-Id: I1ec37b0a77c05a0458683eecf4f442398a68be57
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump immutables.org to 2.7.4

https://github.com/immutables/immutables#272-2018-11-05
https://github.com/immutables/immutables#273-2018-11-10
https://github.com/immutables/immutables#274-2018-12-26

Change-Id: Iad67173c83c37965c0bb15381166281cffe5938a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add javax.annotation-api declaration

This is another package which karaf provides and Java 11 does not,
which means downstreams need to declare a dependency and we need
to filter it from features.

Change-Id: Id70b29ca3c25b07a8a1a79b92b8e133012c099d6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove javadoc link detection

Enabled detection, while working, is troublesome, throwing a bunch
of errors.

Remove the override, as downstreams can control this trivially
via detectLinks user property. Also remove detectOfflineLinks=true,
as it is the default.

Change-Id: I3839592b391abee7da1cfd388538662e07e77228
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Switch to Maven plugin annotations

This uses plugin annotations instead of Javadoc-based Mojo setup.

Change-Id: Ib3272ec24b7253f9a4a0989ce854cb7847ec0aec
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump SpotBugs 3.1.9 → 3.1.10

... with the associated plugin.

Release notes:
https://github.com/spotbugs/spotbugs/blob/d13e4210b8a5148714ced2562325742fc1fb1baf/CHANGELOG.md

Change-Id: I1b5f0bdd555864ffb82dcfdadd2174c367bc6fe8
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Enforce Checkstyle in karaf-plugin

... and fix the flagged problems.

Change-Id: Ic9620bc2e000f36f54aaa411d97feb5a428f561a
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Jackson 2.9.7 → 2.9.8

Release notes:
https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.9.8

Change-Id: I53c5c5392900bc6996f2b223742fc5298e09b221
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Release notes for 4.0.7

Change-Id: Ibc14d1949f2e5f4e348d5a1110d260065757ef0a
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Release notes for 4.0.6

Change-Id: Ia975f99b3db56fb7451d6e0ed465c8f0da23f608
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Release notes for 4.0.5

Change-Id: I29d70467ba77e0a0cb1631571f403c6d8eb2b906
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Release notes for 4.0.4

Change-Id: Ib86da7d74f1097ad04beb48f3d19e957e6d8e8d1
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Release notes for 4.0.3

Change-Id: I6fff0426ddcb9ccd69fa49add3a2dc8bc9fab2de
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add jaxb-{core,impl}

Java 11 does not ship JAXB, hence downstreams need to pull it in
themselves. Add declarations matching recent Java 8 builds.

Change-Id: I1b32b7a345f3f7a4dfe1f6c663c9db4f30beea26
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add triemap dependency check

This will prevent any breakage from creeping in, like it did
in odlparent-4.0.6.

Change-Id: I39f67a388fb20095b0ccc863b68abcee69f7fd67
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Install BouncyCastle in lib/boot

JDK9 has removed JVM extension mechanism, which leads to jars
present in lib/ext not being accessible by the Main class -- which
we are using to add the provider.

Rather than using lib/ext, use lib/boot, putting the jars onto
the boot class loader.

JIRA: ODLPARENT-183
Change-Id: I32abbc53fa7ca80c2850e9e29fe5991b1193c553
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove duplicate BC provider jars

bcprov-ext-jdk15on is a superset of bcprov-jdk15on, additionally
containing NTRU algorithm. Do not drop both jars into lib/ext,
reducing our distribution by ~4MB.

Change-Id: I66358840fb930d6dbf2d21fee1d1581deab7ad78
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up karaf-4.2.2/JDK9 options

This reworks the workaround to use OptionUtils and
dynamically-determined karafVersion.

Change-Id: I5b46a5b8dd5aed42aeebcb5d7ae2c8238c2a0167
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enable detectLinks in javadoc

We have bumped javadoc plugin to 3.0.1 without removing the workaround
for MJAVADOC-427, which is fixed in that release.

Flip the switch, addressing the TODO.

Change-Id: I881c4750deb45d402c38ba8b0dd2a23e57c567e9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 4.0.8-SNAPSHOT

This starts the next development iteration.

Change-Id: I0acc47ae0b674b692afc280241b8c6e83307420e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix triemap dependency declaration

The declaration is missing type=pom, fix that.

Change-Id: Ide9249a081f255c429e46f69fe9bc2f5d66e6587
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 4.0.7-SNAPSHOT

This starts the next development iteration.

Change-Id: I3f683f163298b71742bc8777c1d430ccb3e2bcc6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Import triemap bom

triemap is used by yangtools and controller, make sure we declare
the version from odlparent.

Change-Id: Ifa2aeac691a4aac7e79424feb73d2d535c6df0e5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add JDK9+ karaf configuration

karaf-4.2.2 and later needs additional JVM configuration to work
with JDK9+, otherwise it fails to boot.

This patch adds that configuration based on Karaf's ExampleITest.

Change-Id: I547329afb1fdad990a4a13b8001be78f7c676497
JIRA: ODLPARENT-182
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add a maven central bandge

Now that odlparent is published to central, we can add a nice badge
for github users. While we're at it, also add a license badge.

Change-Id: I585110574ce247d381cf38547dcbb9dd65cc6381
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 4.0.6-SNAPSHOT

Change-Id: Ib40d10492acdac7dbd1ba09f4013add5e8c0752d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Fixup karaf4-parent installation"

This reverts commit 2d60028313174d77710753a6b07790e9b3bcf1c2,
as it does not help at all.

Change-Id: I50163d9b41ae1cac9a49563fa9bd0e707c2a2878
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Restore Karaf deployments

karaf-maven-plugin 4.2.2 breaks installation of Karaf archives: the
POM is deployed with a ZIP extension. This patch reverts to 4.2.1 only
for karaf4-parent, fixing the issue temporarily.

Change-Id: Ie06c65d673b0d1782a1e9f0878f27c86886828da
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Fixup karaf4-parent installation

It would seem karaf-plugin-4.2.2 does not correctly work with
maven-install-plugin-2.5.2, resulting in pom.xml being installed
as .zip, breaking downstreams.

Bump maven-install-plugin (and deploy-plugin) in karaf4-parent
to 3.0.0-M1 in an attempt to fix the issue.

Change-Id: Iae551ba413a5b6b183ef666258db15b184824218
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Start odlparent 4.0.5-SNAPSHOT

Change-Id: I9ac6066d0db631ecfc03e5507e82c212d5012df3
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Revert "Support building without zip archives"

This reverts commit dd16e4611811b9fc7add790bf364f805d2795b93, which
breaks builds on our infrastructure (without the empty Karaf
archive).

Change-Id: I8f6cb74c97a827175f8bd6089c6b9a5217aae78e
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Start odlparent 4.0.4-SNAPSHOT

Change-Id: Id6f1c7d0dfe0eba65cfdd2499df0372fb183e43e
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump karaf to 4.2.2

https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12343458&projectId=12311140

Also align versions:
- ow2.asm 6.2.1 -> 7.0
- org.apache.felix.metatype 1.2.0 -> 1.2.2
- pax-web-api 7.2.2 -> 7.2.5
- jetty 9.4.11.v20180605 -> 9.4.12.v20180830
- blueprint-core 1.9.0 -> 1.10.1
- jaxb-api 2.2.1 -> 2.2.8

Change-Id: I137a33da4ad55fe8b81f4f006c939aca809a080c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Recognize Sonar build

Sonar jobs are running with -Dsonar, which is a clue for us to
disable various plugins, which do not affect the result of the
analysis.

Change-Id: I0e1ee1392703b7b1efd96d3eb91d7367130abf59
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump pax-exam to 4.13.1

https://ops4j1.jira.com/issues/?jql=project+%3D+PAXEXAM+AND+fixVersion+%3D+4.13.0
https://ops4j1.jira.com/issues/?jql=project+%3D+PAXEXAM+AND+fixVersion+%3D+4.13.1

Change-Id: I635b1285e87c4128034eb9005cb75a4c17648909
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-jar-plugin to 3.1.1

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317526&version=12343046

Change-Id: I30ed94901baa0d5172fea2609590745cd50e6f47
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-help-plugin to 3.1.1

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317522&version=12343422

Change-Id: I7cb2cfa560ed27eb32bf71b8b969035efe2ee045
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Constrain dependencies for convergence

This adds a number of third-party artifacts to dependency management,
in order to control dependency convergence. These artifacts are used
in various versions by other third-party dependencies; by constraining
them (to mutually-compatible versions), we can then hope to enforce
dependency convergence.

Change-Id: Ifa7bd7fb5252958f3ca51d3a648a7d595bfdf119
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Teach top-level aggregator about jacoco/sonar

This adds the profile to merge all jacoco reports, so that sonar
job can use the aggregated file.

Change-Id: Ica0f7f5052670fe3619e4dfbd003147d3bd5b5b1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Switch to LevelDB 0.10

Akka Persistence now expects LevelDB 0.10, switch to that. Drop the
0.7 artifact from the feature repository to avoid dependency
convergence issues. (We still ship the old artifact to preserve
backwards compatibility.)

Change-Id: Id104805879a70576eafc55c4acc8f2d57a54c1a1
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump akka to 2.5.19

https://akka.io/blog/news/2018/08/24/akka-2.5.15-released
https://akka.io/blog/news/2018/08/29/akka-2.5.16-security-fix-released
https://akka.io/blog/news/2018/09/27/akka-2.5.17-released
https://akka.io/blog/news/2018/10/07/akka-2.5.18-released
https://akka.io/blog/news/2018/12/07/akka-2.5.19-released

This also bumps dependencies for alignment:
- ssl-config to 0.3.6:
https://github.com/lightbend/ssl-config/milestone/9?closed=1
https://github.com/lightbend/ssl-config/milestone/10?closed=1
https://github.com/lightbend/ssl-config/milestone/11?closed=1
https://github.com/lightbend/ssl-config/compare/v0.3.4...v0.3.6

- aeron to 1.12.0:
https://github.com/real-logic/aeron/releases/tag/1.10.0
https://github.com/real-logic/aeron/releases/tag/1.10.1
https://github.com/real-logic/aeron/releases/tag/1.10.2
https://github.com/real-logic/aeron/releases/tag/1.10.3
https://github.com/real-logic/aeron/releases/tag/1.10.4
https://github.com/real-logic/aeron/releases/tag/1.10.5
https://github.com/real-logic/aeron/releases/tag/1.11.0
https://github.com/real-logic/aeron/releases/tag/1.11.1
https://github.com/real-logic/aeron/releases/tag/1.11.2
https://github.com/real-logic/aeron/releases/tag/1.11.3
https://github.com/real-logic/aeron/releases/tag/1.12.0

- agrona to 0.9.27:
https://github.com/real-logic/agrona/releases/tag/0.9.22
https://github.com/real-logic/agrona/releases/tag/0.9.23
https://github.com/real-logic/agrona/releases/tag/0.9.24
https://github.com/real-logic/agrona/releases/tag/0.9.25
https://github.com/real-logic/agrona/releases/tag/0.9.26
https://github.com/real-logic/agrona/releases/tag/0.9.27

Change-Id: Ib528e5c63526c6f1355f07e99690c0d6c0b2bcea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump xtend to 2.16.0

The full release of xtend is available in maven central, bump
to it instead of M3 build.

Change-Id: I12934fb2bc393903c25e64b8af80aa9f5e09ee85
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump asciidoctorj-diagram 1.5.10 → 1.5.11

Change-Id: Ifc81dedae5f33f32763d5dc3ca3129be992ab88c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump scala to 2.12.8

https://github.com/scala/scala/releases/tag/v2.12.8

Change-Id: I4a223c20b643d341ce8f3489ef1ecb11b0af8823
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Disable NPE NULL check

As noted https://github.com/spotbugs/spotbugs/issues/756,
this check is triggered by Java 11's desugraing of try-with-resources.

Change-Id: If826874c3023c85edcd40294329f6fff29ba66df
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Checkstyle 8.14 → 8.15

Release notes: https://checkstyle.org/releasenotes.html#Release_8.15

Change-Id: I6cb04fc68e637591338eeee7934363fbd355e101
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Checkstyle 8.13 → 8.14

Release notes: https://checkstyle.org/releasenotes.html#Release_8.14

Change-Id: I003d58aa9b6f70e32ab61d1ce2cbf18f2bf70a80
Signed-off-by: Stephen Kitt <skitt@redhat.com>

bump checkstyle from 8.12 to 8.13

Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.12 to 8.13.
- [Release notes](https://github.com/checkstyle/checkstyle/releases)
- [Commits](https://github.com/checkstyle/checkstyle/compare/checkstyle-8.12...checkstyle-8.13)

Change-Id: Id7840883dc1421f9025cd6f0bbe7b5aa90c10a15
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump xtend to 2.16.0.M3

While this is a milestone release, it fixes xtend-maven-plugin
with Java 11 and seems to work okay.

Change-Id: Iabd69ccfa1ee48ff2732a7f214dd988c6eb7b3d2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Mockito 2.20.1 → 2.23.4

Release notes:
https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md

2.22.1 provides support for Java 11.

Change-Id: I7adcd9ff526f3fe93681e167eab8df35624a451a
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Ignore META-INF versions duplicates

These are used in newer modules provided by ByteBuddy.

Change-Id: I9712b953cb0b65d16db5a6b8ab045b9cc4f41e89
Signed-off-by: Stephen Kitt <skitt@redhat.com>

bump xbean-finder-shaded from 4.9 to 4.12

Change-Id: Id6d91c85dcee74ccee63bc18224cb4899b340143
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump javassist to 3.24.0-GA

There are no explicit release notes, the changes are at:

https://github.com/jboss-javassist/javassist/compare/rel_3_23_1_ga...rel_3_24_0_ga

Most notable is the fix for Powermock-induced CME and Java 11 support.

Change-Id: I4fb6330def0219e59bdf88ea9e66e04c33b45f4e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

bump dependency-check-maven from 3.3.4 to 4.0.0

Bumps [dependency-check-maven](https://github.com/jeremylong/DependencyCheck) from 3.3.4 to 4.0.0.
- [Release notes](https://github.com/jeremylong/DependencyCheck/releases)
- [Changelog](https://github.com/jeremylong/DependencyCheck/blob/master/RELEASE_NOTES.md)
- [Commits](https://github.com/jeremylong/DependencyCheck/compare/v3.3.4...v4.0.0)

Change-Id: Ib2c0b9aa5386abff0ed8caa33a0bbef025656d3c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump maven-shade-plugin from 3.2.0 to 3.2.1

Bumps [maven-shade-plugin](https://github.com/apache/maven-shade-plugin) from 3.2.0 to 3.2.1.

There are Release Notes on
https://blog.soebes.de/blog/2018/11/12/apache-maven-shade-plugin-version-3-dot-2-1-released/
and https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&version=12344059,
[Commits](https://github.com/apache/maven-shade-plugin/compare/maven-shade-plugin-3.2.0...maven-shade-plugin-3.2.1),
pointing to https://issues.apache.org/jira/browse/MSHADE-302 as a
worthwhile reason to upgrade for better Java 11 support.

Change-Id: Idf8a02396fba47640075306433930be76aa79cd0
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump spotbugs from 3.1.7 to 3.1.9

Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 3.1.7 to 3.1.9.
- [Release notes](https://github.com/spotbugs/spotbugs/releases)
- [Changelog](https://github.com/spotbugs/spotbugs/blob/release-3.1/CHANGELOG.md)
- [Commits](https://github.com/spotbugs/spotbugs/compare/3.1.7...3.1.9)

Change-Id: Iae42638988be6adcbf13fffb2cae21c8c6dc3412
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump maven-remote-resources-plugin 1.5 to 1.6.0

Bumps [maven-remote-resources-plugin](https://github.com/apache/maven-remote-resources-plugin) from 1.5 to 1.6.0.
- [Release notes](https://blogs.apache.org/maven/entry/apache-maven-remote-resources-plugin)
- [Commits](https://github.com/apache/maven-remote-resources-plugin/compare/maven-remote-resources-plugin-1.5...maven-remote-resources-plugin-1.6.0)

Change-Id: I971714196d4bc981493256fb6213288fc67d4ba5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Disable explicit GCs by default

This adds -XX:+DisableExplicitGC to the JVM options, so that explicit
calls to System.gc() are no longer taken into account. They’re
counter-productive anyway on modern JVMs.

Change-Id: If6cc12a80897e2cd6c394f639e4f4a63c17db031
JIRA: ODLPARENT-175
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump asciidoctorj-diagram 1.5.9 → 1.5.10

There doesn’t appear to be any release notes.

Change-Id: Ie11ff17de553a61a389f44fa7fa1b0b7ea7c11ac
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Support building without zip archives

The build can be configured to skip zip or tar.gz archives (or even
both). Currently if zip archives are disabled, the build fails since
features-test expects a zip archive; this patch allows either a zip or
a tar.gz to be used, depending on what's built.

If both are disabled the build will fail unless it can retrieve a
matching archive from a repository. The nominal configuration is still
to build both.

JIRA: ODLPARENT-174
Change-Id: I858810767bcca452eebf52107ee76be129f85192
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump maven-bundle-plugin from 4.0.0 to 4.1.0

There are no release notes e.g. on
https://svn.apache.org/repos/asf/felix/releases/maven-bundle-plugin-4.1.0/changelog.txt
or elsewhere that I can find.

and straight from 3.5.0 to 4.1.0 in
karaf/karaf-branding/pom.xml, where we seem
to have forgotten to bump back in
https://git.opendaylight.org/gerrit/#/c/75675/

Change-Id: Icc1b01f43bedea29f037ff8a079fc5ccd96c186a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump spotbugs-maven-plugin to 3.1.8

The plugin doesn’t seem to have release notes;
https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-3.1.7...spotbugs-maven-plugin-3.1.8
shows the changes.

Change-Id: I988f6118161b2ffa89d5c8f8184706d26c868974
Signed-off-by: Stephen Kitt <skitt@redhat.com>

bump maven-pmd-plugin from 3.10.0 to 3.11.0

Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.10.0 to 3.11.0.
- [Release notes](https://blogs.apache.org/maven/entry/apache-maven-pmd-plugin-3)
- [Commits](https://github.com/apache/maven-pmd-plugin/compare/maven-pmd-plugin-3.10.0...maven-pmd-plugin-3.11.0)

Change-Id: I749801b38c09fa588099d6573874c4259f0776b2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

bump maven-failsafe-plugin from 2.22.0 to 2.22.1

Bumps [maven-failsafe-plugin](https://github.com/apache/maven-surefire) from 2.22.0 to 2.22.1.
- [Release notes](https://blogs.apache.org/maven/entry/apache-maven-surefire-plugin-version1)
- [Commits](https://github.com/apache/maven-surefire/compare/surefire-2.22.0...surefire-2.22.1)

Change-Id: Ib03e878f07c868c251ca92da5809dfa4cc584b49
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

bump maven-surefire-plugin from 2.22.0 to 2.22.1

Bumps [maven-surefire-plugin](https://github.com/apache/maven-surefire) from 2.22.0 to 2.22.1.
- [Release notes](https://blogs.apache.org/maven/entry/apache-maven-surefire-plugin-version1)
- [Commits](https://github.com/apache/maven-surefire/compare/surefire-2.22.0...surefire-2.22.1)

Change-Id: I8d6afcc1ab1c44b26586e048105d3a1704c08c40
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

bump wagon-http from 3.1.0 to 3.2.0

Change-Id: I0479b92bab5d35d45244e28198ed65b40cd3724f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump org.eclipse.jdt.annotation 2.2.0 to 2.2.100

Change-Id: Ie95f9c3c092085619b1b21adc6e09a098be9ec17
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump dependency-check-maven from 3.3.2 to 3.3.4

Bumps [dependency-check-maven](https://github.com/jeremylong/DependencyCheck) from 3.3.2 to 3.3.4.
- [Release notes](https://github.com/jeremylong/DependencyCheck/releases)
- [Changelog](https://github.com/jeremylong/DependencyCheck/blob/master/RELEASE_NOTES.md)
- [Commits](https://github.com/jeremylong/DependencyCheck/compare/v3.3.2...v3.3.4)

Change-Id: I9251ed406fc97848a64f30589661be474a7f9f0f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

bump spotbugs-maven-plugin from 3.1.6 to 3.1.7

Bumps [spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 3.1.6 to 3.1.7.
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-3.1.6...spotbugs-maven-plugin-3.1.7)

Change-Id: I02eb35a8d0eee42ccbe2eb3c3cf15f199b3b1605
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Upgrade netty to 4.1.31

https://netty.io/news/2018/10/30/4-1-31-Final.html

Change-Id: I747867eb6bb3b64ee7725328064119a8af9665ab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

bump asciidoctor-maven-plugin 1.5.7 to 1.5.7.1

Bumps [asciidoctor-maven-plugin](https://github.com/asciidoctor/asciidoctor-maven-plugin) from 1.5.7 to 1.5.7.1.
- [Release notes](https://github.com/asciidoctor/asciidoctor-maven-plugin/releases)
- [Commits](https://github.com/asciidoctor/asciidoctor-maven-plugin/compare/asciidoctor-maven-plugin-1.5.7...asciidoctor-maven-plugin-1.5.7.1)

Change-Id: Idcc70001a1fc1efcb77f3663c5975289b4e92a1e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add javax.activation:activation to exclusions

Karaf provides version 1.1.1 of this from its boot classpath,
hence we should never emit references to it.

Change-Id: I3585e9aa56afcc7f22c6139ba6404221d3142f88
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump commons-text 1.5 → 1.6

Release notes:
http://www.apache.org/dist/commons/text/RELEASE-NOTES.txt

Change-Id: I36ead59ee9578223224d69efa0bab84baec73eaa
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add odl-jersey-2 feature

This adds an upgraded version of jersey, so we do not end up
packaging it multiple times by downstreams.

Change-Id: I64323615b9dbd289b2d9ae3296525397b5bd6391
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add odl-servlet-api feature

javax.servlet:javax.servlet-api is being packaged by multiple
downstream features: infrautils, controller, aaa. Provide a common
packaging of this bundle.

Change-Id: I16da5a398bb926adf4cb78c1c675a2c99c904542
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add odl-ws-rs-api feature

javax.ws.rs/javax.ws.rs-api is being used by jackson-2.9, jersey2
as well as aaa APIs. Package it as a separate feature, so it can
be reused.

Change-Id: If8dd354e99d32165b5c7554a79007634bcd78809
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add odl-stax2-api feature

stax2-api.jar is used by both odl-jackson-2.9 and yangtools (without
an implementation). Package it in a common feature so it gets reused.

Change-Id: I45cc31fe102bfa1726613ce24eaccaf817562190
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add odl-gson feature

At least yangtools and infrautils are installing the gson bundle
separately. Introduce a common feature to host it.

Change-Id: Ic69b86c4869cb5b7052283486b9253bbd94bce74
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add odl-antlr4 feature

We have multiple downstream features packaging antlr4-runtime,
add is a feature so we can reuse a single source of it.

Change-Id: I1cf38630f289c76f4e2fcee2c6c84699fe6d1c6f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix odl-jackson artifact declaration

We are providing odl-jackson-2.9 now. Also update features-odlparent
to reference features without their version, so as to check
odlparent-artifacts.

Change-Id: Ic228131c7b5243c31666b0c8a2728d3562bd99a1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add JAXB handling for Java 11

JAXB modules have been removed from Java 11, hence applications
using them need to declare a dependency on them. These modules
are provided on Karaf's boot classpath, hence we should be filtering
them from features.

Change-Id: I92a2b349c50caaa61d390ed0860901597a6b32f6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make annotations optional

JSR-305 annotations are strictly optional to resolve, as they do not
affection production funcionality. Make sure we mark them as such,
which prevents downstreams failing with newer JDK.

Change-Id: I869e0c84f9762e2abfb10b994890fe98cdb850ce
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump commons-text 1.4 → 1.5

Release notes:
http://www.apache.org/dist/commons/text/RELEASE-NOTES.txt

Change-Id: I2e025705124c658e635ea4403ae2985f0d7f5181
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Skip spotbugs in quick profile

This adds the knob to disable spotbugs on quick builds.

Change-Id: I021907289c853b5d322095149e97ffc312c4cb01
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add powermock-api-mockito2

To support downstreams still using powermock, add mockito2-compatible
api declaration.

Change-Id: I1ce1d4d65bdc7dd20b53157518b5be53fabf8265
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>