openflowplugin.git
9 years agoBug 1254 - added basic functionality test for OFRpcTaskUtil 57/11757/2
Martin Bobak [Tue, 30 Sep 2014 07:33:43 +0000 (09:33 +0200)]
Bug 1254 - added basic functionality test for OFRpcTaskUtil

- removed unused method OFRpcTaskUtil#wrapBarrierErrors

Change-Id: I6ad9cfdf22f12fd00fd6d8727e8cad730d788dae
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - added basic functionality test for TableFeaturesConvertor 11/11611/4
Martin Bobak [Fri, 26 Sep 2014 08:56:59 +0000 (10:56 +0200)]
Bug 1254 - added basic functionality test for TableFeaturesConvertor

Change-Id: Idd990ad4e479f4f67945e053a77ecc2de0ffe261
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBUG 1254 - test for PacketInV10Translator.java 46/11746/2
Jakub [Fri, 3 Oct 2014 19:20:08 +0000 (21:20 +0200)]
BUG 1254 - test for PacketInV10Translator.java

Signed-off-by: Jakub <jatoth@cisco.com>
9 years agoBug 1254 - Added MatchConvertorImpl unit tests 68/11668/3
Michal Polkorab [Thu, 25 Sep 2014 12:25:29 +0000 (14:25 +0200)]
Bug 1254 - Added MatchConvertorImpl unit tests

 - FIXME - mask computation of PbbIsid match entry (both ways)
 - FIXME - add mask computation for ArpSpa and ArpTpa match entries
 - TODO - finish implementation of vlan vid match entry - isVlanIdPresent() is not set

Change-Id: I9ba5da086584db2e678a79486376a0f9de4b30f0
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
9 years agoBug 1254 - Added NotificationPlainTranslator and TypeVersionKey unit tests 70/11670/2
Michal Polkorab [Tue, 30 Sep 2014 13:29:53 +0000 (15:29 +0200)]
Bug 1254 - Added NotificationPlainTranslator and TypeVersionKey unit tests

Change-Id: I3d2f6f52eaa4082660bc452f7d1160799d849359
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
9 years agoSwitched back on dlux circular dependency for post-helium master 73/11873/1
Michal Rehak [Fri, 10 Oct 2014 07:48:19 +0000 (09:48 +0200)]
Switched back on dlux circular dependency for post-helium master

Change-Id: Ie0725cd0f5bccbec3c8a4867d22c99fdbf24b623
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoIncrementing versions by 0.1.0 for post-helium master branch 75/11775/2
Michal Rehak [Tue, 7 Oct 2014 11:43:25 +0000 (13:43 +0200)]
Incrementing versions by 0.1.0 for post-helium master branch

+ temporarily disabled dlux in features (pom.xml, features.xml) in order
  to avoid cyrcular dependency during release

Change-Id: Ibc5c80c3252e1e3e52816b3ffc25ac3e5559e250
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBug 2128: Send SET_CONFIG message to OF10 switch. 01/11701/2
Shigeru Yasuda [Wed, 1 Oct 2014 14:24:10 +0000 (23:24 +0900)]
Bug 2128: Send SET_CONFIG message to OF10 switch.

Change-Id: I8c596d0f2969ea054829955c2ca90fbeaab4e954
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
9 years agoBug 2127: Fixed bugs in MatchConvertorImpl.fromOFMatchV10ToSALMatch(). 00/11700/1
Shigeru Yasuda [Wed, 1 Oct 2014 13:13:52 +0000 (22:13 +0900)]
Bug 2127: Fixed bugs in MatchConvertorImpl.fromOFMatchV10ToSALMatch().

  * TOS value in NW_TOS match field needs to be converted into
    IP DSCP value.
  * DSCP match field should be configured into a MD-SAL match unless
    NW_TOS wildcard bit is set in OF10 match.

Change-Id: Ie4d5dbf8a9db564a0e6785fea880b0d78cc1f499
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
9 years agoBug 2126: Fixed bugs in MatchConvertorImpl.OfMatchToSALMatchConvertor(). 92/11692/3
Shigeru Yasuda [Wed, 1 Oct 2014 10:37:42 +0000 (19:37 +0900)]
Bug 2126: Fixed bugs in MatchConvertorImpl.OfMatchToSALMatchConvertor().

  * Convert IN_PORT match field value into URI of the specified
    switch port.
  * Copy CFI bit in VLAN_VID field into MD-SAL match.

Change-Id: I7098b99e20538bbaaab391b45b2c87b4157f7d90
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
9 years agoBug 2103: Fix hash collisions preventing some switches from registering 75/11675/1
Ed Warnicke [Tue, 30 Sep 2014 19:59:32 +0000 (12:59 -0700)]
Bug 2103: Fix hash collisions preventing some switches from registering

Change-Id: I3131f80ebd2c6731febd600d3701f1de2bd23cd8
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoBUG-1994: IP ToS bits match field for OF 1.0 61/11661/1
Michal Rehak [Mon, 29 Sep 2014 13:40:46 +0000 (15:40 +0200)]
BUG-1994: IP ToS bits match field for OF 1.0

- fixed TOS conversion for match by OF-1.0

Change-Id: I57449e4b8413801e890e8add31819dbc39dc6190
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBug:2103 Insure that we start the InventoryManager and friends first 32/11632/1
Ed Warnicke [Sat, 27 Sep 2014 21:29:24 +0000 (14:29 -0700)]
Bug:2103 Insure that we start the InventoryManager and friends first

If the InventoryManager and friends are not started before
the openflowplugin begins accepting connections, they may not
be informed and thus not record whole nodes.

Change-Id: I24be7991d3ee9022ca95b2e85bb8eb445cdf7dc9
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoBug 1254 - added basic functionality tests for FeaturesV10ToNodeConnectorUpdatedTrans... 73/11573/2
Martin Bobak [Thu, 25 Sep 2014 10:34:06 +0000 (12:34 +0200)]
Bug 1254 - added basic functionality tests for FeaturesV10ToNodeConnectorUpdatedTranslator

Change-Id: Ie4e6c31e1409387176993389521fee3618b098c7
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBUG 1254 - Test for PacketOutConvertor 83/11483/5
Jakub [Tue, 23 Sep 2014 10:50:06 +0000 (12:50 +0200)]
BUG 1254 - Test for PacketOutConvertor

Signed-off-by: Jakub <jatoth@cisco.com>
Change-Id: I45a8445966a3265eb86429eea666c86ee629b5d2

9 years agoMerge "BUG-2091: notification NodeRemoved and processing queue"
Abhijit Kumbhare [Fri, 26 Sep 2014 02:48:24 +0000 (02:48 +0000)]
Merge "BUG-2091: notification NodeRemoved and processing queue"

9 years agoBug 1254 - yet another attempt to exclude yang generated files from sonar report 31/11531/2
Martin Bobak [Wed, 24 Sep 2014 14:34:00 +0000 (16:34 +0200)]
Bug 1254 - yet another attempt to exclude yang generated files from sonar report

Change-Id: Ie9fc66fb359df518d716f8fc440a50c4b1577caf
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - added basic functionality test for FlowRemovedTranslator 30/11530/3
Martin Bobak [Wed, 24 Sep 2014 13:27:24 +0000 (15:27 +0200)]
Bug 1254 - added basic functionality test for FlowRemovedTranslator

Change-Id: I4f71f75575c5f43908c2ebd21996cacc98157bdc
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoMerge "Bug 2071: Check to see if we still have the switch in LLDPSpeaker"
Abhijit Kumbhare [Thu, 25 Sep 2014 17:04:16 +0000 (17:04 +0000)]
Merge "Bug 2071:  Check to see if we still have the switch in LLDPSpeaker"

9 years agoBUG-2091: notification NodeRemoved and processing queue 91/11591/1
Michal Rehak [Thu, 25 Sep 2014 16:32:18 +0000 (18:32 +0200)]
BUG-2091: notification NodeRemoved and processing queue

- NodeRemoved notification is now enqueued in the same way
  as other notifications so that original order will be preserved
  and "homeless" messages eliminated
- NodeUpdated must use the same way of delivery to MD-SAL in order
  to preclude state where during reconnect nodeAdded would arrive
  before nodeRemoved

Change-Id: Iede472870fac9ce12e7e5817c9b21967a2a43173
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBug 2071: Check to see if we still have the switch in LLDPSpeaker 57/11557/2
Ed Warnicke [Thu, 25 Sep 2014 03:02:39 +0000 (22:02 -0500)]
Bug 2071:  Check to see if we still have the switch in LLDPSpeaker

It can sometimes happen that we can loose our connection to a Node
Connector while we still have NodeConnectorUpdates to process.

When this happens, we will get a null md in LLDPSpeaker, and should
just drop the messages there.

Change-Id: Ie5810c5c00fbaeb7022f2496da7166edf109678d
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoBug 1254 - added unit tests for MultiPartReplyPortToNodeConnectorUpdatedTranslator 69/11569/2
Michal Polkorab [Wed, 24 Sep 2014 13:45:10 +0000 (15:45 +0200)]
Bug 1254 - added unit tests for MultiPartReplyPortToNodeConnectorUpdatedTranslator
 and MultipartReplyTableFeaturesToTableUpdatedTranslator

Change-Id: I3648eeb8ec37f93f53c1c3a93fc0853e4ed7ad5b
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
9 years agoBug 1254 - Added MultiPartMessageDescToNodeUpdatedTranslatorTest 95/11495/2
Michal Polkorab [Tue, 23 Sep 2014 15:56:00 +0000 (17:56 +0200)]
Bug 1254 - Added MultiPartMessageDescToNodeUpdatedTranslatorTest

Change-Id: Ic66f0a63f0634888d838b4d503817f7b42a00661
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
9 years agoBug 1254 - Finished MultipartReplyTranslator tests 93/11493/2
Michal Polkorab [Tue, 23 Sep 2014 14:39:24 +0000 (16:39 +0200)]
Bug 1254 - Finished MultipartReplyTranslator tests

 - added tested method in javadoc
 - renamed existing MultipartReplyTranslator tests with name ending with number
   as those tests were not included in Sonar analysis
 - contains TODO for MeterConfig case - missing flags translation and also
   prec_level for DscpRemark band type

Change-Id: I72610f31bc0ba8991564e90b142f19d4b54ef65f
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
9 years agoBug 2071: Improved Null checking and logging in LLDPSpeaker 56/11556/4
Ed Warnicke [Thu, 25 Sep 2014 02:06:46 +0000 (21:06 -0500)]
Bug 2071: Improved Null checking and logging in LLDPSpeaker

Change-Id: Ic2717fd5f5abd163f334ef668e6027b525315dd1
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoBug 2068: Fix NPE in OFRPCUtil$1.onSuccess, improve logging. 43/11543/4
Ed Warnicke [Wed, 24 Sep 2014 20:06:39 +0000 (15:06 -0500)]
Bug 2068: Fix NPE in OFRPCUtil$1.onSuccess, improve logging.

Change-Id: I748b5e2dbf335a03bb7c3eaa1adbb5b468be8355
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoBug 2051: Catch exceptions in firePopListener 49/11549/2
Ed Warnicke [Wed, 24 Sep 2014 23:10:23 +0000 (18:10 -0500)]
Bug 2051: Catch exceptions in firePopListener

Change-Id: Idfeb9ec9e76e168df821554f8ab096de6d007b8a
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoBug 1254 - added basic functionality test for LLDPSpeakerPopListener 86/11486/2
Martin Bobak [Tue, 23 Sep 2014 12:02:30 +0000 (14:02 +0200)]
Bug 1254 - added basic functionality test for LLDPSpeakerPopListener

Change-Id: I3e03964ed9f96158f940e714b1da0666253499c0
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 2061 - DropRate and BurstSize swapped - fixed tests 11/11511/1
Devin Avery [Wed, 24 Sep 2014 07:01:44 +0000 (03:01 -0400)]
Bug 2061 - DropRate and BurstSize swapped - fixed tests

This bug fixes an issue where the dropRate and burst size were swapped in code.
This bug also fixes the unit tests which tested for the bug instead. Made the test use hard-coded constants so inputs matched expected outputs which then caught the bug.

Signed-off-by: Devin Avery <devin.avery@brocade.com>
9 years agoBug 1948: Separate out restconf features 71/11471/4
Ed Warnicke [Tue, 23 Sep 2014 02:09:58 +0000 (21:09 -0500)]
Bug 1948: Separate out restconf features

In order to avoid a maven project cycle in solving
Bug 1948, we need to separate restconf features.
Note, this is a first step, suffixing everything
with -new.  Subsquently, after everywhere using
odl-restconf has been fixed to use this new repo,
we will deprecate the ones in the mdsal features.xml
and rename these to not have the -new.

This patch just adds the dependency to features/pom.xml

Change-Id: Ie22375e154848bbf5f7ab0336e6fb695e529c862
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoMerge "BUG-1626: low cbench performance against dataStore"
Ed Warnicke [Mon, 22 Sep 2014 22:39:28 +0000 (22:39 +0000)]
Merge "BUG-1626: low cbench performance against dataStore"

9 years agoMerge "BUG-1997: moving barrier after message"
Ed Warnicke [Mon, 22 Sep 2014 22:21:10 +0000 (22:21 +0000)]
Merge "BUG-1997: moving barrier after message"

9 years agoBUG-1626: low cbench performance against dataStore 58/11458/1
Michal Rehak [Mon, 22 Sep 2014 16:19:25 +0000 (18:19 +0200)]
BUG-1626: low cbench performance against dataStore

- replaced constant flow.id with incremented value

Change-Id: Iae146611d54782805260c8341504ac6661213dc8
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBUG-1997: moving barrier after message 57/11457/1
Michal Rehak [Mon, 22 Sep 2014 20:39:12 +0000 (22:39 +0200)]
BUG-1997: moving barrier after message

- before <message>.isBarrier rendered into barrier exchange before message
  now barrier exchange occurs after message

Change-Id: I1e4c4738eedef50b737a2d395123873156740df6
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBug 1985 - NPE when running groupbasedpolicy POC demo 56/11456/1
Martin Bobak [Mon, 22 Sep 2014 12:42:13 +0000 (14:42 +0200)]
Bug 1985 - NPE when running groupbasedpolicy POC demo

- OFSessionUtild doesn't set session as valid anymore, session
  management moved to SessionManagerOFImpl
- session validation/invalidation is synchronized
- when registration is about to be closed SalRegistrationManager checks
  whether session from which registration is originated is valid

Change-Id: I2c523586676d3533aaf84afd2cecc38bd53181f4
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoMerge "BUG-2012: stats via jmx failing with exception"
Ed Warnicke [Mon, 22 Sep 2014 00:12:30 +0000 (00:12 +0000)]
Merge "BUG-2012: stats via jmx failing with exception"

9 years agoBUG-2012: stats via jmx failing with exception 29/11429/1
Michal Rehak [Sun, 21 Sep 2014 22:52:38 +0000 (00:52 +0200)]
BUG-2012: stats via jmx failing with exception

- removed trailing spaces on right (formatting experiment consequences)

Change-Id: Ic1048f994e33cb724d7a9b419dae8bdee26223ea
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBUG-1988: OF Plugin changes the order of NodeConnector update events 2 28/11428/2
Michal Rehak [Sun, 21 Sep 2014 08:54:43 +0000 (10:54 +0200)]
BUG-1988: OF Plugin changes the order of NodeConnector update events 2

- processing of messages is now turned on after features delivery
  and service registrations - messages must wait till registration done
- moved enqeueueing of featureReply (for OF-1.0) in front of registration code
  (for registration takes some time during which port updates arrive)

Change-Id: I0a25974b9c51eccb2772af44685c613b83dc098f
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoMerge "Bug 1254 - Added unit tests"
Prasanna Huddar [Sun, 21 Sep 2014 09:32:44 +0000 (09:32 +0000)]
Merge "Bug 1254 - Added unit tests"

9 years agoMerge "BUG-1952 Flow update rpc"
Prasanna Huddar [Sun, 21 Sep 2014 09:32:25 +0000 (09:32 +0000)]
Merge "BUG-1952 Flow update rpc"

9 years agoBUG-1988: OF Plugin changes the order of NodeConnector update events 16/11416/1
Michal Rehak [Sun, 21 Sep 2014 08:54:43 +0000 (10:54 +0200)]
BUG-1988: OF Plugin changes the order of NodeConnector update events

- processing of messages is now turned on after features delivery
  and service registrations - messages must wait till registration done

Change-Id: Ibc08ccc176ae87c021e0741dcf672f6f2a98a341
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBUG-1952 Flow update rpc 06/11406/1
Michal Rehak [Tue, 16 Sep 2014 17:15:12 +0000 (19:15 +0200)]
BUG-1952 Flow update rpc

- in case that delete and recreate of flow is required then
  the action after delete should be add -> was modify
- fixed xid propagation to notification
- using RpcResultBuilder

Change-Id: Idd519256519e32b2cd475b4cd954fe16f7518e66
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBug 1254 - Added unit tests 05/11405/1
Michal Polkorab [Fri, 19 Sep 2014 15:23:25 +0000 (17:23 +0200)]
Bug 1254 - Added unit tests

 - + fixed MultipartReplyTranslator#getGroupActionsSupportBitmap()

Change-Id: Ie05f26b366da6e2edaf5ca6392b80ce81c018734
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
9 years agoBug 1999: fix msgspy 98/11398/2
Ed Warnicke [Sat, 20 Sep 2014 12:36:03 +0000 (07:36 -0500)]
Bug 1999: fix msgspy

Change-Id: Ie06d390170a092fb2f42f6b97d8544bd18ecad9d
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoBug 1962: add convenience -rest and -ui features 44/11344/3
Ed Warnicke [Thu, 18 Sep 2014 22:11:12 +0000 (17:11 -0500)]
Bug 1962: add convenience -rest and -ui features

Change-Id: I2f619f322abfb2de069fbcba9fb2751fb924bd00
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoBug 1254 - added basic conversion test for OFToMDSalFlowConvertor 67/11367/3
Martin Bobak [Thu, 18 Sep 2014 20:14:30 +0000 (22:14 +0200)]
Bug 1254 - added basic conversion test for OFToMDSalFlowConvertor

Change-Id: If82e5d0c2d01d8fff89882dad5df9c87ce1baa80
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - added basic functionality test for MatchExtensionHelper 70/11370/1
Martin Bobak [Fri, 19 Sep 2014 15:07:04 +0000 (17:07 +0200)]
Bug 1254 - added basic functionality test for MatchExtensionHelper

Change-Id: I8e77f64b9c5995b3555c719f0924034f9011cfc8
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - basic mapping functionality test for MeterStatsResponseConvertor 35/11335/2
Martin Bobak [Thu, 18 Sep 2014 19:33:30 +0000 (21:33 +0200)]
Bug 1254 - basic mapping functionality test for MeterStatsResponseConvertor

Change-Id: I7cb84ba68fc42149144308586316669d086fe19f
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - change sonar.exclude pattern 27/11327/2
Martin Bobak [Thu, 18 Sep 2014 14:54:52 +0000 (16:54 +0200)]
Bug 1254 - change sonar.exclude pattern

Change-Id: Icde4847fe106e39b80622e1326ac1f159795eaa7
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - increase unit test fix 23/11323/2
Martin Bobak [Thu, 18 Sep 2014 14:16:14 +0000 (16:16 +0200)]
Bug 1254 - increase unit test fix

- remove unwanted test dependency

Change-Id: I95b777cd90e83e4005794d3e7bd94f6069f3767b
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1947 - fixed IndexOutOfBounds exception on MultipartReplyMessage deserialization 09/11309/1
Michal Polkorab [Thu, 18 Sep 2014 09:15:25 +0000 (11:15 +0200)]
Bug 1947 - fixed IndexOutOfBounds exception on MultipartReplyMessage deserialization

Change-Id: I8306c731cf58d004c89fdf3e1dd336adaaacef5e
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
9 years agoBug 1254 - increase unit test coverage 96/11296/2
Martin Bobak [Wed, 17 Sep 2014 20:26:55 +0000 (22:26 +0200)]
Bug 1254 - increase unit test coverage

Change-Id: Id7797341a91c166ada906b6ce3cadc7606311061
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - increase unit test coverage 95/11295/1
Martin Bobak [Wed, 17 Sep 2014 19:34:03 +0000 (21:34 +0200)]
Bug 1254 - increase unit test coverage

- added trivial tests for NxmExtensionsConvertor.java

Change-Id: Ic3bd931f70dbd5269e7286a060c4430e9c5d4ee7
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - increase unit test coverage 92/11292/1
Martin Bobak [Wed, 17 Sep 2014 18:48:44 +0000 (20:48 +0200)]
Bug 1254 - increase unit test coverage

- added sonar.jacoco.exclude property that excludes yang generated sources

Change-Id: Idcb748d656eaf724808f05357f5ba407c3103c6c
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1909: fix maven-bundle-plugin version 57/11257/2
Ed Warnicke [Tue, 16 Sep 2014 21:38:39 +0000 (16:38 -0500)]
Bug 1909: fix maven-bundle-plugin version

- used variable ${maven.bundle.version}

Change-Id: I597a65c7d662daad367dc18098ea066491fd9cbe
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoFixed distribution to include the bundles 76/10876/3
Mathieu Lemay [Sat, 6 Sep 2014 18:56:53 +0000 (14:56 -0400)]
Fixed distribution to include the bundles

This patch adds the bundles to the karaf /system folder so that
the distribution can be used standalone without a developer .m2
local repository.

Change-Id: I5f82403a1c519fec3fc587d4da2a4e00836fa9cc
Signed-off-by: Mathieu Lemay <mlemay@inocybe.com>
9 years agoBug 1257 - increase UT coverage 71/11271/2
Martin Bobak [Wed, 17 Sep 2014 06:37:55 +0000 (08:37 +0200)]
Bug 1257 - increase UT coverage

- added sonar.jacoco.exclude property that excludes yang generated sources

Change-Id: I4f7398d13e15bf84c20cf2c2d2c42d7e4442be26
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBUG-1759 ip-tos value 14/11114/2
Michal Rehak [Fri, 12 Sep 2014 13:48:06 +0000 (15:48 +0200)]
BUG-1759 ip-tos value

- added shift from tos to dscp fro OF-1.3

Change-Id: I4a2f8dc968aeda2538b56c3b9420e5d8cfe582a3
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBug 1667 - Openflow plugin statistics must be available through the config subsystem 43/10943/2
Martin Bobak [Tue, 9 Sep 2014 13:10:41 +0000 (15:10 +0200)]
Bug 1667 - Openflow plugin statistics must be available through the config subsystem

Change-Id: Ie4a6ff48cd0d6877d0a7821c04a4d6cbccf12bf9
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1250 - increase UT coverage 38/11038/4
Martin Bobak [Thu, 11 Sep 2014 12:00:08 +0000 (14:00 +0200)]
Bug 1250 - increase UT coverage

- removed unused methods

Change-Id: I8ecd6a406955412f8710bd4650d692e2742b7af4
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - increase UT coverage 28/11028/2
Martin Bobak [Thu, 11 Sep 2014 08:51:34 +0000 (10:51 +0200)]
Bug 1254 - increase UT coverage

- removed unused ConnectionConfigurationFactory.java

Change-Id: Idb4b61f94e793ab035a94fa75e5a6536a2ad3306
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - increase UT coverage 25/11025/2
Martin Bobak [Thu, 11 Sep 2014 07:15:47 +0000 (09:15 +0200)]
Bug 1254 - increase UT coverage

- removed unused classes

Change-Id: I6ea1eb81ea1d31967fce82eb49ac051e3980dfed
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - increase UT coverage 92/10992/3
Martin Bobak [Wed, 10 Sep 2014 12:52:10 +0000 (14:52 +0200)]
Bug 1254 - increase UT coverage

- unused GroupEntityData.java removed

Change-Id: I743b207752e36b914dbdfecf5352406d0f8502ec
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - increas UT coverage 90/10990/2
Martin Bobak [Wed, 10 Sep 2014 12:28:33 +0000 (14:28 +0200)]
Bug 1254 - increas UT coverage

- messageSpy basic functionality test added

Change-Id: Idf5ad0ca493adbb1374d0cc85b0439726f16f49b
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - Increase UT coverage 78/10978/2
Martin Bobak [Wed, 10 Sep 2014 07:53:47 +0000 (09:53 +0200)]
Bug 1254 - Increase UT coverage

- removed unused class

Change-Id: If6ec76942ca5417e7fa79798472a7d2328d8e1f6
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoMerge "BUG-1421: VLAN tag"
Abhijit Kumbhare [Thu, 11 Sep 2014 01:17:23 +0000 (01:17 +0000)]
Merge "BUG-1421: VLAN tag"

9 years agoBUG-1713: NPE by flow with push-vlan action (OF-1.0) 06/11006/1
Michal Rehak [Wed, 10 Sep 2014 18:02:02 +0000 (20:02 +0200)]
BUG-1713: NPE by flow with push-vlan action (OF-1.0)

- fixed empty action

Change-Id: I21c8aced0024e70b05777487a75c695118c50a5d
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBUG-1421: VLAN tag 16/10916/3
Michal Rehak [Mon, 8 Sep 2014 17:45:58 +0000 (19:45 +0200)]
BUG-1421: VLAN tag

- added original match to vlan-injected match
- fixed offset of action order
- added original vlan-* actions before injecting special actions
- fixed vlan-id-present ignorance

Change-Id: I7475fcaa3d1e04a03511cf9c0c33cda6d1c9185a
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBug 1680 - default table-miss-entry feature should be pulled out into separate module 10/10910/4
Martin Bobak [Sun, 31 Aug 2014 17:44:35 +0000 (19:44 +0200)]
Bug 1680 - default table-miss-entry feature should be pulled out into separate module

Change-Id: I45e01c2edecfde58ceb13d0ae9a7c905faf9a018
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1748 - Use version property for yangtools in openflowplugin pom's 09/10909/3
Martin Bobak [Mon, 8 Sep 2014 08:40:36 +0000 (10:40 +0200)]
Bug 1748 - Use version property for yangtools in openflowplugin pom's

Change-Id: I7595ab064c67d20324f3566b3a4b7b928948d0f3
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1588 - Move API classes from openflowplugin module to openflowplugin-api module 87/10887/5
Martin Bobak [Sun, 7 Sep 2014 14:42:49 +0000 (16:42 +0200)]
Bug 1588 - Move API classes from openflowplugin module to openflowplugin-api module

Change-Id: Ifbbd6c0756a90c79913c5740c07564fa34d3be4a
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1739 - remove unused dependency on openflowplugin-api from openflow-extension-api 84/10884/2
Martin Bobak [Sun, 7 Sep 2014 15:05:44 +0000 (17:05 +0200)]
Bug 1739 - remove unused dependency on openflowplugin-api from openflow-extension-api

dependency on openflowplugin-api is worthless

Change-Id: I66ec75c9dac34dfbed8056a810f9af8d2b8ca526
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoMerge "DO NOT MERGE: adding drop-test support for karaf"
Ed Warnicke [Fri, 5 Sep 2014 00:22:54 +0000 (00:22 +0000)]
Merge "DO NOT MERGE: adding drop-test support for karaf"

9 years agoDO NOT MERGE: adding drop-test support for karaf 18/10718/5
Michal Rehak [Wed, 3 Sep 2014 17:47:13 +0000 (19:47 +0200)]
DO NOT MERGE: adding drop-test support for karaf

- added empty test-common bundle for test logic
- test logic will be pulled in later
- drop test logic pulled up to test-common
- fixed notificationListener registration
- added karaf command implementation (drop-test, dropAllPackets)
- added dropAllPacketsRpc
- fixed features xml format

Change-Id: I06249f4671121e89a7de1a8003feef8fe0b2fca1
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBug 1588 - OFConstants.java moved to openflowplugin-api module 30/10630/4
Martin Bobak [Fri, 29 Aug 2014 20:37:33 +0000 (22:37 +0200)]
Bug 1588 - OFConstants.java moved to openflowplugin-api module

Change-Id: I71eb2432d78a87734a24699f4973ab3bd8cd3087
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - increase UT coverage 39/10639/2
Martin Bobak [Fri, 29 Aug 2014 20:17:28 +0000 (22:17 +0200)]
Bug 1254 - increase UT coverage

Change-Id: I520491294faa25d46ab86b8d8ae306f5f419dcdb
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoRemoved hard coded distribution management URLs 92/10492/2
Devin Avery [Fri, 29 Aug 2014 17:31:38 +0000 (13:31 -0400)]
Removed hard coded distribution management URLs

Replaced with variables.

Signed-off-by: Devin Avery <devin.avery@brocade.com>
9 years agoBug 1544 - Explicit LLDP flow to punt whole LLDP packets to the controller 78/10478/4
Martin Bobak [Wed, 27 Aug 2014 21:13:35 +0000 (23:13 +0200)]
Bug 1544 - Explicit LLDP flow to punt whole LLDP packets to the controller

Change-Id: I2943e1d13828212f8a9912ceb3f155bc034f8808
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - increase UT coverage 55/10755/1
Martin Bobak [Sat, 30 Aug 2014 18:53:00 +0000 (20:53 +0200)]
Bug 1254 - increase UT coverage

Change-Id: I448f8a2430cfbc47988daacb2608d0f9b64d838f
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBUG-1681 removing osgi.console dependency 08/10708/1
Michal Rehak [Wed, 3 Sep 2014 15:49:06 +0000 (17:49 +0200)]
BUG-1681 removing osgi.console dependency

- removed dependency
- removed dumpMsgCount osgi console command

Change-Id: I5f09b8372db7ac347fedeee856d1802d25b1886d
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoOpenflowJava UDP support corresponding change 47/10447/3
Michal Polkorab [Mon, 18 Aug 2014 11:41:35 +0000 (13:41 +0200)]
OpenflowJava UDP support corresponding change

 - DO NOT MERGE until https://git.opendaylight.org/gerrit/#/c/10432/ is merged

Change-Id: I499bc7375a67296d96049c34dcaf9ad70c6420c6
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
9 years agoBug-1421 - Chaining of results and updateFlow 48/10348/3
Kamal Rameshan [Tue, 26 Aug 2014 22:27:26 +0000 (15:27 -0700)]
Bug-1421 - Chaining of results and updateFlow

1. Chained the flowmod results when more than one flows are added/updated
2. Fixed updateFlow when match/priority were changed. After RemoveFlow, add flow was being passed in as null.
3. Create a common set of methods to be used for both add and update flow tasks

Change-Id: I5d3576150bc5da79764c1b311e9c51df387f8c6f
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
9 years agoInventoryDataServiceUtil shifted to new API 69/10369/4
Martin Bobak [Mon, 25 Aug 2014 18:49:28 +0000 (20:49 +0200)]
InventoryDataServiceUtil shifted to new API

Change-Id: I1e53e13bdb503f34238d971d4fb88332cab06c1f
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoFixed dataBroker - copy from working distribution config 67/10367/6
Martin Bobak [Tue, 26 Aug 2014 04:55:37 +0000 (06:55 +0200)]
Fixed dataBroker - copy from working distribution config

Change-Id: Id0c95c18cc4b39ecdf51593520771ce07f5266bd
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1254 - increase UT coverage 31/10331/3
Martin Bobak [Tue, 26 Aug 2014 19:42:42 +0000 (21:42 +0200)]
Bug 1254 - increase UT coverage

Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoReplace harcoded URLs, updated out of date dependencies 24/10324/2
Devin Avery [Tue, 26 Aug 2014 17:02:42 +0000 (13:02 -0400)]
Replace harcoded URLs, updated out of date dependencies

1) Replaced hardcoded URLs with nexusproxy variables
2) Replaced out of date dependencies that were hardcoded
   with variables / dependency management.

Change-Id: Iea97ba79a532f5f73f31b80f63e6ef1072291acb
Signed-off-by: Devin Avery <devin.avery@brocade.com>
9 years agoRemoved wrong imports 50/10450/1
Martin Sunal [Thu, 28 Aug 2014 13:09:39 +0000 (15:09 +0200)]
Removed wrong imports

Signed-off-by: Martin Sunal <msunal@cisco.com>
9 years agoAdded exemplary ofjava thread model configuration 51/9651/3
Michal Polkorab [Mon, 4 Aug 2014 14:11:10 +0000 (16:11 +0200)]
Added exemplary ofjava thread model configuration

Depends on https://git.opendaylight.org/gerrit/#/c/9650/

 + one compatibility change

Change-Id: Ibc920a9b9e88681beee112e5d9966a07ac86117f
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
9 years agoRemoved implementation of RPC get-node-ip-address 82/10382/2
Martin Sunal [Wed, 27 Aug 2014 14:47:36 +0000 (16:47 +0200)]
Removed implementation of RPC get-node-ip-address

implementation of RPC get-node-ip-address from flow-node-inventory is removed.
This RPC is not needed anymore. IP address is stored in datastore.

Signed-off-by: Martin Sunal <msunal@cisco.com>
9 years agoBug 1254 - Increase UT coverage 62/10262/2
Martin Bobak [Mon, 25 Aug 2014 19:55:56 +0000 (21:55 +0200)]
Bug 1254 - Increase UT coverage

Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoStores and gets IP address of a flow capable node 16/9616/8
Martin Sunal [Sat, 2 Aug 2014 17:28:40 +0000 (19:28 +0200)]
Stores and gets IP address of a flow capable node

- implements RPCs get-node-ip-address from flow-node-inventory.yang
depends on https://git.opendaylight.org/gerrit/#/c/9612/
- impelementation is done by using switch IP address from OFJava
depends on https://git.opendaylight.org/gerrit/#/c/9615/
- stores IP address of OF capable switch to data store (depends on Bug 1585)

Change-Id: I5b46106cf94109ddddd8cf5353d749e40c43b0ec
Signed-off-by: Martin Sunal <msunal@cisco.com>
9 years agoBug 1596: Fixed stats issue and NPE 96/10296/3
Prashaanth [Tue, 26 Aug 2014 10:56:18 +0000 (16:26 +0530)]
Bug 1596: Fixed stats issue and NPE

Signed-off-by: Prashaanth <prashaanthr92@gmail.com>
9 years agoBug 1254 - Increase UT coverage 57/10257/2
Martin Bobak [Mon, 25 Aug 2014 19:17:00 +0000 (21:17 +0200)]
Bug 1254 - Increase UT coverage

Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug-1421 - MD-SAL app cannot create a flow entry which adds a VLAN tag with the speci... 80/10280/3
Kamal Rameshan [Tue, 26 Aug 2014 05:18:40 +0000 (22:18 -0700)]
Bug-1421 - MD-SAL app cannot create a flow entry which adds a VLAN tag with the specified VLAN ID into untagged frame

Change-Id: I9bbda50487b26479f51e4a00582e1fbb9f8f98f1
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
9 years agoMerge "Added a signum to the SetMetaDataMask BigInt constructor"
Abhijit Kumbhare [Tue, 26 Aug 2014 05:32:04 +0000 (05:32 +0000)]
Merge "Added a signum to the SetMetaDataMask BigInt constructor"

9 years agoAdded a signum to the SetMetaDataMask BigInt constructor 59/10159/1
Brent Salisbury [Fri, 22 Aug 2014 08:16:59 +0000 (04:16 -0400)]
Added a signum to the SetMetaDataMask BigInt constructor

-OF TestCommandProvider doesnt appear functional atm, but
I did test the Java API calls from elsewhere. The test
function should now work. Below is the instantiated flowmod:
(Match) metadata=0x100/0xffffff0000000101 actions=drop

Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
9 years agoMerge "Bug 1088 :flow id in operational not matched; after removal not removed comple...
Abhijit Kumbhare [Thu, 21 Aug 2014 17:44:46 +0000 (17:44 +0000)]
Merge "Bug 1088 :flow id in operational not matched; after removal not removed completely Statistics manager uses custom comparators to compare the flows it receive from switch against the flows available in the config data store. Comparator was failing to match flow against the config flow because of two issues 1) Port number convertion at openflow plugin includes prefix openflow:1: to the port number. Prefix is not required,so removed it. 2) Mac address in the flow match, received from openflow plugin has different case (e.g XX:XX:XX:XX:XX:XX) then the one in config data store (e.g xx:xx:xx:xx:xx:xx). Default MacAddress class equals fails because of different case of mac address string. This need to be fixed in statistics manager module in controller."

9 years agoBUG-1458: apply 'create parents' bandaid 10/9610/5
Robert Varga [Sat, 2 Aug 2014 16:17:22 +0000 (18:17 +0200)]
BUG-1458: apply 'create parents' bandaid

Prevents exceptions being thrown, but results in pretty much no
performance at all.

Change-Id: I01306dddc8ed42efdccd22732535a4a464de74d6
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBug 1545 - set default switch configuration after handshake 02/10102/3
Martin Bobak [Mon, 18 Aug 2014 21:05:59 +0000 (23:05 +0200)]
Bug 1545 - set default switch configuration after handshake

Change-Id: I06d08a66738b9bf10522264a079e5fcf19acf755
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoBug 1088 :flow id in operational not matched; after removal not removed completely 36/10136/2
Anilkumar Vishnoi [Tue, 19 Aug 2014 14:51:36 +0000 (20:21 +0530)]
Bug 1088 :flow id in operational not matched; after removal not removed completely
Statistics manager uses custom comparators to compare the flows it receive from
switch against the flows available in the config data store. Comparator was failing
to match flow against the config flow because of two issues
1) Port number convertion at openflow plugin includes prefix openflow:1: to the port
number. Prefix is not required,so removed it.
2) Mac address in the flow match, received from openflow plugin has different case
(e.g XX:XX:XX:XX:XX:XX) then the one in config data store (e.g xx:xx:xx:xx:xx:xx).
Default MacAddress class equals fails because of different case of mac address string.
This need to be fixed in statistics manager module in controller.

Change-Id: I8d10baa64af92dc9be4dd62c1c59c33344ac843d
Signed-off-by: Anilkumar Vishnoi <avishnoi@in.ibm.com>