packetcable.git
9 years agoFixed block responsible for parsing the PCMM gate request's traffic profile from... 57/19457/2
Steven Pisarski [Fri, 1 May 2015 21:31:17 +0000 (15:31 -0600)]
Fixed block responsible for parsing the PCMM gate request's traffic profile from a byte[]. Only commented the BestEffortService line as we will most likely need to support the parsing of other types of ITrafficProfile objects.

Change-Id: I70a82d431c6a20d06a346ff511122d3e8aabd70c
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoFixed the routine responsible for parsing a gate request decision message. 56/19456/2
Steven Pisarski [Fri, 1 May 2015 21:29:21 +0000 (15:29 -0600)]
Fixed the routine responsible for parsing a gate request decision message.

Change-Id: I8efa03e6300ea25117388869ad74b3bf9bcdf097
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoFixed hashCode() so it returns the same value after the data in the _data + _padding... 55/19455/2
Steven Pisarski [Fri, 1 May 2015 21:08:28 +0000 (15:08 -0600)]
Fixed hashCode() so it returns the same value after the data in the _data + _padding is taken into account.

Change-Id: Iadde6326c660deba6dbe05a1cda55f2c5b0219de
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoRemoved the requirement that the COPSData member (aka. _data) cannot be null. Found... 53/19453/2
Steven Pisarski [Fri, 1 May 2015 20:56:06 +0000 (14:56 -0600)]
Removed the requirement that the COPSData member (aka. _data) cannot be null. Found this issue while building tests for the packetcable-policy-server PCMMService class for connecting to and setting gates for a CCAP.

Change-Id: I02e5c8d9562b2ecfbcb30c9ffcc7ac649262a1db
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoImproved exception handling, increased immutability, and general houskeeping. 95/19395/2
Steven Pisarski [Thu, 30 Apr 2015 16:10:44 +0000 (10:10 -0600)]
Improved exception handling, increased immutability, and general houskeeping.

Change-Id: I7243c358ed878b12afca657a2c0ebb0840aa97be
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoGeneralizing COPSPdpException to a COPSException. 91/19391/2
Steven Pisarski [Thu, 30 Apr 2015 15:42:17 +0000 (09:42 -0600)]
Generalizing COPSPdpException to a COPSException.

Change-Id: I26043dd475f12a5fe02a7b04b97e04ab747e1063
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoFix to NPE during instantiation after moving the instantiation of the gateIidMap... 90/19390/2
Steven Pisarski [Thu, 30 Apr 2015 15:10:55 +0000 (09:10 -0600)]
Fix to NPE during instantiation after moving the instantiation of the gateIidMap member after the call to the private method getGates().

Change-Id: I6bade15d28f16f4c79e83e5161abf547088fb908
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoWith previous change to AbstractPCMMServer, instantiation of the CMTS class now requi... 47/19347/2
Steven Pisarski [Wed, 29 Apr 2015 21:10:18 +0000 (15:10 -0600)]
With previous change to AbstractPCMMServer, instantiation of the CMTS class now requires one to specify the port number that will be opened else the ServerSocket class will assign one automatically.

Change-Id: Iabc32d486952475f18b5b3025b809003f48c5c8f
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoNow Karaf module capable of starting the new bundles contained in the new feature... 46/19346/2
Steven Pisarski [Wed, 29 Apr 2015 20:55:40 +0000 (14:55 -0600)]
Now Karaf module capable of starting the new bundles contained in the new feature odl-packetcable-policy-server-all.

Change-Id: Ib88791973fbfd38cbb72ea9521d642872afd4318
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoNew feature bundle for the new feature odl-packetcable-policy-server-all. 45/19345/2
Steven Pisarski [Wed, 29 Apr 2015 20:34:30 +0000 (14:34 -0600)]
New feature bundle for the new feature odl-packetcable-policy-server-all.

Change-Id: Ib84294970a8b955b5f06e6edc521397286d1e431
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoNew configuration bundle for the new feature odl-packetcable-policy-server-all. 44/19344/2
Steven Pisarski [Wed, 29 Apr 2015 20:20:32 +0000 (14:20 -0600)]
New configuration bundle for the new feature odl-packetcable-policy-server-all.

Change-Id: I8cee33d563cdda7dcb2deb7f1773ea06a777221b
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoThe provider module for the Arris designed APIs. 42/19342/2
Steven Pisarski [Wed, 29 Apr 2015 20:07:19 +0000 (14:07 -0600)]
The provider module for the Arris designed APIs.

Change-Id: I14b087d72c4ff180007cda2c9fd9992cf54e9906
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoNew model module for use in the new feature to be called odl-packetcable-policy-serve... 28/19328/2
Steven Pisarski [Wed, 29 Apr 2015 18:26:29 +0000 (12:26 -0600)]
New model module for use in the new feature to be called odl-packetcable-policy-server-all.

Change-Id: I7e1b3ee8d937165c3e3af0d735555180b23cdd1f
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoMiscellaneous driver fixes found while migrating and testing the new Arris API submis... 27/19327/2
Steven Pisarski [Wed, 29 Apr 2015 18:16:50 +0000 (12:16 -0600)]
Miscellaneous driver fixes found while migrating and testing the new Arris API submission that will live in a new feature called odl-packetcable-policy-server-all.

Change-Id: I9c56c26faf8b59e5f9e48027e8a3b351d25ebb03
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoAdded an optional COPSClientSI object as a member to the COPSDecisionMsg as per specs. 25/19325/2
Steven Pisarski [Wed, 29 Apr 2015 17:24:24 +0000 (11:24 -0600)]
Added an optional COPSClientSI object as a member to the COPSDecisionMsg as per specs.

Change-Id: If648ca341ca889fd6c6f0d9382ea180b0c239351
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoAdded new constructor. May need to tighten down interfaces in the future. 16/19316/2
Steven Pisarski [Wed, 29 Apr 2015 16:04:50 +0000 (10:04 -0600)]
Added new constructor. May need to tighten down interfaces in the future.

Change-Id: I56bbcc65514f9eb2f7ff9aad804780449968e4fb
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoChanged tests to leverage a dynamic port for testing COPS message marshalling/unmarsh... 22/19322/2
Steven Pisarski [Wed, 29 Apr 2015 17:09:14 +0000 (11:09 -0600)]
Changed tests to leverage a dynamic port for testing COPS message marshalling/unmarshalling. Was previously leveraging the static port number of 7777 which has shown to cause problems on the gerrit Jenkins verify build as it appears it allows tests to be run in parallel.

Change-Id: Ie52ac87d9efa776e3a1ee1afb57fc44cc6259354
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoEnsure padding data cannot be written when empty. 14/19314/1
Steven Pisarski [Wed, 29 Apr 2015 15:44:26 +0000 (09:44 -0600)]
Ensure padding data cannot be written when empty.

Change-Id: Ic816da28fff33587d6ba847c29159127a2515f86
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoAdded logging to help debug COPS message handling. 13/19313/1
Steven Pisarski [Wed, 29 Apr 2015 15:41:23 +0000 (09:41 -0600)]
Added logging to help debug COPS message handling.

Change-Id: I47c67821e55666f9a67928efdc45e31b25b9d5c2
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoCreated a client-type enumeration as part of the original COPS refactor and have... 33/19033/1
Steven Pisarski [Fri, 24 Apr 2015 16:21:22 +0000 (10:21 -0600)]
Created a client-type enumeration as part of the original COPS refactor and have changed it back to an short value due to a misinterpretation of the COPS specifications. Additionally changed the enumeration held by the COPSDecision to not leverage the ordinal value as a mapping between the COPS payload which comes in as two bytes.

Change-Id: I2c86fd4fc134afa12de1fee12a52279f1a9fdf31
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoCompleted COPS Message refactoring. Was planning on one additional patch starting... 70/18670/1
Steven Pisarski [Mon, 20 Apr 2015 21:24:51 +0000 (15:24 -0600)]
Completed COPS Message refactoring. Was planning on one additional patch starting with the COPSHeader; however, the dependencies of COPSHeader were everywhere the COPSMsg objects were being instantiated and determined it would be easier merging this as the final patch versus splitting these changes up. Please see Bugzilla report #2943 for more details. In addition to the restructuring of the COPSMsg classes for immutability, semantics by adding in enumerations, and testability, this patch is also fixing some of the code warnings and removing MS-DOS CR characters.

Change-Id: Ica1e55209728fab5c71d0bffb52eb4ca0401e4dc
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoThe second patch of an estimated 4 to complete the COPS message refactoring as descri... 39/18639/1
Steven Pisarski [Mon, 20 Apr 2015 15:08:16 +0000 (09:08 -0600)]
The second patch of an estimated 4 to complete the COPS message refactoring as described in Bugzilla report #2943. This patch completes the refactoring for all of the objects that can be contained within a COPS message. Although this changelist is quite large, it was not possible to subdivide it any further as it was necessary to refactor each of the classes being extended by COPSObjectBase. Most of the changes made at the service level are to the COPS object construction; however, a few fixes have also been made to address some of the compiler warnings. This patch also should have taken out all of the DOS CR characters in any of the source being altered at this time.

Change-Id: I299f2360dac8455b2f4e87d9e8e751ae7c843f3b
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoMerge changes I0d4117b1,Ib233ea80,I307b4ddd,I03338c43,Id8641e04, ...
Thomas Kee [Sat, 18 Apr 2015 00:06:07 +0000 (00:06 +0000)]
Merge changes I0d4117b1,Ib233ea80,I307b4ddd,I03338c43,Id8641e04, ...

* changes:
  Removed DOS CR characters as per Alixis de Talhouet's code review to patch #18478.
  Removed COPSDebug.java and all remaining references.
  Replaced use of logger abstraction COPSDebug.java to having this class log directly to it's own logger as well as fixing several compiler warnings.
  Replaced use of logger abstraction COPSDebug.java to having this class log directly to it's own logger as well as fixing several compiler warnings.
  Replaced use of logger abstraction COPSDebug.java to having this class log directly to it's own logger as well as fixing several compiler warnings.
  Replaced use of logger abstraction COPSDebug.java to having this class log directly to it's own logger as well as fixing several compiler warnings.
  Replaced use of logger abstraction COPSDebug.java to having this class log directly to it's own logger as well as fixing several compiler warnings.

9 years agoMerge "Replaced use of logger abstraction COPSDebug.java to having this class log...
Thomas Kee [Sat, 18 Apr 2015 00:05:31 +0000 (00:05 +0000)]
Merge "Replaced use of logger abstraction COPSDebug.java to having this class log directly to it's own logger as well as fixing several compiler warnings."

9 years agoMerge changes I80861f13,I2d6675bd
Thomas Kee [Sat, 18 Apr 2015 00:01:36 +0000 (00:01 +0000)]
Merge changes I80861f13,I2d6675bd

* changes:
  Replaced use of logger abstraction COPSDebug.java to having this class log directly to it's own logger.
  Replaced use of logger abstraction COPSDebug.java to having this class log directly to it's own logger.

9 years agoMerge changes I99dfd3ce,Ib55b1ca2,I584ed58f,I0020da7e,If9376252
Thomas Kee [Sat, 18 Apr 2015 00:00:45 +0000 (00:00 +0000)]
Merge changes I99dfd3ce,Ib55b1ca2,I584ed58f,I0020da7e,If9376252

* changes:
  Removed existing \t (tab) characters per code review to change 18467 from Alexis de Talhouet.
  Removed existing \r characters per code review to change 18469 from Alexis de Talhouet.
  Replaced System.err.println() call with a logger.
  Replaced System.out.println() calls with a logger.
  Replaced System.out.println() calls with a logger and removed several compiler warnings.

9 years agoMerge changes Id19fc95a,I83a73ed1
Thomas Kee [Fri, 17 Apr 2015 23:57:58 +0000 (23:57 +0000)]
Merge changes Id19fc95a,I83a73ed1

* changes:
  Replaced System.out.println() with a logger.
  Replaced System.out.println() calls with a logger.

9 years agoMerge "Replaced System.out.println() calls with a logger and fixed a few compiler...
Thomas Kee [Fri, 17 Apr 2015 23:31:47 +0000 (23:31 +0000)]
Merge "Replaced System.out.println() calls with a logger and fixed a few compiler warnings."

9 years agoMerge "Oops! Change to logger class."
Thomas Kee [Fri, 17 Apr 2015 23:30:42 +0000 (23:30 +0000)]
Merge "Oops! Change to logger class."

9 years agoMerge "Replaced System.out.println() calls with a logger."
Thomas Kee [Fri, 17 Apr 2015 23:30:16 +0000 (23:30 +0000)]
Merge "Replaced System.out.println() calls with a logger."

9 years agoMerge "Removal of calls to COPSDebug.err() and replaced with calls to the logger."
Thomas Kee [Fri, 17 Apr 2015 23:29:39 +0000 (23:29 +0000)]
Merge "Removal of calls to COPSDebug.err() and replaced with calls to the logger."

9 years agoMerge "Replaced System.out.println() and COPSDebug.error() calls with logging. Also...
Thomas Kee [Fri, 17 Apr 2015 23:28:05 +0000 (23:28 +0000)]
Merge "Replaced System.out.println() and COPSDebug.error() calls with logging. Also added error logs for all exceptions being caught."

9 years agoMerge "Start of the COPS message refactoring to make all of these classes more semant...
Thomas Kee [Fri, 17 Apr 2015 23:26:41 +0000 (23:26 +0000)]
Merge "Start of the COPS message refactoring to make all of these classes more semantic, immutable and testable. More unit tests will be added as each COPS message/object has been refactored."

9 years agoRemoved DOS CR characters as per Alixis de Talhouet's code review to patch #18478. 95/18495/1
Steven Pisarski [Thu, 16 Apr 2015 22:02:25 +0000 (16:02 -0600)]
Removed DOS CR characters as per Alixis de Talhouet's code review to patch #18478.

Change-Id: I0d4117b1b1bde9305c9fdbddef8b20c4f2ddd936
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoRemoved COPSDebug.java and all remaining references. 94/18494/1
Steven Pisarski [Thu, 16 Apr 2015 21:53:00 +0000 (15:53 -0600)]
Removed COPSDebug.java and all remaining references.

Change-Id: Ib233ea8028755359e6e233bd70ef3646d0198836
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoReplaced use of logger abstraction COPSDebug.java to having this class log directly... 93/18493/1
Steven Pisarski [Thu, 16 Apr 2015 21:38:44 +0000 (15:38 -0600)]
Replaced use of logger abstraction COPSDebug.java to having this class log directly to it's own logger as well as fixing several compiler warnings.

Change-Id: I307b4ddd5b1a1d12a9baf7465caf5a10214ecb98
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoReplaced use of logger abstraction COPSDebug.java to having this class log directly... 91/18491/1
Steven Pisarski [Thu, 16 Apr 2015 21:28:55 +0000 (15:28 -0600)]
Replaced use of logger abstraction COPSDebug.java to having this class log directly to it's own logger as well as fixing several compiler warnings.

Change-Id: I03338c4348f0e9649cdedf9868839e7d37494b37
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoReplaced use of logger abstraction COPSDebug.java to having this class log directly... 89/18489/1
Steven Pisarski [Thu, 16 Apr 2015 21:19:12 +0000 (15:19 -0600)]
Replaced use of logger abstraction COPSDebug.java to having this class log directly to it's own logger as well as fixing several compiler warnings.

Change-Id: Id8641e045e47ee84db9a0421a5ff97bfe7843763
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoReplaced use of logger abstraction COPSDebug.java to having this class log directly... 87/18487/1
Steven Pisarski [Thu, 16 Apr 2015 21:09:15 +0000 (15:09 -0600)]
Replaced use of logger abstraction COPSDebug.java to having this class log directly to it's own logger as well as fixing several compiler warnings.

Change-Id: If1709dc853ddf210775319cde1e78d6f397ebb34
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoReplaced use of logger abstraction COPSDebug.java to having this class log directly... 85/18485/1
Steven Pisarski [Thu, 16 Apr 2015 20:57:28 +0000 (14:57 -0600)]
Replaced use of logger abstraction COPSDebug.java to having this class log directly to it's own logger as well as fixing several compiler warnings.

Change-Id: I0e870ba11017fc8270ac056814fe7046fc6db04a
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoReplaced use of logger abstraction COPSDebug.java to having this class log directly... 82/18482/1
Steven Pisarski [Thu, 16 Apr 2015 20:14:20 +0000 (14:14 -0600)]
Replaced use of logger abstraction COPSDebug.java to having this class log directly to it's own logger as well as fixing several compiler warnings.

Change-Id: I5d000525c81c4be2075e2579058e6ae4f887076d
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoReplaced use of logger abstraction COPSDebug.java to having this class log directly... 81/18481/1
Steven Pisarski [Thu, 16 Apr 2015 20:02:55 +0000 (14:02 -0600)]
Replaced use of logger abstraction COPSDebug.java to having this class log directly to it's own logger.

Change-Id: I80861f13e32a05861efd01ad187d6cde20080582
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoReplaced use of logger abstraction COPSDebug.java to having this class log directly... 78/18478/1
Steven Pisarski [Thu, 16 Apr 2015 19:53:26 +0000 (13:53 -0600)]
Replaced use of logger abstraction COPSDebug.java to having this class log directly to it's own logger.

Change-Id: I2d6675bd9e425e449050e73c3c00000b149a1787
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoRemoved existing \t (tab) characters per code review to change 18467 from Alexis... 74/18474/1
Steven Pisarski [Thu, 16 Apr 2015 19:33:20 +0000 (13:33 -0600)]
Removed existing \t (tab) characters per code review to change 18467 from Alexis de Talhouet.

Change-Id: I99dfd3ce172e8a514e326ce32743e8e7e55d21e2
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoRemoved existing \r characters per code review to change 18469 from Alexis de Talhouet. 72/18472/1
Steven Pisarski [Thu, 16 Apr 2015 19:18:45 +0000 (13:18 -0600)]
Removed existing \r characters per code review to change 18469 from Alexis de Talhouet.

Change-Id: Ib55b1ca297afe510b2dce4ab27355de53538397a
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoReplaced System.err.println() call with a logger. 69/18469/1
Steven Pisarski [Thu, 16 Apr 2015 18:34:00 +0000 (12:34 -0600)]
Replaced System.err.println() call with a logger.

Change-Id: I584ed58f9cdbd1693767be77eb71e6f5039c445d
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoReplaced System.out.println() calls with a logger. 68/18468/1
Steven Pisarski [Thu, 16 Apr 2015 18:29:09 +0000 (12:29 -0600)]
Replaced System.out.println() calls with a logger.

Change-Id: I0020da7ef7294ed121df3ead1486e6dd4ab70f9e
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoReplaced System.out.println() calls with a logger and removed several compiler warnings. 67/18467/1
Steven Pisarski [Thu, 16 Apr 2015 18:22:34 +0000 (12:22 -0600)]
Replaced System.out.println() calls with a logger and removed several compiler warnings.

Change-Id: If93762527c6dd52f3260be0bea488edf2c3163c7
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoReplaced System.out.println() with a logger. 66/18466/1
Steven Pisarski [Thu, 16 Apr 2015 18:14:28 +0000 (12:14 -0600)]
Replaced System.out.println() with a logger.

Change-Id: Id19fc95a3b0ffb5c3f17728d6e13f85fe42515a8
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoReplaced System.out.println() calls with a logger. 65/18465/1
Steven Pisarski [Thu, 16 Apr 2015 18:11:12 +0000 (12:11 -0600)]
Replaced System.out.println() calls with a logger.

Change-Id: I83a73ed1133785214d03df798cff43693e653c7c
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoReplaced System.out.println() calls with a logger and fixed a few compiler warnings. 64/18464/1
Steven Pisarski [Thu, 16 Apr 2015 17:48:32 +0000 (11:48 -0600)]
Replaced System.out.println() calls with a logger and fixed a few compiler warnings.

Change-Id: I50e6ca5d130aebb83554420cc5fcda00ee10312e
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoOops! Change to logger class. 62/18462/1
Steven Pisarski [Thu, 16 Apr 2015 17:35:14 +0000 (11:35 -0600)]
Oops! Change to logger class.

Change-Id: I1e658c81e71e3832c179b331987d9cabe9de0db4
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoReplaced System.out.println() calls with a logger. 61/18461/1
Steven Pisarski [Thu, 16 Apr 2015 17:25:36 +0000 (11:25 -0600)]
Replaced System.out.println() calls with a logger.

Change-Id: I889920613d858f84cecadcf8206a02913c58921e
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoRemoval of calls to COPSDebug.err() and replaced with calls to the logger. 59/18459/1
Steven Pisarski [Thu, 16 Apr 2015 17:20:07 +0000 (11:20 -0600)]
Removal of calls to COPSDebug.err() and replaced with calls to the logger.

Change-Id: I0acf0aeb3d4e73c057ea0ca52f2c821a2eea64d7
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoReplaced System.out.println() and COPSDebug.error() calls with logging. Also added... 58/18458/1
Steven Pisarski [Thu, 16 Apr 2015 16:44:49 +0000 (10:44 -0600)]
Replaced System.out.println() and COPSDebug.error() calls with logging. Also added error logs for all exceptions being caught.

Change-Id: Ic768dca152943ddc07b21eb8682f5639480c3ed9
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoStart of the COPS message refactoring to make all of these classes more semantic... 56/18456/1
Steven Pisarski [Thu, 16 Apr 2015 16:29:46 +0000 (10:29 -0600)]
Start of the COPS message refactoring to make all of these classes more semantic, immutable and testable. More unit tests will be added as each COPS message/object has been refactored.

Change-Id: Ic21c14cf850b01fc48c9806cf1dc24a222994a69
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoUpdated references to latest karaf versions. 23/18423/1
Tony Tkacik [Thu, 16 Apr 2015 13:17:09 +0000 (15:17 +0200)]
Updated references to latest  karaf versions.

karaf.version is inherited from odlparent.

Change-Id: I78b69529785fad70ffc35a5e1aff72968c347a68
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoRemoved references to features-flow 74/18074/1
Tony Tkacik [Fri, 10 Apr 2015 07:27:13 +0000 (09:27 +0200)]
Removed references to features-flow

Change-Id: Iefcf60bf3dd06976c97c7d90874d24d42a9fe6d7
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoMerge "Add <relativePath/> to ensure Maven pulls artifact from Nexus"
Thomas Kee [Thu, 2 Apr 2015 17:56:51 +0000 (17:56 +0000)]
Merge "Add <relativePath/> to ensure Maven pulls artifact from Nexus"

9 years agoMerge "Migrate to odlparent-provided features-test"
Thomas Kee [Thu, 2 Apr 2015 16:58:40 +0000 (16:58 +0000)]
Merge "Migrate to odlparent-provided features-test"

9 years agoMerge "changed revision of flow-capable transaction"
Thomas Kee [Thu, 2 Apr 2015 16:29:21 +0000 (16:29 +0000)]
Merge "changed revision of flow-capable transaction"

9 years agoAdd <relativePath/> to ensure Maven pulls artifact from Nexus 70/17470/1
Thanh Ha [Tue, 31 Mar 2015 15:50:02 +0000 (11:50 -0400)]
Add <relativePath/> to ensure Maven pulls artifact from Nexus

Needed by autorelease to be able to find and replace this value
prebuild.

Change-Id: I0f3368e7a10546eedcef7fca46ea93c5decf116b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
9 years agochanged revision of flow-capable transaction 22/17222/1
Michal Rehak [Fri, 27 Mar 2015 10:20:40 +0000 (11:20 +0100)]
changed revision of flow-capable transaction

 - changes in openflowplugin resulted into new revision of
   flow-capable-transaction model
 - added exact revision into yang import (packetcable-broker.yang)
 - fixed import package in java (OpendaylightPacketcableProvider.java)

Change-Id: I405b291cd528e90b65e6bc0631311580097bd6fa
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoRefactor classes designed to hold data to be more immutable, and reducing the probabi... 02/16502/1
Steven Pisarski [Fri, 13 Mar 2015 21:49:06 +0000 (15:49 -0600)]
Refactor classes designed to hold data to be more immutable, and reducing the probability of throwing NullPointerExceptions as well as adding some unit tests around them.

Change-Id: Ibab87ae43226d36b399ceaf987123e7797e719f3
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoChanged System.err calls to use logger instead. 95/16395/1
Steven Pisarski [Thu, 12 Mar 2015 15:09:18 +0000 (09:09 -0600)]
Changed System.err calls to use logger instead.

Change-Id: I0b05fbee1e9e74f6d7821bfefdff72405cf1a6b5
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
9 years agoMigrate to odlparent-provided features-test 34/16234/1
Robert Varga [Tue, 10 Mar 2015 08:05:17 +0000 (09:05 +0100)]
Migrate to odlparent-provided features-test

The yangtools one is going away, so migrate to the new (and working)
one.

Change-Id: I989b3dab229c225ad34fc781f3780c1cc8d7471e
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-2675: model+nsf.app migration proposal 76/14576/4
Michal Rehak [Wed, 28 Jan 2015 19:14:09 +0000 (20:14 +0100)]
BUG-2675: model+nsf.app migration proposal

 - requires:
    controller https://git.opendaylight.org/gerrit/#/c/14464/
    ofplugin https://git.opendaylight.org/gerrit/#/c/14463/

 - added feature dependency

Change-Id: I939f0047c6f7cf49e78db3bc8ffcf9702c47812c
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoRemove <repositories> and <pluginRepositories> sections 79/15179/1
Thanh Ha [Wed, 11 Feb 2015 23:30:01 +0000 (18:30 -0500)]
Remove <repositories> and <pluginRepositories> sections

It is recommended that developers and servers configure this locally via
settings.xml.

https://lists.opendaylight.org/pipermail/discuss/2015-January/004482.html

Change-Id: Iad2d4baf59c60d70341bab4b51f74eb0edc6f98a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
9 years agoMerge "Remove deprecated BindingAwareProvider methods"
Thomas Kee [Thu, 15 Jan 2015 22:31:21 +0000 (22:31 +0000)]
Merge "Remove deprecated BindingAwareProvider methods"

9 years agoRemove deprecated BindingAwareProvider methods 28/14128/1
Ed Warnicke [Tue, 13 Jan 2015 15:21:53 +0000 (09:21 -0600)]
Remove deprecated BindingAwareProvider methods

https://git.opendaylight.org/gerrit/#/c/13806/

will remove deprecated BindingAwareProvider methods.
This patch simply removes them from
implmementation of that interface so when 13806 is
merged we can merge this to fix.

Change-Id: I4d913d2200a5e5017018d5b8b865fa7313ba2eb9
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoSet root pom.xml <name> for Sonar 44/14044/1
Thanh Ha [Fri, 9 Jan 2015 20:42:26 +0000 (15:42 -0500)]
Set root pom.xml <name> for Sonar

As mentioned on the mailing list Sonar uses the <name> field of the
pom.xml that is passed to the mvn command as the name of the project in
Sonar. In most cases this is the root pom.xml file in a project. This
patch sets the name to the project shortname.

https://lists.opendaylight.org/pipermail/discuss/2014-November/004024.html

Change-Id: Idca25733b692b1fdb635164d03c9646ecf27ef06
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
9 years agoIncrementing versions by 0.1.0 of packetcable for post-helium master branch 23/11823/1
Thomas Kee [Wed, 8 Oct 2014 18:10:46 +0000 (11:10 -0700)]
Incrementing versions by 0.1.0 of packetcable for post-helium master branch

Change-Id: Ia7d73282367430258359440cbf96f5b43ab79a08
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agoBug 1909: fix maven-bundle-plugin version 49/11249/1
Ed Warnicke [Tue, 16 Sep 2014 16:58:54 +0000 (11:58 -0500)]
Bug 1909: fix maven-bundle-plugin version

Change-Id: I0ee6ff2bdb3b5dc3e5eacc9f2d09a581802816a3
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoactivate consumer bundle 73/11173/1
Thomas Kee [Sun, 14 Sep 2014 21:55:16 +0000 (14:55 -0700)]
activate consumer bundle

Change-Id: Ifefa28c1940e2573483c90fce215d584e33e8446
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agorha and tek code push for code complete 71/11171/1
Thomas Kee [Sun, 14 Sep 2014 20:54:02 +0000 (13:54 -0700)]
rha and tek code push for code complete

Change-Id: I2ec80d68cdf9cf34a7127191f1de30d116607fcd
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agolost pom entries 80/10880/1
Thomas Kee [Sat, 6 Sep 2014 21:20:06 +0000 (14:20 -0700)]
lost pom entries

Change-Id: I06fa7fb7bba48269ac274f2d7107294021b01320
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agoAdjustment to features missing from merge 79/10879/1
Thomas Kee [Sat, 6 Sep 2014 20:44:37 +0000 (13:44 -0700)]
Adjustment to features missing from merge

Change-Id: I201c5790c25613610f533e6a563f61d153e317cc
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agoSync: md-sal augmentation re-model with broker. Traffic profile: Best Effort hooked up. 73/10873/1
Thomas Kee [Sat, 6 Sep 2014 06:58:33 +0000 (23:58 -0700)]
Sync: md-sal augmentation re-model with broker. Traffic profile: Best Effort hooked up.

Change-Id: I12551cf44db640d9ff3515214a87cfe1d2ba1f39
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agoremove consumer from features 61/10861/1
Thomas Kee [Fri, 5 Sep 2014 19:59:37 +0000 (12:59 -0700)]
remove consumer from features

Change-Id: I422392554f2b584ee655f0606852ccccac597ca5
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agoremove consumer and other unneeded artifacts 58/10858/1
Thomas Kee [Fri, 5 Sep 2014 16:46:55 +0000 (09:46 -0700)]
remove consumer and other unneeded artifacts

Change-Id: I22f715dcb6f813e5da3a46df23ad2837659f2f3a
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agoplz work 33/10733/1
Thomas Kee [Wed, 3 Sep 2014 21:55:23 +0000 (14:55 -0700)]
plz work

Change-Id: I84a3350a0cf46c17aaf4b338163667d60dd5c1b8
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agowatch jenkins 32/10732/1
Thomas Kee [Wed, 3 Sep 2014 21:28:45 +0000 (14:28 -0700)]
watch jenkins

Change-Id: I685eb765afc969b3b55a0ff513f2b6a1252e9980
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agoAdd release and snapshot repos 30/10730/1
Thomas Kee [Wed, 3 Sep 2014 21:05:12 +0000 (14:05 -0700)]
Add release and snapshot repos

Change-Id: Ice6e35d10977a01966455e1647013f446065b32e
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agofeature missing group id change 64/10564/1
Thomas Kee [Mon, 1 Sep 2014 01:20:23 +0000 (18:20 -0700)]
feature missing group id change

Change-Id: Id2e83216f0a5e59c1cd918ddd3e0a6dda8aeb205
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agomodel pom.xml ci 63/10563/1
Thomas Kee [Mon, 1 Sep 2014 00:51:58 +0000 (17:51 -0700)]
model pom.xml ci

Change-Id: I227decb47b26980276f14f4352bc7daa09fc2c01
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agoRemove junk 62/10562/1
Thomas Kee [Mon, 1 Sep 2014 00:37:52 +0000 (17:37 -0700)]
Remove junk

Change-Id: Ibb3b87edf26e46a6f0d50c2afb30e065486adefa
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agoChange the group id 61/10561/1
Thomas Kee [Mon, 1 Sep 2014 00:35:35 +0000 (17:35 -0700)]
Change the group id

Change-Id: Ie7708a519cbf2fe1a51446cbf09d376c0da1363e
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agofix features, again 56/10556/1
Thomas Kee [Sun, 31 Aug 2014 20:42:25 +0000 (13:42 -0700)]
fix features, again

Change-Id: I05f06a933e24ab3c4e68f0e555bc836c9d0c93ca
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agoAdd packetcable-driver as a bundle and fix karafe depends. Merge hop-along model... 55/10555/1
Thomas Kee [Sun, 31 Aug 2014 19:58:29 +0000 (12:58 -0700)]
Add packetcable-driver as a bundle and fix karafe depends.  Merge hop-along model rewrites. Ensure build sanity.

Change-Id: I83e7fd93fdc7650250a3e05c4903217417b4812d
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agoMerge changes I8eb61ed9,I09e66c9f,Ic4c8c6f5
Thomas Kee [Sat, 30 Aug 2014 21:22:03 +0000 (21:22 +0000)]
Merge changes I8eb61ed9,I09e66c9f,Ic4c8c6f5

* changes:
  Functional Karaf additions
  correct features to reflect bundle structure change
  correct features to reflect bundle structure change

9 years agoFixing up the model. 29/10529/1
Ed Warnicke [Sat, 30 Aug 2014 21:18:21 +0000 (16:18 -0500)]
Fixing up the model.

Change-Id: I67322fa1a0e663dc5351a48500e49eb974d0297e
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoFunctional Karaf additions 28/10528/1
Thomas Kee [Sat, 30 Aug 2014 21:12:23 +0000 (14:12 -0700)]
Functional Karaf additions

Change-Id: I8eb61ed9e3009b145c0d57c2972d1335bd04cdea
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agocorrect features to reflect bundle structure change 18/10518/1
Thomas Kee [Sat, 30 Aug 2014 15:10:53 +0000 (08:10 -0700)]
correct features to reflect bundle structure change

Change-Id: I09e66c9f6886e51f02c0bc4aca1156c9baa3ce35
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agocorrect features to reflect bundle structure change 17/10517/1
Thomas Kee [Sat, 30 Aug 2014 15:02:32 +0000 (08:02 -0700)]
correct features to reflect bundle structure change

Change-Id: Ic4c8c6f5678bd5b75f7565a64fa99678502339a0
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agoAdd ODL Repo; Save commit_msg 84/10184/1
Thomas Kee [Fri, 22 Aug 2014 19:40:15 +0000 (12:40 -0700)]
Add ODL Repo; Save commit_msg

Change-Id: I532a0ed9d228d371778f52746d5489dfa939b7d3
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agoMerge "developer house keeping"
Thomas Kee [Wed, 20 Aug 2014 22:22:05 +0000 (22:22 +0000)]
Merge "developer house keeping"

9 years agodeveloper house keeping 13/10113/1
Thomas Kee [Wed, 20 Aug 2014 21:30:55 +0000 (14:30 -0700)]
developer house keeping

Change-Id: Ib9d8cb18f196d17cc115ed162164fc874ecc5d53
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agoconsumer/provider restructure 12/10112/1
Thomas Kee [Wed, 20 Aug 2014 21:30:55 +0000 (14:30 -0700)]
consumer/provider restructure

Change-Id: Ib3611b00862a21aaeb1ece4aad231404921594be
Signed-off-by: Thomas Kee <xsited@yahoo.com>
9 years agoStarted draft of features file for karaf distro 95/9495/3
Jonathan Fok kan [Wed, 30 Jul 2014 15:13:27 +0000 (11:13 -0400)]
Started draft of features file for karaf distro

When installed in karaf odl-packetcable gives:

org.pcmm.PCMMPdpAgent:Error socket
 -Reason: Connection timed out

Change-Id: I34f5b9b3969533e8350c2a5bd2eb72267a2af1a2
Signed-off-by: Jonathan Fok kan <jfokkan@inocybe.com>
9 years agoAdd the previous docs to be extended 16/9216/1
Thomas Kee [Tue, 22 Jul 2014 05:12:39 +0000 (22:12 -0700)]
Add the previous docs to be extended

Change-Id: I57d80ad6de5aabe8f14f5ba5b0cbe88ebe64510c
Signed-off-by: Thomas Kee <xsited@yahoo.com>