Michael Vorburger [Fri, 6 Apr 2018 19:28:51 +0000 (21:28 +0200)]
increase code quality in tools api/testutils by using infrautils' parent
Change-Id: I7485ce352b452cec2db19c5e726c9bb51438846c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Nobin Mathew [Mon, 16 Apr 2018 09:37:41 +0000 (15:07 +0530)]
AlivenessMonitor pause/stop should work in a cluster
JIRA: GENIUS-126
Change-Id: I464c3d6bdd67ebda2c47cdbb22d69e9b254b28c6
Signed-off-by: Nobin Mathew <nobin.mathew@ericsson.com>
Edw7n [Tue, 24 Apr 2018 06:35:01 +0000 (12:05 +0530)]
Support for ITM direct tunnels in ITM workers
Modified the ItmInternalTunnel Add and Delete workers
to support creation/deletion of tunnels directly by ITM
Fixed issues while testing
Fix for bfd CSIT failure
Change-Id: I1bd9c0edf1f549168d95bc2e7c1e7c3caf6b5967
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Edw7n [Thu, 5 Apr 2018 04:21:29 +0000 (09:51 +0530)]
Updating tunnel status based on tp status update
Update the ITM tunnel status by listening to the termination point status
Fixed issues while testing
Change-Id: I5b9b5389b4a2073d6648b164f2a5975484874ab1
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Edw7n [Wed, 4 Apr 2018 14:59:13 +0000 (20:29 +0530)]
Implemented tunnel state updation
Listening to the inventory DS and create tunnel state information and also
program the ingress flows related to the tunnel
Fixed issues while testing
Change-Id: I83b0b6e95156ad7013cd8b3ff9902dcfed0a35ee
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Edw7n [Wed, 4 Apr 2018 14:11:17 +0000 (19:41 +0530)]
Support for tunnel creation directly by ITM
Implemented creation of tunnels directly by ITM when the switch connects.
Conditional creation of listener if the itm-direct-tunnel flag is enabled.
Removed unused constants from ITMConstants.
Fixed some issues while testing
Change-Id: Ib5bef52ca85f7589057fadc2614e97de14e0109a
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Michael Vorburger [Wed, 18 Apr 2018 09:50:48 +0000 (11:50 +0200)]
remove duplicate pax-cdi-api dependency in mdsalutil-impl
[WARNING] Some problems were encountered while building the effective model for org.opendaylight.genius:mdsalutil-impl:bundle:0.5.0-SNAPSHOT
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.ops4j.pax.cdi:pax-cdi-api:jar -> duplicate declaration of version (?) @ line 115, column 17
Change-Id: I6a470db91686a790c76270386821bb364d75eae6
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Sun, 25 Mar 2018 22:13:17 +0000 (15:13 -0700)]
Use OVSDB features instead of bundles
odl-genius-api depends on OVSDB’s utils.config, and currently attempts
to embed it; instead, depend on the odl-ovsdb-utils feature which
provides it.
Change-Id: I98da04b8978525946fcdeb98da4b989ef2571485
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Faseela K [Wed, 11 Apr 2018 05:52:42 +0000 (11:22 +0530)]
Remove deprecated utils in mdsalutil-api
Listener base classes as well as FutureRpcResults are moved to genius/tools
and all the usages are also migrated to the new utils. Let us remove
the deprecated utils asap, so that new usages will not creep in :)
Change-Id: I27a004694ae762fc7420156be11e0a34e76cc7a7
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Mon, 16 Apr 2018 09:15:20 +0000 (14:45 +0530)]
BFD status not reflected accurately on controller restart
Itm-direct-tunnels code patches had modified a check for handling
BFD, in a wrong manner, so that controller restart cases won't be handled
properly. Fixing the same.
Change-Id: I0a674fc337534355c45f40d0f40e134301dca1f0
Signed-off-by: Faseela K <faseela.k@ericsson.com>
David Suarez [Mon, 2 Apr 2018 21:48:59 +0000 (23:48 +0200)]
Migrate the last two listeners in itm-impl module
Migrate the last two listeners in itm-impl module to use the new
listeners framework.
Change-Id: I0a7bc5ed17634f72b7dffcd1f8818d454e3cc489
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Faseela K [Wed, 18 Apr 2018 08:46:24 +0000 (14:16 +0530)]
Fix issues with SRM test plan
Change-Id: I91bfc8a1fc37d5ea4a673d6b2c26b11a0310a6ce
Signed-off-by: Faseela K <faseela.k@ericsson.com>
K.V Suneelu Verma [Wed, 11 Apr 2018 12:07:49 +0000 (17:37 +0530)]
add l2gw and dhcp for service recovery
Change-Id: Ia01f6c99016573802efce726396856dda2326138
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
Faseela K [Fri, 13 Apr 2018 06:31:28 +0000 (12:01 +0530)]
Re-enable FindBugs and ignore the null violations
Change-Id: I6d5e905119dfa3f57b9b6a0ce2f61f16fb924e4a
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Nidhi Adhvaryu [Fri, 16 Mar 2018 11:03:59 +0000 (16:33 +0530)]
TestPlan for SRM
Change-Id: I7ebd5ed2eff066de0f1d8b373615847e65a030fe
Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
Stephen Kitt [Thu, 22 Mar 2018 17:24:32 +0000 (18:24 +0100)]
Bump to odlparent 3.1.0 and yangtools 2.0.3
Change-Id: If99df255661c177c6424ee7eb7f77fdb00522d63
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Thu, 12 Apr 2018 17:00:16 +0000 (19:00 +0200)]
remove un-used org.osgi.core from tools-api
Change-Id: I34b353fedafe908baacd536c58a26670e2f09a4f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Thu, 12 Apr 2018 15:23:30 +0000 (20:53 +0530)]
wrong feature dependencies in newly added features.
Change-Id: Ie592de3ee8f6ba01c86e7d411dad8d5c411cf59c
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Wed, 11 Apr 2018 13:04:30 +0000 (15:04 +0200)]
remove un-used it-parent
Change-Id: I32eaa7da323298780035b2b9080ac9f9fbe36c76
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Tarun Thakur [Wed, 28 Mar 2018 09:58:45 +0000 (15:28 +0530)]
Support for dynamic update of local_ip from SBound
This change will enable support for dynamic change in TEP's local_ip.
No need to explicitly remove tep and then add to achieve update
operation.
Simply update other_config's local_ip in openvswitch table of OVSDB to
update tep in the transport-zone inside ODL.
Change-Id: Ia3ba618dd95945f8bb4b14aa8c8f9b4b74ac0e92
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>
Tarun Thakur [Mon, 2 Apr 2018 10:42:38 +0000 (16:12 +0530)]
Change ext ID tzname key to transport_zone
This is for changing external_id's tzname key to transport_zone
which seems more understandable and better for long run.
Change-Id: I2d932b7a74bb2a21cf811e7feb27c4f372d81ec2
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>
Tarun Thakur [Wed, 4 Apr 2018 08:31:15 +0000 (14:01 +0530)]
Spec update against reviews #70100, #70246, #70319
Spec is updated against below reviews:
Review ID: 70100
Move tepsNotHosted from Config DS to Oper DS
Review ID: 70246
Change ext ID tzname key to transport_zone
Review ID: 70319
Support for dynamic update of local_ip from Southbound
Change-Id: I99a47049f1fe850560754239d00465eaa11556db
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>
Nishchya Gupta [Fri, 6 Apr 2018 14:02:22 +0000 (19:32 +0530)]
NETVIRT-1198: Acl Stats does not support Anti Spoof drop stats.
Support has been added in netvirt which requires few new definations in genius.
Change-Id: I9a4750209e134338e4f06506dea6e1273ecaa922
Signed-off-by: Nishchya Gupta <nishchyag@altencalsoftlabs.com>
(cherry picked from commit
754e9833ac42a6fa937894144a0b5b255faf616f)
Faseela K [Tue, 10 Apr 2018 17:41:55 +0000 (23:11 +0530)]
Revert "Revert "GENIUS-116: Efficient Handling of DPN disconnect""
This reverts commit
1c26ba35a1c6e03534151bbddeed8ec4d460c109.
Change-Id: Ie09689a0d1596c09e0a18d4e4ed462cbca46106e
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Tom Pantelis [Thu, 28 Dec 2017 20:10:29 +0000 (15:10 -0500)]
Replace HwvtepHACache with HwvtepNodeHACacheImpl
HwvtepHACache is replaced by HwvtepNodeHACacheImpl in the
mdsalutil-impl bundle.
Change-Id: Id29450416ae0f738b0e91d108e22418341d70b22
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
David Suarez [Tue, 10 Apr 2018 14:05:43 +0000 (16:05 +0200)]
Remove unnecessary @Inject annotation in abstract classes
Remove unnecessary @Inject in abstract classes as described in [1].
[1]https://git.opendaylight.org/gerrit/#/c/70455/
Change-Id: I837995ae4a4ada0cd59ed5cc3c3ccb75e3341b2b
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Faseela K [Mon, 9 Apr 2018 09:02:38 +0000 (14:32 +0530)]
Migrate users of mdsalutil-api/Abstract listener base classes to tools/listeners
Change-Id: Ib00afd1c8f4d45317fc5bd8ee1d3d4e0afcf7f93
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Stephen Kitt [Wed, 21 Mar 2018 15:46:05 +0000 (16:46 +0100)]
InterfaceInventoryStateListener: check presence in tx
This checks node presence inside transactions, ensuring that state
changes are consistent.
Change-Id: Ia6a66a6859215c86ad393a340536fd77b9d70ec1
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Fri, 6 Apr 2018 17:22:11 +0000 (19:22 +0200)]
make DataStoreMetrics package local instead of a publicly supported API
and, exceptionally, keep it copy/pasted into the old (mdsalutil) and new
place (genius.tools); this IMHO is, exceptionally, better than keeping
something public - hopefully the duplicate in the old package will be
removed soon-ish, anyway.
Change-Id: I997dbb6eeb702f010eaee1becea1a43b57d950b3
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Tue, 10 Apr 2018 12:45:03 +0000 (14:45 +0200)]
ignore InterfaceManagerConfigurationTest's newl2vlanInterfaceTests()
because, apparently, it has become unstable (again?!), despite much
recent progress Faseela made to finally make it more predictable :-(
Issue: GENIUS-120
Change-Id: I548ce8f6da3433cc0a0aa490b1ac76e4c0c2d685
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Mon, 9 Apr 2018 08:57:03 +0000 (14:27 +0530)]
Migrate mdsalutil-api/FutureRpcResults to tools/FutureRpcResults
Change-Id: I9e9e92ed3307a282b920f0b14b1a5980b0f031a4
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Fri, 6 Apr 2018 17:43:36 +0000 (19:43 +0200)]
remove test-jar from new tools-api artifact
This is not needed here, and before anyone creates a dependency to the
new (empty) attached test artifact by mistake, should be removed to
avoid any confusion.
A test-jar is only required if we need to publish src/test on Nexus.
This project does not even have a src/test; and even if it did, we would
only ever have tests for tools-api in it, not test utilities which other
projects would use - because we have the tools-testutils for that,
instead.
Change-Id: Ie1a3152386fee538eb812d52985a3ac17db8520b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Fri, 6 Apr 2018 16:45:25 +0000 (18:45 +0200)]
link ManagedNewTransactionRunner in SingleTransactionDataBroker's doc
Change-Id: I6e70198275f3bab31f7ab836fecf261195d1ed84
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Mon, 9 Apr 2018 12:05:57 +0000 (17:35 +0530)]
Add Cookie for COE Kube Proxy Table
Change-Id: Ib21556fa772ee37c80a8b205ed4cd5f099df6cac
Signed-off-by: Faseela K <faseela.k@ericsson.com>
David Suarez [Fri, 6 Apr 2018 22:55:46 +0000 (00:55 +0200)]
Migrate listener's methods
Migrate add, update and remove methods to use the new ones.
Change-Id: Ia53baaa5a2333168f2bd6983fda616fefb885b7d
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Faseela K [Wed, 21 Mar 2018 12:43:48 +0000 (18:13 +0530)]
Moving datastore related utils from mdsalutil to new "genius.tools"
There are several requirements coming in where users are asking for a
simple feature with only datastore related utils. Currently all the utils
are parked in mdsalutil which has even openflowplugin related utils, and is embedded
in a heavier genius feature. This patch aims to move of these heavily used utils
to a new module, and add new features to expose the same.
Change-Id: I7d59273851c51b02fe43afcb1525c94ced1c5088
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Thu, 29 Mar 2018 16:53:27 +0000 (22:23 +0530)]
New table for COE Kube Proxy
COE needs a new table for service implementation, Adding
Table 30 for the same. Also this will be a new service, which
should be of higher priority than L3 and hence moving all
the lower priority services by 1.
Change-Id: If14bbef5d8d7f5b54093a645c5625ee35e605730
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Thanh Ha [Sat, 7 Apr 2018 01:58:10 +0000 (21:58 -0400)]
Add Karaf build profile
Project local Karaf distros are handy for devs to test their work
however is unneeded by autorelease builds and should not be released
as part of the Simultanious Release. Add a profile that is active by
default so that default behaviour is unchanged however allows the
autorelease project to disable building this module.
Issue: RELENG-86
Change-Id: I4e8ccf36f901d4127a7a9254797b87e7dc7b9c64
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sat, 7 Apr 2018 01:57:04 +0000 (21:57 -0400)]
Remove obsolete Maven Site configuration
Change-Id: Ia98ab43c4687b63f59c2fe39f247c3e58f71f47d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Stephen Kitt [Wed, 21 Mar 2018 14:51:24 +0000 (15:51 +0100)]
AlivenessMonitorUtils: wrap top-level in transactions
This uses transactions throughout based on top-level operations,
propagating the transaction through the call chain to ensure
consistent views of the MD-SAL.
Change-Id: Iae31775989102b1277a4e8a11a7f0633df21ae08
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 16 Mar 2018 10:00:40 +0000 (11:00 +0100)]
Remove MDSALDataStoreUtils
Since there are very few users left, remove the class entirely
(replacing it with SingleTransactionDataBroker).
This needs Ia012cc825a9eb7768de91c1882f76127d44c3595 to be merged
first.
Change-Id: I3c89e6549c7f2355583d6192d9134e9e589fbd39
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Aswin Suryanarayanan [Sat, 3 Mar 2018 05:06:14 +0000 (10:36 +0530)]
NETVIRT-430 Ping responder on tenant network and FIP-FIP traffic between
vm in same n/w in same compute is not working in stateful SG mode.
Added Ct Clear action
Depends-on: Change-Id: I163ed99d5af8d3643749ac2a278f5c8170d7ae29
Change-Id: If86203e73a5ec516ff487f3f5c33fbd7dbfd12e1
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Michael Vorburger [Thu, 22 Mar 2018 13:54:07 +0000 (14:54 +0100)]
add requireNonNull to SingleTransactionDataBroker constructor
thought of this while seeing this which is actually broken:
@Inject DataBroker dataBroker;
S.T.D.B. db = new SingleTransactionDataBroker(dataBroker);
which cannot work with Dependency Injection (Guice or otherwise), and
it's better to have the null check here in the constructor already, not
fail with NPE later when one of the (non-static) methods of it is used.
see Change-Id: I63d0a93da481003b701c5a1843cece7d50cf51d1
Change-Id: I319d92c2bb50446ff59d156c4f261a51afe01863
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 5 Apr 2018 14:46:36 +0000 (16:46 +0200)]
fix broken build; recent *Transaction change which removed commit()
The {@link ReadWriteTransaction#commit()} in JavaDoc lead to an "error:
reference not found" in maven-javadoc-plugin:3.0.0:jar (attach-javadocs)
@ mdsalutil-api during the build.
Change-Id: Ic489315ab050136f9de06a0331574aebb26e69c2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Fri, 16 Mar 2018 10:24:55 +0000 (11:24 +0100)]
Remove AlivenessMonitor::read
This can be entirely replaced by SingleTransactionDataBroker.
Change-Id: I8c302537f7abefafc1cf57c5e5c884a6b879c18f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Somashekar Byrappa [Thu, 22 Mar 2018 12:00:55 +0000 (17:30 +0530)]
Removed unused ACL constants
Ensured there are no references in netvirt for these constants.
Change-Id: I4372e2cd7733b469d0dee6f0ba0afc551eff0af5
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>
Stephen Kitt [Thu, 22 Mar 2018 09:59:05 +0000 (10:59 +0100)]
Add transaction variant of getChildInterfaces
In preparation for removing the current implementation of
IInterfaceManager::getChildInterfaces, this patch adds a variant
accepting a transaction (along with a few other related methods).
Change-Id: Idd93023de5b549c8ee7bed23fc3c485752d87548
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Tue, 3 Apr 2018 15:20:02 +0000 (17:20 +0200)]
increase max time out in AbstractTestableListenerTest from 50ms to 500ms
Change-Id: Ic45ad3bf911f81e030f7e425510a37fb2a54df0d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Tarun Thakur [Mon, 26 Mar 2018 09:51:49 +0000 (15:21 +0530)]
Move tepsNotHosted from Config DS to Oper DS
As tepsNotHosted list was part of transport-zones container in itm.yang
and stored into config DS earlier. Since, it gets populated from
southbound only and will be available again on switch/ODL restart,
even if the switch goes away, we do not want to track these information
unnecessarily in the config DS. So, it is better to keep this data into
OperDS instead of config DS.
Change-Id: I731dfdb64ea3dc589567f4abeac3457ca0cbe395
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>
Tom Pantelis [Thu, 22 Mar 2018 22:22:23 +0000 (18:22 -0400)]
Remove deprecated AsyncWriteTransaction#commit method
This method has been deprecated for quite some time and now has a
default implementation so can be safely removed from sub-classes.
Change-Id: I584c2e51ee1241b0198bcd310c2d2ca3d1b0f55a
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Michael Vorburger [Thu, 22 Mar 2018 13:48:05 +0000 (14:48 +0100)]
deprecate IfmUtils' read() method
Change-Id: If1f5b547f9861f28066f3c490c2164b82c310536
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Mon, 12 Mar 2018 16:40:56 +0000 (17:40 +0100)]
Use new Map methods
Map::computeIfAbsent models the common "initialise value collection
when missing and add to it" idiom.
Change-Id: I6e21374a8dc3fba0b4942c40d0ab1031d65b97f8
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 12 Mar 2018 16:40:39 +0000 (17:40 +0100)]
Use switch instead of chained ifs
Change-Id: I9d99d610abc7984e146b459a7fa3dcdd64425aa1
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 12 Mar 2018 16:38:20 +0000 (17:38 +0100)]
Add a model conversion method for InterfaceOpState
Change-Id: I984cb90ddd81e78bb346ece701de2ccf2de4edce
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Tue, 20 Mar 2018 13:33:21 +0000 (14:33 +0100)]
deprecate ItmUtils' async*() methods
Change-Id: I82e08e6a2a31a2dda014e69eebea1373ddc3e1a6
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Wed, 21 Mar 2018 15:02:56 +0000 (16:02 +0100)]
Flow-based listeners: use top-level transactions
This changes the listener to use a single transaction for its
top-level operations.
Change-Id: I739ba6ce11b881331945d77ea2a9d7c3b2120206
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Edw7n [Tue, 6 Mar 2018 06:11:17 +0000 (11:41 +0530)]
Utils for itm performance enhancements
Change-Id: Id0400bd56473550ebc49d2968024632fcdf5b265
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Faseela K [Thu, 15 Mar 2018 12:05:29 +0000 (17:35 +0530)]
Re-enable interface-manager l2vlan component tests
Change-Id: I63d0a93da481003b701c5a1843cece7d50cf51d1
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Wed, 21 Mar 2018 08:47:45 +0000 (14:17 +0530)]
Make createVlanInterface APIs return ListenableFuture
Note : This will require a remerge in netvirt repo.
Change-Id: I91511a3b6e7aa6f4709c9ebb215c5ce5f4d49a55
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Edw7n [Mon, 12 Feb 2018 17:50:07 +0000 (23:20 +0530)]
yang changes for scaling,
to support corresponding netvirt changes
Change-Id: If29c11f61658a44f8b5614baddfe660782fb7c69
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Michael Vorburger [Tue, 20 Mar 2018 13:26:06 +0000 (14:26 +0100)]
deprecate ItmUtils' read() and write() methods
Change-Id: I848145f71b3a3002898b34d26b9699514f14b684
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Mon, 18 Dec 2017 17:19:50 +0000 (18:19 +0100)]
GENIUS-103: use a callback to start LLDP monitoring
This ensures that the transaction is *processed* before we start LLDP
monitoring.
Change-Id: I61abc7e1d03321fd94c86fbe311aed2a2e3951ca
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Vishal Thapar [Wed, 21 Mar 2018 09:08:50 +0000 (14:38 +0530)]
Fix ITM UT failures
Yangtools has changed how IPAddresses are converted
to string. ITM code is using different methods to
convert String IPs to IpAddress. Fix is to use
IpAddressBuilder, which is v4/v6 anogstic, at all
places.
Change-Id: I49649152a2f97b8b1cbdc19a3bb35fd0791ff2a8
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Stephen Kitt [Mon, 12 Mar 2018 16:14:57 +0000 (17:14 +0100)]
Use Map::forEach instead of streaming maps
Change-Id: I3419d9767571ecc2ed078c0dee010fb512523938
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Wed, 7 Mar 2018 10:16:38 +0000 (11:16 +0100)]
add real Lifecycle management to DataObjectCache
by throwing an IllegalStateException if you get() or getAllPresent()
after close(), to prevent it from being used after it's closed, as was
attempted in Change-Id: I8d5f15757a805798f16b98b79b3ad03899b1130d (which
would lead to quite weird behaviour)
Change-Id: Id3a21afe5f297bebe15fc94bcd1fb24178bc334a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Tue, 20 Mar 2018 13:34:46 +0000 (14:34 +0100)]
minor JavaDoc fix to ManagedNewTransactionRunner
It should not @link to a (now) only package local class.
Change-Id: I444cb537be04401740793724d41e7e1b1736c441
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
eswanit [Fri, 16 Mar 2018 09:05:10 +0000 (14:35 +0530)]
Service-Recovery: support for elan-interface entity type
instead of elan-instance entity type
Change-Id: I723bd2ac707bf8b34d869b9b7abfdea4b616c47a
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>
Stephen Kitt [Mon, 12 Mar 2018 09:35:07 +0000 (10:35 +0100)]
Remove redundant type information
Change-Id: Ic03751095df7ff7a01dc112d7f397df94fc09096
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 12 Mar 2018 16:39:57 +0000 (17:39 +0100)]
Clean up lambdas
Use method references and lambda expressions where appropriate.
Change-Id: Id329f3a6abc9d23678e6b5e4ce554778fc590c00
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Nidhi Adhvaryu [Fri, 9 Mar 2018 10:28:27 +0000 (15:58 +0530)]
Service Recovery Manager for ITM
Change-Id: I5dab695d7c397606728c46f19c4f2e2e38dfef42
Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
Edw7n [Wed, 7 Mar 2018 07:15:17 +0000 (12:45 +0530)]
Caches for newly introduced immutables in ITM
Change-Id: I8d5f15757a805798f16b98b79b3ad03899b1130d
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
malani [Sun, 11 Mar 2018 22:22:03 +0000 (03:52 +0530)]
enforce correct logging via findbugs-slf4j (GENIUS-118)
Modified genius/commons/binding-parent/pom.xml
to enable findbugs-slf4j enforcement in binding-parent.
This ensures we won’t have any regressions in log handling in modules
based on binding-parent.
Change-Id: I7030f32c3c5f16afb6ed7cd5e8c8ff96ca4865a2
Signed-off-by: Saurav Malani <sauravmalani1@gmail.com>
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Thu, 15 Mar 2018 19:21:48 +0000 (00:51 +0530)]
Fix ItmAlarm Exception in logs
This is a regression caused by :
https://git.opendaylight.org/gerrit/#/c/67658/
Change-Id: I16b58dc3a08bb012dd4d9366a77a9e4bf9ef064b
Signed-off-by: Faseela K <faseela.k@ericsson.com>
sathwik boggarapu [Wed, 14 Mar 2018 09:48:25 +0000 (15:18 +0530)]
Fix logging issues in ITM
Change-Id: Ie2d697ce8026f3b75022ac7150457dde9f486582
Signed-off-by: sathwik boggarapu <b.sathwik@ericsson.com>
sathwik boggarapu [Wed, 14 Mar 2018 07:17:00 +0000 (12:47 +0530)]
Fix logging issues in InterfaceManager
Change-Id: Ib77840b84f6190be7537c4a6f6f32d317cf89414
Signed-off-by: sathwik boggarapu <b.sathwik@ericsson.com>
David Suarez [Mon, 29 Jan 2018 13:00:52 +0000 (14:00 +0100)]
Migrate ItmTunnelEventListener to use new listeners fw
Some additional changes:
- Make some variables final
- Remove dead code
- Make some methods private
Change-Id: I2679bb74ef1aafa775ab23cb1577a6c770f617fe
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Stephen Kitt [Tue, 14 Nov 2017 11:15:51 +0000 (12:15 +0100)]
GENIUS-102: interface manager: use transaction manager
Use the transaction manager to manage all write transactions.
Change-Id: If224c5193e4e9f4c12ebcaa1c31864646aafd026
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 12 Mar 2018 16:33:26 +0000 (17:33 +0100)]
Use List::sort instead of Collections::sort
Change-Id: Ia9949460dd3e09b00cabd887a70386e42370734c
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Tom Pantelis [Thu, 8 Mar 2018 12:56:12 +0000 (07:56 -0500)]
Extend DataObjectCache to allow for custom key
Users want to be able to provide a custom key derived from the
DataObject instead of keying by InstanceIdentifier.
Change-Id: I5f55068ff56390998270c2813d2682763479a404
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
David Suarez [Wed, 14 Mar 2018 19:51:11 +0000 (20:51 +0100)]
Fix abstract listeners
The deprecated method are now properly implemented in the base class
Change-Id: Ieab4e8e4537400a7a1d27ca85a1bee4a812c79b8
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
sathwik boggarapu [Wed, 14 Mar 2018 11:56:45 +0000 (17:26 +0530)]
Fix logging issues in alivenessmonitor
Change-Id: I730efda2afc6ffbeed547737e47c980ae418ccd5
Signed-off-by: sathwik boggarapu <b.sathwik@ericsson.com>
Faseela K [Wed, 14 Mar 2018 16:42:35 +0000 (22:12 +0530)]
Make recoverableListenerMap maintain a queue of recoverableListeners.
This was a review comment from Michael which was not addressed on the
original patch
Change-Id: I14b7d9f4a92a4439cae40b4c4b23b7972f5468b4
Signed-off-by: Faseela K <faseela.k@ericsson.com>
sathwik boggarapu [Wed, 14 Mar 2018 12:41:04 +0000 (18:11 +0530)]
Fix logging issues in SRM
Change-Id: I89a5ff35903202d549a91a510f323856d78b1542
Signed-off-by: sathwik boggarapu <b.sathwik@ericsson.com>
sathwik boggarapu [Wed, 14 Mar 2018 11:09:05 +0000 (16:39 +0530)]
Fix logging issues in fcapsapplication
Change-Id: I4aa3358a1c4774f6eea83b7c8b7d2805d5565f5b
Signed-off-by: sathwik boggarapu <b.sathwik@ericsson.com>
Hema Gopalakrishnan [Sat, 24 Feb 2018 09:45:44 +0000 (15:15 +0530)]
Fixed issue when null is passed in CLI cmds
Due to the karaf migration, the tep CLIs were not working as expected when
null is passed as arguments in CLI cmds.
Change-Id: I4b493c1615846651717ac345b7eaf51551b80abe
Signed-off-by: Hema Gopalakrishnan <hema.gopalkrishnan@ericsson.com>
Faseela K [Wed, 14 Mar 2018 06:54:41 +0000 (12:24 +0530)]
fix logging issues in mdsalutil
Change-Id: If22e310b05d927b61d3829c7a8e7188727348afd
Signed-off-by: Faseela K <faseela.k@ericsson.com>
David Suarez [Thu, 8 Mar 2018 23:33:26 +0000 (00:33 +0100)]
Add InstanceIdentifier to method add/update/remove in Genius' listeners
Some use cases require the Genius' listeners to provide the
InstanceIdentifier as a parameter in add, update and remove methods.
The change is made on the DataTreeChangeListenerActions interface by
making the new methods the default ones. The current methods are
deprecated and they will be removed once all the current implementations
are converted.
The AbstractDataTreeChangeListener will implement the old methods until
the migration to the new ones finishes.
Change-Id: I979e5f3e2480f441828f2ee87e917543df6504b0
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Faseela K [Tue, 13 Mar 2018 09:09:43 +0000 (14:39 +0530)]
Re-enable bindings of interfacemanager junits
Change-Id: I6618539c8349ad1fd3e83959377eb08ea8a597e6
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Stephen Kitt [Mon, 12 Mar 2018 09:33:20 +0000 (10:33 +0100)]
Remove unnecessary boxing/unboxing
Change-Id: I06fee32b08066e3b1d95b7c2ca0220cef9800ab1
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Faseela K [Wed, 7 Mar 2018 10:51:37 +0000 (10:51 +0000)]
Revert "GENIUS-116: Efficient Handling of DPN disconnect"
This reverts commit
3cf5a4776c2b8dcd77049ecb3ba4e1b28bc1aa4c.
Change-Id: I7a377a9b4cd74fe9052843882e7b730a63cb0036
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Michael Vorburger [Fri, 9 Mar 2018 20:43:07 +0000 (21:43 +0100)]
simplify TestableJobCoordinatorEventsWaiter
Change-Id: Ic9e5ab1e695e296d983b5ed3783e40c0373b6189
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Ankit [Mon, 12 Mar 2018 09:39:28 +0000 (15:09 +0530)]
LockManager test failure
Looks like underlying error message has changed. After changing the
expected error message accordingly, test is passing.
Change-Id: I46829aa23c353c3c7a7de9968d54462f8d0ba7ba
Signed-off-by: Ankit <ankit.j.jain@ericsson.com>
Michael Vorburger [Mon, 12 Mar 2018 12:10:07 +0000 (13:10 +0100)]
fix ItmManagerRpcServiceTest ExternalTunnelBuilder destinationDevice
but ... the fact that this destinationDevice is a "String typed" instead
of "strongly typed" (a real YANG model) seems really wrong, to me.
Change-Id: Ibfab110a7488c3dfd1a8cecd3cace773c55bc277
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
sathwik boggarapu [Fri, 2 Mar 2018 09:18:08 +0000 (14:48 +0530)]
Updating rst doc, how to run CSIT
Change-Id: I285bd34e687945801f1b1443d523a6c3b3908915
Signed-off-by: sathwik boggarapu <b.sathwik@ericsson.com>
Faseela K [Fri, 9 Mar 2018 14:49:52 +0000 (20:19 +0530)]
JobCoordinatorEventsWaiter to wait for specific job count completion
Change-Id: I88fb852a5bae667716044b61f4689f9fe258a151
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Edw7n [Fri, 2 Mar 2018 05:23:32 +0000 (10:53 +0530)]
Immutables for performance enhancements
Change-Id: I150d8edc58ad91724679dba15a1f269bd9e2e674
Depends-on: I250b75fea3ae29e8adb351693e7eeb0a596e18fe
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Tom Pantelis [Thu, 8 Mar 2018 12:42:36 +0000 (07:42 -0500)]
Add InstanceIdDataObjectCache
DataObjectCache will be extended to allow for custom key so
add implementation that keys by InstanceIdentifier.
Change-Id: I16450c794512afde8d1091dc88f43a43ef8639b5
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Josh [Tue, 27 Feb 2018 05:49:56 +0000 (07:49 +0200)]
Bug: GENIUS-115 OVS Nodes Connect Quickly, Not All Get TransportZone TEPs
1) In ItemTepAddWorker do NOT use cached DPNTEPsInfos, read from DS instead
2) In ItmInternalTunnelAddWorker do not queue the new DPNTEPsInfos via
ITMBatchingUtils, instead write synchronously and unbatched in that thread
Change-Id: I91be9de8e7d098fbe94abc480605f460dfecef79
Signed-off-by: Josh <jhershbe@redhat.com>
Faseela K [Wed, 7 Mar 2018 06:39:12 +0000 (12:09 +0530)]
Issues with SRM service recovery
service recovery logic was doing a close of the already registred
listeners. However the close method of the AsyncListener base classes
were shutting down the dataTreeChangeHandlerExecutor as well, which
will cause issues when we again register the listeners.
Change-Id: I2e39c9ba0226c298fbd10f114ad33be39ae961a0
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Edw7n [Sat, 17 Feb 2018 20:27:39 +0000 (01:57 +0530)]
ifm changes for itm performance enhancements
Change-Id: I250b75fea3ae29e8adb351693e7eeb0a596e18fe
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Code Review / genius.git / log