ignore test testMultithreadedIdAllocationFromReleaseIds of Idmanager

This test is failing and causing build faliure for other patches.
It seems like the issue with test framework and required investigation.
For now ignoring the test so that build can go through for other
patches.

Signed-off-by: Ankit Jain <ankit.j.jain@ericsson.com>
Change-Id: Id613ac771b6d8774f26c4902c8a3a24bb6cfe331

MRI version bump for Aluminium

This bumps versions to the following:
- odlparent-7.0.1
- yangtools-5.0.1
- mdsal-6.0.0
- controller-2.0.0

Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>
Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
Change-Id: I508ba70555f52da12439a3963d642fc60cfe7775

Fix javadoc failures in genius

Fixing javadoc failures post MDSAL-API migration.

Change-Id: I9e6c5408c5f132006bc0c737a0980ac0fe6425c8
Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>

InfraUtil JobCordinator Changes.

Desc:
https://git.opendaylight.org/gerrit/c/infrautils/+/89057

Change-Id: I76744bf161cc6d1edadf013f2310f6aa6bb1efae
Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>

MDSAL-API Migration

1)Change Futures to FluentFuture
- Remove ReadFailedException
- Replace TrnasactionCommitfailedException with Execution
  and Interrupted exception
- submit() -> commit()
- checkedGet() -> get()

2)Change org.opendaylight.controller.md.sal package to org.opendaylight.mdsal
- Primarily databroker, all transactions
- ReadOnlyTransaction -> ReadTransaction

3)Change com.google.common.base.Optional to java.util.Optional

4)Change serviceutils.tools.mdsal.listener to serviceutils.tools.listener

Change-Id: I91f6178e1ef363d989cd19e2ab7048001e811ed7
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>

Use Magnesium controller

As part of controller transition to being MRI, downgrade the version
used to Magnesium release. This will be bumped to Aluminium proper
during the MRI window.

Change-Id: I84d1c7cdeaf8ae9bd3b00070c434e8a27ba23665
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "doesExists() utility method"

This reverts commit 8b0a3fd63b457589f0f869897c46c696994c618c.

Reason for revert: Remove Deprecated APIs

Signed-off-by: Hema Gopalakrishnan <hema.gopalkrishnan@ericsson.com>
Change-Id: I60b0723c3e927ffe65ed0f55f05e2241bb4c51b1

doesExists() utility method

Common utility method doesExists() added to check whether any DS entry
exists or not in SingleTransactionDataBroker

Change-Id: I92a8f5bda8d4d924be6a820e6a18acd598a40dae
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>

Bump versions by x.y.(z+1)

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I897b2682f347c8e1eb9f03e211882a1c008df499

Encapsulate ActionableResourceImpl

This provides ActionableResources for use by external users, which
enforce well-formedness off ActionableResource. This allows us to
eliminate the need for ActionableResource.getKey(), which is not
used anywhere aside from ResourceBatchingManager, where we can
simply default to ActionableResource.toString().

This eliminates the need to eagerly invoke InstanceIdentifier.toString()
just to enqueue a task and makes sure this is not done unless the
resource is constructed using deprecated interfaces.

JIRA: GENIUS-281
Change-Id: I48691f9d3dbcbf2715f7eddaf775b0e9a37fd7b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

GENIUS-282 Resolving genius yang model errors

Some errors that appeared while testing the Yang models,
https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/distribution-merge-managed-magnesium/657/opendaylight-models/genius/
which is being addressed in this patch

Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
Change-Id: Id0b3f212983876e7908f6b4ee142d91c538d6d59

Revert "Packet duplication due to forwarding from HWvTEP tunnel to ITM"

This reverts commit a1b8a5918a7f9319214d597ffe85e212004ae71c.

Change-Id: I377f5e67a311a18493baa606ff926a05ef3fb6cf
Signed-off-by: Hema Gopalakrishnan <hema.gopalkrishnan@ericsson.com>

Packet duplication due to forwarding from HWvTEP tunnel to ITM

Fix details:
--------------
ELAN_DMAC_TABLE = 51 has been refactored into two
ELAN_LOCAL_DMAC_TABLE = 51 and ELAN_REMOTE_DMAC_TABLE=52

Signed-off-by: Amitesh Soni <amitesh.soni@ericsson.com>
Change-Id: I6ad9d4267ab6b48c28120e7631917ec3038cea9a

Fix odl-genius-api

Multiple things done here:
- use artifacts to import proper upstream versions
- add dependency on odl-openflowplugin-eric-extensions
  to prevent duplicate packaging of Ericsson extensions

Change-Id: I79f51be20559798a0539a65e1cf924bbc32f2278
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix odl-genius

Multiple things done to clean up packaging:
- use properly-imported artifacts poms from upstream to eliminate
  properties
- add proper dependency on odl-serviceutils-listener to eliminate
  duplicate packaging
- eliminate unneeded explicit dependencies, they are pulled in as
  needed
- cloudscaler dependency on javax.annotation is optional, as it is
  not used in Karaf and should not be pulled into the feature

Change-Id: I1313695530bd7354c2e8f75d45ee8f99525fcb05
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to odlparent-6.0.4/yangtools-4.0.6/mdsal-5.0.9

Pick up latest fixes and upgrades.

Change-Id: I8680b14deaec92583bb89a9a10088fc3d34b5b51
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Change the log level to debug

JIRA: NETVIRT-1656

Signed-off-by: Chandra Shekar S <chandra.shekar.s@ericsson.com>
Change-Id: Ic7e501cb82046d2d5077d047ac92956fed66cd17

Remove ARIES-1923 workaround

We now have proper monkey-patch in place and can therefore remove
this workaround.

Change-Id: Ia69518cb72aaa99de9f4eb83c6a295d9715928a0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent/yangtools/mdsal to 6.0.3/4.0.3/5.0.6

Pick up the latest upgrades and fixes.

Change-Id: I127543de2d469e3aa626a427450e1db2a37d0dfb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Expose TypedReadTransaction.exists(InstanceIdentifier)

This operation was not exposed at the binding layer when these
utilities were conceived and thus is lacking here, even when they
are available as part of MDSAL-389.

The MD-SAL version of TypedReadTransaction has been updated back
then, this patch backports these changes to legacy Genius APIs.

Also converts a few callers to use this capability, potentially
improving performance.

JIRA: MDSAL-389
Change-Id: Ieb870a49c8239ee74e697d7d36dea431b24362ae
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 7144e4db6a02daf37f8ba055745a359d0a80c21e)

Optimize String formatting

In some hot paths we end up calling String.format() where a simple
concatenation would suffice. Fix that up.

Change-Id: Ib173fc0599899f40012410b75e243dd3873019a3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove ActionableResource setters

This removes previously-deprecated setters, so that the resource
itself has an immutable surface.

JIRA: GENIUS-281
Change-Id: Ic621cb4afb5567442b29a7c69fdaf0bcb7c5430e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update docs header to Magnesium in the master

Should be Magnesium on master and Sodium on stable/sodium.

Signed-off-by: Anushka Bhandari <anushka16134@iiitd.ac.in>
Change-Id: I6aa4bcd7742ee5efcdf44ad4f1511f952278e196

Cleaning Oper DS during scalein

- to key tunnel remove events on tunnel name
- uses tombstone api

Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
Change-Id: I46470cc20c477c2301e20d2da480a2746d949ee3

Bump to odlparent-6.0.1/yangtools-4.0.2/mdsal-5.0.4

This picks up latest upgrades and fixes.

Change-Id: I8db358b0af81394a561071d98bffea168dda47cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Addessing NPE and UnsupportedOperationException in Genius

Signed-off-by: xcheara <chetan.arakere@altencalsoftlabs.com>
Change-Id: Ie71bd0096968057574a018a04cec0da18b0196c4

Deprecate ActionableResource setters

ActionableResource should not allow modification of parameters
once built. Deprecate setters in the base interface, retaining
them in the implementation.

JIRA: GENIUS-281
Change-Id: Iaf64bb20b67e3d39cfb769bffad0ddbd669cf169
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Downgrate aggregator's javadoc plugin

It seems javadoc-verify/merge jobs are affected by some bug in
maven-javadoc-plugin -- it would filter iana-if-type dependency,
leading to a a failure in javadoc:aggregate.

Change-Id: I8efd03b24cffd509de7f44c9ab1c103c1ee50bad
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump version odlparent->6.0.0,mdsal->5.0.3

This adopts new version of MRI projects and adjusts for the changes
therein. Most notably DPs/DPNs are identified by Uint64, not
BigInteger.

Some drive-by cleanups are performed, mostly to eliminate valid
Eclipse complaints.

Change-Id: Ib73c963d515f55f0865775584de3632e3731820c
Signed-off-by: xcheara <chetan.arakere@altencalsoftlabs.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump mdsal to 4.0.6

This picks up the latest fixes.

Change-Id: I8ec178ca726c1df504efc4f19d2c9c80965d93be
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump yangtools to 3.0.5

This picks up the latest fixes.

Change-Id: Ic37a0d36367f6d89768bec2b92618b4b55aa844f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent to 5.0.2

This bumps odlparent to pick up latest references.

Change-Id: Ica16c98bd6eeeb2530bdc9cee4bb7f198e4a6ab0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix checkstyle

This fixes up violations reported by upgraded checkstyle.

Change-Id: Ic0db886bc974a31692b228667c93375a958c3618
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Retry on DS if read fails

Issue: During the initialization of ID Manager, ID Manager reads
ID pools DS. If this DS read fails, ID Manager does not come up
and other applications dependent on ID Manager do not come up.

Fix: Fix is made to retry on DS until read succeeds.

Change-Id: I627846e1c84f75461f43d9248e98e561b1ffd5bd
Signed-off-by: Amitesh Soni <amitesh.soni@ericsson.com>

Fix minor typo in the csit document

Change-Id: Ic832ecd4c8817d8fd4f810d31183d1f2d574e3af
Signed-off-by: Faseela K <faseela.k@ericsson.com>

GENIUS-202 GENIUS-257 Retry for Unlock() & IdManager calls tryLock()

** LockManager's unlock() method now retries 10 times in case of
exception is thrown. The interval between retries is 1 sec.

** LockManager's lock() method now eternally retries in case of
DataStoreUnavailableException and OptimisticLockFailedException
otherwise it returns FailedRpcResult.

** IdManager no longer calls LockManager's lock() api. It now calls
LockManager's tryLock() api which internally retries for 10 times.
Idmanager returns failure if lock is not acquired after specified lock
attempts. After this change, it is the responsibility of the consumers of
Idmanager to handle these failures.

Change-Id: Ic230e2e4edce4f95ee461ef22ff895368af9663d
Signed-off-by: Ankit Jain <ankit.j.jain@ericsson.com>
Signed-off-by: Amitesh Soni <amitesh.soni@ericsson.com>

GENIUS-171 IdManager's releaseId() returns id being released

The releaseId() RPC now returns the release-id upon successful release
so that applications can use the same for cleaning-up their id which
they might have cached in their states.

Signed-off-by: Amitesh Soni <amitesh.soni@ericsson.com>
Change-Id: I811a2b1b4daf7124162b35c5d88159b6a917f8c2

Adding test classes for scale-in/scale-out functionality

Change-Id: Ie038ca19a4199316b8a5c432e20295cd58e967a1
Signed-off-by: manojna v <manojna.vijayakrishna@ericsson.com>

GENIUS-254 GENIUS-119 GRE and L2GW tunnel missing

There is a race condition between creation of tun port and
bridge ref, port not created. When we are trying to add bridge
to ovsdb from SB, NB is trying to add port for same bridge.
during which NB will check DS for bridge entry,which will be
empty as SB is trying to add it in ovsdb at the same time.
So we are adding eventcallback to synchronize both events.

Change-Id: I7f6c0583d90d5aa91e0ae063123680bdece08998
Signed-off-by: Nidhi <nidhi.adhvaryu@ericsson.com>

GENIUS-251 Documentation for genius event logging using log4j2

Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
Change-Id: I5b7ed401482dfda550b450d9beb1e425292e7923

"Adding scale-in/scale-out functionality""

This patch has to go in along with the corresponding netvirt patch.
Else genius merge jobs will start failing

Change-Id: I654fbdf30a7e1b5565d238878a5eca7a96960de9
Signed-off-by: Faseela K <faseela.k@ericsson.com>

NETVIRT-1586

OVS Based NA Responder for IPv6 default Gateway

Change-Id: Idd52407babc7bbd9bc45da1910cb0767c4511af3
Signed-off-by: nithi thomas <nithi.t@altencalsoftlabs.com>

Grep not working for Karaf commands

This cover changes for idmanager.
The fix is to replace Session.getConsole() with System.print().

Change-Id: Ic85a495ae5386b996942b47c7a6b75f281dd3f3c
Signed-off-by: Manu B <amitesh.soni@ericsson.com>

Bump mdsal to 4.0.4

This brings in latest fixes.

Change-Id: I59f89ef4fe76ef16fcdc9b59f8d9b50aa0849847
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions by x.y.(z+1)

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I04a508da4a70d18d5b297b98fbedfed89e0df6d5

GENIUS-251: Event Logger for Genius

Separate Logger to capture events for debugging.

Change-Id: I2410d8b336ab83ba2ec186ebcdbfb77e915dbf1b
Signed-off-by: Nidhi <nidhi.adhvaryu@ericsson.com>

ITM recovery is not working

Tunnels were not getting recovered and what we found is
Itm Direct Tunnel support was missing for tep and
transportzone recovery. So this patch is adding that.

Change-Id: Ie0c4df35065384e26dce9d271d229868daa4c8ce
Signed-off-by: Nidhi <nidhi.adhvaryu@ericsson.com>

Selective BFD: Fix to enable BFD on both
Source and Destination DPN.

Change-Id: I18ac0ae566c89b9e5f7055d30a36e440abacba31
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>

Enable interface-manager-stats polling by default

Currently a flag in genius-ifm-config.xlm which controls
the Performance counter is disabled by default.
Making this flag enable by default will make these
counters available to be queried using mbean by default.
As the polling interval is 15 mintues, it should not hurt performance.

Change-Id: I4d904dcacbc13e42e695a1f9d37f20a61cf6eafa
Signed-off-by: Naveen Kumar Verma <naveen.kumar.verma@ericsson.com>

VNF BFD packets are dropped by OVS when Tunnel monitoring
BFD is turned ON.
Adding BFD MAC filter on tunnels to fix this issue.

Change-Id: I5bbb13ac3aae82bffbebdef7e373a10fea9418bc
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>

Bump mdsal to 4.0.3

This bumps mdsal to 4.0.3, bringing in latest fixes and improvements.

Change-Id: Ie8e03aab1f31edf80bc9f1d7896c334c9d83be8d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump yangtools to 3.0.4

This picks up latest fixes and improvements.

Change-Id: I03201927d23762acf641c1ab0ff3419ba8b94969
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent to 5.0.1

This picks up the latest upgrades.

Change-Id: If6006a94197839a9718cd5eae16b0a025913af93
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Issue:  uuid was not coming from interface manager as portNameCache
which pmcounters where using was not getting update.

Solution: EOS of INTERFACE_CONFIG was preventing the
cache to be modified on other Cics. Now adding and removing entries into
portNameCache as moved before the EOS check.

Change-Id: Ia64d56e5dd59ef4044617b77139c35a1ee2a77ea
Signed-off-by: Naveen Kumar Verma <naveen.kumar.verma@ericsson.com>

Revert "Adding scale-in/scale-out functionality"

This reverts commit 1e7bda5287304ba3a5dde948b5fe38124b56349b.

Change-Id: I6d5c7df57439bacf80f4c540c34dcdd75acdfa1b
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Handle Node Repair in IFM

Handle Node Repair in IFM, check for UNKNOWN state.

Change-Id: I48a0e66d396b9072e897f96a71108fc1d4ea8fc6
Signed-off-by: Nobin Mathew <nobin.mathew@ericsson.com>

Adding scale-in/scale-out functionality

Change-Id: Ic28ed5c32a3d26cfc608cd9c0ad87e37ad1b552a
Signed-off-by: manojna v <manojna.vijayakrishna@ericsson.com>

GENIUS-266: Deletion of OF-Port along with status
- takes care of deleting of-Port
- takes case of deleting tunnels to and from this port
- takes care of deleting ingress and egress flows

Change-Id: I8d42b02134d163e5ebf6b18aa7734cc65237ab33
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>

JIRA: GENIUS-271-ITM Tunnel state operational DS population
The changes are made to populate the tunnel states for OF tunnels

Change-Id: If77d0311bccc8fb67720d927344adb5c05cdac63
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>

Fix for NPE in ArpUtil

Change-Id: I9411a1576cf2d74950b685a6bd2d10e5bb3ea0ab
Signed-off-by: Nidhi <nidhi.adhvaryu@ericsson.com>

Fixing NullPointerException.
ITM was not processing the parked NC event due to a wrong lookup.
As a result all the parked NC events were lost.

Change-Id: Ie6ca0a603c83de778c6741abdeefe3b345a48555
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>

Remove JSR305 dependencies

JSR305 is not used anywhere, remove it from dependencies.

Change-Id: Ia8129823dc2ac78d967ca23a2502e799d5148d31
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove DataStoreCache

Caches based on this class have been eradicated, with the only
user being CLI trying to find it. Remove the class and references
to it.

Change-Id: I9e4848ae9e491d04d9a2fa771fc8cdf5b3545e2f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Skipping tunnel ports when colleting port stats...

Incomplete statistics comes for Tunnel ports from ovs:

 "bytes_received": "-1",
 "bytes_sent": "-1",
 "duration": "65373",
 "packets_received": "-1",
 "packets_received_drop": "-1",
 "packets_received_error": "-1",
 "packets_received_on_tunnel": "0",
 "packets_sent": "-1",
 "packets_sent_on_tunnel": "0",
 "port_id": "23",
 "tenant_id": "3ecca858-98cd-4923-9011-e8c750f7b9a8",
 "uuid": "9e94558d-9dbf-4a82-88df-b99d8fe056fa"

Change-Id: I116020f735bc341864b3fd80ee6d866deac155f8
Signed-off-by: Naveen Kumar Verma <naveen.kumar.verma@ericsson.com>

Move Pm Counter processing to new thread

Porcessing of RPC response has been moved to a newer thread.

Change-Id: I2fcf385847924f164d6799d59ea390b2acdcd059
Signed-off-by: Naveen Kumar Verma <naveen.kumar.verma@ericsson.com>

Issue: Table-0 to Table-36 flow was missing
As part of ITM Yang Models Cleanup, internal flag was removed which
caused the issue. The internal flag is brought back to fix the issue.

Change-Id: Ia069fc52ecbd3223fa7ca7c4713ffb475fb3a353
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>

Make Batching size and interval as configurable parameters
in ITM

Define batch size and interval in itm-config.yang and use that instead
of using it from system.properties(),so it can be configured if needed.

Change-Id: I6f292bad3323fd4b5cd1d1be6cb6e575e41c3c1a
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>

Id allocation failing

Issue
=====
While reading data store if data is not present in the DS,
"ExpectedDataObjectNotFoundException" exception is thrown.
Since this exception is not handled, ID allocation is failing.

Fix
====
Added try-catch block to handle the "ReadFailedException" exception
so that the code execution does not stop if read fails.

https://gerrit.ericsson.se/#/c/4354671/

Change-Id: I00423597e1681085b1fbcd187e11e5f2dd7582cd
Signed-off-by: Amitesh Soni <amitesh.soni@ericsson.com>

TSC-181: ITM Yang Models Cleanup

Merge issues are fixed now, hence restoring the actual change

Change-Id: Ie774a5a2c09f901cd4ff58c732acf73effc36827
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Ignore flaky ITM test

Signed-off-by: Faseela K <faseela.k@ericsson.com>
Change-Id: I51654fa1b348308215e3c47692729c15fd5caac3

Revert "TSC-181: ITM Yang Models Cleanup"

This reverts commit f32af7aad9875d8aa281ff711f86945c18685318.

Change-Id: I89c0ea7a8b8b5e365d540a8d1987f3a0b191eb76
Signed-off-by: Faseela K <faseela.k@ericsson.com>

TSC-181: ITM Yang Models Cleanup

Change-Id: I2d4e79e78c562572d9d91598b489f563eb1f6484
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>

Adding compute node scale-in scale-out spec

Change-Id: I00058d5eeac8256e79dcce9a5b2c4502cec826cd
Signed-off-by: manojna v <manojna.vijayakrishna@ericsson.com>

Remove use of powermock from mdsalutil-impl

powermock is not really used in these tests, remove it, allowing
us to simply upgrade mockito.

Change-Id: I26eca39285e2bcca7193c837e69c347c4b5cc878
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate to use LoggingFutures

JdkFutures are not taking advantage of various known implementations,
which LoggingFutures does. This migrates code to use new equivalent
method.

Change-Id: Ifd8ae59f82cdb2eb8ea70783bc81288139e5c3d5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make private MDSALManager methods static

These methods are not touching any state, incurring Eclipse warnings.
Fix those warnings by making the methods static.

Change-Id: I0649ee508fffe6d2b83ea55710e405635921812c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove powermock version overrides

odlparent is providing version 2.0.0, hence there is no point
in us overriding versions (and specifying some artifacts).

Change-Id: Ia006b48a772a98ae9cc8e6fb7abc00dccaba0295
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Declare api artifacts in genius-artifacts

This reduces the number of project.version declarations throughout
the project, improving consistency.

Change-Id: Id039b72d27da6d07315cc83d9d3da5d4e1abb6b5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Import genius-artifacts from binding-parent

This removes duplicate imports and allows us to share versions
at a later point.

Change-Id: Ibd8d2f717975affeb61d51116a1d67c5255d49e7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Import openflowplugin-artifacts in binding-parent

This reduces the need for duplicate imports and version tracking
in projects that are based on binding-parent.

Change-Id: Iec6b7d2be820a908051fe1759bfc134a6d744f73
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Import infrautils-artifacts in binding-parent

This is done at least in two places, with a myriad of other
places using the property instead of relying on upstream to declare
the correct version.

This patch fixes the layout up so we only only export the property
to one user, which unfortunately is not declared by upstream.

Change-Id: I589f239d932518a5275bd5e5998a1a599ef33caf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate from tools-api to rpc-api

This migrates users of FutureRpcResults to the non-deprecated
version. Also import serviceutils artifacts from binding-parent.

Change-Id: I52661ad4b116be525234a18022ad4c48c8511a2c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove controller.mdsal.version

This property is only used for imports, remove it in favor of
inlining the version into import.

Change-Id: If2405635464d530e52f5108f975d14f9659b6226
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unused declarations

junit/mockito-core are always a test dependency, hence these
declarations are not needed.

Change-Id: I744bd0b9bd58a29de0245bb2ee2e781163bbbced
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unused properties

These properties are not consumed anywhere, remove them.

Change-Id: I144f271ab05ca6f663e1d9f8ce94c861e08e8df5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove use of FluentFutures2.toChecked()

This method has been deprecated, remove its only in-tree user.

Change-Id: I71c3e14e3ad98db06c11f6dda56803b8951c5c50
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Spec for ITM Yang models cleanup
1. Added specification document for ITM Yang Models cleanup
2. Linked spec to specs/index

Change-Id: I1217ae59584775a44cbe3b266ba3cbcded7f0b01
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>

Fix syncronization issue in table 220 flows

Change-Id: Id7c6a1f967c561a969b47b59ad93134d622028a6
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>

To address sporadic failures

- addresses failures seen in autoRelease
- clean up of explicit sleeps in the Junit
- replaced sleep with awaitsEventConsumption:q

Change-Id: I97fa44da04d38afe67aa9d4adc8b7314078ebb4d
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

Tunnel mesh was not fully created.

There is a timing issue between SB and NB event while
creating bridge. When we are trying to add bridge to
ovsdb from SB, NB is trying to add port for same bridge.
during which NB will check DS/cache for bridge entry,
which will be empty as SB is trying to add it in ovsdb
at the same time. So we are adding eventcallback to
synchronize both events.

Change-Id: I7c33f41591de27972742df14ae913daae7f6889f
Signed-off-by: Nidhi <nidhi.adhvaryu@ericsson.com>

Migrate to NamedLocks

KeyedLocks have been deprecated, have an very bad API and do not
quite work as advertized.

Migrate to NamedLocks, which have a safe and easy-to-use API while
providing improved performance. While doing that, change
DirectTunnelUtils to not leak the entire structure, but only provide
a lockTunnel() method.

Change-Id: I8c099e491189c49015ee2939a3ea20f2c0f8c8c5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

In ITM Scale-In-Out when same IP is used, some stale
tunnels hanging in new mesh creation.

When computes were scaled-in and scaled-out with the same vtep ip, ITM
full mesh was not created.During scale-in, ITM caches were notcompletely
cleaned up resulting in stale DPN in ITM. This prevented the full mesh
creation.This patch add solution to this problem.

Change-Id: If712ca51893f56e6d0efd260260387242fab667a
Signed-off-by: Nidhi <nidhi.adhvaryu@ericsson.com>

Bump mdsal to 4.0.2

This picks up latest improvements.

Change-Id: I923294ebdac1dc69e8253096f4199b0630b30356
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump yangtools to 3.0.1

This picks up latest fixes.

Change-Id: I0b14617c404a45f59d48eaa2fc58c37b7d265eac
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Heavy service-binding READs in scale

A code refactoring post Boron has duplicated serviceInfo read
in two places, on an interface-state addition. Removing this
duplicate read.

Change-Id: Ia173452c200bbcac33728f51b7766ebf0ca17496
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Bump mdsal to 4.0.1

This bumps mdsal to 4.0.1.

Change-Id: Ia57117a74f1b97030b6879f422867f2adc8ce717
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Queueing iface remove on its name

- to handle interface remove in DJC on interface name
  for both vlanInterfaces and tunnels

Change-Id: I4ecb07b76b607650893a5581a2dd7b128190b699
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

GENIUS-145: Creation of OFPort on ITM Direct Tunnels.

Change-Id: Ic6d229f22eb540b4859d61450b5b3f53cee9faaa
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>

Fix wrong condition statement in update method

In update method in TunnelInventoryStateListener.java,
the below condition is wrong obviously.

if (DirectTunnelUtils.TUNNEL_PORT_PREDICATE.test(portName)) {
    LOG.debug("Node Connector Update - {} Interface is not ...
    return;
}

JIRA: GENIUS-275

Change-Id: I0b03d7357edb37baf0f535d06dd3a72952b387f5
Signed-off-by: Yi Yang <yangyi01@inspur.com>

Update Pipeline diagram for Egress Tunnel Table

JIRA: GENIUS-161

Change-Id: Id9e5a3aa1266eb9e54252aab12940533f74491a8
Signed-off-by: Faseela K <faseela.k@ericsson.com>