Remove use of Optional from DeviceInitializationUtil

The use here is completely unneeded -- we can serve the same thing
with checks for null.

Change-Id: Ic5958cd97f91676a2ab6b34c9f049a7f73eaa1d5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Reduce use of Optional in ContextChainHolderImpl

Optional.ofNullable().ifPresent() can easily be replaced with
a null check, making code clearer. We also end up rewrapping
ownership state -- just drop to using nullable, as that makes
the corresponding check easier.

Change-Id: I74efb538cdf3cf66350a8bcb23d0207070864dc2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup MultipartReplyTranslatorUtil

Rather than using Optional.flatMap(), which seems to be an all-time
favorite switch to using null checks and explicit returns. While we
are here, also make sure we use Builders' fluent capacity.

Change-Id: Ib27cbc4e290620ddb53139349079f0349f84e0ff
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup MatchUtil

Switch MatchUtil.resolveExtensions() to return a map, removing
a source of needless copying.

Change-Id: I3343be5cb848774d7047ad27c2ec96a24e343aa8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup AbstractActionInstructionSerializer

Do not use Optional.ofNullable() for null checks, leading to cleaner
and meaner code.

Change-Id: I302bccbadbaeb6633c8f12afdea6ffe3a751826c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup ConfigurationServiceFactoryOsgiImpl

Do not use Optional.ofNullable() for null checks and also properly
unget service after use.

Change-Id: I0360904dcec7ee25d6702a943f2d6782540a79c0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup TableFeaturesMatchFieldDeserializer

Remove overzealous use of optionals to make the logic cleaner
and more performant.

Change-Id: I8305b49877e309971222954f8a0a5e8cce9b8f59
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup MatchSerializer

Remove use of Optional.ofNullable() as a null guard, improving
overall performance and readability.

Change-Id: I028537276720697b7109c92096719a55df53e6a8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup ExtensionSessionManagerImpl

Use a properly-constant singleton and remove unused logger.

Change-Id: I0ed7bc521aaa121a13f07ad8f72b37e00d2b522a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup MultipartRequestExperimenterSerializer

Split fallback serialization into its own method and remove use
of Optional.ofNullable().ifPresent() in favor of null checks.

Change-Id: Ic4581efbc383de4b2c6028c6be654280fae0605d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge changes Ia53720b0,I9f54d265

* changes:
  Cleanup GroupMessageSerializer
  Cleanup MultipartRequestTableFeaturesSerializer

Cleanup GroupMessageSerializer

Do not use Optional for logic decisions, making translation clearer
and more performant.

Change-Id: Ia53720b0b18753e77de5f74614bb5a7ea775fd42
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup MultipartRequestTableFeaturesSerializer

Remove use of Optional for logic decisions. Also do not convert
string to bytes twice.

Change-Id: I9f54d2653fbbb86525c6dfd1cbbaf76d187d573e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up ListeningExecutorService usage

It turns out we do not really need ListeningExecutorService at all,
but can live with a normal ExecutorService. Furthermore most contexts
where we used ExecutorService can completely get by through a simple
Executor, which makes lifecycle more predictable.

Change-Id: Ic1b2a3d49433557d0c5934445a79e06391d24fe8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup FlowMessageSerializer

Further reduce use of Optional.ofNullable().map() crud and also
reduce Guava use as per modernizer warnings.

Change-Id: Ic060c95941b9ac0f1b40b1350dce50c004e0fd0e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Optimize SetAsyncInputMessageFactory

This class is very similar to GetAsyncReplyMessageFactory, apply
same optimizations.

Change-Id: Iaeacd426fb99aaf1ce527d53bcb935aaf0551fcd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Optimize AsyncConfigMessageSerializer

Do not use optionals to dispatch on nullable properties. Also do not
create a Map for bitmap conversion.

Change-Id: I4205d127c2e78e67671d8a599b065f9afe7c6f2a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate a few convertors

Be a bit smarter about dealing with units, fixing related warnings.

JIRA: OPNFLWPLUG-1099
Change-Id: I9ab33dc6634f37bb38735d948741424c9c2fa07f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Optimize GetAsyncReplyMessageFactory bitmasks

Do not instantiate a HashMap just to store offsets we have readily
available. Use direct bitmask construction instead, speedings things
up quite a bit.

Since we are doing the same thing for three difference enumerations,
introduce a common methods to do the heavy lifting.

Change-Id: I2999b00df64f596f3d025d9e83c5e3dcca376d90
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove a reference to org.mockito.Matchers

These methods are deprecated, migrate to ArgumentMatchers. Also
remove a few unused constants.

Change-Id: Ida46bc436184374a851a5a4eee7ad034e80b02bb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate .setXid() callers

Use ByteBufUtils to readUint32() instead. While we are at it, apply
the same pattern to other methods as well.

JIRA: OPNFLWPLG-1099
Change-Id: Ifcd4beab39ed00e93db3b4b062a56a0d8bad6b35
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate EncodeConstants.OF13_VERSION_ID users

This is a search-and-replace for the correct constant.

JIRA: OPNFLWPLUG-1099
Change-Id: Ia912773d9fb299922fd1a68158e4f275b16682be
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix ServiceException

We do not have an UUID here, fix that. Since this has been out there
for some time, start with a generated UUID.

Change-Id: I9322717e5cd1f845275aa56cb756139a7304d3fb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup FlowMessageSerializer.isSetVlanIdActionCasePresent()

Rather than bouncing through Optional.ofNullable(), use an explicit
null check to significantly simplify this method.

Change-Id: I59237a4ccef3c407c033d3e1588b7958840d9c06
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup FlowMessageSerializer.isVlanMatchPresent()

Rather than doing silly ofNullable()/flatMap() things, just perform
two non-null checks -- making things much simpler to see.

Change-Id: I7be0f55e58427e29b9310c55989faf126b3bb7cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate OpenflowPluginBulkTransactionProvider

Use BindingMap to eliminate deprecation warnings and also clean up
builder use.

Change-Id: I3dc94c38c48eaeff9727da5048fe907acf522846
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Final round of isFoo() migration

Finish up remaining components, so that we do not use isFoo()
anywhere.

Change-Id: I4da07dd94b689176ecc07ffb64ecfc36890e73b0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Optimize LLDPUtil.colonize()

We are performing a regex-based replacement here, pre-compile the
Pattern so we get faster replacements.

Change-Id: Ib1b09e3fbb5975ad18dd6f41e45022661bb1e220
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Further warning removal

Migrate further call sites of isFoo(), as well as various other
deprecated constructs.

Change-Id: If840e14f523eaafc596ef1a6ccd5354e19cb826f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Un-deprecate OpenflowVersion

Our API vs. annotations do not agree on deprecation here. Let's
drop the JavaDoc and replace it with a FIXME.

A follow-up patch will address the enum's future and introduce
a proper @Deprecated once we have reigned-in our current warnings.

Change-Id: Iae325d1cf167890f299e0b31faef235b8ee4a3d4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate openflow-protocol-impl isFoo() users

Mass-migrate boolean getter users, which have changed from isFoo()
to getFoo().

Change-Id: I931fb7542a88870d017bb8ad8bc23568e73a9df0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump MRI upstreams

Adopt following versions:
- odlparent-8.0.2
- infrautils-1.9.3
- yangtools-6.0.2
- mdsal-7.0.3
- controller-3.0.3

Change-Id: I5731acb571b168f984e740441914c7867bd9b4ea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update active committers info

Change-Id: I5e85ffdf12e629000901fca57eb4a38ca4582f76
Signed-off-by: Gobinath <gobinath@ericsson.com>

Bump infrautils to 1.9.1

Pick up mbean fixes from upstream.

Change-Id: I77f72e799f91e8214506d27ea4e02eb11986fb27
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to mdsal-7.0.1/controller-3.0.1

Pick up mdsal fixes and improvements.

Change-Id: I6a4797e108a63abf08a20cd63a0e56dfdc80380c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams for Silicon

Adopt the following upstream versions:
- odlparent-8.0.0
- yangtools-6.0.0
- mdsal-7.0.0
- controller-3.0.0
- infrautils-1.9.0

Since we are forced to migrate some of the code, perform related
migrations if they are trivial to do.

Quite a few tests are missing proper keys and properties, hence
these are added in the most obvious manner possible. If there is
a list/map warning in that vicinity, also use BindingMap.of() to get
rid of the warning.

Also a few obvious modernizer warnings are fixed, as it's easier
than add suppressions.

Change-Id: Ic4302fba6916dca8385633f1889e8e619fc281e4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove ByteBufUtils.readIpv4Address()

This method is not used anywhere and has a replacement in
readIetfIpv4Address(). Remove it.

Change-Id: Ia18f54b36e4974108cc65bf61207d320b4e7a134
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove ByteBufUtils.readIpv6Address()

This method is not used anywhere, with readIetfIpv6Address() being
its replacement. Remove it along with
EncodeConstants.SIZE_OF_IPV6_ADDRESS_IN_BYTES.

Change-Id: Icc33beb47c4212f3fc187a39fc84cea74931c2dd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove ByteBufUtil.macAddressToString()

All users have been migrated, remove this method along with its
test.

Change-Id: Ic8f213320a3df34f2a28c456ac686a4b47e61901
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate ByteBufUtil.macAddressToString() users

We have users only in tests, perform the straightforward migration.

While we are at it, we also fix expected/actual order in tests, as
well as eliminate call sites which are better served by
Assert.assertArrayEquals().

A few places are asserting the use of upper-case letters, which runs
contrary to what the canonical format is. These are adjusted to use
canonical lower-case.

Change-Id: I4dfc342b005d1cbdec2537eb4cfdac20d6521da2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Deprecate ByteBufUtil.macAddressToString()

All callers of this method are actually interfacing with
ietf-yang-types' MacAddress. IetfYangUtil provides a better alternative,
as it foregoes String checking performed by MacAddress(String).

Change-Id: Ib54218eb74936bd7c5550322829f5fa809cd3c33
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove ByteBufUtils.macAddressToBytes()

With all callers migrated, remove the now-unused method.

Change-Id: I65412717a28c393d3e31d2cda19d8becb3278dd7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Deprecate ByteBufUtils.macAddressToBytes()

This method operates on any string, whereas all its users are faced
with an ietf-yang-types' MacAddress. IetfYangUtil.macAddressBytes()
provides a superior alternative to this open-coded utility.

Change-Id: Id4f7448a0894a4cec5e76ec801cfde47b03e3be7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use Short.BYTES

We have a few places where we a using Short.SIZE / Byte.SIZE. This
is already a constant known as Short.BYTES.

Change-Id: I51bbc7028131948d615ef2f21e9301ba1cff0fc6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix switch serial number type

This is a day-0 bug in the definition: X509Certificate's serial
number can be any unbounded number, not just uint64.

Change the definition to be string-based so we do not get errors
if the serial number is negative or quite large.

Change-Id: I41292cc329c4eac81a7c671821e29b6851030056
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix openflow-protocol-impl deprecation warnings

Convert all use of widened types to proper uint types.

JIRA: OPNFLWPLUG-1099
Change-Id: Iabdcf752965851b29be0162c70f463206d07abaa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do no subclass HashMap

Eclipse is correctly pointing out we are creating a serializable
subclass without assigning a version to it. Rather than doing that,
use a simple initializer through an intermediate map.

Change-Id: I83d5a05c138bf7ee664612daf81f721fe30435f7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate test-extension to use uint types

This is a straightforward replacement with Uint64.

JIRA: OPNFLWPLUG-1099
Change-Id: I2cc7607ec96c31566d2fbadb4bbab7cb54ed32e7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate frm-sync to use uint types

This is a simple matter of encapsulating values, make sure we do
that.

JIRA: OPNFLWPLUG-1099
Change-Id: I12f5c63b9a9935a993b52a7ce90f5ae91a55edc4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make methods static

Eclipse is pointing out a number of methods which can be made static,
fix those warnings.

Change-Id: I4691094f1e5ee098cca5d377a92a3417d667de7e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate southbound-cli to use uint types

We have some technical debt here, fix it up.

JIRA: OPNFLWPLUG-1099
Change-Id: I7c777dec680234b9c3a9978175e007b2d39c6d59
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use deprecated Mockito constructs

Mockito has moved some functionality around, adjust to that.

Change-Id: I965d6ba5fd29e95060e9bfd6286fdad40d3a99df
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Finish test code migration to uint

Fix up the few remaining users of widened types, preparing the floor
for migration of production code.

JIRA: OPNFLWPLUG-1099
Change-Id: I6a2ed96d2859244debd63aa41a16db5c8dc7f7f5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate openflowplugim-impl tests to uint types

This migrates the entire openflowplugin-impl test suite to use
Uint types.

We borrow EncodeConstants to get at Uint8-specified
protocol numbers, which is probably not what we want, but then
there seems to be variance of opinion whether to use that or
OFConstants. This is fine for this migration, we will address
the OFConstants/EncodeConstants duplicity when we migrate
production code.

JIRA: OPNFLWPLUG-1099
Change-Id: I088597573037b8a662840aff62b0593a058a10b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate openflow-protocol-impl tests to Uint types

There are plenty of warnings in the test suite, address all of them
without touching production code.

JIRA: OPNFLWPLUG-1099
Change-Id: I8ec19c008ef51dfdabeded610bef4bda4e11d8f0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove ByteBufUtils.padBuffer()

This method has been deprecated for at least three years and is not
used anywhere, remove it.

Change-Id: Ied94f803d3a2025542a07ef1e6e9320fd9a7af4a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix migration warnings in openflowjava-util

We have some use of legacy widened types, fix them up.

JIRA: OPNFLWPLUG-1099
Change-Id: I1266a79d5957f4ae1009258593447f0cadfff40c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove deprecated ActionSerializerKey constructor

Legacy widened-type constructor is not used anywhere, remove it.

Change-Id: Ib1b4225657c5bba3455e2b7edbf53a659b02ce40
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove deprecated ExperimenterActionSerializerKey constructor

This constructor is using widened Long argument and is not used
anywhere, remove it.

Change-Id: I41ef92b1957657c50d1bb5be7a0ca985851b5bf0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Refactor AbstractOxmMatchEntryDeserializer"

Merge "AbstractOxmMatchEntryDeserializer should be an OFDeserializer"

Bump MRI projects

This patch adopts:
- odlparent-7.0.6
- infrautils-1.8.1
- yangtools-5.0.6
- mdsal-6.0.5
- controller-2.0.4

Change-Id: I56ec950e030e1cb67bb697df85703c8d76dfa95a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor AbstractOxmMatchEntryDeserializer

All subclassses of AbstractOxmMatchEntryDeserializer follow the same
deserializer pattern. Make sure we eliminate useless getters and
streamline the implementation accordingly.

JIRA: OPNFLWPLUG-1102
Change-Id: I2417ce9f58f7f97acfab91a93d4c346ece3b1208
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

AbstractOxmMatchEntryDeserializer should be an OFDeserializer

All subclasses already also implement OFDeserializer, centralize
that connection.

JIRA: OPNFLWPLUG-1102
Change-Id: I4105e6b71937f43bd649c26aaf4d2cb7f476590e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make VersionAssignableFactory implement OFDeserializer

All subclasses are implementing OFSerializer, hence it makes sense
to encode this in the base class. This ends up sharing the offset
of the implementation.

JIRA: OPNFLWPLUG-1102
Change-Id: I53342f0f0ec5ffe37440ee29f6e06c20be5add5d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix warnings around SimpleRpcListener

SimpleRpcListener has generic arguments, fix warnings pointing out
unparameterized use.

Change-Id: Ia0a4bd398eddb81bfac1e6459249be685e95d931
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove an unneeded cast

We have a superfluous cast, remove it.

Change-Id: Id325d5b4c1593241a156e6f4560c10ae0bfc6501
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Eliminate AbstractEmptyActionDeserializer subclasses

Method dispatch works on particular class implementation and
individual per-type subclasses are not bringing anything to the
table.

Change AbstractEmptyActionDeserializer to a final
EmptyActionDeserializer and use its instances to perform duties
previously held by its subclasses.

JIRA: OPNFLWPLUG-1102
Change-Id: I3e1e03a498a15808cf2538fcca651c6c258e07f5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use ActionContstants in ActionDeserializerInitializer

Rather than using a plain constants, use symbolic names so that we
can neatly cross-reference users.

JIRA: OPNFLWPLUG-1102
Change-Id: I106798adbf77f7e9a9e917b72707ae76b49bae94
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Eliminate AbstractEmptyActionSerializer subclasses"

Merge "Add AbstractEmptyActionSerializer"

Merge "Make AbstractActionSerializer.serialize() final"

Merge "Refactor AbstractActionSerializer"

Merge "Refactor AbstractInstructionSerializer"

Eliminate AbstractEmptyActionSerializer subclasses

Method dispatch works on particular class implementation and
individual per-type subclasses are not bringing anything to the
table.

Change AbstractEmptyActionSerializer to a final
EmptyActionSerializer and use its instances to perform duties
previously held by its subclasses.

In order to aid debugging, we customize its toString() to list
the code being handled.

JIRA: OPNFLWPLUG-1102
Change-Id: Icf7176a62bde41d036c9251ed6e347a85aaa35ce
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add AbstractEmptyActionSerializer

Similar to AbstractEmptyActionDeserializer, we can centralize
common body reads in a single class, eliminating duplicate code.

JIRA: OPNFLWPLUG-1102
Change-Id: I91e02ac81d7f631bc7237e4ea770fad40ca5eb0d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make AbstractActionSerializer.serialize() final

We want to reduce the number of megamorphic calls in the serialization
path. Rather than overriding the serialize() method in abstract base
class and call into it, make sure the base class calls out to subclasses
to serialize the body.

This reduces the number of serialize() implementations, peeling common
code into the caller. It also makes it clear there are opportunities
to further reduction.

JIRA: OPNFLWPLUG-1102
Change-Id: I0cb421be9f84fd278039a07107254bfac9ddd9a2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor AbstractActionSerializer

Current structure is causing multiple megamorphic invocations in
the serialization paths. This first step eliminates
getType()/getLength() methods, storing their values in the object
instead.

JIRA: OPNFLWPLUG-1102
Change-Id: Ie806a6a4a011b9235c9b47005927cfc5704f018b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor AbstractInstructionSerializer

AbstractInstructionSerializer can be made more efficient with
inlining types -- which means we will issue a simple read/load
instead of having to go through virtual dispatch.

JIRA: OPNFLWPLUG-1102
Change-Id: I8c325718715a928a1b24fc75a6de11a6b80eada1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump conf.yaml versions to Silicon

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: Ic81fabcf98bf798b92dc08f5d77dc72486f2c549

OPNFLWPLUG-1105 : Fix for get-active bundle DOMRpcImplementationNotAvailableException

description: GetActive Bundles failed  with "No implementation of RPC AbsoluteSchemaPath" exception even after the path registered successfully.
              Issue Observered when multiple Switches connected to controller, and some of them were restarted.
  During restart previous bundle rpc registrations are overwritten.
  Fix done as registrations are stored and retrieved using map.

Signed-off-by: Dheenadayalan.b <dhinua@gmail.com>
Change-Id: I4de90445db2f5b29e4fefb2d5bd296cdcd73af8a
Signed-off-by: Dheenadayalan.b <dhinua@gmail.com>

Merge "Refactor AbstractActionDeserializer"

OPNFLWPLUG-1089 : Enable matching of a range of tcp/udp-source/destination-ports per flow

Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>
Change-Id: I047fd49aa60f0a9e951eef9f55b0104931a15679
Signed-off-by: Dheenadayalan.b <dhinua@gmail.com>

Refactor AbstractActionDeserializer

Looking at AbstractActionDeserializer, we can increase performance
of parseHeader() by eagerly instantiating choice/header objects.

JIRA: OPNFLWPLUG-1102
Change-Id: Ia71bb2d865eaf83627945b1a7039a0978b76be80
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove EncodeConstants.SIZE_OF_{BYTE,SHORT,INT,LONG}_IN_BYTES

These constants are exposed since Java 8 as
{Byte,Short,Integer,Long}.BYTES use them from there instead of
brewing our own.

Change-Id: I3a47659f136165d54f3f97315b0911cc7feaec6b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Remove OFConstants.SIZE_OF_LONG_IN_BYTES"

Merge "Change OFConstants.OFPCML_NO_BUFFER to Uint16"

Merge "Fix a modernizer warning"

Merge "Migrate most of openflowplugin to use Uint types"

Merge "Migrate openflowplugin tests to use Uint types"

Merge "Fix a raw type warning"

Merge "Fix javadoc reference"

Merge "openflow devices are getting disconnected from Controller, sending OFPBFC_BAD_ID error reply"

Merge "Fix uint warnings in sample-bundles"

Merge "Fix for openflow devices not connecting to controller"

Merge "Fix deprecation warnings in learning-switch"

Merge "Do not parse string multiple times"

Merge "Remove unneeded boxing"

Merge "Mark static methods"

Fix for openflow devices not connecting to controller

Signed-off-by: dheenadayalan b <dhinua@gmail.com>
Change-Id: I641997a74f5b5081366fcaa1fe9a56b6d1c67f5d
Signed-off-by: Dheenadayalan.b <dhinua@gmail.com>