To fix bfd status related issue
seen on ovs restart in tdd-wip

Change-Id: Iaaf997db33109941409b7da3ac405be3cdf98a8f
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

Stop git from thinking logo.png has changed

something in our build systems thinks there is something
different about line endings now that the logo.png
file has been put in the genius repo. Removing eol=lf
should prevent that. I'm not totally understanding
what is happening, as this is not a problem on a local
linux system, and our build systems are centos7 so I
would expect the problem to be in both places.

some extra reading here:
https://help.github.com/articles/dealing-with-line-endings/

Change-Id: I4809c34cb04e63563f314bdc7086f0a76955c470
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
(cherry picked from commit 66dbc7e8f524e03be17438b7bfa483615dfd7b48)

OVS Port Delete not going through

JIRA: GENIUS-133

Deletion of OVS port is resulting in the below error:

mainWorker=InterfaceStateRemoveWorker{nodeConnectorIdNew=Uri{_value=openflow:68797520762178:2},
nodeConnectorIdOld=Uri{_value=openflow:68797520762178:2}, fcNodeConnectorOld=FlowCapableNodeConnector{
getAdvertisedFeatures=PortFeatures{_tenMbHd=false, _tenMbFd=false, _hundredMbHd=false, _hundredMbFd=false,
_oneGbHd=false, _oneGbFd=false, _tenGbFd=false, _fortyGbFd=false, _hundredGbFd=false, _oneTbFd=false, _other=false,
_copper=false, _fiber=false, _autoeng=false, _pause=false, _pauseAsym=false}, getConfiguration=PortConfig{_pORTDOWN=false,
_nORECV=false, _nOFWD=false, _nOPACKETIN=false}, getCurrentFeature=PortFeatures{_tenMbHd=false, _tenMbFd=false,
_hundredMbHd=false, _hundredMbFd=false, _oneGbHd=false, _oneGbFd=false, _tenGbFd=false, _fortyGbFd=false,
_hundredGbFd=false, _oneTbFd=false, _other=false, _copper=false, _fiber=false, _autoeng=false, _pause=false,
_pauseAsym=false}, getCurrentSpeed=0, getHardwareAddress=MacAddress{_value=9a:be:c5:8b:90:d2}, getMaximumSpeed=0,
getName=tun704bde687e8, getPeerFeatures=PortFeatures{_tenMbHd=false, _tenMbFd=false, _hundredMbHd=false,
_hundredMbFd=false, _oneGbHd=false, _oneGbFd=false, _tenGbFd=false, _fortyGbFd=false, _hundredGbFd=false, _oneTbFd=false,
_other=false, _copper=false, _fiber=false, _autoeng=false, _pause=false, _pauseAsym=false}, getPortNumber=
PortNumberUni{_uint32=2}, getQueue=[], getReason=Delete, getState=State{isBlocked=false, isLinkDown=false,
isLive=false, augmentations={}}, getSupported=PortFeatures{_tenMbHd=false, _tenMbFd=false, _hundredMbHd=false,
_hundredMbFd=false,_oneGbHd=false, _oneGbFd=false, _tenGbFd=false, _fortyGbFd=false, _hundredGbFd=false,
_oneTbFd=false, _other=false, _copper=false, _fiber=false, _autoeng=false, _pause=false, _pauseAsym=false}},
interfaceName='tun704bde687e8'}, rollbackWorker=null, retryCount=6/6, futures=[com.google.common.util.concurrent.
ImmediateFuture$ImmediateFailedFuture@6a75e6cd[status=FAILURE, cause=[java.lang.UnsupportedOperationException: submit()
cannot be used inside a Managed[New]TransactionRunner]]]}
java.lang.UnsupportedOperationException: submit() cannot be used inside a Managed[New]TransactionRunner
at org.opendaylight.genius.infra.NonSubmitCancelableReadWriteTransaction.submit(NonSubmitCancelableReadWriteTransaction.java:36) ~[332:org.opendaylight.genius.mdsalutil-api:0.5.0.SNAPSHOT]
at org.opendaylight.genius.interfacemanager.listeners.InterfaceInventoryStateListener$InterfaceStateRemoveWorker.handleTunnelMonitoringRemoval(InterfaceInventoryStateListener.java:424) ~[?:?]
at org.opendaylight.genius.interfacemanager.listeners.InterfaceInventoryStateListener$InterfaceStateRemoveWorker.lambda$removeInterfaceStateConfiguration$0(InterfaceInventoryStateListener.java:398) ~[?:?]
at org.opendaylight.genius.infra.ManagedNewTransactionRunnerImpl.callWithNewReadWriteTransactionAndSubmit(ManagedNewTransactionRunnerImpl.java:63) [332:org.opendaylight.genius.mdsalutil-api:0.5.0.SNAPSHOT]
at org.opendaylight.genius.interfacemanager.listeners.InterfaceInventoryStateListener$InterfaceStateRemoveWorker.removeInterfaceStateConfiguration(InterfaceInventoryStateListener.java:378) [326:org.opendaylight.genius.interfacemanager-impl:0.5.0.SNAPSHOT]
at org.opendaylight.genius.interfacemanager.listeners.InterfaceInventoryStateListener$InterfaceStateRemoveWorker.call(InterfaceInventoryStateListener.java:355) [326:org.opendaylight.genius.interfacemanager-impl:0.5.0.SNAPSHOT]
at org.opendaylight.genius.interfacemanager.listeners.InterfaceInventoryStateListener$InterfaceStateRemoveWorker.call(InterfaceInventoryStateListener.java:318) [326:org.opendaylight.genius.interfacemanager-impl:0.5.0.SNAPSHOT]
at org.opendaylight.infrautils.jobcoordinator.internal.JobCoordinatorImpl$MainTask.runWithUncheckedExceptionLogging(JobCoordinatorImpl.java:401) [352:org.opendaylight.infrautils.jobcoordinator-impl:1.4.0.SNAPSHOT]
at org.opendaylight.infrautils.utils.concurrent.LoggingUncaughtThreadDeathContextRunnable.run(LoggingUncaughtThreadDeathContextRunnable.java:60) [357:org.opendaylight.infrautils.util:1.4.0.SNAPSHOT]
at java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1402) [?:?]
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) [?:?]
at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) [?:?]
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692) [?:?]
at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157) [?:?]

Change-Id: I5d0e634bdf24f159f018ed8ff8bdf9cacd98a78a
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Fix a typo

Change-Id: I1c8b7b67148c0de3d4fc4624c3ec169b7511d5dc
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
(cherry picked from commit f0ac4597d46032a1ca0fbf6016a948a9c97ad917)

Rpc changes for performance enhacements
cherry-pick from: https://git.opendaylight.org/gerrit/#/c/68397/
netvirt changes: Ib65733e577182067d02d0e90234c06591da09074
includes fixes for Elan Junits: I9e2d285e18cea4ec44cfe5794ee5772843708633

Change-Id: I142de600b189ba1e803779a7ba47be714efb4764
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

Switch to using lfdocs-conf to pull in theme

lfdocs-conf is a new project that allows us to centrally manage
project theme configuration without having to duplicate it
everywhere or have the "docs" project become a large submodule
project.

We will push to ReadTheDocs separately and then create a new path
for this doc under docs.opendaylight.org/projects/integration-packaging

For further details refer to:
http://docs.releng.linuxfoundation.org/en/latest/project-documentation.html

Issue: DOCS-69
Change-Id: I2259eea16a3cc6a52d1b72ee67a84ca6439dca6c
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Support for ITM direct tunnels in ITM workers

Modified the ItmInternalTunnel Add and Delete workers
to support creation/deletion of tunnels directly by ITM
Fixed issues while testing
Fix for bfd CSIT failure
Cherry picked from master https://git.opendaylight.org/gerrit/#/c/70243/

Change-Id: I1bd9c0edf1f549168d95bc2e7c1e7c3caf6b5967
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

Updating tunnel status based on tp status update

Update the ITM tunnel status by listening to the termination point status
Fixed issues while testing

Change-Id: I5b9b5389b4a2073d6648b164f2a5975484874ab1
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

Implemented tunnel state Updation

Listening to the inventory DS and create tunnel state information and also
program the ingress flows related to the tunnel
Fixed issues whilte testing
Cherry pick from master https://git.opendaylight.org/gerrit/#/c/70237

Change-Id: I83b0b6e95156ad7013cd8b3ff9902dcfed0a35ee
Signed-off-by: Hema Gopalakrishnan <hema.gopalkrishnan@ericsson.com>

Support for tunnel creation directly by ITM

Implemented creation of tunnels directly by ITM when the switch connects.
Conditional creation of listener if the itm-direct-tunnel flag is enabled.
Removed unused constants from ITMConstants.
Fixed some issues while testing

Change-Id: Ib5bef52ca85f7589057fadc2614e97de14e0109a
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
(cherry picked from commit 741125169954f1129b37aa27e90c80a0e084cfd0)

AlivenessMonitor pause/stop should work in cluster

JIRA: GENIUS-126
Change-Id: I464c3d6bdd67ebda2c47cdbb22d69e9b254b28c6
Signed-off-by: Nobin Mathew <nobin.mathew@ericsson.com>
(cherry picked from commit 95e03d7)

Cherry pick changes on listeners some changes from master

- Add InstanceIdentifier to the add/update/remove methods
- Remove @Inject from abstract classes
- Move ChainableDataTreeChangeListener and its implementation to tools
- Implement ChainableDataTreeChangeListener so that they can be testable

Change-Id: If1d4b4fb56ef3fcb88e48e58fd891b67acd0531c
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Migrate users of mdsalutil-api/Abstract listener base classes to tools/listeners

Change-Id: Ib00afd1c8f4d45317fc5bd8ee1d3d4e0afcf7f93
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Migrate mdsalutil-api/FutureRpcResults to tools/FutureRpcResults

Change-Id: I9e9e92ed3307a282b920f0b14b1a5980b0f031a4
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Moving datastore related utils from mdsalutil to new "genius.tools"

There are several requirements coming in where users are asking for a
simple feature with only datastore related utils. Currently all the utils
are parked in mdsalutil which has even openflowplugin related utils, and is embedded
in a heavier genius feature. This patch aims to move of these heavily used utils
to a new module, and add new features to expose the same.

Change-Id: I7d59273851c51b02fe43afcb1525c94ced1c5088
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Support for dynamic update of local_ip from SBound

This change will enable support for dynamic change in TEP's local_ip.
No need to explicitly remove tep and then add to achieve update
operation.
Simply update other_config's local_ip in openvswitch table of OVSDB to
update tep in the transport-zone inside ODL.

Change-Id: Ia3ba618dd95945f8bb4b14aa8c8f9b4b74ac0e92
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>
(cherry picked from commit daaa3e10f63a4985cc72029f43b0171538105972)

Change ext ID tzname key to transport_zone

This is for changing external_id's tzname key to transport_zone
which seems more understandable and better for long run.

Change-Id: I2d932b7a74bb2a21cf811e7feb27c4f372d81ec2
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>
(cherry picked from commit 9bb2a0d81d6056a18fc835708fe2e234bb606be4)

Fix issues with SRM test plan

Change-Id: I91bfc8a1fc37d5ea4a673d6b2c26b11a0310a6ce
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Spec update against reviews #70100, #70246, #70319

Spec is updated against below reviews:
Review ID: 70100
Move tepsNotHosted from Config DS to Oper DS

Review ID: 70246
Change ext ID tzname key to transport_zone

Review ID: 70319
Support for dynamic update of local_ip from Southbound

Change-Id: I99a47049f1fe850560754239d00465eaa11556db
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>
(cherry picked from commit d45da5e00aa9f588e19a40a4a525dcf2a58d36da)

TestPlan for SRM

Change-Id: I7ebd5ed2eff066de0f1d8b373615847e65a030fe
Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
(cherry picked from commit 624946f8c6cc73d99b4316aa43de0a429603d410)

Bump versions by x.y.(z+1)

Change-Id: Ice8766c724b7d15bdf0558405c3cc1b7fe2cbd4d
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

GENIUS-123: Efficient Handling of DPN disconnect

This reverts commit e4403a4cb9a57690f75885524051a55685a5f3f3.

Change-Id: Ia5c6efc21c904c753cd3fb83b23e17fadb9645ed
Signed-off-by: Faseela K <faseela.k@ericsson.com>

GENIUS-124: CSIT Failure as BFD status is not reflected accurately

changes to fix Genius CSIT Failure

Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
Change-Id: Ic6f68fcfa56610b7e335216ac27b03250f228043

NETVIRT-1198: Acl Stats does not support Anti Spoof drop stats.

Support has been added in netvirt which requires few new definations in genius.

Change-Id: I9a4750209e134338e4f06506dea6e1273ecaa922
Signed-off-by: Nishchya Gupta <nishchyag@altencalsoftlabs.com>

Add Karaf build profile

Project local Karaf distros are handy for devs to test their work
however is unneeded by autorelease builds and should not be released
as part of the Simultanious Release. Add a profile that is active by
default so that default behaviour is unchanged however allows the
autorelease project to disable building this module.

Issue: RELENG-86
Change-Id: I4fcc4a4f4575ae1f157d905a2de9e8e3b1092d97
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Remove obsolete Maven Site configuration

Change-Id: Ie27ef0b3152e95f5c6c566e86fd0982b218da393
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix FindBugs issues with odlparent 3.1.0

Change-Id: Iefca498bae9cec74569d958cc569277a938d6925
Signed-off-by: Stephen Kitt <skitt@redhat.com>

AlivenessMonitorUtils: wrap top-level in transactions

This uses transactions throughout based on top-level operations,
propagating the transaction through the call chain to ensure
consistent views of the MD-SAL.

Change-Id: Iae31775989102b1277a4e8a11a7f0633df21ae08
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump to odlparent 3.1.0 and yangtools 2.0.3

Change-Id: Ib6cef64750a76709751c9b7411b72712a6914b40
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Utils for itm performance enhancements
depends on the patch :
https://git.opendaylight.org/gerrit/#/c/69941/
which implements the caches needed for these utils.

Change-Id: Id0400bd56473550ebc49d2968024632fcdf5b265
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

Caches for newly introduced immutables in ITM
needs to get merged after data obj cache
is extended for custom key:
https://git.opendaylight.org/gerrit/#/c/69964/

Change-Id: I8d5f15757a805798f16b98b79b3ad03899b1130d
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
(cherry picked from commit d128fccc12595dfee34d92b56ab90249a0c9a378)

Extend DataObjectCache to allow for custom key

Users want to be able to provide a custom key derived from the
DataObject instead of keying by InstanceIdentifier.

needs to be merged after netvirt changes go in:
https://git.opendaylight.org/gerrit/#/c/70012/
would break netvirt CSIT otherwise.

Change-Id: I5f55068ff56390998270c2813d2682763479a404
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Removed unused ACL constants

Ensured there are no references in netvirt for these constants.

Change-Id: I4372e2cd7733b469d0dee6f0ba0afc551eff0af5
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>

ifm changes for itm performance enhancements

Change-Id: I250b75fea3ae29e8adb351693e7eeb0a596e18fe
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

increase max time out in AbstractTestableListenerTest from 50ms to 500ms

Change-Id: Ic45ad3bf911f81e030f7e425510a37fb2a54df0d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fix ActionNxConntrack.NxCtMark problem with xtendbeans (with a test)

Change-Id: I0bb0d42226adbccd32775353da326a680bb4e238
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
(cherry picked from commit ba314905ae33078a0842f62f08cec37993d0d021)

Add InstanceIdDataObjectCache

DataObjectCache will be extended to allow for custom key so
add implementation that keys by InstanceIdentifier.
needs to be merged along with the corresponding netvirt changes:
https://git.opendaylight.org/gerrit/#/c/70012/
Cherry-picked from:
https://git.opendaylight.org/gerrit/#/c/69264/

Change-Id: I95c973739e5430044a067417e213c4688c2ff598
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

Service Recovery Manager for ITM

Change-Id: I5dab695d7c397606728c46f19c4f2e2e38dfef42
Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>

Revert "Add InstanceIdDataObjectCache"

This reverts commit 15c2321f619ccd0b7ef0e660b144d0df1a5c0aaf.

Change-Id: I6f61ba633af73303ac117536ca934d4b5045e8fd
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Add InstanceIdDataObjectCache

DataObjectCache will be extended to allow for custom key so
add implementation that keys by InstanceIdentifier.

Change-Id: I16450c794512afde8d1091dc88f43a43ef8639b5
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
(cherry picked from commit 549075f9f3c8b562c3893c4b3655e8164262d0ed)

Make recoverableListenerMap maintain a queue of recoverableListeners.

This was a review comment from Michael which was not addressed on the
original patch

Change-Id: I14b7d9f4a92a4439cae40b4c4b23b7972f5468b4
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Service-Recovery: support for elan-interface entity type
instead of elan-instance entity type

Change-Id: I723bd2ac707bf8b34d869b9b7abfdea4b616c47a
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>

Issues with SRM service recovery

service recovery logic was doing a close of the already registred
listeners. However the close method of the AsyncListener base classes
were shutting down the dataTreeChangeHandlerExecutor as well, which
will cause issues when we again register the listeners.

Change-Id: I2e39c9ba0226c298fbd10f114ad33be39ae961a0
Signed-off-by: Faseela K <faseela.k@ericsson.com>

SRM refactoring

Realized that some code that went in interface-manager for service
recovery can be reused across modules, and hence moving some of those
common utilities to srm.

Change-Id: I65dbb9b27bddbe11f7ca4a30a3a27838eef8cefc
Signed-off-by: Faseela K <faseela.k@ericsson.com>
(cherry picked from commit 94d5f60b8cec8c0d4355591863e859742adba487)

Service-Recovery: Support needed for ACL feature introduced in SRM
framework.

(a) srm-types.yang updated with 'netvirt-acl', 'netvirt-acl-interface' and
'netvirt-acl-instance' definitions to support ACL service and instance
recovery operations. 'netvirt-acl-interface' and
'netvirt-acl-instance' are the two instance recovery options supported.
(b) SrmRpcUtils.java and SrmCliUtils.java updated to add required ACL definitions
to the internal maps maintained to support recovery operations.

Change-Id: I4c91cd52e7595b92b494356dfa715dbdf15da3c5
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>

Immutables for performance enhancements

Change-Id: I150d8edc58ad91724679dba15a1f269bd9e2e674
Depends-on: I250b75fea3ae29e8adb351693e7eeb0a596e18fe
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
(cherry picked from commit 472a2c7f07d92295d082509cf2ede81ca9ac57f6)

yang changes for scaling,
to support corresponding netvirt changes

Change-Id: If29c11f61658a44f8b5614baddfe660782fb7c69
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
(cherry picked from commit 04a7bbc3a1615be58aa25d14d933afba7d8ab3bb)

Genius Specific Changes to support QoS with SRM

Adding QOS option as recoverable service & Qos policy as recoverable
instance.

Change-Id: I0e123bec31f663d8b6673b37c5858fbcc85b8b46
Signed-off-by: Naveen Kumar Verma <naveen.kumar.verma@ericsson.com>

Bump versions by x.y.(z+1)

Change-Id: Ic2f9d952232be18343aac3f373a40f9ed8a3baa8
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

NETVIRT-430 Ping responder on tenant network and FIP-FIP traffic between
vm in same n/w in same compute is not working in stateful SG mode.

Added Ct Clear action

Change-Id: If86203e73a5ec516ff487f3f5c33fbd7dbfd12e1
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>

Bug: GENIUS-115 OVS Nodes Connect Quickly, Not All Get TransportZone TEPs

1) In ItemTepAddWorker do NOT use cached DPNTEPsInfos, read from DS instead
2) In ItmInternalTunnelAddWorker do not queue the new DPNTEPsInfos via
ITMBatchingUtils, instead write synchronously and unbatched in that thread

Change-Id: I91be9de8e7d098fbe94abc480605f460dfecef79
Signed-off-by: Josh <jhershbe@redhat.com>

Revert "GENIUS-116: Efficient Handling of DPN disconnect"

This reverts commit 3cf5a4776c2b8dcd77049ecb3ba4e1b28bc1aa4c.

Change-Id: I7a377a9b4cd74fe9052843882e7b730a63cb0036
Signed-off-by: Faseela K <faseela.k@ericsson.com>

GENIUS-116: Efficient Handling of DPN disconnect

Dependent on OF plugin patch https://git.opendaylight.org/gerrit/#/c/63261/

The changes in openflowplugin includes, port removal event will come with proper
reason flag set which will enable interface-manager to distinguish between a port
removal and a "port removal due to node removal" from the info in
the incoming event itself.

Change-Id: I39c5cdc6f57052521cb0061ca97ab7518637a5fe
Signed-off-by: SujaT <suja.t@ericsson.com>

Update .gitreview to stable/oxygen

Change-Id: I50bcf4d87de82ae1726953223d424eb974906b69
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix for GENIUS-112.

This is a race condition, proper fix should remove Batching manager from add callback.

Change-Id: Ia9de21864e82b2c8ded1ea121de615cafa6dab19
Signed-off-by: Nobin Mathew <nobin.mathew@ericsson.com>

Update genius ITM Tunnel auto config spec

The TEP-IP is now obtained from other_config:local_ip,
so update the spec to reflect that change.

Change-Id: I47d04acb4897cd4c8c5e0a952a08a65dc7e36259
Signed-off-by: Victor Pickard <vpickard@redhat.com>

Revert "ifm changes for performance enhancements"

This reverts commit 51d5fab28b9fbd2c165bd0c803ad768441385d0f as discussed on the TSC mailing list: https://lists.opendaylight.org/pipermail/tsc/2018-February/008919.html

Change-Id: Icc95f983591f9c8c871dd14c1266642cba4eb9bb
Signed-off-by: Stephen Kitt <skitt@redhat.com>

ifm changes for performance enhancements

Change-Id: Icdceb46e6453b6b1e503d14d89bd1b201f9a183b
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

NETVIRT-1068: Upstreaming fixes 3

When ARP response is received for the learnt IPs like MIP, its not
processed due to wrong check of table-id. Hence this check is removed. One
more bug was SrcIp and DestIP had junk chars which led formation of wrong
MonitoringKey. Due to this , MIP IP Arp Response was not processed.

Change-Id: If25bbc6fdc264ac866b5cd89c247c487d9f6ca6b
Signed-off-by: HANAMANTAGOUD V Kandagal <hanamantagoud.v.kandagal@ericsson.com>

NETVIRT-1009 - Enable genius auto-tz

https://jira.opendaylight.org/browse/NETVIRT-1009

Enable genius auto tunnels. There will be a separate
patch to disable netvirt dynamic tunnels.

https://git.opendaylight.org/gerrit/#/c/66109/1

This will be the default starting in oxygen.
Carbon and nitrogen will continue to have netvirt
dynamic tunnels as the default.

Change-Id: I9b9bb5d47618b7988bcc61bcadf44a746b6a9452
Signed-off-by: Victor Pickard <vpickard@redhat.com>

InterfaceManager Service Recovery

Adding recovery support for interface-manager.
Two types of recovery are supported:

1. Service Level Recovery - This triggers deregistration and
registration of all external facing listeners

2. Interface Instance Level Recovery - This triggeres a delete and
create of a particular interface configuration so that the state can
be fully reconstructed

Change-Id: I9b8ee67730d0ce7e07ef8f70e7d9e22b35b67c63
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Remove FlowBasedServicesInterfaceStateListener

Now that all applications are properly calling unbind-service,
the interfacestatelistener which by itself tries to remove
dispatcher table entries can be removed for a cleaner implementation

Change-Id: Ic37f45d8c923e8a8f8800d331c3666f50bd7a9bd
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Migrating IFM PM counters to infrautils counters

Existing IFM PM counters were using JMX MBeans,
now new counters are written for IFM PM counters using
infrautils metrics counter APIs which will be common library
to populate JMX MBeans for these counters by leveraging
Codahale framework.

Change-Id: I3a0f87ec3f60a207a56ec29eef5b28a22e3fd0c3
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>

ItmRpcTestImpl throw UnsupportedOperationException instead return null

Change-Id: I60138084a79bb2827cf363920506da5d44c29ad5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fix more build failure due to openflowplugin lldp attribute name changes

Change-Id: I0848efef3982ecd34e9715a375d008ffac607a36
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Migrate VtepConfigSchemaListener to use new listeners fw

Additional changes:

- Remove useless JavaDoc
- Remove IllegalCatchs

Change-Id: I0b87599af95b95920d2bea157917889c06327861
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Migrating FCAPSApplication PM Counters to Infrautils Counters

Change-Id: I2a4edeeb9deb72de15b8e4b75adf225843c4ddfb
Signed-off-by: Ankit <ank123it@gmail.com>

Migrate HwVtepTunnelsStateHandler to use new listeners fw

Change-Id: I67ff8c833c13bbc8f8b6c61154309c61cac52b70
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Build failures due to openflowplugin lldp attribute name changes

Change-Id: I9b06553ce1a0fcae7266492ea8fe176072d87874
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

use feature for inter-project dependency

Use feature to express inter-project dependency correctly instead of
bundle.

For details, refer to
https://lists.opendaylight.org/pipermail/release/2018-January/013604.html
https://lists.opendaylight.org/pipermail/release/2017-September/012356.html

This depends on below patches to export necessary bundle as feature.
https://git.opendaylight.org/gerrit/#/c/68214/
https://git.opendaylight.org/gerrit/#/c/68233/

Change-Id: If3188ac2afaaa10d000969341e0f788c45c8bd2b
Signed-off-by: Faseela K <faseela.k@ericsson.com>

NETVIRT-1066: Scale 150 DPN

Iterating through non-L2VLAN interfaces in L3VPN Tunnel
Interface State listener is unnecessary
For scaling to 150DPN , each TunnelIntfState add event causes a read of
list of interfaces on the given DPN.This list includes even non L2Vlan
type interfaces like tunnel-port etc. By ignoring these ports , read of
operational vpn-interface is avoided.

Change-Id: I3e658eb8eb78d39dc9ed0a7fc1750ce55ae6a7ec
Signed-off-by: HANAMANTAGOUD V Kandagal <hanamantagoud.v.kandagal@ericsson.com>
Signed-off-by: Sam Hague <shague@redhat.com>

remove wrong @Inject from DataStoreMetrics (and very minor clean up)

because instances of DataStoreMetrics are created explicitly via new by
the listeners in package org.opendaylight.genius.datastoreutils, but
never by Blueprint XML or annotations, the @Inject here is not needed,
and could be confusing to humans and tools in the future (and we could
never @Inject Class<?> anyway).

Change-Id: Ia361a59f468f4fb77d30610b02882b354c66b847
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

GENIUS-109: write interface state correctly

we need to provide the mandatory statistics.

Change-Id: I246a456ba8a8e767cd84e70b83dc985696c24c1d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

added data change listener counters

Change-Id: Ib4fe1aa05a7e2a007a78078e6e5a9ed5ad790c4e
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>

Change log level from info to debug

Change-Id: I3e7fb7e274fe0cdb65aa06e31e3be6d97382a13a
Signed-off-by: Ankit <ankit.j.jain@ericsson.com>

LockManager lock() no longer eternally retries in case of errors

it should only retry if there is an OptimisticLockFailedException,
otherwise it should return a Future failed RpcResult.

this CHANGES the behavior of lock() to return a FAILED RpcResult in case
of a TransactionCommitFailedException caused by a AskTimeOutException
(before that, and other errors, returned a SUCCESS RpcResult); which, to
me, seems the Right Thing to do.

includes proper test driven reproducer for non-regression

much more work remains TBD in LockManager, see TODO in LockManagerTest;
anyone interested in taking this up?  Thank you!

Change-Id: I070fd5ef6ffff195a81dbc2d676913d417b073b7
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Handle br-int dpid update for genius auto tunnels

In OOO deployments, genius auto tunnels does not work,
and vxlan tunnels are not created.

When br-int is added by netvirt, the ovsdb node add
comes in for br-int, without a dpid. The code bails
if br-int does not have a dpid (tep not added).
Then, a second notification comes in, as an ovsdbNodeUpdate,
with the dpid for the node (br-int). But, the current code
does not handle br-int updates, and the tep is never added.

This code change checks for dpid being added to br-int
in the update path, and triggers tep to be added when
this condition occurs.

Change-Id: I3a62283f1596dba3c6d734f5497c3f38a5be4b10
Signed-off-by: Victor Pickard <vpickard@redhat.com>

GENIUS-104 Genius auto-tz: use local_ip for TEP IP

Currently, Genius auto tunnels is configured to read tep-ip from OVS
external_ids tuple in the Open_vSwitch table.  Details can be found here:

http://docs.opendaylight.org/en/stable-nitrogen/submodules/genius/docs/specs/itm-tunnel-auto-config.html

This change will be to use the existing, supported field local_ip,
from OVS other_config tuple in the Open_vSwitch table.

The main reasons for this change are:

1. Avoid duplicate data. Instead of introducing a new field, tep-ip, for
source VTEP IP, reusing existing local_ip.

2. Devstack and other installers already support local_ip. By reusing
this field, there should be no changes required in any of the
installers (devstack, OOO, etc).

So, going forward, local_ip will be used as the source IP for the VTEP,
instead of tep-ip.

Change-Id: I529040c0da81a187927f9f91b9f50839c7fe340d
Signed-off-by: Victor Pickard <vpickard@redhat.com>

IFM stats params configured by Blueprint

In interfacemanager-impl, new config file genius-ifm-config.xml is added
and corresponding yang for it.

It contains following params:
- ifm-stats-poll-enabled
- ifm-stats-def-poll-interval

Change-Id: I592f9cbf8c18aa05fba3d4ecec4ba6edb52d79b5
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>

Scale-In Scale-Out RPC call to get DPN info

Below changes exposes RPC call to get DPN details (DPN ID and Tep Ip of
the DPN) by passing the compute node.

Change-Id: I3d80e2d582e049e35bbd21d6f499e1e74c2c3b99
Signed-off-by: Riyazahmed <riyazahmed.d.talikoti@ericsson.com>

minor fix InterfaceStateHelper import statement order

I'm not sure why Checkstyle in mvn hasn't picked up on this?!

Change-Id: Iade51c9350f32dc9bd8e37b4fc6b35b053a730c5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Changed RPC to retrieve Vxlan DC GWY Ext. Tunnels

Changed the ITM RPC to look for external tunnels towards DC gateway based on
the tunnel type provided as input and removed the hard-coded MPLS Over GRE
tunnel type.
Fixed merge conflicts

Change-Id: I1ac9da0390539adbaeaeb841ce95f31a122dda6b
Signed-off-by: Hema Gopalakrishnan <hema.gopalkrishnan@ericsson.com>

Enforce deferred recycling of IDs by IDManager

Cause - IDManager allocates released ids first if ids are
avaliable in Released Ids holder. Hence, frequent recycling of ids by
IDManager is resulting in dataplane failures.

Following are changes done as part of this fix:

i) Allocate id from child pools available holder. If that gets exhausted, allocate id from released ids holder.
ii) If child pool is exhausted then get IdBlock from parent pools available ids holder. If that also gets exhaused, get IdBlock from parent pools released ids holder.

Change-Id: Ia8648d599c70480ebce15f05cbe85d13d841ba1d
Signed-off-by: Ankit <ankit.j.jain@ericsson.com>

remove IT, because SFT does that now

and InterfaceManagerIT really had nothing about InterfaceManager anyway

Change-Id: I96c34fc3f11c5b62aa91ac68a77434068ad98a54
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

refactor ResourceManagerTest into correct .genius. sub-package

Change-Id: Ia345e480bfc91c66d968457fa87d4746df2c4c73
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Migrate FlowBasedServicesNodeStateListener to use new listeners fw

Change-Id: Ia78f1d641cd2bd004ca28a9f1e0a8680f56df1f8
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Test Plan for ITM Scale Improvements

Find Spec for newly added feature ITM Scale Improvements here
https://git.opendaylight.org/gerrit/#/c/65809/

Change-Id: I0990094f9e1edb0403da176474cc58a5b163d3cf
Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>

Add MetricProvider to JobCoordinatorTestModule

This requires Ie90562c2f8205bab8817d370d077def9a3419d52 and
I530d20946a80933b05371c5220def447be1ee5e6 in infrautils in order to be
able to compile, and must be merged together (with the 2nd, the first
can go in before).

NB: We cannot mock(MetricProvider.class, RETURNS_DEEP_STUBS), because
the TestableJobCoordinatorEventsWaiter relies on JobCoordinatorMonitor
and assumes a working getIncompleteTaskCount... which the mocked one
would not be.  So we use the (new) "real" TestMetricProviderImpl.

Change-Id: I80e3f5b6e8a601345cd2fbae79f0de22d0fa0e7d
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bug 8400 - ACL changes doesn't affect the
existing connections

Problem:
    Change in SG rules not affecting
the existing communications

Fix provided:
    When we delete the SG rule, added
a flow to reset the communication.

Change-Id: I40bb9c93b11b785e153e5751f083b628cec4b000
Signed-off-by: vinothb <vinothb@hcl.com>

Yang Definitions for Itm Scale Improvements

Change-Id: I689605e35c7ee3c6b6681674c1629461693fd7bf
Signed-off-by: Hema Gopalakrishnan <hema.gopalkrishnan@ericsson.com>

GENIUS-105 IdManagerTest testMultithreadedIdAllocationForSameKeyFromAvailableIds is brittle

Non thread safe idSet is used inside executor which is resulting in testMultithreadedIdAllocationForSameKeyFromAvailableIds
and testMultithreadedIdAllocationForSameKeyFromReleasedIds tests failures.

Making idSet thread safe fixes both the tests.

Change-Id: Ia90456793b46ec8924f6f831bf3553319387776f
Signed-off-by: Ankit <ankit.j.jain@ericsson.com>

Migrate HwVTEPConfigListener to use new listeners fw

Additional changes:

- Replace Callable objects by lambdas
- Swap order of helper's parameter to be consistent with the rest

Change-Id: Ibbfe29b3b8ddab51f7c991ff45062ab23220363c
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

OPNFLWPLUG-972 : Point to openflowpluign liblldp

Point to liblldp libraries from openflowplugin instead
of controller project (which will be removed soon)

Change-Id: Ie4feb5a9bb5d5552195f61356f9b27ec203d446d
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>

Migrate VlanMemberConfigListener to use new listeners fw

Addtional changes to simplify it:

- Remove unused parameters
- Replace Callables by lambdas

Change-Id: Ie0ba50e1563df32cb76a2edf5ed11a4e5af76104
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Replace DataStoreCache with DataObjectCache in itm-impl

There were 4 different caches to convert. 2 of them,
TunnelMonitorParams and TunnelMonitorInterval, are singleton
DataObjects use for global tunnel monitorng configuration.
These seem to be condidates for clustered-app-config however
dynamic updates would restrart the BP container but it doesn't
appear itm-impl is ready for that. So to preserve existing
behavior, they're DataObjectCache instances local to a new
TunnelMonitoringConfig class.

The other 2 caches were replaced by DataObjectCache subclasses,
DPNTEPsInfoCache and TunnelStateCache, and injected where needed.

Change-Id: I4e4ed505fa46a5af05086436a7593d92d2bdb56c
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Migrate TransportZoneListener to use new listeners fw

It includes the fixing of some issues found during the process.

Change-Id: Ic28489b872730f78e0a5aa85582abba1797fb656
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Running Genius CSIT in a dev environment

Document on how to run genius csit in a dev
environment

Change-Id: Iccc0468023f5a5ee1452d4d1712c741c464713bc
Signed-off-by: Faseela K <faseela.k@ericsson.com>

adding portuuid to be retrieved as part of port statistics

Port statistics Listener gives nodeconnectorid.
To retrieve portuuid, portname is required.
Through "InterfaceInventoryStateListener" nodeconnectorId-portname map
is built.
Listener class is added upon
"odl-interface-meta/interface-child-info/interface-parent-entry" through
which interfaceparentname-interfacechildentry map is built.

Using these two maps, portuuid is retreived in port statistics.

Change-Id: I83ad72ce0ff21980b323f28aeb2cc177a4034eab
Signed-off-by: Viji J <viji.j@ericsson.com>
Signed-off-by: VijiJ <viji.j@ericsson.com>
Signed-off-by: Viji J <viji.j@ericsson.com>

Remove older s-n-d implementation.

Now that genius has moved to infrautils based
diagstatus, let us remove the older status-and-diagnostics
code which was remaining in IFM and ITM in bits and pieces.

Change-Id: I322c020021e60efe28c1b35415660e0b26b90fee
Signed-off-by: Faseela K <k.faseela@gmail.com>
Signed-off-by: Faseela K <faseela.k@ericsson.com>

added read method to ResourceBatchingManager

Reads the identifier of given resource type
If the identifier is going to be deleted , returns Optional.absent()
If the identifier is going to be added , returns the to be added DataObject
else goes to the datastore and reads it.

Change-Id: Ie3e5903d22463d5914068bb693c54f4b93594d02
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>