Remove deprecated Qname.cachedReference method

Remove deprecated Qname.cachedReference method

Change-Id: I401b75a2a583b9fd048dba6ac7698dd84c47f915
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Add a private constructor to hide the implicit public one

Add a private constructor to hide the implicit public one on
OpenConfigComparatorFactory.

Change-Id: Id24e1b3bb8c59e0eaed71093acd4443e75ac50db
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Rename Label package name to match the regular expression

Change-Id: I31996acbcca5b3e247c977a3615f2b4050670488
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Use StandardCharsets.UTF_8

Do not look up the charset, but use a global shared instance.

Change-Id: I43ae1e93c0a13675585e69cf32bbf46d80c1ebfa
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-4729: PCEP RP object priority can be set 0

Fix RP object priority parser - if priority is 0,
priority is not present.

Change-Id: I86a9ffb652763524440e9f1599b468bbf27704db
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug 4801 - FromExternalImportPolicyTest is failing at JDK7

Enable the test.
The failure was caused by:
https://git.opendaylight.org/gerrit/#/c/31365/
The change was reverted:
https://git.opendaylight.org/gerrit/#/c/31511/

Change-Id: I70b130b15ec57fc696a3af02b9dfc7f8f9e93ae7
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Unit tests for openconfig-impl/moduleconfig

Change-Id: I179021c1214f127151defcc77cd2a6eaec6ab251
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

Bug 4781 - BGP at work is not ready for application of 43-bgp-openconfig.xml

Change starting order - first BGP OpenConfig app is stared, then RIBImpl
is started.
The change avoids problem with reconfiguring RIBImpl instance at startup.

Change-Id: I8777bb0175b03bd4450076b6e916fc1d015d1394
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4780: New peers failed to connect after one gets connected

After one peer gets connected, new peer failed to connect.
Cause of the issue was that we were reusing DefaultPromise
from previous connection.
Fix by creating new promise for each connection.
Remove needless EventExecutor variables, use
GlobalEventExecutor.INSTANCE instead.

Change-Id: I2938b9f16087d5b004fdbd43bcf082e26bb8a071
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-4740: No reconnect after negotiation failure

Change-Id: I31a152bcfc52f98a9e95a8a75b26d42d2da8a014
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BUG-4779: Openconfig mandatory descendant missing

Make sure mandatory leaf is allways present.
Map RIB module configuration on OpenConfig Bgp top level container.

Change-Id: I5f28a5fa2924ec2ddc721c69f0b2a67fdf374f63
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4792: Fix failing single feature tests

Use "odl-netty" feature from odlparent.

Ignore JUnit test FromExternalImportPolicyTest.testEffectiveAttributes
Will be fixed in additional patch.

Change-Id: I7baa260325cbf4fe6d317d71315e091fcf1d7a6b
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4696: BGP OpenConfig bugfixing

-introduce comparators, used when comparing current configuration state
with proposed state

-pass whole configuration (not only identifier) when removing
config module instance

-use MountPointListener instead of DataTreeChangeListener

-refactor implementations

Change-Id: I388dcd6ccb094a82d922740b86f721b5baf23e18
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4730: Update BGP-LS EPE

Update implementation to conform draft-ietf-idr-bgpls-segment-routing-epe-01
which is reflecting changes in latest linkstate segment routing extension draft.
-TLVs redefined with common structure
-changed TLVs codepoints

API (Yang data model) change:
renamed container "peer-sid" -> "peer-node-sid"
added container "peer-adj-sid"

Change-Id: I391862970fd751f54426e7222eb99519a68b4d99
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4689: Advertising performance fix

The TCP channel become unwritable too fast and too often, hence
use high & low write watermark option for channel.

Change-Id: Icd52f164153dde94cd7c61a0c38f805a5c0593cf
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Sonar warning fix: IPv4RIBSupport

attribute name refactor

Change-Id: I89e58a8a1b4120b44085983ccf724f94b0370c27
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

Test coverage: rsvp-spi/subobjects

Change-Id: I29400140d6e5cb5846473896a20151e3a57fbdc5
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BUG-4705: LS-SR MplsLabel as 20 rightmost bits

Change-Id: Ia8c47d4f9b16785b911025994c5b56cd6e7b78d9
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

Refactor classes names

Refactor classes name to have same stetic in capitals
all, like BGP and PCEP.

Change-Id: I58fb5a3524e2628a4b7555621e34b2d1f3c3c362
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Unit Test: BGPOpenConfig

Change-Id: I501cc7c2ecde00e00d68535aa4b05ae1f3bbb52b
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

Test coverage: rsvp-spi

Change-Id: I4cdcecd0610c667e3d1f4bbe3e4871b77c869c7f
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

Use odlparent jacoco configuration

Change-Id: I2948f02064ad38fa018b7ae05068a65d3a961ae7
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bug 4646: Fixed up duplicate use of reference statements.

minor fix of invalid yang files

Change-Id: Ic8dbcee91e9be2c78813291dd95239d3ca5895b6
Signed-off-by: Filip.Gregor <fgregor@cisco.com>

Use odlparent-lite as artifacts parent

We created odlparent-lite to provide a minimal pom which allows projects
to publish to the correct server. Without this ${project}-artifacts may
fail to deploy to Nexus.

Change-Id: Icff4d53b0af400ecae86c6099ebba00ec0509c72
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Eradicate use of commons-codec

Guava provides hex-codec, use that instead of commons-codec. Also turn
some methods into statics while we're in the area.

Change-Id: I9e950277995f78bfe6323b11b41ef840e427726a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove antlr4-runtime-osgi-nohead

This bundle was removed from yangtools so no longer exists. See:
https://git.opendaylight.org/gerrit/28272/

Change-Id: I7094edc12c3f12ad6ef8aee0e4c2cfaf98af7263
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BUG-4672: BMP client reconnection not working

-get rid of protocol-framework's reconnect strategy
-introduce simple initial reconnection as suggested in
https://tools.ietf.org/html/draft-ietf-grow-bmp-15#section-3.2
-BMP session should go to "up" state once the connection is established (channel is active),
introduced "IDLE" state of a BMP session
-added commented sample of active client (monired router) configuration

Introduces "IDLE" state of a BMP session,
session goes up once the channel is active.

Change-Id: Ibd78fe708162a710fdcc20c614cc1d9c1be6eb95
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-3919: Support for non-MP advertisement

Add a support for old-school BGP-4 advertising,
if peer do not advertise IPv4-Unicast MP capability.

Revert changes in IPv4RIBSupport class.

Change-Id: I0f3a4c767f4f7048e4867ec3aab6c2b8dac6c008
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4569: Data-change-counter reconfiguration failure

Data-change-counter reconfiguration fails because of
race condition. Last task which removes model from
DS is not executed before new data-change-counter is
created and insert his own model on DS.
Fix by wait until last task is executed when close module.

Change-Id: Ic9349bf99d6a96fd44babdb874158138d7eaf6e8
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-4679: NPE in IPv4 prefix withdrawn Update msg serialization

When building Update message for withdrawing routes, check if
Multi-protocol is supported for this type of route.
If not, pack withdrawing routes as per RFC4271.

Change-Id: Ia9a36add74dd817bf0a460cfeaa5281f9b2fb50a
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Refactor Tunnel-Programming

Refactor Tunnel-programming and create new
TunnelInstrucctionExecutor classes.

Change-Id: I0be6fd4f5a050a9b81f8f7bed01b3eabb848fd25
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Remove redundant modifier

Change-Id: Ibfc7b03b4e73fd4d329af0b690967ce38772a2c9
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BGPRibImplProvider sonar fix

Change-Id: I9c3101ba41b5cadadbbc1d1fc24b1b19c67296cb
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

OpenConfigUtil sonar fix

Change-Id: I16c4abaca3cd57e492695ae896fb54271b17db93
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

Rev130715Util minor fixes

misspelled Uitl -> Util
added private constructor

Change-Id: I949cceb518cdaa4a66b9b725d5974f09610b15f6
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

SrRangeTlv: inner area parsing/serializing

Inner area should be handled just in case of OSPF protocol.

Change-Id: I8468dfe0aeff6ed6c4ee7945f489b22bf8874075
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BUG-4617: BGP Flow-Spec Redirect to IP Action

-adds support for BGP FS Redirect to IP action
-implementation is based on draft-ietf-idr-flowspec-redirect-ip-02
-registered under Ex. comm type/subtype as per
https://tools.ietf.org/html/draft-ietf-idr-flowspec-redirect-ip-00#section-7

Change-Id: If889e1b65d944c71b85e0d27c57af4be7e08af6c
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Move releaseConnection from ReusableBGPPeer to BGPSessionListener

Move releaseConnection from ReusableBGPPeer to BGPSessionListener

Change-Id: Ief296eccc81cc00661462cc9ec861ff4acc379de
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Refactor LinkstateNlriParser

Refactor LinkstateNlriParser to fix Sonar complains

Change-Id: If4f523bc7fe338f370b809df68c952ceef8e403f
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Implement changedRoutes Test

Implement changedRoutes Test

Change-Id: I2026338225959325efefd9501248a0fa01cc6335
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Remove unnecesary dependency

Remove unnecesary yang-ext dependency

Change-Id: I9a0434a756326ebe5d670d346a01b01648cb5c60
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Remove workaround for bug 1276

Since bug 1276 is fixed, workaround is not required
anymore.

Change-Id: I5939f3ac94ab3b3f865c3c2920e4f491f39f9827
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Refactor Stateful07TopologySessionListener

Refactor Stateful07TopologySessionListener to fix Sonar
complains.

Change-Id: Ib9548697baa6e405cadc1013857388df1379b99b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Create AbstractEROPathKeySubobjectParser

Create AbstractEROPathKeySubobjectParser for PCEP

Change-Id: Ifeb84955f2002d78871705c0e7091ac3df31e894
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-4616: Update Flowspec Redirect Ext. Communities

-implementation of handlers for BGP flowspec
Ipv4 and AS4 Redirect extended communities

ref.: http://tools.ietf.org/html/rfc7674

Change-Id: Ia4da00db3b62633206e643654e64a3faf5b76aa2
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Fix extended community parser key generator

Change-Id: Ie311b0f1a03b1475313f4c657ffa6d9147965ca9
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Refactor EffectiveRibInWriter

Refactor EffectiveRibInWriter to fix Sonar Complains

Change-Id: Ie5b5892b26f045cf683ca5af56307cad3de683ef
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-4618: FS Redirect ipv6 EC handler

Change-Id: I460fb793c2b0cbf09e954214c8142e9bbfcb8666
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

create AbstractNumericByteOperandParser

create AbstractNumericByteOperandParser and remove duplicate code.

Change-Id: Ibb58d848dd7f92780e824a867b680cb550b38107
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Test coverage: openconfig-impl

Change-Id: Ie1de0875a1f4fbe1aab3c602a5a75b78b3654d08
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BUG-4633: Use ietf-inet-type rev. 20130715 on bgp-openconfig
Add mssing dependencies.

Add missing dependencies required by openconfig
Reconfigure openconfig to use ietf-inet-type
revision 20130715.

Change-Id: I4c5f6960c1b1e5f364f0a4f9d9cf347677fa72cb
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Add path-binding-tlv missing reference model

Add path-binding-tlv missing reference model

Change-Id: I14df2a1c1e21266d1b820729add1660e8024de49
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BmpMonitorImplTest fails

Test BmpMonitorImplTest sometimes fails
because port still not free from previous test.
As a solution we set the Socket as reusable.

Change-Id: Idb4ecc50f43e2be57d5b11a7c72c09fd8e2de51d
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-4634: Prefix in withdrawn list is not ignored when announced in same msgUpd.

An UPDATE message SHOULD NOT include the same address prefix in the
WITHDRAWN ROUTES and Network Layer Reachability Information fields.
However, a BGP speaker MUST be able to process UPDATE messages in
this form.  A BGP speaker SHOULD treat an UPDATE message of this form
as though the WITHDRAWN ROUTES do not contain the address prefix.
Fix by ingore common NLRI on withdrawn router

Change-Id: Ic9ebd3ce13f042f0dfcd2b28815442f8484add16
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-4622: Sending Empty Optional Attributes

Some of the parsers of Optional Attributes
only take in account the possibility of null
attribute and not of an empty one.
Fix by check it and dont parse them in case of
empty or null.

Change-Id: I34d801a001ed167e18646e228b9b9dfc03f7c882
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Remove unused dependency on yang-ext

Since the augmentation order is predictable now, do not depend on unused
yang-ext bundle.

Change-Id: I7e511a2f43f3f4e430ac6746a46ecefb13f10174
Signed-off-by: Robert Varga <rovarga@cisco.com>

Sonar warnings fix

Complexity issue - extracted switch into private method.
Renaming attributes and variables.
Removed unused attributes.
And other minor refactoring.

Change-Id: I335cb6ccce85b55e30c9537fe39f3dfb7754cc39
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BUG-4598: upgrade openconfig models

bgp.yang conflicts with another model in ODL. As it turns out,
this has already been fixed in OpenConfig 1.1.0 release. Update the
models to resolve the conflict.

Change-Id: Iede4e57116b81f5f8d835b60958ae3d87b59d897
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4593: BGP peer registry lookup false negative result

Added method into Ipv6Utill for creating Ipv6Address with uncompressed value.
Used when registring and deleting peer address.

Change-Id: Ifa96a3ec2f9f7cc3ee60329e888590647af40f64
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
(cherry picked from commit 0e5baad314c8374cc1d0dd4bcce9b2845d32da24)

BUG-4618: FS Redirect-IPv6 Extended Community

updated FS model for redirect-ipv6 ext.com and added to augmentations.

ref.: https://tools.ietf.org/html/draft-ietf-idr-flow-spec-v6-06#section-4

Change-Id: I65acbc4d47f9f0fe2375a8bcb920e1af83f08010
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BUG-3771: Use sync on FutureChannels intead of await

"Await" waits until future has finished and throw execution
if thread was interrupted."Sync"" instead waits for this
future until it is done, and re throws the cause of
the failure if this future failed.
When closing the module, first we ensure that channel
has been closed and if it didn't fail we proceed
with next closures.

Change-Id: I1240d6fdb6986b8c30251206d8027db7b1a987fa
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-4617: BGP-FS redirect to next-hop IP action

-added yang data model for "redirect to IP extended communities"

ref.: https://tools.ietf.org/html/draft-ietf-idr-flowspec-redirect-ip-02#section-3

Change-Id: I80e74b884e87e2fdbcc0a9feb0ed5f873f8abbb7
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4616: Update BGP-FS Redirect extended Communities

-added yang data model for redirect AS-4Byte
-added yang data model for redirect IPv4

ref.: https://tools.ietf.org/html/rfc7674

Change-Id: I4456f8bd7789f82418e852be74c010b1ee7038ee
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4568: Introduce BGP Extended Community registry

-new Extended Community registry
-parsers registration is based on type/subtype
-serializers registration is based on "extened community case"
-added new "transitive" field for extened communities
-other "transitive" fileds are deprecated in yang data model
-deprecated type/sub-type value from yang data model:
-values are not filled in during a parsing
-values are ignored during a serialization
-make the extended commnity attribute parser non-extensible:
-BGP path attribute serializers are registred in
a specific order, an extending of the extended community
handler breaks the contract
-added missing IPv4 Transitive/non-transitive Route Target/Route Origin
extened communities
-updated Flowspec extended communities

Change-Id: I2818b20c069da362f60a716862421bb185bc8571
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4594: ISIS PseudoNode NPE

NPE caused beacuse of wrong container.
Fix by:  add missing is-is-router Container
which contains ISO System ID. Affecting
isis-node-case and isis-pseudonode-case.

Change-Id: I256c36ea980326bd39db4e8189ef092e20491c54
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Remove gracefullyShutdown of EventLoopGroops

When instance is closed, boosgroud and workergroop
shouldnt be shutdown since they are required in case
of new instance created. If new instance is created
it will cause
RejectedExecutionException: event executor terminated

Change-Id: I58f9328140bc209aeafc7bfad14f883887447a59
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Keep consistency under Optional parssword

Change-Id: Ib0f5901237ff370f7f9a6f143f1d9e8ec59405e9
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Add openconfig-config to BGP feature dependencies

SingleFeatureTests in distribution jobs are failing.

Change-Id: Id6b6a55eb87519c27f63f6149f8dc505033c102f
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

BUG-4197: BGP OpenConfig Implementation

-BGP OpenConfig for ODL BGP RIB and peer/app-peer configuration (config-subsystem) and vice-versa
*RIBImpl <-> Global
*BGPPeer <-> Neighbor
*BGPApplicationPeer <-> Neighbor (belonging to special neighbors grupup "application-peers")

-support BGP configuration module to BGP OpenConfig mapping:
*once configuration of a particular BGP config module is created, the attributes
are mapped to OpenConfig API, configuration is stored and written do configuration DS
*once configuration of a particular BGP Configuration module is closed, a stored OpenConfig DTO
is removed and deleted from configuration DS
-support BGP OpenConfig API to BGP configuration module mapping
-application is listening to the changes in BGP OpenConfig DS subtree:
*when a new data are created or modified, the new BGP OpenConfig DTO is mapped to
BGP config module, the DTO is stored and config module is written to
controller-config's Modules subtree.
*when data is removed, the DTO is removed from inner store and BGP config module is removed
from controller-config's Modules subtree.

Motivation: Simplify configuration of the main ODL BGP components (mainly in programatic way) in a most used use-cases.
Limitations: BGP OpenConfig Yang data model is composed for configuration of one BGP speaker, ODL may have multiple instances of BGP Speaker
The change brings a dependecy on netconf's sal-nectonf-connector ot BGP project.

Change-Id: If245bd54d844bd9965637c83f382e82c6a5b9a53
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Remove duplicate class

Remove duplicate and unnecesaries classes

Change-Id: I5835cb41ef3dfd881478b5ed93930c9cc87cf066
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-4552: Enhance LS-SR - discern protocols

Updated yang model and decoding methods.
Corrected and extended unit tests.

Change-Id: I4cb8e7ba18ebce2962d4a5155e910f1292d57174
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

Utilizing MplsLabel

Applied in BGP-LU and BGP-LS SR

Change-Id: I0736a96a71a2aca06bf9645df4fdf9b3afa967b9
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

Sonar minor issues fix: modifiers

Change-Id: Idc6504dc7e95f64452a9c3e11f60690bbec36168
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BGPCEP MD5 Password Fix

Password were checked in case if null
but not in case of empty.
Fix by creating an Optional from password where in
case of null or empty will be absent.

Change-Id: I67033deeccd5f634a73d941d0c3da23e8dfb644d
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Sonar issues fix: LS, FS

added final modifiers, solved complexity by extracting switches
to private methods, removed not used attributes.

Change-Id: Iab11adafac0b2519a5d07b26d638e8265ac6d0ff
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BUG-4557: Fix BMP initial config files

-reconnecting strategy belongs to dispacther configuration
-add expected protocol framework capability in bmp's "features.xml"

Change-Id: Icde460db308d6882e742456df3829d9fb7cac683
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-4534: Fix yang model

remove an unexpected comma causing "line 124:13 extraneous input ',' expecting {'}', SEP, IDENTIFIER}"

Change-Id: Ia3dc19bdf95e3450b89bdcc00f33ad6898a55b67
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4545: PCEP SR- ERO/RRO codepoint configurable

Since we dont have IANA stablished code point for
SR- ERO/RRO subobjects,  and there are new one
proposed by draft (ref) we made the code point
configurable, setting by default previouly used.
ref:https://tools.ietf.org/html/draft-ietf-pce-segment-routing-06

Change-Id: I2055f1cd6644ad1506cb6d2ceb05bcaf9f794dd4
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-4447: BGP-LS SR extention

applied in LS YANG model
updated attributes parsers of types: link, node, prefix
unit tests correction

Change-Id: Ie6624360ce0947ac4f5523386c1700bb41f11565
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BUG-4197: use yang-ext's augment-identifier

-make sure that generated java APIs for augmentation have
always the same name.

Change-Id: I859460ca6265a5e52148af22d45d638b4d54030f
Signed-off-by: Milos Fabian <milfabia@cisco.com>

make bmp session with reconnect strategy

Change-Id: Ia4a0bc455b0d920c13eb9d4e1804ff7d98e79b7e
Signed-off-by: Jeff Liu <bigdataops@gmail.com>

BUG-4197: BGP OpenConfig SPI

Defines the APIs to track a BGP configuration modules status changes and
BGP OpenConfig data writers consumed as a service injected by config subsystem into
BGP configuration module.
The goal is to react on changes in the BGP configuration module instances - the configuration
modules are mapped to the OpenConfig BGP data model instances and kept in a datastore.

Change-Id: Ic38d5049d4d7e2f51f05a0e44e28626fc48e7ab7
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4173: flowspec fixes

Fixed extraction of nodes in FSNlriParser.
Fixed model for extended communities and augmentation of bgp-rib route.
Corrected and simplified RIB support destination processing.
Unit test correction.

Change-Id: I3ddd1424703eb1e7f4a3506eeb4c02f641753452
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BGP-LU mpls-label replacement

Change-Id: Ifca9ba8f21dde71808360a4c5504ba4ef8739de7
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

FS configuration

Change-Id: Ic52e2927572ce129775e81fce06e7a60338b86c1
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BUG-4531: Error channelFactory set already

When we change the MD5 password we see
IllegalStateException: channelFactory set already.
Fix by setting only once the channelFactory, according
the case, MD5ServerChannelFactory when MD5 instead of
NioServerSocketChannel.

Change-Id: I5d02b1a3e325f1cd47099ee13397d141105969a3
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-4447: BGP-LS SR extention: new YANG module

Change-Id: Icdf09f2303fc93b48c558efb9359698bec3f0d00
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

Update Node Flag TLV

Update Node Flag TLV based on last RFC

ref:https://tools.ietf.org/html/draft-ietf-idr-ls-distribution-12

Change-Id: Ia371c77780355709d65ebb9943a5b8a3fc488543
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BGP Logs improvement

Logs in LocRibWriter and EffectiveRibInWriter were not
providing useful information, therefore they are mnodified.

Change-Id: I3ee623d287debf33a12c704b031c11d5fe0f5bad
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-4063: Deprecate vs-tlv

Deprecate vs-tlv, Vendor Information TLV should be used instead.

Change-Id: Ie14a44647dcd83d09460061acce56143917eb54f
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-3778: Next Hop needs to be specified in each extension

Since each NextHop need to be specified for each extension,
we need to enforce users to register his corresponding handlers.
Thus a new registerNlriParser method is created with NexHop
handler and NextHop classes which are handled, as a new parameters.
Previous registerNlriParser method is deprecated.

Change-Id: I7aca6dbc679bf146e9333e7f2d2c9affb75808e8
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-4490: onTransactionChainFailed return null transaction when closing
Karaf, causing NPE.

Check if null transaction is received from  onTransactionChainFailed

Change-Id: Iece7abee96d7e4eb94960b173341ff2d56c8e170
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-4197: Use "revision-date" along imported modules

-avoid yang data modules version mismatch

Change-Id: Ifff049a580e0a536e78c935e1d40db8b598d50cb
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4438: When delete a route from the app RIB transaction chain brokes

When deleting routes from app RIB, transaction get broken, therefore
some routes keep stored in DS.
Fix by indentify type of modification applied under
routes in ApplicatioPeer and apply correct write transaction
instead of use 'put' with any of them.

Change-Id: Ia7ad615d5290ec4deed0cdadfcd0d0f64c99cc52
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Refactor BGP session

refactored attribute, parameter, method names

Change-Id: I9840f65d7d52637cdf4e063642281c26edb22e50
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

Sonar warning, refactor: AbstractNumericOperandParser

Change-Id: If19f82f959997f75c676bf8935117965f61ec4ae
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BUG-4328: Update BMP implementation according the draft version 15

1. Implemented route mirroring bmp message parser/serialize and wired up to Bmp monitor module thru bmp activator
2. Extended stats report bmp message to include type 9 - 13
3. Extended peer down bmp message to include reason 5
4. Added JUnit tests for route mirroring bmp message including both parser and serializer
5. Added Junit tests for bmp monitor handling bmp route mirroring message

Change-Id: I4dd8442b4cb1f08576ae0f51c10480e9f6ff2797
Signed-off-by: Jeff Liu <bigdataops@gmail.com>

BUG-4197: BGP OpenConfig API

BGP OpenConfig yang models as defined in https://tools.ietf.org/html/draft-ietf-idr-bgp-model-00
Defines yang data model for configuration and managing BGP.
Added "odl-openconfig-extensions" Yang data model to support missing AFI/SAFI

Change-Id: I1a59a1c36f6f81b94058cc201115174e41fdfc8b
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4364: data change counter transaction chain

to avoid logging spam

Change-Id: Ia59091f71edfb69d0fd3860086634112c4de0226
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
(cherry picked from commit e6cdc776146d60ff8c33c12eedda930d8bf03e4d)

BUG-139: PCE-triggered State Re-synchronization Procedure

Trigger resync
 - RPC Trigger resyng
 - Send Upd Message with SYNC Flag for LSP set to 1
 - RPC Trigger resync Lsp
 - Send Upd Message with an LSP object containing a PLSP-ID
   of 0 and with the SYNC flag set to 1

Change-Id: I5642eb57426df739858359c0c1fe004ca339ef98
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>