Move build-helper-maven-plugin declaration

Builder helper is useful in simple poms, where it can be used to
attach files. Move its declaration to odlparent-lite, so it is widely
available.

Change-Id: I84a235707b72287d7121c77ee3a0b7dd2958f965
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump sevntu to 1.35.0

https://sevntu-checkstyle.github.io/sevntu.checkstyle/#1.35.0

Change-Id: I2ccb96334c7b6911b3bf88ac36db407053f844ed
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Commons BeanUtils to 1.9.4

Release notes:
http://www.apache.org/dist/commons/beanutils/RELEASE-NOTES.txt

Change-Id: I4fa56e9ce439c770f21737570b1dbdfc61198119
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Silence license unpacking

License unpacking happens for every artifact we build, adding
some noise to the build. Suppress that noise.

Change-Id: I513e4b0cfe9aa31240bf7d8dc9bc3f4c1965e5dc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Akka to 2.5.24 and ssl-config to 0.3.8

https://akka.io/blog/news/2019/08/09/akka-2.5.24-released
https://github.com/lightbend/ssl-config/compare/v0.3.7...v0.3.8

Change-Id: Ifcc2479a39cbb904ff2d691ad6148899ca91545c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump netty to 4.1.39

https://netty.io/news/2019/06/28/4-1-37-Final.html
https://netty.io/news/2019/07/24/4-1-38-Final.html
https://netty.io/news/2019/08/13/4-1-39-Final.html

Change-Id: If67c1920f0c7982989de04b8c3adc829de763b5d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-pmd-plugin to 3.12.0

https://blogs.apache.org/maven/entry/apache-maven-pmd-plugin-version1

This bumps used pmd to 6.13.0:
https://pmd.github.io/2018/12/09/PMD-6.10.0/
https://pmd.github.io/2019/01/27/PMD-6.11.0/
https://pmd.github.io/2019/02/24/PMD-6.12.0/
https://pmd.github.io/2019/03/31/PMD-6.13.0/

Change-Id: I046d0fdac2beaa6b84bc591f448504027ee8c6f2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Upgrade jackson-databind for CVE-2019-14379

See https://github.com/FasterXML/jackson-databind/issues/2387 for
details.

Change-Id: I3a8a416bba7e72861512531a3a83d818daf6fd5f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fixup commons-codec upgrade

This adds missing overrides to karaf distribution, so that we do
not package duplicate versions.

Change-Id: Icb8b3a7b7d923f2e0cb3d9ce02f719e436dbc191
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump commons-codec 1.12 → 1.13

Release notes:
http://www.apache.org/dist/commons/codec/RELEASE-NOTES.txt

Change-Id: Ibcf6e1a6cd59a4341cad7a65ac1c8cbf7ceefb26
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump scala to 2.12.9

https://github.com/scala/scala/releases/tag/v2.12.9

Change-Id: I492c89dc7cf93211174946accfeaaeefa8edab25
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit f29ca446f8ab5e9c81af0f899e4e6550bd6544ca)

Skip checkstyle for module-info.java

checkstyle cannot handle module-info.java syntax, hence do not allow
it to touch those files.

Change-Id: I12d45daef31dea29d50159c249ed6e972d5a73b8
JIRA: ODLPARENT-201
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Drop modernizer back to Java 8

Modernizer produces a ton of recommendations to use List.of()
and similar -- which requires careful consideration, as we are
using ImmutableList.copyOf() all over the place and Java's version
does not offer a check for immutability.

This is a stop-gap until we figure out a way forward.

JIRA: ODLPARENT-201
Change-Id: I7037e6ef09f132129ac3b63145235eb6903961bc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add modernizer-maven-annotations

There are rare cases when we actually want to suppress modernizer,
this adds the annotations to do that.

JIRA: ODLPARENT-203
Change-Id: Ia1a28ac565b99f3a24c3e88b6320d6fb09885bb8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump spotbugs-maven-plugin to 3.1.12.2

https://github.com/spotbugs/spotbugs-maven-plugin/releases/tag/spotbugs-maven-plugin-3.1.12.1
https://github.com/spotbugs/spotbugs-maven-plugin/releases/tag/spotbugs-maven-plugin-3.1.12.2

Change-Id: I547f8e224553e0898b6810520aca2dcf989f8545
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Java requirement to 11

This bumps required JDK version and target versions to Java 11.

JIRA: ODLPARENT-201
Change-Id: I837f15f2bdb0d79f561fa2cae86cf8cf9a87806b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add odlparent-docs

This adds a proper aggregator for javadocs, so that we can ditch
the javadoc jobs.

Change-Id: I0bf15e5c0dae63a46d94b292686d46bfe11fa026
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enable modernizer-maven-plugin by default

This enables modernizer in all projects by default.

JIRA: ODLPARENT-203
Change-Id: I1053a29dd9578b454c1da4425b3cbe69867fc28c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove JSR305 artifact

We have moved away from JSR305 annotations, this removes
the dependency declaration, so that it does not creep back in.

JIRA: ODLPARENT-202
Change-Id: I8b3811af0d298edb2acdd0ed0588919f9e5f7ab8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 6.0.0-SNAPSHOT

This starts the next development iteration.

Change-Id: Id858b6a794e9ef5733e32c7ea5effb77a8a4ff45
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-javadoc-plugin to 3.1.1

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&version=12345060

Change-Id: I1950586a8774878eb7eab333680f0deac8d4cf66
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump triemap to 1.0.6

https://github.com/PantheonTechnologies/triemap/releases/tag/triemap-1.0.6

Change-Id: I3e77d1149de1459ee5312a4f066913c5d96534df
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update dependency check

This updates dependecy check to catch previous updates.

Change-Id: I47aec9a6d75dc796ea30b2fe1dde3ea45332d537
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Checkstyle 8.18 → 8.20

Release notes:
https://checkstyle.org/releasenotes.html#Release_8.19
https://checkstyle.org/releasenotes.html#Release_8.20

Change-Id: I1861930af1af7dc83c8b29cedc7c39adc99e9fe6
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump commons-text to 1.7

Changelog:
https://commons.apache.org/proper/commons-text/changes-report.html#a1.7

Change-Id: Icf6257d4fcc4777b60f664b7b4f4c608f9625434
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump spotbugs-maven-plugin to 3.1.12

There are no release notes, but the release seems to be about
dependency upgrades:

https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-3.1.11...spotbugs-maven-plugin-3.1.12

Change-Id: I3fe199c1fa71735da911bda23af01c3e038ea311
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add xmlunit-assertj

Downstreams do wish to use xmlunit with AssertJ, this adds
the corresponding artifact declaration.

Change-Id: I9f180c3c587a703660a7be8ec9ce18342fcf5fbb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump sevntu 1.32.0 → 1.34.1

https://sevntu-checkstyle.github.io/sevntu.checkstyle/#1.33.0
https://sevntu-checkstyle.github.io/sevntu.checkstyle/#1.34.0
https://sevntu-checkstyle.github.io/sevntu.checkstyle/#1.34.1

Change-Id: I6086f2aa1850ecae72aac1f7abf855debcbc46d9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 5.0.2-SNAPSHOT

This starts next development iteration.

Change-Id: I6e0cb57773a2b82ab3dbd28a259a6e6cb11f3ad9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Yet another odlparent-5.0.1 release note update

This reflects latest changes in NEWS.rst.

Change-Id: If226d9c1a7017cc0b3edb578640888373cbc0b5e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add modernizer-maven-plugin declaration

This adds version management and lifecycle binding for modernizer
plugn, which detects deprecated constructs. The plugin is not
enabled by default.

Change-Id: Iae803bb0fb76c8692364df8493bdcc1b607a688b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump PowerMock to 2.0.2

https://github.com/powermock/powermock/releases/tag/powermock-2.0.1
https://github.com/powermock/powermock/releases/tag/powermock-2.0.2

Change-Id: I9f9f8f6fb84eaab97bbc2b62c98ca49a677d8e0a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump jacoco to 0.8.4

https://github.com/jacoco/jacoco/releases/tag/v0.8.4

Change-Id: Ieeeabe9f8860dd8e169981b6268b06ab7a829110
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump jolokia to 1.6.2

https://jolokia.org/changes-report.html#a1.6.2

Change-Id: I56ebbfd239027a4939b4b60d490dac849e813169
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Upgrade pt-triemap to 1.0.5

https://github.com/PantheonTechnologies/triemap/releases/tag/triemap-1.0.5

Change-Id: I5114c840e0de901fc24334c58be53abc8320cffb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump xmlunit to 2.6.3

https://github.com/xmlunit/xmlunit/releases/tag/v2.6.3

Change-Id: I92c8a3173cc85c9e2ec2a77706f4c22da743c284
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update 5.0.1 release notes

This is another round of updates, now accruing enough changes
to justify a release.

Change-Id: I948f32a283ec322540aee191f1b5f29bdc5e025b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-checkstyle-plugin to 3.1.0

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223&version=12342397

Change-Id: Ife523280c58192a7e841e766de702c6ed350188a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-source-plugin to 3.1.0

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317924&version=12336941

Change-Id: Ieb82d95315f34e0aa9b9914538e5089e30e2278b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-jar-plugin to 3.1.2

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317526&version=12344629

Change-Id: I0a563e3d9f36c6b3b21599da7743097ed08d7790
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-compiler-plugin to 3.8.1

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317225&version=12343484

Change-Id: I832d539b87db880449f0beaf3353708d5c426dad
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-bundle-plugin to 4.2.0

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310100&version=12345047

Change-Id: I4533ecfcd58ae2074c1d6828a4900fa2768d2c4e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump archetype-maven-plugin to 3.1.1

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317122&version=12340346
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317122&version=12345450

Change-Id: If051e346bddc14df5ecece0ed105e66622c6ad8d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update maven-help-plugin to 3.2.0

https://blog.soebes.de/blog/2019/04/22/apache-maven-help-plugin-version-3-dot-2-0-released/

Change-Id: Ifb8fb07dc0c6859d3751c91bfbe962f16df52f16
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update odlparent-5.0.1 release notes

This sums up the changes made so far.

Change-Id: Ic611ee166327f2ab48e402899720e4680aa4fbd2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump BouncyCastle to 1.62

https://www.bouncycastle.org/releasenotes.html

Change-Id: I0c8435e049768ea9e03463ac5f8a1021b49d48c8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump xbean to 4.14

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310312&version=12345220

Change-Id: Idfdfc7b5a02a6bbe837ac753bfc08e5dbe64f927
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump jolokia to 1.6.1

https://jolokia.org/changes-report.html#a1.6.1

Change-Id: Iaee01bb0f0f83b3a70236061f08d17d10c311e6d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump jackson to 2.9.9

https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.9.9

Change-Id: Id28e7b87fb2687c8c5458c48b310589c56dacdaa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add Caffeine

Caffeine provides significantly faster caches while maintaining
pretty much the same API. Add it as odl-caffeine-2, along with
its Guava compability bridge.

The feature is structured to depend on odl-guava, so that checker
and errorprone-annotations dependencies are still provided by
odl-guava.

Change-Id: Ia0f8bbdf82113ce3bc8424998cc06891993d3277
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump netty to 4.1.36

https://netty.io/news/2019/04/17/4-1-35-Final.html
https://netty.io/news/2019/04/30/4-1-36-Final.html

Change-Id: I34d0c7f7f3ddc79dd97a3f83b21b86e7409ebfca
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump akka to 2.5.23

https://github.com/akka/akka/releases/tag/v2.5.23

Change-Id: I4191db97f4c1fe91b57b1ab4669242d1e161f0de
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Pin pygments to 2.3.1

pygments-2.4.0 is breaking with python-3.4.9, pin them to 2.3.1.

Change-Id: I3f1b3f5013338cfd2aa573aab0c411d294fb0eb0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump surefire/failsafe to 2.22.2

This fixes just a single issue with JUnit5:
https://issues.apache.org/jira/browse/SUREFIRE-1614

Change-Id: I85461616cdc6dc3075848e1a6a2a7a7100159800
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Commons Lang 3.8.1 → 3.9

Release notes: http://www.apache.org/dist/commons/lang/RELEASE-NOTES.txt

Change-Id: Ifb03a0c84a5852b134b78d8776c66e004a545fec
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add a dependency-version-bumping script

Change-Id: I7659eb6a045a074039ee2f3a6985f4aec0afd3eb
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Import the Jetty BOM

This is well-defined and only specifies Jetty artifacts.

Change-Id: I09d9dfa83a85c182f9d005ebe8c319af9586f70d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump scala-parser-combinators to 1.1.2

https://github.com/scala/scala-parser-combinators/releases/tag/v1.1.2

Change-Id: I8d90620c7de23ee308e7fb0d76199e6dc0da3fe5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump reactive-streams to 1.0.2

https://www.lightbend.com/blog/update-reactive-streams-102-released

Change-Id: I9c515c487bead630cc8c55364f341b14a5aa9d27
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump akka to 2.5.22

https://akka.io/blog/news/2019/04/03/akka-2.5.22-released

Also align typesafe.config and ssl-config:
https://github.com/lightbend/config/releases/tag/v1.3.3
https://github.com/lightbend/ssl-config/releases/tag/v0.3.7

Change-Id: I4c119e9b928f05e4de90452ffd443eddee1babd3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump xtend to 2.17.1

https://www.eclipse.org/xtend/releasenotes.html#/releasenotes/2019/04/03/version-2-17-1

Change-Id: I930ad4010e3012ae04bbc4e443f39fde5f5d5151
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump XBean 4.12 → 4.13

Release notes:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12344253&projectId=12310312

Change-Id: I8c2cac968b17fd88814051d12520237031c7a9ca
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Sevntu Checkstyle 1.32 → 1.33

Release notes:
http://sevntu-checkstyle.github.io/sevntu.checkstyle/#1.33.0

In particular, this allows ForbidCertainMethodCheck to be used with
lambdas (see https://git.opendaylight.org/gerrit/73686 for an
example).

Change-Id: Ied43e31d6db228f2c70988047d20b8a63ee10f37
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Mockito 2.25.0 → 2.25.1

Release notes:
https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md#2251

Change-Id: I1967cee18a8b6385cb410406c0fdc1f7f24bd7e6
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump asciidoctorj-diagram to 1.5.16

No upstream changelog that I can find...

Change-Id: I7e33b72ad115f99674fb37ac18c6cb182765de76
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump maven-plugin-plugin to 3.6.0

https://blogs.apache.org/maven/entry/apache-maven-plugin-tools-version1

Change-Id: I88fd468d38730bd5edcf1b3e22a3109d613c50b3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add a script to fix JSR-305 dependencies

This adds the jsr305 dependency in modules which need it but don’t yet
have it.

Change-Id: Iedc9d8350b4bea0ee9eae709c033ef35a5796658
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump versions to 5.0.1-SNAPSHOT

This starts the next release.

Change-Id: I1d2dfd00138445130c0683cd8abb3c57e17a88d5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update release-notes

We have delivered the fix for ODLPARENT-130, reflect that in the
release notes.

Change-Id: Id9fc2b315db9d4358469d64244fa848ee3aaae58
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove features-test's exclusions

opendaylight-karaf-empty has three additional dependencies, which
need to be present in local repository when we run SFT. This would
normally be achieved through transitive dependencies, but it does
not work due to features-test exclusion of these.

This was due to infrautils using features-test and also requiring
no classpath duplicates, hence single-feature-parent needed to
explicitly name them -- which broke when we added BouncyCastle
framework extensions and did not add them to single-feature-parent.

This has changed since then, though, and infrautils is using
bundles-test-lib, which does not bring the duplicates, and thus
features-test is used exclusively by SFT.

Therefore remove the exclusion and duplication single-feature-parent,
restoring sanity.

Change-Id: I167bae2965706406b5040a699929963c66e59e31
JIRA: ODLPARENT-130
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update dependency on OSGi compendium

The artifact name changed and we are getting compendium populated
at 5.0.0. This changes to using osgi.cmpn instead.

Change-Id: If594ed56ad9cfa91b1e03b4778ea75c138bf1a64
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

opendaylight-karaf-resources needs framework-ext

The build order is important, as we are running populate-local-repo,
which warns about them not being available during staging build.

Change-Id: I96c3a1aee601864d444b5d5ba894868c1d57dcee
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Integrate features-akka into features-odlparent

We do not need a separate feature repository for akka, just
integrate it into features-odlparent.

JIRA: ODLPARENT-195
Change-Id: If03312353506d8b83e4b9350ab83433bc8dadcaf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add odlparent-5 release notes

This populates release notes for 5.0.0.

Change-Id: I49a26fe1f70e6a4f7a4a9e2b5d382e48f149d175
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump maven-javadoc-plugin to 3.1.0

https://mail-archives.apache.org/mod_mbox/maven-announce/201903.mbox/%3C6064d830-474c-4b43-afef-99502c3a305a%40getmailbird.com%3E

Most important is the javadoc-links fix.

Change-Id: I5b9e270a39c67248b89b378476c870174c769a1a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Guava to 27.1

https://github.com/google/guava/releases/tag/v26.0
https://github.com/google/guava/releases/tag/v27.0
https://github.com/google/guava/releases/tag/v27.0.1
https://github.com/google/guava/releases/tag/v27.1

Change-Id: Ieb3ab9c1a94cb31a7c7d7d36ea7cf22c838547f1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Allow multi-version builds

Since we are defining maven.compiler.* properties, there is no
point in hard-coding that in plugin configuration, as it will be
picked up automatically.

When we are running with JDK9+, also define maven.compiler.release
to pass --release flag to javac, which fixes cross-compilation
warnings about boot class path -- see JEP-247 for details

Since the version configuration is driven by properties, downstreams
now can easily override the defaults and use that to create JEP-238
jars.

Change-Id: I36e7aaa857b91f1d68eac800c275306325a96e0f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Allow javadoc links to be opted-in

Some artifacts need javadoc links to be activated irrespective
of the command-line. Property activation does not work, as it binds
to a system property, hence it cannot be activated from a downstream
pom.xml.

Switch activation to check for odl-javadoc-links-optin file being
present.

Change-Id: I9d9d73b8e264659bacd6377301f4a7751b92d170
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove superfluous junit API link

junit.org link is the right one, drop the obsolete one.

Change-Id: Ieee17229caa1d26d69b19e9b62596dafb3b1b507
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneeded dependency

odlparent already pulls in junit, there's no point in bundle-parent
doing the same.

Change-Id: I67f43f49ed0792d8484ec878f8ee35029bd2a275
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump spotbugs-maven-plugin to 3.1.11

No release notes around, only list of changes:
https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-3.1.8...spotbugs-maven-plugin-3.1.11

Change-Id: Iefab2b724e7969b9e7d075b7f970910b4abe62a1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix log4j configuration

We are missing the strategy name, which means SFT is blowing up
downstream. Also max parameter specifies the maximum suffix, hence
we would end up with nine files.

JIRA: ODLPARENT-153
Change-Id: I8a12a2ded2d5ad306926016df98bc0b3e42a66f5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make javadoc HTML5 support an opt-out feature

Our long-term goal is to support HTML5 javadoc, which is not supported
by our current JDK8 tool chain, but is available with JDK9+.

JDK9+ allow fallowing back to html4 with the appropriate option, but
this option causes JDK11+ to emit a warning.

The transition to HTML5 should not be too hard and we want migrate
seamlessly while still allowing downstreams to defer the migration.

This patch makes the -html4 profile conditional on the existence of
odl.javadoc.html5.optout file in maven project root directory, thus
achieving the goal of not emitting warnings on compliant projects
with newer toolchain.

Change-Id: Ida91e9ffbe74afaac2a2edd43e066e57f73991a4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump ThreeTen to 1.5.0

Changelog:
https://www.threeten.org/threeten-extra/changes-report.html#a1.5.0

Change-Id: Ie99309c56e688daceddfbe074d60750997ffce80
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Xtend to 2.17.0

Changelog:
http://www.eclipse.org/xtend/releasenotes.html#/releasenotes/2019/03/05/version-2-17-0

Change-Id: I8ea02c12b0097111bda27bb9b72c0bc80a94ea0d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Immutables to 2.7.5

Changelog: https://github.com/immutables/immutables/#changelog
(nothing for 2.7.5 though).

Change-Id: I3e67a710e036405a5256756954efd6a01d157047
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump SpotBugs to 3.1.12

Changelog:
https://github.com/spotbugs/spotbugs/blob/3.1.12/CHANGELOG.md

Change-Id: Iadbfa71fd5665421e0bda574ae3110cd3185ca95
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump h2 to 1.4.199

No release notes, but this fixes a number of regressions in 1.4.198;
see https://github.com/h2database/h2database/issues/1778 for the
discussion leading to the release.

Change-Id: I39f1f0ac4c5f5ca98a3aef7a5597a483532b2877
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Error Prone to 2.3.3

No changelogs; they would normally be on
https://github.com/google/error-prone/releases/tag/v2.3.3

Change-Id: I5d1409e7011ba8c6fdad0171f00abdc3f5a8a225
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump asciidoctorj-diagram to 1.5.12

No upstream changelog that I can find...

Change-Id: I2dbdf1c72adbb916639113fe67b2e0f8a31784a1
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump netty to 4.1.34

https://netty.io/news/2019/03/08/4-1-34-Final.html

Change-Id: I4ced054420ebca6897d7bf240c745684ab8935a3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump karaf.log size to 64MiB

We can log quite a chunk of messages during startup, bump our log
size to 64MiB, so we do not have to reassemble logs.

JIRA: ODLPARENT-154
Change-Id: Icd2ffccc8d11f6c2399162442144eec936d3e7b7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump checkstyle to 8.18

http://checkstyle.sourceforge.net/releasenotes.html#Release_8.17
http://checkstyle.sourceforge.net/releasenotes.html#Release_8.18

Change-Id: Iddb56f43cc049f36b04a20c5c9ad668fa4fdaccb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove BLACKLISTED_BROKEN_FEATURES

Since we are generating features and testing only individual ones,
there is no point in keeping the blacklist around, as features which
need to be disabled can just define sft.diag.skip or disable testing
completely.

JIRA: ODLPARENT-58
JIRA: ODLPARENT-80
Change-Id: I4ce7fbca7a190571ee650cdedd3fc9a955ffddcf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Upgrade hamcrest to 2.1

https://github.com/hamcrest/JavaHamcrest/blob/master/CHANGES.md#version-21-21st-december-2018

Change-Id: I6a1bfc069aeb7444cec0e24115ca8a6f4a9fbb18
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump mockito to 2.25.0

https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md#2240
https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md#2250

Change-Id: I0f1cd702766b5a81d3c1dc4979a9705482cccf4c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump javassist to 3.24.1_GA

https://github.com/jboss-javassist/javassist/releases/tag/rel_3_24_1_ga

Change-Id: I1a7816e1e9a1f841e85a0bcc0c3e11e64455955e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump truth to 0.43

https://github.com/google/truth/releases/tag/release_0_43

Change-Id: I3556aa619b8042fbabcce5fdef024c0d28ecef58
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not pull in JSR305 by default

The migration to findbugs:annotations is actively hurtful to us,
as JSR305 is clashing on javax.annotation package with JEE
annotations.

This patch removes findbugs:annotations, making them a banned
dependency, and instead defines spotbugs:annotations and
findbugs:jsr305.

spotbugs:annotations replaces findbugs:annotations as the default
dependency.

JIRA: ODLPARENT-198
Change-Id: I3e113fb3af3f2cdd6e4cd6b22ffc0dcac5efbcf9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

bump bug-pattern from 1.4.0 to 1.4.2

Bumps [bug-pattern](https://github.com/KengoTODA/findbugs-slf4j) from 1.4.0 to 1.4.2.
- [Release notes](https://github.com/KengoTODA/findbugs-slf4j/releases)
- [Changelog](https://github.com/KengoTODA/findbugs-slf4j/blob/master/CHANGELOG.md)
- [Commits](https://github.com/KengoTODA/findbugs-slf4j/compare/findbugs-slf4j-1.4.0...findbugs-slf4j-1.4.2)

Change-Id: I2ffdcb38e3afcc81539058db1d690a9ba4c5a936
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>