Ignore deb build dir in coala/git

Change-Id: I2ea1f01fba0228e31a3926a28c7a5ddaa58f28e3
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Rename pkg-specific build scripts to libs

Start of refactoring to consolidate and test more packaging logic.

Change-Id: Ia9f94290648f78c3e0188f3310c9146fbd60072d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Fix Coala Jinja linting, errors

Use correct paths to Jinja2 templates, fix errors now identified.

Change-Id: I16205e18df4405cc26bfc6f68333aa7c6591a92b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Refactor packaging Vagrant env

Change-Id: Ib4a3dd05b681a9dae92e8ffb28823ff89344889e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Common Vagrantfile for local testing

A single vagrant file makes sense post refactoring than two vagrantfiles
in each deb and rpm directories. The commit also updates debian box to
the new stable 'stretch' version.

Change-Id: I62543f02ebd768540593a78d5ce644187b3c42a8
Signed-off-by: Alok Anand <alok4nand@gmail.com>

Rename pkg helper logic vars->lib

This module started off containing only logic for getting build
variables, but now it's used as a generic packaging logic library.

Change-Id: Iaf953514a892a39d0fb801eedb41eec0d136f889
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add .repo files for Nexus-hosted 7/8 RPMs

Repo config files that will install ODL Nitrogen and Oxygen from ODL
Nexus repos.

Change-Id: I74b28ab892af2a27c67542407ddb97eb69480806
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Refactor package building CLI

Use subparsers to get correct package building CLI behavior. Fixes
issues like:

* Major version should be required when using latest-snap
* Download URL should be required for new-build but not latest-snap
* Minor version shouldn't be accepted

Also simplifies build definition-building logic that consumes CLI args.

Change-Id: Ie1c71b1828fff592aec74da6e9acfdbe0ed894ee
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add gitignore rule for tarballs/zips

Change-Id: Ic7c09202a86d23d568c330569d466470875e83f4
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Ignore zips in Coala linting

Change-Id: I79fdae1fd71fa9ac75145f31b67999abe5a9175e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Ignore extracted distros in Coala linting

Change-Id: Id12a58aa228f31c6f88b79242767ed6f4651bd27
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Fix fn name/args to make RPM snap builds work

Also add unit tests to catch basic issues with this fn.

Change-Id: I3ee18483b7bf6e53462789d6b169dcc730039ea0
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Fix permissions for zip-build RPMs

Python's zipfile.ZipFile.extractall doesn't preserve permissions.
Long-standing Python bug with a proposed patch, but still isn't fixed.

Use a subprocess to call system unzip tool instead.

Change-Id: Id330cd34fd61b1b4e619aa5006d96b43e4d4db5b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add pkg support for Karaf 4 not having codenames

Karaf 3 distros had codenames our version parsing logic expected to be
able to extract. Starting with Nitrogen there are no codenames.

Also note that starting Carbon SR1 we dropped SR versions in codenames,
but the logic already happened to handle this.

Change-Id: I0b3bac64abd1290d5d3012e73935b76d1a913a8a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Support Karaf 3 and Karaf 4 distro prefixes

Karaf 3 used distribution-karaf, Karaf 4 uses karaf. Modify RPM building
logic to support both.

Karaf 4 snapshot builds should work after this change, but Karaf 4
autorelease builds still fail as they don't have the expected codename
tarball version component.

Change-Id: I03c789e530205ded2a948c99dd4cdcb7b6c16254
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

opendaylight.service Restart=on-failure

https://bugzilla.redhat.com/show_bug.cgi?id=1479292

Change-Id: I3ae058a9581c642c314aaf7bac4fcb17a40bb771
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Make version extraction logic more generic

Turns out just making the match less strict fixes both issues with
multipatch-test Nexus repos and Karaf 3/4 distro naming.

Change-Id: Icc5272cb0c9411db51cf343681d24093363d39c4
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Run packaging unit tests in tox, verify job

Adding package unit test to tox will cause them to be run as part of
regular verify jobs, which should give insight and keep them working.

Change-Id: Iedef7db355ad0399ff9b7e714a2fff3cbff9f8ef
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Update pkg unit tests for new path, add tests

Change directory of packaging unit tests to work after recent RPM/deb
consolidation refactoring. Also add many tests for proper coverage.

Change-Id: I693c17b19a33a4b2eb7bb7ffbcb1e4c7b3eb06fe
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add support for building RPMs from zips

The RPM specfile logic requires a tarball, but this allows us to accept
links to zip distros and repackage them as tarballs.

This is useful because the multipatch-test job only publishes zips.

Change-Id: I361dd43fc722e675bd90bb69a50b7b2d8d532b82
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Fix systemd unit file URL for new dir structure

Recent refactoring changed the path to this file, update accordingly.

Change-Id: Iabe11c826da9ce3663e262fae6a5065565712b38
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Update RPM repo cfg file URL

Recent refactoring in Int/Pack changed the path, update accordingly.

Change-Id: Ifcfad2ebf5f413987109bb2cdd19830f3ede80f5
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Always use current datetime in pkg changelogs

Don't accept a changelog_date param in packaging build logic. Instead,
always automatically find the current datetime and format it
appropriately based on package type.

Now that we're typically building from CI, and not supporting static
builds defined in var files, there's no valid usecase for using a
changelog datetime other than the current datetime. Keeping it just
adds complexity.

Also extract datetime formatting logic to a helper function.

Change-Id: I041f8852a340ff554934a274d3523cc27fcfc464
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Make a common .gitignore file

Change-Id: If00e8b16d7707d2ae8f2da13aa61cd3b64b9dd98
Signed-off-by: Alok Anand <alok4nand@gmail.com>

Remove YAML logic from DEB cache and templates

As the YAML logic has been removed from building DEB packages these
functionalities are no more relevant.

Change-Id: Idaa1949bdf5023700aae7a0bd56510ee0c563155
Signed-off-by: Alok Anand <alok4nand@gmail.com>

Move rpm & deb build logic into packages/

This commit organizes deb/ and rpm/ into packages/ . build.py, vars.py,
requirements.txt are moved into the base of packages/ to work with the
refactored logic.

Change-Id: Ife0b6a1382ce906a18d539d132569158860620fa
Signed-off-by: Alok Anand <alok4nand@gmail.com>

Build deb's using common build.py

Refactoring aims at creating a common entry point for both rpms and debs
building logic. Using a common build.py, debain will enjoy the same
advancements made earlier in rpm's build logic.

Change-Id: I038e40c7486cc8243feec9a7bb1dc407018f9b41
Signed-off-by: Alok Anand <alok4nand@gmail.com>

Move rpm/requirements.txt

requirements.txt in the base dir will serve a common requirements file
for both rpm/deb building logic.

Change-Id: I64c3da2be9997fa344b62bdded87bbb5aa9cbc6b
Signed-off-by: Alok Anand <alok4nand@gmail.com>

Remove YAML logic from RPM's spec & cache

As the YAML logic has been removed from building RPM packages these
functionalities are no more relevant.

Change-Id: I67c393bd02e02d7248acb022fc16363c15f6bab6
Signed-off-by: Alok Anand <alok4nand@gmail.com>

Update RPM spec file to use `java_version`

`java_version` variable is used by deb to provide java version required
as dependency for ODL package. This patch update RPM build logic as well
as spec file to use the variable `java_version` instead of hard coded
value.

Change-Id: Iac74fb751d3e6fedfea25badc5bdcdb7e498a66a
Signed-off-by: Alok Anand <alok4nand@gmail.com>

Add `get_java_version` func

The function returns the `java_version` variable which helps packages to
determine the needed version of java dependency.

Change-Id: Ifbe044be565ef597e42efa529858e509defd403f
Signed-off-by: Alok Anand <alok4nand@gmail.com>

Change `rpm_release` to `pkg_version`

The RPM build logic uses a var called rpm_version The deb uses a more
generic name, pkg_version. Changing `rpm_release` to `pkg_version` makes
it easier to have consistent names.

Change-Id: Idb2eaa824f78222353c62755d25186ec42b761fa
Signed-off-by: Alok Anand <alok4nand@gmail.com>

Refactor snapshot url fetch logic

The logic to build snapshots is a key difference between rpm and deb
pipeline. `build_rpm_snapshot()` is essentially snapshot url fetch logic
plus `build_rpm()`, refactoring this logic makes it simple to add
snapshot build feature to deb pipeline.

Change-Id: I1369df471d546c4fdd55425830cdb2b86dda5bf9
Signed-off-by: Alok Anand <alok4nand@gmail.com>

Relocate `extract_version()` & `get_sysd_commit()`

The functions named above are useful to collect variables for both rpm
and deb building logic. The common build.py entry point can call these
functions from vars.py

Change-Id: I05fac7b6f09693233ca54a317af2ea7323814344
Signed-off-by: Alok Anand <alok4nand@gmail.com>

Relocate entry function of `rpm/build.py`

RPM build script can be used as a reference for building
a common entry point for both rpm and deb build pipelines.
This commit also creates the new common entry point in
`packages/build.py` for further refactoring.

Change-Id: Idee82deced213ce5963587eb376c19e2c5c2e4ac
Signed-off-by: Alok Anand <alok4nand@gmail.com>

Remove submodules removed by I57f71982890f84ba4adc

The patch I57f71982890f84ba4adc00077963961836ed6799 removed some
submodule configuration but did not actually remove the submodule. This
breaks projects like docs which pulls in packaging and tries to
recursively download submodules but the reference is now missing.

Change-Id: Ibfc1f7b314966ed67743596f7157f5c8ff213f8e
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Default to headless Packer builds

Builds in CI don't have X and fail with obtuse errors when this is true.

Change-Id: Id6ada81d7cd35a21d0def28744f0a1086ad56f64
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Remove old ansible/puppet-odl submodules

The ansible-opendaylight and puppet-opendaylight projects have been
imported into ODL-managed repos under Integration/Packaging. Remove the
old git submodules referencing their old GitHub repos.

Change-Id: I57f71982890f84ba4adc00077963961836ed6799
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Make Packer docker_repo vary by OS

We have DockerHub repos opendaylight/odl for CentOS (main OS) and
opendaylight/fedora for Fedora. With the docker_repo var in ODL var
file, it required a manual `docker tag` to push Fedora images to the
right repo. Making it vary by OS is more correct, avoids this step.

Change-Id: Ibcdfa2d509427652ac6096104e883316c2c54905
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Use new become syntax for Packer Ansible provision

The old `sudo: yes` way to do Ansible provisioning as root is
deprecated, throws a depreciation warning.

Change-Id: I4b530fa68aab234c3af21eec504369eb30128fee
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Remove old Packer OS versions

Debating if should also remove old ODL versions, but I have been
updating them with new OS releases so thinking no for now. Definitely
don't need old OS versions though, no plans to use them again.

Change-Id: Ic0836fa4a279f9ec3920e7dc0f265cb29168e8d1
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Update packages at end of configuration

We already do a yum/dnf update at the start of the provisioning in the
Kickstart scripts, but by the end of the process there are additional
packages that should be updated.

Change-Id: I48d38aac680805894a9a21850206d57731a6bd38
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Use Fedora 26 default in Packer Vagrant helper

This Vagrantfile is just for testing built boxes, but as we're now
building F26 for new images should use that as default.

Change-Id: Icc16ab83b36acdee21b70665707cb1fd34ba7f0e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Fix various age-induced Vagrant tutorial errors

* Update tutorial Vagrant boxes to Fedora 26
* Remove now-unnecessary SSH config fix.
* Update path of wireshark file
* Update version of ODL installed in L2Switch tutorial
* Remove old doc link

Change-Id: I3d84c5b60714ec62d2d3f5ec5c194d63288bcb5e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Use ODL-managed ansible-odl repo in Packer builds

Explicitly telling ansible-galaxy that the SCM for Gerrit is git works
around the problem described in #61159 and the upstream issue.

https://github.com/ansible/galaxy-issues/issues/277

Change-Id: I08eb57a579d06cbad589ef721cb82ec41c31415e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add Boron SR4 Packer var file

Change-Id: Ib7881afa82b569d9672b25eb95b7857df7e07c09
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Use new ODL ansible-opendaylight repo in Packer

Using the GitHub mirror of the ODL-hosted ansible-opendaylight repo
because installing roles with ansible-galaxy from upstream repo fails
with what seems to be an Ansible Galaxy bug (reported upstream).

https://github.com/ansible/galaxy-issues/issues/277

Change-Id: I62a0e37dde21b62e5eb03654a8c98381d7287d1f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add Fedora 26 build support

Change-Id: Ia134a7f65a1a5a8350722ee0c9d6bcc904092322
Signed-off-by: Sri Sanketh U <sanketh.uppalapati@research.iiit.ac.in>

Add Carbon SR1 Packer var file

Change-Id: I7e93767adbe6a45e1825e3c132a268fe9ef4479b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Remove deprecated rpm_repo_file ansible-odl param

Change 60815 to ansible-opendaylight made this var unnecessary.

Change-Id: Ic6c15e9909babb8d92a780e3bfe7ff3d6e7ca428
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Remove Packer ssh-"fixing" logic

This logic was adding because of a problem with upstream Fedora boxes
that seems to be fixed now (SSH doesn't hang forever without this). Also
this config now breaks because the file it's editing doesn't exist.

Change-Id: I9adb10f5fea7f47d3b4ee95549839c7fd18a0ff1
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add example RPM repo configs for ODL Nexus repos

Add .repo files that will install RPMs from each of the new RPM repos
hosted on ODL's Nexus.

Not adding .repo files for release repos yet as there are no RPMs in
them and trying to install from them errors out.

Not adding 7-devel repo because there are no Nitrogen builds in it yet
and trying to install from it errors out.

Change-Id: Id09048c837d80bf197dde8f2b1fa7ba25c8e93cb
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Remove old instantiations of spec template

We are mostly using Jenkins jobs to build RPMs now, so we have moved
away from keeping the spec files that end up getting wrapped in RPMs.

Change-Id: Ib8888d0d114e1eeaa72e22ab5d767f05c40db266
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Ignore spec files built during RPM builds

When building RPMs locally, the spec template is populated and rolled
into the RPM. Ignore the populated templates.

Change-Id: I0c7c9c0ecefb5d47f12a6435b82dadb700d4a0f4
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Require Java >=1.8 for RPMs, vs current >=1.7

All currently supported versions of ODL require Java 1.8, so make it a
hard requirement in the RPM spec file. Currently installs always happen
to pull down 1.8, but we should force it.

Change-Id: I15a765ff3305de5a9ee6db0af548590a6c3bc37f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Update service node image for new base

Moved build collateral into build/ dir. Updates to build files to
reflect new systemd-based container. Added connect_container_to_network
to create veth pairs and bind container to Linux beidges on the host.
Modeled service node files after upstream compute node files.

Change-Id: I3b662a801403f7d25dd134b3281d204d621ab41b
Signed-off-by: Matt Welch <matt.welch@intel.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Update compute build & run for new base

Moved build collateral into build/ dir.
Updates to build files to reflect new systemd-based container.
Added connect_container_to_network to create veth pairs and bind
container to Linux beidges on the host.
Updates to local.conf to enable instance VNC console and use ODL by
default.
Added restart script that can usually be used instead of start.sh.
Updates to run script to reflect new systemd-based container.

Change-Id: I6e3f2d184a222cdb5ae74b2c221b0f132ae47c62
Signed-off-by: Matt Welch <matt.welch@intel.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add necessary iso_checksum variable

Change-Id: I19fe8ca357b7a596896e0004f4cff3d3db56c830
Signed-off-by: Sri Sanketh U <sanketh.uppalapati@research.iiit.ac.in>

Add necessary iso_urls variable

Change-Id: I78116a45b7c02937fd2db714071adf4f2d88d057
Signed-off-by: Sri Sanketh U <sanketh.uppalapati@research.iiit.ac.in>

Add Carbon SR1 example RPM repo config

Change-Id: I2094df3add1b805b7a948e7c5f756f45f29829a7
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Fix typo in 60-release example RPM repo config

Just effected the name of the repo, still worked as expected.

Change-Id: Icca37a75ac4fc7ad6d7cb1c1babdb13c309ee6eb
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

enable building of s3p/systemd base container

Build script and Dockerfile to build systemd base container.
Compute and service nodes will be based on this image (FROM).

See https://github.com/matt-welch/docker-devstack/tree/master/systemd
for development history.

Change-Id: I6ff5f8520ae889df81dccac12bf35f3995e5cbd0
Signed-off-by: Matt Welch <matt.welch@intel.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Remove existing/YAML building logic

The building logic is moving towards automated
vars collection and is triggered by Jenkins
jobs.Using old list of builds configs makes it
difficult to refactor a consistent interface for
both rpm and deb piplelines.

Signed-off-by: Alok Anand <alok4nand@gmail.com>
Change-Id: I0cf19c21f2417ce915c850fe4861fe40653f4714
Signed-off-by: Alok Anand <alok4nand@gmail.com>

Remove unnecessary docker_repo variable

Change-Id: I74dfd7f6a06ba37554d5850810a47657c8dfbcf8
Signed-off-by: Sri Sanketh U <sanketh.uppalapati@research.iiit.ac.in>

Add WriteGoodLintBear support

Fix WriteGood errors where appropriate

Fix readability, inheritance issues in coafile

Change-Id: I7c778e391c05b20326edc04c7a102864dc38ee8a
Signed-off-by: Sri Sanketh U <sanketh.uppalapati@research.iiit.ac.in>

Add Boron SR4 example RPM repo config

Change-Id: I0239d02c2192a42b347d170d9843e03a4d06a814
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Various minor docs fixes, link additions

Change-Id: I8c884c85afbe4113910598e6f01969b23e09ff23
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Major docs update

Change-Id: I56396daabbdbe213dee61992533335be38ff70d0
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add Boron SR3 Packer config

Change-Id: Id035a7c23ddbf2b76845c4dde81e1aa30cdffc47
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add Carbon Packer config

Change-Id: I79a22f3501e1298398142e4d7a1ede957309316b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Update Packer Vagrantfile for new versions

Also refactor with better loops to be more clean.

Also remove F24 and Beryllium entries.

Change-Id: I2d137f68643b2c58c80c2781a95663051fba85a8
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Fix new shellcheck errors caught by latest version

Main new shellcheck rule is related to exiting if cd commands fail. Add
or conditions to exit if they do, per recommendations.

Also make a few shellcheck ignores more explicit.

Change-Id: Ic8e290c1a75891b47b7aa874fe9cff0c3e9fd720
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add example 7-testing RPM repo config

Change-Id: If57b93dde2430a205d7a3c1a26b727f41000c5d7
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add 6-release example RPM repo

Change-Id: Ic849ca23a4a658d336f2580857ae4d92635c94a2
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add vars for Carbon's .deb build

Change-Id: Ia3fed1e209a780803970c320610511964886413b
Signed-off-by: Akshita Jha <zenith158@gmail.com>

Pin requests to <2.16

The new requests library pulls in a chardet dependency that is in
conflict with coala packages. Pin the version of requests to ensure
we're pulling in a supported version.

Copied change by Thanh.

Change-Id: I345f37da5b96f40da5dce077635b6e85bb8638ff
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Pin coala to 0.11

coala-bears 0.11 just released 5 hrs from this patch author date. It
breaks the build because we were pinning coala. It seems coala and
coala-bears versions must match exactly so pin both versions for good
measure.

Change-Id: Ib6c903140895077c0053666cd4203aac88c220a2
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Pin coala version to <0.11

I seems the new 0.11 version breaks us due to dependency conflicts.
Let's pin the version and migrate when we have time to troubleshoot.

Change-Id: I9e3b696746fcbc87e11c413f31096623e5ed0c22
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Re-add apt-get update to deb/Dockerfile, per OPNFV

OPNFV Fuel is telling me removing this broke them.

https://build.opnfv.org/ci/view/fuel/job/fuel-build-daily-master/2234/console

Change-Id: I165c272d619b21f683d906a14c6412b6ab9a2c71
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Allow long links in git commit messages

Change-Id: I6f5f6737fdc375dff7d4cb80fdca571fe36dac1d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add Boron SR3 example RPM repo config

Change-Id: If2f3929fe8876ecbf7c48eafa069d2b15c734a18
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add Dockerfile linting, fix errors

Major refactoring to basic CentOS and Debian Dockerfiles.

Change-Id: Icf5f48b3de5337f9a88ea276570618f9899b3077
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Enable XML linting

Change-Id: I1a90ebcced045741338802e7735705fc63104ce8
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Enable spacing linting, fix problems

Change-Id: I711d6ebcebfc053f7919b5a500c09a7ce27e16e6
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Enable RST linting, fix problems

Ignore toctree, Sphynx thing not RST so linter can't handle it.

Change-Id: I88e9c5176f7629f9e929f2c8e156dfbc7685a403
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Enable Markdown linting, fix errors

Also use ApplyPatchAction for all Coala Bears.

Change-Id: I0f1646de0e8676cc227175c4804a9a29944f25ce
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Refactor coalafile, add stubs for future tests

Also do Coala dep installs in one line for better speed and install
additional dep of MarkdownBear.

Change-Id: Iab9ac746378b9ef4516e94edbadc537b1536a4c7
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Fix all Python import ordering

Change-Id: If156ee3e0cc753494616e17ca971f54e56df5ab1
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Enable JSON linting via Coala, fix JSON errors

Change-Id: Ic685c192c1f00b85cac1ea844d1b9538dd8929df
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Enable shellcheck linting, fix problems

Change-Id: I5043e5b2c700dab5de82ff37c698dc5dcf17e2cf
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Fix node dependencies to work inside tox

Change-Id: I7eb0641d39db8eaaa5488a1046cbf4d6493fa891
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add back ApplyPatchAction

Accidently removed by https://git.opendaylight.org/gerrit/53816

Change-Id: I08891b7c9dd7e75e2ed9d7f4501c7baa7ce4a782
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Enable Coala PEP8 linting

Change-Id: I46b343d205ad2f39ede250fba14f871fbcf9afbb
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Fix RPM extract_version unittests

Update to use current autorelease examples, fix PEP8 violation.

Change-Id: Iec782dddd9f86e1a3b672cf46c8d07709ea49fc7
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Enable YAML Coala linting, fix problems

Change-Id: I7bc73817311879dfc2bf83f0bb8915094cadc7d0
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Use latest Int/Pack repo commit hash as sysd_commit var

This adds logic to use the latest Int/Pack repo commit hash as sysd_commit
var unless passed by param.

Change-Id: I7b1e703648fb2eee6b8ed962532126276f7a12d9
Signed-off-by: Akshita Jha <zenith158@gmail.com>

Add coala linting to tox

Ignore most checks for now. Will enable as things are fixed.

Change-Id: I2b9bd627277ef04e6d2f72d07072c5448f1d3271
Signed-off-by: srisankethu <sanketh.uppalapati@research.iiit.ac.in>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Ignore tmp dir created by coala

Change-Id: I838a74c9b033016fd8ffcff035f27a4b76de9c7c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Use current datetime as default for RPM changelog date

The current datetime should be the default date for RPM changelog dates
but can still accept optional `changelog_date` param.

Change-Id: I8bcc579d27d63ca091fff536254d3f17752ae306
Signed-off-by: Akshita Jha <zenith158@gmail.com>

Add .rst files for readthedocs for Int/Pack

Change-Id: I37fa9706c36b57b8cb0118e2abed0b4c2369d073
Signed-off-by: Umesh Singla <umeshksingla@gmail.com>