Allow non-default controller-dhcp-enabled at init

Currently controller-dhcp-enabled cn only be set through yang and defaults
to false. To change one must wait for bundles to come up and change
through restconf. This adds option to specif a different default at bring
up.

To set the default for controller-dhcp-enabled:

1. Change the value in dhcpservice/.../netvirt-dhcpservice.xml
2. Copy the file into the unzipped distribution before starting karaf:
  cd netvirt/vpnservice
  mkdir -p ./distribution/karaf/target/assembly/etc/opendaylight/datastore/initial/config
  cp dhcpservice/impl/src/main/resources/netvirt-dhcpservice.xml ./distribution/karaf/target/assembly/etc/opendaylight/datastore/initial/config

Change-Id: I6768e117515a4ff2c52e70961efb3aeac65c8d5f
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Blueprint fix

Registration of entity type "elan" missed out. This is used by L2Gw in
order to identify the owner for type "elan".

Change-Id: I583ec617529a82ee8a0db1dbd34421c29ac9f571
Signed-off-by: Kency Kurian <kency.kurian@ericsson.com>

Merge "Port cloud-servicechain to Blueprint"

Merge "add local_ip to other_config to satisfy auto-tunnel"

Merge "Clean up a bunch of trival Checkstyle violations"

Merge "Bug 6449 - Issues in Service Function Forwarder translation"

Merge "clean isExternal NPE and string syntax"

Merge "ACL Support for IPv6 IPAM"

Merge "More elan Blueprint clean-up"

Merge "Remove elanUtils instance from ElanInstanceManager"

add local_ip to other_config to satisfy auto-tunnel

Change-Id: I06b6688572440f2445a0a0f64f9fe6a6933ac18b
Signed-off-by: Sam Hague <shague@redhat.com>

clean isExternal NPE and string syntax

Change-Id: I5aed5a3bcc830a9df461e7c76fa92d0095ff796f
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Fixing external network group table lifecycle"

Merge "Neutronvpn caches require update upon Router/Network changes"

Merge "Rename JMX MBean's ObjectName from com.ericsson to org.opendaylight"

Merge "Fix completely broken ElanStatusMonitor JMX MBean"

Neutronvpn caches require update upon Router/Network changes

Change-Id: I1381bc8def2124a57b0daa29faa11341ecdd99f9
Signed-off-by: Tali <tali.ben-meir@hpe.com>

Rename JMX MBean's ObjectName from com.ericsson to org.opendaylight

From com.ericsson.sdncp.services.status:type=SvcElanService to
org.opendaylight.netvirt.elan:type=SvcElanService

Change-Id: I598004f3272f267cdd1331aef0e96cac5ac82ef7
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fix completely broken ElanStatusMonitor JMX MBean

including a test for future non-regression of this problem:

javax.management.NotCompliantMBeanException: MBean class
org.opendaylight.netvirt.elan.statusanddiag.ElanStatusMonitorJMX does
not implement DynamicMBean, and neither follows the Standard MBean
conventions (javax.management.NotCompliantMBeanException: Class
org.opendaylight.netvirt.elan.statusanddiag.ElanStatusMonitorJMX is not
a JMX compliant Standard MBean) nor the MXBean conventions
(javax.management.NotCompliantMBeanException:
org.opendaylight.netvirt.elan.statusanddiag.ElanStatusMonitorJMX: Class
org.opendaylight.netvirt.elan.statusanddiag.ElanStatusMonitorJMX is not
a JMX compliant MXBean)
at
com.sun.jmx.mbeanserver.Introspector.checkCompliance(Introspector.java:176)
at
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:317)
at
com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
at
org.opendaylight.netvirt.elan.statusanddiag.ElanStatusMonitorJMX.registerMbean(ElanStatusMonitorJMX.java:30)
at
org.opendaylight.netvirt.elan.statusanddiag.ElanStatusMonitorJMX.init(ElanStatusMonitorJMX.java:24)

Change-Id: Ic269921840effd7ffae1c3c51dba88afd78999d5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Port cloud-servicechain to Blueprint

This also enables the feature.

Change-Id: Ia65d372c291fea413661b33be93e5b5731ddee71
Signed-off-by: Stephen Kitt <skitt@redhat.com>

ACL Support for IPv6 IPAM

This patch implements the following support.
1. Programs the anti-spoofing rules not to allow a VM to run an IPv6 Router.
2. Allows the necessary ICMPv6 traffic in the VM-egress pipeline.
3. Allows the necessary ICMPv6 traffic in the VM-ingress pipeline.
4. Fixes the DHCPv6 ports

Pending:
Some of the flows should be made more restrictive by taking into
consideration the MAC address of the IPv6 Router/DHCP server. This
change is required for both V4 and V6 rules and will be handled in
a separate patch.

Change-Id: I5e64d989dfa4d03ad6ce941201e32f2f2caef308
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>

Clean up a bunch of trival Checkstyle violations

None of these changes has any real impact on code, so please merge this
ASAP, to avoid re-re-re-base.

Change-Id: Ie83af4724b183ed94f093c80e21a81a12ed8186e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Merge "Create VLAN trunk once for multiple VLAN networks"

More elan Blueprint clean-up

* Use static ElanUtils methods where appropriate.
* Drop ElanUtils and IInterfaceManager from
  ElanInterfaceStateChangeListener.
* Drop ElanUtils and MdsalUtils from ElanStatisticsImpl.
* Remove ElanServiceProvider.getElanUtils().

Change-Id: I00271336051cf82ba28bdc596576000ac201a51d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "allow all should be verified by null protocol"

Fixing external network group table lifecycle

Subnet changes will create and remove group tables

Change-Id: I000a295f93af5f1217cc54d5ad2cbf3b3aa3ed9a
Signed-off-by: yair <yair.zinger@hpe.com>

Bug 6449 - Issues in Service Function Forwarder translation

Change-Id: I7ca466ae65aa36c732d74a26def73bd64981b133
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>

Remove elanUtils instance from ElanInstanceManager

With a couple of clean-ups in ElanUtils, ElanInstanceManager can run
with only static method calls.

Change-Id: Idf73692c0109d0e38c8233653c34bbe7425fde25
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Create VLAN trunk once for multiple VLAN networks

Change-Id: I1d4134ddcebffaf6ded35abce41c840d28ea2a77
Signed-off-by: Tali <tali.ben-meir@hpe.com>

Merge "Refactoring to make ElanStatusMonitor more pluggable for tests"

allow all should be verified by null protocol

Change-Id: I94720d90cba5822a75a5ca3454927303d9eaf66c
Signed-off-by: Shlomi <shlomi.alfasi@hpe.com>

Merge "wrong goto table in stateless default flows"

Refactoring to make ElanStatusMonitor more pluggable for tests

Change-Id: I541f60b55af7bcf3b3a861e872931eba3707d8a8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Merge "elanmanager Checkstyle clean-up (94%) "

wrong goto table in stateless default flows

Change-Id: Ieebb317073dbd4511e35a084d5f79a6caabd2aad
Signed-off-by: Shlomi <shlomi.alfasi@hpe.com>

Merge "Listen to changes on subnet GW mac addresses"

Merge "Check network type before adding vtep to TZ"

Merge "add nextHopPointerPool poolId"

Listen to changes on subnet GW mac addresses

- Update ext-net flow based on MAC changes

Change-Id: Id107872a3c04d5d1a218ad87e020c1216adb6265
Signed-off-by: Tali <tali.ben-meir@hpe.com>

Check network type before adding vtep to TZ

Change-Id: Iba7f71812e3ab9eaa69c1a8a38157fb77c1783c2
Signed-off-by: Slava <slava.radune@hpe.com>

add nextHopPointerPool poolId

Change-Id: I026df62363b2a15ad94ea806cc64bac197034479
Signed-off-by: Sam Hague <shague@redhat.com>

elanmanager Checkstyle clean-up (94%)

Enforcement on for api, but not yet for impl (coming later; let's at
least merge this already ASAP to save re-re-basing)

Change-Id: Ic727c9a9fdc8b0a10b61bfbe6a886b9f1d24ea7c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fixes Bug6423

1)The dhcp port should not have SG associated. DHCP will be created with
portsecurityenabled=true and later it will be updated. The update even
was getting ignored.
2)Updated few priority values

Change-Id: Ieb65ed02cf469aad0372fbd3e370c9043ef81682
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>

Merge "Fix bug wherein console commands would not work with Karaf ssh session"

Merge "netvirt-it Checkstyle clean-up (100%) and enforcement"

Merge "Fix (minor) usage of MacNotFoundException"

Merge "pom cleanup, odlparent-lite"

Merge "bug 5618 - fix creation of default rules in stateless security group mode"

pom cleanup, odlparent-lite

Change-Id: Ib277506b43241f035d1da52852c9a8f76abf40a1
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "blueprint cleanup"

Merge "MAC resolution of external GWs"

blueprint cleanup

Change-Id: I16e01a06b43c1325f4b4b0fad6e9117a73e9e0e2
Signed-off-by: Sam Hague <shague@redhat.com>

MAC resolution of external GWs

- NeutronSubnetGwMacResolver will send ARP requests periodically to GW ips
- ARP requests would also be triggered by neutron router changes

ARP responses are already handled and saved to the ARP cache by ArpNotificationHandler

Change-Id: Ib56ec1711aa8c5dd4be13c013dd64b7a59291ca6
Signed-off-by: Tali <tali.ben-meir@hpe.com>

bug 5618 - fix creation of default rules in stateless security group mode

Change-Id: I7bc8e2c52c9b783e722136840b5478e612e638f6
Signed-off-by: Shlomi <shlomi.alfasi@hpe.com>

Fix (minor) usage of MacNotFoundException

Change-Id: I0f25d30bca67d97145be3e00b719d9d71f5c8661
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fix bug wherein console commands would not work with Karaf ssh session

Thank You to Checkstyle for pointing these out.  Please see
https://wiki.opendaylight.org/view/BestPractices/Coding_Guidelines#System.out
for background & details.

Change-Id: I042e2679a4463fc509a5d8d9cc9065454b55e2c3
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

netvirt-it Checkstyle clean-up (100%) and enforcement

Change-Id: I5e40ef24063c33dd106618f75c43ab0706426271
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fix vrf metadata not to override the SH bit

The original fix for this issue was deleted as part of
https://git.opendaylight.org/gerrit/#/c/43306/ (performance improvements)

Change-Id: I23ab430e7f7a7ed289c2619a88261e11259e1fef
Signed-off-by: Tali <tali.ben-meir@hpe.com>

Merge "Add config for aclservice to set security-group-mode"

Merge "change log debug level of elanutils lock print"

Merge "Fix IT default flows validation"

Add config for aclservice to set security-group-mode

1) add transparent security group
2) load default value from blueprint

To set the default for security-group-mode:
1. Change the value in aclservice/.../aclservice-config_aclservice-config.xml
2. Copy the file into the unzipped distribution before starting karaf:
cd netvirt/vpnservice
mkdir -p ./distribution/karaf/target/assembly/etc/opendaylight/datastore/initial/config; cp aclservice/impl/src/main/resources/aclservice-config_aclservice-config.xml ./distribution/karaf/target/assembly/etc/opendaylight/datastore/initial/config

Change-Id: Ic57c438499f6b529e462b57fbfcbc669c591bfc4
Signed-off-by: Shlomi <shlomi.alfasi@hpe.com>
Signed-off-by: Sam Hague <shague@redhat.com>

change log debug level of elanutils lock print

Change-Id: I14de4e470f9fc48e12ad868934217b5a124a29ea
Signed-off-by: Alon Kochba <alonko@hpe.com>

Fix ipv6service main pom.xml version.

Change-Id: I5c03fc57af0487d299512cfb6289ab5148dcc464
Signed-off-by: Alon Kochba <alonko@hpe.com>

Add missing init-methods

Change-Id: I6de3c5ace68b83e1861433583ae596ea798b2a0e
Signed-off-by: Tali <tali.ben-meir@hpe.com>

Fix IT default flows validation

1)Changed the list of default flows due to some
changes in the pipeline.
2)Changed the max time for flow validation method,
because 1 minute was not enough.

Change-Id: Icc7c2ac03fce75a14cb04f185b1350936d39f67b
Signed-off-by: Oded Shvartz <oshvartz@redhat.com>

Add missing init-method to FIB+ELAN services

Change-Id: Ia46f50edc71c8ec57d7bb31466b27e91c855d581
Signed-off-by: Tali <tali.ben-meir@hpe.com>

Merge "cleanup elanmanager blueprint 2"

Merge "Bug 6089: Fix to drop Tcp Syn packets after default SG removed."

cleanup elanmanager blueprint 2

Change-Id: I8a85f5ccdcdb6007bf04717cd00073cf1f54bf6d
Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit 4a7e3ef25d48e2fb598f7ab44c0f01e3621d34b3)

Merge "Fix exception in IPv6Service for non-neutron ports"

Merge "Optimize iface search in transmitRouterAdvertisement"

Merge "Change controller-dhcp-enabled default value"

Merge "ACL: Using non-deprecated ACL constants"

Merge "BUG 6387: Traffic drop in 17 in serviceChain"

Merge "cleanup elanmanager blueprint"

Bug 6089: Fix to drop Tcp Syn packets after default SG removed.

 * Removed rule to check legitimate ip/mac pair during
   VM creation because incoming Tcp packets matches this
   rule and it passing packets to next pipeline.
   "cookie=0x0, duration=45.414s, table=40, n_packets=0, n_bytes=0,
   priority=36001,ip,in_port=12,dl_src=fa:16:3e:49:06:f1,nw_src=10.0.0.2
   actions=goto_table:50"
 * Support added for Tcp Syn drop rule in Egress table.

Change-Id: Ifa0e8cb122c16dd12f5d94c98a187dc604bd8c87
Signed-off-by: bharathi.m <bharathi.m@hcl.com>

Fix exception in IPv6Service for non-neutron ports

This patch fixes the IllegalArgumentException for notifications
related to non-neutron ports.

Change-Id: I0824cafd5f7aa9edd8d8208b729cc1cf3e7416a3
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>

Optimize iface search in transmitRouterAdvertisement

Currently the periodic router advt timer is iterating over
all the virtual ports to figure out the ports on the network
where the RA has to be sent out. This patch optimizes the
search by using the local cache of (dpnIds <--> List[ofPorts])
maintained per network.

Change-Id: I6e64064c72b0586aa8f4b42b66ef49d2fc7ed46f
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>

cleanup elanmanager blueprint

Change-Id: I40049c85a8ec8740983a0382d7240cbc79edab71
Signed-off-by: Sam Hague <shague@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Fix ipv6 version for rc0

Change-Id: I8ec4f623a08c1239d0602c7f0c53f09fb741c289
Signed-off-by: Sam Hague <shague@redhat.com>

Change controller-dhcp-enabled default value

Changed the default value to false in order to use the
neutron dhcp agent.

Change-Id: I8be03bde202759964b85f89c125218e2fcd5e8fb
Signed-off-by: Oded Shvartz <oshvartz@redhat.com>

Support new actions in new ovs nsh patches

- rebase
- Added pop_nsh to classifier bypass flow

Change-Id: Id12e9c0bea42aa5c20adf34769b366d9b5c0231b
Signed-off-by: Yi Yang <yi.y.yang@intel.com>

BUG 6387: Traffic drop in 17 in serviceChain

 Analysis:
    In a non servicechain scenario, packets get to LFIB and are sent over
    the corresponding port.
    In ServiceChain scenario, there are new Flows in LFIB, with higher priority,
    that sends the packet to 17 which, in turn, is redirecting it to SCF Pipeline.
    However, no SC matches and packets are submitted back to 17. Since packets
    have not changed, they get in a loop between 17 and 70.

 Solution:
    Table-miss in 70-75 tables must change the SI to L3VPN, so that when
    the packet gets back to 17, they are redirected to FIB table.
    Also, entries in 17 that handle packets that match no SC must be
    programmed in all CSS where the VPN has footprint, not just in the
    CSS where the last vSF in the chain is located.

Change-Id: I1cfc2973049746019a310ef3b106a5e416f24f04
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>

ACL: Using non-deprecated ACL constants

+ Replaced usage of deprecated constants with non-deprecated constants.

Change-Id: Ibe3b516665f51fb4358bf9eb432c651810717017
Signed-off-by: Somashekar Byrappa <somashekar.byrappa@ericsson.com>

Merge "Changing the conntrack default drop and allow flows from per port to per switch."

Merge "Exception in SubnetRoute Feature"

Changing the conntrack default drop and allow flows from per port to per
switch.

Change-Id: I9ddf734cebb66d2b6a778cc9671312adf0c980b5
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>

Merge "blueprint cleanup"

Merge "Add blueprint wiring for elanmanager"

blueprint cleanup

Change-Id: I9e16225162ff59e9d8d9122f104da220be72180c
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "ACL: Enabling ACL service in the pipeline"

Add blueprint wiring for elanmanager

Change-Id: I1274ef299469602cd8fa4722bc037e4e2785e1ea
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Signed-off-by: Alexis de Talhouët <alexis.de.t@gmail.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

ACL: Enabling ACL service in the pipeline

Change-Id: Ieca5bbefa97f38703c79f592b383fb32bc745fd9
Signed-off-by: Somashekar Byrappa <somashekar.byrappa@ericsson.com>

Fix IT setup

Remove deprecated methods after moving to blueprints.
The method were used when working with config and after
moving to blueprints we get "NOT FOUND Module" exception.

Change-Id: I16a417c58ee9c2b0720ef35675dc98ddc333b3cf
Signed-off-by: Oded Shvartz <oshvartz@redhat.com>

Exception in SubnetRoute Feature

1. Handle exception in subnetroute feature
specifically for the
SubnetRouteInterfaceStateChangeListener.

2. Handle removal of subnetroutes when
subnets are removed from the router (or)
when the router is disassociated from VPN.

3. Increase the retry count to 3 when trying
deletion of VPNs.

Change-Id: Iaf263c5596bd2b2b061e82597dcdc400dad42f17
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>

Merge "IPv6Service Binding using elanTag"

Merge "Using DataStoreJobCoordinator"

Merge "BUG 6363: Further performance improvements for VPN Engine"

Using DataStoreJobCoordinator

- Made changes such that the Interface Events make use of
  DataStoreJobCoordinator.
- Batching transactions.

Change-Id: Ieeb4da479bf9b4710edcc1294b2c03fb66dcba6e
Signed-off-by: Kency Kurian <kency.kurian@ericsson.com>