l2switch.git
9 years agoBug2121 -- Add configuration parameter for TopologyId. 74/11674/1
Alex Fan [Tue, 30 Sep 2014 19:06:27 +0000 (12:06 -0700)]
Bug2121 -- Add configuration parameter for TopologyId.

Change-Id: I3a5f486c7fa32f10451098fcfdf6fff0d87d104d
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoBug 2104 Fixed, creating threadpool only once. 29/11629/1
Amit Mandke [Sat, 27 Sep 2014 17:30:38 +0000 (23:00 +0530)]
Bug 2104 Fixed, creating threadpool only once.

Change-Id: Ic978c1008f2fedd02e7e837a785e74705c6242e5
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoBUG-2097 hosts not seen in topology. 02/11602/1
André Martins [Fri, 26 Sep 2014 01:32:22 +0000 (02:32 +0100)]
BUG-2097 hosts not seen in topology.

Fixed NPE when a topology with a null list of links was checked.

Change-Id: If3b6a8f0aeb623c4bd78d41e2d812a2d3720a6d5
Signed-off-by: André Martins <aanm90@gmail.com>
9 years agoBug 2040: Reschedule flow thread in case of error. 55/11555/1
Alex Fan [Thu, 25 Sep 2014 01:47:18 +0000 (18:47 -0700)]
Bug 2040: Reschedule flow thread in case of error.

Change-Id: I83a42d67e37a2d792dbaa85743d91c103093aa0e
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoBug 2040: Reduce delays. 50/11550/1
Alex Fan [Wed, 24 Sep 2014 23:32:55 +0000 (16:32 -0700)]
Bug 2040: Reduce delays.

Change-Id: I7b722f3a2c9bd9a458cdc0296d2eab04feda9d49
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoAdding callbacks for errors, bug 1707. 41/11541/2
Alex Fan [Wed, 24 Sep 2014 16:36:06 +0000 (09:36 -0700)]
Adding callbacks for errors, bug 1707.

Change-Id: Ia7078faef392517f6028a9ddd3c1aea5d4e0a799
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoMerge "Bug 2040: Install flood flows after data has been fully written to datastore."
Alex Fan [Wed, 24 Sep 2014 06:49:15 +0000 (06:49 +0000)]
Merge "Bug 2040: Install flood flows after data has been fully written to datastore."

9 years agoBug 2040: Install flood flows after data has been fully written to datastore. 78/11478/5
Alex Fan [Tue, 23 Sep 2014 07:59:05 +0000 (00:59 -0700)]
Bug 2040: Install flood flows after data has been fully written to datastore.

Change-Id: I075cd5e66b5a7bf35b9b6d76603b75f366462759
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoMerge "Bug 1948: Separate out restconf features"
Alexander Fan [Wed, 24 Sep 2014 05:47:15 +0000 (05:47 +0000)]
Merge "Bug 1948: Separate out restconf features"

9 years agoBug 1757, Integration with Sonar. 07/11507/3
Alex Fan [Wed, 24 Sep 2014 02:17:20 +0000 (19:17 -0700)]
Bug 1757, Integration with Sonar.

Change-Id: Iad8097e3b0a420ed49ebcd91b1673d9ab015ad50
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoBUG-2059: Hosttracker doesn't close readTransaction. 02/11502/2
André Martins [Tue, 23 Sep 2014 20:31:56 +0000 (21:31 +0100)]
BUG-2059: Hosttracker doesn't close readTransaction.

Change-Id: Ife998eee724b256182726eb622dd1730384380d8
Signed-off-by: André Martins <aanm90@gmail.com>
9 years agoBug 1948: Separate out restconf features 73/11473/3
Ed Warnicke [Tue, 23 Sep 2014 02:10:29 +0000 (21:10 -0500)]
Bug 1948: Separate out restconf features

In order to avoid a maven project cycle in solving
Bug 1948, we need to separate restconf features.
Note, this is a first step, suffixing everything
with -new.  Subsquently, after everywhere using
odl-restconf has been fixed to use this new repo,
we will deprecate the ones in the mdsal features.xml
and rename these to not have the -new.

This patch just adds the dependency to features/pom.xml

Change-Id: I11c7170b60a5d993c2ee7f60ad81fba8d0b965bb
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoMerge "BUG-2043: Hosttracker gives a NPE."
Alexander Fan [Tue, 23 Sep 2014 18:27:02 +0000 (18:27 +0000)]
Merge "BUG-2043: Hosttracker gives a NPE."

9 years agoBUG-2043: Hosttracker gives a NPE. 82/11482/1
André Martins [Tue, 23 Sep 2014 10:55:13 +0000 (11:55 +0100)]
BUG-2043: Hosttracker gives a NPE.

Change-Id: Iecb04ffb18fe77d2d13a0b1299f195649fabc367
Signed-off-by: André Martins <aanm90@gmail.com>
9 years agoMerge "Bug 1757 Negative test cases for addresstracker"
Alexander Fan [Tue, 23 Sep 2014 00:41:17 +0000 (00:41 +0000)]
Merge "Bug 1757 Negative test cases for addresstracker"

9 years agoBug 1757 Negative test cases for addresstracker 52/11452/2
Aarti Lolage [Mon, 22 Sep 2014 19:29:26 +0000 (12:29 -0700)]
Bug 1757 Negative test cases for addresstracker

Change-Id: I4c68af786a9ad43c21363ae1ae071580341cca34
Signed-off-by: Aarti Lolage <aalolage@cisco.com>
9 years agoBug 2032: Integrating HostTracker with config subsystem. 36/11436/4
Alex Fan [Mon, 22 Sep 2014 10:40:27 +0000 (03:40 -0700)]
Bug 2032: Integrating HostTracker with config subsystem.

Change-Id: I30362f7428e6e9e9d46b0ec6a7d202e643a278ee
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoBUG fixes. 77/11177/4
André Martins [Sat, 20 Sep 2014 01:46:21 +0000 (02:46 +0100)]
BUG fixes.

BUG-1627: Hosts are cleaned by hosttracker.
BUG-1754: Implemented a clusterAware mechanism for hosttracker.

Change-Id: I56a7b1fada563aaf9d423c2cfed7c8dff0c9dac3
Signed-off-by: André Martins <aanm90@gmail.com>
9 years ago Bug 1757 UT for Inventory Reader 86/11386/1
Aarti Lolage [Fri, 19 Sep 2014 21:49:15 +0000 (14:49 -0700)]
 Bug 1757 UT for Inventory Reader

Change-Id: I6a3dc4833d03e4b997c5bf3dff4604d52a606ab6
Signed-off-by: Aarti Lolage <aalolage@cisco.com>
9 years agoAdding L2SwitchMain Unit Tests, bug 1757. 48/11348/2
Alex Fan [Fri, 19 Sep 2014 00:37:51 +0000 (17:37 -0700)]
Adding L2SwitchMain Unit Tests, bug 1757.

Change-Id: I033f19f39a624d5d889d8d218367b403ac716f40
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoBug 1757 UT for Flow Writer module 42/11342/2
Aarti Lolage [Thu, 18 Sep 2014 21:48:29 +0000 (14:48 -0700)]
Bug 1757 UT for Flow Writer module

Change-Id: Ic5b467e7a1602f78ca42cf12ec333e0f0513e403
Signed-off-by: Aarti Lolage <aalolage@cisco.com>
9 years agoAdding InstanceIdentifier UnitTests, fixing bug in previous unit tests, bug 1757. 39/11339/1
Alex Fan [Thu, 18 Sep 2014 21:28:42 +0000 (14:28 -0700)]
Adding InstanceIdentifier UnitTests, fixing bug in previous unit tests, bug 1757.

Change-Id: I155672aae57a423f075aa3faebdfb3b504a02d1d
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoMerge "Add -rest and -ui features to make it easier for folks to get the collection...
Alexander Fan [Thu, 18 Sep 2014 19:34:06 +0000 (19:34 +0000)]
Merge "Add -rest and -ui features to make it easier for folks to get the collection they want."

9 years agoAdd -rest and -ui features to make it easier for folks 17/11317/1
Ed Warnicke [Thu, 18 Sep 2014 12:14:26 +0000 (07:14 -0500)]
Add -rest and -ui features to make it easier for folks
to get the collection they want.

Change-Id: I4c3570be7bedfd92d8d4a67814e7349e2f4e99e9
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoAdding java docs, bug 1757. 99/11299/1
Alex Fan [Thu, 18 Sep 2014 01:41:47 +0000 (18:41 -0700)]
Adding java docs, bug 1757.

Change-Id: Ief6a410a1fe61cfadc466d1f984e10669172bed2
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoL2Switch now works with a single switch, bug 1916. 98/11298/2
Alex Fan [Thu, 18 Sep 2014 00:22:45 +0000 (17:22 -0700)]
L2Switch now works with a single switch, bug 1916.

Change-Id: I36a1c99252ed551fafbe0ca0f4cf650e89a7c2e2
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoUnit Tests for ArpHandler module. Bug 1757 73/11273/1
Alex Fan [Wed, 17 Sep 2014 07:11:11 +0000 (00:11 -0700)]
Unit Tests for ArpHandler module.  Bug 1757

Change-Id: I2e7572013cc58d340c119571f5af375061251ff8
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoFix for bug 1814 - where the AddressTracker records the same address twice. 59/11259/1
Alex Fan [Wed, 17 Sep 2014 01:04:35 +0000 (18:04 -0700)]
Fix for bug 1814 - where the AddressTracker records the same address twice.

Change-Id: I79b824e81605097060ba37f51370480f1ef81fae
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoBug 1873 - Replace Hardcoded URLs and add Missing Parent sections to poms to get... 45/10945/5
Devin Avery [Tue, 9 Sep 2014 13:45:20 +0000 (09:45 -0400)]
Bug 1873 - Replace Hardcoded URLs and add Missing Parent sections to poms to get distributionManagement section

Change-Id: I01c1e7447df398204b92b23bbc71405e16cb4ede
Signed-off-by: Devin Avery <devin.avery@brocade.com>
9 years agoBug 1757 UT for addresstracker 04/11204/1
Aarti Lolage [Mon, 15 Sep 2014 18:55:33 +0000 (11:55 -0700)]
Bug 1757 UT for addresstracker

Change-Id: Iadbdc515feb18aef35720db1ca5e9dc1928a7fcc
Signed-off-by: Aarti Lolage <aalolage@cisco.com>
9 years agoUnit Tests for LoopRemover module. Bug 1757 79/11079/2
Alex Fan [Fri, 12 Sep 2014 01:32:28 +0000 (18:32 -0700)]
Unit Tests for LoopRemover module.  Bug 1757

Change-Id: I2b388894684d6e0fddafd689ffe447641f8bab65
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoFix for bug 1834. 76/11076/1
Alex Fan [Fri, 12 Sep 2014 00:30:36 +0000 (17:30 -0700)]
Fix for bug 1834.

Change-Id: Idf4b8698d23adc9368d98469f7cbcdb3d46637e1
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoBug 1707: Changed data updates to use merge 70/10870/2
Amit Mandke [Thu, 4 Sep 2014 00:52:19 +0000 (17:52 -0700)]
Bug 1707: Changed data updates to use merge
Now these data store updates use merge api. Also changed the
instance identifier to use augmentation so that data base can
mange it efficiently.

Change-Id: I2d05f0bd04f1b6f39a7a24dee52568ac4f26c88b
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoAdd another configuration item to L2SwitchMain. Refactor pom.xml to use appropriate... 27/10827/1
Alex Fan [Fri, 5 Sep 2014 01:14:12 +0000 (18:14 -0700)]
Add another configuration item to L2SwitchMain.  Refactor pom.xml to use appropriate output directories.

Change-Id: I26d2d0e692856503303237891c640881eb82a82a
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoMerge "Adding config param to choose packet types for address tracking"
Alexander Fan [Fri, 5 Sep 2014 01:19:59 +0000 (01:19 +0000)]
Merge "Adding config param to choose packet types for address tracking"

9 years agoAdding config param to choose packet types for address tracking 25/10825/1
Amit Mandke [Fri, 5 Sep 2014 00:55:52 +0000 (17:55 -0700)]
Adding config param to choose packet types for address tracking

Change-Id: I6f5f4bccf31d28310a4bc1e680496b015b079a08
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoIntegrate L2SwitchMain with config subsystem. 19/10819/1
Alex Fan [Thu, 4 Sep 2014 23:26:50 +0000 (16:26 -0700)]
Integrate L2SwitchMain with config subsystem.

Change-Id: I572de5580194ac6f693a66fdd9e90ed8da55b837
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoIntegrate address tracker with config subsystem. 05/10805/1
Alex Fan [Thu, 4 Sep 2014 20:57:06 +0000 (13:57 -0700)]
Integrate address tracker with config subsystem.

Change-Id: Icf3e011fe21067c69d54c8a8a15e08e222ed8dbc
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoIntegrate LoopRemover module with config subsystem. 38/10738/5
Alex Fan [Wed, 3 Sep 2014 22:08:47 +0000 (15:08 -0700)]
Integrate LoopRemover module with config subsystem.

Change-Id: Icfbd3fdd2e9e87d47983264e07b77301e1966ef3
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoURGENT Fix for missing dependency in features. 43/10743/1
Amit Mandke [Thu, 4 Sep 2014 00:58:16 +0000 (17:58 -0700)]
URGENT Fix for missing dependency in features.

Change-Id: I9c541301f9db80bbb04c6cb7ed83700d21a26a5b
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoIntegrate packethandler & arphandler with config subsystem. 00/10400/10
Alex Fan [Wed, 27 Aug 2014 22:59:54 +0000 (15:59 -0700)]
Integrate packethandler & arphandler with config subsystem.

Change-Id: Ia43c2b349c47e07d97a36dd45373b1a2d8c0823a
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoURGENT Fix feature for arphandler dependency. 77/10377/1
Ed Warnicke [Wed, 27 Aug 2014 13:34:30 +0000 (08:34 -0500)]
URGENT Fix feature for arphandler dependency.

Integration is broken until this is fixed.

Change-Id: I47cf046b340cc297a166129844ca69c810e29883
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRefactoring code seperating arp handler from main 44/10344/1
Amit Mandke [Tue, 26 Aug 2014 19:22:54 +0000 (12:22 -0700)]
Refactoring code seperating arp handler from main
Currently address tracker needs l2switch main to work to its full potential.
So this refactoring would seprate out a module that can go as only dependency
of address tracker. This would leave only reactive flow writing in main module.

Change-Id: Ic36ba57dd69e429453f0593cbd9a935842fa8ae6
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoAdding Karaf features for L2switch 15/10115/5
Ed Warnicke [Tue, 19 Aug 2014 00:08:53 +0000 (17:08 -0700)]
Adding Karaf features for L2switch

Also added a local karaf distributions.

cd distribution/karaf/target/assembly/bin
./karaf

And it will come up running l2switch and restconf.

Point mininet at it, pingall, and look at the host tracking
in topology:

GET http://localhost:8181/restconf/operational/network-topology:network-topology/

Had to force maven bundle plugin to 2.4.0 as 2.5.0 is incompatible
with karaf

Change-Id: I0ff09b6d330d3fc7e741cfdc8d652637fdea8ff3
Signed-off-by: Amit Mandke <ammandke@cisco.com>
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoAdded util classes for packet decoding instead of depending on controller 99/10199/2
Amit Mandke [Sat, 23 Aug 2014 00:48:37 +0000 (17:48 -0700)]
Added util classes for packet decoding instead of depending on controller

Change-Id: I61f6e4cfb561ac3816b2c209c7c0cccceb70c572
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoAdding interval in address obsrvation writes. 97/10197/3
Amit Mandke [Fri, 22 Aug 2014 22:19:35 +0000 (15:19 -0700)]
Adding interval in address obsrvation writes.
Currently address observation writer updates same observation too
frequently. This change would update it only after some interval.

Change-Id: Ib329de930829438f2d10a29f0377ca299636710f
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoCreating separate proactive flows for internal and external ports. 56/10156/1
Amit Mandke [Fri, 22 Aug 2014 07:47:25 +0000 (00:47 -0700)]
Creating separate proactive flows for internal and external ports.
1. this helps writting less address observation to store.
2. due to point 1. no conclicting commits are observed for test upto
64 switches 10 hosts each.
3. this affects mac to mac flow writer as flows are not written on
each switch. Improved solution is required for this.

Change-Id: I70024f2a300b74f65b8e16e231114a9bd1b17ba7
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoAdding back single flood flow. 24/10124/2
Amit Mandke [Thu, 21 Aug 2014 07:51:29 +0000 (00:51 -0700)]
Adding back single flood flow.
Openflow specification confirms that oputput action would not
send a packet out of ingress port unless reserved port is used.
So it is safe to use single flood flow that only discards 'discarding'
ports.

Change-Id: Ic82013ad0ea3915b217884582c0fd9552bd21c7c
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoAdded logic to ignore host link events. 21/10121/3
Amit Mandke [Thu, 21 Aug 2014 03:25:34 +0000 (20:25 -0700)]
Added logic to ignore host link events.
Network graph or mst doesnt need referesh if host links are
added or removed.

Change-Id: I3cbdfa836943c45bab9b2d84b49ed8451cc90a3b
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoImplemented a small AddressObserver for HostTracker. 23/9923/7
André Martins [Wed, 13 Aug 2014 17:05:53 +0000 (18:05 +0100)]
Implemented a small AddressObserver for HostTracker.

Host tracker with new methods and implementations.
Fix a bug and hosttracker checks datacreated.
Created documentations for Host.

Change-Id: I9c83287c3ed7541ac6b7af05f2a04275ab19ac00
Signed-off-by: André Martins <aanm@ua.pt>
9 years agoApplied Karaf features to l2switch. 70/9970/5
André Martins [Fri, 15 Aug 2014 03:07:01 +0000 (23:07 -0400)]
Applied Karaf features to l2switch.

Change-Id: I55831747a4ed6b9650ab107c5e36183272406f44
Signed-off-by: André Martins <aanm@ua.pt>
Signed-off-by: Mathieu Lemay <mlemay@inocybe.com>
Signed-off-by: André Martins <aanm@ua.pt>
9 years agoMaking further changes to proactive flood, with additional performance improvements. 86/10086/3
Amit Mandke [Wed, 20 Aug 2014 07:27:16 +0000 (00:27 -0700)]
Making further changes to proactive flood, with additional performance improvements.
1. initial flood flows are changed to handle pingall failure.
2. removed some redundant calls to inventory reader and made some further code optimization.
3. code restructuring moved logical classes in respective packages.(arphandler & flow)
4. made pending change to address observer to generate unique key for each address observation.

Change-Id: I501f2a0082e9623c91336a445f135dc41abd1408
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoAdding proactive mode for L2Switch, which installs flood flows. 46/10046/3
Alex Fan [Mon, 18 Aug 2014 21:23:01 +0000 (14:23 -0700)]
Adding proactive mode for L2Switch, which installs flood flows.

Change-Id: I779a49fe9e7fd4ba69dfe934fd4a742b0f77b2bc
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoSplitting Flow writing and packet dispatch(reactive flood). 42/10042/1
Amit Mandke [Mon, 18 Aug 2014 19:21:15 +0000 (12:21 -0700)]
Splitting Flow writing and packet dispatch(reactive flood).
This would allow either to be enabled or disabled easily based on need.

Change-Id: I271a1f58ff8df916413aa1e20154c60fa2860784
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoMaking changes to loop remover so that it doesnt rely on in memory graph. 61/9961/1
Amit Mandke [Tue, 12 Aug 2014 20:43:51 +0000 (13:43 -0700)]
Making changes to loop remover so that it doesnt rely on in memory graph.
This would help the loopremover to behave same across cluster(in a clustered env)
and it will not reply on any in memory local state.

Change-Id: I639ce0cd87a3e61c67a69a611ded4bea050682cb
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoMerge "Fixed ClassCastException during decode. There was possibility of single decode...
Alexander Fan [Wed, 13 Aug 2014 22:44:21 +0000 (22:44 +0000)]
Merge "Fixed ClassCastException during decode. There was possibility of single decoder instance being registered twice as notification listner. This synchronized method would eliminate that. This was resulting in ClassCastException/ unpredictable behaviour."

9 years agoFixed ClassCastException during decode. 32/9932/1
Amit Mandke [Wed, 13 Aug 2014 21:10:35 +0000 (14:10 -0700)]
Fixed ClassCastException during decode.
There was possibility of single decoder instance being registered
twice as notification listner. This synchronized method would eliminate that.
This was resulting in ClassCastException/ unpredictable behaviour.

Change-Id: I52e57b8e1568520c6742c20ea60e5b28610df68f
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoRemoving duplicated information from poms in host tracker 97/9897/2
Colin Dixon [Tue, 12 Aug 2014 18:52:55 +0000 (13:52 -0500)]
Removing duplicated information from poms in host tracker

This includes things already specified in parent poms like:
* dependency versions
* groupIDs
* artifact versions

Change-Id: I5c0e7fe7ea2dbd02774550c81180e653a0805b38
Signed-off-by: Colin Dixon <colin@colindixon.com>
9 years agoEnabling checkstyle by default 96/9896/2
Colin Dixon [Tue, 12 Aug 2014 18:41:53 +0000 (13:41 -0500)]
Enabling checkstyle by default

This patch includes the default checkstyle from the controller project and
updates all currently checked in files to comply with the checkstyle rules.

Change-Id: I78f7949adf6ec0a7144c88756ccee546192879d2
Signed-off-by: Colin Dixon <colin@colindixon.com>
9 years agoFixing pom files so Eclipse works 94/9894/2
Colin Dixon [Tue, 12 Aug 2014 18:14:54 +0000 (13:14 -0500)]
Fixing pom files so Eclipse works

Moved the Eclipse-related plugins and pluginMangement to the l2switch-parent
so that all relevant projects will automatically import into Eclipse correctly.

Change-Id: I27dcd4adf726634ae78501a425bf33b39130a708
Signed-off-by: Colin Dixon <colin@colindixon.com>
9 years agoAdding Initial Flows on switch for performance improvement. 82/9882/4
Amit Mandke [Fri, 8 Aug 2014 19:04:45 +0000 (12:04 -0700)]
Adding Initial Flows on switch for performance improvement.
These sends minimum packets(ARP and LLDP) to controller for
learning addresses and programming flows as l2switch requires.

Change-Id: Id7f0ba5ca7dea6e83b02c4a8a997bcc2bade05e0
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoMoving address observer implementation to address tracker. 83/9883/2
Amit Mandke [Tue, 12 Aug 2014 07:36:50 +0000 (00:36 -0700)]
Moving address observer implementation  to address tracker.
This would help to seperate address tracking implementation
moduler and independent of other l2switch fuctionality.

Change-Id: I97a434fb105293e063a85f9dda62a0bb479aeb92
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoFollowing minor fixes done. 03/9803/1
Amit Mandke [Fri, 8 Aug 2014 06:50:33 +0000 (23:50 -0700)]
Following minor fixes done.
1. info logs changed to debug as unnecessary log was being printed at info level.
2. transaction commit changed to submit as commit is deprecated.

Change-Id: I27b1277d8f1debce328c2c6a195c5059ddfa5393
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoMerge "Host Tracker generated source code imports into Eclipse"
Evan Zeller [Thu, 7 Aug 2014 20:36:33 +0000 (20:36 +0000)]
Merge "Host Tracker generated source code imports into Eclipse"

9 years agoMinor fixes observeed during testing. 66/9766/1
Amit Mandke [Thu, 7 Aug 2014 01:58:50 +0000 (18:58 -0700)]
Minor fixes observeed during testing.

Change-Id: I2019e5e1e496b2caac0a435a0ae9ee4cac7b49b3
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoFixing l2switch base distribution so it runs without errors 58/9758/1
Colin Dixon [Wed, 6 Aug 2014 17:45:25 +0000 (12:45 -0500)]
Fixing l2switch base distribution so it runs without errors

This involved commenting out the exclude for
opendaylight/plugins/org.opendaylight.controller.sal-remote*.jar

Change-Id: Ied02eb9f4cf1aa6baad70872a9f7753a1ea0640f
Signed-off-by: Colin Dixon <colin@colindixon.com>
9 years agoHost Tracker generated source code imports into Eclipse 22/9722/3
Colin Dixon [Tue, 5 Aug 2014 22:37:32 +0000 (17:37 -0500)]
Host Tracker generated source code imports into Eclipse

Change-Id: I97ddf55fdd69da033c7df58fed2990aab6c2b6fb
Signed-off-by: Colin Dixon <colin@colindixon.com>
9 years agoMerge "Refined host model & pushing to topology"
Amit Mandke [Mon, 4 Aug 2014 22:56:13 +0000 (22:56 +0000)]
Merge "Refined host model & pushing to topology"

9 years agoChanging key for addresses (Bug 1470) 11/9611/1
Colin Dixon [Sat, 2 Aug 2014 16:19:29 +0000 (11:19 -0500)]
Changing key for addresses (Bug 1470)

The addresses structure used to use the first-seen timestamp as a key.
That is not guranteed to be unique. This changes that to use an opaque
64-bit identifier. Currently, it's populated with the MAC addres
interpreted as a BigInteger, but that should not be counted on in the
future and should be checked for uniqueness.

Change-Id: I579c2c5587c62ef685317bd54049aead67406d35
Signed-off-by: Colin Dixon <colin@colindixon.com>
9 years agoRefined host model & pushing to topology 08/9608/1
Evan Zeller [Fri, 1 Aug 2014 19:46:45 +0000 (15:46 -0400)]
Refined host model & pushing to topology

Change-Id: I53acd272482e42ab43d31ebf388bd59a8f01cd4b
Signed-off-by: Evan Zeller <evanrzeller@gmail.com>
9 years agoFixed nullpointer exception and added new functionalities on hosttracker 57/9557/1
André Martins [Fri, 1 Aug 2014 02:43:44 +0000 (03:43 +0100)]
Fixed nullpointer exception and added new functionalities on hosttracker

Change-Id: I988121a16bdd95ea50e3405b55730f8bc8980f75
Signed-off-by: André Martins <aanm@ua.pt>
9 years agoAvoiding Null pointer in hosttracker. 50/9550/1
Amit Mandke [Fri, 1 Aug 2014 00:11:44 +0000 (17:11 -0700)]
Avoiding Null pointer in hosttracker.
Better implementation needs to be added. Just avoiding nullpointer for now.

Change-Id: If3aabd11bb49b6fc49fc578f200c7a9c989d3aa3
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoAdded new changes to hosttracker 14/9514/2
André Martins [Thu, 31 Jul 2014 00:27:49 +0000 (01:27 +0100)]
Added new changes to hosttracker

Change-Id: Ib51f46111f69a887d752c96a9b4f69893a49a762
Signed-off-by: André Martins <aanm@ua.pt>
9 years agoMerge "Bring hosttracker code into l2switch"
Amit Mandke [Wed, 30 Jul 2014 22:11:06 +0000 (22:11 +0000)]
Merge "Bring hosttracker code into l2switch"

9 years agoMerge "BUG-432: Fix in response to Gerrit 9362"
Alexander Fan [Mon, 28 Jul 2014 23:13:18 +0000 (23:13 +0000)]
Merge "BUG-432: Fix in response to Gerrit 9362"

9 years agoBUG-432: Fix in response to Gerrit 9362 17/9417/1
Ed Warnicke [Mon, 28 Jul 2014 22:38:03 +0000 (17:38 -0500)]
BUG-432: Fix in response to Gerrit 9362

https://git.opendaylight.org/gerrit/#/c/9362/
broke stuff... this fixes it.

Change-Id: Ia152a160511429a3f5cc467e48f8e880b134a28a
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoChanging Registrations to not use generics 12/9412/3
Colin Dixon [Mon, 28 Jul 2014 21:34:40 +0000 (16:34 -0500)]
Changing Registrations to not use generics

This is a reaction to this patch in yangtools:
https://git.opendaylight.org/gerrit/#/c/9362/

Change-Id: I69e8d93c8d058cbe13c7aa68ad66640f3367c514
Signed-off-by: Colin Dixon <colin@colindixon.com>
9 years agoBring hosttracker code into l2switch 39/9339/1
Evan Zeller [Fri, 25 Jul 2014 23:44:22 +0000 (19:44 -0400)]
Bring hosttracker code into l2switch

Change-Id: I718dca4d8a0e2ed3516499b770c0b612bb6f8718
Signed-off-by: Evan Zeller <evanrzeller@gmail.com>
9 years agoMove stp status to operational datastore. 49/9249/1
Alex Fan [Tue, 22 Jul 2014 22:57:33 +0000 (15:57 -0700)]
Move stp status to operational datastore.

Change-Id: Ic0e4dc593e157a62a8b2a24eaf812f0166d3275c
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoRefactor for the DataStore changes. 47/9247/1
Alex Fan [Tue, 22 Jul 2014 22:29:01 +0000 (15:29 -0700)]
Refactor for the DataStore changes.

Change-Id: I8fa367f46687dec4f598f46b7f4954810c02f40d
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoFollowing Fixes are added 74/9174/3
Amit Mandke [Sat, 19 Jul 2014 01:09:39 +0000 (18:09 -0700)]
Following Fixes are added
1. Fixed Null pointer exception while reading data from InvetoryReader
2. Compilation for read from data store is removed. Optional<> needs to be declared for the specific type you are reading from store, instead of just DataObject.
3. Dlux UI is added to the distribution.

Change-Id: Ia18c3f32d353cdcdb44bd00d76a5f0618af4cc6c
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoScript for ring and mesh topology in mininet 67/9167/1
Amit Mandke [Fri, 18 Jul 2014 18:08:11 +0000 (11:08 -0700)]
Script for ring and mesh topology in mininet

Change-Id: I6afc719b83314379e9befc36dbb7b69a88d0946c
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoFix for Amit's review comment to check stp status for destinationNodeConnector. ... 31/9131/1
Alex Fan [Thu, 17 Jul 2014 23:38:40 +0000 (16:38 -0700)]
Fix for Amit's review comment to check stp status for destinationNodeConnector.  Also added some JavaDocs.

Change-Id: I77c7013b978c9a5e731ad85ce7f3ab65ef373a4a
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoFinishing FlowWriterService. 30/9130/1
Alex Fan [Thu, 17 Jul 2014 22:57:16 +0000 (15:57 -0700)]
Finishing FlowWriterService.

Change-Id: I2134bb49e2c5f08dc0b5a91738e643711d3bfc50
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoCleaning up old decoders. 27/9127/1
Amit Mandke [Thu, 17 Jul 2014 22:01:20 +0000 (15:01 -0700)]
Cleaning up old decoders.
All decoders are part of packet handler now.

Change-Id: I1b896d67f9edcdf8dac67c3ea6688c38ce5227a3
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years ago(1) Added FlowWriter code. (2) Added code to InventoryService to read the address... 05/9105/1
Alex Fan [Thu, 17 Jul 2014 08:29:49 +0000 (01:29 -0700)]
(1) Added FlowWriter code.  (2) Added code to InventoryService to read the address observations.

Change-Id: Ic358509cfecbe38f3285110619913079d974e8f3
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoDo not flood on the node connectors marked as "discarding." 97/9097/2
Alex Fan [Wed, 16 Jul 2014 23:18:12 +0000 (16:18 -0700)]
Do not flood on the node connectors marked as "discarding."

Change-Id: Iffcb467e8cb5c483e3638648af9eea2815f6c2c4
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoAdding loop remover service. 43/9043/2
Amit Mandke [Wed, 16 Jul 2014 01:48:36 +0000 (18:48 -0700)]
Adding loop remover service.
1. Builds MST based on topology.
2. Updates port status based on redundent links.

Change-Id: Iab6428c29b8e7cd52607b8ceac81259cdb9d8b62
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoFixing null pointer exception in packet handler 54/8954/2
Colin Dixon [Fri, 11 Jul 2014 20:32:51 +0000 (15:32 -0500)]
Fixing null pointer exception in packet handler

Change-Id: Ibd8f700af3fc4330d461ada31757bb5eaa0da896
Signed-off-by: Colin Dixon <colin@colindixon.com>
9 years agoRefactor ipv4packet.yang to use already-defined inet types, per Wojciech's previous... 23/8923/1
Alex Fan [Fri, 11 Jul 2014 02:35:50 +0000 (19:35 -0700)]
Refactor ipv4packet.yang to use already-defined inet types, per Wojciech's previous patch.

Change-Id: I9b104b27413bc9cec08946762bc34590c9c1d2f1
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoChange address-tracker.yang to use the vlan-id typedef in ethernet-packet.yang 22/8922/1
Alex Fan [Fri, 11 Jul 2014 02:18:13 +0000 (19:18 -0700)]
Change address-tracker.yang to use the vlan-id typedef in ethernet-packet.yang

Change-Id: Icb008d427c2d42ee3b99c0b445fd7d765f85e6ad
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoAdding arp and ipv4 tests from mininet/wireshark dump. 21/8921/1
Alex Fan [Fri, 11 Jul 2014 02:07:58 +0000 (19:07 -0700)]
Adding arp and ipv4 tests from mininet/wireshark dump.

Change-Id: Ib27962822d587300bee47d387fe55ee945b8a97d
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoFixed a bug in IPv6decoder. 17/8917/3
Alex Fan [Thu, 10 Jul 2014 23:36:18 +0000 (16:36 -0700)]
Fixed a bug in IPv6decoder.

Change-Id: If5d5bd9e6634601ce9a107b2aa2ba8f24181c660
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoAdding handling of IPv6 packets for l2switch-main. 16/8916/1
Alex Fan [Thu, 10 Jul 2014 22:31:33 +0000 (15:31 -0700)]
Adding handling of IPv6 packets for l2switch-main.

Change-Id: Ibbbc4e0b8fcb737cf3ec337e2b9f4c4709b1e1e4
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoRefactor to packet-chain, per Wojiech suggestion. 84/8884/7
Alex Fan [Thu, 10 Jul 2014 02:20:08 +0000 (19:20 -0700)]
Refactor to packet-chain, per Wojiech suggestion.

Change-Id: I0f251c3288ea722fcb1711e0ec984c2fa69f5fd0
Signed-off-by: Alex Fan <railor33@gmail.com>
9 years agoFixed following issues: 36/8836/1
Amit Mandke [Wed, 9 Jul 2014 02:34:25 +0000 (19:34 -0700)]
Fixed following issues:
1. made use of new DataBrokre and removed referece to old DataBrokerService as it is deprecated.
2. fixed a bug in address observer where multiple entries were being made for same address tuple.

Change-Id: I213c2a6df82768a2881bda640cbd9b63d6033ff2
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoMerge "Add generated source as source folder in eclipse"
Amit Mandke [Tue, 8 Jul 2014 22:01:00 +0000 (22:01 +0000)]
Merge "Add generated source as source folder in eclipse"

9 years agoinstantiated ipv4 decoder 23/8823/1
Amit Mandke [Tue, 8 Jul 2014 19:45:23 +0000 (12:45 -0700)]
instantiated ipv4 decoder

Change-Id: Ieaee8a9f17428eea55c3de998d988a3eb591a9c9
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoAdd generated source as source folder in eclipse 20/8820/1
Evan Zeller [Tue, 8 Jul 2014 19:07:42 +0000 (15:07 -0400)]
Add generated source as source folder in eclipse

Signed-off-by: Evan Zeller <evanrzeller@gmail.com>
Change-Id: I63318aec3e316aadc4a6930937024d6ee456e94a

9 years agoSend packetOut for Ipv4 packets too. 67/8767/2
Alex Fan [Mon, 7 Jul 2014 23:48:09 +0000 (16:48 -0700)]
Send packetOut for Ipv4 packets too.

Change-Id: Ie4ea8f5a129887d1bc8344901dd89303184b4277
Signed-off-by: Alex Fan <railor33@gmail.com>