Vishal Thapar [Sun, 22 Jan 2017 09:30:08 +0000 (15:00 +0530)]
BUG 7489: Add startup config file for elanmanager-config
This implements issue 2 mentioned in BUG 7489 by adding a new
configuration file in which user can specify default values for
elan-config at startup.
Note: Update-Strategy is set to None which means any runtime changes to
config will not be reflect till next restart
Path: etc/opendaylight/datastore/initial/config/
Config file name: netvirt-elanmanager-config.xml
Change-Id: I7e3c34166ffd3d8c72f860e1ea34a2c3cc79c309
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Alon Kochba [Wed, 25 Jan 2017 16:47:22 +0000 (18:47 +0200)]
Lower debug level when truncating provider port name
This print shows up a lot in the log, as it is
called on multiple events, whenever the configured
provider port name is longer than 15 chars.
Lowering debug level as it is mostly an internal
translation.
Change-Id: Ic317c96c66cd876e2fd3628b4985ea0abb6d5152
Signed-off-by: Alon Kochba <alonko@hpe.com>
Yakir Dorani [Sun, 22 Jan 2017 17:15:09 +0000 (19:15 +0200)]
Fix ElanStatusMonitorJMX failing upon bundle reinitialization.
Change-Id: I9e04e3ee1b9edc6000439e18b35c729f9ec0f92b
Signed-off-by: Yakir Dorani <yakir.dorani@hpe.com>
Sam Hague [Fri, 27 Jan 2017 19:12:46 +0000 (14:12 -0500)]
Enable checkstyle for fibmanager
Change-Id: I28b903c0d0121af5127baacc8e825e3ee57e9afd
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 27 Jan 2017 17:40:33 +0000 (12:40 -0500)]
Enable checkstyle for natservice
Change-Id: Ica28849eba2b1bfe546861015372c051d50f3b6c
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 27 Jan 2017 17:44:30 +0000 (12:44 -0500)]
Enable checkstyle for neutronvpn api and shell
Change-Id: Ieda73d1d922d4941d8e7a60579da5dfa2ff5957e
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 27 Jan 2017 19:37:23 +0000 (14:37 -0500)]
Disable aclservice tests until fix provided for matchinfo
Change-Id: Icb58828fdc54f640ca5f796d6251fe748881f46c
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 26 Jan 2017 22:22:42 +0000 (17:22 -0500)]
Enable checkstyle for neutronvpn
Change-Id: I51d61224c1f718310798a412b041261c979ac854
Signed-off-by: Sam Hague <shague@redhat.com>
Stephen Kitt [Thu, 26 Jan 2017 20:50:44 +0000 (21:50 +0100)]
Handle the Genius InstructionInfo clean-up
I'd missed a couple of changes... One of the tests is disabled for
now, I'll fix it later.
Change-Id: Ifb313d7e89a24df6a52fff3830ee34a560e50237
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Olga Schukin [Thu, 26 Jan 2017 06:45:16 +0000 (08:45 +0200)]
SNAT tests failures
The rule with empty action list was installed to T47
Change-Id: I8fb81cafb2a7bfd392ce24b73dedf14ab29608bb
Signed-off-by: Olga Schukin <olga.schukin@hpe.com>
Stephen Kitt [Fri, 2 Dec 2016 16:33:30 +0000 (17:33 +0100)]
Fix vpnmanager-impl Checkstyle issues and enforce
This switches Checkstyle to enforcing mode on vpnmanager-impl, and
fixes all the issues apart from exception handling (which I left alone
since it would change the code paths). This includes:
* ordering imports
* removing unused imports
* formatting code (whitespace, line lengths...)
I fixed up some SLF4J uses when it helped with the line wrapping. I've
also fixed up some exceptions and migrated some MD-SAL code to
SingleTransactionDataBroker.
There's also some cleanup in IBgpManager to allow simpler exception
handling in vpnmanager-impl.
Change-Id: I9542a2307c0ab5dd7782e6a4b324d7604452dcab
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 5 Jan 2017 10:54:41 +0000 (11:54 +0100)]
MatchInfo redesign
This uses the new MatchInfo subclasses and drops all references to
MatchFieldType.
Change-Id: I4e17f86b20d2b3f605f728c36871341b177b244b
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 2 Jan 2017 14:48:13 +0000 (15:48 +0100)]
InstructionInfo redesign
This removes all uses of InstructionType in favour of the new
InstructionInfo subclasses.
Change-Id: I4c193c834af165415a8520f800a35fc94aea1134
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Olga Schukin [Mon, 23 Jan 2017 14:52:06 +0000 (16:52 +0200)]
Bug 7660 Infinite loop while vpn instance removal
Sometimes VpnInstanceListener gets into endless loop because not all vpn
interfaces removed successfully.
Analysis:
The current interface counter value inside the function waitForOpRemoval()
can be less that original counter, but still not zero, then we are back to
beginning of the cycle without any action and sleep again.
The infinite loop doesn't allow to DataStoreJobCoordinator to run any
other job within same key.
Change-Id: I31ce3d38fa49212b7736888664a2d597d09f9666
Signed-off-by: Olga Schukin <olga.schukin@hpe.com>
Abhinav Gupta [Wed, 25 Jan 2017 18:49:30 +0000 (00:19 +0530)]
Bug 7384: CSIT Exception: NPE in deleteVpnInterface
getNeutronPort is returning null, causing port.getUUid() to result
in an NPE.
Further analysis necessary as to how it happened in the first place
since port delete event for the port in concern hasn't come.
The introduced check should ensure avoiding this NPE for now.
Change-Id: Ia4298d3b9f2b57b1a94805bca3ae34dffa2df4fe
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>
Olga Schukin [Thu, 19 Jan 2017 11:12:40 +0000 (13:12 +0200)]
Bug 7532 - arp responder rule sometimes missing after vm reboot
VRF entry is not removed during the port down because of wrong value (null string) in the next hop address list.
Change-Id: Ib0a0a84358cce116bdb9c4768ff9d9608f5c638b
Signed-off-by: Olga Schukin <olga.schukin@hpe.com>
Maxime Millette-Coulombe [Thu, 19 Jan 2017 21:01:41 +0000 (16:01 -0500)]
[BUG 7543] Replace the request function used by restangular
Restangular as two methods to fetch data: get and getList.
Those two methods was doing the same things, but it seems
that getList now expect a List of JSON and not an object
who caused the application to crash.
Change-Id: I4aa51860cd03f3f6a04d2322518c7c9c7a1b3092
Signed-off-by: Maxime Millette-Coulombe <mmcoulombe@inocybe.com>
Tomer [Sun, 25 Dec 2016 12:31:02 +0000 (14:31 +0200)]
Bug 7436: Handle VpnInterfaces of VpnInstance
The problem:
VpnOpDataSyncer.waitForVpnDataReady is using java wait method
that does not return the thread to the pool while waiting.
If there are more compute nodes then CPU threads, all threads
in DjC will wait and there will be not availabe thread to
execute the code which waitForVpnDataReady waits for.
The solution:
VpnInterfaceManager holds all vpn interfaces that cannot be processed till the
relevant vpn instance in ready.
Updated the synchronized lock blocks to user vpnInstanceName instead of this.
Added cleanup of removed interface
Change-Id: I66da144356e17e778f1d04e5720befbece565fd5
Signed-off-by: Tomer <tomer.pearl@hpe.com>
Sam Hague [Sat, 14 Jan 2017 13:54:14 +0000 (08:54 -0500)]
Bug 7601 - Cleanup Elan instances when a network is deleted
Fix npe for getNetworkType() being null
Change-Id: I0e7ede43cdd7553b4525f5921b487f7e17c25b52
Signed-off-by: Sam Hague <shague@redhat.com>
Michael Vorburger [Mon, 23 Jan 2017 20:06:14 +0000 (21:06 +0100)]
Replace FindBugs :jsr305 by full :annotation (Bug 7663)
Change-Id: I4e703c6db99e0934952d3636c21f130262a430cf
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Miguel Perez [Fri, 13 Jan 2017 13:13:50 +0000 (14:13 +0100)]
Bug 7536: Static routes not handled when ivpnlink becomes active
+ Corner test case found that if the InterVpnLink is created when
there's no available DPN to be installed in, the InterVpnLink is
correctly created in ERROR state. Next step is to add some static
routes to the corresponding Neutron Router. Third step is to connect
some OVS node to the controller. At this point, the InterVpnLink
is correctly installed on that DPN and the State is correctly set
to ACTIVE... but the Static routes are forgoten.
+ It may look big but it is mostly moving code from
InterVpnLinkListener to InterVpnLinkService
Change-Id: I87018e6cba48146c12fbad0d506445931275977e
Signed-off-by: Miguel Perez <francisco.miguel.perez@ericsson.com>
Tali [Sun, 18 Dec 2016 12:08:57 +0000 (14:08 +0200)]
Spec to support hairpinning of floating IPs in flat/VLAN provider networks
Change-Id: I272bca9991e66111ea96bb87e285720f7cd44ce0
Signed-off-by: Tali <tali.ben-meir@hpe.com>
Michael Vorburger [Mon, 23 Jan 2017 14:58:00 +0000 (15:58 +0100)]
Remove mockito-all to fix NoSuchMethodError: org.hamcrest.Matcher ...
Bug 7662 related
Change-Id: I19f7ba972d7fa86e0fa34a175f2b4734942d2370
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Mon, 15 Aug 2016 14:41:58 +0000 (16:41 +0200)]
elanmanager-impl component test v0.1; coverage from 1.7% to 7.1%
Change-Id: I3d07660ffc913844afc07201ef1854aba93c6aab
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Kency Kurian [Wed, 11 Jan 2017 19:19:34 +0000 (00:49 +0530)]
Bug 7533 : Fix for bind/unbind in DHCP service
- If the unbind is called from interface state listeners there could be
chances of ending up in a race condition in service bind logic and hence
the flow does not get removed.
- Moved the bind service call to interface config listener rather than state
so that the service flows get programmed as soon as the interface is UP.
Change-Id: Iadd3743e47efed9f256612fe8bab7085d3de2d54
Signed-off-by: Kency Kurian <kency.kurian@ericsson.com>
Guy Sela [Thu, 12 Jan 2017 14:50:05 +0000 (16:50 +0200)]
Bug 7530 : ElanPacketInHandler mutexes are too coarse
Mutex for manipulating flows related to MAC was locking on
ELAN + MAC, when could lock ELAN + MAC + DPID. By locking
on the finer-grained mutex, we can support much bigger scale.
Problem occured in scale testing when 180 computes were
getting packet ins with the same MAC (External Network), and
every OVS was competing with all other OVSs for the lock of ELAN+MAC.
ElanPacketInHandler also updates a global data structure
of MACs that must be locked with the coarser mutex of
ELAN+MAC. This is why this patch splits the ElanPacketInHandler
into 2 jobs instead of one.
The transactions there also caused OptimisticLockException because
delete was called and submitted and then put was called and
submitted. This can't work due to the asynchronoush nature of
MD-SAL. There is no need in delete anyway if you call put, so
the delete was removed.
The 10 seconds protection was removed because it is unnecessary
as it already exists in the OVS with a learn rule.
The MAC migration code never worked because the condition could
ever be true there (it's a bug). I preserved the same behavior.
Fixed potential NPE in Etree code
Change-Id: I1aa038f9e0d271b94ffee6076654571b2e811d37
Signed-off-by: Guy Sela <guy.sela@hpe.com>
Michael Vorburger [Tue, 17 Jan 2017 09:48:17 +0000 (10:48 +0100)]
Add missing CacheElanInstanceListener blueprint registration
It appears that this was either forgotten in the initial migration from
CSS to BP, or subsequently lost by mistake? (If on the other hand this
is wrong; then CacheElanInstanceListener should be removed, because it's
effectively "dead code". This change is thus the 'counter-proposal' to
c/50457.
Change-Id: I58e451a00ef662751f54d3243e0dbd907c80c964
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Vivekanandan Narasimhan [Tue, 17 Jan 2017 17:02:15 +0000 (22:32 +0530)]
Bug 7567: External subnet group is not updated with external gwmac
The external subnet group is not getting updated even though
the resolution for external gateway macaddress is successful.
The fix here is to make the the external subnet group programmer
to listen for Learned IP-MAC datastore which would really hold
the external-subnet-gateway-ip TO external-subnet-gateway-mac
mapping.
Also multiple external subnets can share the same subnet ip addresses
and so this patch fixes that too..
Change-Id: Id8c2ba8ace8dbeaf20ceb35d81f43a07e50c3a9f
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>
Guy Sela [Wed, 11 Jan 2017 15:30:40 +0000 (17:30 +0200)]
Bug 7528 : Don't learn the DMAC flows from other DPNs
When working with an elan of type VLAN or FLAT, we shouldn't
learn the known macs from other DPNs. Before calling
programRemoteDmacFlow, validate that the elan is not VLAN or FLAT.
Change-Id: Ib96546aff94bc18f830d72c1735c364f1a21156b
Signed-off-by: Guy Sela <guys.sela@hpe.com>
Miguel Perez [Fri, 13 Jan 2017 11:50:11 +0000 (12:50 +0100)]
Cleanup unused constants in cloud-servicechain-impl
+ Constants referring to Service indexes and table numbers are
centrally located in NwConstants, they shouldnt be here
Change-Id: I3250a8d1976c0b9e18b27960818525dcfb50f35f
Signed-off-by: Miguel Perez <francisco.miguel.perez@ericsson.com>
Marcos López Samaniego [Tue, 13 Dec 2016 18:19:25 +0000 (19:19 +0100)]
Remove unused imports in class VpnUtil
Change-Id: Ica7c47592ef8b05d63ccf174fca3060171338af7
Signed-off-by: Marcos López Samaniego <marcos.lopez.samaniego@ericsson.com>
Stephen Kitt [Thu, 8 Dec 2016 00:52:02 +0000 (01:52 +0100)]
Action redesign: use the new ActionInfo Genius classes
This removes all uses of ActionType, paving the way for its removal in
Genius.
Change-Id: I8c9311a5d37a0e62224ed6fd64c1ff6c23c18b46
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Tue, 17 Jan 2017 12:54:07 +0000 (13:54 +0100)]
Document why ElanInterfaceManager has a setElanUtils instead of DI
This is instead of finishing up
https://git.opendaylight.org/gerrit/#/c/50456/
Change-Id: I9a82de6e6e7c48bd4896fcbdcf39209ef9be5ec8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Marcos López Samaniego [Mon, 9 Jan 2017 14:35:15 +0000 (15:35 +0100)]
Bug 7525 - Inter-VPN link static/connected routes leaking not working
+ Enable static/connected routes in the inter-VPN link creation.
+ Fixed some issues related to routes provisioned after the inter-VPN link.
These issues were affecting the leaking of every kind of route.
Change-Id: Ibb73f86f163f6fe7adf4a26b81ab1ead93855561
Signed-off-by: Marcos López Samaniego <marcos.lopez.samaniego@ericsson.com>
ehvkand [Mon, 16 Jan 2017 09:11:20 +0000 (14:41 +0530)]
Bug 7547 : Ping from DC-GW to invisible ip configured in VM is failing
Change-Id: Iba7869b3ccbaf3f5921c9f705628444aca630996
Signed-off-by: ehvkand <hanamantagoud.v.kandagal@ericsson.com>
Yakir Dorani [Sun, 8 Jan 2017 18:01:07 +0000 (20:01 +0200)]
Fix exceptions when using IPv6 vxlan tunnels
This code deals with two different problems by:
1. Enabling setting an IPv6 address to a router id for IPv6 BGP peering.
2. Enabling setting a tunnel endpoint as the nexthop IPv6 address.
Change-Id: I35a616e2b12b3625c837507f2cb51fc69ff624fe
Signed-off-by: Yakir Dorani <yakir.dorani@hpe.com>
Shashidhar Raja [Wed, 7 Dec 2016 13:00:36 +0000 (18:30 +0530)]
Spec for ACL Statistics
The scope of this feature is to provide additional operational support for
ACL through statistical counters. New feature planned to be supported will
provide additional information on the number of packets dropped by the ACL
rules.
Change-Id: Id3ba370f585c65d718e199177cf07d0a1e7cc382
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Michael Vorburger [Mon, 16 Jan 2017 09:50:53 +0000 (10:50 +0100)]
Remove duplicate dependency openstack.net-virt
Change-Id: I03832a4506a8805040c38e4ddba3f9b7cdeb3af0
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Fri, 13 Jan 2017 21:53:54 +0000 (22:53 +0100)]
de-static-ify ElanUtils field in ElanServiceProvider
I don't see any reason why this needs to be static?
On the contrary, it will only lead to problems in tests.
Change-Id: I711f67a293f59227c4b89f13bad883f72059fc5f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Olga Schukin [Tue, 10 Jan 2017 08:11:00 +0000 (10:11 +0200)]
Bug 7497 - NAPT rules missed for second DPN
Install the group using synced mdsal write to improve the timing.
Change-Id: I3270fa1f1bc3bbccf11d1b02befe76db7f70fcc2
Signed-off-by: Olga Schukin <olga.schukin@hpe.com>
Sam Hague [Sat, 14 Jan 2017 13:23:46 +0000 (08:23 -0500)]
Fix links to openstack images
Change-Id: Ic361aa3b2530f9770c1b2ad6ab27b2760c8d265e
Signed-off-by: Sam Hague <shague@redhat.com>
Miguel Perez [Mon, 19 Dec 2016 15:07:16 +0000 (16:07 +0100)]
Bug 7405: IVpnLink routes not removed from BGP on cascade
+ When the InterVpnLink is removed, the routes that had been
advertised to BGP are not withdrawn in consequence
Change-Id: I795d1ebef26428561eb7307e5a84efdc50343cb7
Signed-off-by: Miguel Perez <francisco.miguel.perez@ericsson.com>
Miguel Perez [Fri, 13 Jan 2017 14:39:47 +0000 (15:39 +0100)]
Cleanup unnecessary 'toStringIpAddress'
+ 'toStringIpAddress' is centralized in NWUtil
+ projects should use that one instead of their own copy
Change-Id: I3f8cf7a33211750aae0cf6050757d9802d66a01a
Signed-off-by: Miguel Perez <francisco.miguel.perez@ericsson.com>
Robert Varga [Fri, 13 Jan 2017 09:07:01 +0000 (10:07 +0100)]
BUG-5222: do not pull in odl-mdsal-xsql
xsql is deprecated, buggy and never was meant for production
use. Do not pull it in.
Change-Id: If247c87058db3d826861dcbcb97be720c27b56f4
Signed-off-by: Robert Varga <nite@hq.sk>
Sam Hague [Thu, 12 Jan 2017 13:18:31 +0000 (08:18 -0500)]
Minor updates to openstack doc
Change-Id: I5097f2d911597c2c97b1564f62d0ba5a08538a5b
Signed-off-by: Sam Hague <shague@redhat.com>
karthikeyan k [Thu, 17 Nov 2016 08:19:09 +0000 (13:49 +0530)]
Bug 7478 : SNAT traffic to use router GW MAC
Problem Statement :
Currently SNAT traffic uses VM MAC as source MAC instead of Router Gateway
MAC
Solution:
Changes has been done for SNAT traffic as source MAC address as Router Gateway MAC Address in
NAPT_OUTBOUND_TABLE(Table=46)
Change-Id: I1563cc9f04d8e479c9c1173644a168262b448d80
Signed-off-by: karthikeyan k <karthikeyan.k@altencalsoftlabs.com>
Signed-off-by: karthikeyan <karthikeyan.k@altencalsoftlabs.com>
Sridhar Gaddam [Wed, 11 Jan 2017 06:42:27 +0000 (12:12 +0530)]
Bug 7520: Avoid creating auto-tunnels for VLAN tenant networks
Currently auto-tunnel code of Netvirt is creating a Transport zone with
vteps even for tenant VLAN networks. This patch updates the code to create
the TZ only if the network type is VxLAN.
Change-Id: Iceeac4dc2dda99a41860d29f5d6f635f964b1a69
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
David Goldberg [Mon, 9 Jan 2017 16:44:23 +0000 (18:44 +0200)]
BUG7318: ETREE ODL learning leaf MACS on wrong tag
Change-Id: I1d65f6d70054eb4d48e6c0b1d158e9104b0c92d4
Signed-off-by: David Goldberg <gdavid@hpe.com>
Vishal Thapar [Sun, 8 Jan 2017 10:34:19 +0000 (16:04 +0530)]
BUG 7488: Autobridge overwrites DpnId if bridge already exists
Change-Id: I49fcc00b116af84609e7f0654072a26f51fa6400
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
VinothB [Wed, 11 Jan 2017 12:51:28 +0000 (18:21 +0530)]
Bug-7363: Fix for Flows are overlapped when we add custom SG along with ANY rule.
*Added reg match condition to avoid flow overlapping issue in other_protocols
Change-Id: Iea12c93a64b418a7e0028359ca54473bac76077b
Signed-off-by: VinothB <vinothb@hcl.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 11 Jan 2017 18:44:56 +0000 (13:44 -0500)]
Use Developer Guide text in place of Documentation
Change-Id: I8ae9301af107f38d20ec0e0307d542eb5016335a
Signed-off-by: Sam Hague <shague@redhat.com>
Stephen Kitt [Wed, 5 Oct 2016 16:59:51 +0000 (18:59 +0200)]
Optional clean-up
Clean up Optional handling using .transform() and .orNull().
Clean up Optional construction using .fromNullable().
Remove Optionals wrapping collections (returning empty collections
instead).
Change-Id: I356152f60bcfcdcd7a21347f925370ad1a5b9a2a
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 5 Oct 2016 16:59:51 +0000 (18:59 +0200)]
Optional clean-up
Fix a couple of invalid Optional uses:
* Optional should never be used instead of a direct null-check;
* Optional should never wrap a collection.
Change-Id: I157aa18cad75461fad79d14a321ad85c35693e1c
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Tue, 10 Jan 2017 10:05:53 +0000 (11:05 +0100)]
Remove xtendbeans direct dependency
because this now gets inherited transitively from
mdsal-binding-test-utils. E.g.
https://git.opendaylight.org/gerrit/#/c/50137/ upgrades the version of
the xtendbeans dependency in mdsal-binding-test-utils, and the fixed
version here unnecessarily ties aclservice to the old version.
Change-Id: Id8f2ba2933d147973fe24bd730ed9d4a156bfc4e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Daniel Malachovsky [Wed, 14 Dec 2016 17:01:27 +0000 (18:01 +0100)]
Replace dlux with dluxapps features
Renaming is due to DLUX project split.
Also, replacing yangui feature with yangman, new, redesigned and restyled
application.
https://wiki.opendaylight.org/view/Weather#Rename_some_odl-dlux-.2A_features_to_odl-dluxapps-.2A
Signed-off-by: Daniel Malachovsky <dmalacho@cisco.com>
Change-Id: If3f0b7641d27855a71d15fce21a2c2dd6a8b1326
Abhinav Gupta [Mon, 19 Dec 2016 10:26:46 +0000 (15:56 +0530)]
Bug 7403 : getl3vpn RPC behavioural issues
Following issues are fixed wrt getL3VPN RPC:
1. When fetches all VPNs and none is present, incorrectly shows error. >>
should display success
2. When all VPNs are deleted after being created, and then the RPC is used
to fetch for all VPNs and none is present, shows success by processing
wrongly. >> logic needs to be hardened.
3. when all VPNs are fetched, vlan-provider implicit VPNs should not be
displayed.
4. When specific VPN is fetched, internal VPNs corresponding to routers
should not be displayed.
5. When specific VPN is fetched, vlan-provider implicit VPNs should not be
displayed.
Change-Id: Ic08bd2fb5b1558e036531e7613e881a42adfd9b1
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>
vinoth [Thu, 29 Dec 2016 17:16:10 +0000 (22:46 +0530)]
Bug 7406: The flows are overridden.
Problem:
The flows are overriddern when multiple router
connect with same external network, due to this
the ping was not succeed in first created router.
Use cases:
* Fix the override problem when connect multiple routers
with same external network.
* The flows were properly create and delete
the multiple VLAN external networks.
* The ping was success all the test cases
for multiple VLAN external networks.
Change-Id: If521912e0a042fac066855c1e045af91c19bd7b6
Signed-off-by: vinoth <m.vinoth@hcl.com>
Alvaro Gonzalez ARROYO [Mon, 12 Dec 2016 11:43:40 +0000 (12:43 +0100)]
Bug 7355: Remove Vrf Entries in a single transaction
Make removeVrfEntries() and removeVrfEntriesByOrigin()
methods to remove Vrf entries in one single transaction
instead of several transactions, one per Vrf entry
to be removed.
Change-Id: I5408c100c17e2f61f41c1f0b754dd38f7b9917fa
Signed-off-by: Alvaro Gonzalez ARROYO <alvaro.gonzalez.arroyo@ericsson.com>
hari.pr [Thu, 29 Dec 2016 15:01:34 +0000 (20:31 +0530)]
Bug 7393: Flows are not getting removed from table:20 and table:90
* Fixed code for removing table#20 flows removal in DistributedArpService.
* Added code for removing table#90 flows removal in SecurityServicesImpl.
Change-Id: I002a245b4cabda190e14eaaa30d7b8c0356056bf
Signed-off-by: hari.pr <hari.pr@hcl.com>
Sam Hague [Tue, 10 Jan 2017 21:50:22 +0000 (16:50 -0500)]
Updates to NetVirt docs from some user feedback
Change-Id: I0f2ce58052d921813b1ae75530aa58eca4cd919d
Signed-off-by: Alon Kochba <alonko@hpe.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Suraj Ranjan [Mon, 21 Nov 2016 10:21:59 +0000 (15:51 +0530)]
Spec for L3Vpn Over Vxlan With Evpn RT5
This spec provides detailed documentaion of Support of VXLAN based
connectivity across Datacenters using EVPN RT5 to achieve L3 connectivity.
Change-Id: Ia65e21e0cc11c86b34f622ad22fa6fd3aacb21db
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
Co-Authored-By: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>
Sam Hague [Tue, 10 Jan 2017 21:22:24 +0000 (16:22 -0500)]
Add basic initial docs for new layout
Change-Id: Ib6588368370f349e6695faa463cd3c847b2921f9
Signed-off-by: Sam Hague <shague@redhat.com>
David Goldberg [Sun, 11 Dec 2016 15:14:51 +0000 (17:14 +0200)]
BUG7339:EtreeLeafBG isn't updated with new remotes
Change-Id: I8d60dd51dc74828ac5b72d8eca66527d2aad029f
Signed-off-by: David Goldberg <gdavid@hpe.com>
Sridhar Gaddam [Fri, 6 Jan 2017 15:55:18 +0000 (21:25 +0530)]
Bug 7476: Configure Reachable Time in IPv6 Router Advt
Currently, ODL IPv6 Router does not specify the "Reachable Time" in the
Router Advts. So, Neighbor unreachability detection algorithm in the
hosts use the default value of REACHABLE_TIME (i.e., normally 30 seconds)
which is distributed with a random factor between MIN_RANDOM_FACTOR (.5)
and MAX_RANDOM_FACTOR (1.5).
In this patch, we configure "Reachable Time" to two minutes to reduce the
number of Neighbor Solicitation messages in the tenant network. In a future
patch, we can make this a configurable value.
Change-Id: Icd40d51d9ec9e34306c1d05fdaa7348fb25ad302
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Ankit Tripathi [Thu, 22 Dec 2016 07:02:40 +0000 (12:32 +0530)]
Scalability of ServiceChainTag
Presently scftag is stored in 8 bits of metadata. Now we are using ovs
register so that 31 bits can be used.
Change-Id: I4debf8d0d649e789f67e2db9d24c146b5d005bd2
Signed-off-by: Ankit Tripathi <ank123it@gmail.com>
Miguel Perez [Tue, 27 Dec 2016 10:53:20 +0000 (11:53 +0100)]
Cleanup about isIpInSubnet
+ Method VpnUtil.isIpInSubnet is already in
Genius's NWUtil class, so it is not needed here
anymore
Change-Id: I7a18eba86e76d06d1d546c6d5b118cce2a46e073
Signed-off-by: Miguel Perez <francisco.miguel.perez@ericsson.com>
Olga Schukin [Wed, 4 Jan 2017 07:59:53 +0000 (09:59 +0200)]
Bug 7496: Errors and exceptions handling
Add fixes of the following problems:
1) TransactionCommitFailedException{message=Data did not pass validation., ...
router-to-vpn-mapping/routermapping does not exist. Cannot apply modification to its children.]]}
at org.opendaylight.genius.mdsalutil.MDSALUtil.syncDelete(MDSALUtil.java:571)
at org.opendaylight.netvirt.natservice.internal.RouterPortsListener.remove(RouterPortsListener.java:93)
2) Exception in thread "..." java.lang.NullPointerException
at org.opendaylight.netvirt.natservice.internal.ExternalNetworkGroupInstaller.installExtNetGroupEntries(ExternalNetworkGroupInstaller.java:79)
3) Exception in thread "..." java.lang.RuntimeException: java.lang.IllegalArgumentException: All keys must be specified for class
org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.elan.rev150602.elan.dpn.interfaces.elan.dpn.interfaces.list.DpnInterfacesKey.
Missing key is getDpId. Supplied key is DpnInterfacesKey []
at org.opendaylight.netvirt.elan.utils.ElanUtils.read(ElanUtils.java:299)
at org.opendaylight.netvirt.elan.utils.ElanUtils.getElanInterfaceInfoByElanDpn(ElanUtils.java:501)
4) Exception in thread "..." java.lang.NullPointerException
at org.opendaylight.netvirt.vpnmanager.VpnInterfaceManager.update(VpnInterfaceManager.java:1243)
5) ERROR | Port Info Config DS to set isFloatingIpDeleted flag as true failed with exception java.lang.IllegalArgumentException:
All keys must be specified for class
org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.floating.ip.port.info.FloatingIpIdToPortMappingKey.
Missing key is getFloatingIpId. Supplied key is FloatingIpIdToPortMappingKey []
6) Exception in thread "..." java.lang.NullPointerException
at org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.removeL3Vpn(NeutronvpnManager.java:1486)
7) Exception in thread "..." java.lang.NullPointerException
at org.opendaylight.netvirt.natservice.internal.NatUtil.getSubnetIpAndPrefix(NatUtil.java:953)
Change-Id: I91053bc78623c68e530f705ee1795d964839df19
Signed-off-by: Olga Schukin <olga.schukin@hpe.com>
Janki [Wed, 21 Dec 2016 15:07:56 +0000 (20:37 +0530)]
Bug: 7422 Resolve checkstyle errors
Fix checkstyle errors at multiple places
Change-Id: I94d424dd9ee773ba65f4c31e51642e3c800c873a
Signed-off-by: Janki <jchhatba@redhat.com>
Miguel Perez [Fri, 30 Dec 2016 11:39:53 +0000 (12:39 +0100)]
Bug 7463: nexthop in leaked routes is wrongly set
+ It is being set as nexthop the String representation of
the Ipv4Address object instead of the value of the Ipv4Address as
a String
Change-Id: Ife91ac823709a80c88b8aacaa03451f2ecac8831
Signed-off-by: Miguel Perez <francisco.miguel.perez@ericsson.com>
Miguel Perez [Wed, 21 Dec 2016 17:50:51 +0000 (18:50 +0100)]
Bug 7423: Clean unnecessary leaked flows and fibEntries
+ Method 'leakExtraRoutesToVpnEndpoint' had been deprecated by method
'handleStaticRoutes' but hadn't been 'switched off', so we had
similar code being executed twice.
Change-Id: I09a3b4e97c26137e8a4dbf593bea403f92428ae9
Signed-off-by: Miguel Perez <francisco.miguel.perez@ericsson.com>
Romanos Skiadas [Wed, 21 Dec 2016 09:39:57 +0000 (11:39 +0200)]
Actually trim whitespace from vtysh output
.replaceAll() does not mutate the string, we need to capture the return and use
that instead.
Change-Id: Ieb3bf226ca9b06a407729f1faeae27841ad1b1b2
Signed-off-by: Romanos Skiadas <rski@intracom-telecom.com>
Olga Schukin [Thu, 15 Dec 2016 10:40:24 +0000 (12:40 +0200)]
Bug 7382: NPE while getting the napt primary-switch-id
Change-Id: I4739695316afca25b0fbe154700000c7f68b3e1b
Signed-off-by: Olga Schukin <olga.schukin@hpe.com>
Olga Schukin [Mon, 2 Jan 2017 08:47:04 +0000 (10:47 +0200)]
Bug 7447: Unexpected flows from T21 to T44 for FIP
The incorrect rules were installed due to not updated DS models
Change-Id: I80b3872c28bc560801e376a158710df70008a2e8
Signed-off-by: Olga Schukin <olga.schukin@hpe.com>
Achuth Maniyedath [Mon, 26 Dec 2016 13:26:31 +0000 (18:56 +0530)]
Spec to setup SMAC on routed packets destined to virtual endpoints
Change-Id: I72a2c008464ac99d7bd2796fae2d89030ee3826c
Signed-off-by: Achuth Maniyedath <achuth.m@altencalsoftlabs.com>
epgoraj [Thu, 22 Dec 2016 10:40:17 +0000 (16:10 +0530)]
BUG:7426 Adding elantag along with mac-address as key to synchronized block
Change-Id: I7d9e677ec071730233b925f9eec0652285cb42a2
Signed-off-by: epgoraj <p.govinda.rajulu@ericsson.com>
Olga Schukin [Wed, 21 Dec 2016 07:55:44 +0000 (09:55 +0200)]
Bug 6866 - missed NAPT rules for second router
Fix the race causing missed NAPT rules while the router creation.
Depends-On: https://git.opendaylight.org/gerrit/49420/
Change-Id: Ica0db89a5de8800090c7cdfc38a0bab2ad1bf12c
Signed-off-by: Olga Schukin <olga.schukin@hpe.com>
Gobinath [Fri, 4 Nov 2016 02:31:35 +0000 (08:01 +0530)]
Bug 7142 - all VpnPortIpToPort entries are lost from ODL cache after
reboot.
As part of this fix we ensure that control path information mapping
a vpn to fixed-neutron-port (gleaned from openstack configuration by
the tenant) is persistently retained inside Config Datastore and so
it will be accessible immediately after ODL cluster reboot.
In addition to that we created a new Operational DS that will
hold discovered IPs from the cloud. In more detail, this review
encompasses:
1. Create a new LearntVpnVipToPort OPERATIONAL Datastore which
will contain discovered IP addresses via GARP/ARP responses.
2. The existing NeutronVpnPortIpToPort will be changed as a pure Config
only Datastore as it will store all Neutron Port and their IP and
MAC Addresses. This datastore will continue to be used
for lookup during ARP resolution and SubnetRoute handling.
3. Decoupling of the mymac changes(subnetMac) from Arp cache feature.
Mymac changes would still be listening to the VpnPortipToPort DS.
4. The ArpNotificationHandler would now modify the LearntVpnVipToPort DS which
the ArpMonitoringHandler would listen to.
The feature which initiates periodic ARP-based location discovery of
non-neutron IPs from the controller brought in via the earlier review
here: https://git.opendaylight.org/gerrit/#/c/45410/
Co-Authored-By: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>
Change-Id: Ic96517f4a57fe547d42495274a74ec5aa32b7d9e
Signed-off-by: Gobinath <gobinath@ericsson.com>
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>
Suraj Ranjan [Mon, 14 Nov 2016 10:53:10 +0000 (16:23 +0530)]
subnet-op-data and port-op-data is empty after cluster reboot
Change-Id: If7e0b5d3109c53eb58505e69a389d15d2f7a6d1e
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
karthikeyan [Tue, 27 Dec 2016 06:05:11 +0000 (11:35 +0530)]
Bug 7444 : External routes are not getting populated
Description:
External routes are not getting populated in fib after recreating vpn and
associating to extnet as well as enable-snat true or false use cases
Solution:
Existing Behaviour:
======================
when disable the SNAT in neutron router, exiting implementation
will get the primary (NAPT) switch id from the DS. When re-enable the
SNAT existing code still it is fetching the primary (NAPT) switch id from
DS. Which leads to get the invalid value (zero) which was set during
disable SNAT.
Changed Behaviour:
====================
When re-enable the SNAT, it invokes the Update() code for re-election process for
getting primary (NAPT) switch id instead of directly querying to DS. Since
DS contains the Invalid (zero) Primary NAPT switch id.
Patch-Set 3: Changes:
==========================
Observed class cast exception when floatingIPHandler.cleanupFibEntries()
method. Changes has been done to declare this method in FloatingIPHandler
Interface to avoid this casting exception.
Change-Id: I8c5cf5fafc79f9933fedbbaad31d9c672696421e
Signed-off-by: karthikeyan <karthikeyan.k@altencalsoftlabs.com>
Marcos López Samaniego [Tue, 13 Dec 2016 16:09:36 +0000 (17:09 +0100)]
Bug 7358 - Inter-VPN traffic is drop when out_port == in_port
Set the in_port field to 0 in table 21 only in this scenario:
- port of type tunnel mpls AND for all BGP only routes
NOTE: This code is already in beryllium. Needed in boron/master.
Change-Id: I9afef768fb0a4c71d9fe4de6bff854aa8f9f7028
Signed-off-by: Marcos López Samaniego <marcos.lopez.samaniego@ericsson.com>
Olga Schukin [Wed, 14 Dec 2016 08:26:53 +0000 (10:26 +0200)]
Bug 7340: overwritten rule in T28 for multi-tenant
Root cause: the key used in the model was including the
internal IP (which is common to the two VMs in the multi-tenanted
environment) instead of the floating IP which is unique.
Fix: build the flow key in the same way as the rule match
Change-Id: Id1b7d8c80f58e42609fa6e279dbca5f95f1639e6
Signed-off-by: Olga Schukin <olga.schukin@hpe.com>
Sridhar Gaddam [Fri, 23 Dec 2016 12:20:34 +0000 (17:50 +0530)]
Bug 7229: Allow certain ICMPv6 NDP packets by default
This patch programs OVS flows to allow ICMPv6 egress packets (from VM POV)
of type 133(RS), 135(NS) and 136(NA). Prior to this patch, these packets
were going through the conntrack module (in stateful implementation) and
were getting dropped as there was an inconsistency in the ct_state between
kernel and user-space conntrack implementations. After discussing this issue
with OVS team, the recommendation was to bypass conntrack for the ND packets.
Change-Id: I1a74046056bd683a71237c7d8ab8ab4606f29a96
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Miguel Perez [Tue, 20 Dec 2016 15:04:02 +0000 (16:04 +0100)]
Bug 7439: Discard internal VPNs for InterVpnLink purposes
+ At InterVpnLink creation, the code must check if there is any
router with a static route pointing to any of InterVpnLink
endpoints. For each router, the VPN to which the router is
attached must be retrieved. However, internal VPNs must be
discarded here.
Change-Id: I9763bf5187fae41d21be1757b49534435ba35071
Signed-off-by: Miguel Perez <francisco.miguel.perez@ericsson.com>
Miguel Perez [Wed, 7 Dec 2016 11:23:39 +0000 (12:23 +0100)]
Bug 7321: ELAN Pseudo-port flows not installed on new DPNs
+ Stateful info about the Elan for cloud-sc was being stored in
CONFIG but it was trying to read it from OPERATIONAL
+ I took the chance of migrating it from AbstractDataChangeListener
to AsyncDataTreeChangeListener since the former is deprecated. This
change seems to fix the problem and now the listener is getting the
DCNs
Change-Id: Ib5b4fad79d7557a9a8d2805fe84f5c42087c51ad
Signed-off-by: Miguel Perez <francisco.miguel.perez@ericsson.com>
cgowdru [Wed, 21 Dec 2016 13:12:32 +0000 (18:42 +0530)]
Bug 7409 - Traffic Drop from NFip VM to FIP VM
Description : when an Non-FIP VM try to reaches FIP, the packet is
forwarded to the DPN1->DPN2 and DPN2(Primary-NAPT) has the SNAT flows.
After going though the SNAT flows, the packet will be sent back to
DPN1 via same vxvlan tunnel-port .
Since the packet entered DPN2 on Tunnel-port and again sent back to same
port(out_port == in_port), because of default OVS split-horizon behaviour
, the packet is dropped.
Changes done in NAPT_PFIB(47) table to add extra action
(load:0->NXM_OF_IN_PORT[]) which nullifes the in_port value thereby
disabling split-horizon-protection.
Change-Id: I7cf80527587114812af992e8c23f88c1164fc9f5
Signed-off-by: cgowdru <chetan.arakere@altencalsoftlabs.com>
Periyasamy Palanisamy [Tue, 20 Dec 2016 09:47:37 +0000 (15:17 +0530)]
Bug 7377, Bug 7383: handling unnecessary error log
* There is no need of quering ElanInterface from config DS since
its reference is already part of the method argument
* Due to faster addition/removal of elan interface, elan interface is deleted
when its queried from installEntriesForElanInterface which caused 7377.
Now this is solved by directly passing elanInterface without querying
config DS.
* potential fix 7383 if mac is already deleted in elan-mac container.
This might occur when same mac is learned again on VLAN provider port
Change-Id: I7ed776a3b9a679ee22427b6f13e5e1a9adce57aa
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>
Tali [Tue, 27 Dec 2016 12:07:54 +0000 (14:07 +0200)]
Bug 7448 - External network recreation fails in newton nodl v2
Network delete in newton/networking_odl v2 resets some provider_attributes
prior to delete using a network-update.
This patch handles that update() by dealing with removing vpninterfaces on the external network.
For the case of network delete no new elements will be deleted as the physical network
is not configured
Change-Id: I4932610316c9445934334bb2211378b507b018f7
Signed-off-by: Tali <tali.ben-meir@hpe.com>
Brady Johnson [Thu, 22 Dec 2016 13:23:14 +0000 (14:23 +0100)]
Fixing removed nsh-aware field from SFC SF data model
- the field was removed in this SFC patch:
https://git.opendaylight.org/gerrit/#/c/49687/
Change-Id: I3ccc3375879bc7a67c097ab0f458ea1592bc9556
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>
Romanos Skiadas [Tue, 20 Dec 2016 13:59:00 +0000 (15:59 +0200)]
Remove unnecessary null checks
The two paths in the ifs reduce to no if
Change-Id: I4635b73672d13ffb8586982d95cc2fa29bcbab50
Signed-off-by: Romanos Skiadas <rski@intracom-telecom.com>
Vishal Thapar [Fri, 16 Dec 2016 06:50:37 +0000 (12:20 +0530)]
Update specs template
1. Removed TODO
2. Added useful links
3. Added Table of Contents
Change-Id: I95438e43e09cb16c047d5a4f90ad8473a7d0ebe1
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Sam Hague [Wed, 14 Dec 2016 22:44:59 +0000 (17:44 -0500)]
Initial layout for NetVirt docs migration
Adding placeholder doc indexes so that the docs project can link
tonetvirt.
Change-Id: Ieb7109217d6d05b31a7d3f287df65441ece83293
Signed-off-by: Sam Hague <shague@redhat.com>
Vivekanandan Narasimhan [Wed, 14 Dec 2016 17:46:09 +0000 (23:16 +0530)]
Bug 7368: VPN Engine unable to process external interfaces
The external network interfaces were not serviced by
VPNEngine due to an NPE that came in via review [1].
Here we fix that NPE and in addition to that
optimize code in VPNEngine to reduce MD-SAL reads.
[1] https://git.opendaylight.org/gerrit/#/c/48991
Change-Id: Ife0091b2bdd6674cc994aca084a9641e81a670ea
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>
Olga Schukin [Tue, 13 Dec 2016 05:53:40 +0000 (07:53 +0200)]
Bug 7260: no rules in table 26 for default route
* the model of router gateway wasn't written to mdsal due to NPE
* fix the race cond when add router gateway port done after handling ext network for this router
Change-Id: Ide2e5d6bb8e90d1d13effb8456aeaed395c9675a
Signed-off-by: Olga Schukin <olga.schukin@hpe.com>
David Goldberg [Wed, 14 Dec 2016 08:12:41 +0000 (10:12 +0200)]
BUG 7359: duplicate local broadcast group backets
In a setup with more than two switches, when creating a network with one
port on each switch, sometimes the remote broadcast group has more than
one bucket directing to the local broadcast group.
because the list was initiated outside the for loop of the switches, the
local brodcast bucket was added to it more than once, hence the
duplication.
Change-Id: Ifa1decd5b238f45f97770e03eb10bd781c24cbfc
Signed-off-by: David Goldberg <gdavid@hpe.com>
Alvaro Gonzalez ARROYO [Mon, 12 Dec 2016 15:53:30 +0000 (16:53 +0100)]
Remove unneeded code from VpnUtil
- Use getOperativeDPNs() from NwUtil and remove same function
from VpnUtil.
- Remove pickRandomDPNs() from VpnUtil.
- Remove buildDpnNode() from VpnUtil.
Change-Id: I75c6de1fa295b4b849625056759180bd358ba9b4
Signed-off-by: Alvaro Gonzalez ARROYO <alvaro.gonzalez.arroyo@ericsson.com>
Alon Kochba [Wed, 30 Nov 2016 14:33:18 +0000 (16:33 +0200)]
Spec for temporary SMAC learning table
Temporary source MAC learning introduces two new tables to the ELAN
service, for OVS-based source MAC learning using a learn action,
to reduce a large scale of packets punted to the controller for an
unlearned source MAC.
Change-Id: Iccc605b23dc8c67f8ddbb03f10b159636ca4fe06
Signed-off-by: Alon Kochba <alonko@hpe.com>
Koby Aizer [Sat, 10 Dec 2016 21:30:22 +0000 (23:30 +0200)]
Cleanup ArpNotificationHandler code
* Remove code duplication between ArpRequestReceived & ArpResponseReceived
* Remove unused functions
* Remove unused imports
* Remove unused deps
Change-Id: Ic2122e7610a42c20ba2ac8c58c991f0a2f166d57
Signed-off-by: Koby Aizer <koby.aizer@hpe.com>
Tali [Sun, 11 Dec 2016 09:57:05 +0000 (11:57 +0200)]
Bug 7077 - NAPT inbound rules never Expire
OFP do not send flow removed notifications via SwitchFlowRemoved but FlowRemoved
Change-Id: I9499412c1d6121d57248de68ec95c75236219ca0
Signed-off-by: Tali <tali.ben-meir@hpe.com>
hari.pr [Fri, 9 Dec 2016 19:03:55 +0000 (00:33 +0530)]
Bug 7333: Fix for Arp flows were not deleted for DHCP port in Control node.
* Problem: when network is removed, arp flows were not deleted for DHCP port in control node.
* Fix: fixed Ips for Dhcp port has been retrieved from local cache and used for deletion.
Change-Id: I6617a9a29f6be5e77d0362f112e38cb74c08df48
Signed-off-by: hari.pr <hari.pr@hcl.com>
Tomer [Wed, 7 Dec 2016 17:00:13 +0000 (19:00 +0200)]
Bug 7319: thread.sleep in group installation
Full BC group installation delay is at least 300ms times number of DPNS in the ELAN.
This has devastating effects in scale setups, which is described in the bug ticket.
Moving the sleep outside of the loop.
Change-Id: I6d0f20a7b9c196fc7118b8d579c53013d4f5cce6
Signed-off-by: Tomer <tomer.pearl@hpe.com>