Sam Hague [Wed, 2 May 2018 21:41:33 +0000 (17:41 -0400)]
Use ifname in place of ifName
JIRA: NETVIRT: 1232
Change-Id: Ia65f2dd43ed2cfd14259617b644663b31381835b
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 2 May 2018 21:37:14 +0000 (17:37 -0400)]
Use transport in cli for http/https
This also allows using tcp or ssl when ovs is wired in.
JIRA: NETVIRT-1232
Change-Id: Icde4ae6684be3adfa03b87d91c952649471adac9
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 2 May 2018 10:46:06 +0000 (06:46 -0400)]
Refactor Model class
- reduce some of the boilerplate code from the classes
- move the get_container and the by_key methods to the
the base Model class
- Added tox integration to run tests
- Changed the way test resources are found so it works
for both tox and other test runners
JIRA: NETVIRT-1232
Change-Id: I86b7c67dd14a4dfdea7b016c21807c47a69539bf
Signed-off-by: Sam Hague <shague@redhat.com>
eaksahu [Mon, 30 Apr 2018 11:52:16 +0000 (17:22 +0530)]
NETVIRT-1227 : L2gw with multisegment network fail
The starting index from segmentation index is 1 not 0 which is another
reason for failure.
Change-Id: Ibc3115ab56c8aa22fd302512d647c52b2dda7bc5
Signed-off-by: eaksahu <a.k.sahu@ericsson.com>
Vishal Thapar [Wed, 2 May 2018 05:31:09 +0000 (11:01 +0530)]
ODLTools: Misc CLI improvements
* Display table name alongwith table id in flow outputs
* Add option to print flow meta info only
* Add option to print flow URLs
* Add option to use https
* Clean-up a stray print of elan interfaces
JIRA: NETVIRT-1232
Change-Id: I719138a6945d854f650931b9e3244861dc64a99f
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
David Suarez [Thu, 12 Apr 2018 19:04:07 +0000 (21:04 +0200)]
Migrate some old Java constructs
- Remove unboxing
- Replace lambdas to method references
- Remove some redundancies
Change-Id: I126ba1e5a5264669a31462ee418d256fb8a8c79d
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Arun Sharma [Mon, 30 Apr 2018 11:50:04 +0000 (17:20 +0530)]
NETVIRT-1225 QOS bandwidth rule not pushed to ovs
Root cause: Configuration fails because config change is not applied
in child node if parent does not exist.
Fix: Use write config transaction 'merge' method instead of 'put'
pass a flag to true to create the parent if does not exist.
this flag is default false in case of 'put'
Change-Id: I0f1a1ae6c6eaf28719969998a7ac147c7be2c236
Signed-off-by: Arun Sharma <arun.e.sharma@ericsson.com>
Arun Sharma [Thu, 19 Apr 2018 18:07:47 +0000 (23:37 +0530)]
NETVIRT-1207 QoS Alert not working
Now karaf uses Log4J2, custom qos alert logger configuration
no longer works. Moved to log4j2 logger and appender config.
Change-Id: Id6105d6734851b6c9d213bdfe8d966a4a42ca9fa
Signed-off-by: Arun Sharma <arun.e.sharma@ericsson.com>
Josh [Mon, 2 Apr 2018 05:28:03 +0000 (08:28 +0300)]
Add doc for debugging port status update
Change-Id: I44a8361f0339b9d6388fc2ef05a47bbdd5fb38e2
Signed-off-by: Josh <jhershbe@redhat.com>
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Sam Hague [Tue, 1 May 2018 20:45:17 +0000 (16:45 -0400)]
Fix outdir to be path arg
Change-Id: Ia06a46f951181608eed1ba62150fc9ad803c90ab
Signed-off-by: Sam Hague <shague@redhat.com>
Vishal Thapar [Tue, 1 May 2018 09:19:51 +0000 (14:49 +0530)]
ODLTools: Misc fixes and additions
1. Add using ifindexes for mapping lport to interface
2. Fix tunnel state always showing none
3. Fix 'show flows elan'
4. Fix dpn to hostname mapping
JIRA: NETVIRT-1232
Change-Id: I9bda2ce3d77c3b011fee8ed308b46957cf199229
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
Stephen Kitt [Mon, 30 Apr 2018 16:24:01 +0000 (18:24 +0200)]
Use managed transactions in fibmanager-impl
This also enforces restrictions on newReadWriteTransaction and
newWriteOnlyTransaction calls, to prevent new code introducing
unmanaged transactions.
Change-Id: Ia850f60e8497f449200aafb99b1cfcd3ec0c0107
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 30 Apr 2018 14:57:45 +0000 (16:57 +0200)]
Use managed transactions in neutronvpn-impl
This also enforces restrictions on newReadWriteTransaction and
newWriteOnlyTransaction calls, to prevent new code introducing
unmanaged transactions.
Change-Id: Iaa7965e8d02327b2345151db62bd5ba847cc04ef
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Nishchya Gupta [Thu, 5 Apr 2018 08:36:54 +0000 (14:06 +0530)]
NETVIRT-1198: Acl Stats does not support Anti Spoof drop stats.
Anti-spoofing stats support was not present currently. Support has been
added, and for implementing that all the drops from Anti Spoofing table
has been redirected to acl committer table by modifing 4th bit in
metatdata.
A new flow has been introduced in committer table with this new
match criteria and their we are dropping all the drop packets.
This new flow will contains all the anti spoof drops and using the cookie, we will
be pulling the table details and displaying anti spoof stats
Change-Id: Ia3009517136d8c00282ed78307c5bf990897e148
Signed-off-by: Nishchya Gupta <nishchyag@altencalsoftlabs.com>
Karthikeyan Krishnan [Thu, 5 Apr 2018 06:57:57 +0000 (12:27 +0530)]
NETVIRT-1171:IPv4 entries appearing in FIB though not associated to Router
Problem Description:
====================
IPv4 entries are appearing in FIB when subnet is not associated to router
in a dualstack network
Solution Description:
=====================
Dual Stack VM has both IPv4 and IPv6 Address, IPv6 or IPv4 subnet only
associated to router means it should show only IPv6 or IPv4 address based
on the subnet address family. To do this behaviour we need to create the
VPN-Interface adjacency based on the subnet associated to router. Have
done the code changes accordingly in VPN-Interface adjacency.
Change-Id: Id1a4712dc1b8be0713fe7dcb526555c5e5021e39
Signed-off-by: Karthikeyan Krishnan <karthikeyangceb007@gmail.com>
xcheara [Thu, 5 Apr 2018 10:19:31 +0000 (15:49 +0530)]
NETVIRT-1194 : NAT has two Listener on Interrface-State Oper DS
Description : Currently, NAT has two listeners on interface-state
Operational DS. One performing operation related to SNAT and other
related to DNAT.
These two Listeners can be combined to one which reduces querying on
certain DS queries commonly done by both of these listeners.
Change-Id: I184d237fa2349dd4c7449120775c1c1c82cd7f50
Signed-off-by: xcheara <chetan.arakere@altencalsoftlabs.com>
Sam Hague [Tue, 1 May 2018 16:40:04 +0000 (12:40 -0400)]
Fix ifname to be ifName
Change-Id: I10111a3a07b1d9c2b71e60e8dfc4eba1aba8f117
Signed-off-by: Sam Hague <shague@redhat.com>
Tom Pantelis [Sun, 29 Apr 2018 21:32:17 +0000 (17:32 -0400)]
Implement AsyncWriteTransaction.commit() in BatchedTransaction
Implement the new commit() method which uses FluentFuture
instead of the deprecated CheckedFuture. The commit() method
is defaulted in the interface but, as soon as all implementations
implement commit(), the deprecated submit() method will be defaulted
instead.
Change-Id: I765ae406308768c819bf1910cfb649cd381fa4cf
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
enavive [Wed, 21 Mar 2018 10:32:24 +0000 (16:02 +0530)]
Provide a class in VPN to manage cluster ownership.
The cluster ownership management can be accomplished
by few approaches. However, this initial review
attempts to decouple the ownershipmanager from the
rest of the vpn system.
Area 1
Review #1
Refer l3vpn-robustness spec: https://git.opendaylight.org/gerrit/69526
Change-Id: Id3f4258ea960728f438d09d41e38a4a677f9362f
Signed-off-by: Vivekanandan Narasimhan <vivek.konnect@gmail.com>
Stephen Kitt [Wed, 11 Apr 2018 14:38:51 +0000 (16:38 +0200)]
Use managed transactions in qosservice-impl
This also enforces restrictions on newReadWriteTransaction and
newWriteOnlyTransaction calls, to prevent new code introducing
unmanaged transactions.
Change-Id: I8d5b1b9686120f4e2870f279b40b49f924b349c3
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 11 Apr 2018 12:48:04 +0000 (14:48 +0200)]
Use managed transactions in statistics-impl
This also enforces restrictions on newReadWriteTransaction and
newWriteOnlyTransaction calls, to prevent new code introducing
unmanaged transactions.
Change-Id: Ic4cb8f955fe7942214a740115934014c0815524c
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Tue, 10 Apr 2018 11:35:53 +0000 (13:35 +0200)]
Prevent new code from using the DataBroker
This introduces a new Checkstyle check to fail the build if code
*calls* the newReadWriteTransaction or newWriteOnlyTransaction methods
in DataBroker. I haven’t found a nice way to make this check
conditional, so for now it’s added via a new parent module,
managed-tx-parent, which is used instead of binding-parent in all
modules which currently support it.
This patch is self-contained, but the plan is to move the Checkstyle
implementation to infrautils and the Checkstyle configuration to
Genius or MD-SAL, alongside ManagedNewTransactionRunner. Once all the
existing code has been converted to use only
ManagedNewTransactionRunner, we’ll be able to apply the configuration
to binding-parent and do away with managed-tx-parent.
Change-Id: I27ab7f0744477606bae04bff31a2148134038bb8
Signed-off-by: Stephen Kitt <skitt@redhat.com>
eupakir [Mon, 9 Apr 2018 12:36:15 +0000 (18:06 +0530)]
NETVIRT-1201 Upstream fixes to master --- 7
Read Vrf Table within the DJC to establish/clear VPN footprint on a
DPN.
Change-Id: I721541334553c89eac7bb06cd6d7071aece75b30
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
eupakir [Mon, 2 Apr 2018 12:56:52 +0000 (18:26 +0530)]
NETVIRT-1190: Local Adjacency for extra-route is not cleaned up from the
vpn-netxhop data-store
Extra routes with one next-hop should be treated as non-ECMP routes. This
fix rectifies a condition to update local-nextHops for extraroutes with
only one next-hop
Change-Id: I7ee18b921f59a320d6d78484e58c9056dd600c08
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
Sam Hague [Mon, 30 Apr 2018 20:56:19 +0000 (16:56 -0400)]
Use ifName instead of ifname
JIRA: NETVIRT-1232
Change-Id: I835e92c5a352e8bc482858739ef1673efa5bdce3
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Mon, 30 Apr 2018 20:09:13 +0000 (16:09 -0400)]
Move ovs under netvirt
JIRA: NETVIRT-1232
Change-Id: Ibc9f5460a42bca1005402b196d3c16c03f53677f
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Mon, 30 Apr 2018 02:03:14 +0000 (22:03 -0400)]
Wire in analzye inventory
JIRA: NETVIRT-1232
Change-Id: I8052cb5aa0f160157ed5801065f7f49fb2bac6ce
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Mon, 30 Apr 2018 01:23:45 +0000 (21:23 -0400)]
Wire in flow commands and parser
JIRA: NETVIRT-1232
Change-Id: Ife96728f41012a4fc1d002e461d19eab652b085a
Signed-off-by: Sam Hague <shague@redhat.com>
Edw7n [Sat, 28 Apr 2018 14:24:42 +0000 (19:54 +0530)]
Elan Junits fixes
follow up to:https://git.opendaylight.org/gerrit/#/c/68187/
Change-Id: Ia20fa0493bfacd1d7ef231d17a28e9ff9017ebbd
Signed-off-by:Edw7n <n.edwin.anthony@ericsson.com>
Sam Hague [Sat, 28 Apr 2018 14:14:22 +0000 (10:14 -0400)]
Bump odltools version to 0.1.2
Change-Id: I5e291fafc021299f439e97f95c6a55808530509e
JIRA: NETVIRT-1232
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Sat, 28 Apr 2018 14:04:50 +0000 (10:04 -0400)]
Add more show and analyze commands
Also renamed the resource model files to not have
: in the name since that is a special character
with Windows.
JIRA: NETVIRT-1232
Change-Id: I2d1dd093451854da1caedffd8d5a2a1ca5602db8
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 27 Apr 2018 11:50:28 +0000 (07:50 -0400)]
Use quotes consistently
JIRA: NETVIRT-1232
Change-Id: If7d435a8f5d58b2a5dc0befbea524357ca69df2a
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 27 Apr 2018 01:16:08 +0000 (21:16 -0400)]
Add setup clean option
JIRA: NETVIRT-1232
Change-Id: I1eb28dfd2c1e70ff284ddf6f63eba28c816d0d1b
Signed-off-by: Sam Hague <shague@redhat.com>
Edw7n [Tue, 10 Apr 2018 15:42:13 +0000 (21:12 +0530)]
itm-direct tunnel related changes for scaling
depends on genius RPC implementation:
https://git.opendaylight.org/gerrit/#/c/68397/
Change-Id: Ib65733e577182067d02d0e90234c06591da09074
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Aswin Suryanarayanan [Fri, 20 Apr 2018 04:42:22 +0000 (10:12 +0530)]
Router internal address not reachable
The router internal address was not reachable since ovs is marking the
packet as -trk. Now -trk packets will be resubmitted to ct to have
second lookup.
This is a workaround until ovs bug is fixed. Now in table 239 ct_clear
is called for both tracked and untracked packet.
table=244, n_packets=39, n_bytes=3822, priority=62030,ct_state=-trk
actions=ct_clear,resubmit(,242)
table=239, n_packets=5, n_bytes=378, priority=100,ipv6
actions=ct_clear,goto_table:240
table=239, n_packets=246, n_bytes=35726, priority=100,ip
actions=ct_clear,goto_table:240
NETVIRT-1064 No connectivity to a router's internal address
Change-Id: Id5b2500822d6cc37c8ee82feae0aa9ee75cb0426
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Aswin Suryanarayanan [Fri, 13 Apr 2018 15:34:30 +0000 (21:04 +0530)]
VMs on tennant vlan network not getting an IP when spwaned after
the networks are added to the router.
The router port elandpnlist didn't have a state. So when the first port
is router port in the list, the elan flows fails.
Check is added to skip router port while checking if a port is the first
one in the list.
NETVIRT-1208 An Instance doesn't get an IP after when a network is added
to a router
Change-Id: I25ea20759eefc3043f1616e7907b0c6916fe90e5
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Sam Hague [Thu, 26 Apr 2018 16:37:33 +0000 (12:37 -0400)]
Move files around to fit pypi better
JIRA: NETVIRT-1232
Change-Id: I0632fbcaa83c20f8ab5fd2f2ccadfe97b389d600
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 26 Apr 2018 23:03:56 +0000 (19:03 -0400)]
rm odltools egg files
JIRA: NETVIRT-1232
Change-Id: I62d29b48c79e76a3a4a548e9b74967be071389a2
Signed-off-by: Sam Hague <shague@redhat.com>
Aswin Suryanarayanan [Thu, 5 Apr 2018 14:31:29 +0000 (20:01 +0530)]
NETVIRT-1157 Stale flows after clearing gateway info from a router
The CentralizedSwitchChangeListener was not able to retrieve the router
object for delete hence added cache for it.
Change-Id: I1a2f10f1667bed3a51275847bba21db39b387e62
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
kiranvasudeva [Thu, 19 Apr 2018 09:03:10 +0000 (14:33 +0530)]
NETVIRT-221: Fixed rules are not added when no SG is associated with the
port.
1. When we add a port with SG disabled and no SG associated, the
port does not have InterfaceAcl Augmentation. this is causing
NullPointerException when port is updated with SG enable. So handled
the NPE, fixed the issue and update flow will add the required fixed
rules.
Change-Id: I0199f7eabad7f1b6caec8ce53412d86e50f63f51
Signed-off-by: kiranvasudeva <kirankumar.v@altencalsoftlabs.com>
eaksahu [Wed, 25 Apr 2018 11:38:58 +0000 (17:08 +0530)]
NETVIRT-1227 : L2gw with multisegment network fail
Because of wrong index being captured in debug mode , failing with
ArrayIndexOutOfBoundException and elan instance creation is failing.
Change-Id: I0ef479bb5e545e4c8587dfa077ab4334afe778b3
Signed-off-by: eaksahu <a.k.sahu@ericsson.com>
HANAMANTAGOUD V Kandagal [Tue, 10 Apr 2018 06:47:57 +0000 (12:17 +0530)]
NETVIRT-1200: Upstreaming fixes 2
VM interface IP not advertised to DCGW via BGP
Issue:
When compute server(CSS) is rebooted , the port state was
transitioning from UP->UNKNOWN and UNKNOWN->UP.The check for
original/updated state in InterfaceStateChange listener update() method
prevented the handling of states.
Fix:
When compute reboots, port state transition can have various
combination. Graceful transition would be UP->DOWN->UNKNOWN and
UNKNOWN->DOWN->UP. But as per the logs we saw UP->UNKNOWN and UNKNOWN->UP.
To handle all posible state transition , now State Transition Table is
introduced.
Change-Id: Ibd79866196f085dab30baaa11d8c5c526567e2fd
Signed-off-by: HANAMANTAGOUD V Kandagal <hanamantagoud.v.kandagal@ericsson.com>
Sam Hague [Thu, 26 Apr 2018 02:06:47 +0000 (22:06 -0400)]
Initial packaging support
Change-Id: I8d93396986ca24a1bb7f267d4fb348008a08f8c2
Signed-off-by: Sam Hague <shague@redhat.com>
Michael Vorburger [Mon, 16 Apr 2018 09:09:52 +0000 (11:09 +0200)]
reduce LOG.error() to debug() in ElanUtils.waitForTransactionToComplete
JIRA: NETVIRT-1215
Change-Id: I32f6273cce59a5cc0b1b03489bab31d2c9622e52
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Mon, 23 Apr 2018 14:23:49 +0000 (16:23 +0200)]
fix error handling in elanmanager-impl workers
It should not log confusing ERROR messages if it will retry (which it
currently does). It should however fail the jobs, and the let the
JobCoordinator log the problem (and increments its failure metrics!) if
the caught RuntimeException is anything else than caused by a
TransactionCommitFailedException (currently that will lead to
addToListenableFutureIfTxException doing nothing and the worker to error
log it, but the JobCoordinator to think the job passed, when actually it
really failed).
This is "take 2" with a self counter proposal to the initial attempt in
change Idf603c6ec8679125a9659378af6627c5fb3eb49e, which would be
abandoned if this was deemed to be a more acceptable solution.
JIRA: NETVIRT-1215
Change-Id: I23be5fae88bf908273c47ade1e74348d1e20dada
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sam Hague [Wed, 25 Apr 2018 21:44:26 +0000 (17:44 -0400)]
Wire in subparsers
Change-Id: I7f4f64ffb4914342e73ea1d35ebd1a74501f2f54
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 25 Apr 2018 16:51:49 +0000 (12:51 -0400)]
integrate various updates
- move model map to models.py
- add json pretty_print for model dumps to files
Change-Id: I0553da82f3fa4f5ca441b45ee3122c6859c8deea
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Mon, 23 Apr 2018 16:07:36 +0000 (12:07 -0400)]
integrate model operations
Change-Id: Ie1dc0946bbe906549a0ea71e59adec69cd2171f8
Signed-off-by: Sam Hague <shague@redhat.com>
Vishal Thapar [Wed, 25 Apr 2018 11:05:12 +0000 (16:35 +0530)]
ODLTools: Capture dumps for all data models
This adds all data models as captured in netvirt CSIT to
get_all_dumps()
Change-Id: Id7a0222915595ee6cf5f74a466bf2038bb10b046
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
Vishal Thapar [Tue, 24 Apr 2018 13:41:41 +0000 (19:11 +0530)]
Fixes and additions
1. Fixes the lport and vrfid masks
2. Adds more dds models to constants for data collection
Change-Id: I652463b1a10a8c011809ae51080657bfd5c1f3f6
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
Stephen Kitt [Tue, 17 Apr 2018 12:46:22 +0000 (14:46 +0200)]
Ensure NeutronPCL txs are closed
This is a minimal set of fixes to ensure that all write transactions
opened in NeutronPortChangeListener are closed.
Change-Id: I705da839bf39e2b6f832e28ba7fcfd625a086387
JIRA: NETVIRT-1210
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sam Hague [Mon, 23 Apr 2018 13:09:07 +0000 (09:09 -0400)]
reduce debug logging
Change-Id: Ieec658adc5a0f3ccfe31daf1d8ee79178c8036d7
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Mon, 23 Apr 2018 13:08:44 +0000 (09:08 -0400)]
change logger format
Change-Id: Ib937127e05f9e735b9e8e28fb3f9cf050e667a75
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Mon, 23 Apr 2018 13:07:50 +0000 (09:07 -0400)]
move deprecated files to old dir
Change-Id: I2c76bc58bb1a42581e5ac6b0dbd8491cc8f82abf
Signed-off-by: Sam Hague <shague@redhat.com>
Siva Kumar Perumalla [Fri, 20 Apr 2018 12:53:53 +0000 (18:23 +0530)]
updating spec with related yang changes.
Change-Id: I4f7ceed89fbca2321eaffbfab010768b70a31885
Signed-off-by: Siva Kumar Perumalla <sivakumar.perumalla@gmail.com>
Sam Hague [Fri, 20 Apr 2018 16:43:53 +0000 (09:43 -0700)]
Refactor odltools to use commands
- changed layout of packages to be more modular
- refactored logging to use a common root config
Change-Id: I88cc012e5599ddc29d75940bea396a4861403097
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Mon, 16 Apr 2018 18:44:18 +0000 (11:44 -0700)]
Fix tox errors in existing specs
Change-Id: Id235926666a2623f943b13bfabc6b43a20eebc5e
Signed-off-by: Sam Hague <shague@redhat.com>
Vishal Thapar [Mon, 16 Apr 2018 07:31:53 +0000 (13:01 +0530)]
Minor fixes and addendums
1. Fix definition for itm-config
2. Add option to specify tmp data directory for logs
3. Changed json file names to .json from .log to distinguish from other logs
4. Add method to generate all json files
Change-Id: I459c66b9c5e64d6de95ab54a7f30a7e57605f003
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
Siva Kumar Perumalla [Mon, 5 Mar 2018 09:29:51 +0000 (14:59 +0530)]
providing range values for min-rx, min-tx of BGP-BFD.
removed threashold,cbit from yang.
Change-Id: I65a45066735646f23c07bc92b098a62af2637638
Signed-off-by: Siva Kumar Perumalla <sivakumar.perumalla@gmail.com>
Somashekar Byrappa [Tue, 17 Apr 2018 12:43:48 +0000 (18:13 +0530)]
Deleted ACL xtend-gen files
Looks like xtend generated files were unintentionally added to git,
hence removing them.
Change-Id: I27066534fbfc68dc4bbcb06970a880d7dbf24280
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>
Stephen Kitt [Thu, 22 Mar 2018 17:24:26 +0000 (18:24 +0100)]
Bump to odlparent 3.1.0 and yangtools 2.0.3
Change-Id: I06d9dadd753b64c3d717b028bb1ddfbcc71a6bf4
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sam Hague [Fri, 13 Apr 2018 15:10:47 +0000 (08:10 -0700)]
Update robotfiles for latest csit format
Change-Id: Id7427b5e164e1ea010c4a208403532e3e2c65b5d
Signed-off-by: Sam Hague <shague@redhat.com>
Loshmitha [Mon, 9 Apr 2018 11:35:48 +0000 (17:05 +0530)]
No option to configure IPV6 on ODL
IPV6 option was not able in ConfigCli so adding the option in it
Issue: NETVIRT-1163
Change-Id: I59262991fba566ad6bbf08c56e9a99529c3d0389
Signed-off-by: Loshmitha <loshmitha@ericsson.com>
Somashekar Byrappa [Mon, 26 Mar 2018 13:30:06 +0000 (19:00 +0530)]
NETVIRT-1193: ACL dropping IPv6 RA packets from external router.
When an IPv6 subnet is created without specifying ipv6_ra_mode,
it is expected that the VMs with this subnet obtains global IPv6
address from non-OpenStack router using SLAAC.
Hence added below ACL flow to allow IPv6 RA packets from external
router if ipv6_ra_mode is not specified.
Since ipv6_src for RA packets are always link-local address, flow
contains match ipv6_src=fe80::/10 to allow from entire link-local
prefix.
cookie=0x6900000, duration=12.117s, table=240, n_packets=0, n_bytes=0, priority=63010,icmp6,reg6=0x400/0xfffff00,ipv6_src=fe80::/10,icmp_type=134,icmp_code=0 actions=resubmit(,220)
Change-Id: I030a99dd2e4385748a6b49cb2735e154b229da01
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>
K.V Suneelu Verma [Thu, 12 Apr 2018 10:30:02 +0000 (16:00 +0530)]
fix unit test failure
Change-Id: I0fdcb1dd54cd59dea5d88734349c7a871cbb34ed
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
Vishal Thapar [Wed, 28 Mar 2018 06:52:52 +0000 (12:22 +0530)]
Add Trunks and duplicate flow analysis
Change-Id: Ieb3cadec7608e58153e0840f4abfa466564c4782
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Sridhar Gaddam [Tue, 10 Apr 2018 17:49:36 +0000 (23:19 +0530)]
Fix NPE in startArpMonitoring for a dual-stack network
Issue: NETVIRT-1206
Change-Id: Ic4ac243fe8378b7fa70606dcaf0bb7937f3fc80b
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Yugandhar Reddy Kaku [Tue, 5 Dec 2017 13:35:12 +0000 (19:05 +0530)]
ELAN L2GW Junit Test Cases
1. verifyL2gw1Connection
verify the dpn macs are programed in tor remote ucast
verify dpn remote broadcast group includes tor endpoint
verify tor1 mcast group includes dpns
2. verifyL2gwMac1InDpns
verify tor mac is programed in dpn
3. verifyL2gw2Connection
verify tor1 mac is programed in tor2
verify tor1 mcast group includes tor2 tep
4. verifyL2gwMac2InTors
verify new tor1 mac is programed in tor2
5. verifyL2gwMacDeleteInTors
verify tor1 mac is deleted from tor2
6. verifyAddDpnAfterL2gwConnection
verify tor macs are programed in new dpn
7. verifyDeleteDpnAfterL2gwConnection
verify tor macs are removed from dpn
verify tor mcast group does not contain deleted dpn
verify dpn mac is removed from tor
8. verifyDeleteL2gw1Connection
verify dpn bc group does not contain tor
verify dpn macs are removed from tor
Change-Id: I648e246079d0c432037a4b6851275e7986ebf753
Signed-off-by: Yugandhar Reddy Kaku <yugandhar.reddy.kaku@ericsson.com>
David Suarez [Wed, 11 Apr 2018 19:22:16 +0000 (21:22 +0200)]
Fix some minor issues found through static analysis
Change-Id: I314bef2f98fceaca399c3a9358b371deae6188eb
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Sam Hague [Thu, 12 Apr 2018 01:25:01 +0000 (01:25 +0000)]
Revert "Disable building sfc by default"
This reverts commit
03b638ad869fc47929e08dfd0464eee13ad357c2.
Change-Id: Id79e47d877428a070573c59c08bd55a78d2025d2
Signed-off-by: Sam Hague <shague@redhat.com>
Jamo Luhrsen [Tue, 10 Apr 2018 20:59:29 +0000 (13:59 -0700)]
Enable building of sfc by default
Change-Id: I7e1dace00f188e9426aee9b433cdce365155d7ab
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Michael Vorburger [Wed, 11 Apr 2018 12:50:20 +0000 (14:50 +0200)]
fix BindingToNormalizedNodeCodec NoClassDefFoundError in sfc.classifier
Change-Id: I4bd5433160af22b8e59ed1dcf95a2439070ddfbd
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Wed, 11 Apr 2018 06:46:27 +0000 (12:16 +0530)]
Missed one listener migration to genius/tools
Change-Id: I7d833da23221c4272834179b2281381cc0c11fd1
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Mon, 9 Apr 2018 10:17:51 +0000 (15:47 +0530)]
Migrate from genius mdsalutil-api/utils to tools-api/utils
Change-Id: I5fa864aa9c206ddbfbdec0012c21f18db2c2abc1
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Deepthi V V [Wed, 4 Apr 2018 12:27:30 +0000 (17:57 +0530)]
Clean up VPN data on VPN delete.
1. When a VRFTable is not created in FIB due to VPN addition, the VRFTable will
not be available during VPN deletion.
2. The prefix-to-interface, l3-nexthop datastores will not have any data for
a vpn, until a vpn-interface is up and running in the network.
Under such conditions VPN deletion causes
ModifiedNodeDoesNotExistException on trying to delete such datastores
which causes entire transaction which handles clean-up to fail, leave
stale-data in the system.
This further causes new VPN-create with same RDs to fail. This review
fixes the issue.
Change-Id: I3011d81907eb32693de3079bd118cfaaf1b9dfcc
Signed-off-by: Deepthi V V <deepthi.v.v@ericsson.com>
Aswin Suryanarayanan [Tue, 20 Mar 2018 15:28:19 +0000 (20:58 +0530)]
NETVIRT-1158 ping to floating IPs of VMs start working only after
pinging from within VM to the outside first
When the packet returned to pipeline after sending to conntrack had
metadata which ofplugin was not able to parse. Now the metadata
associated with conntrack is cleared before resubmitting dispatcher at
table 214.
table=214, priority=62030,ct_state=-new-est+rel-inv+trk,ct_mark=0x1/0x1
actions=ct_clear,resubmit(,17)
table=214, priority=62030,ct_state=-new+est-rel-inv+trk,ct_mark=0x1/0x1
actions=ct_clear,resubmit(,17)
Change-Id: I0c01bb2da5fdc95f6f44e03e2f2d21881a55958b
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
(cherry picked from commit
2c548a85205e2bef3d004e6811423acba277b86e)
Aswin Suryanarayanan [Fri, 6 Apr 2018 06:24:43 +0000 (06:24 +0000)]
Revert "Revert "NETVIRT-430 Ping responder on tenant network and FIP-FIP traffic between vm in same n/w in same compute is not working in stateful SG mode.""
This reverts commit
5cc1d18d2fae5d5590b80e82416170641a786ff0.
Change-Id: I0a8df5496b04c76b71ead3fd2a0006c64d72393b
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
kiranvasudeva [Mon, 2 Apr 2018 15:09:10 +0000 (20:39 +0530)]
NETVIRT-1181: 3 issues related to port-udpate with Allowed address pairs
are addressed in this fix.
1. AAP added as port-udpate, is added for L2Broadcast allow rule.
2. AAP deleted as port-update, is handled to remove L2Broadcast allow
rule only if there is no other aap with same mac.
3. AAP deleted as port-udpate, is handled to remove Dhcp v4 & v6 allow
rule only if there is no other aap with same mac
Change-Id: Id422f2dd828265d12da4cc03b41f6cd4e6967569
Signed-off-by: kiranvasudeva <kirankumar.v@altencalsoftlabs.com>
Sam Hague [Wed, 4 Apr 2018 13:34:20 +0000 (06:34 -0700)]
Add fluorine and oxygen spec dirs
Change-Id: Iabcf865ff32ab6effa0af726bce56d5a61c57000
Signed-off-by: Sam Hague <shague@redhat.com>
eswanit [Fri, 9 Mar 2018 10:44:39 +0000 (16:14 +0530)]
NETVIRT-942, NETVIRT-945 : Conflicting modification for path...
*Conflicting path modification exception is seen for
elan forwarding tables when two methods, removeElanInterface
and removeElanStateForInterface, are trying two remove the
same elan forwarding tables entry
*This is fixed by adding djc for each elan interface for
remove method
Change-Id: I8139e53fe08a236348975e653bf7cad2a32f65da
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>
Tom Pantelis [Wed, 4 Apr 2018 17:38:47 +0000 (13:38 -0400)]
Convert ManagerListener to non-static HwvtepNodeHACache
This one popped up after the original patches to convert to
non-static HwvtepNodeHACache were submitted while ago.
Let's get this patch and the subsequent genius patch that
removes the static version in ASAP to finally put this to bed.
Change-Id: I657aa9d1b2065ac531117fd1236fe44865a8ae1a
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Shaik Zakir [Mon, 26 Mar 2018 05:51:14 +0000 (11:21 +0530)]
NETVIRT-1173 : Prevent SNAT packets unnecessary looping
Problem Description:
======================
We noticed lot of SNAT packets are
getting punted to ODL which is causing delayed installation of certain
flows.
On analysis, it's been obseved that under one more scenario, packets
unnecessarily getting looped for 4 sec between ODL and OVS (threshold time we wait to flow
install before making drop decision)
1) N1-> subnet1 (10.0.0.0/24)
2) R1 and subnet1 added to R1.
3) VPN1(100:1) and R1 added to this VPN.
4) Ext-NET1 created and associated with Ext-BGPVPN.
5) Router-gw-set R1 with Ext-Net1
With this set-up, if following configuration is done,
certain packets are looped due to existing NAT bug
6) create N2(20.0.0.0/24) and associated this with VPN1.
7) Initiate TCP/UDP traffic from VMs of N2.
When first packet punted to ODL Controller, we make an
entry(<routerid>:<VM-IP>:<TCP/UDP Port>) in a map and try to find if
internal-to-external mapping available which will not be available for
N2's subnet(as this is not associated with R1) and we just drop that
packet. But, at this point we not taking care of removing of earlier added
entry. Hence, when the 2nd packet is punt to ODL Controller, this packet simply loops
between ODL<->OVS for 4 sec(same will happened with subsequent packets
too).
Solution Proposal:
==================
Changes done to prevent such packet being send back to OVS which is
causing congestion between ODL<->OVS.
Change-Id: I3215a5230f49e05e820b057d6fba415acad084a8
Signed-off-by: Shaik Zakir <shaikzakir119@gmail.com>
Shashidhar Raja [Thu, 29 Mar 2018 15:27:33 +0000 (20:57 +0530)]
NETVIRT-1188: ACL: Stats not working for ingress direction
Fixed this problem by using lport tag in Cookie for drop flows.
Earlier, metadata matches which was available in pipeline egress side (VM
Ingress) is no longer supported. So, added lport details in Cookie itself
now to uniquely identify drop flows. Aligning with aforementioned changes,
removed metadata matches from direct stats input which only has Cookie
matches now.
Change-Id: Ifac03e75eb42b2a6f9dbd0d14579f462873d9285
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
HANAMANTAGOUD V Kandagal [Thu, 15 Feb 2018 09:14:18 +0000 (14:44 +0530)]
NETVIRT-1068: Upstreaming fixes 2
Issue-1 : When VM is configured with extra-route, refcount in l3nexthop is
incremented. It gets incremented further due to following reasons:
(a) After initial extra-route configuration using command - neutron
router-update RouterA destination=IP-A,nexthop=prefix-A , if another
update is done using command - neutron router-update RouterA
destination=IP-A,nexthop=prefix-B , neutron router listener calls update
on prefix-A as well as prefix-B. On prefix-A , secondary adj (IP-A) is
removed , where as its added on prefix-B. This back-to-back update creates
race-condition in Vrf Engine , leading inconsistencies in l3nexthop,
VpnExtraRoute, VpnInterfaceOp DS. (b) After initial extra-route
configuration using command - neutron router-update RouterA
destination=IP-A,nexthop=prefix-A, if cluster reboot is performed ,
TEP-ADD event triggered the update of FIB entry for IP-A. Update call in
FIB leads to increase in refcount of l3nexthop for prefix-A.
After refcount has reached high number due to issue-(a) and (b) , if VM is
migrated , group will not be programmed on destination DPN,, thus leading
to VM becoming un-reachable.
Fix: For issue-(a) , a temporary fix of 2sec delay is introduced in
neutron. A better fix/design need to be thought to avoid race condition.
For issue-(b) , after cluster reboot , secondary-adj FIB updated is
avoided due to wrong check in updateVpnInterfaceOnTepAdd method. refcount
is removed from l3nexthop yang because , after cluster reboot , due to
multiple Add/Update replays for a given prefix, refcount goes higher than
it should be. Hence prefixes using a group themselves are stored in
l3nexthop , so that even if spurious Add/Update are triggered post cluster
reboot for same prefix , its not updated.
Change-Id: I4618303345db1241b1826b018424b3df0f8bd9ec
Signed-off-by: HANAMANTAGOUD V Kandagal <hanamantagoud.v.kandagal@ericsson.com>
Signed-off-by: Sam Hague <shague@redhat.com>
eupakir [Thu, 29 Mar 2018 11:40:29 +0000 (17:10 +0530)]
NETVIRT-1187 Imported FIB Route is not being translated to flows
Caused due to NPE by calling a getter on a null extra-route object while
processing an imported FIB.
Also, remote table-21 flow creation was broken for imported routes.
Change-Id: Ib3783f9a83cf40d4560e10ba593600f47d3a176b
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
Tom Pantelis [Thu, 28 Dec 2017 18:59:03 +0000 (13:59 -0500)]
Migrate HwvtepHACache users to HwvtepNodeHACache
The static HwvtepHACache instance is replaced by the
HwvtepNodeHACache singleton service so migrate users.
Change-Id: I3bab48856df6d1ccb4aad0d34c90b4d68d64d668
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Stephen Kitt [Thu, 22 Feb 2018 12:51:18 +0000 (13:51 +0100)]
Java 8 migration
* Use method references instead of lambda expressions where
appropriate.
* Use lambda expressions instead of anonymous functions where
appropriate.
* Use Map::forEach instead of streaming over entry sets and retrieving
matching values.
* Use Map::computeIfAbsent instead of manually handling missing
entries.
Change-Id: I815d20d26ad7d7dfdf36b8f11d4d813ebc402457
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 22 Feb 2018 10:46:44 +0000 (11:46 +0100)]
Drop unnecessary explicit types
Change-Id: Id6ea9e86b9c0a3bf9086d2efb7af89e277e2c56c
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 22 Feb 2018 10:42:18 +0000 (11:42 +0100)]
Java 5 migration
* Use foreach loops instead of indexed for loops or iterating while
loops.
* Use String::contains instead of String::indexOf.
* Use StringBuilder instead of StringBuffer, or a collector when the
StringBuffer is only used to join a string collection.
This patch also simplifies the return value handling in
FibHelper::doesPrefixBelongToSubnet.
Change-Id: I13c63380e056cdeaa96090c16fee06316db782d9
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sam Hague [Wed, 4 Apr 2018 12:48:41 +0000 (05:48 -0700)]
Ignore xtend-gen files
Change-Id: I0d198170d15416532c4ea1d67d257b4ca2fc6474
Signed-off-by: Sam Hague <shague@redhat.com>
Nishchya Gupta [Fri, 23 Mar 2018 08:11:59 +0000 (13:41 +0530)]
Removal of deprecated ACL table constants.
With new ACl pipeline old ACL table constants are not deprecated same were
present in Unit tests. Renaming them with new pipeline table names.
Change-Id: I7419897ce5970d14539a0fe442b0abc3700df195
Signed-off-by: Nishchya Gupta <nishchyag@altencalsoftlabs.com>
Sam Hague [Tue, 3 Apr 2018 18:42:30 +0000 (11:42 -0700)]
Disable building sfc by default
Change-Id: Ie64bb828f27d3e6ffc5ecc052fbb06c488f6d62e
Signed-off-by: Sam Hague <shague@redhat.com>
HANAMANTAGOUD V Kandagal [Thu, 15 Mar 2018 05:21:26 +0000 (10:51 +0530)]
NETVIRT-1155: L3nexthop group count is not decremented for extra-route
Change-Id: I666c065ee72bbf604f596ec6c51a745f9466091f
Signed-off-by: HANAMANTAGOUD V Kandagal <hanamantagoud.v.kandagal@ericsson.com>
(cherry picked from commit
596786022adfadabe39b7a4fd30b1a1e3c87139b)
eswanit [Tue, 27 Feb 2018 06:17:29 +0000 (11:47 +0530)]
ELAN Service Recovery
Below service recovery options are supported
for ELAN:
* ELAN service recovery (deregister and register
ElanInterface Listener again)
* ELAN Interface recovery
Change-Id: I7ded46eb34ec6c7942cd4a7903f2ad0a2a01df5d
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>
Josh [Sun, 1 Apr 2018 06:45:17 +0000 (09:45 +0300)]
Add debug log for port status update
Make this puppy a little more debug-able.
Change-Id: Icd927169945112c4b06ff7f2d596a380a455bba3
Signed-off-by: Josh <jhershbe@redhat.com>
karthikeyan [Wed, 21 Mar 2018 10:08:00 +0000 (15:38 +0530)]
NETVIRT-1166:IPv6 NA packet is setting with wrong solicited flag
Problem Description:
====================
Currently ODL IPv6 Service is doing Neighbor Advertisement (NA) for
Neighbor Solicitation (NS) request.
NS packet may contains IPv6 Source Address as below possible way:
:: --> Unspecified
SLL --> Source Link Local Address
When NS packet is punted to the ODL controller, It will prepare the NA
packet and it will send this NA to NS initiated nodes.
NA packet contains IPv6 Destination Address as below possible way based on
the NS packet received.
FF02::1 --> All node multicast IP address (FLAGS: R:1, S:0, O:1)
Dest_LLA --> Destination LLA taken from NS (FLAGS: R:1, S:1, O:1)
Currently ODL controller is setting Solicited Flag=1 for All node
multicast IPv6 address. Which is wrong.
Solution:
===========
ODL IPv6 Service Defined constant with wrong value is the root cause of
this issue. To address this issue have made the changes properly with IPv6
constant.
Change-Id: I0b0868ad78a904c8e7ea4d0d157b16d6ef309974
Signed-off-by: karthikeyan <karthikeyangceb007@gmail.com>
Tom Pantelis [Fri, 30 Mar 2018 17:30:47 +0000 (13:30 -0400)]
Remove config import from inter-vpn-link.yang
CSS remnant - not needed
Change-Id: Icffb5ad18286663862443b2b8e4c1e323c8d96ba
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Stephen Kitt [Tue, 27 Mar 2018 23:37:11 +0000 (16:37 -0700)]
Remove last use of AbstractDataBrokerTest
This has been deprecated in favour of
AbstractConcurrentDataBrokerTest. Note that BgpManagerTest’s tests are
actually useless since they assert that 1 equals 1, but that’s
something for another patch.
Change-Id: I0d9b2a8013754cb56fc2eb111b225a750bdf2e02
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 28 Mar 2018 20:58:36 +0000 (13:58 -0700)]
Remove all dlux dependencies
These were already disabled, this patch removes them.
Change-Id: I5e56495e15e70981382c177700868c3289c5da71
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Siva Kumar Perumalla [Thu, 22 Mar 2018 16:10:42 +0000 (21:40 +0530)]
Opening update server port with specified IP address (if configured)
update server port shall depend on EoS-entity-BGP.
Change-Id: Iad8bb1e1daf318c811453c2ddd622fb7e6187390
Signed-off-by: Siva Kumar Perumalla <sivakumar.perumalla@gmail.com>
Code Review / netvirt.git / log