Bug 1441: Fixed incorrect commas serialization of unkeyed-list.

Change-Id: I467325fdebeca33e8b61054e137290e82f41f6e0
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Bug 1442: Fixed SchemaTracker resolving case children.

Change-Id: I5bfb012bf4bbd5234f31f668a0f17552bdac32b7
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Bug 1441: Expose constructor, which allows to modify initial namespace of JSON Stream.

Change-Id: Ibbfea5c9b57a7608df8faea78ae67d2028adad76
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Fixed getPath in SchemaContextImpl.

Change-Id: I4af93fa9c7aee6342c3a5cfacd8634520fe8ccc2
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

BUG 1441: Fixed JSONNormalizedNodeStreamWriter bug in writing list items.

Change-Id: I3c3b14bd48e2bdbfc126284fe6e4a3e469b7a47e
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Fixed compilation breakage in JSONNormalizedNodeStreamWriter caused by merge job.

Change-Id: I05b9ced5e2cce837df1f86a0804e36bf1a7cf907
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Merge "Fixed SchemaTracker behaviour in choice nodes."

Merge "Hotfix for stmtsep use in YangParser grammar."

Fixed SchemaTracker behaviour in choice nodes.

Change-Id: Ia1ed56a8a263b1d0397ad0c54f9b6e5775939d89
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Merge "Bug 1478 - Autoboxing support"

Merge "Use resolved augmentation schema instead of original schema."

Merge "Replaced harcoded nexus proxy URLs with variable."

Merge "BUG-1440: extract a reusable StringInstanceIdentifierCodec"

Merge "Improve TypeProviderImpl.sortTypeDefinitionAccordingDepth()"

Use resolved augmentation schema instead of original schema.

Change-Id: Ieb6970723539478c72f22e698cf19b05482950a1
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

BUG-1440: extract a reusable StringInstanceIdentifierCodec

Eliminates the helpers package and exposes the mapping utilities in the
yang-data-util package. The utilities can then be reused by the XML
implementation, too.

Change-Id: I20df1b04e6ad875d13d18072852b0f5ac35ab8cc
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Change yang-maven-plugin to write yang files to build output"

BUG-1440: introduce SchemaTracker and use it

Extracts schema tracking from the XML writer, exposes it to the outside
world and teach yang-data-codec-gson how to use it.

Change-Id: I6794273caf75d9c0d94fa7db272acb45f6a34364
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-1440: simplify parsing

Merges the switch statement and push out the value setting into a common
method.

Change-Id: I6b8d8271bd3daab29db8f90a3e7a0a2cd1594043
Signed-off-by: Robert Varga <rovarga@cisco.com>

Add slf4j-simple for tests

Just to activate logging, so we get something, not the NOOP
implementation.

Change-Id: I0c485264bfef4ce9944c970cb453c9049fd44bee
Signed-off-by: Robert Varga <rovarga@cisco.com>

Kill trailing whitespace

Change-Id: If8e0ee748fb3f595f2e3e39ef40800fd35d317d8
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge changes I8a672b0e,I8f0a22a8,I2192d909

* changes:
  BUG-1440: use a precondition instead of a throw
  BUG-1440: remove open-coded Multimap
  BUG-1440: improve CompositeNodeDataWithSchema

Merge changes I0bc3b486,I67f2ca3e,Ie591417d,I01acd9f9,I8e1526a6,I0876d878,I0ed71b9c,I0697d018,I2750f089,I48183547

* changes:
  BUG-1440: add documentation and update API
  BUG-1440: add documentation
  BUG-1440: speed up LoggingNormalizedNodeStreamWriter
  BUG-1441: implement XMLStreamNormalizedNodeStreamWriter
  BUG-1440: fix a few typos
  BUG-1440: speedup namespace/localname splitting
  BUG-1440: speedup namespace resolution
  BUG-1440: cache codecs
  BUG-1440: remove unused imports
  BUG-1440: include gson codec in feature

Merge "BUG-869: minor changes to improve code readability in TypeDefinitionAwareCodec"

BUG-1440: use a precondition instead of a throw

Removes string concat in exception text and makes the code more
readable.

Change-Id: I8a672b0e355b61119db3e48bc290853bbc78a429
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 1443: Make sure that LazyDataObject hashCode computation is consistent

Change-Id: Ib430dabc445975c02d6176e23e4fb9c85b43f906
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Replaced harcoded nexus proxy URLs with variable.

Change-Id: I150dc155c81471d098c974491683d15059805ca0
Signed-off-by: Devin Avery <devin.avery@brocade.com>

BUG-1440: remove open-coded Multimap

The code is completely equivalent with what Guava's Multimap provides,
so let's just use that.

Change-Id: I8f0a22a89c4c31a62f16ebd970f940cfc04af2ff
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-1440: add documentation and update API

Cleans up the API defition, making it slightly easier to understand.

Change-Id: I0bc3b486ec6bc88eea226a6fe39a346775b9e2bc
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-1440: improve CompositeNodeDataWithSchema

- Hide internal state, making fields final
- Preserve field order in augmentations
- Use preconditions and simplify checks
- Emit correct child sizing hints
- Speed up predicate/augmentation builder

Change-Id: I2192d9093aa3909a960f4172468d971d2fd51aec
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-1440: add documentation

Change-Id: I67f2ca3e03216afeb8a4b80105d72347c5a4719c
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-1440: speed up LoggingNormalizedNodeStreamWriter

Precompute indent string as we go, saving some object instantiations.

Change-Id: Ie591417d28066140e99d7718d19d926d1e863d1f
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-1441: implement XMLStreamNormalizedNodeStreamWriter

Introduces a direct NormalizedNode/XMLStreamWriter binding component.

Change-Id: I01acd9f9d9e8c70b3f4cbe796ae2f948073f94f4
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-1440: fix a few typos

Change-Id: I8e1526a67a746006e9c6200d68ca26303846c547
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-1440: speedup namespace/localname splitting

Instead of using splitters, perform just normal lookups.

Change-Id: I0876d8784c35e1911985293c010afcdf8484793e
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-1440: speedup namespace resolution

Use char lookup instead of string.

Change-Id: I0ed71b9c317cafe3847680cb861136cd0258499e
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-1440: cache codecs

Building a codec up is a bit expensive, so let's cache the objects while
we're decoding them.

Change-Id: I0697d018fe3937b8caf97518fd7a5d22ba832c51
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-1440: remove unused imports

These were leftover by previous changes.

Change-Id: I2750f0895fd7fbccb419167eb8e474fc18d26234
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-1440: include gson codec in feature

This updates the feature file to include the yang-data-codec-gson.

Change-Id: I48183547ba70a5f3d866dd9e5e694863d0607a2a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 1478 - Autoboxing support

Change-Id: Id9c812f238c16d6bae2894364a366f6781a986e3
Signed-off-by: Ladislav Borak <lborak@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove explicit final keywords

These context use the filan modifier needlessly, so remove them to get
rid of sonar warnings.

Change-Id: I1ec3133c3978b0cfaa31c74ba57393ff9973ddc6
Signed-off-by: Robert Varga <rovarga@cisco.com>

Compare booleans via equals()

Fixes a sonar warning.

Change-Id: Ifd39bfb8318b406365901117647be581d18ef9e7
Signed-off-by: Robert Varga <rovarga@cisco.com>

IdentifiableItemCodec should be a static inner class

Headline really says it all. There is no reason for
IdentifiableItemCodec to be non-static.

Change-Id: I713625dbea7201a9f11d5431d81584528ddb74aa
Signed-off-by: Robert Varga <rovarga@cisco.com>

Do not use String.toString()

It is obviously not needed. Fixes a sonar warning.

Change-Id: I944acc591793520c62907f90924fc0d730646d49
Signed-off-by: Robert Varga <rovarga@cisco.com>

Improve UnionType.toString()

Do not create itermediate string just to pass it into a StringBuilder.
Fixes a sonar warning.

Change-Id: I424c1686bd919255d306c1934cb67779b7a07f52
Signed-off-by: Robert Varga <rovarga@cisco.com>

Make sure to use exception chaining

Preserving the original exception is critical for finding the root
cause, so let's keep it available via getCause(). Fixes a sonar warning.

Change-Id: I1315d228df13460a76be3e3dd6a97d03ed1723a6
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix ObjectCacheFactory thread safety

The global factory instance needs to be volatile to guarantee proper
visibility. Also fix a sonar warning about field naming.

Change-Id: Ia0fd50d7a2a6210dbda1c1e2f0615ac05512eb64
Signed-off-by: Robert Varga <rovarga@cisco.com>

Uint16 shared instance should be final

Reported by sonar.

Change-Id: I3b33c1d65db865c3bfebf4e455044b3d5a941397
Signed-off-by: Robert Varga <rovarga@cisco.com>

Simplify YangInstanceIndentifier references

Change-Id: I272b332b87f05ef03c27f0e38256c64a70dd92f4
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix SchemaPath.legacyPath visibility

Thread safety is not assured without legacyPath being volatile.

Change-Id: I7e69777cb4af6b3bc359a0a2b218ecdba433f369
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "BUG-576: fixed possible null pointer dereference in BindingGeneratorImpl"

Merge "BUG-1433: augmentation field visibility changed to default"

Merge "Bug 1446: Add new concurrent classes for tracking stats"

Merge "BUG-869: removed redundant check for null before an instanceof"

Merge "BUG-869: added proper handling of nullable parameter"

Merge "Fix to feature files to include ietf-yang-types-20130715"

Fix to feature files to include ietf-yang-types-20130715

ietf-yang-types-20130715 was missing from feature:

odl-yangtools-models

Change-Id: Idb6c6cd2b3377e8f3c18bd1e4b1dd665f00d2642
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Bug 1446: Add new concurrent classes for tracking stats

TrackingLinkedBlockingQueue
    A LinkedBlockingQueue that tracks the largest queue size foridebugging.

CountingRejectedExecutionHandler
    A RejectedExecutionHandler that delegates to a backing RejectedExecutionHandler
    and counts the number of rejected tasks.

DurationStatsTracker
    Class that calculates and tracks time duration statistics.

Change-Id: I1b7bbb45301d8cf682a5de5d51cc64727e3139dc
Signed-off-by: tpantelis <tpanteli@brocade.com>

Merge "Bug 1505 - Provide test coverage for binding-data-codec using sal-test-model"

Merge "Hotfix for gson test."

Merge "BUG-869: avoid String repetition in RestRestconfService."

Merge "BUG-576: fixed invalid key used to search map of modules."

Merge "BUG-576: fixed bug in AbstractSchemaRepository.removeSource"

Merge "BUG-576: added support for handling nested groupings in code generator."

Merge "BUG-576: fixed invalid if conditions in LazyGeneratedCodecRegistry."

Hotfix for gson test.

Test had to be modified prior to internal use of hash sets. Test relied on retrieving first item from
parsedData values. That lead to test failure on various platforms. Now test should run without problems.

Change-Id: Icaa920645c0e12bc922eef131b89e27d7a6b213f
Signed-off-by: Lukas Sedlak <lsedlak@cisco.com>

Hotfix for stmtsep use in YangParser grammar.

The stmtsep can occour 0..n times. Based on that the use of stmtsep? was replaced for stmtsep*
Added definitions for use of extensions outside of body statements in ext-use.yang.

Change-Id: I23092a7a6a5474bfed214ad08f64346a17b13df3
Signed-off-by: Lukas Sedlak <lsedlak@cisco.com>

Merge "BUG-576: fixed test sources loading in YangModuleInfoCompilationTest."

Merge "BUG-869: removed useless null check from DataValidationException.checkListKey"

BUG-869: avoid String repetition in RestRestconfService.

Change-Id: I5dee877114166842dbbbf3596970e0cea55b7686
Signed-off-by: Martin Vitez <mvitez@cisco.com>

BUG-869: removed useless null check from DataValidationException.checkListKey

Null check is useless because

1. it is already performed in call to overloaded checkListKey
2. value is already dereferenced and if it were null a NullPointerException would have occurred

Expression 'if (isLegal == false)' simplified to 'if (!isLegal)'.

Change-Id: I7bf332e99e35d283726e439caf1d2a39a17df932
Signed-off-by: Martin Vitez <mvitez@cisco.com>

Merge "BUG-1590: introduce PathArgument.toRelativeString() and use it"

BUG-869: minor changes to improve code readability in TypeDefinitionAwareCodec

 - String.format should use %n rather than \n
 - removed redundant call to String.toString on known non-null object

Change-Id: Iac2506041184852c1e1e12bab787d1eefef1358b
Signed-off-by: Martin Vitez <mvitez@cisco.com>

BUG-869: removed redundant check for null before an instanceof

No need to check for null before an instanceof, the instanceof keyword returns false when given a null argument.

Change-Id: Ib572460a5972406a6a27347f73e19d27109f994c
Signed-off-by: Martin Vitez <mvitez@cisco.com>

BUG-576: fixed bug in AbstractSchemaRepository.removeSource

Change-Id: If91f1877c1bcd17eab3f547dbe4dc6613421a129
Signed-off-by: Martin Vitez <mvitez@cisco.com>

BUG-869: replaced inefficient use of keySet with entrySet in XmlUtils

Change-Id: Ib665da6c15b6906e6eb220fd0ec53b7ecfbba04f
Signed-off-by: Martin Vitez <mvitez@cisco.com>

BUG-576: fixed invalid if conditions in LazyGeneratedCodecRegistry.

1. fixed check to 'previous instanceof DataNodeContainer' - this check always return true
2. fixed incorrect equals parameter: expected URI but was QName

Change-Id: Ib67ac5b1fc87296bcaa117e9bf1d5f04185c367b
Signed-off-by: Martin Vitez <mvitez@cisco.com>

Improve TypeProviderImpl.sortTypeDefinitionAccordingDepth()

Follow-up patch to . We do not actually need the key, so just use
values() instead of full entries.

Change-Id: Ibb5679bdf0caca140d73eb9ef065db6a58505532
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 1505 - Provide test coverage for binding-data-codec using
sal-test-model

* added test yang modules to bindig-test-model
* added tests for serialization/deserialization of normalized nodes and
paths to binding-data-codec

Change-Id: Ibdf24dd9e51281be488fb40481a79d6f086a2115
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>

Merge "Fixed incorrect instanceof in yang-data-operations."

BUG-576: fixed test sources loading in YangModuleInfoCompilationTest.

Fixed test to parse File sources with relative test.

Change-Id: I4af05166a2c26cf4a3f673b1651ac28c717dd43e
Signed-off-by: Martin Vitez <mvitez@cisco.com>

Merge "Bug 1630: Updated normalized to binding codec to exclude LeafSetEntryNode."

Bug 1630: Updated normalized to binding codec to exclude LeafSetEntryNode.

Change-Id: I8d921ed8d03e19a3fb9868ef9a0a8ebecb02563c
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Merge "Fixed merge job breakage."

Fixed merge job breakage.

Change-Id: I981e5e70e8798492403ef14c9d7af091145765d0
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Merge "BUG-869: reworked check for integer value."

Merge "ModifiedNode instantiation improvement."

Merge "Bug 1258: Implement DataTree partial indexing"

BUG-1630: fix warning message format

The bug has been reasolved by change
I4a35ff27725dab7f35b83ae1bcc6d728a313bd1c, this patch just fixes the
message format.

Change-Id: Ic77f0675c8adb1c6d2ba29ea555335e7eaba4a34
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "BUG-650: add missing bypass"

Merge "BUG-650: improve toYangInstanceIdentifier() speed"

BUG-650: add missing bypass

ChoiceNode is not representable either, so check for it early. Also
eliminate the FIXME, now that we are in the clear about what needs to
happen. Finally log offending class in warning, so we can track it down.

Change-Id: I4a35ff27725dab7f35b83ae1bcc6d728a313bd1c
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Pre-cache child node set"

Merge "Bug 1443: Added support for misplaced augmentations."

Fixed incorrect instanceof in yang-data-operations.

Intended check was to check for AugmentationIdentifier,
AugmentationNode was incorrectly checked.

Change-Id: Ice6f31407c1b8f0bb2400685730324503cd05e44
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Bug 1443: Added support for misplaced augmentations.

Binding Specification reuses elements inside groupings
as part of normal data tree. Augmentations and augmented
cases could be copied by user using copy builders
and may be used at incorrect place, where augmentation
with same data is present.

Binding Data Codec will treat this augmentations as
same, if augmentation definining same data subtree
is present at real location.

Change-Id: Ie232ef9b5e5bbe84f5562bfce612d8ea03b9a9a5
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

BUG-650: improve toYangInstanceIdentifier() speed

This removes a superfluous call to getCodecContextNode(), since that
call is already performed by the InstanceIdentifierCodec.

Change-Id: I2077e70517adf6795f805b6c37c0a7e29b4fb9e5
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-650: clarify BindingNormalizedNodeSerializer API contract

Non-representable YangInstanceIdentifiers are properly reported via a
null return instead of raising an undocumented IllegalArgumentException.

Also does some implementation house-cleaning geared towards performance,
as ArrayList gives better locality.

Change-Id: Iea4717c19587fd2cc1e403aae4c5967811240e9a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove unused arguments from UnionTypeCodec.loader()

The two codecs passed in were unused, so remove them, fix the callsite
and remove the useless warnings suppression.

Change-Id: Ib3d052109303c1c18f9a4d58d2eafeefea37caba
Signed-off-by: Robert Varga <rovarga@cisco.com>

UnionTypeCodec should not throw raw Exception

This is a callable, and we know what types of exceptions can be thrown,
so get rid of the implied sonar warning.

Change-Id: Iab62d6749cd1d33096297c2072e02c42ddebd878
Signed-off-by: Robert Varga <rovarga@cisco.com>