Ed Warnicke [Fri, 19 Dec 2014 22:25:16 +0000 (16:25 -0600)]
Simple whitespace commit to check the JJB sfc jobs
Change-Id: I25035d83d4e68f68b7b6b334ab7552d686d2ceb7
Signed-off-by: Ed Warnicke <[email protected]>
Reinaldo Penno [Fri, 19 Dec 2014 15:57:57 +0000 (15:57 +0000)]
Merge "addressing reinaldo's comments"
Andrej Kincel [Fri, 19 Dec 2014 10:17:33 +0000 (11:17 +0100)]
Sfc-ui patchset
+ inteligent RESTconf URL handling based on URL
on which Sfc-ui is accessed
+ added Delete-all button
+ Classifier moved to RSP (temporary fix for classifier)
Change-Id: Iad908640213bb0133026e7f4c01c44028cecdc94
Signed-off-by: Andrej Kincel <[email protected]>
Paul Quinn [Thu, 18 Dec 2014 13:27:41 +0000 (08:27 -0500)]
addressing reinaldo's comments
Change-Id: I30cb69404dd55730b65205783acd5a93ee68b985
Signed-off-by: Paul Quinn <[email protected]>
ebrjohn [Tue, 16 Dec 2014 09:29:53 +0000 (10:29 +0100)]
Fixing Sonar issues, focusing mainly on renaming constant names.
Change-Id: I830c18c49e6d401d6ab5162b075f8e5e9713d773
Signed-off-by: ebrjohn <[email protected]>
Reinaldo Penno [Mon, 15 Dec 2014 18:34:51 +0000 (10:34 -0800)]
Changed ACl, SCL to reference Rendered Service Paths
Change-Id: I5c956d3d481891767fcdb0558f858e7c4b776fdf
Signed-off-by: Reinaldo Penno <[email protected]>
Andrej Kincel [Thu, 4 Dec 2014 15:47:08 +0000 (16:47 +0100)]
SB REST plugin - initial classifier support
+ listener to ACL datastore
+ put task for ACL (PUT on URL from sfc_agent.py)
When any change is detected in ACL datastore, all classifiers are examined.
The procedure is following:
1. Get all Clasiffiers
2. For each SFF listed in a Classifier
3. Submit (PUT) ACL used in the Classifier to SFF
The functionality needs to be improved according to discussion.
Change-Id: Ib44c4430ef9b65f0140c49ca48e6ed9a8ad6ba9c
Signed-off-by: Andrej Kincel <[email protected]>
Andrej Kincel [Mon, 15 Dec 2014 10:39:29 +0000 (11:39 +0100)]
Sfc-ui - data templates, improved clone button
+ for each create dialog 'default' template is predefined
+ user can create own templates which are stored in browser storage forever
+ clone button now opens edit dialog to allow changes to cloned entity
Change-Id: Ie19f5425763c2106a4f4dc9b9af53e7f26c838d8
Signed-off-by: Andrej Kincel <[email protected]>
Reinaldo Penno [Mon, 15 Dec 2014 04:43:46 +0000 (20:43 -0800)]
Added Python Access List Regression Test
- Small fix to return proper response when agent gets
an access list message and OS is not Linux
Change-Id: Id154dc5255ea788458c849efdd6d64030b6ab533
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Sun, 14 Dec 2014 09:47:08 +0000 (01:47 -0800)]
Classifier code is gracefully bypassed in non-Linux OSs
- Fixed logging on Ubuntu
- Misc fixes
Change-Id: I1972cafad4c045c81b51e67b6a8055f789c9e222
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Sun, 14 Dec 2014 03:32:06 +0000 (19:32 -0800)]
Fixing Classifier Conflicts and Committing
Change-Id: I7a313097eb4bb933c46210112c096bbd2abcbb40
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Sat, 13 Dec 2014 20:31:47 +0000 (12:31 -0800)]
Changed Agent port parameter from sff-port to rest-port
Change-Id: I3857229231335f01484bb1e9ed5a0fb40a201aa6
Signed-off-by: Reinaldo Penno <[email protected]>
Jim Guichard [Sat, 13 Dec 2014 02:25:33 +0000 (21:25 -0500)]
fixed typos in cli and re-added SFF port option
Change-Id: I7c065061b95c6b4afff7ef9ad3dd173aae6c78c7
Signed-off-by: Jim Guichard <[email protected]>
Jim Guichard [Fri, 12 Dec 2014 22:17:26 +0000 (17:17 -0500)]
merged all changes with latest branch. Added check for enabled router.
Change-Id: Ib2405fb335c9da336bf6bbf862d7d8affb595c33
Signed-off-by: Jim Guichard <[email protected]>
Reinaldo Penno [Fri, 12 Dec 2014 21:40:37 +0000 (21:40 +0000)]
Merge "added support for multiple SFF types in sfc_agent create of cli module"
Reinaldo Penno [Fri, 12 Dec 2014 21:40:28 +0000 (21:40 +0000)]
Merge "updated sff_agent to support multiple SFF types created OF cli module"
Paul Quinn [Fri, 12 Dec 2014 18:14:06 +0000 (13:14 -0500)]
added support for multiple SFF types in sfc_agent
create of cli module
Change-Id: I4d33e4b86a0b99a098dc0f686433cdb2861d36fa
Signed-off-by: Paul Quinn <[email protected]>
Paul Quinn [Fri, 12 Dec 2014 18:12:15 +0000 (13:12 -0500)]
updated sff_agent to support multiple SFF types
created OF cli module
Change-Id: I56e5fdf07a05537c0e2923e3992157b97765f4df
Signed-off-by: Paul Quinn <[email protected]>
Konstantin Blagov [Fri, 12 Dec 2014 09:51:37 +0000 (10:51 +0100)]
SB REST autoload at boot
* fixing "Expected but not found" bug
Change-Id: Idf3929c4c7beec72139de992b84e18f7df54916e
Signed-off-by: Konstantin Blagov <[email protected]>
Reinaldo Penno [Fri, 12 Dec 2014 01:17:56 +0000 (01:17 +0000)]
Merge "added ssh processing to send commands to router"
Jim Guichard [Fri, 12 Dec 2014 01:04:43 +0000 (20:04 -0500)]
added ssh processing to send commands to router
Change-Id: Ia1ab7e9164524595434c6c3a5babdbef5cce396e
Signed-off-by: Jim Guichard <[email protected]>
Paul Quinn [Thu, 11 Dec 2014 23:30:12 +0000 (23:30 +0000)]
Merge "added hook to process xe cli in sfc_agent.py added new xe cli module"
Jim Guichard [Thu, 11 Dec 2014 23:19:36 +0000 (18:19 -0500)]
added hook to process xe cli in sfc_agent.py
added new xe cli module
Change-Id: Ia041fd96c10437a5bbef0816be290eb7c0006b88
Signed-off-by: Jim Guichard <[email protected]>
Konstantin Blagov [Thu, 11 Dec 2014 13:47:45 +0000 (14:47 +0100)]
SB REST fix for config subsystem
Change-Id: I287700630acfe2ff2804b3ddc3c52bf854d66c60
Signed-off-by: Konstantin Blagov <[email protected]>
Konstantin Blagov [Thu, 4 Dec 2014 14:42:32 +0000 (15:42 +0100)]
SB REST sfc-production bundle, Karaf feature fix
Change-Id: I561bd4f7ded12f60f56a5305811c155838a5732b
Signed-off-by: Konstantin Blagov <[email protected]>
Reinaldo Penno [Thu, 11 Dec 2014 03:32:22 +0000 (19:32 -0800)]
Revamped SB REST exception handling
- After some testing noticed that the current try/catch/finally
for SB REST were not providing enough detail to debug any
reachability problems. Fixed to catch the appropriate
exception/causes
- Changed a few LOGs from info to debug
Change-Id: Idfabefbb5fc9b3f6795a7e4c3d25ffc404e860fb
Signed-off-by: Reinaldo Penno <[email protected]>
Andrej Kincel [Wed, 10 Dec 2014 12:25:30 +0000 (13:25 +0100)]
Sfc-ui patch based on feedback V
- missing templating
+ added clone function for SF/SFF
+ tables now remember used Filters
+ select box in SFF allows to select unlisted SN
(however, I don't like this approach)
+ some minor string and bug fixes
Change-Id: If024afd4327f09bb620c8f00369db7982df3588c
Signed-off-by: Andrej Kincel <[email protected]>
Reinaldo Penno [Wed, 10 Dec 2014 06:58:02 +0000 (22:58 -0800)]
Data/Control plane Python cleanup
- Coverted most print to logs
- Moved packet header definitions to common module
- Moved global thread dict to common module
- Wrote comments for some functions
Change-Id: I4119f87ed9bc4b6965fcc8fb1f05ab459126a34d
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Tue, 9 Dec 2014 18:28:08 +0000 (10:28 -0800)]
Fixing Sonar bugs related to exception handling
Change-Id: I2b54236d876d7fbb8bd619ddecf11d765f5986fb
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Tue, 9 Dec 2014 08:00:40 +0000 (00:00 -0800)]
Removed Python files that are not maintained anymore
Change-Id: I92fd9dae22e958be19ce4188e39a75f3aa5d46b9
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Tue, 9 Dec 2014 06:26:56 +0000 (22:26 -0800)]
Trying ti fix sonar issue
Change-Id: I987b81cf35fceb428cd4c1a4239d687813c97e34
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Tue, 9 Dec 2014 01:17:27 +0000 (17:17 -0800)]
Fixing POMs
- Fixed some POMs taht maven was complaining during compilation
Change-Id: I2879194a3cce6a64240329b409ad1dfd5b7a0ed5
Signed-off-by: Reinaldo Penno <[email protected]>
Paul Quinn [Mon, 8 Dec 2014 19:53:48 +0000 (14:53 -0500)]
fixed pom.xml nexus proxy dependency
Change-Id: If544a983176fa8a2139c12910483dc2f6ee09ddf
Signed-off-by: Paul Quinn <[email protected]>
Reinaldo Penno [Mon, 8 Dec 2014 17:50:02 +0000 (09:50 -0800)]
Changed sff_rest.py to sfc_agent.py
sff_rest is not a SFF anymore. It has become a SFC agent that creates
SFF, SF and others based on ODL messages.
Change-Id: I30c3465095d6ac332b87ce8cdfbe643a804e7f34
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Mon, 8 Dec 2014 16:45:08 +0000 (08:45 -0800)]
Fix for 'symmetric false' in JSON object
Today there is no support for Yang default statements, therefore
all leafs need to be specified or a check for NULL is needed
Change-Id: I2586a12bdc2da191fd136f30c48d42d6640867ad
Signed-off-by: Reinaldo Penno <[email protected]>
Andrej Kincel [Mon, 8 Dec 2014 15:36:11 +0000 (16:36 +0100)]
Sfc-ui - added Rendered Service Path view
+ tabbed tables are automatically reloading
+ SF REST URI can be configured
+ modal dialogs are now scaling properly
+ a lot of minor bugfixes
Change-Id: Icf8c25bee2649bda5a2568e84ee11d306b2d49d2
Signed-off-by: Andrej Kincel <[email protected]>
Reinaldo Penno [Mon, 8 Dec 2014 05:33:27 +0000 (21:33 -0800)]
Support for Symmetric Paths
- When user creates a service path and service chain has symmetric set to "true"
then SFC Provider will create two RSPs.
- Basically when a SFP is created, Provider will:
* 1 - Create RSP
* 2 - Add Path to SFF State
* 3 - Add path to SF state
* 4 - Check if Chain is symmetric
* 5 - if chain is symmetric repeat 1-3 for reverse path
Change-Id: Ie38808a48c4d2d8132bf82ea4337e1e5712ff1de
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Fri, 5 Dec 2014 20:45:37 +0000 (12:45 -0800)]
Improvements to Data Plane code
- Fixes to prevent looping in certain situations
- Starting index = 255
- Misc Fixes
Change-Id: I780b5b1ebaa4f0963533a7ba0ec7b852e60e51d8
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Thu, 4 Dec 2014 13:04:22 +0000 (05:04 -0800)]
SFF/SF Data Plane fixes
- SF decrements service index properly
- SFF checks if SI == 0
- If SI == 0 SFF decaps packet and transmits
- Properly handles packets with paths that do not exist
- Moved more variables to globals after testing
- Added VXLAN-GPE, NSH headers as comments in the code
Change-Id: I516dbbe36c061681f4f552e0a51e7a914b5715ae
Signed-off-by: Reinaldo Penno <[email protected]>
Jim Guichard [Wed, 3 Dec 2014 23:09:01 +0000 (18:09 -0500)]
added handling for socket error and KeyError
added debug for packet processing
Change-Id: I796546be9f3882d550b1e511f51b64dab26511b1
Signed-off-by: Jim Guichard <[email protected]>
Jim Guichard [Wed, 3 Dec 2014 19:58:19 +0000 (14:58 -0500)]
added class structures to service_function.py for decode
added KeyError checking to service_classifier.py
Change-Id: I24b9e429a959ee47e9d0e5d22efee185c933d071
Signed-off-by: Jim Guichard <[email protected]>
Reinaldo Penno [Thu, 4 Dec 2014 02:59:22 +0000 (18:59 -0800)]
Fixes to SFC Agent, SFF and SF implementations
- SF would not accept packets when SFF on the same host
- SF/SFF now bind to 0.0.0.0 instead of specific IP
- Moved some globals to another module sff_globals.py
- Fixed CLI input for SF/SFF/SFF_CLIENT
- Created shell scripts to start SFC agent and SF
- other Misc fixes
Change-Id: Ia7635659022aeaf0bbb4d937c3f465fa2c6ed02a
Signed-off-by: Reinaldo Penno <[email protected]>
Marcus G. koontz [Mon, 1 Dec 2014 03:40:54 +0000 (19:40 -0800)]
Added Unit Test SfcOpenflowUtilsTest.java
Modified pom.xml for needed dependencies.
Change-Id: I72c5066d553b51c01a926e322bb2563133f3c1c5
Signed-off-by: Marcus G. koontz <[email protected]>
Reinaldo Penno [Wed, 3 Dec 2014 14:36:26 +0000 (06:36 -0800)]
Removed Future callback from DataStoreAPIs
- Other Misc fixes
- More regression tests
Change-Id: If0bde426d70b9e5894409ec86c26b42f45f98e8e
Signed-off-by: Reinaldo Penno <[email protected]>
Andrej Kincel [Tue, 2 Dec 2014 09:50:44 +0000 (10:50 +0100)]
Service function type change to identityref
All changes which were necessary to use service-function-type
identityref instead of using simple String type.
+ updated regression tests
+ UI support
Change-Id: I137d24a662767f1e49fab6088f1cc64a38ca116e
Signed-off-by: Andrej Kincel <[email protected]>
Jim Guichard [Wed, 3 Dec 2014 01:09:14 +0000 (20:09 -0500)]
updated service_function.py to pass server_base_values
updated nsh_service_index.py to receive server_base_values as parameter
Change-Id: I94b384000b6d76279cf40441c6344394557cea67
Signed-off-by: Jim Guichard <[email protected]>
Jim Guichard [Tue, 2 Dec 2014 18:00:00 +0000 (13:00 -0500)]
added vxlan & NSH context decode to service_function.py
moved service index processing to nsh_service_index.py
added a check for service index 0
Change-Id: If85fb64487f9a1700cc17699164317e69522632d
Signed-off-by: Jim Guichard <[email protected]>
Reinaldo Penno [Wed, 3 Dec 2014 05:46:36 +0000 (21:46 -0800)]
More Python Dcloud Regression
Change-Id: Ia56c94ccddd742ccd1ba807dd6b6c5feeca714c5
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Wed, 3 Dec 2014 04:36:35 +0000 (04:36 +0000)]
Merge "Python agent now capable of processing RSPs"
Andrej Kincel [Mon, 1 Dec 2014 15:11:40 +0000 (16:11 +0100)]
Fixing Karaf Webconsole logs
Newer version of Pax Logging is necessary to fix not working logs in Karaf Webconsole.
Solution was found here: https://issues.apache.org/jira/browse/KARAF-2481
However, this fix targets only Karaf 3.0.2 and ODL is still using version 3.0.1.
That's why manual replacement of Pax Logging service/api was necessary.
After Karaf will be updated to version >3.0.2 this fix would not be required more.
Change-Id: Icff9bfe24dd728abe93719bf7f0ea23220a46e84
Signed-off-by: Andrej Kincel <[email protected]>
Andrej Kincel [Mon, 24 Nov 2014 09:27:10 +0000 (10:27 +0100)]
Sfc-ui patch set based on feedback (I, II, III)
+ Added webconsole as boot feature for sfc-karaf
+ SFF set as default view on UI access
+ SN topology showing data from SFF as default
+ Table view for service-function-type
+ RESTconf URL kept in storage of web browser persistently
+ System info tab: karaf features + karaf logs
+ Top menu responsive - in future should be even more improved
+ Fixed UI layout for low-res screens
Change-Id: If10de42271e47ef888c417afb433dcd602065a60
Signed-off-by: Andrej Kincel <[email protected]>
Reinaldo Penno [Tue, 2 Dec 2014 08:14:30 +0000 (00:14 -0800)]
Python agent now capable of processing RSPs
- Python agent can process rendered service path messages
from ODL
Change-Id: I57b05d8bdec9f8d1d434e5a26ab78e0c6e0f6f4a
Signed-off-by: Reinaldo Penno <[email protected]>
Jim Guichard [Mon, 1 Dec 2014 19:02:48 +0000 (14:02 -0500)]
imported nsh_encode and removed build_packet from service_classifier
added parameters into build_packet()
Change-Id: Ib26795461d7ef6ee7b8829d1c00170dc5fa2e51c
Signed-off-by: Jim Guichard <[email protected]>
Jim Guichard [Mon, 1 Dec 2014 18:37:18 +0000 (13:37 -0500)]
initial python service classifier basic implementation
Change-Id: I835d43604a1e16a5ed190222df591d5a30a6393a
Signed-off-by: Jim Guichard <[email protected]>
Robert Varga [Mon, 1 Dec 2014 14:30:01 +0000 (15:30 +0100)]
Add dependency on odlparent
Refers to odlparent as the upstream parent, thus bringing in the
third-party definitions such that they match the larger project-wide
settings.
Signed-off-by: Robert Varga <[email protected]>
Reinaldo Penno [Thu, 27 Nov 2014 06:42:29 +0000 (22:42 -0800)]
Introduced Rendered Service Path
One of the problems with the current code is that the constructed
service path is written in the config data store by merging SFF/SF
information with config provided by the user. This is very bad and I
tried to avoid changing this but it needs to be done if we are serious
about SFC.
The problem is that after SFC provider modifies the SFP with data from
SFF, SF, etc and commit its, it triggers the listener again, which
recreates the path again, which triggers the listeners again, in an
infinite loop. Today I break the loop by using a trick but it makes
the code fragile, specially in the face of modifications, as opposed
to SFP creations.
So, thinking about making the code rock solid, this is what I will be
working on (let me know feedback):
- I will introduce a new yang model called “Rendered Service Path”.
The IETF architecture document actually has this construct. This will
be an operational yang model. Meaning it can not be changed by the
user.
- When user creates a SFP, provider will include SFF/SF
information and save it in a RSP. This will not trigger any listener
and information will be protected from RESTconf.
- Modificationsto SFP by the user will carry to RSP but not
vice-versa (of course). This makes the code much more reliable and
predictable. It also makes it easier for the Python agent since
there is no confusion about what is actually something it needs
to act on (RSP) versus something
that might not be complete (SFP).
- Changed SF and SFF operational containers. Changed from leaf-list
to list because it is error prone and tricky to update leaf-lists
in ODL. It requires reading the list, copying, updating and
writing it back. In the case of list a single indexe operations
to add/delete/update is possible.
- Changed SFcProvider*API to use new DataStore APIs. This reduced a lot
of repetitive code
- Removed dead code
Change-Id: I42cfda4c2a83c0e651523852c3c0dc064dbe7127
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Wed, 26 Nov 2014 03:40:18 +0000 (19:40 -0800)]
Introduced strong synchronization
- Strong synchronization across listeners with Locks and synchronizaed
- Strong synchronization in checked future callback with semaphores
- Fixed several logs
- Added more javadocs
- Removed busy wait form SfcDataStoreAPIs
Change-Id: I4d58ea8c13be61b1fc6aac96e29400939a661b5c
Signed-off-by: Reinaldo Penno <[email protected]>
Konstantin Blagov [Tue, 25 Nov 2014 13:20:01 +0000 (14:20 +0100)]
SB REST plugin & Karaf features
(port fixed after code review)
Change-Id: I44b0a086235557feda4a4d50b7560678624d0306
Signed-off-by: Konstantin Blagov <[email protected]>
Reinaldo Penno [Tue, 25 Nov 2014 08:30:34 +0000 (00:30 -0800)]
Critical Bug fixes and Enhacements
- Added javadoc to many methods
- Introduced wrappers around datastore API. These wrappers take care of retries, logging,
check whether transaction is in progress, etc
- Added more tests to Python dcloud regression. Now it checks for operational state
correctness as well
- As much as possible changed most methods to use new datastore wrappers.
- Introduced rest:uti to SF Yang. This will allow python agent to manage SFs
- Removed dead code
- Fixed several conditions where operational state was not cleared after delete
- Fixed several concurrency issues
- Fixed SFcDataStore callback to take into account transactions in progress
- Fixed logging in multiple places
- Added more documentation to Python SFC agent and SFF thread
Change-Id: If90a0c45ed928b59a5f4634c18ed2819c6723c59
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Fri, 21 Nov 2014 00:52:19 +0000 (16:52 -0800)]
Bugs and Enhancements to SB REST and SFF/SF Data Plane
- Expanded and cleared considerably the Python refernce implementation.
- There are now mseparate modules for NSH encode, decode
- Module for SFF client
- Self contained module for SFF
- Module of SFF with REST
- An agent based module that creates SFF on the fly, meaning no
pre-configuration needed. This will probably become the future
of data plane side ODL SFC.
- In next commits will enahnce agent to create SFs on the fly as well.
- SFF now uses a dictionary indexed by sfp-id and sfp-index to
lookup next SF/SFF. This is an considerable improvement over the
preivous method.
- Fixed an issue on the SB REST where SFP were not communicated down
- Fixed an issue where SFPs were deleted more than once. Not really
a biggie given DELETE is idempotent but still worth it.
- Service locator Yang now can be configured with a local function
Change-Id: Ic89f175781f29eea7b2aeef7e9e748cc624be6bb
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Thu, 20 Nov 2014 17:37:06 +0000 (17:37 +0000)]
Merge "Sfc-UI classifier functionality"
Reinaldo Penno [Thu, 20 Nov 2014 17:36:52 +0000 (17:36 +0000)]
Merge "Sfc-provider classifier functionality"
Reinaldo Penno [Tue, 18 Nov 2014 10:05:32 +0000 (02:05 -0800)]
SFF REST server that configures SFF data plane implementation
Fixed a few other bugs on reference SFF implementation
Change-Id: Ie4342470dee8b2981a85fa5d4ff89a19a21fde96
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Mon, 17 Nov 2014 23:42:00 +0000 (15:42 -0800)]
Bugs in SFF refernece implementation
- When decoding NSH v3 packets, there were a couple of
off-by-one erros
Change-Id: I110f8e2732034c6f85899efdaf03d8710928d93d
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Mon, 17 Nov 2014 11:43:19 +0000 (11:43 +0000)]
Merge "Changed messages based on list feedback"
Reinaldo Penno [Mon, 17 Nov 2014 10:09:53 +0000 (02:09 -0800)]
Changed messages based on list feedback
Changed and clarified some messages from error to warning or info.
The conditions were not errors.
Changed REST abstract class exception handling to differentiate
between REST Server not responding and invocation exception.
Change-Id: I7349f1d0c4fa3ceabfe1d7c1c006d12b269e40ab
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Fri, 14 Nov 2014 12:49:30 +0000 (12:49 +0000)]
Merge "Several bug fixes and Python SFF/SF reference implementation"
Reinaldo Penno [Fri, 14 Nov 2014 12:35:36 +0000 (02:35 -1000)]
Several bug fixes and Python SFF/SF reference implementation
Introduced a CheckedFuture callback implementation
Started using CheckedFuture for some transactions
Fixed a bug with SB REST where the URI was not extracted from model correctly
Fixed handling of exceptions in SB REST code
Added LOGs to several transaction
Added a new directory and Python reference implementations of SFF/SF
Fixed minor bugs with SFC python regression
Change-Id: I56811650900eb44818ae144368969bb01a8d5274
Signed-off-by: Reinaldo Penno <[email protected]>
Andrej Kincel [Tue, 11 Nov 2014 15:17:41 +0000 (16:17 +0100)]
Sfc-UI classifier functionality
+ UI modified according to changes proposed in commit:
Sfc-provider classifier functionality
Signed-off-by: Andrej Kincel <[email protected]>
Andrej Kincel [Thu, 6 Nov 2014 08:43:42 +0000 (09:43 +0100)]
Sfc-provider classifier functionality
+ classifier yang model change
+ classifier entry listener
+ basic API for ACL
How it works:
Whenever Classifier is attached to SFP it creates mapping between SFP <-> ACL.
Then, Classifier entry listenter calls method from ACL API which will update ACL
entries to point to the SFP.
If it comes to change of ACL in Classifier, old ACL entries are unset,
thus are not pointing to the SFP anymore. The new ACL is updated
appropriately.
Change-Id: Iba179fedee05756dbd3101242a481866ddfcba24
Signed-off-by: Andrej Kincel <[email protected]>
Andrej Kincel [Tue, 4 Nov 2014 07:28:26 +0000 (08:28 +0100)]
SFC-UI - several fixes and improvements
+ Updated SFF table view
+ Fixes in SFF create/edit dialog
+ All select boxes can now be reset to no value selected (initial state)
+ Classifier create/edit dialog ehancements
Change-Id: Ib2cfaa097644bd1ccc63591f6c9cca5cb3b1b099
Signed-off-by: Andrej Kincel <[email protected]>
Signed-off-by: Martin Lauko <[email protected]>
Andrej Kincel [Thu, 30 Oct 2014 16:29:35 +0000 (17:29 +0100)]
SFC-UI - adapted to new YANG models
+ Support for classifier CRUD operations
+ Classifier is now attachable to SFC
+ SFF adapted to new YANG models
+ SFF now supports OVS augmentation
+ various bug fixes and improvements
Change-Id: I51f5625bf845be681a2f1407d976f182bedc05da
Signed-off-by: Andrej Kincel <[email protected]>
Signed-off-by: Martin Lauko <[email protected]>
Andrej Kincel [Mon, 27 Oct 2014 11:12:27 +0000 (12:12 +0100)]
SFC-UI - SFP support for context metadata
+ Context metadata can be attached to existing SFP
+ Bugfix for ACL create/edit dialog
+ Improvements in SFC create dialog
Change-Id: Ibb7155b8f0395b3908f5d4e70cee6993894b9b77
Signed-off-by: Andrej Kincel <[email protected]>
Andrej Kincel [Tue, 21 Oct 2014 06:43:49 +0000 (08:43 +0200)]
SFC-UI added metadata functionality
+ new tab NSH metadata
+ possibility to define context/variable metadata
+ attachment to SFP/ACL is prepared but disabled at the moment
(because of missing YANG models)
Change-Id: Ief2b7dae731b92d928ee04211a61e14c48e9b316
Signed-off-by: Andrej Kincel <[email protected]>
Reinaldo Penno [Wed, 5 Nov 2014 19:35:20 +0000 (11:35 -0800)]
Fixes to SouthBound REST
- When a SFF is created/modified, we send to the REST URI founds in the
SFF config ("rest-uri") instead of a generic URI
- When a SFP is created/modified, we send only to the SFFs found in the
service-hop list. For this we also use the rest-uri found in the SFF
config
Change-Id: I8bd4905c6ededb9fb5003adaa00bca338673c8a1
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Mon, 3 Nov 2014 03:21:35 +0000 (19:21 -0800)]
Fixes and Enhancements to REST and Generics API
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Fri, 31 Oct 2014 11:38:58 +0000 (04:38 -0700)]
More fixes and Robustness changes
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Fri, 31 Oct 2014 07:07:01 +0000 (00:07 -0700)]
Several Fixes in the REST code and Listeners
Signed-off-by: Reinaldo Penno <[email protected]>
Andrej Kincel [Wed, 29 Oct 2014 08:47:36 +0000 (09:47 +0100)]
Fixed bootstrap files
+ added order to service-function-chains
+ updated boostrap files for sfc-distribution
(service-function-forwarders were loaded properly in karaf but not in
sfc-distribution)
Change-Id: Ia5aa80c95b0bfdf1cfbfeb42d3bb3b07b3e76f2b
Signed-off-by: Andrej Kincel <[email protected]>
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Sun, 26 Oct 2014 23:04:41 +0000 (16:04 -0700)]
Modified yang models, setup scripts and provider
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Sun, 26 Oct 2014 06:09:49 +0000 (23:09 -0700)]
Modified SFF OVS Model and Python scripts
- Changed SFF and SFF OVS models after studying dcloud setup
Now, each sff data plane locator is augment to have bridge name
and other OVS data. Same for sff-sf data plane locators
- Modified SFF bootstrap config to account for change
- Created Python script to setup all dcloud config in ODL in a single sweep.
- Modified gitignore to ignore pyc files
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Thu, 23 Oct 2014 10:48:55 +0000 (03:48 -0700)]
New Classifier Model
- Classifier model
- Metadata model reference in SFP
- Removed old model directory
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Sat, 4 Oct 2014 17:01:50 +0000 (10:01 -0700)]
Typdefs for Metadata Model
Signed-off-by: Reinaldo Penno <[email protected]>
Reinaldo Penno [Sat, 4 Oct 2014 16:07:21 +0000 (09:07 -0700)]
Metadata Model
- Any number of Context headers and TLV headers can be
build independently
- Headers can be attached to SFPs
Signed-off-by: Reinaldo Penno <[email protected]>
Vinayak Joshi [Mon, 3 Nov 2014 09:54:02 +0000 (09:54 +0000)]
Merge "Enabling Acl entries for ping"
Konstantin Blagov [Fri, 17 Oct 2014 13:20:59 +0000 (13:20 +0000)]
Merge "SFC-UI - added classifier functionality"
Andrej Kincel [Thu, 16 Oct 2014 07:26:01 +0000 (09:26 +0200)]
SFC-UI - added classifier functionality
+ added ACL (classifier) tab
+ added support for all types of service locators
+ allowed addition of plain SFF to SFP
+ validation is now showing incorrectly filled inputs
+ ipv4/ipv6 validation now supports ip/mask CIDR notation
+ fixed modal dialogs css (is not stretching the window anymore)
+ added new tests
+ various bug fixes and improvements
Signed-off-by: Andrej Kincel <[email protected]>
Signed-off-by: Martin Lauko <[email protected]>
Paul Quinn [Thu, 16 Oct 2014 19:49:38 +0000 (15:49 -0400)]
big 2133: odl-mdsal-apidocs need to be part of SFC Karaf distribution
Change-Id: I850b25843dd04b288ef3f9e8ebc749dcdd969f6b
Signed-off-by: Paul Quinn <[email protected]>
Reinaldo Penno [Mon, 6 Oct 2014 18:32:21 +0000 (11:32 -0700)]
Overall hardening of the code
- Overall hardening of the code
- Expansion of regression testing
Change-Id: Ib62aae644d85e47ee8c14fc8566556db413082aa
Signed-off-by: Reinaldo Penno <[email protected]>
(cherry picked from commit
0ed2f0614b0076e3fbe22b2beedae52df0b9c28e)
Reinaldo Penno [Fri, 10 Oct 2014 03:44:29 +0000 (20:44 -0700)]
Incrementing versions by 0.1.0 for post-helium master branch
Change-Id: I1ca0a618b1a412f847fdfa91a2304c5be8730d3d
Signed-off-by: Reinaldo Penno <[email protected]>
Shuva Jyoti Kar [Thu, 9 Oct 2014 16:24:56 +0000 (21:54 +0530)]
Enabling Acl entries for ping
Change-Id: If96e6264e8a97f7e2e4b0ea5b6ed264d046e38b1
Signed-off-by: Shuva Jyoti Kar <[email protected]>
Shuva Jyoti Kar [Thu, 9 Oct 2014 07:35:04 +0000 (13:05 +0530)]
Enabling subnet-mask as input
Change-Id: Ibd1f4a2e077f7dfc096854f08b62537fe2584165
Signed-off-by: Shuva Jyoti Kar <[email protected]>
Shuva Jyoti Kar [Thu, 9 Oct 2014 06:11:17 +0000 (11:41 +0530)]
Acl-flow fixed
Signed-off-by: Shuva Jyoti Kar <[email protected]>
Change-Id: I10a5db61e73502b27644448310bb2fd571763e72
Signed-off-by: Shuva Jyoti Kar <[email protected]>
Andrej Kincel [Fri, 3 Oct 2014 14:04:10 +0000 (16:04 +0200)]
Bug 2146: SFC broken due to new auth requirement (correct fix)
HTTPBasicAuthFilter added to jersey REST client
It attaches Authorization: Basic YWRtaW46YWRtaW4= to HTTP header
It means that username and password is hardcoded to "admin", "admin"
Change-Id: Ib164a8736c5793a670b55347b703f249bdd63e66
Signed-off-by: Andrej Kincel <[email protected]>
Shuva Jyoti Kar [Wed, 1 Oct 2014 03:21:57 +0000 (08:51 +0530)]
Support for multiple data-plane locators
Change-Id: I0f04145d238298a9ec4bddf9102b851e361c7787
Signed-off-by: Shuva Jyoti Kar <[email protected]>
Shuva Jyoti Kar [Tue, 30 Sep 2014 04:59:41 +0000 (10:29 +0530)]
Disabling egress transport table
Change-Id: Id08686d0083c52f21b8c4abd19fa918ca656e4bf
Signed-off-by: Shuva Jyoti Kar <[email protected]>
Shuva Jyoti Kar [Mon, 29 Sep 2014 06:38:02 +0000 (12:08 +0530)]
EthType matches not required
Signed-off-by: Shuva Jyoti Kar <[email protected]>
Shuva Jyoti Kar [Sun, 28 Sep 2014 17:15:35 +0000 (22:45 +0530)]
Getting rid of vlan_vid/different priorities flow
Signed-off-by: Shuva Jyoti Kar <[email protected]>
Change-Id: I7c61fdc3c527b4ad5f2e7f37527d2a7c562b9163
Signed-off-by: Shuva Jyoti Kar <[email protected]>
Shuva Jyoti Kar [Sat, 27 Sep 2014 14:14:35 +0000 (19:44 +0530)]
Resolved NoClassDefFoundError at runtime
Signed-off-by: Shuva Jyoti Kar <[email protected]>
Change-Id: I28ecf0139191f945d68a4be1185cc6167149d1bb
Signed-off-by: Shuva Jyoti Kar <[email protected]>
Shuva Jyoti Kar [Fri, 26 Sep 2014 07:57:05 +0000 (13:27 +0530)]
Multiple Mac matches to address multiple chains
Change-Id: Iae7312446ff1ab9b646c7ebd62bbd4cf03e03f91
Signed-off-by: Shuva Jyoti Kar <[email protected]>