Sam Hague [Fri, 24 Nov 2017 04:30:39 +0000 (23:30 -0500)]
NetVirt Offset 2 M2 Status
Change-Id: I0990272a6201907f6f99d147c5686539cb8e5e01
Signed-off-by: Sam Hague <shague@redhat.com>
Luis Gomez [Wed, 22 Nov 2017 23:09:45 +0000 (15:09 -0800)]
Updated git submodules
Project: integration/test master
40d28a8c8a4e314a4eed48ae2483f9ee5908a414
Add more time in version test
Change-Id: Ia4f98a1bf28fd21a29b8f3afc843ab0fd141910e
Signed-off-by: Luis Gomez <ecelgp@gmail.com>
Tom Pantelis [Wed, 22 Nov 2017 13:07:05 +0000 (08:07 -0500)]
Updated git submodules
Project: netvirt master
fbcc8687782c424171a58d524cd0dfd2bbd8db8b
Fix FindBugs violations and enable enforcement in elanmanager-impl
See in-line comments
Change-Id: I4d8b7cf418ebb0aa46435de3c5cb2b3b06440b71
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Wed, 22 Nov 2017 16:27:13 +0000 (11:27 -0500)]
Updated git submodules
Project: netvirt master
852420c8b3bd3561dd1ff33a8cc919e87f2163e0
Fix FindBugs violations and enable enforcement in natservice
See in-line comments
Change-Id: I831e0a60048cddce1224356ae27f3e8359ea17d2
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Sam Hague [Thu, 23 Nov 2017 17:21:11 +0000 (12:21 -0500)]
Updated git submodules
Project: integration/test master
511fc6398168f7d65fe44d71776b3954a04529b3
Make the ha suite names unique
Change-Id: I68c659f346f642042b612b08b8167f108ce50902
Signed-off-by: Sam Hague <shague@redhat.com>
Josh [Wed, 8 Nov 2017 08:17:25 +0000 (10:17 +0200)]
Updated git submodules
Project: genius master
6f8e7f2a9c0ff163c08427359d63630cc0dd8e67
Upgrading flag for full sync upgrades
This commit introduces a small utility that tracks whether or not
an upgrade is in progress. The purpose of this state is so that
code paths required during upgrade need not be entered during
regular application flow. The upgrade in progress state is toggled
via REST (or config xml). I tested it like this:
> curl -v -u admin:admin -X PUT -d @put-data -H \
"Content-Type: application/json" \
http://127.0.0.1:8181/restconf/config/genius-mdsalutil:config
...where the contents of the put-data file are:
{
"config": {
"upgradeInProgress": false
}
}
The REST call to retrieve the status is:
> curl -u admin:admin http://127.0.0.1:8181/restconf/config/genius-mdsalutil:config
Change-Id: I96d4255645b8650ee97154ff58c1afc52d1ac9f0
Signed-off-by: Josh <jhershbe@redhat.com>
Jakub Toth [Thu, 23 Nov 2017 14:46:06 +0000 (15:46 +0100)]
Updated git submodules
Project: netconf master
b587bcac431d667c0835dd4ab312b83edb24f608
Fix harcoded port in location of streams
Change-Id: I449772b7233186f29df97a3968f65b19204f79ca
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
Robert Varga [Thu, 23 Nov 2017 13:41:11 +0000 (14:41 +0100)]
Updated git submodules
Project: bgpcep master
c1b4aafd7b5fb5857452494e02fff85bb5a4b4e6
Fix odlparent reference
The reference should point to 2.0.5, not 1.9.0.
Change-Id: I739d260b1509ce981b803a7a0b7e087a55f97159
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Tom Pantelis [Wed, 22 Nov 2017 22:20:46 +0000 (17:20 -0500)]
Updated git submodules
Project: netvirt master
aa1ab10c5a667e47afb095efac7bc0025011ddb3
Fix FindBugs violations and enable enforcement in ipv6service
See in-line comments.
Eliminated the static instances for IfMgr and Ipv6PeriodicTrQueue.
The ShowIpv6Command class referenced the static IfMgr instance.
I extracted an interface, ElementCache, for the IfMgr whicb is
advertsed as a service and injected into ShowIpv6Command. The shell
bundle shouldn't reference packages in the impl bundle so I also
extracted interfaces for VirtualRouter, VirtualPort et al.
Ipv6ServiceImpl basically just wired the static instances - since
this is no longer needed, Ipv6ServiceImpl was removed.
Change-Id: I635ff43cffded41c7a32079214cff48a057f4fac
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Michael Vorburger [Thu, 9 Nov 2017 18:14:27 +0000 (19:14 +0100)]
Updated git submodules
Project: genius master
bad33ace570da5a6433870fd7d6e32abf9a28b9c
Nicer (shorter) how to addErrorLogging in AlivenessProtocolHandlerLLDP
improves If342b11591f1dfe6e58fdca29b400531455669fd
using I6be0a0677659d9748e86995c8a4874e99e2c6493
Change-Id: I9b8de70bd1d3f226801c68946f1e4ceaaca8bb3a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Tomas Cere [Tue, 21 Nov 2017 15:45:42 +0000 (16:45 +0100)]
Updated git submodules
Project: netconf master
39cf308c4fb81ab696bcc06736361afa0b230f9b
Fix NPE when trying to download restconf provided yang files
Restconf throws a NPE when trying to download the provided yang files
due to using Module.getSource() which is deprecated an @Nullable.
Switch this to using DOMSchemaService.
This fixes the NPE only in the rfc8040 implementation,
draft02 still most likely has it.
Change-Id: Ic8fc94a26a1e29e037872dfdc16c97ef19fcf115
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Faseela K [Sun, 5 Nov 2017 19:16:24 +0000 (00:46 +0530)]
Updated git submodules
Project: infrautils master
affb4edf3c14e555eec488ba52bdf10acfe6b323
Expose system ready state as MBean
This will help applications to acquire cluster wide system status
if required.
Change-Id: I4cf048a0927e120a699ad88f7736e78906a59685
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Jaime Caamaño Ruiz [Tue, 21 Nov 2017 16:39:03 +0000 (17:39 +0100)]
Updated git submodules
Project: integration/test master
668367619017d89769c5d5cfd119cf4acddf4f39
Make sure ip forward is enabled on SFC full deploy
So that OVS instances running in docker containers can talk to ODL
controller.
Change-Id: I24fa65c2956b0474328658132277f251b746d8d3
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@suse.com>
Michael Vorburger [Thu, 16 Nov 2017 19:26:12 +0000 (20:26 +0100)]
Updated git submodules
Project: genius master
9b4c3f9bb0bddbbe2dcd6fc2a7b2497488159696
Remove un-used fields, services and DEFAULT_CALLBACK in 3 ITM Workers
Change-Id: Icb1cedc35c98cd91e0ca22500c3a1c1cc41677f6
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Tue, 21 Nov 2017 13:48:04 +0000 (14:48 +0100)]
Updated git submodules
Project: odlparent master
bb1e41cf0ca6c146d16bc123660e6de37246b335
Start 3.0.1-SNAPSHOT
Change-Id: I9be70dcdef4b95a98095df72f7bb5e4eafb7ef59
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Tom Pantelis [Tue, 21 Nov 2017 02:29:12 +0000 (21:29 -0500)]
Updated git submodules
Project: netvirt master
a538caa9aac31f0e204ba38f72ec536b5e658aed
Fix FindBugs violations and enable enforcement in aclservice
See in-line comments
Change-Id: If57c4a0c1a9478daaffeb08132bdf117ecbd59a6
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Michal Cmarada [Thu, 16 Nov 2017 11:41:05 +0000 (12:41 +0100)]
Add Honeycomb/vbd M2 offset 2 status
Change-Id: I073951c4d5a636c131bcd736fda085003616d44b
Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.tech>
Kit Lou [Wed, 22 Nov 2017 14:52:30 +0000 (14:52 +0000)]
Merge "Add Groupbasedpolicy M2 offset2 status"
Kit Lou [Wed, 22 Nov 2017 14:47:05 +0000 (14:47 +0000)]
Merge "Neutron Northbound M2 offset 1 status for Oxygen"
Ryan Goulding [Tue, 7 Feb 2017 19:37:08 +0000 (14:37 -0500)]
Updated git submodules
Project: odlparent master
a86685d6214422f6f12cc2f9f84b752467332cb1
Bug 7756 Bind web services to single port
Right now, we mirror web service offerings on ports 8080 and 8181.
There has been much discussion surrounding consolidating on a single
port. See these email threads:
https://lists.opendaylight.org/pipermail/release/2017-February/009244.html
https://lists.opendaylight.org/pipermail/controller-dev/2016-September/012677.html
Based on community feedback, it would appear that most people utilize
port 8181, and it would take a LOT of work to change that. Thus, this
change removes the port 8080 offering. If downstream consumers still
wish to use web services on port 8080, then can simply re-add the
connector in etc/jetty.xml without recompiling (will require karaf
container restart to reinitialize pax-web).
This is just a change to the default offering, and makes the ODL
platform a bit more consistent OOB.
Change-Id: I62ccf4a8f9719c7923f06204955239ceea8a780f
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Michael Vorburger [Wed, 22 Nov 2017 09:58:20 +0000 (10:58 +0100)]
Updated git submodules
Project: netvirt master
e1be36e69891c8949ea4f0816be9572f9bafb9c2
Fix the fix for the bad transaction leak in VpnInterfaceManager
In
0c3a7e3103fea3dc039519ab4d4497fd218dc3d8 for
I0f62fcc17c037365c9384e56c9f6f5a430693c20 there was a left-over
tx.submit() that should have also been removed as part of it (because
callWithNewWriteOnlyTransactionAndSubmit already does that, as its name
says). This fixes the follow new error which started appearing in CSIT
logs since that was merged:
2017-11-21 18:05:05,592 | ERROR | ChangeHandler-77 | L3vpnPopulator
| 349 - org.opendaylight.netvirt.vpnmanager-impl - 0.6.0.SNAPSHOT |
Future (eventually) failed: addToLabelMapper
java.lang.UnsupportedOperationException: submit() cannot be used inside
a Managed[New]TransactionRunner
see https://jira.opendaylight.org/browse/NETVIRT-985
Change-Id: Ic2c8b02670242f3a3f190860c205d7d70c2939b3
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Jakub Toth [Sun, 12 Nov 2017 17:04:52 +0000 (18:04 +0100)]
Updated git submodules
Project: netconf master
6b8e4f7ee09ed344969ddad8017a7f41ad89f2d0
Add update method of handlers for REST services
Change-Id: I64a7f7a47f43566a50839ce1a83ba0fdd4034ed9
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
Michal Cmarada [Thu, 16 Nov 2017 11:40:27 +0000 (12:40 +0100)]
Add Groupbasedpolicy M2 offset2 status
Change-Id: Ie545947ea49a82b635e34386b70082b807abd296
Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.tech>
Isaku Yamahata [Tue, 21 Nov 2017 00:29:33 +0000 (16:29 -0800)]
Neutron Northbound M2 offset 1 status for Oxygen
Change-Id: I304a40c0992874a05c633dc0571d1dcae76841fa
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Kit Lou [Wed, 22 Nov 2017 03:52:04 +0000 (03:52 +0000)]
Merge "Add p4plugin user guide to index.rst"
A H [Thu, 16 Nov 2017 18:41:47 +0000 (10:41 -0800)]
Add USC M2 Status
Change-Id: I9f34a98ec130d55056532ac56713e1a05c5df6be
Signed-off-by: A H <an.ho@huawei.com>
Kit Lou [Wed, 22 Nov 2017 03:10:32 +0000 (03:10 +0000)]
Merge "Add NEMO M2 Status"
Vyshakh Krishnan CH [Mon, 10 Jul 2017 14:11:37 +0000 (19:41 +0530)]
Updated git submodules
Project: netvirt master
6e6e533529d5e938d87907c9438f73238a185301
EVPN RT2 : L2VNI demux table changes
When a packet comes from another DC in evpn RT2 scenario, it lands up in
table 24(l2vni demux table) from where the elan tag is derived and send
to destination mac table
Change-Id: I3ddf1b0d086a78eb1b2cc7a2760f02bf1c55ae4d
Signed-off-by: Vyshakh Krishnan CH <vyshakh.krishnan.c.h@ericsson.com>
Tom Pantelis [Tue, 21 Nov 2017 22:50:27 +0000 (17:50 -0500)]
Updated git submodules
Project: netvirt master
7f5b4410712c5b91940cab2234fa8d844e6d2b61
NETVIRT-937: Fix NPE in ElanInstanceManager
2017-11-21 16:21:43,179 | ERROR | nPool-1-worker-2 | JobCoordinatorImpl | 261 - org.opendaylight.infrautils.jobcoordinator-impl - 1.3.0.SNAPSHOT | Runnnable likely about to terminate thread due to uncaught exception; but here is useful debugging context: JobEntry{key='elaninterface-
963a4d35-297e-4757-be14-
6c3dec354221', mainWorker=org.opendaylight.netvirt.elan.internal.ElanInstanceManagerElanInstanceManager$$Lambda$774/
1098386956@
516cbba2, rollbackWorker=null, retryCount=6, futures=[null, com.google.common.util.concurrent.ImmediateFuture$ImmediateSuccessfulCheckedFuture@
39325841]}
java.lang.NullPointerException: at index 0
at com.google.common.collect.ObjectArrays.checkElementNotNull(ObjectArrays.java:235)[27:com.google.guava:22.0.0]
at com.google.common.collect.ObjectArrays.checkElementsNotNull(ObjectArrays.java:225)[27:com.google.guava:22.0.0]
at com.google.common.collect.ObjectArrays.checkElementsNotNull(ObjectArrays.java:219)[27:com.google.guava:22.0.0]
at com.google.common.collect.ImmutableList.construct(ImmutableList.java:342)[27:com.google.guava:22.0.0]
at com.google.common.collect.ImmutableList.copyOf(ImmutableList.java:257)[27:com.google.guava:22.0.0]
at com.google.common.collect.ImmutableList.copyOf(ImmutableList.java:228)[27:com.google.guava:22.0.0]
at com.google.common.util.concurrent.Futures.allAsList(Futures.java:835)[27:com.google.guava:22.0.0]
at org.opendaylight.infrautils.jobcoordinator.internal.JobCoordinatorImpl$MainTask.runWithUncheckedExceptionLogging(JobCoordinatorImpl.java:369)[261:org.opendaylight.infrautils.jobcoordinator-impl:1.3.0.SNAPSHOT]
The futures List in remove is reused across the submitted jobs in the forEach loop
which is unsafe as the List is accessed by multiple threads. Each job now returns its
own local futures List.
The futures returned from elanInterfaceManager.removeElanInterface
were also added to the List but I don't see the purpose of this. removeElanInterface
waits for those tx's to complete. Maybe it was so the JC would retry them? If so, this
entire code path has a mix of sync and async transactions which is a bit confusing -
some are submitted to the JC, ohers aren't; some may be retried, others aren't.
Change-Id: I82193fc36a339db42b83df5bfa3d17ff0a88dfa0
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Charles La Voy [Tue, 21 Nov 2017 23:50:06 +0000 (17:50 -0600)]
Add p4plugin user guide to index.rst
Change-Id: Ib73fe45d68a97533cc73bf9f314faab098dcaf80
Signed-off-by: Charles La Voy <clavoy@luminanetworks.com>
Tom Pantelis [Tue, 21 Nov 2017 20:54:24 +0000 (15:54 -0500)]
Updated git submodules
Project: netvirt master
ba954c2d85d5d9e7aa41c1b81c6f56992c41a588
Fix NPE in NeutronvpnManager
CSIT log shows:
2017-11-21 17:20:01,945 | ERROR | nPool-1-worker-3 | JobCoordinatorImpl | 261 - org.opendaylight.infrautils.jobcoordinator-impl - 1.3.0.SNAPSHOT | Exception when executing jobEntry: JobEntry{key='PORT-
f08a0cc9-49aa-4db8-b69b-
dcc486817764', mainWorker=org.opendaylight.netvirt.neutronvpn.NeutronvpnManager$$Lambda$825/
713684833@
92010fc, rollbackWorker=null, retryCount=0, futures=null}
java.lang.NullPointerException
at org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.withdrawPortIpFromVpnIface(NeutronvpnManager.java:817)
at org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.lambda$removeSubnetFromVpn$2(NeutronvpnManager.java:1413)
This line:
if (sn == null || !adj.getSubnetId().equals(sn.getId()))
I assume adj isn't null in which case getSubnetId() must be null. I changed it to
use Objects.equals which means the equals check would evaluate to false if
getSubnetId() is null (unless sn.getId() is also null). I assume this is correct.
Change-Id: Ib769273ee805e333fc96d0fcb83db15da056f69e
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Fix NPE in VpnSubnetRouteHandler
CSIT log shows several of these:
2017-11-21 16:51:37,973 | ERROR | nPool-1-worker-0 | VpnSubnetRouteHandler | 349 - org.opendaylight.netvirt.vpnmanager-impl - 0.6.0.SNAPSHOT | SUBNETROUTE: onInterfaceDown: SubnetOpDataEntry update on interface
174fcd9a-f2fc-4f70-bc1e-
9a42755175ea down event for subnet
9189b34e-b7be-40ff-9bd4-
8c0d0a4f96f3 falied {}
java.lang.NullPointerException
at org.opendaylight.netvirt.vpnmanager.VpnSubnetRouteHandler.electNewDpnForSubnetRoute(VpnSubnetRouteHandler.java:988)
at org.opendaylight.netvirt.vpnmanager.VpnSubnetRouteHandler.onInterfaceDown(VpnSubnetRouteHandler.java:649)
at org.opendaylight.netvirt.vpnmanager.SubnetRouteInterfaceStateChangeListener.lambda$remove$1(SubnetRouteInterfaceStateChangeListener.java:154)
networkId is purposely passed as null in several call sites. It is only used to extract
the String value to pass to addSubnetRouteToFib which passes to L3vpnInput#setNetworkName.
From there is looks like null network name is handled.
Change-Id: Ie86c2ead79d4431a06e04526dc415f58c893d461
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Fix NPE in SubnetmapChangeListener
CSIT log shows a ton of these:
java.lang.NullPointerException
at org.opendaylight.netvirt.vpnmanager.SubnetmapChangeListener.update(SubnetmapChangeListener.java:119)[349:org.opendaylight.netvirt.vpnmanager-impl:0.6.0.SNAPSHOT]
at org.opendaylight.netvirt.vpnmanager.SubnetmapChangeListener.update(SubnetmapChangeListener.java:31)[349:org.opendaylight.netvirt.vpnmanager-impl:0.6.0.SNAPSHOT]
at org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase$DataTreeChangeHandler.run(AsyncDataTreeChangeListenerBase.java:152)[247:org.opendaylight.genius.mdsalutil-api:0.4.0.SNAPSHOT]
Either vpnIdOld or subnetId was null when calling getValue(). We could check for
null in all places they're being logged but I just changed it to pass the
reference as Uuid's toString will print the internal value.
Change-Id: I6c88177a476f38c38189bddfb55a62cfba61d9a9
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
A H [Thu, 16 Nov 2017 18:40:19 +0000 (10:40 -0800)]
Add NEMO M2 Status
Change-Id: I746b6b480578062607df73db6c87fef213b874fb
Signed-off-by: A H <an.ho@huawei.com>
Kit Lou [Tue, 21 Nov 2017 22:24:01 +0000 (22:24 +0000)]
Merge "Steps to setup Animal sniffer plugin with project"
Loshmitha [Mon, 20 Nov 2017 09:34:00 +0000 (15:04 +0530)]
Updated git submodules
Project: netvirt master
c7dd19b71e01464a027c9ec2f66df340ca6981c2
Bug 9188 Removing the ODL thrift IP check
In RHEL,ODL MIP will not be hosted in the BGP EOS owner and it will be
in HA proxy.So removing the availability and check for this IP in the
code.Check was not required as QBGP has replay mechanism whenever the IP
comes up
Change-Id: I79a6cfddb36dd9c7b2322615bf3871a9bfdc7e44
Signed-off-by: Loshmitha <loshmitha@ericsson.com>
Sridhar Gaddam [Tue, 21 Nov 2017 14:31:49 +0000 (20:01 +0530)]
Updated git submodules
Project: netvirt master
e4e0bc15902f874644898e81f2e2e9b3e2e73ce6
Small optimization in ipv6service code
Change-Id: Ibc6d4431d9139826ede38c6708b70130d5a32030
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Tom Pantelis [Tue, 21 Nov 2017 15:49:37 +0000 (10:49 -0500)]
Updated git submodules
Project: netvirt master
387fcd37db989c57c7ef64f5aac931d4a86fb117
Fix FindBugs violations and enable enforcement in qosservice
See in-line comments.
Change-Id: I323e23bccdfcc526ceb3f62148292152f5dc5738
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Kit Lou [Tue, 21 Nov 2017 20:24:03 +0000 (20:24 +0000)]
Merge "Remove link to oxygen release notes for DOCS-46"
Anil Belur [Sat, 18 Nov 2017 22:32:28 +0000 (08:32 +1000)]
Steps to setup Animal sniffer plugin with project
Document the steps for installing and setting up Animal
Sniffer plugin with Maven projects, which is useful for testing
API compatibility.
Change-Id: Ibf7386ef3ef0694c2d62c469628aa57c2187e300
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Michael Vorburger [Thu, 16 Nov 2017 20:25:41 +0000 (21:25 +0100)]
Updated git submodules
Project: genius master
38582f4b56dd8287bd8cb3f9334cf77adfe16613
Fix possible transaction leak in ItmInternalTunnelDeleteWorker
Change-Id: I0e079346c12002a55eb043b72c2f2e2c3b81f7c4
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 16 Nov 2017 20:08:05 +0000 (21:08 +0100)]
Updated git submodules
Project: genius master
11a8883246fb881e8ddbf4373599b23c9136648e
Fix bad transaction leak in ItmInternalTunnelAddWorker
see https://jira.opendaylight.org/browse/NETVIRT-985
523x transactions opened here, which are not closed:
org.opendaylight.genius.itm.confighelpers.ItmInternalTunnelAddWorker.buildAllTunnels
Change-Id: I9c32010b64688b9cb441a2ea637e9519ba803c80
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Mon, 20 Nov 2017 16:53:11 +0000 (17:53 +0100)]
Updated git submodules
Project: netvirt master
e653da5ee3781e045078e334b40ad898756e0d7e
NETVIRT-1000: protect VpnInterfaceManager::remove
This patch ensures that the write transactions in
VpnInterfaceManager::remove are always closed.
Change-Id: Iaca016e08fed88f8cb34afbef702465ba152bbe0
Signed-off-by: Stephen Kitt <skitt@redhat.com>
NETVIRT-1000: protect VrfEntryListener (partially)
This patch ensures that the write transactions in
VrfEntryListener.CleanupVpnInterfaceWorker::call and
::deleteFibEntries are always closed.
Change-Id: I57a6912fa162d3e37792d479ad76ae0879c3ae35
Signed-off-by: Stephen Kitt <skitt@redhat.com>
NETVIRT-1000: protect TunnelEndPointChangeListener
This patch ensures that the write transactions in
TunnelEndPointChangeListener::add are always closed.
Change-Id: I79af37a9c046a405113c1fd408098b06fb59d028
Signed-off-by: Stephen Kitt <skitt@redhat.com>
NETVIRT-1000: protect manageRemoteRouteOnDPN
This patch ensures that the write transaction in
VrfEntryListener::manageRemoteRouteOnDPN is always closed.
Change-Id: I4add610addb470bea3ceda9736f9cbc457adcb44
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Kit Lou [Tue, 21 Nov 2017 19:12:51 +0000 (19:12 +0000)]
Merge "Update m2 template to include odlparent/yangtools"
Kit Lou [Tue, 21 Nov 2017 18:52:43 +0000 (12:52 -0600)]
Update m2 template to include odlparent/yangtools
Add a new item under Integration and Test to
cover integration with odlparent 3 / yangtools 2
Change-Id: Ie8b8c6ea0fb2d312a7bfbcab4ffc7b788db0cb31
Signed-off-by: Kit Lou <klou.external@gmail.com>
Michael Vorburger [Mon, 20 Nov 2017 18:01:29 +0000 (19:01 +0100)]
Updated git submodules
Project: infrautils master
191ade3713e25af811490c10d7da5ddafa2d4d6c
Switch metrics to use infrautils parent (w. error-prone, CPD & CP dupes)
Change-Id: Ia35f1135aad8ceedc2440a7904bb6b108ddc1798
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Tue, 21 Nov 2017 14:41:08 +0000 (15:41 +0100)]
Updated git submodules
Project: netvirt master
1e3bee00e37000c8eaaed0ff23418c31053ed708
Fix wrong use of JobCoordinator in ElanInstanceManager
found by chance during analysis of
https://jira.opendaylight.org/browse/NETVIRT-937, but then realised that
this will not fix that NPE - but would be good to rectify anyway.
Change-Id: If49efc13855ddeb085256ce0a6d5c093f42687f8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Kency Kurian [Fri, 11 Aug 2017 05:47:21 +0000 (11:17 +0530)]
Updated git submodules
Project: genius master
156715d3929e8a36ccba1222dd8fd335916278c7
GENIUS-86 : LockManager fixes
Root cause:
There were few AskTimeOut exception that was observed, which means the
data got eventually written to the DS. But because of the exception the
lock was being tried again to be acquired. Later, because of the first
write attempt that got succesful we were getting logs saying that the lock is
already present. This could be avoided by checking if the lock that is
already present in the DS is that of the same request.
Fix:
- For each request we can maintain an id so that if at all a timeOut
exception occurs, but eventually the write succeeds, we can identify
which request got successful by checking the owner field.
- While trying for lock, if lock is already present check for owner and
if it is the same owner then return from lock.
Change-Id: Ia2757981e92dbd48f3057c841f6ed6d710ba5bd2
Signed-off-by: Kency Kurian <kency.kurian@ericsson.com>
Jaime Caamaño Ruiz [Thu, 9 Nov 2017 09:46:10 +0000 (10:46 +0100)]
Updated git submodules
Project: sfc master
5da06e7324cc7024a7c7c9d2e360062186abb3d0
SFC-205: Fix wrong table when removing scf flows
Fixes SFC SCF classifier removing flows from incorrect table. Refactored
ClassifierInterface to provide the correct table numbers and for
MacChainingClassifier to also implement it.
Change-Id: I4383209ce24d0d3dce14f8f498c91abaf36b6c09
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@suse.com>
Ryan Goulding [Tue, 21 Nov 2017 15:29:05 +0000 (15:29 +0000)]
Updated git submodules
Project: aaa master
fa2496c171645ebd1bc399ccd1ed8a306dee61bc
Merge "Dissuade use of author name in source"
Dissuade use of author name in source
This is just an attempt to make the code more community centric.
I don't care if other contributors want to keep their "@author"
annotation tags-- but I do want to spread the love in terms of
support queries etc :).
This removes my name/email anywhere possible in an effort to
make the aaa codebase more community centric. I still plan to
be active, I just would rather people email the aaa reflector:
aaa-dev@lists.opendaylight.org
rather than unicast my email address.
Whenever I saw trivial changes like unused import or whatnot,
I just removed them to make the code cleaner.
Change-Id: I56573bf618deac22c41a2276233ed9d6c00c07de
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Stephen Kitt [Mon, 20 Nov 2017 10:15:33 +0000 (11:15 +0100)]
Updated git submodules
Project: netvirt master
70ee8ba26ef1c8e0d019f1954b66df96a4aa0210
NETVIRT-1000: protect handleNeutronPortUpdated
This patch ensures that the write transaction in
NeutronPortChangeListener::handleNeutronPortUpdated is always closed.
Change-Id: I56557db7fc4852100599379b0b32267a94ed9807
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit
9448a059037d75fc3d1a307ee47031b890b1b0d3)
(cherry picked from commit
040f5af4bff626b56e7ed51e1e25fc3c773abafa)
Jaime Caamaño Ruiz [Mon, 20 Nov 2017 17:38:49 +0000 (18:38 +0100)]
Updated git submodules
Project: sfc master
645e172fbabbac173ec2a7180f32abd41db4067f
SFC-206: Fix no sfc-scf-openflow listeners @runtime
sfc-scf-openflow listeners were not being instantiated by blueprint
because their constructor parameters were not singletons that could be
injected. Introduced in
b5fabe5.
Fixed by creating the listeners manually.
Bug: https://jira.opendaylight.org/browse/SFC-206
Change-Id: If3a01d691cbce8478537fd50cdead461d6740e9c
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@suse.com>
Tom Pantelis [Fri, 17 Nov 2017 00:38:45 +0000 (19:38 -0500)]
Updated git submodules
Project: genius master
a83922e36132bd5e64a6f8f5741222b68b006367
Fix FindBugs violations and enable enforcement in interfacemanager-api
Change-Id: I244fae322dce5042c72b942f0c814331e92a5d1e
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Thu, 16 Nov 2017 23:42:58 +0000 (18:42 -0500)]
Updated git submodules
Project: genius master
a867a71a7894bfb507a03dd8e58a31a7841e8664
Fix FindBugs violations and enable enforcement in mdsalutil-impl
Also converted FlowBatchingUtils from static to a singleton.
Change-Id: I22f9e5eb82ac3022bd8a5a754f84338ee7bab4a3
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Ryan Goulding [Tue, 21 Nov 2017 14:50:30 +0000 (14:50 +0000)]
Updated git submodules
Project: aaa master
8de983c96bcf2c613edc0889fcae1cebc62a98b9
Merge "Add MdsalRealm information to README.md"
Add MdsalRealm information to README.md
Add caveats about the new MdsalRealm to the AAA README. Point
out the current state and the future work involved to get
MdsalRealm in production shape.
Change-Id: I55016467e37f00c14d4ade2b8c113032c6c9a6a8
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Sam Hague [Tue, 21 Nov 2017 13:54:32 +0000 (08:54 -0500)]
Updated git submodules
Project: integration/test master
e0007d9e0a86d3d4a34582f1645a2a6b8cd77753
Use full path to netvirt tests 2
Change-Id: I93969f5799f6c389eb4eec13de0b11b67aa2c600
Signed-off-by: Sam Hague <shague@redhat.com>
David Suarez [Tue, 14 Nov 2017 23:48:01 +0000 (00:48 +0100)]
Updated git submodules
Project: genius master
c693a7eb73a284ea8e80aad537c4b886d9d2a480
Enforce findbugs
Change-Id: I4c5d2832b248e51bb4cb648875e3bc3205354f81
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Faseela K [Thu, 5 Oct 2017 18:50:01 +0000 (00:20 +0530)]
Updated git submodules
Project: netvirt master
85a9c55918eb83a9124b85b06f95a732008b705f
Infrautils DiagStatus Integration For ELAN
Change-Id: Ifc2b79e370def61728929ba7ba8d22289510cff8
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Jamo Luhrsen [Mon, 20 Nov 2017 17:59:40 +0000 (09:59 -0800)]
Updated git submodules
Project: integration/test master
4f179b6b1dfda0ebc3fb353a448d3a77fb58e8e6
Remove legacy script and test plans
netvirt legacy is no longer consumed by any projects. Boron
was the last release this was the case and Boron jobs no
longer exist
Change-Id: Ib58ba44cb74d402829fd152fe75743d5b4416bc3
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Philippe Guibert [Mon, 10 Jul 2017 11:54:32 +0000 (12:54 +0100)]
Updated git submodules
Project: netvirt master
bbf14f6e7babed71a8a42f86153b7348ae35c250
vpnmanager: various support for vpn-interface-op in operDS
Misc changes in vpn-manager related to the support of two router setup:
- tunnelinterface state changes
This commit enhances API changes for the following:
o updateVpnInterfaceOnTepDelete
o updateVpnInterfaceOnTepDelete
Instead of looking for a VPNInterface in operDS and refreshing context,
the VPNInterfaceOpDataEntries are looked up. Contexts are refreshed
accordingly.
- vpn-subnet: update packet processing with correct router-id
The metadata retrieved from the packet is compared against the router
used in the VPN interface. Action is done accordingly.
Also, upon interface going down, a check is done on the retrieving
datapath ID and performing subnet propagation, provided that
vpninterface-op-data-entry is present.
- vpn-util: check ARP learning against VPN interface
When receiving an ARP response on a VPN interface, the metadata is
checked against the list of routers in that VPN interface.
- vpnmanager-interface-op-data: adapt vpnInterfaceOpDataEntry listener
This change handles the update and deletion of operDS vpnInterfaceOpDataEntry
entries. It replaces the old code that was expecting vpnInterface entries.
- vpnmanager-shell: dump the list of vpnInterfaceOpDataEntry()
This lists the whole list of vpnInterfaceOpDataEntry() previously
created when a vpnInterface was created in config DS.
Change-Id: Ia0a8845464912a56a16e87649c2adaf74c71d5de
Signed-off-by: Noel de Prandieres <prandieres@6wind.com>
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Valentina Krasnobaeva <valentina.krasnobaeva@6wind.com>
vpnservice: various changes to support vpn-interface-op-data-entry
- natservice: misc nat changes while using vpn-interface-op-data-entry
On some cases where a VM interface is connected to two routers ( case
with dual stack IPs), then the router which has nat enabled is searched.
The changes parse the list of router per VPN interface, and return the
first router which has NAT enabled.
Obviously, that kind of setup may have only one router with NAT enabled,
at maximum.
On EVPN flow programmation, on removing floating IPs, the vpnInterfaces
operational is removed too.
On Interface state change, the vpnInterfaces will be updated, added or
removed.
- cloud-service-chain: update VpnToPseudoPortData with VpnInterfaces
Because VpnInterface can support more than one VPN, when a new VPN
interface is created or removed, the list of its VPN should be parsed
against the VpnToPseudoPortData contexts.
- fib-manager: update operational Adjacencies by using vpnInterfaceOpDataEntry
This commit deletes the adjacenciesOp entry related to a vrfEntry, in
vpnInstanceOpDataEntry. The list of vpnRouterIds() is parsed in config
DS vpnInstance, to check is there is a vpnInstanceOpDataEntry existing.
Then if present, the associated adjacenciesOp is deleted.
The commit introduces a new function called getAdjacencyIdentifierOp().
It replaces getAdjacencyIdentifier, and will search for adjacencies that
are relying on vpninterfaceopdataentry.
Change-Id: I5a676b15dfdb415064a2e9daba5f4c7b4d584fe9
Signed-off-by: Valentina Krasnobaeva <valentina.krasnobaeva@6wind.com>
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Noel de Prandières <prandieres@6wind.com>
vpninterface-manager: introduce vpn-interface-op-data context in oper DS
This commit includes the following:
- upon add() and remove() event, create/or remove vpn-interface-op-data-entry
for each pair (interface,vpnname) in operDS.
- BGP advertisement related to adjacencies from VPN
- support for AdjacenciesOp new yang model for operDS
- vpninterface-manager: update router interface FIB entry if a new vpn interface
is updated, the extraroutes are being added accordingly. The same is done for
FIB entries.
- vpninterface-manager: support for update operation upon the list of routers
changed for a vpn interface, the vpnInterfaceOpDataEntry are removed, then
readded.
Following API changed: replaced VpnInterface with VpnInterfaceOpDataEntry
o processExternalVpnInterface
o processVpnInterfaceDown
o withdrawAdjacenciesForVpnFromBgp and advertiseAdjacenciesForVpnToBgp
o processVpnInterfaceUp use VpnInterface as new parameter
o addVpnInterfaceVpn and addNewAdjToVpnInterface and delAdjFromVpnInterface
Change InterfaceStateChangeListener accordingly
The two following APIs
are being added vpnName as parameter:
- deleteFibEntryForRouterInterface
- createFibEntryForRouterInterface
Change-Id: I6320c7839c274fcf5d7779ce15a89733dd97217f
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Noel de Prandieres <prandieres@6wind.com>
vpnmanager: vpn-interfaces yang container has vpn-instance-name list
- In order to handle internal VPN or BGPVPN in a two router case solution,
some yang changes is needed.
Config DS is being added a list of vpn-instance configuration for one
VPN interface. The need is to have two vpn instances configurable for one VPN.
This commit change only handles the compilation by adapting java code
to as to care about the first element of vpn-instance.
- vpnmanager: basis changes for two router case solution
o vpnmanager-api: yang changes for two router case solution
In order to handle internal VPN or BGPVPN in a two router case solution,
some yang changes is needed. In a dual router case solution, one vpn
Instance and two vpn Interfaces will lead to create one structure for
config DS and two structures for oper DS.
This commit is change for OperDS. Oper DS is using a vpn-interface-op
structure instead of using vpn-interface structure. The structure is indexed
by interface name and by vpn-instance.
Add adjacencies in vpn-interface-op-data. In oper DS,
vpn-interface-op-data will benefit from adjacencies like it has been
done for config DS with vpn-interface structure.
o vpn-util: introduction of vpn-interface-op-data related functions
This commit introduces some utility routines to handle
vpn-interface-op-data structures within operDS context.
New functions are:
o getVpnInterfaceOpDataEntryIdentifier
o getVpnInterfaceOpDataEntry
This function is modified, because now, the operational VpnInterface is
VpnInterfaceOpDataEntry:
o getOperationalVpnInterface
o scheduleVpnInterfaceForRemoval
Add utility functions to handle adjacenciesOp. The introduction of
AdjacenciesOp structure, based on VpnInterfaceOpDataEntry introduces two
new routines.
o getVpnInterfaceOpDataEntry
o getVpnInterfaceOpDataEntryAugmentation
Change-Id: I87a4919899b0c702267977e5942ff8589f77de55
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Noel de Prandieres <prandieres@6wind.com>
Tom Pantelis [Tue, 21 Nov 2017 01:33:52 +0000 (20:33 -0500)]
Updated git submodules
Project: netvirt master
6e8dcbfb96e8fe1bc597eb347d825e386878de82
Fix compiler errors in aclservice
Patches https://git.opendaylight.org/gerrit/#/c/62955/ and
https://git.opendaylight.org/gerrit/#/c/64684/ crossed while
merging and cause compile errors.
The first patch introduced an AclDataUtil interface which has the
same name as the AclDataUtil impl. It's confusing to have classes
with the same name and it's also a bit strange to have an interface
with Util in the name so I renamed the interface to AclDataCache.
I also changed the Map getters in AclDataUtil to return copies
as the caller shouldn't modify them.
Change-Id: I1f818d06f967665fe677ddf7b0bad71f7640f8ac
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Sam Hague [Tue, 21 Nov 2017 02:38:01 +0000 (21:38 -0500)]
Updated git submodules
Project: integration/test master
fc4066a7346ebe74cce54e9a0e7c02916591a73d
Use full path to netvirt tests
Change-Id: Iee93f187f6cc568aa18a21ec6fc7fc1d1834d734
Signed-off-by: Sam Hague <shague@redhat.com>
Charles La Voy [Tue, 21 Nov 2017 02:42:44 +0000 (02:42 +0000)]
Merge "add p4plugin user guide"
wsx25289 [Mon, 13 Nov 2017 03:14:06 +0000 (11:14 +0800)]
add p4plugin user guide
Change-Id: I6233920389439e98f33de1626e4adfbead671f9d
Signed-off-by: Wsx25289 <10200860@zte.com.cn>
Tomas Jamrisko [Mon, 20 Nov 2017 14:10:45 +0000 (15:10 +0100)]
Updated git submodules
Project: integration/test master
72439d5260cfbdd3cdafff256c18c060aaeb643c
Workarounds for containers
Adding NODE_KARAF_COUNT_COMMAND as all the other operations on
nodes can be overwritten on command line and this is useful when
running from a container.
Also changing the start function to check for "docker" as we don't
want to add those options when using docker.
This is just a temporary fix that makes it usable, but it could be
limiting and require more work later
Change-Id: I5e90cefcb52dec9b9666813824a6a42721db173d
Signed-off-by: Tomas Jamrisko <tjamrisk@redhat.com>
Sam Hague [Fri, 17 Nov 2017 14:30:09 +0000 (09:30 -0500)]
Updated git submodules
Project: integration/test master
d7b7c20493d2f213c5934d8fe9e7c8b55183d91c
name netvirt suites consistently
Change-Id: Iadfd417aead7bd8fae53f468931ba181e3f5832c
Signed-off-by: Sam Hague <shague@redhat.com>
Robert Varga [Mon, 20 Nov 2017 18:30:34 +0000 (19:30 +0100)]
Updated git submodules
Project: aaa master
e00327f07f1fb38db437afdf4a243a327514e13d
Fix odlparent-3.0.0 checkstyle violations
There are new violations reported:
- hidden fields
- utility classes with public constructor
Change-Id: Iced411566cc5e1d8c5d69554222db0d53bedee3f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 20 Nov 2017 18:34:39 +0000 (19:34 +0100)]
Updated git submodules
Project: aaa master
9bb7b0619aa7d9bb47976f0a6ae2bd11752b97e8
Remove duplicate dependency declarations
This fixes maven warnings related to duplicates being declared.
Change-Id: I9b2c905b893de73466bd7f2012b1e53fb0ba236f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Mon, 20 Nov 2017 09:55:38 +0000 (10:55 +0100)]
Updated git submodules
Project: netvirt master
9feb03fc46134de121b4687c68ca5da15b4915e8
NETVIRT-1000: protect handleNeutronPortCreated
This patch ensures that the write transaction in
NeutronPortChangeListener::handleNeutronPortCreated is always closed.
Change-Id: I97fed4d99d0c81bf4f8c2704233238884dbb2a0d
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Charles La Voy [Mon, 20 Nov 2017 22:48:43 +0000 (16:48 -0600)]
Remove link to oxygen release notes for DOCS-46
Change-Id: If55bd9a8055433291c487f2882aecb3ae24367f9
Signed-off-by: Charles La Voy <clavoy@luminanetworks.com>
Jamo Luhrsen [Mon, 20 Nov 2017 21:57:32 +0000 (13:57 -0800)]
Updated git submodules
Project: integration/test master
4bc6d322cadd82c7e9ca56824b3d2c267c128cb4
Fix sfc variable VP_IPS -> NET1_VM_IPS
this was overlooked in the refactor here:
https://git.opendaylight.org/gerrit/#/c/65589/4/csit/suites/openstack/extensions/sfc.robot
Change-Id: Ife8823eef4be6846ce8a783e71cfdb4c961012b7
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Faseela K [Mon, 20 Nov 2017 16:35:07 +0000 (22:05 +0530)]
Updated git submodules
Project: genius master
1a046eee0953c77004f2281b770a3e4a87a9b635
Fix too long service binding INFO logs
Change-Id: I93860de36c332a1a8fcca0d06e5073fb2baac439
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Kit Lou [Mon, 20 Nov 2017 20:16:28 +0000 (20:16 +0000)]
Merge "Add Oxygen OpFlex M2 status"
Nishchya Gupta [Mon, 11 Sep 2017 09:12:41 +0000 (14:42 +0530)]
Updated git submodules
Project: netvirt master
ddefd7082060a352624b2aa6961f9c825172365d
Changes are related to provide a command to display acl caches.
Added a new command display-acl-data-cache with aclservice scope,this
command displays the data for in total 4 caches of acl module.
Three cache from AclDatautils and one cache from AclInterfaceCacheUtil.
Usages for command will be shown if input command is improper.
Change-Id: Ide45e04b41747ddc1dd59fbad8e05b1d61e6964b
Signed-off-by: Nishchya Gupta <nishchyag@altencalsoftlabs.com>
Michael Vorburger [Mon, 20 Nov 2017 17:02:14 +0000 (18:02 +0100)]
Updated git submodules
Project: netvirt master
0c3a7e3103fea3dc039519ab4d4497fd218dc3d8
Fix bad transaction leak in VpnInterfaceManager
see https://jira.opendaylight.org/browse/NETVIRT-985
292x transactions opened here, which are not closed:
org.opendaylight.controller.md.sal.binding.impl.BindingDOMDataBrokerAdapter.newWriteOnlyTransaction(BindingDOMDataBrokerAdapter.java:69)
(...)
org.opendaylight.netvirt.vpnmanager.VpnInterfaceManager.addToLabelMapper(VpnInterfaceManager.java:1594)
org.opendaylight.netvirt.vpnmanager.populator.impl.L3vpnPopulator.addSubnetRouteFibEntry(L3vpnPopulator.java:104)
org.opendaylight.netvirt.vpnmanager.populator.impl.L3vpnOverMplsGrePopulator.populateFib(L3vpnOverMplsGrePopulator.java:57)
org.opendaylight.netvirt.vpnmanager.VpnSubnetRouteHandler.addSubnetRouteToFib(VpnSubnetRouteHandler.java:827)
org.opendaylight.netvirt.vpnmanager.VpnSubnetRouteHandler.electNewDpnForSubnetRoute(VpnSubnetRouteHandler.java:906)
org.opendaylight.netvirt.vpnmanager.VpnSubnetRouteHandler.onSubnetAddedToVpn(VpnSubnetRouteHandler.java:241)
org.opendaylight.netvirt.vpnmanager.SubnetmapChangeListener.add(SubnetmapChangeListener.java:89)
org.opendaylight.netvirt.vpnmanager.SubnetmapChangeListener.add(SubnetmapChangeListener.java:29)
org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase$DataTreeChangeHandler.run(AsyncDataTreeChangeListenerBase.java:158)
Change-Id: I0f62fcc17c037365c9384e56c9f6f5a430693c20
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Tom Pantelis [Sat, 18 Nov 2017 02:09:24 +0000 (21:09 -0500)]
Updated git submodules
Project: netvirt master
2c23a9878c1df52a825c101136b7293b87ce143f
Fix FindBugs violations and enable enforcement in dhcpservice
See in-line comments
Change-Id: Ib1a0b983f1bf89516a55002bbbb7ddb1f6e61d14
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Rob Adams [Mon, 20 Nov 2017 18:59:09 +0000 (10:59 -0800)]
Add Oxygen OpFlex M2 status
Change-Id: Ie5e60f75a14cd056cb302d2ae4885acb96fd9a7d
Signed-off-by: Rob Adams <readams@readams.net>
Kit Lou [Mon, 20 Nov 2017 17:44:39 +0000 (17:44 +0000)]
Merge "Add M2 status for ALTO"
Kit Lou [Mon, 20 Nov 2017 17:42:57 +0000 (17:42 +0000)]
Merge "Provide SXP Oxygen M2 status"
Kit Lou [Mon, 20 Nov 2017 17:41:39 +0000 (17:41 +0000)]
Merge "Oxygen M2 SFC readout."
Michael Vorburger [Mon, 13 Nov 2017 13:11:40 +0000 (14:11 +0100)]
Updated git submodules
Project: infrautils master
ad86dd316c225acd37a50bd7d9778e0431433f52
parent enforcing odlparent's optional checks
Change-Id: I3b91f2c07952c433238fe79c43aad695c4d1f9f0
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Sun, 5 Nov 2017 13:53:27 +0000 (14:53 +0100)]
Updated git submodules
Project: infrautils master
806df4a56233ef97fd63d3b6b4b4bbe775e8c3f1
Add error-prone to parent POM and fix violations
Contrary to c/62090, this does not only emit warnings, but will actually
fail the build for (some) error-prone violations, for project using
infrautils' parent.
see http://errorprone.info/bugpatterns
Change-Id: I7ced66455052c6417c0f8da8479dc58984489489
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
ebrjohn [Fri, 17 Nov 2017 21:59:46 +0000 (15:59 -0600)]
Oxygen M2 SFC readout.
Change-Id: I6c8634373f5e8d08d487a3bd38f28aedf2ca2268
Signed-off-by: Brady Johnson <bjohnson@inocybe.com>
Tom Pantelis [Thu, 16 Nov 2017 23:00:29 +0000 (18:00 -0500)]
Updated git submodules
Project: genius master
4dd03a34f25a9257e634f23c24688983c5e045b8
Enable FindBugs enforcement in alivenessmonitor-impl
No violations found!
Change-Id: I41b94f0b0c7a3d9bb7e239c45733448db80ac2f4
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Michael Vorburger [Thu, 16 Nov 2017 19:49:13 +0000 (20:49 +0100)]
Updated git submodules
Project: genius master
85d48f9c523ec73ccda5cc38b395b2b405958e44
ItmInternalTunnel[Add|Delete]Worker with DataBroker as field instead arg
Change-Id: Iedb80eb07a9b7be9a377d3e904512a5ae343c1c7
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Martin Dindoffer [Mon, 20 Nov 2017 14:30:51 +0000 (15:30 +0100)]
Provide SXP Oxygen M2 status
Change-Id: I997a4a9b46f699d079a1a11627c72d15fee826bf
Signed-off-by: Martin Dindoffer <martin.dindoffer@pantheon.tech>
Kai Gao [Mon, 20 Nov 2017 14:33:25 +0000 (22:33 +0800)]
Add M2 status for ALTO
Change-Id: I527a3fea836feae798b2dc37f13f6f43d6840867
Signed-off-by: Kai Gao <gaok12@mails.tsinghua.edu.cn>
Tom Pantelis [Thu, 16 Nov 2017 22:49:12 +0000 (17:49 -0500)]
Updated git submodules
Project: genius master
c6d51b5cd461773b68b42128d496967fe76cfa74
Fix FindBugs violations and enable enforcement in lockmanager-impl
Change-Id: I7b84acae64c5fae452903e9797c707732261b12f
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Victor Pickard [Fri, 17 Nov 2017 14:31:06 +0000 (09:31 -0500)]
Updated git submodules
Project: netvirt master
114903ecead870e25e085e0fd527d2e8c6a6687d
NETVIRT-999 - Interface leak when subnet deleted
https://jira.opendaylight.org/browse/NETVIRT-999
Cleanup/remove Interface when subnet is deleted to
fix resource leak.
Change-Id: Iac96a91de9dbdeeb19f8df3d35cd3e7e514e9471
Signed-off-by: Victor Pickard <vpickard@redhat.com>
BugId: NETVIRT-989 TEP not deleted when subnet is deleted
https://jira.opendaylight.org/browse/NETVIRT-989
Remove TEP from ds when subnet is deleted.
Change-Id: I5db9902c53a4021609718330406ad65985e0dffb
Signed-off-by: Victor Pickard <vpickard@redhat.com>
Tom Pantelis [Wed, 15 Nov 2017 07:44:44 +0000 (02:44 -0500)]
Updated git submodules
Project: netvirt master
3963ca8e4fcf9328559bf7e6d79f84b905eb21a9
Remove static VrfEntryListener.isOpenStackVniSemanticsEnforced
VrfEntryListener defines a static isOpenStackVniSemanticsEnforced
which is set in the ctor via the IElanService. FindBugs flags this
as a violation although it technically is safe b/c VrfEntryListener
is a singleton. However statics in this manner aren't good practice.
Users of the static flag should instead inject and obtain the flag
from IElanService.
One user was the static FibUtil class. FibUtil was converted to a
singleton. It also had static methods that take the DataBroker
and IdManagerService. Thee services are now injected and the methods
changed to non-static to make it cleaner. All users of these methods
now inject the FibUtil instance.
Change-Id: Ifecd9511568e263545ca7ce1c486483f67f9fe85
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Fix FindBugs violations and enable enforcement in fibmanager-impl
See in-line comments
Change-Id: I7eeaa287693922b26d92bef840680858b5519845
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sun, 29 Oct 2017 04:02:45 +0000 (00:02 -0400)]
Updated git submodules
Project: netvirt master
a3ddc9bfba1fbe82ce72aee6904db901ad24a5bb
Fix FindBugs violations and enable enforcement in bgpmanager-impl
See in-line comments (most on patch set 1)
The thrift-generated code has a quite a few violations and, as
we do with other generated code, I excluded it from analysis.
Only one of the violations in was serious:
Impossible cast from org.apache.thrift.TApplicationException to
org.apache.thrift.TBase
This occurs in every BgpConfigurator inner class that creates an
anonymous AsyncMethodCallback instance from its getResultHandler
method. The generated code in onError method does a blind cast
to a clearly incompatible class. I'm not sure what the correct
solution is if we wanted to manual fix the generated code as I'm
not familiar with how thrift works. There isn't a TBase
implementation for an Exception and the generated *_result classes
don't have a field for an Exception.
Change-Id: I3a6a2fd60f2088e307a213563f267bdf00bdd1ef
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Thu, 16 Nov 2017 20:07:36 +0000 (15:07 -0500)]
Updated git submodules
Project: netvirt master
75fc65060a2090776e86187c0edaed02bbd1f489
Remove NeutronUtils#lock/unLock in favor of KeyedLock
The lock/unLock code in NeutronUtils should not be static and
doesn't really belong in a static utils class. A new KeyedLock
class was aded to infrautils so utilize that in NeutronvpnManager
and NeutronFloatingToFixedIpMappingChangeListener. Instead of a
shared, global KeyedLock, each class creates local instances
per resource to lock (router, vpn, interface).
Change-Id: Icbd9c341c8d7399e31ed8c38b92177a7fa8ed666
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Wed, 25 Oct 2017 02:01:21 +0000 (22:01 -0400)]
Updated git submodules
Project: netvirt master
9ddb426212cb8db03250d0e28be80cc0b3b1801b
Fixes/cleanup in aclservice-impl
See inline comments.
Change-Id: I03ec0d7e1a5fd44d617e2e9486714c8e76a1418d
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 18 Nov 2017 00:20:04 +0000 (19:20 -0500)]
Updated git submodules
Project: netvirt master
99a2746aa9863fcc7c1e7d09c29110fa94432e4b
Convert vpnmanager-impl to use blueprint annotations
Now that the circular dependencies have been eliminated, we can
blueprint annotations.
Change-Id: I10d0849e885cff3cb721ca44d84a4c2c3afa92a9
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Stephen Kitt [Fri, 17 Nov 2017 15:31:22 +0000 (16:31 +0100)]
Updated git submodules
Project: genius master
1a7f4be052318beb91a7566f87c3871613f08858
Shut down the resource batcher before cleaning up
Currently, every time the batcher runs, it retrieves the information
it needs from a map. When we unregister a resource, we remove that
information before stopping the scheduled thread; this can result in
errors being logged because the thread fires between the removal and
the scheduler shutdown.
This patch switches the order, stopping the scheduler before cleaning
up the map.
Change-Id: I9a95cbf90b0b45c9d2ffe2731700d8e4416f9c54
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Tom Pantelis [Thu, 16 Nov 2017 22:25:54 +0000 (17:25 -0500)]
Updated git submodules
Project: genius master
7113f6619d236ab1be2c6eb9d741f51930a221b5
Fix FindBugs violations and enable enforcement in idmanager-impl
See in-line comments
Change-Id: I0a204876084ed15dca98c9022f8940869b3750f8
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Michael Vorburger [Thu, 16 Nov 2017 10:59:32 +0000 (11:59 +0100)]
Updated git submodules
Project: netvirt master
4f711264634e19350933c34e530bb4ffe059f004
Fix transaction leak in NeutronvpnManager
see https://jira.opendaylight.org/browse/NETVIRT-886
Change-Id: I4b0d73203c46087d35cbfccc8aaf5d29d39d89b0
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sam Hague [Sat, 18 Nov 2017 20:29:11 +0000 (15:29 -0500)]
Updated git submodules
Project: integration/test master
dc784f488a64deb07b7342fd6b0428cdde9a3179
Use iproute instead of nameserver to get gw
The nameserver line is only included when a vm fails
to ping the gw and you see the below messages in the
console log:
=== pinging gateway failed, debugging connection ===
The iproute line is always included:
ip-route:169.254.169.254 via 10.20.20.2 dev eth0
The old code worked because at least one of the vms
in the list would hit the gateway failed block and
get the gw from the nameserver line. The old code
also would only copy the gw address once for all
the vms because it kept a list with size 1 for
the address. The new Get VM IPs tries to get the
gw for each vm and not just one for the whole list
of vms. Timing differences might end up not getting
the nameserver line, so instead use the metadata
line which is always present.
Change-Id: I72637575b5171d3eaad6110ed2e8bc2cefed25ed
Signed-off-by: Sam Hague <shague@redhat.com>
Noel de Prandières [Thu, 16 Nov 2017 14:06:53 +0000 (15:06 +0100)]
Updated git submodules
Project: netvirt master
ef8bc141b53177561899513b5f727343b8686135
FIXUP ipVersionChoice in case of mutiple add of ipversion
Change-Id: I4c80912f515eb18c14b332215f026557f7b53785
Signed-off-by: Noel de Prandières <prandieres@6wind.com>
Tom Pantelis [Fri, 17 Nov 2017 02:33:27 +0000 (21:33 -0500)]
Updated git submodules
Project: netvirt master
594025cf34803d66c4713d09025453e67e4ac872
Eliminate statistics-impl dependency on vpnmanagr-impl
statistics-impl depends on vpnmanagr-impl to get access to the
InterfaceUtils class. This is problematic for converting vpnmanagr-impl
to use blueprint injection annotations b/c all the @Singleton classes
get included in the statistics-impl blueprint xml. It appears the
plugin scans @Singleton classes in all dependencies. I don't know if
there's a way to prevent that but eliminating the dependency on
vpnmanagr-impl would fix it. It is better not to depend on an impl
bundle anyway. Therefore I moved the InterfaceUtils class to the
vpnmanagr-api bunndle. In addition I modified the maven-bundle-plugin
instructions to not export any packages to prevent a dependency on
vpnmanagr-impl in the future.
Change-Id: I3731a4faf37a1ba56659346cb0a5697707acbc32
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Eliminate circular dependencies in vpnmanager-impl
There's several circular dependencies surrounding the
VpnManagerImpl that was cleverly worked around by importing
IVpnManager as an optional service. However circular dependencies
and unnecessary coupling are difficult to understand and maintain
and eliminating them will allow us to use injection annotations.
vpnInstanceListener -> vpnInterfaceManager -> vpnManagerImpl -> vpnInstanceListener
This one was easy by moving the isVPNConfigured code from VpnInstanceListener
to VpnManagerImpl, which was the only caller.
vpnInterfaceManager -> vpnManagerImpl -> vpnInterfaceManager
VpnManagerImpl's IVpnManager interface methods addExtraRoute/delExtraRoute
called a corresponding method on the VpnInterfaceManager so the methods were
moved to IVpnManager/VpnManagerImpl.
vpnSubnetRouteHandler -> vpnInterfaceManager -> vpnManagerImpl -> vpnSubnetRouteHandler
Broke the vpnSubnetRouteHandler -> vpnInterfaceManager by moving
deleteSubnetRouteFibEntryFromDS VpnSubnetRouteHandler which was the only caller.
However this called getVpnsImportingMyRoute et al which are used by
VpnInterfaceManager so these were moved to VpnUtil as they're pretty simple
and mainly use VpnUtil methods anyway.
Also moved addToLabelMapper from VpnInterfaceManager to L3vpnPopulator as it's not
called VpnInterfaceManager. This eliminates unnecessary coupling between
L3vpnPopulator and VpnInterfaceManager.
Change-Id: Ib93a17d2150e5dd758fc294276906d3c4d7c636c
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Sridhar Gaddam [Wed, 11 Oct 2017 07:23:16 +0000 (12:53 +0530)]
Updated git submodules
Project: netvirt master
7def530565fb6937a623e5d8801dae879b21ebcb
Shell Commands to Display Ipv6Service Cache
IPv6Service in netvirt maintains a cache of various Neutron resources to
honor the Router Solicitation/Neighbor Solicitation requests (which are
time sensitive) coming from the VMs spawned on the IPv6 Network.
This patch implements the necessary shell commands to dump the ipv6Cache.
Conflicts:
vpnservice/features/vpnservice-features/pom.xml
vpnservice/features/vpnservice-features/src/main/features/features.xml
Change-Id: Ie1aed6d47da540e3fd94c6a8cc3eedf7b4954989
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
(cherry picked from commit
156124fda4f55fe7c1f34f1e4e8c0584441ad65f)
David Suarez [Thu, 16 Nov 2017 20:23:53 +0000 (21:23 +0100)]
Updated git submodules
Project: sfc master
62cbc5f4ffd63866c026c0c12b9554ba95e79b73
Migrate sfc-ovs listeners to Genius' Listeners framework
Change-Id: I02019c49787c45cd45d3d27d089e5bc0a140416d
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>