Dana Kutenicsova [Fri, 6 Feb 2015 15:59:19 +0000 (16:59 +0100)]
BUG-608 : initial segment routing model for BGP
Change-Id: Id364a1e4255f6d0604b0ff66f51da0c1799167f0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 3 Feb 2015 12:50:57 +0000 (13:50 +0100)]
BUG-2228 : modified best path selection algorithm according to RFC5004
Change-Id: Iaf5a95487eef5060da253c2153086540216d016c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 30 Jan 2015 17:07:48 +0000 (18:07 +0100)]
Add prefixForByteBuf method to util.
Change-Id: Iad68714b97074d71aa7051860e5d1f5af32da48a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 26 Jan 2015 16:50:50 +0000 (17:50 +0100)]
BUG-2571 - added parsers for new Extended Communities
Change-Id: I7bbf4f3d47164e8eaccd72f97e41703df51c4539
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 26 Jan 2015 16:34:51 +0000 (17:34 +0100)]
Rework of extended communities.
- moved parsing/serializing of the header to separate methods
- switch to use ByteBufWriteUtil
- rewritten tests to be more clear
Change-Id: Ibc7ba4d7d54c80b9f7c2f59b96172c29a3b318c4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 26 Jan 2015 12:43:59 +0000 (13:43 +0100)]
BUG-2571 : initial model for BGP flow specification
Change-Id: I33c73bda31dfe18101802ff0db6e0fa2e6e994fb
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 18 Jan 2015 21:21:22 +0000 (22:21 +0100)]
BUG-2225 : upgraded docs to new draft version.
Change-Id: I5d02da38279edf5ee2d26fa1d19660782a274b6f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Thu, 22 Jan 2015 18:42:11 +0000 (18:42 +0000)]
Merge "Bug-2225 Update PCEP segment routing according draft version 00."
Robert Varga [Thu, 22 Jan 2015 14:17:38 +0000 (15:17 +0100)]
BUG-2475: Fix keepalives not being sent
As it turns out, we failed to update channel configuration when MD5 keys
were not specified.
Change-Id: I5c2a5983c0797d032bb058974aac82254b554041
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Fri, 5 Dec 2014 09:27:28 +0000 (10:27 +0100)]
Bug-2225 Update PCEP segment routing according draft version 00.
reference: http://tools.ietf.org/html/draft-ietf-pce-segment-routing-00
-removed "02" suffix from package names, class names and yang filed
-added SR RRO Subobject model, parser/serializer and tests
-added new PCEP errors
-removed unnecessary PCEP messages extensions
-removed F and S flags from Subobject model - can be determined from context
Change-Id: Iac566fea7b3f74e0bd61341306ac5a5e46bbf15e
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Wed, 21 Jan 2015 14:45:11 +0000 (15:45 +0100)]
Optimize AsPath lists
Tracing on 500K routes has shown we waste about 35MB of memory in sparse
arrays. It turns out that we fail to size ArrayLists properly when
allocating AsPaths: in case of attribute, we can trimToSize(), in case
of individual segments we know the right size beforehand.
Change-Id: Ie25610b9f04e57c6659b69b65f20299c5cb10881
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 21 Jan 2015 15:17:49 +0000 (16:17 +0100)]
Fix a potential deadlock in BGPSession
In a two-session scenario, it is possible to arrive at a ABBA deadlock,
where we acquire locks:
Thread 1 Thread 2
-------- --------
Session A Session B
RIB
RIB <-- blocks waiting for Thread 1
Session B <-- blocks waiting for Thread 2
The lock is being held only for scheduling a task on Thread 2, which a
thread-safe operation, so we can simply remove the need to take the lock
in Thread 1.
Change-Id: I4e55d3228a48790b2f19eef12ce1b54fd57955a0
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Tue, 20 Jan 2015 15:12:20 +0000 (16:12 +0100)]
Fixed synchronization.
Change-Id: I2ae6bcaddfac6fd7555a8b418542cb4f5417f7a1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Tue, 20 Jan 2015 18:32:41 +0000 (18:32 +0000)]
Merge "Fix build breakage after controller API change"
Robert Varga [Tue, 20 Jan 2015 16:17:05 +0000 (17:17 +0100)]
Fix build breakage after controller API change
Just add a canReuse() method.
Change-Id: I142dbf8c304a63ad8f00ec0ea660724721598ca7
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 20 Jan 2015 13:55:54 +0000 (13:55 +0000)]
Merge "BUG-1025 : Moved log level of unrecognized attribute in BGP to WARN."
Robert Varga [Tue, 20 Jan 2015 12:08:54 +0000 (13:08 +0100)]
Fix unsynchronized access to TransactionChain
The background resynchronization task instantiated transactions without
holding RIBImpl lock, leading to:
Exception in thread "Thread-29" java.lang.IllegalStateException: Previous transaction DOM-OPER-1298 is not ready yet
at com.google.common.base.Preconditions.checkState(Preconditions.java:176)
at org.opendaylight.controller.md.sal.dom.store.impl.DOMStoreTransactionChainImpl$Allocated.getSnapshot(DOMStoreTransactionChainImpl.java:68)
at org.opendaylight.controller.md.sal.dom.store.impl.DOMStoreTransactionChainImpl.getSnapshot(DOMStoreTransactionChainImpl.java:111)
at org.opendaylight.controller.md.sal.dom.store.impl.DOMStoreTransactionChainImpl.newReadWriteTransaction(DOMStoreTransactionChainImpl.java:131)
at org.opendaylight.controller.md.sal.dom.broker.impl.AbstractDOMForwardedTransactionFactory.newReadWriteTransaction(AbstractDOMForwardedTransactionFactory.java:206)
at org.opendaylight.controller.md.sal.dom.broker.impl.PingPongTransactionChain.slowAllocateTransaction(PingPongTransactionChain.java:127)
at org.opendaylight.controller.md.sal.dom.broker.impl.PingPongTransactionChain.allocateTransaction(PingPongTransactionChain.java:144)
at org.opendaylight.controller.md.sal.dom.broker.impl.PingPongTransactionChain.newReadWriteTransaction(PingPongTransactionChain.java:295)
at org.opendaylight.controller.md.sal.dom.broker.impl.PingPongTransactionChain.newWriteOnlyTransaction(PingPongTransactionChain.java:326)
at org.opendaylight.controller.md.sal.binding.impl.BindingTranslatedTransactionChain.newWriteOnlyTransaction(BindingTranslatedTransactionChain.java:77)
at org.opendaylight.protocol.bgp.rib.impl.RIBImpl$1.run(RIBImpl.java:125)
at java.lang.Thread.run(Thread.java:745)
Change-Id: I8b5b34f313dbd1b2584ea73aef37fb6e5c6b5120
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Tue, 20 Jan 2015 09:12:32 +0000 (10:12 +0100)]
BUG-1025 : Moved log level of unrecognized attribute in BGP to WARN.
Change-Id: I84a9e252b78407fb9ec091af02805d996b13d374
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Fri, 16 Jan 2015 14:08:02 +0000 (14:08 +0000)]
Merge "Removed rib dependency on linkstate."
Robert Varga [Fri, 16 Jan 2015 14:07:39 +0000 (14:07 +0000)]
Merge "Bug-2226: RFC5886 - Messages parsers/serializers"
Robert Varga [Fri, 16 Jan 2015 14:05:47 +0000 (14:05 +0000)]
Merge "Refactor linkstate."
Dana Kutenicsova [Fri, 16 Jan 2015 13:54:41 +0000 (13:54 +0000)]
Merge "Bug 868: Replaced use of toInstance() for build()."
Dana Kutenicsova [Tue, 25 Nov 2014 15:34:44 +0000 (16:34 +0100)]
Refactor linkstate.
- split LinkstateAttributeParser to Node/Link/Prefix AttributeParser
- split LinkstateNlriParser to Node/Link/PrefixNlriParser
- moved constants from TlvCode to appropriate classes
- renamed TlvCode class to TlvUtil
- small improvements in the code
Change-Id: I9ce95ef9d704e9e2a183121c35ba5973d2ec308e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 16 Jan 2015 09:45:49 +0000 (09:45 +0000)]
Merge "Set root pom.xml <name> for Sonar"
Milos Fabian [Tue, 28 Oct 2014 09:54:14 +0000 (10:54 +0100)]
Bug-2226: RFC5886 - Messages parsers/serializers
-new messages PCMonReq and PCMonRep parsers/serializers implementation
-extended PCReq and PCRep message parsers/serializer
-fixed and refactored PCReq message parser
Change-Id: I53081c1cdca7d8e0acedc24e25260f31f76032cd
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Tony Tkacik [Fri, 16 Jan 2015 09:21:59 +0000 (10:21 +0100)]
Bug 868: Replaced use of toInstance() for build().
Change-Id: I55280880475f6011d5494dba30e4ac052c34b474
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Dana Kutenicsova [Fri, 16 Jan 2015 08:32:26 +0000 (09:32 +0100)]
Removed rib dependency on linkstate.
Change-Id: I179f13ceace2a65c299ca657ebfb63ded6e7040f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Wed, 14 Jan 2015 16:42:43 +0000 (16:42 +0000)]
Merge "Bug-2225: Move Path Setup Type TLV to base PCEP"
Ed Warnicke [Tue, 13 Jan 2015 15:14:37 +0000 (09:14 -0600)]
Remove deprecated BindingAwareProvider methods
https://git.opendaylight.org/gerrit/#/c/13806/
will remove deprecated BindingAwareProvider methods.
This patch simply removes them from
implmementation of that interface so when 13806 is
merged we can merge this to fix.
Change-Id: I8606df504c491b1167224b6f4d61dd6c2efb3af4
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Milos Fabian [Thu, 4 Dec 2014 10:14:04 +0000 (11:14 +0100)]
Bug-2225: Move Path Setup Type TLV to base PCEP
-moved PST TLV yang model to pcep-types.yang
-added to RP Object TLV container
-added to SRP Object TLV container in stateful07
-moved/updated parsers/serializers according to changes in model
-segment routnig extends PST TLV parser/serializer - can handle PST=1
-added PST TLV as input argument in addLsp and updateLsp
-addLsp - optional for RSVP-TE, resp. PST TLV is omitted in message when PST=0; must be present for SR
-updateLsp - if present, use PST TLV defined in input argument; otherwise use stored one.
-LSP can be migrated from RSVP-TE to SR-TE and vice-versa -> PST TLV must be explicitly included in input args.
-removeLsp - stored PST TLV is used
-PST TLV is exposed in pcep-topology - if present in report message
-motivation:
-get rid of ugly augmentations in segment-routing
-get rid of hacking (adding PST TLV) in PCEP SR messages serializer
-reference: https://tools.ietf.org/html/draft-sivabalan-pce-lsp-setup-type-02
Change-Id: Id6e099fe5bb55e7436c7e89df4821a547ed065b8
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Thanh Ha [Fri, 9 Jan 2015 21:53:41 +0000 (16:53 -0500)]
Set root pom.xml <name> for Sonar
As mentioned on the mailing list Sonar uses the <name> field of the
pom.xml that is passed to the mvn command as the name of the project in
Sonar. In most cases this is the root pom.xml file in a project. This
patch sets the name to the project shortname.
https://lists.opendaylight.org/pipermail/discuss/2014-November/004024.html
Change-Id: Ib41a4bf3539149b81023ad857d0d0136f885e55a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Robert Varga [Fri, 9 Jan 2015 16:12:59 +0000 (16:12 +0000)]
Merge "BUG-2568 : fixed generated EORs"
Dana Kutenicsova [Fri, 9 Jan 2015 14:51:55 +0000 (15:51 +0100)]
Avoid NPE when PCC node was cleaned up from the topology.
Change-Id: I9a232dba0726517f09f2ae0945910e989e8ecaab
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Thu, 8 Jan 2015 12:50:11 +0000 (13:50 +0100)]
BUG-2568 : fixed generated EORs
Change-Id: I225b8aa7a1741f7c472715567e6157df42b6d69f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Thu, 8 Jan 2015 13:44:30 +0000 (13:44 +0000)]
Merge "Added forgotten SLRG attribute to linkstate-topology output."
Robert Varga [Mon, 1 Dec 2014 16:42:41 +0000 (17:42 +0100)]
Use mdsal-artifacts for dependencies
Instead of declaring them manually, use the exported artifacts.
Change-Id: Ia38931fbfc1aff14a4284078a796c9cb61f31177
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Wed, 7 Jan 2015 09:34:41 +0000 (10:34 +0100)]
Added forgotten SLRG attribute to linkstate-topology output.
Change-Id: I5c19cb5f60a4955f1e1f5ad16aec3067401a93d0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Wed, 7 Jan 2015 12:32:01 +0000 (13:32 +0100)]
Remove references to xtend-lib-osgi
This library is no longer needed (and no longer exported from
yangtools), so remove any and all references to it.
Change-Id: I80bff551e29cb66ed4d767d44f6f03efe5d2cf4e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sat, 15 Nov 2014 15:20:54 +0000 (16:20 +0100)]
BUG-196 : support graceful restart
- rework parser/serializer for capability
- from now on, bgp peer is sending graceful restart
capability by default, to increase speed of synchronization
Change-Id: Ida62710ff505288bff48d6d78faf5142b7a43db5
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Wed, 24 Dec 2014 12:49:51 +0000 (12:49 +0000)]
Merge "Introducing method byteBufForAddress."
Robert Varga [Wed, 24 Dec 2014 12:49:13 +0000 (12:49 +0000)]
Merge "Fixed version warnings in pom files."
Robert Varga [Wed, 24 Dec 2014 12:48:10 +0000 (12:48 +0000)]
Merge "Added key to list of advertized tables to be compliant with 6020."
Dana Kutenicsova [Tue, 23 Dec 2014 21:41:01 +0000 (22:41 +0100)]
Fixed version warnings in pom files.
Change-Id: I7b13a07e74cf4f10f12021edc804a585e975c902
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 23 Dec 2014 16:39:46 +0000 (16:39 +0000)]
Merge "Split out RIBEntry"
Dana Kutenicsova [Sat, 22 Nov 2014 15:51:43 +0000 (16:51 +0100)]
Introducing method byteBufForAddress.
Change-Id: I7494a20ea464a35553895076402298a63631abb7
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 12 Dec 2014 12:13:04 +0000 (13:13 +0100)]
Added key to list of advertized tables to be compliant with 6020.
Change-Id: I24f37cadad003de8f27c51eea0d0e5ec70a1bd74
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit
c3aadd1f5006b0c477396039a873dd2b03e66741)
Dana Kutenicsova [Tue, 23 Dec 2014 16:10:25 +0000 (16:10 +0000)]
Merge changes Ia42de3cd,Iae8be8b9
* changes:
The set of local tables should always be a Set
Improve documentation
Robert Varga [Tue, 23 Dec 2014 15:19:44 +0000 (15:19 +0000)]
Merge changes I8c9c6038,I7d340c4d
* changes:
Bug-2226: RFC5886 - New objects parsers/seriazers
Bug-2226: RFC5886 yang model
Robert Varga [Tue, 23 Dec 2014 00:38:23 +0000 (01:38 +0100)]
Split out RIBEntry
Change-Id: Ifccb24128ebb32172ada1cc61d8e3bc2c593270c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 22 Dec 2014 23:22:55 +0000 (00:22 +0100)]
The set of local tables should always be a Set
Change-Id: Ia42de3cd6aeb4df01df601b3410f5ca92d5920df
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 22 Dec 2014 23:14:13 +0000 (00:14 +0100)]
Improve documentation
Change-Id: Iae8be8b9646e60747e4554418c3bfad63fe30990
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 19 Dec 2014 16:13:16 +0000 (17:13 +0100)]
Further optimize reachability topology builder
When we remove a large number of prefixes, we end up reading the current
prefixes over and over, just to make sure we can clean up the node.
This is very slow when there is a large number of prefixes. As it turns
out, we can cache node presence in a very lightweight manner and perform
a simple delete counting to expire it. It also helps with the add case,
as we do not have to issue a merge every time.
Change-Id: Ibd5d15a96e758480edf5cf12324fee9215784042
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 19 Dec 2014 12:37:58 +0000 (13:37 +0100)]
Optimize reachability topology builder
Instead of performing a read(), which forces a temporary commit within
the transaction, issue a merge to ensure the node is present. Also
optimize the delete case very slightly, by reading one level deeper.
Change-Id: I5cf0aa27b03b9782297bae59268389529e805fae
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Mon, 27 Oct 2014 09:37:16 +0000 (10:37 +0100)]
Bug-2226: RFC5886 - New objects parsers/seriazers
-Implementation of parsers and serializers for
new objects defined in RFC5886
-ref.: https://tools.ietf.org/html/rfc5886
Change-Id: I8c9c6038058f3dbdf19253c6284cd29619237359
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Thu, 23 Oct 2014 14:58:18 +0000 (16:58 +0200)]
Bug-2226: RFC5886 yang model
reference: https://tools.ietf.org/html/rfc5886
https://tools.ietf.org/html/draft-many-pce-pcep-bcp-00
- new objects:
- MONITORING
- PCC-REQ-ID
- PCE-ID
- PROC-TIME
- OVERLOAD
-extended messages
-PCRep
-PCReq
-new messages:
-PCMonRep
-PCMonReq (extended PCReq can be reused)
Change-Id: I7d340c4d05d6e8635a5539649ce5c9213ea6b4f8
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Fri, 12 Dec 2014 16:17:57 +0000 (17:17 +0100)]
Bug-2508: Switch PCEP topology provider to use pingpong-binding-data-broker
-changed initial config file, pingpong-binding-data-broker instance is now injected as data-broker
-the change increases performance
Change-Id: Ib06b0d5e68926d648110e004960e46d5ee5dd707
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Thu, 27 Nov 2014 08:51:27 +0000 (09:51 +0100)]
Bug-2423: LSP Identifiers TLV in PCEP-SR PCRpt messsage
-LSP Identifier TLV is not included in LSP object of PCRpt
message for PCEP segment routing
-since building of PCEP topology depends on LSP Identifier,
lets put fake LSP Identifier (use PLSP ID value)
Change-Id: Idb0ec249a11f343c6071e6bf286fa2cb6f91940f
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit
06dd46a992e834d73e526f4a600a8aae4f88a0e0)
Dana Kutenicsova [Mon, 1 Dec 2014 15:56:09 +0000 (16:56 +0100)]
BUG-1953 : adjust ISO system identifier
Change-Id: Ia71d4f2e07f21e1cb30c87cf7d4c3802b4d970f1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Mon, 1 Dec 2014 16:49:40 +0000 (16:49 +0000)]
Merge "BUG-2255 : adjusted BGP configuration to use pingpong data broker."
Robert Varga [Mon, 1 Dec 2014 16:48:57 +0000 (16:48 +0000)]
Merge "BUG-2448 : added more defensive lookup to node & link attributes"
Dana Kutenicsova [Mon, 1 Dec 2014 08:22:25 +0000 (09:22 +0100)]
More warnings down:
- remove empty statement
- add private constructor where needed
- log exception
- order modifiers
- duplicate string literals
Change-Id: I9456437fd66421dbb040f08f469b2a99851cce66
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 28 Nov 2014 13:44:49 +0000 (14:44 +0100)]
Switch statements should end with a default case.
Change-Id: I04b67c4c8a0109a00867970a122a30bc26228b90
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 28 Nov 2014 12:52:48 +0000 (13:52 +0100)]
Constant names should comply with a naming convention.
Change-Id: Ia52c00bcb2c4aa8ffab978046fedf2ebd0234408
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 28 Nov 2014 09:51:21 +0000 (10:51 +0100)]
BUG-2448 : added more defensive lookup to node & link attributes
Change-Id: I2feb75c1a178df0eeffe8e234072eafa3628bd6a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 26 Nov 2014 13:07:02 +0000 (13:07 +0000)]
Merge "Bug-2436: PCEP segment-routing - take F and S flag into account"
Milos Fabian [Wed, 26 Nov 2014 10:32:46 +0000 (11:32 +0100)]
Bug-2436: PCEP segment-routing - take F and S flag into account
-if F flag is set, NAI value is ommited
-if S flag is set, SID value is ommited
Change-Id: Ia92680c77af0a6f8b1406de4723e9e9174479a4c
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Tue, 25 Nov 2014 13:14:38 +0000 (14:14 +0100)]
Bug-2418 PCEP session statistics RuntimeBean was not closed properly
-RuntimeBean was not unregistered, when session was closed - causing NPE in netconf-state
Change-Id: I85cab707e4626fa0c22d02080eb90cc3be01ef7f
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Tue, 25 Nov 2014 15:36:04 +0000 (16:36 +0100)]
BUG-2255 : adjusted BGP configuration to use pingpong data broker.
Change-Id: I455b9ed3d655675585c6eee48e4fa934bea289a1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Milos Fabian [Tue, 25 Nov 2014 14:30:08 +0000 (15:30 +0100)]
Bug-1953: Fix bgpcep tests
-ipv4/6 prefixes must contain mask
Change-Id: I93c4ce30e98f5a0cd5fa8ba86a39129ee837d800
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 24 Nov 2014 13:48:59 +0000 (14:48 +0100)]
Bug-865: modified BGPCEP config tests
-edited config tests to reflect changes in binding-broker config module
https://git.opendaylight.org/gerrit/#/c/13018/
Change-Id: Ibdf28b9df4908500e178453b727f35c7e9b93243
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Wed, 19 Nov 2014 17:12:07 +0000 (18:12 +0100)]
Wipe operational state
Clustered data store may end up persisting our data, which means that if
an instance comes up after a crash, we may have stale data. Rather than
failing to come up, lets just wipe whatever was there.
Change-Id: I3b43d9bf692f083142e44fe8b588d1a92f81e7a2
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Fri, 21 Nov 2014 21:04:54 +0000 (21:04 +0000)]
Merge "Use TCPMD5-supplied artifacts"
Robert Varga [Thu, 20 Nov 2014 17:56:15 +0000 (18:56 +0100)]
Use TCPMD5-supplied artifacts
Rather than declaring the versions by hand we just import whatever is
exported.
Change-Id: I2c08b7dc7ef7350f25ab26821d207570be6d013b
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 20 Nov 2014 17:54:51 +0000 (18:54 +0100)]
Remove unneeded model declarations
the yangtools artifacts import already handles these, so no need to be
repetetive.
Change-Id: Ie9a2c9630e6c1ea41535679860946028b130e95b
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 21 Nov 2014 10:03:55 +0000 (11:03 +0100)]
BUG-2157: Fix missing programming models
This fixes the hanging tests, since the RPC registration process
requires the models to be present.
Change-Id: I2f986821a610e2664305c0f49f5ce19e7ba660b8
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 19 Nov 2014 16:44:53 +0000 (16:44 +0000)]
Merge "Synchronize close methods in RIB and topology provider to avoid closing conflicts."
Dana Kutenicsova [Tue, 18 Nov 2014 15:21:35 +0000 (16:21 +0100)]
Synchronize close methods in RIB and topology provider to avoid closing conflicts.
Change-Id: I758e55c932500189aead22dd858af140a93d3667
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Tue, 18 Nov 2014 17:56:17 +0000 (17:56 +0000)]
Merge "BUG-2383: lower default candidate allocation"
Robert Varga [Tue, 18 Nov 2014 17:55:59 +0000 (17:55 +0000)]
Merge "BUG-2283 : workaround in programming-impl"
Robert Varga [Sun, 16 Nov 2014 13:58:33 +0000 (14:58 +0100)]
BUG-2383: lower default candidate allocation
Rather than allocating the default of 16 entries, we force the HashMap
to allocate a lower number of entries. While this is not a complete
solution, it lowers the memory overhead significantly.
Change-Id: Ic3afe36381930d567ee7523856b3d3959c013459
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit
547bd6ec0a7d0147572dc355ab186571bf42e8b7)
Dana Kutenicsova [Tue, 18 Nov 2014 14:37:39 +0000 (15:37 +0100)]
BUG-2283 : workaround in programming-impl
Change-Id: Ibff71c25a5106e1cff96feb8a1429caa54735825
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Vratko Polak [Tue, 18 Nov 2014 14:18:58 +0000 (15:18 +0100)]
Bug 2398: AbstractTopologyBuilder() to put() with createParents.
Change-Id: I96bd59ce75a09ddcde6460327a131b46b61744d9
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Robert Varga [Thu, 13 Nov 2014 18:01:30 +0000 (19:01 +0100)]
BUG-2385: introduce a shorter version of identifierForKey()
This takes advantage of the fact that the basePath is passed down to the
constructor -- so the subclasses can actually do a better job at
finiding the true base path.
Change-Id: I965e27ca6599bc606d8447acf7e6f2ddc1370ac4
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 14 Nov 2014 17:38:22 +0000 (17:38 +0000)]
Merge "Read-only transactions were not being closed"
Robert Varga [Thu, 6 Nov 2014 15:40:24 +0000 (16:40 +0100)]
Read-only transactions were not being closed
We have failed to close read-only transactions, which can lead to resource
starvation.
Change-Id: I62dbf6b6409a65f279b01c3bb5b2238ffa6febc8
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit
16cdb27ad01eb27950aba2c6fd5e4b03881a623a)
Robert Varga [Thu, 13 Nov 2014 18:27:48 +0000 (19:27 +0100)]
Use config-artifacts for dependencies
Rather than manually pulling configuration dependencies, use the
artifacts provided.
Change-Id: Ie992c7fd771d9d5051ace3319607285d9be93729
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 13 Nov 2014 18:23:46 +0000 (19:23 +0100)]
Use yangtools-artifacts for dependencies.
Rather than relying on manual dependencies, let's just import the
artifacts published by yangtools.
Change-Id: I9289d3982aca2a8eb6c5265cf2999bec133a653f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Thu, 13 Nov 2014 11:37:22 +0000 (12:37 +0100)]
Fixed ordering of configuration files in features.xml
Change-Id: I4d09667dad74a31c26fe52c24d85939bf400e440
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Tue, 11 Nov 2014 15:16:15 +0000 (15:16 +0000)]
Merge "BUG-731: last warnings fixed"
Dana Kutenicsova [Mon, 10 Nov 2014 15:37:46 +0000 (16:37 +0100)]
BUG-731: last warnings fixed
Change-Id: I649141d1c6209a2774a3dda2f3d6b3ab27217888
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Tue, 11 Nov 2014 10:49:42 +0000 (10:49 +0000)]
Merge "Added forgotten MAX_MSG_PER_READ option to BGP."
Dana Kutenicsova [Mon, 10 Nov 2014 16:58:25 +0000 (17:58 +0100)]
Added forgotten MAX_MSG_PER_READ option to BGP.
Change-Id: I690f2043a4c8a4d4ee9c48bf64c8841b1a704b16
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Mon, 3 Nov 2014 14:06:56 +0000 (15:06 +0100)]
BUG-2299: allow PCEP extensions to be reconfigured
The trigger here is a change in the extensions cause the corresponding
context to be re-created from scratch, which leads to the topology
manager to being re-created. This patch implements instance reuse by
adding proper activator hooks.
Change-Id: I5f114b81ceeb26a3943afc4bd2f0c34b678ff029
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 10 Nov 2014 09:33:17 +0000 (09:33 +0000)]
Merge "BUG-2109 : clear BGP session after it was already initialized"
Dana Kutenicsova [Fri, 7 Nov 2014 15:24:17 +0000 (16:24 +0100)]
BUG-731 : more warnings down
Change-Id: I83598fdb04d4357d3efc6ed26c1d5beac70686c1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sat, 8 Nov 2014 20:28:30 +0000 (21:28 +0100)]
Split Error identifiers to separate classes.
Change-Id: I1b74e56c3fb79d4eb375a0da7e1e81fc00b52797
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Thu, 6 Nov 2014 13:24:20 +0000 (14:24 +0100)]
BUG-2109 : clear BGP session after it was already initialized
Change-Id: Ib70a725b948892a2a887a941bdcb4e8dcfdb80eb
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 5 Nov 2014 10:39:22 +0000 (11:39 +0100)]
Fix for NPE in OSPF, when forwarding address is not set.
Change-Id: Iff310eee0a5c4c9a34971b6cf5d958d8ed5004e2
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Thu, 6 Nov 2014 10:32:56 +0000 (10:32 +0000)]
Merge "Removed obsolete methods from Ipv4/Ipv6Util."
Dana Kutenicsova [Wed, 5 Nov 2014 14:50:35 +0000 (15:50 +0100)]
Removed obsolete methods from Ipv4/Ipv6Util.
Change-Id: I79a7d82840a989418dc9216b522b8d3fdc4d77cd
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>