Robert Varga [Sat, 20 May 2017 09:57:22 +0000 (11:57 +0200)]
Migrate XML output to yang-data-codec-xml
The codecs provided yang-data-impl are superseded by those in
codec-xml. This patch provides the first part of migration.
Change-Id: If777defcc6218faf5597289956b800d68dcb5e5a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sun, 21 May 2017 16:31:48 +0000 (18:31 +0200)]
Run NormalizedNode parsing inline if possible
While JSON does not guarantee object ordering, we do not have to
fall back to building internal string if we have the target node
set.
If the target has been set, we call directly to parser with our
current parser, which will be moved forward -- which is more
efficient.
Change-Id: I311cc3525944fd2327183c200b3ed9dbee9e915a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 12 Jun 2017 13:12:52 +0000 (15:12 +0200)]
Adjust to EffectiveSchemaContext movement
This code depends directly on parser internals. Adjust the import,
but really this should be fixed by subclassing AbstractSchemaContext
from yang-model-util.
Change-Id: I57c84ec7e721bf0bd1e6a6eef1d8ccd0562f8b74
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
David Suarez [Sat, 3 Jun 2017 16:06:08 +0000 (18:06 +0200)]
Fix checkstyle problems not detected by the current version
This change is required for overall move to new Checkstyle version, see
https://git.opendaylight.org/gerrit/#/q/topic:bumpCheckstyle
Change-Id: I4fac148d693e5de5c96485243a5469a22f1a8237
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Marek Gradzki [Mon, 5 Jun 2017 14:28:44 +0000 (16:28 +0200)]
BUG-8085: create missing parent augmentation node
Augmentation nodes do not exist in serialized form
(e.g. in edit-config message), but are required by DataTree-based
DOMDataBroker implementations, so should be created if data from
augment is present.
This patch creates missing augment nodes by issuing merge on augmentation
before put operation (based on current behaviour for ListSchemaNodes).
Change-Id: If657ae96e914fc46617099042a833c7d4d5883b7
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Thanh Ha [Tue, 6 Jun 2017 02:18:22 +0000 (22:18 -0400)]
Migrate to odlparent 1.8.0-Carbon
Per request of odlparent project we are downgrading all Nitrogen
projects to use the released odlparent 1.8.0-Carbon to allow for the
odlparent project to start performing semver style releases.
Jira: RELENG-159
RT: 41406
Change-Id: Ib81afe4e0e7eb5587044bade9d50d00bc98906e1
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Tomas Cere [Mon, 5 Jun 2017 13:39:45 +0000 (13:39 +0000)]
Merge "Un-deprecate JSONRestconfService(Impl)"
Tomas Cere [Wed, 31 May 2017 12:53:57 +0000 (14:53 +0200)]
BUG 8566 direct writes to ordered list fail
Incorrect handling of direct writes into a mapEntry which tries
to merge an empty parent list instead of an exists check but doesnt
correctly handle the possibility of an OrderedMapNode as a parent.
Change-Id: Ia2c75cc50e6ff4c9c7c9be36846c08cc85cff491
Signed-off-by: Tomas Cere <tcere@cisco.com>
Tom Pantelis [Fri, 2 Jun 2017 03:41:01 +0000 (23:41 -0400)]
Un-deprecate JSONRestconfService(Impl)
Patch https://git.opendaylight.org/gerrit/#/c/56391/ deprecated
JSONRestconfService and JSONRestconfServiceImpl however no reason
was given in the patch message (in fact the patch was about fixing
checkstyle violations) nor were any comments added to the classes
as to why they're deprecated.
There really shouldn't be any reason to deprecate these classes
as they are useful and are used in applications. Therefore I remove
the @Deprecated annotation.
Change-Id: I335c8e8665cc2b489e4d3b690d8cac7dbd157b4f
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tomas Cere [Mon, 29 May 2017 10:44:20 +0000 (10:44 +0000)]
Merge "Test RestconfWrapperProviders"
Tomas Cere [Mon, 29 May 2017 10:43:11 +0000 (10:43 +0000)]
Merge changes Ieb46b050,I6bff6467
* changes:
Bug 8533: Not possible to invoke RPC on mount points with new Restconf
Bug 7933: NPE when posting using XML
Jakub Toth [Thu, 13 Apr 2017 09:50:44 +0000 (11:50 +0200)]
Test RestconfWrapperProviders
Change-Id: Id95c607bba19c56c6924938ba5ef107f8937a76b
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Ivan Hrasko [Tue, 23 May 2017 07:27:43 +0000 (09:27 +0200)]
Bug 8533: Not possible to invoke RPC on mount points with new Restconf
- put identifer of RPC into InstanceIdentiferContext
instead of mount point identifer which leads to fail
in unit test
- when working with mount point use mount point's
schema context to find RPC module, previously used
controller's schema context leads to NPE
- repaired imports in RestconfApplication to use
new implementation
Change-Id: Ieb46b050e881c89ea58bb9f521be69554733d575
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Tomas Cere [Tue, 23 May 2017 10:43:13 +0000 (10:43 +0000)]
Merge "Bug 7933: NPE when posting using XML"
matus.kubica [Thu, 18 May 2017 14:32:26 +0000 (16:32 +0200)]
Bug 7933: NPE when posting using XML
PUT operation:
- fix issue when putting malformed XML body did not
fail with appropriate status.
Change-Id: I6bff6467f4b99bed9adf1ac39def54822899761e
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Robert Varga [Sun, 21 May 2017 15:28:36 +0000 (17:28 +0200)]
Introduce abstract body readers
{Json,Xml}{NormalizedNode,ToPatch}BodyReader classes share some
common code. Factor it out into abstract classes to reduce code
duplication.
Change-Id: I7358151f617f5327fc514ac2066b2aee883b2fba
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sun, 21 May 2017 14:13:33 +0000 (16:13 +0200)]
Use URI.create()
We wrap 'new URI(String)' in a try-catch block, which is not really
necessary -- use URI.create(String) to get pretty much the same
behavior (except for the exception thrown).
Change-Id: Id9baa17dddb564b2be6d2258a1d73947a67c15f6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sun, 21 May 2017 14:12:48 +0000 (16:12 +0200)]
Pre-instantiate operations
There is no point in creating the operations over and over again.
Instantiate them immediately and keep them in an ImmutableSet.
Change-Id: I952bcf026b9d0de99252530e8fc44863408adb3e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Ivan Hrasko [Fri, 19 May 2017 12:39:16 +0000 (14:39 +0200)]
Bug 7933: NPE when posting using XML
- NPE was thrown because leaf value was not parsed,
thus data value was null
- fixed by adding condition to parse leaf nodes
- log warning when unknown schema node type was
not parsed
- fixed in old and new restconf
Change-Id: I13c8e419e35999980548e09f6963b0d407a45b31
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Robert Varga [Sat, 20 May 2017 12:05:46 +0000 (14:05 +0200)]
Fix PatchEditOperation
Enums support methods, so instead of a switch dispatch use normal
property. Also simplify users so they do not pass strings around.
Change-Id: I3818f3d6a4020cee2f2e43fb8ec110e0bc872ba6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sat, 20 May 2017 11:46:12 +0000 (13:46 +0200)]
Optimize JsonToPatchBodyReader
Use a StringBuilder instead of a StringBuffer, use switch statements
and du not use string concat when using StringBuilder.append().
Change-Id: Icaf68a7a92dae6aece4e9382ba4a03bac429d4ec
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sat, 20 May 2017 10:19:08 +0000 (12:19 +0200)]
Fix various warnings
The code is full of eclipse warnings around static methods, raw types
and similar. Fix that up.
Change-Id: I8aa84b8c0fbde5c32ab855dfc215205501ce2777
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Ivan Hrasko [Tue, 16 May 2017 12:14:27 +0000 (14:14 +0200)]
Bug 8153: enforce check-style rules for netconf
- enforce checkstyle in all modules + cleanup
Change-Id: I64b003c8f8f554445423e54642ef46bb95bc90b1
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Ivan Hrasko [Mon, 15 May 2017 13:50:39 +0000 (15:50 +0200)]
Bug 8153: enforce check-style rules for netconf
- call-home
Change-Id: I1b5e2db2d6b0a4d3591e56d773cfcd4ffc13ae67
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Ivan Hrasko [Mon, 15 May 2017 08:52:02 +0000 (10:52 +0200)]
Bug 8153: enforce check-style rules for netconf
- netconf-testool
Change-Id: Ic7e772768596d7e9e66e74896029f72caadeff9e
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Ivan Hrasko [Wed, 17 May 2017 10:54:57 +0000 (12:54 +0200)]
Bug 8351: enforce check-style rules for restconf
- enforce checkstyle in all modules + cleanup
Change-Id: I9d8dc0d8461a11582029debcba8512ef6f0ed96a
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Ivan Hrasko [Mon, 15 May 2017 14:27:34 +0000 (16:27 +0200)]
Bug 8351: enforce check-style rules for restconf
- sal-rest-docgen
Change-Id: I848691f539b189dffcd9ff10fadf5d3c708a9792
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
matus.kubica [Tue, 2 May 2017 14:17:30 +0000 (16:17 +0200)]
Bug 8351: Enforce check-style rules for restconf - sal-rest-connector
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add the fail on violation flag into the pom.xml .
Change-Id: I81b704c5ed79dead57e5e37c925b4aaa8579444a
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Ivan Hrasko [Tue, 16 May 2017 08:55:04 +0000 (10:55 +0200)]
Bug 8455: Yang Patch response is not having the error details
- add error-info to error message
Change-Id: I0d637871969ff91850749228e92bda2055c71eef
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Ivan Hrasko [Mon, 15 May 2017 07:27:53 +0000 (09:27 +0200)]
Bug 8153: enforce check-style rules for netconf
- netconf-cli module
Change-Id: Ifb0be378ff9f3ddc697bb34d139c5fc76b824907
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
matus.kubica [Wed, 19 Apr 2017 09:29:42 +0000 (11:29 +0200)]
Bug 8153: Enforce check-style rules for netconf - mdsal-netconf-connector
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add the fail on violation flag into the pom.xml .
Change-Id: Ib50c1754c97932714d4eb19b7e34a818af8a1a77
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Tomas Cere [Thu, 11 May 2017 10:22:17 +0000 (10:22 +0000)]
Merge "Bug 8351: Enforce check-style rules for restconf - sal-rest-docgen"
Tomas Cere [Thu, 11 May 2017 10:20:50 +0000 (10:20 +0000)]
Merge "Bug 8153: Enforce check-style rules for netconf - yanglib"
miroslav.kovac [Mon, 3 Apr 2017 12:39:19 +0000 (14:39 +0200)]
Bug 8074 - actor name [test-device] is not unique!
When creating a new actor with same name as an old one, it might fail
becuase old actor might not be completely gone at this point.
This creates a slaveActor which will never be closed, but instead
every time that mountpoint is closed or master is changed, it would
update NetconfNodeActor data and keep the same actor.
Only time that actor is closed is when node was deleted. Or slave
became a master
The name of the actor is removed - letting akka to handle that -
log the akka created name.
Change-Id: I6d10db7b8902048632e336fb5a9701a797b363c6
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
Jakub Morvay [Wed, 10 May 2017 13:18:29 +0000 (13:18 +0000)]
Merge "Resolve exception from registerClusterSingletonService"
Andrej Mak [Tue, 9 May 2017 11:17:48 +0000 (13:17 +0200)]
Bug 8405: Add close check to NetconfDevice
Since schema resolution runs in its own thread, it is possible,
that handleSalInitializationSuccess is called when
NetconfDeviceCommunicator was closed meanwhile. Add check to
prevent this.
Change-Id: If93d32b26f0b98c4c0d47fdd65fdb5104db20bc5
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
miroslav.kovac [Wed, 10 May 2017 09:05:14 +0000 (11:05 +0200)]
Resolve exception from registerClusterSingletonService
registerClusterSingletonService return RuntimeException in
case of problems with registration and client should implement
strategy to resolve this issue
Change-Id: If6350969f1d1c2917c78850f4c66629b52137b0b
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
matus.kubica [Tue, 2 May 2017 07:54:31 +0000 (09:54 +0200)]
Bug 8153: Enforce check-style rules for netconf - yanglib
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add the fail on violation flag into the pom.xml .
Change-Id: I841ed5ba3ba57f91e18a82015c7582195cec5562
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
Jakub Morvay [Sat, 6 May 2017 11:55:03 +0000 (11:55 +0000)]
Merge "Bug 7891: Add ssh feature to netconf-netty-util"
Jakub Morvay [Sat, 6 May 2017 11:53:10 +0000 (11:53 +0000)]
Merge "Bug 8364: Set bundle context when module reloads"
Tomas Cere [Fri, 5 May 2017 13:52:24 +0000 (13:52 +0000)]
Merge "Bug 8361 - NetconfConnector cannot be created due to NullPointerException"
matus.kubica [Tue, 25 Apr 2017 12:38:20 +0000 (14:38 +0200)]
Bug 8153: Enforce check-style rules for netconf - netconf-topology-singleton
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add the fail on violation flag into the pom.xml .
Change-Id: I690d1d6c21f042874977f1030f216b08c4c21c45
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
Andrej Mak [Fri, 5 May 2017 09:05:46 +0000 (11:05 +0200)]
Bug 8364: Set bundle context when module reloads
Fix for bug Bug 8214 handles waiting for AAA, when Restconf
is installed for the first time. Override handleChangedClass
to do the same thing for reinstall case. Also close old
module to release bound ports and started threads.
Change-Id: I00f5f330fca39bb63f66517dddd8d1371ae353e8
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
Martin Mihálek [Wed, 3 May 2017 11:24:02 +0000 (13:24 +0200)]
Bug 8361 - NetconfConnector cannot be created due to NullPointerException
- Adds Nullpointer checks in RemoteDeviceConnecterImpl
- If Yang module capabilities are missing its override flag is set to false
- If Non module capabilities are missing its override flag is set to false
Change-Id: I25d172e94a1013d79c0c7db37c930c89ad2ed94f
Signed-off-by: Martin Mihálek <mamihale@cisco.com>
Andrej Mak [Wed, 3 May 2017 07:06:48 +0000 (09:06 +0200)]
Bug 7891: Add ssh feature to netconf-netty-util
Odl-netconf-netty-util needs sshd-core bunde to work.
It is provided by karaf. However, if odl-netconf-netty-util
is placed to featuresBoot, ssh provided by karaf isn't
started, so ResolutionException is thrown. To prevent this
add ssh feature to odl-netconf-netty-util.
Change-Id: Iaf5ecddaa726ea892191b5cf47095c1df3b096f6
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
Tomas Cere [Wed, 3 May 2017 14:01:52 +0000 (14:01 +0000)]
Merge "Bug 8153: Enforce check-style rules for netconf - sal-netconf-connector"
Tomas Cere [Wed, 3 May 2017 13:34:51 +0000 (13:34 +0000)]
Merge "Bug 8153: Enforce check-style rules for netconf - netconf-topology"
matus.kubica [Fri, 21 Apr 2017 09:49:55 +0000 (11:49 +0200)]
Bug 8153: Enforce check-style rules for netconf - netconf-monitoring
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add the fail on violation flag into the pom.xml .
Change-Id: If5e2448d5ae5a312bde0295ed52df9f8314afb6d
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
Tomas Cere [Wed, 3 May 2017 11:25:07 +0000 (11:25 +0000)]
Merge "Bug 8153: Enforce check-style on messagebus-netconf"
matus.kubica [Wed, 3 May 2017 10:56:12 +0000 (12:56 +0200)]
Bug 8351: Enforce check-style rules for restconf - sal-rest-docgen
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add the fail on violation flag into the pom.xml .
Change-Id: If4a4a3b17f8a0b93433fb41813f2560b334fd45c
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
Jakub Morvay [Wed, 3 May 2017 08:55:55 +0000 (08:55 +0000)]
Merge "Do not use InetAddress.getByName()"
Jakub Morvay [Wed, 3 May 2017 07:44:19 +0000 (07:44 +0000)]
Merge "Bug 8311 - Apidoc: Incomprehensible 500 id model is wrong Bug 8266 - Apidoc explorer is broken after installing Boron SR3"
Jakub Morvay [Wed, 3 May 2017 07:08:46 +0000 (07:08 +0000)]
Merge "Bug 8084 - FilterContentValidator.getKeyValues creates invalid YII key values"
miroslav.kovac [Tue, 2 May 2017 13:05:11 +0000 (15:05 +0200)]
Bug 8311 - Apidoc: Incomprehensible 500 id model is wrong
Bug 8266 - Apidoc explorer is broken after installing Boron SR3
Depending on path if it is relative or absolute module has to be
resolved different ways. If it is relative path it will have to
be resolved through DataSchemaNote which returns namespace and
revision of module in which node is situated. If it is absolute
path we need TypeDefinition which returns a namespace and
revision of original module.
Change-Id: I522ea66383ba1d65e6674d5e8ff67ec31e019303
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
Jakub Morvay [Tue, 2 May 2017 11:31:35 +0000 (11:31 +0000)]
Merge "Bug 8311 - Apidoc: Incomprehensible 500 id model is wrong Bug 8266 - Apidoc explorer is broken after installing Boron SR3"
matus.kubica [Tue, 25 Apr 2017 12:04:09 +0000 (14:04 +0200)]
Bug 8153: Enforce check-style rules for netconf - netconf-topology
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add the fail on violation flag into the pom.xml .
Change-Id: I448131bc4ad3138d65762f31872e458e8f46f0cc
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
matus.kubica [Thu, 27 Apr 2017 13:06:53 +0000 (15:06 +0200)]
Bug 8153: Enforce check-style rules for netconf - sal-netconf-connector
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add the fail on violation flag into the pom.xml .
Change-Id: I741ea586178981d6c66533259619c27c24bbd744
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
Robert Varga [Thu, 27 Apr 2017 17:16:24 +0000 (19:16 +0200)]
Do not use InetAddress.getByName()
We have better alternatives for these, use those.
Change-Id: Ibfcea2779b822d0ff2d113bed4fe218d02f64eb5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
matus.kubica [Wed, 19 Apr 2017 12:52:45 +0000 (14:52 +0200)]
Bug 8153: Enforce check-style on messagebus-netconf
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Change-Id: I51b121d8aec45999cef18a960c4b4a0a1c00c57c
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
Tomas Cere [Fri, 28 Apr 2017 12:32:08 +0000 (12:32 +0000)]
Merge "Bug 8153: Enforce check-style rules for netconf - mdsal-netconf-notification"
miroslav.kovac [Fri, 28 Apr 2017 11:20:20 +0000 (13:20 +0200)]
Bug 8311 - Apidoc: Incomprehensible 500 id model is wrong
Bug 8266 - Apidoc explorer is broken after installing Boron SR3
TypeDefinition returns a namespace and revision of original module
if it is coming from grouping. We need a DataSchemaNode which
returns namespace and revision of module in which node is situated.
Change-Id: I48246f86d55414c58226f7b523800e847bac5ee4
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
miroslav.kovac [Fri, 28 Apr 2017 08:17:44 +0000 (10:17 +0200)]
Bug 8289 - 409 in cluster restperfclient test
To ensure message ordering we need ReadWriteTransactionActor. This
way we are sure that all reads and writes will be executed in
the order that they are sent.
Change-Id: I7a76f6b4d9e6e348ec0d58abe24e56dfeae66f24
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
miroslav.kovac [Tue, 28 Mar 2017 15:51:39 +0000 (17:51 +0200)]
Bug 8084 - FilterContentValidator.getKeyValues creates invalid YII key values
Change-Id: Ie6c65c9cb005f9f1be85e04a8cf643e48e07bb94
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
Tomas Cere [Fri, 28 Apr 2017 08:11:12 +0000 (08:11 +0000)]
Merge "Bug 8153: Enforce check-style rules for netconf - netconf-tcp"
Tomas Cere [Fri, 28 Apr 2017 08:11:09 +0000 (08:11 +0000)]
Merge "Bug 8153: Enforce check-style rules for netconf - netconf-notification-impl"
Tomas Cere [Fri, 28 Apr 2017 08:11:05 +0000 (08:11 +0000)]
Merge "Bug 8153: Enforce check-style rules for netconf - netconf-notification-api"
matus.kubica [Thu, 13 Apr 2017 16:01:34 +0000 (18:01 +0200)]
Bug 8153: Enforce check-style rules for netconf - config-netconf-connector
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add the fail on violation flag into the pom.xml .
Change-Id: Idb0546157cb40658eccd2af6b73d66362fc22508
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
miroslav.kovac [Tue, 4 Apr 2017 13:27:06 +0000 (15:27 +0200)]
Bug 8032 - Initialization in sal failed, disconnecting from device
MountpointService is initialized with blueprint and therefore it
should never throw null pointer exception anymore.
All the binding and dom broker are deleted because they are
not needed any more.
Change-Id: I9aa9064752043819bc73043f7b667b4ea2c0fd0a
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
Tomas Cere [Thu, 27 Apr 2017 16:38:28 +0000 (16:38 +0000)]
Merge "Bug 8153: Enforce check-style on netconf-impl"
Tomas Cere [Thu, 27 Apr 2017 16:38:25 +0000 (16:38 +0000)]
Merge "Bug 8153: Enforce check-style rules for netconf - netconf-console"
Tomas Cere [Thu, 27 Apr 2017 16:38:21 +0000 (16:38 +0000)]
Merge "Bug 8153: Enforce check-style rules for netconf-api"
Tomas Cere [Thu, 27 Apr 2017 16:38:17 +0000 (16:38 +0000)]
Merge "Bug 8153: Enforce check-style rules for netconf - mdsal-netconf-yang-library"
Jakub Morvay [Thu, 27 Apr 2017 14:58:09 +0000 (14:58 +0000)]
Merge "Refactor netconf clustered topology tests"
Tomas Cere [Thu, 27 Apr 2017 13:58:55 +0000 (13:58 +0000)]
Merge "Bug 8153: Enforce check-style rules for netconf - aaa-authn-odl-plugin"
matus.kubica [Wed, 19 Apr 2017 11:58:01 +0000 (13:58 +0200)]
Bug 8153: Enforce check-style rules for netconf - mdsal-netconf-notification
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add the fail on violation flag into the pom.xml .
Change-Id: I4d2d61f049132abad779b20c6720b002f0cfba4a
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
matus.kubica [Tue, 25 Apr 2017 09:27:34 +0000 (11:27 +0200)]
Bug 8153: Enforce check-style rules for netconf - netconf-notification-impl
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add the fail on violation flag into the pom.xml .
Change-Id: I0f0f2a503bfc41becf6709503c02808af4324964
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
matus.kubica [Tue, 25 Apr 2017 10:49:43 +0000 (12:49 +0200)]
Bug 8153: Enforce check-style rules for netconf - netconf-tcp
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add the fail on violation flag into the pom.xml .
Change-Id: Ib65a129cf1f715c4ba37c70a177eea021090eac6
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
matus.kubica [Mon, 24 Apr 2017 14:37:01 +0000 (16:37 +0200)]
Bug 8153: Enforce check-style rules for netconf - netconf-notification-api
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add the fail on violation flag into the pom.xml .
Change-Id: Ia72dc0a43df827093c1e0b1490773af8c2f2291e
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
matus.kubica [Fri, 21 Apr 2017 08:30:24 +0000 (10:30 +0200)]
Bug 8153: Enforce check-style on netconf-impl
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add checkstyle for test suites.
Add the fail on violation flag into the pom.xml .
Change-Id: I3173827beb34cbece031e61c1b0ba255357f3445
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
matus.kubica [Fri, 21 Apr 2017 07:41:52 +0000 (09:41 +0200)]
Bug 8153: Enforce check-style rules for netconf - netconf-console
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add the fail on violation flag into the pom.xml .
Change-Id: I35ab1fa9fc90c8180c9800ee88c62371b727a9b1
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
Tomas Cere [Thu, 27 Apr 2017 12:55:55 +0000 (12:55 +0000)]
Merge "Bug 8197: Deregister schema sources on actor stop"
matus.kubica [Wed, 19 Apr 2017 15:07:25 +0000 (17:07 +0200)]
Bug 8153: Enforce check-style rules for netconf-api
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add the fail on violation flag into the pom.xml .
Change-Id: Ibd2c23c38d02a0067d7c980abfd0a54a2cf59306
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
matus.kubica [Wed, 19 Apr 2017 12:18:34 +0000 (14:18 +0200)]
Bug 8153: Enforce check-style rules for netconf - mdsal-netconf-yang-library
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add the fail on violation flag into the pom.xml .
Change-Id: Iafc8742de05233039e7d38ec7177c8ca5ac425a4
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
Tomas Cere [Thu, 27 Apr 2017 12:51:45 +0000 (12:51 +0000)]
Merge "Bug 8153: Enforce check-style rules for netconf - mdsal-netconf-monitoring Organize Imports for Checkstyle compliance. Checkstyle compliance: line length. Checkstyle compliance: various types of small changes. Checkstyle compliant Exception handling. Checkstyle final clean up & enforcement."
Tomas Cere [Thu, 27 Apr 2017 12:51:40 +0000 (12:51 +0000)]
Merge "Bug 8153: Enforce check-style rules for netconf - netconf-netty-util"
Tomas Cere [Thu, 27 Apr 2017 12:51:34 +0000 (12:51 +0000)]
Merge "Bug 8153: Enforce check-style rules for netconf - client."
Tomas Cere [Thu, 27 Apr 2017 12:51:27 +0000 (12:51 +0000)]
Merge "Bug 8153: Enforce check-style rules for netconf - netconf-ssh"
Tomas Cere [Thu, 27 Apr 2017 12:51:03 +0000 (12:51 +0000)]
Merge "Bug 8153: Enforce check-style rules for netconf - netconf-util"
Jakub Morvay [Thu, 27 Apr 2017 12:44:56 +0000 (12:44 +0000)]
Merge "Bug 8152: Add way to configure idle timeout"
Andrej Mak [Tue, 25 Apr 2017 06:19:53 +0000 (08:19 +0200)]
Refactor netconf clustered topology tests
- split long tests into smaller
- remove duplicated code
Change-Id: I64913380fd0768394b430971ef5ff118d56b7b6b
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
matus.kubica [Thu, 13 Apr 2017 14:14:36 +0000 (16:14 +0200)]
Bug 8153: Enforce check-style rules for netconf - aaa-authn-odl-plugin
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add the fail on violation flag into the pom.xml .
Change-Id: I91e2642a694f330863ffcc6b3759a4df530001bb
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
matus.kubica [Tue, 25 Apr 2017 13:49:16 +0000 (15:49 +0200)]
Bug 8153: Enforce check-style rules for netconf - netconf-util
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add the fail on violation flag into the pom.xml .
Change-Id: I4895535d9481489b96ba22671a3f61cc89398d4a
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
Ivan Hrasko [Mon, 24 Apr 2017 08:58:57 +0000 (10:58 +0200)]
Bug 8181 - Add karaf4 feat to artifacts
Change-Id: Ied3f487b8292b41b2a863bedc2ccf2aefaea662d
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
matus.kubica [Wed, 19 Apr 2017 11:26:40 +0000 (13:26 +0200)]
Bug 8153: Enforce check-style rules for netconf - mdsal-netconf-monitoring
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Change-Id: I9535f6b09ea4d3916f3f378a433565f8cbe97d19
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
matus.kubica [Mon, 24 Apr 2017 13:47:45 +0000 (15:47 +0200)]
Bug 8153: Enforce check-style rules for netconf - netconf-netty-util
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add the fail on violation flag into the pom.xml .
Change-Id: I54aa8b0b3e64c83dff89e54ea4e1281ba839ee98
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
Andrej Mak [Wed, 19 Apr 2017 08:32:18 +0000 (10:32 +0200)]
Bug 8152: Add way to configure idle timeout
Clustered apps should be configurable via datastore
to allow config distribution to all nodes according to
https://wiki.opendaylight.org/view/Using_Blueprint#Using_the_Datastore
Add such configuration for clustered topology.
Change-Id: I1a318590c75c6c95da48cb1e0521994f0b83dfe4
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
Andrej Mak [Mon, 24 Apr 2017 13:08:27 +0000 (15:08 +0200)]
Bug 8197: Deregister schema sources on actor stop
NetconfNodeActor registers schema source provider
to schema registry. When mountpoint is removed, this
registration should be removed too. If it isn't,
following issue can happen:
1. Create mountpoint for device1
2. Master actor for device1 is registered as mod-1.yang provider
3. Delete device1
4. Create mountpoint for device2
5. Master actor for device2 is registered as mod-1.yang provider
6. Register slave -
schemaContextFactory.createSchemaContext(sourceIdentifiers)
is called
7. Since dead device1 master is still registered as provider,
ask in ProxyYangTextSourceProvider timeouts
8. After timeout device2 master is queried
9. Device 2 slave mountpoint registered
This delays slave mountpoint registration.
Change-Id: I060c8b1988ba7b54f9a93d7eb37adb5c5e48b23b
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
matus.kubica [Fri, 21 Apr 2017 06:34:11 +0000 (08:34 +0200)]
Bug 8153: Enforce check-style rules for netconf - client.
Organize Imports for Checkstyle compliance.
Checkstyle compliance: line length.
Checkstyle compliance: various types of small changes.
Checkstyle compliant Exception handling.
Checkstyle final clean up & enforcement.
Add the fail on violation flag into the pom.xml .
Change-Id: I889c86f680d93ffe946c5223b86da1c2967af114
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
Robert Varga [Fri, 21 Apr 2017 09:24:49 +0000 (11:24 +0200)]
Make EditConfig methods static
Some of these do not refer to object state and hence we can
make them static.
Change-Id: I220c5a0ed9340bc9cdd8f2ce7541568a2eaa7613
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 21 Apr 2017 09:00:55 +0000 (11:00 +0200)]
Eliminate ReadWriteTransaction proliferation
Many of the internal methods really need only a WriteTransaction,
hence adjust the type to make it more clear what a method can
actually do.
Change-Id: I9f5dca23c5174f2668f269fbf40e811e7046862d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
0d3d0f4c0d3ca99f4b3dc6367d3f1b02fdcdfed8)