Robert Varga [Tue, 21 Jan 2014 07:50:03 +0000 (08:50 +0100)]
Improve generation of node/link identifiers
Change-Id: I90580daa4f3a2e34cf51b754a07e7e6950bd5015
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 20 Jan 2014 17:05:01 +0000 (18:05 +0100)]
Add more info about state being processed
Change-Id: Ic58ee7726658cb98ca96d6ec4ceeb1fcb09fc4d4
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 20 Jan 2014 17:04:11 +0000 (18:04 +0100)]
Spell out termination points being created
Change-Id: Id447e4409c9d1aee0b7eb19e3c6cdb295cf7c7a8
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Mon, 20 Jan 2014 14:02:04 +0000 (15:02 +0100)]
Created separated project for stateful07.
Change-Id: I04b6f5c4ff8bebcbd9e3e675de853b53c6486d0f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 20 Jan 2014 13:26:39 +0000 (14:26 +0100)]
Rename models to reside in ODL namespace
Change-Id: Ica56ec7c909ea6d99649a85b901f846d71c5ea6a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 20 Jan 2014 13:13:00 +0000 (13:13 +0000)]
Merge "Created separated project for stateful-02."
Dana Kutenicsova [Mon, 20 Jan 2014 10:15:39 +0000 (11:15 +0100)]
Created separated project for stateful-02.
Change-Id: I1914920cd7006d272eaed260d868018a871cf663
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Maros Marsalek [Thu, 9 Jan 2014 11:52:25 +0000 (12:52 +0100)]
Added routed rpcs to pcep-topology|tunnel-provider
Also added integration(pax-exam) test to test the routing
Change-Id: I385f99ecc0fbb9c3cee0a555c87335f3080e2412
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Dana Kutenicsova [Mon, 20 Jan 2014 08:37:04 +0000 (08:37 +0000)]
Merge "Bump yangtools to 0.6.0"
Robert Varga [Mon, 20 Jan 2014 08:23:11 +0000 (09:23 +0100)]
Bump yangtools to 0.6.0
Change-Id: I7f0018ad64e49356b6f3dd7ab1d42f6cdcb47f82
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sun, 19 Jan 2014 14:50:05 +0000 (14:50 +0000)]
Merge "Bumped initiated draft to draft-ietf-pce-pce-initiated-lsp-00."
Dana Kutenicsova [Sun, 19 Jan 2014 14:12:38 +0000 (15:12 +0100)]
Bumped initiated draft to draft-ietf-pce-pce-initiated-lsp-00.
Change-Id: I0882741b7e8b5a95479aa687d203409cf8562109
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Sun, 19 Jan 2014 13:19:22 +0000 (14:19 +0100)]
Add logback into dependency management section
Change-Id: I107aa6dd3fd2e5efc065b37e9c16ec3f473e5608
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 16 Jan 2014 16:14:28 +0000 (17:14 +0100)]
Switch to controller-provided protocol framework
Change-Id: I378be68986a867477044ef8f35a0f50e410de82f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 16 Jan 2014 15:58:54 +0000 (16:58 +0100)]
Switch to yangtools-provided mockito configuration
This depends on https://git.opendaylight.org/gerrit/#/c/4316/ being
merged.
Change-Id: Ibbe90af42acb202a42d2329b6e24ee88dc90c981
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 17 Jan 2014 12:28:52 +0000 (13:28 +0100)]
Add scm tag in preparation for release
Change-Id: I08ccc6ef9fe636a61f659c2b21ce8e3d1449e014
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 17 Jan 2014 11:30:55 +0000 (11:30 +0000)]
Merge "Bumped stateful draft to 07."
Robert Varga [Fri, 17 Jan 2014 11:16:53 +0000 (12:16 +0100)]
Fix unimplemented module
Change-Id: I6c8a37361ea2305ec3d085fb231e6f0ca651ffc8
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Fri, 17 Jan 2014 10:26:22 +0000 (11:26 +0100)]
Bumped stateful draft to 07.
Change-Id: Ic81ddd5138436c2795a7b94505d1df49cd3c6639
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Thu, 16 Jan 2014 12:52:24 +0000 (13:52 +0100)]
BUG-221 : created Activator for stateful draft.
Change-Id: Ia10f071da98835c29d0e65bb6b5d2952383916af
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Maros Marsalek [Tue, 14 Jan 2014 12:51:57 +0000 (13:51 +0100)]
Transform initial config files to xml format
Change-Id: I33401ad6065bdf18ad65ed4c2e22a6d05ca39822
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
jenkins-bgpcep [Thu, 16 Jan 2014 09:54:20 +0000 (09:54 +0000)]
Update to new version of the artifacts proposed by jenkins-bgpcep-version-changes-2
Change-Id: Ie2fc60b51d84ef76a8d7674a59e4eff85bec5718
Signed-off-by: jenkins-bgpcep <jenkins-bgpcep@opendaylight.org>
Robert Varga [Thu, 16 Jan 2014 08:43:32 +0000 (09:43 +0100)]
Deprecate SSLUtil
SSLUtil has no use in this project and was moved into ints sole user in
the controller project.
Change-Id: I10418fb2abe436c79ab967a911e8e9c5fc33c451
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 15 Jan 2014 15:51:13 +0000 (16:51 +0100)]
More missing copyright headers
Change-Id: Ide3aa6263b557d9497eac1f9a56db1993caca50d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 14 Jan 2014 13:32:55 +0000 (14:32 +0100)]
Rework metadata storage to retain metadata through PCEP session flaps
Change-Id: I38651e6286cbca4280ac342799d3b42fab8d8bcd
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 13 Jan 2014 10:27:50 +0000 (11:27 +0100)]
Disable example BGP client
Change-Id: I81cddad1b763458af42500b4b94f7c22b52c7cbc
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 13 Jan 2014 11:41:57 +0000 (12:41 +0100)]
Unify logback version
Also remove OSGi dependency, as it is no longer used
Change-Id: Ied9c19c9b761485607f318704e9a08239bacb704
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 13 Jan 2014 10:10:26 +0000 (11:10 +0100)]
Use ODL nexus group for release artifacts
Change-Id: Ibe1e7a0d9804723f0a9a6bab72b89b465fa850ba
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 13 Jan 2014 09:45:08 +0000 (10:45 +0100)]
Add missing copyright headers
Change-Id: I5e98168c13ee87e16d76dfed5a983d8d42ed0ab6
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 13 Jan 2014 09:34:11 +0000 (10:34 +0100)]
Switch to using System.err.println() for help
Change-Id: Ie7a1b1df9393d03472b7975534dda0f2e39eb3b9
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 13 Jan 2014 09:27:56 +0000 (10:27 +0100)]
Remove System.out and improve the test
Change-Id: I53d13a6f08aab159f3c52a1377852c957bc6011e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Fri, 10 Jan 2014 10:24:29 +0000 (11:24 +0100)]
BUG-221 : finished splitting stateful draft.
Change-Id: Iabd77a3bc5c9ab8c3b9add1ed8a247b03c0c16e8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Thu, 9 Jan 2014 20:18:38 +0000 (21:18 +0100)]
Adjusted area identifier.
Change-Id: I0258a1cc80605b30c29835b428c5cbfd2f1d692c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Maros Marsalek [Wed, 8 Jan 2014 10:57:44 +0000 (11:57 +0100)]
Added test for ProgrammingServiceImpl
Tested
-scheduling, canceling, executing and cleaning of transactions with or without dependencies
-timeout of instructions in different states with or without dependencies
Change-Id: I2fa5d592c31fe93227c535f2c7deb015aaf4f2e2
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Dana Kutenicsova [Thu, 9 Jan 2014 15:39:28 +0000 (15:39 +0000)]
Merge "Improve debug logging to track prefixes"
Dana Kutenicsova [Thu, 9 Jan 2014 15:35:47 +0000 (15:35 +0000)]
Merge "Add an attachment point for metadata and propagate it into topology"
Robert Varga [Thu, 9 Jan 2014 15:13:14 +0000 (16:13 +0100)]
Improve debug logging to track prefixes
Change-Id: Ibdd5cf0e50f096153e7e6cbb745fd7ddb30a3dd5
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 9 Jan 2014 14:12:38 +0000 (14:12 +0000)]
Merge "Changed length of IS-IS Area Identifier from fixed to range."
Dana Kutenicsova [Thu, 9 Jan 2014 14:07:42 +0000 (14:07 +0000)]
Merge "Re-activate disabled test"
Dana Kutenicsova [Thu, 9 Jan 2014 13:33:40 +0000 (14:33 +0100)]
Changed length of IS-IS Area Identifier from fixed to range.
Change-Id: I626f8e6b6bc36a5a5f3d41355e1dd0ae2a48b7df
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Thu, 9 Jan 2014 11:05:26 +0000 (12:05 +0100)]
Add an attachment point for metadata and propagate it into topology
Change-Id: I3083ea3e6c427d4168376e8158bba9a60d588fec
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 19 Dec 2013 12:27:55 +0000 (13:27 +0100)]
Re-activate disabled test
The test was deactivated due to deficiencies in testing framework.
Change-Id: I3846dfbf44219e3ddde45a01094ca16ac1e167fb
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Wed, 8 Jan 2014 14:31:18 +0000 (15:31 +0100)]
BUG-185 : fixed NPE.
Change-Id: Ic2c2e64628815c61a95226bdcab9b22a2d0b0209
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 8 Jan 2014 14:11:50 +0000 (15:11 +0100)]
Fixed BGP configuration.
Change-Id: I3aa3dee36d0233b67c8db05f1a21c7fbf2390f04
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 7 Jan 2014 13:55:04 +0000 (14:55 +0100)]
BUG-185 : implemented Best Path Selection Algorithm.
Change-Id: Iec0f6440e21f12e140606973e15901542092c63e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 7 Jan 2014 08:34:55 +0000 (08:34 +0000)]
Merge "Generate WADL files for RESTCONF endpoints"
Robert Varga [Mon, 6 Jan 2014 09:44:25 +0000 (09:44 +0000)]
Merge "Adding support for the git-review command line tool"
Robert Varga [Mon, 6 Jan 2014 08:30:15 +0000 (09:30 +0100)]
Generate WADL files for RESTCONF endpoints
Change-Id: Ia6f21ef49d12db95b6ef6af2553711f2e8c65497
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 1 Jan 2014 13:03:13 +0000 (14:03 +0100)]
Rename lists such that they follow IETF conventions
reported-lsps -> reported-lsp
various subobjects -> subobject
Change-Id: I08bea6203401a2a05a78af669fe3c6a98636b326
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 31 Dec 2013 12:06:08 +0000 (13:06 +0100)]
Expose PCEP peer IP address in topology
This patch adjusts the PCEP topology extensions to explicitly expose the
PCC IP address as visible by the PCE. Note that this address may be
subject to NAT and thus may not bear any relationship with the IP
address as seen on the PCC.
Change-Id: I7513a6278fadc023a624367a99df2b9edd4e13ca
Signed-off-by: Robert Varga <rovarga@cisco.com>
Colin McNamara [Mon, 30 Dec 2013 03:10:50 +0000 (19:10 -0800)]
Adding support for the git-review command line tool
The OpenStack doc workflow (and entire gerrit workflow) has the
option of using a tool called git-review that automates ChangeID:
creation and management,automates rebasing of local commits
as well as simplifies submiting to gerrit and pulling and
pushing reviews.
Usage of the tool is entirely optional, however it does require
a pointer file named .gitreview in the root of the repository
that is referenced.
I am totally new to this project, if you guys don't want to merge
this then no big deal. However I think this will help with dev's
coming over from OpenStack as it will provide a optional workflow
that is closer to the OpenStack workflow.
It is necessary to run git review -s to append the change-id into
git-hooks the first time you use the tool
Change-Id: I73a912d2b8a6a00166387b97d96f1ec8804e3558
Signed-off-by: Colin McNamara <colin@2cups.com>
Robert Varga [Sun, 22 Dec 2013 20:33:37 +0000 (21:33 +0100)]
BUG-221: Split off stateful draft
Change-Id: I053aedb426efaa8d1a1758064d366166feba300f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sun, 22 Dec 2013 20:32:23 +0000 (21:32 +0100)]
Remove stray comment
Change-Id: I3ea3e909982ce0cf1fa224bfd1d7812b802a9019
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 23 Dec 2013 12:58:41 +0000 (13:58 +0100)]
Initialize instruction list to empty
Change-Id: I972caaa6e320a6335f329ba75bde997066c7165d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 23 Dec 2013 09:22:59 +0000 (10:22 +0100)]
Initialize the list of reported LSPs
Change-Id: I07fad7cc59c3c381c15325bfac783177e6af3e7e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 23 Dec 2013 07:33:14 +0000 (08:33 +0100)]
Fix a few deprecation warnings in framework
Change-Id: I8eacfe7e84b2322d6daf8d0838fcb69ec391a050
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 23 Dec 2013 07:28:03 +0000 (08:28 +0100)]
Instantiate the local rib with empty tables
Change-Id: Ie949507cf51ae8291f513ca5d2a29c34c8f0cdc0
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 20 Dec 2013 16:50:07 +0000 (16:50 +0000)]
Merge "Add SimpleBGPExtensionProviderContextModuleTest."
Robert Varga [Fri, 20 Dec 2013 12:35:31 +0000 (13:35 +0100)]
Improve BGP/LS topology export
This improves the topology export in the following ways:
- dynamic hostname is propagated
- OSPF router types for internal, ABR and pseudonode are handled
- IS-IS node types are detected correctly
- OSPF TED information is being filled
Change-Id: Ic437871cd658ab44f9914aa86e2846652811b0e7
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 20 Dec 2013 10:01:48 +0000 (10:01 +0000)]
Merge "Replaced Linkstate attribute tlv codes with static finals."
Dana Kutenicsova [Thu, 19 Dec 2013 15:33:07 +0000 (16:33 +0100)]
Replaced Linkstate attribute tlv codes with static finals.
Change-Id: Ia7dd3ed6c172ae1e01109c41ca1164dfc6fa20b1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Thu, 19 Dec 2013 17:06:19 +0000 (18:06 +0100)]
Implement PCE ID union type builder
Change-Id: I7e53b274101feb357dfef67bf3d71148be8f94a8
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 12 Dec 2013 08:30:51 +0000 (09:30 +0100)]
BUG-185: include the ability to configure multiple peers
Change-Id: Ia09859bc7b2c9483029df0584a8630d3fb92fd9f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 18 Dec 2013 23:02:05 +0000 (00:02 +0100)]
Make sure RIB entry is created when the implementation starts
Change-Id: I92174ea6634cd738dec97058fa35316d726c477e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 18 Dec 2013 22:13:56 +0000 (23:13 +0100)]
Fix RIB ID not being set
Change-Id: I3cca8ead10a74206e1fcbeaabf967b8d83e3af55
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tomas Olvecky [Wed, 18 Dec 2013 17:42:34 +0000 (18:42 +0100)]
Add SimpleBGPExtensionProviderContextModuleTest.
Add test to bgp-parser-spi-config, simplify tests in bgp-rib-impl-config.
Fix wrong comparison of modules for reusage decision in
http://git.opendaylight.org/gerrit/3831 that should fix the bgpcep build.
Change-Id: Ida75aec5c438f7058992a89d4ee90a046f92c8a8
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Robert Varga [Wed, 18 Dec 2013 15:44:10 +0000 (16:44 +0100)]
Fix NPE when node attributes are not present
By the same token, also fix the link and prefix cases.
Change-Id: I5c2bd356d8aeec674414aee32461431e556617d5
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Tue, 17 Dec 2013 22:38:00 +0000 (23:38 +0100)]
Added more logs.
Change-Id: I934e5d96f242b463cb761b4a42fe1e8f1773234a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Tue, 17 Dec 2013 19:44:05 +0000 (20:44 +0100)]
Handle null LinkstateDestination case
Change-Id: I8b6f45e9d8018be3234ded076d597188fff985c7
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 17 Dec 2013 18:57:47 +0000 (19:57 +0100)]
Make sure we can operate without a link state attribute
This just makes the code more defensive and allows it to return an empty
attribute when the BGP update message does not have the link state
attribute.
Change-Id: I957bdc119c8939841a4b8556902bdbc2d116da21
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Tue, 17 Dec 2013 12:47:09 +0000 (13:47 +0100)]
Fixing NPE when adding linkstate routes.
Change-Id: If0f6fdbe1b38af0c2ceb72550a0941dcf52479e2
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 16 Dec 2013 15:51:05 +0000 (16:51 +0100)]
Fixed PCEP synchronization.
Change-Id: I4d552691227b820e28b3482886cb95161701fa8d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 16 Dec 2013 15:49:21 +0000 (16:49 +0100)]
Fixed BGP synchronization.
Change-Id: I95ece0d4d9cf28df71acaebe6367ddd1b20fa3ba
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 16 Dec 2013 08:47:52 +0000 (09:47 +0100)]
Fixed some sonar warnings.
Change-Id: Id479799620a766afdec826913c2bf7213d1d2699
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Fri, 13 Dec 2013 23:54:52 +0000 (00:54 +0100)]
Adjust dependencies
Change-Id: I93d40bbd53ddbe30ede9e65bb05c4bddba380726
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Fri, 13 Dec 2013 19:34:04 +0000 (20:34 +0100)]
BUG-199 : bgp negotiation now working without mentioning specific multiprotocol capabilities.
Change-Id: I22287197daa0941e151f0dda81ab1e78cf00f199
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 13 Dec 2013 19:38:04 +0000 (19:38 +0000)]
Merge "BUG-218: expose instruction status in MD-SAL"
Dana Kutenicsova [Fri, 13 Dec 2013 19:37:01 +0000 (19:37 +0000)]
Merge "BUG-223: Support having multiple RIB instances"
Dana Kutenicsova [Fri, 13 Dec 2013 19:13:59 +0000 (19:13 +0000)]
Merge "BUG-191: provide a way for executors to provide scheduling feedback"
Robert Varga [Fri, 13 Dec 2013 16:58:00 +0000 (17:58 +0100)]
BUG-218: expose instruction status in MD-SAL
Change-Id: I03f9c9562b314a6da264acab418a856daadc7217
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 9 Nov 2013 08:08:45 +0000 (09:08 +0100)]
BUG-191: provide a way for executors to provide scheduling feedback
The idea is that the executor is hooked onto the ListenableFuture,
kicking in if it succeeds. Should the insn be cancelled, the future
will be, too.
The notification part is handled internally until the Future succeeds --
once it does, the executor can either start immediately executing, after
checking with the Instruction, or inform it why it delayed execution.
Once execution completes, the executor pushes the appropriate details
into the instruction.
Change-Id: I9dd9c29c876b890cadf842941c1e59e0f394cf84
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Fri, 13 Dec 2013 14:54:58 +0000 (15:54 +0100)]
BUG-130 : introduced ObjectUtil.
Change-Id: I5f323f4e404e522dae6d3d7fb7cfb29bf36242f5
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Fri, 13 Dec 2013 06:49:34 +0000 (07:49 +0100)]
Fixup a few sonar warnings
Change-Id: I80a9a4d2f8507980b7d933f25bb7e23fc22409cc
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 12 Dec 2013 17:47:12 +0000 (18:47 +0100)]
BUG-242: expose configuration through well-known artifacts
Change-Id: I5167c506347eadb8a397eb4285ec1f903f29ea6b
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 11 Dec 2013 13:59:08 +0000 (14:59 +0100)]
BUG-223: Support having multiple RIB instances
Change-Id: Ie9b2786b13058b6ee622b6aed6a83f09556b0046
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 12 Dec 2013 08:28:48 +0000 (09:28 +0100)]
Drop mandatory flag to allow inclusion in augmentations
Change-Id: I4cc225eae087c1de25caaf7b0b2e35fce2ec9b34
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 11 Dec 2013 18:46:25 +0000 (19:46 +0100)]
Fix a NPE when MultiTopology ID is not present
Change-Id: Id035a03481d5882e93f40ba678709bebc46bae1d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 11 Dec 2013 17:29:12 +0000 (18:29 +0100)]
Improve abstract topology builder to resist NPEs
It is possible for an instance identifier to not contain the expected
class. Detect the condition, log it and continue rather than failing the
entire update. Evidenced by:
java.lang.NullPointerException: null
at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:191) ~[bundlefile:na]
at org.opendaylight.bgpcep.bgp.topology.provider.AbstractTopologyBuilder.onLocRIBChange(AbstractTopologyBuilder.java:108) ~[na:na]
at org.opendaylight.bgpcep.bgp.topology.provider.AbstractTopologyBuilder.onDataChanged(AbstractTopologyBuilder.java:155) ~[na:na]
at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.publishDataChangeEvent(TwoPhaseCommit.java:131) [bundlefile:na]
at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.call(TwoPhaseCommit.java:97) [bundlefile:na]
at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.call(TwoPhaseCommit.java:31) [bundlefile:na]
at java.util.concurrent.FutureTask.run(Unknown Source) [na:1.7.0_45]
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [na:1.7.0_45]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [na:1.7.0_45]
at java.lang.Thread.run(Unknown Source) [na:1.7.0_45]
Change-Id: I1a152a05d9d1370d74aa9cf607877f5d113ffbf9
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Wed, 11 Dec 2013 17:23:51 +0000 (17:23 +0000)]
Merge "Increase log level to warning"
Dana Kutenicsova [Wed, 11 Dec 2013 16:50:09 +0000 (17:50 +0100)]
Warn log level not needed.
Change-Id: I8ca195ef99137e45245200494a0788edf28b014f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Wed, 11 Dec 2013 17:01:55 +0000 (17:01 +0000)]
Merge "BUG-130 : introduced XROSubobjectUtil."
Robert Varga [Wed, 11 Dec 2013 16:59:23 +0000 (17:59 +0100)]
Increase log level to warning
The abstract class catching RuntimeException indicates major
implementation problem, raise it to warning from info.
Change-Id: Ibe2defaa474e9914e1a7dd93e31d78f73bfa0da2
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 11 Dec 2013 16:58:56 +0000 (16:58 +0000)]
Merge "BUG-130 : introduced RROSubobjectUtil."
Robert Varga [Wed, 11 Dec 2013 16:57:30 +0000 (16:57 +0000)]
Merge "BUG-130: introduced EROSubobjectUtil."
Robert Varga [Wed, 11 Dec 2013 16:34:09 +0000 (17:34 +0100)]
Fix Link/Node/Prefix class cast problems
2013-12-11 08:02:03.994 PST [pool-25-thread-14] INFO o.o.b.b.t.p.AbstractTopologyBuilder - Data change org.opendaylight.controller.md.sal.common.impl.service.DataChangeEventImpl@
2e2cfae9 was not completely propagated to listener org.opendaylight.bgpcep.bgp.topology.provider.LinkstateTopologyBuilder@
731a1c7d
java.lang.ClassCastException: org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.linkstate.rev131125.loc.rib.tables.routes.linkstate.routes._case.linkstate.routes.linkstate.route.attributes.attribute.type.LinkCaseBuilder$LinkCaseImpl cannot be cast to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.linkstate.rev131125.update.path.attributes.linkstate.path.attribute.link.state.attribute.link.attributes._case.LinkAttributes
at org.opendaylight.bgpcep.bgp.topology.provider.LinkstateTopologyBuilder.createLink(LinkstateTopologyBuilder.java:226) ~[na:na]
at org.opendaylight.bgpcep.bgp.topology.provider.LinkstateTopologyBuilder.createObject(LinkstateTopologyBuilder.java:415) ~[na:na]
at org.opendaylight.bgpcep.bgp.topology.provider.LinkstateTopologyBuilder.createObject(LinkstateTopologyBuilder.java:91) ~[na:na]
at org.opendaylight.bgpcep.bgp.topology.provider.AbstractTopologyBuilder.onLocRIBChange(AbstractTopologyBuilder.java:125) ~[na:na]
at org.opendaylight.bgpcep.bgp.topology.provider.AbstractTopologyBuilder.onDataChanged(AbstractTopologyBuilder.java:155) ~[na:na]
at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.publishDataChangeEvent(TwoPhaseCommit.java:131) [bundlefile:na]
at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.call(TwoPhaseCommit.java:97) [bundlefile:na]
at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.call(TwoPhaseCommit.java:31) [bundlefile:na]
at java.util.concurrent.FutureTask.run(Unknown Source) [na:1.7.0_45]
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [na:1.7.0_45]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [na:1.7.0_45]
at java.lang.Thread.run(Unknown Source) [na:1.7.0_45]
Change-Id: I01044cb22f75cf94c96a486aad1e292b1f417585
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Wed, 11 Dec 2013 15:40:31 +0000 (16:40 +0100)]
BUG-130 : introduced XROSubobjectUtil.
Change-Id: I4379bad92913ca164637f44856edda11a9e7bbe8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 11 Dec 2013 14:36:14 +0000 (15:36 +0100)]
BUG-130 : introduced RROSubobjectUtil.
Change-Id: I14e3585315d309bb04e76fc23d787f66b19527ee
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 11 Dec 2013 13:46:39 +0000 (14:46 +0100)]
BUG-130: introduced EROSubobjectUtil.
Change-Id: Icb5a15dc398da020b3a4c72b6d47f8c4b7f3a098
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Wed, 11 Dec 2013 14:51:07 +0000 (15:51 +0100)]
Fix BGP-based topology builders failing to commit anything
Change-Id: I06648bbc2a69dd7590991d2e4defef38c8e272a6
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Wed, 11 Dec 2013 08:46:58 +0000 (08:46 +0000)]
Merge "Fix message arguments to match format string"
Code Review / bgpcep.git / log