Migrate sfc docs to project repo

Change-Id: Ia75f52fb0c1f24bfd5428a92eb1a68717e57f43e
Signed-off-by: Thanh Ha <[email protected]>

Master branch is now Neon

Change-Id: Id581977ce73f3f60311ce2060f04680cb4af1aec
Signed-off-by: Thanh Ha <[email protected]>

Return Set instead of Iterable in test

Method signature will be changed to Set to define equality, prepare
for that.

Change-Id: I6d0754e21196e03727400631d20d85fe4c84f903
Signed-off-by: Robert Varga <[email protected]>

Fix vxlan_tool to work with Python3

Now this tool can work with Python 2 and 3 as well

Change-Id: Id0256a8ecaf3341bbd1b0c6c1bb58a99e1411eb1
Signed-off-by: gvrangan <[email protected]>

Remove references to mdsal-model-artifacts

This artifact is going away, migrate to mdsal-artifacts.

Change-Id: Ib051be61e8d83c53a81321b472b6955c58c664e5
Signed-off-by: Robert Varga <[email protected]>

Bump versions by x.(y+1).z for next dev cycle

Change-Id: I40bf744b1e446c844a7f447e7ef27639e7db1495
Signed-off-by: Anil Belur <[email protected]>

Fixes to sfc103 demo for OVS 2.9 NSH changes.

Change-Id: I5c162752088d216308be2f70adcc66236664584d
Signed-off-by: Brady Johnson <[email protected]>

Remove Callable APIs from SFC OVS

- The SFC OVS API in SfcOvsDataStoreAPI are now called directly.

Change-Id: Id9b455c1b5008d5648f48633aefdd8331eb8da84
Signed-off-by: Brady Johnson <[email protected]>

Fix missing blueprint build plugin in poms

Fix issue introduced in commit 1ad7b63f where blueprint annotations
were used without adding the proper build plugin to module poms.

Change-Id: Ie845f81879b1adcf5c0ed6a53f08b677cdcc73ad
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Bump to odlparent 3.1.3

Change-Id: I36fcc5060713539f02fbba3d9290f237d44994dd
Signed-off-by: Stephen Kitt <[email protected]>

Adjust to DOMDataTreeCommitCohort API change

Implement the new canCommit method in ServiceFunctionPathCohort
that returns FluentFuture instead of the deprecated CheckedFuture.

Change-Id: I18dd564542ad367212a89c9652b731ac64bbbfe6
Signed-off-by: Tom Pantelis <[email protected]>

Add support for official OVS NSH implementation

Changes the SFC NSH pipeline to align to the official OVS NSH
implementation as detailed on spec [1].

[1] https://git.opendaylight.org/gerrit/#/c/72078/

Change-Id: Ic907dd5bfa302b664cc1593ee2b2c3aca3aefde7
JIRA: TSC-114
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Update paramiko and pycrypto dependencies

According to GitHub there are security vulnerabilities in these
2 packages. Bump paramiko up to a fixed version and set pycrypto
to pull in latest patch version so that it will automatically pick
up the fix when it is available.
https://github.com/opendaylight/sfc/network/dependencies

Change-Id: If4fdb4244272aff080ad5c9a84d312e389616191
Signed-off-by: Thanh Ha <[email protected]>

Use moved BindingReflections

BindingReflections are being evacuated from yang-binding, use them
from their new location.

Change-Id: I6703ec47d6f2e70c4cbad7dd1754f044e8fee236
Signed-off-by: Robert Varga <[email protected]>

Do not user char[] union constructor

This constructor is just a bridge towards
*Builder.getDefaultInstance(), do not use it. This also fixes
use of getVaue() -- which has been replaced by stringValue().

Change-Id: I14d53f2ffdb09c729392b208da837eb7588658bc
Signed-off-by: Robert Varga <[email protected]>

Use IetfInetUtil to convert InetAddress

We provide a utility method for this particular conversion,
use it instead of open-coding it.

Change-Id: I8753c22eb54b654d01af891570a8f02ee43da674
Signed-off-by: Robert Varga <[email protected]>

SFC OpenFlow Pipeline specification

- detail the changes resulting from converting the ODL
  OpenFlow Plugin to use the mainstream OVS 2.9 NSH
  APIs.

Change-Id: Ie74de5a817fb2877a8514632ac1e346830811e8c
Signed-off-by: Brady Johnson <[email protected]>
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Pull in minimal models

Rather than pulling odl-mdsal-models, which is quite huge, pull
in specific models we need: RFC7223/7277 and the acl model.

JIRA: MDSAL-363
Change-Id: Ia4155c2165f1c74e7ef02d5f68a22f4bf40d4837
Signed-off-by: Robert Varga <[email protected]>

Move genius utilities to new module

Reduces dependencies on sfc-genius module, making it genius-specific so
that it is not activated (and thus, it's event listeners and logic are
not triggered) when activating other basic bundles, like openflow
renderers, that for some scenarios do not rely on genius at all.

Change-Id: Idfb24fd050aeee2339c80a0270a1eeaf19b46104
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Swap RpcProviderRegistry with RpcConsumerRegistry

Avoids validation of the RPC model which is currently causing issues
with genius RPCs that are not properly augmented with the OFP nicira
extension models.

Change-Id: Ie2c3edee5ede3e963016da5e57a7fe0ab316adfb
JIRA: SFC-222 GENIUS-174
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Fix some minor issues

- Remove unneeded unboxing
- Make some variables final

Change-Id: Ibe9cecf3dd1094051a507583cc59cb18139a3421
Signed-off-by: David Suarez <[email protected]>

Fix some minor issues

- Remove unneeded unboxing
- Make some variables final

Change-Id: I4413cee5450829d17ea516515c547ba0ba701857
Signed-off-by: David Suarez <[email protected]>

Add output interface option to vxlan_tool

vxlan_tool can now be run with an ouput option to egress traffic on a
different interface than the input one. This is useful to simulate
bump in the wire SFs.

Change-Id: I72b7da6292c3139645b8eb580c1cbced6e0c49e5
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

To avoid to get the null vxlan-gpe port number

Sometimes the ovs has two vxlan-gpe ports,and
one vxlan-gpe port number is null .
The patch avoid to get the null
vxlan-gpe port number

Change-Id: Icefd7df780d657009a86e1b11d54d83b1295d049
Signed-off-by: Qiuzheng <[email protected]>

Use a version range for odl-jackson-2.8

Using a version range for the feature dependency simplifies version
upgrades and bump merges.

Change-Id: I16afd80487ea35f050748b94d1f9976d78e2651e
Signed-off-by: Stephen Kitt <[email protected]>

Migrate to serviceutils/tools

Change-Id: I821db09dc53ea93b6a9ebc8e74fa1e7d46635d04
Signed-off-by: Faseela K <[email protected]>

Bump odlparent to 3.1.2

Change-Id: I5bcba8789b0ae56856ec42a3600226c0b66bb034
Signed-off-by: Stephen Kitt <[email protected]>

Optimize using Java 8 constructs

Change-Id: If5500d8f5d88d637e4f4902c92dbddab1a01f6e4
Signed-off-by: David Suarez <[email protected]>

Add some improvements

- Remove redundant initializers
- Convert some variables to local
- Make some variables final
- Delete unused variables

Change-Id: Ic28875ec20e8f4c34764cc31ce082b8fe18d9098
Signed-off-by: David Suarez <[email protected]>

Simplify assertions

Change-Id: I0eb385cd36265a0c01eede3d4b4c337dd1069d83
Signed-off-by: David Suarez <[email protected]>

Remove unused methods and JavaDoc

Change-Id: I8f36f29fff04226e5027f72a3c0f1831de2a234c
Signed-off-by: David Suarez <[email protected]>

Simplify JUnit assertions

Change-Id: I43d03536dc4d4fc9f5c66213999ecf95b0bcfb84
Signed-off-by: David Suarez <[email protected]>

Remove unneeded boxing and unboxing of types

Change-Id: I85e33fcf30d9d8d63142d29dce75367c8cf327b6
Signed-off-by: David Suarez <[email protected]>

Simplify some of the assertions

Change-Id: Ic85b0722bc6fe1d32624d7118b851c7aa6eb9703
Signed-off-by: David Suarez <[email protected]>

Remove RPCs to create and delete RSP

Those RPCs were deprecated in Oxygen and they will be removed in
Fluorine.

Change-Id: I5cb4046e30dc7cbe5da24904bbcf51cc96949835
Signed-off-by: David Suarez <[email protected]>

Remove uses of BindingAwareBroker

BindingAwareBroker is a legacy CSS remnant that essentially wraps
the binding services. It's now deprecated in lieu of obtaining
the services via blueprint and soon will no longer be available via
the OSGi registry.

Change-Id: Ic366410cfbcaef2c6af23f5b56bf77eae9d85f9b
Signed-off-by: Tom Pantelis <[email protected]>

Switch to using lfdocs-conf to pull in theme

lfdocs-conf is a new project that allows us to centrally manage
project theme configuration without having to duplicate it
everywhere or have the "docs" project become a large submodule
project.

We will push to ReadTheDocs separately and then create a new path
for this doc under docs.opendaylight.org/projects/integration-packaging

For further details refer to:
http://docs.releng.linuxfoundation.org/en/latest/project-documentation.html

JIRA: DOCS-69
Change-Id: I2d618e4cf56144b0445c99b0b4af87767b98fc76
Signed-off-by: Thanh Ha <[email protected]>

fix up Augmentable and Identifiable methods

This is a fixup of the change in binding codegen, adjusting:
- getKey() -> key()
- setKey() -> withKey()
- getAugmentation() -> augmentation()

JIRA: TSC-101
Change-Id: Idb3db3933176f667f3454663bc53ceacbd0714d0
Signed-off-by: Stephen Kitt <[email protected]>

Resolve Sphinx build warnings

Change-Id: Ib2c5e6fe1328cf2a3a716c90826a61a3a8debd71
Signed-off-by: Thanh Ha <[email protected]>

Convert to jersey 2

JIRA: TSC-113

Change-Id: I62f2d4bbe9e29cbffa0e2e12a14147f088e1ee1d
Signed-off-by: Tom Pantelis <[email protected]>

Deprecate SF and SFC model RPCs.

- Most of these RPCs arent even implemented.
- The ones that are implemented can easily be performed
  with simple RESTconf messages.

Change-Id: I244d7512259589dd0850a029d539c19b5b36c61c
Signed-off-by: Brady Johnson <[email protected]>

Remove use of InstanceIdentifier.toInstance()

This method has been long-deprecated, do not use it.

Change-Id: I62b2fdc3c2f63af056b073acf3f6d42d4d1276a3
Signed-off-by: Robert Varga <[email protected]>

Add .coafile for linting, fix tox verify job

The tox.ini file defines a Coala test env, and the JJB tox job template
in global-jjb calls all test envs, so the Coala env was failing due to
missing .coafile. Add a .coafile with sections for linting many of the
types of files in SFC. All tests except Git commit message linting are
disabled because there are violations in SFC that cause failures. The
violations should be fixed and corresponding sections enabled to keep
them fixed in different commits.

Change-Id: Ib8f9b4a7d68bcad6d1c3b1fe2230e96b736ee12d
Signed-off-by: Daniel Farrell <[email protected]>

Adjust to RPC method signature update

Change-Id: I0d65b7e34b8dd93451aca51f42760394f9af4015
JIRA: TSC-99
Signed-off-by: Tom Pantelis <[email protected]>

Remove registerDataChangeListener remnants

registerDataChangeListener is being removed - a few UTs were
still calling it unnecessarily.

Change-Id: I6189722edb5e698f5ba58586cf6c399dba04acf2
Signed-off-by: Tom Pantelis <[email protected]>

Migrate sfc-netconf's listeners

- Migrate sfc-netconf's listeners to use the Genius' framework
- Use Blueprint annotations instead of xml file

Change-Id: Ie648d11347936c1067bbe8c1689a316ae09cc989
Signed-off-by: David Suarez <[email protected]>

Improve provider & ovs unit tests

- Remove usage of deprecated AbstractDataBrokerTest
- Remove traces of asynchronous listener event handling
- Remove duplicated tests

Change-Id: I5112d3b4d724f53236463499636f0c21c850a53b
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Migrate sfc-model to binding-parent

This disconnects it from root pom.xml, pulling-in all definitions
as needed. This will allow us to turn root pom.xml into a much
lighter artifact.

Change-Id: I0f9c799a52ea4574b65ca777da989fc6a025d783
Signed-off-by: Robert Varga <[email protected]>

Introduce sfc-artifacts

This is the recommended project structure, which is important
so we can duplicate configuration across the project.

Change-Id: If7489159c8634deb4343dac2988ea4157247e0ed
Signed-off-by: Robert Varga <[email protected]>

Migrate listener's methods

Migrate add, update and remove methods to use the new ones.

Change-Id: I7652b596be36afdb69b8516b0376feace083d175
Signed-off-by: David Suarez <[email protected]>

Migrate from genius mdsalutil-api/utils to tools-api/utils

Change-Id: I9293be18ee02bbe0ab2562c6d2249097d729c78f
Signed-off-by: Faseela K <[email protected]>

Bump to odlparent 3.1.0 and yangtools 2.0.3

Change-Id: Iab5a1c87fae57ec45524f8be10ceef3aee716ab5
Signed-off-by: Stephen Kitt <[email protected]>

RELENG-63: Fix duplicate bundles in features

Change-Id: I921a0b78e2a6da5ff9f23a9d2a5357ecbf86b5a0
JIRA: RELENG-63
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Use ietf-ip.yang from mdsal instead of our own

Change-Id: I692e6301fc0e3303e13e5dd1893443bd7cab0b05
Signed-off-by: Lorand Jakab <[email protected]>

Add Karaf build profile

Project local Karaf distros are handy for devs to test their work
however is unneeded by autorelease builds and should not be released
as part of the Simultanious Release. Add a profile that is active by
default so that default behaviour is unchanged however allows the
autorelease project to disable building this module.

Issue: RELENG-86
Change-Id: Id968ab6ce79d7067ad71c78634cb8a29b4b2edb7
Signed-off-by: Thanh Ha <[email protected]>

Improve vpp utils logging on transaction failure

Change-Id: Ib07ffe823d9133811d5117b967ebba5bfa1d666d
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Fix formatting of license statements and remove some redundancies

Change-Id: Iaeaacb2ad82108b2266a22188be4c862928debc3
Signed-off-by: David Suarez <[email protected]>

Remove sfc-ui module (DLUX)

SFC's User Interface (module sfc-ui) is based on DLUX project which is
not properly maintained, so it's been decided to removed this dependency
from all Opendaylight projects.

Change-Id: I797ff02078f7ea4afa4b72d5f8a67d5c2fcd5524
Signed-off-by: David Suarez <[email protected]>

Remove sal-binding-config dependency

It's CSS-related and not needed and will be going away.

Change-Id: Iad88f3e8bc58dd51846ca7f80b527b080a7d154f
Signed-off-by: Tom Pantelis <[email protected]>

Migrate listener's deprecated methods to use the new ones

Change-Id: I1b0fa95c8e2f33b86c5a394efbb6ededed8eb64c
Signed-off-by: David Suarez <[email protected]>

Migrate listener's deprecated methods to use the new ones

Change-Id: Ida842033c0f4221a0bcc0ea63db40c2c1d68e7c1
Signed-off-by: David Suarez <[email protected]>

Use odl-jackson-2.8

We should use the odl-jackson-2.8 feature to fulfill our dependencies
on Jackson.

Change-Id: If859f41c3e8f94819376267db65bc578dfe51e82
Signed-off-by: Stephen Kitt <[email protected]>

Bump java-uuid-generator to 3.1.5

The new version removes an explicit dependency on log4j, hence
removing it from packaging.

Change-Id: I3ba1ebc656e0d1c4e78092a8831c1d804cd48bfd
Signed-off-by: Robert Varga <[email protected]>

Migrate listener's deprecated methods to use the new ones

Change-Id: Ib9e91aba0300231f6bf1af6b89d0622759b944d1
Signed-off-by: David Suarez <[email protected]>

SFC-215: Fix sfc-103 demo issues

- Use Ubuntu 16 as Ubuntu 15 is no longer available
- Fix ODL distribution URL path
- Use latest ODL snapshot available instead of a fixed version
- Removed unused and un-existent requirement 'messages'

Change-Id: I6e9588dff79d82be3a077acf21478b43238e17a4
JIRA: SFC-215
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Migrate listener's deprecated methods to use the new ones

Change-Id: I124fec07636d2ce86e018e0aada73225d4bfdeeb
Signed-off-by: David Suarez <[email protected]>

SFC-217: Fix sfc-py pep8 issues and packaging

sfc-python-verify has been failing for some time. After fixing it [1],
some issues have arised in sfc-py:

- Fix pep8 issues.
- Refactor jenkins_build_package.sh so that it does not build python3
  itself as it is already available in the enviroment on which
  sfc-python-verify runs. Anyway, it has also being removed form the
  job for the time being as per [1].

[1] https://git.opendaylight.org/gerrit/#/c/68873

Change-Id: I2f0ae12bb6fef56bce50137515a23e024d08b4ee
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Remove deprecated abstract listeners

These abstract listeners were superseded by the Genius' listeners. They
were deprecated in Nitrogen and now we delete them.

Change-Id: Iac27ae94535b03a77b816678a17f03fe3b50ed59
Signed-off-by: David Suarez <[email protected]>

Clean up fragile Unit Test

Change-Id: If23f0d1acda11a57d52686608dce43785071dea1
Signed-off-by: Brady Johnson <[email protected]>

Fix some unit tests for listeners

Change-Id: Idbee6a8ae6047af5fb377b4f1f13535e95c8cccb
Signed-off-by: David Suarez <[email protected]>

Refactor to change packages' names

org.opendaylight.sfc.ofrenderer package is replaced by a more canonical
name: org.opendaylight.sfc.renderers.openflow

Change-Id: I170fefdca841d7deeb86d42d587a4478c4073467
Signed-off-by: David Suarez <[email protected]>

Remove unused reference to AsyncDataChangeEvent

AsyncDataChangeEvent is deprecated and scheduled for
removal.

Change-Id: Ie140ad16235479e3f79401a91988731742454cc6
Signed-off-by: Tom Pantelis <[email protected]>

SFC-213 SFC statistics dont always work

- The OpenFlow NodeId is not available on
  the SFF, so the statistics cant work.
- There's a race condition between when SFC
  creates the OVS bridge for an SFF and when
  we try to get the bridge DPID.

Change-Id: I05b2d0da61f8147ffea0a995b3efef38cbf05b31
Signed-off-by: Brady Johnson <[email protected]>

Refactor to change packages' names

sfc-ios-xe-renderer package is replaced by more canonical name:
org.opendaylight.sfc.renderers.iosxe

Change-Id: I86e9f2e355e86823300c4de7003d4133f1dfe95e
Signed-off-by: David Suarez <[email protected]>

Refactor sfc-vpp-renderer

- Migrate to use Blueprint
- Use Blueprint annotations
- Migrate listeners to use Genius' ones

Change-Id: Iaec54c9d59bb078e1e455fd10aff96155af9c042
Signed-off-by: David Suarez <[email protected]>

Minor change in .gitignore

Change-Id: Icb8095295dbb30eba28a624c608aaeb1b4a4fdda
Signed-off-by: David Suarez <[email protected]>

Fix sfc-104 demo issues

Change-Id: Idfd3cc4b3fdca31188c4a4c2132ee06ed3ebe3a1
JIRA: SFC-218
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

SFC-218: Fix sfc-scf-vpp wiring

Change-Id: I73ad125c433f145bba93ef8b0c56f0cfb344a30d
JIRA: SFC-218
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Remove binary jar and download when running test

Change-Id: I15bbbb8a56d2e208b472d096ed85c9e166132258
Signed-off-by: Brady Johnson <[email protected]>

Refactor to change packages' names

sfc_vpp_renderer package is replaced by more canonical name:
org.opendaylight.sfc.renderers.vpp

Change-Id: I08a361eb9aab2f692a2a125b4447a1fc3dd5c7ad
Signed-off-by: David Suarez <[email protected]>

SFC-214: Fix sb-rest wiring

Missing build plugin and incorrect bean naming was preventing the
blueprint wiring to actually happen. Fixed the SFF listener which
was missing the wiring annotations. Got rid also of the unnecessary
provider module.

Change-Id: Id3b6ef73cd274a108b07a50fedbe94eab6123cf3
JIRA: SFC-214
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

SFC-216: Fix exception message check for bad macs

The IllegalArgumentException message thrown when constructing a bad
MacAddress (or any IllegalArgumentException thrown for any yang type
value that fails a regex pattern check) changed with [1].

[1] https://git.opendaylight.org/gerrit/#/c/68461/

Change-Id: I5b6a73773cb6b4742d004b6bc6ac7ae6e38e4d66
JIRA: SFC-216
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Bump versions by x.(y+1).z for next dev cycle

Change-Id: Ie6a846caecb2cdec46cced1398dcf0c8ab11e42f
Signed-off-by: Anil Belur <[email protected]>

SFC-210: Remove config RSP on delete RSP rpc (II)

First patch did not really deal with the fact the previous behavior of
the RPC was to return once the operational RSP was already deleted.
This patch aligns the solution of the delete RPC to the one adopted
for the create RPC which respects previous behavior. And solves the
corresponding test case that fails in the basic SFC csit suite.

Change-Id: I7d21665c32f3358b083f43932da3285c11d7c1fe
JIRA: SFC-210
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Avoid exception on default scheduler handling

Default scheduler selection is handled through an exception that is
printed out in the logs and looks rather ugly. Replaced by a proper
cleaner log message.

Change-Id: I1fd8e6ffe91eaa45ef21a15942c58d12983a5f9d
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Fixes for mac chaining demo

- Fix the traffic  example given in the instructions
- Fix the demo not working with a remote ODL
- Set python output to unbuffered for dummy SFs and GW
  so that output is actually written while using the demo
- Fix ovs node id value although commented out for now as it has side
  effects: when set, some values are overwritten on OVS topology node,
  which changes the node's datapath id.
- Provided a vagrant file with a mininet environment

Change-Id: Ic001ff9ecd7a91ee6fc56b90fff1fe1d56565edb
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Fix openflow node mess in mac chaining classifier

Mac chaining SCF classifier was obtaining the openflow node
to write flows to through different ways on different places:
sometimes it would use the service node while others would
use the methods of SfcOvsUtils. Also it would sometimes try to
obtain the SFF from the openflow node when it already has it
readily available through a class property. So cleaned up this
which allowed also to clean up the ClassifierInterface a bit.

Change-Id: I8fe070e2a3a70a17b4520012de9358617b51d63f
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Fix NPEs and improved debugging in SCF classifier

Fixed some methods that would return null if some mandatory input data
was also null. Users of these methods were not prepared for this even
thought there were unit tests asserting this behavior.

As there is no good reason for that data to possibly be null, make them
fail with a controlled NPE and remove unit tests.

Change-Id: I16baa44d1ad6a844aef2a33cc7f3121be7f12c98
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

SFC-212: Fix scf rendering with no RSP metadata

Fixes a problem where the rendering of the classifier flows would fail
if the RSP did no include the optional NSH metadata.

Change-Id: Ib8c4bef199b704db202a3c71faee1a93dea77068
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

SFC-211: Fix service function path state not deleted

Change-Id: Icd413d85002cda4e51f4a003bb71260f266dc984
JIRA: SFC-211
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

SFC-210: Remove config RSP on delete RSP rpc

Change-Id: I6cf06398e6046dabcf3339ddeb1f68a910a8c882
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Fix lisp NPEs on Logical SFF and more

Change-Id: I95fabe89de7ca0b02aa64fe2191ca3c945e564ad
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

UT for SfcStatistics

Change-Id: Ib84e5ecfff1be0cc51cb78b9b5189cd23894d9f9
Signed-off-by: Brady Johnson <[email protected]>

SFC-208: Add hardening for create RSP RPC

Change-Id: I05125e0e3486572b98c756a9fed6d525ba57c529
JIRA: SFC-208
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Config data store listener for RSP creation

- Previous RSP creation via RPC is deprecated, but still supported.
- Now its possible to create RSPs with a write to the SFP config.
- SFP config creation will trigger an RSP config creation, which
  triggers an RSP oper creation.
- Deleting or modifying SFs/SFFs now deletes the SFP, not the RSP
- Still pending: Unit tests

Change-Id: I9cf947abdac6433d0e7d961c372f43f0f6d572c8
Signed-off-by: Brady Johnson <[email protected]>
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

RSP statistics feature

- RSP statistics are retrieved on-demand by calling an RPC
- To be completed next: Unit Tests

Change-Id: If90657ad339a77bc50e6809ccbb1425c5eb31872
Signed-off-by: Brady Johnson <[email protected]>

Refine affected RSP search on SFF update

Previously, any SFF locator update would cause the removal of any RSP
associated with that SFF. With this patch, in regards to a SFF locator
update, an associated RSP will be removed only if any of these
conditions are met:

* The SFF locator is used in a SF dictionary entry for an SF associated
with the RSP.

* The RSP is associated with more SFFs than the updated SFF so that the
updated locator could be used in a SFF-SFF hop.

This improvement is particularly meaningful for the logical SFF scenario
in combination with the changes introduced for the directional-dpl spec.
The logical SFF singleton is no longer an empty SFF and will be updated
frequently as paths are created or removed. It is fundamental that other
paths are not affected when they shouldn't.

The current data model does not allow for optimum processing and there
might be performance impacts on big SFFs, as the logical SFF most likely
will be. For a future release, there is the option to enhance the data
model to optimize this.

Change-Id: I16660e241779ff24bf644e4377e12965b12f695b
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Use directional dpls for openflow rendering

Change-Id: I36ceff0509d0d33d9e34e6cec4f30df100c3cd06
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Remove legacy sfc-test-consumer feature

- It hasnt been used for a long time

Change-Id: I1141abe111f9ea74e376aa2940ef575f292c8405
Signed-off-by: Brady Johnson <[email protected]>

Fix in the firewall mode of vxlan_tool

The firewall mode of vxlan_tool was not compatible with the ETH + NSH
encapsulation. This patch fixes that through offset which is different in the
two cases we support (the other one is ETH + IP + UDP + VXLAN + ETH + NSH)

Change-Id: Ib8d84bd8d4c06e91b146a68d1a749ecb3eb6070f
Signed-off-by: Manuel Buil <[email protected]>