sfc-ovs adding unit tests

SfcOvsToSffMappingAPI, SfcSffToOvsMappingAPI, HopOvsdbBridgePair,
SfcOvsRpc, SfcOvsUtil

Change-Id: I2cf47d961e7c305bd0a3b9961374b5a983ba843e
Signed-off-by: Vladimir Lavor <[email protected]>

Bug 3107: Sfc-OVS lacks API for storing OVS Bridge Openflow ID

Change-Id: I87fbf73eec44d99e4612235085394efa6239abd7
Signed-off-by: Andrej Kincel <[email protected]>

Fix JDK8 compatibility

JDK8 is more picky about javadoc correctness. Fixup errors preventing
compilation.

Change-Id: I6d373b1f2987580ded725c44355806b1fe9249aa
Signed-off-by: Robert Varga <[email protected]>

Merge Layer3Match values for multiple Ipv4 Matches

- If multiple layer3 match fields need to be set, the
  MatchBuilder Layer3Match field was being overwritten,
  instead of being appended onto.

Change-Id: Iecd120056de2a49dc3a98c0a8fd2959553319612
Signed-off-by: Brady Johnson <[email protected]>

Merge EthernetMatch values for multiple Ethernet Matches

- If multiple ethernet match fields need to be set, the
  MatchBuilder EthernetMatch field was being overwritten,
  instead of being added onto.

Change-Id: I2d67060032a870e82270699040b390f730bde90c
Signed-off-by: Brady Johnson <[email protected]>

Disabling SFF/SF/SN initial config files

- IPFIX initial config file is still active
- Created another config file to preserve
 the original in memory data store config

Change-Id: If3e580499113cb53b829a325fdfe68eb1b99bac3
Signed-off-by: Reinaldo Penno <[email protected]>

Debugging Improvements

- Naming threads
- Proper shutdown

Change-Id: Ie41c1698fb79c7f93967a1f2b30908a42adeac0b
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Removing unecessary debugging log"

Removing unecessary debugging log

Change-Id: I02ee7049a62007f95c2e93cd1e107d3bfc000d13
Signed-off-by: Brady Johnson <[email protected]>

Merge "SFCOFL2 minor cleanups"

SFCOFL2 minor cleanups

- Fix priority issue in Transport Egress table
- Removed some dead code

Change-Id: I0e70a692008fccd0875c351ea4cd2094a859cec3
Signed-off-by: Brady Johnson <[email protected]>

Merge "Sfc-OVS: Fixing NPE caused by non-OVS or hybrid RSPs"

Merge "Add Connected SFF Dictionary into SFF"

Sfc-OVS: Fixing NPE caused by non-OVS or hybrid RSPs

Change-Id: If73f5603a49d27fb8c9709710e02b89f38ff8a4a
Signed-off-by: Andrej Kincel <[email protected]>

Merge "Fixing NSH OpenFlow programming"

Fixing NSH OpenFlow programming

- Set tunnel IP dst, not the inner IP
- Move the vxlan VNID to the dst tunnel
- If the switch port is not avail, use IN_PORT

Change-Id: I210ea87d6d0506166c14eae832bb0e29ad94ed87
Signed-off-by: Brady Johnson <[email protected]>

Add Connected SFF Dictionary into SFF

Yang model service-function-forwarder.yang introduces new
connected-sff-dictionary into SFF. This patch add Web GUI
implementation to fill out the connected-sff-dictionary.

Signed-off-by: Johnson Li <[email protected]>

SFC-PY - prepare for packaging

Move relevant files to the sfc/ package.
Make intrapackage imports relative, fix test/ imports.

Change-Id: I083087a6cc8e7306b6ea2634fb0e55346021debc
Signed-off-by: Dusan Madar <[email protected]>

Merge "Fix UNSTABLE build issue led by unit tests"

Fix UNSTABLE build issue led by unit tests

- Correct *Funtion* to *Function* in file name and function name
- Catch NullPointerException to trace call stack
- Add LOG.debug for debugging
- Print SfcDataStoreAPI Transaction failed with caller info
- Modify Load Banlance scheduler
- Check if a ServiceFunction does exist in scheduler
- Add sleep after getPutAll in order to ensure they are really put
- Clean up all the objects in SFC data store and ensure they are deleted before unit test

Change-Id: Ic4df527b1abc0f84d392e0e024de87a449d6e8f5
Signed-off-by: Yi Yang <[email protected]>

Sfc-UI: adding support for create-ovs-bridge RPC

+ Service Function Forwarders tab now provides access to
create-ovs-bridge RPC call

+ Slightly modified create-ovs-rpc debug messages

Change-Id: I239a114f60f94037dca705b4e8f8be05d9574620
Signed-off-by: Andrej Kincel <[email protected]>

Sfc-ovs: removing NPE catch blocks

- reported by sonar as major issue
- not good coding practice (catching NPE can hide its real origin)

Change-Id: I49138ad4b63b280e8782a5c95512a87753b5b777
Signed-off-by: Andrej Kincel <[email protected]>

SFC-OVS: Creating VXLAN tunnels according to RSP

sfc-test/ - added regression tests for OVS
(as SFF name is based on OVS NodeId which contains ip+arbitrary port,
port must be changed before test execution accordingly. OVSDB guys
are discussing about this arbitrary port in NodeId issue)

sfc-test/common.py - added URL for create-ovs-bridge RPC

sfc-ovs:
+ Vxlan tunnels are created between OVS Bridges according to RSP Hops

+ Vxlan endpoint IP addresses are taken from OVS bridge-other-config
list
  (drawback is, that this IPs must be set manually -
  ovs-vsctl set Bridge br1 other_config={"local_ip"="192.168.1.1"}
  However, this should be solved by OVSDB overlay model ASAP)

+ Vxlan tunnels are destroyed after RSP deletion

Currently only pure OVS RSPs are supported, hybrid RSP will cause
exception and the tunnels will be not configured.

Change-Id: I72ff50b7078a26cce7d44921b0ea9851a471d8c9
Signed-off-by: Andrej Kincel <[email protected]>

Merge "Minor fixes to NSH flow programming"

Minor fixes to NSH flow programming

- For NSH, transport ingress goes to table NextHop
- Transport Egress should not be checking metadata for NSH

Change-Id: I199dc1025e11015f1772ce18293e1185fc0a2163
Signed-off-by: Brady Johnson <[email protected]>

Merge "SFC-PY - rename directory nfq_classifier ro nfq"

Merge "SFC-PY - move/remove unused files"

Unit test for readRenderedServicePathFirstHop and readRspFirstHopBySftList

This unit test can block some commits that bring regression.

Change-Id: Id9edf2edb672907ab2e49ab12e7575dd728f9b90
Signed-off-by: Yi Yang <[email protected]>

Adding NSH to flow programming

- no longer using table 2, classifier

Change-Id: I5e49944cb9d5b83168e9c7d19ef33c0cd7cb589f
Signed-off-by: Brady Johnson <[email protected]>

SFC-PY - move/remove unused files

Remove test/__init__.py.
Move service_function.py and start_sf.sh to unused/.

Change-Id: I1f1963a7a073d6d87721614ea121f49bf5b8e228
Signed-off-by: Dusan Madar <[email protected]>

SFC-PY - rename directory nfq_classifier ro nfq

Change-Id: I760d818090b7502d46ff546951ad52ed21873f44
Signed-off-by: Dusan Madar <[email protected]>

Statistics for Cisco vNBAR and vASA SFs

Change-Id: Ic1f824548b46229528e3a654ef083ad30cff71c0
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Service Function SL-Transport and SFF mapping"

Service Function SL-Transport and SFF mapping

- patch-set 2 Added list of SF types that map to a
  list of SFs.

Change-Id: I8835ef155535c5239320d34050a4adb7331a90d0
Signed-off-by: Brady Johnson <[email protected]>

Adding Maven Central Metadata to pom

- This allows SFC to meet the Maven Central requirements

Change-Id: Ib7366e15666d44f844caca48691a36b5b505de06
Signed-off-by: Brady Johnson <[email protected]>

Merge "removed XR parameter from start_agent added policy-map and interface configuration processing"

removed XR parameter from start_agent
added policy-map and interface configuration processing

Change-Id: I74ad18321015728f9201fb02a5f7831052436b2c
Signed-off-by: jguichar <[email protected]>

sfc-ui: Add UI for IPFIX (Matchers and Add/Remove AppId)
sfc-model: BUG: It was not possible to add a new AppId thru the REST method 'PUT' as multiple keys were defined

Change-Id: Idd7b0687ceae6e08cb5e1dccaa38dfe880e39417
Signed-off-by: Christophe Fontaine <[email protected]>

Merge changes I48e300f0,Id6648e3f

* changes:
  SFC-PY - scapyNSH
  SFC-PY - create cli subpackage

Merge "Sfc-ovs: seperating config file"

SFC-PY - scapyNSH

Move the scapyNSH.py module to nsh package, remove the scapy package.

Change-Id: I48e300f066d9d1bce73f0f1f7d6675d1d8458cf8
Signed-off-by: Dusan Madar <[email protected]>

SFC-PY - create cli subpackage

Move xe_cli, xr_cli and ovs_cli to a cli subpackage, update related imports.

Change-Id: Id6648e3f2b15b94a68806998179ff698932406a2
Signed-off-by: Dusan Madar <[email protected]>

Fixing get first RSP Hop RPC due to previous omission.

- A previous patch to add SFG left out this code,
  adding it back now.

Change-Id: I7bf6d08a549ae1ab2fa84296b266cde070368d49
Signed-off-by: Brady Johnson <[email protected]>

Sfc-ovs: seperating config file

Change-Id: I74157f27b642199dc22d6e7ede22e6a820e2eb2b
Signed-off-by: Andrej Kincel <[email protected]>

Merge "Sfcofl2: seperating config file"

Sfcofl2: seperating config file

+ tested that RSP listener works

+ added sfc-provider to <required-capabilities> of sfcofl2-initial.xml

- there are still some errors, but probably not related to config file

Patch set 5:
Fixed missing dependency of sfcofl2/xml/config

Change-Id: I899a65a67bdf2ff144eca16b6baff53f1e8cf2aa
Signed-off-by: Andrej Kincel <[email protected]>

Fixing Start Agent

Change-Id: I44b62f56527dc7dfcb2e19978300dc9216ae0bfd
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "fixed build errors added CLI processing for IOS-XR"

Merge "Add shortest path algorithm for service function selection"

Generating XML from new Identities

Change-Id: I971437cff0a4f286d6adc127a22b0698b8533fcd
Signed-off-by: Reinaldo Penno <[email protected]>

Identities for Cisco Platforms

Change-Id: I7077771c63675ae4f7971d92368a822bf2330076
Signed-off-by: Reinaldo Penno <[email protected]>

fixed build errors
added CLI processing for IOS-XR

Change-Id: Id3928c3cefab662eb7f8822388131e5a62fc55e5
Signed-off-by: jguichar <[email protected]>

cleaning sfcofl2 POMs and configs

- Cleaned sfcofl2 POMs
- Commented out a config file that is not used anymore
- Fixed 80-sfc.xml but still let commented out
- Removed .m2 and compiled and ran control plane regression tests
   it was ok

Change-Id: Ifc212c78fcde511dd3aa4e1e687e048f273258b3
Signed-off-by: Reinaldo Penno <[email protected]>

Fixing broken sfc-provider feature

- temporarily disabled sfcofl2 because of wrong config files

Change-Id: Idfe17cc2532dd9c37f295666abacd40b7e541b59
Signed-off-by: Andrej Kincel <[email protected]>

Cleaning POMs

Change-Id: Ifb9e7dc1ed7be2160500020fb18a1d285e6ddf6f
Signed-off-by: Reinaldo Penno <[email protected]>

Add shortest path algorithm for service function selection

Change-Id: Ia7acb96bd8bc60b740ada2036986ac4de76f22be
Signed-off-by: Shuqiang Zhao <[email protected]>
Signed-off-by: Yi Yang <[email protected]>

Fixing and cleaning POM issues

Change-Id: Iab9a47eeae21fb368f26c305e91c1f3376593846
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Deny both SF and SFG in the same Rendered Path"

Merge "Allow Service Function Group in Rendered Path"

Merge "Updated references to latest  karaf versions."

sfc-model:
 - modify L7 matchers to comply with IPFIX
 - modify service-function-acl.yang to be able to match on multiple application-id
sfc-jsonconfig: Add default configuration files for IPFIX-classid

Change-Id: I57606ee43fb0f381252e25d86409b584b5ce4553
Signed-off-by: Christophe Fontaine <[email protected]>

Merge "Fixes to SFF client"

Merge "Fixing missing NextHop and TransportEgress flows"

Fixing missing NextHop and TransportEgress flows

Change-Id: I95c0ac1fe9057083202c5e2951cb9b00e3660cac
Signed-off-by: Brady Johnson <[email protected]>

Fixes to SFF client

- Added alarm handler when response not received
- Added signal handler to clean up state in order to
  avoid "address in-user errors" across runs
- Fixed ethernet addresses
- Added construction of inner packet
- Added internet_checksum algorithm
- Added source port and IP as CLI options
- Fixed default values
- Used inheritance and default values to
  considerably simplify code

Change-Id: Ia26525bbc87db00b5ef3d32bc007962f0afad981
Signed-off-by: Reinaldo Penno <[email protected]>

Updated references to latest  karaf versions.

karaf.version is inherited from odlparent.

Signed-off-by: Tony Tkacik <[email protected]>

SFC-UI Fixing broken create/edit URLs

+ fix for ACL
+ fix for Metadata

Change-Id: I04de72cfd262675ef6671dfc0f865cf2aac24194
Signed-off-by: Andrej Kincel <[email protected]>

Merge "Sfc-ovs: Storing TerminationPoint options in SFF"

SFC-UI: removing not longer used files

Change-Id: If72172f05873c57b69069fe7776557286585d52b
Signed-off-by: Andrej Kincel <[email protected]>

Formalizing flow programming for MPLS and VLAN

- patch set 2: rebasing to get correction to sfc model that
  exports sff ofs models
- patch set 3: minor bug fixes, still need to handle the SF OfsPort info
- patch set 4: Fixed SF OfsPort info retreival, one minor bug remains
- patch set 5: Fixed remaining OfsPort bugs
- patch set 6: Now using exceptions to handle error conditions

Change-Id: Ib64ac121806ff10a07df6fabde7d14676f041961
Signed-off-by: Brady Johnson <[email protected]>

Deny both SF and SFG in the same Rendered Path

Change-Id: I4ba9c28d89b288e82c634e573b6a9b1aea18f7e8
Signed-off-by: Kfir Yeshayahu <[email protected]>

Allow Service Function Group in Rendered Path

Change-Id: I754cb7dc8bcb9c635764c3e52099e22a459b4504
Signed-off-by: kfiry <[email protected]>

Sfc-ovs: Storing TerminationPoint options in SFF

+ we need to store these options in SFF OVS Options augmentation,
because we need a way how to set these options in SFF

+ sfc-ui is displaying options in SFF create/edit dialog

Change-Id: Ie769353ff5af451aea1b2fab32da42a91ea44017
Signed-off-by: Andrej Kincel <[email protected]>

Adding SFF ofs models to sfc model exports

Change-Id: I4b2374a4ca84cbe5f8f3968d220243c5a13ef09f
Signed-off-by: Brady Johnson <[email protected]>

Merge "add type to SFG algorithm according to OFL"

Merge "corrected default encapsulate type"

Copy transport from SFP to RSP upon creation

- Copy the SFP transport to the RSP upon creation
- If the SFP transport is null, then default to VxLAN on RSP
- Remove mac address from mpls now that its on the SFF DPL

Change-Id: Ib99c8f62f99d69bc94c665102be3aea948f8c2a6
Signed-off-by: Brady Johnson <[email protected]>

corrected default encapsulate type

Change-Id: I6db50d890322000d498779d4fd500a910b3fae94
Signed-off-by: jguichar <[email protected]>

SFC-OVS: Improving create-ovs-bridge RPC

+ improving create-ovs-bridge RPC (specifying IP address of OVS node is
sufficient, if only one OVS instance is running on that IP address -
no need to specify port)

+ creating RSP listener

Change-Id: I55fa916bf6b569a0d4b528638842ba05bff576b9
Signed-off-by: Andrej Kincel <[email protected]>

Adding OFS info to SFF SF dictionary

Change-Id: I14a50dee8b58a0081a334c68819848eed7563ba4
Signed-off-by: Brady Johnson <[email protected]>

Merge "Augmenting ServiceFunctionForwarder yang"

Augmenting ServiceFunctionForwarder yang

- Adding OpenFlow port and related mac address to SFF

Change-Id: I0dc648d66ef6dd474646ee5eca505a25d150a9e6
Signed-off-by: Brady Johnson <[email protected]>

NSH Support: configure openflow tables

This commit enabled sfcofl2 to support VxLAN-gpe + NSH,
main changes include:

- SffGraphEntry includes serviceIndex for nsi match
- Uses ip-port-locator to recognize VxLan-gpe flow
- Match L3/IP to differentiate flows
- Uses action SetNwDst to steer the flow to SFs or SFFs

Change-Id: I5999b6e787a43c84f0ffd75b233d001473dd7222
Signed-off-by: Yi Yang <[email protected]>

SFC-PY - move unused logger settings file to unused/ dir

- we keep old files for historical reasons, thus moving and not removing

Change-Id: Ib1bfc1aa2c1ba62b054c57f98f9ced594026f1c0
Signed-off-by: Dusan Madar <[email protected]>

add type to SFG algorithm according to OFL

Change-Id: I521b4697683f83d7a926cafa7d0bda708d014fc8
Signed-off-by: shlomi <[email protected]>

SFC-OVS: Various improvements and fixes

+ Adapted to new OVSDB APIs (TerminationPoint does not contain
attachedTo and bridgeName anymore) - fix for broken build

+ Node/Termination Point is now deleted according to InstanceIdentifier
directly (before Node/Termination Point was built and InstanceIdentifier
was derived from built instance)

+ SFF DataPlane locator now gets IP:PORT from OVSDB TerminationPoint
options List

+ OVS Termination Point is created when IP:PORT locator when set

Change-Id: I4c5580ed1eb2f5f8335769dc3f14210abe3fdbb9
Signed-off-by: Andrej Kincel <[email protected]>

Merge "Scapy directory organization"

Merge "sfc-model: Add L7 matchers and subscriber based matcher"

Scapy directory organization

Change-Id: I131dbccbedd6b61e4b6d8cf7cc4b877695c3d7e3
Signed-off-by: Reinaldo Penno <[email protected]>

Update sfclisp to the lispflowmapping API changes

The lispflowmapping project updated its YANG model describing protocol
data in an non-backwards compatible way, bumping the revision.  This
commit adapts the sfclisp code to the new revision.

Change-Id: Id966b4214e826322671bc6cda91efe7d3eb640de
Signed-off-by: Lorand Jakab <[email protected]>

sfc-model: Add L7 matchers and subscriber based matcher

Change-Id: If38cb4c8b7f06bbe8e714addfcf0b153d9930920
Signed-off-by: Christophe Fontaine <[email protected]>

adding reference to sft and algorithm

Change-Id: Ibf6d26ae783eaea99b250f4eddf23f8ff4dc2c07
Signed-off-by: shlomi <[email protected]>

Scapy Plugin:
 - Added implementation of 'mysummary' to display the incoming packets
 - Added the ability to use this plugin as a Service Function when used with OVS+NSH
 - Added the configuration whithin the comments

Change-Id: I9b6afe0e9b50bbf9c2ee04947007a5a6591bcfef
Signed-off-by: Christophe Fontaine <[email protected]>

Scapy plugin:
Add VxLAN and NSH layers to be able to send and dissect packets with scapy.

Change-Id: I9e7fdd8cc69ab3c17052735d4c15a17153621352
Signed-off-by: Christophe Fontaine <[email protected]>

Remove sfclisp from build

Change-Id: Ib9b03e5d4a2d567293aa61343477ce645c11c136
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "SFC-OVS: Introducing OvsDataStoreAPI"

Merge "SFC-PY - update NSH, classifier"

Merge "fix yang date"

SFC-PY - update NSH, classifier

nsh:
- rename VXLANGPE attribute 'protocol_type' to 'next_protocol'

classifier:
- fix VXLANGPE next_protocol value
- update regarding NSH changes
- introduce GRE header

Change-Id: I6b963c10dd159a787b362e19c6d1506544063a57
Signed-off-by: Dusan Madar <[email protected]>

SFC-OVS: Introducing OvsDataStoreAPI

+ write/delete operations are now executed in separate thread

+ improving SFF<->OVS Bridge mapping
  * added TerminationPoint creation from SffDataPlaneLocators

+ create-ovsdb-bridge RPC finally creates Bridge instance on given
  OpenVSwitch running instance

- there are some issues when TerminationPoint is deleted, it is not
  deleted from SFF
- the same applies in backward direction - when SFF Data plane locator
  is deleted, TerminationPoint is not deleted

Change-Id: I9069eca21badefbd853f2719d89b6981790e1c2e
Signed-off-by: Andrej Kincel <[email protected]>