Naveen Kumar Verma [Wed, 10 Jul 2019 05:03:43 +0000 (10:33 +0530)]
Move Pm Counter processing to new thread
Porcessing of RPC response has been moved to a newer thread.
Change-Id: I2fcf385847924f164d6799d59ea390b2acdcd059
Signed-off-by: Naveen Kumar Verma <naveen.kumar.verma@ericsson.com>
Apurba Mukherjee [Mon, 29 Jul 2019 12:29:08 +0000 (17:59 +0530)]
Issue: Table-0 to Table-36 flow was missing
As part of ITM Yang Models Cleanup, internal flag was removed which
caused the issue. The internal flag is brought back to fix the issue.
Change-Id: Ia069fc52ecbd3223fa7ca7c4713ffb475fb3a353
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
R P Karthika [Mon, 8 Jul 2019 12:56:51 +0000 (18:26 +0530)]
Make Batching size and interval as configurable parameters
in ITM
Define batch size and interval in itm-config.yang and use that instead
of using it from system.properties(),so it can be configured if needed.
Change-Id: I6f292bad3323fd4b5cd1d1be6cb6e575e41c3c1a
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>
Amitesh Soni [Fri, 19 Jul 2019 07:10:49 +0000 (12:40 +0530)]
Id allocation failing
Issue
=====
While reading data store if data is not present in the DS,
"ExpectedDataObjectNotFoundException" exception is thrown.
Since this exception is not handled, ID allocation is failing.
Fix
====
Added try-catch block to handle the "ReadFailedException" exception
so that the code execution does not stop if read fails.
https://gerrit.ericsson.se/#/c/
4354671/
Change-Id: I00423597e1681085b1fbcd187e11e5f2dd7582cd
Signed-off-by: Amitesh Soni <amitesh.soni@ericsson.com>
Faseela K [Wed, 24 Jul 2019 10:57:37 +0000 (10:57 +0000)]
TSC-181: ITM Yang Models Cleanup
Merge issues are fixed now, hence restoring the actual change
Change-Id: Ie774a5a2c09f901cd4ff58c732acf73effc36827
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Wed, 24 Jul 2019 09:45:40 +0000 (15:15 +0530)]
Ignore flaky ITM test
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Change-Id: I51654fa1b348308215e3c47692729c15fd5caac3
Faseela K [Tue, 23 Jul 2019 09:51:21 +0000 (09:51 +0000)]
Revert "TSC-181: ITM Yang Models Cleanup"
This reverts commit
f32af7aad9875d8aa281ff711f86945c18685318.
Change-Id: I89c0ea7a8b8b5e365d540a8d1987f3a0b191eb76
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Apurba Mukherjee [Thu, 2 May 2019 05:42:03 +0000 (11:12 +0530)]
TSC-181: ITM Yang Models Cleanup
Change-Id: I2d4e79e78c562572d9d91598b489f563eb1f6484
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
manojna v [Thu, 20 Jun 2019 10:21:49 +0000 (15:51 +0530)]
Adding compute node scale-in scale-out spec
Change-Id: I00058d5eeac8256e79dcce9a5b2c4502cec826cd
Signed-off-by: manojna v <manojna.vijayakrishna@ericsson.com>
Robert Varga [Sat, 29 Jun 2019 07:38:05 +0000 (09:38 +0200)]
Remove use of powermock from mdsalutil-impl
powermock is not really used in these tests, remove it, allowing
us to simply upgrade mockito.
Change-Id: I26eca39285e2bcca7193c837e69c347c4b5cc878
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 18 Jun 2019 11:09:16 +0000 (13:09 +0200)]
Migrate to use LoggingFutures
JdkFutures are not taking advantage of various known implementations,
which LoggingFutures does. This migrates code to use new equivalent
method.
Change-Id: Ifd8ae59f82cdb2eb8ea70783bc81288139e5c3d5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 18 Jun 2019 09:40:13 +0000 (11:40 +0200)]
Make private MDSALManager methods static
These methods are not touching any state, incurring Eclipse warnings.
Fix those warnings by making the methods static.
Change-Id: I0649ee508fffe6d2b83ea55710e405635921812c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sat, 29 Jun 2019 07:43:59 +0000 (09:43 +0200)]
Remove powermock version overrides
odlparent is providing version 2.0.0, hence there is no point
in us overriding versions (and specifying some artifacts).
Change-Id: Ia006b48a772a98ae9cc8e6fb7abc00dccaba0295
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 26 Jun 2019 10:30:00 +0000 (12:30 +0200)]
Declare api artifacts in genius-artifacts
This reduces the number of project.version declarations throughout
the project, improving consistency.
Change-Id: Id039b72d27da6d07315cc83d9d3da5d4e1abb6b5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 25 Jun 2019 11:37:33 +0000 (13:37 +0200)]
Import genius-artifacts from binding-parent
This removes duplicate imports and allows us to share versions
at a later point.
Change-Id: Ibd8d2f717975affeb61d51116a1d67c5255d49e7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 25 Jun 2019 11:33:23 +0000 (13:33 +0200)]
Import openflowplugin-artifacts in binding-parent
This reduces the need for duplicate imports and version tracking
in projects that are based on binding-parent.
Change-Id: Iec6b7d2be820a908051fe1759bfc134a6d744f73
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 25 Jun 2019 11:25:31 +0000 (13:25 +0200)]
Import infrautils-artifacts in binding-parent
This is done at least in two places, with a myriad of other
places using the property instead of relying on upstream to declare
the correct version.
This patch fixes the layout up so we only only export the property
to one user, which unfortunately is not declared by upstream.
Change-Id: I589f239d932518a5275bd5e5998a1a599ef33caf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 25 Jun 2019 10:30:13 +0000 (12:30 +0200)]
Migrate from tools-api to rpc-api
This migrates users of FutureRpcResults to the non-deprecated
version. Also import serviceutils artifacts from binding-parent.
Change-Id: I52661ad4b116be525234a18022ad4c48c8511a2c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 25 Jun 2019 10:35:12 +0000 (12:35 +0200)]
Remove controller.mdsal.version
This property is only used for imports, remove it in favor of
inlining the version into import.
Change-Id: If2405635464d530e52f5108f975d14f9659b6226
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 25 Jun 2019 10:35:59 +0000 (12:35 +0200)]
Remove unused declarations
junit/mockito-core are always a test dependency, hence these
declarations are not needed.
Change-Id: I744bd0b9bd58a29de0245bb2ee2e781163bbbced
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 25 Jun 2019 10:34:13 +0000 (12:34 +0200)]
Remove unused properties
These properties are not consumed anywhere, remove them.
Change-Id: I144f271ab05ca6f663e1d9f8ce94c861e08e8df5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 18 Jun 2019 09:42:28 +0000 (11:42 +0200)]
Remove use of FluentFutures2.toChecked()
This method has been deprecated, remove its only in-tree user.
Change-Id: I71c3e14e3ad98db06c11f6dda56803b8951c5c50
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Apurba Mukherjee [Mon, 24 Jun 2019 06:01:09 +0000 (11:31 +0530)]
Spec for ITM Yang models cleanup
1. Added specification document for ITM Yang Models cleanup
2. Linked spec to specs/index
Change-Id: I1217ae59584775a44cbe3b266ba3cbcded7f0b01
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
R P Karthika [Mon, 13 May 2019 10:17:32 +0000 (15:47 +0530)]
Fix syncronization issue in table 220 flows
Change-Id: Id7c6a1f967c561a969b47b59ad93134d622028a6
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>
Edw7n [Mon, 17 Jun 2019 15:53:33 +0000 (21:23 +0530)]
To address sporadic failures
- addresses failures seen in autoRelease
- clean up of explicit sleeps in the Junit
- replaced sleep with awaitsEventConsumption:q
Change-Id: I97fa44da04d38afe67aa9d4adc8b7314078ebb4d
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Nidhi [Fri, 10 May 2019 08:46:42 +0000 (14:16 +0530)]
Tunnel mesh was not fully created.
There is a timing issue between SB and NB event while
creating bridge. When we are trying to add bridge to
ovsdb from SB, NB is trying to add port for same bridge.
during which NB will check DS/cache for bridge entry,
which will be empty as SB is trying to add it in ovsdb
at the same time. So we are adding eventcallback to
synchronize both events.
Change-Id: I7c33f41591de27972742df14ae913daae7f6889f
Signed-off-by: Nidhi <nidhi.adhvaryu@ericsson.com>
Robert Varga [Sat, 13 Apr 2019 10:00:07 +0000 (12:00 +0200)]
Migrate to NamedLocks
KeyedLocks have been deprecated, have an very bad API and do not
quite work as advertized.
Migrate to NamedLocks, which have a safe and easy-to-use API while
providing improved performance. While doing that, change
DirectTunnelUtils to not leak the entire structure, but only provide
a lockTunnel() method.
Change-Id: I8c099e491189c49015ee2939a3ea20f2c0f8c8c5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Nidhi [Fri, 3 May 2019 06:46:50 +0000 (12:16 +0530)]
In ITM Scale-In-Out when same IP is used, some stale
tunnels hanging in new mesh creation.
When computes were scaled-in and scaled-out with the same vtep ip, ITM
full mesh was not created.During scale-in, ITM caches were notcompletely
cleaned up resulting in stale DPN in ITM. This prevented the full mesh
creation.This patch add solution to this problem.
Change-Id: If712ca51893f56e6d0efd260260387242fab667a
Signed-off-by: Nidhi <nidhi.adhvaryu@ericsson.com>
Robert Varga [Fri, 31 May 2019 14:11:41 +0000 (16:11 +0200)]
Bump mdsal to 4.0.2
This picks up latest improvements.
Change-Id: I923294ebdac1dc69e8253096f4199b0630b30356
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 31 May 2019 14:10:18 +0000 (16:10 +0200)]
Bump yangtools to 3.0.1
This picks up latest fixes.
Change-Id: I0b14617c404a45f59d48eaa2fc58c37b7d265eac
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Faseela K [Tue, 28 May 2019 08:48:32 +0000 (14:18 +0530)]
Heavy service-binding READs in scale
A code refactoring post Boron has duplicated serviceInfo read
in two places, on an interface-state addition. Removing this
duplicate read.
Change-Id: Ia173452c200bbcac33728f51b7766ebf0ca17496
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Robert Varga [Wed, 1 May 2019 11:44:09 +0000 (13:44 +0200)]
Bump mdsal to 4.0.1
This bumps mdsal to 4.0.1.
Change-Id: Ia57117a74f1b97030b6879f422867f2adc8ce717
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Edw7n [Thu, 28 Feb 2019 05:17:30 +0000 (10:47 +0530)]
Queueing iface remove on its name
- to handle interface remove in DJC on interface name
for both vlanInterfaces and tunnels
Change-Id: I4ecb07b76b607650893a5581a2dd7b128190b699
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Dimple Jain [Wed, 23 Jan 2019 11:01:14 +0000 (16:31 +0530)]
GENIUS-145: Creation of OFPort on ITM Direct Tunnels.
Change-Id: Ic6d229f22eb540b4859d61450b5b3f53cee9faaa
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>
Yi Yang [Tue, 7 May 2019 01:06:39 +0000 (21:06 -0400)]
Fix wrong condition statement in update method
In update method in TunnelInventoryStateListener.java,
the below condition is wrong obviously.
if (DirectTunnelUtils.TUNNEL_PORT_PREDICATE.test(portName)) {
LOG.debug("Node Connector Update - {} Interface is not ...
return;
}
JIRA: GENIUS-275
Change-Id: I0b03d7357edb37baf0f535d06dd3a72952b387f5
Signed-off-by: Yi Yang <yangyi01@inspur.com>
Faseela K [Mon, 11 Jun 2018 09:08:10 +0000 (14:38 +0530)]
Update Pipeline diagram for Egress Tunnel Table
JIRA: GENIUS-161
Change-Id: Id9e5a3aa1266eb9e54252aab12940533f74491a8
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Edw7n [Fri, 15 Mar 2019 08:14:24 +0000 (13:44 +0530)]
Programming ingress table for OF-tunnels
- to program ingress flow per OF-tunnel basis
- table 0 will now also match on source IP
Change-Id: Ifad2202aaa30ac40479cab34266055676403ef49
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Edw7n [Thu, 14 Mar 2019 09:51:42 +0000 (15:21 +0530)]
Implement ITM Egress Tunnel Tables
Adding a new Egress Tunnel Table for dpn-dpn tunnels.
All packets that will egress to a tunnel will go through this
table now, benefits being:
1. Applications need not listen on tunnel add/delete events,
to update their flows based on port number or egress lport tag, as the
port number will be contained within the egress tunnel table.
2. Tunnel addition and deletion can be ITM self-contained.
Change-Id: I8302318f479785c949fff928d5ba2f043f59b0c8
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Robert Varga [Thu, 2 May 2019 13:54:17 +0000 (15:54 +0200)]
Fix javadoc HTML5 compliance
This removes the use of <tt/> in favor of {@code}.
Change-Id: Iff784cbc56c3372865448d8725732cf2c19cde4f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
R P Karthika [Wed, 10 Apr 2019 10:03:54 +0000 (15:33 +0530)]
Bump mdsal to 4.0.0
Bump mdsal version to 4.0.0 and codegen changes
Change-Id: Idcfb62212acb989848fa1d77e822183165dd7826
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>
R P Karthika [Tue, 9 Apr 2019 11:42:08 +0000 (17:12 +0530)]
Bump yangtools to 3.0.0
Bump yangtools version in genius from
2.1.8 to 3.0.0
Change-Id: I9fb99935f93ebc4c7bb891ad4b9ca085d6f917af
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>
Faseela K [Tue, 9 Apr 2019 05:48:38 +0000 (11:18 +0530)]
Bump odlparent version to 5.0.0
Change-Id: I82b08404b577a9bbd67eec9a372b2a447a805d8f
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>
Stephen Kitt [Tue, 2 Apr 2019 15:04:47 +0000 (17:04 +0200)]
Adjust Checkstyle DTD URIs
The DTDs have moved from checkstyle.sourceforge.net to checkstyle.org,
using secure URLs.
Change-Id: I6df4408c91fa828385f0457139706737c33efb66
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Robert Varga [Sun, 24 Feb 2019 20:32:55 +0000 (21:32 +0100)]
Correct yangtools version
This bump seems to have been forgotten: neon should work on
version 2.1.8.
Change-Id: I30d6a60dee45ca40b89eadf233a6fd1b84cfe46f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Tue, 8 Jan 2019 10:16:53 +0000 (11:16 +0100)]
Port arputil to mdsal 3
Change-Id: I8e05daef17d56fda9786a63dc6e33709be347799
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 14 Feb 2019 16:52:19 +0000 (17:52 +0100)]
Switch to JDT annotations for Nullable and NonNull
This reduces our dependency on JSR-305 which causes a number of issues
(e.g. with javax.annotation resolution in OSGi bundles).
Annotations on local variables are removed because they trigger a
Javac bug which crashes ASM and then FindBugs, SpotBugs and JaCoCo.
SpotBugs mis-detects null returns in packages marked as “non-null by
default”, so its NP_NONNULL_RETURN_VIOLATION check is disabled on
affected methods.
Change-Id: I15199aa22854b0c66b719f02e28ecf5cbb53d580
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Faseela K [Sat, 16 Feb 2019 17:52:51 +0000 (23:22 +0530)]
Remove upgrade-in-progress flag
JIRA: GENIUS-190
Change-Id: I4621188d92a42669559aa2b5ebf3a82fcfb6178d
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Nishchya Gupta [Wed, 16 May 2018 14:11:53 +0000 (19:41 +0530)]
NETVIRT-1262: Tep's are not part of transport zone when a transport zone
is removed and added from NB
Problem
-------
TEPs do not add back to transport-zone which is removed and then added
again from northbound.
Problem solution
----------------
When tz delete event arrives for a particular Transport zone,
teps of that will be moved to tepsInNotHostedTransportZone OperDs.
And, when same name tz gets re-added from NBI, then these teps
will go back to re-added tz.
Change-Id: I482528a1e695ee439ca731c63138639dff2dce3f
Signed-off-by: Nishchya Gupta <nishchyag@altencalsoftlabs.com>
souvikdas95 [Mon, 3 Dec 2018 13:45:01 +0000 (19:15 +0530)]
GENIUS-249: Add CLI to print bridge from given DPN-ID
Change-Id: I50bd87711487d3071286b3d39878c5095a206952
Signed-off-by: souvikdas95 <souvikdas95@yahoo.co.in>
R P Karthika [Fri, 11 Jan 2019 11:47:57 +0000 (17:17 +0530)]
Genius-130: Test plan for OF-Tunnels
OF Tunnels support for ITM direct tunnels
Change-Id: I28698713338773eb245f06a0c9a18b6554c1ec6a
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>
Robert Varga [Wed, 6 Feb 2019 02:49:41 +0000 (03:49 +0100)]
Fix build with Java 11
This adds required dependecies on javax.annotation-api, fixing the
build with JDK11.
Change-Id: I8b3fef99ac8058e4a38714bf7bddef5f2a3a7a42
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 7 Feb 2019 09:31:11 +0000 (10:31 +0100)]
Use scope=provided for karaf shell
The is filtered from features, but its dependencies are not,
fix that by having shell at scope=provided.
Change-Id: If927a076ef8701ddd2fc883a55d2223cddfa71a0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Thu, 31 Jan 2019 15:52:44 +0000 (16:52 +0100)]
Drop Karaf console dependency from genius-api
We shouldn’t be passing the command session around in the API layer;
use exceptions for errors throughout, and rework showTeps to return
the information to be displayed instead of displaying it directly.
Change-Id: Ic61909aa47c7246308a0dd3260f542b3b44b53a2
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Tarun Thakur [Wed, 23 Jan 2019 13:23:12 +0000 (18:53 +0530)]
GENIUS-248: ITM-Vtem Auto tunnel feature- Tunnels not coming up after deleting external id's in OVS
Issue:
When exterenal_id is deleted from OVS, then TEPs are supposed to move in def-TZ.
When TEP's movement to default-transport-zone from TZA happens, tunnels do not come up.
Main issue is during movement, TEP is added followed by TEP deletion
which makes TEP not available in tep-show-state. This happens because
TEP is keyed on dpn-id in DpnTepsInfo and tz-membership do not help in synchronization
issues.
Fix:
Introduced DataTreeEventCallbackRegistrar on DpnTepsInfo to check if TEP is deleted and
when it is removed and event is notified, then only perform TEP add in TZ movement case.
Change-Id: Iadbcc2a23ac971722237d0dd8f0b9d603d31a8ff
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>
jenkins-releng [Fri, 1 Feb 2019 13:06:29 +0000 (13:06 +0000)]
Bump versions by x.y.(z+1)
Change-Id: I5363fef9ef2795a360283a066117bddef3caf937
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Faseela K [Thu, 20 Dec 2018 17:01:43 +0000 (22:31 +0530)]
GENIUS: Migrate fcaps from XML to annotation based BP
Change-Id: I9ca19e733770a07f8976024bbd62a1c06a9ccd34
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Stephen Kitt [Thu, 31 Jan 2019 15:24:26 +0000 (16:24 +0100)]
Use odl-apache-sshd
... instead of pulling in the sshd bundle.
Change-Id: Ibde7756506ac814f914888ec943810c08cf74508
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Edw7n [Mon, 21 Jan 2019 14:41:03 +0000 (20:11 +0530)]
GENIUS-185: Removing usage of databroker tx
- replaces most uses of databroker tx
- few worker classes have been refactored into their respective listeneres
- some classes ommitted in /itm-impl/..../cli/
would lead to other comprehensive changes which are out of scope
Change-Id: I8d2218636471923b7fb9e61dd2b42b6d80207bcf
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Dimple Jain [Mon, 28 Jan 2019 10:43:17 +0000 (16:13 +0530)]
Creating OF Tunnel parent child in memory mapping.
Change-Id: Id14d216b7bd744bd1d6ce28bd7baede9777a24ae
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>
Stephen Kitt [Mon, 28 Jan 2019 09:51:46 +0000 (10:51 +0100)]
Add a wrapping DataBroker test wiring ...
which wraps an MD-SAL DataBroker with a Controller DataBroker for test
purposes. (This will be removed once the migration is complete in
Genius and NetVirt.)
Change-Id: I7b8e9316d9e12f6c4252c6d64dfaeb3f482616c3
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Dimple Jain [Fri, 18 Jan 2019 08:48:58 +0000 (14:18 +0530)]
GENIUS-268: Disabling BFD by default.
Change-Id: I172779668282fce77f58946b8a303483b4d8ca11
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>
Stephen Kitt [Fri, 11 Jan 2019 10:02:54 +0000 (11:02 +0100)]
Add mdsal 3 DataBroker test modules
Change-Id: Id2a34b49bd144e6a2b6e930cdf28965515839954
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Faseela K [Mon, 14 Jan 2019 08:59:48 +0000 (14:29 +0530)]
genius/interfacemanager annotation based bp
Change-Id: I3f91ce5cf6b60beaa0a634c1f73bb4cfd42d6646
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Dimple Jain [Wed, 23 Jan 2019 07:24:11 +0000 (12:54 +0530)]
Adding OF Tunnel detail to config DS.
Change-Id: I4ad233308e64d8e2dcaba6eee7d8a4fc1398d961
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>
Stephen Kitt [Thu, 10 Jan 2019 10:51:05 +0000 (11:51 +0100)]
Port fcapsapplication to mdsal 3
Change-Id: I12189d6d63d4e346cfe9c280abc90a57367a3f65
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Dimple Jain [Fri, 18 Jan 2019 10:19:02 +0000 (15:49 +0530)]
GENIUS-130: Adding OFTunnel enablement configuration
flag in ITM and removing from IFM.
Change-Id: I5d2c7c5e8a80251d2fc824963075d5a0623abfe4
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>
Chintan Apte [Thu, 17 Jan 2019 08:15:18 +0000 (13:45 +0530)]
TSC-181
Marking the fields set to be removed as depercated.
Taking care of Hema's comments.
Gerrit link for the corresponding spec change:-
https://git.opendaylight.org/gerrit/77605
Signed-off-by: Chintan Apte <chintan.apte@ericsson.com>
Change-Id: I611cfbe52a38c84f4dd3221c1df9e48e1c06d857
Robert Varga [Sun, 20 Jan 2019 02:43:51 +0000 (03:43 +0100)]
Bump mdsal to 3.0.6
This aligns with odlparent-4.0.9 and yangtools-2.1.8.
Change-Id: Ie7f524c8a482f570f43257d12856a5dd6c83d620
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 18 Jan 2019 15:32:40 +0000 (16:32 +0100)]
Bump to odlparent 4.0.9
Change-Id: Ieeae64846bab1f12c91520cd3285f8434401dc89
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Faseela K [Thu, 17 Jan 2019 11:44:59 +0000 (17:14 +0530)]
Huge INFO log in TerminationPointStateListener
This log is coming in csit runs for each bfd status
update on tunnel creation.
Change-Id: I0b75b68b2ca299b791755c57597ca20dd98f798a
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Vyshakh Krishnan CH [Wed, 2 Jan 2019 17:39:49 +0000 (23:09 +0530)]
RD allocation using IDManager
JIRA: GENIUS-262
RD is currently allocated by opensatck in netvirt.
For COE, RD has to be auto generated.
These changes is to introduce the logic in GENIUS using IDmanager
Change-Id: I8afadbc330b41f8dc7b71252de396f8500bfd5d1
Signed-off-by: Vyshakh Krishnan CH <vyshakh.krishnan.c.h@ericsson.com>
Robert Varga [Thu, 10 Jan 2019 15:44:25 +0000 (16:44 +0100)]
Bump mdsal to 3.0.4
This realigns odlparent/yangtools/mdsal and brings in the latest
improvements.
Change-Id: Ia4f91421a4ca9ccf8f1b70513f74855d95a93ad6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Wed, 9 Jan 2019 14:54:53 +0000 (15:54 +0100)]
Bump to odlparent 4.0.8
Change-Id: I28d2d37031a530ebadf04224cd7ccabf89e65576
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Tue, 30 Oct 2018 08:26:42 +0000 (09:26 +0100)]
Port alivenessmonitor to mdsal 3
Change-Id: I936f986dabbac2d7c917d1086dcf645ff2067984
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Dimple Jain [Mon, 12 Nov 2018 06:51:25 +0000 (12:21 +0530)]
GENIUS-130: Adding OFTunnel enablement configuration.
Change-Id: I0458f4d1f1af760570bdb22e96af8fd94ab2e39a
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>
Faseela K [Wed, 19 Dec 2018 15:16:03 +0000 (20:46 +0530)]
GENIUS:arputil from XML to annotation based BP
Change-Id: I500dc72ba4f630a18ede2ec000d73f070cf64f7e
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Fri, 21 Dec 2018 10:47:13 +0000 (16:17 +0530)]
GENIUS: idmanager from xml to annotation based bp
Change-Id: I7b5f0197340a5c72b306fa766db685ae9821c6b5
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Stephen Kitt [Wed, 2 Jan 2019 10:24:09 +0000 (11:24 +0100)]
Bump odlparent to 4.0.7
Change-Id: I6235a463da8f44663c1b2415e1524c492df87cd3
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Robert Varga [Thu, 3 Jan 2019 15:40:58 +0000 (16:40 +0100)]
Fix odl-genius-fcaps-framework
This feature is using stuff from infrautils, make sure we depend
on the correct upstream feature.
Change-Id: I6b7d31d1ccd20f3860f5c6e1fc848fcbc6542d0f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 3 Jan 2019 15:35:31 +0000 (16:35 +0100)]
Use odl-apache-commons-net
odlparent provides a wrapper feature, use it to package commons-net.
Change-Id: Ic4afbb808323dbe63cdc76f0497f4167554e442d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sat, 22 Dec 2018 17:37:30 +0000 (18:37 +0100)]
Revert "skip tests using xtend until odlparent bump"
This reverts commit
c30f9b64ecde99cb4078bd8fd3a7eb1ad752d3a0. With
odlparent-4.0.5, the tests should work again as expected.
Change-Id: Ia125654dd8fcf623ee175927a982ee6f21df940d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Faseela K [Wed, 19 Dec 2018 11:52:30 +0000 (17:22 +0530)]
GENIUS:alivenessmonitor from XML to annotation based blueprint
Change-Id: I442b1efd4af465fe4a2e8a6aa5aa613a069c5bb8
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Robert Varga [Sun, 23 Dec 2018 22:55:55 +0000 (23:55 +0100)]
Bump mdsal to 3.0.3
This brings in latest fixes and alignes with odlparent-4.0.5.
Change-Id: I5457187f545fa0b1a39d74bdc840cfb2a7e62270
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Fri, 21 Dec 2018 09:10:08 +0000 (10:10 +0100)]
Bump to odlparent 4.0.5
Change-Id: I8b171097895667e34397a1b3ce0ba5eb904c3088
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Faseela K [Fri, 21 Dec 2018 06:26:17 +0000 (11:56 +0530)]
skip tests using xtend until odlparent bump
Change-Id: I4d7f5e3fbed0aabbada457500b85bc081d4a0a81
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Stephen Kitt [Mon, 3 Dec 2018 10:11:23 +0000 (11:11 +0100)]
Drop nullToEmpty
Use the nonnull getter variants where appropriate.
Change-Id: I25d0b58cd3984d6924fee406ac7cd7a4de358abf
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Faseela K [Fri, 30 Nov 2018 11:06:49 +0000 (16:36 +0530)]
Move IdManager based VNI Carving to a centralized module
JIRA: GENIUS-250
Netvirt currently has a vni carving logic which is
tightly coupled with NAT. There are more netvirt
services which are in need of this utility now, and
hence we need to move this to a centralized place.
Adding a new VniUtils in genius, to which later
netvirt services can be migrated to.
Change-Id: I68c2f6cfe74d03c741e519e86704490043787d95
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Dimple Jain [Tue, 11 Dec 2018 10:42:46 +0000 (16:12 +0530)]
GENIUS-246:Removing updation of cache.
When tunnels are not found in cache today, ITM does a dip into DS
and updates the cache accordingly. This cause stale entries
getting added into the cache.
This issue was observed when a tep delete command is executed:
1. ITM initiates delete process.
2. ITM removes the tunnel from the InternalTunnel cache.
3. Before the DS is cleaned up, we try to fetch tunnels from cache
to process clearance of Alarm if any for that tunnel.
As the cache does not have that specific tunnel; ITM
repopulates the cache by doing a dip into the DS.
4. Thereby a stale tunnel gets added to the cache.
The fix is to dip into DS if the tunnel is not present in the
cache but not update the cache.
Change-Id: I1fa7dded96f7a15cba0e63cf9318af5c75e2b41d
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>
Faseela K [Thu, 13 Dec 2018 11:42:16 +0000 (17:12 +0530)]
Stale interface cache entry
interface-config and interface-state DS entries
are front ended by a ConcurrentHashMap for easy
subsequent access. These maps are populated
by a clustered DTCN, but on top of that there
is an additional logic for populating the maps
when an external entity tries to access the same
from DS. This logic is causing stale data to be
written to the cache in some cases.
Change-Id: I6e57777094e0aff98af9b27fa7548d0b954161a7
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Stephen Kitt [Thu, 13 Dec 2018 11:05:23 +0000 (12:05 +0100)]
Ensure that maps accesses are protected
All methods which directly access the flow, group and bucket maps
should be synchronized.
Change-Id: I3e600d141ed1b090a1fb7e7783163a464adaa152
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Faseela K [Thu, 13 Dec 2018 10:37:57 +0000 (16:07 +0530)]
Remove genius/resourcemanager
resourcemanager is not used by any applications for
the last few releases. Let us remove it from the
main genius feature, and add it back only when
someone really needs it.
Change-Id: I3e381cc3b401bca94a1084469d45c643cfad5f47
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Robert Varga [Mon, 19 Nov 2018 20:06:28 +0000 (21:06 +0100)]
Use cached invariant objects
This caches operation result futures and make use of them, so we
do not need to allocate them.
Change-Id: I670996cadb905fefe0a104bbafa9a281428e0241
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Michael Vorburger [Wed, 12 Dec 2018 10:06:58 +0000 (11:06 +0100)]
reduce 'Total taken ##time' log level in ResourceBatchingManager from INFO to DEBUG
JIRA: GENIUS-255
Change-Id: I5d2c5d9e257474a4d5d5abb415ea5792812f2c5e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Dimple Jain [Tue, 11 Dec 2018 08:14:11 +0000 (13:44 +0530)]
Adding few log statements for Cache updation.
Change-Id: Ie7eab2422bf2b797bff83d0addd2634a4f95b88f
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>
Robert Varga [Mon, 26 Nov 2018 18:53:04 +0000 (19:53 +0100)]
Fix an xtend warning
This is != vs !== confusion, xtend is not java.
Change-Id: I32b64cffbe2415acdd6683a9dacc524add1186d4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 26 Nov 2018 09:27:52 +0000 (10:27 +0100)]
Bump to mdsal-3.0.2
This bumps mdsal to 3.0.2.
Change-Id: Ib51a71a0bfcac88fa81a41f5ac967db46d5e7e28
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Fri, 30 Nov 2018 09:11:02 +0000 (10:11 +0100)]
Add missing optionOfTunnel
As done in I5c34b8d147dff82e8e56bc82fa472919e425f368, this adds a
missing optionOfTunnel, which is necessary for the mdsal 3.0.2 bump.
Change-Id: I41b937c450be279e40ea82ad8e9e1ef892070929
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 29 Nov 2018 09:50:54 +0000 (10:50 +0100)]
Reduce liblldp usage
We can use Byte.SIZE instead of NetUtils.NUM_BITS_IN_A_BYTE.
Change-Id: I8b0bf17e9b6472dea45fa50e323b0813cb5acaf7
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sridhar Gaddam [Sun, 11 Nov 2018 09:06:37 +0000 (14:36 +0530)]
Fix mtu type in router-advertisement-packet
This patch also defines few constants used while
framing an RA.
Change-Id: Ic67a92522438c6d60dfa90198196bb0e7af13f5f
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Robert Varga [Mon, 19 Nov 2018 19:52:29 +0000 (20:52 +0100)]
Do not use createMissingParents
Locks does not have any elements which would be created, so do not
force this operation to be needlessly slow.
Change-Id: I56acb72e943e05d6a1fc4dd7f71e2afdd0f2bfb2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Code Review / genius.git / log