Bump commons-fileupload 1.3.2 → 1.3.3

Release notes:
http://www.apache.org/dist/commons/fileupload/RELEASE-NOTES.txt

Change-Id: Ic18fec72aea51fe33debd160b03d984e512ecbed
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump commons-io 2.5 → 2.6

Release notes: http://www.apache.org/dist/commons/io/RELEASE-NOTES.txt

This version is now a Java 9 module.

Change-Id: Ie5ca856b636347927d4bf9e3d1fd824d79b02a8d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump JSONassert 1.3.0 → 1.5.0

Release notes: https://github.com/skyscreamer/JSONassert/releases

Change-Id: I5d066a5168a22d1b56b61e19d9582deacf9f21a9
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump SLF4J 1.7.21 → 1.7.25

Release notes: https://www.slf4j.org/news.html

Change-Id: I8092ba8f07824c8433774898c24d25d5e3510680
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Karaf 4.1.2 → 4.1.3

Change-Id: Ia3eb52ca11cc3e3e870badf469ef8ead7294d031
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BUG-8258: Bump karaf 4.1.2

This is a straightforward upgrade from 4.0.9 to 4.1.2 and will need
to be updated to 4.1.3.

Change-Id: I9275dd42e53dec3e46bc169b6aafb5cb75b40753
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Coda Hale Metrics 3.1.2 → 3.2.3

Release notes:
http://metrics.dropwizard.io/3.2.3/about/release-notes.html

Change-Id: I723e77d1907fc6dde8724f8236ee9c545a20ebbe
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump checkstyle 8.2 → 8.4

Release notes:
http://checkstyle.sourceforge.net/releasenotes.html#Release_8.4

Change-Id: Ibf0f3079d0c7911c1106d8dbbbf7a4f32037dc8b
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add support for local feature files

Karaf 4.1 introduces local feature files for some dependencies. This
patch adjusts populate-local-repo so that it copes with them instead
of crashing.

Change-Id: Ia709011d928abd4994346fde5002c3ff35fe874a
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Xtend 2.12 → 2.13

Release notes: https://www.eclipse.org/xtend/releasenotes.html

Change-Id: I97f878b8904dc83b04c78e9759d38adf48116b64
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Google Truth 0.28 → 0.36

Release notes: https://github.com/google/truth/releases

This also enables the Java 8 extensions.

Change-Id: If374852847f0669d03cd08f6a541465cfbc6bd95
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump guava to 23.3-jre

https://github.com/google/guava/releases/tag/v23.3

Change-Id: I887206256c1f4ed611dc350eac3bf887fab6f72e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Checkstyle HiddenField

see http://checkstyle.sourceforge.net/config_coding.html#HiddenField

Change-Id: I7c25835837e63a9580a9f870d2c1d7cef9e2f57d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Checkstyle TrailingComment, aligned with Sonar

http://checkstyle.sourceforge.net/config_misc.html#TrailingComment

Change-Id: I063cc5b40b561292d3d412d595669851b29951bb
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

BUG-9201: bump maven-enforcer-plugin to 3.0.0-M1

This is required for building with Java 9. Release notes are at:
http://maven.40175.n5.nabble.com/ANN-Apache-Maven-Enforcer-Plugin-3-0-0-M1-Released-td5911744.html

Change-Id: I4b32b3703efea41aed8e3e685896c8fcbd13b4f9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BUG-9200: upgrade maven-shade-plugin

Version 3.1.0 is required for Java 9, release notes at:
https://mail-archives.apache.org/mod_mbox/maven-announce/201708.mbox/raw/%3Cop.y5d393zfkdkhrr%40desktop-2khsk44.dynamic.ziggo.nl%3E/

Change-Id: I5892cba22d1f50708b219aaee35be5ed2af2d2ec
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BUG-9200: update failsafe/surefire plugin version

Version 2.20.1 is required to support Java 9, changelogs are at
https://mail-archives.apache.org/mod_mbox/maven-announce/201709.mbox/%3CCAKuVzBTt6gPWkjDS7AcLBKj7C1i9C7CgjRa3s0mQ0S-P%3D3CiiQ%40mail.gmail.com%3E

Change-Id: I08c48631b3ddcec3d36476e759d16f49a1c0a70f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump commons-codec 1.10 → 1.11

Release notes: http://www.apache.org/dist/commons/codec/RELEASE-NOTES.txt

Change-Id: I402e984c90e9f59b65c06244a8bade3e2156db6c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove deploy-site.xml

With the javadoc jobs now available to generate javadoc it is time to
remove the maven-sites and related files.

Change-Id: If751fe5cf6c4b122063699f4ac234c25fc8daffb
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Switch bundles4-test from FindBugs to SpotBug

Change-Id: I4d4a92d3800a1b23705f8cac3d24c44dfcc01950
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add SpotBugs dependencies

SpotBugs is the maintained replacement for FindBugs, which has been
abandoned. See https://spotbugs.github.io/ for details.

This patch is phase 1 of the (long-term) migration from FindBugs to
SpotBugs: it adds the spotbugs-maven-plugin to plugin management with
the appropriate version specifications and default configuration.

Change-Id: I29a47604bdd25a20dc0fe56f41cd0083ad934e13
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Guava to 23.2-jre

https://github.com/google/guava/releases/tag/v23.1
https://github.com/google/guava/releases/tag/v23.2

Change-Id: I6c9992ad6caf1810359a79203038aaf79a5c8eb5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Exclude jsr305 from guava-testlib

... in the same way as for guava itself. Otherwise our own enforcer
fails builds...

Change-Id: Ibecbbf48c9045c290d439f3666f01fde519b842f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump pax-url 2.5.2 → 2.5.3

Release notes:
https://ops4j1.jira.com/browse/PAXURL-345?jql=project%20%3D%20PAXURL%20AND%20fixVersion%20%3D%202.5.3
(in particular, this addresses CVE-2015-5262).

Change-Id: I2c7bfdb9139ae15573fc9d92f47d28a14ef0e345
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump netty to 4.1.16

http://netty.io/news/2017/09/25/4-0-52-Final-4-1-16-Final.html

Change-Id: I327ac3968dd3421a20f514a70a25002f7aebfbd5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump reactive-streams to 1.0.1

No changes, just clarifications according to
http://www.reactive-streams.org/announce-1.0.1

Change-Id: I9932ef2ede27cce4bae61ab7332c3f5746e2e27e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bug 9229:  Bump bouncycastle from 1.57 to 1.58

Release notes can be found here:
https://www.bouncycastle.org/releasenotes.html

Change-Id: Ie686001b8f02a08ee9f94a8e34c8079a8222366d
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Bug 9169: Bump jdt.annotation from 2.0.0 to 2.1.0

Most importantly, this introduces a handy util for legacy interop
org.eclipse.jdt.annotation.Checks; see its JavaDoc on:
https://help.eclipse.org/neon/index.jsp?topic=%2Forg.eclipse.jdt.doc.isv%2Freference%2Fapi%2Forg%2Feclipse%2Fjdt%2Fannotation%2FChecks.html

Full git change log with more details available on
https://gist.github.com/vorburger/0479be76f9cd3d10aa5ef86d4034a090

I'm starting to explore using org.eclipse.jdt.annotation more, and want
to have its latest version at my disposal for this.  This is part of
https://git.opendaylight.org/gerrit/#/c/47370/ but that's bigger and
still WIP and it would be great if you would agree to get this one in
already now.

This should be very low risk and not break anything anywhere.

Change-Id: Ib1f6389cc0929e08d1585efc7bdc5e75097a3544
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump maven-compiler-plugin from 3.6.1 to 3.7.0

This also removes a number of uses of the
maven-compiler-plugin and maven-surefire-plugin
from project with odlparent-lite as parent, which
should not require these two plugins.

Change-Id: Iec5ad374633903cdcda6344eb736ec337f727a1d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bug 9228: Package bcprov-ext-jdk15on jar

Bouncycastle is hotwired as the default JCE provider in ODL
since it has greater capabilities than those provided with
the default Oracle and OpenJDK JCE implementations.  This
change adds an overlooked and missing jar to the existing
provider infra.

Change-Id: I16cdab1d838285b3d690c61ae9fb3586e8cc69d3
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Bump maven-dependency-plugin from 3.0.1 to 3.0.2

Change-Id: Ib3d7831d2c62bbd1d8b5da1302454f6793c4b554
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

BUG-9161: Bump karaf to 4.0.10

Upstream has delivered a speed up in initial repository indexing
and couple of other fixes. Bump karaf version to consume them.

Release notes:
https://github.com/apache/karaf/commit/a16c3b095a6f17fb3641c98cbe56b7e9f69418c5

Change-Id: I1a632c51e8af62802473afb3d314743f5ca31cfc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit b0e04a0c274d86ea3dbbd71f85ec148c383458f2)

maven-archetype-plugin pluginManagement

The new version property introduced here will be used in controller.

Change-Id: Idf0859ee1be990c130735ca93dabf2e7557703a7
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump Checkstyle core from 7.6.1 to 8.2

and Sevntu from 1.21.0 to 1.24.2 (note the required change in groupId)

also includes removal of LeftCurly.maxLineLength = 100, which is not
supported (anymore; or -more likely- never was, probably the validation
just became stricter)

and removal of a duplicate RightCurly, which was always wrong

and required fixes to odlparent Java code showing violations now

Change-Id: I3efc1d2e97c87a9c072b3fe097cf388f5a457cf5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Eliminate scala.version and scala.micro.version

These properties are interfering with scala-maven-plugin, which is
using scala.version to control target versions.

Change-Id: I501cd941b35f2c0ca738209ca2db1c722743b2e8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump akka to 2.5.4

http://akka.io/blog/news/2017/08/10/akka-2.5.4-released

Change-Id: Ib22206bdaf1c0aa4a218d33ecf8335f718868bc7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump netty to 4.1.15

http://netty.io/news/2017/08/25/4-0-51-Final-4-1-15-Final.html

Change-Id: Icc6415af8d73ab22f75fceb9f7d3fd574d3ebd0a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add net.sf.jung dependency declaration

Downstreams are using an old revision backaged from controller,
which is completely out-dated. Add a dependency declaration and
a proper feature.

Change-Id: I77b1e42aa8a21d94f96a967c0c21af497a65f18e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Checkstyle AvoidHidingCauseExceptionCheck

http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/coding/AvoidHidingCauseExceptionCheck.html

Change-Id: I37d22c88869911f26daad023d66c5559a3cd1fa8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

CS new FinalClass & HideUtilityClassConstructor

* http://checkstyle.sourceforge.net/config_design.html#FinalClass
* http://checkstyle.sourceforge.net/config_design.html#HideUtilityClassConstructor

Change-Id: I4ab4d4550c2bba4e25a19cae7a0c20aa1241757e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Remove & forbid mockito-all + findbugs:jsr305

via the maven-enforcer-plugin

as all projects should only use findbugs:annotations, to avoid duplicate
classpath entries from FindBugs annotations which are present in both
:jsr305 as well as :annotations (which is more recent, bigger, and
maintained)

https://git.opendaylight.org/gerrit/#/q/topic:bug/7663, which replaces
all current existing usages of findbugs:jsr305 by :annotations in ODL
project, is the 1st pre-req. to this change.

https://git.opendaylight.org/gerrit/#/c/47337/, which changes the
dependencyManagement re. FindBugs, is the 2nd pre-req. to this change.

Related to Bug 7663 & Bug 7662.

Change-Id: Ifcd9c833af37fe52182dbc8604978fb82cdbcba7
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add karaf.shell.core dependencyManagement

see also https://github.com/apache/karaf/pull/338

Change-Id: Ia1e732dfe5b83b5795bf022d8bdd89417f0c0d62
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

BUG-7767: Bump servlet-api to 3.1.0

This reverts commit 63c56783199d6fba319fc92373c1714dc8816d8e,
reinstating servlet-api 3.1.0. Also bump H2, which breaks unless
upgraded.

Change-Id: Icb141c95812b2d30a6a23801386a8e931c34b5be
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bump guava to 23.0

https://github.com/google/guava/wiki/Release23

Change-Id: I1efaea3a901f93e4a95aabf13b7dacd4f544aad9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Upgrade jolokia to 1.3.7

https://github.com/rhuss/jolokia/releases/tag/v1.3.7

Change-Id: I6a1174ba6a9621b66d495d92d87f05a4e75d0083
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump jettison to 1.3.8

https://github.com/jettison-json/jettison/compare/jettison-1.3.7...jettison-1.3.8

Change-Id: Ie1f260e7673d10822c1cc1f43eba32775f8810c9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove equinoxSDK381 artifact declarations

These should not be used anywhere, the only downstream of these
is openflowplugin, which does not really need it.

Change-Id: I0c06aa5a951af78002a9e17545f610fe96d58589
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-bundle-plugin 2.4.0/3.0.1 -> 3.3.0

Change-Id: I4f4909f69f57fcdfbe703a91251fd2c038d777ab
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump depends-maven-plugin 1.3.1 → 1.4.0

Change-Id: I72ecfa4178042ce7bf994f717edad1e32a70823f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Configurable path to place SFT heap dumps

Change-Id: Ib9e56f9147f972b4b28db2e7db7426402adb220e
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit 3b3dc36e0af2d848a044f2a5841e10fcb3258e20)

Make SingleFeatureTest max heap size configurable

Currently, CSIT jobs of -only- type use 2GB of heap and CSIT
of -all- type use 3GB. But we are seeing occasional failures
in distribution, especially odl-integration-all feature can take
more heap than usual.

Address the TODO item by allowing maximum heap size to be specified
as a system property -- thus can be overridden by downstreams in
their pom.xml.

Change-Id: I84adda01f3bd20180c6d81d3da807d38b5af6fa1
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 1aa0ac18166b3183e7733b50612f9706efa3c8b9)

Move karaf-util dependency

from bundles-test to features-test

The new karaf-util artifact introduced in
https://git.opendaylight.org/gerrit/#/c/61293/ should not be a
dependency of bundles-test but rather of features-test IMHO.

This is because bundles-test actually not have a compile time dependency
to the CustomBundleUrlStreamHandlerFactory from karaf-util; only
features-test (in PerRepoTestRunner).

However, bundles-test is also used in infrautils' ready.  Bumping to
odlparent 2.0.4 (which includes this) fell over with "...
odl-infrautils-ready ... Unable to resolve
org.opendaylight.odlparent.karaf-util...", because of the
<Embed-Dependency>bundles-test-lib in ready-impl.

We could add karaf-util to the <Embed-Dependency> of ready-impl to work
around this, at least temporarily to unblock, but the root cause is that
the dependency is wrong.

Change-Id: I031fbbc8fb9d8eebba3550ef0683b8363397d8a8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump netty to 4.1.14

http://netty.io/news/2017/08/03/4-0-50-Final-4-1-14-Final.html

Change-Id: Iff5310e47cfbfd4e12bb33ac38cebc1fe6c20ccc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Eliminate triemap declaration

Triemap is forked and delivered in yangtools, this was a private
stop-gap build.

Change-Id: Ife6f1b29e28d7fea2e80b49dc6670d92458d3240
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump scala to 2.12.3

http://scala-lang.org/news/2.12.3

Change-Id: I39b18bd3abbd8aeaa6693f098599f9362cfe0023
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove opendaylight-karaf-empty scope=provided

Having a scope=provided breaks features-test, as it fails to
pull in its required resources, leading to SFT failure.

Change-Id: I1203f224f72f0678c7ccab976d4eb1ae530bc774
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 3e11458209eee6a61cc9837928a016e82bab8866)

BUG-8923: use karaf-empty for SFT

Since we are excluding bouncy castle from generated features (and
we want to assume it is installed), we cannot run SFT against
vanilla karaf. This patch adjusts features-test to pull in our
pre-build opendaylight-karaf-empty instead of vanilla upstream.

Change-Id: Ic45ff713e90c0be7c232e0a1cee36b27c83efe95
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 70f33da04cfdd2e9ddea9a322da5e0b9f6610106)

BUG-8923: create karaf-util

We need to use opendaylight-karaf-empty for SFT, but doing so
directly leads to a circular dependency, as karaf-plugin needs
sft (which needs karaf-empty, which needs karaf-plugin).

Resolve the dependency cycle by breaking out the single class
karaf-plugin requires into a separate artifact.

Change-Id: Id0649dd8203087ed82c1b936428cb6d9295f2957
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 5d3c00c2b98de5ebb4a7eda6e5cc0734c86b74f8)

BUG-8923: Bouncy Castle is provided

We need to exclude the Bouncy Castle artifacts from generated feature
descriptors, since they’re provided in our startup configuration.

Change-Id: I26814b09efa37d12c1e567e5622f509eea9241be
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit 580bee99d255788f8e0f879075b8a12cb92c607f)

BUG-8923: package javassist in a feature

Javassist is an optional dependency to netty and is required by
binding mdsal. This can lead to re-wires when mdsal is pulled in
after anything using odl-netty-4 is installed.

Change-Id: Ia5135dfd27dd6227d9897d1a2ab24e0078673d8c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit e1b90dbbcdf55251192c2bf5b34c5a6f61e58590)

Fix tagGz property

karaf.archiveTagGz should be karaf.archiveTarGz, as used in the plugin
configuration.

Change-Id: I7173180a0e602867bd6a9c5b9fe1ac41a0a4ab6a
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump immutables to 2.5.6

General house-keeping to keep us uptodate.

Change-Id: Ic8ce978f8274701677997ac2987ec483816d7842
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add commons-text declaration

commons-lang3's WordUtils is deprecated in favor of commons-text
version. Downstreams should be able to migrate without having to
deal with versions.

Change-Id: I592f92b79372a21a8ada3225d05bed410a00363b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump javassist to 3.21.0GA

https://github.com/jboss-javassist/javassist/compare/rel_3_20_0_ga...rel_3_21_0_ga

Change-Id: I56af3a4a7ecacd919300e5c2a0332e749b1ed708
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump akka to 2.5.3

http://akka.io/blog/news/2017/04/13/akka-2.5.0-released
http://akka.io/blog/news/2017/05/02/akka-2.5.1-released
http://akka.io/blog/news/2017/05/24/akka-2.5.2-released
http://akka.io/blog/news/2017/06/19/akka-2.5.3-released

Also leaks sun.net from the JDK, as it is required now :(

Change-Id: I65ab6b1a2024084281774cfb17ea1bdd54cd1848
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump jackson to 2.8.9

Version 2.3.2 is really ancient, bump it to 2.8.9.

Change-Id: I92b5aa15c49fe0742f0069a88328e700d2e04f82
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add stax2-api declaration to match jackson

stax2-api is useful for others even without a provider, but
we cannot use 4.0.0 (as we'd like) because jackson has not upgraded
to it.

Change-Id: I69c15a360c2624fb842d4512accad67769de5d1d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add Javadoc links for third parties

Add some links for third party libraries declared as dependencies in
odlparent-lite so that those links are automatically added to the Maven
javadoc:aggregate or javadoc:javadoc goals. The list is not
comprehensive, it is just an starting point to continue adding more
links.

The projects/modules/aggregators referencing odlparent-lite will inherit
these links.

The <detectLinks> flag is set to false until [1] is resolved.

[1] https://issues.apache.org/jira/browse/MJAVADOC-427

Change-Id: I56a6eabe0ba7b9f32ffed7748ab13a79aa6bc2e1
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Revert "Add an origin ID from the MDC into ..."

"... Karaf logs" until we agree on terminology etc.

This reverts commit 03609ff917ea5a187664614252a3e777108cb2ab.

Change-Id: I947fb2e44622f33e71614a66cf2ded816a61b26c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove logback.xml

as well as the reference to it in etc/custom.properties

as discussed on https://lists.opendaylight.org/pipermail/odlparent-dev/2017-July/001262.html

Change-Id: I4423d3950e3d5f23be6d59423ef8b39abd0866a8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add an origin ID from the MDC into Karaf logs

see https://git.opendaylight.org/gerrit/#/q/topic:mdc related changes

and read https://logback.qos.ch/manual/mdc.html
or https://logging.apache.org/log4j/2.x/manual/thread-context.html

This change will show the OID in all logs, for example like this:

2017-07-27 23:14:16,034 | WARN  | 0000000000000 | ion(1)-127.0.0.1 |
InfrautilsIT                     | 93 -
PAXEXAM-PROBE-41ce6a29-abaf-44c0-8044-71d3e2bf99da - 0.0.0 | Ho, ho - do
you also see this funky Origin ID at the <== start of this log message:
0000000000000

If there is no originID available, then the new column will just be 13
empty spaces (for correct padding, like all other columns in the log),
like this:

2017-07-27 23:14:16,554 | ERROR |               | 0e6-c784b3cb4f5b |
core                             | 6 - org.apache.karaf.features.core -
4.0.9 | FrameworkEvent ERROR - org.apache.karaf.features.core

Change-Id: If18e1d35d71da5bd5c0fee5f2212915cccb0992e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

BUG-7464: do not package upstream triemap

yangtools carries a reworked fork with a large number of bugfixes
and it is no longer using upstream. Remove odl-triemap, letting
downstreams consume the yangtools fork.

Change-Id: I5c04c5bed193594a57d4845f857ab62637b70ce4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 3.0.0-SNAPSHOT

We are making backwards-incompatible changes, hence we need to bump
major version.

Change-Id: I1bbd7d55f3a4f1a8cb31e03be9e9215a7bbca4dd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bug 8771: add bcpkix to the startup bundles

This will avoid bundle refreshes due to wiring in bcpkix.

Change-Id: Ia7ceb119d96c8ffa642e3d427e3357c2b7e750d3
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump scala to 2.12.2

This updates scala runtime to 2.12 and adjusts features accordingly.

Change-Id: I1cffaa9c4e7ef2e615d41e125d4d75a377acf537
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump netty to 4.1.13

http://netty.io/news/2017/03/10/4-0-45-Final-4-1-9-Final.html
http://netty.io/news/2017/04/30/4-0-46-Final-4-1-10-Final.html
http://netty.io/news/2017/05/12/4-0-47-Final-4-1-11-Final.html
http://netty.io/news/2017/06/09/4-0-48-Final-4-1-12-Final.html
http://netty.io/news/2017/07/06/4-0-49-Final-4-1-13-Final.html

Change-Id: I950a06bcb8e70f07803912a6d7c2f55eb67a0394
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Upgrade Jacoco Listeners 2.4 -> 3.8

Change-Id: I951403569556ded05380bb65e5e30addb643dc64
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove outdated src/site documentation

see https://lists.opendaylight.org/pipermail/odlparent-dev/2017-July/001218.html

Change-Id: Ie1580e11fa449ed38864960c868c4930f847e291
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Control karaf archive by parameters

    - add properties karaf.archiveZip and karaf.archiveTagGz
    - by default all archives are being created as before

See also: BUG-8765

Change-Id: I303bc2966d3436b7080d2ac47c7b2c735e537a40
Signed-off-by: Michal Rehak <mirehak@cisco.com>

${project.build.directory} in maven-bundle-plugin

Instead of hard-coding "target/" as directory name.
for the LICENSE file. This fixes the following probem:

   mvn -Pq,ide clean install

[INFO] --- maven-bundle-plugin:3.0.1:bundle (default-bundle) @ ... ---
[ERROR] Bundle ... : Input file does not exist: target/classes/LICENSE
[ERROR] Error(s) found in bundle configuration

Locally verified that with this fix, the problem shown above does not
happen anymore - and the LICENSE file is still in bundle JARs.

PS: In order to reproduce the problem above (and test this fix),
you (obviously) need to 'rm -rf target/ target-ide/' first... ;)

Change-Id: I313478ec95c9a6e647a595418bd92d45bbb04a8d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bug 8799: populate repo first

To avoid overwriting patched files, we populate the local repository
before overwriting files with contents from
opendaylight-karaf-resources. This ensures that our patched files
survive karaf4-parent processing into projects’ distributions.

Change-Id: I4c00b493d50e56b117ec3c56ac3ffe2fa7814516
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bug-8798: ensure script permissions are correct

Since https://git.opendaylight.org/gerrit/59486 script permissions
aren’t preserved (from a tarball); this patch enforces permissions on
all the shell scripts.

Change-Id: Ie4ed6b31b20302ea925aeefc472e1c09a3295a1d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Disable SFT on feature repos by default

Testing the features in repos can cause issues when they are
mutually-incompatble. Since we test features individually anyway, we
can safely disable SFT by default. skip.karaf.featureTest can be set
to false for projects which want to re-enable this.

Change-Id: I02ec0094985ccc5e7cc1f404808b156883c25911
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump BC to 1.57

https://www.bouncycastle.org/releasenotes.html

Change-Id: I802837879550de85af80858bd1c62c8028d04f03
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add Bouncy Castle to startup bundles

We rely on the provider being available, wire it into startup
properties to get that going.

Change-Id: Iee3a386a2d7f6e36caaaa03e846511ad4a213bbe
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bug 8677: Do Karaf patch-ing earlier and only once

This changes the application of those patches over Karaf to happen once
during the opendaylight-karaf-resources build (as part of odlparent),
instead of in (each child of) karaf4-parent, as it used to be.

This is better because it:

 (a) solves mysterious issues with patch sometimes failing, see
https://lists.opendaylight.org/pipermail/odlparent-dev/2017-June/001136.html

 (b) avoids problems for Windows users (where there is no "patch")

 (c) makes Karaf local distro builds in projects (a bit) faster.

Change-Id: I16d912c6bc0d60295a787994a602e2753b37bfb2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Remove unused k4.0.7 patches

Change-Id: I956ad203e1f8d17b5e5da61f44590e789ad705d8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump versions to 2.1.0-SNAPSHOT

Change-Id: I87425ce991c5277f60074121132254104704d813
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bug 8571: copy src/main/assembly

The contents of src/main/assembly need to be copied to
target/assembly, overwriting any conflicting file from Karaf.
integration/distribution needs this to be able to add custom scripts
and replace configuration files.

(Arguably this should be part of integration/distribution, but it
can’t be — at least not in a maintainable fashion.)

Change-Id: Ifcce82862d350b87853727e2c77140adee164886
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump org.apache.aries.blueprint.core version

From 1.4.2 to latest 1.7.1, because in
org.opendaylight.controller:blueprint version 1.7.1 was already used
anyway, and indeed this appears to be the version used in our current
version of Karaf, and it seems wiser to declare this in only a single
place, to avoid possible version discrepancy problems re. this artifact
in the future.  So let's just bump this one, and drop the version in
controller:blueprint in a follow-up change.

Change-Id: Ib332fb88eab11a376e93ea90304e2a22115b3e85
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Remove '4' suffix in karaf[4]-plugin

Change-Id: I05c6241213d761f4764f7b7db8accb2e100d638c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Drop odl-guava-18

Change-Id: I545bcacb92d7ede5c95a1f004869d3d35f0438ca
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Clean up POMs

The main point of this patch is to remove duplicates in the artifacts
POM. The patch also uses ${project.version} where appropriate.

Change-Id: I0554adb79bb7060bf0d45dbd3349440b7f808a7c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG-7446: switch advertized guava to 22.0

This is the build-time switchover patch to have downstream
pick up guava 22.

Change-Id: Ic547fb93ba718d51e6be6f6400b259beff83b8b8
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add antlr4 dependency declaration

This is used in yangtools mostly, but will be useful for anyone
dealing with lexers/parsers.

Change-Id: I5e1b232ca7357a6895162427d35736020859f266
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Xtend 2.11 → 2.12

https://eclipse.org/Xtext/releasenotes.html#/releasenotes/2017/05/25/version-2-12-0

Change-Id: I538fed69d39af0c493d0eda6642601b1a28a3c7d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump to 2.0.0-SNAPSHOT

Since we’ve introduced breaking changes, we need to bump to
2.0.0-SNAPSHOT. (Thanks to Michael for pointing out the error of my
ways!)

Change-Id: Ic79385b234526ca0ab72180dbe2664351ed680ab
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump git-commit-id-plugin 2.2.1 → 2.2.2

Change-Id: Id73ca8bee3b8b048ad3f277b2bc40dced19c6b37
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove '4' suffix in applicable artifact names

During the Karaf 4 migration, while both Karaf versions coexisted it
was necessary to have a different artifactId for Karaf 4 features and
feature repositories produced by odlparent. After Karaf 3 is removed,
this is no longer necessary, and this patch removes the '4' from
applicable directory, artifact and property names.

Change-Id: Ib6446a86a75a1a4b9637e73b71aca640a22807f4
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Remove all Karaf 3 Artifacts (now Karaf 4, only)

Change-Id: I4e60779869d8d4cb4760c1327f4abf238be98ddd
Signed-off-by: Michael Vorburger <vorburger@redhat.com>