netconf.git
7 years agoUse SerializationUtils to (de)serialize NormalizedNode and YangInstanceIdentifier 94/47394/2
Alexis de Talhouët [Fri, 21 Oct 2016 20:26:02 +0000 (16:26 -0400)]
Use SerializationUtils to (de)serialize NormalizedNode and YangInstanceIdentifier

Controller CDS implementation provide utility method for this,
we can re-use them, as it appears it's keeping a ThreadLocal
holding NormalizedNodeDataOutput instance

Change-Id: Ia106f33d04f937ac8dacf89cb6837a157eee8ae1
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
(cherry picked from commit 4f326302b5dcb41b1da291a0240e2b8808a63893)

7 years agoMerge "Bug 6714 - Use singleton service in clustered netconf topology" into stable...
Tomas Cere [Fri, 21 Oct 2016 16:59:58 +0000 (16:59 +0000)]
Merge "Bug 6714 - Use singleton service in clustered netconf topology" into stable/boron

7 years agoBug 6714 - Use singleton service in clustered netconf topology 51/47351/3
Rudolf Brisuda [Fri, 7 Oct 2016 09:44:23 +0000 (11:44 +0200)]
Bug 6714 - Use singleton service in clustered netconf topology

Implemented clustered netconf topology with using clustered
singleton service.

Change-Id: I0e71a9934a70c6bce8eeab0644a5bd05c5548a8c
Signed-off-by: Rudolf Brisuda <rbrisuda@cisco.com>
7 years agoBug 6256 - OpenDaylight RESTCONF XML selects wrong YANG model for southbound NETCONF 04/47304/4
Ivan Hrasko [Tue, 27 Sep 2016 12:32:33 +0000 (14:32 +0200)]
Bug 6256 - OpenDaylight RESTCONF XML selects wrong YANG model for southbound NETCONF

- dataSchemaNode can contains multiple childs with the same name,
thus when looking for child also namespace has to be compared
- added unit tests

Change-Id: I922e96fd2aea686c27ad4683ef7366c6718486c3
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
(cherry picked from commit 87542484718b320055eb1de42b85f90ef7624584)

7 years agoMerge "Fix tests after merging Change 47121 to Yangtools" into stable/boron
Tomas Cere [Fri, 21 Oct 2016 14:40:44 +0000 (14:40 +0000)]
Merge "Fix tests after merging Change 47121 to Yangtools" into stable/boron

7 years agoMerge "Bug 5615 - Netconf connector update overwriting existing topology data" into...
Tomas Cere [Fri, 21 Oct 2016 14:09:45 +0000 (14:09 +0000)]
Merge "Bug 5615 - Netconf connector update overwriting existing topology data" into stable/boron

7 years agoFix tests after merging Change 47121 to Yangtools 45/47345/1
Ivan Hrasko [Fri, 21 Oct 2016 13:38:38 +0000 (15:38 +0200)]
Fix tests after merging Change 47121 to Yangtools

Change-Id: I4bafce0972da4e83fe4575517b5e95808bb21caf
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
7 years agoBug 6272 - support RESTCONF PATCH for mounted NETCONF nodes 02/47302/1
Ivan Hrasko [Fri, 2 Sep 2016 14:01:32 +0000 (16:01 +0200)]
Bug 6272 - support RESTCONF PATCH for mounted NETCONF nodes

- distinguish between operation on server or on mount point
- when operates on server then use global schema context and
data broker
- when operates on mount point then use schema context and
broker from mount point
- if broker on mount point is missing then PATCH operation fails
with global error
- contains unit tests

Change-Id: I97135a467209fcb4a5782d1c2677f482b842ff8a
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
(cherry picked from commit c09b7ffd0f3812a237c82805ea16a67ffdeda89d)

7 years agoAdd xml config dependency to features pom 12/47212/2
Vratko Polak [Thu, 20 Oct 2016 15:25:00 +0000 (17:25 +0200)]
Add xml config dependency to features pom

Configfile added here [0] also needs to be listed as pom dependency,
otherwise distribution-check would fail.
Also added to netconf-artifacts.

[0] https://git.opendaylight.org/gerrit/#/c/44243/10/features/netconf/src/main/features/features.xml

Change-Id: If016aadb03154d83ddd0afa680e8d1d8acd88217
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit c2272d825c810de0a023661f054cd0ce023e0a77)

7 years agoMerge "Bug 6023 - Adress for config subsystem netconf endpoint is not configurable...
Tomas Cere [Thu, 20 Oct 2016 13:01:32 +0000 (13:01 +0000)]
Merge "Bug 6023 - Adress for config subsystem netconf endpoint is not configurable" into stable/boron

7 years agoBug 6023 - Adress for config subsystem netconf endpoint is not configurable 33/47133/1
Rudolf Brisuda [Wed, 17 Aug 2016 12:03:04 +0000 (14:03 +0200)]
Bug 6023 - Adress for config subsystem netconf endpoint is not configurable

- added NetconfConfigurationActivator for loading ManagedService
- updating configuration from karaf netconf.cfg file
- edited NetconfTCPActivator, NetconfSSHActivator for run with
  cfg values

Change-Id: I5069a9f307a9a9b7c2d79723dc6c1cca0b2cc201
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
7 years agoBug 6936 - Fix post request 13/47113/6
Ivan Hrasko [Wed, 19 Oct 2016 08:07:03 +0000 (10:07 +0200)]
Bug 6936 - Fix post request

When post request sends data which already exist, it response with
data already exist.

Change-Id: I2ea60dfe4b8aa4236fbec0fd73b64a6f146146ee
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
7 years agoUnit test for PostDataTransactionUtil class 26/47126/2
Ivan Hrasko [Wed, 19 Oct 2016 12:36:58 +0000 (14:36 +0200)]
Unit test for PostDataTransactionUtil class

Change-Id: I38e1d29daa1598609e1a706b16d1bb2f24012f0f
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
7 years agoUnit test for RestconfInvokeOperationsUtil class 27/47127/1
Ivan Hrasko [Wed, 19 Oct 2016 13:15:42 +0000 (15:15 +0200)]
Unit test for RestconfInvokeOperationsUtil class

Fixed so it add rpcError to the result when there is one.

Change-Id: I5e3e924a0e80970f2f754e2ec39d58e4b0a06984
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
7 years agoBug 5615 - Netconf connector update overwriting existing topology data 18/47118/1
rbrisuda [Wed, 10 Aug 2016 12:50:35 +0000 (14:50 +0200)]
Bug 5615 - Netconf connector update overwriting existing topology data

- putting only augmented node 'NetconfNode' to operational datastore
- updated tests

Change-Id: I3153613c9041c36f558e73128d40dd75dece0293
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
(cherry picked from commit de60ce77c83f1f09bb804f61124fe5c9f439c376)

7 years agoBug 6848 - update url pattern of restconf from 16 to 17 27/46827/1
Jakub Toth [Wed, 5 Oct 2016 13:33:07 +0000 (15:33 +0200)]
Bug 6848 - update url pattern of restconf from 16 to 17

Change-Id: I41882d048a3aede5f4c47c3e160537f7a31a1fab
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 6848 - repackage providers for jersey+create xml 26/46826/1
Jakub Toth [Wed, 5 Oct 2016 12:56:08 +0000 (14:56 +0200)]
Bug 6848 - repackage providers for jersey+create xml
and json reader for restconf draft17

  *fix tests
  *rename tests part from draft11 to draft17

Change-Id: I1315bb693eccc34c78f07ea0acbf45f6ff972455
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 6848 - upgrade XML media type 25/46825/1
Jakub Toth [Tue, 4 Oct 2016 06:54:46 +0000 (08:54 +0200)]
Bug 6848 - upgrade XML media type

Change-Id: I16b959a4f325468836477c60d094a1e7473de9e1
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 6848 - upgrade namespace of notification container 99/46699/1
Jakub Toth [Tue, 4 Oct 2016 06:48:07 +0000 (08:48 +0200)]
Bug 6848 - upgrade namespace of notification container

Change-Id: I6f50832bc94d809d5ba354ceb17dfdecc0b181bd
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 6848 - Renaming to draft17 97/46697/1
Jakub Toth [Mon, 3 Oct 2016 13:48:08 +0000 (15:48 +0200)]
Bug 6848 - Renaming to draft17

Change-Id: Ib76f9f0ed4e86a4e9cc15d82fd4ede5040964969
Signed-off-by: Jakub Toth <jatoth@cisco.com>
(cherry picked from commit acbc3139281024824f927426562d25a1f764b34c)

7 years agoDo a proper disconnect when deleting a connector. 67/46667/1
Tomas Cere [Fri, 7 Oct 2016 10:21:43 +0000 (12:21 +0200)]
Do a proper disconnect when deleting a connector.

Change-Id: I1abba51e331eb1f019e5f2fe741f3836f840aae1
Signed-off-by: Tomas Cere <tcere@cisco.com>
(cherry picked from commit fc129a55005ce9d0c1cacfb2538e71fbe56ddd2a)

7 years agoBug 6099 - ControllerContext#addKeyValue ignores key type when key is derived 14/46514/1
Jakub Toth [Mon, 12 Sep 2016 13:30:06 +0000 (15:30 +0200)]
Bug 6099 - ControllerContext#addKeyValue ignores key type when key is derived
type from instance-identifier

 * added instance identifier support as value
 * JUnit test added

Change-Id: I4f6a070b5814ef2a33b68534d887745a099712c8
Signed-off-by: Jakub Toth <jatoth@cisco.com>
(cherry picked from commit aa0006992ccc87f68e9810c0dee6c16cf339f544)

7 years agoBug 6797 - Fix deadlock on cached schema-changed notifications 17/46317/1
ykq [Thu, 29 Sep 2016 03:36:54 +0000 (11:36 +0800)]
Bug 6797 - Fix deadlock on cached schema-changed notifications

Add an atomic state in NetconfDeviceCommunicator to improve the state
transition of close operation, to avoid deadlock while multiple threads
are doing the close.

Change-Id: I2f2c41b86b724eba78a74bfb96c0b499dc7f79a3
Signed-off-by: ykq <yin.kangqian@zte.com.cn>
7 years agoBug 6664 - upgrade draft15 to draft16 - change media types 77/45977/3
Jakub Toth [Thu, 8 Sep 2016 09:04:01 +0000 (11:04 +0200)]
Bug 6664 - upgrade draft15 to draft16 - change media types

  * for XML - yang-data -> yang-data-xml

Change-Id: I56c8cc5439d962ca7a54c931965ccb519f0f0617
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 6664 - upgrade draft15 to draft16 - renaming 60/45960/4
Jakub Toth [Thu, 8 Sep 2016 08:35:25 +0000 (10:35 +0200)]
Bug 6664 - upgrade draft15 to draft16 - renaming

Change-Id: Iaaefc58f8615f8ef16ba538d23576ea852be1064
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoFix broken ApiDocGeneratorTest 75/45975/1
miroslav.kovac [Wed, 21 Sep 2016 11:22:42 +0000 (13:22 +0200)]
Fix broken ApiDocGeneratorTest

Patch https://git.opendaylight.org/gerrit/#/c/43500/ changed
the way constraints are handled in yangtools which causes
the faiure of EdgeTest in ApiDocGeneratorTest.

Change-Id: I455d924b69aee0a6cd6304be27656d44a62e6c73
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
(cherry picked from commit 42fca64cadd8bce723dc2b74bcf8cc73143189b0)

7 years agoMerge "Bug 6343 - Incorrect handling of configuration failures in SAL netconf connect...
Tomas Cere [Wed, 21 Sep 2016 11:59:50 +0000 (11:59 +0000)]
Merge "Bug 6343 - Incorrect handling of configuration failures in SAL netconf connector" into stable/boron

7 years agoBumping versions by 0.0.1 for next dev cycle 79/45679/1
Anil Belur [Thu, 15 Sep 2016 23:09:31 +0000 (09:09 +1000)]
Bumping versions by 0.0.1 for next dev cycle

Change-Id: I13c1020747f50264c59e2e2d71e0ab8385d72c14
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
7 years agoBug 6343 - Incorrect handling of configuration failures in SAL netconf connector 54/45054/1
Jakub Morvay [Wed, 31 Aug 2016 14:41:56 +0000 (16:41 +0200)]
Bug 6343 - Incorrect handling of configuration failures in SAL netconf connector

Change-Id: I4fbf06038b4a14c0efecfa6564e69671a3d23bcc
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
(cherry picked from commit 827f758622c4cce82653f3d00507b8a88e7e457a)

7 years agoMerge "Bug 6594 - Unsupported leaf in identityref in leafref" into stable/boron
Tomas Cere [Wed, 31 Aug 2016 14:53:09 +0000 (14:53 +0000)]
Merge "Bug 6594 - Unsupported leaf in identityref in leafref" into stable/boron

7 years agoBug 6594 - Unsupported leaf in identityref in leafref 31/44931/1
Jakub Toth [Wed, 31 Aug 2016 11:36:37 +0000 (13:36 +0200)]
Bug 6594 - Unsupported leaf in identityref in leafref

  * fixed incorrect checking of variable

Change-Id: I01c631d7bbc22857e1c454a860ac636305301e38
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 6325 - Fix for draft15 update 29/44929/1
Jakub Toth [Thu, 4 Aug 2016 14:32:19 +0000 (16:32 +0200)]
Bug 6325 - Fix for draft15 update

- transaction chain must be updated
in transaction handler

- adapt utility methods to reset
transaction chain

Change-Id: I20578f97c9a8d002c0ebcc6b8a89a152c1e1c47a
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 6325 - upgrade draft11 to draft15 - added timestamp & etag 28/44928/1
Jakub Toth [Thu, 4 Aug 2016 13:26:41 +0000 (09:26 -0400)]
Bug 6325 - upgrade draft11 to draft15 - added timestamp & etag

  *fixed read of data from datastore

Change-Id: I629c909ba05f93f4d662199a86637e966cb6d8e1
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 6325 - upgrade draft11 to draft15 - change get modules 27/44927/1
Jakub Toth [Tue, 2 Aug 2016 18:23:58 +0000 (14:23 -0400)]
Bug 6325 - upgrade draft11 to draft15 - change get modules

  *change modules to modules-state
  *chagne modules/module to modules-state/module

Change-Id: I54f04c99484941e1ff59af67f822c2ef73c411b5
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 6325 - upgrade draft11 to draft15 - change media types 26/44926/1
Jakub Toth [Tue, 2 Aug 2016 17:58:38 +0000 (13:58 -0400)]
Bug 6325 - upgrade draft11 to draft15 - change media types

  * remove media types(for +json and +xml in all cases):
    * yang.api
    * yang.datastore
    * yang.data
    * yang.operation
    * yang.errors
  * add new media type:
    * for xml - yang-data
    * for json - yang-data+json

Change-Id: I9c1e3a28872c47f691d342a4982eaa3f8bbae16c
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 6325 - upgrade draft11 to draft15 - renaming 83/44083/5
Jakub Toth [Tue, 2 Aug 2016 14:19:48 +0000 (10:19 -0400)]
Bug 6325 - upgrade draft11 to draft15 - renaming

  *renaming of all occurencies of "draft11" to "draft15"

Change-Id: Ie681c8c511fda87f6d3c862f64667827a9bff1f6
Signed-off-by: Jakub Toth <jatoth@cisco.com>
(cherry picked from commit bb7dcf7024a5918e72e2035312205f726189a2c4)

7 years agoBug 6457 - Delete Cars configuration from Follower produces HTTP 500 Error 59/44559/8
Jakub Toth [Tue, 23 Aug 2016 15:09:53 +0000 (17:09 +0200)]
Bug 6457 - Delete Cars configuration from Follower produces HTTP 500 Error

  * change InterruptedException with Exception
  * Ignore unstable tests in RestPutOperationTest + TODO

Change-Id: I93f66dc713781f4dacd7c9f804d8bf71ffc798e3
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 6485 - unstable mount point 04/44604/1
Jakub Toth [Wed, 24 Aug 2016 12:41:47 +0000 (14:41 +0200)]
Bug 6485 - unstable mount point

  * swap result of operation with CountDownLatch.countDown()

Change-Id: Ib042de4ee5d6399a15d7877fef0c9260339380f0
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5553 - Impl get operations 43/43943/4
Jakub Toth [Mon, 4 Jul 2016 10:47:24 +0000 (12:47 +0200)]
Bug 5553 - Impl get operations

  *package protected impl of container, leaf and module
  *fix for new restconf part too

Change-Id: I1e3e1eb1a52158278992df871ba6690dd3b7c640
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoMerge "Bug 6251 - Exclude flawed models from mount point" into stable/boron
Tomas Cere [Fri, 12 Aug 2016 08:45:19 +0000 (08:45 +0000)]
Merge "Bug 6251 - Exclude flawed models from mount point" into stable/boron

7 years agoMerge "Bug 6278: Switch to use odlparent's karaf-parent" into stable/boron
Tomas Cere [Thu, 11 Aug 2016 12:28:10 +0000 (12:28 +0000)]
Merge "Bug 6278: Switch to use odlparent's karaf-parent" into stable/boron

7 years agoMerge "Bump OpenExi to 2.62.0" into stable/boron
Tomas Cere [Thu, 11 Aug 2016 12:28:00 +0000 (12:28 +0000)]
Merge "Bump OpenExi to 2.62.0" into stable/boron

7 years agoBug 6251 - Exclude flawed models from mount point 90/43690/3
Jakub Morvay [Wed, 10 Aug 2016 20:02:51 +0000 (22:02 +0200)]
Bug 6251 - Exclude flawed models from mount point

Flawed models that cannot be parsed by Yangtools are ignored when
building schema context for mountpoint.

Change-Id: I32585bcf34ae9df153c7147566828ba887f466de
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoMerge "Bug 6198 - Use sal-netconf-connector to connet device costs too much time...
Tomas Cere [Thu, 11 Aug 2016 11:51:12 +0000 (11:51 +0000)]
Merge "Bug 6198 - Use sal-netconf-connector to connet device costs too much time" into stable/boron

7 years agoBug 6278: Switch to use odlparent's karaf-parent 08/43708/1
Ryan Goulding [Wed, 3 Aug 2016 16:39:31 +0000 (12:39 -0400)]
Bug 6278: Switch to use odlparent's karaf-parent

Change-Id: I13739711964cd58cb0ef148bcb04532883fea19f
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
7 years agoBump OpenExi to 2.62.0 07/43707/1
Robert Varga [Tue, 2 Aug 2016 18:58:16 +0000 (20:58 +0200)]
Bump OpenExi to 2.62.0

This bumps the version to the latest released one.

Change-Id: I10dff28446bb7bdcde86c06fe03075f6a67a2bd3
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-865: remove String-based getDataChildByName() 89/43689/1
Jakub Morvay [Wed, 10 Aug 2016 22:00:53 +0000 (00:00 +0200)]
BUG-865: remove String-based getDataChildByName()

Replace usage of deprecated String-based getDataChildByName() method
with QName-based one.

Change-Id: I0108a98bb35082f1fe1b0a3c728fef2e4f43f9b9
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoBug 6198 - Use sal-netconf-connector to connet device costs too much time 87/43687/1
Xu Rong [Tue, 19 Jul 2016 13:16:44 +0000 (21:16 +0800)]
Bug 6198 - Use sal-netconf-connector to connet device costs too much time

Filter missing sources Identifiers before createSchemaContext in class RecursiveSchemaSetup.

Change-Id: Ic41d4803df0807d799a1e80ceb6639877f006e42
Signed-off-by: Xu Rong <xu.rong4@zte.com.cn>
(cherry picked from commit 57f2e5cc5a34fbecd7a492f3180e9a54d9cd8d17)

7 years agoUpdate .gitreview for stable/boron 73/43373/1
Thanh Ha [Mon, 8 Aug 2016 21:40:31 +0000 (17:40 -0400)]
Update .gitreview for stable/boron

Change-Id: I05e62c11b732a80c04cf1631cda4e2e3685ac7cb
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
7 years agoBug 6358 - Fix merge parents 16/43316/2
Jakub Toth [Mon, 8 Aug 2016 13:50:27 +0000 (15:50 +0200)]
Bug 6358 - Fix merge parents

Change-Id: I965f1ebe2e2bcc06f9af93e613351f28778448ff
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoMerge "Bug 6037 - Check if delete request was successful"
Tomas Cere [Fri, 5 Aug 2016 09:55:46 +0000 (09:55 +0000)]
Merge "Bug 6037 - Check if delete request was successful"

7 years agoMerge "Yang HTTP PATCH for Restconf11"
Tomas Cere [Fri, 5 Aug 2016 09:55:40 +0000 (09:55 +0000)]
Merge "Yang HTTP PATCH for Restconf11"

7 years agoBug 6037 - Check if delete request was successful 12/42712/25
Ivan Hrasko [Thu, 28 Jul 2016 13:16:01 +0000 (15:16 +0200)]
Bug 6037 - Check if delete request was successful

- adaptation for Restconf draft 11+
- checking if data to delete exists, if not return error 404
- remove not needed method from POST utils
and use method from common transaction utils
- added unit tests

Change-Id: I133c628a2e41f12d1db58fd06ff6c073ebfc6ece
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoYang HTTP PATCH for Restconf11 33/41833/53
Ivan Hrasko [Thu, 14 Jul 2016 13:57:09 +0000 (15:57 +0200)]
Yang HTTP PATCH for Restconf11

- support for restconf draft11-15 changes
- support for xml and json media types
- applied fixes for:
- Bug 5897 - PATCH merge operation does nothing
- Bug 5909 - PATCH does not report 409 on
OptimisticLockFailedException
- Bug 5730 - Delete subset of list items using PATCH?
- Bug 5898 - PATCH success "ok" field has wrong JSON value
- Bug 5915 - PATCH with "target":"/" error
- Bug 5509 - HTTP Patch in Restconf doesn't support general
absolute or relative target xpath
- contains unit tests
- Draft02 classes marked as deprecated
- adapt PATCH writers to support error path

Change-Id: I981dc8cbead3c5a7dc06b7b807c17a40a9cfe7b3
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 6037 - Check if delete request was successful 05/42705/11
Ivan Hrasko [Thu, 28 Jul 2016 12:45:09 +0000 (14:45 +0200)]
Bug 6037 - Check if delete request was successful

- solution for old restconf
- checking if data to delete exists, if not return error 404
- use callbacks for transactions

Change-Id: I0f4c11cb3dd9c7fc560a4fee06df0d398c0c4f61
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 2594 - PUT method returns wrong status for create resource 35/40235/14
Jakub Toth [Mon, 13 Jun 2016 12:49:47 +0000 (14:49 +0200)]
Bug 2594 - PUT method returns wrong status for create resource

  *remove get() and checkedGet() on future objects, add callback
  *fix tests

Change-Id: I48f8f825da2427357c3f8948cbea52d2f9c235ce
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoMerge changes I426a2bc1,I5440b866
Tomas Cere [Tue, 2 Aug 2016 13:57:34 +0000 (13:57 +0000)]
Merge changes I426a2bc1,I5440b866

* changes:
  Bug 6291 - Fix bugs of new Restconf 11 implementation
  Bug 5909 - PATCH does not report 409 on OptimisticLockFailedException

7 years agoBug 6322 - Boron: odl-netconf-clustered-topology still depends on distributed-entity... 43/42943/1
Jakub Morvay [Tue, 2 Aug 2016 07:06:28 +0000 (09:06 +0200)]
Bug 6322 - Boron: odl-netconf-clustered-topology still depends on distributed-entity-ownership-service

Change-Id: I47c234ff6b927c770d89974907a7291067ab1af1
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoBug 6291 - Fix bugs of new Restconf 11 implementation 65/42565/17
Ivan Hrasko [Tue, 26 Jul 2016 12:46:04 +0000 (14:46 +0200)]
Bug 6291 - Fix bugs of new Restconf 11 implementation

- first identifier does not start with slash
when deserialization is invoked
- adapted unit tests
- return error 404 when data missing with GET
operation
- return config data when state data does
not exists with GET operation
- return state data when config data does
not exists with GET operation
- identifier can be null and it is deserialized to
YangInstanceIdentifier.EMPTY

Change-Id: I426a2bc1cb0e908dc189553e464f405ef4ce1457
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5909 - PATCH does not report 409 on OptimisticLockFailedException 62/42462/18
Ivan Hrasko [Tue, 26 Jul 2016 14:17:46 +0000 (16:17 +0200)]
Bug 5909 - PATCH does not report 409 on OptimisticLockFailedException

- wait for transaction to be finished using callback

Change-Id: I5440b866eada07ee6540c6b93d2e9174e62a37ce
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5897 - PATCH merge operation does nothing 61/42461/11
Ivan Hrasko [Mon, 25 Jul 2016 10:43:38 +0000 (12:43 +0200)]
Bug 5897 - PATCH merge operation does nothing

- added merge patch operation processing

Change-Id: Ic3f5908c5f016a0680779ed12b4bc26b7b840d9a
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5915 - PATCH with "target":"/" error 60/42460/10
Ivan Hrasko [Mon, 25 Jul 2016 10:43:06 +0000 (12:43 +0200)]
Bug 5915 - PATCH with "target":"/" error

- fixed bug + added unit test (example of usage)
for json and xml
- improved solution of bug5730

Change-Id: I0d8042ffdced97918ff936817513fc30163be577
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5509 - HTTP Patch in Restconf doesn't support general absolute or relative target... 59/42459/12
Ivan Hrasko [Mon, 25 Jul 2016 10:42:30 +0000 (12:42 +0200)]
Bug 5509 - HTTP Patch in Restconf doesn't support general absolute or relative target xpath

- yang patch for xml media now supports relative or absolute xpaths
- only create, merge, replace and insert operations require value to be present
- if value is not present with create, merge, replace or insert operation
then error 400 is returned
- if value is used with other operations then error 400 is returned
- deleting sublist values instead of full parent
- support for multiple values
- added unit tests

Change-Id: I9828ceb7368760642b22b3a336884b949f0edfcc
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5509 - HTTP Patch in Restconf doesn't support general absolute or relative target... 57/42457/9
Ivan Hrasko [Mon, 25 Jul 2016 10:12:07 +0000 (12:12 +0200)]
Bug 5509 - HTTP Patch in Restconf doesn't support general absolute or relative target xpath

- dependencies shared between XML and JSON PATCH implementations

Change-Id: Ia649763379fab03019ddfd16eac564da576cb35b
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5898 - PATCH success "ok" field has wrong JSON value 56/42456/9
Ivan Hrasko [Mon, 25 Jul 2016 10:08:33 +0000 (12:08 +0200)]
Bug 5898 - PATCH success "ok" field has wrong JSON value

- empty value is represented as an array with value null

Change-Id: Ie8315d5a18756fd12d3b7a7de693dfd1c569945a
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5730 - Delete subset of list items using PATCH? 49/42449/9
Ivan Hrasko [Mon, 25 Jul 2016 10:35:53 +0000 (12:35 +0200)]
Bug 5730 - Delete subset of list items using PATCH?

- fix: edit is not ignored when end of input is reached
- fix: only create, merge, replace and insert operations require value to be present
- fix: if value is not present with create, merge, replace or insert operation then error 400 is returned
- fix: if value is used with other operations error 400 is returned
- fix: deleting sublist values instead of full parent
- fix: order of patch edit fields is not important anymore (target, value)
- move class StringModuleInstanceIdentifierCodec to own file

Change-Id: I4c3f407858034b49795034da6c93b41f9d891b62
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5509: HTTP Patch in Restconf doesn't support general absolute or relative target... 58/42458/6
Ivan Hrasko [Mon, 25 Jul 2016 10:27:57 +0000 (12:27 +0200)]
Bug 5509: HTTP Patch in Restconf doesn't support general absolute or relative target xpath

Absolute or relative input URI and PATCH target JSON support

Change-Id: I86821e59581968cef5f11ec34ce98757909f7c36
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoRevert "Bump apache mina to 1.2.0" 27/42627/1
Tomas Cere [Wed, 27 Jul 2016 11:12:03 +0000 (13:12 +0200)]
Revert "Bump apache mina to 1.2.0"

This reverts commit 3911a32461cf5817787c807cad676d4164f0cbd4.

Change-Id: Ia4cdf9a281706157933326f7e8de1ef95bcbb6a6
Signed-off-by: Tomas Cere <tcere@cisco.com>
7 years agoBug 3959 - support netconf notification 39/41639/18
Jakub Toth [Fri, 8 Jul 2016 13:44:52 +0000 (15:44 +0200)]
Bug 3959 - support netconf notification

  *added dependency for converting JSON to XML
  *created new notification listener adapter extended
   by DOMNotificationListener
  *added augment for sal-remote to add new param
   for input of create-notification-stream rpc to
   make a choice between JSON or XML output of
   notification (not mandatory - default is XML)
  *added unit tests

Change-Id: I7f5909208dce71e2280fd1bc6dbe49cb7533523a
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoMerge "Bump apache mina to 1.2.0"
Tomas Cere [Mon, 25 Jul 2016 12:11:49 +0000 (12:11 +0000)]
Merge "Bump apache mina to 1.2.0"

7 years agoAdd missing license headers 78/42378/1
Thanh Ha [Sat, 23 Jul 2016 03:12:52 +0000 (23:12 -0400)]
Add missing license headers

Change-Id: Ic4bb7ae58d821c8c00849db4b934c5eeb3bf5b68
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
7 years agoBump apache mina to 1.2.0 24/41824/9
Robert Varga [Thu, 14 Jul 2016 12:19:18 +0000 (14:19 +0200)]
Bump apache mina to 1.2.0

Bumps the dependency from pre-release to the current
release. Also adjusts implementation to match changed APIs.

Change-Id: Ia5d7479e32cbd25c9f9f67a5866a5d2830f146d6
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Switch to using StandardCharsets"
Tomas Cere [Tue, 19 Jul 2016 07:57:28 +0000 (07:57 +0000)]
Merge "Switch to using StandardCharsets"

7 years agoSwitch to using StandardCharsets 83/41983/3
Robert Varga [Mon, 18 Jul 2016 14:52:02 +0000 (16:52 +0200)]
Switch to using StandardCharsets

Guava's Charsets should not be used in recent Java
environments.

Change-Id: I24d14cd2410ba3d249037e802b7863a6141c89db
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoUse upgraded ietf-{inet,yang}-types in test-tool 75/41975/1
Jakub Morvay [Mon, 18 Jul 2016 14:18:58 +0000 (16:18 +0200)]
Use upgraded ietf-{inet,yang}-types in test-tool

Change-Id: I5c99b7bb815f723bbc7640b4c118f5ee395fe6cf
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoMerge "Organize Import to conform to Checkstyle guidelines."
Tomas Cere [Mon, 18 Jul 2016 07:58:42 +0000 (07:58 +0000)]
Merge "Organize Import to conform to Checkstyle guidelines."

7 years agoMerge "Bug 5682 - MDSAL netconf northbound yang library"
Tomas Cere [Mon, 18 Jul 2016 07:53:16 +0000 (07:53 +0000)]
Merge "Bug 5682 - MDSAL netconf northbound yang library"

7 years agoBug 5682 - MDSAL netconf northbound yang library 40/40540/7
Jakub Morvay [Sun, 19 Jun 2016 19:07:28 +0000 (21:07 +0200)]
Bug 5682 - MDSAL netconf northbound yang library

This adds support for ietf-yang-library for MDSAL netconf northbound
server

Change-Id: Iab6178d2fc975860f7c5c835517fc3c120faebb7
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoBug 6154 - Connection to config subsystem netconf endpoint refused 16/41816/3
Jakub Morvay [Thu, 14 Jul 2016 08:37:30 +0000 (10:37 +0200)]
Bug 6154 - Connection to config subsystem netconf endpoint refused

Makes config subsystem SSH server listen on address 0.0.0.0 instead of
127.0.0.1.

Change-Id: I7577629763b7d5a0d86d92ea0e997a80e841f360
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoAdjust tests to new ietf-inet-types 22/41922/1
Robert Varga [Sun, 17 Jul 2016 08:25:10 +0000 (10:25 +0200)]
Adjust tests to new ietf-inet-types

Change-Id: I39d6bebfb178950f828bce912a8b3e533b0e1abc
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoOrganize Import to conform to Checkstyle guidelines. 18/39618/3
Michael Vorburger [Mon, 30 May 2016 17:20:02 +0000 (19:20 +0200)]
Organize Import to conform to Checkstyle guidelines.

Change-Id: Ia766cb2af1c13808a7a0b28761fdd241c781319b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoUpgrade ietf-{inet,yang}-types to 2013-07-15 93/40793/4
Lorand Jakab [Wed, 6 Jul 2016 13:56:38 +0000 (08:56 -0500)]
Upgrade ietf-{inet,yang}-types to 2013-07-15

Change-Id: I632370c6e9b078817c69a19b3f7c1c17846ce249
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoBug 5526 - Testing - RestconfModulesService 01/38501/33
Jakub Toth [Fri, 6 May 2016 09:42:27 +0000 (11:42 +0200)]
Bug 5526 - Testing - RestconfModulesService

Unit tests for RestconfModulesServiceImpl + repackaging of tests

Change-Id: I0cb9c7b753d5c4c54d4d4d393d86787294a0903e
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5526 - Testing - Utils - Mapping 76/38576/34
Ivan Hrasko [Mon, 9 May 2016 13:42:24 +0000 (15:42 +0200)]
Bug 5526 - Testing - Utils - Mapping

Unit test for RestconfMappingNodeUtil

Change-Id: I8c2be08791b1e87a59b198c5f145ef3fe0961376
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5528 - Connecting RESTful part to restconf + fix bugs 46/40246/10
Jakub Toth [Mon, 13 Jun 2016 16:05:13 +0000 (18:05 +0200)]
Bug 5528 - Connecting RESTful part to restconf + fix bugs

  *new wrapper for transaction services
  *wrapper for transaction and base services
  *fix bugs
    *fix serializer of YII for create right prefix of namespace

Change-Id: I847eb536d94ff0e1b0c1e34cbb8d7c110b744ac4
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - Subscribing to stream impl 00/40100/12
Jakub Toth [Thu, 9 Jun 2016 09:48:48 +0000 (11:48 +0200)]
Bug 5528 - Subscribing to stream impl

  *preparing dom data broker handler

Change-Id: Id90c13e8ebba1b60237a45808c973ccdf3a8dcda
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - Create stream for DS 55/40055/14
Jakub Toth [Wed, 8 Jun 2016 16:37:16 +0000 (18:37 +0200)]
Bug 5528 - Create stream for DS

Change-Id: I2bdd16302aebd70c8929bbedfa99672358a96c91
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - Streams service impl - prepare impl by interface 28/39928/13
Jakub Toth [Tue, 7 Jun 2016 09:18:05 +0000 (11:18 +0200)]
Bug 5528 - Streams service impl - prepare impl by interface

Change-Id: Ib3d2a755159ee90b2fdafde2aa203f1f5dacbcbd
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - Invoke RPC impl 88/39888/18
Jakub Toth [Mon, 6 Jun 2016 14:00:49 +0000 (16:00 +0200)]
Bug 5528 - Invoke RPC impl

  *create RpcServiceHandler for handling service of rpc
  *create factory of rpc result

Change-Id: I2b2fff5558887e8c6f5e370b36d197dbde271955
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - RPC invoke impl - prepare impl of interface 49/39749/20
Jakub Toth [Thu, 2 Jun 2016 08:26:19 +0000 (10:26 +0200)]
Bug 5528 - RPC invoke impl - prepare impl of interface

Change-Id: I571166124fbe7588f187091976af6b8d6deb6e22
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - Delete data impl 34/39634/23
Jakub Toth [Tue, 31 May 2016 08:41:25 +0000 (10:41 +0200)]
Bug 5528 - Delete data impl

Change-Id: I47955a4f6563c3ae5ab5d5db38823530bf013cba
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - Impl Post data 66/39566/30
Jakub Toth [Sun, 29 May 2016 08:55:37 +0000 (10:55 +0200)]
Bug 5528 - Impl Post data

  *added new constant for post data
  *added location to response factory
  *moved ensureParentsByMerge to common util class of Put and Post

Change-Id: I2d525a1e602170ef41fd332bb8db9dfabd59e188
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - Put data impl 85/39485/29
Jakub Toth [Thu, 26 May 2016 13:50:31 +0000 (15:50 +0200)]
Bug 5528 - Put data impl

  *make FutureCallbackTx more generaly
  *factory for NormalizedNode(READ) and Response(PUT) from Future
  *fix ReadDataTransactionUtil after remake of FutureCallbackTx

Change-Id: Iec2d35271881c7ffe630cdd832510a3f0df7616a
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - Read data impl 64/39464/32
Jakub Toth [Thu, 26 May 2016 08:32:29 +0000 (10:32 +0200)]
Bug 5528 - Read data impl

  *impl RestconfDataService
    *util class for constants
  *wrapper for transaction vars

Change-Id: I61f4662b61ac9cf15535492f31bc896a863ce986
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - Handlers 63/39463/27
Jakub Toth [Thu, 26 May 2016 08:25:57 +0000 (10:25 +0200)]
Bug 5528 - Handlers

  *make handlers immutable
    *DOMMountPointServiceHandler
    *SchemaContextHandler
    *TransactionChainHandler
  *common interface for all handlers
  *fix dependencies of these changes

Change-Id: I4f3a78103036d88a5129f084bd088cd51c5b549c
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - Preparing enviroment for impl of restful services 47/38747/23
Jakub Toth [Thu, 12 May 2016 08:58:35 +0000 (10:58 +0200)]
Bug 5528 - Preparing enviroment for impl of restful services

  * repackeging
  * fixing changes

Change-Id: I2ece0416ed09c3fc3517957427e18673406013de
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5403 - Support yang-library schema resolution 06/40606/3
Jakub Morvay [Tue, 21 Jun 2016 11:23:03 +0000 (13:23 +0200)]
Bug 5403 - Support yang-library schema resolution

Change-Id: I3599d3cf857cbb7b40c17aafadc9db7c83c4b09d
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoMerge "Bug 5526 - Unit testing"
Tomas Cere [Tue, 28 Jun 2016 08:26:12 +0000 (08:26 +0000)]
Merge "Bug 5526 - Unit testing"

7 years agoMerge ".gitignore .factorypath created by m2e-apt"
Tomas Cere [Tue, 28 Jun 2016 08:07:41 +0000 (08:07 +0000)]
Merge ".gitignore .factorypath created by m2e-apt"

7 years agoBug 5526 - Unit testing 14/40914/2
Ivan Hrasko [Tue, 28 Jun 2016 07:42:02 +0000 (09:42 +0200)]
Bug 5526 - Unit testing

Fix for streams service unit testing. Prepare test streams
before tests are run and clean test streams after tests completed.

Change-Id: Ic61b7adcdc8aa48ee54d2f164143152729c6a899
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>