Michael Vorburger [Thu, 16 Mar 2017 11:13:11 +0000 (12:13 +0100)]
Fix broken hashCode & equals in FlowEntity related classes
This in turn then fixes TestIMdsalApiManager assertFlowsInAnyOrder bug.
Change includes new TestIMdsalApiManagerTest non-regression test.
Also includes missing toString() - not directly related, but useful.
Change-Id: I92ec5948a91ecd41eaa75777d44545fc7adc142a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Thu, 16 Mar 2017 10:40:10 +0000 (10:40 +0000)]
Merge "Clean-up of unwanted ERROR logs"
Faseela K [Thu, 16 Mar 2017 09:49:36 +0000 (09:49 +0000)]
Merge "Remove deprecated yang models and rpcs"
Faseela K [Thu, 16 Mar 2017 09:11:18 +0000 (09:11 +0000)]
Merge "Adding API to support bucket addition/deletion"
Michael Vorburger [Wed, 15 Mar 2017 09:38:32 +0000 (10:38 +0100)]
InstructionInfo implementations made valid beans (XtendBeanGenerator)
This is required to unblock the (now) failing *AclServiceImplTest/s in
c/53002. The IllegalStateException seen there were due to the
InstructionInfo implementations not having been valid beans; this caused
XtendBeanGenerator to be unable to get their fields values.
Change-Id: I0549a7faa306afdf8f95908efa3eb561185f81a4
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Wed, 15 Mar 2017 15:38:23 +0000 (15:38 +0000)]
Merge "Spec for Counter Framework bundle"
Faseela K [Wed, 15 Mar 2017 10:57:26 +0000 (16:27 +0530)]
Remove deprecated yang models and rpcs
interface-manager has some yang models which have been
deprecated from Beryllium time-frame, but still not removed
from the yangs.
Change-Id: I6fc72c5fdba62bcdccf5b9c5609e9c2516e9b79d
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Tue, 14 Mar 2017 18:41:25 +0000 (00:11 +0530)]
Clean-up of unwanted ERROR logs
Some of the ERROR logs are coming in the standard call flow, and is
expected to fail, hence making them debugs
Change-Id: I34582bd41a733309eeeb6c442c6671aec77d7151
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Wed, 15 Feb 2017 22:47:30 +0000 (23:47 +0100)]
Fix exception & null handling in AbstractAlivenessProtocolHandler
Change-Id: Iea86daecda9a38d855c76a425d8dbc3675076c68
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Kency Kurian [Tue, 7 Mar 2017 07:33:38 +0000 (13:03 +0530)]
Adding API to support bucket addition/deletion
Introduced new API in mdsal using which we can add or remove a backet from
the group.
With this application need not construct the entire group if it knows the
bucketId.
Have tested and made sure that the groups are getting updated properly
when this API is used.
Change-Id: I5b07da503bb33d39adf7bc4d7cdc53122ce36f03
Signed-off-by: Kency Kurian <kency.kurian@ericsson.com>
Vishal Thapar [Mon, 13 Mar 2017 12:38:49 +0000 (12:38 +0000)]
Merge "Modify ACL table numbers for remote acl indirection"
David [Sun, 12 Mar 2017 18:23:17 +0000 (19:23 +0100)]
Remove unnecessary casts
Remove unnecessary casts in the call to newReleaseId.
Change-Id: If611f52d403c26d4a145edccced3b6d1aff89ded
Signed-off-by: David <david.suarez.fuentes@ericsson.com>
Faseela K [Sat, 11 Mar 2017 09:45:19 +0000 (09:45 +0000)]
Merge "Handling RACE conditions in bind/unbind service"
Michael Vorburger [Wed, 1 Mar 2017 02:11:55 +0000 (03:11 +0100)]
Improve exception message in NWUtil.isIpv4Address(String)
Change-Id: I590ee8c2e23685d7955ad31275d7ff04fb1aa2d8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Tue, 7 Mar 2017 08:24:29 +0000 (13:54 +0530)]
Handling RACE conditions in bind/unbind service
There are race conditions seen while binding/unbinding services,
due to the configlistener and statelistener being executed parallelly.
Avoiding this by adding a new service_binding_entity, and processing
service binding only on the entity owner.
Removing batching of interface-child-info as it is causing issues in
clustered tests
Change-Id: I35ed95fe99878fcbde757cd61880400832b30220
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Vivek Srivastava [Thu, 9 Mar 2017 15:59:39 +0000 (15:59 +0000)]
Merge "Spec to support load balancing and high availability of multiple VxLAN tunnels"
Alon Kochba [Thu, 23 Feb 2017 14:02:32 +0000 (16:02 +0200)]
Modify ACL table numbers for remote acl indirection
Change table numbers of ingress ACL, add another table
to each ACL service and add a metadata match for the
ACL service, in preparation for remote_acl_indirection
changes.
This patch must be merged combined with
https://git.opendaylight.org/gerrit/#/c/52215/
due to changes in ACL tables naming.
Change-Id: I597f705c68f898a2efa03b85182ab28618ffb0f7
Signed-off-by: Alon Kochba <alonko@hpe.com>
Vishal Thapar [Thu, 9 Mar 2017 12:21:03 +0000 (12:21 +0000)]
Merge "Improve scale of AsyncXListenerBase"
Michael Vorburger [Wed, 8 Mar 2017 01:13:46 +0000 (01:13 +0000)]
Merge "Fix (some) unlogged Thread death uncaught exceptions, now logged"
Michael Vorburger [Fri, 17 Feb 2017 20:57:06 +0000 (21:57 +0100)]
Fix (some) unlogged Thread death uncaught exceptions, now logged
see also email list thread "Re: [netvirt-dev] [genius-dev] Exceptions
that don't even reach the log"
This doesn't actually fix any such exceptions, but it makes them get
properly logged, to the logging subsystem, instead of only appear on the
console.
Change-Id: If08408c103dd7a0520fc95ce2da632d67ee9c6a1
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Wed, 8 Mar 2017 00:09:06 +0000 (00:09 +0000)]
Merge "Add missing <name> fields for pom.xml files"
Michael Vorburger [Fri, 17 Feb 2017 19:32:33 +0000 (20:32 +0100)]
AlivenessMonitor final clean-up, remove unneeded dep & service setters
and use constructor for initializing more fields (some already are),
instead of start() method, which prevents use of final fields.
Change-Id: I7a62629ec4c78d00987b03bbd176ac148f676af4
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
David [Thu, 2 Mar 2017 23:33:46 +0000 (00:33 +0100)]
Fix issues related to checkstyle compliance in module mdsalutil-impl
Fix issues related to checkstyle compliance in module
mdsalutil-impl:
- Copyright sections
- Line lengths
- Order imports
- Formatting
- Declaration of constants: name, modifiers
- Rename variables
- Exception catching
- Move declaration of variables closer to their use
- Remove unused variables
- Enforcement in pom.xml
There is more cleanup to be done, apart from checkstyle, I'll rise a
separate commit.
Change-Id: I91848d2ca07e404787489c15040dfa8983594692
Signed-off-by: David <david.suarez.fuentes@ericsson.com>
Faseela K [Mon, 6 Mar 2017 18:04:26 +0000 (18:04 +0000)]
Merge "Bind/Unbind Service should work irrespective of Port Status"
Guy Sela [Wed, 15 Feb 2017 15:35:24 +0000 (17:35 +0200)]
Improve scale of AsyncXListenerBase
Convert single static thread pool for all listeners to thread pool per
listener.
Deprecate the base classes.
Change-Id: I0d86b2c017ed443db3093dc81f124677e1cf0449
Signed-off-by: Guy Sela <guy.sela@hpe.com>
Faseela K [Mon, 6 Mar 2017 07:34:23 +0000 (13:04 +0530)]
Bind/Unbind Service should work irrespective of Port Status
- Removing port status check during bind-service
- Clean up of bind/unbind code path
Change-Id: I7f4cb9749a40325826ce3c8f29b43635f5202151
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Thu, 2 Mar 2017 12:24:51 +0000 (13:24 +0100)]
Fix missing alivenessmonitor-impl-protocols in features.xml
Somehow forgot to uncomment this in c/52020
(
a202894405787214fd9271902af55525b1324f09) - and nobody noticed?! (Not
in code review, and no failing CSIT - our processes are broken...)
Change-Id: Ic47c721c3468619e55cc888c29abcafd259486d8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Vivek Srivastava [Mon, 6 Mar 2017 05:20:44 +0000 (05:20 +0000)]
Merge "Add support for IPv6 VXLAN tunnels"
Faseela K [Sun, 5 Mar 2017 17:27:09 +0000 (17:27 +0000)]
Merge "Enhancing interface-manager logging"
Faseela K [Fri, 3 Mar 2017 19:35:13 +0000 (01:05 +0530)]
Enhancing interface-manager logging
Change-Id: I47fc2341a3a1ba2513de9272b40840433f221e88
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Aswin Suryanarayanan [Thu, 2 Mar 2017 13:34:39 +0000 (19:04 +0530)]
Added set_field action for meta data.
Change-Id: I5e50bf74504c731420a9d762081f644e2d488f79
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Vivek Srivastava [Fri, 3 Mar 2017 11:41:12 +0000 (11:41 +0000)]
Merge "Minor: Clean up fcapsmanager/countermanager POM"
Viji J [Mon, 23 Jan 2017 15:34:47 +0000 (21:04 +0530)]
Spec for Counter Framework bundle
Change-Id: I923908bc901c2aa931294b8748118948b187123f
Signed-off-by: Viji J <viji.j@ericsson.com>
Thanh Ha [Fri, 3 Mar 2017 01:33:53 +0000 (20:33 -0500)]
Add missing <name> fields for pom.xml files
This is used by autorelease scripts to automatically parse which project
is failing a build and report to the mailing list automatically. We need
names in the format:
ODL :: <groupId> :: <artifactId>
This patch formats in the same format as found in the startup archetypes
patch found here: https://git.opendaylight.org/gerrit/52522
Change-Id: I8874717d4c30d835ef1233344148a558401aed88
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Michael Vorburger [Thu, 2 Mar 2017 15:26:52 +0000 (15:26 +0000)]
Merge "TestIMdsalApiManager assertFlowsInAnyOrder LOG.warn"
Edwin Anthony [Thu, 23 Feb 2017 11:11:21 +0000 (16:41 +0530)]
Interfacemanager blueprint migration
Change-Id: I4b3f7ea54ef290546a4e7e031a0f3b5b3023c7aa
Signed-off-by: Edwin Anthony <n.edwin.anthony@ericsson.com>
Signed-off-by: Sam Hague <shague@redhat.com>
David [Wed, 22 Feb 2017 17:39:59 +0000 (18:39 +0100)]
Migrate mdsalutil-impl module to blueprint
Second approach (first one was [1]) to migrate the module
mdsalutil-impl to blueprint after the patch [2] that breaks some cyclic
dependencies.
[1] https://git.opendaylight.org/gerrit/#/c/48317/
[2] https://git.opendaylight.org/gerrit/#/c/52020/
I couldn't manage to get it pass the SFT locally, but I want you to
review it so that I can get a clue on how to progress it. I tried to
make as few as possible changes (it is not checkstyle compliant, etc.)
to keep it focused.
Change-Id: Ib83ce98bde9d113f6be02ae72e0ea55d17740f3c
Signed-off-by: David <david.suarez.fuentes@ericsson.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Faseela K [Wed, 1 Mar 2017 16:43:23 +0000 (16:43 +0000)]
Merge "Adding job retries for DJC bind/unbind service jobs"
Tali [Sun, 22 Jan 2017 17:38:36 +0000 (19:38 +0200)]
Spec to support load balancing and high availability of multiple VxLAN tunnels
Change-Id: Id608d4007a7be8419380314f27c40f8f8ff06ecb
Signed-off-by: Tali <tali.ben-meir@hpe.com>
Michael Vorburger [Wed, 1 Mar 2017 11:56:08 +0000 (12:56 +0100)]
TestIMdsalApiManager assertFlowsInAnyOrder LOG.warn
based on the discussion in
https://git.opendaylight.org/gerrit/#/c/50467/
Change-Id: Iefe24270d1861e2eddc12bdec577cb14591f429f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Wed, 1 Mar 2017 07:41:32 +0000 (13:11 +0530)]
Adding job retries for DJC bind/unbind service jobs
Change-Id: Id581cd6b1186287a380ce4432f3326c51475527b
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Tue, 28 Feb 2017 23:13:22 +0000 (00:13 +0100)]
Minor: Clean up fcapsmanager/countermanager POM
We should not be using this old outdated version of maven-bundle-plugin
here, but the one that odlparent provides.
Ran into this while testing Bug 7182 (but it's not directly related to
that), where I hit this problem in the Eclipse IDE:
Manifest org.opendaylight.genius:countermanager:bundle:0.2.0-SNAPSHOT :
Input file does not exist: target/classes/LICENSE
org.apache.maven.plugin.MojoExecutionException: Error(s) found in
manifest configuration
Change-Id: Ie67a1e8314e901b31e1908eacb1f611b9b671e41
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Tue, 28 Feb 2017 22:45:03 +0000 (23:45 +0100)]
Bug 7182 related: Remove M2E lifecycle mapping
These should never be in individual projects anymore now, we handle this
centrally, either in odlparent, or
https://github.com/vorburger/opendaylight-eclipse-setup, or by
appropriate lifecycle-mapping-metadata.xml in a Maven plugin (that's
what Bug 7182 does for the yang-maven-plugin; this removes what makes
that not work for these projects).
Change-Id: I91b37c2e4c729bc7253eb6fedbbc281d25892642
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Miguel Perez [Thu, 26 Jan 2017 14:05:01 +0000 (15:05 +0100)]
Make 'bindService' transaction-embeddable
Change-Id: I3608e43991a9b00a021f3f49f9c4413567d17acc
Signed-off-by: Miguel Perez <francisco.miguel.perez@ericsson.com>
Michael Vorburger [Mon, 27 Feb 2017 11:55:35 +0000 (12:55 +0100)]
Remove try { } finally { LOG.error } introduced in previous commit
In
29ede9a79082ff38b5de705d9b1e8e779edf4f23, David turned a try {} catch
(Exception e) { LOG.error(e) } into a finally { LOG.error }, which to me
seems wrong - as-is now, it would ALWAYS LOG.error, wouldn't it? So
best to just remove this finally.
This looks like a bigger change than it is because indention changed.
(I've not touched anything in that big block, just un-indent'ed it.)
Change-Id: I25c3479e3939ed54b1ec35a031e6c6f4c7f5514a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Miguel Perez [Thu, 26 Jan 2017 14:48:17 +0000 (15:48 +0100)]
Add API methods to check if service is bound on iface
Change-Id: I21ed6d2e5871be3c91a5f874f384f21045698196
Signed-off-by: Miguel Perez <francisco.miguel.perez@ericsson.com>
Yakir Dorani [Thu, 15 Dec 2016 14:44:36 +0000 (16:44 +0200)]
Add support for IPv6 VXLAN tunnels
Description: IPv6 tunnels are supported since OVS 2.6
Change-Id: I10dbecc145c9ec8ff76115a34c9824827fd22c28
Signed-off-by: Yakir Dorani <yakir.dorani@hpe.com>
Tarun Thakur [Wed, 11 Jan 2017 16:14:50 +0000 (21:44 +0530)]
Use def-tz-enabled and of-tunnel for TEP addition
1) Using def-tz-enabled config flag while adding TEP under default-transport-zone.
2) Added support to configure of-tunnel as TEP parameter from southbound and
use of-tunnel flag while adding TEP under transport-zone or tepsNotHostedInTransportZone.
Change-Id: I894bef7500bd72836f2020ac320e40ea7329c470
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>
Faseela K [Thu, 23 Feb 2017 18:15:22 +0000 (18:15 +0000)]
Merge "Remove an unnecessary augmentation"
David [Wed, 22 Feb 2017 12:39:31 +0000 (13:39 +0100)]
Fix some problems introduced after checkstyle enforcement
ResourceBatchingManager violates some checkstyle rules. It should fix
the compilation problems.
Change-Id: I9516a85b58188e4708e73152f988ea24f5d44f41
Signed-off-by: David <david.suarez.fuentes@ericsson.com>
Faseela K [Wed, 22 Feb 2017 09:33:00 +0000 (09:33 +0000)]
Merge "Bug 7599 hwvtep ucast mac consumption performance"
Faseela K [Wed, 22 Feb 2017 06:16:24 +0000 (06:16 +0000)]
Merge "BUG-7758: Fix creation of FLAT and VLAN networks with the same parent"
Faseela K [Tue, 21 Feb 2017 08:52:17 +0000 (14:22 +0530)]
Remove @Deprecated from interface-manager APIs
Initially GENIUS was planning to move away from API models
to promote the usage of RPCs. However, given the various benefits of
using APIs, removing the Deprecated tags.
Change-Id: Ibbbf60632ede1a324a80d67a35302f84e8aa33d7
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Fri, 17 Feb 2017 18:48:27 +0000 (19:48 +0100)]
Intro. alivenessmonitor-impl-protocols to break cyclic dependency
This change makes alivenessmonitor-impl not be dependent on
interfacemanager-api anymore, by refactoring the protocol handlers
(which are somewhat orthogonal) into a separate bundle, thus breaking a
cyclic dependency which caused issues in the BP migration (c/49175).
The real problem actually wasn't the compile time dependency of
alivenessmonitor-impl to interfacemanager-api, but the (implicit)
blueprint DI dependency to interfacemanager-impl (which itself requires
alivenessmonitor); but this solves this, because now
(only) interfacemanager-impl can depend on alivenessmonitor, and the 3rd
new
bundle alivenessmonitor-impl-protocols depends on both.
Change-Id: I4fe98dbf55e727d6704b216c5fea304e336babb2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Tue, 31 Jan 2017 17:58:54 +0000 (23:28 +0530)]
Design spec for Service Binding On Tunnels
Change-Id: Icb3747badf76cd93df22bcb6db3dd546fcc089ee
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Edwin Anthony [Thu, 16 Feb 2017 15:10:40 +0000 (20:40 +0530)]
Interfacemanager-api : Checkstyle Enforcement
Change-Id: I89250d986237ee75bb87ce99c4066c9f5e87d602
Signed-off-by: Edwin Anthony <n.edwin.anthony@ericsson.com>
Faseela K [Fri, 17 Feb 2017 06:31:10 +0000 (06:31 +0000)]
Merge "Genius support for Trunks"
Sam Hague [Fri, 17 Feb 2017 01:47:53 +0000 (01:47 +0000)]
Merge "Nat Action added in ActionNxConntrack"
Michael Vorburger [Wed, 15 Feb 2017 22:39:37 +0000 (23:39 +0100)]
minor AlivenessMonitorUtil clean-up incl. removal of 2 unused methods
Change-Id: Ia11625018060033ebfeef7b0a99bad28d0026eb2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 16 Feb 2017 16:05:05 +0000 (16:05 +0000)]
Merge "MdSalUtilTest no longer extends @deprecated AbstractDataBrokerTest"
Vivek Srivastava [Thu, 16 Feb 2017 15:56:33 +0000 (15:56 +0000)]
Merge "Fix issues related to checkstyle compliance"
Michael Vorburger [Thu, 16 Feb 2017 15:53:58 +0000 (15:53 +0000)]
Merge "alivenessmonitor-impl reduce dependency to interfacemanager-api"
Michael Vorburger [Thu, 16 Feb 2017 15:50:40 +0000 (15:50 +0000)]
Merge "Change ITMManagerRpcservice Test frm Mock to Guice"
Michael Vorburger [Thu, 16 Feb 2017 15:49:46 +0000 (15:49 +0000)]
Merge "Fix issues related to checkstyle compliance"
Aswin Suryanarayanan [Wed, 21 Dec 2016 09:25:51 +0000 (14:55 +0530)]
Nat Action added in ActionNxConntrack
Change-Id: Id9c112e2490bd98192ef003d28c2065476c28c09
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Michael Vorburger [Wed, 15 Feb 2017 20:20:59 +0000 (21:20 +0100)]
alivenessmonitor-impl AlivenessProtocolHandlerLLDP dead code removed
I obviously have no idea what this code really does, but something looks
very wrong in this handlePacketIn() method .. all of that code does
NOTHING, literally (dead code). -- Can this entire class be removed?
Change-Id: I181c82acff2af6e80953a1554f35d33fc86b5465
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Tarun Thakur [Tue, 14 Feb 2017 07:31:05 +0000 (13:01 +0530)]
Change ITMManagerRpcservice Test frm Mock to Guice
ITM RPC service Test cases are re-written in Guice framework.
Change-Id: I8a2f8a5bee35c9e5edc74292eeb1f1d75cc5056c
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>
David [Thu, 16 Feb 2017 00:27:09 +0000 (01:27 +0100)]
Fix issues related to checkstyle compliance
Fix issues related to checkstyle compliance in module
fcapsapplication-impl:
- Copyright sections
- Line lengths
- Order imports
- Declaration of constants: name, modifiers
- Formatting
- Exception catching
- Change name of variables
- Checkstyle enforcement activated
Change-Id: I342fae60e3be3addad147a08d309a743dec37f95
Signed-off-by: David <david.suarez.fuentes@ericsson.com>
Faseela K [Thu, 16 Feb 2017 09:15:36 +0000 (09:15 +0000)]
Merge "ITM Auto-config: Change other_config to ExternalId"
Michael Vorburger [Wed, 15 Feb 2017 20:11:22 +0000 (21:11 +0100)]
alivenessmonitor-impl reduce dependency to interfacemanager-api
All code removed here is completely dead code, this should be low risk.
BTW: Now only AlivenessProtocolHandlerARP still needs interfacemanager
API.. if that could be removed as well, then we could resolve the cyclic
dependency that is causing us pain... could it refactored?
Change-Id: Idba767b1f59cc255d59f5d1751983a9a2d48620e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Thu, 16 Feb 2017 07:36:01 +0000 (13:06 +0530)]
interfacemanager-shell : Checkstyle Enforcement
Change-Id: I406a957160481b2463d2c88d705d67d2360939cf
Signed-off-by: Faseela K <faseela.k@ericsson.com>
David [Wed, 15 Feb 2017 18:55:02 +0000 (19:55 +0100)]
Fix issues related to checkstyle compliance
Fix issues related to checkstyle compliance in module
fcapsappjmx:
- Copyright sections
- Line lengths
- Order imports
- Declaration of constants: name, modifiers
- Formatting
- Checkstyle enforcement activated
Change-Id: If4e6131025190ba4c38504053273f7114a3bbc09
Signed-off-by: David <david.suarez.fuentes@ericsson.com>
Michael Vorburger [Wed, 15 Feb 2017 20:35:17 +0000 (20:35 +0000)]
Merge "Revert I466b2489107172ad7f391ba6b50c4dce9f08343d"
Miguel Duarte [Wed, 15 Feb 2017 14:15:02 +0000 (15:15 +0100)]
Remove an unnecessary augmentation
The Ovsdb node was being augmented twice - in ItmUtils, and in
OvsdbNodeListener.
With this small change, it is only augmented once in OvsdbNodeListener,
then passed as a parameter into the ItmUtils.
Change-Id: I933fc794c25573371262df746309f215d9706ba5
Signed-off-by: Miguel Duarte <miguel.duarte.de.mora.barroso@ericsson.com>
Tarun Thakur [Wed, 11 Jan 2017 09:37:10 +0000 (15:07 +0530)]
ITM Auto-config: Change other_config to ExternalId
Change TEP fields configuration from other_config to external_ids.
Parse TEP params from external_ids list of ovsdb node, and then use it
for add/update/delete TEP in ITM Config DS.
Change-Id: I29f2a7aabb12ac97b896956f931e6d8fba89df83
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>
Faseela K [Sun, 12 Feb 2017 09:46:40 +0000 (15:16 +0530)]
Tunnels in DOWN state in scaled scenario
In a scaled environment, some of the tunnels remain in DOWN
state after ITM full mesh creation. This is due to a race condition
when openflow port add and bfd port status messages are processed
out of order. Making the code more robust against such races.
Change-Id: Ic239c15605c2e446aa8a465b09508cfcc0b18eb0
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Tue, 14 Feb 2017 16:05:43 +0000 (16:05 +0000)]
Merge "Prepare Karaf 4 migration: move old features"
Faseela K [Tue, 14 Feb 2017 10:37:37 +0000 (16:07 +0530)]
Revert I466b2489107172ad7f391ba6b50c4dce9f08343d
Reverting the temporary work around as part of
Bug 7538 InterfaceManagerTestModule temporary local work-around
Change-Id: I976934978d2d3ddd69052b449d623aa6f1fc527c
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Tue, 14 Feb 2017 10:19:30 +0000 (10:19 +0000)]
Merge "Remove specific version for maven-bundle-plugin"
Stephen Kitt [Tue, 24 Jan 2017 09:17:30 +0000 (10:17 +0100)]
Prepare Karaf 4 migration: move old features
This sets the stage for the Karaf 4 migration (which needs dluxapps,
ovsdb and openflowplugin first, on top of patches which are already in
progress for yangtools, mdsal, controller, infrautils and netconf).
Bug: 7623
Change-Id: Icf20f546c6a65870a07b546c3fb945c1fca303b4
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Tue, 14 Feb 2017 07:31:17 +0000 (07:31 +0000)]
Merge "Checkstyle enforcement - idmanager-shell"
David Suarez [Fri, 10 Feb 2017 00:05:22 +0000 (01:05 +0100)]
Remove specific version for maven-bundle-plugin
Remove specific version for maven-bundle-plugin to avoid problems like:
https://bugs.opendaylight.org/show_bug.cgi?id=7537
Change-Id: I7997ef221ab16e7fe4a6c422f5886587e66d0e06
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Vishal Thapar [Sat, 11 Feb 2017 14:17:54 +0000 (19:47 +0530)]
Genius support for Trunks
Trunk Port API adds certain use cases which are currently not supported in
InterfaceManager. These include but not restricted to:
1. Interface membership will not be known at creation but come as an
upate later. There is no means to know at creation if it will become a
trunk member later or not.
2. Trunk member interfaces will not have any termination point, so
parentRefs will never be updated from southbound event. Trunk members will
add parentRefs through an interface update.
3. Trunk member interface can go from member to trunk if it is removed
from a trunk as subport.
4. Trunk member interface's parentRefs can be removed if it is removd from
a trunk as subport.
This means IFM now needs to support use cases where if2Vlan and parentRef
augmentations of an interface can change dynamically.
Related gerrits:
https://git.opendaylight.org/gerrit/#/q/topic:vlan-aware-vms
Change-Id: Ie240c1307547cce17463e2ff16a223aa72807d4c
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Michael Vorburger [Mon, 13 Feb 2017 16:27:45 +0000 (17:27 +0100)]
mdsalutil-api clean up Checkstyle now enforced
Change-Id: I758925b0d5bd30bafd6b117c09f3575a52dab320
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Mon, 6 Feb 2017 23:26:07 +0000 (00:26 +0100)]
MdSalUtilTest no longer extends @deprecated AbstractDataBrokerTest
use new AbstractConcurrentDataBrokerTest instead - and fix MDSALManager
Bug: 7538
Change-Id: Iaad38472581f7271f894650f255bda0c6a48aae8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Mon, 13 Feb 2017 09:28:51 +0000 (09:28 +0000)]
Merge "Fix NPE in ITM endpoint list usage"
Alon Kochba [Sun, 12 Feb 2017 16:00:03 +0000 (18:00 +0200)]
Fix NPE in ITM endpoint list usage
This NPE is popping up in CSIT , while deleting all
transport zones and interfaces via REST API.
Change-Id: Iea4c162519a0dbfe9bb6f926e6c9895fffdab02e
Signed-off-by: Alon Kochba <alonko@hpe.com>
Hema Gopalkrishnan [Sat, 3 Dec 2016 03:23:11 +0000 (08:53 +0530)]
Bug 6952: Support for deleting TEPs in multiple TZ
Resolved merge conflict
Removed commented lines
Change-Id: Ib25a95242cbc96af0e0087f524630dd42ea4f669
Signed-off-by: Hema Gopalkrishnan <hema.gopalkrishnan@ericsson.com>
Faseela K [Sun, 12 Feb 2017 01:15:07 +0000 (01:15 +0000)]
Merge "fix for id duplication for different id keys"
Faseela K [Sat, 11 Feb 2017 05:19:19 +0000 (05:19 +0000)]
Merge "Blueprint XML Config support in ITM."
Faseela K [Fri, 10 Feb 2017 18:32:16 +0000 (00:02 +0530)]
Checkstyle enforcement - idmanager-shell
Change-Id: I5c43b3c5f4de7b52198b6d19b2859eb6c044171c
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Wed, 8 Feb 2017 18:51:55 +0000 (00:21 +0530)]
getInterfaceInfoFromOperationalDS Optimisation
vxlan:show CLI was getting stuck in one of the cluster nodes
in a scaled scenario of full mesh creation due to a datastore
reads in the call flow
Change-Id: Iab43b5c2d6eea3d77351658fe44e5f41d793b30d
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Periyasamy Palanisamy [Fri, 10 Feb 2017 11:56:50 +0000 (17:26 +0530)]
fix for id duplication for different id keys
* handling id pool listener appropriately otherwise it overwrites local pool
which lead to allocation of same id to different key
Change-Id: Ibc075846a7daa07e681ce2b34dfaabf084e7d287
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>
Faseela K [Fri, 10 Feb 2017 05:56:20 +0000 (05:56 +0000)]
Merge "Optimizing southbound Tunnel Events"
Michael Vorburger [Thu, 9 Feb 2017 15:26:36 +0000 (15:26 +0000)]
Merge "Enforce checkstyle in arputil-impl module"
Michael Vorburger [Mon, 19 Dec 2016 15:11:32 +0000 (16:11 +0100)]
Add missing JavaDoc to ResourceBatchingManager
copy/pasted, with minor adjustments for clarity, from a review comment
by Vivekanandan Narasimhan in
https://git.opendaylight.org/gerrit/#/c/49491/
Change-Id: I02d513e594e17379b62ddb1a2226da3d4f3f6b8f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Edwin Anthony [Thu, 9 Feb 2017 07:46:52 +0000 (13:16 +0530)]
To fix grep not working for tep:show &
tep:show-state on karaf console
Change-Id: I59469c0c1da10d55c2bd5d1a9f87e3021c8a46cf
Signed-off-by: Edwin Anthony <n.edwin.anthony@ericsson.com>
Faseela K [Fri, 3 Feb 2017 19:21:09 +0000 (00:51 +0530)]
Optimizing southbound Tunnel Events
When a tunnel is created on OVS, there are a series of events triggered
from plugins(OVSDB and OpenFlow) based on which interface-manager does a
sequence of operations. The code is optimised to batch all these
transactions so that there will be faster programming of Table 0 flows,
and interface-state operational DS population in a scaled scenario.
Change-Id: Ie8140f59b44985c394d6d7ac37348733ba946a42
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Wed, 8 Feb 2017 18:53:02 +0000 (19:53 +0100)]
Bug 7538 InterfaceManagerTestModule temporary local work-around
until https://git.opendaylight.org/gerrit/#/c/51486/ finally goes in
upstream in controller ... then this will have to be reverted again.
Change-Id: I466b2489107172ad7f391ba6b50c4dce9f08343d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Alon Kochba [Wed, 8 Feb 2017 15:14:05 +0000 (17:14 +0200)]
BUG-7758: Fix creation of FLAT and VLAN networks with the same parent
Change-Id: Ia0e08c3ef22de39769c6f81e978060501107a0c2
Signed-off-by: Alon Kochba <alonko@hpe.com>