Thanh Ha [Mon, 30 Oct 2017 20:53:42 +0000 (16:53 -0400)]
Remove deploy-site.xml
With the javadoc jobs now available to generate javadoc it is time to
remove the maven-sites and related files.
Change-Id: I27ab85cca6733c8ebe6a5a95c9c4b675789c9454
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Claudio D. Gasparini [Sat, 28 Oct 2017 21:13:13 +0000 (23:13 +0200)]
Use bulk operation
Change-Id: Id8da3f1394551ec6c879bfab847fdd93fda3e0a1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 28 Oct 2017 20:50:01 +0000 (22:50 +0200)]
Migrate Jave 5 Stringbuffer
Change-Id: I57a2e07fa111dc6cf87d5920cf388169f4fe41e3
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 28 Oct 2017 20:49:24 +0000 (22:49 +0200)]
Remove unnecesary boxing
Change-Id: I48a32e366ab320a31b868bb9af8e11014bf1aa12
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 28 Oct 2017 20:47:24 +0000 (22:47 +0200)]
Fix missing version for maven reports
Change-Id: I45f229b90731d22d1099d38c690b2e6bb8ad5763
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 25 Oct 2017 12:20:01 +0000 (14:20 +0200)]
Create pcep topology parent aggregator
Change-Id: I3fbf0eb152ba84da138881f1080eb7b65d15469c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Kevin Wang [Wed, 30 Aug 2017 22:46:39 +0000 (15:46 -0700)]
BUG-9079 Make PCEP session recoverable from exception
This patch makes PCEP session recoverable from any netty exception.
Whenever an exception happens, PCEP session will be closed. So it
will be at a clean state when the next session retry comes.
Change-Id: I38a983c44519fd5c12cb9cd0da09fa14c4177ac7
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Claudio D. Gasparini [Fri, 13 Oct 2017 13:01:30 +0000 (15:01 +0200)]
BUG-9192 / BUG-9191
Enforce that each bundle under bgp is part of exactly one
feature by introducing new topology-api and concepts features.
Change-Id: Ifc6898b7154ba3451f1af7cfeba638c90c3c7a31
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 27 Aug 2017 11:23:31 +0000 (13:23 +0200)]
Remove table type deprecated model
Change-Id: Ic08f591d2952a5cc839aac48677323edb1bca31d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 27 Aug 2017 10:42:55 +0000 (12:42 +0200)]
Remove addpathcapability deprecated model
Change-Id: Ifd17ee8a8374c85fba978666295c0520ca5b7047
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 26 Aug 2017 23:00:06 +0000 (01:00 +0200)]
Remove deprecated binding type / value models
Change-Id: I1afd5a57f34f8531574578ed007d7fcaf7ffd0d8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Ajay Lele [Fri, 22 Sep 2017 21:53:10 +0000 (14:53 -0700)]
Bug 9205: NPE received while receiving BGP peers
Change-Id: I05383a406b03e5dc460e5ae013da82280920981e
Signed-off-by: Ajay Lele <ajayslele@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Mon, 9 Oct 2017 12:31:14 +0000 (14:31 +0200)]
BUG-9218: eliminate duplicate bundles
Packaging api bundles in multiple features causes inefficiency
in Karaf4. Introduce org-bgpcep-{bmp,rsvp,bgp-parser}-api
features to hold them.
Change-Id: I6351c945bbf3e272187dcd875854bff40c9b4f11
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Yrineu Rodrigues [Thu, 7 Sep 2017 21:08:12 +0000 (18:08 -0300)]
BUG-8929: NPE during singleton startup
Avoid NPE when installing features 'odl-bgpcep-bgp-api' and
'odl-bgpcep-bgp-impl' individually
Change-Id: Id651dff7c813544bd07a03b435069de5e723721d
Signed-off-by: Yrineu Rodrigues <yrineu.rodrigues@serro.com>
Claudio D. Gasparini [Mon, 4 Sep 2017 11:02:48 +0000 (13:02 +0200)]
BUG-8987: Print Exception when Css registration fails
Change-Id: I34236ac8546358fe3c00985fbbf40f69aa0bef19
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Stephen Kitt [Wed, 27 Sep 2017 13:36:39 +0000 (15:36 +0200)]
Bump odlparent 2.0.4 to 2.0.5
Change-Id: I0764041e6638fb24bc73deba3d158c265669ed66
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Anil Belur [Fri, 29 Sep 2017 02:34:21 +0000 (12:34 +1000)]
Bump bgpcep to use yangtools 1.2.0
Jira: releng-485
Change-Id: I322b6c2595c75b61a829a74dc5ebfdd12784f1c7
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Claudio D. Gasparini [Sat, 26 Aug 2017 22:07:27 +0000 (00:07 +0200)]
remove RD and Distinguisher deprecated models
Change-Id: I57d9073358b0284d9a7cef2463f05406a9653b24
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 11 Sep 2017 09:57:07 +0000 (11:57 +0200)]
BUG-9141: Fix Stateful07TopologySessionListener failing test
Some of the timers are rounding down, which is ending
on some statistics results in 0, when we have better
performance than expected. Update the code to round up.
Use LongAdder instead of long for counters
Change-Id: I958f1c252ba94f8cd392979fe469555aee3f8d48
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 26 Aug 2017 22:04:16 +0000 (00:04 +0200)]
Migrate if to switch statement
Change-Id: Iacd0e96cd33884da88ce443f9a6f04e438996c7e
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 26 Aug 2017 22:03:00 +0000 (00:03 +0200)]
Migrate iterables to java 8
Change-Id: I8cb6a37d1bc961c27b87b4fcb62ec93620288759
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 25 Aug 2017 11:28:57 +0000 (13:28 +0200)]
remove unnecesary boxing / unboxing
Change-Id: Ia0600f1684cb122bd41b2b0bb056ac60f50593c6
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Mon, 4 Sep 2017 11:52:35 +0000 (13:52 +0200)]
Adjust for mdsal-binding-dom-codec movement
The codec is moveing its package, adjust for that. Also migrate
to using mdsal infra instead of controller, where possible.
Change-Id: I89306996d0a80908176c2918c1bff5f04e7bcad8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Mon, 4 Sep 2017 16:02:56 +0000 (18:02 +0200)]
BUG-8987: check for null keys
Keys can be passed down as null, hence we need to check for this
happening.
Change-Id: I67018107b0925244f32b0cde6d8b53605594d521
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 4 Sep 2017 11:43:46 +0000 (13:43 +0200)]
Migrate to using mdsal binding codec APIs
yangtools.binding.codec is deprected, migrate away from it.
Change-Id: Id11820a63bed195cd71578c9b92c7b29a642a844
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Fri, 25 Aug 2017 10:09:58 +0000 (12:09 +0200)]
Remove redundant cast
Change-Id: I8bb65db4621c817df641e8ed5c3a63b57d4b3f9c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 25 Aug 2017 10:00:31 +0000 (12:00 +0200)]
Remove unnecesary imports
Change-Id: Ib51f90fae97a00962ebe44989b8c134546fada96
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 25 Aug 2017 09:59:53 +0000 (11:59 +0200)]
Remove unnecesary interface modifiers
Change-Id: I4d55d622e5f8431f0ee7d5650025b0a1bfd448dc
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 25 Aug 2017 09:58:43 +0000 (11:58 +0200)]
Fix wrong return of null when it should be optional
Change-Id: Iaa90b7dea002ea24da40973cab9d3a18e6955a1b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Vratko Polak [Fri, 25 Aug 2017 08:17:25 +0000 (10:17 +0200)]
Bug 9046: Bring back data change counter feature
Tests which rely on data change counter do not work without this.
Change-Id: I0a82674c50887f7282cc6ed7a6a54573da73d637
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Ajay Lele [Thu, 10 Aug 2017 21:49:50 +0000 (14:49 -0700)]
Bug-8942: Fix DelegatedLspsCount
mbean value returns count of all LSPs and not just
the ones that are delegated
- Fixed code to return count of delegated LSPs only
- Added unit-test
Change-Id: I067b4cff8c7503fa878742ab6605fca2685a6c15
Signed-off-by: Ajay Lele <ajayl.bro@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 9 Aug 2017 08:04:54 +0000 (10:04 +0200)]
enforce check-style for rsvp impl
Change-Id: I50a5540b58bcffe0c60687a5b37474f2ac27656f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 21 Aug 2017 07:40:08 +0000 (09:40 +0200)]
Replace Preconditions.CheckNotNull per RequireNonNull
Change-Id: I41b155a876cdb10911ea28a31fe4040f5fe1bd53
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Dana Kutenicsova [Sun, 6 Aug 2017 10:18:35 +0000 (12:18 +0200)]
BUG-8156 : conflicting listener fix
In case another session listener is in conflict
with the existing one, close the new listener.
Change-Id: I1a594c3876eb1d28133dcc08b31f38deb5ceb27a
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Dana Kutenicsova [Sun, 6 Aug 2017 08:53:58 +0000 (10:53 +0200)]
BUG-8156 : fixed start of session manager
Upon restart of session manager, its close flag was never
set to false, causing pcep sessions to be rejected as they
rely on this value.
Change-Id: I676ea5774cea4cbbee84222d2ad562bea70e83f3
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Dana Kutenicsova [Sat, 5 Aug 2017 23:00:49 +0000 (01:00 +0200)]
BUG-8156 : duplicate session up fixed
In case of session up twice, the second session gets
deleted from pcep and controller.
Change-Id: I25894bcbc0cc9e7a2d7759278244e4d93553122d
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Claudio D. Gasparini [Mon, 7 Aug 2017 14:56:00 +0000 (16:56 +0200)]
Enforce checkstyle for rsvp api/spi
Change-Id: I7ceb91c1eaf1a1b3fb583eec31f08f5a497e4c8a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 13 Aug 2017 20:54:08 +0000 (22:54 +0200)]
Enforce check-style under rsvp spi tests
Change-Id: If52a4ab3a18c3618009127cd14ac7f3fa53a09dd
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 13 Aug 2017 20:55:14 +0000 (22:55 +0200)]
Enforche check-stile under rsvp api
Change-Id: I4bdd959b3c27353bc945e6c9282a948c97afaaa7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Thanh Ha [Mon, 14 Aug 2017 17:15:46 +0000 (13:15 -0400)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: I75484ae00ea56a89a168cc408714ca4dd898eb49
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Stephen Kitt [Tue, 8 Aug 2017 16:14:19 +0000 (18:14 +0200)]
Bump odlparent 2.0.2 to 2.0.4
Change-Id: Ieee18f9e069a0d9eb6ca8cc9e12237654d958105
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Claudio D. Gasparini [Sat, 6 May 2017 18:37:21 +0000 (20:37 +0200)]
BUG-8335: Adjust instantiation
The hanging issue stems from the use of a blocking dispatch for DTCL,
which means we are calling into user code while holding listener
registration lock. This does not happen in production environment.
This patch adds an explicit test for this scenario and migrates
the hanging test to call properly initialize its base class.
Also cleans up warnings in the implementation, as it has not seen much
love lately.
Change-Id: I6c424acfad87244c7a23b013ea91da543ecf72a8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Mon, 7 Aug 2017 11:48:17 +0000 (13:48 +0200)]
Clean up
- Migrate Futures.addCallback
- Move test to shorter package
Change-Id: I7c5f8f9743cd7220414d68d043ca912261edec4d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Sat, 5 Aug 2017 22:36:33 +0000 (00:36 +0200)]
Cleanup eclipse warnings
- static methods
- deprecated classes
- raw types
- unneded version declarations
Change-Id: Ibfe2f1f3203ebca416d8badd1f149d669ddc2415
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 4 Aug 2017 22:03:38 +0000 (00:03 +0200)]
Enforce no split packages
This patch augments Export-Packages with a directive to fail build
if a split package is detected.
Change-Id: I52a2a157f992cb97fd8c6a88cf45c933ed0fd953
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 4 Aug 2017 21:18:26 +0000 (23:18 +0200)]
BUG-8722: fix regression introduced by BUG-5876
Change I707914f3ab0786c0ad8ba71a5476b3b7e322b0cd regressed
bgp-rib-impl packaging such that it massively over-included
classes, leading to split package.
This patch fixes that regression.
Change-Id: I6366972b88e3881675c3dd70517fc4e95c050261
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Fri, 7 Jul 2017 07:28:56 +0000 (09:28 +0200)]
Re add features-bgpcep-extra to integration test
Change-Id: Ic61d66e420f5281dbde1a836b5adbc1ba78be777
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 11 Jul 2017 21:09:15 +0000 (23:09 +0200)]
Remove deprecated CSS Topology provider configuration
replaced by openconfig configuration
Change-Id: I569f75217302e3867a2106065ca9936981a4a126
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 19 May 2017 10:51:57 +0000 (12:51 +0200)]
BUG-6978: Integrate BMP collector with Cluster Singleton Service
Implement bmp HA by introducing CSS to BmpMonitoringStation
Change-Id: I657c367c33fc6b1946c3db19a71725a78917925a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Igor Foltin [Wed, 21 Jun 2017 09:06:24 +0000 (11:06 +0200)]
Bug 8675: Follow-up fix to new XML parser change in yangtools
Behaviour of the new XML parser in yangtools project needs
to be changed a bit so that RESTCONF/NETCONF projects can be
migrated to the new parser. However, these changes break some
parts of BGPCEP which have already been using it.
This patch provides a fix for the issue and should be merged
right after the following yangtools patch goes in:
https://git.opendaylight.org/gerrit/#/c/59036/
Change-Id: I23a5677e31b01fee7f67c8a5eb6b4081bd976f8b
Signed-off-by: Igor Foltin <igor.foltin@pantheon.tech>
Robert Varga [Sat, 15 Jul 2017 12:42:14 +0000 (14:42 +0200)]
Move tests to base package
Test FQCN is used by surefire to generate a report file, which has
limits on its length, causing problems with archival.
Move these tests to base model package to keep the file name short.
Change-Id: I90a49004c235590c87cb331e7cd31f693b3cd6d1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sun, 9 Jul 2017 17:16:08 +0000 (19:16 +0200)]
Bump odlparent to 2.0.2
Automated bump to latest release.
Change-Id: Ib8ecc4751f93c75f93262fa42d43566b0d6094d2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
matcauf [Fri, 9 Jun 2017 21:10:03 +0000 (17:10 -0400)]
Bug 8667 - PCEP: When peer closes got IO exception
When peer closes the pcep session, it results on IO
Exception.
it is due to this close is not recognized as local pcep
PCEP session termination.
It was first implemented as a local pcep session
termination.
https://git.opendaylight.org/gerrit/#/c/906/1/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/PCEPSessionImpl.java
Solution: Use the reason encapsulated in the close message to close the session.
Change-Id: Ia423f5c10b117ef21af5a3bddc28652ebb659e26
Signed-off-by: matcauf <mcauffiez@inocybe.ca>
Thanh Ha [Thu, 6 Jul 2017 01:32:19 +0000 (21:32 -0400)]
Remove missing dependency features-extras
This appears to have been removed via
I6db5b40c398fbe5e7cb4077d2c2a321a0286fab0
Change-Id: I161964a0ed1d7e52a8a5d6a7dd28f771de2b29b2
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Dana Kutenicsova [Tue, 25 Apr 2017 15:21:17 +0000 (17:21 +0200)]
BUG-7027 : Remove Data change counter CSS configuration
since is not longer need it. New configuration is done via REST.
Change-Id: I32c3ffcfa66108d72dd8033e44b1cbd7596537eb
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 30 Jun 2017 06:01:08 +0000 (08:01 +0200)]
Bump odlparent dependency to 2.0.1
Change-Id: Ic2c34fb71552aeb6365ce37374c73f0bb909e14a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 21 Jun 2017 11:19:50 +0000 (13:19 +0200)]
Bump odlparent dependency to 2.0.0
also rename karaf4 features
Change-Id: I4d9d9274d12e4bb098884d70827d7ed57e8d7b48
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Wed, 21 Jun 2017 11:45:59 +0000 (13:45 +0200)]
Remove BGPCEP Karaf 3 features
Change-Id: I6db5b40c398fbe5e7cb4077d2c2a321a0286fab0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 21 Jun 2017 10:31:20 +0000 (12:31 +0200)]
Remove no longer required 31-bgp.xml for bgp feature
CSS configuration is not longer supported under nitrogen.
Therefore 31-bgp.xml is no longer required for bgp feature.
Change-Id: I43aa0a52d919a03e90133a2f908505941285773a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 17 May 2017 14:04:00 +0000 (16:04 +0200)]
BUG-6976: Migrate BMP collector to use BP wiring
Migrate to BP wiring
Change-Id: I6d7d33029123039d27493b014ae459da1333a77c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 29 May 2017 09:44:01 +0000 (11:44 +0200)]
KeyMapping rework
Change-Id: I76a1a1c0353219d453963422b64cd7bcf86bb523
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 15 May 2017 08:49:48 +0000 (10:49 +0200)]
BUG-6801: Remove deprecated bgpcep *-all features
Remove deprecated bgpcep *-all features
Change-Id: Ib87ea2d091e2eead955b8cf959a02f071365a7f9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Ryan Goulding [Mon, 19 Jun 2017 18:28:16 +0000 (14:28 -0400)]
Remove stale prerequisite sections
It is generally accepted that ODL requires maven 3.3.9+ in order to
compile correctly. This cleans up a bunch of places that reference
older minimum versions to avoid confusion. Instead, we should
recommend that all modules are compiled using the ODL global minimum
in order to promote a common toolset across the project.
Change-Id: I61591cfbd262e712bdd428e8b6697f7c0742dbde
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Ryan Goulding [Mon, 19 Jun 2017 17:00:45 +0000 (13:00 -0400)]
Migrate bgpcep local karaf distribution to karaf4
This change migrates the local karaf distribution from karaf 3 to
karaf 4.
Change-Id: Iabf8a96ecec5e3473eae55e6a1ca8f70856bc60c
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Robert Varga [Mon, 19 Jun 2017 13:52:39 +0000 (15:52 +0200)]
Reduce over-inclusion of base BGPCEP artifacts
We have some duplication across concepts/utils, use the extras
dependencies feature to bring those in for now.
Change-Id: I594a8a7d553ab17c992882eb117c7dc94a1a9ee3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Kevin Wang [Mon, 24 Apr 2017 23:28:10 +0000 (16:28 -0700)]
BUG-8292 Fix BGP flowspec NLRI length read
In BGP Flowspec, NLRI length is set per NLRI. The
current implementation only read NLRI once. So
BGP parser will throw exception when multiple
NLRIs are batched in one BGP UPDATE message.
Change-Id: I6630bca4c222e68f4609134192550d6c0a7ea3ba
Signed-off-by: Kevin Wang <kevixw@gmail.com>
(cherry picked from commit
51646d108fc36adef7cffd99657386fd6f5f96bd)
Robert Varga [Mon, 19 Jun 2017 12:26:05 +0000 (14:26 +0200)]
Remove dependency on blueprint
There is no need to declare this, as far as I can tell.
Change-Id: I58e8cb0cefff8d05ab00319eb3cb6c9db3a22fa6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Thanh Ha [Tue, 13 Jun 2017 20:07:47 +0000 (16:07 -0400)]
Migrate to odlparent 1.9.0
Change-Id: Ie210d3177329d2bd94f590f06ecbcb5ed9877863
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Mon, 15 May 2017 11:55:23 +0000 (13:55 +0200)]
Fix sonar complains
- Remove unused imports
- Remove unused exception
- Extract try block
- dont use generic Exception
- Reduce the number of conditional operators
Change-Id: I0d51ef2aa6540d1d841f637308431ce768b1636b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Dana Kutenicsova [Tue, 25 Apr 2017 15:16:06 +0000 (17:16 +0200)]
BUG-7027 : wired data-change-counter with Blueprint
Deprecate existing config modules,
add BP xml with custom config yang file.
No default configuration is set, to avoid
conflict modification when using on 3 node clustering.
Change-Id: I2b0408310605c9b96388585582d2e7a9f63007cb
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
matcauf [Fri, 9 Jun 2017 14:22:57 +0000 (10:22 -0400)]
Migrate to odlparent 1.8.0-Carbon
Per request of odlparent project we are downgrading all Nitrogen
projects to use the released odlparent 1.8.0-Carbon to allow for the
odlparent project to start performing semver style releases.
Jira: RELENG-159
RT: 41406
Change-Id: I3e41a57a11b63902be1bce25f3a6937609eb1f1f
Signed-off-by: matcauf <mcauffiez@inocybe.ca>
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
matthieu [Thu, 8 Jun 2017 16:40:06 +0000 (12:40 -0400)]
Bug 8568 - Remove deprecated CSS module tests
Remove Test class that are using deprecated DataProviderService
for Classes
BGPApplicationPeerModule
BGPPeerModule
RIBImplModule
Ipv4ReachabilityTopologyBuilderModule
Ipv6ReachabilityTopologyBuilderModule are deprecated and
will be not tested
Classes AddPathImplModule and BGPTableTypeImplModule are not
deprecated and will be not tested.
Do they need to be deprecated ?
Change-Id: I9b9d3125b6f80ee70c86451f8a46cbd480bde6c2
Signed-off-by: matthieu <mcauffiez@inocybe.com>
Claudio D. Gasparini [Mon, 29 May 2017 06:13:31 +0000 (08:13 +0200)]
Rework failing test testStateful07TopologySessionListener
Change-Id: Id48d30e15351217a9738de742dec2d2581480d29
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 25 May 2017 08:04:02 +0000 (10:04 +0200)]
Remove deprecated methods
Change-Id: I8d38181081702c692a4d093761b95d5a2dddeca2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 22 May 2017 09:09:06 +0000 (11:09 +0200)]
Change deprecated SchemaService by DOMSchemaService
Change-Id: Iaa4adace5e15a1aeee2824cac81f8c72703a80fb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 16 May 2017 11:12:50 +0000 (13:12 +0200)]
Introduce dependecies version management
for handle version of ODL features in an
unique place.
Change-Id: Ifbf831a0fd387f548f58084c003ef6475f7b0a8d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 31 May 2017 07:04:29 +0000 (09:04 +0200)]
BUG-8548: Pass missing parameter to
SimpleBGPExtensionProviderContext#registerNlriParser
Change-Id: I625f82d64efa0d2843b94de31c649572be9cacf9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
matcauf [Fri, 26 May 2017 16:10:47 +0000 (12:10 -0400)]
Code Cleanup: unused var and imports
Remove unused logs, class member and
methods paramenters
Change-Id: I02640d49844d46726da8da9ae162507dc6c6e581
Signed-off-by: matcauf <mcauffiez@inocybe.ca>
matcauf [Fri, 26 May 2017 19:03:21 +0000 (15:03 -0400)]
Code cleanup: Duplicate Code
Remove duplicated code
Change-Id: I318e391e95bc892ebcf6af3081a455e84843c93a
Signed-off-by: matcauf <mcauffiez@inocybe.ca>
Claudio D. Gasparini [Mon, 29 May 2017 12:25:21 +0000 (14:25 +0200)]
Remove unused LOG
Change-Id: I03d203e42e009ef737b07e05d56f2df5d650cded
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Kevin Wang [Mon, 24 Apr 2017 20:31:12 +0000 (13:31 -0700)]
BUG-8156 Fix PCEP topology registration
It is possible that when a PCEP session is being dropped and being
unregistered from ServerSessionManager, the thread gets switched
thus the topology unregistering cannot finish.
If such situation happens, PCEP session from the same PCEP peer will
not be able to established until after DEADTIMER_EXPIRED, as the
topology instance was not removed correctly.
Change-Id: I647ecfbbb35ef6805d563753b7ebd87edfc350fe
Signed-off-by: Kevin Wang <kevixw@gmail.com>
(cherry picked from commit
2801f2b71ca49dcee50b643ef5ed4f53938609fc)
Xiao Liang [Wed, 3 May 2017 08:44:08 +0000 (08:44 +0000)]
Fix RD pattern in RouteDistinguisherBuilder
Type 0 RD is 2+4 bytes.
Change-Id: I7ec0099cf5c1cdf8ab7d333dc26756c17228579b
Signed-off-by: Xiao Liang <shaw.leon@gmail.com>
Claudio D. Gasparini [Wed, 10 May 2017 18:30:19 +0000 (20:30 +0200)]
migrate yangtools deprecated BindingNormalizedNodeSerializer
migrate yangtools deprecated BindingNormalizedNodeSerializer
to mdsal BindingNormalizedNodeSerializer
Change-Id: I32439a487a209a567b5436b204c11d979ac46cc8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 9 May 2017 11:33:30 +0000 (13:33 +0200)]
BUG-8356: Rename features4-extras
Rename features4-extras which colides
with controller features4-extras, making
SingleFeatureTest for repos/index fail.
Change-Id: I04c693f853178e08a15eaa5435310659f66ee061
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Colin Dixon [Mon, 1 May 2017 16:03:15 +0000 (12:03 -0400)]
BUG-8335: @Ignore InstructionDeployerImplTest
This test hangs fairly consistently in autorelease-carbon.
Change-Id: Idc6a207ff669f433096017494c24d99b8ec02c09
Signed-off-by: Colin Dixon <colin@colindixon.com>
(cherry picked from commit
5cca02bf6871cc9345baadcc282acfa76e0ff5de)
Claudio D. Gasparini [Wed, 26 Apr 2017 06:57:42 +0000 (08:57 +0200)]
BUG-8306: Fix Pcep failing test
Given that messages takes differents time to arrive on listener
Fix Stateful07TopologySessionListenerTest by
use checkEquals, which checks the assertion with timeout.
Change-Id: I13733fa7ad7686671d9c026a8528ad912e2c7cd5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Tue, 25 Apr 2017 17:38:01 +0000 (19:38 +0200)]
Fix yang module file names
This patch fixes these two warnings:
2017-04-25 19:34:22,251 | INFO | ... | Provided module name bgp-evpn.yang does not match actual text odl-bgp-evpn@2016-03-21.yang, corrected
2017-04-25 19:34:03,806 | INFO | ... | Provided module name bgp-path-selection-mode.yang does not match actual text odl-bgp-path-selection-mode@2016-03-01.yang, corrected
We do not have to include the revision, as that mismatch leads
only to a debug.
Change-Id: I58dddf24128804a6151ac84369030d8e5f8fcac3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 21 Apr 2017 10:42:18 +0000 (12:42 +0200)]
Fix karaf4 features
Features should be pulling in transitive dependencies from
the corresponding features. Fix that.
Change-Id: Ib758202ad0ff03e3a44b8a040dcc72f241c59920
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
86388150d7239e6430503752f312707bf63d07b6)
Claudio D. Gasparini [Fri, 21 Apr 2017 12:36:32 +0000 (14:36 +0200)]
BUG-8275: Close ReadOnly transaction
PCEPStatefulPeerProposal needs to
close ReadOnlyTransaction created
after use it
Change-Id: I1515f09028c9e6bd8403d6ea2851196511d4da24
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
b85554f565b2e03d2c8237b160ac055907b86b23)
Claudio D. Gasparini [Wed, 12 Apr 2017 06:58:46 +0000 (08:58 +0200)]
BUG-8202: Fix Conflict Modification on odl-programming
Instruction DS configuration only should be written
on Leader when instatiateService.
Change-Id: I9acf17c8a19d8b22d83e62b315fdadf9494783f2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 20 Apr 2017 12:03:35 +0000 (14:03 +0200)]
BUG-8198: Fix InferenceException
Add presence statement under graceful-restart-capability.
Change-Id: Idc98f74661d4dea4f440d178da868ec83f896370
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit
187428a5c597c78c625ca2b1baa1a920108a979f)
Kevin Wang [Thu, 20 Apr 2017 00:28:47 +0000 (17:28 -0700)]
BUG-8252 Fix IP prefix length util
The byte representing IP prefix length is a unsigned byte.
The length should be converted to an unsigned int explicitly.
Change-Id: I0c1df171822858825da69f39c91de9ed332865f8
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Claudio D. Gasparini [Wed, 12 Apr 2017 20:22:54 +0000 (22:22 +0200)]
BUG-8213: Add missing mandatory attribute on tests
Add missing origin attribute on tests
Change-Id: I125437e187286a7a949e26191e66f19ded123274
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Anil Belur [Tue, 11 Apr 2017 01:45:26 +0000 (11:45 +1000)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: I4d89069222217139eceba9eac78cefc1234c3304
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Claudio D. Gasparini [Wed, 22 Feb 2017 11:35:38 +0000 (12:35 +0100)]
Improve synchronization under BMP
Improve synchronization under BMP whenever
transaction chain is created and submitted.
Change-Id: If7a61c394218bd7c78c6021ee19ba42f4276560a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 3 Apr 2017 11:13:59 +0000 (13:13 +0200)]
Restrict dependencies scope to test
Restrict various dependencies scope to test
Change-Id: I23cef78c244454d2059311c0d56af753f695c02f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 21 Mar 2017 11:18:25 +0000 (12:18 +0100)]
BUG-4491: Race condition under PCEP Topology Provider
Race condition under PCEP Topology Provider when
instace is reconfigured, since closeInstance under CSS
is nonbloking, it can race the delete with the writing
of the new instance when restarting.
Fix by calling first closeServiceInstance(blocking)
on topology instance and once it gets done call close.
Change-Id: If79bf34f77223bc56424a57e4e600fdb17ddd154
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 22 Mar 2017 14:23:19 +0000 (15:23 +0100)]
BUG-8021: Race between Peer structure creation and route init.
There is a possibility of race between Peer structure
creation and route initialization/advertizement.
Fix by introducing a flag, which indicates whether
peer's structure has been created and is able to be updated.
Change-Id: Ia9515d2017cb5213ce286e463712092c87764e10
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 24 Mar 2017 19:26:08 +0000 (20:26 +0100)]
BUG-7976: Race between peer removal and routes update
There is a race condition when we are advertizing routes,
and a session peer goes down which will end in
removing the peer from DS.
Since advertizement and removal are done by 2 different tx,
we need to do it blocking mode, and not route should be
advertized until peer is removed and vice versa, peer
should not be removed until routes are advertized.
Otherwise toure update will try to update a peer/path which
is not longer present.
Fix by rework PeerExportGroup & ExportPolicyPeerTracker,
now instead of generate PeerExportGroup each time a peer
is reg/unreg, we make PeerExportGroup work as a
blocking registry to solve previous issue.
Change-Id: I46a27871bfa2aa2a632e3bfb76061105c62bb6d2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 19 Mar 2017 13:10:31 +0000 (14:10 +0100)]
Fix sonar complains
- Remove unused imports
- Throw exception
- Name convention
- Comparison
- private constructor on util
- replace explicit type per <>
- migrate to java stream api
Change-Id: I224eb8dfe776130b0f45468be4791239daf878af
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>