netvirt.git
7 years agoRefactor moving tunnelinfstatechglistener subclass 98/43098/2
Abhinav Gupta [Thu, 4 Aug 2016 06:36:04 +0000 (12:06 +0530)]
Refactor moving tunnelinfstatechglistener subclass

1. Refactored moving tunnelinterfacestatechangelistener subclass out of
VPNInterfaceManager class.
2. Added itmRpcService and FibManager dependency for the above class.
3. Renamed a few misleading functions

Change-Id: I7c8467bdbf69e54b7a3242e6c563e0adf1319f2f
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>
7 years agoMerge "Multiple fixes related to VPN concurrency"
Sam Hague [Thu, 4 Aug 2016 02:15:52 +0000 (02:15 +0000)]
Merge "Multiple fixes related to VPN concurrency"

7 years agoMerge "Complete ETree implementation in netvirt. Extended ElanService to support...
Sam Hague [Thu, 4 Aug 2016 02:10:13 +0000 (02:10 +0000)]
Merge "Complete ETree implementation in netvirt. Extended ElanService to support Etree model."

7 years agoMerge "Fix exception in IPv6 ifacelistener for a tunnel add notification"
Sam Hague [Thu, 4 Aug 2016 00:12:19 +0000 (00:12 +0000)]
Merge "Fix exception in IPv6 ifacelistener for a tunnel add notification"

7 years agoMerge "Commented out frequently replayed BGPMIP errorlogs"
Sam Hague [Thu, 4 Aug 2016 00:09:50 +0000 (00:09 +0000)]
Merge "Commented out frequently replayed BGPMIP errorlogs"

7 years agoMerge "Fixes related to anit-spoofing rule to allow DHCP traffic."
Sam Hague [Thu, 4 Aug 2016 00:08:51 +0000 (00:08 +0000)]
Merge "Fixes related to anit-spoofing rule to allow DHCP traffic."

7 years agoComplete ETree implementation in netvirt. Extended ElanService to support Etree model. 37/40737/28
Guy Sela [Sun, 19 Jun 2016 10:26:59 +0000 (13:26 +0300)]
Complete ETree implementation in netvirt. Extended ElanService to support Etree model.

Etree network adds another attribute for interfaces: Root or Leaf.
In the same Etree network:
Root interfaces can communicate with all interfaces.
Leaf interfaces can communicate only with Root interfaces.

Change-Id: I7855015db9c34757249a7461ebf37924969d398c
Signed-off-by: Guy Sela <guy.sela@hpe.com>
7 years agoMerge "ACL: Updated to cache interface/interface state details"
Sam Hague [Thu, 4 Aug 2016 00:00:24 +0000 (00:00 +0000)]
Merge "ACL: Updated to cache interface/interface state details"

7 years agoMerge "Add IT to netvirt-vpnservice"
Sam Hague [Wed, 3 Aug 2016 18:15:04 +0000 (18:15 +0000)]
Merge "Add IT to netvirt-vpnservice"

7 years agoFix exception in IPv6 ifacelistener for a tunnel add notification 61/43061/2
Sridhar Gaddam [Wed, 3 Aug 2016 16:11:33 +0000 (21:41 +0530)]
Fix exception in IPv6 ifacelistener for a tunnel add notification

This patch fixes the IllegalArgumentException in Ipv6ServiceInterfaceEventListener
when a tunnel is created.

Change-Id: I9ca9045bac191863ff265ceea418d34458102f81
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
7 years agoMerge changes from topic 'openstack-sfc-translator'
Anil Vishnoi [Wed, 3 Aug 2016 16:30:54 +0000 (16:30 +0000)]
Merge changes from topic 'openstack-sfc-translator'

* changes:
  Port Pair/Group & Chain Listener registration and translator hookup
  OpenStack Networking SFC Flow classifier translator
  OpenStack Networking SFC Neutron Northbound Yang Model translator

7 years agoMultiple fixes related to VPN concurrency 50/43050/2
HANAMANTAGOUD V Kandagal [Wed, 3 Aug 2016 14:42:31 +0000 (20:12 +0530)]
Multiple fixes related to VPN concurrency

1. Handle dpnToVpn list maintained by vpn engine correctly.
2. Make sure that SNAT flows appear when Internet VPN is created.
3. Print batches and batchsize for batchable resources as an INFO.
4. Fix the issue when VM holding the invisible IP is removed, the
invisible IP is removed along with the original VM IP.
5. Fixes extra-route add logic so that Extra-Routes configured via neutron
router now appear in FIB for further realization into flows.
6. Avoid using LabelRouteInfo for InternalVPN. This saves Operation DS
namespace.

Change-Id: Ia9d8f422b1254cf153b6725c2fa8ea0bd68a0ed4
Signed-off-by: HANAMANTAGOUD V Kandagal <hanamantagoud.v.kandagal@ericsson.com>
7 years agoCommented out frequently replayed BGPMIP errorlogs 42/43042/3
Abhinav Gupta [Wed, 3 Aug 2016 13:20:18 +0000 (18:50 +0530)]
Commented out frequently replayed BGPMIP errorlogs

Change-Id: I9cc11e3aca91f02f556453cc419d242f25a0bc2a
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>
7 years agoFixes related to anit-spoofing rule to allow DHCP traffic. 41/43041/2
Aswin Suryanarayanan [Wed, 3 Aug 2016 13:00:59 +0000 (18:30 +0530)]
Fixes related to anit-spoofing rule to allow DHCP traffic.

Change-Id: I953dacbc9454f26c2ef96afcdb19c9d1b7e033ab
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
7 years agoACL: Updated to cache interface/interface state details 67/42967/8
unknown [Tue, 2 Aug 2016 12:14:19 +0000 (17:44 +0530)]
ACL: Updated to cache interface/interface state details

    - Updated to cache only required interface/interface state details in
      AclInterface object
    - AclInterface object used now as reference in all listeners for
      programming ACL flows instead of Interface/Interface State object
      from config/operational DS
    - Resolved NullPointerException observed while ACL flows were deleted
    - Updated AclDataUtil to use UUID of SG everywhere instead of SG name

Change-Id: If1a12e9a746aa1bf0360aa82caa3a26f6118d420
Signed-off-by: unknown <shashidhar.raja@ericsson.com>
7 years agofix compilation error 49/43049/3
Shlomi [Wed, 3 Aug 2016 14:43:18 +0000 (17:43 +0300)]
fix compilation error

Change-Id: I179c898cf228d8fb1e63f1713c556deb13e90fd7
Signed-off-by: Shlomi <shlomi.alfasi@hpe.com>
7 years agoAdd IT to netvirt-vpnservice 92/42492/6
Oded Shvartz [Mon, 25 Jul 2016 14:50:41 +0000 (17:50 +0300)]
Add IT to netvirt-vpnservice

Writing IT that are available in the old Netvirt project.
The first patch include 2 tests:
1)validate basic connection between ovs and controller.
2)validate ping between 2 ports (using docker).

Change-Id: I3b885b043aa66975ead5b5f2d1eb3bb20a0a1bf2
Signed-off-by: Oded Shvartz <oshvartz@redhat.com>
7 years agoPort Pair/Group & Chain Listener registration and translator hookup 53/42953/3
Anil Vishnoi [Tue, 2 Aug 2016 10:05:49 +0000 (03:05 -0700)]
Port Pair/Group & Chain Listener registration and translator hookup

Change-Id: I9bcb1e7906ded8cf19dbefb896e9cdd37359f1df
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
7 years agoOpenStack Networking SFC Flow classifier translator 48/42948/4
Anil Vishnoi [Tue, 2 Aug 2016 09:03:17 +0000 (02:03 -0700)]
OpenStack Networking SFC Flow classifier translator

Patch contains translator code that converts OpenStack Networking SFC
flow classifier neutron yang models to OpenDaylight ACL Flow classifier
yang models

Change-Id: I028e312755c968cbeb1f2c50a1152d65f83463ce
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
7 years agoOpenStack Networking SFC Neutron Northbound Yang Model translator 47/42947/4
Anil Vishnoi [Sun, 31 Jul 2016 22:19:23 +0000 (15:19 -0700)]
OpenStack Networking SFC Neutron Northbound Yang Model translator

This project will be hosting a code that will convert OpenStack
Networking SFC Neutron Northbound Yand Models to OpenDaylight
ACL/ SFC yang models.

Patch contains the project structure that hooks in all the
required dependencies that is required for the translator code.

Change-Id: I6deed62ffc4e33854594a47499657955cae79082
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
7 years agoMerge "bug-6326 use new sig for setBridgeController"
Sam Hague [Tue, 2 Aug 2016 21:49:28 +0000 (21:49 +0000)]
Merge "bug-6326 use new sig for setBridgeController"

7 years agoMerge "Added Port Range and Ipv6 matches"
Sam Hague [Tue, 2 Aug 2016 21:28:49 +0000 (21:28 +0000)]
Merge "Added Port Range and Ipv6 matches"

7 years agoSet vpn-id/router-id metadata so it would not to override split-horizon bit 19/42919/4
Tali [Mon, 1 Aug 2016 14:13:51 +0000 (17:13 +0300)]
Set vpn-id/router-id metadata so it would not to override split-horizon bit

Depends on genius commit https://git.opendaylight.org/gerrit/#/c/42918/

Change-Id: I1956afa5c7fbcf2d942a0a6ff1ff98830cbc32e6
Signed-off-by: Tali <tali.ben-meir@hpe.com>
7 years agobug-6326 use new sig for setBridgeController 80/42980/2
Josh [Tue, 2 Aug 2016 15:17:39 +0000 (17:17 +0200)]
bug-6326 use new sig for setBridgeController

depends on: https://git.opendaylight.org/gerrit/42979

Change-Id: Id8a8d9a1838089f81c996597ef8fc2f315a53120
Signed-off-by: Josh <jhershbe@redhat.com>
7 years agoAdded Port Range and Ipv6 matches 89/42889/3
Aswin Suryanarayanan [Mon, 1 Aug 2016 08:00:17 +0000 (13:30 +0530)]
Added Port Range and Ipv6 matches

1)Added port range match using nicira extension.
2)Added IPV6 source and destination matches
3)UT Fixes

Change-Id: I7668bcd32c78953b84e455bdf9cc2bed421c05e7
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
7 years agoMerge "Formatting changes"
Sam Hague [Tue, 2 Aug 2016 11:04:22 +0000 (11:04 +0000)]
Merge "Formatting changes"

7 years agoGlobal use of table ids from NwConstants.java 46/42946/2
Suraj Ranjan [Tue, 2 Aug 2016 08:25:44 +0000 (13:55 +0530)]
Global use of table ids from NwConstants.java

This review includes following things:

1> After merging of https://git.opendaylight.org/gerrit/#/c/42940/, build
of Netvirt started failing. Because ElanStatisticsImpl.java was using one
constant from IfmConstants.java, which was removed in mentioned commit.

2> Removed few table ids from FibConstants.java, NATConstants.java and
VpnSubnetRouteHandler.java then using directly from NwConstants.java.

Change-Id: Ie6d1663113d7f8dcb1965954d51776d98fd73ddb
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
7 years agoMerge "Periodic RA transmission"
Sam Hague [Mon, 1 Aug 2016 20:37:55 +0000 (20:37 +0000)]
Merge "Periodic RA transmission"

7 years agoMerge "Add a match to nd_target for IPv6 NS punt flows"
Sam Hague [Mon, 1 Aug 2016 20:36:01 +0000 (20:36 +0000)]
Merge "Add a match to nd_target for IPv6 NS punt flows"

7 years agoFormatting changes 21/42921/1
Guy Sela [Mon, 1 Aug 2016 15:22:54 +0000 (18:22 +0300)]
Formatting changes

Change-Id: I3879443332230cfd37aa2cb5f9b52fe276182b55
Signed-off-by: Guy Sela <guy.sela@hpe.com>
7 years agoPeriodic RA transmission 27/42727/5
kalaiselvik [Mon, 1 Aug 2016 11:34:00 +0000 (17:04 +0530)]
Periodic RA transmission

Support added for periodic transmission of the RA messages
from the router interfaces available in the compute nodes.
The unsolicitied RA is sent out only on the interfaces
where the same network is available.

Pending items:
1. Configurable RA interval
2. UT for the periodic transmission
(Will be added in separate patch)

Change-Id: I7b498e88ba6801f564c931abc6b5dfeb2d0b14ed
Signed-off-by: kalaiselvik <Kalaiselvi_K@Dell.com>
7 years agoAdd a match to nd_target for IPv6 NS punt flows 16/42916/1
Sridhar Gaddam [Mon, 1 Aug 2016 14:09:17 +0000 (19:39 +0530)]
Add a match to nd_target for IPv6 NS punt flows

Previous patchset that added support for IPv6 ServiceBinding
programs a generic flow to send all Neighbor Solicitation requests
to the controller. This was done since the support to match nd_target
was missing in genius matchutil at that time.

We now have support for matching nd_target in genius. This patch
modifies the punt flows to send only NS packets that correspond to
the Router interface. Neighbor Soliciation for other VMs would be
answered by the respecive VMs on the network.

Change-Id: I434919cdb3a62f762ca2e1287397459ab17754d5
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
7 years agoMerge "Fixes related to ACL service."
Sam Hague [Mon, 1 Aug 2016 13:43:53 +0000 (13:43 +0000)]
Merge "Fixes related to ACL service."

7 years agoMerge "Fix of NPE in DhcpServiceCounters and NatServiceCounters."
Sam Hague [Mon, 1 Aug 2016 13:36:01 +0000 (13:36 +0000)]
Merge "Fix of NPE in DhcpServiceCounters and NatServiceCounters."

7 years agoFixes related to ACL service. 14/42714/4
Somashekar Byrappa [Thu, 28 Jul 2016 15:00:13 +0000 (20:30 +0530)]
Fixes related to ACL service.

+ Egress ACL table is split into two tables (40 and 41).
+ Ingress ACL table is split into two tables (251 and 252).
+ Ingress/Egress filter tables are made to match on lport tag.
+ Packets matching ingress/egress ACL filters are re-submitted to
corresponding dispatcher tables for the next service.
+ Egress (w.r.t switch) acl service priority is changed to value 6.
+ Few more fixes.

Change-Id: I06ca4a7358aae36a456bb0be2e9e3c8024576ce8
Signed-off-by: Somashekar Byrappa <somashekar.byrappa@ericsson.com>
7 years agoFix of NPE in DhcpServiceCounters and NatServiceCounters. 91/42891/1
yair [Mon, 1 Aug 2016 08:52:45 +0000 (11:52 +0300)]
Fix of NPE in DhcpServiceCounters and NatServiceCounters.

Change-Id: I04eaa7ae26072fa4313897ee3ade365edfe76c21
Signed-off-by: yair <yair.zinger@hpe.com>
7 years agoGlobal use of Table ids from NwConstants.java 76/42876/1
Suraj Ranjan [Mon, 1 Aug 2016 06:24:07 +0000 (11:54 +0530)]
Global use of Table ids from NwConstants.java

In my previous patches for global use of table ids, I missed one table id
to remove from NATConstants.java.

Removing that particular table id in this patch and using directly from
NwConstants.java.

Change-Id: If143ee91576a85feeab806ed299649c8b359cbf3
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
7 years agoMerge "Using Table Ids from NwConstants.java"
Sam Hague [Sun, 31 Jul 2016 21:24:46 +0000 (21:24 +0000)]
Merge "Using Table Ids from NwConstants.java"

7 years agoMerge "First use of the infrautils counters in netvirt."
Sam Hague [Sun, 31 Jul 2016 13:48:15 +0000 (13:48 +0000)]
Merge "First use of the infrautils counters in netvirt."

7 years agoUsing Table Ids from NwConstants.java 76/42776/4
Suraj Ranjan [Fri, 29 Jul 2016 10:19:09 +0000 (15:49 +0530)]
Using Table Ids from NwConstants.java

This review includes changes in entire netvirt module, to use table ids
from NwConstants.java.

Change-Id: I8eb854efffee776b1cfe644e52fb2ba65bcb3a20
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
7 years agoAdd external ports to L3VPN models 37/42437/22
Tali [Mon, 25 Jul 2016 05:32:11 +0000 (08:32 +0300)]
Add external ports to L3VPN models

Change-Id: I3d2aa9c08c72a675d106441df20a17d2cbc00156
Signed-off-by: Tali <tali.ben-meir@hpe.com>
7 years agoFirst use of the infrautils counters in netvirt. 74/42574/8
yair [Tue, 26 Jul 2016 14:07:30 +0000 (17:07 +0300)]
First use of the infrautils counters in netvirt.

Added install and remove flows counters for Dhcp and SNAT default flows.

Change-Id: I2b4b6692675b4f22af600cb3edea6bf660462af6
Signed-off-by: yair <yair.zinger@hpe.com>
7 years agoSupport update/delete operations for provider networks 44/41944/21
Tali [Mon, 18 Jul 2016 04:44:09 +0000 (07:44 +0300)]
Support update/delete operations for provider networks
Add external ports to remote BC group buckets

Depends on genius commit https://git.opendaylight.org/gerrit/#/c/41943/

Change-Id: Ibf7c73cec88f6cf629815ab57bb657bcb336a955
Signed-off-by: Tali <tali.ben-meir@hpe.com>
7 years agoMerge "Write netvirt:1 to mdsal when netvirt is ready"
Sam Hague [Sat, 30 Jul 2016 14:12:48 +0000 (14:12 +0000)]
Merge "Write netvirt:1 to mdsal when netvirt is ready"

7 years agoWrite netvirt:1 to mdsal when netvirt is ready 02/42802/3
Sam Hague [Fri, 29 Jul 2016 20:10:28 +0000 (16:10 -0400)]
Write netvirt:1 to mdsal when netvirt is ready

This new module will write netvirt:1 to mdsal when all the
netvirt services have started. There are 10 services that
are required. Some services are in the Service Registry and
can be referenced in the blueprint.xml. Other services can
only be found via the config subssystem beans. Once we move
the rest of netvirt to blueprint we can deprecate the config
related code.

Change-Id: I3841609c18ba65463d8e7ee07304fa0210b193f7
Signed-off-by: Sam Hague <shague@redhat.com>
7 years agoCreate ELAN interface for physnet ports 51/41751/29
Tali [Wed, 13 Jul 2016 09:00:31 +0000 (12:00 +0300)]
Create ELAN interface for physnet ports

Change-Id: Ibafba16bb2dac1490d711532edafc305173d72a3
Signed-off-by: Tali <tali.ben-meir@hpe.com>
7 years agoCreate physnet bridges+ports and patch to br-int 25/41925/21
Josh [Sun, 17 Jul 2016 12:09:54 +0000 (14:09 +0200)]
Create physnet bridges+ports and patch to br-int

NB: This commit depends on changes in the ovsdb
project: https://git.opendaylight.org/gerrit/#/c/41946/

AND NOW ALSO:
https://git.opendaylight.org/gerrit/#/c/42693/

Assume "provider_mappings=physnet1:ABC". ABC will either be (in this
order) (1) the name of a port already configured on br-int, (2) the name
of a bridge already configured on OVS, or (3) the name of a physical
interface. So for each option:

(1) ABC is a port already on br-int
At OVSDB node add/update event:
  no op
When adding the ElanInterface to the ElanInstance:
  ABC is the name of the port, use that

(2) ABC is the name of a bridge on OVS
At OVSDB node add/update event:
  patch the bridge to br-int, br-int side port name is ABC-patch
When adding the ElanInterface to the ElanInstance:
  ABC-patch is the name of the port, use that

(3) ABC is the name of a NIC
At OVSDB node add/update event:
  add the port directly to br-int
When adding the ElanInterface to the ElanInstance:
  ABC is the name of the port, use that

Change-Id: Ibf6851d420c8197e11a6503b950fa381b829499c
Signed-off-by: Josh <jhershbe@redhat.com>
7 years agoMerge "Flat/VLAN network type support"
Sam Hague [Sat, 30 Jul 2016 10:36:23 +0000 (10:36 +0000)]
Merge "Flat/VLAN network type support"

7 years agoMerge "Support Service Binding for ipv6service"
Sam Hague [Fri, 29 Jul 2016 17:40:49 +0000 (17:40 +0000)]
Merge "Support Service Binding for ipv6service"

7 years agoMerge "Security Group: Allowed address pair changes"
Sam Hague [Fri, 29 Jul 2016 17:16:16 +0000 (17:16 +0000)]
Merge "Security Group: Allowed address pair changes"

7 years agoMerge "Add NetvirtItUtils.verifyFlowByFields"
Sam Hague [Fri, 29 Jul 2016 17:15:29 +0000 (17:15 +0000)]
Merge "Add NetvirtItUtils.verifyFlowByFields"

7 years agoMerge "Fix and disable cloud-servicechain config"
Andre Fredette [Fri, 29 Jul 2016 15:59:34 +0000 (15:59 +0000)]
Merge "Fix and disable cloud-servicechain config"

7 years agoSupport Service Binding for ipv6service 28/42628/2
Sridhar Gaddam [Wed, 27 Jul 2016 11:14:20 +0000 (16:44 +0530)]
Support Service Binding for ipv6service

This patch supports ServiceBinding with genius for an interface
that is having an IPv6 address and is connected to a router.

IPv6Service uses genius NWConstants for the serviceIndex value.

Pending (will be taken up via a different patch):
  1. Flow to punt Neighbor Solicitation currently does not include
     the nd_target, as support is missing in MatchUtils.
  2. ServiceBinding for existing ports when a v6 subnet is added to
     a network and associated to the router.

Change-Id: I05f6b410f1996143e50bd2507e973af3dd13d8fc
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
7 years agoFix and disable cloud-servicechain config 86/42786/1
Sam Hague [Fri, 29 Jul 2016 14:18:27 +0000 (10:18 -0400)]
Fix and disable cloud-servicechain config

Change-Id: I92f9c81171c1f48adb97e6bb89c89bee4879ca69
Signed-off-by: Sam Hague <shague@redhat.com>
7 years agoInterVpnLinkNodeListener log message is happening about 83/42783/2
Andre Fredette [Fri, 29 Jul 2016 14:03:27 +0000 (10:03 -0400)]
InterVpnLinkNodeListener log message is happening about
8 times per second.

Changing it from info to debug.

Change-Id: Id0f8fe9b0a9c939daaf75a5614beb7855417dc7e
Signed-off-by: Andre Fredette <afredette@redhat.com>
7 years agoAdded license headers in cloudservicechain test 63/42763/2
Abhinav Gupta [Fri, 29 Jul 2016 07:07:21 +0000 (12:37 +0530)]
Added license headers in cloudservicechain test

Also included fix from https://git.opendaylight.org/gerrit/42760
(reflection of NwConstants change in Genius) to enable
successful compilation.

Change-Id: Iee2a70a8527dabb936373330c4cc213f5049f84c
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>
7 years agoMerge "Fixed NPO and and some other changes"
Sam Hague [Fri, 29 Jul 2016 00:20:46 +0000 (00:20 +0000)]
Merge "Fixed NPO and and some other changes"

7 years agoSecurity Group: Allowed address pair changes 14/42614/4
unknown [Wed, 27 Jul 2016 09:05:45 +0000 (14:35 +0530)]
Security Group: Allowed address pair changes

    - Updated Neutron port listener to pass Neutron port's MAC + Fixed Ips
      as allowed address pairs to Acl Service
    - Moved all SG utility methods to NeutronvpnUtils

Change-Id: I44467157e9b5085b198d1a107f2f121c7ef814a4
Signed-off-by: unknown <shashidhar.raja@ericsson.com>
7 years agoRemoved unnecessary changes 81/42681/1
Suraj Ranjan [Thu, 28 Jul 2016 09:18:04 +0000 (14:48 +0530)]
Removed unnecessary changes

Dependencies of interfcemanager-shell not required on pom.xml
of vpnservice in netvirt.

Change-Id: I25263d4719a629d0849da47fa61c45747e8418a9
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
7 years agoFlat/VLAN network type support 46/41646/22
Tali [Mon, 11 Jul 2016 11:16:24 +0000 (14:16 +0300)]
Flat/VLAN network type support

Change-Id: I18b3ca02aec3f35b68a83eb028b449c58af64607
Signed-off-by: Tali <tali.ben-meir@hpe.com>
7 years agoMerge "Updated to support allowed address pair with ACL service"
Vishal Thapar [Thu, 28 Jul 2016 07:33:45 +0000 (07:33 +0000)]
Merge "Updated to support allowed address pair with ACL service"

7 years agoFixed NPO and and some other changes 17/42617/2
Aswin Suryanarayanan [Wed, 27 Jul 2016 10:07:32 +0000 (15:37 +0530)]
Fixed NPO and and some other changes

1)Fixed NPO in case of empty access list

2)Added code to support ether type.

Change-Id: Ib62216d2a6b6cd10cbba3708a99bce57cbcae4a2
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
7 years agointerfacemgr-shell was renamed to interfacemanager-shell 67/42667/2
Thanh Ha [Thu, 28 Jul 2016 01:45:33 +0000 (21:45 -0400)]
interfacemgr-shell was renamed to interfacemanager-shell

See:
https://git.opendaylight.org/gerrit/42028/

Change-Id: Iadf8c11f79b6fac8835a1776ff398435b4b94750
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
7 years agoMerge "Clean up programDhcpMatches()"
Sam Hague [Wed, 27 Jul 2016 23:15:20 +0000 (23:15 +0000)]
Merge "Clean up programDhcpMatches()"

7 years agoMerge "Redefining DHCP_TABLE as 19"
Vishal Thapar [Wed, 27 Jul 2016 18:24:53 +0000 (18:24 +0000)]
Merge "Redefining DHCP_TABLE as 19"

7 years agoUpdated to support allowed address pair with ACL service 75/42575/4
unknown [Tue, 26 Jul 2016 14:07:05 +0000 (19:37 +0530)]
Updated to support allowed address pair with ACL service

    - Updated to program flows with ip + MAC matches of VM and allowed
      address pairs in both ingress/egress directions

Change-Id: Ie50d136d5d05541873406d35a283741516cfa622
Signed-off-by: unknown <shashidhar.raja@ericsson.com>
7 years agoRedefining DHCP_TABLE as 19 36/42636/1
epgoraj [Wed, 27 Jul 2016 12:31:27 +0000 (18:01 +0530)]
Redefining DHCP_TABLE as 19

    Table 25 is already used by DNAT, so DHCP table is changed to 19

Change-Id: I6aca924842dd347a6f47d25de1212a5b03a651ec
Signed-off-by: epgoraj <p.govinda.rajulu@ericsson.com>
7 years agoMerge "Adding cloud-servicechain module"
Sam Hague [Wed, 27 Jul 2016 12:05:38 +0000 (12:05 +0000)]
Merge "Adding cloud-servicechain module"

7 years agoMerge "AclServiceOFFlowBuilder UT added"
Sam Hague [Wed, 27 Jul 2016 12:03:53 +0000 (12:03 +0000)]
Merge "AclServiceOFFlowBuilder UT added"

7 years agoMerge "Fix for DHCP with Metadata"
Sam Hague [Wed, 27 Jul 2016 10:21:34 +0000 (10:21 +0000)]
Merge "Fix for DHCP with Metadata"

7 years agoAclServiceOFFlowBuilder UT added 60/42060/8
Ravit Peretz [Tue, 19 Jul 2016 12:37:06 +0000 (15:37 +0300)]
AclServiceOFFlowBuilder UT added

Change-Id: I52d6f2779139edba1012044caf5541ef8033e71a
Signed-off-by: Ravit Peretz <ravit.peretz@hpe.com>
7 years agoUpstreaming changes in Netvirt 48/42548/2
Suraj Ranjan [Tue, 26 Jul 2016 09:08:22 +0000 (14:38 +0530)]
Upstreaming changes in Netvirt

(Dependent on https://git.opendaylight.org/gerrit/#/c/42540/)

This commit includes VPN Engine Concurrency Fixes also some SNAT and DNAT
regression issues.

1. We have made multiple fixes here for safe concurrency.

2. We have moved all helper methods that deal with VRFEntry
resource into FibManager from VPNManager.

3. We have gracefully handled deletion of bgpvpn regardless of
how many ever external routes are available in such vpn.

4. We have fixed NATService to directly use FibManager to
program SNAT/DNAT VRFEntries.

5. As of this review, all local VM routes WILL NOT be batched for
write into VRFEntry Config DataStore.

6. All the external routes imported from BGP, WILL BE batched and
written to VRFEntry Config DataStore.

Change-Id: I3109516e8d163f2b61ba49acc463b85b09bbaf85
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
7 years agoFix for DHCP with Metadata 45/42545/1
Oded Shvartz [Tue, 26 Jul 2016 08:18:54 +0000 (11:18 +0300)]
Fix for DHCP with Metadata

Fixing patch https://git.opendaylight.org/gerrit/#/c/40518/
The patch does not work after changes on the dhcpservice
module for adding support in dhcp as a service.

Change-Id: Ie77a85bc3c3cfa74e72b2e681863ba0105f8520c
Signed-off-by: Oded Shvartz <oshvartz@redhat.com>
7 years agoClean up programDhcpMatches() 96/42496/2
Stephen Kitt [Mon, 25 Jul 2016 17:36:35 +0000 (19:36 +0200)]
Clean up programDhcpMatches()

The method as it currently stands is rather opaque: using it requires
knowing how it works, since the data structure it returns needs to be
completed. This patch replaces it with two methods whose return values
can be used as-is.

Change-Id: Ibf420a6a37d9aa06a6d7ececc98088cfb6f2dd14
Signed-off-by: Stephen Kitt <skitt@redhat.com>
7 years agoMerge "Remove unused netvirt dependencies"
Sam Hague [Mon, 25 Jul 2016 22:44:49 +0000 (22:44 +0000)]
Merge "Remove unused netvirt dependencies"

7 years agoMerge "Fix for SingleFeatureTest wiring for neutron model"
Sam Hague [Mon, 25 Jul 2016 22:44:38 +0000 (22:44 +0000)]
Merge "Fix for SingleFeatureTest wiring for neutron model"

7 years agoMerge "code refactor for aclservice"
Sam Hague [Mon, 25 Jul 2016 17:38:49 +0000 (17:38 +0000)]
Merge "code refactor for aclservice"

7 years agoRemove unused netvirt dependencies 90/42490/1
Sam Hague [Mon, 25 Jul 2016 14:49:14 +0000 (10:49 -0400)]
Remove unused netvirt dependencies

Change-Id: Ieba4657ff0e91229f984f2abf13153435136f8bc
Signed-off-by: Sam Hague <shague@redhat.com>
7 years agoFix for SingleFeatureTest wiring for neutron model 87/42487/1
Sam Hague [Mon, 25 Jul 2016 14:31:01 +0000 (10:31 -0400)]
Fix for SingleFeatureTest wiring for neutron model

Change-Id: I79f9ec0cff800e5f4c1fba6271217beed81617aa
Signed-off-by: Sam Hague <shague@redhat.com>
7 years agocode refactor for aclservice 21/42121/5
gujele [Wed, 20 Jul 2016 06:35:04 +0000 (12:05 +0530)]
code refactor for aclservice

1. remove dupliate code in EgressAclServiceImpl and IngressAclServcieImpl
by using base class
2. constants are moved from AclServiceUtils to AclConstants
3. classes are moved to meaningful packages
4. class names are changed to make it more meaningful

Change-Id: If51e1a83db45d04c871799b563490c81a3573161
Signed-off-by: gujele <imanilyadav@gmail.com>
7 years agoAdding cloud-servicechain module 84/42384/2
Abhinav Gupta [Sat, 23 Jul 2016 12:28:29 +0000 (17:58 +0530)]
Adding cloud-servicechain module

Change-Id: I1e51d98de366243ee0209b25ad204e164e62dad7
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>
7 years agoMerge "NeutronVPN: Acquire lock from local JavaVM"
Sam Hague [Mon, 25 Jul 2016 11:45:49 +0000 (11:45 +0000)]
Merge "NeutronVPN: Acquire lock from local JavaVM"

7 years agoNeutronVPN: Acquire lock from local JavaVM 41/42441/1
Abhinav Gupta [Mon, 25 Jul 2016 06:58:05 +0000 (12:28 +0530)]
NeutronVPN: Acquire lock from local JavaVM

Change-Id: I440698628ce5bfc1fae42b1055b4e66da2d7b490
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>
7 years agoUpstreaming changes in netvirt 40/42440/1
Suraj Ranjan [Mon, 25 Jul 2016 06:57:32 +0000 (12:27 +0530)]
Upstreaming changes in netvirt

This commit includes following changes:

1> Fixing Port Up/Down Event handling for ELAN
2> Parallelization done in Arpcache

Parallelization of adding and removing arp cache done with the help of
DataStoreJobCoordinator.

Change-Id: Ic017bdc7165042550ad1046b55131854689a221a
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
7 years agoAdd NetvirtItUtils.verifyFlowByFields 05/42405/1
Josh [Sun, 24 Jul 2016 14:13:27 +0000 (16:13 +0200)]
Add NetvirtItUtils.verifyFlowByFields

This method checks that, for a flow which
exists in config, a flow with the
same priority and match fields exists in
operational. The flow is retrieved from
configuration datastore by flow-id and
then compared to flows in the operational
until a match is found...or not.

Change-Id: I4d1b55ec97dc22baccbc37618b5ad868983a555a
Signed-off-by: Josh <jhershbe@redhat.com>
7 years agoMultiple fixes in various modules 83/42383/2
Suraj Ranjan [Sat, 23 Jul 2016 07:19:44 +0000 (12:49 +0530)]
Multiple fixes in various modules

This review includes following fixes or changes:

1> BGPManager using the batching infrastructure
to batch and apply VRFEntries to Config DS.
(both bgp advertisement and bgp withdrawals).

2> FibManager using the batching infrastructure
to batch and apply flow rules to Inventory Config DS.

3> VPN Refactoring - Concurrency for VPNInterfaceManager

4> Changed the code in dhcpservice such that we add only
direct and macvtap vnic_type to the neutron port cache.

5> Fix for bgp display commands to work in COMCLI

Change-Id: Ib0c0e8515f61e299fa49ef3d432232ce4f3313d7
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
7 years agoAdd missing license headers 76/42376/2
Thanh Ha [Sat, 23 Jul 2016 03:04:25 +0000 (23:04 -0400)]
Add missing license headers

Change-Id: I1c04ef692375fdc741858b77c1ae76b985da3721
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
7 years agoFix build broken due to Checkstyle, and prepare for more CS to come 48/42348/2
Michael Vorburger [Fri, 22 Jul 2016 22:41:08 +0000 (00:41 +0200)]
Fix build broken due to Checkstyle, and prepare for more CS to come

preparing for https://git.opendaylight.org/gerrit/#/c/41305/ with:
* Utility classes should have private constructor
* potential future problems re. hidden fields
* inner assignments

and also for the just merged
https://git.opendaylight.org/gerrit/#/c/40957/, which I think that
something here just got added and missed in the verification for
c/40957, so was about to cause build failures - so this one urgently
needs to get merged ASAP!

Change-Id: I4b608fa1501ff758527672fdd9569afe36933cfd
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoMerge "Bug 6066 - Improve the logging."
Sam Hague [Fri, 22 Jul 2016 12:10:29 +0000 (12:10 +0000)]
Merge "Bug 6066 - Improve the logging."

7 years agoMerge "Fix Sonar (soon Checkstyle) constant name"
Sam Hague [Fri, 22 Jul 2016 10:28:03 +0000 (10:28 +0000)]
Merge "Fix Sonar (soon Checkstyle) constant name"

7 years agoMerge "BGPManager FIXMEs fixed"
Vishal Thapar [Fri, 22 Jul 2016 07:00:46 +0000 (07:00 +0000)]
Merge "BGPManager FIXMEs fixed"

7 years agoMerge "Vpnmanager module sync up"
Sam Hague [Thu, 21 Jul 2016 20:52:57 +0000 (20:52 +0000)]
Merge "Vpnmanager module sync up"

7 years agoMerge "Update eos to use service module: entity-ownership-service"
Sam Hague [Thu, 21 Jul 2016 20:52:10 +0000 (20:52 +0000)]
Merge "Update eos to use service module: entity-ownership-service"

7 years agoBug 6066 - Improve the logging. 61/42261/1
ananthip [Thu, 21 Jul 2016 15:22:37 +0000 (11:22 -0400)]
Bug 6066 - Improve the logging.

Change-Id: Ia695cde0f870768d85405d389a85d77fd636e46f
Signed-off-by: ananthip <ananthip@hcl.com>
7 years agoVpnmanager module sync up 41/42241/2
Kiran N Upadhyaya [Thu, 21 Jul 2016 14:00:39 +0000 (19:30 +0530)]
Vpnmanager module sync up

This commit contains upstreaming of VpnManger module alongwith dependent
commits into fibmanager and neutronvpn manager

Change-Id: I631d9f3652c863180804cdf426d15e6e3ea1cfbc
Signed-off-by: Kiran N Upadhyaya <kiran.n.upadhyaya@ericsson.com>
7 years agoFix Sonar (soon Checkstyle) constant name 53/42253/1
Michael Vorburger [Thu, 21 Jul 2016 17:20:30 +0000 (19:20 +0200)]
Fix Sonar (soon Checkstyle) constant name

Change-Id: Ia847fb0413ea59ac5aa75af72ab7f7857e16eb57
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoUpdate eos to use service module: entity-ownership-service 31/42231/2
Sridhar Gaddam [Thu, 21 Jul 2016 12:17:55 +0000 (17:47 +0530)]
Update eos to use service module: entity-ownership-service

Change-Id: I2462838f0845e1343a3bb4c9936616e4e3868f66
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
7 years agoMerge "Finish renaming odl-netvirt-vpnservice features."
Sam Hague [Thu, 21 Jul 2016 13:36:45 +0000 (13:36 +0000)]
Merge "Finish renaming odl-netvirt-vpnservice features."

7 years agoBGPManager FIXMEs fixed 24/42224/1
Abhinav Gupta [Thu, 21 Jul 2016 09:44:40 +0000 (15:14 +0530)]
BGPManager FIXMEs fixed

SInce odl-fib.yang is updated now, dependent classes in FIB are available,
hence the FIXMEs have been fixed.

Change-Id: Id845e4eab2428c62b32fee1388bc64566b2953fa
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>
7 years agoFinish renaming odl-netvirt-vpnservice features. 87/42187/1
Andre Fredette [Tue, 19 Jul 2016 21:58:13 +0000 (17:58 -0400)]
Finish renaming odl-netvirt-vpnservice features.

Change-Id: I21a03c992e91ada7cd6d0764d0c8aaf01e7aa408
Signed-off-by: Andre Fredette <afredette@redhat.com>