Remove findbugs support

FindBugs is obsolete, does not work with JDK9+ and replaced by
SpotBugs. Remove it from all declarations.

JIRA: ODLPARENT-186
Change-Id: Id8237ac38f8291954d041b0d4ca3becb5aea89ef
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 5.0.0-SNAPSHOT

This bumps versions for Sodium development.

Change-Id: I280c718472237e47b381f617d68c0a247afc07f1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add a fix for KARAF-5086

This is manual upgrade of aries/proxy-impl to make it work with
Java 8 default methods.

Change-Id: I05ad26c2608bb76f4482e231cf5d07e0016f7082
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit fe6f26cbf3ced523b8251e7a9a8c48cd10441cb4)

Bump commons-codec 1.11 → 1.12

Release notes:
http://www.apache.org/dist/commons/codec/RELEASE-NOTES.txt

Change-Id: I2fe5fcf57885b562a5d63859440aa15428ebbe90
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump to h2 1.4.198

Changelog: http://www.h2database.com/html/changelog.html

This fixes at least one security issue (CVE-2018-14335).

Change-Id: I41c7157a85324dc1321f69f92eca491c1edefc8f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump to Bouncy Castle 1.61

Release notes: http://www.bouncycastle.org/releasenotes.html

Change-Id: I6852d79b546f822c992ed78ad6741dc3bf7b7311
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump apache-sshd to 2.2.0

https://github.com/apache/mina-sshd/compare/sshd-2.0.0...sshd-2.2.0

Fixes important to us are:
https://issues.apache.org/jira/browse/SSHD-840
https://issues.apache.org/jira/browse/SSHD-846

Change-Id: Ibceff00b84adce003595042fcfca001bbaecca47
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

ODLPARENT-197: META-INF services are not packaged

- We need to count META-INF services generated by annotations like
  @AutoService or @MetaInfServices.

Change-Id: Iebc421778f2894c6bef998ff371f06c1a5db24e1
Signed-off-by: Jie Han <han.jie@zte.com.cn>

Bump akka, aeron, agrona to 2.5.21, 1.15.3, 0.9.33

https://akka.io/blog/news/2019/01/29/akka-2.5.20-released
https://akka.io/blog/news/2019/02/13/akka-2.5.21-released

https://github.com/real-logic/aeron/releases/tag/1.13.0
https://github.com/real-logic/aeron/releases/tag/1.14.0
https://github.com/real-logic/aeron/releases/tag/1.15.0
https://github.com/real-logic/aeron/releases/tag/1.15.1
https://github.com/real-logic/aeron/releases/tag/1.15.2
https://github.com/real-logic/aeron/releases/tag/1.15.3

https://github.com/real-logic/agrona/releases/tag/0.9.28
https://github.com/real-logic/agrona/releases/tag/0.9.29
https://github.com/real-logic/agrona/releases/tag/0.9.30
https://github.com/real-logic/agrona/releases/tag/0.9.31
https://github.com/real-logic/agrona/releases/tag/0.9.32
https://github.com/real-logic/agrona/releases/tag/0.9.33

Change-Id: I8368a58a8c371e4c3e042399abcb41bca96901ea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add osgi.cmpn declaration

The artifact name for OSGi Compendium has changed with release 6.0.0,
this patch provides the new definition so downstreams can seamlessly
migrate.

Change-Id: I1b1a23713bfa3670e422f2e6f97e8b2066804f0e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update org.apache.logging.log4j dependencycheck

This declaration was not updated when we bumped, fix that up.

Change-Id: Ida641027c1f1f54ca012757bda67cecc085f2940
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump antlr to 4.7.2

https://github.com/antlr/antlr4/releases/tag/4.7.2, most significant
is the inclusion of automatic module names.

Change-Id: I1ea0fd53943b2332abdb33f8f7c88a8699bde237
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to log4j 2.11.2

Release notes:
https://github.com/apache/logging-log4j2/blob/log4j-2.11.2/RELEASE-NOTES.md

Change-Id: I1e6f18f0b1b8d21d449beca33743904bd2785b0c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

bump maven-invoker-plugin from 3.1.0 to 3.2.0

Bumps [maven-invoker-plugin](https://github.com/apache/maven-invoker-plugin) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/apache/maven-invoker-plugin/releases)
- [Commits](https://github.com/apache/maven-invoker-plugin/compare/maven-invoker-plugin-3.1.0...maven-invoker-plugin-3.2.0)

Change-Id: I785538c04acb726ff224d0f9178299e2b826a65a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump jacoco-maven-plugin from 0.8.2 to 0.8.3

Notable changes from the linked Release Notes include that
"JaCoCo now officially supports Java 11".

Bumps [jacoco-maven-plugin](https://github.com/jacoco/jacoco) from 0.8.2 to 0.8.3.
- [Release notes](https://github.com/jacoco/jacoco/releases)
- [Commits](https://github.com/jacoco/jacoco/compare/v0.8.2...v0.8.3)

Change-Id: I771424043515944bb2d367ceb225d75ddb888fd4
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump netty to 4.1.33

https://netty.io/news/2018/11/29/4-1-32-Final.html
https://netty.io/news/2019/01/21/4-1-33-Final.html

Change-Id: I22d9459744a152f5c273bacaa32fcb938aa6bf1f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix javadoc-links with plugin-3.0.1

maven-javadoc-plugin has a bug which prevents non-redirecting links
from working. This adds a workaround forcing redirects to happen.

Change-Id: Id9ace69f6fce4d645eeaebf636a9433aa779f397
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update junit javadoc link

Javadocs have moved, the old site does not exist anymore, update
the link accordingly.

Change-Id: I9344f25cb24bb8812cff9d52192ce7eb5d2f3528
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add javadoc-links property activation

There is a distinct case when we want to explicitly activate
the profile in certain poms. Add a property activation to allow
doing that.

Change-Id: If55913b1c94dd8d7b6298fdf4ff5d4f59727b641
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump h2 database to 1.4.197

This includes a ton of fixes, the changelog is at
http://www.h2database.com/html/changelog.html

Change-Id: I300ee7a57ea36bc0a0cfa839f6ddea26ea3f2dd9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump version to 4.0.10-SNAPSHOT

This starts the next development cycle.

Change-Id: Iaf15eab2e3318de7e03fc97c4f2d7cb056d7f418
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add Woodstox to the release notes

Change-Id: Ie5c6d644e464ac117a1cbd79b9039efeb486bad0
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Revert "Update the 4.0.8 release notes"

This reverts commit 551259dbdaf1a86f22988b9f0f4787949b17126f.

Change-Id: Iedab8cc2c0690fe5cd85e983af481c0cfddaff48
JIRA: ODLPARENT-184
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Restore "Add SLF4J dependency for SpotBugs"

This reverts commit 08eb264e99cec9af128fcd87c732c40188b60a9c; the
SLF4J 1.8 dependency is carried by SpotBugs 3.1.9, so we do need
this.

Change-Id: Ia6789cc9be29f2ac5d83c73bbe893c34dc68216e
JIRA: ODLPARENT-184
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add odl-woodstox

This is a StAX implementation used by jackson, and forced on us
through Karaf. It contains useful utilities, hence make it available
as a separate feature.

Change-Id: I0df2faefe7522dbe7d02187d179334b44acfcef5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneeded javax.ws.rs-api dependency

jackson does not need to spell this out, it is provided by
odl-ws-rs-api feature, which we pull as dependency.

Change-Id: I333bce0f62fda6c7beb3b5ccfe8df724c32e2312
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove hibernate-validator-osgi-features hack

We have moved on to a karaf version which does not need this hack,
remove it.

Change-Id: Icb67a337cc739c2aba83777c70c850dfc26ac89d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update dependency-check

This is a refresh after running update-dependencies.

Change-Id: I64cfbaeff5d95667e3129440e87d008ad563fd49
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Update 4.0.9 release notes

This adds the news bits about karaf packaging.

Change-Id: I84a7e4526350f12e9c155aae0456b026161c6948
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add feature descriptions

<description/> stanzas are propagated to feature details,
override the default specified to odlparent-lite.

Change-Id: Idc2b700d2057914fd4e27177e877150720da7805
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneded artifact.toString()

Logger will call toString() if needed, remove the explicit call.

Change-Id: I169e98bc7a04390f56503666782ac1bdb7413b61
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove local artifacts after merging features

features.cfg has references to some features, which we are probably
patching, hence we need to merge them before we perform removal
of artifacts from install request.

Change-Id: I42fad1a7eff17778dccdfdd8c0936c2aa35606b4
JIRA: ODLPARENT-194
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Allow karaf-plugin version to be overridden

Us hard-coding the version here prevents downstreams from
using dependencyManagement section to override the version.

Make sure we use dependencyManagement, which can easily be
overridden.

Change-Id: Ib644b5e0a56e13236730cfb07a8eb853886dfd14
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove local artifacts from install request

Since we may have artifacts in the local repository which have
modifications, we do not want to include them in the install
request.

Make sure we exclude such artifacts.

Change-Id: Ib468cac841875e13124ead73c9f8911a29caa2ff
JIRA: ODLPARENT-194
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not read feature twice

We have already read the feature, there is no point in unmarshalling
it yet again.

Change-Id: Id34dc83165b0479e12abdb915ec8dc42cfa9853a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Start 4.0.9

Change-Id: Ic579cb62ca8159c603d506f26dee61ccdd1dd278
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Update the 4.0.8 release notes

... with the SLF4J / SpotBugs revert.

Change-Id: I085c79e854dacd98c4ee3287ec1b6a78bfcb0748
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Revert "Add SLF4J dependency for SpotBugs"

This reverts commit 105806df6324df4d9f6db145f3631b44aeff0a0d which is
irrelevant now that the SpotBugs bump has been reverted.

Change-Id: Ie02967cd10908d994351f06532e89dbfe0dde7f5
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Release notes for 4.0.8

Change-Id: Iab9e444ceb3b397600081a62c22ac0c6f991841e
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Revert "Bump SpotBugs 3.1.9 → 3.1.10"

This reverts commit 8119cd6455c1c4524671eb69c6274b0780f8cc4d. The
stricter NP_METHOD_PARAMETER_TIGHTENS_ANNOTATION check causes build
failures in other ODL projects.

Change-Id: I333e5e9a9870e1756462520dcba86b89a4a77972
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump commons-fileupload 1.3.3 → 1.4

Release notes:
http://www.apache.org/dist/commons/fileupload/RELEASE-NOTES.txt

Change-Id: If828c54b89dca8dcfb0a7cf51ab97e59c563fd24
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add SLF4J dependency for SpotBugs

The SpotBugs Maven plugin is built with SLF4J 1.8 beta 2, so we need
to give it the appropriate SLF4J implementation (our 1.7 doesn’t work
with it).

JIRA: ODLPARENT-184
Change-Id: I1693928f1a15217aa7a7592e03a81634009ab0b1
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Revert to Immutables 2.7.3

Release 2.7.4 produces invalid Javadocs which break our build (see
https://github.com/immutables/immutables/issues/890 for one example).
This patch reverts to 2.7.3 which produces valid Javadocs. Release
2.7.5 should also be usable; the current snapshot works fine.

Change-Id: Idae6f726080e00197753e2ac93fc062b66670c1c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Avoid pulling old versions

This uses karaf-plugin’s ability to resolve patched features to
upgrade the versions of javax.mail, commons-beanutils, commons-codec
and aries.util pulled in by Karaf and Pax.

We need to change the order of steps in karaf4-parent so that the
Karaf assembly is processed first, then the resources overwritten with
our versions, before karaf-plugin resolves the dependencies.

JIRA: ODLPARENT-189
Change-Id: Id78d7301bd402bc6872fe8a696af9ddc734cbe8d
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Prefer local features

PopulateLocalRepoMojo should prefer features from the local repository
(the Karaf installation repository, typically) to those in the system
repositories: this allows features to be patched, and the patches
taken into account when resolving dependencies.

(Adding the local repository to Aether’s repositories doesn’t have the
intended effect, because the feature dependencies have generally
already been resolved, and are resolved again from the cache when
PopulateLocalRepoMojo runs.)

JIRA: ODLPARENT-189
Change-Id: I232115e0fcdef1ae17c22a17028021f825573e31
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

bump git-commit-id-plugin from 2.2.5 to 2.2.6

Bumps [git-commit-id-plugin](https://github.com/ktoso/maven-git-commit-id-plugin) from 2.2.5 to 2.2.6.
- [Release notes](https://github.com/ktoso/maven-git-commit-id-plugin/releases)
- [Commits](https://github.com/ktoso/maven-git-commit-id-plugin/compare/v2.2.5...v2.2.6)

Change-Id: I2ebaad17d469e3bb6afe09eee113c489be4d5054
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump dependency-check-maven from 4.0.0 to 4.0.2

Bumps [dependency-check-maven](https://github.com/jeremylong/DependencyCheck) from 4.0.0 to 4.0.2.
- [Release notes](https://github.com/jeremylong/DependencyCheck/releases)
- [Changelog](https://github.com/jeremylong/DependencyCheck/blob/master/RELEASE_NOTES.md)
- [Commits](https://github.com/jeremylong/DependencyCheck/compare/v4.0.0...v4.0.2)

Change-Id: Ibc164b047e723ed9caa3fb11d5452376012fb564
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add enunciate-maven-plugin declaration

maven-enunciate-plugin is dead, this patch adds the declaration
for its replacement enunciate-maven-plugin.

Also remove superfluous copy&paste annotation exclusion and mark
old annotations and plugin for removal.

Change-Id: Iee3131019893c5dfad4718d4ed35628cd60ede39
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add odl-dropwizard-metrics

This adds dependency declaration for io.dropwizard.metrics-4.0.5
and also a basic wrapper feature, which provides core, JMX reporter,
healthcheck support and JVM metrics.

Change-Id: If0356b4d6746f95824f30d19323ca286aa7fe857
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rework BouncyCastle/OSGi integration

We are packaging BC jars twice, once in lib/boot for the purposes
of having the provider set by karaf's Main class and second time
to expose them to OSGi world via startup.properties as normal bundles.

This is required because the boot classpath is not exposed directly
into OSGi world and thus bundles linking to BC would not be able
to find correct exports.

An alternative would be to specify all the packages through
org.osgi.framework.system.packages.extra, but that has the downside
of being static and requiring maintentance.

This patch takes the route of Framework Extension Bundles, where
it provides two fragment bundles, which attach to system.bundle,
which itself has access to the boot class loader -- hence they
can themselves contain appropriate Export-Package instructions.

We generate these instructions from upstream bundles by unpacking
their manifest and retaining only Export-Package instruction (via a
simplistic maven plugin) and feeding this as input into
maven-bundle-plugin.

JIRA: ODLPARENT-185
Change-Id: I5cbfc9a499aa117581004585f4fa5283f65a5a38
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove obsolete patched dependencies

karaf4-parent pulls in a number of dependencies which we used to patch
in the underlying feature files; but the upstream features have since
been updated and we no longer patch them, which means we no longer
need to manually depend on these artifacts.

Change-Id: I67c5d7377b5ac85d51b5934e83adc8d90f0d0233
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Enable SpotBugs

Change-Id: Ic8c3237c2f3cda75387af6d2220d401d1c357de6
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Warn on duplicate feature dependencies

When PopulateLocalRepoMojo encounters multiple versions for the
dependencies pulled in through features, it now warns about them.

JIRA: ODLPARENT-189
Change-Id: I916e3dc47e109da9f727eff27b530796649a0218
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Checkstyle 8.15 → 8.16

Release notes: https://checkstyle.org/releasenotes.html#Release_8.16

Change-Id: I1ec37b0a77c05a0458683eecf4f442398a68be57
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump immutables.org to 2.7.4

https://github.com/immutables/immutables#272-2018-11-05
https://github.com/immutables/immutables#273-2018-11-10
https://github.com/immutables/immutables#274-2018-12-26

Change-Id: Iad67173c83c37965c0bb15381166281cffe5938a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add javax.annotation-api declaration

This is another package which karaf provides and Java 11 does not,
which means downstreams need to declare a dependency and we need
to filter it from features.

Change-Id: Id70b29ca3c25b07a8a1a79b92b8e133012c099d6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove javadoc link detection

Enabled detection, while working, is troublesome, throwing a bunch
of errors.

Remove the override, as downstreams can control this trivially
via detectLinks user property. Also remove detectOfflineLinks=true,
as it is the default.

Change-Id: I3839592b391abee7da1cfd388538662e07e77228
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Switch to Maven plugin annotations

This uses plugin annotations instead of Javadoc-based Mojo setup.

Change-Id: Ib3272ec24b7253f9a4a0989ce854cb7847ec0aec
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump SpotBugs 3.1.9 → 3.1.10

... with the associated plugin.

Release notes:
https://github.com/spotbugs/spotbugs/blob/d13e4210b8a5148714ced2562325742fc1fb1baf/CHANGELOG.md

Change-Id: I1b5f0bdd555864ffb82dcfdadd2174c367bc6fe8
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Enforce Checkstyle in karaf-plugin

... and fix the flagged problems.

Change-Id: Ic9620bc2e000f36f54aaa411d97feb5a428f561a
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Jackson 2.9.7 → 2.9.8

Release notes:
https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.9.8

Change-Id: I53c5c5392900bc6996f2b223742fc5298e09b221
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Release notes for 4.0.7

Change-Id: Ibc14d1949f2e5f4e348d5a1110d260065757ef0a
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Release notes for 4.0.6

Change-Id: Ia975f99b3db56fb7451d6e0ed465c8f0da23f608
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Release notes for 4.0.5

Change-Id: I29d70467ba77e0a0cb1631571f403c6d8eb2b906
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Release notes for 4.0.4

Change-Id: Ib86da7d74f1097ad04beb48f3d19e957e6d8e8d1
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Release notes for 4.0.3

Change-Id: I6fff0426ddcb9ccd69fa49add3a2dc8bc9fab2de
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add jaxb-{core,impl}

Java 11 does not ship JAXB, hence downstreams need to pull it in
themselves. Add declarations matching recent Java 8 builds.

Change-Id: I1b32b7a345f3f7a4dfe1f6c663c9db4f30beea26
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add triemap dependency check

This will prevent any breakage from creeping in, like it did
in odlparent-4.0.6.

Change-Id: I39f67a388fb20095b0ccc863b68abcee69f7fd67
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Install BouncyCastle in lib/boot

JDK9 has removed JVM extension mechanism, which leads to jars
present in lib/ext not being accessible by the Main class -- which
we are using to add the provider.

Rather than using lib/ext, use lib/boot, putting the jars onto
the boot class loader.

JIRA: ODLPARENT-183
Change-Id: I32abbc53fa7ca80c2850e9e29fe5991b1193c553
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove duplicate BC provider jars

bcprov-ext-jdk15on is a superset of bcprov-jdk15on, additionally
containing NTRU algorithm. Do not drop both jars into lib/ext,
reducing our distribution by ~4MB.

Change-Id: I66358840fb930d6dbf2d21fee1d1581deab7ad78
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up karaf-4.2.2/JDK9 options

This reworks the workaround to use OptionUtils and
dynamically-determined karafVersion.

Change-Id: I5b46a5b8dd5aed42aeebcb5d7ae2c8238c2a0167
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enable detectLinks in javadoc

We have bumped javadoc plugin to 3.0.1 without removing the workaround
for MJAVADOC-427, which is fixed in that release.

Flip the switch, addressing the TODO.

Change-Id: I881c4750deb45d402c38ba8b0dd2a23e57c567e9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 4.0.8-SNAPSHOT

This starts the next development iteration.

Change-Id: I0acc47ae0b674b692afc280241b8c6e83307420e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix triemap dependency declaration

The declaration is missing type=pom, fix that.

Change-Id: Ide9249a081f255c429e46f69fe9bc2f5d66e6587
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 4.0.7-SNAPSHOT

This starts the next development iteration.

Change-Id: I3f683f163298b71742bc8777c1d430ccb3e2bcc6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Import triemap bom

triemap is used by yangtools and controller, make sure we declare
the version from odlparent.

Change-Id: Ifa2aeac691a4aac7e79424feb73d2d535c6df0e5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add JDK9+ karaf configuration

karaf-4.2.2 and later needs additional JVM configuration to work
with JDK9+, otherwise it fails to boot.

This patch adds that configuration based on Karaf's ExampleITest.

Change-Id: I547329afb1fdad990a4a13b8001be78f7c676497
JIRA: ODLPARENT-182
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add a maven central bandge

Now that odlparent is published to central, we can add a nice badge
for github users. While we're at it, also add a license badge.

Change-Id: I585110574ce247d381cf38547dcbb9dd65cc6381
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 4.0.6-SNAPSHOT

Change-Id: Ib40d10492acdac7dbd1ba09f4013add5e8c0752d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Fixup karaf4-parent installation"

This reverts commit 2d60028313174d77710753a6b07790e9b3bcf1c2,
as it does not help at all.

Change-Id: I50163d9b41ae1cac9a49563fa9bd0e707c2a2878
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Restore Karaf deployments

karaf-maven-plugin 4.2.2 breaks installation of Karaf archives: the
POM is deployed with a ZIP extension. This patch reverts to 4.2.1 only
for karaf4-parent, fixing the issue temporarily.

Change-Id: Ie06c65d673b0d1782a1e9f0878f27c86886828da
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Fixup karaf4-parent installation

It would seem karaf-plugin-4.2.2 does not correctly work with
maven-install-plugin-2.5.2, resulting in pom.xml being installed
as .zip, breaking downstreams.

Bump maven-install-plugin (and deploy-plugin) in karaf4-parent
to 3.0.0-M1 in an attempt to fix the issue.

Change-Id: Iae551ba413a5b6b183ef666258db15b184824218
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Start odlparent 4.0.5-SNAPSHOT

Change-Id: I9ac6066d0db631ecfc03e5507e82c212d5012df3
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Revert "Support building without zip archives"

This reverts commit dd16e4611811b9fc7add790bf364f805d2795b93, which
breaks builds on our infrastructure (without the empty Karaf
archive).

Change-Id: I8f6cb74c97a827175f8bd6089c6b9a5217aae78e
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Start odlparent 4.0.4-SNAPSHOT

Change-Id: Id6f1c7d0dfe0eba65cfdd2499df0372fb183e43e
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump karaf to 4.2.2

https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12343458&projectId=12311140

Also align versions:
- ow2.asm 6.2.1 -> 7.0
- org.apache.felix.metatype 1.2.0 -> 1.2.2
- pax-web-api 7.2.2 -> 7.2.5
- jetty 9.4.11.v20180605 -> 9.4.12.v20180830
- blueprint-core 1.9.0 -> 1.10.1
- jaxb-api 2.2.1 -> 2.2.8

Change-Id: I137a33da4ad55fe8b81f4f006c939aca809a080c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Recognize Sonar build

Sonar jobs are running with -Dsonar, which is a clue for us to
disable various plugins, which do not affect the result of the
analysis.

Change-Id: I0e1ee1392703b7b1efd96d3eb91d7367130abf59
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump pax-exam to 4.13.1

https://ops4j1.jira.com/issues/?jql=project+%3D+PAXEXAM+AND+fixVersion+%3D+4.13.0
https://ops4j1.jira.com/issues/?jql=project+%3D+PAXEXAM+AND+fixVersion+%3D+4.13.1

Change-Id: I635b1285e87c4128034eb9005cb75a4c17648909
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-jar-plugin to 3.1.1

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317526&version=12343046

Change-Id: I30ed94901baa0d5172fea2609590745cd50e6f47
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-help-plugin to 3.1.1

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317522&version=12343422

Change-Id: I7cb2cfa560ed27eb32bf71b8b969035efe2ee045
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Constrain dependencies for convergence

This adds a number of third-party artifacts to dependency management,
in order to control dependency convergence. These artifacts are used
in various versions by other third-party dependencies; by constraining
them (to mutually-compatible versions), we can then hope to enforce
dependency convergence.

Change-Id: Ifa7bd7fb5252958f3ca51d3a648a7d595bfdf119
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Teach top-level aggregator about jacoco/sonar

This adds the profile to merge all jacoco reports, so that sonar
job can use the aggregated file.

Change-Id: Ica0f7f5052670fe3619e4dfbd003147d3bd5b5b1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Switch to LevelDB 0.10

Akka Persistence now expects LevelDB 0.10, switch to that. Drop the
0.7 artifact from the feature repository to avoid dependency
convergence issues. (We still ship the old artifact to preserve
backwards compatibility.)

Change-Id: Id104805879a70576eafc55c4acc8f2d57a54c1a1
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump akka to 2.5.19

https://akka.io/blog/news/2018/08/24/akka-2.5.15-released
https://akka.io/blog/news/2018/08/29/akka-2.5.16-security-fix-released
https://akka.io/blog/news/2018/09/27/akka-2.5.17-released
https://akka.io/blog/news/2018/10/07/akka-2.5.18-released
https://akka.io/blog/news/2018/12/07/akka-2.5.19-released

This also bumps dependencies for alignment:
- ssl-config to 0.3.6:
https://github.com/lightbend/ssl-config/milestone/9?closed=1
https://github.com/lightbend/ssl-config/milestone/10?closed=1
https://github.com/lightbend/ssl-config/milestone/11?closed=1
https://github.com/lightbend/ssl-config/compare/v0.3.4...v0.3.6

- aeron to 1.12.0:
https://github.com/real-logic/aeron/releases/tag/1.10.0
https://github.com/real-logic/aeron/releases/tag/1.10.1
https://github.com/real-logic/aeron/releases/tag/1.10.2
https://github.com/real-logic/aeron/releases/tag/1.10.3
https://github.com/real-logic/aeron/releases/tag/1.10.4
https://github.com/real-logic/aeron/releases/tag/1.10.5
https://github.com/real-logic/aeron/releases/tag/1.11.0
https://github.com/real-logic/aeron/releases/tag/1.11.1
https://github.com/real-logic/aeron/releases/tag/1.11.2
https://github.com/real-logic/aeron/releases/tag/1.11.3
https://github.com/real-logic/aeron/releases/tag/1.12.0

- agrona to 0.9.27:
https://github.com/real-logic/agrona/releases/tag/0.9.22
https://github.com/real-logic/agrona/releases/tag/0.9.23
https://github.com/real-logic/agrona/releases/tag/0.9.24
https://github.com/real-logic/agrona/releases/tag/0.9.25
https://github.com/real-logic/agrona/releases/tag/0.9.26
https://github.com/real-logic/agrona/releases/tag/0.9.27

Change-Id: Ib528e5c63526c6f1355f07e99690c0d6c0b2bcea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump xtend to 2.16.0

The full release of xtend is available in maven central, bump
to it instead of M3 build.

Change-Id: I12934fb2bc393903c25e64b8af80aa9f5e09ee85
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump asciidoctorj-diagram 1.5.10 → 1.5.11

Change-Id: Ifc81dedae5f33f32763d5dc3ca3129be992ab88c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump scala to 2.12.8

https://github.com/scala/scala/releases/tag/v2.12.8

Change-Id: I4a223c20b643d341ce8f3489ef1ecb11b0af8823
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Disable NPE NULL check

As noted https://github.com/spotbugs/spotbugs/issues/756,
this check is triggered by Java 11's desugraing of try-with-resources.

Change-Id: If826874c3023c85edcd40294329f6fff29ba66df
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Checkstyle 8.14 → 8.15

Release notes: https://checkstyle.org/releasenotes.html#Release_8.15

Change-Id: I6cb04fc68e637591338eeee7934363fbd355e101
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Checkstyle 8.13 → 8.14

Release notes: https://checkstyle.org/releasenotes.html#Release_8.14

Change-Id: I003d58aa9b6f70e32ab61d1ce2cbf18f2bf70a80
Signed-off-by: Stephen Kitt <skitt@redhat.com>