SFC UI cosmetic fixes

- cosmetic fixes in SFC UI

Change-Id: I4049941f1f656fc3fb14c60107f0cce946547437
Signed-off-by: Stanislav Jamrich <[email protected]>

Yang model for Abstract Type Definition of Service Functions

Change-Id: I1f460577a043091d3f5d8d20e0d2b2b7171cdc41
Signed-off-by: Ricardo Noriega <[email protected]>
Signed-off-by: Keith Burns (alagalah) <[email protected]>

Fixed tests using default value

- fixed tests based on change
https://git.opendaylight.org/gerrit/#/c/28251/

Change-Id: Ifbdc51ed7dd68ac5b2c8e4b56260643880e59134
Signed-off-by: Martin Sunal <[email protected]>

Add code style check

Change-Id: I153bee1a32f342401cff2c2c2ccbd49709d894aa
Signed-off-by: Ruijing Guo <[email protected]>

Add NSH C3 C4 move action

Change-Id: I184e4ee48bf072f017037207c7a0e614df8ee0b3
Signed-off-by: Ruijing Guo <[email protected]>

Merge "Yin files creation fix"

Merge "Fix for ACL YANG changes"

Fix for ACL YANG changes

- URI sent to iptables classifier changed, yet Task sending old one.

Change-Id: If87041312fc6fe9b5070a81009b1d8e6ff2ea5b0
Signed-off-by: Keith Burns (alagalah) <[email protected]>

Adding sequential path generation algorithm.

- Random generation breaks sfcofl2 vlan demo
- Also added impl code for the service path id RPCs
- Sequential generation Unit tests included

Change-Id: If65a71f4f33cc4a89f9b527366c987967dfc928b
Signed-off-by: Brady Johnson <[email protected]>

Feature clean up

- centralised and homogenised
- removed openflowplugin-all and netconf-all !!!!
- no more spurious log messages during startup
- removed un-needed depedencies
- removed redundant feature dependencies inside feature defn.

Change-Id: If5ea542732868b89ccd1cc6f5ae52167c8a4830b
Signed-off-by: Keith Burns (alagalah) <[email protected]>

Pom file clean up.

Change-Id: Ice04f4064257354a98dad66bc979ac78d37ca9bd
Signed-off-by: Keith Burns (alagalah) <[email protected]>

Yin files creation fix

- added search path to convert_yang_to_xml.sh script
- added yang files which are included into sfc models in sfc-model folder

Change-Id: I74acb65ced8bb844a646b6edead54ce89fcea08f
Signed-off-by: Daniel Malachovsky <[email protected]>

Revert "Bug 4544 - SFC-VNFM Interface Implementation"

This reverts commit b31d270a05ea744ff8d539745e04738d836cf119.

Needs further discussion.

Change-Id: I22da812c27c83eb2084a403de5b665d1a0d5eb4e
Signed-off-by: Johnson Li <[email protected]>

Bug 4544 - SFC-VNFM Interface Implementation

Change-Id: I5b2c150df649e1a1ec1b484225754209d83dea29
Signed-off-by: Reinaldo Penno <[email protected]>

Bug 4507

 - Fixed script generating YIN files from Yang modules in the project.
 - added empty yang2xml folder
 - fixed many of the JS errors
 - deleted unnecessary files

 - more info @ https://bugs.opendaylight.org/show_bug.cgi?id=4507

Change-Id: I92892893e8955961c7f574b62296322bcf92c18b
Signed-off-by: Daniel Malachovsky <[email protected]>

Bug 4528 - SFC SBRest Broken

- Commit https://git.opendaylight.org/gerrit/#/c/28539/
  introduced a new Yang model sfc-common.yang with typedefs
  for names used throughout other models.

- Although the typedefs resolve to strings, the typedefs
  themselves are instantiated as objects. Therefore in order
  to get the actual value of, say, the SF name from a SF
  object, first you get a handle to the object associated
  with the typedef and then perform a getValue().

- Introduced try/catch around jersey client methods
  in order to catch future issues

Change-Id: I870f3f84c707f6964aa1683b67a7c0e8ff2c847f
Signed-off-by: Reinaldo Penno <[email protected]>

Fix for YANG revisions not being explicit in import.

Change-Id: Ib1b6045ad74685ba37095c67aec424b67067545b
Signed-off-by: Keith Burns (alagalah) <[email protected]>

Merge "Add exception handle for SfcProviderRenderedPathAPI & SfcNshHeader"

Add exception handle for SfcProviderRenderedPathAPI & SfcNshHeader

Change-Id: Iad676023f076195e3dae2bc9fa24fdb5ca392d9c
Signed-off-by: Ruijing Guo <[email protected]>

Fixing sfc-scf-openflow naming/class convention

- Module, namespace and file name need to be consistent in
  sfc-scf-openflow-provider-impl.yang

- Fixes on .yang required corresponding changes in package
  name, class name, etc

- Fixed all possible Yang issues in sfc-provider-impl.yang.
  I do not think this is the cause of any issues but fixed
  everything according to pyang

- Fixed initial config files

Change-Id: I14f1d7f90d0c1c76f454535bd45fb362b08e2f1c
Signed-off-by: Reinaldo Penno <[email protected]>

fix NullPointerException in SfcLispUtil

Change-Id: I4f0b2217f02ca44c1f0c3ad8101ea92e1ee6ecf8
Signed-off-by: Ruijing Guo <[email protected]>

Bug 4481 - Standalone SFC classifier support

  1. add more ACL match for SFC classifier
  2. clean up some code
  3. add some exception handle

Change-Id: I0c6e55c775da67a8aa19be7cb5374b92fbd34f2e
Signed-off-by: Ruijing Guo <[email protected]>

Merge "Append NSH-aware SF to vxlan_dump.py and rename as vxlan_tool.py"

Append NSH-aware SF to vxlan_dump.py and rename as vxlan_tool.py

Usage: vxlan_tool.py [-h] [-i INTERFACE] [-d dump | forward]

This is a VxLAN/VxLAN-gpe + NSH dump and forward tool, you can use it to dump
and forward VxLAN/VxLAN-gpe + NSH packets, it can also act as an NSH-aware SF
for SFC test when you use --forward option, in that case, it will
automatically decrease nsi by one.

optional arguments:
  -h, --help            show this help message and exit
  -i INTERFACE, --interface INTERFACE
                        Specify the interface to listen
  -d {dump,forward}, --do {dump,forward}
                        dump/foward VxLAN/VxLAN-gpe + NSH packet

Change-Id: I2417327e1192073831d9da89893f90c0ccb741cd
Signed-off-by: Yi Yang <[email protected]>

Fix charset encode issue in sfc-py/MANIFEST.in

Before fix:
$ iconv -t ascii sfc-py/MANIFEST.in
iconv: illegal input sequence at position 0
$

After fix:
$ iconv -t ascii sfc-py/MANIFEST.in
graft nfq
graft test
include start_agent.sh tox.ini README.rst

prune unused
global-exclude *.pyc
recursive-exclude * __pycache__
$

https://pypi.python.org/pypi/sfc has same issue because of this
bad encode, this results in "pip3 install sfc" failure.

Change-Id: Ib12ad58e38d68b2bcaa4ce7a6670ccd286381267
Signed-off-by: Yi Yang <[email protected]>

Merge "Introducing typedef and leafrefs for strings."

Merge "Add a SFC NSH test tool vxlan_dump.py"

Add a SFC NSH test tool vxlan_dump.py

This is a pure python script, it can dump Ethernet
header, IP header, UDP header, NSH base header and
NSH context header, this is very helpful for SFC NSH
test.

It includes much code from sfc-py, the intention
is to make sure it is self-contained and hasn't too many
dependencies and packeges installation, in addition,
it does need some changes, the original APIs can't meet
its requirements.

Change-Id: I7ff2101afeeba009311e2f75efb2fc02bd3fc384
Signed-off-by: Yi Yang <[email protected]>

Fix errors in compute_internet_checksum in corner case

When data length is odd, compute_internet_checksum will
hit a corner case, this results in two errors:
  1. pad = bytearray('\x00')
  2. out-of-boundary access to 'data'

This commit fixes them and it is verified in my python-based
SF.

Change-Id: Ida19b0b0f7c3a790a234273fc5773a4becd9f220
Signed-off-by: Yi Yang <[email protected]>

Introducing typedef and leafrefs for strings.

This is to prepare for new data model, introduce
type safety and code-readability.

Change-Id: If181b38391abcc74754f2801bb2d6d66fd155e68
Signed-off-by: Keith Burns (alagalah) <[email protected]>

Bug 4500: Clean up Classifier/RSP dependency

Change-Id: Ie2d37a8d4d565bbdaae9edabaf1ec818f4740aad
Signed-off-by: Ruijing Guo <[email protected]>

Merge "SFC - fixed broken SFC UI by DLUX patch - fixed bugs about new version of angular >1.4 - changed SFC compatibility to DLUX - SFC is depend just only on DLUX core - changed SFC UI translations to partial (like DLUX core) - removed yang2xml folder with Yin files - changed service-function-metadata module to   service-function-path-metadata in sfc.services.js"

Bug 4452 - Multiple Context Header Allocation Support

This commit adds a SFC yang model as part of the
design of allows multiple SFC clients besides GBP.

https://lists.opendaylight.org/pipermail/sfc-dev/2015-September/001886.html

- The SFF metadata fatures design follows the recommended approach
  for capability and model evolution:
- https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-04#page-31
- The common model (SFF) does not need to be touched
- All new augmentation and features remain on separate files
- Separate files can be reved and changed as needed

- RSP model was patched so client can request metadata allocation.
- Added new provisional code to test new RSP RPC
  parameters

- This code is safe in that it does not require any GBP changes yet

- Rebased to new classifier

Change-Id: I161d88196fa6ccd9baf64c3385974bcbd2af5fb4
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Bug 4481 - Standalone SFC classifier support"

Bug 4481 - Standalone SFC classifier support

1. Standalone SFC classifier framework
2. Already test in uni-direction SFC

TODO:

1. plan to add exception handle
2. plan to add bi-directory SFC
3. plan to add VLAN
4. plan to add classifier stats

Change-Id: I59fafc5f2145f7b07c4fd0bf66d055d9dc35fa86
Signed-off-by: Ruijing Guo <[email protected]>

Change protected to public in SfcProviderServiceFunctionMetadataAPI

Change-Id: I96260af2e8f3c5f32058e4f490ba91c4cb4eeff5
Signed-off-by: Ruijing Guo <[email protected]>

Merge "Bug 4458 - implement SfcOpenflowUtils as SFC util module"

Bug 4458 - implement SfcOpenflowUtils as SFC util module

Change-Id: Id06266ed7a9541fb765bb808af650076aa7406b1
Signed-off-by: Ruijing Guo <[email protected]>

Add sfclisp postman collection for testing

Change-Id: I838b7c6b3c2aec027dec4a70d8d94377703ad1af
Signed-off-by: Florin Coras <[email protected]>

Merge "Removed methods containing reflection"

Removed methods containing reflection

- removed all methods with name *Executor
- removed SfcProviderAbstractAPI which is not needed anymore

Change-Id: Ib7f0e2ad3ad5c43f4d06b3c93363eee0b2070ea2
Signed-off-by: Martin Sunal <[email protected]>

Merge "Bug 4474 - Add metadata in rendered path data store"

Bug 4474 - Add metadata in rendered path data store

Change-Id: Ia298f106959cdac5ae203df33d447fc1b1516b12
Signed-off-by: Ruijing Guo <[email protected]>

Bug 4445 : Clean up pom.xml in SFC project

Change-Id: I928de057bb1d8fbf66785b3f3bd838b90be927eb
Signed-off-by: Ruijing Guo <[email protected]>

SFC
- fixed broken SFC UI by DLUX patch
- fixed bugs about new version of angular >1.4
- changed SFC compatibility to DLUX - SFC is depend just only on DLUX core
- changed SFC UI translations to partial (like DLUX core)
- removed yang2xml folder with Yin files
- changed service-function-metadata module to
  service-function-path-metadata in sfc.services.js

Change-Id: Iedf77a7a8a909ec9a6fdadf9e80508aedc9ed51c
Signed-off-by: Daniel Kuzma <[email protected]>
Signed-off-by: Daniel Malachovsky <[email protected]>

Merge "Bug 4453 - service function metadata provider support"

Merge "Bug 4443 - Add default classifier table for SFC"

Merge "Bug 4445 : Clean up pom.xml in SFC project"

Bug 4453 - service function metadata provider support

Change-Id: Ifee42e311e3c54869dbec0ba0f049c23474e38e5
Signed-off-by: Ruijing Guo <[email protected]>

Merge "Bug 4444 : Add system interface for SFC data plane locator"

Bug 4443 - Add default classifier table for SFC

Change-Id: I6e48370f2b033b732c29115bd958db182084fbe3
Signed-off-by: Ruijing Guo <[email protected]>

Bug 4444 : Add system interface for SFC data plane locator

Change-Id: Ie15e7bdb9cffd697ef24d144672edd6fadbe7b7f
Signed-off-by: Ruijing Guo <[email protected]>

Bug 4445 : Clean up pom.xml in SFC project

Change-Id: I7fcad0c678491c027eb6391d08810e0574a5e4ca
Signed-off-by: Ruijing Guo <[email protected]>

Fix bug 4450 random failure in SfcProviderSfstEntryDataListenerTest

Change-Id: I5660aaa0aa4d4e1fced3d286e10cef2089dd9048
Signed-off-by: Hongli Chen <[email protected]>

Merge "Bug 4362 - Update SFC to IETF ACL Yang"

Merge "Bug 4361 - Add SetNSH Action & actionsInstruction in SFC openflow utility"

Unit Test of SfcProviderSfstEntryDataListener

Change-Id: Icf5950026d275a6951f1b4a6971928e43527403f
Signed-off-by: Hongli Chen <[email protected]>

Bug 4361 - Add SetNSH Action & actionsInstruction in SFC openflow utility

Change-Id: Ia80736970e247908edf9ea584c30def0a6b70129
Signed-off-by: Ruijing Guo <[email protected]>

Bug 4362 - Update SFC to IETF ACL Yang

Change-Id: I3a9189fd56be83488b05ef21b07aa53fed3fa9ca
Signed-off-by: Ruijing Guo <[email protected]>

Changes for Java8 javadocs and Checkstyle changes

Change-Id: I1d7992516aa8d595b48fb75a89d88448db408c68
Signed-off-by: Keith Burns (alagalah) <[email protected]>

Display per port rx/tx statistics in service node of sfc GUI
 -Add per port rx/tx statistics in service-function-description-monitor-report.yang
 -Add the rest API of service-function-state
 -Display per port rx/tx statistics from netconf server in service node of sfc GUI

Change-Id: Ic68d850545eb0a835d5aaf3e81e0a62a4d508ac6
Signed-off-by: Hongli Chen <[email protected]>

Merge "Revert "Change SF reference to SFF to be leafref for data consistency""

Revert "Change SF reference to SFF to be leafref for data consistency"

This reverts commit 9d77a27a53bf7234f191326e66d864caa8fd11f3.

Change-Id: Iae2b44a9fb4efc09c6fbaf52a87528ab05de8835
Signed-off-by: Brady Johnson <[email protected]>

Merge "Fix the bug 3574 about listening of Algorithm Type  1. Fix SbRestSfstEntryDataListener and SfcProviderSfstEntryDataListener is not registered  2. Fix not to modify the the isEnabled status of previous used algorithm type when current used algorithm type is changed"

Fix the bug 3574 about listening of Algorithm Type
 1. Fix SbRestSfstEntryDataListener and SfcProviderSfstEntryDataListener is not registered
 2. Fix not to modify the the isEnabled status of previous used algorithm type when current used algorithm type is changed

Change-Id: I04093ae89aa2da931b6a30cd5c70740f90f6c17c
Signed-off-by: Hongli Chen <[email protected]>

Change SF reference to SFF to be leafref for data consistency

Change-Id: I741e3de0dfc6a17cf696e93455041b8df345c765
Signed-off-by: Keith Burns (alagalah) <[email protected]>

Re-enable the odl-sfclisp feature in Karaf

Change-Id: I784526d9b0adca02e180566e81b1b80146879850
Signed-off-by: Lorand Jakab <[email protected]>

Merge "Re-enable sfclisp"

Re-enable sfclisp

Change-Id: Ie659284b0b4e561f7ae42ae165a7595881d20d48
Signed-off-by: Florin Coras <[email protected]>

Changes to how sfcofl2 demo handles ARP

- now send arp/icmp packets through GW to GW connection.
- drop everything else not explicitly sent to/from clients to avoid pkt loop

Change-Id: If379431ab4c285dbf5a2c5614c74ac854dd9e481
Signed-off-by: Brady Johnson <[email protected]>

Bump LISP mappingservice YANG revision

Change-Id: Iea826e1048f5aee1b130f45dc3f042b8fb8107a0
Signed-off-by: Lorand Jakab <[email protected]>

Increasing Test Coverage - Sfc*Mapper classes not used

Change-Id: Id65206b9b8d8488a9213f979b0fc1f7c2260ed8b
Signed-off-by: Reinaldo Penno <[email protected]>

Removing LISP from Build due to build break

- SFC is broken and folks are blocked from working
  so removing LISP from build until things are
  fixed

Change-Id: I938300d1d90fa8de45c0bbf94d3314dbd10114ae
Signed-off-by: Reinaldo Penno <[email protected]>

Increasing Test Coverage - SFP Listener is not used

- Today RSP is derived from SFP
- If SFP is removed, we maintain RSP so not to disrupt
  forwarding packets
- Revoming a SFP has the action of no more RSP will be
  derived from it

Change-Id: Idc184546f79fe641b80fb95108d570ab8137e9cc
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Increasing Test Coverage - SfcProviderSfgEntryDataListener not used"

Merge "Increasing Test Coverage - SfcDataStoreCallback not used"

Increasing Test Coverage - SfcProviderSfgEntryDataListener not used

- Removed Listener

Change-Id: I05508868f409686b88eee3e5e9c01b5eb977a803
Signed-off-by: Reinaldo Penno <[email protected]>

Bug 4293 - No test coverage for SfcProviderSffEntryDataListener

Change-Id: Idca56ff2a53d7ecb99482133ddfcd72d9cfa60e1
Signed-off-by: Reinaldo Penno <[email protected]>

Increasing Test Coverage - SfcDataStoreCallback not used

Change-Id: Iac176e8c9d2d327ef414beef03f2272bf3c64891
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Migration to use MD-SAL Project"

Merge "Increasing Test Coverage - SFC Listeners"

Increasing Test Coverage - SFC Listeners

- Clean up. SFC listeners are not used.

Change-Id: Ib4c968077fdd6209575feab7ed56557e99657311
Signed-off-by: Reinaldo Penno <[email protected]>

Increasing Test Coverage - Executor Dispatch

- Clean-up. Class is not used

Change-Id: I237beb3c4b477cacf07e18407dbdbc478dd28b5b
Signed-off-by: Reinaldo Penno <[email protected]>

Migration to use MD-SAL Project

Change-Id: I058bc990525af9ea1d056e1c263bc46340a9fe4c
Signed-off-by: Tony Tkacik <[email protected]>

Merge "Update ovsdb.southbound.version"

Merge "BUG 4263: No test coverage for SfcProviderSfEntryDataListener"

Merge "Increasing coverage for SFc Provider"

Merge "Reving Python Package to 0.1.4"

Update ovsdb.southbound.version

OVSDB bumped that version to 1.2.1-SNAPSHOT in this change:
https://git.opendaylight.org/gerrit/#/c/25574/

Change-Id: I30753a2de238b1b9603758d644cd9b06a7150bb6
Signed-off-by: Vratko Polak <[email protected]>

Increasing coverage for SFc Provider

- SfcProviderUnitTest.java is not used. Historical

Change-Id: I0589ce73dbcd2dd5279043cd073ac7cb7dc4a0fb
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Use odlparent JaCoCo UT configuraiton"

Reving Python Package to 0.1.4

- Considerable changes went in that a new Package version is needed

Change-Id: I24a8c8b536ea52068b9e355d63d313f73ce75b06
Signed-off-by: Reinaldo Penno <[email protected]>

BUG 4263: No test coverage for SfcProviderSfEntryDataListener

In the process of providing coverage for SF listener I had to fix
or improve a series of minor to medium things.

- Change a couple of IIDs to private static final in Opendaylight class
- Fixed identation in SfcProviderSfEntryDataListener.java
- Removed unused method in SfcDataStoreAPI.java
- Fixed Javadocs in SfcProviderRenderedPathAPI.java
- Introduced a new API in SfcProviderServiceForwarderAPI.java
- Fixed Javadocs and Introduced new APIs in SfcProviderServiceFunctionAPI.java
- Fixed Javadocs and Introduced new APIs in SfcProviderServiceTypeAPI.java
- Fixed LOG object instantiation in AbstractSfcRendererServicePathAPITest.java
- Fixed a problem in an existing test SfcProviderRenderedPathAPITest.java

Change-Id: Ie25a92b75b06e627818950c3c851b3ece79c0451
Signed-off-by: Reinaldo Penno <[email protected]>

Use odlparent JaCoCo UT configuraiton

Change-Id: Ie157b6db72323e4ccc20a3bc96b6d8e2692547f2
Signed-off-by: Thanh Ha <[email protected]>

Fix version in migrated netconf dependency

Change-Id: I4968caeff45bc6c3356985945954bb4c50f32c7e
Signed-off-by: JMorvay <[email protected]>

Merge "sff_client can specify inner ethernet addresses"

sff_client can specify inner ethernet addresses

- User can know pass inner src and dest ethernet address to sff_client
- sff_client will us those values when using NSH Type 3 or VXLAN-legacy
- Modified inline example to add ethernet values

Change-Id: I2924f47d3ceb0acdf42e812dc71ca7047cbd14f0
Signed-off-by: Reinaldo Penno <[email protected]>

Test coverage for Service Path ID

- Hopefully 100% test coverage for Service Path ID file and algorithm
- Refactored RSP Test to use same abstract class as SPID

Change-Id: Iffe877abcea245d00d7f69e9a8f1dc2fdcbfefb7
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Migrate netconf/restconf dependencies"

Migrate netconf/restconf dependencies

Change-Id: Ic3c17dc3701dc97f23691fe73875573a2b630766
Signed-off-by: Tomas Cere <[email protected]>