Bump versions by x.y.(z+1)

Change-Id: I5ef2fda25bb91507e8dc7f1617a9ff02ad1dda04
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

BUG-8292 Fix BGP flowspec NLRI length read

In BGP Flowspec, NLRI length is set per NLRI. The
current implementation only read NLRI once. So
BGP parser will throw exception when multiple
NLRIs are batched in one BGP UPDATE message.

Change-Id: I6630bca4c222e68f4609134192550d6c0a7ea3ba
Signed-off-by: Kevin Wang <kevixw@gmail.com>
(cherry picked from commit 51646d108fc36adef7cffd99657386fd6f5f96bd)

BUG-8548: Pass missing parameter to

SimpleBGPExtensionProviderContext#registerNlriParser

Change-Id: I625f82d64efa0d2843b94de31c649572be9cacf9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit 9483e0a24a75c94732a0c1b325087be62f0f9384)

BUG-8156 Fix PCEP topology registration

It is possible that when a PCEP session is being dropped and being
unregistered from ServerSessionManager, the thread gets switched
thus the topology unregistering cannot finish.

If such situation happens, PCEP session from the same PCEP peer will
not be able to established until after DEADTIMER_EXPIRED, as the
topology instance was not removed correctly.

Change-Id: I647ecfbbb35ef6805d563753b7ebd87edfc350fe
Signed-off-by: Kevin Wang <kevixw@gmail.com>

Fix RD pattern in RouteDistinguisherBuilder

Type 0 RD is 2+4 bytes.

Change-Id: I7ec0099cf5c1cdf8ab7d333dc26756c17228579b
Signed-off-by: Xiao Liang <shaw.leon@gmail.com>
(cherry picked from commit a52ecc55a9dca19ce563cea27263ea0842ff9789)

BUG-4491: Race condition under PCEP Topology Provider

Race condition under PCEP Topology Provider when
instace is reconfigured, since closeInstance under CSS
is nonbloking, it can race the delete with the writing
of the new instance when restarting.

Change-Id: If79bf34f77223bc56424a57e4e600fdb17ddd154
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8306: Fix Pcep failing test

Given that messages takes differents time to arrive on listener
Fix  Stateful07TopologySessionListenerTest by
use checkEquals, which checks the assertion with timeout.

Change-Id: I13733fa7ad7686671d9c026a8528ad912e2c7cd5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8202: Fix Conflict Modification on odl-programming

Instruction DS configuration only should be written
on Leader when instatiateService.

Change-Id: I9acf17c8a19d8b22d83e62b315fdadf9494783f2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8275: Close ReadOnly transaction

PCEPStatefulPeerProposal needs to
close ReadOnlyTransaction created
after use it

Change-Id: I1515f09028c9e6bd8403d6ea2851196511d4da24
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit b85554f565b2e03d2c8237b160ac055907b86b23)
(cherry picked from commit d0032a5e38fa0860165031a19c1195036e4e9681)

BUG-8198: Fix InferenceException

Add presence statement under graceful-restart-capability.

Change-Id: Idc98f74661d4dea4f440d178da868ec83f896370
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit 187428a5c597c78c625ca2b1baa1a920108a979f)

BUG-8252 Fix IP prefix length util

The byte representing IP prefix length is a unsigned byte.
The length should be converted to an unsigned int explicitly.

Change-Id: I0c1df171822858825da69f39c91de9ed332865f8
Signed-off-by: Kevin Wang <kevixw@gmail.com>

BUG-6973: Implement test for InstructionDeployer

Cover InstructionDeployer with test

Change-Id: I8ed071a8a11dd0d9183fe6c5b45ae7616f6ce5f9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Rework CheckUtil Test

Change-Id: Icada2980901bea076b061b933d8ba42876d0e5f5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8007: Code Clean Up

Fix instance fields not accessed with this

Change-Id: Iec1520fa728ea21098dd5a79dbfa25837b117e1c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8007: Code clean Up

Classes missing final

Change-Id: Ie260d9f4a48290b492171f79f94f7f8ee53ccbde
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8007: Code Clean Up

Anonymous type replaced by lambda

Change-Id: Idd81b1e43866e5d960ec2dfa777b66bae3e53da9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8007: Code clean up

Remove unnecesaries imports

Change-Id: I0ecf1894c1be211f9ffd7ed0d98a3c80ae9a6025
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6975: Integrate Topology Provider with CS Service

Integrate Topology Provider with CS Service

Change-Id: I0e9c42aa3538e0936b74120535fee369db1ad9d5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6973: Wire topology-provider with BP

-Wire topology-provider with BP
-Preserve backwards compatibility

Change-Id: Ibc459117b1656a0efe5e34365b9fc131479bdaea
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8213: Add missing mandatory attribute on tests

Add missing origin attribute on tests

Change-Id: I125437e187286a7a949e26191e66f19ded123274
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8007: Programming Clean up

Migrate deprecated classes
Code clean up

Change-Id: I06551491a30499d81d4c0dc7f0e1dbe68dc04eab
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6975: Integrate Programming with Cluster Singleton Service

Integrate Programming with Cluster Singleton Service

Change-Id: I95e3c8c1dc1e596c060256d3f59fec9cfe882456
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6973: Implement Programming config via DS

-Expose programming's configuration in config DS
-Allow multiple programming configuration

Change-Id: Ib6de3355dae6533367890ef87c504edbdca04654
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6973: Wire Programming with BP

-Wire Programming with BP
-Preserve backwards compatibility

Change-Id: I750fdb86a6c22d3b1a90e7466466ab7c5426d729
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8203: update Netty isRoot method name

Netty has changed the name of the method isRoot
to maybeSuperUser.

Change-Id: Id2a5c19d914cccd5e3581a3ca59846d113ecaeb0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Restrict powermock dependency scope to test

Change-Id: I0fd96dd52deacd1169d8a7e497cf5455838ca725
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>

BUG-7976: Race between peer removal and routes update

There is a race condition when we are advertizing routes,
and a session peer goes down which will end in
removing the peer from DS.
Since advertizement and removal are done by 2 different tx,
we need to do it blocking mode, and not route should be
advertized until peer is removed and vice versa, peer
should not be removed until routes are advertized.
Otherwise toure update will try to update a peer/path which
is not longer present.
Fix by rework PeerExportGroup & ExportPolicyPeerTracker,
now instead of generate PeerExportGroup each time a peer
is reg/unreg,  we make PeerExportGroup work as a
blocking registry to solve previous issue.

Change-Id: I46a27871bfa2aa2a632e3bfb76061105c62bb6d2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bumping versions by x.y.(z+1) for next dev cycle

Change-Id: Ie8898450fe3fd1bc0c8a2c93b4a5b5d50ed98420
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Correct XSD pattern

YANG patterns are XSD regexes, so they have implicit ^/$
anchors. Fix this up.

Change-Id: I911ca3d3bd286c0f77bccfb4f3e9a3ef8fc8dbdb
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 141707ac43ba8594c1c5f7c76f39198daebdb786)

Fix NPE under TopologyProviderTest test

Fix by check reportedLsps is not null.

Change-Id: I18878db061ab5816ac5f13e5cdac21107df86aa1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7964: IllegalStateException under testReconectClient test

Fix by wait until channel is closed before retry to connect.

Change-Id: If1c7889b7988ce5cab3e11f73b6134ad2af182c7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7958: Fix IllegalArgumentException

Remove unnecessary service registration for AppPeer

Change-Id: I0d76f372aa553ad16e76ae83f0f78babc49bd423
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7003: Remove sleeping from Tests

Remove sleeping from test whenever possible.
Perform clean up under tests.

Change-Id: I734ca5721090669c75f09d107ee4c5ea1e3d14ee
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7937: Fix BGPTerminationReason

When closing the session because of some error
2 Notify messages are sent. One containing the
reason and other with CEASE.
Fix by dont send CEASE Termination Notification
if already other termination notification has
been sent.

Change-Id: Ibfabd7cfb038bef7a452a7458cd5cc1e6fa4b9a7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit d9a7ab7217f7d14c96356db48e7d6dcdd00601ba)

BUG-7505: Conflict Modification

When closing Peer and Rib, can cause
race condition between the removal
of the peer and the rib when updating DS.
Fix by close peers on blocking mode, and once
they are closed proceed with rib.
Same its applied in case that peer/rib is updated.
First we close it and then once DS is updated
we proceed with creating the new instance.

Change-Id: Ibe70e0324ae12bcbb88b2e7f039671141447ddb1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7386 Remove blocking gracefulshutdown

Remove blocking gracefulshutdown for EventLoopGroup

Change-Id: I03fd04cd77d613ce4b8c83f1f48deb3142227bfb
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7768 Fix missing registration

In previous BUG-7768 fix, pcep topology registration was
missing. This patch adds it back. It also adds several debug
logging and unit test.

Change-Id: I4c82a7fcd9cb1ed7371817ffabc52fdf927ab51e
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bug-7614: LocRibWriter does not recover well from transaction chain failure

If transaction chain associated with LocRibWriter fails, create a
new transaction chain and re-initialize it with the new chain.

Change-Id: Ibbb60c41594ad6b3602cabac18f5e4bccaa093bb
Signed-off-by: Ajay <ajayl.bro@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7222: Make BGP DS clean up asynchronous

Close of the service must be done async, otherwise
will bock the thread.
Fix by make BGP DS clean up asynchronous

Change-Id: Icb19ef7b7f118fbc6b07407d1df2cb5f6cffc0fb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-4808: remove reference to IdentityHashMap

Class documentation is misleading, as the internal cache is implemented
by a weak key/weak value equivalent.

Change-Id: Ie0d08ee990b725c5ed1a52cb074b6f72eff2a26f
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 0aa43abe473e1b7b07879008861ae8e0017dd8ed)

BUG-7768 Synchronize ServerSessionManager for PCEP

Add the check so that session manager can only be closed once
and becomes unusable after closing.

A java.util.ConcurrentModificationException is possible to happen
due to the close() method of ServerSessionManager is not synchronized.
The situation mostly likely will happen during a controller reboot.
It may also happen when a PCEP config is updated. The ServerSessionManager
is being restarted while all the PCEP negotiation is still happening.

Change-Id: I0e0d387add046a4fe9ec5ac74a85f8350e238d60
Signed-off-by: Kevin Wang <kevixw@gmail.com>

BUG-7732: Improve BGPDeployer synchronization

Improve BGPDeployer synchronization

Change-Id: I0a4c321ac36efefea473d0e2557588c6d687d5d3
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bug-7708: Invalid Route Distinguisher error while processing withdraw update containing VPN route

 - RFC 3107 says that label value in withdraw message should be 0x800000
   ref. https://tools.ietf.org/html/rfc3107#section-3
 - Changed code to correctly handle this value in withdraw message received from peer.
   Also ODL will now use this value when sending withdraw message to its peer
 - Updated unit-tests accordingly

Change-Id: Ie9d90779c32e9141f953a18b07a86d0624eaee5c
Signed-off-by: Ajay <ajayl.bro@gmail.com>

BUG-7723 Change BGP connection failure log level

Change the BGP connection failure log level from DEBUG to WARN.

Change-Id: I68766d8849a7ce246959534b5fc80aa2eaf8fc3c
Signed-off-by: Kevin Wang <kevixw@gmail.com>

BUG-7351: Update IRO reference

IRO is compliant of rfc7896 therefore we
update the reference.

Change-Id: Ia31d2e5c59ba68b966a53f92482dad56380c809b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit 682d5d39484d34c67f93953fb3d87adb574fc400)

BUG-7673: Improve synchonization under BGP/PCEP Session

- Improve synchonization under BGP/PCEP Session
- Code clean up

Change-Id: I93851323232fa9df0c23e1e23751320cdf578031
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit 727af29cfbf68c09adeac3fab4ee7729dc42c8f8)

BUG-7673: Fix PCC Mock test failures

Fix PCC Pcep test failures by passing missing executor
Fix annotations
Fix warns for keepAlive size

Change-Id: I0013af17e01d2d8afa136a16d6315719e0aac3fd
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit adefcce2fc703a06ce951a3e23d147a4f2b03fad)

BUG-7215: Fix App Peer ModifiedNodeDoesNotExistException

If Rib is reconfigured with different Family than the
previous supported one, application peer will be
reconfigured. In the case there are some routes or,
family table configured on Config DS, when restarting
App peer with new configuration will end on
ModifiedNodeDoesNotExistException.

Fix by:
   -Make Application peer more defensiveness by ingore changes
 on config DS for non supported Families.
   - Register Change Listener once AdjRibIn has been
 succesfully initialized.

Change-Id: I25b08b057fad02df365070c0a6d5177b9e0392a0
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Bumping versions by 0.0.1 for next dev cycle

Change-Id: I8d0746d01128b447e73eca8912bfca878f8eba9e
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

BUG-7222: Fix clustering BGPPeer NPE

Fix NPE: Any call to rib should be done
during singleton service instantiation or after.
Any call before can cause a NPE since RIB might be
on undefined status yet.

Change-Id: Ia1ebbc334f07362f325ac599f39f9d601e717321
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Pcepy: Address pep8 violations

Newer libraries used in verification are more sensitive to
"E305 expected 2 blank lines after class or function definition".

Change-Id: I3f94115bb70b069f3eb417429bbc457c73048a7a
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

BUG-7003: Remove Thread.sleep() calls in tests

Partial improvement under Additional Paths tests.
The time spent has been reduced.

Change-Id: I8ebfd19af9147a10f1d5856b5478501f2ab890ab
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit 257ee3c3c96e5f15b39c7ca0fdbf4f436517a766)

BUG-7006: Unit-tests sometimes hangs during execution

Fix sporadically hangs during unit-tests execution

Change-Id: Ia339af6d9181a7be8e4b3e6335bba250aaecd822
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7003: Introduce CheckUtil

Introduce CheckUtil for replace Thread.sleep on tests

Change-Id: I6a74b7dc9563594424c8b1a0b03ca39890d3e803
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7098: Fix Sonar complains

Fix duplicate code
Naming conventions

Change-Id: I2425fc111b5890100cda942913b0d617b4029f2c
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit 1bb09133cb0d2a72c087ed345406354934999f39)

Bumping versions by 0.0.1 for next dev cycle

Change-Id: I56bac23a20443bbb5197dbe1167b35058d1e896e
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Bug-6737: bgp:show-stats Karaf CLI causes NPE

Change-Id: I2006c119d1213b0a69ca11c0cb557dd503d69cc6
Signed-off-by: Ajay <ajayl.bro@gmail.com>

Bug-6781: Inbound and outbound connection attempts from controller are not synchronized
- created new peer session listener registry in BGPPeerRegistry for the
  outbound connection establishment logic to get notified when new peer
  session is created or destroyed
- updated outbound connection establishment logic to attempt a connection
  only when no existing session is present
- updated unit-tests

Change-Id: Ie6afb79e290c1a3c98d82af87febd6851ad200c2
Signed-off-by: Ajay <ajayl.bro@gmail.com>

Bug-7004: NPE when configuring BGP peer using OpenConfig API twice
- handle scenario where peer not having AFI-SAFI info is
  reconfigured using OpenConfig API
- updated unit-test

Change-Id: Ib9dd4550814fe861ab60efc3276cb91b45692078
Signed-off-by: Ajay <ajayl.bro@gmail.com>

Bug 6622 - ClusterSingletonService registration race condition

This is a hot fix for a race condition issue which can happen during a service lifecycle.
An application which manages services in not aware when the unregistration is finished, hence
service close is followed by immendiate service registration which may fail consequently.
This condition is handled by reatempting service regsiration after 10 ms.

Also fixes RIBImpl - create TX chain in #instantiateServiceInstance and asynchronously clean operatoinal DS.

Patch https://git.opendaylight.org/gerrit/#/c/46761/ is depending on this changes.

Change-Id: I110badc8bfb482a5b7cb6545b882cda2d0c661ae
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Do not wrap Guava as a bundle in features' definition

As it will refresh the bundle when the feature is loaded,
because it will certainly be already installed,and hence
will refresh all bundles depending on Guava.

Also, this is not necessary.

This patch is not directly tied to BUG-6956 but it's a result of it

Change-Id: If2fff1c6326fb8b53786d59e94c364cf0f3292c3
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
(cherry picked from commit 622a8cf869f13ad75777e39612c9a26374132e3b)

Bug-6889: BGPCEP Boron Autorelease Breaking
- if server is not ready when client connects, wait for client reconnection
  before checking for test pass/fail criteria

Change-Id: I172d3e829f70081f0d943458dd43c6139381bf61
Signed-off-by: Ajay <ajayl.bro@gmail.com>

BUG-6955: Fix BGP TestTool

Register BGP Extensions

Change-Id: I1fd1874d580ad922afa776d45c195118b694286f
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit ad06ba88b71504bdb80c1e66193c4871d6f56c5e)

BUG-6954: Create Application Peer with Route Counter

Create Application Peer with Route Counter

Change-Id: I41faaa0dedebb158139987617a1106ddd9c584a5
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Bug 6809: PMSI attribute's mandatory leaves are always enforced

The PMSI Tunnel is an optional BGP path attribute.
Enforce the attribute's leaves presence only if the attribute is present in route's attributes.

Change-Id: Ifadf68ac30791614ed7695b940d3042cdca6aeb7
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 2c81d987ea7cdaad9b1dcb04c3591a8de2cd226f)

BUG-6257: Implement PMSI tunnel attribute handler

-Fix pmsi tunnel attibute yang model
-Implement PMSI tunnel attribute handler
-Implement test

Change-Id: Iffc1750724c3e97d1694fba8360007741ad08d80
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit 7cfbcfb35072f4b1e3ae3b02f09f7791c72f1527)

BUG6257 Add BGP attribute PMSI tunnel to the EVPN Yang

Add the BGP attribute "PMSI tunnel" to bgp-evpn.yang file and create
new pmsi-tunnel.yang file.

Change-Id: Ib4806a09a4e25721eb6a369f9617446f6645db54
Signed-off-by: Bruce Brandon <bb2697@att.com>
(cherry picked from commit 170546f6164b63bc773e7a3bad3c1dbbaeb50f89)

Bug-6889: BGPCEP Boron Autorelease Breaking

Increased timeout in BmpMockTest using Mockito#timeout
(it waits till timeout only if needed)

Change-Id: I8151757aa29a46c30b674398efeddc711189ac93
Signed-off-by: Ajay <ajayl.bro@gmail.com>

Bug 6788: peer singleton service closed just after initialization

In case of HA failover scenario, configured peer is not getting initiated on
new singleton group master node, as the neighbor is removed from configuration when
default example-rib-impl is initiated (OpenConfig BGP configuration written to config DS).
To avoid overriding neighbors configuration after failover, minimize scope of rib-impl
representation from "protocol" to "global" node.

Change-Id: If4df2a070e0cbceae1c42cbe0d0c5a2258388092
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 533415c23f2dc2115e529594be8673ea087d1264)

Bug 6811: wrong namespace for binding-codec-tree-factory

Set correct type of binding-codec-tree-factory in initial BGP configuration.

Change-Id: Ic35a0089157f02be9d5d45bc08e23f377c2dd649
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug 6835: Missing "simple-routing-policy" knob in OpenConfig BGP Neighbor configuration

Enables to configure simple routing policy (learn-none/advertise-none) via OpenConfig BGP API.

Change-Id: I1de260e57e603d5abf09f891a5fc971861217e0d
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 4a9a75cbfd84be6a1d42f6555ab14ff3af11be18)

Bug 6675: add missing cluster-id configuration knob

Enables global cluster identifier configuration for local RR.

Change-Id: I810ffcd097795ea4296a89a624f762863fea6526
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 2f71869e1eea0cb65ee87a602502d888fa0fe073)

BUG-6616: BGP synchronization can happen after the session was closed

Fix by handle message only when session is up.
-Handle exception in synchronation mode.
-Sort close of the session, removal of the peer
and send close reason message.

Change-Id: I21328f9a63d5360603f219cd3699b08874da318b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-6747: Race condition on peer connection

Race condition is observed under Loc rib when new peer is connected.
There is a chance that Eff-rib-in changes are notified before
than changes under supported tables, therefore none existing route
is announced to the  peer.
Fix by implement a unique ExportPolicyPeerTrackee per TableType and
per Rib.
On session stablished, peer will register itself to supported tables,
and remove himself when session down. This allow us to remove
CacheDisconnected peer, since it wont be longer required.
Also LocRib will be exclusively updated only related routes.

-Implement Base Path selection test
-Implement ExportPolicyPeerTrackerImpl test

Change-Id: I38b72f0ac9db09c64c4acdfeeb8eabade6ed046c
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-6647 Increase code coverage and clean up IV

-Implemet Rib-impl test

Change-Id: Idc952503dddae027e5a48d7b866ed8e94771287f
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-6647 Increase code coverage and clean up III

-Implement Openconfig Tests
-Implement testtool-util tests
-Implemet Rib-spi test

Change-Id: I85d45ef84f37b8e00249e3a462c8ee9c9c5f5a60
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-6734: Generate correct L3VPN route key

VPN label should no be a part of the L3VPN route key

Change-Id: I004be87834f60bd4d10d7d2f64d9775a1d06bd3c
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit 018100bab78fa6d9e2284df63ed9b604f9ad682a)

BUG-6799: IllegalAccessException on install bgp

Fix by remove final on reflected #close method of
TopologyReferenceSingletonServiceImpl

Change-Id: I0cca40aa1925348812a573d61022253243f731aa
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-6647 Increase code coverage and clean up II

Remove unused methods, parameters.

Change-Id: I14fdf71afc08a5c85fd86ea4a40c9b15993157e1
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit f0f2090ce6b2d7c204737352b784275a908d300f)

BUG-6647 Increase code coverage and clean up I

-Remove unused imports

Change-Id: Ib930f52f961a262acc33e720c51c2e5bbe8792bc
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit 76742780c07a29fe3d22759863ca20b7965e0710)

BUG-6784 - Failed to fully assemble schema context for ..

Failed to fully assemble schema context for ..
when installing odl-bgpcep-bgp-linkstate
Fix by sort bundle import of the feature

Change-Id: Ie9398dfab8500a06cddd38f0761d68f1e6971658
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Bug-6662: On connection reset by peer, sometimes re-connection attempt stops after HoldTimer expired error

This issue happens when the neighbor config is removed from peer router while retaining the BGP router config.
Under this scenario, since BGP router config is still present, router is listening on BGP port. So when ODL
tries to connect, the connection succeeds. However the BGP negotiation fails as neighbor config has been removed
from router.

BGPReconnectPromise.ClosedChannelHandler#channelInactive triggers the reconnect, but the actual connection
retries as per the connection stragegy are done from BGPProtocolSessionPromise.BootstrapConnectListener#operationComplete

In failure scenario, since connection succeeds but negotiation fails, failure is not detected in BGPProtocolSessionPromise.BootstrapConnectListener#operationComplete
and so no reconnection attempts are made.

When negotiation fails, AbstractBGPSessionNegotiator#negotiationFailedCloseChannel is called, which causes BGPReconnectPromise.ClosedChannelHandler#channelInactive
to get called. Fix involves detecting negotiation failure here, and calling BGPProtocolSessionPromise#reconnect.

The scheduled job in AbstractBGPSessionNegotiator to detect hold-timer expiry during negotiation is also being cancelled
from AbstractBGPSessionNegotiator#negotiationFailedCloseChannel as the job is not needed when channel is closed.

Change-Id: Ie4aecd1f99312476abd75f008c0a3ee4ce1d44a6
Signed-off-by: Ajay <ajayl.bro@gmail.com>
(cherry picked from commit 8b8556445b106974cb438244330e5ab68134f898)

Bug 4827 - BGP add-path unit tests

N Paths selection mode test
All Paths selection mode test

Change-Id: Ide97bea2e8af21aba82305e0422038e7552e0df8
Signed-off-by: Brian Freeman <bf1936@att.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 390c052e1b5fb768d351c5d8333fb135865b859d)

OpenConfig BGP more defensive

Add null checks and set default values to allow to configure BGP with
minimalistic configuration.

Change-Id: Id7f4c4014832054100e9148f575e215d493c3bb7
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 6efa3c0d6a4490a7e898519e3905847284803f2c)

BUG-6651:  Route Advertisement improvement

When N/All Paths
-advertise only the new best path selected.
When Best Paths selected are updated
-Don't send a withdrawal for removed path from the best ones.
-Only send thew withdrawal when route is removed by owner

Change-Id: Ia5051ac97e26cfe7cf9f28a5bc6ddb21cf87670a
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit 2193f98741659d1bf7cb77fde78cf685bfa091b5)

Bumping versions by 0.0.1 for next dev cycle

Change-Id: I8bb120f25aa3efeeb28a9b4d995387d7ba24da59
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Bug 6585: BGP ChannelOutputLimiter waits forever

After a while (when an output buffer reach upper bound),
BGP's ChannelOutputLimiter handler get stacked waiting for the channel to become writable again.
The writability change never happen, however socket flush is invoked,
so the session peer dies on holdtimer expiration.

Looks like calling #flush when writability changes to non-writable has no effect.
Invoking #flush in #ensureWritable makes the expected action.

Change-Id: I95681d87c30aff82ec360a2d13fc01fe35873507
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 684d75cb36f3b34b2691b374166f1bbc9ef52de5)

Bug-6621: ModifiedNodeDoesNotExistException encountered while building Linkstate topology
- added null check in BGP topology builder removeObject() method to
  gracefully handle issue created by BUG-6577
- when destroying operational topology to recover from a failure,
  flush the internally stored topology info as well so that both are in sync

Change-Id: Id239d74738d43dd63177aa3b2ba1d3d9136c3338
Signed-off-by: Ajay <ajayl.bro@gmail.com>
(cherry picked from commit b4657f9d04a5e0d30fa6d275ef933c420d9016c8)

Bug 6604 - Fix NPE in AbstractBgpTopologyProvider#topologyTypeFilter

The BGP topology provider is not the only ODL component which is writing to
config DS network-topology node (i.e. netconf-topology).

Make the code more defensive to avoid NPE when filtering topologies' configuration
without topology-type container.

Change-Id: I493759ce23277ac6b4c5f15653708c853426e56b
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 9cfa9f12dbc439cc8fde08794db823de534d5366)

BUG-6497: fixup augmentation lookup

This fixes the augmentations being looked up so they correspond
to the model. It also makes sure we squash them to minimum required
interface, as that is all we require.

Change-Id: I227e35a3cba596d41bcedaddf3b0196c18b0874b
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 2cdf4dece347e8570241fbc78638f7a7ba577bbf)

Bug 6497 - Wrong augmentations used in BGP

Fix BGP OpenConfig augmentations usage after changes in
yangtools parser.

Change-Id: Idfe474f6e2fd345934d3d7e74e581d8fb9547868
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 321f65d08a97de037a9b6f3b18e44c1db5242357)

Bug 5685: Integate BGP topology provider with cluster singleton service.

The BgpTopologyDeployer service is responsible for a topology builder instances creation.
In clustered environment, this service is running on all three nodes, consuming the same
configuration, create the same topology builder instance and register it to the cluster singleton service
provider on all nodes, but only one instance become active.
This integration allows fail-over scenarios and avoids confilicting datastore modifications for
topology builders with the same topology-id.
Provide backwards compatility for CSS modules, where instance is created and configuration
is written to DS when instance become active.

Change-Id: Id1af5368f5d9fad04243e2ab909c5948632626d7
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit e1a2ab99146c6e345f4e9911e51595eea5cdea11)

Bug 6568 - Termination Point Type is never set in BGP-LS topology

Change-Id: Ic7695b821f34c93826b8cde78921122222725e65
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-6468: Duplicate cleanup and connected-peer-counter decrement during BGP session cleanup
1. Add synchronized to BGPPeer#releaseConnection to avoid race condition
2. Add check to BGPSessionImpl#closeWithoutMessage so that it's body does not
   get executed twice, even if it does get called twice during session cleanup

Change-Id: I78d89de2c9c0fa8968bbb6a019d568a539a8c5f7
Signed-off-by: Ajay <ajayl.bro@gmail.com>
(cherry picked from commit 78b58179e6ef65fae98b134112e7aa0bbe7e1a91)

BUG-6497: fixup for shifted augmentations

With the numbering scheme fixed in yangtools, this patch
adjusts the code to use correct augmentation.

Change-Id: I50a9fa058bbff9d58a52eff39c0a750410b5fe8b
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 5061: Move BGP topology providers configuration to config DS

Allow to configure BGP topology provider from config DS Topology subtree.
The BGP topology provider configuration consists of topology-id,
rib-id (where topology provider is listening) and topology-type (identifies the type
of the BGP topology provider - IPv4/6 reachability, linkstate).
Services are wired with Blueprint, while CSS module based configuration
is still preserved.

Change-Id: I94e27c6cdf7f3f5c55b6972324ddb486d2ac185d
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 6681efdbd8d819d56236517d684978c7af237e0e)

Remove duplicate dependencies

These trigger maven warnings, remove them.

Change-Id: I775653ed89f3052952adb1832671573c29161110
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 5b60a2503c6600bf207582f71c7a7b1de656f295)

Bug 6530 - ApplicationPeer's CSS configuration not visible in OpenConfig BGP

Write Neighbor, representing application peer module configuration, when
singleton service is initiated.
Added missing "group name" augmentation of neighbor's configuration.

Change-Id: I7dd558648c3ec275e05ec3245309c7f3473b721c
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 3f047616c1e26d6b28d047f26bc7230506c70509)

BUG-6020: FlowspecL3vpn RIBSupportTest

FlowspecL3vpn RIBSupportTest

Change-Id: Ia3c057b9e0e2166eb9771ee05f4a9891d6dd053c
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit eb83f3dbb47f3a8f0bf1af58d89d341cf7b3c825)

BUG-6409: Fix L3vpn flowspec routes model

Fix L3vpn flowspec routes model to fit with
corresponding destination route model.

Change-Id: I4c60d4550b423b42848912da6acde787ebe17661
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit 7ff8942ba27c9c9da54d0520439287146ce5e7b7)