Bump versions by x.y.(z+1)

Change-Id: Idfb7eada43fb555c43632c7d890b8745976ace6c
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Use byte[].clone()

BGPDocumentedException can be made more efficient by using
byte[].clone() instead of Arrays.copyOf(). Also pre-cache empty
data and return it when needed.

Change-Id: Ib4e36522f0d3a734621349c1b62865496d330009
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use dedicated executor for BGPCEP Stats

BGPCEP-786
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Change-Id: I7c33b4938cf575350dee4e32aef02abca808bc05

Add Karaf build profile

Project local Karaf distros are handy for devs to test their work
however is unneeded by autorelease builds and should not be released
as part of the Simultanious Release. Add a profile that is active by
default so that default behaviour is unchanged however allows the
autorelease project to disable building this module.

Issue: RELENG-86
Change-Id: If42ef5140ecdf762cc57e2c938f1456784566446
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Remove obsolete Maven Site configuration

Change-Id: Ib303d75d40fb4d0ed7891439e31cbbc78f620c62
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BGPCEP-740: Fix logic for MED comparison in BGP best path selection

New better path should be selected only if new MED is lower than
actual best path MED.

Change-Id: I8bd07dc8b42e575cebcc4e1ea4b55d9c2c842f42
Signed-off-by: Ajay Lele <ajayslele@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix model compliance

Declared prefix should be unique within a module, as that is
the prefix that is used to refer to a module within itself.

Change-Id: I699c529831fd62854a50e46c105a3d7922d670f1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BGPCEP-732:  Pass IpAddress as BGP Peer identifier

a not give for true that it will be all the time Ipv4.

Change-Id: I5cb237f422fd4246d86e9e0c44e8dfda919a7af8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-770: Lock file before processing

In this way we ensure is not still been modified
when event is raised.

Change-Id: I69047f244e78bdf4536d6f2a83d3b80c45191e90
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit ac2ebcb16be3c1c17136cb479ba85f1c15dfa02f)

BGPCEP-774: Improver error message when missing AFI/SAFI

on peer configuration

Change-Id: I79568d87a0e8401fa71376e9a9c0b3b5389a8baf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-764: Use full Ipv6 form under StrictBGPPeerRegistry

Ipv6 equal is not capable of handle short or full form
of Ipv6, returning false when comparing different versions.
Therefore use full form under registry.

Change-Id: I2127f20e847860792d0f1c18b0ae243825a9d86a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit 889700a070e725f44ee3d4fe215d93312ac8f0bf)

BGPCEP-739: Fix  "raced with transaction PingPongTransaction"

under TopologyNodeState. Raced call to putTopologyNode
will cause an override node and therefore PathComputationClient
was being removed and ending on exception when trying to update
it after such change.

Change-Id: I1d5b44c383d7159669bec7475afff3713f1370a0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-760: Fix Dead lock

when connecting multiple peers at
the same time multiple routes are announced.
Fix by improve sync under Peer export groups.

Change-Id: I588db1bfc3cfca80308837084ac5088b8fc89cea
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Document path-id reserved value

Change-Id: I663ffac423e8a48c8528782165abc1406d70bb44
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-742 Fix BGP NPE filter null BGP State

from BGP State collector.

Change-Id: Ic23277b22466140c2e17c429eea7467fd9d33ce8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit b323c783131390fbc70f41db19271ddc1e16cbc5)

BGPCEP-672: Fix key storage un adj-rib-out

list key must not be null, therefore
path-id should always be included.
Reserving PATH-ID 0 for non-supporting
add-path.

Change-Id: I9b0af92e91e7c0b1c7281230a804c7adeff2dbca
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-737: Implement BMP client reconnection

after succesful connection goes down.
Remove duplicate code.

Change-Id: I8690de7d6a49c6c92e319c840a37a1fe043b9775
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-748: Fix AFI/SAFI

peer support registration when old-school BGP-4
is used.

Change-Id: I2137ea2647f01fb87bad04e682fe0bf5541768e8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-736: BMP Testtool retry connection

capability

Change-Id: I70169ff59c621e6a0c60b9b185bf9e2a2337b8b7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-758: Use random ip for Pcc mock tests

-perform some clean up

Change-Id: I79ef9f8e5f01b1d461c5848d7966f9e3521f926d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bump versions by x.y.(z+1)

Change-Id: I6f6a24eef097e0f5fb14efb0217bcd54675a91f5
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

BGPCEP-724 Make BGP Session recoverable

This patch make BGP Session recoverable when anything wrong
happens during netty session negotiation. When an exception
is captured, the BGP session will be terminated.

Change-Id: Id3fc7ec282a2151e3bd6bdbfa8930e141b3ceaff
Signed-off-by: Kevin Wang <kevixw@gmail.com>

BGPCEP-728: BMP Mock clustering

Fix clustering connection for bmp test tool
-enforce findbug

Change-Id: Icd0cb21467ab5c8fbea38a2561f0330cbdc5914d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit dd553db0255426051b8fd7f201a9895759c8bcba)

Improve CheckUtil testss

-enforce checkstyle
-enforce findbug

Change-Id: I9d3dd4dc6b6b6192d8015f0d9f11a4c7082e7297
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit 3fc26db07a4eadd2c6ed4d89b6beb42fce9cb568)

BGPCEP-717: Add logback config file

 for reduce log level of yang parser.
As a result we reduce 1G output to
only 12M

- set debug loglevel for test

Change-Id: I5ed2c81e006b3d78193383ad78e5e01f9cbdccb2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-717: Add logback config file

 for reduce log level of yang parser.
As a result we reduce 1G output to
only 12M

- set debug loglevel for test
- set info loglevel for yang parser

Change-Id: I29f4480d2bc9e27bb77be4cdb18d621f06d40bcb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit 4cb70b1abd7db5cf10db44cf36e7780a0fd3c5bd)

BGPCEP-711: BMP test tool clustering support

Make test tool able to connect to multiple nodes

Change-Id: Ic0011095140e7a31e598bc475f66713c85ed3038
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-706: Fix BGP Flowspec NumbericOphrand

Right now when serializing a NumbericOphrand, the "end-of-list"
bit is not properly set. The last entry in the ophrand list
should have this bit set according to RFC [1]. Otherwise the packet
will be in malformed format.
This patch fix BGP flowspec NumbericOphrand to set the "end-of-list"
field properly. When the serialization happens, the end-of-list
field will be set in runtime.

[1] https://tools.ietf.org/html/rfc5575

Change-Id: Ib8841360b47137dc0ec0f54c3ef156a298ba3c81
Signed-off-by: Kevin Wang <kevixw@gmail.com>

BUG-9079 Make PCEP session recoverable from exception

This patch makes PCEP session recoverable from any netty exception.
Whenever an exception happens, PCEP session will be closed. So it
will be at a clean state when the next session retry comes.

Change-Id: I38a983c44519fd5c12cb9cd0da09fa14c4177ac7
Signed-off-by: Kevin Wang <kevixw@gmail.com>
(cherry picked from commit 004a235ef03cf72dd39e91a2085fa94fd5c1c80d)

Bump versions by x.y.(z+1)

Change-Id: I233999b5f9c7ca041f16774daad88af4c7d34c02
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Bug 9205: NPE received while receiving BGP peers

Change-Id: I05383a406b03e5dc460e5ae013da82280920981e
Signed-off-by: Ajay Lele <ajayslele@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8929: NPE during singleton startup

Avoid NPE when installing features 'odl-bgpcep-bgp-api' and
'odl-bgpcep-bgp-impl' individually

Change-Id: Id651dff7c813544bd07a03b435069de5e723721d
Signed-off-by: Yrineu Rodrigues <yrineu.rodrigues@serro.com>
(cherry picked from commit ab128ea6a1ee1fd19578326049bbfd8084a250c4)

BUG-8987: Print Exception when Css registration fails

Change-Id: I34236ac8546358fe3c00985fbbf40f69aa0bef19
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bug-8942: Fix DelegatedLspsCount

mbean value returns count of all LSPs and not just
the ones that are delegated

- Fixed code to return count of delegated LSPs only
- Added unit-test

Change-Id: I067b4cff8c7503fa878742ab6605fca2685a6c15
Signed-off-by: Ajay Lele <ajayl.bro@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8156 : conflicting listener fix

In case another session listener is in conflict
with the existing one, close the new listener.

Change-Id: I1a594c3876eb1d28133dcc08b31f38deb5ceb27a
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>

BUG-8156 : fixed start of session manager

Upon restart of session manager, its close flag was never
set to false, causing pcep sessions to be rejected as they
rely on this value.

Change-Id: I676ea5774cea4cbbee84222d2ad562bea70e83f3
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>

BUG-8156 : duplicate session up fixed

In case of session up twice, the second session gets
deleted from pcep and controller.

Change-Id: I192a13e29ccb69bb869a9ed344d6f504d80100af
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Signed-off-by: Kevin Wang <kevixw@gmail.com>

Enforce no split packages

This patch augments Export-Packages with a directive to fail build
if a split package is detected.

Change-Id: I52a2a157f992cb97fd8c6a88cf45c933ed0fd953
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit c03293f4b1f5e396235713dc9b148eb32c19ddc9)

BUG-8722: fix regression introduced by BUG-5876

Change I707914f3ab0786c0ad8ba71a5476b3b7e322b0cd regressed
bgp-rib-impl packaging such that it massively over-included
classes, leading to split package.

This patch fixes that regression.

Change-Id: I6366972b88e3881675c3dd70517fc4e95c050261
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit e6368af274f1971ef5bf5e68ad4d1a11a8f86eab)

Bug 8667 - PCEP: When peer closes got IO exception

When peer closes the pcep session, it results on IO
Exception.
it is due to this close is not recognized as local pcep
PCEP session termination.
It was first implemented as a local pcep session
termination.
https://git.opendaylight.org/gerrit/#/c/906/1/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/PCEPSessionImpl.java
Solution: Use the reason encapsulated in the close message to close the session.

Change-Id: Ia423f5c10b117ef21af5a3bddc28652ebb659e26
Signed-off-by: matcauf <mcauffiez@inocybe.ca>
(cherry picked from commit b8d57a84bd130ff3f98cd08b175bb9da18a6e24e)

BUG-7027 : Remove Data change counter CSS configuration

since is not longer need it. New configuration is
done via REST.

Change-Id: I32c3ffcfa66108d72dd8033e44b1cbd7596537eb
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bump versions by x.y.(z+1)

Change-Id: I4ca0c3db2122263426d90fa678e81dd4d9dd27aa
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Revert "BUG-8156 Terminate PCEP session properly when ServerSessionManager is closed"

This reverts commit 361265e3d13003bc3bfe75c888c40713ecbb36de
which introced a new bug.
bgpcep-csit-1node-periodic-throughpcep-*-carbon not passing

Change-Id: I965b09b36ef46f2a0ba4ea6b4861d66b7d0ddaec
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8156 Terminate PCEP session properly when ServerSessionManager is closed

When the PCEP topology provider is loading the configuration initially,
the ServerSessionManager will be restarted.  Any new PCEP connection
coming in during this period will be rejected by the ServerSessionManager.

This patch is to terminate these rejected PCEP session properly when above
situation happens, so that the session can be established successfully
in the next retry.

Change-Id: Ifa3366c97025a0b31fb7d3ee50b1142f63a6209c
Signed-off-by: Kevin Wang <kevixw@gmail.com>

BUG-7027 : wired data-change-counter with Blueprint

Deprecate existing config modules,
add BP xml with custom config yang file.
No default configuration is set, to avoid
conflict modification when using on 3 node clustering.

Change-Id: I2b0408310605c9b96388585582d2e7a9f63007cb
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit 32edf04044a599bfff9a69abd94af53650c4a5ad)

Code Cleanup: unused var and imports

Remove unused logs, class member and
methods paramenters

Change-Id: I02640d49844d46726da8da9ae162507dc6c6e581
Signed-off-by: matcauf <mcauffiez@inocybe.ca>
(cherry picked from commit f23133e4267aa3a759eca8f03c4c51346418d0a1)

Code cleanup: Duplicate Code

Remove duplicated code

Change-Id: I318e391e95bc892ebcf6af3081a455e84843c93a
Signed-off-by: matcauf <mcauffiez@inocybe.ca>
(cherry picked from commit 54c65cb54ea79c7681d3dee6c0a289bd90f8b5b3)

BUG-8292 Fix BGP flowspec NLRI length read

In BGP Flowspec, NLRI length is set per NLRI. The
current implementation only read NLRI once. So
BGP parser will throw exception when multiple
NLRIs are batched in one BGP UPDATE message.

Change-Id: I6630bca4c222e68f4609134192550d6c0a7ea3ba
Signed-off-by: Kevin Wang <kevixw@gmail.com>

BUG-8156 Fix PCEP topology registration

It is possible that when a PCEP session is being dropped and being
unregistered from ServerSessionManager, the thread gets switched
thus the topology unregistering cannot finish.

If such situation happens, PCEP session from the same PCEP peer will
not be able to established until after DEADTIMER_EXPIRED, as the
topology instance was not removed correctly.

Change-Id: I647ecfbbb35ef6805d563753b7ebd87edfc350fe
Signed-off-by: Kevin Wang <kevixw@gmail.com>
(cherry picked from commit 2801f2b71ca49dcee50b643ef5ed4f53938609fc)

Remove unused LOG

Change-Id: I03d203e42e009ef737b07e05d56f2df5d650cded
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8548: Pass missing parameter to

SimpleBGPExtensionProviderContext#registerNlriParser

Change-Id: I625f82d64efa0d2843b94de31c649572be9cacf9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bump versions by x.y.(z+1)

Change-Id: I53f8c0348eaa3d2c652f7d8ab928deebc8de8e3d
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Fix RD pattern in RouteDistinguisherBuilder

Type 0 RD is 2+4 bytes.

Change-Id: I7ec0099cf5c1cdf8ab7d333dc26756c17228579b
Signed-off-by: Xiao Liang <shaw.leon@gmail.com>
(cherry picked from commit a52ecc55a9dca19ce563cea27263ea0842ff9789)

migrate yangtools deprecated BindingNormalizedNodeSerializer

migrate yangtools deprecated BindingNormalizedNodeSerializer
to mdsal BindingNormalizedNodeSerializer

Change-Id: I32439a487a209a567b5436b204c11d979ac46cc8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6801: Remove deprecated bgpcep *-all features

Remove deprecated bgpcep *-all features

Change-Id: Ib87ea2d091e2eead955b8cf959a02f071365a7f9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8356: Rename features4-extras

Rename features4-extras which colides
with controller features4-extras, making
SingleFeatureTest for repos/index fail.

Change-Id: I04c693f853178e08a15eaa5435310659f66ee061
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Commenting failing test until fix is implemented

Commenting out failing until fix is implemented

Change-Id: Icecd697ef54d8141780dfd2ee5cbb1f1f84e05ca
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8335: @Ignore InstructionDeployerImplTest

This test hangs fairly consistently in autorelease-carbon.

Change-Id: Idc6a207ff669f433096017494c24d99b8ec02c09
Signed-off-by: Colin Dixon <colin@colindixon.com>

BUG-8306: Fix Pcep failing test

Given that messages takes differents time to arrive on listener
Fix  Stateful07TopologySessionListenerTest by
use checkEquals, which checks the assertion with timeout.

Change-Id: I13733fa7ad7686671d9c026a8528ad912e2c7cd5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix karaf4 features

Features should be pulling in transitive dependencies from
the corresponding features. Fix that.

Change-Id: Ib758202ad0ff03e3a44b8a040dcc72f241c59920
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BUG-8275: Close ReadOnly transaction

PCEPStatefulPeerProposal needs to
close ReadOnlyTransaction created
after use it

Change-Id: I1515f09028c9e6bd8403d6ea2851196511d4da24
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BUG-8202: Fix Conflict Modification on odl-programming

Instruction DS configuration only should be written
on Leader when instatiateService.

Change-Id: I9acf17c8a19d8b22d83e62b315fdadf9494783f2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8252 Fix IP prefix length util

The byte representing IP prefix length is a unsigned byte.
The length should be converted to an unsigned int explicitly.

Change-Id: I0c1df171822858825da69f39c91de9ed332865f8
Signed-off-by: Kevin Wang <kevixw@gmail.com>

BUG-8198: Fix InferenceException

Add presence statement under graceful-restart-capability.

Change-Id: Idc98f74661d4dea4f440d178da868ec83f896370
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8213: Add missing mandatory attribute on tests

Add missing origin attribute on tests

Change-Id: I125437e187286a7a949e26191e66f19ded123274
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Update .gitreview to stable/carbon

Change-Id: Ia647e2ba233012ddd0d7a1e4896bb8f8210b4700
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Improve synchronization under BMP

Improve synchronization under BMP whenever
transaction chain is created and submitted.

Change-Id: If7a61c394218bd7c78c6021ee19ba42f4276560a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Restrict dependencies scope to test

Restrict various dependencies scope to test

Change-Id: I23cef78c244454d2059311c0d56af753f695c02f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-4491: Race condition under PCEP Topology Provider

Race condition under PCEP Topology Provider when
instace is reconfigured, since closeInstance under CSS
is nonbloking, it can race the delete with the writing
of the new instance when restarting.

Fix by calling first closeServiceInstance(blocking)
on topology instance and once it gets done call close.

Change-Id: If79bf34f77223bc56424a57e4e600fdb17ddd154
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8021: Race between Peer structure creation and route init.

There is a possibility of race between Peer structure
creation and route initialization/advertizement.

Fix by introducing a flag, which indicates whether
peer's structure has been created and is able to be updated.

Change-Id: Ia9515d2017cb5213ce286e463712092c87764e10
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7976: Race between peer removal and routes update

There is a race condition when we are advertizing routes,
and a session peer goes down which will end in
removing the peer from DS.
Since advertizement and removal are done by 2 different tx,
we need to do it blocking mode, and not route should be
advertized until peer is removed and vice versa, peer
should not be removed until routes are advertized.
Otherwise toure update will try to update a peer/path which
is not longer present.
Fix by rework PeerExportGroup & ExportPolicyPeerTracker,
now instead of generate PeerExportGroup each time a peer
is reg/unreg,  we make PeerExportGroup work as a
blocking registry to solve previous issue.

Change-Id: I46a27871bfa2aa2a632e3bfb76061105c62bb6d2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix sonar complains

- Remove unused imports
- Throw exception
- Name convention
- Comparison
- private constructor on util
- replace explicit type per <>
- migrate to java stream api

Change-Id: I224eb8dfe776130b0f45468be4791239daf878af
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix BmpDispatcherImplTest intermitent failure

-Use CheckUtil under test.
-Use mockito timeout.

Change-Id: I2e6c77de1324dc079375271bd7c2e2d028a9fc4f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6975: Integrate Topology Provider with CS Service

Integrate Topology Provider with CS Service

Change-Id: I0e9c42aa3538e0936b74120535fee369db1ad9d5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6973: Implement test for InstructionDeployer

Cover InstructionDeployer with test

Change-Id: I8ed071a8a11dd0d9183fe6c5b45ae7616f6ce5f9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Rework CheckUtil Test

Change-Id: Icada2980901bea076b061b933d8ba42876d0e5f5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Correct XSD pattern

YANG patterns are XSD regexes, so they have implicit ^/$
anchors. Fix this up.

Change-Id: I911ca3d3bd286c0f77bccfb4f3e9a3ef8fc8dbdb
Signed-off-by: Robert Varga <rovarga@cisco.com>

Code clean Up

Classes missing final

Change-Id: Ie260d9f4a48290b492171f79f94f7f8ee53ccbde
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Code Clean Up

Fix instance fields not accessed with this

Change-Id: Iec1520fa728ea21098dd5a79dbfa25837b117e1c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Code Clean Up

Anonymous type replaced by lambda

Change-Id: Idd81b1e43866e5d960ec2dfa777b66bae3e53da9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6973: Wire topology-provider with BP

-Wire topology-provider with BP
-Preserve backwards compatibility

Change-Id: Ibc459117b1656a0efe5e34365b9fc131479bdaea
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7960: Fix AssertionError under AppPeerBenchmarkTest

Use CheckUtil.readData for check DS update.

Change-Id: Iae77923c4b8fe0e3a87ffeff0b5c4d00815bf88d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Code clean up

Remove unnecesaries imports

Change-Id: I0ecf1894c1be211f9ffd7ed0d98a3c80ae9a6025
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7964: IllegalStateException under testReconectClient test

Fix by wait until channel is closed before retry to connect.

Change-Id: If1c7889b7988ce5cab3e11f73b6134ad2af182c7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit 7b48d57ba01775ff48b1686ea8093b009df2ee3c)

Fix NPE under TopologyProviderTest test

Fix by check reportedLsps is not null.

Change-Id: I18878db061ab5816ac5f13e5cdac21107df86aa1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove deprecated class AbstractDataBrokerTest

Remove deprecated class AbstractDataBrokerTest under
programming and data-change-counter tests
Perform some code clean up

Change-Id: I2ff02760338d8774c3908d107ff76de433acba2a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7946: Fix  SomeModifiersUnresolvedException

SomeModifiersUnresolvedException under ConfigLoaderImplTest
Fix by remove duplicated schema.

Change-Id: I1200e21e76e6da0d35a10932eede27df4a410aa0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7894: Fix ConcurrentModificationException under test

-Fix ConcurrentModificationException under
testSessionTriggeredFullDBReSync test
-Perform some code clean up

Change-Id: I8e4652f273ea994efa5b9477f8af59239e92dd08
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove pcep-service.yang.disabled

Remove pcep-service.yang.disabled

Change-Id: Ib862326a5cd976c6cc9fb714892c8064915a3cfb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove deprecated class AbstractDataBrokerTest under BGP

Remove deprecated class AbstractDataBrokerTest on tests.
Perform some code clean up under tests.

Change-Id: I64b120bdbbf59db4df0e4d4e2d769eac22738c33
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7937: Fix BGPTerminationReason

When closing the session because of some error
2 Notify messages are sent. One containing the
reason and other with CEASE.
Fix by dont send CEASE Termination Notification
if already other termination notification has
been sent.

Change-Id: Ibfabd7cfb038bef7a452a7458cd5cc1e6fa4b9a7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7003: Remove sleeping from Tests

Remove sleeping from test whenever possible.
Clean up some tests.

Change-Id: I734ca5721090669c75f09d107ee4c5ea1e3d14ee
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7505: Conflict Modification

When closing Peer and Rib, can cause
race condition between the removal
of the peer and the rib when updating DS.
Fix by close peers on blocking mode, and once
they are closed proceed with rib.
Same its applied in case that peer/rib is updated.
First we close it and then once DS is updated
we proceed with creating the new instance.

Change-Id: Ibe70e0324ae12bcbb88b2e7f039671141447ddb1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove deprecated class AbstractDataBrokerTest under PCEP

-Remove deprecated class AbstractDataBrokerTest on tests.
-Perform some code clean up under tests.

Change-Id: Iee8bdb1e190c80aa0ae883e52963afb6b29cc4f0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Programming Clean up

Migrate deprecated classes
Code clean up

Change-Id: I06551491a30499d81d4c0dc7f0e1dbe68dc04eab
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6975:  Integrate Programming with Cluster Singleton Service

Integrate Programming with Cluster Singleton Service

Change-Id: I95e3c8c1dc1e596c060256d3f59fec9cfe882456
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6973: Implement Programming config via DS

-Expose programming's configuration in config DS
-Allow multiple programming configuration

Change-Id: Ib6de3355dae6533367890ef87c504edbdca04654
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6973: Wire Programming with BP

-Wire Programming with BP
-Preserve backwards compatibility

Change-Id: I750fdb86a6c22d3b1a90e7466466ab7c5426d729
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bug 6859 - Binding generator v1 refactoring

Based on transfer of Binding generator v1 from
Yangtools project to MDSAL in past, we need to finalize
this process by refactoring package naming:
org.opendaylight.yangtools -> org.mdsal.binding
org.opendaylight.yangtools.sal -> org.mdsal.binding

Refactoring changes in MDSAL, see:
https://git.opendaylight.org/gerrit/#/c/52107

By using of Binding generator v1, this change needs to be addressed in
Bgpcep project.

- refactoring itself

Change-Id: Iccb2af9806db18a3e5bf98092ca70ae9b350dabf
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Improve Singleton Service Logs

Improve Singleton Service Logs

Change-Id: Ie09d2e00e7159539dcecc520ef0e9cd39ca4e02f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>