Bump versions by x.y.(z+1)

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Idb5b1cb45d623461399f8df9b46e893ff801eee9

Bump upstream versions

Pick up:
- odlparent-6.0.12
- yangtools-4.0.14
- mdsal-5.0.15

Change-Id: I3dad6a88e2f46ada14c7fe0fb028653ba22877ba
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use StandardCharsets.UTF_8

Let's not lookup the charset, just use a constant.

Change-Id: I3b4dbc83a5d574433822b292c47e9566ec7dca8e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 5c55c4dfc3cb4826b8756f79cdbaea862d43617b)

Repair AuthenticationManager

AuthenticationManager was utterly wrecked in commit
193729d84ebb567d94e75311cd3bb871e7731b0b, which removed its
binding to CM, effectively meaning it was always disabled.

This is best evidenced by the unused bits in OSGI-INF/metatype,
the unpackaged authn.cfg file and the fact AuthenticationManager
is referencing them without having the BluePrint wiring to do so.

The primary problem is addressed by switching to OSGi DS, which
eliminates all run-time dependencies on OSGi, as it is purely
compile-time.

This flushes out the rest of the problems, as in order to drive
the OSGi CM integration we really need a configurationPID --
which investigation has shown to be long-lost
'org.opendaylight.aaa.authn'.

Furthermore OSGi CM integration really discourages use of properties,
preferring those be bound to a configuration object -- which points
to src/main/resources/OSGI-INF/metatype/ -- hence we ditch those XMLs
and replace them with Metatype Annotations.

Doing all this shifts property interpretation solely down to
ConfigAdmin -- hence we do not need to deal with at all, cleaning up
AuthenticationManagerTest.

Finally, to take advantage of all this work, we re-ingrate the new
component into blueprint as a simple service. We throw in proper
@Singleton annotation as a bonus.

JIRA: AAA-201
Change-Id: I51e23dc02836208774e8cdb8fb1a999537a691a6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit d2451de3fdb03702b02a18f6b26c275ea576a489)
(cherry picked from commit 4b941f4ee405396feebf763b63ffcc55e73018a8)

Do not fail on warnings for docs-linkcheck

This is a workaround due to sphinx-tabs being incompatible with the
Sphinx linkchecker which throws a warning. We mainly use linkchecker
to catch broken links so we don't really need to fail on warnings as
the main "docs" builder will still fail for warning level issues so
this is a reasonable workaround.

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I489719282c71a11e2ffdc394f79307303a62ef73

Bump versions by x.y.(z+1)

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Ide33cc753a6f20d884adb12a31940dd53fd4aa80

Bump odlparent/yangtools/mdsal to 6.0.11/4.0.13/5.0.14

Pick up latest updates from upstream.

Change-Id: I9ba69da68f2ce0371cb89854edea192371e9b95f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent/yangtools/mdsal to 6.0.10/4.0.12/5.0.13

Pick up latest updates from upstream.

Change-Id: Ia39fc3e9a8b37294b6c2c205c3385e70b6339a40
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use version range for odl-mdsal-binding-base

Make sure we can upgrade version seamlessly.

Change-Id: Ib2426238955c2dc67ecdf5fe563dd9cb687d38ff
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent/yangtools/mdsal

This adopts the following versions:
- odlparent-6.0.9
- yangtools-4.0.11
- mdsal-5.0.12

Change-Id: Ibedf32a03c46a40f4d5a4e847e67f5d5794df020
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update dependency-check

We have a few artifacts added, make sure we update dependency-check.

Change-Id: Ic6b160122962821c2a4f696283ba990331b00699
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions by x.y.(z+1)

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I9e040558d6dc19f7b985bf87a5cad42856716916

Bump odlparent/yangtools/mdsal

This adopts the following versions:
- odlparent-6.0.6
- yangtools-4.0.8
- mdsal-5.0.10

Change-Id: I2bb0a6a92ffc934aab0ddf58b46d458d8251c678
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "AAA-194 Fix for Pattern Matching in Shiro" into stable/magnesium

AAA-194 Fix for Pattern Matching in Shiro

The Path Matching is based on AntPathMatcher
(https://docs.spring.io/spring-framework/docs/current/javadoc-api
/org/springframework/util/AntPathMatcher.html).
This Patch wil ensure the default urls also match in Shiro.

Signed-off-by: Venkatrangan Govindarajan <vgovindarajan@luminanetworks.com>
Change-Id: Iaa7a18d9138dad756eda24a31190421b07f25594
(cherry picked from commit fb552fc3b4d15ad4a3e0bed0b5cc4b524cf0abe4)

Remove jetty-servlet-tester references

These are ancient and we do not seem to need them anymore, remove
them.

Change-Id: I4e7c3315aa53526cc2ce630db9cbe9f657fd45be
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit ba13a62944fc7dfeebeb32b5b0047fd59eecc7bb)

Merge "Migrate OSGi compendium references" into stable/magnesium

Merge "Fix checkstyle" into stable/magnesium

Migrate OSGi compendium references

We are using OSGi R6, make sure we are also referencing the correct
compendium artifact name.

Change-Id: Ie142c309aa6b128e6223bf62d46dd2ad9ea50d8d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 99c1f680cef346f05b23f034fc8c4737d6e51ff6)

Migrate Assert.assertThat()

Migrate to non-deprecated version of assertThat().

Change-Id: I13a0387c46e758c3ba66fc0d38513311379d68d3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit fb5c2ecd6b7d68838e363a484f486a1ec8b807e0)

Fix checkstyle

Upgraded checkstyle does not like the mess in these declarations, clean them up.

Change-Id: Id6b42dc273f25ad716f048003d64a21022b08871
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit df9e167314bf839f2646674f1f0c3d9d46093f3a)

Bump versions by x.y.(z+1)

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I8732dc5d2c00bc625116b384b2d4803b7ec7333f

Cleanup KeyStoreConstant

Java 11 provides utility methods which makes it much easier to
interact with files. Use them instead of verbose code doing the
same thing.

Change-Id: I1cf5bb3e307bc31f2301b4537fc718d0c9d29d00
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix NPE when loading certificate

This Patch fixes the NPE when using a certificate from a
non-default location.

JIRA: AAA-191
Change-Id: If12d49d45d2e914bdc901ee692c02790bf9b51b9
Signed-off-by: gvrangan <vgovindarajan@luminanetworks.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update .gitreview to stable/magnesium

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Ife397f4210b34d88f42f4a23149d4e3959b83cbf

AAA-180: Fix Dynamic authorization

Repeated trials indicate the initfilter from shiro is never invoked for
this filter causing the problem. This patch instead uses the other metod(ProcessPAthConfig)
for initialization.

Signed-off-by: Venkatrangan Govindarajan <vgovindarajan@luminanetworks.com>
Change-Id: I30195bf745ac30f0cfd59021cb0b2fe524bede02
(cherry picked from commit 5b35f181c0315f5bcb99f95bd9a2ab4ea92122ef)

Fix variable name s/newUser/new_user/

this bug was introduced with a pep8 refactor done in
https://git.opendaylight.org/gerrit/c/aaa/+/86832

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I26a3c80df1e49d1514bcceb7d7a93eeae98b7e1c

Remove infrautils-testutils dependency

We do not need this dependency, remove it.

Change-Id: I14d328d25b6a8c05c6a0580495a0264d1e76b261
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Switch to JUnit assertThrows()

We have it available, there is no point to open-code it anymore.

Change-Id: I54274591545852bb7b698f436f7cf5581aa5494b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to odlparent-6.0.4/yangtools-4.0.6/mdsal-5.0.9

Pick up latest fixes and upgrades.

Change-Id: I41f80e0822a3232c8a7b1a3077322b9727b2215f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix python pep8 warnings

a few warnings were not fixed like line length over 79 and
using bare except. Those can be done later if desired.

Change-Id: Ib21f7fc803daa34f696ad3a2ad277ae8f6657b04
Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>

Catch missing arguments in python3

See inline code comments for more details

JIRA: AAA-193
Change-Id: Id4de48147aaef26a7bb03dd00cf24dbe0d77fb05
Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>

Drop dependencies on commons-text

We are only using commons-lang3, which is a transitive dependency
of commons-text. Remove the unintended dependency.

Change-Id: I3d8a42703996de800926cb20b17c1b65672e9324
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update immutables.org integration

Use only annotations, the rest is already configured from odlparent.

Change-Id: I6935b867f8e412128beb9f37b4872a20cc279c61
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent/yangtools/mdsal to 6.0.3/4.0.3/5.0.6

Pick up the latest upgrades and fixes.

Change-Id: I5a7098202d353bc1f9de761db66ae84e42a4c851
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove superfluous feature dependencies

We are generating features automatically, do not explicitly
specify dependencies, as they are picked up as needed.

Change-Id: I14cd2079a22d264dfa55dcf254fba59dd005da7e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to odlparent-6.0.1/yangtools-4.0.2/mdsal-5.0.4

This picks up latest upgrades and fixes.

Change-Id: I8db358b0af81394a561071d98bffea168dda47cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Do not use toString() with loggers"

Merge "Updated the user guide after testing"

Fix idmtool.py for handling errors

a. Modify the exiting method for checking REST reponses
and report success/failure.
b. Handle intermediate GET failures

JIRA: AAA-114
JIRA: AAA-120
Change-Id: I981e46859a2313a0f782b012920b2ab824ffcf44
Signed-off-by: Venkatrangan Govindarajan <vgovindarajan@luminanetworks.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use toString() with loggers

Formatting statements which are arguments to debug() is wasteful,
as logging implementation will do the right thing if/when needed.

Change-Id: Ic00eec1a23378f70b272151fc1224e9c13b0ebd8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup JettyWebServer suppressions

This cleans up exception handling, removing unneeded supressions
and lowering the scope of the checkstyle:IllegalCatch.

Change-Id: I8a385e6508d593a21f9f4dd613345f7afff17c14
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Aggregators should use odlparent-lite

These are mistakenly using full odlparent, which is not what
we want. Additionally aaa-password-service lists dependencies,
which is also wrong.

Change-Id: I2696f5340554a168650563244e035ba9907e989a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove comons-beanutils overrides

odlparent is propagating the proper definition, do not override
it here.

Change-Id: Ie2ea3ed759d0f6d54a36cb5d23155fcc039295fb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove install/deploy plugin configuration

Control install/deploy through a simple property rather than
spelling out the complete configuration for install/deploy plugins.

Change-Id: I902c383957d815fd32eb0c35125db9d34d017e11
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Ditch dependency on infrautils.testutils"

Merge "Fix Typo in RPC Name"

Ditch dependency on infrautils.testutils

We are depending on testutils only for WebClient. Java 11 provides
a simple HttpClient, which is way more powerful, use that rather
than a random home-grown thing.

Change-Id: Id406b7a774e54b325a5f05f5b8ca786eab2aa522
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fixup aaa-cert-mdsal pyang warnings

This is just a matter of reordering statements, fix that up.

Change-Id: I25cb60842dcdee6bfbb212caa2bda380cfbb69af
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneeded checkstyle/spotbugs declaration

odlparent is enabling these, remove superfluous configuration.

Change-Id: Ib3b54f3db0a52c52197e47a5adfe7a572b55f56f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix Typo in RPC Name

This is a simple typo, make sure we have a sane interface.

JIRA: AAA-186
Change-Id: I1ecceff4c860792664b6dbd17c8309b8bb43dbaf
Signed-off-by: Venkatrangan Govindarajan <vgovindarajan@luminanetworks.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove use of jdepend.maven.plugin.version

jdepend-maven-plugin is properly declared in odlparent, remove
the property reference.

Change-Id: I576b692dc28041875120e04aa0eba6caad0afbb0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump mdsal to 5.0.3

This bumps mdsal to 5.0.3 to workaround issues with Blueprint
injection.

Change-Id: I848c9220ce06ec7b4af304ab64948bdc30257dbd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Disable slf4j SSL link

slf4j does not provide apidocs over TLS (WTF?!?!?!), link HTTP
site instead.

Change-Id: I2158c043a2d9e810a329587159fc6af9d57d8e56
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump mdsal to 5.0.2

This bumps mdsal to 5.0.2 as part of Magnesium MRI.

Change-Id: Id9ab45edf28477dca8acf8f7538cfd26f237f6f4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Updated the user guide after testing

Change-Id: Ida7ddee17c36290767257356ec568be968b0d350
Signed-off-by: Venkatrangan Govindarajan <vgovindarajan@luminanetworks.com>

Bump yangtools to 4.0.1

This bumps yangtools to 4.0.1 as part of Magnesium MRI.

Change-Id: I6228c73d31721c8427e7f456afd5ab3ff715c88b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Reduce javadoc links

There is a bunch of links we do not use -- just remove them.

Change-Id: Ia03e1e048ad0833e3d63fd45dcc931a47076747a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent to 6.0.0

This bumps odlparent to 6.0.0 as part of Magnesium MRI.

Change-Id: Id4623f27c1c34a2dfeb41b610e0b650ba73443d7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fixup web-api tests

This removes @Ignore from the two out of three tests, and fixes them
up to perform correct assertion. Also ditch dependency on infrautils
while we're at it -- while this has *some* duplication, we will ditch
that once we have JUnit 4.13 anyway.

Change-Id: I85a8701a6bb9bfa08aa02a8233e20c9814a82ed6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add modernizer suppressions

We are dealing with Dictionaries, hence we need to suppress
modernization.

Change-Id: Icd25282433fc86fdeba28d45a6bfc476b8c504cf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump mdsal to 4.0.6

This brings in the latest fixes.

Change-Id: Ib5b6a2cc0fa56b5b7d999d4ec6f74feedd3951ef
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump yangtools to 3.0.5

This picks up the latest improvements.

Change-Id: Iad3b646f63a274022f004fa9f3d0b2ebdf0cf9db
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent to 5.0.2

This bumps odlparent to pick up latest references.

Change-Id: I42508f1a80a959766ec5223d31ac255ebd16e9f2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Update docs header to Magnesium in the master"

Apply code modernizations

This migrates off of methods pointed out by modernizer plugin.

Change-Id: Idc4411bab70ce946551da618ba7f6257c4902098
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate Vector to ArrayList

As pointed out by modernizer, we should be using ArrayList instead
of Vector.

Change-Id: I184d63b2f124ba8fae169d61234493eeb4fe935e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate deprecated newInstance()

Class.newInstance() is deprecated since Java 9, remove its use.

Change-Id: Iae15923310b8001ed1b58e22a28dd5c36f3a00d8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix checkstyle

This fixes up checkstyle warnings reported by updated version.

Change-Id: I91fd55a8817630c36e673adc3b8569a82aa315f6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneeded assert

This assertion is always true, remove it.

Change-Id: I8e24a6bfb3c662dfc4e96df77d1df79d81a2380b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update docs header to Magnesium in the master

Should be Magnesium on master and Sodium on stable/sodium.

Signed-off-by: Anushka Bhandari <anushka16134@iiitd.ac.in>
Change-Id: I3e4db5d8431ebac5b55cdb00ccd6f3de9831f440

Bump mdsal to 4.0.4

This brings in latest fixes.

Change-Id: I59f89ef4fe76ef16fcdc9b59f8d9b50aa0849847
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions by x.y.(z+1)

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I10ceb0ab12c777b0cb034a4e28054bb441973428

update dev-guide.rst

update the instructions for servlet support

Issue-ID: AAA-185
Change-Id: Ibc8537f33893d82f3bb5fc924a5d714c7d428267
Signed-off-by: nullop <ks6305@att.com>

Bump mdsal to 4.0.3

This bumps mdsal to 4.0.3, bringing in latest fixes and improvements.

Change-Id: Ie8e03aab1f31edf80bc9f1d7896c334c9d83be8d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump yangtools to 3.0.4

This picks up latest fixes and improvements.

Change-Id: I03201927d23762acf641c1ab0ff3419ba8b94969
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent to 5.0.1

This picks up the latest upgrades.

Change-Id: If6006a94197839a9718cd5eae16b0a025913af93
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix JDK11/docs compilation

JDK11 is more picky about errors, this fixes them up.

Change-Id: I89d2179bdc07572edeb7d5158ede398078e618b0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add aaa-docs

This adds documentation aggregator, which produces a aaa-docs.jar,
containing all AAA documentation we have in-tree.

Change-Id: I73e900e655ce2153ec0ab53cde4f90e9f15880ed
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Initialize MDSALDynamicAuthorizationFilter lazily

Filters should not initialize in their constructor, but rather
when instructed to do so by the container. This patch moves
initialization to onFilterConfigSet(), which is called from
the init() method.

Change-Id: I37c371c94ea3abc8dccd1793bf9dd981bf034b36
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump mdsal to 4.0.2

This picks up the latest improvements.

Change-Id: Ic51617c1ef8574c949995d81daad4e6b2ae3db07
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump yangtools to 3.0.1

This picks up the latest fixes.

Change-Id: I5aa12ab70664b573710a7648df2bc61b6fbeb013
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump mdsal to 4.0.1

This bumps mdsal to 4.0.1.

Change-Id: I567bb9d42b8ec0691e515d030699829ea6b1c5a5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add web-jetty-impl to artifacts

Failing to publish the proper version is a mistake forcing
downstreams to specify multiple versions. Fix that.

Change-Id: I4fd4409914f64d32f3602e1c7ae36e84033b19db
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump mdsal to 4.0.0

This bumps mdsal to 4.0.0.

Change-Id: Ie12f7a41e1620fd366f132e4fe7232e2c5d7a89b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump yangtools to 3.0.0

This bumps yangtools to 3.0.0, with no additional changes required.

Change-Id: I35e75b228308a40edc1d4f4b2c00466cc0b47d86
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent to 5.0.0

This bumps odlparent dependencies to 5.0.0, removing references
to javax.annotation.concurrent, as they are not that useful.

Change-Id: I6ceb7d04c41a533ea9f7f7c329a6a59c72fc3e4c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not unregister oauth2 endpoint

Since we are not registering the endpoint, we should not be
unregistering it.

Change-Id: I96ed22f6c7e4bff4670650ca83265ef908813b86
JIRA: AAA-173
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix warnings in aaa-filterchain

These are simple uses of deprecated methods, missing serialVersion
and unneded suppression.

Change-Id: Ic3d7fc013b0152b62ab6a57ef076c2dbc81a6420
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Remove dependency on features-test"

Remove dependency on features-test

This dependency should not be used anywhere, remove it.

Change-Id: I8de63c1fa7dbdf9aa58c8535fde2bb9120dc6b3e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

AAA-174 : Don't reuse JDBC connection

Multiple threads can obtain same instance of Connection
which is not thread safe. After first thread call #close()
other threads can't use connection further.

Proper solution would be connection pool, but as H2 store
is local, obtaining new connection is cheap.
Local testing doesn't yield measurable performence penality.

Change-Id: Ie326e39da8cb01283cc516ef99363c0f4236698d
Signed-off-by: Richard Kosegi <richard.kosegi@gmail.com>

Eliminate AAA OAuth2 Provider

For the foreseeable past, OpenDaylight AAA development team has
agreed to avoid becoming an IdP.  The simple fact is that there
hundreds (if not more) of IdP solutions that are very secure and
have been proved with time.  The cost of maintaining an IdP is
extremely high, as the code is not always simple, and requires
highly skilled, security minded developers to maintain.

However, one remenant of IdP currently exists as a part of ODL
AAA, namely the OAuth2 Provider Implementation.  The OAuth2
Provider implementation allows users to derive scoped access
tokens in order to access the controller without using plain
credentials.  Part of OAuth2 inherently also provides easy
revocation of tokens.

However, this begs the question, are we an IdP at this point?
The preferred security model would be to delegate to an external,
third-party OAuth2 Provider, since many exist and are readily
available for federation.  This would limit the scope to
client-only for AAA.  This is preferred since AAA should not
be responsible for generation and revocation of tokens.  The
existing implementation utilized Apache OLTU, which has now
been retired to the Attic.

This patch favors removing unmaintained, possibly vulnerable
security code over maintaining OAuth2 backwards compatibility.
The functionality is not being replaced for two reasons:

1) we strive not to act as and IdP
2) most other OAuth2 provider solutions are spring-security based,
and are fairly difficult to use from non-spring contexts.

JIRA: AAA-173
Change-Id: I090014771b2f345cedc0330738b15b18684e1fcf
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove javax.annotation-api version overrides

odlparent-4.0.9 is integrated, hence the override is not needed
anymore.

Change-Id: I535c5b9e93a0d324729a7c741cab178b6cae01a1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Eliminate powermock from aaa-encrypt-service

The single test here is easily reformulated in terms of mockito,
hence remove static mocking and powermock.

Change-Id: I80b6ac652cd985cdd5e3f12244a503ec86e9560c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate to ArgumentMatchers

This fixes warnings in aaa-cert around use of deprecated mockito
methods.

Change-Id: Iadb9adbcc409d10dd85b12aa97204178df18faa5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove powermock from KeyStoresDataUtilsTest

This test uses static method mocking, but that can be easily
fixed by injecting proper DataBroker behavior.

Remove static mocking, eliminating the need for powermockito
in aaa-cert.

Change-Id: I507eadf7ac789c0aae3a057dc8440d425b90a90a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove powermock from AaaCertProviderTest

This test does not require powermock, use plain mockito instead.

Change-Id: Icbb330547fb1fe771b340e3db00600b5e7363e98
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

make JettyWebServer accept WebContext path without slash (and test it)

because that is, apparently, what the "real" (Jetty through Pax Web)
implementation in the Karaf run-time does.  This has come up in the
review of change I614a48bcc425db8faa1a79ebd6236236bcd09e73, where I
added a slash to a context to get a test to pass - with this, that is no
longer needed.

Change-Id: I3c632adbb4c4a9d9ac7bed4557bcaaece47dd0cf
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump versions by x.y.(z+1)

Change-Id: Ie79426eab5edd155329862d04fe9ce44c7d0c656
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>