lispflowmapping.git
6 years agoBump versions by x.y.(z+1) 40/71940/1 stable/nitrogen
jenkins-releng [Thu, 10 May 2018 23:34:39 +0000 (23:34 +0000)]
Bump versions by x.y.(z+1)

Change-Id: I2b00f1ad1f0ca360c1b53539b061d2ec3988022e
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
6 years agoBump to odlparent 2.0.7 85/71385/2
Stephen Kitt [Thu, 26 Apr 2018 09:28:03 +0000 (11:28 +0200)]
Bump to odlparent 2.0.7

Change-Id: I04c09e93283847e5d93debe6c39619b1327b89a3
Signed-off-by: Stephen Kitt <skitt@redhat.com>
6 years agoRevert "Add Karaf build profile" 52/70752/3
Thanh Ha [Wed, 11 Apr 2018 02:06:23 +0000 (02:06 +0000)]
Revert "Add Karaf build profile"

This reverts commit a756e1a3c89ddf2e92f1b65e36a7e745bdd607ec.

Change-Id: I717e522ecc143a38c19fe5fadc853f64d0860fd3
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agoMerge "Revert "Add integrationtests to the karaf profile"" into stable/nitrogen
Lori Jakab [Wed, 11 Apr 2018 23:53:30 +0000 (23:53 +0000)]
Merge "Revert "Add integrationtests to the karaf profile"" into stable/nitrogen

6 years agoRevert "Add integrationtests to the karaf profile" 07/70807/1
Lori Jakab [Wed, 11 Apr 2018 20:27:06 +0000 (20:27 +0000)]
Revert "Add integrationtests to the karaf profile"

This reverts commit 46fb5782d0a18ab4446261001f9df671d183cdf9.

Change-Id: I455c971dd9101367f5443b2e90d1752a56c219d4
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoMerge "Increase MD-SAL logging to DEBUG in IT" into stable/nitrogen
Vina Ermagan [Wed, 11 Apr 2018 18:34:14 +0000 (18:34 +0000)]
Merge "Increase MD-SAL logging to DEBUG in IT" into stable/nitrogen

6 years agoAdd integrationtests to the karaf profile 19/70719/1
Thanh Ha [Tue, 10 Apr 2018 14:55:22 +0000 (10:55 -0400)]
Add integrationtests to the karaf profile

integration tests need karaf to build so must be activated along
with the karaf distrobution.

Change-Id: I7ca8dff52bb6f9103e591ac4a224088cc1b60889
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agoAdd Karaf build profile 31/70531/1
Thanh Ha [Sat, 7 Apr 2018 02:21:23 +0000 (22:21 -0400)]
Add Karaf build profile

Project local Karaf distros are handy for devs to test their work
however is unneeded by autorelease builds and should not be released
as part of the Simultanious Release. Add a profile that is active by
default so that default behaviour is unchanged however allows the
autorelease project to disable building this module.

Issue: RELENG-86
Change-Id: I865cb1fb873acc02488f9a6274515d5279a8b5ee
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agoRemove obsolete Maven Site configuration 30/70530/1
Thanh Ha [Sat, 7 Apr 2018 02:20:50 +0000 (22:20 -0400)]
Remove obsolete Maven Site configuration

Change-Id: Iebcfea2784ffd3ebfb208dabf6bf8bf9d379c48a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agoIncrease MD-SAL logging to DEBUG in IT 24/67724/2
Lorand Jakab [Tue, 30 Jan 2018 13:36:55 +0000 (15:36 +0200)]
Increase MD-SAL logging to DEBUG in IT

Change-Id: I33074f5ed5dd6253d71c05b2c881247c1de1b66f
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBump versions by x.y.(z+1) 77/68577/1
Thanh Ha [Fri, 23 Feb 2018 21:20:38 +0000 (16:20 -0500)]
Bump versions by x.y.(z+1)

Change-Id: I4b8c1ab527855abe34ef6561427eea32c6ee8537
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agoIncrease some of the integration test timers 12/67012/3
Lorand Jakab [Fri, 12 Jan 2018 11:43:28 +0000 (13:43 +0200)]
Increase some of the integration test timers

After the Jenkins infrastructure was moved to a different cloud,
integration tests started failing in different ways, even after VMs were
upgraded to 4 vCPUs. This patch is a result of trial and error to see
what timings can compensate for the slowdown in MD-SAL performance on
the new infrastructure.

This patch was not needed on my local machine for the build to pass.

Change-Id: I96dc4b8b1f5c3b09df2c24a492e2bcaf0c838114
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBug 9171: Fix lookup when first result is expired 12/66412/1
Lorand Jakab [Tue, 28 Nov 2017 10:36:08 +0000 (12:36 +0200)]
Bug 9171: Fix lookup when first result is expired

When looking up southbound mappings, we check if they are expired, in
which case we remove them and return null. This patch keeps looking up
mappings after deletion, since a valid non-expired mapping matching the
lookup key may still exist.

JIRA: LISPMAP-168

Change-Id: I73550275cc27215296dd7b51c1708e6c7a5f8791
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 02186956943bb7932c75f1d7fde7a2adafec0df0)

6 years agoBug 9116: Fix negative mapping handling 11/66411/1
Lorand Jakab [Fri, 8 Dec 2017 10:46:23 +0000 (12:46 +0200)]
Bug 9116: Fix negative mapping handling

Change-Id: I23022dc9481e52363cbb4768caf17a44894e74ee
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 3052c6925c7acbde86101ea38bcbd3bba5696c6c)

6 years agoBug 9116: Move notification logic to MappingSystem 33/66233/2
Lorand Jakab [Wed, 15 Nov 2017 12:22:00 +0000 (14:22 +0200)]
Bug 9116: Move notification logic to MappingSystem

JIRA: LISPMAP-165

Change-Id: I78c66d7801118536729fdf3e8fe42d5312129cef
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit c21a95c086d81e26aee48a624c8b44dc8c726522)

6 years agoBug 9116: SMR children of a prefix too 25/66225/1
Lorand Jakab [Tue, 12 Sep 2017 17:41:01 +0000 (20:41 +0300)]
Bug 9116: SMR children of a prefix too

JIRA: LISPMAP-165

Change-Id: I99800a800cef37a5d9cd1b33fe2e13a6d1ca1f5d
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 5d0eed4dade2350534ad190244baf0ed7bafedbc)

6 years agoBug 9116: Add getChildPrefixes() method to caches 23/66223/1
Lorand Jakab [Fri, 8 Sep 2017 12:26:24 +0000 (15:26 +0300)]
Bug 9116: Add getChildPrefixes() method to caches

As a first step to fixing the bug, we need a way to find child prefixes
of a given prefix.

Change-Id: Icaf45888766e79fb2800fb4e24f3aa4e67eb580e
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit dc263f8aa8ee431ff8f80559742d6e76806755b5)

6 years agoFix NPE in MappingSystem#removeMapping() 28/66028/1
Lorand Jakab [Tue, 28 Nov 2017 14:34:25 +0000 (16:34 +0200)]
Fix NPE in MappingSystem#removeMapping()

JIRA: LISPMAP-173

Change-Id: I61540332110869c1bacc670695b378c268298a76
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 0dae9b11d0f439d62dacdc134b826a98a75e7b18)

6 years agoBug 9311: Remove expired mappings before printing 02/65002/2
Lorand Jakab [Wed, 18 Oct 2017 11:41:49 +0000 (14:41 +0300)]
Bug 9311: Remove expired mappings before printing

Change-Id: I11aa5ab1b8313c7f1bca5968ab486afc7cd45ec7
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 95fa93918ff8b29498aeb7f342e3d0d1f8e71063)

6 years agoBump versions by x.y.(z+1) 72/65972/1
jenkins-releng [Tue, 28 Nov 2017 03:49:04 +0000 (03:49 +0000)]
Bump versions by x.y.(z+1)

Change-Id: I9307d902189d1414d2350dbc110b9fb1406eeaf4
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
6 years agoBug 9127: Make IT more robust when receiving packets 02/64102/1
Lorand Jakab [Fri, 1 Sep 2017 13:14:47 +0000 (16:14 +0300)]
Bug 9127: Make IT more robust when receiving packets

Methods of the type receiveMapNotify() pass the raw packet to a specific
deserializer without checking if the packet is actually of the correct
type. Deserializers expect checking to happen outside, and deserialize
anyway. In some cases, they even succeed without throwing an exception,
with erroneous results. This is obviously bad.

This patch fixes the serializers to throw an exception when the wrong
packet type is passed for deserialization. It also makes the
receiveXXX() methods in the IT to retry until they receive the expected
packet type.

In some cases, a Map-Register can cause an SMR to be sent. SMRs are sent
in a separate thread. This may lead to a race condition beween the
Map-Notify sent back to the xTR and the SMR sent to the subscriber. In
some cases, we expect a Map-Notify, but deserialize an SMR as a
Map-Notify, if it comes first. We had IT fail in the past with a message
of the type:

MappingServiceIntegrationTest.testLCAFs:357->registerAndQuery__SrcDestLCAF:1828->registerAddressAndQuery:1789 expected:<8> but was:<-859317697383733792>

This patch finally fixes that.

It needs to disable testRepeatedSmr() though, because the test is
broken, and it never actually worked as intended. It will be fixed in a
future commit.

Change-Id: Ife4396013df82cb6320978c3c02536df91fba646
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 94989baeda43fa8e9da628fcefa1ad60c4948c87)

6 years agoBump odlparent 2.0.4 to 2.0.5 73/63673/2
Stephen Kitt [Wed, 27 Sep 2017 13:34:33 +0000 (15:34 +0200)]
Bump odlparent 2.0.4 to 2.0.5

Change-Id: I4c7e96da4721264323f31ad610ebfb57088dec62
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit e479a85bfb22d18cebf20649d8743345e236f9b4)

6 years agoBug 9172: Don't store subscribers with "No Address" source EID 33/63633/1
Lorand Jakab [Fri, 15 Sep 2017 19:44:50 +0000 (22:44 +0300)]
Bug 9172: Don't store subscribers with "No Address" source EID

Change-Id: Ifc9bc62c875c4a6bd42bf9b53286dd461cd2f7cc
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 11e9b23c7624f5821577a96de4b9252f821b5e8a)

6 years agoBug 9037: Fix positive overlapping negative 15/63615/1
Lorand Jakab [Tue, 5 Sep 2017 10:08:42 +0000 (13:08 +0300)]
Bug 9037: Fix positive overlapping negative

Change-Id: I026d94ed9604287a0dae1a3bba2dc0f201c38793
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 0f7f9b45027171c6f4caf5b8f36498e0cfd2bbef)

6 years agoBug 7947: Move subscribers to a separate cache 10/63610/1
Lorand Jakab [Thu, 31 Aug 2017 10:26:28 +0000 (13:26 +0300)]
Bug 7947: Move subscribers to a separate cache

Change-Id: I2cfa03b2dcdcea21e5c4382747b7317f4eb5f30b
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 05ae28a1d25b16f37667e695c9111babdd00e9d1)

6 years agoRevert "Bug 7947: Store MappingOrigin in MappingData" 02/63602/1
Lorand Jakab [Wed, 30 Aug 2017 11:29:44 +0000 (14:29 +0300)]
Revert "Bug 7947: Store MappingOrigin in MappingData"

This reverts commit 8dcc9410db67deddd3fe3a35e53a28e5d64ddfc8.

Change-Id: I22fc039b21a4ac94aca0ef32aa27b64b9c557389
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit c5d4830ce5df9f97c8ddbab43490dbb9264ed4ea)

6 years agoBug 9023: Fix merging of negative prefixes 98/63598/1
Lorand Jakab [Tue, 20 Jun 2017 11:54:10 +0000 (14:54 +0300)]
Bug 9023: Fix merging of negative prefixes

This happens after a positive mapping removal. Add integration test to
keep from regressing.

Change-Id: I32788e8af5b457bf895197ba11add34e8ae06c57
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 3e875e5c4e77cc6f4d9689b9fd83dfb4ec954524)

6 years agoBug 8746: Multi-threading improvements 13/62713/2
Lorand Jakab [Fri, 4 Aug 2017 12:10:24 +0000 (15:10 +0300)]
Bug 8746: Multi-threading improvements

Remove all state from SB handlers

This needs a significant rework of the LispSouthboundServiceTest test
class, moving even more functionality to Mockito, so eventually we can
remove the dependency on the old unittest.tools.

Change-Id: I901c5633cb60563ac5bc38a521796dad2186886a
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 384b058a907b8ce37e896e8050c65c6a67414476)

6 years agoBump versions by x.y.(z+1) 58/63558/1
Thanh Ha [Tue, 26 Sep 2017 21:13:08 +0000 (17:13 -0400)]
Bump versions by x.y.(z+1)

Change-Id: I81b1b10a37abaec9fe6be2df777db06c6e9513b4
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agoBug 7947: Store MappingOrigin in MappingData 77/61877/1
Lorand Jakab [Tue, 4 Apr 2017 16:20:14 +0000 (19:20 +0300)]
Bug 7947: Store MappingOrigin in MappingData

As a first step towards separate subscriber storage, based on origin,
this patch adds support for storing the origin of a mapping in the
MappingData object. The origin is defined as a Set, to support the use
case of returning a combined mapping with information from different
origins, such as the NB_AND_SB policy surrently.

This patch doesn't change behavior yet, it just stores the origin.

Change-Id: Id285e829fed794de9ecf40ee9a9cb5e775228e92
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 8dcc9410db67deddd3fe3a35e53a28e5d64ddfc8)

6 years agoRemove our NETCONF component 17/61817/1
Lorand Jakab [Thu, 10 Aug 2017 08:41:26 +0000 (11:41 +0300)]
Remove our NETCONF component

Our NETCONF connector has not been updated since several releases, and
any attempt to make it work again would likely mean reimplementing from
scratch. It is using the config subsystem too.

Worst case, if we still need to code for whatever reason, we can
resurrect it from old Git revisions.

Change-Id: Ia3e9479a1e83fbdc1f69d946c197e8f39ca9e9a4
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 5f02c77fba96dad176f2d4b4dbba66fddb4bd9f0)

6 years agoBug 8746: Multi-threading improvements 94/61794/2
Lorand Jakab [Mon, 7 Aug 2017 17:34:20 +0000 (20:34 +0300)]
Bug 8746: Multi-threading improvements

Fix southbound Map-Register cache authentication update code

Change-Id: I616d199e1fc6f37357c35ac75a9c60c5884068f7
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit a4002190b571db0466e678feeee5b3c47a42f760)

6 years agoBug 8112: IT: send SMR-invoked Map-Request on SMR 93/61793/2
Lorand Jakab [Fri, 31 Mar 2017 11:40:45 +0000 (14:40 +0300)]
Bug 8112: IT: send SMR-invoked Map-Request on SMR

Change-Id: I3458ef941460ad5af91ef097c16f17894f5bbfa9
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 1a88dcbfb533c0188047784f2ecb7d11ae0547f4)

6 years agoBug 8469: Account for losing prefix length in Source EID 92/61792/1
Lorand Jakab [Fri, 11 Aug 2017 17:11:20 +0000 (20:11 +0300)]
Bug 8469: Account for losing prefix length in Source EID

Change-Id: I188d3001d887ade55be3a90738f74d0bace48c81
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit bd7c037a5737571cd58a6b4f464f594dae7363ab)

6 years agoUpdate .gitreview to stable/nitrogen 46/61646/1
Thanh Ha [Mon, 14 Aug 2017 16:23:59 +0000 (12:23 -0400)]
Update .gitreview to stable/nitrogen

Change-Id: I02db0341a15e64f9ab0a6baf2d7ff18b2056fba1
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agoMerge "Bug 8746: Multi-threading improvements"
Vina Ermagan [Mon, 14 Aug 2017 00:13:54 +0000 (00:13 +0000)]
Merge "Bug 8746: Multi-threading improvements"

6 years agoMerge "Bump odlparent 2.0.2 to 2.0.4"
Lori Jakab [Thu, 10 Aug 2017 04:43:47 +0000 (04:43 +0000)]
Merge "Bump odlparent 2.0.2 to 2.0.4"

6 years agoBump odlparent 2.0.2 to 2.0.4 44/61344/2
Stephen Kitt [Tue, 8 Aug 2017 16:14:05 +0000 (18:14 +0200)]
Bump odlparent 2.0.2 to 2.0.4

Change-Id: Ie310e026eb3408b236be40dffdea58171a8e166a
Signed-off-by: Stephen Kitt <skitt@redhat.com>
6 years agoMerge "Switch to MD-SAL LISP address model"
Vina Ermagan [Tue, 8 Aug 2017 18:25:51 +0000 (18:25 +0000)]
Merge "Switch to MD-SAL LISP address model"

6 years agoBug 8746: Multi-threading improvements 09/59509/6
Lorand Jakab [Mon, 26 Jun 2017 07:52:35 +0000 (10:52 +0300)]
Bug 8746: Multi-threading improvements

- Remove non-concurrent statistics class
- Make some variables 'volatile'
- Make some methods 'synchronized'

Change-Id: I83471fe7a422e63c2ab90e4c5fbc97b69c187247
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoSwitch to MD-SAL LISP address model 40/60940/3
Lorand Jakab [Mon, 31 Jul 2017 15:08:55 +0000 (18:08 +0300)]
Switch to MD-SAL LISP address model

ietf-lisp-address-types.yang was added to MD-SAL in [0] with the
intention to be the canonical place for the model. This patch removes
this model from lispflowmapping and switches to using that model.

[0] https://git.opendaylight.org/gerrit/#/c/60528/

Change-Id: Ib731bf9f10efd7f4417d3ea8cb1b73018519062f
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBug 8764: Fix handling of old negative 18/59618/6
Lorand Jakab [Wed, 28 Jun 2017 12:35:45 +0000 (15:35 +0300)]
Bug 8764: Fix handling of old negative

Change-Id: Ia3295c955ecf7b364865e445cb7f75a0ec80a6bf
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoRemove config subsystem remnants 09/61209/1
Tom Pantelis [Fri, 4 Aug 2017 20:02:16 +0000 (16:02 -0400)]
Remove config subsystem remnants

lispflowmapping no longer uses the config subsystem so remove
remnants from the pom.

Change-Id: Ia211b670d6c3277f0ebc164fe1676f203c7a79cc
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
6 years agoMerge "Return negative mapping with 0 TTL for deletion"
Vina Ermagan [Fri, 21 Jul 2017 05:03:42 +0000 (05:03 +0000)]
Merge "Return negative mapping with 0 TTL for deletion"

6 years agoReturn negative mapping with 0 TTL for deletion 84/60584/1
Lorand Jakab [Thu, 20 Jul 2017 09:22:09 +0000 (12:22 +0300)]
Return negative mapping with 0 TTL for deletion

When an SMR-invoked Map-Request is asking for a mapping that is
negative, it is most likely an attempt to delete that mapping.

Change-Id: Iec949c5ca9da90845c6634a7d26fabebd65afc81
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoMake 'keys' CLI output user friendly 33/60533/1
Lorand Jakab [Wed, 14 Jun 2017 13:04:09 +0000 (16:04 +0300)]
Make 'keys' CLI output user friendly

Before this patch, the 'keys' CLI command would print out the full
Java objects contained in a map-cache. That's great for in-depth
debugging, but for a quick look it very hard to read. This patch
implements a user friendly CLI output for keys, to improve
readability.

The old full output is still available in Karaf, by adding the '-d' or
'--debug' switch to the CLI command.

Example output:

---8<------------------------------------------------------------------------------
opendaylight-user@root>keys
Instance ID 0
  -> EID                                           HMAC Algorithm        Shared Key
     192.0.2.1/32                                  HmacSHA1              password
     192.0.2.1/32|192.0.2.2/32                     HmacSHA1              password
------------------------------------------------------------------------------>8---

Change-Id: Ibe95d0ee4318053df3bc9f30c09c0e01c1d00eba
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoFully remove Maven Sites 47/60247/1
Lorand Jakab [Wed, 12 Jul 2017 12:04:59 +0000 (15:04 +0300)]
Fully remove Maven Sites

Change-Id: I8c6ba1fe18e0fff43d0aa47b19c9f11df05ead20
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoRemove outdated src/site documentation 42/60242/1
Lorand Jakab [Wed, 12 Jul 2017 10:53:18 +0000 (13:53 +0300)]
Remove outdated src/site documentation

https://lists.opendaylight.org/pipermail/odlparent-dev/2017-July/001218.html

Content moved to the wiki:
https://wiki.opendaylight.org/view/Southbound_Performance_Cache

Change-Id: I9867417f6f0a9f30cb3166371f4cfe4c5f3cbe14
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoMerge "Make negative mapping TTL configurable"
Lori Jakab [Tue, 11 Jul 2017 11:09:46 +0000 (11:09 +0000)]
Merge "Make negative mapping TTL configurable"

6 years agoUpgrade to odlparent 2.0.2 45/60145/1
Lorand Jakab [Mon, 10 Jul 2017 13:07:36 +0000 (16:07 +0300)]
Upgrade to odlparent 2.0.2

Build is broken without this upgrade.

Change-Id: Ib9e24eb78d4af103ad8e30febd233ef2ec175963
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoMake negative mapping TTL configurable 60/59560/4
Lorand Jakab [Tue, 27 Jun 2017 11:34:24 +0000 (14:34 +0300)]
Make negative mapping TTL configurable

Change-Id: I08c6ad1517f4cc34747a4762dc604b0de87b2bea
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoFix build 49/59549/1
Lorand Jakab [Tue, 27 Jun 2017 08:21:47 +0000 (11:21 +0300)]
Fix build

Change-Id: I5bfc3c58fef1fcb1c20387d840f1307f09fd7990
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBug 8679: Fix widest negative prefix calculation 06/59206/4
Lorand Jakab [Tue, 20 Jun 2017 08:53:15 +0000 (11:53 +0300)]
Bug 8679: Fix widest negative prefix calculation

And add integration tests to avoid regressions.

Change-Id: I6cadaca03d360f475c7c88fd3cb58dd39814d23f
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoUpgrade to odlparent 2.0.0 81/59281/1
Lorand Jakab [Wed, 7 Jun 2017 09:36:55 +0000 (12:36 +0300)]
Upgrade to odlparent 2.0.0

Change-Id: I10061eda3522ded1d55adc1ac365ab9d4b22763b
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoDo not build Karaf 3 features and distro 92/58392/8
Lorand Jakab [Wed, 7 Jun 2017 09:36:55 +0000 (12:36 +0300)]
Do not build Karaf 3 features and distro

Disable building the Karaf 3 features and local distribution, since
that's a prerequisite for getting back into autorelease in Nitrogen [0],
apart from the build breaking right now.

For now, just comment them out in the build, we fully remove source code
just before code freeze (in case we need to contrast behaviors between a
Karaf 3 and 4 container).

[0] https://lists.opendaylight.org/pipermail/odlparent-dev/2017-June/001036.html

Change-Id: Id7f9a82e4b9868ad57141d3ef7e5a0cc2ef74946
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoUpgrade V3PO model version 35/59135/1
Lorand Jakab [Mon, 19 Jun 2017 06:57:04 +0000 (09:57 +0300)]
Upgrade V3PO model version

Else build fails

Change-Id: I57439066304d70c633dd565873d9401870238b13
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoMerge "Bug 8503: Remove empty structures in DAO"
Vina Ermagan [Thu, 15 Jun 2017 01:08:27 +0000 (01:08 +0000)]
Merge "Bug 8503: Remove empty structures in DAO"

6 years agoMigrate to odlparent 1.9.0 65/58865/1
Thanh Ha [Tue, 13 Jun 2017 20:20:20 +0000 (16:20 -0400)]
Migrate to odlparent 1.9.0

Change-Id: I9de99604521440580045e6bedcff4606389561a2
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agoBug 8503: Remove empty structures in DAO 99/57799/6
Lorand Jakab [Thu, 25 May 2017 06:29:15 +0000 (09:29 +0300)]
Bug 8503: Remove empty structures in DAO

Change-Id: I52bb47edbb2e34c0b72d874b1ceab33125156f42
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoBUG-6709: migrate karaf-empty 75/58375/2
Robert Varga [Tue, 6 Jun 2017 20:41:58 +0000 (22:41 +0200)]
BUG-6709: migrate karaf-empty

No longer provided by controller.

Change-Id: I11fa1db7b9aaf2a15be3c8979c744d23d5c77d62
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 years agoMigrate to odlparent 1.8.0-Carbon 61/58661/1
Thanh Ha [Sat, 10 Jun 2017 05:31:21 +0000 (01:31 -0400)]
Migrate to odlparent 1.8.0-Carbon

Per request of odlparent project we are downgrading all Nitrogen
projects to use the released odlparent 1.8.0-Carbon to allow for the
odlparent project to start performing semver style releases.

Change-Id: I38f3b068e85b2e9aa81fb6fc8a48e862c249bf95
Jira: RELENG-159
RT: 41406
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
7 years agoFix configuration file parsing 90/58190/1
Lorand Jakab [Fri, 2 Jun 2017 22:19:24 +0000 (15:19 -0700)]
Fix configuration file parsing

Change-Id: Ifd747d1b5d5b39da80920bc088c7c9c0e5cb7111
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoAdd knob to disable authentication 48/58148/2
Lorand Jakab [Thu, 1 Jun 2017 22:20:49 +0000 (15:20 -0700)]
Add knob to disable authentication

Change-Id: I87a2311be0d6b3821fa276feb84cd208d8e8dd30
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoCancel ongoing SMR futures on new event 98/57798/2
Lorand Jakab [Thu, 25 May 2017 05:32:39 +0000 (08:32 +0300)]
Cancel ongoing SMR futures on new event

The SMR scheduler keeps retrying the sending of SMRs a few (configurable
number) of times with a given spacing between the retries until an
SMR-invoked Map-Request is received for the particular EID. When that
happens, the retrying is cancelled for the subscriber that sent it.

However, up until now, when a new set of SMRs was scheduled for a given
EID, the old set, if still retrying, was left untouched. This patch
fixes that, and starts with a clean slate for the given EID.

Change-Id: Ic64ce0980b39d780433ac2c4e96608af12302392
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoReverse SmrScheduler Map order Subscriber <--> Eid 86/57786/3
Lorand Jakab [Wed, 24 May 2017 17:19:57 +0000 (20:19 +0300)]
Reverse SmrScheduler Map order Subscriber <--> Eid

Change-Id: Ic4b5614c2825f0e03b637896fae5b93f21bdbe32
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoReplace Rloc with Subscriber for SMR key 51/57651/2
Lorand Jakab [Mon, 22 May 2017 22:38:37 +0000 (01:38 +0300)]
Replace Rloc with Subscriber for SMR key

Change-Id: I362c6037707efc091d58c6d1aa4e4e16351523d3
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoAdd cluster testing Postman collection 80/57380/1
Lorand Jakab [Thu, 18 May 2017 16:19:02 +0000 (19:19 +0300)]
Add cluster testing Postman collection

Change-Id: I190b9d0e952c361db0fe3f204ff8dd7fe43c81fc
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoMerge "Add CSR1Kv configs"
Vina Ermagan [Tue, 16 May 2017 18:29:04 +0000 (18:29 +0000)]
Merge "Add CSR1Kv configs"

7 years agoMore detailed subscriber event logging 37/56837/7
Lorand Jakab [Thu, 11 May 2017 08:37:48 +0000 (11:37 +0300)]
More detailed subscriber event logging

Change-Id: I21de8a93d0c4973a29b210dcf857f36ba08a84db
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoBug 8429: Fix SMR handling concurrency issue 42/56842/6
Lorand Jakab [Thu, 11 May 2017 10:21:24 +0000 (13:21 +0300)]
Bug 8429: Fix SMR handling concurrency issue

Change-Id: I1944a82600a3956c053edd9134541a6eab776e0a
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoAdd CSR1Kv configs 21/57121/1
Lorand Jakab [Tue, 16 May 2017 08:07:06 +0000 (11:07 +0300)]
Add CSR1Kv configs

Add CSR1Kv example configs from the tutorial, so they can be linked to.

Change-Id: I28d65d9bb65a769770b3d446634b77a6ec01a4fb
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoTrace-level improved IT logging 17/56617/1
Lorand Jakab [Fri, 5 May 2017 19:02:53 +0000 (22:02 +0300)]
Trace-level improved IT logging

Change-Id: I29bc887ff4efd81d11629c0028a95beaf4cf2d68
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoAdd IPv6 default key for addkeys CLI command 86/56486/1
Lorand Jakab [Wed, 3 May 2017 11:37:49 +0000 (14:37 +0300)]
Add IPv6 default key for addkeys CLI command

The addkeys Karaf CLI command adds a default authentication key
"password" of type one for the whole IPv4 EID space to ease southbound
testing. This patch extends the command to add a default authentication
key for the whole IPv6 EID space as well.

Change-Id: I93b84ab03699592cd5722f42ca63fe66437eb6d5
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoBug 8248: Don't access DSBE from different threads 29/55929/3
Lorand Jakab [Mon, 24 Apr 2017 18:55:50 +0000 (21:55 +0300)]
Bug 8248: Don't access DSBE from different threads

With Epoll we may have more than one LispSouthboundHandler thread, and
they may access the same DataStoreBackEnd (DSBE) instance concurrently.
This patch moves DSBE access to the single threaded
LispSouthboundPlugin. Additionally, it implements some suggestions from
the following thread:

https://lists.opendaylight.org/pipermail/release/2017-April/010273.html

Change-Id: I32f48b6dcb58b241a4a679f7145bd36b5f410861
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoIT: Before each checkSMR(), print map-caches to log 64/54964/2
Lorand Jakab [Thu, 13 Apr 2017 12:43:02 +0000 (15:43 +0300)]
IT: Before each checkSMR(), print map-caches to log

Change-Id: I64ff1f3a10ec0b0ddcc1605703fbd5ce95325aa6
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoMake 'mappings' CLI output user friendly 66/54766/4
Lorand Jakab [Thu, 22 Dec 2016 16:54:38 +0000 (18:54 +0200)]
Make 'mappings' CLI output user friendly

Before this patch, the mappings CLI command would print out the full
Java objects contained in a map-cache. That's great for in-depth
debugging, but for a quick look it very hard to read. This patch
implements a user friendly CLI output for mappings, to improve
readability.

The old full output is still available in Karaf, but is by adding the
'-d' or '--debug' switch to the CLI command.

Example output:

---8<--------------------------------------------------------------------
opendaylight-user@root>mappings
Policy map-cache
----------------
Instance ID 1
  [1] 192.0.2.1/32|192.0.2.2/32, TTL: 1440
    -> Locator                                         State     Pri/Wgt
       10.10.10.10                                     no-route  1/1

Southbound map-cache
--------------------
Instance ID 0
  192.0.2.1/32, TTL: 1440
    -> Locator                                         State     Pri/Wgt
       192.168.16.21                                   up        1/1
       fdab:cc19:b80e::21                              up        1/1
       -----------------------------------------------------------------
    -> Subscriber RLOC                                 Subscriber EID
       192.168.16.21                                   No Address Present
       127.0.0.2                                       No Address Present
-------------------------------------------------------------------->8---

Change-Id: Id3c304ac9eda77a0cc36bff1cdeb18d61608a796
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoPrepare for checkstyle version upgrade 65/55265/1
Lorand Jakab [Wed, 19 Apr 2017 18:20:13 +0000 (21:20 +0300)]
Prepare for checkstyle version upgrade

See https://git.opendaylight.org/gerrit/#/c/54981/

Change-Id: I451e9016a2545b0455d31e057191cb9df1990aaf
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoBump versions by x.(y+1).z for next dev cycle 04/54704/1
Anil Belur [Tue, 11 Apr 2017 01:45:41 +0000 (11:45 +1000)]
Bump versions by x.(y+1).z for next dev cycle

Change-Id: Ibf7642de95c0c4bd04d683ba2de53549ecd7c8f4
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
7 years agoBug 7272: Fully remove mappings 12/52112/14
Lorand Jakab [Tue, 21 Feb 2017 12:58:59 +0000 (14:58 +0200)]
Bug 7272: Fully remove mappings

When removing a mapping, remove all subkeys, and the radix trie entry,
to avoid false lookup results.

Also, instead of sending a notification w/o a subscriber list, expecting
the listeners to look up the subscribers from the mapping system,
include the subscriber list with the notification. That way all subkeys
can be deleted when the change is a mapping removal.

Change-Id: Ic922b82fab42f533f9fa8ec828e4d21f6fa35198
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoMigrate IT to use the Karaf 4 distribution 17/52217/6
Lorand Jakab [Wed, 22 Feb 2017 21:07:31 +0000 (23:07 +0200)]
Migrate IT to use the Karaf 4 distribution

Change-Id: Iecef5c6745bcee3853810303815199c12b6957a5
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoMerge "Use Optional to avoid null return value"
Vina Ermagan [Wed, 22 Mar 2017 23:04:16 +0000 (23:04 +0000)]
Merge "Use Optional to avoid null return value"

7 years agoUse Optional to avoid null return value 17/53617/2
Lorand Jakab [Tue, 21 Mar 2017 14:34:29 +0000 (16:34 +0200)]
Use Optional to avoid null return value

Change-Id: I390f182341fffa36da989fb0e9daaa72473ec466
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoUpdate port tests with proper implementation 38/53638/1
Shakib Ahmed [Tue, 21 Mar 2017 23:18:19 +0000 (16:18 -0700)]
Update port tests with proper implementation

New implementation of Neutron PortDataProcessor left the old unit tests
useless. Those tests are being updated with validated ones.

Change-Id: I6b419aa06cd03721606c2e3cf7a6cac31b8cea4d
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>
7 years agoCreate mapping record with proper VNI 42/52042/6
Shakib Ahmed [Sat, 18 Feb 2017 00:12:56 +0000 (16:12 -0800)]
Create mapping record with proper VNI

Change-Id: I63f94bb9b87b7256d8c12375bfbd10defd937280
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>
7 years agoUpdate mapping records with port data update 88/51588/7
Shakib Ahmed [Wed, 8 Feb 2017 22:20:11 +0000 (14:20 -0800)]
Update mapping records with port data update

Neutron port update can provide a new set of fixed ips. With new fixed
ips, we need to removed old set of mapping recordss in case there were
already old fixed ips and we have mapping records in mapcaches related
to those fixed ips. And then we need to add the new mapping records
in the mapcache.

Change-Id: Id2eca598fcb073169e6d63b72dd14830a35a4f5b
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>
7 years agoAdd mapping record with port data add with fixed ip 93/51493/9
Shakib Ahmed [Mon, 6 Feb 2017 00:14:17 +0000 (16:14 -0800)]
Add mapping record with port data add with fixed ip

When a neutron port create comes with a fixed ip, we consider the fixed
ip as EID. We need to save this EIDs specific to host id, so that when
we have host id to locator mapping available we can create a mapping
record.

This patch adds hostid to all eid mappings keyed by port uuid. And also
attempts to create a mapping record if hostid to locator mapping is
available.

Change-Id: Ia6ae4643e1ecf5d16c592bcd9a52170b28f38777
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>
7 years agoAdd Neutron host-id to RLOC mapping 92/50392/17
Shakib Ahmed [Tue, 10 Jan 2017 22:17:54 +0000 (14:17 -0800)]
Add Neutron host-id to RLOC mapping

Neutron port create call provides us informations like port uuid, host-
id, sometimes fixed-ips but we don't know the interface VPP is going to
use for sending traffic from one host to another. That interface is
going to be the locator for the mapping record we will be putting in
the map-cache. For that, we need to know the locator interface of a
host. Just to clarify, for OpenStack environment is going to be the
tenant network interface.

This patch adds the functionality of listening to VbridgeTopology for
topology updates in Virtual Bridge Domain and pre-populate host to
locator information base.

Change-Id: Ic4c0844ccfcb972e46122df875b628c789f8c837
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>
7 years agoMerge "Add timeout to subscriber data"
Vina Ermagan [Thu, 16 Mar 2017 22:41:14 +0000 (22:41 +0000)]
Merge "Add timeout to subscriber data"

7 years agoMerge "Provide Karaf 4 features"
Vina Ermagan [Thu, 16 Mar 2017 18:22:18 +0000 (18:22 +0000)]
Merge "Provide Karaf 4 features"

7 years agoAdd timeout to subscriber data 88/52088/11
Lorand Jakab [Mon, 20 Feb 2017 22:10:29 +0000 (00:10 +0200)]
Add timeout to subscriber data

The timeout of a subscriber is immutable too, and needs to be
transmitted in a MappingChanged notification using the YANG modeled
subscriber data.

Change-Id: Id62485c79b92ba35c6cd682c78a888ed14234059
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoSMR parent prefix continued 77/48977/33
Lorand Jakab [Mon, 5 Dec 2016 12:15:51 +0000 (14:15 +0200)]
SMR parent prefix continued

This patch completes work started in
https://git.opendaylight.org/gerrit/#/c/47120/

First, it handles the insertion of a positive mapping that overlaps
a negative one, by removing the negative mapping and generating SMRs for
its subscribers. This leads to pushing the positive mapping to the right
subscribers and generating only the needed negative mappings.

Second, it merges negative mappings when a positive mapping is removed
(reversing what was done in the first point above).

Additionally, it creates a variable for the action considered the
default for negative mappings, and uses it in the right places instead
of harcoding Action.NativelyForward.

Change-Id: I6a8799d3af23c20a9797840b3e64f632a3e2ee91
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoProvide Karaf 4 features 94/50094/21
Lorand Jakab [Fri, 6 Jan 2017 19:06:55 +0000 (21:06 +0200)]
Provide Karaf 4 features

This patch provides Karaf 4 features for lispflowmapping. The neutron
upstream doesn't have its Karaf 4 patch finalized and merged yet, so our
odl-lispflowmapping-neutron feature for Karaf 4 is not enabled yet (but
it is migrated and ready to be enabled).

Bug: 7628
Change-Id: Icf8d404f4d46c71557b1f6f088626c2fb75200c8
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoGUI - Add default redirect on app start 34/53134/1
Daniel Malachovsky [Fri, 10 Mar 2017 11:52:47 +0000 (12:52 +0100)]
GUI - Add default redirect on app start

Due Dlux split we removed Topology app from odl-dlux-core feature.
There were also default redirect to that app, so it was landing page, when
DLUX was started.
This patch adds default route to GUI in this project.

More info:
https://wiki.opendaylight.org/view/Weather#Rename_some_odl-dlux-.2A_features_to_odl-dluxapps-.2A

Also fixed errors caused by refactor in YangUI and Yangutils

Change-Id: I125ebc851b749a244b834627326833a71e8079ea
Signed-off-by: Daniel Malachovsky <dmalacho@cisco.com>
7 years agoBug 7818: xTR-ID timestamp updated only when merging 68/52868/1
Lorand Jakab [Mon, 6 Mar 2017 10:10:18 +0000 (12:10 +0200)]
Bug 7818: xTR-ID timestamp updated only when merging

A warning was shown on the Map-Register fast path with default setting,
saying somthing "Could not update timestamp for EID 192.0.2.0/24 xTR-ID
E073DF027BF20605DC9B9518BA753345, no mapping found". Default settings
mean that mapping merge is not on and xTR-ID mappings are not stored, so
the warning is not warranted. And it's not just the warning, the extra
lookup at EVERY fast path Map-Register timestamp upadte has a
performance cost, so make sure it only happens when merge is on.

Change-Id: Id7a66ff8c3309bbcb4ef0bf014f2987149f02fe7
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoFix radix trie last byte prefix comparison 40/52740/4
Florin Coras [Fri, 3 Mar 2017 09:40:21 +0000 (01:40 -0800)]
Fix radix trie last byte prefix comparison

Change-Id: Id360576c7a6e59fc556d484d9f869985e8f1714a
Signed-off-by: Florin Coras <fcoras@cisco.com>
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>
7 years agoAllow Address for getString() 93/52293/3
Lorand Jakab [Mon, 27 Feb 2017 11:21:44 +0000 (13:21 +0200)]
Allow Address for getString()

For now getString only takes LispAddress arguments (and XtrId). Some
times we only have access to the Address inside LispAddress, and we want
to be able to print that too in a user friendly way.

Change-Id: I9568ec9b08dba5c78572140b467d982e32f592ab
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoFix NPE related to mapping record in IT 59/52759/1
Shakib Ahmed [Fri, 3 Mar 2017 12:28:34 +0000 (04:28 -0800)]
Fix NPE related to mapping record in IT

Change-Id: Ica7dbdf7e054729f1586c7867d5a40a80ad2eab5
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>
7 years agoAdd missing <name> fields for pom.xml files 43/52743/1
Anil Belur [Fri, 3 Mar 2017 10:02:25 +0000 (20:02 +1000)]
Add missing <name> fields for pom.xml files

This is used by autorelease scripts to automatically parse which project
is failing a build and report to the mailing list automatically. We need
names in the format:

    ODL :: <groupId> :: <artifactId>

This patch formats in the same format as found in the startup archetypes
patch found here: https://git.opendaylight.org/gerrit/52522

Change-Id: I9c822509f8cb035cd656f5b2ff8c427c85cf7176
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
7 years agoFix a NPE in SmrScheduler 96/52296/2
Lorand Jakab [Mon, 27 Feb 2017 11:29:00 +0000 (13:29 +0200)]
Fix a NPE in SmrScheduler

Change-Id: Iae5bd84361d19b5a6f30f881b2fd5eced26eb171
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoBug 7182 related: Remove M2E lifecycle mapping 29/52429/1
Michael Vorburger [Tue, 28 Feb 2017 22:54:59 +0000 (23:54 +0100)]
Bug 7182 related: Remove M2E lifecycle mapping

These should never be in individual projects anymore now, we handle this
centrally, either in odlparent, or
https://github.com/vorburger/opendaylight-eclipse-setup, or by
appropriate lifecycle-mapping-metadata.xml in a Maven plugin (that's
what Bug 7182 does for the yang-maven-plugin; this removes what makes
that not work for these projects).

Change-Id: Ic3e7f81560e54882a8c17bece500148637aa1087
Signed-off-by: Michael Vorburger <vorburger@redhat.com>