Robert Varga [Fri, 18 Jan 2019 23:48:09 +0000 (00:48 +0100)]
Bump yangtools to 2.0.6.7
These are latest fixes, with odlparent-3.1.6.
Change-Id: I9a057eccb779e7263b6733b19557c0f950f930bb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Fri, 18 Jan 2019 15:44:24 +0000 (16:44 +0100)]
Bump to odlparent 3.1.6
Change-Id: I5d19a4e3e32dde5f4850e89fb46046ff498234fd
Signed-off-by: Stephen Kitt <skitt@redhat.com>
jenkins-releng [Wed, 12 Dec 2018 11:58:15 +0000 (11:58 +0000)]
Bump versions by x.y.(z+1)
Change-Id: If74f5fe01d906e7fd34f35754c5dc7dac12b9f0f
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Robert Varga [Tue, 20 Nov 2018 13:52:24 +0000 (14:52 +0100)]
Remove duplicate message type check
Rather than performing two instanceof checks, use an if/else
construct to dispatch message.
Change-Id: I4ce5aba7e1c826fe343b279c9767193d0ba83154
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Matej Perina [Wed, 31 Oct 2018 10:22:13 +0000 (11:22 +0100)]
use thread-safe list in ConfigLoaderImplTest
- to prevent ConcurrentModificationException in
situation when List.stream() is called at same
time as List.clear()
JIRA: BGPCEP-829
Change-Id: I9e69971de5ec75ca515e81e2b95fe44e50489fda
Signed-off-by: Matej Perina <matej.perina@pantheon.tech>
(cherry picked from commit
928a2df7adfba60e2657b08019abc9e51a6d0837)
Stephen Kitt [Fri, 19 Oct 2018 13:28:59 +0000 (15:28 +0200)]
Bump to odlparent 3.1.4 and yangtools 2.0.6.5
Change-Id: Ic99ac9a7ffe2f838e816d6438893dce32bbf5c98
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Robert Varga [Thu, 15 Nov 2018 10:52:28 +0000 (11:52 +0100)]
Cache dataAfter result
Rather than constructing the optional twice, cache it in a local
field, preventing multiple access.
Change-Id: Idfb8c631bc0267a63710c2cb650e6bda1c227df3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Matej Perina [Wed, 14 Nov 2018 11:11:16 +0000 (12:11 +0100)]
use multi thread executor in unit tests
- instantiatie AbstractConcurentDataBroker the way to use
CachedThreadPoolExecutor instead of DirectExecutor
JIRA: BGPCEP-847
Change-Id: I86cbe54a17e65d4ac7bdc7ca447ac58f345c473a
Signed-off-by: Matej Perina <matej.perina@pantheon.tech>
Claudio D. Gasparini [Thu, 8 Nov 2018 16:36:53 +0000 (17:36 +0100)]
Fix application peer handling of DISAPPEARED / APPEARED case
JIRA: BGPCEP-843
Change-Id: I82368d8cf029ffe83391333c6e11633511688b69
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 6 Nov 2018 12:26:37 +0000 (13:26 +0100)]
Solve deadlock
JIRA: BGPCEP-841
Change-Id: I9daaa786e9d1b1cf7aa74141d346f1bd86b36452
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 26 Oct 2018 08:36:24 +0000 (10:36 +0200)]
Fix LEAK: ByteBuf.release()
JIRA: BGPCEP-839
Change-Id: I07692d26e7b8cbb3b1134a61f2ea0c5947b8bd81
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 24 Oct 2018 06:16:56 +0000 (08:16 +0200)]
Fix LinkstateTopologyBuilder NPE
JIRA: BGPCEP-838
Change-Id: Ie5ba13434245195d77e3c29850cf54ef973e3441
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Matej Perina [Tue, 9 Oct 2018 10:28:27 +0000 (12:28 +0200)]
fix concurrent access to config file
- calling handleConfigFile from two differrent threads was
causing ConncurentModificationException in ConfigLoaderImpl
test
JIRA: BGPCEP-829
Change-Id: I9ada792c98aafc06daa8971b75df22b85b3ff4c1
Signed-off-by: Matej Perina <matej.perina@pantheon.tech>
(cherry picked from commit
5a7b80c3b4e4c59203659116e7d8fa098e75ec92)
Robert Varga [Tue, 18 Sep 2018 12:37:10 +0000 (14:37 +0200)]
Bump yangtools to 2.0.6.3
This bumps yangtools to 2.0.6.3, picking up latest fixes.
Change-Id: I8903a4d93dcddeeaf43e92282df9e2bf80efbe8b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 31 Aug 2018 09:23:52 +0000 (11:23 +0200)]
Bump yangtools to 2.0.6.2
This brings in latest fixes.
Change-Id: I138df8cfe51d22abaae1f2d2c8934717f12f81da
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Matej Perina [Tue, 7 Aug 2018 13:21:46 +0000 (15:21 +0200)]
add server channels closure in tests
JIRA: BGPCEP-818
Change-Id: I6b65b36406cf7a40e2d9738a06ce5a57c9251dbd
Signed-off-by: Matej Perina <matej.perina@pantheon.tech>
jenkins-releng [Thu, 9 Aug 2018 16:39:41 +0000 (16:39 +0000)]
Bump versions by x.y.(z+1)
Change-Id: If27c87a6513f3a217b004d935062b266e2e19690
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Stephen Kitt [Tue, 31 Jul 2018 09:18:16 +0000 (11:18 +0200)]
Bump yangtools to 2.0.6.1
Change-Id: I19fb142e8bfe0df457f93d88591af1a31b182012
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Robert Varga [Mon, 9 Jul 2018 17:18:04 +0000 (19:18 +0200)]
Fix invalid models
These models do not contain correct import stanzas and were resolved
accidentally via prefixes declared in modules thy are importing.
JIRA: YANGTOOLS-889
Change-Id: Ia94e3f78ed4a9aec8b55743b821373738b4e6c54
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
58d5468c187c63e93f7dc2cee09230bf0b8b2e62)
Robert Varga [Thu, 28 Jun 2018 07:30:06 +0000 (09:30 +0200)]
Fix invalid flowspec model
Augmenting the same choice with equally-named containers from
a single model is data tree namespace violation. Fix that.
Change-Id: Icb5f1580c23fd53365481c89111888566eb04747
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
d0aeb999f179d8468aaa77957db7b0fd76845caf)
Robert Varga [Thu, 28 Jun 2018 09:21:14 +0000 (11:21 +0200)]
Fix invalid rsvp model
Augmenting the same choice with equally-named containers from
a single model is data tree namespace violation. Fix that.
Change-Id: I36eea127a33ade8dec108042bd43dac12e97e64e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
c26582bfccc3fb6aca26ac5cbd3932e7a67ed532)
Stephen Kitt [Thu, 26 Jul 2018 14:02:03 +0000 (16:02 +0200)]
Bump to odlparent 3.1.3
Change-Id: I75aa83a8296da41e79fa6b0ca6c7166f15765921
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Matej Perina [Tue, 24 Jul 2018 10:55:24 +0000 (12:55 +0200)]
fix timing issue in server creation for BmpMockTest
- add wait unitl server is created
Change-Id: Id217822e57be8c7df1139341af9ade2517dad516
JIRA: BGPCEP-815
Signed-off-by: Matej Perina <matej.perina@pantheon.tech>
Claudio D. Gasparini [Fri, 20 Jul 2018 08:21:31 +0000 (10:21 +0200)]
Reduce use of waitFutureSuccess utility
Change-Id: I90e2cd1104ade35801a734ead26eeac2c90c0361
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 20 Jul 2018 06:51:43 +0000 (08:51 +0200)]
Rework BmpMockDispatcherTest
- Use test timeout instead of waitFutureSuccess utility
- use blocking futures
JIRA: BGPCEP-814
Change-Id: I1471226c703779222ed27f11154d8557b0ab7a65
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit
3bab01236ef38a758a96bdaf6a73482bb1840891)
Ajay Lele [Tue, 17 Jul 2018 21:09:14 +0000 (14:09 -0700)]
Fix calculation and roll-over of BGP operational neighbor uptime value.
Change-Id: I6ba03074658b45c17ee440fa81158720531a2cef
JIRA: BGPCEP-813
Signed-off-by: Ajay Lele <ajayslele@gmail.com>
Claudio D. Gasparini [Thu, 21 Jun 2018 15:38:37 +0000 (17:38 +0200)]
Improve handling for protocols config changes
Given the dependency of Peers of Rib.
When delete
- remove first peers
- then remove Rib
when modification
- update rib
- then update peers
JIRA: BGPCEP-799
Change-Id: I582398dab191842473f7cbbd1010b76fe9a9d9fd
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 19 Jun 2018 12:09:48 +0000 (14:09 +0200)]
Inherit common extensions families dependencies
from extensions parent
Change-Id: Ic115f76bd184142d15e9b42f69f80dfd12fa375a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 21 Jun 2018 15:29:25 +0000 (17:29 +0200)]
Create common parent for extensions families
Change-Id: I9aff6bb41e565df54fcbcfb660ac014b7547c334
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Stephen Kitt [Mon, 18 Jun 2018 08:38:52 +0000 (10:38 +0200)]
Bump to odlparent 3.1.1
JIRA: RELENG-129
Change-Id: I7d8ed367ac99c196fbfac58b1f591f903f4469f8
Signed-off-by: Stephen Kitt <skitt@redhat.com>
jenkins-releng [Wed, 13 Jun 2018 00:07:27 +0000 (00:07 +0000)]
Bump versions by x.y.(z+1)
Change-Id: Ie1960106fa701398e6ccb5037875de77865cd313
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Robert Varga [Fri, 1 Jun 2018 08:43:01 +0000 (10:43 +0200)]
Use range to import yangtools features
This removes version-specific binding, allowing features to be
resolved against newer versions.
Change-Id: I62728a4aa1d3fd817c629bcd7057724b448379ab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
e83fdd20a40831dfdbdbc21a6ba99611dbe51ab1)
Robert Varga [Fri, 25 May 2018 10:53:02 +0000 (12:53 +0200)]
Bump yangtools to 2.0.5
Latest fixes.
Change-Id: I16db310fab811486942b90778d5beefedfa1679d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Tom Pantelis [Wed, 2 May 2018 17:25:54 +0000 (13:25 -0400)]
Fix IllegalStateException in StateProviderImpl
If a transaction fails, the StateProviderImpl can get stuck in
a perpetual cycle of subsequent transactions failing due to:
java.lang.IllegalStateException: Previous transaction odl2-1-datastore-operational-fe-3-chn-44-txn-1-0 is not ready yet
at org.opendaylight.controller.cluster.datastore.TransactionChainProxy$Allocated.checkReady(TransactionChainProxy.java:85)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
at org.opendaylight.controller.cluster.datastore.TransactionChainProxy.allocateWriteTransaction(TransactionChainProxy.java:187)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
at org.opendaylight.controller.cluster.datastore.TransactionChainProxy.newReadWriteTransaction(TransactionChainProxy.java:166)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
at org.opendaylight.controller.cluster.databroker.DOMBrokerReadWriteTransaction.createTransaction(DOMBrokerReadWriteTransaction.java:52)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
at org.opendaylight.controller.cluster.databroker.DOMBrokerReadWriteTransaction.createTransaction(DOMBrokerReadWriteTransaction.java:22)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
at org.opendaylight.controller.cluster.databroker.AbstractDOMBrokerTransaction.getSubtransaction(AbstractDOMBrokerTransaction.java:57)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
at org.opendaylight.controller.cluster.databroker.AbstractDOMBrokerWriteTransaction.merge(AbstractDOMBrokerWriteTransaction.java:102)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
at org.opendaylight.controller.md.sal.dom.spi.ForwardingDOMDataReadWriteTransaction.merge(ForwardingDOMDataReadWriteTransaction.java:54)[314:org.opendaylight.controller.sal-core-spi:1.6.0.ODL_7_0_0_0]
at org.opendaylight.controller.md.sal.binding.impl.BindingDOMWriteTransactionAdapter.ensureParentsByMerge(BindingDOMWriteTransactionAdapter.java:67)[302:org.opendaylight.controller.sal-binding-broker-impl:1.6.0.ODL_7_0_0_0]
at org.opendaylight.controller.md.sal.binding.impl.AbstractWriteTransaction.put(AbstractWriteTransaction.java:41)[302:org.opendaylight.controller.sal-binding-broker-impl:1.6.0.ODL_7_0_0_0]
at org.opendaylight.protocol.bgp.state.StateProviderImpl.storeOperationalState(StateProviderImpl.java:151)[252:org.opendaylight.bgpcep.bgp-openconfig-state:0.8.0.ODL_7_0_0_0]
at org.opendaylight.protocol.bgp.state.StateProviderImpl.lambda$updateBGPStats$1(StateProviderImpl.java:124)[252:org.opendaylight.bgpcep.bgp-openconfig-state:0.8.0.ODL_7_0_0_0]
The root cause is due to attempitng to continue to use a failed
transaction chain. It should close the failed chain and create a new
on as is required by the API contract.
For the UT, I used the RememberingLogger from infrautils to indirectly
verify the tx chain is rest on failure by checking logged errors. The
RememberingLogger is wired via static binding in infrautils which
supplants logback as the backing impl.
Change-Id: Ie26f047c2320ff812d796a25f2e3721b59b73ba0
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Claudio D. Gasparini [Sun, 6 May 2018 10:59:08 +0000 (12:59 +0200)]
Improve TopologyStatsProvider transaction chain failure
Create new chain when onTransactionChainFailed
for TopologyStatsProvider.
Change-Id: Ib3ff3b7b1c9381efa8f35cbb5ed88195320f06c9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 14 May 2018 06:29:20 +0000 (08:29 +0200)]
Improve chain transaction fail handling
under Data change counter.
- Migrate submit to commit.
Change-Id: If2149bdf87ca8a94e4d74f379424ff36f934a52f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Sat, 7 Apr 2018 12:20:39 +0000 (14:20 +0200)]
Rework OffsetMap.remove() and share empty arrays
Empty arrays are immutable, hence we can share those instances,
reducing overheads. Also updates OffsetMap.remove() to take an
empty array argument, which will be used when the map would become
empty.
Change-Id: I9e44ec0eb984f8614d307dd679bed8db0739478a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sat, 7 Apr 2018 12:05:27 +0000 (14:05 +0200)]
Use byte[].clone()
BGPDocumentedException can be made more efficient by using
byte[].clone() instead of Arrays.copyOf(). Also pre-cache empty
data and return it when needed.
Change-Id: Ib4e36522f0d3a734621349c1b62865496d330009
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sat, 7 Apr 2018 11:57:22 +0000 (13:57 +0200)]
Do not use 'new Long()'
Instantiating a long through new is inefficient, use Long.valueOf()
instead.
Change-Id: I7c520334e3a0012e7938a11fc587bfa894afbcf4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Wed, 11 Apr 2018 10:57:42 +0000 (12:57 +0200)]
Migrate deprecated OsgiCommandSupport
Change-Id: I3fabc2af08746b2690a8e1ca8cb87e6ec84ad411
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Sat, 7 Apr 2018 11:22:26 +0000 (13:22 +0200)]
Migrate to karaf shell api
org.apache.felix.gogo.commands is deprecated, migrate to
org.apache.karaf.shell.api.action equivalents.
Change-Id: I22d1714f4bff6acfecb0fdd87c595e32af5d9a8c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sat, 7 Apr 2018 11:16:04 +0000 (13:16 +0200)]
Migrate ShellTable to non-deprecated class
org.apache.karaf.shell.support.table.ShellTable is the new location,
use that.
Change-Id: I85b6adc2ae01a47236217676f78cce9e0f81237e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Tue, 24 Apr 2018 21:31:05 +0000 (23:31 +0200)]
Deprecate parseNlri method
Change-Id: I6a87d4aae25e56029bc412ca7777b90a7c122cef
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
jenkins-releng [Wed, 25 Apr 2018 18:24:25 +0000 (18:24 +0000)]
Bump versions by x.y.(z+1)
Change-Id: Ifd4808818e4824726c2c0f3c807538f77a88b5b1
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Thanh Ha [Sat, 7 Apr 2018 02:39:57 +0000 (22:39 -0400)]
Add Karaf build profile
Project local Karaf distros are handy for devs to test their work
however is unneeded by autorelease builds and should not be released
as part of the Simultanious Release. Add a profile that is active by
default so that default behaviour is unchanged however allows the
autorelease project to disable building this module.
Issue: RELENG-86
Change-Id: I3b13b5051907226c136ab2788ee3881794a3ce52
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sat, 7 Apr 2018 02:38:31 +0000 (22:38 -0400)]
Remove obsolete Maven Site configuration
Change-Id: I2946377b3a24cedc05073611e13b9973583af8ae
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Stephen Kitt [Fri, 23 Mar 2018 13:11:14 +0000 (14:11 +0100)]
Bump to odlparent 3.1.0 and yangtools 2.0.3
Change-Id: Id97e73be4560826c786c7ca661cbffafcef01d27
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Mon, 9 Apr 2018 13:25:00 +0000 (15:25 +0200)]
Fix findbug NP_NONNULL_PARAM_VIOLATION complains
Change-Id: I359f4a8c626753e9d5eeb6eb4b2cbd906b28e984
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 9 Apr 2018 12:59:30 +0000 (14:59 +0200)]
Use dedicated executor for BGPCEP Stats
BGPCEP-786
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Change-Id: I85d227f237509e3646805258ebeb1c22ebb3a54b
Claudio D. Gasparini [Wed, 4 Apr 2018 15:35:19 +0000 (17:35 +0200)]
BGPCEP-740: Fix logic for MED comparison in BGP best path selection
New better path should be selected only if new MED is lower than
actual best path MED.
Change-Id: I8bd07dc8b42e575cebcc4e1ea4b55d9c2c842f42
Signed-off-by: Ajay Lele <ajayslele@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit
c98b6ebaaca98050c7e2bebe4709e918b15fba70)
Claudio D. Gasparini [Mon, 26 Feb 2018 15:58:31 +0000 (16:58 +0100)]
Add missing copyrights
Change-Id: I992492a29d54cd0d70e0a1289fb891754775584b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 22 Mar 2018 11:24:10 +0000 (12:24 +0100)]
BGPCEP-770: Lock file before processing
In this way we ensure is not still been modified
when event is raised.
Change-Id: I69047f244e78bdf4536d6f2a83d3b80c45191e90
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit
ac2ebcb16be3c1c17136cb479ba85f1c15dfa02f)
Claudio D. Gasparini [Tue, 13 Mar 2018 09:25:51 +0000 (10:25 +0100)]
BGPCEP-574: Deprecate simple-routing-policy
Change-Id: I5528f5bd7942e1edf1383176dbf07fa104705ad5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Wed, 28 Feb 2018 00:11:11 +0000 (01:11 +0100)]
Fix model compliance
Declared prefix should be unique within a module, as that is
the prefix that is used to refer to a module within itself.
Change-Id: I699c529831fd62854a50e46c105a3d7922d670f1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Mon, 19 Mar 2018 16:18:18 +0000 (17:18 +0100)]
BGPCEP-764: Use full Ipv6 form under StrictBGPPeerRegistry
Ipv6 equal is not capable of handle short or full form
of Ipv6, returning false when comparing different versions.
Therefore use full form under registry.
Change-Id: I2127f20e847860792d0f1c18b0ae243825a9d86a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit
889700a070e725f44ee3d4fe215d93312ac8f0bf)
jenkins-releng [Thu, 22 Mar 2018 16:57:42 +0000 (16:57 +0000)]
Bump versions by x.y.(z+1)
Change-Id: Iac930fab220ac59c3f55ecf66b117c5e02493b4b
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Claudio D. Gasparini [Fri, 16 Mar 2018 08:56:29 +0000 (09:56 +0100)]
BGPCEP-766: Reduce synchornization
under AbstractTopologySessionListener
Change-Id: I99efef02cef6f9af761c73d57bb4b37e50177830
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 1 Mar 2018 10:26:09 +0000 (11:26 +0100)]
BGPCEP-763: Fix Pcep Deadlocked thread
improve synchronization
Change-Id: Ie10528d511b35911051a9aef149ae0c0c87116e0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Anil Belur [Mon, 26 Feb 2018 06:59:40 +0000 (16:59 +1000)]
Update .gitreview to stable/oxygen
Change-Id: I9b5d182977d37a17d35d41238da8160edc3ba8a5
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Claudio D. Gasparini [Fri, 23 Feb 2018 21:12:09 +0000 (22:12 +0100)]
BGPCEP-760: Fix Dead lock
when connecting multiple peers at
the same time multiple routes are announced.
Fix by improve sync under Peer export groups.
Change-Id: I588db1bfc3cfca80308837084ac5088b8fc89cea
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 23 Feb 2018 14:40:33 +0000 (15:40 +0100)]
Fix NPE
when calling containsEqualConfiguration on Peer
Change-Id: Idc674a8be808386c0a3050dca3a3895cf0491caf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 15 Feb 2018 09:59:07 +0000 (10:59 +0100)]
Remove no longer required service-properties
for restart OSGI CSS service
Change-Id: I65c4810ca5da9bd357dbdabb3ed413649ba8fbb1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 14 Feb 2018 11:06:38 +0000 (12:06 +0100)]
BGPCEP-758: Use random ip for Pcc mock tests
-perform some clean up
Change-Id: I79ef9f8e5f01b1d461c5848d7966f9e3521f926d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 14 Feb 2018 10:16:19 +0000 (11:16 +0100)]
BGPCEP-757: Handle WRITE as SUBTREE_MODIFIED
on case of Topology rewrite, following
the same procedure as if it was an update.
Change-Id: Ida6bf596137054bb6a5d02d4345daee8cf5f3394
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 12 Feb 2018 13:24:46 +0000 (14:24 +0100)]
Remove unnecesary sync
Change-Id: I6cf0f20346719e311164bf96c3b87387878200d3
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 31 Jan 2018 17:31:15 +0000 (18:31 +0100)]
Remove default pcep tunnel topology
until is documented.
Change-Id: Iaa046626cdad1271db7a89a7d455bbe04ea88364
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 30 Jan 2018 18:54:39 +0000 (19:54 +0100)]
BGPCEP-745: Improve synchronization
when unbinding PCEPState
Change-Id: I7558610208f12e09f69d859bb0b613a044f8b1ce
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 30 Jan 2018 19:16:06 +0000 (20:16 +0100)]
Fix Tunnel Topology configuration
by catch correctly the id of the pcep
topology from topology-ref.
- Improve logs
- Add tunnel topology to example config
Change-Id: If55ea04c6361241b4199bfca02a4c534e67805b6
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 25 Jan 2018 21:55:10 +0000 (22:55 +0100)]
Remove config-parent
Change-Id: I0e75ed7e809b5904e3ec11fa3f1937b371d0c2d2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 25 Jan 2018 10:31:32 +0000 (11:31 +0100)]
BGPCEP-739: Fix "raced with transaction PingPongTransaction"
under TopologyNodeState. Raced call to putTopologyNode
will cause an override node and therefore PathComputationClient
was being removed and ending on exception when trying to update
it after such change.
Change-Id: I1d5b44c383d7159669bec7475afff3713f1370a0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 24 Jan 2018 11:25:59 +0000 (12:25 +0100)]
Rework poms
- Remove bundle-parent.
- Remove dependency-version-management
- Use instead bgpcep-parent
- Clean up bgpcep parent
Change-Id: Icc0e40017204916c8fa2c33546195f56e0249591
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 23 Jan 2018 16:39:05 +0000 (17:39 +0100)]
Simplify config loader tests
Change-Id: I8c04f7f27aafb9a4760bb5d043db2f08bdee91d9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 23 Jan 2018 09:01:22 +0000 (10:01 +0100)]
BGPCEP-748: Fix AFI/SAFI
peer support registration when old-school BGP-4
is used.
Change-Id: I2137ea2647f01fb87bad04e682fe0bf5541768e8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 15 Jan 2018 15:36:35 +0000 (16:36 +0100)]
Replace deprecated CheckNotNull
Change-Id: I21ec7c40264533e027320f7b5b31ee895003537e
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 22 Jan 2018 13:08:34 +0000 (14:08 +0100)]
Document path-id reserved value
Change-Id: I663ffac423e8a48c8528782165abc1406d70bb44
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 20 Jan 2018 12:08:18 +0000 (13:08 +0100)]
BGPCEP-672: Fix key storage un adj-rib-out
list key must not be null, therefore
path-id should always be included.
Reserving PATH-ID 0 for non-supporting
add-path.
Change-Id: I9b0af92e91e7c0b1c7281230a804c7adeff2dbca
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Kevin Wang [Mon, 11 Dec 2017 21:58:17 +0000 (13:58 -0800)]
BGPCEP-724 Make BGP Session recoverable
This patch make BGP Session recoverable when anything wrong
happens during netty session negotiation. When an exception
is captured, the BGP session will be terminated.
Change-Id: Id3fc7ec282a2151e3bd6bdbfa8930e141b3ceaff
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Claudio D. Gasparini [Fri, 12 Jan 2018 15:57:33 +0000 (16:57 +0100)]
Remove private constructor tests
Change-Id: I33cc6ffcf940db226826e350e59c8af5eb1e1d71
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 12 Jan 2018 11:26:26 +0000 (12:26 +0100)]
Remove no longer required method
Change-Id: Ic987e86f09cff5df35f81c13a7385866727f30ed
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 18 Jan 2018 10:49:15 +0000 (11:49 +0100)]
Reduce number of parameters for pcep
-improve logs
Change-Id: Ibdf63a2b7d7894600a466a07086d7b9d4d9b5cc4
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 21 Jan 2018 17:21:11 +0000 (18:21 +0100)]
Add feature-repo-parent pom
reducing duplicated dependencies
by inheritance.
Change-Id: I8683f302ec4bd7aa08ed38bbc8a149e17de24a5d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 21 Jan 2018 16:14:45 +0000 (17:14 +0100)]
Add single feature parent
reducing duplicated dependencies
by inheritance
Change-Id: Ia143e2f70f1aa76cb611f58b7673bb96a722bdd1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 21 Jan 2018 11:31:44 +0000 (12:31 +0100)]
Fix poms
- use dependency version management
- fix checkstyle complains
- add checkstyles to parents
Change-Id: Ide387d38f5d4e6c865f12070c5f8e3bbea5f9aef
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Thu, 18 Jan 2018 22:47:50 +0000 (23:47 +0100)]
Eliminate unneeded declarations
yangtools.version is not really useful, as are the plugin
declarations, which we are inheriting from elsewhere.
Change-Id: I78ca9db9bb0341237fca05d251a801efab95266b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 18 Jan 2018 22:59:38 +0000 (23:59 +0100)]
Cleanup feature dependencies
Use smaller upstream features to the extent we need them.
Change-Id: I9bf9dac7fe926c5c69a544ac7620d8a18085e5e5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 15 Jan 2018 12:24:01 +0000 (13:24 +0100)]
Fix config-loader-spi pulling in bundles
Depend on odl-mdsal-broker instead of pulling in controller bundles
into this feature.
Change-Id: I86c7e150a0e972f2f802c8bc5e8bea892b0d5bad
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Thu, 18 Jan 2018 07:07:26 +0000 (08:07 +0100)]
Bump to yang 2.0.1
Change-Id: I6551c9e338f7e178997edaf1fdc680598f587c6c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Mon, 15 Jan 2018 12:09:40 +0000 (13:09 +0100)]
Disable offline link detection in bmp-impl
This seems to suffer from a similar affliction.
Change-Id: I236f7bdfd00dc361d8d7e5177c4d9eac8954d2a5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 15 Jan 2018 10:39:01 +0000 (11:39 +0100)]
Disable offline links in bgp-rib-impl
This is a workaround for broken merge job -- disable link
detection until we figure out what is wrong with jenkins.
Change-Id: I985702541b46fd015cde55a9e35390ffc978cf8a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 23 Nov 2017 12:51:31 +0000 (13:51 +0100)]
Bump to odlparent-3.0.2 and yangtools-2.0.0
This is a combined upgrade of dependencies, adopting them in one
go. Since yangtools has switched to using java.util.Optional,
mirror that decision in interfacing expected do directly interact
with NormalizedNodes.
Change-Id: I87977f2757777c3cefe2a59acb0ec1f2d3beed21
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Fri, 12 Jan 2018 15:29:08 +0000 (16:29 +0100)]
Fix yangtools feature reference
The feature was renamed to odl-yangtools-data, fix the reference.
Change-Id: I1f26a9206ff151bc90d8bb298bff8a83af755a1e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Fri, 12 Jan 2018 14:32:23 +0000 (15:32 +0100)]
Bump to odlparent-3.0.0 and yangtools-2.0.0
This is a combined upgrade of dependencies,
adopting them in one go.
Change-Id: I68206648e60f657a2d16f1160bd379c0a769ee75
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 11 Jan 2018 14:59:46 +0000 (15:59 +0100)]
BGPCEP-742 Fix BGP NPE filter null BGP State
from BGP State collector.
Change-Id: Ic23277b22466140c2e17c429eea7467fd9d33ce8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 11 Jan 2018 08:52:34 +0000 (09:52 +0100)]
BGPCEP-739: Improve logs under programming
- make programming service closeable
- close service when pcep-topology provider
service is closed.
Change-Id: I87ad85b3b4a54c71b1020f12b962277b7595b182
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 9 Jan 2018 12:24:33 +0000 (13:24 +0100)]
Introduce testtool-parent
to enforce findbug and checkstyle
under testtools
Change-Id: I971c273cbfd739e308d3548faf664af7812cc30c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 9 Jan 2018 11:51:34 +0000 (12:51 +0100)]
Fix findbug and checkstyle issues
Change-Id: Ia8fef246d76af79c9557f7cecf7cbd2740249ab9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 7 Jan 2018 22:06:47 +0000 (23:06 +0100)]
Fix findbug issues under pcep modules
Change-Id: Ia1fd4067479bc0bbdc8242ef7cc111394b62c059
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 7 Jan 2018 21:37:20 +0000 (22:37 +0100)]
Fix findbug issues
for rib-spi & rib-impl module
Change-Id: I76e4bebdab4581ec4475647af5ce87bcfc52d616
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 7 Jan 2018 18:35:13 +0000 (19:35 +0100)]
Enforce checkstyle & findbug under bundle-parent
and remove enforcement from modules which
contains it as a parent.
Change-Id: I48846c5765f35411ab28508da8df7fdcf2c8f8a2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 5 Jan 2018 17:17:19 +0000 (18:17 +0100)]
Enforce checksyle findbug and checkstyle
under bgp topology
Change-Id: Id30c083d36fa47b42f45f2eaa1c0ccd91109564f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>