sxp.git
3 years agoAdd INFO.yaml for sxp 68/91268/1 master
Anil Belur [Sun, 12 Jul 2020 02:47:21 +0000 (12:47 +1000)]
Add INFO.yaml for sxp

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I72cffbd000f0ad23254da73523c941d2ba6e7956

5 years agoDo not shutdown SXP nodes 57/80057/1
Ivan Hrasko [Thu, 31 Jan 2019 08:03:00 +0000 (09:03 +0100)]
Do not shutdown SXP nodes

- sxp cluster routing service is not responsible
for shutting down nodes on cluster owner change

- it is responsibility of spx controller service

- many times datastore transactions are already closed
when sxp routing service tries to shutdown nodes,
which breaks its route wiping functionality

JIRA: SXP-158
Change-Id: I2a6af3087322f45ffffdb15c523bf1d261366f57
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoInstall odl-sxp-routing by default 56/80056/1
Ivan Hrasko [Wed, 30 Jan 2019 15:10:08 +0000 (16:10 +0100)]
Install odl-sxp-routing by default

Change-Id: I8ff408bc7a4e68daa62d0e916f56fc8a14e4c61c
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoFix putting empty SXP topology 25/79825/3
Ivan Hrasko [Tue, 22 Jan 2019 16:04:45 +0000 (17:04 +0100)]
Fix putting empty SXP topology

- do not put empty SXP topology
if it already exists

JIRA: SXP-148
Change-Id: Ia3211b6bf0f4791159e100a1a21add8bd43d5e11
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoMerge "Bump to mdsal 3.0.6"
Robert Varga [Wed, 23 Jan 2019 00:50:57 +0000 (00:50 +0000)]
Merge "Bump to mdsal 3.0.6"

5 years agoBump jrobot-remote-server to 3.5.1 20/79820/3
Ivan Hrasko [Tue, 22 Jan 2019 11:12:05 +0000 (12:12 +0100)]
Bump jrobot-remote-server to 3.5.1

Change-Id: Ibc1177ffefdce7a9c14257687db59bc8694c9f3d
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoBump to mdsal 3.0.6 14/79814/1
Stephen Kitt [Tue, 22 Jan 2019 08:53:54 +0000 (09:53 +0100)]
Bump to mdsal 3.0.6

Change-Id: I57a71f951fd93aa434bab92cb8f41c526b1f5aab
Signed-off-by: Stephen Kitt <skitt@redhat.com>
5 years agoBump mdsal to 3.0.5 81/79781/1
Ivan Hrasko [Mon, 21 Jan 2019 08:01:16 +0000 (09:01 +0100)]
Bump mdsal to 3.0.5

Change-Id: I08177bdccb0d34859367d9618c1c0df50f794b52
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoBump to yangtools 2.1.8 80/79780/1
Ivan Hrasko [Mon, 21 Jan 2019 08:00:11 +0000 (09:00 +0100)]
Bump to yangtools 2.1.8

Change-Id: I082da760f0a83a22019aa6b0652b86318b76e97d
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoBump odlparent to 4.0.9 79/79779/1
Ivan Hrasko [Mon, 21 Jan 2019 07:56:49 +0000 (08:56 +0100)]
Bump odlparent to 4.0.9

Change-Id: If88e2121ab71c2f3fdaf5b480395bccee3fdeea9
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoImprove logs for SXP connections shutting down 98/77798/9
Ivan Hrasko [Wed, 14 Nov 2018 15:44:03 +0000 (16:44 +0100)]
Improve logs for SXP connections shutting down

Change-Id: I2f3cc89db854699365818bdfb7185df2581e9739
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoMake onDataTreeChanged synchronized 15/79515/2
Ivan Hrasko [Mon, 14 Jan 2019 14:18:48 +0000 (15:18 +0100)]
Make onDataTreeChanged synchronized

Change-Id: I1d7556a20caa2dd78aac847d62699cacb46e41fa
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoPrint exception message into log 39/79539/2
Ivan Hrasko [Tue, 15 Jan 2019 14:20:13 +0000 (15:20 +0100)]
Print exception message into log

Change-Id: Idcfd98e9638e377b6955b43bb0629fa3093cc32a
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoSimplify processPurgeAllMessage method 75/79475/2
Ivan Hrasko [Fri, 11 Jan 2019 13:55:50 +0000 (14:55 +0100)]
Simplify processPurgeAllMessage method

Change-Id: Ia895b060ddd21fa67401c22bfed02b8ab305dfbe
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoBump mdsal to 3.0.4 55/79455/2
Ivan Hrasko [Fri, 11 Jan 2019 07:55:24 +0000 (08:55 +0100)]
Bump mdsal to 3.0.4

Change-Id: Idb27b2327269f8ea751c79badbc2c83af18a551d
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoBump yangtools to 2.1.7 57/79457/1
Ivan Hrasko [Fri, 11 Jan 2019 07:59:00 +0000 (08:59 +0100)]
Bump yangtools to 2.1.7

Change-Id: Ibf22ea8702f25fcbd2ceaa9afbd1663c718d64b6
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoBump odlparent to 4.0.8 56/79456/1
Ivan Hrasko [Fri, 11 Jan 2019 07:57:00 +0000 (08:57 +0100)]
Bump odlparent to 4.0.8

Change-Id: Id5c744f3d0222f5f145528f69d0141b4ae626b58
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoMake serverChannel volatile 14/79414/1
Ivan Hrasko [Thu, 10 Jan 2019 14:15:11 +0000 (15:15 +0100)]
Make serverChannel volatile

Change-Id: If5f8cf82e57331c69bc60567e5bd1369790b9ac2
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoSimplify SxpNode#openConnections 48/79348/1
Ivan Hrasko [Wed, 9 Jan 2019 13:27:15 +0000 (14:27 +0100)]
Simplify SxpNode#openConnections

Change-Id: I122e0ef5b45138de31c164a05792558ec9f176da
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoFix code smells reported by ODL Sonar 47/79347/1
Ivan Hrasko [Wed, 9 Jan 2019 13:23:33 +0000 (14:23 +0100)]
Fix code smells reported by ODL Sonar

Change-Id: I0c62f73e46480ba69080aa546567f0fda339166a
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoRemove usage of AtomicRefrence 38/79338/2
Ivan Hrasko [Wed, 9 Jan 2019 12:44:18 +0000 (13:44 +0100)]
Remove usage of AtomicRefrence

Change-Id: I6fe362e901487bbc213ed35c40c9cc432157d06d
JIRA: SXP-147
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoBump odlparent to 4.0.7 15/79315/1
Ivan Hrasko [Tue, 8 Jan 2019 14:42:15 +0000 (15:42 +0100)]
Bump odlparent to 4.0.7

Change-Id: I76c2ed063ba4e425c5155475c939094dcfd01d64
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoSynchronize node start/stop methods 83/79283/3
Ivan Hrasko [Mon, 7 Jan 2019 16:23:07 +0000 (17:23 +0100)]
Synchronize node start/stop methods

Change-Id: I5f92b48ca92e0520ca7536c2af86dca03b96168a
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoBump odlparent/yangtools/mdsal versions 30/79030/1
Robert Varga [Mon, 24 Dec 2018 19:05:29 +0000 (20:05 +0100)]
Bump odlparent/yangtools/mdsal versions

This bumps versions to current plaform versions:
- odlparent-4.0.5
- yangtools-2.1.6
- mdsal-3.0.3

Change-Id: Iaeae511566cd03dbc61236824ee86b931136031e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoFix connection retry task scheduling 59/78459/4
Ivan Hrasko [Wed, 5 Dec 2018 14:45:45 +0000 (15:45 +0100)]
Fix connection retry task scheduling

- set retryOpenScheduledOrRunning to false
to allow next connection retry

JIRA: SXP-147
Change-Id: Ic13b4cf36dd9fa42f5041e9ab82983c808a57a6f
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoFix SXP node start/stop 27/78427/3
Ivan Hrasko [Tue, 4 Dec 2018 15:22:54 +0000 (16:22 +0100)]
Fix SXP node start/stop

- improve node start and stop methods
to allow consequent start and stop
of the same node multiple times

- change node port in SxpDatastoreNodeTest
to 64977 to avoid conflicts with other
unit test suites

JIRA: SXP-156
Change-Id: I83367f41b2542d70a45371bd20e54d7940b10127
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoBump yangtools to 2.1.4 and mdsal to 3.0.2 01/77601/5
Ivan Hrasko [Thu, 8 Nov 2018 07:36:50 +0000 (08:36 +0100)]
Bump yangtools to 2.1.4 and mdsal to 3.0.2

- update toString() for SXP database to order
bindings by IP prefix

Change-Id: Ib343c075feb91d14d4df7a40ccee2174af798c3f
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoFix datastore closing 14/78214/6
Ivan Hrasko [Tue, 27 Nov 2018 15:32:21 +0000 (16:32 +0100)]
Fix datastore closing

- close datastore access only after
node is sucessfully down

Change-Id: I77d46ef6d6bfe0bae9219568677378255b13e6b6
JIRA: SXP-153
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoExclude system tests from JUnit 47/78047/3
Ivan Hrasko [Thu, 22 Nov 2018 12:55:16 +0000 (13:55 +0100)]
Exclude system tests from JUnit

- system tests are not meant to be run
by JUnit

- they have to be run manually and requires
running SXP Karaf on the machine

Change-Id: Ifdbb2a868add76421ec715676f42018f9d5feb35
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoFix data for system test 45/78045/1
Ivan Hrasko [Thu, 22 Nov 2018 11:56:58 +0000 (12:56 +0100)]
Fix data for system test

- master-database is no more part
of config datastore

Change-Id: I5f57b6640db3a03d36c948058af6e5f41a77966e
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoFix SXP release validation issues 34/78034/1
Thanh Ha [Thu, 22 Nov 2018 04:29:33 +0000 (12:29 +0800)]
Fix SXP release validation issues

Issue: SXP-155
Change-Id: Ic2b010d7ce32a38b97d3ba3d5c19e1f13c7ec87f
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoUpdate add/delete node RPCs 47/77947/4
Ivan Hrasko [Mon, 19 Nov 2018 15:14:30 +0000 (16:14 +0100)]
Update add/delete node RPCs

- add-node: do not wait for node to appear in
nodes register

- delete-node: first try to remove node from
config DS and only afterwards try to remove node
from operational DS because change in config DS
is reflected into operational DS by listeners

JIRA: SXP-154
Change-Id: I228114eba68b3d62dd8a77a5d5fc78a2069a3ec6
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoImprove logs in DatastoreAccess class 69/77969/2
Ivan Hrasko [Tue, 20 Nov 2018 09:10:56 +0000 (10:10 +0100)]
Improve logs in DatastoreAccess class

Change-Id: I60868036c16429cd33905d90912e7583479f8a97
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoImprove readablitity of SxpRpcServiceImpl class 87/77787/1
Ivan Hrasko [Wed, 14 Nov 2018 13:11:23 +0000 (14:11 +0100)]
Improve readablitity of SxpRpcServiceImpl class

- rename datastoreAccess field to serviceDatastoreAccess

Change-Id: Ib9831240375112be50e6e7c4b80195bb2d2bc20e
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoDatastoreAccess on one cluster node (leader) is closed 86/77786/1
Ivan Hrasko [Wed, 14 Nov 2018 13:01:31 +0000 (14:01 +0100)]
DatastoreAccess on one cluster node (leader) is closed

- when owner is going to be follower
it closes SXP nodes and theirs data store
access instances - afterwards SXP nodes
have to be removed from NodesRegister

Change-Id: Id18bd23942e3e7c57e0dc9024fbec0d7281481da
JIRA: SXP-146
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoRemove unnecessary checks for node existence 42/77642/2
Ivan Hrasko [Fri, 9 Nov 2018 08:15:30 +0000 (09:15 +0100)]
Remove unnecessary checks for node existence

- if nodeId is null it has no sense to try
read node from datastore

Change-Id: I730287898b812aad52a7e74d9b76aecfa326c88b
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoCheck for parent existence in RPCs 25/77625/1
Ivan Hrasko [Thu, 8 Nov 2018 14:37:13 +0000 (15:37 +0100)]
Check for parent existence in RPCs

- check if parent exists for:
- domain filter
- filter

Change-Id: I6be536d59f9717b5b7930a2457fb91bce667defe
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoFix check for virtual ip presence 74/77574/1
Ivan Hrasko [Wed, 7 Nov 2018 08:50:15 +0000 (09:50 +0100)]
Fix check for virtual ip presence

- fix check for existence of virtual ip
assigned to virtual interface

Change-Id: I53047686a6e1d58d125fe6f9d755106c5c8f0c26
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoUse jackson transitive dependency 08/76308/8
Ivan Hrasko [Thu, 20 Sep 2018 13:36:48 +0000 (15:36 +0200)]
Use jackson transitive dependency

Change-Id: Ie4efd38c77ee5b195ca94d69206c879b88e76a2e
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoMove NODES map to own class 24/77024/11
Ivan Hrasko [Tue, 16 Oct 2018 12:19:45 +0000 (14:19 +0200)]
Move NODES map to own class

- NODES map belongs to its own
NodesRegister class

Change-Id: I3d856d399bf8570cc00ca05cd1eb26df01a24dbb
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoDo not check for parent existence 81/76881/12
Ivan Hrasko [Thu, 11 Oct 2018 13:45:27 +0000 (15:45 +0200)]
Do not check for parent existence

- it is a responsibility of the caller to
know/ensure that parent node exists

- reduces unnecessary reads when writting

- solves problem after Neon platform update
when list parents are not present when
inserting the first list item

Change-Id: Ie725e1b20562db08907c2f6cdf05b3d1df61485d
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoFormat DatastoreAccess class 30/76930/8
Ivan Hrasko [Fri, 12 Oct 2018 10:53:11 +0000 (12:53 +0200)]
Format DatastoreAccess class

Change-Id: Iff4e97dc7bae61f8593056b2b5a4f01e797dc5f0
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoNeon MRI changes 91/75991/54
Ivan Hrasko [Tue, 11 Sep 2018 14:36:18 +0000 (16:36 +0200)]
Neon MRI changes

This patch bumps:
- odlparent to 4.0.2
- yangtools to 2.1.2
- mdsal to 3.0.1

- Removed Powermock due to incompatibility
with Mockito 2

- Adapted to mdsal.common.api removal
and model updates

- Removed mocks of ListenableFuture class

JIRA: SXP-151
Change-Id: Ib84a7badf5c17cdb8171b1c627b300603190826f
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
5 years agoDo not turn UP/DOWN dummy interface 53/77253/1
Ivan Hrasko [Wed, 24 Oct 2018 13:27:58 +0000 (15:27 +0200)]
Do not turn UP/DOWN dummy interface

- it is not neccessary
- makes problems on CentOS

Change-Id: I4bef7a97c8798f8349bf52af05de89369c0a154a
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoRevert "Remove waiting for Configuration update" 01/77101/6
Ivan Hrasko [Fri, 19 Oct 2018 12:23:46 +0000 (12:23 +0000)]
Revert "Remove waiting for Configuration update"

- this reverts commit 6f695c28e073e9a9f4f5691a26e75b03b229c42b

- waiting is possible after: https://git.opendaylight.org/gerrit/#/c/77079/ is merged

Change-Id: Ib0866e1079ef60654054ec5773fab6546805694a
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoRegister RPC services on cluster owner only 79/77079/9
Ivan Hrasko [Thu, 18 Oct 2018 12:33:17 +0000 (14:33 +0200)]
Register RPC services on cluster owner only

- some of the RPC calls depend on static structures
which are available only on cluster owner

- for example: map of sxp nodes, map of binding origins

JIRA: SXP-145
Change-Id: If34f44686a4e3c5318359eea909beabaeac31bcd
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoUpdate routing to use ip command 05/77205/3
Ivan Hrasko [Tue, 23 Oct 2018 13:33:58 +0000 (15:33 +0200)]
Update routing to use ip command

- ifconfig is not installed on CentOS
- in the future pure Java solution will be needed

Change-Id: Ie62788c3ad6f0a094e6c6e9430bdb6a020780488
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoRemove blank lines 87/77187/1
Ivan Hrasko [Tue, 23 Oct 2018 07:11:41 +0000 (09:11 +0200)]
Remove blank lines

Change-Id: I716dec99ecb77dc370717e3341e47d6cb965878f
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoRemove Collections2 18/76418/3
Ivan Hrasko [Mon, 24 Sep 2018 15:10:51 +0000 (17:10 +0200)]
Remove Collections2

Change-Id: I2e2e210792ed4c23c1b23423f7a538ae4bc85eda
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoPrefer Java 8 instead of Guava 35/76135/2
Ivan Hrasko [Mon, 17 Sep 2018 08:56:18 +0000 (10:56 +0200)]
Prefer Java 8 instead of Guava

- remove usage of com.google.common.base.Predicate;
- remove usage of com.google.common.collect.Collections2;

Change-Id: Id0b037b37f5bf2518f76e776d3db133d9956a352
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoMigrate sxp docs to project repo 86/75886/1
Thanh Ha [Sun, 9 Sep 2018 01:23:37 +0000 (21:23 -0400)]
Migrate sxp docs to project repo

Change-Id: Iaab419314a4cb95ba936d799a4378f388df4c8fd
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoBootstrap sxp documentation 85/75885/1
Thanh Ha [Sun, 9 Sep 2018 01:22:02 +0000 (21:22 -0400)]
Bootstrap sxp documentation

Change-Id: Iec0090ac9839ead136e6401f1b6046e8157eb31a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoRemove waiting for Configuration update 54/75354/1
Ivan Hrasko [Tue, 21 Aug 2018 14:21:13 +0000 (16:21 +0200)]
Remove waiting for Configuration update

- temporarily remove waiting for presence
of added node in Configuration untill better
approach will be discovered

- not working in cluster environment

Change-Id: I48a93876e4ddee7a83f1db82d1800ce13fa16903
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoDelete ip address when virtual interface is down 14/75314/2
Ivan Hrasko [Mon, 20 Aug 2018 07:08:28 +0000 (09:08 +0200)]
Delete ip address when virtual interface is down

- when virtual interface is set to down
delete also its IP address to block routing
throught that virtual IP address

- otherwise routing to node throught virtual IP
still works despite interface is down

Change-Id: I17096011c8d2e66657ad8a3b199d05637179b7a9
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoReplace controller's API by mdsal's API 64/74764/26
Ivan Hrasko [Thu, 2 Aug 2018 11:33:26 +0000 (13:33 +0200)]
Replace controller's API by mdsal's API

Change-Id: I7f05fb12d420dfdeb093017b97f78e29d5dd3ad7
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoRemove usage of com.google.common.base.Functions 07/75007/2
Ivan Hrasko [Thu, 9 Aug 2018 14:00:22 +0000 (16:00 +0200)]
Remove usage of com.google.common.base.Functions

Change-Id: Ibca5eefb8dcce128c7bf887b4d951d9c67718838
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoOptimize imports 91/74791/6
Ivan Hrasko [Fri, 3 Aug 2018 08:45:32 +0000 (10:45 +0200)]
Optimize imports

Change-Id: I955b642c2472dacaeab7da707da5f3b3e491554d
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoDrop CheckedFutures in favor of FluentFutures 23/74223/18
Martin Dindoffer [Mon, 9 Jul 2018 11:46:01 +0000 (13:46 +0200)]
Drop CheckedFutures in favor of FluentFutures

Change-Id: I5347842368ae2334ec5c5b57efc7ccb224894343
Signed-off-by: Martin Dindoffer <mdindoff@cisco.com>
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoBump versions by x.(y+1).z for next dev cycle 95/75095/1
Ivan Hrasko [Fri, 10 Aug 2018 10:42:03 +0000 (12:42 +0200)]
Bump versions by x.(y+1).z for next dev cycle

Change-Id: Ib822f3a7701a6561d5ef01b4c54684e8db567ea8
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoImprove documentation for DatastoreAccess class 56/74756/5
Ivan Hrasko [Thu, 2 Aug 2018 08:29:11 +0000 (10:29 +0200)]
Improve documentation for DatastoreAccess class

Change-Id: Iaa8acaeacfea8052d27aa4e1ca581f82f33f1f71
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoBump to yangtools 2.0.10 14/74914/1
Ivan Hrasko [Tue, 7 Aug 2018 12:10:23 +0000 (14:10 +0200)]
Bump to yangtools 2.0.10

Change-Id: I9f296bb268ba022532ad4d4b1265764be43815c8
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoAdapt tests for controller changes 38/74838/1
Ivan Hrasko [Mon, 6 Aug 2018 08:20:47 +0000 (10:20 +0200)]
Adapt tests for controller changes

Change-Id: Iad0854eda4410b9ea8f0c92300b1a1be99ed42d3
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoCode cleaning 21/74721/1
Ivan Hrasko [Wed, 1 Aug 2018 08:33:31 +0000 (10:33 +0200)]
Code cleaning

Change-Id: Iabe0b34b372bc1aacfad549a0cf93c0f993fd0f8
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoAdd documentation and remove null check 20/74720/1
Ivan Hrasko [Wed, 1 Aug 2018 08:31:45 +0000 (10:31 +0200)]
Add documentation and remove null check

- null check is unnecessary because methods
are called only on alive connections

Change-Id: Ie6ecf9f7f05c7929dab35570d02e204fad36a157
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoIncrease code coverage 90/74690/2
Ivan Hrasko [Tue, 31 Jul 2018 12:20:17 +0000 (14:20 +0200)]
Increase code coverage

- add unit tests for SxpRpcServiceImpl.java

Change-Id: Iaaeb1868a84e3639fec6d8a9e6541ee3f2395a02
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoIncrease code coverage 81/74581/8
Ivan Hrasko [Fri, 27 Jul 2018 13:20:47 +0000 (15:20 +0200)]
Increase code coverage

- add unit tests for SxpConfigRpcServiceImpl.java

Change-Id: Iefce9e9aa293d7b45c8af67616e2e12acc06e293
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoFix small code smells reported by Sonar 44/74644/3
Ivan Hrasko [Mon, 30 Jul 2018 11:59:26 +0000 (13:59 +0200)]
Fix small code smells reported by Sonar

Change-Id: Iac3966a45160d0d483d8e63ef5d4a546cccf332d
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoMerge "Increase code coverage"
Ivan Hrasko [Mon, 30 Jul 2018 11:57:45 +0000 (11:57 +0000)]
Merge "Increase code coverage"

5 years agoIncrease code coverage 77/74577/4
Ivan Hrasko [Fri, 27 Jul 2018 12:29:05 +0000 (14:29 +0200)]
Increase code coverage

- unit tests for BindingOriginsConfig.java

Change-Id: Ic2cb78aa5864370ab9f0e71e9cb924e334152e04
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoFix bugs reported by ODL Sonar 27/74627/3
Ivan Hrasko [Mon, 30 Jul 2018 07:48:23 +0000 (09:48 +0200)]
Fix bugs reported by ODL Sonar

Change-Id: I8012546b9efe918c570e9c40366aceadc29b9ff2
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoBump yangtools to 2.0.9 37/74637/2
Robert Varga [Mon, 30 Jul 2018 10:27:27 +0000 (12:27 +0200)]
Bump yangtools to 2.0.9

This patch bumps yangtools to latest release.

Change-Id: I3ecc67f57c64b14cd425525891744b4ee1724f41
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoBump to odlparent 3.1.3 29/74629/2
Stephen Kitt [Thu, 26 Jul 2018 14:12:31 +0000 (16:12 +0200)]
Bump to odlparent 3.1.3

Change-Id: Iafc8c3676afb2099b39765b7673aa1a92628e3c9
Signed-off-by: Stephen Kitt <skitt@redhat.com>
5 years agoFix simultaneous connection problems and add ITs for Binding Origins 58/74458/9
Martin Dindoffer [Mon, 16 Jul 2018 12:47:53 +0000 (14:47 +0200)]
Fix simultaneous connection problems and add ITs for Binding Origins

This commit fixes long standing bugs, where two nodes end up in
a corrupted state if they happen to connect to each other at the same time.
Fix is basically to just close the correct contexts and only when there is no
handshake in progress.
Also fixes the incorrect addition of the GLOBAL domain when there is one
provided during the construction of an SXP node.
Finally, it adds some IT for checking correct binding origin priorities
handling.

Change-Id: I29857bfc297c16cbe0b41135b7edbdc2c03641b5
Signed-off-by: Martin Dindoffer <mdindoff@cisco.com>
5 years agoClean SxpNode class 56/74456/3
Ivan Hrasko [Wed, 25 Jul 2018 14:03:44 +0000 (16:03 +0200)]
Clean SxpNode class

- removed methods used only for one type
of bindings
- removed methods deprecated since Carbon

Change-Id: I60ffe14fdf1301b58546cdde6f19be3af9de2f88
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoFix get-node-bindings RPC 41/74341/2
Ivan Hrasko [Mon, 23 Jul 2018 15:18:58 +0000 (17:18 +0200)]
Fix get-node-bindings RPC

- get-node-bindings RCP cannot fail if
requesting for bindings of not existing
domain within a node
- instead return an empty result

Change-Id: Ibcdbfa2a44aaf92c4ea108d799df0e77d26e7309
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoFix getValue() and char[] use 11/74311/3
Robert Varga [Sun, 22 Jul 2018 10:50:26 +0000 (12:50 +0200)]
Fix getValue() and char[] use

Do not use deprecated union getValue() nor char[]-based constructor.

Change-Id: Ide234c395f492039b4cc3f01d629fe08e3732e58
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoRemove dependency on odl-mdsal-broker 88/74288/2
Robert Varga [Fri, 20 Jul 2018 13:13:21 +0000 (15:13 +0200)]
Remove dependency on odl-mdsal-broker

This in an API feature, odl-mdsal-broker should not be necessary.

Change-Id: I7a3ed87bd9aa28c56e926b904bd52a2b3278789c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoRemove reference to odl-mdsal-models 82/74282/2
Robert Varga [Fri, 20 Jul 2018 13:08:21 +0000 (15:08 +0200)]
Remove reference to odl-mdsal-models

We really need just ietf-inet-types, so depend on that.

Change-Id: Ice11660cd316b37ffcc321235feca8b8b3fd1520
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoMerge "Add origin type to add-bindings RPC"
Ivan Hrasko [Thu, 19 Jul 2018 11:58:14 +0000 (11:58 +0000)]
Merge "Add origin type to add-bindings RPC"

5 years agoAdd origin type to add-bindings RPC 79/74179/2
Ivan Hrasko [Wed, 18 Jul 2018 07:52:05 +0000 (09:52 +0200)]
Add origin type to add-bindings RPC

- using of SXP is easier when user can specify
origin of bindings also in add-bindings RPC

- previously only add-domain offered possibity
to specify added bindings origin

Change-Id: I48f439d322cf2fb15a0d14926a88bd420434e753
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoCheck if incoming binding origin is set 81/74181/3
Ivan Hrasko [Wed, 18 Jul 2018 08:31:32 +0000 (10:31 +0200)]
Check if incoming binding origin is set

- if incoming binding origin type is null
then throw IllegalArgumentException

Change-Id: I513f20590ccf8de746d616298f50cfb6e01bd229
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoRespect origin priorities in Hazelcast master DB 77/73877/16
Martin Dindoffer [Tue, 10 Jul 2018 10:53:27 +0000 (12:53 +0200)]
Respect origin priorities in Hazelcast master DB

Change-Id: I7368a1143f06795a30c7efbce8b2b7d5d6d4a6db
Signed-off-by: Martin Dindoffer <mdindoff@cisco.com>
5 years agoAdapt add-domain RPC for binding origins 79/73879/24
Ivan Hrasko [Tue, 10 Jul 2018 09:56:17 +0000 (11:56 +0200)]
Adapt add-domain RPC for binding origins

- removed config-persistence input field because:
- domain is always saved to both CONFIG
and OPERATIONAL (throught listeners)

- added origin input field because:
- user can then specify binding origin of
domain bindings

Change-Id: I628852712f49c7f761ed267d9664a5a761d5fd44
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoCheck for binding origin's existence 29/73929/11
Ivan Hrasko [Wed, 11 Jul 2018 12:24:25 +0000 (14:24 +0200)]
Check for binding origin's existence

- do not allow binding with unknown origin
to be saved to master database

Change-Id: I055e133b92647b78491eb660666f9c9bf082a26d
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
Signed-off-by: Martin Dindoffer <mdindoff@cisco.com>
5 years agoRemove config-persistence from add-bindings 74/73874/14
Ivan Hrasko [Tue, 10 Jul 2018 09:56:17 +0000 (11:56 +0200)]
Remove config-persistence from add-bindings

- add-bindings RPC only allows to add LOCAL bindings
- all bindings will be stored only in OPERATIONAL
datastore
- leaf is never used

Change-Id: I8775a0095b5f8f30df30a0c09c7a3ce207817c28
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoRemove deprecated REST calls 73/73873/12
Ivan Hrasko [Tue, 10 Jul 2018 09:52:21 +0000 (11:52 +0200)]
Remove deprecated REST calls

- removed add-entry, update-entry
and delete-entry RPCs

Change-Id: I28236cc62e6a24115725342f074fd2862c43311a
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoAdd priority checks to md-sal DB 10/73810/24
Ivan Hrasko [Mon, 2 Jul 2018 13:26:07 +0000 (15:26 +0200)]
Add priority checks to md-sal DB

- all datastore bindings are stored only in OPERATIONAL
- when adding higher priority binding for
the same ip prefix then previous binding with
lower priority is replaced
- when adding multiple bindings for the
same ip prefix at once then only the binding
with the highest priority is saved to datastore

Change-Id: Icadbe234c6e44f2e6b055cf8188a528e5aae3f5d
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
Signed-off-by: Martin Dindoffer <mdindoff@cisco.com>
5 years agoAdd priority checks to in-memory DBs 52/73652/38
Ivan Hrasko [Mon, 2 Jul 2018 13:26:07 +0000 (15:26 +0200)]
Add priority checks to in-memory DBs

- all in-memory bindings are stored only
in one map
- when adding higher priority binding for
the same ip prefix then previous binding with
lower priority is replaced
- when adding multiple bindings for the
same ip prefix at once then only the binding
with the highest priority is saved to database

Change-Id: I4172283ffd78200d2dbf7dbfe6d500556ad78933
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
Signed-off-by: Martin Dindoffer <mdindoff@cisco.com>
5 years agoRemove methods used solely for local bindings 07/73707/19
Ivan Hrasko [Tue, 3 Jul 2018 13:52:08 +0000 (15:52 +0200)]
Remove methods used solely for local bindings

- removed addLocalBindings(), deleteBindingsLocal() and getLocalBindings()
from MasterDatabaseInf
- this change is needed after configurable origin was introduced
into bindings:
- each binding now includes its origin type
- thus we no more need methods used only for one
specified type of bindings

Change-Id: If1dfc27791f9b91daf77d4806fb29a3b2a97d34d
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoUse unique hazelcast group in DistributedBindingsIT 12/74012/2
Martin Dindoffer [Fri, 13 Jul 2018 11:21:06 +0000 (13:21 +0200)]
Use unique hazelcast group in DistributedBindingsIT

Change-Id: Ia96d2c4d796e083671fb1d53c5d5d3f12e3cfd2c
Signed-off-by: Martin Dindoffer <mdindoff@cisco.com>
5 years agoClose all available contexts during VSS switchover 81/73881/1
Martin Dindoffer [Tue, 10 Jul 2018 15:17:13 +0000 (17:17 +0200)]
Close all available contexts during VSS switchover

Change-Id: Ia0ff3dc32b9217a10eed52446aab5221ef2162b5
Signed-off-by: Martin Dindoffer <mdindoff@cisco.com>
5 years agoProvide utility method for adding origin type priorities 47/73647/5
Martin Dindoffer [Mon, 2 Jul 2018 12:20:12 +0000 (14:20 +0200)]
Provide utility method for adding origin type priorities

Change-Id: I5b4883782e2be4879929fc4c96e46aa9daf44dea
Signed-off-by: Martin Dindoffer <mdindoff@cisco.com>
5 years agoCreate add, update and delete binding origins RPCs 47/73447/31
Martin Dindoffer [Mon, 18 Jun 2018 11:08:03 +0000 (13:08 +0200)]
Create add, update and delete binding origins RPCs

- possibilty for user to create, modify and delete binding
origins via RPC
- RPC logic contains verification that binding origins are
not getting misconfigured and it is not possible to delete required
defaults LOCAL and NETWORK origins

Change-Id: I1994252d7c09f4075f7202e25ca668868092c1c3
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoInject binding origins to md-sal data-store 44/73344/34
Martin Dindoffer [Mon, 18 Jun 2018 11:08:03 +0000 (13:08 +0200)]
Inject binding origins to md-sal data-store

- save default binding origins to datastore at SXP start-up in
SxpControllerInstance class
- user defined binding origins are not replaced if they already exists
from prevoius application runs

Change-Id: Icb48200e725d64ff38a425dd532f4a95bc56f3a4
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoMove binding origins configuration to singleton 02/73402/18
Ivan Hrasko [Mon, 25 Jun 2018 13:04:23 +0000 (15:04 +0200)]
Move binding origins configuration to singleton

- make binding origin configuration available for all nodes
in BindingOriginsConfig class

Change-Id: I438ed5e359726353c9020d2306e78d459fa99e15
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
5 years agoIntroduce an Origin type to SGT bindings 57/72957/13
Martin Dindoffer [Tue, 12 Jun 2018 07:52:38 +0000 (09:52 +0200)]
Introduce an Origin type to SGT bindings

- add binding origin config to yang and make binding origin part of
each binding

Change-Id: I077151f765335b87f34884f76762e0bfc45d6325
Signed-off-by: Martin Dindoffer <mdindoff@cisco.com>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
5 years agoUse unique multicast groups for each junit test 50/73650/2
Martin Dindoffer [Mon, 2 Jul 2018 13:19:38 +0000 (15:19 +0200)]
Use unique multicast groups for each junit test

Change-Id: I6361eb46b0287bc564f9016782e06a070c640fde
Signed-off-by: Martin Dindoffer <mdindoff@cisco.com>
5 years agoAdd basic lifecycle logging to HazelcastBackedSxpDBIT 36/73636/1
Martin Dindoffer [Mon, 2 Jul 2018 09:12:15 +0000 (11:12 +0200)]
Add basic lifecycle logging to HazelcastBackedSxpDBIT

Change-Id: I13d7ba9a0da83c5566599f43b48750d48c252faa
Signed-off-by: Martin Dindoffer <mdindoff@cisco.com>
5 years agoBump yangtools to 2.0.7 06/73606/1
Martin Dindoffer [Fri, 29 Jun 2018 12:33:18 +0000 (14:33 +0200)]
Bump yangtools to 2.0.7

Change-Id: I22d62d2404a2c1a0531c185d78c969a6f4f11a5e
Signed-off-by: Martin Dindoffer <mdindoff@cisco.com>
5 years agoSXP-131: Robot reports negative periods of time 86/73186/5
Ivan Hrasko [Tue, 19 Jun 2018 13:11:00 +0000 (15:11 +0200)]
SXP-131: Robot reports negative periods of time

- remove using of AtomicLong because all methods
are synchronized
- use proper synchronization in addDestinationNode
and addNode methods

Change-Id: I9e3902389395f0045a62f9cb084cc6dd8a75e142
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>