Bug 6585: BGP ChannelOutputLimiter waits forever 46/44946/2
authorMilos Fabian <milfabia@cisco.com>
Wed, 31 Aug 2016 15:40:49 +0000 (17:40 +0200)
committerMilos Fabian <milfabia@cisco.com>
Mon, 5 Sep 2016 12:07:15 +0000 (14:07 +0200)
commit684d75cb36f3b34b2691b374166f1bbc9ef52de5
treef3b407632360ec17e42697699b1a1d22ff09876b
parentb4657f9d04a5e0d30fa6d275ef933c420d9016c8
Bug 6585: BGP ChannelOutputLimiter waits forever

After a while (when an output buffer reach upper bound),
BGP's ChannelOutputLimiter handler get stacked waiting for the channel to become writable again.
The writability change never happen, however socket flush is invoked,
so the session peer dies on holdtimer expiration.

Looks like calling #flush when writability changes to non-writable has no effect.
Invoking #flush in #ensureWritable makes the expected action.

Change-Id: I95681d87c30aff82ec360a2d13fc01fe35873507
Signed-off-by: Milos Fabian <milfabia@cisco.com>
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/ChannelOutputLimiter.java