From 3653b34fe4de5af40a9f9c99dc50c72775794f0a Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Fri, 23 Sep 2016 15:38:37 +0200 Subject: [PATCH] Do not instantiate iterator for debugging Logging the entire collection is more appropriate and also faster when logging is disabled. Change-Id: Ib3e44851bcedad1eaabad983c1ac45de6890eec2 Signed-off-by: Robert Varga --- .../inmemory/AbstractDOMShardTreeChangePublisher.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/dom/mdsal-dom-inmemory-datastore/src/main/java/org/opendaylight/mdsal/dom/store/inmemory/AbstractDOMShardTreeChangePublisher.java b/dom/mdsal-dom-inmemory-datastore/src/main/java/org/opendaylight/mdsal/dom/store/inmemory/AbstractDOMShardTreeChangePublisher.java index 1cfea3463e..271871677d 100644 --- a/dom/mdsal-dom-inmemory-datastore/src/main/java/org/opendaylight/mdsal/dom/store/inmemory/AbstractDOMShardTreeChangePublisher.java +++ b/dom/mdsal-dom-inmemory-datastore/src/main/java/org/opendaylight/mdsal/dom/store/inmemory/AbstractDOMShardTreeChangePublisher.java @@ -212,7 +212,7 @@ abstract class AbstractDOMShardTreeChangePublisher extends AbstractDOMStoreTreeC @Override public void onDataTreeChanged(@Nonnull final Collection changes) { - LOG.debug("Received data changed {}", changes.iterator().next()); + LOG.debug("Received data changed {}", changes); delegate.onDataTreeChanged(changes); } @@ -275,8 +275,7 @@ abstract class AbstractDOMShardTreeChangePublisher extends AbstractDOMStoreTreeC private final PathArgument identifier; EmptyDataTreeCandidateNode(final PathArgument identifier) { - Preconditions.checkNotNull(identifier, "Identifier should not be null"); - this.identifier = identifier; + this.identifier = Preconditions.checkNotNull(identifier, "Identifier should not be null"); } @Nonnull @@ -288,7 +287,7 @@ abstract class AbstractDOMShardTreeChangePublisher extends AbstractDOMStoreTreeC @Nonnull @Override public Collection getChildNodes() { - return Collections.emptySet(); + return Collections.emptySet(); } @Nullable -- 2.36.6