From 8c1a4caabb4d1978e28d2c7bfd43943e22576334 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Tue, 25 Apr 2023 11:37:06 +0200 Subject: [PATCH] Rename netconf-impl to netconf-server This artifact contains only server-side things. Make sure to rename it to reflect that. JIRA: NETCONF-945 Change-Id: I13322553c4bdd8979fe564ce1337dfb9e43c7e7a Signed-off-by: Robert Varga --- artifacts/pom.xml | 12 ++---- features/netconf/odl-netconf-impl/pom.xml | 2 +- netconf/mdsal-netconf-impl/pom.xml | 2 +- .../DefaultNetconfMonitoringService.java | 2 +- .../mdsal/DefaultNetconfServerDispatcher.java | 4 +- .../impl/mdsal/NetconfMapperAggregator.java | 2 +- .../netconf/impl/mdsal/OSGiNetconfServer.java | 8 ++-- netconf/tools/netconf-testtool/pom.xml | 8 ++-- .../test/tool/MdsalOperationProvider.java | 2 +- .../test/tool/NetconfDeviceSimulator.java | 12 +++--- .../test/tool/SimulatedOperationProvider.java | 2 +- .../test/tool/TesttoolNegotiationFactory.java | 4 +- .../operations/DefaultOperationsCreator.java | 2 +- .../tool/operations/OperationsCreator.java | 2 +- .../tool/operations/OperationsProvider.java | 2 +- .../tool/rpc/SimulatedCreateSubscription.java | 6 +-- plugins/sal-netconf-connector/pom.xml | 2 +- .../{netconf-impl => netconf-server}/pom.xml | 37 +------------------ .../server}/DefaultSessionIdProvider.java | 2 +- .../server}/NetconfServerDispatcherImpl.java | 13 +++---- .../netconf/server}/NetconfServerSession.java | 10 ++--- .../server}/NetconfServerSessionListener.java | 8 ++-- .../NetconfServerSessionNegotiator.java | 2 +- ...NetconfServerSessionNegotiatorFactory.java | 6 +-- ...ServerSessionNegotiatorFactoryBuilder.java | 2 +- .../server}/SendErrorExceptionUtil.java | 7 ++-- .../server}/ServerChannelInitializer.java | 4 +- .../netconf/server}/SessionIdProvider.java | 2 +- .../operations/DefaultCloseSession.java | 6 +-- .../operations/DefaultNetconfOperation.java | 4 +- .../mapping/operations/DefaultStartExi.java | 4 +- .../mapping/operations/DefaultStopExi.java | 13 +++---- ...regatedNetconfOperationServiceFactory.java | 2 +- .../NetconfCapabilityMonitoringService.java | 2 +- .../osgi/NetconfMonitoringServiceImpl.java | 3 +- .../server}/osgi/NetconfOperationRouter.java | 10 ++--- .../osgi/NetconfOperationRouterImpl.java | 14 +++---- .../osgi/NetconfSessionMonitoringService.java | 2 +- .../util/DeserializerExceptionHandler.java | 4 +- .../src/main/yang/odl-netconf-monitoring.yang | 0 .../server}/AdditionalHeaderParserTest.java | 2 +- .../server}/ConcurrentClientsTest.java | 4 +- .../netconf/server}/ExiEncodeDecodeTest.java | 4 +- .../netconf/server}/MessageParserTest.java | 2 +- .../server}/NetconfDispatcherImplTest.java | 4 +- .../NetconfServerSessionListenerTest.java | 5 +-- .../NetconfServerSessionNegotiatorTest.java | 18 +++------ .../server}/NetconfServerSessionTest.java | 2 +- .../server}/SendErrorExceptionUtilTest.java | 2 +- .../operations/DefaultCloseSessionTest.java | 14 +++---- .../operations/DefaultStopExiTest.java | 5 +-- ...tedNetconfOperationServiceFactoryTest.java | 2 +- ...etconfCapabilityMonitoringServiceTest.java | 2 +- .../osgi/NetconfOperationRouterImplTest.java | 8 ++-- .../NetconfSessionMonitoringServiceTest.java | 3 +- .../DeserializerExceptionHandlerTest.java | 3 +- .../src/test/resources/messages/rpc.xml | 0 .../src/test/resources/messages/rpc_ns.xml | 0 protocol/pom.xml | 2 +- 59 files changed, 124 insertions(+), 189 deletions(-) rename protocol/{netconf-impl => netconf-server}/pom.xml (76%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/DefaultSessionIdProvider.java (96%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/NetconfServerDispatcherImpl.java (73%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/NetconfServerSession.java (96%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/NetconfServerSessionListener.java (97%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/NetconfServerSessionNegotiator.java (98%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/NetconfServerSessionNegotiatorFactory.java (97%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/NetconfServerSessionNegotiatorFactoryBuilder.java (98%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/SendErrorExceptionUtil.java (97%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/ServerChannelInitializer.java (92%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/SessionIdProvider.java (90%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/mapping/operations/DefaultCloseSession.java (94%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/mapping/operations/DefaultNetconfOperation.java (77%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/mapping/operations/DefaultStartExi.java (96%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/mapping/operations/DefaultStopExi.java (78%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/osgi/AggregatedNetconfOperationServiceFactory.java (99%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/osgi/NetconfCapabilityMonitoringService.java (99%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/osgi/NetconfMonitoringServiceImpl.java (98%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/osgi/NetconfOperationRouter.java (76%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/osgi/NetconfOperationRouterImpl.java (96%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/osgi/NetconfSessionMonitoringService.java (99%) rename protocol/{netconf-impl/src/main/java/org/opendaylight/netconf/impl => netconf-server/src/main/java/org/opendaylight/netconf/server}/util/DeserializerExceptionHandler.java (93%) rename protocol/{netconf-impl => netconf-server}/src/main/yang/odl-netconf-monitoring.yang (100%) rename protocol/{netconf-impl/src/test/java/org/opendaylight/netconf/impl => netconf-server/src/test/java/org/opendaylight/netconf/server}/AdditionalHeaderParserTest.java (97%) rename protocol/{netconf-impl/src/test/java/org/opendaylight/netconf/impl => netconf-server/src/test/java/org/opendaylight/netconf/server}/ConcurrentClientsTest.java (99%) rename protocol/{netconf-impl/src/test/java/org/opendaylight/netconf/impl => netconf-server/src/test/java/org/opendaylight/netconf/server}/ExiEncodeDecodeTest.java (94%) rename protocol/{netconf-impl/src/test/java/org/opendaylight/netconf/impl => netconf-server/src/test/java/org/opendaylight/netconf/server}/MessageParserTest.java (99%) rename protocol/{netconf-impl/src/test/java/org/opendaylight/netconf/impl => netconf-server/src/test/java/org/opendaylight/netconf/server}/NetconfDispatcherImplTest.java (94%) rename protocol/{netconf-impl/src/test/java/org/opendaylight/netconf/impl => netconf-server/src/test/java/org/opendaylight/netconf/server}/NetconfServerSessionListenerTest.java (98%) rename protocol/{netconf-impl/src/test/java/org/opendaylight/netconf/impl => netconf-server/src/test/java/org/opendaylight/netconf/server}/NetconfServerSessionNegotiatorTest.java (71%) rename protocol/{netconf-impl/src/test/java/org/opendaylight/netconf/impl => netconf-server/src/test/java/org/opendaylight/netconf/server}/NetconfServerSessionTest.java (99%) rename protocol/{netconf-impl/src/test/java/org/opendaylight/netconf/impl => netconf-server/src/test/java/org/opendaylight/netconf/server}/SendErrorExceptionUtilTest.java (98%) rename protocol/{netconf-impl/src/test/java/org/opendaylight/netconf/impl => netconf-server/src/test/java/org/opendaylight/netconf/server}/mapping/operations/DefaultCloseSessionTest.java (92%) rename protocol/{netconf-impl/src/test/java/org/opendaylight/netconf/impl => netconf-server/src/test/java/org/opendaylight/netconf/server}/mapping/operations/DefaultStopExiTest.java (94%) rename protocol/{netconf-impl/src/test/java/org/opendaylight/netconf/impl => netconf-server/src/test/java/org/opendaylight/netconf/server}/osgi/AggregatedNetconfOperationServiceFactoryTest.java (99%) rename protocol/{netconf-impl/src/test/java/org/opendaylight/netconf/impl => netconf-server/src/test/java/org/opendaylight/netconf/server}/osgi/NetconfCapabilityMonitoringServiceTest.java (99%) rename protocol/{netconf-impl/src/test/java/org/opendaylight/netconf/impl => netconf-server/src/test/java/org/opendaylight/netconf/server}/osgi/NetconfOperationRouterImplTest.java (96%) rename protocol/{netconf-impl/src/test/java/org/opendaylight/netconf/impl => netconf-server/src/test/java/org/opendaylight/netconf/server}/osgi/NetconfSessionMonitoringServiceTest.java (99%) rename protocol/{netconf-impl/src/test/java/org/opendaylight/netconf/impl => netconf-server/src/test/java/org/opendaylight/netconf/server}/util/DeserializerExceptionHandlerTest.java (97%) rename protocol/{netconf-impl => netconf-server}/src/test/resources/messages/rpc.xml (100%) rename protocol/{netconf-impl => netconf-server}/src/test/resources/messages/rpc_ns.xml (100%) diff --git a/artifacts/pom.xml b/artifacts/pom.xml index 27737be14f..f8209c0619 100644 --- a/artifacts/pom.xml +++ b/artifacts/pom.xml @@ -62,17 +62,17 @@ ${project.groupId} - mdsal-netconf-connector + netconf-server ${project.version} ${project.groupId} - netconf-impl + netconf-mapping-api ${project.version} ${project.groupId} - netconf-mapping-api + mdsal-netconf-connector ${project.version} @@ -306,12 +306,6 @@ ${project.version} test-jar - - ${project.groupId} - netconf-impl - ${project.version} - test-jar - ${project.groupId} netconf-netty-util diff --git a/features/netconf/odl-netconf-impl/pom.xml b/features/netconf/odl-netconf-impl/pom.xml index fc45317e16..7ae7595791 100644 --- a/features/netconf/odl-netconf-impl/pom.xml +++ b/features/netconf/odl-netconf-impl/pom.xml @@ -59,7 +59,7 @@ ${project.groupId} - netconf-impl + netconf-server diff --git a/netconf/mdsal-netconf-impl/pom.xml b/netconf/mdsal-netconf-impl/pom.xml index 77b4422d53..4c6a1c4114 100644 --- a/netconf/mdsal-netconf-impl/pom.xml +++ b/netconf/mdsal-netconf-impl/pom.xml @@ -43,7 +43,7 @@ org.opendaylight.netconf - netconf-impl + netconf-server org.opendaylight.netconf diff --git a/netconf/mdsal-netconf-impl/src/main/java/org/opendaylight/netconf/impl/mdsal/DefaultNetconfMonitoringService.java b/netconf/mdsal-netconf-impl/src/main/java/org/opendaylight/netconf/impl/mdsal/DefaultNetconfMonitoringService.java index 1b918657d7..97a78bc865 100644 --- a/netconf/mdsal-netconf-impl/src/main/java/org/opendaylight/netconf/impl/mdsal/DefaultNetconfMonitoringService.java +++ b/netconf/mdsal-netconf-impl/src/main/java/org/opendaylight/netconf/impl/mdsal/DefaultNetconfMonitoringService.java @@ -12,8 +12,8 @@ import static java.util.Objects.requireNonNull; import java.util.Map; import org.opendaylight.controller.config.threadpool.ScheduledThreadPool; import org.opendaylight.netconf.api.monitoring.NetconfMonitoringService; -import org.opendaylight.netconf.impl.osgi.NetconfMonitoringServiceImpl; import org.opendaylight.netconf.mapping.api.NetconfOperationServiceFactory; +import org.opendaylight.netconf.server.osgi.NetconfMonitoringServiceImpl; import org.osgi.service.component.annotations.Activate; import org.osgi.service.component.annotations.Component; import org.osgi.service.component.annotations.Deactivate; diff --git a/netconf/mdsal-netconf-impl/src/main/java/org/opendaylight/netconf/impl/mdsal/DefaultNetconfServerDispatcher.java b/netconf/mdsal-netconf-impl/src/main/java/org/opendaylight/netconf/impl/mdsal/DefaultNetconfServerDispatcher.java index a60317b711..a1edec19ee 100644 --- a/netconf/mdsal-netconf-impl/src/main/java/org/opendaylight/netconf/impl/mdsal/DefaultNetconfServerDispatcher.java +++ b/netconf/mdsal-netconf-impl/src/main/java/org/opendaylight/netconf/impl/mdsal/DefaultNetconfServerDispatcher.java @@ -12,8 +12,8 @@ import static java.util.Objects.requireNonNull; import io.netty.channel.EventLoopGroup; import java.util.Map; import org.opendaylight.netconf.api.NetconfServerDispatcher; -import org.opendaylight.netconf.impl.NetconfServerDispatcherImpl; -import org.opendaylight.netconf.impl.ServerChannelInitializer; +import org.opendaylight.netconf.server.NetconfServerDispatcherImpl; +import org.opendaylight.netconf.server.ServerChannelInitializer; import org.osgi.service.component.annotations.Activate; import org.osgi.service.component.annotations.Component; diff --git a/netconf/mdsal-netconf-impl/src/main/java/org/opendaylight/netconf/impl/mdsal/NetconfMapperAggregator.java b/netconf/mdsal-netconf-impl/src/main/java/org/opendaylight/netconf/impl/mdsal/NetconfMapperAggregator.java index cf3637a13f..ea0eda2cdb 100644 --- a/netconf/mdsal-netconf-impl/src/main/java/org/opendaylight/netconf/impl/mdsal/NetconfMapperAggregator.java +++ b/netconf/mdsal-netconf-impl/src/main/java/org/opendaylight/netconf/impl/mdsal/NetconfMapperAggregator.java @@ -7,9 +7,9 @@ */ package org.opendaylight.netconf.impl.mdsal; -import org.opendaylight.netconf.impl.osgi.AggregatedNetconfOperationServiceFactory; import org.opendaylight.netconf.mapping.api.NetconfOperationServiceFactory; import org.opendaylight.netconf.mapping.api.NetconfOperationServiceFactoryListener; +import org.opendaylight.netconf.server.osgi.AggregatedNetconfOperationServiceFactory; import org.osgi.service.component.annotations.Activate; import org.osgi.service.component.annotations.Component; import org.osgi.service.component.annotations.Deactivate; diff --git a/netconf/mdsal-netconf-impl/src/main/java/org/opendaylight/netconf/impl/mdsal/OSGiNetconfServer.java b/netconf/mdsal-netconf-impl/src/main/java/org/opendaylight/netconf/impl/mdsal/OSGiNetconfServer.java index e4bb3ba751..56aae63938 100644 --- a/netconf/mdsal-netconf-impl/src/main/java/org/opendaylight/netconf/impl/mdsal/OSGiNetconfServer.java +++ b/netconf/mdsal-netconf-impl/src/main/java/org/opendaylight/netconf/impl/mdsal/OSGiNetconfServer.java @@ -14,11 +14,11 @@ import io.netty.channel.EventLoopGroup; import io.netty.util.Timer; import java.util.Map; import org.opendaylight.controller.config.threadpool.ScheduledThreadPool; -import org.opendaylight.netconf.impl.NetconfServerSessionNegotiatorFactory; -import org.opendaylight.netconf.impl.ServerChannelInitializer; -import org.opendaylight.netconf.impl.SessionIdProvider; -import org.opendaylight.netconf.impl.osgi.AggregatedNetconfOperationServiceFactory; import org.opendaylight.netconf.mapping.api.NetconfOperationServiceFactory; +import org.opendaylight.netconf.server.NetconfServerSessionNegotiatorFactory; +import org.opendaylight.netconf.server.ServerChannelInitializer; +import org.opendaylight.netconf.server.SessionIdProvider; +import org.opendaylight.netconf.server.osgi.AggregatedNetconfOperationServiceFactory; import org.osgi.framework.FrameworkUtil; import org.osgi.service.component.ComponentFactory; import org.osgi.service.component.ComponentInstance; diff --git a/netconf/tools/netconf-testtool/pom.xml b/netconf/tools/netconf-testtool/pom.xml index 3a6341917c..56a9d7a74c 100644 --- a/netconf/tools/netconf-testtool/pom.xml +++ b/netconf/tools/netconf-testtool/pom.xml @@ -89,6 +89,10 @@ ${project.groupId} netconf-client + + ${project.groupId} + netconf-server + com.guicedee.services javax.inject @@ -98,10 +102,6 @@ org.opendaylight.mdsal.binding.model.ietf rfc6991 - - ${project.groupId} - netconf-impl - ${project.groupId} netconf-mapping-api diff --git a/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/MdsalOperationProvider.java b/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/MdsalOperationProvider.java index 3685f2172b..b60acee256 100644 --- a/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/MdsalOperationProvider.java +++ b/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/MdsalOperationProvider.java @@ -23,7 +23,6 @@ import org.opendaylight.mdsal.dom.spi.store.DOMStore; import org.opendaylight.mdsal.dom.store.inmemory.InMemoryDOMDataStoreFactory; import org.opendaylight.netconf.api.capability.Capability; import org.opendaylight.netconf.api.monitoring.CapabilityListener; -import org.opendaylight.netconf.impl.SessionIdProvider; import org.opendaylight.netconf.mapping.api.NetconfOperation; import org.opendaylight.netconf.mapping.api.NetconfOperationService; import org.opendaylight.netconf.mapping.api.NetconfOperationServiceFactory; @@ -36,6 +35,7 @@ import org.opendaylight.netconf.mdsal.connector.ops.Lock; import org.opendaylight.netconf.mdsal.connector.ops.Unlock; import org.opendaylight.netconf.mdsal.connector.ops.get.Get; import org.opendaylight.netconf.mdsal.connector.ops.get.GetConfig; +import org.opendaylight.netconf.server.SessionIdProvider; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.netconf.monitoring.rev101004.NetconfState; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.netconf.monitoring.rev101004.Yang; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.netconf.monitoring.rev101004.netconf.state.Schemas; diff --git a/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/NetconfDeviceSimulator.java b/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/NetconfDeviceSimulator.java index 973426bc5c..b1136c83e4 100644 --- a/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/NetconfDeviceSimulator.java +++ b/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/NetconfDeviceSimulator.java @@ -38,13 +38,13 @@ import org.opendaylight.netconf.api.capability.BasicCapability; import org.opendaylight.netconf.api.capability.Capability; import org.opendaylight.netconf.api.capability.YangModuleCapability; import org.opendaylight.netconf.api.monitoring.NetconfMonitoringService; -import org.opendaylight.netconf.impl.DefaultSessionIdProvider; -import org.opendaylight.netconf.impl.NetconfServerDispatcherImpl; -import org.opendaylight.netconf.impl.NetconfServerSessionNegotiatorFactory; -import org.opendaylight.netconf.impl.ServerChannelInitializer; -import org.opendaylight.netconf.impl.SessionIdProvider; -import org.opendaylight.netconf.impl.osgi.AggregatedNetconfOperationServiceFactory; import org.opendaylight.netconf.mapping.api.NetconfOperationServiceFactory; +import org.opendaylight.netconf.server.DefaultSessionIdProvider; +import org.opendaylight.netconf.server.NetconfServerDispatcherImpl; +import org.opendaylight.netconf.server.NetconfServerSessionNegotiatorFactory; +import org.opendaylight.netconf.server.ServerChannelInitializer; +import org.opendaylight.netconf.server.SessionIdProvider; +import org.opendaylight.netconf.server.osgi.AggregatedNetconfOperationServiceFactory; import org.opendaylight.netconf.shaded.sshd.common.keyprovider.KeyPairProvider; import org.opendaylight.netconf.shaded.sshd.common.util.threads.ThreadUtils; import org.opendaylight.netconf.ssh.SshProxyServer; diff --git a/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/SimulatedOperationProvider.java b/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/SimulatedOperationProvider.java index 38aabec19f..4988a24d11 100644 --- a/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/SimulatedOperationProvider.java +++ b/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/SimulatedOperationProvider.java @@ -13,10 +13,10 @@ import java.util.Optional; import java.util.Set; import org.opendaylight.netconf.api.capability.Capability; import org.opendaylight.netconf.api.monitoring.CapabilityListener; -import org.opendaylight.netconf.impl.SessionIdProvider; import org.opendaylight.netconf.mapping.api.NetconfOperation; import org.opendaylight.netconf.mapping.api.NetconfOperationService; import org.opendaylight.netconf.mapping.api.NetconfOperationServiceFactory; +import org.opendaylight.netconf.server.SessionIdProvider; import org.opendaylight.netconf.test.tool.rpc.DataList; import org.opendaylight.netconf.test.tool.rpc.SimulatedCommit; import org.opendaylight.netconf.test.tool.rpc.SimulatedCreateSubscription; diff --git a/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/TesttoolNegotiationFactory.java b/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/TesttoolNegotiationFactory.java index d7b2902c29..b6abfe25ea 100644 --- a/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/TesttoolNegotiationFactory.java +++ b/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/TesttoolNegotiationFactory.java @@ -14,10 +14,10 @@ import java.util.HashMap; import java.util.Map; import java.util.Set; import org.opendaylight.netconf.api.monitoring.NetconfMonitoringService; -import org.opendaylight.netconf.impl.NetconfServerSessionNegotiatorFactory; -import org.opendaylight.netconf.impl.SessionIdProvider; import org.opendaylight.netconf.mapping.api.NetconfOperationService; import org.opendaylight.netconf.mapping.api.NetconfOperationServiceFactory; +import org.opendaylight.netconf.server.NetconfServerSessionNegotiatorFactory; +import org.opendaylight.netconf.server.SessionIdProvider; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/operations/DefaultOperationsCreator.java b/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/operations/DefaultOperationsCreator.java index ec27852a15..8833ff8d9b 100644 --- a/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/operations/DefaultOperationsCreator.java +++ b/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/operations/DefaultOperationsCreator.java @@ -11,9 +11,9 @@ import com.google.common.collect.Sets; import java.util.Optional; import java.util.Set; import org.opendaylight.netconf.api.capability.Capability; -import org.opendaylight.netconf.impl.SessionIdProvider; import org.opendaylight.netconf.mapping.api.NetconfOperation; import org.opendaylight.netconf.mapping.api.NetconfOperationService; +import org.opendaylight.netconf.server.SessionIdProvider; import org.opendaylight.netconf.test.tool.rpc.DataList; import org.opendaylight.netconf.test.tool.rpc.SimulatedCommit; import org.opendaylight.netconf.test.tool.rpc.SimulatedCreateSubscription; diff --git a/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/operations/OperationsCreator.java b/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/operations/OperationsCreator.java index ba8d02e1a6..e9d441d6b7 100644 --- a/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/operations/OperationsCreator.java +++ b/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/operations/OperationsCreator.java @@ -9,8 +9,8 @@ package org.opendaylight.netconf.test.tool.operations; import java.util.Set; import org.opendaylight.netconf.api.capability.Capability; -import org.opendaylight.netconf.impl.SessionIdProvider; import org.opendaylight.netconf.mapping.api.NetconfOperationService; +import org.opendaylight.netconf.server.SessionIdProvider; /** * Creator which enables testtool users to inject own. implementation of {@link NetconfOperationService} diff --git a/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/operations/OperationsProvider.java b/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/operations/OperationsProvider.java index 6e56e3d5f0..0955c3ddab 100644 --- a/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/operations/OperationsProvider.java +++ b/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/operations/OperationsProvider.java @@ -10,9 +10,9 @@ package org.opendaylight.netconf.test.tool.operations; import java.util.Set; import org.opendaylight.netconf.api.capability.Capability; import org.opendaylight.netconf.api.monitoring.CapabilityListener; -import org.opendaylight.netconf.impl.SessionIdProvider; import org.opendaylight.netconf.mapping.api.NetconfOperationService; import org.opendaylight.netconf.mapping.api.NetconfOperationServiceFactory; +import org.opendaylight.netconf.server.SessionIdProvider; import org.opendaylight.yangtools.concepts.Registration; diff --git a/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/rpc/SimulatedCreateSubscription.java b/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/rpc/SimulatedCreateSubscription.java index c6932349e0..b354dcd100 100644 --- a/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/rpc/SimulatedCreateSubscription.java +++ b/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/rpc/SimulatedCreateSubscription.java @@ -27,16 +27,16 @@ import org.opendaylight.netconf.api.NetconfMessage; import org.opendaylight.netconf.api.xml.XmlElement; import org.opendaylight.netconf.api.xml.XmlNetconfConstants; import org.opendaylight.netconf.api.xml.XmlUtil; -import org.opendaylight.netconf.impl.NetconfServerSession; -import org.opendaylight.netconf.impl.mapping.operations.DefaultNetconfOperation; +import org.opendaylight.netconf.server.NetconfServerSession; +import org.opendaylight.netconf.server.mapping.operations.DefaultNetconfOperation; import org.opendaylight.netconf.util.mapping.AbstractLastNetconfOperation; import org.w3c.dom.Document; import org.w3c.dom.Element; import org.xml.sax.SAXException; public class SimulatedCreateSubscription extends AbstractLastNetconfOperation implements DefaultNetconfOperation { - private final Map notifications; + private NetconfServerSession session; private ScheduledExecutorService scheduledExecutorService; diff --git a/plugins/sal-netconf-connector/pom.xml b/plugins/sal-netconf-connector/pom.xml index 9bc3e519e0..284d0ef199 100644 --- a/plugins/sal-netconf-connector/pom.xml +++ b/plugins/sal-netconf-connector/pom.xml @@ -113,7 +113,7 @@ ${project.groupId} - netconf-impl + netconf-server test diff --git a/protocol/netconf-impl/pom.xml b/protocol/netconf-server/pom.xml similarity index 76% rename from protocol/netconf-impl/pom.xml rename to protocol/netconf-server/pom.xml index da8f768931..28acf944e9 100644 --- a/protocol/netconf-impl/pom.xml +++ b/protocol/netconf-server/pom.xml @@ -16,7 +16,7 @@ ../../parent - netconf-impl + netconf-server ${project.artifactId} bundle @@ -90,39 +90,4 @@ test - - - - - org.apache.felix - maven-bundle-plugin - - - org.opendaylight.netconf.impl.* - - - - - maven-jar-plugin - - - - test-jar - - - - - - maven-source-plugin - - - - test-jar-no-fork - - - - - - - diff --git a/protocol/netconf-impl/src/main/java/org/opendaylight/netconf/impl/DefaultSessionIdProvider.java b/protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/DefaultSessionIdProvider.java similarity index 96% rename from protocol/netconf-impl/src/main/java/org/opendaylight/netconf/impl/DefaultSessionIdProvider.java rename to protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/DefaultSessionIdProvider.java index ad0ddf8938..29badad0eb 100644 --- a/protocol/netconf-impl/src/main/java/org/opendaylight/netconf/impl/DefaultSessionIdProvider.java +++ b/protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/DefaultSessionIdProvider.java @@ -5,7 +5,7 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ -package org.opendaylight.netconf.impl; +package org.opendaylight.netconf.server; import java.util.concurrent.atomic.AtomicLong; import javax.inject.Inject; diff --git a/protocol/netconf-impl/src/main/java/org/opendaylight/netconf/impl/NetconfServerDispatcherImpl.java b/protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/NetconfServerDispatcherImpl.java similarity index 73% rename from protocol/netconf-impl/src/main/java/org/opendaylight/netconf/impl/NetconfServerDispatcherImpl.java rename to protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/NetconfServerDispatcherImpl.java index e740655069..70a2c91cb1 100644 --- a/protocol/netconf-impl/src/main/java/org/opendaylight/netconf/impl/NetconfServerDispatcherImpl.java +++ b/protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/NetconfServerDispatcherImpl.java @@ -5,7 +5,7 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ -package org.opendaylight.netconf.impl; +package org.opendaylight.netconf.server; import io.netty.channel.ChannelFuture; import io.netty.channel.EventLoopGroup; @@ -17,22 +17,21 @@ import org.opendaylight.netconf.nettyutil.AbstractNetconfDispatcher; public class NetconfServerDispatcherImpl extends AbstractNetconfDispatcher implements NetconfServerDispatcher { - private final ServerChannelInitializer initializer; - public NetconfServerDispatcherImpl(ServerChannelInitializer serverChannelInitializer, EventLoopGroup bossGroup, - EventLoopGroup workerGroup) { + public NetconfServerDispatcherImpl(final ServerChannelInitializer serverChannelInitializer, + final EventLoopGroup bossGroup, final EventLoopGroup workerGroup) { super(bossGroup, workerGroup); - this.initializer = serverChannelInitializer; + initializer = serverChannelInitializer; } @Override - public ChannelFuture createServer(InetSocketAddress address) { + public ChannelFuture createServer(final InetSocketAddress address) { return super.createServer(address, initializer::initialize); } @Override - public ChannelFuture createLocalServer(LocalAddress address) { + public ChannelFuture createLocalServer(final LocalAddress address) { return super.createServer(address, LocalServerChannel.class, initializer::initialize); } } diff --git a/protocol/netconf-impl/src/main/java/org/opendaylight/netconf/impl/NetconfServerSession.java b/protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/NetconfServerSession.java similarity index 96% rename from protocol/netconf-impl/src/main/java/org/opendaylight/netconf/impl/NetconfServerSession.java rename to protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/NetconfServerSession.java index dd2961193d..f9a933951d 100644 --- a/protocol/netconf-impl/src/main/java/org/opendaylight/netconf/impl/NetconfServerSession.java +++ b/protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/NetconfServerSession.java @@ -5,7 +5,7 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ -package org.opendaylight.netconf.impl; +package org.opendaylight.netconf.server; import static com.google.common.base.Preconditions.checkState; import static com.google.common.base.Verify.verify; @@ -48,19 +48,15 @@ import org.slf4j.LoggerFactory; public final class NetconfServerSession extends AbstractNetconfSession implements NetconfManagementSession { - private static final Logger LOG = LoggerFactory.getLogger(NetconfServerSession.class); private static final DateTimeFormatter DATE_FORMATTER = DateTimeFormatter.ISO_OFFSET_DATE_TIME; - - private static final String DATE_TIME_PATTERN_STRING; + private static final Pattern DATE_TIME_PATTERN; static { verify(DateAndTime.PATTERN_CONSTANTS.size() == 1); - DATE_TIME_PATTERN_STRING = DateAndTime.PATTERN_CONSTANTS.get(0); + DATE_TIME_PATTERN = Pattern.compile(DateAndTime.PATTERN_CONSTANTS.get(0)); } - private static final Pattern DATE_TIME_PATTERN = Pattern.compile(DATE_TIME_PATTERN_STRING); - private final NetconfHelloMessageAdditionalHeader header; private final NetconfServerSessionListener sessionListener; diff --git a/protocol/netconf-impl/src/main/java/org/opendaylight/netconf/impl/NetconfServerSessionListener.java b/protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/NetconfServerSessionListener.java similarity index 97% rename from protocol/netconf-impl/src/main/java/org/opendaylight/netconf/impl/NetconfServerSessionListener.java rename to protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/NetconfServerSessionListener.java index 141edb98d3..4fe0d1aa2e 100644 --- a/protocol/netconf-impl/src/main/java/org/opendaylight/netconf/impl/NetconfServerSessionListener.java +++ b/protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/NetconfServerSessionListener.java @@ -5,7 +5,7 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ -package org.opendaylight.netconf.impl; +package org.opendaylight.netconf.server; import com.google.common.base.Preconditions; import com.google.common.collect.ImmutableMap; @@ -18,8 +18,8 @@ import org.opendaylight.netconf.api.monitoring.SessionEvent; import org.opendaylight.netconf.api.monitoring.SessionListener; import org.opendaylight.netconf.api.xml.XmlNetconfConstants; import org.opendaylight.netconf.api.xml.XmlUtil; -import org.opendaylight.netconf.impl.osgi.NetconfOperationRouter; import org.opendaylight.netconf.notifications.NetconfNotification; +import org.opendaylight.netconf.server.osgi.NetconfOperationRouter; import org.opendaylight.netconf.util.messages.SubtreeFilter; import org.opendaylight.yangtools.yang.common.ErrorSeverity; import org.opendaylight.yangtools.yang.common.ErrorTag; @@ -31,8 +31,8 @@ import org.w3c.dom.NamedNodeMap; import org.w3c.dom.Node; public class NetconfServerSessionListener implements NetconfSessionListener { - private static final Logger LOG = LoggerFactory.getLogger(NetconfServerSessionListener.class); + private final SessionListener monitoringSessionListener; private final NetconfOperationRouter operationRouter; private final AutoCloseable onSessionDownCloseable; @@ -41,7 +41,7 @@ public class NetconfServerSessionListener implements NetconfSessionListener