From 6171c2a379f5397ce23f2ec1a570d05812ae918b Mon Sep 17 00:00:00 2001 From: Michal Polkorab Date: Thu, 23 Oct 2014 12:33:30 +0200 Subject: [PATCH] Bug 2245 - Fixed 'Hide Utility Class Constructor' - also fixed 'Method Type(Generic) Parameter Name' Change-Id: I4323326dba8a371c65a5d9c1bfeefe867dbcbd4e Signed-off-by: Michal Polkorab --- .../protocol/api/extensibility/DeserializerRegistry.java | 4 ++-- .../api/extensibility/SerializerExtensionProvider.java | 4 ++-- .../protocol/api/extensibility/SerializerRegistry.java | 8 ++++---- .../openflowjava/protocol/impl/core/SslKeyStore.java | 4 ++++ .../openflowjava/protocol/impl/core/UdpConnectionMap.java | 6 +++++- .../deserialization/ActionDeserializerInitializer.java | 6 +++++- .../impl/deserialization/DeserializerRegistryImpl.java | 2 +- .../InstructionDeserializerInitializer.java | 6 +++++- .../MatchEntryDeserializerInitializer.java | 6 +++++- ...itializer.java => MessageDeserializerInitializer.java} | 6 +++++- .../impl/deserialization/TypeToClassMapInitializer.java | 6 +++++- .../impl/deserialization/match/OxmMaskDeserializer.java | 6 +++++- .../protocol/impl/serialization/ActionsInitializer.java | 6 +++++- .../impl/serialization/InstructionsInitializer.java | 6 +++++- .../impl/serialization/MatchEntriesInitializer.java | 6 +++++- .../impl/serialization/MessageFactoryInitializer.java | 6 +++++- .../openflowjava/protocol/impl/util/ActionConstants.java | 5 ++++- .../protocol/impl/util/InstructionConstants.java | 6 +++++- .../openflowjava/protocol/impl/util/ListDeserializer.java | 6 +++++- .../protocol/impl/clients/ClientSslContextFactory.java | 5 ++++- .../protocol/impl/clients/ClientSslKeyStore.java | 4 ++++ .../protocol/impl/clients/ClientSslTrustStore.java | 4 ++++ .../protocol/impl/clients/ScenarioFactory.java | 6 +++++- 23 files changed, 99 insertions(+), 25 deletions(-) rename openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/{MessageDerializerInitializer.java => MessageDeserializerInitializer.java} (96%) diff --git a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/DeserializerRegistry.java b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/DeserializerRegistry.java index 26ac8c8b..eeeac0a4 100644 --- a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/DeserializerRegistry.java +++ b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/DeserializerRegistry.java @@ -23,8 +23,8 @@ public interface DeserializerRegistry { * @param key used for deserializer lookup * @return deserializer found */ - public - SERIALIZER_TYPE getDeserializer(MessageCodeKey key); + public + SERIALIZERTYPE getDeserializer(MessageCodeKey key); /** * Registers deserializer. diff --git a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/SerializerExtensionProvider.java b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/SerializerExtensionProvider.java index 422a1500..9bbc85c3 100644 --- a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/SerializerExtensionProvider.java +++ b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/SerializerExtensionProvider.java @@ -63,8 +63,8 @@ public interface SerializerExtensionProvider { * @param key used for serializer lookup * @param serializer serializer implementation */ - public void registerMatchEntrySerializer( - MatchEntrySerializerKey key,OFGeneralSerializer serializer); + public void registerMatchEntrySerializer( + MatchEntrySerializerKey key,OFGeneralSerializer serializer); /** * Registers experimenter (vendor) message serializer diff --git a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/SerializerRegistry.java b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/SerializerRegistry.java index 388338e2..a53faa5c 100644 --- a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/SerializerRegistry.java +++ b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/SerializerRegistry.java @@ -26,8 +26,8 @@ public interface SerializerRegistry { * @param msgTypeKey lookup key * @return serializer or NullPointerException if no serializer was found */ - public SERIALIZER_TYPE - getSerializer(MessageTypeKey msgTypeKey); + public SERIALIZERTYPE + getSerializer(MessageTypeKey msgTypeKey); /** * Registers serializer @@ -40,7 +40,7 @@ public interface SerializerRegistry { * @param key used for serializer lookup * @param serializer serializer implementation */ - public void registerSerializer(MessageTypeKey key, + public void registerSerializer(MessageTypeKey key, OFGeneralSerializer serializer); /** @@ -50,5 +50,5 @@ public interface SerializerRegistry { * @return true if serializer was removed, * false if no serializer was found under specified key */ - public boolean unregisterSerializer(MessageTypeKey key); + public boolean unregisterSerializer(MessageTypeKey key); } diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/SslKeyStore.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/SslKeyStore.java index 25c2e0b2..983a03e9 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/SslKeyStore.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/SslKeyStore.java @@ -26,6 +26,10 @@ public final class SslKeyStore { private static final Logger LOGGER = LoggerFactory.getLogger(SslKeyStore.class); + private SslKeyStore() { + throw new UnsupportedOperationException("Utility class shouldn't be instantiated"); + } + /** * InputStream instance of key - key location is on classpath * @param filename keystore location diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/UdpConnectionMap.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/UdpConnectionMap.java index 3c048f67..aeb73056 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/UdpConnectionMap.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/UdpConnectionMap.java @@ -20,10 +20,14 @@ import org.opendaylight.openflowjava.protocol.impl.connection.MessageConsumer; * @author michal.polkorab */ -public class UdpConnectionMap { +public final class UdpConnectionMap { private static Map connectionMap = new HashMap<>(); + private UdpConnectionMap() { + throw new UnsupportedOperationException("Utility class shouldn't be instantiated"); + } + /** * @param address sender's address * @return corresponding MessageConsumer diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/ActionDeserializerInitializer.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/ActionDeserializerInitializer.java index e641ee93..cbec7394 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/ActionDeserializerInitializer.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/ActionDeserializerInitializer.java @@ -44,7 +44,11 @@ import org.opendaylight.openflowjava.protocol.impl.util.ActionDeserializerRegist * @author michal.polkorab * */ -public class ActionDeserializerInitializer { +public final class ActionDeserializerInitializer { + + private ActionDeserializerInitializer() { + throw new UnsupportedOperationException("Utility class shouldn't be instantiated"); + } /** * Registers action deserializers diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/DeserializerRegistryImpl.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/DeserializerRegistryImpl.java index f36b684f..5c7ad39c 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/DeserializerRegistryImpl.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/DeserializerRegistryImpl.java @@ -39,7 +39,7 @@ public class DeserializerRegistryImpl implements DeserializerRegistry { public void init() { registry = new HashMap<>(); // register message deserializers - MessageDerializerInitializer.registerMessageDeserializers(this); + MessageDeserializerInitializer.registerMessageDeserializers(this); // register common structure deserializers registerDeserializer(new MessageCodeKey(EncodeConstants.OF10_VERSION_ID, diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/InstructionDeserializerInitializer.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/InstructionDeserializerInitializer.java index a09f5147..9fcfd4d6 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/InstructionDeserializerInitializer.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/InstructionDeserializerInitializer.java @@ -22,7 +22,11 @@ import org.opendaylight.openflowjava.protocol.impl.util.InstructionDeserializerR * @author michal.polkorab * */ -public class InstructionDeserializerInitializer { +public final class InstructionDeserializerInitializer { + + private InstructionDeserializerInitializer() { + throw new UnsupportedOperationException("Utility class shouldn't be instantiated"); + } /** * Registers instruction deserializers diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/MatchEntryDeserializerInitializer.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/MatchEntryDeserializerInitializer.java index fe15b917..28f87a4c 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/MatchEntryDeserializerInitializer.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/MatchEntryDeserializerInitializer.java @@ -59,7 +59,11 @@ import org.opendaylight.openflowjava.protocol.api.util.OxmMatchConstants; * @author michal.polkorab * */ -public class MatchEntryDeserializerInitializer { +public final class MatchEntryDeserializerInitializer { + + private MatchEntryDeserializerInitializer() { + throw new UnsupportedOperationException("Utility class shouldn't be instantiated"); + } /** * Registers match entry deserializers diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/MessageDerializerInitializer.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/MessageDeserializerInitializer.java similarity index 96% rename from openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/MessageDerializerInitializer.java rename to openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/MessageDeserializerInitializer.java index e45da36f..525f5297 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/MessageDerializerInitializer.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/MessageDeserializerInitializer.java @@ -55,7 +55,11 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731 * @author michal.polkorab * */ -public class MessageDerializerInitializer { +public final class MessageDeserializerInitializer { + + private MessageDeserializerInitializer() { + throw new UnsupportedOperationException("Utility class shouldn't be instantiated"); + } /** * Registers message deserializers diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/TypeToClassMapInitializer.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/TypeToClassMapInitializer.java index 017e2454..213723c1 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/TypeToClassMapInitializer.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/TypeToClassMapInitializer.java @@ -31,7 +31,11 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731 * @author michal.polkorab * */ -public class TypeToClassMapInitializer { +public final class TypeToClassMapInitializer { + + private TypeToClassMapInitializer() { + throw new UnsupportedOperationException("Utility class shouldn't be instantiated"); + } /** * Initializes type to class map diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/match/OxmMaskDeserializer.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/match/OxmMaskDeserializer.java index d4246fd2..728d42fa 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/match/OxmMaskDeserializer.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/match/OxmMaskDeserializer.java @@ -17,7 +17,11 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.oxm.rev130731.oxm. * @author michal.polkorab * */ -public class OxmMaskDeserializer { +public final class OxmMaskDeserializer { + + private OxmMaskDeserializer() { + throw new UnsupportedOperationException("Utility class shouldn't be instantiated"); + } /** * Appends mask to match entry (match entry builder) diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/ActionsInitializer.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/ActionsInitializer.java index 818a842b..d3e74b5c 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/ActionsInitializer.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/ActionsInitializer.java @@ -70,7 +70,11 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.common.action.rev1 * Initializes serializer registry with action serializers * @author michal.polkorab */ -public class ActionsInitializer { +public final class ActionsInitializer { + + private ActionsInitializer() { + throw new UnsupportedOperationException("Utility class shouldn't be instantiated"); + } /** * Registers action serializers into provided registry diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/InstructionsInitializer.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/InstructionsInitializer.java index 09bfe0ce..f60898ed 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/InstructionsInitializer.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/InstructionsInitializer.java @@ -28,7 +28,11 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.common.instruction * @author michal.polkorab * */ -public class InstructionsInitializer { +public final class InstructionsInitializer { + + private InstructionsInitializer() { + throw new UnsupportedOperationException("Utility class shouldn't be instantiated"); + } /** * Registers instruction serializers into provided registry diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/MatchEntriesInitializer.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/MatchEntriesInitializer.java index 50827a77..4889fcbd 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/MatchEntriesInitializer.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/MatchEntriesInitializer.java @@ -103,7 +103,11 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.oxm.rev130731.Vlan * Initializes serializer registry with match entry serializers * @author michal.polkorab */ -public class MatchEntriesInitializer { +public final class MatchEntriesInitializer { + + private MatchEntriesInitializer() { + throw new UnsupportedOperationException("Utility class shouldn't be instantiated"); + } /** * Registers match entry serializers into provided registry diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/MessageFactoryInitializer.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/MessageFactoryInitializer.java index 094b4fde..70db90be 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/MessageFactoryInitializer.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/MessageFactoryInitializer.java @@ -60,7 +60,11 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731 * @author michal.polkorab * */ -public class MessageFactoryInitializer { +public final class MessageFactoryInitializer { + + private MessageFactoryInitializer() { + throw new UnsupportedOperationException("Utility class shouldn't be instantiated"); + } /** * Registers message serializers into provided registry diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/ActionConstants.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/ActionConstants.java index d09d2dd5..cb7b051e 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/ActionConstants.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/ActionConstants.java @@ -12,7 +12,7 @@ package org.opendaylight.openflowjava.protocol.impl.util; * @author michal.polkorab * */ -public class ActionConstants { +public final class ActionConstants { /** Openflow v1.0 & v1.3 OFPAT_OUTPUT code */ public static final byte OUTPUT_CODE = 0; @@ -101,4 +101,7 @@ public class ActionConstants { /** Action header size */ public static final byte ACTION_IDS_LENGTH = 4; + private ActionConstants() { + throw new UnsupportedOperationException("Utility class shouldn't be instantiated"); + } } diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/InstructionConstants.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/InstructionConstants.java index 8e0ae6ec..2476c4e9 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/InstructionConstants.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/InstructionConstants.java @@ -12,7 +12,7 @@ package org.opendaylight.openflowjava.protocol.impl.util; * @author michal.polkorab * */ -public class InstructionConstants { +public final class InstructionConstants { /** Openflow v1.3 OFPIT_GOTO_TABLE code */ public static final byte GOTO_TABLE_TYPE = 1; @@ -41,4 +41,8 @@ public class InstructionConstants { public static final byte WRITE_METADATA_LENGTH = 24; /** Openflow v1.3 header length (only type and length fields) */ public static final byte INSTRUCTION_IDS_LENGTH = 4; + + private InstructionConstants() { + throw new UnsupportedOperationException("Utility class shouldn't be instantiated"); + } } diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/ListDeserializer.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/ListDeserializer.java index 160f3be5..6e32f86f 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/ListDeserializer.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/ListDeserializer.java @@ -22,7 +22,11 @@ import org.opendaylight.yangtools.yang.binding.DataObject; * @author michal.polkorab * */ -public class ListDeserializer { +public final class ListDeserializer { + + private ListDeserializer() { + throw new UnsupportedOperationException("Utility class shouldn't be instantiated"); + } /** * Deserializes items into list diff --git a/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ClientSslContextFactory.java b/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ClientSslContextFactory.java index c1199c1e..a6d93aba 100644 --- a/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ClientSslContextFactory.java +++ b/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ClientSslContextFactory.java @@ -22,7 +22,10 @@ import javax.net.ssl.TrustManagerFactory; */ public final class ClientSslContextFactory { - + private ClientSslContextFactory() { + throw new UnsupportedOperationException("Utility class shouldn't be instantiated"); + } + // "TLS" - supports some version of TLS // Use "TLSv1", "TLSv1.1", "TLSv1.2" for specific TLS version private static final String PROTOCOL = "TLS"; diff --git a/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ClientSslKeyStore.java b/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ClientSslKeyStore.java index 279072fa..233b1c11 100644 --- a/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ClientSslKeyStore.java +++ b/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ClientSslKeyStore.java @@ -19,6 +19,10 @@ public final class ClientSslKeyStore { private static final String filename = "/selfSignedSwitch"; + private ClientSslKeyStore() { + throw new UnsupportedOperationException("Utility class shouldn't be instantiated"); + } + /** * InputStream instance of key * diff --git a/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ClientSslTrustStore.java b/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ClientSslTrustStore.java index 1379c8dd..c346ba1e 100644 --- a/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ClientSslTrustStore.java +++ b/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ClientSslTrustStore.java @@ -19,6 +19,10 @@ public final class ClientSslTrustStore { private static final String filename = "/selfSignedController"; + private ClientSslTrustStore() { + throw new UnsupportedOperationException("Utility class shouldn't be instantiated"); + } + /** * InputStream instance of key * diff --git a/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ScenarioFactory.java b/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ScenarioFactory.java index 318d7226..264bedfd 100644 --- a/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ScenarioFactory.java +++ b/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ScenarioFactory.java @@ -17,7 +17,11 @@ import org.opendaylight.openflowjava.util.ByteBufUtils; * * @author michal.polkorab */ -public class ScenarioFactory { +public final class ScenarioFactory { + + private ScenarioFactory() { + throw new UnsupportedOperationException("Utility class shouldn't be instantiated"); + } /** * Creates stack with handshake needed messages. -- 2.36.6