From 1aee9a9a8d8df9d3207696a98021295ae2e92ad7 Mon Sep 17 00:00:00 2001 From: Stephen Kitt Date: Tue, 6 Nov 2018 18:11:26 +0100 Subject: [PATCH] Remove redundant exception declarations This allows callers to be simplified. JIRA: OPNFLWPLUG-1045 Change-Id: I8ed5eecc20bb66c0b322ef3716612cad24bd8ff1 Signed-off-by: Stephen Kitt --- .../bulk/o/matic/BulkOMaticUtilsTest.java | 14 ++++---- .../bulk/o/matic/FlowReaderTest.java | 4 +-- .../o/matic/FlowWriterConcurrentTest.java | 6 ++-- .../o/matic/FlowWriterDirectOFRpcTest.java | 6 ++-- .../o/matic/FlowWriterSequentialTest.java | 6 ++-- .../bulk/o/matic/FlowWriterTxChainTest.java | 6 ++-- .../o/matic/SalBulkFlowServiceImplTest.java | 6 ++-- .../bulk/o/matic/TableWriterTest.java | 6 ++-- .../frm/impl/DeviceMastershipManagerTest.java | 4 +-- .../frm/impl/DeviceMastershipTest.java | 2 +- .../test/java/test/mock/FlowListenerTest.java | 10 +++--- .../java/test/mock/GroupListenerTest.java | 8 ++--- .../java/test/mock/MeterListenerTest.java | 8 ++--- .../frsync/util/SemaphoreKeeperGuavaImpl.java | 2 +- .../impl/ForwardingRulesSyncProviderTest.java | 4 +-- .../impl/SimplifiedConfigListenerTest.java | 4 +-- .../SimplifiedOperationalListenerTest.java | 6 ++-- .../impl/SyncReactorGuardDecoratorTest.java | 2 +- .../frsync/impl/SyncReactorImplTest.java | 2 +- .../DeviceMastershipManagerTest.java | 4 +-- .../impl/clustering/DeviceMastershipTest.java | 2 +- .../impl/strategy/FlowForwarderTest.java | 2 +- .../impl/strategy/GroupForwarderTest.java | 2 +- .../impl/strategy/MeterForwarderTest.java | 2 +- ...SyncPlanPushStrategyFlatBatchImplTest.java | 18 +++++----- ...ncPlanPushStrategyIncrementalImplTest.java | 2 +- .../impl/strategy/TableForwarderTest.java | 2 +- .../frsync/util/ReconcileUtilTest.java | 18 +++++----- .../util/ReconciliationRegistryTest.java | 2 +- .../util/SemaphoreKeeperGuavaImplTest.java | 2 +- .../applications/lldpspeaker/LLDPSpeaker.java | 3 +- .../applications/lldpspeaker/LLDPUtil.java | 5 ++- ...ConnectorInventoryEventTranslatorTest.java | 4 +-- .../AbstractNotificationSupplierBase.java | 2 +- .../config/DefaultConfigPusherTest.java | 2 +- .../cli/GetRegisteredServices.java | 2 +- .../impl/ReconciliationManagerImpl.java | 2 +- .../cli/GetAllNodesCommandProvider.java | 2 +- .../cli/ReconciliationCount.java | 2 +- .../cli/ShowNodeCommandProvider.java | 2 +- .../lldp/utils/LLDPDiscoveryUtils.java | 8 ++--- .../topology/lldp/LLDPLinkAgerTest.java | 2 +- .../lldp/utils/LLDPDiscoveryUtilsTest.java | 4 +-- .../manager/DataTreeChangeListenerImpl.java | 2 +- .../manager/NodeChangeListenerImpl.java | 2 +- .../TerminationPointChangeListenerImpl.java | 2 +- .../ClearDropStatsCommandProvider.java | 2 +- .../DropAllPacketsCommandProvider.java | 2 +- .../DropAllPacketsRpcCommandProvider.java | 2 +- .../droptestkaraf/DropTestProviderImpl.java | 2 +- .../ShowDropStatsCommandProvider.java | 2 +- .../NiciraExtensionCodecRegistratorImpl.java | 2 +- .../nx/NiciraExtensionsRegistrator.java | 2 +- .../nx/NiciraExtensionsRegistratorTest.java | 2 +- .../api/ConvertorMessageFromOFJava.java | 3 +- .../nicira/NiciraExtensionProviderTest.java | 6 ++-- .../action/ConntrackConvertorTest.java | 6 ++-- .../action/CtClearConvertorTest.java | 6 ++-- .../action/DecNshTtlConvertorTest.java | 2 +- .../convertor/action/DecapConvertorTest.java | 2 +- .../convertor/action/EncapConvertorTest.java | 2 +- .../action/FinTimeoutConvertorTest.java | 6 ++-- .../action/MultipathConvertorTest.java | 6 ++-- .../action/OutputReg2ConvertorTest.java | 2 +- .../action/OutputRegConvertorTest.java | 6 ++-- .../action/RegLoadConvertorTest.java | 6 ++-- .../action/RegMoveConvertorTest.java | 6 ++-- .../action/ResubmitConvertorTest.java | 6 ++-- .../convertor/match/ArpOpConvertorTest.java | 6 ++-- .../convertor/match/ArpShaConvertorTest.java | 6 ++-- .../convertor/match/ArpSpaConvertorTest.java | 6 ++-- .../convertor/match/ArpThaConvertorTest.java | 6 ++-- .../convertor/match/ArpTpaConvertorTest.java | 6 ++-- .../convertor/match/CtStateConvertorTest.java | 6 ++-- .../convertor/match/CtZoneConvertorTest.java | 6 ++-- .../convertor/match/EthDstConvertorTest.java | 6 ++-- .../convertor/match/EthSrcConvertorTest.java | 6 ++-- .../convertor/match/EthTypeConvertorTest.java | 6 ++-- .../match/NshFlagsConvertorTest.java | 2 +- .../match/NshMdtypeConvertorTest.java | 2 +- .../convertor/match/NshNpConvertorTest.java | 2 +- .../convertor/match/NshTtlConvertorTest.java | 2 +- .../convertor/match/Nshc1ConvertorTest.java | 2 +- .../convertor/match/Nshc2ConvertorTest.java | 2 +- .../convertor/match/Nshc3ConvertorTest.java | 2 +- .../convertor/match/Nshc4ConvertorTest.java | 2 +- .../convertor/match/NsiConvertorTest.java | 2 +- .../convertor/match/NspConvertorTest.java | 2 +- .../convertor/match/TcpDstConvertorTest.java | 6 ++-- .../convertor/match/TcpSrcConvertorTest.java | 6 ++-- .../match/TunIPv4DstConvertorTest.java | 6 ++-- .../match/TunIPv4SrcConvertorTest.java | 6 ++-- .../convertor/match/TunIdConvertorTest.java | 6 ++-- .../convertor/match/UdpDstConvertorTest.java | 6 ++-- .../convertor/match/UdpSrcConvertorTest.java | 6 ++-- .../converter/BundleAddMessageConverter.java | 3 +- .../onf/converter/BundleControlConverter.java | 4 +-- .../onf/OnfExtensionProviderTest.java | 4 +-- .../BundleAddMessageConverterTest.java | 2 +- .../converter/BundleControlConverterTest.java | 6 ++-- .../libraries/liblldp/LLDPTLV.java | 4 +-- .../libraries/liblldp/LLDPTLVTest.java | 2 +- .../protocol/impl/core/IdleHandler.java | 2 +- .../impl/core/OFDatagramPacketDecoder.java | 3 +- .../impl/core/OFDatagramPacketHandler.java | 4 +-- .../protocol/impl/core/OFDecoder.java | 2 +- .../protocol/impl/core/OFFrameDecoder.java | 4 +-- .../core/SwitchConnectionProviderImpl.java | 2 +- .../impl/core/UdpChannelInitializer.java | 2 +- .../protocol/impl/core/DummyDecoder.java | 2 +- .../protocol/impl/core/IdleHandlerTest.java | 4 +-- .../core/OFDatagramPacketDecoderTest.java | 2 +- .../core/OFDatagramPacketHandlerTest.java | 2 +- .../impl/core/OFDecoderStatisticsTest.java | 4 +-- .../protocol/impl/core/OFDecoderTest.java | 6 ++-- .../impl/core/OFFrameDecoderTest.java | 14 ++++---- .../impl/core/SslContextFactoryTest.java | 2 +- .../protocol/impl/core/TcpHandlerTest.java | 2 +- .../ChannelOutboundQueue02Test.java | 2 +- .../ConnectionAdapterImp02lTest.java | 2 +- .../ConnectionAdapterImpl02Test.java | 2 +- .../connection/OutboundQueueEntryTest.java | 16 ++++----- .../impl/core/connection/UdpHandlerTest.java | 3 +- .../FlowModInputMessageFactoryTest.java | 2 +- .../PortModInputMessageFactoryTest.java | 4 +-- .../BarrierReplyMessageFactoryTest.java | 2 +- .../MultipartReplyMessageFactoryTest.java | 2 +- .../it/integration/IntegrationTest.java | 2 +- .../openflowjava/util/ByteBufUtils.java | 3 +- .../openflowjava/util/ByteBufUtilsTest.java | 5 ++- ...xperimenterDeserializerKeyFactoryTest.java | 16 ++++----- .../ExperimenterSerializerKeyFactoryTest.java | 10 +++--- .../handlers/DeviceConnectedHandler.java | 2 +- .../lifecycle/ContextChainHolder.java | 2 +- .../wait/SimpleTaskRetryLooperTest.java | 2 +- .../ConfigurationServiceFactoryImpl.java | 2 +- .../impl/connection/HandshakeManagerImpl.java | 8 ++--- .../impl/device/DeviceContextImpl.java | 19 ++++------ .../impl/karaf/ClearStatsCommandProvider.java | 2 +- .../karaf/ResetEventTimesComandProvider.java | 2 +- .../ResetSessionStatsComandProvider.java | 2 +- .../karaf/ShowEventTimesComandProvider.java | 2 +- .../ShowSessionStatsCommandProvider.java | 2 +- .../impl/karaf/ShowStatsCommandProvider.java | 2 +- .../lifecycle/ContextChainHolderImpl.java | 4 +-- ...ultipartReplyExperimenterDeserializer.java | 7 +--- .../impl/services/EchoService.java | 3 +- .../impl/services/RoleService.java | 3 +- ...ltiLayerAggregateFlowMultipartService.java | 4 +-- ...ultiLayerExperimenterMultipartService.java | 20 ++++------- .../multilayer/MultiLayerFlowService.java | 3 +- .../multilayer/MultiLayerGroupService.java | 3 +- .../multilayer/MultiLayerMeterService.java | 3 +- .../MultiLayerTableMultipartService.java | 3 +- .../FlowCapableTransactionServiceImpl.java | 3 +- .../services/sal/NodeConfigServiceImpl.java | 3 +- .../sal/PacketProcessingServiceImpl.java | 3 +- .../impl/services/sal/SalPortServiceImpl.java | 3 +- .../impl/services/sal/SalRoleServiceImpl.java | 3 +- ...gleLayerAggregateFlowMultipartService.java | 4 +-- ...ngleLayerExperimenterMultipartService.java | 3 +- .../singlelayer/SingleLayerFlowService.java | 3 +- .../SingleLayerGetAsyncConfigService.java | 3 +- .../singlelayer/SingleLayerGroupService.java | 3 +- .../singlelayer/SingleLayerMeterService.java | 3 +- .../singlelayer/SingleLayerPortService.java | 3 +- .../SingleLayerSetAsyncConfigService.java | 3 +- .../SingleLayerTableMultipartService.java | 3 +- .../statistics/StatisticsPollingService.java | 2 +- .../AggregateFlowsInTableService.java | 5 ++- .../services/AllFlowsInAllTablesService.java | 3 +- .../services/AllFlowsInTableService.java | 3 +- .../services/AllGroupsStatsService.java | 3 +- .../services/AllMeterConfigStatsService.java | 3 +- .../services/AllMeterStatsService.java | 3 +- .../services/AllPortStatsService.java | 3 +- .../services/AllQueuesAllPortsService.java | 3 +- .../services/AllQueuesOnePortService.java | 3 +- .../services/FlowsInTableService.java | 3 +- .../services/GroupDescriptionService.java | 3 +- .../services/GroupFeaturesService.java | 3 +- .../services/GroupStatsService.java | 3 +- .../services/MeterFeaturesService.java | 3 +- .../services/MeterStatsService.java | 3 +- .../services/OneQueueOnePortService.java | 3 +- ...aylightFlowTableStatisticsServiceImpl.java | 3 +- .../statistics/services/PortStatsService.java | 3 +- .../StatisticsGatheringOnTheFlyService.java | 3 +- .../dedicated/StatisticsGatheringService.java | 3 +- .../FlowDirectStatisticsService.java | 3 +- .../GroupDirectStatisticsService.java | 3 +- .../MeterDirectStatisticsService.java | 3 +- .../PortDirectStatisticsService.java | 3 +- .../QueueDirectStatisticsService.java | 3 +- .../impl/OpenFlowPluginProviderImplTest.java | 4 +-- .../MultipartReplyTranslatorUtilTest.java | 2 +- .../MultipartRequestInputFactoryTest.java | 36 +++++++++---------- .../ConfigurationServiceFactoryImplTest.java | 8 ++--- .../OpenFlowProviderConfigImplTest.java | 36 +++++++++---------- .../connection/ConnectionContextImplTest.java | 14 ++++---- .../ErrorHandlerSimpleImplTest.java | 2 +- .../connection/HandshakeManagerImplTest.java | 36 +++++++++---------- .../OutboundQueueProviderImplTest.java | 2 +- .../listener/HandshakeListenerImplTest.java | 10 +++--- ...enflowProtocolListenerInitialImplTest.java | 8 ++--- .../SystemNotificationsListenerImplTest.java | 10 +++--- .../impl/device/DeviceContextImplTest.java | 18 +++++----- .../impl/device/DeviceManagerImplTest.java | 8 ++--- .../impl/device/PacketInRateLimiterTest.java | 14 ++++---- .../impl/device/SwitchFeaturesUtilTest.java | 4 +-- .../device/TransactionChainManagerTest.java | 26 +++++++------- .../DeviceInitializerProviderTest.java | 6 ++-- .../OF10DeviceInitializerTest.java | 2 +- .../OF13DeviceInitializerTest.java | 2 +- .../karaf/ShowStatsCommandProviderTest.java | 2 +- .../lifecycle/ContextChainHolderImplTest.java | 12 +++---- .../impl/lifecycle/ContextChainImplTest.java | 14 ++++---- ...astershipChangeServiceManagerImplTest.java | 12 +++---- .../MastershipServiceDelegateTest.java | 8 ++--- .../AbstractDeserializerTest.java | 4 +-- .../MessageDeserializerInjectorTest.java | 4 +-- .../CopyTtlInActionDeserializerTest.java | 2 +- .../CopyTtlOutActionDeserializerTest.java | 2 +- .../DecMplsTtlActionDeserializerTest.java | 2 +- .../DecNwTtlActionDeserializerTest.java | 2 +- .../action/GroupActionDeserializerTest.java | 2 +- .../action/OutputActionDeserializerTest.java | 2 +- .../action/PopMplsActionDeserializerTest.java | 2 +- .../action/PopPbbActionDeserializerTest.java | 2 +- .../action/PopVlanActionDeserializerTest.java | 2 +- .../PushMplsActionDeserializerTest.java | 2 +- .../action/PushPbbActionDeserializerTest.java | 2 +- .../PushVlanActionDeserializerTest.java | 2 +- .../SetFieldActionDeserializerTest.java | 2 +- .../SetMplsTtlActionDeserializerTest.java | 2 +- .../SetNwTtlActionDeserializerTest.java | 2 +- .../SetQueueActionDeserializerTest.java | 2 +- ...plyActionsInstructionDeserializerTest.java | 2 +- ...earActionsInstructionDeserializerTest.java | 2 +- .../GoToTableInstructionDeserializerTest.java | 2 +- .../MeterInstructionDeserializerTest.java | 2 +- ...iteActionsInstructionDeserializerTest.java | 2 +- ...teMetadataInstructionDeserializerTest.java | 2 +- .../match/ArpOpEntryDeserializerTest.java | 2 +- ...eHardwareAddressEntryDeserializerTest.java | 2 +- ...TransportAddressEntryDeserializerTest.java | 2 +- ...tHardwareAddressEntryDeserializerTest.java | 2 +- ...TransportAddressEntryDeserializerTest.java | 2 +- ...ernetDestinationEntryDeserializerTest.java | 2 +- .../EthernetSourceEntryDeserializerTest.java | 2 +- .../EthernetTypeEntryDeserializerTest.java | 2 +- .../Icmpv4CodeEntryDeserializerTest.java | 2 +- .../Icmpv4TypeEntryDeserializerTest.java | 2 +- .../Icmpv6CodeEntryDeserializerTest.java | 2 +- .../Icmpv6TypeEntryDeserializerTest.java | 2 +- .../match/InPhyPortEntryDeserializerTest.java | 2 +- .../match/InPortEntryDeserializerTest.java | 2 +- .../match/IpDscpEntryDeserializerTest.java | 2 +- .../match/IpEcnEntryDeserializerTest.java | 2 +- .../match/IpProtoEntryDeserializerTest.java | 2 +- .../Ipv4DestinationEntryDeserializerTest.java | 2 +- .../Ipv4SourceEntryDeserializerTest.java | 2 +- .../Ipv6DestinationEntryDeserializerTest.java | 2 +- .../Ipv6ExtHeaderEntryDeserializerTest.java | 2 +- .../Ipv6FlabelEntryDeserializerTest.java | 2 +- .../match/Ipv6NdSllEntryDeserializerTest.java | 2 +- .../Ipv6NdTargetEntryDeserializerTest.java | 2 +- .../match/Ipv6NdTllEntryDeserializerTest.java | 2 +- .../Ipv6SourceEntryDeserializerTest.java | 2 +- .../match/MetadataEntryDeserializerTest.java | 2 +- .../match/MplsBosEntryDeserializerTest.java | 2 +- .../match/MplsLabelEntryDeserializerTest.java | 2 +- .../match/MplsTcEntryDeserializerTest.java | 2 +- .../match/PbbEntryDeserializerTest.java | 2 +- ...pDestinationPortEntryDeserializerTest.java | 2 +- .../SctpSourcePortEntryDeserializerTest.java | 2 +- ...pDestinationPortEntryDeserializerTest.java | 2 +- .../match/TcpFlagsEntryDeserializerTest.java | 2 +- .../TcpSourcePortEntryDeserializerTest.java | 2 +- .../match/TunnelIdEntryDeserializerTest.java | 2 +- ...pDestinationPortEntryDeserializerTest.java | 2 +- .../UdpSourcePortEntryDeserializerTest.java | 2 +- .../match/VlanPcpEntryDeserializerTest.java | 2 +- .../match/VlanVidEntryDeserializerTest.java | 2 +- .../messages/FlowMessageDeserializerTest.java | 2 +- .../GroupMessageDeserializerTest.java | 2 +- .../MeterMessageDeserializerTest.java | 2 +- .../PacketInMessageDeserializerTest.java | 2 +- .../messages/PortMessageDeserializerTest.java | 2 +- .../MultipartReplyDescDeserializerTest.java | 2 +- ...plyFlowAggregateStatsDeserializerTest.java | 2 +- ...ltipartReplyFlowStatsDeserializerTest.java | 2 +- ...rtReplyFlowTableStatsDeserializerTest.java | 2 +- ...ltipartReplyGroupDescDeserializerTest.java | 2 +- ...artReplyGroupFeaturesDeserializerTest.java | 2 +- ...tipartReplyGroupStatsDeserializerTest.java | 2 +- ...MultipartReplyMessageDeserializerTest.java | 2 +- ...ipartReplyMeterConfigDeserializerTest.java | 4 +-- ...artReplyMeterFeaturesDeserializerTest.java | 2 +- ...tipartReplyMeterStatsDeserializerTest.java | 2 +- ...ultipartReplyPortDescDeserializerTest.java | 2 +- ...ltipartReplyPortStatsDeserializerTest.java | 2 +- ...tipartReplyQueueStatsDeserializerTest.java | 2 +- ...artReplyTableFeaturesDeserializerTest.java | 2 +- ...bleFeaturesMatchFieldDeserializerTest.java | 2 +- .../serialization/AbstractSerializerTest.java | 2 +- .../ActionSerializerInjectorTest.java | 4 +-- .../InstructionSerializerInjectorTest.java | 4 +-- .../MessageSerializerInjectorTest.java | 2 +- .../CopyTtlInActionSerializerTest.java | 2 +- .../CopyTtlOutActionSerializerTest.java | 2 +- .../DecMplsTtlActionSerializerTest.java | 2 +- .../actions/DecNwTtlActionSerializerTest.java | 2 +- .../actions/GroupActionSerializerTest.java | 2 +- .../actions/OutputActionSerializerTest.java | 2 +- .../actions/PopMplsActionSerializerTest.java | 2 +- .../actions/PopPbbActionSerializerTest.java | 2 +- .../actions/PopVlanActionSerializerTest.java | 2 +- .../actions/PushMplsActionSerializerTest.java | 2 +- .../actions/PushPbbActionSerializerTest.java | 2 +- .../actions/PushVlanActionSerializerTest.java | 2 +- .../actions/SetDlDstActionSerializerTest.java | 2 +- .../actions/SetDlSrcActionSerializerTest.java | 2 +- .../SetMplsTtlActionSerializerTest.java | 2 +- .../actions/SetNwDstActionSerializerTest.java | 2 +- .../actions/SetNwSrcActionSerializerTest.java | 2 +- .../actions/SetNwTosActionSerializerTest.java | 2 +- .../actions/SetNwTtlActionSerializerTest.java | 2 +- .../actions/SetQueueActionSerializerTest.java | 2 +- .../actions/SetTpDstActionSerializerTest.java | 2 +- .../actions/SetTpSrcActionSerializerTest.java | 2 +- .../SetVlanIdActionSerializerTest.java | 2 +- .../SetVlanPcpActionSerializerTest.java | 2 +- .../StripVlanActionSerializerTest.java | 2 +- ...ApplyActionsInstructionSerializerTest.java | 2 +- ...ClearActionsInstructionSerializerTest.java | 2 +- .../GoToTableInstructionSerializerTest.java | 2 +- .../MeterInstructionSerializerTest.java | 2 +- ...WriteActionsInstructionSerializerTest.java | 2 +- ...riteMetadataInstructionSerializerTest.java | 2 +- ...tExperimenterMatchEntrySerializerTest.java | 2 +- .../AbstractMatchEntrySerializerTest.java | 2 +- .../match/ArpOpEntrySerializerTest.java | 2 +- ...rceHardwareAddressEntrySerializerTest.java | 2 +- ...ceTransportAddressEntrySerializerTest.java | 2 +- ...getHardwareAddressEntrySerializerTest.java | 2 +- ...etTransportAddressEntrySerializerTest.java | 2 +- ...thernetDestinationEntrySerializerTest.java | 2 +- .../EthernetSourceEntrySerializerTest.java | 2 +- .../EthernetTypeEntrySerializerTest.java | 2 +- .../match/Icmpv4CodeEntrySerializerTest.java | 2 +- .../match/Icmpv4TypeEntrySerializerTest.java | 2 +- .../match/Icmpv6CodeEntrySerializerTest.java | 2 +- .../match/Icmpv6TypeEntrySerializerTest.java | 2 +- .../match/InPhyPortEntrySerializerTest.java | 2 +- .../match/InPortEntrySerializerTest.java | 2 +- .../match/IpDscpEntrySerializerTest.java | 2 +- .../match/IpEcnEntrySerializerTest.java | 2 +- .../match/IpProtoEntrySerializerTest.java | 2 +- ...BitMaskDestinationEntrySerializerTest.java | 2 +- ...traryBitMaskSourceEntrySerializerTest.java | 2 +- .../Ipv4DestinationEntrySerializerTest.java | 2 +- .../match/Ipv4SourceEntrySerializerTest.java | 2 +- ...BitMaskDestinationEntrySerializerTest.java | 2 +- ...traryBitMaskSourceEntrySerializerTest.java | 2 +- .../Ipv6DestinationEntrySerializerTest.java | 4 +-- .../Ipv6ExtHeaderEntrySerializerTest.java | 2 +- .../match/Ipv6LabelEntrySerializerTest.java | 2 +- .../match/Ipv6NdSllEntrySerializerTest.java | 2 +- .../Ipv6NdTargetEntrySerializerTest.java | 2 +- .../match/Ipv6NdTllEntrySerializerTest.java | 2 +- .../match/Ipv6SourceEntrySerializerTest.java | 4 +-- .../match/MetadataEntrySerializerTest.java | 2 +- .../match/MplsBosEntrySerializerTest.java | 2 +- .../match/MplsLabelEntrySerializerTest.java | 2 +- .../match/MplsTcEntrySerializerTest.java | 2 +- .../match/PacketTypeEntrySerializerTest.java | 2 +- .../match/PbbEntrySerializerTest.java | 2 +- ...ctpDestinationPortEntrySerializerTest.java | 2 +- .../SctpSourcePortEntrySerializerTest.java | 2 +- ...TcpDestinationPortEntrySerializerTest.java | 2 +- .../match/TcpFlagsEntrySerializerTest.java | 2 +- .../TcpSourcePortEntrySerializerTest.java | 2 +- .../match/TunnelIdEntrySerializerTest.java | 2 +- ...nelIpv4DestinationEntrySerializerTest.java | 2 +- .../TunnelIpv4SourceEntrySerializerTest.java | 2 +- ...UdpDestinationPortEntrySerializerTest.java | 2 +- .../UdpSourcePortEntrySerializerTest.java | 2 +- .../match/VlanPcpEntrySerializerTest.java | 2 +- .../match/VlanVidEntrySerializerTest.java | 2 +- .../AsyncConfigMessageSerializerTest.java | 2 +- .../messages/FlowMessageSerializerTest.java | 2 +- .../messages/GroupMessageSerializerTest.java | 2 +- .../messages/MeterMessageSerializerTest.java | 2 +- .../messages/PortMessageSerializerTest.java | 2 +- .../MultipartRequestDescSerializerTest.java | 2 +- ...questFlowAggregateStatsSerializerTest.java | 2 +- ...ltipartRequestFlowStatsSerializerTest.java | 2 +- ...rtRequestFlowTableStatsSerializerTest.java | 2 +- ...ltipartRequestGroupDescSerializerTest.java | 2 +- ...artRequestGroupFeaturesSerializerTest.java | 2 +- ...tipartRequestGroupStatsSerializerTest.java | 2 +- ...MultipartRequestMessageSerializerTest.java | 2 +- ...ipartRequestMeterConfigSerializerTest.java | 2 +- ...artRequestMeterFeaturesSerializerTest.java | 2 +- ...tipartRequestMeterStatsSerializerTest.java | 2 +- ...ultipartRequestPortDescSerializerTest.java | 2 +- ...ltipartRequestPortStatsSerializerTest.java | 2 +- ...tipartRequestQueueStatsSerializerTest.java | 2 +- ...artRequestTableFeaturesSerializerTest.java | 2 +- ...ctionsMissTablePropertySerializerTest.java | 2 +- ...plyActionsTablePropertySerializerTest.java | 2 +- ...tfieldMissTablePropertySerializerTest.java | 2 +- ...lySetfieldTablePropertySerializerTest.java | 2 +- ...ctionsMissTablePropertySerializerTest.java | 2 +- ...structionsTablePropertySerializerTest.java | 2 +- .../MatchTablePropertySerializerTest.java | 2 +- ...tTableMissTablePropertySerializerTest.java | 2 +- .../NextTableTablePropertySerializerTest.java | 2 +- .../WildcardsTablePropertySerializerTest.java | 2 +- ...ctionsMissTablePropertySerializerTest.java | 2 +- ...iteActionsTablePropertySerializerTest.java | 2 +- ...tfieldMissTablePropertySerializerTest.java | 2 +- ...teSetfieldTablePropertySerializerTest.java | 2 +- .../matchfield/MatchFieldSerializerTest.java | 2 +- .../flow/DeviceFlowRegistryImplTest.java | 16 ++++----- .../registry/flow/FlowDescriptorDtoTest.java | 4 +-- .../flow/FlowRegistryKeyFactoryTest.java | 10 +++--- .../group/DeviceGroupRegistryImplTest.java | 12 +++---- .../meter/DeviceMeterRegistryImplTest.java | 12 +++---- .../impl/role/RoleContextImplTest.java | 6 ++-- .../impl/rpc/AbstractRequestContextTest.java | 2 +- .../impl/rpc/RpcContextImplTest.java | 10 +++--- .../impl/rpc/RpcManagerImplTest.java | 2 +- .../impl/services/EchoServiceTest.java | 4 +-- .../MultipartRequestCallbackTest.java | 8 ++--- .../MultipartRequestOnTheFlyCallbackTest.java | 2 +- .../impl/services/ServiceMocking.java | 4 +-- .../batch/FlatBatchFlowAdaptersTest.java | 10 +++--- .../batch/FlatBatchGroupAdaptersTest.java | 10 +++--- .../batch/FlatBatchMeterAdaptersTest.java | 10 +++--- ...FlowCapableTransactionServiceImplTest.java | 4 +-- .../sal/NodeConfigServiceImplTest.java | 4 +-- .../sal/PacketProcessingServiceImplTest.java | 4 +-- .../sal/SalAsyncConfigServiceImplTest.java | 2 +- .../sal/SalBundleServiceImplTest.java | 2 +- ...SalExperimenterMessageServiceImplTest.java | 2 +- ...lExperimenterMpMessageServiceImplTest.java | 2 +- .../sal/SalFlatBatchServiceImplTest.java | 4 +-- .../sal/SalFlowsBatchServiceImplTest.java | 4 +-- .../services/sal/SalGroupServiceImplTest.java | 12 +++---- .../sal/SalGroupsBatchServiceImplTest.java | 4 +-- .../services/sal/SalMeterServiceImplTest.java | 10 +++--- .../sal/SalMetersBatchServiceImplTest.java | 4 +-- .../services/sal/SalPortServiceImplTest.java | 4 +-- .../services/sal/SalTableServiceImplTest.java | 7 ++-- ...ayerAggregateFlowMultipartServiceTest.java | 4 +-- ...LayerExperimenterMultipartServiceTest.java | 4 +-- .../SingleLayerFlowServiceTest.java | 4 +-- .../SingleLayerGroupServiceTest.java | 4 +-- .../SingleLayerMeterServiceTest.java | 4 +-- .../SingleLayerPortServiceTest.java | 4 +-- .../SingleLayerTableMultipartServiceTest.java | 4 +-- .../services/util/RequestContextUtilTest.java | 6 ++-- .../services/util/RequestInputUtilsTest.java | 2 +- .../StatisticsContextImplParamTest.java | 2 +- .../statistics/StatisticsContextImplTest.java | 8 ++--- .../StatisticsGatheringUtilsTest.java | 6 ++-- .../statistics/StatisticsManagerImplTest.java | 2 +- .../StatisticsPollingServiceTest.java | 6 ++-- .../impl/statistics/TimeCounterTest.java | 4 +-- ...aylightFlowStatisticsServiceImpl1Test.java | 8 ++--- ...aylightFlowStatisticsServiceImpl3Test.java | 8 ++--- ...ghtFlowTableStatisticsServiceImplTest.java | 2 +- ...aylightGroupStatisticsServiceImplTest.java | 2 +- ...aylightMeterStatisticsServiceImplTest.java | 2 +- ...daylightPortStatisticsServiceImplTest.java | 2 +- ...aylightQueueStatisticsServiceImplTest.java | 2 +- .../services/PortStatsServiceTest.java | 2 +- .../AbstractCompatibleStatServiceTest.java | 2 +- ...FlowStatisticsServiceDelegateImplTest.java | 2 +- ...tatisticsGatheringOnTheFlyServiceTest.java | 4 +-- .../StatisticsGatheringServiceTest.java | 4 +-- .../AbstractDirectStatisticsServiceTest.java | 10 +++--- ...ylightDirectStatisticsServiceImplTest.java | 12 +++---- .../FlowDirectStatisticsServiceTest.java | 8 ++--- .../GroupDirectStatisticsServiceTest.java | 8 ++--- .../MeterDirectStatisticsServiceTest.java | 8 ++--- ...eConnectorDirectStatisticsServiceTest.java | 8 ++--- .../QueueDirectStatisticsServiceTest.java | 10 +++--- .../FlowDirectStatisticsServiceTest.java | 8 ++--- .../GroupDirectStatisticsServiceTest.java | 8 ++--- .../MeterDirectStatisticsServiceTest.java | 8 ++--- ...eConnectorDirectStatisticsServiceTest.java | 8 ++--- .../QueueDirectStatisticsServiceTest.java | 10 +++--- ...ggregatedFlowStatisticsTranslatorTest.java | 4 +-- .../translator/FlowRemovedTranslatorTest.java | 6 ++-- .../PacketReceivedTranslatorTest.java | 6 ++-- .../translator/PortUpdateTranslatorTest.java | 6 ++-- .../util/AddressNormalizationUtilTest.java | 18 +++++----- .../impl/util/BarrierUtilTest.java | 8 ++--- .../util/DeviceInitializationUtilTest.java | 12 +++---- .../impl/util/FlatBatchUtilTest.java | 14 ++++---- .../impl/util/FlowUtilTest.java | 24 ++++++------- .../impl/util/GroupUtilTest.java | 24 ++++++------- .../impl/util/MdSalRegistrationUtilsTest.java | 4 +-- .../impl/util/MeterUtilTest.java | 24 ++++++------- .../NodeConnectorRefToPortTranslatorTest.java | 4 +-- .../impl/util/PathUtilTest.java | 4 +-- .../sal/convertor/ConvertorManagerTest.java | 6 ++-- .../convertor/TableFeaturesConvertorTest.java | 2 +- .../common/IpConversionUtilTest.java | 2 +- .../impl/clients/SimpleClientFramer.java | 4 +-- .../impl/clients/SimpleClientHandler.java | 4 +-- .../impl/clients/SimpleClientInitializer.java | 2 +- .../impl/clients/UdpSimpleClientFramer.java | 4 +-- .../clients/UdpSimpleClientInitializer.java | 2 +- ...penflowpluginGroupTestServiceProvider.java | 2 +- ...luginTableFeaturesTestServiceProvider.java | 2 +- .../OpenflowpluginTestServiceProvider.java | 2 +- 520 files changed, 1009 insertions(+), 1090 deletions(-) diff --git a/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/BulkOMaticUtilsTest.java b/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/BulkOMaticUtilsTest.java index ae15cbab70..f640af1dbd 100644 --- a/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/BulkOMaticUtilsTest.java +++ b/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/BulkOMaticUtilsTest.java @@ -24,7 +24,7 @@ public class BulkOMaticUtilsTest { private static final String FLOW_ID = "1"; @Test - public void testIpIntToStr() throws Exception { + public void testIpIntToStr() { Assert.assertEquals("255.255.255.255/32", BulkOMaticUtils.ipIntToStr(0xffffffff)); Assert.assertEquals("255.255.255.255/32", BulkOMaticUtils.ipIntToStr(-1)); Assert.assertEquals("0.0.0.0/32", BulkOMaticUtils.ipIntToStr(0)); @@ -32,13 +32,13 @@ public class BulkOMaticUtilsTest { } @Test - public void testGetMatch() throws Exception { + public void testGetMatch() { final Match match = BulkOMaticUtils.getMatch(0xffffffff); Assert.assertNotNull(match); } @Test - public void testBuildFlow() throws Exception { + public void testBuildFlow() { final Match match = BulkOMaticUtils.getMatch(0xffffffff); final Flow flow = BulkOMaticUtils.buildFlow((short)1, FLOW_ID, match); Assert.assertEquals(FLOW_ID,flow.getId().getValue()); @@ -46,22 +46,22 @@ public class BulkOMaticUtilsTest { } @Test - public void testGetFlowInstanceIdentifier() throws Exception { + public void testGetFlowInstanceIdentifier() { Assert.assertNotNull(BulkOMaticUtils.getFlowInstanceIdentifier((short)1, "1", "1")); } @Test - public void testGetFlowCapableNodeId() throws Exception { + public void testGetFlowCapableNodeId() { Assert.assertNotNull(BulkOMaticUtils.getFlowCapableNodeId("1")); } @Test - public void testGetTableId() throws Exception { + public void testGetTableId() { Assert.assertNotNull(BulkOMaticUtils.getTableId((short)1, "1")); } @Test - public void testGetFlowId() throws Exception { + public void testGetFlowId() { Assert.assertNotNull(BulkOMaticUtils.getFlowId(BulkOMaticUtils.getTableId((short)1, "1"), "1")); } diff --git a/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/FlowReaderTest.java b/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/FlowReaderTest.java index 5e074ea5c3..a6cb8847a9 100644 --- a/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/FlowReaderTest.java +++ b/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/FlowReaderTest.java @@ -40,7 +40,7 @@ public class FlowReaderTest { private FlowReader flowReader; @Before - public void setUp() throws Exception { + public void setUp() { doReturn(FluentFutures.immediateFluentFuture(Optional.of(node))).when(readOnlyTransaction) .read(any(LogicalDatastoreType.class), any()); when(mockDataBroker.newReadOnlyTransaction()).thenReturn(readOnlyTransaction); @@ -48,7 +48,7 @@ public class FlowReaderTest { } @Test - public void testRun() throws Exception { + public void testRun() { flowReader.run(); Assert.assertEquals(10, flowReader.getFlowCount()); Assert.assertEquals(FlowCounter.OperationStatus.SUCCESS.status(), flowReader.getReadOpStatus()); diff --git a/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/FlowWriterConcurrentTest.java b/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/FlowWriterConcurrentTest.java index e4622691af..7b41b34f25 100644 --- a/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/FlowWriterConcurrentTest.java +++ b/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/FlowWriterConcurrentTest.java @@ -43,7 +43,7 @@ public class FlowWriterConcurrentTest { private FlowWriterConcurrent flowWriterConcurrent; @Before - public void setUp() throws Exception { + public void setUp() { doReturn(writeTransaction).when(mockDataBroker).newWriteOnlyTransaction(); doReturn(CommitInfo.emptyFluentFuture()).when(writeTransaction).commit(); @@ -57,7 +57,7 @@ public class FlowWriterConcurrentTest { } @Test - public void testAddFlows() throws Exception { + public void testAddFlows() { flowWriterConcurrent.addFlows(1, FLOWS_PER_DPN, 10, 10, 10, (short) 0, (short) 1, true); Mockito.verify(writeTransaction, Mockito.times(FLOWS_PER_DPN)).put(ArgumentMatchers.any(), ArgumentMatchers.any(), ArgumentMatchers.any(), @@ -65,7 +65,7 @@ public class FlowWriterConcurrentTest { } @Test - public void testDeleteFlows() throws Exception { + public void testDeleteFlows() { flowWriterConcurrent.deleteFlows(1, FLOWS_PER_DPN, 10, (short) 0, (short) 1); Mockito.verify(writeTransaction, Mockito.times(FLOWS_PER_DPN)) .delete(ArgumentMatchers.any(), diff --git a/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/FlowWriterDirectOFRpcTest.java b/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/FlowWriterDirectOFRpcTest.java index 9680c88b9c..53d007f75f 100644 --- a/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/FlowWriterDirectOFRpcTest.java +++ b/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/FlowWriterDirectOFRpcTest.java @@ -58,7 +58,7 @@ public class FlowWriterDirectOFRpcTest { private FlowWriterDirectOFRpc flowWriterDirectOFRpc; @Before - public void setUp() throws Exception { + public void setUp() { doReturn(RpcResultBuilder.success().buildFuture()).when(mockSalFlowService).addFlow(any()); when(mockDataBroker.newReadOnlyTransaction()).thenReturn(readOnlyTransaction); @@ -83,13 +83,13 @@ public class FlowWriterDirectOFRpcTest { } @Test - public void testRpcFlowAdd() throws Exception { + public void testRpcFlowAdd() { flowWriterDirectOFRpc.rpcFlowAdd("1", FLOWS_PER_DPN, 10); Mockito.verify(mockSalFlowService, Mockito.times(FLOWS_PER_DPN)).addFlow(Mockito.any()); } @Test - public void testRpcFlowAddAll() throws Exception { + public void testRpcFlowAddAll() { flowWriterDirectOFRpc.rpcFlowAddAll(FLOWS_PER_DPN, 10); Mockito.verify(mockSalFlowService, Mockito.times(FLOWS_PER_DPN)).addFlow(Mockito.any()); } diff --git a/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/FlowWriterSequentialTest.java b/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/FlowWriterSequentialTest.java index b9298d31c1..d6fcf0fe76 100644 --- a/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/FlowWriterSequentialTest.java +++ b/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/FlowWriterSequentialTest.java @@ -41,7 +41,7 @@ public class FlowWriterSequentialTest { private FlowWriterSequential flowWriterSequential; @Before - public void setUp() throws Exception { + public void setUp() { doReturn(writeTransaction).when(mockDataBroker).newWriteOnlyTransaction(); doReturn(CommitInfo.emptyFluentFuture()).when(writeTransaction).commit(); @@ -55,7 +55,7 @@ public class FlowWriterSequentialTest { } @Test - public void testAddFlows() throws Exception { + public void testAddFlows() { flowWriterSequential.addFlows(1, FLOWS_PER_DPN, 10, 10, (short) 0, (short) 1, true); Mockito.verify(writeTransaction, Mockito.times(FLOWS_PER_DPN)).put(ArgumentMatchers.any(), ArgumentMatchers.any(), ArgumentMatchers.any(), @@ -63,7 +63,7 @@ public class FlowWriterSequentialTest { } @Test - public void testDeleteFlows() throws Exception { + public void testDeleteFlows() { flowWriterSequential.deleteFlows(1, FLOWS_PER_DPN, 10, (short) 0, (short) 1); Mockito.verify(writeTransaction, Mockito.times(FLOWS_PER_DPN)) .delete(ArgumentMatchers.any(), diff --git a/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/FlowWriterTxChainTest.java b/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/FlowWriterTxChainTest.java index ba2b30d883..72e8576db3 100644 --- a/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/FlowWriterTxChainTest.java +++ b/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/FlowWriterTxChainTest.java @@ -47,7 +47,7 @@ public class FlowWriterTxChainTest { private FlowWriterTxChain flowWriterTxChain; @Before - public void setUp() throws Exception { + public void setUp() { Mockito.doAnswer(invocation -> { ((Runnable) invocation.getArguments()[0]).run(); @@ -65,7 +65,7 @@ public class FlowWriterTxChainTest { } @Test - public void testAddFlows() throws Exception { + public void testAddFlows() { flowWriterTxChain.addFlows(1, FLOWS_PER_DPN, 10, 10, 10, (short) 0, (short) 1, true); Mockito.verify(writeTransaction, Mockito.times(FLOWS_PER_DPN)).put(ArgumentMatchers.any(), ArgumentMatchers.any(), ArgumentMatchers.any(), @@ -73,7 +73,7 @@ public class FlowWriterTxChainTest { } @Test - public void testDeleteFlows() throws Exception { + public void testDeleteFlows() { flowWriterTxChain.deleteFlows(1, FLOWS_PER_DPN, 10, (short) 0, (short) 1); Mockito.verify(writeTransaction, Mockito.times(FLOWS_PER_DPN)) .delete(ArgumentMatchers.any(), diff --git a/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/SalBulkFlowServiceImplTest.java b/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/SalBulkFlowServiceImplTest.java index 6d1a4cd344..254515d5de 100644 --- a/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/SalBulkFlowServiceImplTest.java +++ b/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/SalBulkFlowServiceImplTest.java @@ -95,7 +95,7 @@ public class SalBulkFlowServiceImplTest { private SalBulkFlowServiceImpl salBulkFlowService; @Before - public void setUp() throws Exception { + public void setUp() { when(mockDataBroker.newWriteOnlyTransaction()).thenReturn(writeTransaction); when(mockDataBroker.newReadOnlyTransaction()).thenReturn(readOnlyTransaction); @@ -105,7 +105,7 @@ public class SalBulkFlowServiceImplTest { } @Test - public void testAddRemoveFlowsDs() throws Exception { + public void testAddRemoveFlowsDs() { doReturn(CommitInfo.emptyFluentFuture()).when(writeTransaction).commit(); final BulkFlowDsItemBuilder bulkFlowDsItemBuilder = new BulkFlowDsItemBuilder().setFlowId(new FlowId("1")) @@ -144,7 +144,7 @@ public class SalBulkFlowServiceImplTest { } @Test - public void testAddRemoveFlowsRpc() throws Exception { + public void testAddRemoveFlowsRpc() { Mockito.when(mockSalFlowService.addFlow(ArgumentMatchers.any())) .thenReturn(RpcResultBuilder.success(new AddFlowOutputBuilder().build()).buildFuture()); diff --git a/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/TableWriterTest.java b/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/TableWriterTest.java index 1653cf0d49..9294e60769 100644 --- a/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/TableWriterTest.java +++ b/applications/bulk-o-matic/src/test/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/TableWriterTest.java @@ -43,7 +43,7 @@ public class TableWriterTest { private TableWriter tableWriter; @Before - public void setUp() throws Exception { + public void setUp() { doReturn(writeTransaction).when(mockDataBroker).newWriteOnlyTransaction(); doReturn(CommitInfo.emptyFluentFuture()).when(writeTransaction).commit(); @@ -57,7 +57,7 @@ public class TableWriterTest { } @Test - public void testAddTables() throws Exception { + public void testAddTables() { tableWriter.addTables(DPN_COUNT, START_TABLE_ID, END_TABLE_ID); Mockito.verify(writeTransaction, Mockito.times(TABLES_PER_DPN)) .put(ArgumentMatchers.any(), @@ -66,7 +66,7 @@ public class TableWriterTest { } @Test - public void testDeleteTables() throws Exception { + public void testDeleteTables() { tableWriter.deleteTables(DPN_COUNT, START_TABLE_ID, END_TABLE_ID); Mockito.verify(writeTransaction, Mockito.times(TABLES_PER_DPN)) .delete(ArgumentMatchers.any(), diff --git a/applications/forwardingrules-manager/src/test/java/org/opendaylight/openflowplugin/applications/frm/impl/DeviceMastershipManagerTest.java b/applications/forwardingrules-manager/src/test/java/org/opendaylight/openflowplugin/applications/frm/impl/DeviceMastershipManagerTest.java index 1d31b9ca2f..92a0d65c15 100644 --- a/applications/forwardingrules-manager/src/test/java/org/opendaylight/openflowplugin/applications/frm/impl/DeviceMastershipManagerTest.java +++ b/applications/forwardingrules-manager/src/test/java/org/opendaylight/openflowplugin/applications/frm/impl/DeviceMastershipManagerTest.java @@ -51,7 +51,7 @@ public class DeviceMastershipManagerTest { private FrmReconciliationService reconciliationService; @Before - public void setUp() throws Exception { + public void setUp() { deviceMastershipManager = new DeviceMastershipManager(clusterSingletonService, reconciliationAgent, dataBroker, mastershipChangeServiceManager, rpcProviderService, reconciliationService); Mockito.lenient().when(clusterSingletonService @@ -62,7 +62,7 @@ public class DeviceMastershipManagerTest { } @Test - public void testOnDeviceConnectedAndDisconnected() throws Exception { + public void testOnDeviceConnectedAndDisconnected() { // no context Assert.assertNull(deviceMastershipManager.getDeviceMasterships().get(deviceInfo.getNodeId())); deviceMastershipManager.onBecomeOwner(deviceInfo); diff --git a/applications/forwardingrules-manager/src/test/java/org/opendaylight/openflowplugin/applications/frm/impl/DeviceMastershipTest.java b/applications/forwardingrules-manager/src/test/java/org/opendaylight/openflowplugin/applications/frm/impl/DeviceMastershipTest.java index b92fa18bcb..a4c20e8eeb 100644 --- a/applications/forwardingrules-manager/src/test/java/org/opendaylight/openflowplugin/applications/frm/impl/DeviceMastershipTest.java +++ b/applications/forwardingrules-manager/src/test/java/org/opendaylight/openflowplugin/applications/frm/impl/DeviceMastershipTest.java @@ -23,7 +23,7 @@ public class DeviceMastershipTest { private DeviceMastership deviceMastership; @Before - public void setUp() throws Exception { + public void setUp() { deviceMastership = new DeviceMastership(NODE_ID); } diff --git a/applications/forwardingrules-manager/src/test/java/test/mock/FlowListenerTest.java b/applications/forwardingrules-manager/src/test/java/test/mock/FlowListenerTest.java index 7d9edb8c16..ff49d05e96 100644 --- a/applications/forwardingrules-manager/src/test/java/test/mock/FlowListenerTest.java +++ b/applications/forwardingrules-manager/src/test/java/test/mock/FlowListenerTest.java @@ -91,7 +91,7 @@ public class FlowListenerTest extends FRMTest { } @Test - public void addTwoFlowsTest() throws Exception { + public void addTwoFlowsTest() { addFlowCapableNode(NODE_KEY); FlowKey flowKey = new FlowKey(new FlowId("test_Flow")); @@ -129,7 +129,7 @@ public class FlowListenerTest extends FRMTest { } @Test - public void updateFlowTest() throws Exception { + public void updateFlowTest() { addFlowCapableNode(NODE_KEY); FlowKey flowKey = new FlowKey(new FlowId("test_Flow")); @@ -169,7 +169,7 @@ public class FlowListenerTest extends FRMTest { } @Test - public void updateFlowScopeTest() throws Exception { + public void updateFlowScopeTest() { addFlowCapableNode(NODE_KEY); FlowKey flowKey = new FlowKey(new FlowId("test_Flow")); @@ -211,7 +211,7 @@ public class FlowListenerTest extends FRMTest { } @Test - public void deleteFlowTest() throws Exception { + public void deleteFlowTest() { addFlowCapableNode(NODE_KEY); FlowKey flowKey = new FlowKey(new FlowId("test_Flow")); @@ -245,7 +245,7 @@ public class FlowListenerTest extends FRMTest { } @Test - public void staleMarkedFlowCreationTest() throws Exception { + public void staleMarkedFlowCreationTest() { addFlowCapableNode(NODE_KEY); diff --git a/applications/forwardingrules-manager/src/test/java/test/mock/GroupListenerTest.java b/applications/forwardingrules-manager/src/test/java/test/mock/GroupListenerTest.java index de3076fd42..bc892432f5 100644 --- a/applications/forwardingrules-manager/src/test/java/test/mock/GroupListenerTest.java +++ b/applications/forwardingrules-manager/src/test/java/test/mock/GroupListenerTest.java @@ -88,7 +88,7 @@ public class GroupListenerTest extends FRMTest { } @Test - public void addTwoGroupsTest() throws Exception { + public void addTwoGroupsTest() { addFlowCapableNode(NODE_KEY); GroupKey groupKey = new GroupKey(new GroupId((long) 255)); @@ -120,7 +120,7 @@ public class GroupListenerTest extends FRMTest { } @Test - public void updateGroupTest() throws Exception { + public void updateGroupTest() { addFlowCapableNode(NODE_KEY); GroupKey groupKey = new GroupKey(new GroupId((long) 255)); @@ -149,7 +149,7 @@ public class GroupListenerTest extends FRMTest { } @Test - public void removeGroupTest() throws Exception { + public void removeGroupTest() { addFlowCapableNode(NODE_KEY); GroupKey groupKey = new GroupKey(new GroupId((long) 255)); @@ -177,7 +177,7 @@ public class GroupListenerTest extends FRMTest { } @Test - public void staleGroupCreationTest() throws Exception { + public void staleGroupCreationTest() { addFlowCapableNode(NODE_KEY); StaleGroupKey groupKey = new StaleGroupKey(new GroupId((long) 255)); diff --git a/applications/forwardingrules-manager/src/test/java/test/mock/MeterListenerTest.java b/applications/forwardingrules-manager/src/test/java/test/mock/MeterListenerTest.java index acb4612760..6ecd880336 100644 --- a/applications/forwardingrules-manager/src/test/java/test/mock/MeterListenerTest.java +++ b/applications/forwardingrules-manager/src/test/java/test/mock/MeterListenerTest.java @@ -86,7 +86,7 @@ public class MeterListenerTest extends FRMTest { } @Test - public void addTwoMetersTest() throws Exception { + public void addTwoMetersTest() { addFlowCapableNode(NODE_KEY); MeterKey meterKey = new MeterKey(new MeterId((long) 2000)); @@ -117,7 +117,7 @@ public class MeterListenerTest extends FRMTest { } @Test - public void updateMeterTest() throws Exception { + public void updateMeterTest() { addFlowCapableNode(NODE_KEY); MeterKey meterKey = new MeterKey(new MeterId((long) 2000)); @@ -145,7 +145,7 @@ public class MeterListenerTest extends FRMTest { } @Test - public void removeMeterTest() throws Exception { + public void removeMeterTest() { addFlowCapableNode(NODE_KEY); MeterKey meterKey = new MeterKey(new MeterId((long) 2000)); @@ -172,7 +172,7 @@ public class MeterListenerTest extends FRMTest { } @Test - public void staleMeterCreationTest() throws Exception { + public void staleMeterCreationTest() { addFlowCapableNode(NODE_KEY); StaleMeterKey meterKey = new StaleMeterKey(new MeterId((long) 2000)); diff --git a/applications/forwardingrules-sync/src/main/java/org/opendaylight/openflowplugin/applications/frsync/util/SemaphoreKeeperGuavaImpl.java b/applications/forwardingrules-sync/src/main/java/org/opendaylight/openflowplugin/applications/frsync/util/SemaphoreKeeperGuavaImpl.java index d652aac3e6..7f7e979330 100644 --- a/applications/forwardingrules-sync/src/main/java/org/opendaylight/openflowplugin/applications/frsync/util/SemaphoreKeeperGuavaImpl.java +++ b/applications/forwardingrules-sync/src/main/java/org/opendaylight/openflowplugin/applications/frsync/util/SemaphoreKeeperGuavaImpl.java @@ -31,7 +31,7 @@ public class SemaphoreKeeperGuavaImpl implements SemaphoreKeeper { .weakValues() .build(new CacheLoader() { @Override - public Semaphore load(final K key) throws Exception { + public Semaphore load(final K key) { return new Semaphore(permits, fair); } }); diff --git a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/ForwardingRulesSyncProviderTest.java b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/ForwardingRulesSyncProviderTest.java index 362997c9af..ab1b9eaf13 100644 --- a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/ForwardingRulesSyncProviderTest.java +++ b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/ForwardingRulesSyncProviderTest.java @@ -37,7 +37,7 @@ public class ForwardingRulesSyncProviderTest { private ClusterSingletonServiceProvider clusterSingletonService; @Before - public void setUp() throws Exception { + public void setUp() { Mockito.when(rpcRegistry.getRpcService(ArgumentMatchers.>any())) .thenAnswer(invocation -> { Class serviceType = @@ -51,7 +51,7 @@ public class ForwardingRulesSyncProviderTest { } @Test - public void testInit() throws Exception { + public void testInit() { provider.init(); Mockito.verify(dataBroker, Mockito.times(2)).registerDataTreeChangeListener( diff --git a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/SimplifiedConfigListenerTest.java b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/SimplifiedConfigListenerTest.java index 133369cc74..41b1d08f70 100644 --- a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/SimplifiedConfigListenerTest.java +++ b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/SimplifiedConfigListenerTest.java @@ -64,7 +64,7 @@ public class SimplifiedConfigListenerTest { private FlowCapableNode dataAfter; @Before - public void setUp() throws Exception { + public void setUp() { final DataBroker db = Mockito.mock(DataBroker.class); final FlowCapableNodeSnapshotDao configSnapshot = new FlowCapableNodeSnapshotDao(); final FlowCapableNodeSnapshotDao operationalSnapshot = new FlowCapableNodeSnapshotDao(); @@ -84,7 +84,7 @@ public class SimplifiedConfigListenerTest { } @Test - public void testDSLogicalType() throws Exception { + public void testDSLogicalType() { Assert.assertEquals(LogicalDatastoreType.CONFIGURATION, nodeListenerConfig.dsType()); } diff --git a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/SimplifiedOperationalListenerTest.java b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/SimplifiedOperationalListenerTest.java index 9ae8370b4d..dab4687d7a 100644 --- a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/SimplifiedOperationalListenerTest.java +++ b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/SimplifiedOperationalListenerTest.java @@ -88,7 +88,7 @@ public class SimplifiedOperationalListenerTest { private Node operationalNodeEmpty; @Before - public void setUp() throws Exception { + public void setUp() { final DataBroker db = Mockito.mock(DataBroker.class); final FlowCapableNodeSnapshotDao configSnapshot = new FlowCapableNodeSnapshotDao(); final FlowCapableNodeSnapshotDao operationalSnapshot = new FlowCapableNodeSnapshotDao(); @@ -112,7 +112,7 @@ public class SimplifiedOperationalListenerTest { } @Test - public void testDSLogicalType() throws Exception { + public void testDSLogicalType() { Assert.assertEquals(LogicalDatastoreType.OPERATIONAL, nodeListenerOperational.dsType()); } @@ -125,7 +125,7 @@ public class SimplifiedOperationalListenerTest { } @Test - public void testOnDataTreeChangedDeletePhysical() throws Exception { + public void testOnDataTreeChangedDeletePhysical() { Mockito.when(operationalModification.getDataBefore()).thenReturn(operationalNode); Mockito.when(operationalModification.getDataAfter()).thenReturn(null); diff --git a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/SyncReactorGuardDecoratorTest.java b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/SyncReactorGuardDecoratorTest.java index 8724c53174..52fe9f76cc 100644 --- a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/SyncReactorGuardDecoratorTest.java +++ b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/SyncReactorGuardDecoratorTest.java @@ -45,7 +45,7 @@ public class SyncReactorGuardDecoratorTest { private SyncupEntry syncupEntry; @Before - public void setUp() throws Exception { + public void setUp() { reactor = new SyncReactorGuardDecorator(delegate); InstanceIdentifier nodePath = InstanceIdentifier.create(Nodes.class) .child(Node.class, new NodeKey(NODE_ID)); diff --git a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/SyncReactorImplTest.java b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/SyncReactorImplTest.java index 301135edb9..92adf017c4 100644 --- a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/SyncReactorImplTest.java +++ b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/SyncReactorImplTest.java @@ -77,7 +77,7 @@ public class SyncReactorImplTest { private ArgumentCaptor syncDiffInputCaptor; @Before - public void setUp() throws Exception { + public void setUp() { reactor = new SyncReactorImpl(syncPlanPushStrategy); } diff --git a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/clustering/DeviceMastershipManagerTest.java b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/clustering/DeviceMastershipManagerTest.java index ec22ddcce9..619ea9ddeb 100644 --- a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/clustering/DeviceMastershipManagerTest.java +++ b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/clustering/DeviceMastershipManagerTest.java @@ -34,7 +34,7 @@ public class DeviceMastershipManagerTest { private ClusterSingletonServiceProvider clusterSingletonService; @Before - public void setUp() throws Exception { + public void setUp() { deviceMastershipManager = new DeviceMastershipManager(clusterSingletonService, new ReconciliationRegistry()); Mockito.when(clusterSingletonService .registerClusterSingletonService(ArgumentMatchers.any())) @@ -42,7 +42,7 @@ public class DeviceMastershipManagerTest { } @Test - public void testOnDeviceConnectedAndDisconnected() throws Exception { + public void testOnDeviceConnectedAndDisconnected() { // no context Assert.assertNull(deviceMastershipManager.getDeviceMasterships().get(NODE_ID)); // create context - register diff --git a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/clustering/DeviceMastershipTest.java b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/clustering/DeviceMastershipTest.java index 04d2c807d9..a59e1d118e 100644 --- a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/clustering/DeviceMastershipTest.java +++ b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/clustering/DeviceMastershipTest.java @@ -33,7 +33,7 @@ public class DeviceMastershipTest { private ReconciliationRegistry reconciliationRegistry; @Before - public void setUp() throws Exception { + public void setUp() { deviceMastership = new DeviceMastership(NODE_ID, reconciliationRegistry, Mockito.mock(ClusterSingletonServiceProvider.class)); } diff --git a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/FlowForwarderTest.java b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/FlowForwarderTest.java index f50b50e8b5..41ef706339 100644 --- a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/FlowForwarderTest.java +++ b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/FlowForwarderTest.java @@ -96,7 +96,7 @@ public class FlowForwarderTest { @Before - public void setUp() throws Exception { + public void setUp() { flowForwarder = new FlowForwarder(salFlowService); } diff --git a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/GroupForwarderTest.java b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/GroupForwarderTest.java index 95917a3153..e3a8475844 100644 --- a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/GroupForwarderTest.java +++ b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/GroupForwarderTest.java @@ -82,7 +82,7 @@ public class GroupForwarderTest { private GroupForwarder groupForwarder; @Before - public void setUp() throws Exception { + public void setUp() { groupForwarder = new GroupForwarder(salGroupService); txId = new TransactionId(BigInteger.ONE); } diff --git a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/MeterForwarderTest.java b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/MeterForwarderTest.java index 4127497bff..74c2ecd029 100644 --- a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/MeterForwarderTest.java +++ b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/MeterForwarderTest.java @@ -80,7 +80,7 @@ public class MeterForwarderTest { private MeterForwarder meterForwarder; @Before - public void setUp() throws Exception { + public void setUp() { meterForwarder = new MeterForwarder(salMeterService); txId = new TransactionId(BigInteger.ONE); } diff --git a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/SyncPlanPushStrategyFlatBatchImplTest.java b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/SyncPlanPushStrategyFlatBatchImplTest.java index 1b88389267..74aa5b653e 100644 --- a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/SyncPlanPushStrategyFlatBatchImplTest.java +++ b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/SyncPlanPushStrategyFlatBatchImplTest.java @@ -109,7 +109,7 @@ public class SyncPlanPushStrategyFlatBatchImplTest { @Before - public void setUp() throws Exception { + public void setUp() { syncPlanPushStrategy = new SyncPlanPushStrategyFlatBatchImpl(); syncPlanPushStrategy.setFlatBatchService(flatBatchService); syncPlanPushStrategy.setTableForwarder(tableForwarder); @@ -153,7 +153,7 @@ public class SyncPlanPushStrategyFlatBatchImplTest { } @Test - public void testAssembleRemoveFlows() throws Exception { + public void testAssembleRemoveFlows() { final int lastOrder = SyncPlanPushStrategyFlatBatchImpl.assembleRemoveFlows(batchBag, 0, flowsToRemove); Assert.assertEquals(6, lastOrder); @@ -167,7 +167,7 @@ public class SyncPlanPushStrategyFlatBatchImplTest { } @Test - public void testAssembleAddOrUpdateGroups() throws Exception { + public void testAssembleAddOrUpdateGroups() { final int lastOrder = SyncPlanPushStrategyFlatBatchImpl.assembleAddOrUpdateGroups( batchBag, 0, groupsToAddOrUpdate); @@ -185,7 +185,7 @@ public class SyncPlanPushStrategyFlatBatchImplTest { } @Test - public void testAssembleRemoveGroups() throws Exception { + public void testAssembleRemoveGroups() { final int lastOrder = SyncPlanPushStrategyFlatBatchImpl.assembleRemoveGroups(batchBag, 0, groupsToRemove); Assert.assertEquals(6, lastOrder); @@ -199,7 +199,7 @@ public class SyncPlanPushStrategyFlatBatchImplTest { } @Test - public void testAssembleAddOrUpdateMeters() throws Exception { + public void testAssembleAddOrUpdateMeters() { final int lastOrder = SyncPlanPushStrategyFlatBatchImpl.assembleAddOrUpdateMeters( batchBag, 0, metersToAddOrUpdate); @@ -214,7 +214,7 @@ public class SyncPlanPushStrategyFlatBatchImplTest { } @Test - public void testAssembleRemoveMeters() throws Exception { + public void testAssembleRemoveMeters() { final int lastOrder = SyncPlanPushStrategyFlatBatchImpl.assembleRemoveMeters(batchBag, 0, metersToRemove); Assert.assertEquals(3, lastOrder); @@ -225,7 +225,7 @@ public class SyncPlanPushStrategyFlatBatchImplTest { } @Test - public void testAssembleAddOrUpdateFlows() throws Exception { + public void testAssembleAddOrUpdateFlows() { final int lastOrder = SyncPlanPushStrategyFlatBatchImpl.assembleAddOrUpdateFlows( batchBag, 0, flowsToAddOrUpdate); @@ -243,7 +243,7 @@ public class SyncPlanPushStrategyFlatBatchImplTest { } @Test - public void testDecrementCounters() throws Exception { + public void testDecrementCounters() { final SyncCrudCounters counters = new SyncCrudCounters(); counters.getFlowCrudCounts().setAdded(100); counters.getFlowCrudCounts().setUpdated(100); @@ -283,7 +283,7 @@ public class SyncPlanPushStrategyFlatBatchImplTest { } @Test - public void testMapBatchesToRanges() throws Exception { + public void testMapBatchesToRanges() { final List inputBatchBag = Lists.newArrayList( new BatchBuilder().setBatchOrder(0).build(), new BatchBuilder().setBatchOrder(5).build(), diff --git a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/SyncPlanPushStrategyIncrementalImplTest.java b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/SyncPlanPushStrategyIncrementalImplTest.java index 824142b1ae..6f7c2b9556 100644 --- a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/SyncPlanPushStrategyIncrementalImplTest.java +++ b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/SyncPlanPushStrategyIncrementalImplTest.java @@ -175,7 +175,7 @@ public class SyncPlanPushStrategyIncrementalImplTest { } @Before - public void setUp() throws Exception { + public void setUp() { Mockito.when(flowCapableTxService.sendBarrier(ArgumentMatchers.any())) .thenReturn(RpcResultBuilder.success((SendBarrierOutput) null).buildFuture()); diff --git a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/TableForwarderTest.java b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/TableForwarderTest.java index 9f6a292bb1..7c6e6f3693 100644 --- a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/TableForwarderTest.java +++ b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/TableForwarderTest.java @@ -76,7 +76,7 @@ public class TableForwarderTest { @Before - public void setUp() throws Exception { + public void setUp() { tableForwarder = new TableForwarder(salTableService); txId = new TransactionId(BigInteger.ONE); } diff --git a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/util/ReconcileUtilTest.java b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/util/ReconcileUtilTest.java index 07d5124bb1..ca9c73d68a 100644 --- a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/util/ReconcileUtilTest.java +++ b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/util/ReconcileUtilTest.java @@ -96,7 +96,7 @@ public class ReconcileUtilTest { * add one missing group. */ @Test - public void testResolveAndDivideGroupDiffs1() throws Exception { + public void testResolveAndDivideGroupDiffs1() { final Map installedGroups = new HashMap<>(); installedGroups.put(1L, createGroup(1L)); installedGroups.put(2L, createGroup(2L)); @@ -122,7 +122,7 @@ public class ReconcileUtilTest { * add 3 groups with dependencies - 3 steps involved. */ @Test - public void testResolveAndDivideGroupDiffs2() throws Exception { + public void testResolveAndDivideGroupDiffs2() { final Map installedGroups = new HashMap<>(); installedGroups.put(1L, createGroup(1L)); @@ -156,7 +156,7 @@ public class ReconcileUtilTest { * no actions taken - installed and pending groups are the same. */ @Test - public void testResolveAndDivideGroupDiffs3() throws Exception { + public void testResolveAndDivideGroupDiffs3() { final Map installedGroups = new HashMap<>(); installedGroups.put(1L, createGroup(1L)); installedGroups.put(2L, createGroupWithPreconditions(2L, 1L)); @@ -175,7 +175,7 @@ public class ReconcileUtilTest { * update 1 group. */ @Test - public void testResolveAndDivideGroupDiffs4() throws Exception { + public void testResolveAndDivideGroupDiffs4() { final Map installedGroups = new HashMap<>(); installedGroups.put(1L, createGroup(1L)); installedGroups.put(2L, createGroup(2L)); @@ -200,7 +200,7 @@ public class ReconcileUtilTest { * no action taken - update 1 group will be ignored. */ @Test - public void testResolveAndDivideGroupDiffs5() throws Exception { + public void testResolveAndDivideGroupDiffs5() { final Map installedGroups = new HashMap<>(); installedGroups.put(1L, createGroup(1L)); installedGroups.put(2L, createGroup(2L)); @@ -219,7 +219,7 @@ public class ReconcileUtilTest { * should add 1 group but preconditions are not met. */ @Test - public void testResolveAndDivideGroupDiffs_negative1() throws Exception { + public void testResolveAndDivideGroupDiffs_negative1() { final Map installedGroups = new HashMap<>(); installedGroups.put(1L, createGroup(1L)); installedGroups.put(2L, createGroup(2L)); @@ -236,7 +236,7 @@ public class ReconcileUtilTest { * should update 1 group but preconditions are not met. */ @Test - public void testResolveAndDivideGroupDiffs_negative2() throws Exception { + public void testResolveAndDivideGroupDiffs_negative2() { final Map installedGroups = new HashMap<>(); installedGroups.put(1L, createGroup(1L)); installedGroups.put(2L, createGroup(2L)); @@ -250,7 +250,7 @@ public class ReconcileUtilTest { } @Test - public void testCheckGroupPrecondition() throws Exception { + public void testCheckGroupPrecondition() { final Set installedGroups = new HashSet<>(Arrays.asList(new Long[]{1L, 2L})); final Group pendingGroup1 = createGroupWithPreconditions(3L, 2L, 4L); @@ -305,7 +305,7 @@ public class ReconcileUtilTest { * covers {@link ReconcileUtil#countTotalUpdated(Iterable)} too. */ @Test - public void testCountTotalAdds() throws Exception { + public void testCountTotalAdds() { List> syncPlan = new ArrayList<>(); ItemSyncBox syncBox1 = createSyncBox("a,b", "x,y,z"); syncPlan.add(syncBox1); diff --git a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/util/ReconciliationRegistryTest.java b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/util/ReconciliationRegistryTest.java index c7d492fb2e..c7eee02733 100644 --- a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/util/ReconciliationRegistryTest.java +++ b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/util/ReconciliationRegistryTest.java @@ -26,7 +26,7 @@ public class ReconciliationRegistryTest { private ReconciliationRegistry reconciliationRegistry; @Before - public void setUp() throws Exception { + public void setUp() { reconciliationRegistry = new ReconciliationRegistry(); } diff --git a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/util/SemaphoreKeeperGuavaImplTest.java b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/util/SemaphoreKeeperGuavaImplTest.java index c900344b72..3d1ba57313 100644 --- a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/util/SemaphoreKeeperGuavaImplTest.java +++ b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/util/SemaphoreKeeperGuavaImplTest.java @@ -31,7 +31,7 @@ public class SemaphoreKeeperGuavaImplTest { private final String key = "11"; @Before - public void setUp() throws Exception { + public void setUp() { semaphoreKeeper = new SemaphoreKeeperGuavaImpl<>(1, true); } diff --git a/applications/lldp-speaker/src/main/java/org/opendaylight/openflowplugin/applications/lldpspeaker/LLDPSpeaker.java b/applications/lldp-speaker/src/main/java/org/opendaylight/openflowplugin/applications/lldpspeaker/LLDPSpeaker.java index 84358e0bb0..575da858e7 100644 --- a/applications/lldp-speaker/src/main/java/org/opendaylight/openflowplugin/applications/lldpspeaker/LLDPSpeaker.java +++ b/applications/lldp-speaker/src/main/java/org/opendaylight/openflowplugin/applications/lldpspeaker/LLDPSpeaker.java @@ -12,7 +12,6 @@ import static org.opendaylight.infrautils.utils.concurrent.LoggingFutures.addErr import com.google.common.base.Preconditions; import com.google.common.util.concurrent.ThreadFactoryBuilder; -import java.security.NoSuchAlgorithmException; import java.util.Map; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.Executors; @@ -182,7 +181,7 @@ public class LLDPSpeaker implements NodeConnectorEventsObserver, Runnable, AutoC .setEgress(new NodeConnectorRef(nodeConnectorInstanceId)) .setNode(new NodeRef(nodeInstanceId)).setPayload(LLDPUtil.buildLldpFrame(nodeId, nodeConnectorId, srcMacAddress, outputPortNo, addressDestination)).build(); - } catch (NoSuchAlgorithmException | PacketException e) { + } catch (PacketException e) { LOG.error("Error building LLDP frame", e); return; } diff --git a/applications/lldp-speaker/src/main/java/org/opendaylight/openflowplugin/applications/lldpspeaker/LLDPUtil.java b/applications/lldp-speaker/src/main/java/org/opendaylight/openflowplugin/applications/lldpspeaker/LLDPUtil.java index 28b4268c1e..6ca6b55fe6 100644 --- a/applications/lldp-speaker/src/main/java/org/opendaylight/openflowplugin/applications/lldpspeaker/LLDPUtil.java +++ b/applications/lldp-speaker/src/main/java/org/opendaylight/openflowplugin/applications/lldpspeaker/LLDPUtil.java @@ -11,7 +11,6 @@ import static org.opendaylight.openflowplugin.applications.topology.lldp.utils.L import com.google.common.base.Strings; import java.math.BigInteger; -import java.security.NoSuchAlgorithmException; import javax.annotation.Nonnull; import org.opendaylight.openflowplugin.libraries.liblldp.EtherTypes; import org.opendaylight.openflowplugin.libraries.liblldp.Ethernet; @@ -39,7 +38,7 @@ public final class LLDPUtil { @Nonnull static byte[] buildLldpFrame(final NodeId nodeId, final NodeConnectorId nodeConnectorId, final MacAddress src, final Long outPortNo, final MacAddress destinationAddress) - throws NoSuchAlgorithmException, PacketException { + throws PacketException { // Create discovery pkt LLDP discoveryPkt = new LLDP(); @@ -104,7 +103,7 @@ public final class LLDPUtil { @Nonnull static byte[] buildLldpFrame(final NodeId nodeId, final NodeConnectorId nodeConnectorId, - final MacAddress srcMacAddress, final Long outputPortNo) throws NoSuchAlgorithmException, PacketException { + final MacAddress srcMacAddress, final Long outputPortNo) throws PacketException { return buildLldpFrame(nodeId, nodeConnectorId, srcMacAddress, outputPortNo, null); } diff --git a/applications/lldp-speaker/src/test/java/org/opendaylight/openflowplugin/applications/lldpspeaker/NodeConnectorInventoryEventTranslatorTest.java b/applications/lldp-speaker/src/test/java/org/opendaylight/openflowplugin/applications/lldpspeaker/NodeConnectorInventoryEventTranslatorTest.java index e2f0ea0614..cdd2ed622c 100644 --- a/applications/lldp-speaker/src/test/java/org/opendaylight/openflowplugin/applications/lldpspeaker/NodeConnectorInventoryEventTranslatorTest.java +++ b/applications/lldp-speaker/src/test/java/org/opendaylight/openflowplugin/applications/lldpspeaker/NodeConnectorInventoryEventTranslatorTest.java @@ -157,7 +157,7 @@ public class NodeConnectorInventoryEventTranslatorTest { * observers are registered for notifications. */ @Test - public void testMultipleObserversNotified() throws Exception { + public void testMultipleObserversNotified() { // Create prerequisites InstanceIdentifier id2 = TestUtils.createNodeConnectorId("openflow:1", "openflow:1:2"); InstanceIdentifier iiToConnector2 = id2.augmentation(FlowCapableNodeConnector.class); @@ -173,7 +173,7 @@ public class NodeConnectorInventoryEventTranslatorTest { } @Test - public void tearDown() throws Exception { + public void tearDown() { translator.close(); } diff --git a/applications/notification-supplier/src/main/java/org/opendaylight/openflowplugin/applications/notification/supplier/impl/AbstractNotificationSupplierBase.java b/applications/notification-supplier/src/main/java/org/opendaylight/openflowplugin/applications/notification/supplier/impl/AbstractNotificationSupplierBase.java index fc9a227a6b..2c2f4cc4da 100644 --- a/applications/notification-supplier/src/main/java/org/opendaylight/openflowplugin/applications/notification/supplier/impl/AbstractNotificationSupplierBase.java +++ b/applications/notification-supplier/src/main/java/org/opendaylight/openflowplugin/applications/notification/supplier/impl/AbstractNotificationSupplierBase.java @@ -70,7 +70,7 @@ public abstract class AbstractNotificationSupplierBase imp } @Override - public void close() throws Exception { + public void close() { if (listenerRegistration != null) { listenerRegistration.close(); listenerRegistration = null; diff --git a/applications/of-switch-config-pusher/src/test/java/org/opendaylight/openflowplugin/openflow/ofswitch/config/DefaultConfigPusherTest.java b/applications/of-switch-config-pusher/src/test/java/org/opendaylight/openflowplugin/openflow/ofswitch/config/DefaultConfigPusherTest.java index 6066452bab..f7c8e31a12 100644 --- a/applications/of-switch-config-pusher/src/test/java/org/opendaylight/openflowplugin/openflow/ofswitch/config/DefaultConfigPusherTest.java +++ b/applications/of-switch-config-pusher/src/test/java/org/opendaylight/openflowplugin/openflow/ofswitch/config/DefaultConfigPusherTest.java @@ -60,7 +60,7 @@ public class DefaultConfigPusherTest { private ArgumentCaptor setConfigInputCaptor; @Before - public void setUp() throws Exception { + public void setUp() { doReturn(RpcResultBuilder.success().buildFuture()).when(nodeConfigService).setConfig(any()); defaultConfigPusher = new DefaultConfigPusher(nodeConfigService, Mockito.mock(DataBroker.class), deviceOwnershipService); diff --git a/applications/reconciliation-framework/src/main/java/org/opendaylight/openflowplugin/applications/reconciliation/cli/GetRegisteredServices.java b/applications/reconciliation-framework/src/main/java/org/opendaylight/openflowplugin/applications/reconciliation/cli/GetRegisteredServices.java index e0fdc2afa6..1b7c67cfcf 100644 --- a/applications/reconciliation-framework/src/main/java/org/opendaylight/openflowplugin/applications/reconciliation/cli/GetRegisteredServices.java +++ b/applications/reconciliation-framework/src/main/java/org/opendaylight/openflowplugin/applications/reconciliation/cli/GetRegisteredServices.java @@ -35,7 +35,7 @@ public class GetRegisteredServices extends OsgiCommandSupport { } @Override - protected Object doExecute() throws Exception { + protected Object doExecute() { LOG.debug("Executing getRegisteredServices to Reconciliation Framework command"); if (reconciliationManager.getRegisteredServices().isEmpty()) { session.getConsole().println("No Services have registered to Reconciliation Framework"); diff --git a/applications/reconciliation-framework/src/main/java/org/opendaylight/openflowplugin/applications/reconciliation/impl/ReconciliationManagerImpl.java b/applications/reconciliation-framework/src/main/java/org/opendaylight/openflowplugin/applications/reconciliation/impl/ReconciliationManagerImpl.java index fab79142df..14b28a5858 100644 --- a/applications/reconciliation-framework/src/main/java/org/opendaylight/openflowplugin/applications/reconciliation/impl/ReconciliationManagerImpl.java +++ b/applications/reconciliation-framework/src/main/java/org/opendaylight/openflowplugin/applications/reconciliation/impl/ReconciliationManagerImpl.java @@ -99,7 +99,7 @@ public class ReconciliationManagerImpl implements ReconciliationManager, Reconci @Override @PreDestroy - public void close() throws Exception { + public void close() { } @Override diff --git a/applications/southbound-cli/src/main/java/org/opendaylight/openflowplugin/applications/southboundcli/cli/GetAllNodesCommandProvider.java b/applications/southbound-cli/src/main/java/org/opendaylight/openflowplugin/applications/southboundcli/cli/GetAllNodesCommandProvider.java index 5517d9ffbc..da25c25535 100644 --- a/applications/southbound-cli/src/main/java/org/opendaylight/openflowplugin/applications/southboundcli/cli/GetAllNodesCommandProvider.java +++ b/applications/southbound-cli/src/main/java/org/opendaylight/openflowplugin/applications/southboundcli/cli/GetAllNodesCommandProvider.java @@ -28,7 +28,7 @@ public class GetAllNodesCommandProvider extends OsgiCommandSupport { } @Override - protected Object doExecute() throws Exception { + protected Object doExecute() { List ofNodeList = ShellUtil.getAllNodes(dataBroker); if (ofNodeList.isEmpty()) { session.getConsole().println("No node is connected yet"); diff --git a/applications/southbound-cli/src/main/java/org/opendaylight/openflowplugin/applications/southboundcli/cli/ReconciliationCount.java b/applications/southbound-cli/src/main/java/org/opendaylight/openflowplugin/applications/southboundcli/cli/ReconciliationCount.java index ae322c3d4b..7d2f254788 100644 --- a/applications/southbound-cli/src/main/java/org/opendaylight/openflowplugin/applications/southboundcli/cli/ReconciliationCount.java +++ b/applications/southbound-cli/src/main/java/org/opendaylight/openflowplugin/applications/southboundcli/cli/ReconciliationCount.java @@ -27,7 +27,7 @@ public class ReconciliationCount extends OsgiCommandSupport { } @Override - protected Object doExecute() throws Exception { + protected Object doExecute() { List result = ShellUtil.getReconcileCount(dataBroker); if (result.isEmpty()) { session.getConsole().println("Reconciliation count not yet available for openflow nodes."); diff --git a/applications/southbound-cli/src/main/java/org/opendaylight/openflowplugin/applications/southboundcli/cli/ShowNodeCommandProvider.java b/applications/southbound-cli/src/main/java/org/opendaylight/openflowplugin/applications/southboundcli/cli/ShowNodeCommandProvider.java index b0bd7f4716..fed144275a 100644 --- a/applications/southbound-cli/src/main/java/org/opendaylight/openflowplugin/applications/southboundcli/cli/ShowNodeCommandProvider.java +++ b/applications/southbound-cli/src/main/java/org/opendaylight/openflowplugin/applications/southboundcli/cli/ShowNodeCommandProvider.java @@ -32,7 +32,7 @@ public class ShowNodeCommandProvider extends OsgiCommandSupport { } @Override - protected Object doExecute() throws Exception { + protected Object doExecute() { if (nodeId == null) { session.getConsole().println("NodeID not specified"); return null; diff --git a/applications/topology-lldp-discovery/src/main/java/org/opendaylight/openflowplugin/applications/topology/lldp/utils/LLDPDiscoveryUtils.java b/applications/topology-lldp-discovery/src/main/java/org/opendaylight/openflowplugin/applications/topology/lldp/utils/LLDPDiscoveryUtils.java index c5f985e245..cc667ae67d 100644 --- a/applications/topology-lldp-discovery/src/main/java/org/opendaylight/openflowplugin/applications/topology/lldp/utils/LLDPDiscoveryUtils.java +++ b/applications/topology-lldp-discovery/src/main/java/org/opendaylight/openflowplugin/applications/topology/lldp/utils/LLDPDiscoveryUtils.java @@ -16,7 +16,6 @@ import java.lang.management.ManagementFactory; import java.nio.ByteBuffer; import java.nio.charset.Charset; import java.nio.charset.StandardCharsets; -import java.security.NoSuchAlgorithmException; import java.util.Arrays; import java.util.Objects; import java.util.Optional; @@ -26,7 +25,6 @@ import org.opendaylight.mdsal.eos.binding.api.Entity; import org.opendaylight.mdsal.eos.binding.api.EntityOwnershipService; import org.opendaylight.mdsal.eos.common.api.EntityOwnershipState; import org.opendaylight.openflowplugin.applications.topology.lldp.LLDPActivator; -import org.opendaylight.openflowplugin.libraries.liblldp.BufferException; import org.opendaylight.openflowplugin.libraries.liblldp.Ethernet; import org.opendaylight.openflowplugin.libraries.liblldp.LLDP; import org.opendaylight.openflowplugin.libraries.liblldp.LLDPTLV; @@ -146,8 +144,7 @@ public final class LLDPDiscoveryUtils { * @param nodeConnectorId the NodeConnectorId * @return extra authenticator for lldp security */ - public static byte[] getValueForLLDPPacketIntegrityEnsuring(final NodeConnectorId nodeConnectorId) - throws NoSuchAlgorithmException { + public static byte[] getValueForLLDPPacketIntegrityEnsuring(final NodeConnectorId nodeConnectorId) { String finalKey; if (LLDPActivator.getLldpSecureKey() != null && !LLDPActivator.getLldpSecureKey().isEmpty()) { finalKey = LLDPActivator.getLldpSecureKey(); @@ -163,8 +160,7 @@ public final class LLDPDiscoveryUtils { return hashedValue.asBytes(); } - private static boolean checkExtraAuthenticator(LLDP lldp, NodeConnectorId srcNodeConnectorId) - throws NoSuchAlgorithmException, BufferException { + private static boolean checkExtraAuthenticator(LLDP lldp, NodeConnectorId srcNodeConnectorId) { final LLDPTLV hashLldptlv = lldp.getCustomTLV(LLDPTLV.createSecSubTypeCustomTLVKey()); boolean secAuthenticatorOk = false; if (hashLldptlv != null) { diff --git a/applications/topology-lldp-discovery/src/test/java/org/opendaylight/openflowplugin/applications/topology/lldp/LLDPLinkAgerTest.java b/applications/topology-lldp-discovery/src/test/java/org/opendaylight/openflowplugin/applications/topology/lldp/LLDPLinkAgerTest.java index f94fac3fad..aea9f55be8 100644 --- a/applications/topology-lldp-discovery/src/test/java/org/opendaylight/openflowplugin/applications/topology/lldp/LLDPLinkAgerTest.java +++ b/applications/topology-lldp-discovery/src/test/java/org/opendaylight/openflowplugin/applications/topology/lldp/LLDPLinkAgerTest.java @@ -67,7 +67,7 @@ public class LLDPLinkAgerTest { private LinkRemoved linkRemoved; @Before - public void setUp() throws Exception { + public void setUp() { lldpLinkAger = new LLDPLinkAger(getConfig(), notificationService, getConfigurationService(), eos); Mockito.when(link.getDestination()).thenReturn(new NodeConnectorRef( InstanceIdentifier.create(Nodes.class).child(Node.class, new NodeKey(new NodeId("openflow:1"))))); diff --git a/applications/topology-lldp-discovery/src/test/java/org/opendaylight/openflowplugin/applications/topology/lldp/utils/LLDPDiscoveryUtilsTest.java b/applications/topology-lldp-discovery/src/test/java/org/opendaylight/openflowplugin/applications/topology/lldp/utils/LLDPDiscoveryUtilsTest.java index 3ee30561bc..ccb16e5bce 100644 --- a/applications/topology-lldp-discovery/src/test/java/org/opendaylight/openflowplugin/applications/topology/lldp/utils/LLDPDiscoveryUtilsTest.java +++ b/applications/topology-lldp-discovery/src/test/java/org/opendaylight/openflowplugin/applications/topology/lldp/utils/LLDPDiscoveryUtilsTest.java @@ -31,7 +31,7 @@ public class LLDPDiscoveryUtilsTest { private static final Logger LOG = LoggerFactory.getLogger(LLDPDiscoveryUtilsTest.class); @Test - public void testLldpToNodeConnectorRefLLDP() throws Exception { + public void testLldpToNodeConnectorRefLLDP() { byte[] packetLLDP = { 0x01, 0x23, 0x00, 0x00, 0x00, 0x01, (byte) 0x8a, (byte) 0x8e, (byte) 0xcc, (byte) 0x85, (byte) 0xeb, 0x27, @@ -56,7 +56,7 @@ public class LLDPDiscoveryUtilsTest { } @Test - public void testLldpToNodeConnectorRefNotLLDP() throws Exception { + public void testLldpToNodeConnectorRefNotLLDP() { byte[] packetNotLLDP = { 0x01, 0x23, 0x00, 0x00, 0x00, 0x01, (byte) 0x8a, (byte) 0x8e, (byte) 0xcc, (byte) 0x85, (byte) 0xeb, 0x27, diff --git a/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/DataTreeChangeListenerImpl.java b/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/DataTreeChangeListenerImpl.java index c2e1a387fa..8e37a0a297 100644 --- a/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/DataTreeChangeListenerImpl.java +++ b/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/DataTreeChangeListenerImpl.java @@ -53,7 +53,7 @@ public abstract class DataTreeChangeListenerImpl implement } @Override - public void close() throws Exception { + public void close() { listenerRegistration.close(); } diff --git a/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/NodeChangeListenerImpl.java b/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/NodeChangeListenerImpl.java index 156d9745ae..97effc0b26 100644 --- a/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/NodeChangeListenerImpl.java +++ b/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/NodeChangeListenerImpl.java @@ -62,7 +62,7 @@ public class NodeChangeListenerImpl extends DataTreeChangeListenerImpl>any(), ArgumentMatchers.>any()); + .common.action.rev150203.actions.grouping.Action>>any()); } } diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/ConntrackConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/ConntrackConvertorTest.java index a6a80e03ae..002755bc4d 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/ConntrackConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/ConntrackConvertorTest.java @@ -43,12 +43,12 @@ public class ConntrackConvertorTest { private ConntrackConvertor conntrackConvertor; @Before - public void setUp() throws Exception { + public void setUp() { conntrackConvertor = new ConntrackConvertor(); } @Test - public void testConvertToOfJava() throws Exception { + public void testConvertToOfJava() { final NxActionNatBuilder nxActionNatBuilder = new NxActionNatBuilder() .setFlags(1) @@ -103,7 +103,7 @@ public class ConntrackConvertorTest { } @Test - public void testConvertFromOfJava() throws Exception { + public void testConvertFromOfJava() { org.opendaylight.yang.gen.v1.urn.opendaylight.openflowjava.nx.action.rev140421.ofpact.actions.ofpact.actions .nx.action.nat._case.NxActionNatBuilder nxActionNatBuilder = new org.opendaylight.yang.gen.v1.urn diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/CtClearConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/CtClearConvertorTest.java index d1087596fe..c92b0b3bba 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/CtClearConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/CtClearConvertorTest.java @@ -41,7 +41,7 @@ public class CtClearConvertorTest { private CtClearConvertor ctClearConvertor; @Before - public void setUp() throws Exception { + public void setUp() { final NxCtClear nxCtClear = Mockito.mock(NxCtClear.class); final ActionCtClear actionCtClear = Mockito.mock(ActionCtClear.class); @@ -51,13 +51,13 @@ public class CtClearConvertorTest { } @Test - public void testConvert() throws Exception { + public void testConvert() { final ActionCtClear actionCtClear = (ActionCtClear) ctClearConvertor.convert(actionsCase).getActionChoice(); Assert.assertNotNull(actionCtClear); } @Test - public void testConvert1() throws Exception { + public void testConvert1() { final org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.Action actionResult = ctClearConvertor.convert(action, ActionPath.FLOWS_STATISTICS_UPDATE_APPLY_ACTIONS); Assert.assertNotNull(actionResult); diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/DecNshTtlConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/DecNshTtlConvertorTest.java index 003c64eacd..ac138c7bea 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/DecNshTtlConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/DecNshTtlConvertorTest.java @@ -34,7 +34,7 @@ public class DecNshTtlConvertorTest { private DecNshTtlConvertor decNshTtlConvertor; @Before - public void setUp() throws Exception { + public void setUp() { NxDecNshTtl nxDecNshTtl = Mockito.mock(NxDecNshTtl.class); NxActionDecNshTtl nxActionDecNshTtl = Mockito.mock(NxActionDecNshTtl.class); diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/DecapConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/DecapConvertorTest.java index 4bbac4979f..80ded836ca 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/DecapConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/DecapConvertorTest.java @@ -43,7 +43,7 @@ public class DecapConvertorTest { private DecapConvertor decapConvertor; @Before - public void setUp() throws Exception { + public void setUp() { NxDecap nxDecap = Mockito.mock(NxDecap.class); when(nxDecap.getPacketType()).thenReturn(PACKET_TYPE); when(actionsCase.getNxDecap()).thenReturn(nxDecap); diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/EncapConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/EncapConvertorTest.java index 81d216578d..fac72741fd 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/EncapConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/EncapConvertorTest.java @@ -43,7 +43,7 @@ public class EncapConvertorTest { private EncapConvertor encapConvertor; @Before - public void setUp() throws Exception { + public void setUp() { NxEncap nxEncap = Mockito.mock(NxEncap.class); when(nxEncap.getPacketType()).thenReturn(PACKET_TYPE); when(actionsCase.getNxEncap()).thenReturn(nxEncap); diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/FinTimeoutConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/FinTimeoutConvertorTest.java index 4da5062e5f..f740e70b12 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/FinTimeoutConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/FinTimeoutConvertorTest.java @@ -43,7 +43,7 @@ public class FinTimeoutConvertorTest { private FinTimeoutConvertor finTimeoutConvertor; @Before - public void setUp() throws Exception { + public void setUp() { final org.opendaylight.yang.gen.v1.urn.opendaylight.openflowplugin.extension.nicira.action.rev140714.nx.action .fin.timeout.grouping.NxActionFinTimeout nxFinTimeout = Mockito.mock(org.opendaylight.yang.gen.v1.urn .opendaylight.openflowplugin.extension.nicira.action.rev140714.nx.action.fin.timeout.grouping @@ -63,7 +63,7 @@ public class FinTimeoutConvertorTest { } @Test - public void testConvert() throws Exception { + public void testConvert() { final ActionFinTimeout actionFinTimeout = (ActionFinTimeout) finTimeoutConvertor.convert(actionsCase).getActionChoice(); Assert.assertEquals(1, actionFinTimeout.getNxActionFinTimeout().getFinIdleTimeout().intValue()); @@ -71,7 +71,7 @@ public class FinTimeoutConvertorTest { } @Test - public void testConvert1() throws Exception { + public void testConvert1() { final org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.Action actionResult = finTimeoutConvertor.convert(action, ActionPath.FLOWS_STATISTICS_UPDATE_APPLY_ACTIONS); diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/MultipathConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/MultipathConvertorTest.java index 9804a5f729..5de7ee640f 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/MultipathConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/MultipathConvertorTest.java @@ -54,7 +54,7 @@ public class MultipathConvertorTest { private MultipathConvertor multipathConvertor; @Before - public void setUp() throws Exception { + public void setUp() { final NxMultipath nxMultipath = Mockito.mock(NxMultipath.class); when(bucketActionsCase.getNxMultipath()).thenReturn(nxMultipath); @@ -85,7 +85,7 @@ public class MultipathConvertorTest { } @Test - public void testConvert() throws Exception { + public void testConvert() { final ActionMultipath actionMultipath = (ActionMultipath) multipathConvertor.convert(bucketActionsCase).getActionChoice(); Assert.assertEquals(OfjNxHashFields.NXHASHFIELDSETHSRC, actionMultipath.getNxActionMultipath().getFields()); @@ -97,7 +97,7 @@ public class MultipathConvertorTest { } @Test - public void testConvert1() throws Exception { + public void testConvert1() { final org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.Action actionResult = multipathConvertor.convert(action, ActionPath.FLOWS_STATISTICS_UPDATE_APPLY_ACTIONS); final org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.Action actionResult1 diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/OutputReg2ConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/OutputReg2ConvertorTest.java index d7605f82f8..154bf8370c 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/OutputReg2ConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/OutputReg2ConvertorTest.java @@ -51,7 +51,7 @@ public class OutputReg2ConvertorTest { private OutputReg2Convertor outputReg2Convertor; @Before - public void setUp() throws Exception { + public void setUp() { final NxOutputReg nxOutputReg = Mockito.mock(NxOutputReg.class); final Src src = Mockito.mock(Src.class); diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/OutputRegConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/OutputRegConvertorTest.java index 986ed95373..598b3e39ca 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/OutputRegConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/OutputRegConvertorTest.java @@ -52,7 +52,7 @@ public class OutputRegConvertorTest { private OutputRegConvertor outputRegConvertor; @Before - public void setUp() throws Exception { + public void setUp() { final NxOutputReg nxOutputReg = Mockito.mock(NxOutputReg.class); final Src src = Mockito.mock(Src.class); @@ -74,7 +74,7 @@ public class OutputRegConvertorTest { } @Test - public void testConvert() throws Exception { + public void testConvert() { final ActionOutputReg actionOutputReg = (ActionOutputReg) outputRegConvertor.convert(actionsCase).getActionChoice(); Assert.assertEquals(Integer.valueOf(1), actionOutputReg.getNxActionOutputReg().getNBits()); @@ -82,7 +82,7 @@ public class OutputRegConvertorTest { } @Test - public void testConvert1() throws Exception { + public void testConvert1() { final org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.Action actionResult = outputRegConvertor.convert(action, ActionPath.FLOWS_STATISTICS_UPDATE_APPLY_ACTIONS); final org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.Action actionResult1 diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/RegLoadConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/RegLoadConvertorTest.java index b5e99a24cf..68ad93a313 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/RegLoadConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/RegLoadConvertorTest.java @@ -53,7 +53,7 @@ public class RegLoadConvertorTest { private RegLoadConvertor regLoadConvertor; @Before - public void setUp() throws Exception { + public void setUp() { final NxRegLoad nxRegLoad = Mockito.mock(NxRegLoad.class); final Dst dst = Mockito.mock(Dst.class); @@ -76,14 +76,14 @@ public class RegLoadConvertorTest { } @Test - public void testConvert() throws Exception { + public void testConvert() { final ActionRegLoad actionRegLoad = (ActionRegLoad)regLoadConvertor.convert(actionsCase).getActionChoice(); Assert.assertEquals(Integer.valueOf(65), actionRegLoad.getNxActionRegLoad().getOfsNbits()); Assert.assertEquals(BigInteger.valueOf(3), actionRegLoad.getNxActionRegLoad().getValue()); } @Test - public void testConvert1() throws Exception { + public void testConvert1() { org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.Action actionResult = regLoadConvertor.convert(action, ActionPath.INVENTORY_FLOWNODE_TABLE_WRITE_ACTIONS); org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.Action actionResult1 diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/RegMoveConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/RegMoveConvertorTest.java index 1966331af4..3ab8c1ec90 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/RegMoveConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/RegMoveConvertorTest.java @@ -55,7 +55,7 @@ public class RegMoveConvertorTest { @Before - public void setUp() throws Exception { + public void setUp() { final Src src = Mockito.mock(Src.class); final Dst dst = Mockito.mock(Dst.class); @@ -85,7 +85,7 @@ public class RegMoveConvertorTest { } @Test - public void testConvert() throws Exception { + public void testConvert() { final ActionRegMove actionRegMove = (ActionRegMove) regMoveConvertor.convert(actionsCase).getActionChoice(); Assert.assertEquals(Integer.valueOf(3) ,actionRegMove.getNxActionRegMove().getDstOfs()); Assert.assertEquals(Integer.valueOf(2) ,actionRegMove.getNxActionRegMove().getNBits()); @@ -93,7 +93,7 @@ public class RegMoveConvertorTest { } @Test - public void testConvert1() throws Exception { + public void testConvert1() { final org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.Action actionResult = regMoveConvertor.convert(action, ActionPath.FLOWS_STATISTICS_UPDATE_APPLY_ACTIONS); final org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.Action actionResult1 diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/ResubmitConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/ResubmitConvertorTest.java index d471453934..de57518c8a 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/ResubmitConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/ResubmitConvertorTest.java @@ -48,7 +48,7 @@ public class ResubmitConvertorTest { private ResubmitConvertor resubmitConvertor; @Before - public void setUp() throws Exception { + public void setUp() { final NxResubmit nxResubmit = Mockito.mock(NxResubmit.class); when(actionsCase.getNxResubmit()).thenReturn(nxResubmit); when(nxResubmit.getInPort()).thenReturn(1); @@ -65,14 +65,14 @@ public class ResubmitConvertorTest { } @Test - public void testConvert() throws Exception { + public void testConvert() { final ActionResubmit actionResubmit = (ActionResubmit) resubmitConvertor.convert(actionsCase).getActionChoice(); Assert.assertEquals(1, actionResubmit.getNxActionResubmit().getInPort().intValue()); Assert.assertEquals(2, actionResubmit.getNxActionResubmit().getTable().intValue()); } @Test - public void testConvert1() throws Exception { + public void testConvert1() { final org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.Action actionResult = resubmitConvertor.convert(action, ActionPath.FLOWS_STATISTICS_UPDATE_APPLY_ACTIONS); final org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.Action actionResult1 diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/ArpOpConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/ArpOpConvertorTest.java index 4aa436c4b3..02dc505f0a 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/ArpOpConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/ArpOpConvertorTest.java @@ -52,12 +52,12 @@ public class ArpOpConvertorTest { private ArpOpConvertor arpOpConvertor; @Before - public void setUp() throws Exception { + public void setUp() { arpOpConvertor = new ArpOpConvertor(); } @Test - public void testConvertToOFJava() throws Exception { + public void testConvertToOFJava() { final NxmOfArpOpBuilder nxmOfArpOpBuilder = new NxmOfArpOpBuilder() .setValue(2); final NxAugMatchRpcAddFlowBuilder nxAugMatchRpcAddFlowBuilder = new NxAugMatchRpcAddFlowBuilder(); @@ -73,7 +73,7 @@ public class ArpOpConvertorTest { } @Test - public void testConvertFromOFJava() throws Exception { + public void testConvertFromOFJava() { final ArpOpBuilder arpOpBuilder = new ArpOpBuilder() .setOpCode(2); final ArpOpCaseBuilder arpOpCaseBuilder = new ArpOpCaseBuilder() diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/ArpShaConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/ArpShaConvertorTest.java index 311ef00770..919010bb0b 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/ArpShaConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/ArpShaConvertorTest.java @@ -54,7 +54,7 @@ public class ArpShaConvertorTest { private static final Logger LOG = LoggerFactory.getLogger(ArpShaConvertorTest.class); @Before - public void setUp() throws Exception { + public void setUp() { final NxmNxArpShaBuilder nxmNxArpShaBuilder = new NxmNxArpShaBuilder() .setMacAddress(MAC_ADDRESS); final NxAugMatchRpcAddFlowBuilder nxAugMatchRpcAddFlowBuilder = new NxAugMatchRpcAddFlowBuilder() @@ -68,14 +68,14 @@ public class ArpShaConvertorTest { } @Test - public void testConvertToOFJava() throws Exception { + public void testConvertToOFJava() { final MatchEntry converted = arpShaConvertor.convert(extension); Assert.assertEquals(MAC_ADDRESS.getValue(), ((ArpShaCaseValue) converted.getMatchEntryValue()).getArpShaValues().getMacAddress().getValue()); } @Test - public void testConvertFromOFJava() throws Exception { + public void testConvertFromOFJava() { final ArpShaValuesBuilder arpShaValuesBuilder = new ArpShaValuesBuilder() .setMacAddress(MAC_ADDRESS); final ArpShaCaseValueBuilder arpShaCaseValueBuilder = new ArpShaCaseValueBuilder() diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/ArpSpaConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/ArpSpaConvertorTest.java index 60189a0812..4c1e41af7b 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/ArpSpaConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/ArpSpaConvertorTest.java @@ -51,12 +51,12 @@ public class ArpSpaConvertorTest { private ArpSpaConvertor arpSpaConvertor; @Before - public void setUp() throws Exception { + public void setUp() { arpSpaConvertor = new ArpSpaConvertor(); } @Test - public void testConvertToOFJava() throws Exception { + public void testConvertToOFJava() { final NxmOfArpSpaBuilder nxmOfArpSpaBuilder = new NxmOfArpSpaBuilder() .setIpv4Address(IPV4_ADDRESS); final NxAugMatchRpcAddFlowBuilder nxAugMatchRpcAddFlowBuilder = new NxAugMatchRpcAddFlowBuilder(); @@ -72,7 +72,7 @@ public class ArpSpaConvertorTest { } @Test - public void testConvertFromOFJava() throws Exception { + public void testConvertFromOFJava() { final ArpSpaValuesBuilder arpSpaValuesBuilder = new ArpSpaValuesBuilder() .setValue(IpConverter.ipv4AddressToLong(IPV4_ADDRESS)); final ArpSpaCaseValueBuilder arpSpaCaseValueBuilder = new ArpSpaCaseValueBuilder() diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/ArpThaConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/ArpThaConvertorTest.java index 0209949d71..25b4405796 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/ArpThaConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/ArpThaConvertorTest.java @@ -50,7 +50,7 @@ public class ArpThaConvertorTest { private ArpThaConvertor arpThaConvertor; @Before - public void setUp() throws Exception { + public void setUp() { final NxmNxArpThaBuilder nxArpThaBuilder = new NxmNxArpThaBuilder() .setMacAddress(MAC_ADDRESS); @@ -65,14 +65,14 @@ public class ArpThaConvertorTest { } @Test - public void testConvertToOFJava() throws Exception { + public void testConvertToOFJava() { final MatchEntry converted = arpThaConvertor.convert(extension); Assert.assertEquals(MAC_ADDRESS.getValue(), ((ArpThaCaseValue) converted.getMatchEntryValue()).getArpThaValues().getMacAddress().getValue()); } @Test - public void testConvertFromOFJava() throws Exception { + public void testConvertFromOFJava() { final ArpThaValuesBuilder arpThaValuesBuilder = new ArpThaValuesBuilder() .setMacAddress(MAC_ADDRESS); final ArpThaCaseValueBuilder arpThaCaseValueBuilder = new ArpThaCaseValueBuilder() diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/ArpTpaConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/ArpTpaConvertorTest.java index 6ca886d9de..0d7e490b57 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/ArpTpaConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/ArpTpaConvertorTest.java @@ -51,7 +51,7 @@ public class ArpTpaConvertorTest { private ArpTpaConvertor arpTpaConvertor; @Before - public void setUp() throws Exception { + public void setUp() { final NxmOfArpTpaBuilder nxmOfArpTpaBuilder = new NxmOfArpTpaBuilder() .setIpv4Address(IPV4_ADDRESS); @@ -66,14 +66,14 @@ public class ArpTpaConvertorTest { } @Test - public void testConvertFromOFJava() throws Exception { + public void testConvertFromOFJava() { final MatchEntry converted = arpTpaConvertor.convert(extension); Assert.assertEquals(IpConverter.ipv4AddressToLong(IPV4_ADDRESS), ((ArpTpaCaseValue)converted.getMatchEntryValue()).getArpTpaValues().getValue().longValue()); } @Test - public void testConvertToOFJava() throws Exception { + public void testConvertToOFJava() { final ArpTpaValuesBuilder arpTpaValuesBuilder = new ArpTpaValuesBuilder() .setValue(IpConverter.ipv4AddressToLong(IPV4_ADDRESS)); final ArpTpaCaseValueBuilder arpTpaCaseValueBuilder = new ArpTpaCaseValueBuilder() diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/CtStateConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/CtStateConvertorTest.java index 6e1a816620..25aca9fa57 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/CtStateConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/CtStateConvertorTest.java @@ -47,7 +47,7 @@ public class CtStateConvertorTest { private CtStateConvertor ctStateConvertor; @Before - public void setUp() throws Exception { + public void setUp() { final NxmNxCtStateBuilder nxmNxCtStateBuilder = new NxmNxCtStateBuilder() .setCtState(1L) @@ -64,7 +64,7 @@ public class CtStateConvertorTest { } @Test - public void testConvert() throws Exception { + public void testConvert() { final MatchEntry converted = ctStateConvertor.convert(extension); Assert.assertEquals(1L, ((CtStateCaseValue) converted.getMatchEntryValue()).getCtStateValues().getCtState().longValue()); @@ -73,7 +73,7 @@ public class CtStateConvertorTest { } @Test - public void testConvert1() throws Exception { + public void testConvert1() { final CtStateValuesBuilder ctStateValuesBuilder = new CtStateValuesBuilder() .setCtState(3L) diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/CtZoneConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/CtZoneConvertorTest.java index 77fcb962ec..0408ef9cbc 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/CtZoneConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/CtZoneConvertorTest.java @@ -47,7 +47,7 @@ public class CtZoneConvertorTest { private CtZoneConvertor ctZoneConvertor; @Before - public void setUp() throws Exception { + public void setUp() { final NxmNxCtZoneBuilder nxmNxCtZoneBuilder = new NxmNxCtZoneBuilder() .setCtZone(1); @@ -64,14 +64,14 @@ public class CtZoneConvertorTest { } @Test - public void testConvert() throws Exception { + public void testConvert() { final MatchEntry converted = ctZoneConvertor.convert(extension); Assert.assertEquals(1L, ((CtZoneCaseValue) converted.getMatchEntryValue()).getCtZoneValues().getCtZone().longValue()); } @Test - public void testConvert1() throws Exception { + public void testConvert1() { final CtZoneValuesBuilder ctZoneValuesBuilder = new CtZoneValuesBuilder() .setCtZone(2); final CtZoneCaseValueBuilder ctZoneCaseValueBuilder = new CtZoneCaseValueBuilder() diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/EthDstConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/EthDstConvertorTest.java index 4aa0c2df5f..fba0c9c718 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/EthDstConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/EthDstConvertorTest.java @@ -50,7 +50,7 @@ public class EthDstConvertorTest { private EthDstConvertor ethDstConvertor; @Before - public void setUp() throws Exception { + public void setUp() { final NxmOfEthDstBuilder nxmOfEthDstBuilder = new NxmOfEthDstBuilder() .setMacAddress(MAC_ADDRESS); @@ -67,14 +67,14 @@ public class EthDstConvertorTest { } @Test - public void testConvert() throws Exception { + public void testConvert() { final MatchEntry converted = ethDstConvertor.convert(extension); Assert.assertEquals(MAC_ADDRESS, ((EthDstCaseValue)converted.getMatchEntryValue()) .getEthDstValues().getMacAddress()); } @Test - public void testConvert1() throws Exception { + public void testConvert1() { final EthDstValuesBuilder ethDstValuesBuilder = new EthDstValuesBuilder() .setMacAddress(MAC_ADDRESS); final EthDstCaseValueBuilder ethDstCaseValueBuilder = new EthDstCaseValueBuilder() diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/EthSrcConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/EthSrcConvertorTest.java index ca60bfe024..f45812a1a4 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/EthSrcConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/EthSrcConvertorTest.java @@ -50,7 +50,7 @@ public class EthSrcConvertorTest { private EthSrcConvertor ethSrcConvertor; @Before - public void setUp() throws Exception { + public void setUp() { final NxmOfEthSrcBuilder nxmOfEthSrcBuilder = new NxmOfEthSrcBuilder() .setMacAddress(MAC_ADDRESS); final NxAugMatchNodesNodeTableFlowBuilder nxAugMatchNotifUpdateFlowStatsBuilder = @@ -65,14 +65,14 @@ public class EthSrcConvertorTest { } @Test - public void testConvert() throws Exception { + public void testConvert() { final MatchEntry converted = ethSrcConvertor.convert(extension); Assert.assertEquals(MAC_ADDRESS, ((EthSrcCaseValue)converted.getMatchEntryValue()) .getEthSrcValues().getMacAddress()); } @Test - public void testConvert1() throws Exception { + public void testConvert1() { final EthSrcValuesBuilder ethSrcValuesBuilder = new EthSrcValuesBuilder() .setMacAddress(MAC_ADDRESS); final EthSrcCaseValueBuilder ethSrcCaseValueBuilder = new EthSrcCaseValueBuilder() diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/EthTypeConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/EthTypeConvertorTest.java index 318cbfbceb..50d745d238 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/EthTypeConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/EthTypeConvertorTest.java @@ -47,7 +47,7 @@ public class EthTypeConvertorTest { private EthTypeConvertor ethTypeConvertor; @Before - public void setUp() throws Exception { + public void setUp() { final NxmOfEthTypeBuilder nxmOfEthTypeBuilder = new NxmOfEthTypeBuilder() .setValue(1); @@ -64,14 +64,14 @@ public class EthTypeConvertorTest { } @Test - public void testConvert() throws Exception { + public void testConvert() { final MatchEntry converted = ethTypeConvertor.convert(extension); Assert.assertEquals(1, ((EthTypeCaseValue)converted.getMatchEntryValue()) .getEthTypeValues().getValue().intValue()); } @Test - public void testConvert1() throws Exception { + public void testConvert1() { final EthTypeValuesBuilder ethTypeValuesBuilder = new EthTypeValuesBuilder() .setValue(Integer.valueOf(1)); final EthTypeCaseValueBuilder ethTypeCaseValueBuilder = new EthTypeCaseValueBuilder() diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NshFlagsConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NshFlagsConvertorTest.java index 8e0f6064a7..889809a319 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NshFlagsConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NshFlagsConvertorTest.java @@ -45,7 +45,7 @@ public class NshFlagsConvertorTest { private static final Short MASK_VALUE = (short) 0xFF; @Before - public void setUp() throws Exception { + public void setUp() { NxmNxNshFlags nxmNxNshFlags = new NxmNxNshFlagsBuilder() .setNshFlags(FLAGS_VALUE) .setMask(MASK_VALUE) diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NshMdtypeConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NshMdtypeConvertorTest.java index 4c2b32b19c..fff6512b73 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NshMdtypeConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NshMdtypeConvertorTest.java @@ -45,7 +45,7 @@ public class NshMdtypeConvertorTest { private static final Short MDTYPE_VALUE = (short) 0x7B; @Before - public void setUp() throws Exception { + public void setUp() { NxmNxNshMdtype nxmNxNshMdtype = new NxmNxNshMdtypeBuilder() .setValue(MDTYPE_VALUE) .build(); diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NshNpConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NshNpConvertorTest.java index f838f77bbe..b8028103f7 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NshNpConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NshNpConvertorTest.java @@ -45,7 +45,7 @@ public class NshNpConvertorTest { private static final Short NP_VALUE = (short) 0x7B; @Before - public void setUp() throws Exception { + public void setUp() { NxmNxNshNp nxmNxNshNp = new NxmNxNshNpBuilder() .setValue(NP_VALUE) .build(); diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NshTtlConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NshTtlConvertorTest.java index b854eba651..650f1c1496 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NshTtlConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NshTtlConvertorTest.java @@ -44,7 +44,7 @@ public class NshTtlConvertorTest { private static final Short TTL_VALUE = (short) 0x13; @Before - public void setUp() throws Exception { + public void setUp() { NxmNxNshTtl nxmNxNshTtl = new NxmNxNshTtlBuilder() .setNshTtl(TTL_VALUE) .build(); diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/Nshc1ConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/Nshc1ConvertorTest.java index ab2ee05ab4..6a18a7976b 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/Nshc1ConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/Nshc1ConvertorTest.java @@ -49,7 +49,7 @@ public class Nshc1ConvertorTest { private static final Long MASK_VALUE = 0xFFFFFFFFL; @Before - public void setUp() throws Exception { + public void setUp() { NxmNxNshc1 nxmNxNshc1 = new NxmNxNshc1Builder().setValue(NSHC1_VALUE).setMask(MASK_VALUE).build(); NxAugMatchNodesNodeTableFlow nxAugMatchNotifUpdateFlowStats = new NxAugMatchNodesNodeTableFlowBuilder() .setNxmNxNshc1(nxmNxNshc1) diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/Nshc2ConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/Nshc2ConvertorTest.java index 3f40885ed6..5ddc1f9790 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/Nshc2ConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/Nshc2ConvertorTest.java @@ -49,7 +49,7 @@ public class Nshc2ConvertorTest { private static final Long MASK_VALUE = 0xFFFFFFFFL; @Before - public void setUp() throws Exception { + public void setUp() { NxmNxNshc2 nxmNxNshc2 = new NxmNxNshc2Builder().setValue(NSHC2_VALUE).setMask(MASK_VALUE).build(); NxAugMatchNodesNodeTableFlow nxAugMatchNotifUpdateFlowStats = new NxAugMatchNodesNodeTableFlowBuilder() .setNxmNxNshc2(nxmNxNshc2) diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/Nshc3ConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/Nshc3ConvertorTest.java index d76a113883..e8ecdedb2e 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/Nshc3ConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/Nshc3ConvertorTest.java @@ -49,7 +49,7 @@ public class Nshc3ConvertorTest { private static final Long MASK_VALUE = 0xFFFFFFFFL; @Before - public void setUp() throws Exception { + public void setUp() { NxmNxNshc3 nxmNxNshc3 = new NxmNxNshc3Builder().setValue(NSHC3_VALUE).setMask(MASK_VALUE).build(); NxAugMatchNodesNodeTableFlow nxAugMatchNotifUpdateFlowStats = new NxAugMatchNodesNodeTableFlowBuilder() .setNxmNxNshc3(nxmNxNshc3) diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/Nshc4ConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/Nshc4ConvertorTest.java index 5037b3cce5..57d1dbadf1 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/Nshc4ConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/Nshc4ConvertorTest.java @@ -49,7 +49,7 @@ public class Nshc4ConvertorTest { private static final Long MASK_VALUE = 0xFFFFFFFFL; @Before - public void setUp() throws Exception { + public void setUp() { NxmNxNshc4 nxmNxNshc4 = new NxmNxNshc4Builder().setValue(NSHC4_VALUE).setMask(MASK_VALUE).build(); NxAugMatchNodesNodeTableFlow nxAugMatchNotifUpdateFlowStats = new NxAugMatchNodesNodeTableFlowBuilder() .setNxmNxNshc4(nxmNxNshc4) diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NsiConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NsiConvertorTest.java index b931247b4b..dc25cb16f7 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NsiConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NsiConvertorTest.java @@ -48,7 +48,7 @@ public class NsiConvertorTest { private static final Short NSI_VALUE = (short) 255; @Before - public void setUp() throws Exception { + public void setUp() { NxmNxNsi nxmNxNsi = new NxmNxNsiBuilder().setNsi(NSI_VALUE).build(); NxAugMatchNodesNodeTableFlow nxAugMatchNotifUpdateFlowStats = new NxAugMatchNodesNodeTableFlowBuilder() .setNxmNxNsi(nxmNxNsi) diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NspConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NspConvertorTest.java index e66099b6ce..55c42c19b2 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NspConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/NspConvertorTest.java @@ -48,7 +48,7 @@ public class NspConvertorTest { private static final Long NSP_VALUE = 0xFFL; @Before - public void setUp() throws Exception { + public void setUp() { NxmNxNsp nxmNxNsp = new NxmNxNspBuilder().setValue(NSP_VALUE).build(); NxAugMatchNodesNodeTableFlow nxAugMatchNotifUpdateFlowStats = new NxAugMatchNodesNodeTableFlowBuilder() .setNxmNxNsp(nxmNxNsp) diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/TcpDstConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/TcpDstConvertorTest.java index 936b41f1d5..8128f8b208 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/TcpDstConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/TcpDstConvertorTest.java @@ -49,7 +49,7 @@ public class TcpDstConvertorTest { private TcpDstConvertor tcpDstConvertor; @Before - public void setUp() throws Exception { + public void setUp() { final NxmOfTcpDstBuilder nxmOfTcpDstBuilder = new NxmOfTcpDstBuilder() .setMask(1) .setPort(DEFAULT_PORT); @@ -65,7 +65,7 @@ public class TcpDstConvertorTest { } @Test - public void testConvert() throws Exception { + public void testConvert() { final MatchEntry converted = tcpDstConvertor.convert(extension); Assert.assertEquals(1, ((TcpDstCaseValue) converted.getMatchEntryValue()).getTcpDstValues().getMask().intValue()); @@ -74,7 +74,7 @@ public class TcpDstConvertorTest { } @Test - public void testConvert1() throws Exception { + public void testConvert1() { final TcpDstValuesBuilder tcpDstValuesBuilder = new TcpDstValuesBuilder() .setMask(2) .setPort(DEFAULT_PORT); diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/TcpSrcConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/TcpSrcConvertorTest.java index 0470ba9d3d..22f38f2ac5 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/TcpSrcConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/TcpSrcConvertorTest.java @@ -49,7 +49,7 @@ public class TcpSrcConvertorTest { private TcpSrcConvertor tcpSrcConvertor; @Before - public void setUp() throws Exception { + public void setUp() { final NxmOfTcpSrcBuilder nxmOfTcpSrcBuilder = new NxmOfTcpSrcBuilder() .setMask(1) .setPort(DEFAULT_PORT); @@ -65,7 +65,7 @@ public class TcpSrcConvertorTest { } @Test - public void testConvert() throws Exception { + public void testConvert() { final MatchEntry converted = tcpSrcConvertor.convert(extension); Assert.assertEquals(1, ((TcpSrcCaseValue) converted.getMatchEntryValue()).getTcpSrcValues().getMask().intValue()); @@ -74,7 +74,7 @@ public class TcpSrcConvertorTest { } @Test - public void testConvert1() throws Exception { + public void testConvert1() { final TcpSrcValuesBuilder tcpSrcValuesBuilder = new TcpSrcValuesBuilder() .setMask(2) .setPort(DEFAULT_PORT); diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/TunIPv4DstConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/TunIPv4DstConvertorTest.java index b85e48ae38..7f32a2dce5 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/TunIPv4DstConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/TunIPv4DstConvertorTest.java @@ -50,7 +50,7 @@ public class TunIPv4DstConvertorTest { private TunIPv4DstConvertor tunIPv4DstConvertor; @Before - public void setUp() throws Exception { + public void setUp() { final NxmNxTunIpv4DstBuilder nxmNxTunIpv4DstBuilder = new NxmNxTunIpv4DstBuilder() .setIpv4Address(IPV4_ADDRESS); final NxAugMatchNodesNodeTableFlowBuilder nxAugMatchNotifUpdateFlowStatsBuilder = @@ -65,14 +65,14 @@ public class TunIPv4DstConvertorTest { } @Test - public void testConvert() throws Exception { + public void testConvert() { final MatchEntry converted = tunIPv4DstConvertor.convert(extension); Assert.assertEquals(IpConverter.ipv4AddressToLong(IPV4_ADDRESS), ((TunIpv4DstCaseValue)converted.getMatchEntryValue()).getTunIpv4DstValues().getValue().longValue()); } @Test - public void testConvert1() throws Exception { + public void testConvert1() { final TunIpv4DstValuesBuilder tunIpv4DstValuesBuilder = new TunIpv4DstValuesBuilder() .setValue(IpConverter.ipv4AddressToLong(IPV4_ADDRESS)); final TunIpv4DstCaseValueBuilder tunIpv4DstCaseValueBuilder = new TunIpv4DstCaseValueBuilder() diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/TunIPv4SrcConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/TunIPv4SrcConvertorTest.java index d3c257cdf7..5d6083b273 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/TunIPv4SrcConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/TunIPv4SrcConvertorTest.java @@ -50,7 +50,7 @@ public class TunIPv4SrcConvertorTest { private TunIPv4SrcConvertor tunIPv4DstConvertor; @Before - public void setUp() throws Exception { + public void setUp() { final NxmNxTunIpv4SrcBuilder nxmNxTunIpv4SrcBuilder = new NxmNxTunIpv4SrcBuilder() .setIpv4Address(IPV4_ADDRESS); final NxAugMatchNodesNodeTableFlowBuilder nxAugMatchNotifUpdateFlowStatsBuilder = @@ -65,14 +65,14 @@ public class TunIPv4SrcConvertorTest { } @Test - public void testConvert() throws Exception { + public void testConvert() { final MatchEntry converted = tunIPv4DstConvertor.convert(extension); Assert.assertEquals(IpConverter.ipv4AddressToLong(IPV4_ADDRESS), ((TunIpv4SrcCaseValue) converted.getMatchEntryValue()).getTunIpv4SrcValues().getValue().longValue()); } @Test - public void testConvert1() throws Exception { + public void testConvert1() { final TunIpv4SrcValuesBuilder tunIpv4SrcValuesBuilder = new TunIpv4SrcValuesBuilder() .setValue(IpConverter.ipv4AddressToLong(IPV4_ADDRESS)); final TunIpv4SrcCaseValueBuilder tunIpv4SrcCaseValueBuilder = new TunIpv4SrcCaseValueBuilder() diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/TunIdConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/TunIdConvertorTest.java index 75017d66aa..eef4946af8 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/TunIdConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/TunIdConvertorTest.java @@ -47,7 +47,7 @@ public class TunIdConvertorTest { private TunIdConvertor tunIdConvertor; @Before - public void setUp() throws Exception { + public void setUp() { final NxmNxTunIdBuilder nxmNxTunIdBuilder = new NxmNxTunIdBuilder() .setValue(BigInteger.ONE); final NxAugMatchNodesNodeTableFlowBuilder nxAugMatchNotifUpdateFlowStatsBuilder = @@ -62,14 +62,14 @@ public class TunIdConvertorTest { } @Test - public void testConvert() throws Exception { + public void testConvert() { final MatchEntry converted = tunIdConvertor.convert(extension); Assert.assertEquals(BigInteger.ONE, ((TunIdCaseValue)converted.getMatchEntryValue()) .getTunIdValues().getValue()); } @Test - public void testConvert1() throws Exception { + public void testConvert1() { final TunIdValuesBuilder tunIdValuesBuilder = new TunIdValuesBuilder() .setValue(BigInteger.TEN); final TunIdCaseValueBuilder tunIdCaseValueBuilder = new TunIdCaseValueBuilder() diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/UdpDstConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/UdpDstConvertorTest.java index 2bef460866..fb7aa8ebe5 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/UdpDstConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/UdpDstConvertorTest.java @@ -49,7 +49,7 @@ public class UdpDstConvertorTest { private UdpDstConvertor udpDstConvertor; @Before - public void setUp() throws Exception { + public void setUp() { final NxmOfUdpDstBuilder nxmOfUdpDstBuilder = new NxmOfUdpDstBuilder() .setMask(1) .setPort(DEFAULT_PORT); @@ -65,7 +65,7 @@ public class UdpDstConvertorTest { } @Test - public void testConvert() throws Exception { + public void testConvert() { final MatchEntry converted = udpDstConvertor.convert(extension); Assert.assertEquals(Integer.valueOf(1), ((UdpDstCaseValue) converted.getMatchEntryValue()).getUdpDstValues().getMask()); @@ -74,7 +74,7 @@ public class UdpDstConvertorTest { } @Test - public void testConvert1() throws Exception { + public void testConvert1() { final UdpDstValuesBuilder udpDstValuesBuilder = new UdpDstValuesBuilder() .setMask(2) .setPort(DEFAULT_PORT); diff --git a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/UdpSrcConvertorTest.java b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/UdpSrcConvertorTest.java index 07b5aa2296..71f2159080 100644 --- a/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/UdpSrcConvertorTest.java +++ b/extension/openflowplugin-extension-nicira/src/test/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/match/UdpSrcConvertorTest.java @@ -49,7 +49,7 @@ public class UdpSrcConvertorTest { private UdpSrcConvertor udpSrcConvertor; @Before - public void setUp() throws Exception { + public void setUp() { final NxmOfUdpSrcBuilder nxmOfUdpSrcBuilder = new NxmOfUdpSrcBuilder() .setMask(1) .setPort(DEFAULT_PORT); @@ -65,7 +65,7 @@ public class UdpSrcConvertorTest { } @Test - public void testConvert() throws Exception { + public void testConvert() { final MatchEntry converted = udpSrcConvertor.convert(extension); Assert.assertEquals(Integer.valueOf(1), ((UdpSrcCaseValue) converted.getMatchEntryValue()).getUdpSrcValues().getMask()); @@ -74,7 +74,7 @@ public class UdpSrcConvertorTest { } @Test - public void testConvert1() throws Exception { + public void testConvert1() { final UdpSrcValuesBuilder udpSrcValuesBuilder = new UdpSrcValuesBuilder() .setMask(2) .setPort(DEFAULT_PORT); diff --git a/extension/openflowplugin-extension-onf/src/main/java/org/opendaylight/openflowplugin/extension/onf/converter/BundleAddMessageConverter.java b/extension/openflowplugin-extension-onf/src/main/java/org/opendaylight/openflowplugin/extension/onf/converter/BundleAddMessageConverter.java index 9c74354327..0d9347621b 100644 --- a/extension/openflowplugin-extension-onf/src/main/java/org/opendaylight/openflowplugin/extension/onf/converter/BundleAddMessageConverter.java +++ b/extension/openflowplugin-extension-onf/src/main/java/org/opendaylight/openflowplugin/extension/onf/converter/BundleAddMessageConverter.java @@ -98,8 +98,7 @@ public class BundleAddMessageConverter implements } @Override - public BundleAddMessageSal convert(final BundleAddMessageOnf input, final MessagePath path) - throws ConversionException { + public BundleAddMessageSal convert(final BundleAddMessageOnf input, final MessagePath path) { return new BundleAddMessageSalBuilder() .setSalAddMessageData(new SalAddMessageDataBuilder(input.getOnfAddMessageGroupingData()) .build()) diff --git a/extension/openflowplugin-extension-onf/src/main/java/org/opendaylight/openflowplugin/extension/onf/converter/BundleControlConverter.java b/extension/openflowplugin-extension-onf/src/main/java/org/opendaylight/openflowplugin/extension/onf/converter/BundleControlConverter.java index 6ea9f081e5..f717f6e1c9 100644 --- a/extension/openflowplugin-extension-onf/src/main/java/org/opendaylight/openflowplugin/extension/onf/converter/BundleControlConverter.java +++ b/extension/openflowplugin-extension-onf/src/main/java/org/opendaylight/openflowplugin/extension/onf/converter/BundleControlConverter.java @@ -11,7 +11,6 @@ package org.opendaylight.openflowplugin.extension.onf.converter; import org.opendaylight.openflowplugin.extension.api.ConverterMessageToOFJava; import org.opendaylight.openflowplugin.extension.api.ConvertorMessageFromOFJava; import org.opendaylight.openflowplugin.extension.api.ExtensionConvertorData; -import org.opendaylight.openflowplugin.extension.api.exception.ConversionException; import org.opendaylight.openflowplugin.extension.api.path.MessagePath; import org.opendaylight.openflowplugin.extension.onf.OnfConstants; import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.common.types.rev130731.ExperimenterId; @@ -30,8 +29,7 @@ public class BundleControlConverter implements ConvertorMessageFromOFJava { @Override - public BundleControlOnf convert(final BundleControlSal experimenterMessageCase, final ExtensionConvertorData data) - throws ConversionException { + public BundleControlOnf convert(final BundleControlSal experimenterMessageCase, final ExtensionConvertorData data) { return new BundleControlOnfBuilder().setOnfControlGroupingData( new OnfControlGroupingDataBuilder(experimenterMessageCase.getSalControlData()).build()).build(); } diff --git a/extension/openflowplugin-extension-onf/src/test/java/org/opendaylight/openflowplugin/extension/onf/OnfExtensionProviderTest.java b/extension/openflowplugin-extension-onf/src/test/java/org/opendaylight/openflowplugin/extension/onf/OnfExtensionProviderTest.java index 4987a2cee7..60c6d7eeb0 100644 --- a/extension/openflowplugin-extension-onf/src/test/java/org/opendaylight/openflowplugin/extension/onf/OnfExtensionProviderTest.java +++ b/extension/openflowplugin-extension-onf/src/test/java/org/opendaylight/openflowplugin/extension/onf/OnfExtensionProviderTest.java @@ -32,7 +32,7 @@ public class OnfExtensionProviderTest { private OnfExtensionProvider onfExtensionProvider; @Before - public void setUp() throws Exception { + public void setUp() { Mockito .when(openFlowPluginExtensionRegistratorProvider.getExtensionConverterRegistrator()) .thenReturn(extensionConverterRegistrator); @@ -42,7 +42,7 @@ public class OnfExtensionProviderTest { } @Test - public void init() throws Exception { + public void init() { onfExtensionProvider.init(); Mockito.verify(switchConnectionProvider, Mockito.times(2)) .registerExperimenterMessageSerializer(Mockito.any(), Mockito.any()); diff --git a/extension/openflowplugin-extension-onf/src/test/java/org/opendaylight/openflowplugin/extension/onf/converter/BundleAddMessageConverterTest.java b/extension/openflowplugin-extension-onf/src/test/java/org/opendaylight/openflowplugin/extension/onf/converter/BundleAddMessageConverterTest.java index aadcfdce08..c7c621b206 100644 --- a/extension/openflowplugin-extension-onf/src/test/java/org/opendaylight/openflowplugin/extension/onf/converter/BundleAddMessageConverterTest.java +++ b/extension/openflowplugin-extension-onf/src/test/java/org/opendaylight/openflowplugin/extension/onf/converter/BundleAddMessageConverterTest.java @@ -72,7 +72,7 @@ public class BundleAddMessageConverterTest { private static final GroupId GROUP_ID = new GroupId(1L); @Before - public void setUp() throws Exception { + public void setUp() { } @Test diff --git a/extension/openflowplugin-extension-onf/src/test/java/org/opendaylight/openflowplugin/extension/onf/converter/BundleControlConverterTest.java b/extension/openflowplugin-extension-onf/src/test/java/org/opendaylight/openflowplugin/extension/onf/converter/BundleControlConverterTest.java index f7e68c2fb7..2afe830f48 100644 --- a/extension/openflowplugin-extension-onf/src/test/java/org/opendaylight/openflowplugin/extension/onf/converter/BundleControlConverterTest.java +++ b/extension/openflowplugin-extension-onf/src/test/java/org/opendaylight/openflowplugin/extension/onf/converter/BundleControlConverterTest.java @@ -47,12 +47,12 @@ public class BundleControlConverterTest { } @Test - public void testConvertDownWithProperty() throws Exception { + public void testConvertDownWithProperty() { testConvertDown(true); } @Test - public void testConvertDownWithoutProperty() throws Exception { + public void testConvertDownWithoutProperty() { testConvertDown(false); } @@ -66,7 +66,7 @@ public class BundleControlConverterTest { testConvertUp(true); } - private void testConvertDown(final boolean withProperty) throws Exception { + private void testConvertDown(final boolean withProperty) { final BundleControlSal original = createOFPMessage(withProperty); final BundleControlOnf converted = converter.convert(original, null); testConvert(original, converted, withProperty); diff --git a/libraries/liblldp/src/main/java/org/opendaylight/openflowplugin/libraries/liblldp/LLDPTLV.java b/libraries/liblldp/src/main/java/org/opendaylight/openflowplugin/libraries/liblldp/LLDPTLV.java index 71bd964d66..85c9d0b9dc 100644 --- a/libraries/liblldp/src/main/java/org/opendaylight/openflowplugin/libraries/liblldp/LLDPTLV.java +++ b/libraries/liblldp/src/main/java/org/opendaylight/openflowplugin/libraries/liblldp/LLDPTLV.java @@ -380,11 +380,11 @@ public class LLDPTLV extends Packet { return BitBufferHelper.getByte(ArrayUtils.subarray(value, 3, 4)); } - public static CustomTLVKey createPortSubTypeCustomTLVKey() throws BufferException { + public static CustomTLVKey createPortSubTypeCustomTLVKey() { return new CustomTLVKey(BitBufferHelper.getInt(OFOUI), CUSTOM_TLV_SUB_TYPE_NODE_CONNECTOR_ID[0]); } - public static CustomTLVKey createSecSubTypeCustomTLVKey() throws BufferException { + public static CustomTLVKey createSecSubTypeCustomTLVKey() { return new CustomTLVKey(BitBufferHelper.getInt(LLDPTLV.OFOUI), LLDPTLV.CUSTOM_TLV_SUB_TYPE_CUSTOM_SEC[0]); } } diff --git a/libraries/liblldp/src/test/java/org/opendaylight/openflowplugin/libraries/liblldp/LLDPTLVTest.java b/libraries/liblldp/src/test/java/org/opendaylight/openflowplugin/libraries/liblldp/LLDPTLVTest.java index 29ed516706..a333d5d89f 100644 --- a/libraries/liblldp/src/test/java/org/opendaylight/openflowplugin/libraries/liblldp/LLDPTLVTest.java +++ b/libraries/liblldp/src/test/java/org/opendaylight/openflowplugin/libraries/liblldp/LLDPTLVTest.java @@ -58,7 +58,7 @@ public class LLDPTLVTest { * {@link org.opendaylight.openflowplugin.libraries.liblldp.LLDPTLV#getCustomString(byte[], int)}. */ @Test - public void testGetCustomString() throws Exception { + public void testGetCustomString() { byte[] inputCustomTlv = Bytes.concat(new byte[] { // custom type (7b) + length (9b) = 16b = 2B (skipped) // 0x7f, 24, diff --git a/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/IdleHandler.java b/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/IdleHandler.java index 8ef46bb184..4515da5749 100644 --- a/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/IdleHandler.java +++ b/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/IdleHandler.java @@ -39,7 +39,7 @@ public class IdleHandler extends ReadTimeoutHandler { } @Override - protected void readTimedOut(final ChannelHandlerContext ctx) throws Exception { + protected void readTimedOut(final ChannelHandlerContext ctx) { if (first) { LOG.debug("Switch idle"); SwitchIdleEventBuilder builder = new SwitchIdleEventBuilder(); diff --git a/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/OFDatagramPacketDecoder.java b/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/OFDatagramPacketDecoder.java index 66c36524ea..91b9947d6c 100644 --- a/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/OFDatagramPacketDecoder.java +++ b/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/OFDatagramPacketDecoder.java @@ -29,8 +29,7 @@ public class OFDatagramPacketDecoder extends SimpleChannelInboundHandler out) throws Exception { + List out) { LOG.debug("OFDatagramPacketFramer"); MessageConsumer consumer = UdpConnectionMap.getMessageConsumer(msg.sender()); if (consumer == null) { diff --git a/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/OFDecoder.java b/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/OFDecoder.java index 39b278fb52..76aa09ed5c 100644 --- a/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/OFDecoder.java +++ b/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/OFDecoder.java @@ -40,7 +40,7 @@ public class OFDecoder extends MessageToMessageDecoder { @Override @SuppressWarnings("checkstyle:IllegalCatch") - protected void decode(ChannelHandlerContext ctx, VersionMessageWrapper msg, List out) throws Exception { + protected void decode(ChannelHandlerContext ctx, VersionMessageWrapper msg, List out) { statisticsCounter.incrementCounter(CounterEventTypes.US_RECEIVED_IN_OFJAVA); if (LOG.isDebugEnabled()) { LOG.debug("VersionMessageWrapper received: {}", ByteBufUtils.byteBufToHexString(msg.getMessageBuffer())); diff --git a/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/OFFrameDecoder.java b/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/OFFrameDecoder.java index a095280a9d..5c68d57f13 100644 --- a/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/OFFrameDecoder.java +++ b/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/OFFrameDecoder.java @@ -47,7 +47,7 @@ public class OFFrameDecoder extends ByteToMessageDecoder { } @Override - public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws Exception { + public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) { if (cause instanceof io.netty.handler.ssl.NotSslRecordException) { LOG.warn("Not an TLS record exception - please verify TLS configuration."); } else { @@ -58,7 +58,7 @@ public class OFFrameDecoder extends ByteToMessageDecoder { } @Override - protected void decode(ChannelHandlerContext chc, ByteBuf bb, List list) throws Exception { + protected void decode(ChannelHandlerContext chc, ByteBuf bb, List list) { if (firstTlsPass) { connectionFacade.fireConnectionReadyNotification(); firstTlsPass = false; diff --git a/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/SwitchConnectionProviderImpl.java b/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/SwitchConnectionProviderImpl.java index 40adc5716b..1af6fdd2c5 100755 --- a/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/SwitchConnectionProviderImpl.java +++ b/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/SwitchConnectionProviderImpl.java @@ -210,7 +210,7 @@ public class SwitchConnectionProviderImpl implements SwitchConnectionProvider, C } @Override - public void close() throws Exception { + public void close() { shutdown(); } diff --git a/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/UdpChannelInitializer.java b/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/UdpChannelInitializer.java index 13b3ca35c6..97de2cb6a8 100644 --- a/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/UdpChannelInitializer.java +++ b/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/UdpChannelInitializer.java @@ -18,7 +18,7 @@ import io.netty.channel.socket.DatagramChannel; public class UdpChannelInitializer extends ProtocolChannelInitializer { @Override - protected void initChannel(DatagramChannel ch) throws Exception { + protected void initChannel(DatagramChannel ch) { ch.pipeline().addLast(PipelineHandlers.OF_DATAGRAMPACKET_HANDLER.name(), new OFDatagramPacketHandler(getSwitchConnectionHandler(), getChannelOutboundQueueSize())); OFDatagramPacketDecoder ofDatagramPacketDecoder = new OFDatagramPacketDecoder(); diff --git a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/DummyDecoder.java b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/DummyDecoder.java index f62880066e..2c790102a0 100644 --- a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/DummyDecoder.java +++ b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/DummyDecoder.java @@ -26,7 +26,7 @@ public class DummyDecoder extends ByteToMessageDecoder { @Override protected void decode(ChannelHandlerContext ctx, ByteBuf in, - List out) throws Exception { + List out) { LOG.debug("decoding"); ctx.fireChannelReadComplete(); } diff --git a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/IdleHandlerTest.java b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/IdleHandlerTest.java index 3bb1a5da3b..ccf382ec8a 100644 --- a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/IdleHandlerTest.java +++ b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/IdleHandlerTest.java @@ -56,7 +56,7 @@ public class IdleHandlerTest { * Test channel read timeout. */ @Test - public void testReadTimedOut() throws Exception { + public void testReadTimedOut() { idleHandler.readTimedOut(mockChHndlrCtx); // Verify a read was fired for the next handler to process ... @@ -67,7 +67,7 @@ public class IdleHandlerTest { * Test only one timeout notification. */ @Test - public void testReadTimedOutNoOpNotFirst() throws Exception { + public void testReadTimedOutNoOpNotFirst() { idleHandler.readTimedOut(mockChHndlrCtx); idleHandler.readTimedOut(mockChHndlrCtx); diff --git a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFDatagramPacketDecoderTest.java b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFDatagramPacketDecoderTest.java index f5ddbd8b53..b55c94de5e 100644 --- a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFDatagramPacketDecoderTest.java +++ b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFDatagramPacketDecoderTest.java @@ -38,7 +38,7 @@ public class OFDatagramPacketDecoderTest { } @Test - public void test() throws Exception { + public void test() { OFDatagramPacketDecoder decoder = new OFDatagramPacketDecoder(); decoder.setDeserializationFactory(deserializationFactory); msgWrapper = new VersionMessageUdpWrapper(EncodeConstants.OF13_VERSION_ID, messageBufferMock, diff --git a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFDatagramPacketHandlerTest.java b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFDatagramPacketHandlerTest.java index e7741225d6..aab7b54389 100644 --- a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFDatagramPacketHandlerTest.java +++ b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFDatagramPacketHandlerTest.java @@ -49,7 +49,7 @@ public class OFDatagramPacketHandlerTest { * Test {@link OFDatagramPacketHandler}. */ @Test - public void test() throws Exception { + public void test() { OFDatagramPacketHandler handler = new OFDatagramPacketHandler(switchConnHandler, CHANNEL_OUTBOUND_QUEUE_SIZE); byte version = EncodeConstants.OF13_VERSION_ID; ByteBuf messageBuffer = ByteBufUtils.hexStringToByteBuf("04 02 00 08 01 02 03 04"); diff --git a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFDecoderStatisticsTest.java b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFDecoderStatisticsTest.java index da6a108b97..7afd5993c6 100644 --- a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFDecoderStatisticsTest.java +++ b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFDecoderStatisticsTest.java @@ -70,7 +70,7 @@ public class OFDecoderStatisticsTest { * Test decode success counter. */ @Test - public void testDecodeSuccesfullCounter() throws Exception { + public void testDecodeSuccesfullCounter() { if (!statCounters.isCounterEnabled(CounterEventTypes.US_DECODE_SUCCESS)) { Assert.fail("Counter " + CounterEventTypes.US_DECODE_SUCCESS + " is not enable"); } @@ -103,7 +103,7 @@ public class OFDecoderStatisticsTest { * Test fail decode counter. */ @Test - public void testDecodeFailCounter() throws Exception { + public void testDecodeFailCounter() { if (!statCounters.isCounterEnabled(CounterEventTypes.US_DECODE_SUCCESS)) { Assert.fail("Counter " + CounterEventTypes.US_DECODE_SUCCESS + " is not enable"); } diff --git a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFDecoderTest.java b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFDecoderTest.java index a36b72917a..090ab2dc5e 100644 --- a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFDecoderTest.java +++ b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFDecoderTest.java @@ -55,7 +55,7 @@ public class OFDecoderTest { } @Test - public void testDecode() throws Exception { + public void testDecode() { when(mockDeserializationFactory.deserialize(any(ByteBuf.class), anyShort())).thenReturn(mockDataObject); ofDecoder.decode(mockChHndlrCtx, inMsg, outList); @@ -66,7 +66,7 @@ public class OFDecoderTest { } @Test - public void testDecodeDeserializeException() throws Exception { + public void testDecodeDeserializeException() { when(mockDeserializationFactory.deserialize(any(ByteBuf.class), anyShort())) .thenThrow(new IllegalArgumentException()); @@ -78,7 +78,7 @@ public class OFDecoderTest { } @Test - public void testDecodeDeserializeNull() throws Exception { + public void testDecodeDeserializeNull() { when(mockDeserializationFactory.deserialize(any(ByteBuf.class), anyShort())).thenReturn(null); ofDecoder.decode(mockChHndlrCtx, inMsg, outList); diff --git a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFFrameDecoderTest.java b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFFrameDecoderTest.java index b21f1a16c3..bdc7de6abb 100644 --- a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFFrameDecoderTest.java +++ b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFFrameDecoderTest.java @@ -56,7 +56,7 @@ public class OFFrameDecoderTest { * {@link OFFrameDecoder#decode(io.netty.channel.ChannelHandlerContext, io.netty.buffer.ByteBuf, java.util.List)}. */ @Test - public void testDecode8BMessage() throws Exception { + public void testDecode8BMessage() { decoder.decode(channelHandlerContext, ByteBufUtils.hexStringToByteBuf("04 00 00 08 00 00 00 01"), list); @@ -68,7 +68,7 @@ public class OFFrameDecoderTest { * {@link OFFrameDecoder#decode(io.netty.channel.ChannelHandlerContext, io.netty.buffer.ByteBuf, java.util.List)}. */ @Test - public void testDecode16BMessage() throws Exception { + public void testDecode16BMessage() { ByteBuf byteBuffer = ByteBufUtils .hexStringToByteBuf("04 00 00 10 00 00 00 00 00 00 00 00 00 00 00 42"); @@ -83,7 +83,7 @@ public class OFFrameDecoderTest { * {@link OFFrameDecoder#decode(io.netty.channel.ChannelHandlerContext, io.netty.buffer.ByteBuf, java.util.List)}. */ @Test - public void testDecode5BIncompleteMessage() throws Exception { + public void testDecode5BIncompleteMessage() { ByteBuf byteBuffer = ByteBufUtils.hexStringToByteBuf("04 00 00 08 00"); decoder.decode(channelHandlerContext, byteBuffer, list); @@ -97,7 +97,7 @@ public class OFFrameDecoderTest { * {@link OFFrameDecoder#decode(io.netty.channel.ChannelHandlerContext, io.netty.buffer.ByteBuf, java.util.List)}. */ @Test - public void testDecode16BIncompleteMessage() throws Exception { + public void testDecode16BIncompleteMessage() { ByteBuf byteBuffer = ByteBufUtils .hexStringToByteBuf("04 00 00 11 00 00 00 00 00 00 00 00 00 00 00 42"); @@ -112,7 +112,7 @@ public class OFFrameDecoderTest { * {@link OFFrameDecoder#decode(io.netty.channel.ChannelHandlerContext, io.netty.buffer.ByteBuf, java.util.List)}. */ @Test - public void testDecodeCompleteAndPartialMessage() throws Exception { + public void testDecodeCompleteAndPartialMessage() { ByteBuf byteBuffer = ByteBufUtils .hexStringToByteBuf("04 00 00 08 00 00 00 01 04 00 00 08 00"); @@ -125,7 +125,7 @@ public class OFFrameDecoderTest { } @Test - public void testExceptionCaught() throws Exception { + public void testExceptionCaught() { decoder.exceptionCaught(channelHandlerContext, new Throwable()); } @@ -134,7 +134,7 @@ public class OFFrameDecoderTest { * {@link OFFrameDecoder#decode(io.netty.channel.ChannelHandlerContext, io.netty.buffer.ByteBuf, java.util.List)}. */ @Test - public void testDecode8BMessageWithTls() throws Exception { + public void testDecode8BMessageWithTls() { decoder = new OFFrameDecoder(connectionFacade, true); decoder.decode(channelHandlerContext, diff --git a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/SslContextFactoryTest.java b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/SslContextFactoryTest.java index 0057f0a3c4..ac7ab53e26 100644 --- a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/SslContextFactoryTest.java +++ b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/SslContextFactoryTest.java @@ -43,7 +43,7 @@ public class SslContextFactoryTest { } @Test - public void testGetServerContext() throws Exception { + public void testGetServerContext() { SSLContext context = sslContextFactory.getServerContext() ; assertNotNull(context); diff --git a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/TcpHandlerTest.java b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/TcpHandlerTest.java index 8bbb0bc585..13441ab077 100644 --- a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/TcpHandlerTest.java +++ b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/TcpHandlerTest.java @@ -197,7 +197,7 @@ public class TcpHandlerTest { assertEquals("shutdown failed", true, shutdownRet.get()); } - private Boolean startupServer(boolean isEpollEnabled) throws InterruptedException, IOException, ExecutionException { + private Boolean startupServer(boolean isEpollEnabled) throws InterruptedException { ListenableFuture online = tcpHandler.getIsOnlineFuture(); /** * Test EPoll based native transport if isEpollEnabled is true. diff --git a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/ChannelOutboundQueue02Test.java b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/ChannelOutboundQueue02Test.java index 33e3ad7bf1..4c412d8a85 100644 --- a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/ChannelOutboundQueue02Test.java +++ b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/ChannelOutboundQueue02Test.java @@ -123,7 +123,7 @@ public class ChannelOutboundQueue02Test { private class EmbededChannelHandler extends ChannelOutboundHandlerAdapter { @Override public void write(final ChannelHandlerContext ctx, final Object msg, - final ChannelPromise promise) throws Exception { + final ChannelPromise promise) { if (msg instanceof MessageListenerWrapper) { counter++; } diff --git a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/ConnectionAdapterImp02lTest.java b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/ConnectionAdapterImp02lTest.java index 90282c1635..d9beb94582 100644 --- a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/ConnectionAdapterImp02lTest.java +++ b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/ConnectionAdapterImp02lTest.java @@ -193,7 +193,7 @@ public class ConnectionAdapterImp02lTest { private class EmbededChannelHandler extends ChannelOutboundHandlerAdapter { @Override public void write(final ChannelHandlerContext ctx, final Object msg, - final ChannelPromise promise) throws Exception { + final ChannelPromise promise) { responseOfCall = null; if (msg instanceof MessageListenerWrapper) { final MessageListenerWrapper listener = (MessageListenerWrapper) msg; diff --git a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/ConnectionAdapterImpl02Test.java b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/ConnectionAdapterImpl02Test.java index 684196942f..0ff43eeeae 100644 --- a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/ConnectionAdapterImpl02Test.java +++ b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/ConnectionAdapterImpl02Test.java @@ -193,7 +193,7 @@ public class ConnectionAdapterImpl02Test { private class EmbededChannelHandler extends ChannelOutboundHandlerAdapter { @Override public void write(final ChannelHandlerContext ctx, final Object msg, - final ChannelPromise promise) throws Exception { + final ChannelPromise promise) { responseOfCall = null; if (msg instanceof MessageListenerWrapper) { final MessageListenerWrapper listener = (MessageListenerWrapper) msg; diff --git a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/OutboundQueueEntryTest.java b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/OutboundQueueEntryTest.java index 4ccf3c9fe3..a494b22515 100644 --- a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/OutboundQueueEntryTest.java +++ b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/OutboundQueueEntryTest.java @@ -53,7 +53,7 @@ public class OutboundQueueEntryTest { private final OfHeader flowRemoved = new FlowRemovedMessageBuilder().setVersion(VERSION).setXid(VALUE).build(); @Test - public void commit() throws Exception { + public void commit() { outboundQueueEntry.commit(ofHeader, futureCallback); Assert.assertTrue(outboundQueueEntry.isCommitted()); Assert.assertFalse(outboundQueueEntry.isCompleted()); @@ -61,7 +61,7 @@ public class OutboundQueueEntryTest { } @Test - public void reset() throws Exception { + public void reset() { outboundQueueEntry.commit(ofHeader, futureCallback); Assert.assertTrue(outboundQueueEntry.isCommitted()); @@ -70,33 +70,33 @@ public class OutboundQueueEntryTest { } @Test - public void isBarrier() throws Exception { + public void isBarrier() { outboundQueueEntry.commit(barrierInput, futureCallback); Assert.assertTrue(outboundQueueEntry.isBarrier()); } @Test - public void takeMessage() throws Exception { + public void takeMessage() { outboundQueueEntry.commit(packetOutInput, futureCallback); outboundQueueEntry.takeMessage(); Mockito.verify(futureCallback).onSuccess(Mockito.any()); } @Test - public void complete() throws Exception { + public void complete() { final boolean result = outboundQueueEntry.complete(multipartReplyMessage); Assert.assertTrue(result); Assert.assertTrue(outboundQueueEntry.isCompleted()); } @Test(expected = IllegalStateException.class) - public void completeTwice() throws Exception { + public void completeTwice() { outboundQueueEntry.complete(multipartReplyMessage); outboundQueueEntry.complete(multipartReplyMessage); } @Test - public void fail() throws Exception { + public void fail() { outboundQueueEntry.commit(ofHeader, futureCallback); outboundQueueEntry.fail(null); Mockito.verify(futureCallback).onFailure(Mockito.any()); @@ -107,7 +107,7 @@ public class OutboundQueueEntryTest { } @Test - public void test() throws Exception { + public void test() { final FutureCallback result = new FutureCallback() { @Override diff --git a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/UdpHandlerTest.java b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/UdpHandlerTest.java index feeef65b41..949007051a 100644 --- a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/UdpHandlerTest.java +++ b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/UdpHandlerTest.java @@ -8,7 +8,6 @@ package org.opendaylight.openflowjava.protocol.impl.core.connection; import com.google.common.util.concurrent.ListenableFuture; -import java.io.IOException; import java.net.InetAddress; import java.util.concurrent.ExecutionException; import java.util.concurrent.TimeUnit; @@ -115,7 +114,7 @@ public class UdpHandlerTest { } private Boolean startupServer(final boolean isEpollEnabled) - throws InterruptedException, IOException, ExecutionException { + throws InterruptedException, ExecutionException { ListenableFuture online = udpHandler.getIsOnlineFuture(); /** * Test EPoll based native transport if isEpollEnabled is true. diff --git a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/FlowModInputMessageFactoryTest.java b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/FlowModInputMessageFactoryTest.java index 46873c5d5c..5f6268e08f 100644 --- a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/FlowModInputMessageFactoryTest.java +++ b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/FlowModInputMessageFactoryTest.java @@ -70,7 +70,7 @@ public class FlowModInputMessageFactoryTest { } @Test - public void test() throws Exception { + public void test() { ByteBuf bb = BufferHelper.buildBuffer( "ff 01 04 01 06 00 07 01 ff 05 00 00 09 30 00 30 41 02 00 0c 00 00 00 7e 00 " + "00 00 02 00 00 11 46 00 00 00 62 00 0b 00 00 00 01 00 11 80 00 02 04 00 00 00 2a 80 00 12 01 04 00 " diff --git a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/PortModInputMessageFactoryTest.java b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/PortModInputMessageFactoryTest.java index a5e39f1c2f..f9032d6e87 100644 --- a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/PortModInputMessageFactoryTest.java +++ b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/PortModInputMessageFactoryTest.java @@ -32,7 +32,7 @@ public class PortModInputMessageFactoryTest { private OFDeserializer factory; @Before - public void startUp() throws Exception { + public void startUp() { DeserializerRegistry desRegistry = new DeserializerRegistryImpl(); desRegistry.init(); factory = desRegistry @@ -40,7 +40,7 @@ public class PortModInputMessageFactoryTest { } @Test - public void test() throws Exception { + public void test() { ByteBuf bb = BufferHelper.buildBuffer( "00 00 00 09 00 00 00 00 08 00 27 00 " + "b0 eb 00 00 00 00 00 24 00 00 00 41 00 00 01 10 00 00 00 00"); PortModInput deserializedMessage = BufferHelper.deserialize(factory, bb); diff --git a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/serialization/factories/BarrierReplyMessageFactoryTest.java b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/serialization/factories/BarrierReplyMessageFactoryTest.java index a87549dcf2..0e3020796a 100644 --- a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/serialization/factories/BarrierReplyMessageFactoryTest.java +++ b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/serialization/factories/BarrierReplyMessageFactoryTest.java @@ -30,7 +30,7 @@ public class BarrierReplyMessageFactoryTest { private OFSerializer factory; @Before - public void startUp() throws Exception { + public void startUp() { SerializerRegistry registry = new SerializerRegistryImpl(); registry.init(); factory = registry.getSerializer(new MessageTypeKey<>(EncodeConstants.OF13_VERSION_ID, BarrierOutput.class)); diff --git a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/serialization/factories/MultipartReplyMessageFactoryTest.java b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/serialization/factories/MultipartReplyMessageFactoryTest.java index 72d6d88bc4..fd683b826b 100644 --- a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/serialization/factories/MultipartReplyMessageFactoryTest.java +++ b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/serialization/factories/MultipartReplyMessageFactoryTest.java @@ -189,7 +189,7 @@ public class MultipartReplyMessageFactoryTest { private OFSerializer factory; @Before - public void startUp() throws Exception { + public void startUp() { SerializerRegistry registry = new SerializerRegistryImpl(); registry.init(); factory = registry diff --git a/openflowjava/openflow-protocol-it/src/test/java/org/opendaylight/openflowjava/protocol/it/integration/IntegrationTest.java b/openflowjava/openflow-protocol-it/src/test/java/org/opendaylight/openflowjava/protocol/it/integration/IntegrationTest.java index 92c9d64bc9..33ce4ecd09 100644 --- a/openflowjava/openflow-protocol-it/src/test/java/org/opendaylight/openflowjava/protocol/it/integration/IntegrationTest.java +++ b/openflowjava/openflow-protocol-it/src/test/java/org/opendaylight/openflowjava/protocol/it/integration/IntegrationTest.java @@ -101,7 +101,7 @@ public class IntegrationTest { } @After - public void tearDown() throws Exception { + public void tearDown() { switchConnectionProvider.close(); LOGGER.debug("\n ending test -------------------------------"); } diff --git a/openflowjava/openflowjava-util/src/main/java/org/opendaylight/openflowjava/util/ByteBufUtils.java b/openflowjava/openflowjava-util/src/main/java/org/opendaylight/openflowjava/util/ByteBufUtils.java index a21eb5fcc0..a7c83ade56 100644 --- a/openflowjava/openflowjava-util/src/main/java/org/opendaylight/openflowjava/util/ByteBufUtils.java +++ b/openflowjava/openflowjava-util/src/main/java/org/opendaylight/openflowjava/util/ByteBufUtils.java @@ -14,7 +14,6 @@ import com.google.common.collect.Lists; import com.google.common.primitives.UnsignedBytes; import io.netty.buffer.ByteBuf; import io.netty.buffer.UnpooledByteBufAllocator; -import java.io.IOException; import java.nio.ByteBuffer; import java.nio.charset.StandardCharsets; import java.util.List; @@ -395,7 +394,7 @@ public abstract class ByteBufUtils { return IetfYangUtil.INSTANCE.macAddressFor(tmp); } - public static byte[] serializeList(final List list) throws IOException { + public static byte[] serializeList(final List list) { ByteBuffer byteBuffer = ByteBuffer.allocate(list.size() * 2); for (Short shortValue : list) { byteBuffer.putShort(shortValue); diff --git a/openflowjava/openflowjava-util/src/test/java/org/opendaylight/openflowjava/util/ByteBufUtilsTest.java b/openflowjava/openflowjava-util/src/test/java/org/opendaylight/openflowjava/util/ByteBufUtilsTest.java index 35589bf2b1..23a9bef5cf 100644 --- a/openflowjava/openflowjava-util/src/test/java/org/opendaylight/openflowjava/util/ByteBufUtilsTest.java +++ b/openflowjava/openflowjava-util/src/test/java/org/opendaylight/openflowjava/util/ByteBufUtilsTest.java @@ -11,7 +11,6 @@ package org.opendaylight.openflowjava.util; import io.netty.buffer.ByteBuf; import io.netty.buffer.PooledByteBufAllocator; import io.netty.buffer.UnpooledByteBufAllocator; -import java.io.IOException; import java.util.ArrayList; import java.util.HashMap; import java.util.List; @@ -439,7 +438,7 @@ public class ByteBufUtilsTest { } @Test - public void testSerializeList() throws IOException { + public void testSerializeList() { List shorts = new ArrayList<>(); shorts.add((short) 1); @@ -451,7 +450,7 @@ public class ByteBufUtilsTest { } @Test - public void testUpdateHeader() throws IOException { + public void testUpdateHeader() { ByteBuf buffer = PooledByteBufAllocator.DEFAULT.buffer(); buffer.writeInt(1); final int start = buffer.writerIndex(); diff --git a/openflowjava/openflowjava-util/src/test/java/org/opendaylight/openflowjava/util/ExperimenterDeserializerKeyFactoryTest.java b/openflowjava/openflowjava-util/src/test/java/org/opendaylight/openflowjava/util/ExperimenterDeserializerKeyFactoryTest.java index 13bfa51c42..d67e66fd1b 100644 --- a/openflowjava/openflowjava-util/src/test/java/org/opendaylight/openflowjava/util/ExperimenterDeserializerKeyFactoryTest.java +++ b/openflowjava/openflowjava-util/src/test/java/org/opendaylight/openflowjava/util/ExperimenterDeserializerKeyFactoryTest.java @@ -27,7 +27,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731 public class ExperimenterDeserializerKeyFactoryTest { @Test - public void testCreateExperimenterErrorDeserializerKey() throws Exception { + public void testCreateExperimenterErrorDeserializerKey() { ExperimenterIdDeserializerKey createdKey; ExperimenterIdDeserializerKey comparationKey; @@ -38,7 +38,7 @@ public class ExperimenterDeserializerKeyFactoryTest { } @Test - public void testCreateExperimenterMessageDeserializerKey() throws Exception { + public void testCreateExperimenterMessageDeserializerKey() { ExperimenterIdDeserializerKey createdKey; ExperimenterIdDeserializerKey comparationKey; @@ -50,7 +50,7 @@ public class ExperimenterDeserializerKeyFactoryTest { } @Test - public void testCreateMultipartReplyMessageDeserializerKey() throws Exception { + public void testCreateMultipartReplyMessageDeserializerKey() { ExperimenterIdDeserializerKey createdKey; ExperimenterIdDeserializerKey comparationKey; @@ -62,7 +62,7 @@ public class ExperimenterDeserializerKeyFactoryTest { } @Test - public void testCreateMultipartReplyTFDeserializerKey() throws Exception { + public void testCreateMultipartReplyTFDeserializerKey() { ExperimenterIdDeserializerKey createdKey; ExperimenterIdDeserializerKey comparationKey; @@ -74,7 +74,7 @@ public class ExperimenterDeserializerKeyFactoryTest { } @Test - public void testCreateQueuePropertyDeserializerKey() throws Exception { + public void testCreateQueuePropertyDeserializerKey() { ExperimenterIdDeserializerKey createdKey; ExperimenterIdDeserializerKey comparationKey; @@ -86,7 +86,7 @@ public class ExperimenterDeserializerKeyFactoryTest { } @Test - public void testCreateMeterBandDeserializerKey() throws Exception { + public void testCreateMeterBandDeserializerKey() { ExperimenterIdDeserializerKey createdKey; ExperimenterIdDeserializerKey comparationKey; @@ -98,7 +98,7 @@ public class ExperimenterDeserializerKeyFactoryTest { } @Test - public void testCreateVendorMessageDeserializerKey() throws Exception { + public void testCreateVendorMessageDeserializerKey() { ExperimenterIdDeserializerKey createdKey; ExperimenterIdDeserializerKey comparationKey; @@ -110,7 +110,7 @@ public class ExperimenterDeserializerKeyFactoryTest { } @Test - public void testCreateMultipartReplyVendorMessageDeserializerKey() throws Exception { + public void testCreateMultipartReplyVendorMessageDeserializerKey() { ExperimenterIdDeserializerKey createdKey; ExperimenterIdDeserializerKey comparationKey; diff --git a/openflowjava/openflowjava-util/src/test/java/org/opendaylight/openflowjava/util/ExperimenterSerializerKeyFactoryTest.java b/openflowjava/openflowjava-util/src/test/java/org/opendaylight/openflowjava/util/ExperimenterSerializerKeyFactoryTest.java index 6b863c82cb..cd0f0b833d 100755 --- a/openflowjava/openflowjava-util/src/test/java/org/opendaylight/openflowjava/util/ExperimenterSerializerKeyFactoryTest.java +++ b/openflowjava/openflowjava-util/src/test/java/org/opendaylight/openflowjava/util/ExperimenterSerializerKeyFactoryTest.java @@ -27,7 +27,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731 public class ExperimenterSerializerKeyFactoryTest { @Test - public void testCreateExperimenterMessageSerializerKey() throws Exception { + public void testCreateExperimenterMessageSerializerKey() { ExperimenterIdSerializerKey createdKey; ExperimenterIdSerializerKey comparationKey; @@ -39,7 +39,7 @@ public class ExperimenterSerializerKeyFactoryTest { } @Test - public void testCreateMultipartRequestSerializerKey() throws Exception { + public void testCreateMultipartRequestSerializerKey() { ExperimenterIdSerializerKey createdKey; ExperimenterIdSerializerKey comparationKey; @@ -51,7 +51,7 @@ public class ExperimenterSerializerKeyFactoryTest { } @Test - public void testCreateMultipartRequestTFSerializerKey() throws Exception { + public void testCreateMultipartRequestTFSerializerKey() { ExperimenterIdSerializerKey createdKey; ExperimenterIdSerializerKey comparationKey; @@ -63,7 +63,7 @@ public class ExperimenterSerializerKeyFactoryTest { } @Test - public void testCreateMeterBandSerializerKey() throws Exception { + public void testCreateMeterBandSerializerKey() { ExperimenterIdSerializerKey createdKey; ExperimenterIdSerializerKey comparationKey; @@ -75,7 +75,7 @@ public class ExperimenterSerializerKeyFactoryTest { } @Test - public void testCreateMeterBandSubTypeSerializerKey() throws Exception { + public void testCreateMeterBandSubTypeSerializerKey() { final ExperimenterIdSerializerKey createdKey; final ExperimenterIdSerializerKey comparationKey1; final ExperimenterIdSerializerKey comparationKey2; diff --git a/openflowplugin-api/src/main/java/org/opendaylight/openflowplugin/api/openflow/device/handlers/DeviceConnectedHandler.java b/openflowplugin-api/src/main/java/org/opendaylight/openflowplugin/api/openflow/device/handlers/DeviceConnectedHandler.java index 04fdff9df3..f4f8cd8ae0 100644 --- a/openflowplugin-api/src/main/java/org/opendaylight/openflowplugin/api/openflow/device/handlers/DeviceConnectedHandler.java +++ b/openflowplugin-api/src/main/java/org/opendaylight/openflowplugin/api/openflow/device/handlers/DeviceConnectedHandler.java @@ -22,6 +22,6 @@ public interface DeviceConnectedHandler { * It propagates connected device's connection context. */ ConnectionStatus deviceConnected(ConnectionContext connectionContext) - throws Exception; + ; } diff --git a/openflowplugin-api/src/main/java/org/opendaylight/openflowplugin/api/openflow/lifecycle/ContextChainHolder.java b/openflowplugin-api/src/main/java/org/opendaylight/openflowplugin/api/openflow/lifecycle/ContextChainHolder.java index 55397427a1..413dd8ee21 100644 --- a/openflowplugin-api/src/main/java/org/opendaylight/openflowplugin/api/openflow/lifecycle/ContextChainHolder.java +++ b/openflowplugin-api/src/main/java/org/opendaylight/openflowplugin/api/openflow/lifecycle/ContextChainHolder.java @@ -59,6 +59,6 @@ public interface ContextChainHolder extends ContextChain getContextChain(DeviceInfo deviceInfo); @Override - void close() throws Exception; + void close(); } diff --git a/openflowplugin-common/src/test/java/org/opendaylight/openflowplugin/common/wait/SimpleTaskRetryLooperTest.java b/openflowplugin-common/src/test/java/org/opendaylight/openflowplugin/common/wait/SimpleTaskRetryLooperTest.java index 067b5899a5..9375ba5b89 100644 --- a/openflowplugin-common/src/test/java/org/opendaylight/openflowplugin/common/wait/SimpleTaskRetryLooperTest.java +++ b/openflowplugin-common/src/test/java/org/opendaylight/openflowplugin/common/wait/SimpleTaskRetryLooperTest.java @@ -47,7 +47,7 @@ public class SimpleTaskRetryLooperTest { private int counter = 0; @Override - public String call() throws Exception { + public String call() { counter++; if (counter < retryCountToSucceed) { throw new IllegalStateException("service is not ready"); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/configuration/ConfigurationServiceFactoryImpl.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/configuration/ConfigurationServiceFactoryImpl.java index 9d2424244d..95057657b6 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/configuration/ConfigurationServiceFactoryImpl.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/configuration/ConfigurationServiceFactoryImpl.java @@ -134,7 +134,7 @@ public class ConfigurationServiceFactoryImpl implements ConfigurationServiceFact } @Override - public void close() throws Exception { + public void close() { propertyMap.clear(); listeners.clear(); } diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/connection/HandshakeManagerImpl.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/connection/HandshakeManagerImpl.java index e2107dfb73..2e8a92e65f 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/connection/HandshakeManagerImpl.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/connection/HandshakeManagerImpl.java @@ -168,7 +168,7 @@ public class HandshakeManagerImpl implements HandshakeManager { } } - private void stepByStepVersionSubStep(Short remoteVersion) throws Exception { + private void stepByStepVersionSubStep(Short remoteVersion) { if (remoteVersion >= lastProposedVersion) { postHandshake(lastProposedVersion, getNextXid()); LOG.trace("ret - OK - switch answered with lastProposedVersion"); @@ -191,7 +191,7 @@ public class HandshakeManagerImpl implements HandshakeManager { * @param remoteVersion remote version * @throws Exception exception */ - private void handleLowerVersionProposal(Short remoteVersion) throws Exception { + private void handleLowerVersionProposal(Short remoteVersion) { Short proposedVersion; // find the version from header version field proposedVersion = proposeNextVersion(remoteVersion); @@ -212,7 +212,7 @@ public class HandshakeManagerImpl implements HandshakeManager { * @param elements version elements * @throws Exception exception */ - private void handleVersionBitmapNegotiation(List elements) throws Exception { + private void handleVersionBitmapNegotiation(List elements) { final Short proposedVersion = proposeCommonBitmapVersion(elements); if (lastProposedVersion == null) { // first hello has not been sent yet @@ -320,7 +320,7 @@ public class HandshakeManagerImpl implements HandshakeManager { * @param helloVersion initial hello version for openflow connection negotiation * @param helloXid transaction id */ - private ListenableFuture sendHelloMessage(Short helloVersion, final Long helloXid) throws Exception { + private ListenableFuture sendHelloMessage(Short helloVersion, final Long helloXid) { HelloInput helloInput = MessageFactory.createHelloInput(helloVersion, helloXid, versionOrder); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/device/DeviceContextImpl.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/device/DeviceContextImpl.java index c44a2605bb..35ebc03323 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/device/DeviceContextImpl.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/device/DeviceContextImpl.java @@ -59,7 +59,6 @@ import org.opendaylight.openflowplugin.common.txchain.TransactionChainManager; import org.opendaylight.openflowplugin.extension.api.ConvertorMessageFromOFJava; import org.opendaylight.openflowplugin.extension.api.ExtensionConverterProviderKeeper; import org.opendaylight.openflowplugin.extension.api.core.extension.ExtensionConverterProvider; -import org.opendaylight.openflowplugin.extension.api.exception.ConversionException; import org.opendaylight.openflowplugin.extension.api.path.MessagePath; import org.opendaylight.openflowplugin.impl.datastore.MultipartWriterProvider; import org.opendaylight.openflowplugin.impl.datastore.MultipartWriterProviderFactory; @@ -472,17 +471,13 @@ public class DeviceContextImpl implements DeviceContext, ExtensionConverterProvi } // build notification final ExperimenterMessageOfChoice messageOfChoice; - try { - messageOfChoice = messageConverter.convert(vendorData, MessagePath.MESSAGE_NOTIFICATION); - final ExperimenterMessageFromDevBuilder experimenterMessageFromDevBld = new - ExperimenterMessageFromDevBuilder() - .setNode(new NodeRef(getDeviceInfo().getNodeInstanceIdentifier())) - .setExperimenterMessageOfChoice(messageOfChoice); - // publish - notificationPublishService.offerNotification(experimenterMessageFromDevBld.build()); - } catch (final ConversionException e) { - LOG.error("Conversion of experimenter notification failed", e); - } + messageOfChoice = messageConverter.convert(vendorData, MessagePath.MESSAGE_NOTIFICATION); + final ExperimenterMessageFromDevBuilder experimenterMessageFromDevBld = new + ExperimenterMessageFromDevBuilder() + .setNode(new NodeRef(getDeviceInfo().getNodeInstanceIdentifier())) + .setExperimenterMessageOfChoice(messageOfChoice); + // publish + notificationPublishService.offerNotification(experimenterMessageFromDevBld.build()); } else { LOG.debug("Controller is not owner of the device {}, skipping experimenter message", deviceInfo.getLOGValue()); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ClearStatsCommandProvider.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ClearStatsCommandProvider.java index a58944b5c3..5dcc22613a 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ClearStatsCommandProvider.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ClearStatsCommandProvider.java @@ -18,7 +18,7 @@ import org.opendaylight.openflowplugin.impl.OpenFlowPluginProviderImpl; public class ClearStatsCommandProvider extends OsgiCommandSupport { @Override - protected Object doExecute() throws Exception { + protected Object doExecute() { final MessageIntelligenceAgency messageIntelligenceAgency = OpenFlowPluginProviderImpl.getMessageIntelligenceAgency(); messageIntelligenceAgency.resetStatistics(); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ResetEventTimesComandProvider.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ResetEventTimesComandProvider.java index cf093f364b..7cd5adb3e0 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ResetEventTimesComandProvider.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ResetEventTimesComandProvider.java @@ -20,7 +20,7 @@ import org.opendaylight.openflowplugin.impl.statistics.ofpspecific.EventsTimeCou public class ResetEventTimesComandProvider extends OsgiCommandSupport { @Override - protected Object doExecute() throws Exception { + protected Object doExecute() { PrintStream out = session.getConsole(); EventsTimeCounter.resetAllCounters(); out.print("Events time counters reset.\n"); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ResetSessionStatsComandProvider.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ResetSessionStatsComandProvider.java index e1071a7538..db383c6af4 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ResetSessionStatsComandProvider.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ResetSessionStatsComandProvider.java @@ -20,7 +20,7 @@ import org.opendaylight.openflowplugin.impl.statistics.ofpspecific.SessionStatis public class ResetSessionStatsComandProvider extends OsgiCommandSupport { @Override - protected Object doExecute() throws Exception { + protected Object doExecute() { PrintStream out = session.getConsole(); SessionStatistics.resetAllCounters(); out.print("Session statistics counters reset.\n"); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ShowEventTimesComandProvider.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ShowEventTimesComandProvider.java index 751a6e5400..1374857800 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ShowEventTimesComandProvider.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ShowEventTimesComandProvider.java @@ -21,7 +21,7 @@ import org.opendaylight.openflowplugin.impl.statistics.ofpspecific.EventsTimeCou public class ShowEventTimesComandProvider extends OsgiCommandSupport { @Override - protected Object doExecute() throws Exception { + protected Object doExecute() { PrintStream out = session.getConsole(); final List statistics = EventsTimeCounter.provideTimes(); final StringBuilder result = new StringBuilder(); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ShowSessionStatsCommandProvider.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ShowSessionStatsCommandProvider.java index 732957cc6d..0187ec61d5 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ShowSessionStatsCommandProvider.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ShowSessionStatsCommandProvider.java @@ -22,7 +22,7 @@ import org.opendaylight.openflowplugin.impl.statistics.ofpspecific.SessionStatis public class ShowSessionStatsCommandProvider extends OsgiCommandSupport { @Override - protected Object doExecute() throws Exception { + protected Object doExecute() { PrintStream out = session.getConsole(); final List statistics = SessionStatistics.provideStatistics(); final StringBuilder result = new StringBuilder(); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ShowStatsCommandProvider.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ShowStatsCommandProvider.java index cec18ba2ec..3d8307e6cb 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ShowStatsCommandProvider.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/karaf/ShowStatsCommandProvider.java @@ -19,7 +19,7 @@ import org.opendaylight.openflowplugin.impl.OpenFlowPluginProviderImpl; public class ShowStatsCommandProvider extends OsgiCommandSupport { @Override - protected Object doExecute() throws Exception { + protected Object doExecute() { PrintStream out = session.getConsole(); final MessageIntelligenceAgency messageIntelligenceAgency = OpenFlowPluginProviderImpl.getMessageIntelligenceAgency(); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/lifecycle/ContextChainHolderImpl.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/lifecycle/ContextChainHolderImpl.java index cacf01e3c2..a2260a59b0 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/lifecycle/ContextChainHolderImpl.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/lifecycle/ContextChainHolderImpl.java @@ -144,7 +144,7 @@ public class ContextChainHolderImpl implements ContextChainHolder, MasterChecker } @Override - public ConnectionStatus deviceConnected(final ConnectionContext connectionContext) throws Exception { + public ConnectionStatus deviceConnected(final ConnectionContext connectionContext) { final DeviceInfo deviceInfo = connectionContext.getDeviceInfo(); final ContextChain contextChain = contextChainMap.get(deviceInfo); final FeaturesReply featuresReply = connectionContext.getFeatures(); @@ -269,7 +269,7 @@ public class ContextChainHolderImpl implements ContextChainHolder, MasterChecker } @Override - public void close() throws Exception { + public void close() { Map copyOfChains = new HashMap<>(contextChainMap); copyOfChains.keySet().forEach(this::destroyContextChain); copyOfChains.clear(); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyExperimenterDeserializer.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyExperimenterDeserializer.java index 1fe6e35f26..67f599f517 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyExperimenterDeserializer.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyExperimenterDeserializer.java @@ -17,7 +17,6 @@ import org.opendaylight.openflowjava.protocol.api.keys.MessageTypeKey; import org.opendaylight.openflowjava.protocol.api.util.EncodeConstants; import org.opendaylight.openflowjava.util.ExperimenterDeserializerKeyFactory; import org.opendaylight.openflowplugin.extension.api.ConvertorMessageFromOFJava; -import org.opendaylight.openflowplugin.extension.api.exception.ConversionException; import org.opendaylight.openflowplugin.extension.api.path.MessagePath; import org.opendaylight.openflowplugin.openflow.md.core.session.OFSessionUtil; import org.opendaylight.yang.gen.v1.urn.opendaylight.multipart.types.rev170112.multipart.reply.MultipartReplyBody; @@ -59,11 +58,7 @@ public class MultipartReplyExperimenterDeserializer implements OFDeserializerfailed() - .withError(ErrorType.RPC, - "Conversion of experimenter rpc output failed.").build()); - return; - } + final ExperimenterMessageOfChoice messageOfChoice = + messageConverter.convert(vendorData, MessagePath.MPMESSAGE_RPC_OUTPUT); + final ExperimenterCoreMessageItemBuilder expCoreMessageItemBuilder = + new ExperimenterCoreMessageItemBuilder(); + expCoreMessageItemBuilder.setExperimenterMessageOfChoice(messageOfChoice); + expCoreMessageItem.add(expCoreMessageItemBuilder.build()); } sendExpMpReqOutputBuilder.setExperimenterCoreMessageItem(expCoreMessageItem); finalFuture.set(RpcResultBuilder.success(sendExpMpReqOutputBuilder.build()).build()); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/multilayer/MultiLayerFlowService.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/multilayer/MultiLayerFlowService.java index 10d88f9a57..ccf0281829 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/multilayer/MultiLayerFlowService.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/multilayer/MultiLayerFlowService.java @@ -22,7 +22,6 @@ import org.opendaylight.openflowplugin.api.openflow.device.DeviceContext; import org.opendaylight.openflowplugin.api.openflow.device.RequestContextStack; import org.opendaylight.openflowplugin.api.openflow.device.Xid; import org.opendaylight.openflowplugin.impl.services.AbstractSimpleService; -import org.opendaylight.openflowplugin.impl.services.util.ServiceException; import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.ConvertorExecutor; import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.data.VersionDatapathIdConvertorData; import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.Flow; @@ -49,7 +48,7 @@ public final class MultiLayerFlowService extends AbstractS } @Override - protected OfHeader buildRequest(final Xid xid, final FlowModInputBuilder input) throws ServiceException { + protected OfHeader buildRequest(final Xid xid, final FlowModInputBuilder input) { input.setXid(xid.getValue()); return input.build(); } diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/multilayer/MultiLayerGroupService.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/multilayer/MultiLayerGroupService.java index c942676852..44fee1ce0d 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/multilayer/MultiLayerGroupService.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/multilayer/MultiLayerGroupService.java @@ -12,7 +12,6 @@ import org.opendaylight.openflowplugin.api.openflow.device.DeviceContext; import org.opendaylight.openflowplugin.api.openflow.device.RequestContextStack; import org.opendaylight.openflowplugin.api.openflow.device.Xid; import org.opendaylight.openflowplugin.impl.services.AbstractSimpleService; -import org.opendaylight.openflowplugin.impl.services.util.ServiceException; import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.ConvertorExecutor; import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.GroupConvertor; import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.data.VersionDatapathIdConvertorData; @@ -36,7 +35,7 @@ public final class MultiLayerGroupService } @Override - protected OfHeader buildRequest(final Xid xid, final I input) throws ServiceException { + protected OfHeader buildRequest(final Xid xid, final I input) { final Optional ofGroupModInput = convertorExecutor.convert(input, data); final GroupModInputBuilder groupModInputBuilder = ofGroupModInput diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/multilayer/MultiLayerMeterService.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/multilayer/MultiLayerMeterService.java index 0a09f08cfe..112bd5148c 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/multilayer/MultiLayerMeterService.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/multilayer/MultiLayerMeterService.java @@ -12,7 +12,6 @@ import org.opendaylight.openflowplugin.api.openflow.device.DeviceContext; import org.opendaylight.openflowplugin.api.openflow.device.RequestContextStack; import org.opendaylight.openflowplugin.api.openflow.device.Xid; import org.opendaylight.openflowplugin.impl.services.AbstractSimpleService; -import org.opendaylight.openflowplugin.impl.services.util.ServiceException; import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.ConvertorExecutor; import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.MeterConvertor; import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.data.VersionConvertorData; @@ -36,7 +35,7 @@ public final class MultiLayerMeterService } @Override - protected OfHeader buildRequest(final Xid xid, final I input) throws ServiceException { + protected OfHeader buildRequest(final Xid xid, final I input) { final Optional ofMeterModInput = convertorExecutor.convert(input, data); final MeterModInputBuilder meterModInputBuilder = ofMeterModInput .orElse(MeterConvertor.defaultResult(getVersion())); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/multilayer/MultiLayerTableMultipartService.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/multilayer/MultiLayerTableMultipartService.java index ba8b8a38c1..2d0cd7a5b6 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/multilayer/MultiLayerTableMultipartService.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/multilayer/MultiLayerTableMultipartService.java @@ -25,7 +25,6 @@ import org.opendaylight.openflowplugin.api.openflow.device.Xid; import org.opendaylight.openflowplugin.impl.datastore.MultipartWriterProvider; import org.opendaylight.openflowplugin.impl.services.AbstractTableMultipartService; import org.opendaylight.openflowplugin.impl.services.util.RequestInputUtils; -import org.opendaylight.openflowplugin.impl.services.util.ServiceException; import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.ConvertorExecutor; import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.data.VersionConvertorData; import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.transaction.rev150304.TransactionId; @@ -63,7 +62,7 @@ public class MultiLayerTableMultipartService extends AbstractTableMultipartServi } @Override - protected OfHeader buildRequest(final Xid xid, final UpdateTableInput input) throws ServiceException { + protected OfHeader buildRequest(final Xid xid, final UpdateTableInput input) { final Optional> tableFeatures = diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/sal/FlowCapableTransactionServiceImpl.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/sal/FlowCapableTransactionServiceImpl.java index 1259aeb5a7..37d95d9b63 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/sal/FlowCapableTransactionServiceImpl.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/sal/FlowCapableTransactionServiceImpl.java @@ -12,7 +12,6 @@ import org.opendaylight.openflowplugin.api.openflow.device.DeviceContext; import org.opendaylight.openflowplugin.api.openflow.device.RequestContextStack; import org.opendaylight.openflowplugin.api.openflow.device.Xid; import org.opendaylight.openflowplugin.impl.services.AbstractSimpleService; -import org.opendaylight.openflowplugin.impl.services.util.ServiceException; import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.transaction.rev150304.FlowCapableTransactionService; import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.transaction.rev150304.SendBarrierInput; import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.transaction.rev150304.SendBarrierOutput; @@ -33,7 +32,7 @@ public class FlowCapableTransactionServiceImpl extends AbstractSimpleService ofPortModInput = convertorExecutor .convert(getPortFromInput(input), data); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/sal/SalRoleServiceImpl.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/sal/SalRoleServiceImpl.java index 7175483ee5..15079311a2 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/sal/SalRoleServiceImpl.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/sal/SalRoleServiceImpl.java @@ -20,7 +20,6 @@ import org.opendaylight.openflowplugin.api.openflow.device.RequestContextStack; import org.opendaylight.openflowplugin.api.openflow.device.Xid; import org.opendaylight.openflowplugin.impl.services.AbstractSimpleService; import org.opendaylight.openflowplugin.impl.services.RoleService; -import org.opendaylight.openflowplugin.impl.services.util.ServiceException; import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.OfHeader; import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.RoleRequestOutput; import org.opendaylight.yang.gen.v1.urn.opendaylight.role.service.rev150727.OfpRole; @@ -48,7 +47,7 @@ public final class SalRoleServiceImpl extends AbstractSimpleService extends Abstract } @Override - protected OfHeader buildRequest(final Xid xid, final Flow input) throws ServiceException { + protected OfHeader buildRequest(final Xid xid, final Flow input) { final FlowMessageBuilder flowMessageBuilder = new FlowMessageBuilder(input); final Class clazz = input.getImplementedInterface(); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerGetAsyncConfigService.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerGetAsyncConfigService.java index 69f09448a3..1e89489b2d 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerGetAsyncConfigService.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerGetAsyncConfigService.java @@ -12,7 +12,6 @@ import org.opendaylight.openflowplugin.api.openflow.device.DeviceContext; import org.opendaylight.openflowplugin.api.openflow.device.RequestContextStack; import org.opendaylight.openflowplugin.api.openflow.device.Xid; import org.opendaylight.openflowplugin.impl.services.AbstractSimpleService; -import org.opendaylight.openflowplugin.impl.services.util.ServiceException; import org.opendaylight.yang.gen.v1.urn.opendaylight.async.config.service.rev170619.AsyncConfigMessage; import org.opendaylight.yang.gen.v1.urn.opendaylight.async.config.service.rev170619.GetAsyncInput; import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.GetAsyncInputBuilder; @@ -26,7 +25,7 @@ public class SingleLayerGetAsyncConfigService extends AbstractSimpleService extends Abstrac } @Override - protected OfHeader buildRequest(final Xid xid, final Group input) throws ServiceException { + protected OfHeader buildRequest(final Xid xid, final Group input) { final GroupMessageBuilder groupMessageBuilder = new GroupMessageBuilder(input); final Class clazz = input.getImplementedInterface(); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerMeterService.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerMeterService.java index 1b80d932c4..05900d7003 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerMeterService.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerMeterService.java @@ -12,7 +12,6 @@ import org.opendaylight.openflowplugin.api.openflow.device.DeviceContext; import org.opendaylight.openflowplugin.api.openflow.device.RequestContextStack; import org.opendaylight.openflowplugin.api.openflow.device.Xid; import org.opendaylight.openflowplugin.impl.services.AbstractSilentErrorService; -import org.opendaylight.openflowplugin.impl.services.util.ServiceException; import org.opendaylight.yang.gen.v1.urn.opendaylight.meter.service.rev130918.AddMeterInput; import org.opendaylight.yang.gen.v1.urn.opendaylight.meter.service.rev130918.RemoveMeterInput; import org.opendaylight.yang.gen.v1.urn.opendaylight.meter.service.rev130918.meter.update.OriginalMeter; @@ -34,7 +33,7 @@ public final class SingleLayerMeterService extends Abstrac } @Override - protected OfHeader buildRequest(final Xid xid, final Meter input) throws ServiceException { + protected OfHeader buildRequest(final Xid xid, final Meter input) { final MeterMessageBuilder meterMessageBuilder = new MeterMessageBuilder(input); final Class clazz = input.getImplementedInterface(); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerPortService.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerPortService.java index 34aa509522..c6eceee0d9 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerPortService.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerPortService.java @@ -12,7 +12,6 @@ import org.opendaylight.openflowplugin.api.openflow.device.DeviceContext; import org.opendaylight.openflowplugin.api.openflow.device.RequestContextStack; import org.opendaylight.openflowplugin.api.openflow.device.Xid; import org.opendaylight.openflowplugin.impl.services.AbstractSimpleService; -import org.opendaylight.openflowplugin.impl.services.util.ServiceException; import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.port.rev130925.CommonPortWithMask; import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.port.rev130925.PortMessageBuilder; import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.OfHeader; @@ -28,7 +27,7 @@ public final class SingleLayerPortService extends Abstract } @Override - protected OfHeader buildRequest(final Xid xid, final CommonPortWithMask input) throws ServiceException { + protected OfHeader buildRequest(final Xid xid, final CommonPortWithMask input) { return new PortMessageBuilder(input) .setVersion(getVersion()) .setXid(xid.getValue()) diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerSetAsyncConfigService.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerSetAsyncConfigService.java index 0e4f9971a5..bbfc248cb8 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerSetAsyncConfigService.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerSetAsyncConfigService.java @@ -12,7 +12,6 @@ import org.opendaylight.openflowplugin.api.openflow.device.DeviceContext; import org.opendaylight.openflowplugin.api.openflow.device.RequestContextStack; import org.opendaylight.openflowplugin.api.openflow.device.Xid; import org.opendaylight.openflowplugin.impl.services.AbstractSimpleService; -import org.opendaylight.openflowplugin.impl.services.util.ServiceException; import org.opendaylight.yang.gen.v1.urn.opendaylight.async.config.service.rev170619.AsyncConfigMessageBuilder; import org.opendaylight.yang.gen.v1.urn.opendaylight.async.config.service.rev170619.SetAsyncInput; import org.opendaylight.yang.gen.v1.urn.opendaylight.async.config.service.rev170619.SetAsyncOutput; @@ -26,7 +25,7 @@ public class SingleLayerSetAsyncConfigService extends AbstractSimpleService } @Override - protected OfHeader buildRequest(final Xid xid, final MultipartType input) throws ServiceException { + protected OfHeader buildRequest(final Xid xid, final MultipartType input) { return MultipartRequestInputFactory.makeMultipartRequest(xid.getValue(), getVersion(), input, diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/dedicated/StatisticsGatheringService.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/dedicated/StatisticsGatheringService.java index ade408bf9d..a0638491c7 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/dedicated/StatisticsGatheringService.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/dedicated/StatisticsGatheringService.java @@ -17,7 +17,6 @@ import org.opendaylight.openflowplugin.api.openflow.statistics.ofpspecific.Event import org.opendaylight.openflowplugin.api.openflow.statistics.ofpspecific.StatisticsGatherer; import org.opendaylight.openflowplugin.impl.common.MultipartRequestInputFactory; import org.opendaylight.openflowplugin.impl.services.AbstractMultipartService; -import org.opendaylight.openflowplugin.impl.services.util.ServiceException; import org.opendaylight.openflowplugin.impl.statistics.ofpspecific.EventsTimeCounter; import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.common.types.rev130731.MultipartType; import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.OfHeader; @@ -46,7 +45,7 @@ public class StatisticsGatheringService } @Override - protected OfHeader buildRequest(final Xid xid, final MultipartType input) throws ServiceException { + protected OfHeader buildRequest(final Xid xid, final MultipartType input) { return MultipartRequestInputFactory.makeMultipartRequest(xid.getValue(), getVersion(), input, diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/FlowDirectStatisticsService.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/FlowDirectStatisticsService.java index 81f4aeb7af..1a0303317d 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/FlowDirectStatisticsService.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/FlowDirectStatisticsService.java @@ -14,7 +14,6 @@ import org.opendaylight.openflowplugin.api.openflow.device.DeviceContext; import org.opendaylight.openflowplugin.api.openflow.device.RequestContextStack; import org.opendaylight.openflowplugin.api.openflow.device.Xid; import org.opendaylight.openflowplugin.impl.datastore.MultipartWriterProvider; -import org.opendaylight.openflowplugin.impl.services.util.ServiceException; import org.opendaylight.openflowplugin.impl.statistics.services.direct.AbstractFlowDirectStatisticsService; import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.ConvertorExecutor; import org.opendaylight.yang.gen.v1.urn.opendaylight.direct.statistics.rev160511.GetFlowStatisticsInput; @@ -59,7 +58,7 @@ public class FlowDirectStatisticsService extends AbstractFlowDirectStatisticsSer } @Override - protected OfHeader buildRequest(final Xid xid, final GetFlowStatisticsInput input) throws ServiceException { + protected OfHeader buildRequest(final Xid xid, final GetFlowStatisticsInput input) { return new MultipartRequestBuilder() .setXid(xid.getValue()) .setVersion(getVersion()) diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/GroupDirectStatisticsService.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/GroupDirectStatisticsService.java index e6eee3eb18..8dafbd6b8c 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/GroupDirectStatisticsService.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/GroupDirectStatisticsService.java @@ -14,7 +14,6 @@ import org.opendaylight.openflowplugin.api.openflow.device.DeviceContext; import org.opendaylight.openflowplugin.api.openflow.device.RequestContextStack; import org.opendaylight.openflowplugin.api.openflow.device.Xid; import org.opendaylight.openflowplugin.impl.datastore.MultipartWriterProvider; -import org.opendaylight.openflowplugin.impl.services.util.ServiceException; import org.opendaylight.openflowplugin.impl.statistics.services.direct.AbstractGroupDirectStatisticsService; import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.ConvertorExecutor; import org.opendaylight.yang.gen.v1.urn.opendaylight.direct.statistics.rev160511.GetGroupStatisticsInput; @@ -48,7 +47,7 @@ public class GroupDirectStatisticsService extends AbstractGroupDirectStatisticsS } @Override - protected OfHeader buildRequest(final Xid xid, final GetGroupStatisticsInput input) throws ServiceException { + protected OfHeader buildRequest(final Xid xid, final GetGroupStatisticsInput input) { return new MultipartRequestBuilder() .setXid(xid.getValue()) .setVersion(getVersion()) diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/MeterDirectStatisticsService.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/MeterDirectStatisticsService.java index 9bc8b6dfdd..4c7dc1daf0 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/MeterDirectStatisticsService.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/MeterDirectStatisticsService.java @@ -14,7 +14,6 @@ import org.opendaylight.openflowplugin.api.openflow.device.DeviceContext; import org.opendaylight.openflowplugin.api.openflow.device.RequestContextStack; import org.opendaylight.openflowplugin.api.openflow.device.Xid; import org.opendaylight.openflowplugin.impl.datastore.MultipartWriterProvider; -import org.opendaylight.openflowplugin.impl.services.util.ServiceException; import org.opendaylight.openflowplugin.impl.statistics.services.direct.AbstractMeterDirectStatisticsService; import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.ConvertorExecutor; import org.opendaylight.yang.gen.v1.urn.opendaylight.direct.statistics.rev160511.GetMeterStatisticsInput; @@ -48,7 +47,7 @@ public class MeterDirectStatisticsService extends AbstractMeterDirectStatisticsS } @Override - protected OfHeader buildRequest(final Xid xid, final GetMeterStatisticsInput input) throws ServiceException { + protected OfHeader buildRequest(final Xid xid, final GetMeterStatisticsInput input) { return new MultipartRequestBuilder() .setXid(xid.getValue()) .setVersion(getVersion()) diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/PortDirectStatisticsService.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/PortDirectStatisticsService.java index 20179df58b..52b2bc7522 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/PortDirectStatisticsService.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/PortDirectStatisticsService.java @@ -14,7 +14,6 @@ import org.opendaylight.openflowplugin.api.openflow.device.DeviceContext; import org.opendaylight.openflowplugin.api.openflow.device.RequestContextStack; import org.opendaylight.openflowplugin.api.openflow.device.Xid; import org.opendaylight.openflowplugin.impl.datastore.MultipartWriterProvider; -import org.opendaylight.openflowplugin.impl.services.util.ServiceException; import org.opendaylight.openflowplugin.impl.statistics.services.direct.AbstractPortDirectStatisticsService; import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.ConvertorExecutor; import org.opendaylight.yang.gen.v1.urn.opendaylight.direct.statistics.rev160511.GetNodeConnectorStatisticsInput; @@ -49,7 +48,7 @@ public class PortDirectStatisticsService extends AbstractPortDirectStatisticsSer @Override protected OfHeader buildRequest(final Xid xid, - final GetNodeConnectorStatisticsInput input) throws ServiceException { + final GetNodeConnectorStatisticsInput input) { return new MultipartRequestBuilder() .setXid(xid.getValue()) .setVersion(getVersion()) diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/QueueDirectStatisticsService.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/QueueDirectStatisticsService.java index 14229ff317..a3e09bebee 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/QueueDirectStatisticsService.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/QueueDirectStatisticsService.java @@ -14,7 +14,6 @@ import org.opendaylight.openflowplugin.api.openflow.device.DeviceContext; import org.opendaylight.openflowplugin.api.openflow.device.RequestContextStack; import org.opendaylight.openflowplugin.api.openflow.device.Xid; import org.opendaylight.openflowplugin.impl.datastore.MultipartWriterProvider; -import org.opendaylight.openflowplugin.impl.services.util.ServiceException; import org.opendaylight.openflowplugin.impl.statistics.services.direct.AbstractQueueDirectStatisticsService; import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.ConvertorExecutor; import org.opendaylight.yang.gen.v1.urn.opendaylight.direct.statistics.rev160511.GetQueueStatisticsInput; @@ -48,7 +47,7 @@ public class QueueDirectStatisticsService extends AbstractQueueDirectStatisticsS } @Override - protected OfHeader buildRequest(final Xid xid, final GetQueueStatisticsInput input) throws ServiceException { + protected OfHeader buildRequest(final Xid xid, final GetQueueStatisticsInput input) { return new MultipartRequestBuilder() .setXid(xid.getValue()) .setVersion(getVersion()) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/OpenFlowPluginProviderImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/OpenFlowPluginProviderImplTest.java index 24383c5469..c9eb819d4e 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/OpenFlowPluginProviderImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/OpenFlowPluginProviderImplTest.java @@ -88,7 +88,7 @@ public class OpenFlowPluginProviderImplTest { private static final int DEVICE_CONNECTION_RATE_LIMIT_PER_MIN = 0; @Before - public void setUp() throws Exception { + public void setUp() { when(dataBroker.newWriteOnlyTransaction()).thenReturn(writeTransaction); doReturn(CommitInfo.emptyFluentFuture()).when(writeTransaction).commit(); when(entityOwnershipService.registerListener(any(), any())).thenReturn(entityOwnershipListenerRegistration); @@ -109,7 +109,7 @@ public class OpenFlowPluginProviderImplTest { } @Test - public void testInitializeAndClose() throws Exception { + public void testInitializeAndClose() { final OpenFlowPluginProviderImpl provider = new OpenFlowPluginProviderImpl( configurationService, new SwitchConnectionProviderList(Lists.newArrayList(switchConnectionProvider)), diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/common/MultipartReplyTranslatorUtilTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/common/MultipartReplyTranslatorUtilTest.java index b84fd961ff..7cbe1e8170 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/common/MultipartReplyTranslatorUtilTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/common/MultipartReplyTranslatorUtilTest.java @@ -76,7 +76,7 @@ public class MultipartReplyTranslatorUtilTest { private TranslatorLibrarian translatorLibrarian; @Before - public void setUp() throws Exception { + public void setUp() { when(deviceInfo.getVersion()).thenReturn(OFConstants.OFP_VERSION_1_3); translatorLibrarian = new TranslatorLibrarian() { diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/common/MultipartRequestInputFactoryTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/common/MultipartRequestInputFactoryTest.java index 2a66f3a0c2..546c202ee7 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/common/MultipartRequestInputFactoryTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/common/MultipartRequestInputFactoryTest.java @@ -50,12 +50,12 @@ public class MultipartRequestInputFactoryTest { @Before - public void setUp() throws Exception { + public void setUp() { ofVersion = OFConstants.OFP_VERSION_1_3; } @Test - public void testMakeMultipartRequestInput_DESC() throws Exception { + public void testMakeMultipartRequestInput_DESC() { MultipartType mpType = MultipartType.OFPMPDESC; final MultipartRequestInput mpRqInput = (MultipartRequestInput) MultipartRequestInputFactory.makeMultipartRequest(xid, ofVersion, mpType, false); @@ -64,7 +64,7 @@ public class MultipartRequestInputFactoryTest { } @Test - public void testMakeMultipartRequestInput_FLOW_13() throws Exception { + public void testMakeMultipartRequestInput_FLOW_13() { final MultipartType mpType = MultipartType.OFPMPFLOW; final MultipartRequestInput mpRqInput = (MultipartRequestInput) MultipartRequestInputFactory.makeMultipartRequest(xid, ofVersion, mpType, false); @@ -85,7 +85,7 @@ public class MultipartRequestInputFactoryTest { } @Test - public void testMakeMultipartRequestInput_FLOW_10() throws Exception { + public void testMakeMultipartRequestInput_FLOW_10() { final MultipartType mpType = MultipartType.OFPMPFLOW; ofVersion = OFConstants.OFP_VERSION_1_0; final MultipartRequestInput mpRqInput = @@ -105,7 +105,7 @@ public class MultipartRequestInputFactoryTest { } @Test - public void testMakeMultipartRequestInputAggregate() throws Exception { + public void testMakeMultipartRequestInputAggregate() { MultipartType mpType = MultipartType.OFPMPAGGREGATE; final MultipartRequestInput mpRqInput = (MultipartRequestInput) MultipartRequestInputFactory.makeMultipartRequest(xid, ofVersion, mpType, false); @@ -115,7 +115,7 @@ public class MultipartRequestInputFactoryTest { } @Test - public void testMakeMultipartRequestInputTable() throws Exception { + public void testMakeMultipartRequestInputTable() { MultipartType mpType = MultipartType.OFPMPTABLE; final MultipartRequestInput mpRqInput = (MultipartRequestInput) MultipartRequestInputFactory.makeMultipartRequest(xid, ofVersion, mpType, false); @@ -124,7 +124,7 @@ public class MultipartRequestInputFactoryTest { } @Test - public void testMakeMultipartRequestInputPortStats() throws Exception { + public void testMakeMultipartRequestInputPortStats() { final MultipartType mpType = MultipartType.OFPMPPORTSTATS; final MultipartRequestInput mpRqInput = (MultipartRequestInput) MultipartRequestInputFactory.makeMultipartRequest(xid, ofVersion, mpType, false); @@ -137,7 +137,7 @@ public class MultipartRequestInputFactoryTest { } @Test - public void testMakeMultipartRequestInputQueue() throws Exception { + public void testMakeMultipartRequestInputQueue() { final MultipartType mpType = MultipartType.OFPMPQUEUE; final MultipartRequestInput mpRqInput = (MultipartRequestInput) MultipartRequestInputFactory.makeMultipartRequest(xid, ofVersion, mpType, false); @@ -151,7 +151,7 @@ public class MultipartRequestInputFactoryTest { } @Test - public void testMakeMultipartRequestInputGroup() throws Exception { + public void testMakeMultipartRequestInputGroup() { final MultipartType mpType = MultipartType.OFPMPGROUP; final MultipartRequestInput mpRqInput = (MultipartRequestInput) MultipartRequestInputFactory.makeMultipartRequest(xid, ofVersion, mpType, false); @@ -164,7 +164,7 @@ public class MultipartRequestInputFactoryTest { } @Test - public void testMakeMultipartRequestInputGroupDesc() throws Exception { + public void testMakeMultipartRequestInputGroupDesc() { MultipartType mpType = MultipartType.OFPMPGROUPDESC; final MultipartRequestInput mpRqInput = (MultipartRequestInput) MultipartRequestInputFactory.makeMultipartRequest(xid, ofVersion, mpType, false); @@ -174,7 +174,7 @@ public class MultipartRequestInputFactoryTest { } @Test - public void testMakeMultipartRequestInputGroupFeatures() throws Exception { + public void testMakeMultipartRequestInputGroupFeatures() { MultipartType mpType = MultipartType.OFPMPGROUPFEATURES; final MultipartRequestInput mpRqInput = (MultipartRequestInput) MultipartRequestInputFactory.makeMultipartRequest(xid, ofVersion, mpType, false); @@ -184,7 +184,7 @@ public class MultipartRequestInputFactoryTest { } @Test - public void testMakeMultipartRequestInputMeter() throws Exception { + public void testMakeMultipartRequestInputMeter() { final MultipartType mpType = MultipartType.OFPMPMETER; final MultipartRequestInput mpRqInput = (MultipartRequestInput) MultipartRequestInputFactory.makeMultipartRequest(xid, ofVersion, mpType, false); @@ -197,7 +197,7 @@ public class MultipartRequestInputFactoryTest { } @Test - public void testMakeMultipartRequestInputMeterConfig() throws Exception { + public void testMakeMultipartRequestInputMeterConfig() { final MultipartType mpType = MultipartType.OFPMPMETERCONFIG; final MultipartRequestInput mpRqInput = (MultipartRequestInput) MultipartRequestInputFactory.makeMultipartRequest(xid, ofVersion, mpType, false); @@ -211,7 +211,7 @@ public class MultipartRequestInputFactoryTest { } @Test - public void testMakeMultipartRequestInputMeterFeatures() throws Exception { + public void testMakeMultipartRequestInputMeterFeatures() { MultipartType mpType = MultipartType.OFPMPMETERFEATURES; final MultipartRequestInput mpRqInput = (MultipartRequestInput) MultipartRequestInputFactory.makeMultipartRequest(xid, ofVersion, mpType, false); @@ -221,7 +221,7 @@ public class MultipartRequestInputFactoryTest { } @Test - public void testMakeMultipartRequestInputTableFeatures() throws Exception { + public void testMakeMultipartRequestInputTableFeatures() { final MultipartType mpType = MultipartType.OFPMPTABLEFEATURES; final MultipartRequestInput mpRqInput = (MultipartRequestInput) MultipartRequestInputFactory.makeMultipartRequest(xid, ofVersion, mpType, false); @@ -235,7 +235,7 @@ public class MultipartRequestInputFactoryTest { } @Test - public void testMakeMultipartRequestInputPortDesc() throws Exception { + public void testMakeMultipartRequestInputPortDesc() { MultipartType mpType = MultipartType.OFPMPPORTDESC; final MultipartRequestInput mpRqInput = (MultipartRequestInput) MultipartRequestInputFactory.makeMultipartRequest(xid, ofVersion, mpType, false); @@ -245,7 +245,7 @@ public class MultipartRequestInputFactoryTest { } @Test - public void testMakeMultipartRequestInputExperimenter() throws Exception { + public void testMakeMultipartRequestInputExperimenter() { MultipartType mpType = MultipartType.OFPMPEXPERIMENTER; final MultipartRequestInput mpRqInput = (MultipartRequestInput) MultipartRequestInputFactory.makeMultipartRequest(xid, ofVersion, mpType, false); @@ -262,7 +262,7 @@ public class MultipartRequestInputFactoryTest { } private void checkEmptyBody(Class mpRqBody, Class expectedMpRqBodyClass) throws Exception { + MultipartRequestBody> expectedMpRqBodyClass) { Assert.assertTrue(expectedMpRqBodyClass.isAssignableFrom(mpRqBody)); Assert.assertEquals(expectedMpRqBodyClass, mpRqBody); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/configuration/ConfigurationServiceFactoryImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/configuration/ConfigurationServiceFactoryImplTest.java index a9685b24fd..3245b51b0f 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/configuration/ConfigurationServiceFactoryImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/configuration/ConfigurationServiceFactoryImplTest.java @@ -61,7 +61,7 @@ public class ConfigurationServiceFactoryImplTest { private ConfigurationService configurationService; @Before - public void setUp() throws Exception { + public void setUp() { when(config.isIsStatisticsPollingOn()).thenReturn(IS_STATISTICS_POLLING_ON); when(config.isIsFlowStatisticsPollingOn()).thenReturn(IS_STATISTICS_POLLING_ON); when(config.isIsTableStatisticsPollingOn()).thenReturn(IS_STATISTICS_POLLING_ON); @@ -96,7 +96,7 @@ public class ConfigurationServiceFactoryImplTest { } @Test - public void update() throws Exception { + public void update() { final int tpMinThreads = configurationService .getProperty(ConfigurationProperty.THREAD_POOL_MIN_THREADS.toString(), Integer::valueOf); @@ -114,7 +114,7 @@ public class ConfigurationServiceFactoryImplTest { } @Test - public void getProperty() throws Exception { + public void getProperty() { final int tpMaxThreads = configurationService .getProperty(ConfigurationProperty.THREAD_POOL_MAX_THREADS.toString(), Integer::valueOf); @@ -122,7 +122,7 @@ public class ConfigurationServiceFactoryImplTest { } @Test - public void registerListener() throws Exception { + public void registerListener() { configurationService.registerListener(configurationListener); verify(configurationListener, times(CONFIG_PROP_COUNT)).onPropertyChanged(any(), any()); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/configuration/OpenFlowProviderConfigImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/configuration/OpenFlowProviderConfigImplTest.java index ea153bddeb..af7ff22016 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/configuration/OpenFlowProviderConfigImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/configuration/OpenFlowProviderConfigImplTest.java @@ -47,7 +47,7 @@ public class OpenFlowProviderConfigImplTest { private OpenflowProviderConfig openflowProviderConfig; @Before - public void setUp() throws Exception { + public void setUp() { when(configurationService.getProperty(eq(ConfigurationProperty.IS_STATISTICS_POLLING_ON.toString()), any())) .thenReturn(IS_STATISTICS_POLLING_ON); when(configurationService.getProperty(eq(ConfigurationProperty.BARRIER_COUNT_LIMIT.toString()), any())) @@ -91,88 +91,88 @@ public class OpenFlowProviderConfigImplTest { } @Test - public void getRpcRequestsQuota() throws Exception { + public void getRpcRequestsQuota() { assertEquals(RPC_REQUESTS_QUOTA, openflowProviderConfig.getRpcRequestsQuota().getValue()); } @Test - public void isSwitchFeaturesMandatory() throws Exception { + public void isSwitchFeaturesMandatory() { assertEquals(SWITCH_FEATURES_MANDATORY, openflowProviderConfig.isSwitchFeaturesMandatory()); } @Test - public void getGlobalNotificationQuota() throws Exception { + public void getGlobalNotificationQuota() { assertEquals(GLOBAL_NOTIFICATION_QUOTA, openflowProviderConfig.getGlobalNotificationQuota()); } @Test - public void isIsStatisticsPollingOn() throws Exception { + public void isIsStatisticsPollingOn() { assertEquals(IS_STATISTICS_POLLING_ON, openflowProviderConfig.isIsStatisticsPollingOn()); } @Test - public void isIsStatisticsRpcEnabled() throws Exception { + public void isIsStatisticsRpcEnabled() { assertEquals(IS_STATISTICS_RPC_ENABLED, openflowProviderConfig.isIsStatisticsRpcEnabled()); } @Test - public void getBarrierIntervalTimeoutLimit() throws Exception { + public void getBarrierIntervalTimeoutLimit() { assertEquals(BARRIER_INTERVAL_TIMEOUT_LIMIT, openflowProviderConfig.getBarrierIntervalTimeoutLimit() .getValue()); } @Test - public void getBarrierCountLimit() throws Exception { + public void getBarrierCountLimit() { assertEquals(BARRIER_COUNT_LIMIT, openflowProviderConfig.getBarrierCountLimit().getValue()); } @Test - public void getEchoReplyTimeout() throws Exception { + public void getEchoReplyTimeout() { assertEquals(ECHO_REPLY_TIMEOUT, openflowProviderConfig.getEchoReplyTimeout().getValue()); } @Test - public void getThreadPoolMinThreads() throws Exception { + public void getThreadPoolMinThreads() { assertEquals(THREAD_POOL_MIN_THREADS, openflowProviderConfig.getThreadPoolMinThreads()); } @Test - public void getThreadPoolMaxThreads() throws Exception { + public void getThreadPoolMaxThreads() { assertEquals(THREAD_POOL_MAX_THREADS, openflowProviderConfig.getThreadPoolMaxThreads().getValue()); } @Test - public void getThreadPoolTimeout() throws Exception { + public void getThreadPoolTimeout() { assertEquals(THREAD_POOL_TIMEOUT, openflowProviderConfig.getThreadPoolTimeout()); } @Test - public void isEnableFlowRemovedNotification() throws Exception { + public void isEnableFlowRemovedNotification() { assertEquals(ENABLE_FLOW_REMOVED_NOTIFICATION, openflowProviderConfig.isEnableFlowRemovedNotification()); } @Test - public void isSkipTableFeatures() throws Exception { + public void isSkipTableFeatures() { assertEquals(SKIP_TABLE_FEATURES, openflowProviderConfig.isSkipTableFeatures()); } @Test - public void getBasicTimerDelay() throws Exception { + public void getBasicTimerDelay() { assertEquals(BASIC_TIMER_DELAY, openflowProviderConfig.getBasicTimerDelay().getValue()); } @Test - public void getMaximumTimerDelay() throws Exception { + public void getMaximumTimerDelay() { assertEquals(MAXIMUM_TIMER_DELAY, openflowProviderConfig.getMaximumTimerDelay().getValue()); } @Test - public void isUseSingleLayerSerialization() throws Exception { + public void isUseSingleLayerSerialization() { assertEquals(USE_SINGLE_LAYER_SERIALIZATION, openflowProviderConfig.isUseSingleLayerSerialization()); } @Test - public void getDeviceConnectionRateLimitPerMin() throws Exception { + public void getDeviceConnectionRateLimitPerMin() { assertEquals(DEVICE_CONNECTION_RATE_LIMIT_PER_MIN, openflowProviderConfig.getDeviceConnectionRateLimitPerMin()); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/ConnectionContextImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/ConnectionContextImplTest.java index bca7a967fb..9903d206f3 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/ConnectionContextImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/ConnectionContextImplTest.java @@ -44,7 +44,7 @@ public class ConnectionContextImplTest { private ConnectionContextImpl connectionContext; @Before - public void setUp() throws Exception { + public void setUp() { Mockito.when(connetionAdapter.getRemoteAddress()) .thenReturn(InetSocketAddress.createUnresolved("ofp-ut.example.org", 4242)); Mockito.when(connetionAdapter.isAlive()).thenReturn(true); @@ -59,7 +59,7 @@ public class ConnectionContextImplTest { } @Test - public void testCloseConnection1() throws Exception { + public void testCloseConnection1() { connectionContext.closeConnection(true); Mockito.verify(outboundQueueRegistration).close(); Mockito.verify(handshakeContext).close(); @@ -70,7 +70,7 @@ public class ConnectionContextImplTest { } @Test - public void testCloseConnection2() throws Exception { + public void testCloseConnection2() { connectionContext.closeConnection(false); Mockito.verify(outboundQueueRegistration).close(); Mockito.verify(handshakeContext).close(); @@ -81,7 +81,7 @@ public class ConnectionContextImplTest { } @Test - public void testOnConnectionClosed() throws Exception { + public void testOnConnectionClosed() { connectionContext.onConnectionClosed(); Assert.assertEquals(ConnectionContext.CONNECTION_STATE.RIP, connectionContext.getConnectionState()); Mockito.verify(outboundQueueRegistration).close(); @@ -91,19 +91,19 @@ public class ConnectionContextImplTest { } @Test - public void testChangeStateToHandshaking() throws Exception { + public void testChangeStateToHandshaking() { connectionContext.changeStateToHandshaking(); Assert.assertEquals(ConnectionContext.CONNECTION_STATE.HANDSHAKING, connectionContext.getConnectionState()); } @Test - public void testChangeStateToTimeouting() throws Exception { + public void testChangeStateToTimeouting() { connectionContext.changeStateToTimeouting(); Assert.assertEquals(ConnectionContext.CONNECTION_STATE.TIMEOUTING, connectionContext.getConnectionState()); } @Test - public void testChangeStateToWorking() throws Exception { + public void testChangeStateToWorking() { connectionContext.changeStateToWorking(); Assert.assertEquals(ConnectionContext.CONNECTION_STATE.WORKING, connectionContext.getConnectionState()); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/ErrorHandlerSimpleImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/ErrorHandlerSimpleImplTest.java index dd215eb0e0..12754dc556 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/ErrorHandlerSimpleImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/ErrorHandlerSimpleImplTest.java @@ -18,7 +18,7 @@ public class ErrorHandlerSimpleImplTest extends TestCase { ErrorHandler errorHandler = new ErrorHandlerSimpleImpl(); @Test - public void testHandleException() throws Exception { + public void testHandleException() { ConnectionException connectionException = new ConnectionException("Exception for testing purpose only."); errorHandler.handleException(connectionException); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/HandshakeManagerImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/HandshakeManagerImplTest.java index e4746f7048..7edc9b7d86 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/HandshakeManagerImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/HandshakeManagerImplTest.java @@ -151,7 +151,7 @@ public class HandshakeManagerImplTest { * */ @Test - public void testVersionNegotiation10() throws Exception { + public void testVersionNegotiation10() { LOG.debug("testVersionNegotiation10"); Short version = OFConstants.OFP_VERSION_1_0; @@ -170,7 +170,7 @@ public class HandshakeManagerImplTest { * */ @Test - public void testVersionNegotiation10SwitchStarts() throws Exception { + public void testVersionNegotiation10SwitchStarts() { LOG.debug("testVersionNegotiation10-ss"); Short version = OFConstants.OFP_VERSION_1_0; @@ -187,7 +187,7 @@ public class HandshakeManagerImplTest { * Switch delivers first helloMessage with version 0x00 = negotiation unsuccessful */ @Test - public void testVersionNegotiation00() throws Exception { + public void testVersionNegotiation00() { LOG.debug("testVersionNegotiation00"); expectedErrors = 1; Short version = (short) 0x00; @@ -203,7 +203,7 @@ public class HandshakeManagerImplTest { * Switch delivers first helloMessage with version 0x00 = negotiation unsuccessful */ @Test - public void testVersionNegotiation00SwitchStarts() throws Exception { + public void testVersionNegotiation00SwitchStarts() { LOG.debug("testVersionNegotiation00-ss"); expectedErrors = 1; Short version = (short) 0x00; @@ -221,7 +221,7 @@ public class HandshakeManagerImplTest { * */ @Test - public void testVersionNegotiation11() throws Exception { + public void testVersionNegotiation11() { LOG.debug("testVersionNegotiation11"); Short version = (short) 0x02; Short expVersion = (short) 0x01; @@ -240,7 +240,7 @@ public class HandshakeManagerImplTest { * Test of version negotiation Where 1.0 < switch version < 1.3. */ @Test - public void testVersionNegotiation11SwitchStarts() throws Exception { + public void testVersionNegotiation11SwitchStarts() { LOG.debug("testVersionNegotiation11-ss"); final Short version = (short) 0x02; final Short expVersion = (short) 0x01; @@ -262,7 +262,7 @@ public class HandshakeManagerImplTest { * */ @Test - public void testVersionNegotiation13() throws Exception { + public void testVersionNegotiation13() { LOG.debug("testVersionNegotiation13"); Short version = OFConstants.OFP_VERSION_1_3; @@ -279,7 +279,7 @@ public class HandshakeManagerImplTest { * */ @Test - public void testVersionNegotiation13SwitchStarts() throws Exception { + public void testVersionNegotiation13SwitchStarts() { LOG.debug("testVersionNegotiation13-ss"); Short version = OFConstants.OFP_VERSION_1_3; @@ -298,7 +298,7 @@ public class HandshakeManagerImplTest { * */ @Test - public void testVersionNegotiation15() throws Exception { + public void testVersionNegotiation15() { LOG.debug("testVersionNegotiation15"); Short version = (short) 0x06; Short expVersion = OFConstants.OFP_VERSION_1_3; @@ -318,7 +318,7 @@ public class HandshakeManagerImplTest { * */ @Test - public void testVersionNegotiation15SwitchStart() throws Exception { + public void testVersionNegotiation15SwitchStart() { LOG.debug("testVersionNegotiation15-ss"); Short version = (short) 0x06; Short expVersion = OFConstants.OFP_VERSION_1_3; @@ -338,7 +338,7 @@ public class HandshakeManagerImplTest { * */ @Test - public void testVersionNegotiation15_MultipleCall() throws Exception { + public void testVersionNegotiation15_MultipleCall() { LOG.debug("testVersionNegotiation15_MultipleCall"); Short version = (short) 0x06; expectedErrors = 1; @@ -356,7 +356,7 @@ public class HandshakeManagerImplTest { * */ @Test - public void testVersionNegotiation15_MultipleCallSwitchStarts() throws Exception { + public void testVersionNegotiation15_MultipleCallSwitchStarts() { LOG.debug("testVersionNegotiation15_MultipleCall-ss"); Short version = (short) 0x06; expectedErrors = 1; @@ -376,7 +376,7 @@ public class HandshakeManagerImplTest { * */ @Test - public void testVersionNegotiation10InBitmap() throws Exception { + public void testVersionNegotiation10InBitmap() { LOG.debug("testVersionNegotiation10InBitmap"); Short version = OFConstants.OFP_VERSION_1_0; handshakeManager.setUseVersionBitmap(true); @@ -397,7 +397,7 @@ public class HandshakeManagerImplTest { * */ @Test - public void testVersionNegotiation10InBitmapSwitchStarts() throws Exception { + public void testVersionNegotiation10InBitmapSwitchStarts() { LOG.debug("testVersionNegotiation10InBitmap-ss"); Short version = OFConstants.OFP_VERSION_1_0; handshakeManager.setUseVersionBitmap(true); @@ -420,7 +420,7 @@ public class HandshakeManagerImplTest { * */ @Test - public void testVersionNegotiation13InBitmap() throws Exception { + public void testVersionNegotiation13InBitmap() { LOG.debug("testVersionNegotiation13InBitmap"); Short version = OFConstants.OFP_VERSION_1_3; handshakeManager.setUseVersionBitmap(true); @@ -441,7 +441,7 @@ public class HandshakeManagerImplTest { * */ @Test - public void testVersionNegotiation13InBitmapSwitchFirst() throws Exception { + public void testVersionNegotiation13InBitmapSwitchFirst() { LOG.debug("testVersionNegotiation13InBitmap-ss"); Short version = OFConstants.OFP_VERSION_1_3; handshakeManager.setUseVersionBitmap(true); @@ -464,7 +464,7 @@ public class HandshakeManagerImplTest { * */ @Test - public void testVersionNegotiationNoCommonVersionInBitmap() throws Exception { + public void testVersionNegotiationNoCommonVersionInBitmap() { LOG.debug("testVersionNegotiationNoCommonVersionInBitmap"); Short version = (short) 0x05; expectedErrors = 1; @@ -484,7 +484,7 @@ public class HandshakeManagerImplTest { * */ @Test - public void testVersionNegotiationNoCommonVersionInBitmapSwitchStarts() throws Exception { + public void testVersionNegotiationNoCommonVersionInBitmapSwitchStarts() { LOG.debug("testVersionNegotiationNoCommonVersionInBitmap-ss"); Short version = (short) 0x05; expectedErrors = 1; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/OutboundQueueProviderImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/OutboundQueueProviderImplTest.java index 1cd2c37be2..9549fc3c8c 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/OutboundQueueProviderImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/OutboundQueueProviderImplTest.java @@ -25,7 +25,7 @@ public class OutboundQueueProviderImplTest extends TestCase { new OutboundQueueProviderImpl(OFConstants.OFP_VERSION_1_3); @Test - public void testReserveEntry() throws Exception { + public void testReserveEntry() { outboundQueueProvider.onConnectionQueueChanged(null); Long returnValue = outboundQueueProvider.reserveEntry(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/listener/HandshakeListenerImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/listener/HandshakeListenerImplTest.java index 2d8f34a897..74a64d59e6 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/listener/HandshakeListenerImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/listener/HandshakeListenerImplTest.java @@ -56,7 +56,7 @@ public class HandshakeListenerImplTest { private HandshakeListenerImpl handshakeListener; @Before - public void setUp() throws Exception { + public void setUp() { Mockito.when(connectionAdapter.barrier(ArgumentMatchers.any())) .thenReturn(RpcResultBuilder.success(new BarrierOutputBuilder().build()).buildFuture()); connectionContextSpy = Mockito.spy(new ConnectionContextImpl(connectionAdapter)); @@ -67,12 +67,12 @@ public class HandshakeListenerImplTest { } @After - public void tearDown() throws Exception { + public void tearDown() { Mockito.verify(handshakeContext).close(); } @Test - public void testOnHandshakeSuccessfull() throws Exception { + public void testOnHandshakeSuccessfull() { handshakeListener.onHandshakeSuccessful(features, OFConstants.OFP_VERSION_1_3); Mockito.verify(connectionContextSpy).changeStateToWorking(); Mockito.verify(connectionContextSpy).setFeatures(any(FeaturesReply.class)); @@ -85,7 +85,7 @@ public class HandshakeListenerImplTest { } @Test - public void testOnHandshakeFailure1() throws Exception { + public void testOnHandshakeFailure1() { connectionContextSpy.setNodeId(new NodeId("ut-device:10")); handshakeListener.onHandshakeFailure(); Mockito.verify(handshakeContext).close(); @@ -93,7 +93,7 @@ public class HandshakeListenerImplTest { } @Test - public void testOnHandshakeFailure2() throws Exception { + public void testOnHandshakeFailure2() { Mockito.when(connectionAdapter.getRemoteAddress()) .thenReturn(InetSocketAddress.createUnresolved("ut-ofp.example.org", 4242)); connectionContextSpy.setNodeId(new NodeId("openflow:1")); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/listener/OpenflowProtocolListenerInitialImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/listener/OpenflowProtocolListenerInitialImplTest.java index 5601d0cc27..e7302c355d 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/listener/OpenflowProtocolListenerInitialImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/listener/OpenflowProtocolListenerInitialImplTest.java @@ -42,7 +42,7 @@ public class OpenflowProtocolListenerInitialImplTest { private OpenflowProtocolListenerInitialImpl openflowProtocolListenerInitial; @Before - public void setUp() throws Exception { + public void setUp() { Mockito.when(connectionAdapter.isAlive()).thenReturn(true); Mockito.when(connectionContext.getConnectionAdapter()).thenReturn(connectionAdapter); Mockito.when(connectionContext.getConnectionState()) @@ -53,7 +53,7 @@ public class OpenflowProtocolListenerInitialImplTest { } @Test - public void testOnEchoRequestMessage() throws Exception { + public void testOnEchoRequestMessage() { EchoRequestMessageBuilder echoRequestMessageBld = new EchoRequestMessageBuilder() .setXid(42L) .setVersion(OFConstants.OFP_VERSION_1_3); @@ -63,7 +63,7 @@ public class OpenflowProtocolListenerInitialImplTest { } @Test - public void testOnHelloMessage() throws Exception { + public void testOnHelloMessage() { HelloMessageBuilder helloMessageBld = new HelloMessageBuilder() .setXid(42L) .setVersion(OFConstants.OFP_VERSION_1_3); @@ -73,7 +73,7 @@ public class OpenflowProtocolListenerInitialImplTest { } @Test - public void testCheckState() throws Exception { + public void testCheckState() { Assert.assertFalse(openflowProtocolListenerInitial.checkState(ConnectionContext.CONNECTION_STATE.HANDSHAKING)); Assert.assertTrue(openflowProtocolListenerInitial.checkState(ConnectionContext.CONNECTION_STATE.HANDSHAKING)); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/listener/SystemNotificationsListenerImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/listener/SystemNotificationsListenerImplTest.java index c95d7e4efc..7c5054aece 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/listener/SystemNotificationsListenerImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/listener/SystemNotificationsListenerImplTest.java @@ -84,7 +84,7 @@ public class SystemNotificationsListenerImplTest { } @After - public void tearDown() throws Exception { + public void tearDown() { Mockito.verifyNoMoreInteractions(connectionContext); } @@ -92,7 +92,7 @@ public class SystemNotificationsListenerImplTest { * Successful scenario - connection is on and closes without errors. */ @Test - public void testOnDisconnectEvent1() throws Exception { + public void testOnDisconnectEvent1() { DisconnectEvent disconnectNotification = new DisconnectEventBuilder().setInfo("testing disconnect").build(); systemNotificationsListener.onDisconnectEvent(disconnectNotification); @@ -107,7 +107,7 @@ public class SystemNotificationsListenerImplTest { * Broken scenario - connection is on but fails to close. */ @Test - public void testOnDisconnectEvent2() throws Exception { + public void testOnDisconnectEvent2() { DisconnectEvent disconnectNotification = new DisconnectEventBuilder().setInfo("testing disconnect").build(); systemNotificationsListener.onDisconnectEvent(disconnectNotification); @@ -122,7 +122,7 @@ public class SystemNotificationsListenerImplTest { * Successful scenario - connection is already down. */ @Test - public void testOnDisconnectEvent3() throws Exception { + public void testOnDisconnectEvent3() { connectionContextGolem.changeStateToTimeouting(); DisconnectEvent disconnectNotification = new DisconnectEventBuilder().setInfo("testing disconnect").build(); @@ -138,7 +138,7 @@ public class SystemNotificationsListenerImplTest { * Broken scenario - connection is on but throws error on close. */ @Test - public void testOnDisconnectEvent4() throws Exception { + public void testOnDisconnectEvent4() { Mockito.when(connectionContext.getConnectionState()).thenReturn(ConnectionContext.CONNECTION_STATE.RIP); DisconnectEvent disconnectNotification = new DisconnectEventBuilder().setInfo("testing disconnect").build(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/DeviceContextImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/DeviceContextImplTest.java index 71c1e3c78b..ece6796c8d 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/DeviceContextImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/DeviceContextImplTest.java @@ -181,7 +181,7 @@ public class DeviceContextImplTest { private DeviceContext deviceContextSpy; @Before - public void setUp() throws Exception { + public void setUp() { final FluentFuture> noExistNodeFuture = FluentFutures.immediateFluentFuture(Optional.empty()); Mockito.lenient().when(readTx.read(LogicalDatastoreType.OPERATIONAL, nodeKeyIdent)) @@ -278,7 +278,7 @@ public class DeviceContextImplTest { } @Test - public void testInitialSubmitTransaction() throws Exception { + public void testInitialSubmitTransaction() { Mockito.doReturn(CommitInfo.emptyFluentFuture()).when(writeTx).commit(); final InstanceIdentifier dummyII = InstanceIdentifier.create(Nodes.class); ((DeviceContextImpl) deviceContext).getTransactionChainManager().activateTransactionManager() ; @@ -297,7 +297,7 @@ public class DeviceContextImplTest { } @Test - public void testAddDeleteToTxChain() throws Exception { + public void testAddDeleteToTxChain() { final InstanceIdentifier dummyII = InstanceIdentifier.create(Nodes.class); ((DeviceContextImpl) deviceContext).getTransactionChainManager().activateTransactionManager() ; ((DeviceContextImpl) deviceContext).getTransactionChainManager().initialSubmitWriteTransaction(); @@ -306,7 +306,7 @@ public class DeviceContextImplTest { } @Test - public void testSubmitTransaction() throws Exception { + public void testSubmitTransaction() { ((DeviceContextImpl) deviceContext).getTransactionChainManager().activateTransactionManager() ; ((DeviceContextImpl) deviceContext).getTransactionChainManager().initialSubmitWriteTransaction(); assertTrue(deviceContext.submitTransaction()); @@ -413,7 +413,7 @@ public class DeviceContextImplTest { } @Test - public void testPortStatusMessage() throws Exception { + public void testPortStatusMessage() { final PortStatusMessage mockedPortStatusMessage = mock(PortStatusMessage.class); final Class dummyClass = Class.class; when(mockedPortStatusMessage.getImplementedInterface()).thenReturn(dummyClass); @@ -431,7 +431,7 @@ public class DeviceContextImplTest { } @Test - public void testProcessFlowRemovedMessage() throws Exception { + public void testProcessFlowRemovedMessage() { // prepare translation result final FlowRemovedBuilder flowRemovedMdsalBld = new FlowRemovedBuilder() .setTableId((short) 0) @@ -484,17 +484,17 @@ public class DeviceContextImplTest { } @Test - public void instantiateServiceInstance() throws Exception { + public void instantiateServiceInstance() { deviceContext.instantiateServiceInstance(); } @Test - public void close() throws Exception { + public void close() { deviceContext.close(); } @Test - public void closeServiceInstance() throws Exception { + public void closeServiceInstance() { deviceContext.closeServiceInstance(); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/DeviceManagerImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/DeviceManagerImplTest.java index a0bf7482d8..1f1074abc9 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/DeviceManagerImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/DeviceManagerImplTest.java @@ -104,7 +104,7 @@ public class DeviceManagerImplTest { private DeviceManagerImpl deviceManager; @Before - public void setUp() throws Exception { + public void setUp() { when(mockConnectionContext.getFeatures()).thenReturn(mockFeatures); when(mockConnectionContext.getConnectionAdapter()).thenReturn(mockedConnectionAdapter); when(mockConnectionContext.getDeviceInfo()).thenReturn(deviceInfo); @@ -139,7 +139,7 @@ public class DeviceManagerImplTest { } @Test - public void createContext() throws Exception { + public void createContext() { final DeviceContext context = deviceManager.createContext(mockConnectionContext); assertEquals(deviceInfo, context.getDeviceInfo()); @@ -167,7 +167,7 @@ public class DeviceManagerImplTest { } @Test - public void sendNodeAddedNotification() throws Exception { + public void sendNodeAddedNotification() { deviceManager.sendNodeAddedNotification(DUMMY_IDENTIFIER); deviceManager.sendNodeAddedNotification(DUMMY_IDENTIFIER); verify(notificationPublishService).offerNotification(new NodeUpdatedBuilder() @@ -177,7 +177,7 @@ public class DeviceManagerImplTest { } @Test - public void sendNodeRemovedNotification() throws Exception { + public void sendNodeRemovedNotification() { deviceManager.sendNodeAddedNotification(DUMMY_IDENTIFIER); deviceManager.sendNodeRemovedNotification(DUMMY_IDENTIFIER); deviceManager.sendNodeRemovedNotification(DUMMY_IDENTIFIER); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/PacketInRateLimiterTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/PacketInRateLimiterTest.java index fb546dfc7f..c9e0978793 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/PacketInRateLimiterTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/PacketInRateLimiterTest.java @@ -36,13 +36,13 @@ public class PacketInRateLimiterTest { private InOrder caOrdered; @Before - public void setUp() throws Exception { + public void setUp() { caOrdered = Mockito.inOrder(connectionAdapter); rateLimiter = new PacketInRateLimiter(connectionAdapter, 4, 10, messageSpy, 0.5f); } @Test - public void testDisableFlow() throws Exception { + public void testDisableFlow() { rateLimiter.disableFlow(); Mockito.verify(messageSpy).spyMessage(DeviceContext.class, MessageSpy.StatisticsGroup.OFJ_BACKPRESSURE_ON); @@ -50,7 +50,7 @@ public class PacketInRateLimiterTest { } @Test - public void testEnableFlow() throws Exception { + public void testEnableFlow() { rateLimiter.enableFlow(); Mockito.verify(messageSpy).spyMessage(DeviceContext.class, MessageSpy.StatisticsGroup.OFJ_BACKPRESSURE_OFF); @@ -58,7 +58,7 @@ public class PacketInRateLimiterTest { } @Test - public void testDrainLowWaterMark() throws Exception { + public void testDrainLowWaterMark() { // scenario: // occupy 4 permits // drain low water mark = lwm temporarily set to 50% (= 2) and get limited @@ -111,7 +111,7 @@ public class PacketInRateLimiterTest { } @Test - public void testAcquirePermit() throws Exception { + public void testAcquirePermit() { Assert.assertEquals(0, rateLimiter.getOccupiedPermits()); Assert.assertFalse(rateLimiter.isLimited()); @@ -141,7 +141,7 @@ public class PacketInRateLimiterTest { } @Test - public void testChangeWaterMarks1() throws Exception { + public void testChangeWaterMarks1() { rateLimiter.changeWaterMarks(2, 4); acquirePermits(4); Assert.assertEquals(4, rateLimiter.getOccupiedPermits()); @@ -168,7 +168,7 @@ public class PacketInRateLimiterTest { } @Test - public void testChangeWaterMarks2() throws Exception { + public void testChangeWaterMarks2() { // draining to lwm/occupied = 3/6 acquirePermits(6); rateLimiter.drainLowWaterMark(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/SwitchFeaturesUtilTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/SwitchFeaturesUtilTest.java index f6dd9445a3..2b50238b75 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/SwitchFeaturesUtilTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/SwitchFeaturesUtilTest.java @@ -33,13 +33,13 @@ public class SwitchFeaturesUtilTest { * and {@link SwitchFeaturesUtil SwitchFeaturesUtil}. */ @Before - public void setUp() throws Exception { + public void setUp() { featuresOutputBuilder = new GetFeaturesOutputBuilder(); swUtil = SwitchFeaturesUtil.getInstance(); } @After - public void tearDown() throws Exception { + public void tearDown() { featuresOutputBuilder = null; swUtil = null; } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/TransactionChainManagerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/TransactionChainManagerTest.java index 9d3f1f721b..1fdad07299 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/TransactionChainManagerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/TransactionChainManagerTest.java @@ -59,7 +59,7 @@ public class TransactionChainManagerTest { private NodeId nodeId; @Before - public void setUp() throws Exception { + public void setUp() { final ReadTransaction readOnlyTx = Mockito.mock(ReadTransaction.class); Mockito.when(dataBroker.createTransactionChain(any(TransactionChainListener.class))) .thenReturn(txChain); @@ -74,12 +74,12 @@ public class TransactionChainManagerTest { } @After - public void tearDown() throws Exception { + public void tearDown() { Mockito.verifyNoMoreInteractions(txChain, writeTx); } @Test - public void testWriteToTransaction() throws Exception { + public void testWriteToTransaction() { final Node data = new NodeBuilder().setId(nodeId).build(); txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data, false); @@ -91,7 +91,7 @@ public class TransactionChainManagerTest { * Tests transaction submit {@link TransactionChainManager#submitTransaction()}. */ @Test - public void testSubmitTransaction() throws Exception { + public void testSubmitTransaction() { final Node data = new NodeBuilder().setId(nodeId).build(); txChainManager.initialSubmitWriteTransaction(); txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data, false); @@ -106,7 +106,7 @@ public class TransactionChainManagerTest { * test of {@link TransactionChainManager#submitTransaction()}: no submit, never enabled. */ @Test - public void testSubmitTransaction1() throws Exception { + public void testSubmitTransaction1() { final Node data = new NodeBuilder().setId(nodeId).build(); txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data, false); txChainManager.submitTransaction(); @@ -117,7 +117,7 @@ public class TransactionChainManagerTest { } @Test - public void testSubmitTransactionFailed() throws Exception { + public void testSubmitTransactionFailed() { Mockito.doReturn(FluentFutures.immediateFailedFluentFuture(new TransactionCommitFailedException("mock"))) .when(writeTx).commit(); final Node data = new NodeBuilder().setId(nodeId).build(); @@ -134,7 +134,7 @@ public class TransactionChainManagerTest { * Test of {@link TransactionChainManager#enableSubmit()}: no submit - counter is not active. */ @Test - public void testEnableCounter1() throws Exception { + public void testEnableCounter1() { final Node data = new NodeBuilder().setId(nodeId).build(); txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data, false); txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data, false); @@ -145,7 +145,7 @@ public class TransactionChainManagerTest { } @Test - public void testOnTransactionChainFailed() throws Exception { + public void testOnTransactionChainFailed() { txChainManager.onTransactionChainFailed(txChain, Mockito.mock(Transaction.class), Mockito.mock(Throwable.class)); Mockito.verify(txChain).close(); @@ -153,14 +153,14 @@ public class TransactionChainManagerTest { } @Test - public void testOnTransactionChainSuccessful() throws Exception { + public void testOnTransactionChainSuccessful() { txChainManager.onTransactionChainSuccessful(transactionChain); // NOOP Mockito.verifyZeroInteractions(transactionChain); } @Test - public void testAddDeleteOperationTotTxChain() throws Exception { + public void testAddDeleteOperationTotTxChain() { txChainManager.addDeleteOperationToTxChain(LogicalDatastoreType.CONFIGURATION, path); Mockito.verify(txChain).newReadWriteTransaction(); @@ -168,14 +168,14 @@ public class TransactionChainManagerTest { } @Test - public void testDeactivateTransactionChainManager() throws Exception { + public void testDeactivateTransactionChainManager() { txChainManager.deactivateTransactionManager(); Mockito.verify(txChain).close(); } @Test - public void testDeactivateTransactionChainManagerFailed() throws Exception { + public void testDeactivateTransactionChainManagerFailed() { final Node data = new NodeBuilder().setId(nodeId).build(); txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data, false); @@ -189,7 +189,7 @@ public class TransactionChainManagerTest { } @Test - public void testShuttingDown() throws Exception { + public void testShuttingDown() { final Node data = new NodeBuilder().setId(nodeId).build(); txChainManager.initialSubmitWriteTransaction(); txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data, false); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/initialization/DeviceInitializerProviderTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/initialization/DeviceInitializerProviderTest.java index fe94f681db..a3c2bdddea 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/initialization/DeviceInitializerProviderTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/initialization/DeviceInitializerProviderTest.java @@ -26,12 +26,12 @@ public class DeviceInitializerProviderTest { private DeviceInitializerProvider provider; @Before - public void setUp() throws Exception { + public void setUp() { provider = new DeviceInitializerProvider(); } @Test - public void register() throws Exception { + public void register() { provider.register(OFConstants.OFP_VERSION_1_3, abstractDeviceInitializer); final Optional lookup = provider.lookup(OFConstants.OFP_VERSION_1_3); assertTrue(lookup.isPresent()); @@ -39,7 +39,7 @@ public class DeviceInitializerProviderTest { } @Test - public void lookup() throws Exception { + public void lookup() { assertFalse(provider.lookup(OFConstants.OFP_VERSION_1_0).isPresent()); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/initialization/OF10DeviceInitializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/initialization/OF10DeviceInitializerTest.java index d7da59d728..8c6ec8934f 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/initialization/OF10DeviceInitializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/initialization/OF10DeviceInitializerTest.java @@ -75,7 +75,7 @@ public class OF10DeviceInitializerTest { private AbstractDeviceInitializer deviceInitializer; @Before - public void setUp() throws Exception { + public void setUp() { final KeyedInstanceIdentifier nodeInstanceIdentifier = DeviceStateUtil .createNodeInstanceIdentifier(new NodeId("openflow:1")); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/initialization/OF13DeviceInitializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/initialization/OF13DeviceInitializerTest.java index 3491d0a832..0f219b2006 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/initialization/OF13DeviceInitializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/device/initialization/OF13DeviceInitializerTest.java @@ -82,7 +82,7 @@ public class OF13DeviceInitializerTest { private AbstractDeviceInitializer deviceInitializer; @Before - public void setUp() throws Exception { + public void setUp() { final KeyedInstanceIdentifier nodeInstanceIdentifier = DeviceStateUtil .createNodeInstanceIdentifier(new NodeId("openflow:1")); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/karaf/ShowStatsCommandProviderTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/karaf/ShowStatsCommandProviderTest.java index b573d6f788..870f233a68 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/karaf/ShowStatsCommandProviderTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/karaf/ShowStatsCommandProviderTest.java @@ -45,7 +45,7 @@ public class ShowStatsCommandProviderTest extends AbstractKarafTest { } @After - public void tearDown() throws Exception { + public void tearDown() { // Pattern.DOTALL is set inline via "(?s)" at the beginning Mockito.verify(console).print(matches("(?s).+")); messageIntelligenceAgency.resetStatistics(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/lifecycle/ContextChainHolderImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/lifecycle/ContextChainHolderImplTest.java index 9a1c30174d..b684cb7a8f 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/lifecycle/ContextChainHolderImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/lifecycle/ContextChainHolderImplTest.java @@ -118,12 +118,12 @@ public class ContextChainHolderImplTest { } @Test - public void addManager() throws Exception { + public void addManager() { Assert.assertTrue(contextChainHolder.checkAllManagers()); } @Test - public void createContextChain() throws Exception { + public void createContextChain() { contextChainHolder.createContextChain(connectionContext); Mockito.verify(deviceManager).createContext(Mockito.any(ConnectionContext.class)); Mockito.verify(rpcManager).createContext(Mockito.any(DeviceContext.class)); @@ -133,7 +133,7 @@ public class ContextChainHolderImplTest { @Test - public void reconciliationFrameworkFailure() throws Exception { + public void reconciliationFrameworkFailure() { Mockito.when(reconciliationFrameworkEvent.onDevicePrepared(deviceInfo)) .thenReturn(Futures.immediateFailedFuture(new Throwable("test"))); contextChainHolder.createContextChain(connectionContext); @@ -145,7 +145,7 @@ public class ContextChainHolderImplTest { } @Test - public void reconciliationFrameworkDisconnect() throws Exception { + public void reconciliationFrameworkDisconnect() { Mockito.when(reconciliationFrameworkEvent.onDevicePrepared(deviceInfo)) .thenReturn(Futures.immediateFuture(ResultState.DISCONNECT)); contextChainHolder.createContextChain(connectionContext); @@ -157,7 +157,7 @@ public class ContextChainHolderImplTest { } @Test - public void reconciliationFrameworkSuccess() throws Exception { + public void reconciliationFrameworkSuccess() { contextChainHolder.createContextChain(connectionContext); Mockito.when(reconciliationFrameworkEvent.onDevicePrepared(deviceInfo)) .thenReturn(Futures.immediateFuture(ResultState.DONOTHING)); @@ -170,7 +170,7 @@ public class ContextChainHolderImplTest { } @Test - public void reconciliationFrameworkSuccessButNotSubmit() throws Exception { + public void reconciliationFrameworkSuccessButNotSubmit() { contextChainHolder.createContextChain(connectionContext); // TODO when if (future != null) check in MastershipChangeServiceManagerImpl's becomeSlaveOrDisconnect() is rm // Mockito.when(reconciliationFrameworkEvent.onDevicePrepared(deviceInfo)) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/lifecycle/ContextChainImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/lifecycle/ContextChainImplTest.java index 690717634b..5bac78556d 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/lifecycle/ContextChainImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/lifecycle/ContextChainImplTest.java @@ -56,7 +56,7 @@ public class ContextChainImplTest { private ContextChain contextChain; @Before - public void setUp() throws Exception { + public void setUp() { Mockito.when(deviceContext.getDeviceInfo()).thenReturn(deviceInfo); Mockito.when(deviceInfo.getServiceIdentifier()).thenReturn(SERVICE_GROUP_IDENTIFIER); Mockito.when(deviceContext.closeServiceInstance()).thenReturn(Futures.immediateFuture(null)); @@ -75,7 +75,7 @@ public class ContextChainImplTest { } @Test - public void closeServiceInstance() throws Exception { + public void closeServiceInstance() { contextChain.closeServiceInstance(); Mockito.verify(deviceContext).closeServiceInstance(); Mockito.verify(rpcContext).closeServiceInstance(); @@ -83,7 +83,7 @@ public class ContextChainImplTest { } @Test - public void close() throws Exception { + public void close() { contextChain.registerDeviceRemovedHandler(deviceRemovedHandler); contextChain.close(); Mockito.verify(statisticsContext).close(); @@ -93,7 +93,7 @@ public class ContextChainImplTest { } @Test - public void closeTwoTimes() throws Exception { + public void closeTwoTimes() { contextChain.registerDeviceRemovedHandler(deviceRemovedHandler); contextChain.close(); contextChain.close(); @@ -102,7 +102,7 @@ public class ContextChainImplTest { } @Test - public void closeThreeTimes() throws Exception { + public void closeThreeTimes() { contextChain.registerDeviceRemovedHandler(deviceRemovedHandler); contextChain.close(); contextChain.close(); @@ -111,12 +111,12 @@ public class ContextChainImplTest { } @Test - public void getIdentifier() throws Exception { + public void getIdentifier() { Assert.assertEquals(contextChain.getIdentifier(), SERVICE_GROUP_IDENTIFIER); } @Test - public void instantiateServiceInstanceFail() throws Exception { + public void instantiateServiceInstanceFail() { Mockito.doThrow(new IllegalStateException()).when(deviceContext).instantiateServiceInstance(); contextChain.instantiateServiceInstance(); Mockito.verify(contextChainMastershipWatcher) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/mastership/MastershipChangeServiceManagerImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/mastership/MastershipChangeServiceManagerImplTest.java index 4f78d953a3..dc1faa98d1 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/mastership/MastershipChangeServiceManagerImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/mastership/MastershipChangeServiceManagerImplTest.java @@ -55,12 +55,12 @@ public class MastershipChangeServiceManagerImplTest { } @Test - public void register() throws Exception { + public void register() { Assert.assertNotNull(registration); } @Test - public void registerTwice() throws Exception { + public void registerTwice() { MastershipChangeRegistration registration2; registration2 = manager.register(secondService); Assert.assertNotNull(registration); @@ -79,7 +79,7 @@ public class MastershipChangeServiceManagerImplTest { } @Test - public void reconciliationFrameworkRegistration() throws Exception { + public void reconciliationFrameworkRegistration() { Assert.assertNotNull(registrationRF); } @@ -97,7 +97,7 @@ public class MastershipChangeServiceManagerImplTest { } @Test - public void becomeMaster() throws Exception { + public void becomeMaster() { manager.becomeMaster(deviceInfo); Mockito.verify(service).onBecomeOwner(deviceInfo); manager.becomeSlaveOrDisconnect(deviceInfo); @@ -105,7 +105,7 @@ public class MastershipChangeServiceManagerImplTest { } @Test - public void becomeMasterBeforeDS() throws Exception { + public void becomeMasterBeforeDS() { manager.becomeMasterBeforeSubmittedDS(deviceInfo); Mockito.verify(event).onDevicePrepared(deviceInfo); } @@ -118,7 +118,7 @@ public class MastershipChangeServiceManagerImplTest { } @Test - public void evokeEventAfterRegistration() throws Exception { + public void evokeEventAfterRegistration() { List deviceInfos = new ArrayList<>(); deviceInfos.add(deviceInfo); manager.setMasterChecker(masterChecker); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/mastership/MastershipServiceDelegateTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/mastership/MastershipServiceDelegateTest.java index c1b1ec1adc..f6bd14b9a2 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/mastership/MastershipServiceDelegateTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/mastership/MastershipServiceDelegateTest.java @@ -32,12 +32,12 @@ public class MastershipServiceDelegateTest { private MastershipServiceDelegate mastershipServiceDelegate; @Before - public void setUp() throws Exception { + public void setUp() { mastershipServiceDelegate = new MastershipServiceDelegate(mastershipChangeService, unregisterService); } @After - public void tearDown() throws Exception { + public void tearDown() { verifyNoMoreInteractions(mastershipChangeService); verifyNoMoreInteractions(unregisterService); } @@ -49,13 +49,13 @@ public class MastershipServiceDelegateTest { } @Test - public void onBecomeOwner() throws Exception { + public void onBecomeOwner() { mastershipServiceDelegate.onBecomeOwner(deviceInfo); verify(mastershipChangeService).onBecomeOwner(deviceInfo); } @Test - public void onLoseOwnership() throws Exception { + public void onLoseOwnership() { mastershipServiceDelegate.onLoseOwnership(deviceInfo); verify(mastershipChangeService).onLoseOwnership(deviceInfo); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/AbstractDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/AbstractDeserializerTest.java index 11f1e92f2e..8b02bc4178 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/AbstractDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/AbstractDeserializerTest.java @@ -34,7 +34,7 @@ public abstract class AbstractDeserializerTest { private DeserializationFactory factory; @Before - public void setUp() throws Exception { + public void setUp() { registry = new DeserializerRegistryImpl(); registry.init(); factory = new DeserializationFactory(registry); @@ -45,7 +45,7 @@ public abstract class AbstractDeserializerTest { } @After - public void tearDown() throws Exception { + public void tearDown() { DeserializerInjector.revertDeserializers(provider); MessageDeserializerInjector.revertLegacyDeserializers(provider); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/MessageDeserializerInjectorTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/MessageDeserializerInjectorTest.java index c63720d052..a38e7345b2 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/MessageDeserializerInjectorTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/MessageDeserializerInjectorTest.java @@ -36,13 +36,13 @@ public class MessageDeserializerInjectorTest { injector; @Before - public void setUp() throws Exception { + public void setUp() { injector = MessageDeserializerInjector.createInjector(switchConnectionProvider, EncodeConstants .OF13_VERSION_ID); } @Test - public void injectDeserializers() throws Exception { + public void injectDeserializers() { injector.apply(10).apply(OfHeader.class).accept(ofDeserializer); verify(switchConnectionProvider).unregisterDeserializerMapping(new TypeToClassKey(EncodeConstants .OF13_VERSION_ID, 10)); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/CopyTtlInActionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/CopyTtlInActionDeserializerTest.java index 1233b70df8..0b858c0c97 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/CopyTtlInActionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/CopyTtlInActionDeserializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class CopyTtlInActionDeserializerTest extends AbstractActionDeserializerTest { @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); writeHeader(in); in.writeZero(ActionConstants.PADDING_IN_ACTION_HEADER); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/CopyTtlOutActionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/CopyTtlOutActionDeserializerTest.java index 8664b942d0..df6029d6df 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/CopyTtlOutActionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/CopyTtlOutActionDeserializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class CopyTtlOutActionDeserializerTest extends AbstractActionDeserializerTest { @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); writeHeader(in); in.writeZero(ActionConstants.PADDING_IN_ACTION_HEADER); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/DecMplsTtlActionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/DecMplsTtlActionDeserializerTest.java index 523b9b55db..111fbfce79 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/DecMplsTtlActionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/DecMplsTtlActionDeserializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class DecMplsTtlActionDeserializerTest extends AbstractActionDeserializerTest { @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); writeHeader(in); in.writeZero(ActionConstants.PADDING_IN_ACTION_HEADER); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/DecNwTtlActionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/DecNwTtlActionDeserializerTest.java index 042d972f91..c34bc3db1e 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/DecNwTtlActionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/DecNwTtlActionDeserializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class DecNwTtlActionDeserializerTest extends AbstractActionDeserializerTest { @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); writeHeader(in); in.writeZero(ActionConstants.PADDING_IN_ACTION_HEADER); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/GroupActionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/GroupActionDeserializerTest.java index 2ac12464bb..d74de713c8 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/GroupActionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/GroupActionDeserializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class GroupActionDeserializerTest extends AbstractActionDeserializerTest { @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final int groupId = 10; writeHeader(in); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/OutputActionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/OutputActionDeserializerTest.java index 78dc6e26c4..efd1c2b453 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/OutputActionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/OutputActionDeserializerTest.java @@ -24,7 +24,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class OutputActionDeserializerTest extends AbstractActionDeserializerTest { @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final int portNum = 10; final short maxLength = 24; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PopMplsActionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PopMplsActionDeserializerTest.java index bfa103a553..865465b337 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PopMplsActionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PopMplsActionDeserializerTest.java @@ -22,7 +22,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class PopMplsActionDeserializerTest extends AbstractActionDeserializerTest { @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final short ethType = 10; writeHeader(in); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PopPbbActionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PopPbbActionDeserializerTest.java index c2475578a1..1634e2f5c6 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PopPbbActionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PopPbbActionDeserializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class PopPbbActionDeserializerTest extends AbstractActionDeserializerTest { @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); writeHeader(in); in.writeZero(ActionConstants.PADDING_IN_ACTION_HEADER); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PopVlanActionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PopVlanActionDeserializerTest.java index c0e5de8d81..0d28b786fa 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PopVlanActionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PopVlanActionDeserializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class PopVlanActionDeserializerTest extends AbstractActionDeserializerTest { @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); writeHeader(in); in.writeZero(ActionConstants.PADDING_IN_ACTION_HEADER); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PushMplsActionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PushMplsActionDeserializerTest.java index 1e6c7a73c5..a386a54129 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PushMplsActionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PushMplsActionDeserializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class PushMplsActionDeserializerTest extends AbstractActionDeserializerTest { @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final short ethType = 10; writeHeader(in); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PushPbbActionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PushPbbActionDeserializerTest.java index cfa09680c3..fbee9e841a 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PushPbbActionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PushPbbActionDeserializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class PushPbbActionDeserializerTest extends AbstractActionDeserializerTest { @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final short ethType = 10; writeHeader(in); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PushVlanActionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PushVlanActionDeserializerTest.java index 98225c30bb..4a6e38a7ab 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PushVlanActionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/PushVlanActionDeserializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class PushVlanActionDeserializerTest extends AbstractActionDeserializerTest { @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final short ethType = 10; writeHeader(in); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/SetFieldActionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/SetFieldActionDeserializerTest.java index fcdb910fa1..424194b51f 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/SetFieldActionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/SetFieldActionDeserializerTest.java @@ -25,7 +25,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class SetFieldActionDeserializerTest extends AbstractActionDeserializerTest { @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final int portNum = 0xfffffffa; writeHeader(in); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/SetMplsTtlActionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/SetMplsTtlActionDeserializerTest.java index d2173640da..c4c06a77f1 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/SetMplsTtlActionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/SetMplsTtlActionDeserializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class SetMplsTtlActionDeserializerTest extends AbstractActionDeserializerTest { @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final short mplsTtl = 10; writeHeader(in); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/SetNwTtlActionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/SetNwTtlActionDeserializerTest.java index ec8546b4f6..7a3045a26d 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/SetNwTtlActionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/SetNwTtlActionDeserializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class SetNwTtlActionDeserializerTest extends AbstractActionDeserializerTest { @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final short nwTtl = 10; writeHeader(in); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/SetQueueActionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/SetQueueActionDeserializerTest.java index 6cc48057af..31f03a92b0 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/SetQueueActionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/SetQueueActionDeserializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class SetQueueActionDeserializerTest extends AbstractActionDeserializerTest { @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final int queueId = 10; writeHeader(in); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/ApplyActionsInstructionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/ApplyActionsInstructionDeserializerTest.java index ef81734b0a..09339f26d1 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/ApplyActionsInstructionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/ApplyActionsInstructionDeserializerTest.java @@ -37,7 +37,7 @@ public class ApplyActionsInstructionDeserializerTest extends AbstractInstruction } @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); // Header diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/ClearActionsInstructionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/ClearActionsInstructionDeserializerTest.java index c878af29a1..9a1e9399b1 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/ClearActionsInstructionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/ClearActionsInstructionDeserializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.instru public class ClearActionsInstructionDeserializerTest extends AbstractInstructionDeserializerTest { @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); writeHeader(in); in.writeZero(InstructionConstants.PADDING_IN_ACTIONS_INSTRUCTION); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/GoToTableInstructionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/GoToTableInstructionDeserializerTest.java index cdc8a7e244..0204951357 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/GoToTableInstructionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/GoToTableInstructionDeserializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.instru public class GoToTableInstructionDeserializerTest extends AbstractInstructionDeserializerTest { @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final short tableId = 3; writeHeader(in); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/MeterInstructionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/MeterInstructionDeserializerTest.java index 0b78cb9e8f..a1c8655f80 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/MeterInstructionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/MeterInstructionDeserializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.instru public class MeterInstructionDeserializerTest extends AbstractInstructionDeserializerTest { @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final int meterId = 3; writeHeader(in); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/WriteActionsInstructionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/WriteActionsInstructionDeserializerTest.java index ca7d27fafe..beecbc29fc 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/WriteActionsInstructionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/WriteActionsInstructionDeserializerTest.java @@ -37,7 +37,7 @@ public class WriteActionsInstructionDeserializerTest extends AbstractInstruction } @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); // Header diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/WriteMetadataInstructionDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/WriteMetadataInstructionDeserializerTest.java index 9852ae9931..ae1dc3a2b6 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/WriteMetadataInstructionDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/instruction/WriteMetadataInstructionDeserializerTest.java @@ -24,7 +24,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.instru public class WriteMetadataInstructionDeserializerTest extends AbstractInstructionDeserializerTest { @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final BigInteger metadata = BigInteger.valueOf(1234L); final BigInteger metadataMask = BigInteger.valueOf(9876L); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/ArpOpEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/ArpOpEntryDeserializerTest.java index 3e7b1709e8..c43d3731f2 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/ArpOpEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/ArpOpEntryDeserializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class ArpOpEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final int arpOp = 10; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/ArpSourceHardwareAddressEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/ArpSourceHardwareAddressEntryDeserializerTest.java index 0d4d3923d3..75bbd1e846 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/ArpSourceHardwareAddressEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/ArpSourceHardwareAddressEntryDeserializerTest.java @@ -23,7 +23,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class ArpSourceHardwareAddressEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final MacAddress arpSourceHardwareAddress = new MacAddress("00:01:02:03:04:05"); final MacAddress arpSourceHardwareAddressMask = new MacAddress("00:00:00:00:00:00"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/ArpSourceTransportAddressEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/ArpSourceTransportAddressEntryDeserializerTest.java index 666df7a686..a34a750f53 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/ArpSourceTransportAddressEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/ArpSourceTransportAddressEntryDeserializerTest.java @@ -26,7 +26,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class ArpSourceTransportAddressEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final Ipv4Prefix arpSourceTransportAddress = new Ipv4Prefix("192.168.0.0/24"); final Ipv4Prefix arpSourceTransportAddressNoMask = new Ipv4Prefix("192.168.0.0/32"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/ArpTargetHardwareAddressEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/ArpTargetHardwareAddressEntryDeserializerTest.java index 123f9f1353..6d5a189d3b 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/ArpTargetHardwareAddressEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/ArpTargetHardwareAddressEntryDeserializerTest.java @@ -23,7 +23,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class ArpTargetHardwareAddressEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final MacAddress arpTargetHardwareAddress = new MacAddress("00:01:02:03:04:05"); final MacAddress arpTargetHardwareAddressMask = new MacAddress("00:00:00:00:00:00"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/ArpTargetTransportAddressEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/ArpTargetTransportAddressEntryDeserializerTest.java index a783c9b67b..1178e5d474 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/ArpTargetTransportAddressEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/ArpTargetTransportAddressEntryDeserializerTest.java @@ -26,7 +26,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class ArpTargetTransportAddressEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final Ipv4Prefix arpTargetTransportAddress = new Ipv4Prefix("192.168.0.0/24"); final Ipv4Prefix arpTargetTransportAddressNoMask = new Ipv4Prefix("192.168.0.0/32"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/EthernetDestinationEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/EthernetDestinationEntryDeserializerTest.java index 1c488ec298..7f3a6aa19c 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/EthernetDestinationEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/EthernetDestinationEntryDeserializerTest.java @@ -22,7 +22,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class EthernetDestinationEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final MacAddress ethernetDestinationAddress = new MacAddress("00:01:02:03:04:05"); final MacAddress ethernetDestinationAddressMask = new MacAddress("00:00:00:00:00:00"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/EthernetSourceEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/EthernetSourceEntryDeserializerTest.java index ed83b661ac..47db37a605 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/EthernetSourceEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/EthernetSourceEntryDeserializerTest.java @@ -22,7 +22,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class EthernetSourceEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final MacAddress ethernetSourceAddress = new MacAddress("00:01:02:03:04:05"); final MacAddress ethernetSourceAddressMask = new MacAddress("00:00:00:00:00:00"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/EthernetTypeEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/EthernetTypeEntryDeserializerTest.java index ede1cf769e..a6423f89b4 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/EthernetTypeEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/EthernetTypeEntryDeserializerTest.java @@ -19,7 +19,7 @@ import org.opendaylight.openflowjava.protocol.api.util.OxmMatchConstants; public class EthernetTypeEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final int ethType = 0x800; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Icmpv4CodeEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Icmpv4CodeEntryDeserializerTest.java index f3665573a0..c9fbf7f17c 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Icmpv4CodeEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Icmpv4CodeEntryDeserializerTest.java @@ -19,7 +19,7 @@ import org.opendaylight.openflowjava.protocol.api.util.OxmMatchConstants; public class Icmpv4CodeEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final short code = 7; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Icmpv4TypeEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Icmpv4TypeEntryDeserializerTest.java index 5064722756..f940f6b5c8 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Icmpv4TypeEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Icmpv4TypeEntryDeserializerTest.java @@ -19,7 +19,7 @@ import org.opendaylight.openflowjava.protocol.api.util.OxmMatchConstants; public class Icmpv4TypeEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final short type = 7; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Icmpv6CodeEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Icmpv6CodeEntryDeserializerTest.java index 513c795190..0817d0d67a 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Icmpv6CodeEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Icmpv6CodeEntryDeserializerTest.java @@ -19,7 +19,7 @@ import org.opendaylight.openflowjava.protocol.api.util.OxmMatchConstants; public class Icmpv6CodeEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final short code = 7; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Icmpv6TypeEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Icmpv6TypeEntryDeserializerTest.java index 768f97eb18..823f004a37 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Icmpv6TypeEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Icmpv6TypeEntryDeserializerTest.java @@ -19,7 +19,7 @@ import org.opendaylight.openflowjava.protocol.api.util.OxmMatchConstants; public class Icmpv6TypeEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final short type = 7; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/InPhyPortEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/InPhyPortEntryDeserializerTest.java index 65f85eac6f..2acfb3063d 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/InPhyPortEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/InPhyPortEntryDeserializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.openflowplugin.openflow.md.util.OpenflowPortsUtil; public class InPhyPortEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final int port = -6; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/InPortEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/InPortEntryDeserializerTest.java index d28c2daa64..2bed6d9e59 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/InPortEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/InPortEntryDeserializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.openflowplugin.openflow.md.util.OpenflowPortsUtil; public class InPortEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final int port = -6; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/IpDscpEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/IpDscpEntryDeserializerTest.java index 4bf225e286..8774d03653 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/IpDscpEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/IpDscpEntryDeserializerTest.java @@ -19,7 +19,7 @@ import org.opendaylight.openflowjava.protocol.api.util.OxmMatchConstants; public class IpDscpEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final short ipDscp = 7; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/IpEcnEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/IpEcnEntryDeserializerTest.java index 86fbb64367..9e1b27311d 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/IpEcnEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/IpEcnEntryDeserializerTest.java @@ -19,7 +19,7 @@ import org.opendaylight.openflowjava.protocol.api.util.OxmMatchConstants; public class IpEcnEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final short ipEcn = 7; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/IpProtoEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/IpProtoEntryDeserializerTest.java index 2d470b269d..828e573330 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/IpProtoEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/IpProtoEntryDeserializerTest.java @@ -19,7 +19,7 @@ import org.opendaylight.openflowjava.protocol.api.util.OxmMatchConstants; public class IpProtoEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final short ipProto = 7; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv4DestinationEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv4DestinationEntryDeserializerTest.java index 58c8265ff0..79baddf8e3 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv4DestinationEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv4DestinationEntryDeserializerTest.java @@ -26,7 +26,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Ipv4DestinationEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final Ipv4Prefix address = new Ipv4Prefix("192.168.72.0/24"); final Iterator addressParts = IpConversionUtil.splitToParts(address); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv4SourceEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv4SourceEntryDeserializerTest.java index edd2f6a530..71d4a24d22 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv4SourceEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv4SourceEntryDeserializerTest.java @@ -26,7 +26,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Ipv4SourceEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final Ipv4Prefix address = new Ipv4Prefix("192.168.72.0/24"); final Iterator addressParts = IpConversionUtil.splitToParts(address); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6DestinationEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6DestinationEntryDeserializerTest.java index e36bc7db6b..9d7c7d1b98 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6DestinationEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6DestinationEntryDeserializerTest.java @@ -23,7 +23,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Ipv6DestinationEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final Ipv6Prefix address = new Ipv6Prefix("fe80::200:f8ff:fe21:67cf/30"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6ExtHeaderEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6ExtHeaderEntryDeserializerTest.java index 46700669ae..07a8703fc9 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6ExtHeaderEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6ExtHeaderEntryDeserializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Ipv6ExtHeaderEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final int extHeader = 10; final int extHeaderMask = 8; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6FlabelEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6FlabelEntryDeserializerTest.java index 1c55074f37..2e926a66d1 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6FlabelEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6FlabelEntryDeserializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Ipv6FlabelEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final int flowLabel = 10; final int flowLabelMask = 8; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6NdSllEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6NdSllEntryDeserializerTest.java index 2c8e2707e2..0abb27f6b3 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6NdSllEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6NdSllEntryDeserializerTest.java @@ -22,7 +22,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Ipv6NdSllEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final MacAddress address = new MacAddress("00:01:02:03:04:05"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6NdTargetEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6NdTargetEntryDeserializerTest.java index d8131392a9..3869b3f839 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6NdTargetEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6NdTargetEntryDeserializerTest.java @@ -23,7 +23,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Ipv6NdTargetEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final Ipv6Address address = new Ipv6Address("2001:db8::"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6NdTllEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6NdTllEntryDeserializerTest.java index 4ac20ff0af..110833cb3a 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6NdTllEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6NdTllEntryDeserializerTest.java @@ -22,7 +22,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Ipv6NdTllEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final MacAddress address = new MacAddress("00:01:02:03:04:05"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6SourceEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6SourceEntryDeserializerTest.java index d40e7361a7..25c4b25a65 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6SourceEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/Ipv6SourceEntryDeserializerTest.java @@ -23,7 +23,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Ipv6SourceEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final Ipv6Prefix address = new Ipv6Prefix("fe80::200:f8ff:fe21:67cf/30"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/MetadataEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/MetadataEntryDeserializerTest.java index d65aa98c33..bc45a91044 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/MetadataEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/MetadataEntryDeserializerTest.java @@ -22,7 +22,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class MetadataEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final BigInteger metadata = BigInteger.valueOf(20); final BigInteger metadataMask = BigInteger.valueOf(30); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/MplsBosEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/MplsBosEntryDeserializerTest.java index e9853d9e87..c89114f789 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/MplsBosEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/MplsBosEntryDeserializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class MplsBosEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final short mplsBos = 6; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/MplsLabelEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/MplsLabelEntryDeserializerTest.java index e6d96d2d15..45eeda5c0c 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/MplsLabelEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/MplsLabelEntryDeserializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class MplsLabelEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final int mplsLabel = 10; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/MplsTcEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/MplsTcEntryDeserializerTest.java index bdba3a8b14..3660205c36 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/MplsTcEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/MplsTcEntryDeserializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class MplsTcEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final short mplsTc = 6; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/PbbEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/PbbEntryDeserializerTest.java index 57d5b52ee1..05f37c6486 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/PbbEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/PbbEntryDeserializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class PbbEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final long pbb = 6; final long pbbMask = 5; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/SctpDestinationPortEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/SctpDestinationPortEntryDeserializerTest.java index aa4fd5f212..4456ccf7ed 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/SctpDestinationPortEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/SctpDestinationPortEntryDeserializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class SctpDestinationPortEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final int port = 22; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/SctpSourcePortEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/SctpSourcePortEntryDeserializerTest.java index b05cc164e2..990a4b26d3 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/SctpSourcePortEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/SctpSourcePortEntryDeserializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class SctpSourcePortEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final int port = 22; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/TcpDestinationPortEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/TcpDestinationPortEntryDeserializerTest.java index 3a038cd764..f033940926 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/TcpDestinationPortEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/TcpDestinationPortEntryDeserializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class TcpDestinationPortEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final int port = 22; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/TcpFlagsEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/TcpFlagsEntryDeserializerTest.java index 5aef1bd0f0..d897510f30 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/TcpFlagsEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/TcpFlagsEntryDeserializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class TcpFlagsEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final int tcpFlags = 6; final int tcpFlagsMask = 5; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/TcpSourcePortEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/TcpSourcePortEntryDeserializerTest.java index 31ce7228cc..6dcf7d00eb 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/TcpSourcePortEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/TcpSourcePortEntryDeserializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class TcpSourcePortEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final int port = 22; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/TunnelIdEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/TunnelIdEntryDeserializerTest.java index 4b3f0e7a40..f6ceff81a6 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/TunnelIdEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/TunnelIdEntryDeserializerTest.java @@ -23,7 +23,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class TunnelIdEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final BigInteger tunnelId = BigInteger.valueOf(6); final BigInteger tunnelIdMask = BigInteger.valueOf(5); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/UdpDestinationPortEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/UdpDestinationPortEntryDeserializerTest.java index 10172200fd..30a598d6e1 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/UdpDestinationPortEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/UdpDestinationPortEntryDeserializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class UdpDestinationPortEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final int port = 22; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/UdpSourcePortEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/UdpSourcePortEntryDeserializerTest.java index b39392be1c..ed07da294e 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/UdpSourcePortEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/UdpSourcePortEntryDeserializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class UdpSourcePortEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final int port = 22; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/VlanPcpEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/VlanPcpEntryDeserializerTest.java index bbbee15d9e..6ee6f289ef 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/VlanPcpEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/VlanPcpEntryDeserializerTest.java @@ -19,7 +19,7 @@ import org.opendaylight.openflowjava.protocol.api.util.OxmMatchConstants; public class VlanPcpEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final short vlanPcp = 7; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/VlanVidEntryDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/VlanVidEntryDeserializerTest.java index fd1d975204..14964f0b15 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/VlanVidEntryDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/match/VlanVidEntryDeserializerTest.java @@ -22,7 +22,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class VlanVidEntryDeserializerTest extends AbstractMatchEntryDeserializerTest { @Test - public void deserializeEntry() throws Exception { + public void deserializeEntry() { final ByteBuf in = UnpooledByteBufAllocator.DEFAULT.buffer(); final int vlanVid = 8; final byte[] vlanMask = new byte[]{16, 0}; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/FlowMessageDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/FlowMessageDeserializerTest.java index fa74fc899e..a1daa00b1d 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/FlowMessageDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/FlowMessageDeserializerTest.java @@ -62,7 +62,7 @@ public class FlowMessageDeserializerTest extends AbstractDeserializerTest { } @Test - public void deserialize() throws Exception { + public void deserialize() { // Flow header buffer.writeByte(TYPE); buffer.writeShort(EncodeConstants.EMPTY_LENGTH); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/GroupMessageDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/GroupMessageDeserializerTest.java index 3a24e8e130..1d0caa73da 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/GroupMessageDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/GroupMessageDeserializerTest.java @@ -44,7 +44,7 @@ public class GroupMessageDeserializerTest extends AbstractDeserializerTest { } @Test - public void deserialize() throws Exception { + public void deserialize() { // Group header buffer.writeByte(TYPE); buffer.writeShort(EncodeConstants.EMPTY_LENGTH); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/MeterMessageDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/MeterMessageDeserializerTest.java index bac0ff6ad0..628424aefd 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/MeterMessageDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/MeterMessageDeserializerTest.java @@ -50,7 +50,7 @@ public class MeterMessageDeserializerTest extends AbstractDeserializerTest { } @Test - public void deserialize() throws Exception { + public void deserialize() { buffer.writeByte(TYPE); // Message type buffer.writeShort(EncodeConstants.EMPTY_LENGTH); buffer.writeInt(XID); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/PacketInMessageDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/PacketInMessageDeserializerTest.java index 1cf28613cd..11d3414ee4 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/PacketInMessageDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/PacketInMessageDeserializerTest.java @@ -39,7 +39,7 @@ public class PacketInMessageDeserializerTest extends AbstractDeserializerTest { } @Test - public void deserialize() throws Exception { + public void deserialize() { buffer.writeByte(TYPE); buffer.writeShort(EncodeConstants.EMPTY_LENGTH); buffer.writeInt(XID); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/PortMessageDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/PortMessageDeserializerTest.java index 22d5c65586..e7619d85eb 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/PortMessageDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/PortMessageDeserializerTest.java @@ -60,7 +60,7 @@ public class PortMessageDeserializerTest extends AbstractDeserializerTest { } @Test - public void deserialize() throws Exception { + public void deserialize() { buffer.writeByte(TYPE); buffer.writeShort(EncodeConstants.EMPTY_LENGTH); buffer.writeInt(XID); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyDescDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyDescDeserializerTest.java index 1caef2ff1d..729eb48d3b 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyDescDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyDescDeserializerTest.java @@ -26,7 +26,7 @@ public class MultipartReplyDescDeserializerTest extends AbstractMultipartDeseria private static final String DESCRIPTION = "Description"; @Test - public void deserialize() throws Exception { + public void deserialize() { ByteBuf buffer = UnpooledByteBufAllocator.DEFAULT.buffer(); buffer.writeBytes(MANUFACTURER.getBytes()); buffer.writeZero(DESC_STR_LEN - MANUFACTURER.length()); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyFlowAggregateStatsDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyFlowAggregateStatsDeserializerTest.java index e1a36578d7..8deff4a9ac 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyFlowAggregateStatsDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyFlowAggregateStatsDeserializerTest.java @@ -23,7 +23,7 @@ public class MultipartReplyFlowAggregateStatsDeserializerTest extends AbstractMu private static final byte PADDING_IN_MULTIPART_REPLY_HEADER = 4; @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { ByteBuf buffer = UnpooledByteBufAllocator.DEFAULT.buffer(); buffer.writeLong(PACKET_COUNT); buffer.writeLong(BYTE_COUNT); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyFlowStatsDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyFlowStatsDeserializerTest.java index 041c1c1319..0496b30af3 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyFlowStatsDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyFlowStatsDeserializerTest.java @@ -56,7 +56,7 @@ public class MultipartReplyFlowStatsDeserializerTest extends AbstractMultipartDe private static final int MPLS_LABEL = 135; @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { ByteBuf buffer = UnpooledByteBufAllocator.DEFAULT.buffer(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyFlowTableStatsDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyFlowTableStatsDeserializerTest.java index 8613feb869..04c49b458f 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyFlowTableStatsDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyFlowTableStatsDeserializerTest.java @@ -24,7 +24,7 @@ public class MultipartReplyFlowTableStatsDeserializerTest extends AbstractMultip private static final byte PADDING_IN_TABLE_HEADER = 3; @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { ByteBuf buffer = UnpooledByteBufAllocator.DEFAULT.buffer(); buffer.writeByte(TABLE_ID); buffer.writeZero(PADDING_IN_TABLE_HEADER); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyGroupDescDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyGroupDescDeserializerTest.java index a139ee2d40..464583f332 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyGroupDescDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyGroupDescDeserializerTest.java @@ -30,7 +30,7 @@ public class MultipartReplyGroupDescDeserializerTest extends AbstractMultipartDe private static final int WATCH_GROUP = 4; @Test - public void deserialize() throws Exception { + public void deserialize() { ByteBuf buffer = UnpooledByteBufAllocator.DEFAULT.buffer(); buffer.writeShort(ITEM_LENGTH); buffer.writeByte(GROUP_TYPE); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyGroupFeaturesDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyGroupFeaturesDeserializerTest.java index 1de6d0ca60..416c4c37db 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyGroupFeaturesDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyGroupFeaturesDeserializerTest.java @@ -41,7 +41,7 @@ public class MultipartReplyGroupFeaturesDeserializerTest extends AbstractMultipa GroupCapabilities.ChainingChecks); @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { int bitMaskGroups = ByteBufUtils.fillBitMask(0, GROUP_TYPES_SUPPORTED.contains(GroupTypes.GroupAll), diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyGroupStatsDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyGroupStatsDeserializerTest.java index bf7070873b..f6a00986e9 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyGroupStatsDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyGroupStatsDeserializerTest.java @@ -29,7 +29,7 @@ public class MultipartReplyGroupStatsDeserializerTest extends AbstractMultipartD private static final long BYTE_COUNT = 2L; @Test - public void testDeserialize() throws Exception { + public void testDeserialize() { ByteBuf buffer = UnpooledByteBufAllocator.DEFAULT.buffer(); buffer.writeShort(ITEM_LENGTH); buffer.writeZero(PADDING_IN_GROUP_HEADER_01); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyMessageDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyMessageDeserializerTest.java index b20632245a..d6ebcbcc02 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyMessageDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyMessageDeserializerTest.java @@ -64,7 +64,7 @@ public class MultipartReplyMessageDeserializerTest extends AbstractDeserializerT } @Test - public void deserialize() throws Exception { + public void deserialize() { ByteBuf buffer = UnpooledByteBufAllocator.DEFAULT.buffer(); buffer.writeByte(TYPE); buffer.writeShort(EncodeConstants.EMPTY_LENGTH); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyMeterConfigDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyMeterConfigDeserializerTest.java index ab7d255547..3de6d6443c 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyMeterConfigDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyMeterConfigDeserializerTest.java @@ -40,7 +40,7 @@ public class MultipartReplyMeterConfigDeserializerTest extends AbstractMultipart private static final byte PREC_LEVEL = 3; @Test - public void deserializeDrop() throws Exception { + public void deserializeDrop() { ByteBuf buffer = UnpooledByteBufAllocator.DEFAULT.buffer(); writeCommonAtributes(buffer); buffer.writeShort(OFPMBTDROP); @@ -60,7 +60,7 @@ public class MultipartReplyMeterConfigDeserializerTest extends AbstractMultipart } @Test - public void deserializeDscp() throws Exception { + public void deserializeDscp() { ByteBuf buffer = UnpooledByteBufAllocator.DEFAULT.buffer(); writeCommonAtributes(buffer); buffer.writeShort(OFPMBTDSCP); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyMeterFeaturesDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyMeterFeaturesDeserializerTest.java index c8525c17d7..db377096f8 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyMeterFeaturesDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyMeterFeaturesDeserializerTest.java @@ -35,7 +35,7 @@ public class MultipartReplyMeterFeaturesDeserializerTest extends AbstractMultipa private static final byte MAX_COLOR = 48; @Test - public void deserialize() throws Exception { + public void deserialize() { ByteBuf buffer = UnpooledByteBufAllocator.DEFAULT.buffer(); buffer.writeInt(MAX_METER); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyMeterStatsDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyMeterStatsDeserializerTest.java index 1dc3e467b0..725d4d7ff7 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyMeterStatsDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyMeterStatsDeserializerTest.java @@ -30,7 +30,7 @@ public class MultipartReplyMeterStatsDeserializerTest extends AbstractMultipartD private static final long BYTE_BAND_COUNT = 8L; @Test - public void deserialize() throws Exception { + public void deserialize() { ByteBuf buffer = UnpooledByteBufAllocator.DEFAULT.buffer(); buffer.writeInt(METER_ID); buffer.writeShort(ITEM_LENGTH); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyPortDescDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyPortDescDeserializerTest.java index 709c1e8d1f..b1ed1ececc 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyPortDescDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyPortDescDeserializerTest.java @@ -65,7 +65,7 @@ public class MultipartReplyPortDescDeserializerTest extends AbstractMultipartDes private static final int MAXIMUM_SPEED = 10; @Test - public void deserialize() throws Exception { + public void deserialize() { ByteBuf buffer = UnpooledByteBufAllocator.DEFAULT.buffer(); buffer.writeInt(PORT_NUMBER); buffer.writeZero(PADDING_IN_PORT_DESC_HEADER_01); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyPortStatsDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyPortStatsDeserializerTest.java index 9b5aec3660..e325e00b59 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyPortStatsDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyPortStatsDeserializerTest.java @@ -36,7 +36,7 @@ public class MultipartReplyPortStatsDeserializerTest extends AbstractMultipartDe private static final int NANOSECOND = 15; @Test - public void deserialize() throws Exception { + public void deserialize() { ByteBuf buffer = UnpooledByteBufAllocator.DEFAULT.buffer(); buffer.writeInt(PORT); buffer.writeZero(PADDING_IN_PORT_STATS_HEADER); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyQueueStatsDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyQueueStatsDeserializerTest.java index 98efa83cfb..feb8a0ef9a 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyQueueStatsDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyQueueStatsDeserializerTest.java @@ -27,7 +27,7 @@ public class MultipartReplyQueueStatsDeserializerTest extends AbstractMultipartD private static final int NANOSECOND = 15; @Test - public void deserialize() throws Exception { + public void deserialize() { ByteBuf buffer = UnpooledByteBufAllocator.DEFAULT.buffer(); buffer.writeInt(PORT); buffer.writeInt(QUEUE_ID); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyTableFeaturesDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyTableFeaturesDeserializerTest.java index 943b517b1a..88d8193c80 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyTableFeaturesDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyTableFeaturesDeserializerTest.java @@ -61,7 +61,7 @@ public class MultipartReplyTableFeaturesDeserializerTest extends AbstractMultipa private static final int OFPTFPT_APPLY_SETFIELD_MISS = 15; @Test - public void deserialize() throws Exception { + public void deserialize() { ByteBuf buffer = UnpooledByteBufAllocator.DEFAULT.buffer(); writeValues(buffer, OFPTFPT_INSTRUCTIONS); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/TableFeaturesMatchFieldDeserializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/TableFeaturesMatchFieldDeserializerTest.java index d77836c58b..77347964f4 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/TableFeaturesMatchFieldDeserializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/TableFeaturesMatchFieldDeserializerTest.java @@ -61,7 +61,7 @@ public class TableFeaturesMatchFieldDeserializerTest { private TableFeaturesMatchFieldDeserializer deserializer = new TableFeaturesMatchFieldDeserializer(); @Test - public void deserialize() throws Exception { + public void deserialize() { ByteBuf buffer = UnpooledByteBufAllocator.DEFAULT.buffer(); addValues(buffer, OxmMatchConstants.OPENFLOW_BASIC_CLASS, OxmMatchConstants.ARP_OP); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/AbstractSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/AbstractSerializerTest.java index 5a367880e5..909c811754 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/AbstractSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/AbstractSerializerTest.java @@ -32,7 +32,7 @@ public abstract class AbstractSerializerTest { private SerializerRegistry registry; @Before - public void setUp() throws Exception { + public void setUp() { registry = new SerializerRegistryImpl(); registry.init(); provider = new SerializerExtensionProviderImpl(registry); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/ActionSerializerInjectorTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/ActionSerializerInjectorTest.java index 4bf6c0c11d..56918adde4 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/ActionSerializerInjectorTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/ActionSerializerInjectorTest.java @@ -36,12 +36,12 @@ public class ActionSerializerInjectorTest { private Function, Consumer>> injector; @Before - public void setUp() throws Exception { + public void setUp() { injector = ActionSerializerInjector.createInjector(switchConnectionProvider, EncodeConstants.OF13_VERSION_ID); } @Test - public void injectSerializers() throws Exception { + public void injectSerializers() { injector.apply(CopyTtlInCase.class).accept(actionSerializer); verify(switchConnectionProvider).registerSerializer( new MessageTypeKey(EncodeConstants.OF13_VERSION_ID, CopyTtlInCase.class), diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/InstructionSerializerInjectorTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/InstructionSerializerInjectorTest.java index e1e24817cf..721e3f611f 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/InstructionSerializerInjectorTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/InstructionSerializerInjectorTest.java @@ -36,13 +36,13 @@ public class InstructionSerializerInjectorTest { private Function, Consumer>> injector; @Before - public void setUp() throws Exception { + public void setUp() { injector = InstructionSerializerInjector.createInjector(switchConnectionProvider, EncodeConstants.OF13_VERSION_ID); } @Test - public void injectSerializers() throws Exception { + public void injectSerializers() { injector.apply(ApplyActionsCase.class).accept(instructionSerializer); verify(switchConnectionProvider).registerSerializer( new MessageTypeKey<>(EncodeConstants.OF13_VERSION_ID, ApplyActionsCase.class), diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/MessageSerializerInjectorTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/MessageSerializerInjectorTest.java index 879b91764d..5768f025cc 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/MessageSerializerInjectorTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/MessageSerializerInjectorTest.java @@ -40,7 +40,7 @@ public class MessageSerializerInjectorTest { } @Test - public void injectSerializers() throws Exception { + public void injectSerializers() { injector.apply(OfHeader.class).accept(ofSerializer); verify(switchConnectionProvider) .registerSerializer(new MessageTypeKey<>(OFConstants.OFP_VERSION_1_3, OfHeader.class), ofSerializer); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/CopyTtlInActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/CopyTtlInActionSerializerTest.java index 667f387633..3c3b1515e3 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/CopyTtlInActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/CopyTtlInActionSerializerTest.java @@ -18,7 +18,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class CopyTtlInActionSerializerTest extends AbstractActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Action action = new CopyTtlInCaseBuilder() .setCopyTtlIn(new CopyTtlInBuilder() .build()) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/CopyTtlOutActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/CopyTtlOutActionSerializerTest.java index 14f90b2ed4..aecbb025f9 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/CopyTtlOutActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/CopyTtlOutActionSerializerTest.java @@ -18,7 +18,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class CopyTtlOutActionSerializerTest extends AbstractActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Action action = new CopyTtlOutCaseBuilder() .setCopyTtlOut(new CopyTtlOutBuilder() .build()) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/DecMplsTtlActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/DecMplsTtlActionSerializerTest.java index 415c7e5b67..396bb33f70 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/DecMplsTtlActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/DecMplsTtlActionSerializerTest.java @@ -18,7 +18,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class DecMplsTtlActionSerializerTest extends AbstractActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Action action = new DecMplsTtlCaseBuilder() .setDecMplsTtl(new DecMplsTtlBuilder() .build()) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/DecNwTtlActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/DecNwTtlActionSerializerTest.java index 6d3fa185f8..b5e54fc0f0 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/DecNwTtlActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/DecNwTtlActionSerializerTest.java @@ -18,7 +18,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class DecNwTtlActionSerializerTest extends AbstractActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Action action = new DecNwTtlCaseBuilder() .setDecNwTtl(new DecNwTtlBuilder() .build()) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/GroupActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/GroupActionSerializerTest.java index 47fcf4b33c..08a721d9a5 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/GroupActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/GroupActionSerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class GroupActionSerializerTest extends AbstractActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final long group = 10L; final Action action = new GroupActionCaseBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/OutputActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/OutputActionSerializerTest.java index 1e114c2dbd..bbe5360eb6 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/OutputActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/OutputActionSerializerTest.java @@ -24,7 +24,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.common.types.rev13 public class OutputActionSerializerTest extends AbstractActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int length = 10; final String port = OutputPortValues.LOCAL.toString(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PopMplsActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PopMplsActionSerializerTest.java index 253054d5e9..b3b2d56cad 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PopMplsActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PopMplsActionSerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class PopMplsActionSerializerTest extends AbstractActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int ethType = 10; final Action action = new PopMplsActionCaseBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PopPbbActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PopPbbActionSerializerTest.java index 4461580f74..459a43555c 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PopPbbActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PopPbbActionSerializerTest.java @@ -18,7 +18,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class PopPbbActionSerializerTest extends AbstractActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Action action = new PopPbbActionCaseBuilder() .setPopPbbAction(new PopPbbActionBuilder() .build()) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PopVlanActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PopVlanActionSerializerTest.java index 302e1bad38..947cf9ac57 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PopVlanActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PopVlanActionSerializerTest.java @@ -18,7 +18,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class PopVlanActionSerializerTest extends AbstractActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Action action = new PopVlanActionCaseBuilder() .setPopVlanAction(new PopVlanActionBuilder() .build()) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PushMplsActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PushMplsActionSerializerTest.java index 24dfa5f860..07bf12e9b9 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PushMplsActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PushMplsActionSerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class PushMplsActionSerializerTest extends AbstractActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int ethType = 10; final Action action = new PushMplsActionCaseBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PushPbbActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PushPbbActionSerializerTest.java index 9ac7fa80e9..d97492168e 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PushPbbActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PushPbbActionSerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class PushPbbActionSerializerTest extends AbstractActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int ethType = 10; final Action action = new PushPbbActionCaseBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PushVlanActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PushVlanActionSerializerTest.java index 731ce1d8b8..5dd7d71517 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PushVlanActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/PushVlanActionSerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class PushVlanActionSerializerTest extends AbstractActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int ethType = 10; final Action action = new PushVlanActionCaseBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetDlDstActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetDlDstActionSerializerTest.java index 7f09a69489..b6c70c1938 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetDlDstActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetDlDstActionSerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class SetDlDstActionSerializerTest extends AbstractSetFieldActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final MacAddress address = new MacAddress("00:01:02:03:04:05"); final Action action = new SetDlDstActionCaseBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetDlSrcActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetDlSrcActionSerializerTest.java index 03249df81a..34d5845a6a 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetDlSrcActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetDlSrcActionSerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class SetDlSrcActionSerializerTest extends AbstractSetFieldActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final MacAddress address = new MacAddress("00:01:02:03:04:05"); final Action action = new SetDlSrcActionCaseBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetMplsTtlActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetMplsTtlActionSerializerTest.java index 36bec2f1b8..ba7ee370ea 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetMplsTtlActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetMplsTtlActionSerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class SetMplsTtlActionSerializerTest extends AbstractActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final short mpls = (short) 10; final Action action = new SetMplsTtlActionCaseBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetNwDstActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetNwDstActionSerializerTest.java index 25b25dc1a4..86041264b5 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetNwDstActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetNwDstActionSerializerTest.java @@ -22,7 +22,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.addr public class SetNwDstActionSerializerTest extends AbstractSetFieldActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Ipv4 address = new Ipv4Builder() .setIpv4Address(new Ipv4Prefix("192.168.76.2/32")) .build(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetNwSrcActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetNwSrcActionSerializerTest.java index 974d831ff2..c490c4e16d 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetNwSrcActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetNwSrcActionSerializerTest.java @@ -22,7 +22,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.addr public class SetNwSrcActionSerializerTest extends AbstractSetFieldActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Ipv4 address = new Ipv4Builder() .setIpv4Address(new Ipv4Prefix("192.168.76.2/32")) .build(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetNwTosActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetNwTosActionSerializerTest.java index 6953018c0c..c52744bea2 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetNwTosActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetNwTosActionSerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class SetNwTosActionSerializerTest extends AbstractSetFieldActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int tos = 10; final Action action = new SetNwTosActionCaseBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetNwTtlActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetNwTtlActionSerializerTest.java index 7eadf5c6b5..a79a34adf1 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetNwTtlActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetNwTtlActionSerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class SetNwTtlActionSerializerTest extends AbstractActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final short ttl = 10; final Action action = new SetNwTtlActionCaseBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetQueueActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetQueueActionSerializerTest.java index a3414d1a6b..989a2c1b23 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetQueueActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetQueueActionSerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class SetQueueActionSerializerTest extends AbstractActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final long queue = 10; final Action action = new SetQueueActionCaseBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetTpDstActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetTpDstActionSerializerTest.java index 65e1a842f5..1f4e60a534 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetTpDstActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetTpDstActionSerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class SetTpDstActionSerializerTest extends AbstractSetFieldActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final PortNumber port = new PortNumber(20); final short protocol = 6; // TCP diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetTpSrcActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetTpSrcActionSerializerTest.java index 95e2827898..0c09fe5a85 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetTpSrcActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetTpSrcActionSerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class SetTpSrcActionSerializerTest extends AbstractSetFieldActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final PortNumber port = new PortNumber(20); final short protocol = 6; // TCP diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetVlanIdActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetVlanIdActionSerializerTest.java index cf8fab3828..c90c554f60 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetVlanIdActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetVlanIdActionSerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.l2.types.rev130827.VlanId; public class SetVlanIdActionSerializerTest extends AbstractSetFieldActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int vlan = 1; final Action action = new SetVlanIdActionCaseBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetVlanPcpActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetVlanPcpActionSerializerTest.java index c03de2bcea..e45692fde9 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetVlanPcpActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetVlanPcpActionSerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.l2.types.rev130827.VlanPcp; public class SetVlanPcpActionSerializerTest extends AbstractSetFieldActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final short vlan = 1; final Action action = new SetVlanPcpActionCaseBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/StripVlanActionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/StripVlanActionSerializerTest.java index 14b8e04bd3..38d8722016 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/StripVlanActionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/StripVlanActionSerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti public class StripVlanActionSerializerTest extends AbstractSetFieldActionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Action action = new StripVlanActionCaseBuilder() .setStripVlanAction(new StripVlanActionBuilder() .build()) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/ApplyActionsInstructionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/ApplyActionsInstructionSerializerTest.java index 10c404c5f6..6d3beb080e 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/ApplyActionsInstructionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/ApplyActionsInstructionSerializerTest.java @@ -31,7 +31,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.instru public class ApplyActionsInstructionSerializerTest extends AbstractInstructionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int order = 0; final Ipv4Prefix prefix = new Ipv4Prefix("192.168.76.0/32"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/ClearActionsInstructionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/ClearActionsInstructionSerializerTest.java index 876907d2c7..2b6c81a5e2 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/ClearActionsInstructionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/ClearActionsInstructionSerializerTest.java @@ -18,7 +18,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.instru public class ClearActionsInstructionSerializerTest extends AbstractInstructionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Instruction instruction = new ClearActionsCaseBuilder() .setClearActions(new ClearActionsBuilder() .build()) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/GoToTableInstructionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/GoToTableInstructionSerializerTest.java index fc130ce5f1..a139636b1e 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/GoToTableInstructionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/GoToTableInstructionSerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.instru public class GoToTableInstructionSerializerTest extends AbstractInstructionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final short table = 2; final Instruction instruction = new GoToTableCaseBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/MeterInstructionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/MeterInstructionSerializerTest.java index 090b58c794..4ef6b3d5f9 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/MeterInstructionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/MeterInstructionSerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.meter.types.rev130918.Meter public class MeterInstructionSerializerTest extends AbstractInstructionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final long meter = 2; final Instruction instruction = new MeterCaseBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/WriteActionsInstructionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/WriteActionsInstructionSerializerTest.java index 3cb9e2a319..f2707430a6 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/WriteActionsInstructionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/WriteActionsInstructionSerializerTest.java @@ -31,7 +31,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.instru public class WriteActionsInstructionSerializerTest extends AbstractInstructionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int order = 0; final Ipv4Prefix prefix = new Ipv4Prefix("192.168.76.0/32"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/WriteMetadataInstructionSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/WriteMetadataInstructionSerializerTest.java index 10b0d8195c..a7fec8abf3 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/WriteMetadataInstructionSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/instructions/WriteMetadataInstructionSerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.instru public class WriteMetadataInstructionSerializerTest extends AbstractInstructionSerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final long metadata = 10L; final long metadataMask = 10L; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/AbstractExperimenterMatchEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/AbstractExperimenterMatchEntrySerializerTest.java index 71bcddef1c..e076f87f1e 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/AbstractExperimenterMatchEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/AbstractExperimenterMatchEntrySerializerTest.java @@ -20,7 +20,7 @@ public abstract class AbstractExperimenterMatchEntrySerializerTest extends Abstr protected void assertMatch(final Match match, final boolean hasMask, - final Consumer assertBody) throws Exception { + final Consumer assertBody) { final ByteBuf buffer = UnpooledByteBufAllocator.DEFAULT.buffer(); getSerializer().serialize(match, buffer); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/AbstractMatchEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/AbstractMatchEntrySerializerTest.java index 69ba89747e..16197beb09 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/AbstractMatchEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/AbstractMatchEntrySerializerTest.java @@ -28,7 +28,7 @@ public abstract class AbstractMatchEntrySerializerTest extends AbstractSerialize protected void assertMatch(final Match match, final boolean hasMask, - final Consumer assertBody) throws Exception { + final Consumer assertBody) { final ByteBuf buffer = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(match, buffer); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/ArpOpEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/ArpOpEntrySerializerTest.java index 37d04f63c5..cfd2f7a9b4 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/ArpOpEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/ArpOpEntrySerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class ArpOpEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int arpOp = 42; final Match arpOpMatch = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/ArpSourceHardwareAddressEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/ArpSourceHardwareAddressEntrySerializerTest.java index 89f6cce17f..58510aa7f6 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/ArpSourceHardwareAddressEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/ArpSourceHardwareAddressEntrySerializerTest.java @@ -23,7 +23,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class ArpSourceHardwareAddressEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final MacAddress address = new MacAddress("00:01:02:03:04:05"); final MacAddress mask = new MacAddress("00:00:00:00:00:00"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/ArpSourceTransportAddressEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/ArpSourceTransportAddressEntrySerializerTest.java index f1a6228663..a3cc7e0ca2 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/ArpSourceTransportAddressEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/ArpSourceTransportAddressEntrySerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class ArpSourceTransportAddressEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Match arpSpaMatch = new MatchBuilder() .setLayer3Match(new ArpMatchBuilder() .setArpSourceTransportAddress(new Ipv4Prefix("10.0.2.0/24")) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/ArpTargetHardwareAddressEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/ArpTargetHardwareAddressEntrySerializerTest.java index 81788f2a3e..f36f5d32bc 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/ArpTargetHardwareAddressEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/ArpTargetHardwareAddressEntrySerializerTest.java @@ -23,7 +23,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class ArpTargetHardwareAddressEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final MacAddress address = new MacAddress("00:01:02:03:04:05"); final MacAddress mask = new MacAddress("00:00:00:00:00:00"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/ArpTargetTransportAddressEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/ArpTargetTransportAddressEntrySerializerTest.java index e8e5b6c633..8ab6ab5b34 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/ArpTargetTransportAddressEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/ArpTargetTransportAddressEntrySerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class ArpTargetTransportAddressEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Match arpSpaMatch = new MatchBuilder() .setLayer3Match(new ArpMatchBuilder() .setArpTargetTransportAddress(new Ipv4Prefix("10.0.2.0/24")) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/EthernetDestinationEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/EthernetDestinationEntrySerializerTest.java index e9bf5d2b01..4abfd2a730 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/EthernetDestinationEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/EthernetDestinationEntrySerializerTest.java @@ -22,7 +22,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class EthernetDestinationEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final MacAddress address = new MacAddress("00:01:02:03:04:05"); final MacAddress mask = new MacAddress("00:00:00:00:00:00"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/EthernetSourceEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/EthernetSourceEntrySerializerTest.java index 7b099129cc..d2c8aa1ed0 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/EthernetSourceEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/EthernetSourceEntrySerializerTest.java @@ -23,7 +23,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class EthernetSourceEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final MacAddress address = new MacAddress("00:01:02:03:04:05"); final MacAddress mask = new MacAddress("00:00:00:00:00:00"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/EthernetTypeEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/EthernetTypeEntrySerializerTest.java index 3dd5439c3f..e6ee2d72ce 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/EthernetTypeEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/EthernetTypeEntrySerializerTest.java @@ -22,7 +22,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class EthernetTypeEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final long ethType = 0xffffL; final Match match = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Icmpv4CodeEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Icmpv4CodeEntrySerializerTest.java index f08c079198..8edef31229 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Icmpv4CodeEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Icmpv4CodeEntrySerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Icmpv4CodeEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final short code = 200; final Match match = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Icmpv4TypeEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Icmpv4TypeEntrySerializerTest.java index 347d5dcb0c..834aab0cb9 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Icmpv4TypeEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Icmpv4TypeEntrySerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Icmpv4TypeEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final short type = 128; final Match match = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Icmpv6CodeEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Icmpv6CodeEntrySerializerTest.java index 9ea9c8b13e..652637c0d4 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Icmpv6CodeEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Icmpv6CodeEntrySerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Icmpv6CodeEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final short code = 101; final Match match = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Icmpv6TypeEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Icmpv6TypeEntrySerializerTest.java index c7cd96dede..a6571a2082 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Icmpv6TypeEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Icmpv6TypeEntrySerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Icmpv6TypeEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final short type = 123; final Match match = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/InPhyPortEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/InPhyPortEntrySerializerTest.java index ea49f4c529..74bdfe7ff9 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/InPhyPortEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/InPhyPortEntrySerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeCon public class InPhyPortEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int port = 10122; final Match match = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/InPortEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/InPortEntrySerializerTest.java index 550a84f4d8..d28004ad61 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/InPortEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/InPortEntrySerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeCon public class InPortEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int port = 42; final Match match = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/IpDscpEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/IpDscpEntrySerializerTest.java index da824c1c54..00f81698c3 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/IpDscpEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/IpDscpEntrySerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class IpDscpEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final short dscp = (short) 58; final Match match = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/IpEcnEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/IpEcnEntrySerializerTest.java index f11bc66caf..007aa1639c 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/IpEcnEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/IpEcnEntrySerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class IpEcnEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final short ecn = (short) 58; final Match match = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/IpProtoEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/IpProtoEntrySerializerTest.java index 5f3ff29e2e..b552cfc205 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/IpProtoEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/IpProtoEntrySerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class IpProtoEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final short proto = (short) 6; // TCP final Match match = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv4ArbitraryBitMaskDestinationEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv4ArbitraryBitMaskDestinationEntrySerializerTest.java index ff9c15e781..3270e1f14d 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv4ArbitraryBitMaskDestinationEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv4ArbitraryBitMaskDestinationEntrySerializerTest.java @@ -22,7 +22,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Ipv4ArbitraryBitMaskDestinationEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Ipv4Address ipv4Address = new Ipv4Address("192.168.10.0"); final DottedQuad ipv4mask = new DottedQuad("255.255.255.0"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv4ArbitraryBitMaskSourceEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv4ArbitraryBitMaskSourceEntrySerializerTest.java index 7168aa4bb8..89166907c7 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv4ArbitraryBitMaskSourceEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv4ArbitraryBitMaskSourceEntrySerializerTest.java @@ -22,7 +22,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Ipv4ArbitraryBitMaskSourceEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Ipv4Address ipv4Address = new Ipv4Address("192.168.10.0"); final DottedQuad ipv4mask = new DottedQuad("255.255.255.0"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv4DestinationEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv4DestinationEntrySerializerTest.java index cf30fcecd0..d5ba597efe 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv4DestinationEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv4DestinationEntrySerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Ipv4DestinationEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Match ipv4match = new MatchBuilder() .setLayer3Match(new Ipv4MatchBuilder() .setIpv4Destination(new Ipv4Prefix("10.0.2.0/24")) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv4SourceEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv4SourceEntrySerializerTest.java index d7c677af40..44ebc2c7f4 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv4SourceEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv4SourceEntrySerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Ipv4SourceEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Match ipv4match = new MatchBuilder() .setLayer3Match(new Ipv4MatchBuilder() .setIpv4Source(new Ipv4Prefix("10.0.2.0/24")) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6ArbitraryBitMaskDestinationEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6ArbitraryBitMaskDestinationEntrySerializerTest.java index b9971d82f9..d08a529508 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6ArbitraryBitMaskDestinationEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6ArbitraryBitMaskDestinationEntrySerializerTest.java @@ -24,7 +24,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.opendaylight.ipv6.arbitrary public class Ipv6ArbitraryBitMaskDestinationEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Ipv6Address ipv6Address = new Ipv6Address("aaaa:bbbb:1111:2222::"); final Ipv6ArbitraryMask ipv6mask = new Ipv6ArbitraryMask("ffff:ffff:ffff:ffff::"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6ArbitraryBitMaskSourceEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6ArbitraryBitMaskSourceEntrySerializerTest.java index 748f668b7a..178187c3d8 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6ArbitraryBitMaskSourceEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6ArbitraryBitMaskSourceEntrySerializerTest.java @@ -24,7 +24,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.opendaylight.ipv6.arbitrary public class Ipv6ArbitraryBitMaskSourceEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Ipv6Address ipv6Address = new Ipv6Address("aaaa:bbbb:1111:2222::"); final Ipv6ArbitraryMask ipv6mask = new Ipv6ArbitraryMask("ffff:ffff:ffff:ffff::"); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6DestinationEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6DestinationEntrySerializerTest.java index 719fc16e30..065cbc148a 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6DestinationEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6DestinationEntrySerializerTest.java @@ -23,7 +23,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Ipv6DestinationEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Ipv6Prefix ipv6Address = new Ipv6Prefix("2001:db8::/32"); final Match ipv6abmMatch = new MatchBuilder() @@ -46,7 +46,7 @@ public class Ipv6DestinationEntrySerializerTest extends AbstractMatchEntrySerial } @Test - public void testSerializeWithoutMask() throws Exception { + public void testSerializeWithoutMask() { final Ipv6Prefix ipv6Address = new Ipv6Prefix("2001:db8::123/128"); final Match ipv6abmMatch = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6ExtHeaderEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6ExtHeaderEntrySerializerTest.java index e1bd43f64c..d450af5f87 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6ExtHeaderEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6ExtHeaderEntrySerializerTest.java @@ -23,7 +23,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Ipv6ExtHeaderEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int ipv6extHdr = 358; final int ipv6extHdrMask = 100; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6LabelEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6LabelEntrySerializerTest.java index 8e5d7c63a2..373a545856 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6LabelEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6LabelEntrySerializerTest.java @@ -24,7 +24,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Ipv6LabelEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final long ipv6flowLabel = 358; final long ipv6flowLabelMask = 100; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6NdSllEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6NdSllEntrySerializerTest.java index 2fbc524c7b..c5969a1d27 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6NdSllEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6NdSllEntrySerializerTest.java @@ -22,7 +22,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Ipv6NdSllEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final MacAddress ipv6NdSll = new MacAddress("00:01:02:03:04:05"); final Match ipv6NdSllMatch = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6NdTargetEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6NdTargetEntrySerializerTest.java index 0cf6c5f6b6..b8789305ba 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6NdTargetEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6NdTargetEntrySerializerTest.java @@ -22,7 +22,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Ipv6NdTargetEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Ipv6Address ipv6NdTarget = new Ipv6Address("2001:db8::"); final Match ipv6NdTargetMatch = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6NdTllEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6NdTllEntrySerializerTest.java index f9fbc4937b..dc43c485af 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6NdTllEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6NdTllEntrySerializerTest.java @@ -22,7 +22,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Ipv6NdTllEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final MacAddress ipv6NdTll = new MacAddress("00:01:02:03:04:05"); final Match ipv6NdTllMatch = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6SourceEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6SourceEntrySerializerTest.java index bac5c263e1..847950031c 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6SourceEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/Ipv6SourceEntrySerializerTest.java @@ -23,7 +23,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class Ipv6SourceEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Ipv6Prefix ipv6Address = new Ipv6Prefix("2001:db8::/32"); final Match ipv6abmMatch = new MatchBuilder() @@ -46,7 +46,7 @@ public class Ipv6SourceEntrySerializerTest extends AbstractMatchEntrySerializerT } @Test - public void testSerializeWithoutMask() throws Exception { + public void testSerializeWithoutMask() { final Ipv6Prefix ipv6Address = new Ipv6Prefix("2001:db8::123/128"); final Match ipv6abmMatch = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/MetadataEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/MetadataEntrySerializerTest.java index f0b3b7ef8d..daa750717e 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/MetadataEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/MetadataEntrySerializerTest.java @@ -22,7 +22,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class MetadataEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final byte[] metadata = new byte[] { 0, 1, 2, 3, 4, 5, 6, 7 }; final byte[] metadataMask = new byte[] { 30, 30, 30, 30, 30, 0, 0, 0 }; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/MplsBosEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/MplsBosEntrySerializerTest.java index 276776b6e0..4d84fc5956 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/MplsBosEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/MplsBosEntrySerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class MplsBosEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final short mplsBos = (short) 1; final Match mplsBosMatch = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/MplsLabelEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/MplsLabelEntrySerializerTest.java index 78bf1b51d5..ba205e73f2 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/MplsLabelEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/MplsLabelEntrySerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class MplsLabelEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final long mplsLabel = 10L; final Match mplsLabelMatch = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/MplsTcEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/MplsTcEntrySerializerTest.java index ebe8873ae8..cd941efd27 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/MplsTcEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/MplsTcEntrySerializerTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class MplsTcEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final short mplsTc = (short) 1; final Match mplsTcMatch = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/PacketTypeEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/PacketTypeEntrySerializerTest.java index fbabcc9f00..acaa8da87e 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/PacketTypeEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/PacketTypeEntrySerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class PacketTypeEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void serializeTest() throws Exception { + public void serializeTest() { final long packetType = 0x1894f; PacketTypeMatch packetTypeMatch = new PacketTypeMatchBuilder().setPacketType(packetType).build(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/PbbEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/PbbEntrySerializerTest.java index 424b1036bf..733b81b7e3 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/PbbEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/PbbEntrySerializerTest.java @@ -23,7 +23,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class PbbEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final long pbbId = 6789; final byte[] pbbIdMask = new byte[] { 0, 15, 10 }; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/SctpDestinationPortEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/SctpDestinationPortEntrySerializerTest.java index 5da3fb03f5..b9b936c5a1 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/SctpDestinationPortEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/SctpDestinationPortEntrySerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class SctpDestinationPortEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int sctp = 10; final Match sctpMatch = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/SctpSourcePortEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/SctpSourcePortEntrySerializerTest.java index 4b14930869..2b6ec038bc 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/SctpSourcePortEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/SctpSourcePortEntrySerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class SctpSourcePortEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int sctp = 10; final Match sctpMatch = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TcpDestinationPortEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TcpDestinationPortEntrySerializerTest.java index 2e9e03df7f..f8ef1777db 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TcpDestinationPortEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TcpDestinationPortEntrySerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class TcpDestinationPortEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int tcp = 10; final Match sctpMatch = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TcpFlagsEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TcpFlagsEntrySerializerTest.java index 54792eb4e9..933e29f393 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TcpFlagsEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TcpFlagsEntrySerializerTest.java @@ -22,7 +22,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class TcpFlagsEntrySerializerTest extends AbstractExperimenterMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int tcp = 8; final byte[] tcpMask = new byte[] { 30, 30 }; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TcpSourcePortEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TcpSourcePortEntrySerializerTest.java index 7fb7606ff9..df33771389 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TcpSourcePortEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TcpSourcePortEntrySerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class TcpSourcePortEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int tcp = 10; final Match sctpMatch = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TunnelIdEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TunnelIdEntrySerializerTest.java index 141af7be49..044c252635 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TunnelIdEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TunnelIdEntrySerializerTest.java @@ -23,7 +23,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class TunnelIdEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final long tunnelId = 8; final byte[] tcpMask = new byte[] { 30, 30, 30, 30, 0, 0, 0, 0 }; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TunnelIpv4DestinationEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TunnelIpv4DestinationEntrySerializerTest.java index 391d7a9cf4..4baad60e59 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TunnelIpv4DestinationEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TunnelIpv4DestinationEntrySerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class TunnelIpv4DestinationEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Match ipv4match = new MatchBuilder() .setLayer3Match(new TunnelIpv4MatchBuilder() .setTunnelIpv4Destination(new Ipv4Prefix("10.0.2.0/24")) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TunnelIpv4SourceEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TunnelIpv4SourceEntrySerializerTest.java index 797b03c95d..591362a64c 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TunnelIpv4SourceEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/TunnelIpv4SourceEntrySerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class TunnelIpv4SourceEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Match ipv4match = new MatchBuilder() .setLayer3Match(new TunnelIpv4MatchBuilder() .setTunnelIpv4Source(new Ipv4Prefix("10.0.2.0/24")) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/UdpDestinationPortEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/UdpDestinationPortEntrySerializerTest.java index 3c000dafd5..dcc9b16c29 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/UdpDestinationPortEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/UdpDestinationPortEntrySerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class UdpDestinationPortEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int tcp = 10; final Match sctpMatch = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/UdpSourcePortEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/UdpSourcePortEntrySerializerTest.java index 1dda32cdf0..5bf0b39b59 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/UdpSourcePortEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/UdpSourcePortEntrySerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class UdpSourcePortEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int tcp = 10; final Match sctpMatch = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/VlanPcpEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/VlanPcpEntrySerializerTest.java index 82cb588c1a..109ebf8752 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/VlanPcpEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/VlanPcpEntrySerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class VlanPcpEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final short vlan = (short) 1; final Match vlanMatch = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/VlanVidEntrySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/VlanVidEntrySerializerTest.java index 26180c5f5f..03dd376570 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/VlanVidEntrySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/VlanVidEntrySerializerTest.java @@ -23,7 +23,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 public class VlanVidEntrySerializerTest extends AbstractMatchEntrySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final int vlan = (short) 1; final Match vlanMatch = new MatchBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/AsyncConfigMessageSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/AsyncConfigMessageSerializerTest.java index 010a828a58..494e1ac72b 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/AsyncConfigMessageSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/AsyncConfigMessageSerializerTest.java @@ -85,7 +85,7 @@ public class AsyncConfigMessageSerializerTest extends AbstractSerializerTest { } @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(MESSAGE, out); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/FlowMessageSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/FlowMessageSerializerTest.java index 8dfbc076d0..4d68b23683 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/FlowMessageSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/FlowMessageSerializerTest.java @@ -184,7 +184,7 @@ public class FlowMessageSerializerTest extends AbstractSerializerTest { } @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(MESSAGE, out); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/GroupMessageSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/GroupMessageSerializerTest.java index 5250807445..dc4cfdb078 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/GroupMessageSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/GroupMessageSerializerTest.java @@ -106,7 +106,7 @@ public class GroupMessageSerializerTest extends AbstractSerializerTest { } @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(MESSAGE, out); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/MeterMessageSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/MeterMessageSerializerTest.java index 16f417bad8..ec98addc64 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/MeterMessageSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/MeterMessageSerializerTest.java @@ -111,7 +111,7 @@ public class MeterMessageSerializerTest extends AbstractSerializerTest { } @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(MESSAGE, out); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/PortMessageSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/PortMessageSerializerTest.java index 9cb7c2a80a..2af05a9912 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/PortMessageSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/PortMessageSerializerTest.java @@ -99,7 +99,7 @@ public class PortMessageSerializerTest extends AbstractSerializerTest { } @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(MESSAGE, out); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestDescSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestDescSerializerTest.java index ccd447f4b9..622676b9dc 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestDescSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestDescSerializerTest.java @@ -32,7 +32,7 @@ public class MultipartRequestDescSerializerTest extends AbstractSerializerTest { } @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(BODY, out); assertEquals(out.readableBytes(), 0); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestFlowAggregateStatsSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestFlowAggregateStatsSerializerTest.java index 14efdedcdb..052b4d6820 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestFlowAggregateStatsSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestFlowAggregateStatsSerializerTest.java @@ -59,7 +59,7 @@ public class MultipartRequestFlowAggregateStatsSerializerTest extends AbstractSe } @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(BODY, out); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestFlowStatsSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestFlowStatsSerializerTest.java index 2cef6dbc9c..26b219f739 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestFlowStatsSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestFlowStatsSerializerTest.java @@ -59,7 +59,7 @@ public class MultipartRequestFlowStatsSerializerTest extends AbstractSerializerT } @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(BODY, out); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestFlowTableStatsSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestFlowTableStatsSerializerTest.java index 03ced587e9..1832051267 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestFlowTableStatsSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestFlowTableStatsSerializerTest.java @@ -32,7 +32,7 @@ public class MultipartRequestFlowTableStatsSerializerTest extends AbstractSerial } @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(BODY, out); assertEquals(out.readableBytes(), 0); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestGroupDescSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestGroupDescSerializerTest.java index 2c817cbc02..28e8572bc4 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestGroupDescSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestGroupDescSerializerTest.java @@ -32,7 +32,7 @@ public class MultipartRequestGroupDescSerializerTest extends AbstractSerializerT } @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(BODY, out); assertEquals(out.readableBytes(), 0); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestGroupFeaturesSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestGroupFeaturesSerializerTest.java index 7098b4aa29..a698049946 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestGroupFeaturesSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestGroupFeaturesSerializerTest.java @@ -32,7 +32,7 @@ public class MultipartRequestGroupFeaturesSerializerTest extends AbstractSeriali } @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(BODY, out); assertEquals(out.readableBytes(), 0); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestGroupStatsSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestGroupStatsSerializerTest.java index 24b05db280..8095de642f 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestGroupStatsSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestGroupStatsSerializerTest.java @@ -36,7 +36,7 @@ public class MultipartRequestGroupStatsSerializerTest extends AbstractSerializer } @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(BODY, out); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestMessageSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestMessageSerializerTest.java index 0338df7880..9b996e781d 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestMessageSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestMessageSerializerTest.java @@ -57,7 +57,7 @@ public class MultipartRequestMessageSerializerTest extends AbstractSerializerTes } @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(MESSAGE, out); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestMeterConfigSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestMeterConfigSerializerTest.java index 0df02aee8c..4286199b06 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestMeterConfigSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestMeterConfigSerializerTest.java @@ -36,7 +36,7 @@ public class MultipartRequestMeterConfigSerializerTest extends AbstractSerialize } @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(BODY, out); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestMeterFeaturesSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestMeterFeaturesSerializerTest.java index b1054451cf..70e36b9eb3 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestMeterFeaturesSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestMeterFeaturesSerializerTest.java @@ -32,7 +32,7 @@ public class MultipartRequestMeterFeaturesSerializerTest extends AbstractSeriali } @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(BODY, out); assertEquals(out.readableBytes(), 0); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestMeterStatsSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestMeterStatsSerializerTest.java index a82e516e5b..788b8fd659 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestMeterStatsSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestMeterStatsSerializerTest.java @@ -36,7 +36,7 @@ public class MultipartRequestMeterStatsSerializerTest extends AbstractSerializer } @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(BODY, out); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestPortDescSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestPortDescSerializerTest.java index 2fc8dea14e..666f6b5e29 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestPortDescSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestPortDescSerializerTest.java @@ -32,7 +32,7 @@ public class MultipartRequestPortDescSerializerTest extends AbstractSerializerTe } @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(BODY, out); assertEquals(out.readableBytes(), 0); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestPortStatsSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestPortStatsSerializerTest.java index ff84abdf86..aae23c5a4b 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestPortStatsSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestPortStatsSerializerTest.java @@ -36,7 +36,7 @@ public class MultipartRequestPortStatsSerializerTest extends AbstractSerializerT } @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(BODY, out); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestQueueStatsSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestQueueStatsSerializerTest.java index 7916cf5a08..160dff6994 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestQueueStatsSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestQueueStatsSerializerTest.java @@ -38,7 +38,7 @@ public class MultipartRequestQueueStatsSerializerTest extends AbstractSerializer } @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(BODY, out); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestTableFeaturesSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestTableFeaturesSerializerTest.java index 4fddccaeeb..4307d6db73 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestTableFeaturesSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestTableFeaturesSerializerTest.java @@ -75,7 +75,7 @@ public class MultipartRequestTableFeaturesSerializerTest extends AbstractSeriali } @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ByteBuf out = UnpooledByteBufAllocator.DEFAULT.buffer(); serializer.serialize(BODY, out); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/ApplyActionsMissTablePropertySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/ApplyActionsMissTablePropertySerializerTest.java index bc1a922424..d97df08194 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/ApplyActionsMissTablePropertySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/ApplyActionsMissTablePropertySerializerTest.java @@ -24,7 +24,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table public class ApplyActionsMissTablePropertySerializerTest extends AbstractTablePropertySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ApplyActionsMiss property = new ApplyActionsMissBuilder() .setApplyActionsMiss(new org.opendaylight.yang.gen.v1.urn.opendaylight .table.types.rev131026.table.feature.prop.type.table.feature.prop.type.apply.actions.miss diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/ApplyActionsTablePropertySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/ApplyActionsTablePropertySerializerTest.java index afe5dcf15e..d1ad4fbca2 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/ApplyActionsTablePropertySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/ApplyActionsTablePropertySerializerTest.java @@ -24,7 +24,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table public class ApplyActionsTablePropertySerializerTest extends AbstractTablePropertySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ApplyActions property = new ApplyActionsBuilder() .setApplyActions(new org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table.feature .prop.type.table.feature.prop.type.apply.actions diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/ApplySetfieldMissTablePropertySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/ApplySetfieldMissTablePropertySerializerTest.java index 59562a6c8b..09c4dabca1 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/ApplySetfieldMissTablePropertySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/ApplySetfieldMissTablePropertySerializerTest.java @@ -25,7 +25,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table public class ApplySetfieldMissTablePropertySerializerTest extends AbstractTablePropertySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ApplySetfieldMiss property = new ApplySetfieldMissBuilder() .setApplySetfieldMiss(new org.opendaylight.yang.gen.v1.urn.opendaylight .table.types.rev131026.table.feature.prop.type.table.feature.prop.type.apply.setfield.miss diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/ApplySetfieldTablePropertySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/ApplySetfieldTablePropertySerializerTest.java index dec98fb255..e19f7dbf8e 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/ApplySetfieldTablePropertySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/ApplySetfieldTablePropertySerializerTest.java @@ -25,7 +25,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table public class ApplySetfieldTablePropertySerializerTest extends AbstractTablePropertySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final ApplySetfield property = new ApplySetfieldBuilder() .setApplySetfield(new org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table.feature .prop.type.table.feature.prop.type.apply.setfield diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/InstructionsMissTablePropertySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/InstructionsMissTablePropertySerializerTest.java index 85a30671a8..388bc993b4 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/InstructionsMissTablePropertySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/InstructionsMissTablePropertySerializerTest.java @@ -24,7 +24,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table public class InstructionsMissTablePropertySerializerTest extends AbstractTablePropertySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final InstructionsMiss property = new InstructionsMissBuilder() .setInstructionsMiss(new org.opendaylight.yang.gen.v1.urn.opendaylight .table.types.rev131026.table.feature.prop.type.table.feature.prop.type.instructions.miss diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/InstructionsTablePropertySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/InstructionsTablePropertySerializerTest.java index e409b2a216..a21859275c 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/InstructionsTablePropertySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/InstructionsTablePropertySerializerTest.java @@ -24,7 +24,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table public class InstructionsTablePropertySerializerTest extends AbstractTablePropertySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Instructions property = new InstructionsBuilder() .setInstructions(new org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table.feature .prop.type.table.feature.prop.type.instructions diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/MatchTablePropertySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/MatchTablePropertySerializerTest.java index d489353dcb..1e1a4eda47 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/MatchTablePropertySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/MatchTablePropertySerializerTest.java @@ -26,7 +26,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table public class MatchTablePropertySerializerTest extends AbstractTablePropertySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Match property = new MatchBuilder() .setMatchSetfield(new MatchSetfieldBuilder() .setSetFieldMatch(ImmutableList diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/NextTableMissTablePropertySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/NextTableMissTablePropertySerializerTest.java index 84bcfb5f9d..5bfc3d7445 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/NextTableMissTablePropertySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/NextTableMissTablePropertySerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table public class NextTableMissTablePropertySerializerTest extends AbstractTablePropertySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final short tableId = 42; final NextTableMiss property = new NextTableMissBuilder() .setTablesMiss(new TablesMissBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/NextTableTablePropertySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/NextTableTablePropertySerializerTest.java index c6445794cf..076a589ff0 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/NextTableTablePropertySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/NextTableTablePropertySerializerTest.java @@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table public class NextTableTablePropertySerializerTest extends AbstractTablePropertySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final short tableId = 42; final NextTable property = new NextTableBuilder() .setTables(new TablesBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WildcardsTablePropertySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WildcardsTablePropertySerializerTest.java index 968bcd9079..a91395958c 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WildcardsTablePropertySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WildcardsTablePropertySerializerTest.java @@ -26,7 +26,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table public class WildcardsTablePropertySerializerTest extends AbstractTablePropertySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Wildcards property = new WildcardsBuilder() .setWildcardSetfield(new WildcardSetfieldBuilder() .setSetFieldMatch(ImmutableList diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WriteActionsMissTablePropertySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WriteActionsMissTablePropertySerializerTest.java index bd62929d69..2dd2aa82a0 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WriteActionsMissTablePropertySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WriteActionsMissTablePropertySerializerTest.java @@ -24,7 +24,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table public class WriteActionsMissTablePropertySerializerTest extends AbstractTablePropertySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final WriteActionsMiss property = new WriteActionsMissBuilder() .setWriteActionsMiss(new org.opendaylight.yang.gen.v1.urn.opendaylight .table.types.rev131026.table.feature.prop.type.table.feature.prop.type.write.actions.miss diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WriteActionsTablePropertySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WriteActionsTablePropertySerializerTest.java index a080932328..4ad3c353eb 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WriteActionsTablePropertySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WriteActionsTablePropertySerializerTest.java @@ -24,7 +24,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table public class WriteActionsTablePropertySerializerTest extends AbstractTablePropertySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final WriteActions property = new WriteActionsBuilder() .setWriteActions(new org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table.feature .prop.type.table.feature.prop.type.write.actions diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WriteSetfieldMissTablePropertySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WriteSetfieldMissTablePropertySerializerTest.java index 29373965dc..658f279558 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WriteSetfieldMissTablePropertySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WriteSetfieldMissTablePropertySerializerTest.java @@ -25,7 +25,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table public class WriteSetfieldMissTablePropertySerializerTest extends AbstractTablePropertySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final WriteSetfieldMiss property = new WriteSetfieldMissBuilder() .setWriteSetfieldMiss(new org.opendaylight.yang.gen.v1.urn.opendaylight .table.types.rev131026.table.feature.prop.type.table.feature.prop.type.write.setfield.miss diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WriteSetfieldTablePropertySerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WriteSetfieldTablePropertySerializerTest.java index cf578cbcd6..e33888f648 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WriteSetfieldTablePropertySerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WriteSetfieldTablePropertySerializerTest.java @@ -25,7 +25,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table public class WriteSetfieldTablePropertySerializerTest extends AbstractTablePropertySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final WriteSetfield property = new WriteSetfieldBuilder() .setWriteSetfield(new org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table.feature .prop.type.table.feature.prop.type.write.setfield diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/matchfield/MatchFieldSerializerTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/matchfield/MatchFieldSerializerTest.java index 3508236734..4c49e0878a 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/matchfield/MatchFieldSerializerTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/matchfield/MatchFieldSerializerTest.java @@ -66,7 +66,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table public class MatchFieldSerializerTest extends AbstractTablePropertySerializerTest { @Test - public void testSerialize() throws Exception { + public void testSerialize() { final Match property = new MatchBuilder() .setMatchSetfield(new MatchSetfieldBuilder() .setSetFieldMatch(ImmutableList diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/registry/flow/DeviceFlowRegistryImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/registry/flow/DeviceFlowRegistryImplTest.java index 4a907c3262..9cc4d36ef6 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/registry/flow/DeviceFlowRegistryImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/registry/flow/DeviceFlowRegistryImplTest.java @@ -72,7 +72,7 @@ public class DeviceFlowRegistryImplTest { private ReadTransaction readOnlyTransaction; @Before - public void setUp() throws Exception { + public void setUp() { nodeInstanceIdentifier = InstanceIdentifier.create(Nodes.class).child(Node.class, new NodeKey(new NodeId(NODE_ID))); when(dataBroker.newReadOnlyTransaction()).thenReturn(readOnlyTransaction); @@ -169,12 +169,12 @@ public class DeviceFlowRegistryImplTest { } @Test - public void testRetrieveIdForFlow() throws Exception { + public void testRetrieveIdForFlow() { Assert.assertEquals(descriptor, deviceFlowRegistry.retrieveDescriptor(key)); } @Test - public void testStore() throws Exception { + public void testStore() { //store the same key with different value final FlowDescriptor descriptor2 = FlowDescriptorFactory.create(key.getTableId(), new FlowId("ut:2")); deviceFlowRegistry.storeDescriptor(key, descriptor2); @@ -190,7 +190,7 @@ public class DeviceFlowRegistryImplTest { } @Test - public void testStoreIfNecessary() throws Exception { + public void testStoreIfNecessary() { FlowId newFlowId; //store existing key @@ -214,19 +214,19 @@ public class DeviceFlowRegistryImplTest { } @Test - public void testRemoveDescriptor() throws Exception { + public void testRemoveDescriptor() { deviceFlowRegistry.addMark(key); Assert.assertEquals(0, deviceFlowRegistry.getAllFlowDescriptors().size()); } @Test - public void testClose() throws Exception { + public void testClose() { deviceFlowRegistry.close(); Assert.assertEquals(0, deviceFlowRegistry.getAllFlowDescriptors().size()); } @Test - public void createAlienFlowIdTest() throws Exception { + public void createAlienFlowIdTest() { final String alienFlowId1 = DeviceFlowRegistryImpl.createAlienFlowId(DUMMY_TABLE_ID).getValue(); final Integer index1 = parseIndex(alienFlowId1); final String alienFlowId2 = DeviceFlowRegistryImpl.createAlienFlowId(DUMMY_TABLE_ID).getValue(); @@ -238,7 +238,7 @@ public class DeviceFlowRegistryImplTest { } @Test - public void testForEach() throws Exception { + public void testForEach() { final AtomicInteger counter = new AtomicInteger(0); deviceFlowRegistry.forEach(k -> counter.incrementAndGet()); Assert.assertEquals(1, counter.get()); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/registry/flow/FlowDescriptorDtoTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/registry/flow/FlowDescriptorDtoTest.java index f7afc58718..45642087c1 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/registry/flow/FlowDescriptorDtoTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/registry/flow/FlowDescriptorDtoTest.java @@ -20,7 +20,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.Fl public class FlowDescriptorDtoTest { @Test - public void testCreate() throws Exception { + public void testCreate() { final FlowDescriptor flowDescriptor = FlowDescriptorFactory.create((short) 1, new FlowId("unit:1")); Assert.assertNotNull(flowDescriptor); Assert.assertNotNull(flowDescriptor.getFlowId()); @@ -29,7 +29,7 @@ public class FlowDescriptorDtoTest { @Test(expected = Exception.class) @SuppressFBWarnings("NP_NONNULL_PARAM_VIOLATION") // that is the point of this test - public void testCreateNegative1() throws Exception { + public void testCreateNegative1() { FlowDescriptorFactory.create((short) 1, null); } } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/registry/flow/FlowRegistryKeyFactoryTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/registry/flow/FlowRegistryKeyFactoryTest.java index f9e9c600d7..1d40449da2 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/registry/flow/FlowRegistryKeyFactoryTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/registry/flow/FlowRegistryKeyFactoryTest.java @@ -66,7 +66,7 @@ public class FlowRegistryKeyFactoryTest { } @Test - public void testEquals() throws Exception { + public void testEquals() { FlowsStatisticsUpdate flowStats = FLOWS_STATISTICS_UPDATE_BUILDER.build(); HashSet flowRegistryKeys = new HashSet<>(); @@ -81,7 +81,7 @@ public class FlowRegistryKeyFactoryTest { } @Test - public void testEqualsNegative() throws Exception { + public void testEqualsNegative() { final FlowAndStatisticsMapList flowStatisticsMapList1 = TestFlowHelper.createFlowAndStatisticsMapListBuilder(1).build(); final FlowRegistryKey key1 = FlowRegistryKeyFactory.create(deviceInfo.getVersion(), flowStatisticsMapList1); @@ -111,7 +111,7 @@ public class FlowRegistryKeyFactoryTest { } @Test - public void testGetHash2() throws Exception { + public void testGetHash2() { MatchBuilder match1Builder = new MatchBuilder().setLayer3Match(new Ipv4MatchBuilder() .setIpv4Destination(new Ipv4Prefix("10.0.1.157/32")).build()); FlowBuilder flow1Builder = new FlowBuilder() @@ -137,7 +137,7 @@ public class FlowRegistryKeyFactoryTest { } @Test - public void testGetHashNPE() throws Exception { + public void testGetHashNPE() { MatchBuilder match1Builder = new MatchBuilder().setLayer3Match(new Ipv4MatchBuilder() .setIpv4Destination(new Ipv4Prefix("10.0.1.157/32")).build()); FlowBuilder flow1Builder = new FlowBuilder() @@ -173,7 +173,7 @@ public class FlowRegistryKeyFactoryTest { } @Test - public void testGetHash() throws Exception { + public void testGetHash() { FlowsStatisticsUpdate flowStats = FLOWS_STATISTICS_UPDATE_BUILDER.build(); for (FlowAndStatisticsMapList item : flowStats.getFlowAndStatisticsMapList()) { diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/registry/group/DeviceGroupRegistryImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/registry/group/DeviceGroupRegistryImplTest.java index 47f7056934..d65db0647e 100755 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/registry/group/DeviceGroupRegistryImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/registry/group/DeviceGroupRegistryImplTest.java @@ -24,7 +24,7 @@ public class DeviceGroupRegistryImplTest { private DeviceGroupRegistryImpl deviceGroupRegistry; @Before - public void setUp() throws Exception { + public void setUp() { deviceGroupRegistry = new DeviceGroupRegistryImpl(); groupId = new GroupId(42L); groupId2 = new GroupId(84L); @@ -34,27 +34,27 @@ public class DeviceGroupRegistryImplTest { } @Test - public void testStore() throws Exception { + public void testStore() { deviceGroupRegistry.store(groupId2); Assert.assertEquals(2, deviceGroupRegistry.getAllGroupIds().size()); } @Test - public void testRemoveMarked() throws Exception { + public void testRemoveMarked() { deviceGroupRegistry.addMark(groupId); deviceGroupRegistry.processMarks(); Assert.assertEquals(0, deviceGroupRegistry.getAllGroupIds().size()); } @Test - public void testRemoveMarkedNegative() throws Exception { + public void testRemoveMarkedNegative() { deviceGroupRegistry.addMark(groupId2); deviceGroupRegistry.processMarks(); Assert.assertEquals(1, deviceGroupRegistry.getAllGroupIds().size()); } @Test - public void testClose() throws Exception { + public void testClose() { deviceGroupRegistry.addMark(groupId); deviceGroupRegistry.close(); @@ -67,7 +67,7 @@ public class DeviceGroupRegistryImplTest { } @Test - public void testForEach() throws Exception { + public void testForEach() { final AtomicInteger counter = new AtomicInteger(0); deviceGroupRegistry.store(groupId2); deviceGroupRegistry.forEach(group -> counter.incrementAndGet()); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/registry/meter/DeviceMeterRegistryImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/registry/meter/DeviceMeterRegistryImplTest.java index bd5cc39ca6..477001c461 100755 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/registry/meter/DeviceMeterRegistryImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/registry/meter/DeviceMeterRegistryImplTest.java @@ -24,7 +24,7 @@ public class DeviceMeterRegistryImplTest { private DeviceMeterRegistryImpl deviceMeterRegistry; @Before - public void setUp() throws Exception { + public void setUp() { deviceMeterRegistry = new DeviceMeterRegistryImpl(); meterId = new MeterId(42L); meterId2 = new MeterId(84L); @@ -34,27 +34,27 @@ public class DeviceMeterRegistryImplTest { } @Test - public void testStore() throws Exception { + public void testStore() { deviceMeterRegistry.store(meterId2); Assert.assertEquals(2, deviceMeterRegistry.getAllMeterIds().size()); } @Test - public void testRemoveMarked() throws Exception { + public void testRemoveMarked() { deviceMeterRegistry.addMark(meterId); deviceMeterRegistry.processMarks(); Assert.assertEquals(0, deviceMeterRegistry.getAllMeterIds().size()); } @Test - public void testRemoveMarkedNegative() throws Exception { + public void testRemoveMarkedNegative() { deviceMeterRegistry.addMark(meterId2); deviceMeterRegistry.processMarks(); Assert.assertEquals(1, deviceMeterRegistry.getAllMeterIds().size()); } @Test - public void testClose() throws Exception { + public void testClose() { deviceMeterRegistry.addMark(meterId); deviceMeterRegistry.close(); @@ -68,7 +68,7 @@ public class DeviceMeterRegistryImplTest { } @Test - public void testForEach() throws Exception { + public void testForEach() { final AtomicInteger counter = new AtomicInteger(0); deviceMeterRegistry.store(meterId2); deviceMeterRegistry.forEach(meter -> counter.incrementAndGet()); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/role/RoleContextImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/role/RoleContextImplTest.java index fa491d38ce..1b89f8d7f2 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/role/RoleContextImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/role/RoleContextImplTest.java @@ -54,7 +54,7 @@ public class RoleContextImplTest { private RoleContext roleContext; @Before - public void setUp() throws Exception { + public void setUp() { when(deviceInfo.getNodeInstanceIdentifier()).thenReturn(DeviceStateUtil .createNodeInstanceIdentifier(new NodeId("openflow:1"))); when(deviceInfo.getVersion()).thenReturn(OFConstants.OFP_VERSION_1_3); @@ -66,12 +66,12 @@ public class RoleContextImplTest { } @After - public void tearDown() throws Exception { + public void tearDown() { roleContext.close(); } @Test - public void instantiateServiceInstance() throws Exception { + public void instantiateServiceInstance() { roleContext.instantiateServiceInstance(); verify(roleService).setRole(new SetRoleInputBuilder() .setControllerRole(OfpRole.BECOMEMASTER) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/rpc/AbstractRequestContextTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/rpc/AbstractRequestContextTest.java index 1e311581f6..11f893c10c 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/rpc/AbstractRequestContextTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/rpc/AbstractRequestContextTest.java @@ -31,7 +31,7 @@ public class AbstractRequestContextTest { } @Test - public void testCreateRequestFuture() throws Exception { + public void testCreateRequestFuture() { Future future = requestContext.getFuture(); assertNotNull(future); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/rpc/RpcContextImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/rpc/RpcContextImplTest.java index 9de76edf55..ce4ca89156 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/rpc/RpcContextImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/rpc/RpcContextImplTest.java @@ -95,7 +95,7 @@ public class RpcContextImplTest { } @Test - public void testStoreOrFail() throws Exception { + public void testStoreOrFail() { try (RpcContext rpcContext = new RpcContextImpl( rpcProviderRegistry, 100, @@ -109,7 +109,7 @@ public class RpcContextImplTest { } @Test - public void testStoreOrFailThatFails() throws Exception { + public void testStoreOrFailThatFails() { try (RpcContext rpcContext = new RpcContextImpl( rpcProviderRegistry, 0, @@ -123,7 +123,7 @@ public class RpcContextImplTest { } @Test - public void testStoreAndCloseOrFail() throws Exception { + public void testStoreAndCloseOrFail() { try (RpcContext rpcContext = new RpcContextImpl( rpcProviderRegistry, 100, @@ -165,7 +165,7 @@ public class RpcContextImplTest { * When deviceContext.reserveXidForDeviceMessage returns null, null should be returned. */ @Test - public void testCreateRequestContext1() throws InterruptedException { + public void testCreateRequestContext1() { when(deviceInfo.reserveXidForDeviceMessage()).thenReturn(null); assertEquals(rpcContext.createRequestContext(),null); } @@ -175,7 +175,7 @@ public class RpcContextImplTest { */ @Test - public void testCreateRequestContext2() throws InterruptedException { + public void testCreateRequestContext2() { RequestContext temp = rpcContext.createRequestContext(); temp.close(); verify(messageSpy).spyMessage(RpcContextImpl.class, MessageSpy.StatisticsGroup.REQUEST_STACK_FREED); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/rpc/RpcManagerImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/rpc/RpcManagerImplTest.java index 90c920f6f7..2da9fcb414 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/rpc/RpcManagerImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/rpc/RpcManagerImplTest.java @@ -94,7 +94,7 @@ public class RpcManagerImplTest { } @Test - public void createContext() throws Exception { + public void createContext() { final RpcContext context = rpcManager.createContext(deviceContext); assertEquals(deviceInfo, context.getDeviceInfo()); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/EchoServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/EchoServiceTest.java index a1fa78ea32..cb380af69f 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/EchoServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/EchoServiceTest.java @@ -31,14 +31,14 @@ public class EchoServiceTest extends ServiceMocking { } @Test - public void testSendEcho() throws Exception { + public void testSendEcho() { EchoInputBuilder sendEchoInput = new EchoInputBuilder(); echoService.handleServiceCall(sendEchoInput); verify(mockedRequestContextStack).createRequestContext(); } @Test - public void testBuildRequest() throws Exception { + public void testBuildRequest() { EchoInputBuilder sendEchoInput = new EchoInputBuilder().setData(DUMMY_DATA); final OfHeader request = this.echoService.buildRequest(new Xid(DUMMY_XID_VALUE), sendEchoInput); assertEquals(DUMMY_XID_VALUE, request.getXid()); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/MultipartRequestCallbackTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/MultipartRequestCallbackTest.java index 6ac095c242..844465c621 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/MultipartRequestCallbackTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/MultipartRequestCallbackTest.java @@ -52,7 +52,7 @@ public class MultipartRequestCallbackTest { private AbstractMultipartRequestCallback multipartRequestCallback; @Before - public void setUp() throws Exception { + public void setUp() { Mockito.doNothing().when(requestContext).setResult(rpcResultCapt.capture()); Mockito.when(deviceContext.getMessageSpy()).thenReturn(spy); @@ -69,7 +69,7 @@ public class MultipartRequestCallbackTest { * End collecting. */ @Test - public void testOnSuccess1() throws Exception { + public void testOnSuccess1() { multipartRequestCallback.onSuccess(null); Mockito.verify(multiMsgCollector).endCollecting(ArgumentMatchers.any()); } @@ -78,7 +78,7 @@ public class MultipartRequestCallbackTest { * Fail adding to collection. */ @Test - public void testOnSuccess2() throws Exception { + public void testOnSuccess2() { multipartRequestCallback.onSuccess(new EchoOutputBuilder().build()); final RpcResult> rpcResult = rpcResultCapt.getValue(); Assert.assertNotNull(rpcResult); @@ -89,7 +89,7 @@ public class MultipartRequestCallbackTest { * Successfully added to collection. */ @Test - public void testOnSuccess3() throws Exception { + public void testOnSuccess3() { final MultipartReplyMessage replyMessage = new MultipartReplyMessageBuilder().build(); multipartRequestCallback.onSuccess(replyMessage); Mockito.verify(multiMsgCollector) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/MultipartRequestOnTheFlyCallbackTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/MultipartRequestOnTheFlyCallbackTest.java index 57af525dc0..af573a6b7f 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/MultipartRequestOnTheFlyCallbackTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/MultipartRequestOnTheFlyCallbackTest.java @@ -189,7 +189,7 @@ public class MultipartRequestOnTheFlyCallbackTest { * Not the last reply. */ @Test - public void testOnSuccessWithValidMultipart1() throws Exception { + public void testOnSuccessWithValidMultipart1() { final MatchBuilder matchBuilder = new MatchBuilder() .setMatchEntry(Collections.emptyList()); final FlowStatsBuilder flowStatsBuilder = new FlowStatsBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/ServiceMocking.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/ServiceMocking.java index 2b0016a109..194a8552d0 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/ServiceMocking.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/ServiceMocking.java @@ -97,7 +97,7 @@ public abstract class ServiceMocking { @Before @SuppressWarnings("unchecked") - public void initialization() throws Exception { + public void initialization() { lenient().when(mockedExtensionConverter.getExperimenterId()) .thenReturn(new ExperimenterId(DUMMY_EXPERIMENTER_ID)); lenient().when(mockedExtensionConverterProvider.getMessageConverter(Matchers.any())) @@ -131,7 +131,7 @@ public abstract class ServiceMocking { setup(); } - protected void setup() throws Exception { + protected void setup() { //NOOP - to be overloaded } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/batch/FlatBatchFlowAdaptersTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/batch/FlatBatchFlowAdaptersTest.java index 8bb15ded98..401bac4856 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/batch/FlatBatchFlowAdaptersTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/batch/FlatBatchFlowAdaptersTest.java @@ -51,7 +51,7 @@ public class FlatBatchFlowAdaptersTest { private static final NodeRef NODE_REF = new NodeRef(NODE_II); @Test - public void testAdaptFlatBatchAddFlow() throws Exception { + public void testAdaptFlatBatchAddFlow() { final BatchPlanStep planStep = new BatchPlanStep(BatchStepType.FLOW_ADD); planStep.setBarrierAfter(true); planStep.getTaskBag().addAll(Lists.newArrayList( @@ -85,7 +85,7 @@ public class FlatBatchFlowAdaptersTest { } @Test - public void testAdaptFlatBatchRemoveFlow() throws Exception { + public void testAdaptFlatBatchRemoveFlow() { final BatchPlanStep planStep = new BatchPlanStep(BatchStepType.FLOW_REMOVE); planStep.setBarrierAfter(true); planStep.getTaskBag().addAll(Lists.newArrayList( @@ -102,7 +102,7 @@ public class FlatBatchFlowAdaptersTest { } @Test - public void testAdaptFlatBatchUpdateFlow() throws Exception { + public void testAdaptFlatBatchUpdateFlow() { final BatchPlanStep planStep = new BatchPlanStep(BatchStepType.FLOW_UPDATE); planStep.setBarrierAfter(true); planStep.getTaskBag().addAll(Lists.newArrayList( @@ -119,7 +119,7 @@ public class FlatBatchFlowAdaptersTest { } @Test - public void testCreateBatchFlowChainingFunction_failures() throws Exception { + public void testCreateBatchFlowChainingFunction_failures() { final RpcResult input = RpcResultBuilder.failed() .withError(RpcError.ErrorType.APPLICATION, "ut-flowError") .withResult(new AddFlowsBatchOutputBuilder() @@ -144,7 +144,7 @@ public class FlatBatchFlowAdaptersTest { } @Test - public void testCreateBatchFlowChainingFunction_successes() throws Exception { + public void testCreateBatchFlowChainingFunction_successes() { final RpcResult input = RpcResultBuilder .success(new AddFlowsBatchOutputBuilder().build()) .build(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/batch/FlatBatchGroupAdaptersTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/batch/FlatBatchGroupAdaptersTest.java index 98e1374dd4..e3a403caa5 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/batch/FlatBatchGroupAdaptersTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/batch/FlatBatchGroupAdaptersTest.java @@ -53,7 +53,7 @@ public class FlatBatchGroupAdaptersTest { private static final NodeRef NODE_REF = new NodeRef(NODE_II); @Test - public void testAdaptFlatBatchAddGroup() throws Exception { + public void testAdaptFlatBatchAddGroup() { final BatchPlanStep planStep = new BatchPlanStep(BatchStepType.FLOW_ADD); planStep.setBarrierAfter(true); planStep.getTaskBag().addAll(Lists.newArrayList( @@ -93,7 +93,7 @@ public class FlatBatchGroupAdaptersTest { } @Test - public void testAdaptFlatBatchRemoveGroup() throws Exception { + public void testAdaptFlatBatchRemoveGroup() { final BatchPlanStep planStep = new BatchPlanStep(BatchStepType.FLOW_REMOVE); planStep.setBarrierAfter(true); planStep.getTaskBag().addAll(Lists.newArrayList( @@ -112,7 +112,7 @@ public class FlatBatchGroupAdaptersTest { } @Test - public void testAdaptFlatBatchUpdateGroup() throws Exception { + public void testAdaptFlatBatchUpdateGroup() { final BatchPlanStep planStep = new BatchPlanStep(BatchStepType.FLOW_UPDATE); planStep.setBarrierAfter(true); planStep.getTaskBag().addAll(Lists.newArrayList( @@ -131,7 +131,7 @@ public class FlatBatchGroupAdaptersTest { } @Test - public void testCreateBatchGroupChainingFunction_failures() throws Exception { + public void testCreateBatchGroupChainingFunction_failures() { final RpcResult input = RpcResultBuilder.failed() .withError(RpcError.ErrorType.APPLICATION, "ut-groupError") .withResult(new AddGroupsBatchOutputBuilder() @@ -155,7 +155,7 @@ public class FlatBatchGroupAdaptersTest { } @Test - public void testCreateBatchGroupChainingFunction_successes() throws Exception { + public void testCreateBatchGroupChainingFunction_successes() { final RpcResult input = RpcResultBuilder .success(new AddGroupsBatchOutputBuilder().build()) .build(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/batch/FlatBatchMeterAdaptersTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/batch/FlatBatchMeterAdaptersTest.java index 16c5763162..bf487d3e7e 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/batch/FlatBatchMeterAdaptersTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/batch/FlatBatchMeterAdaptersTest.java @@ -53,7 +53,7 @@ public class FlatBatchMeterAdaptersTest { private static final NodeRef NODE_REF = new NodeRef(NODE_II); @Test - public void testAdaptFlatBatchAddMeter() throws Exception { + public void testAdaptFlatBatchAddMeter() { final BatchPlanStep planStep = new BatchPlanStep(BatchStepType.FLOW_ADD); planStep.setBarrierAfter(true); planStep.getTaskBag().addAll(Lists.newArrayList( @@ -93,7 +93,7 @@ public class FlatBatchMeterAdaptersTest { } @Test - public void testAdaptFlatBatchRemoveMeter() throws Exception { + public void testAdaptFlatBatchRemoveMeter() { final BatchPlanStep planStep = new BatchPlanStep(BatchStepType.FLOW_REMOVE); planStep.setBarrierAfter(true); planStep.getTaskBag().addAll(Lists.newArrayList( @@ -112,7 +112,7 @@ public class FlatBatchMeterAdaptersTest { } @Test - public void testAdaptFlatBatchUpdateMeter() throws Exception { + public void testAdaptFlatBatchUpdateMeter() { final BatchPlanStep planStep = new BatchPlanStep(BatchStepType.FLOW_UPDATE); planStep.setBarrierAfter(true); planStep.getTaskBag().addAll(Lists.newArrayList( @@ -131,7 +131,7 @@ public class FlatBatchMeterAdaptersTest { } @Test - public void testCreateBatchMeterChainingFunction_failures() throws Exception { + public void testCreateBatchMeterChainingFunction_failures() { final RpcResult input = RpcResultBuilder.failed() .withError(RpcError.ErrorType.APPLICATION, "ut-meterError") .withResult(new AddMetersBatchOutputBuilder() @@ -155,7 +155,7 @@ public class FlatBatchMeterAdaptersTest { } @Test - public void testCreateBatchMeterChainingFunction_successes() throws Exception { + public void testCreateBatchMeterChainingFunction_successes() { final RpcResult input = RpcResultBuilder .success(new AddMetersBatchOutputBuilder().build()) .build(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/FlowCapableTransactionServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/FlowCapableTransactionServiceImplTest.java index 682f4cdc36..e612add4ee 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/FlowCapableTransactionServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/FlowCapableTransactionServiceImplTest.java @@ -36,7 +36,7 @@ public class FlowCapableTransactionServiceImplTest extends ServiceMocking { } @Test - public void testBuildRequest() throws Exception { + public void testBuildRequest() { SendBarrierInput sendBarrierInput = buildSendBarrierInput(); final OfHeader request = flowCapableTransactionService.buildRequest(new Xid(DUMMY_XID_VALUE), sendBarrierInput); @@ -45,7 +45,7 @@ public class FlowCapableTransactionServiceImplTest extends ServiceMocking { } @Test - public void testSendBarrier() throws Exception { + public void testSendBarrier() { SendBarrierInput sendBarrierInput = buildSendBarrierInput(); flowCapableTransactionService.sendBarrier(sendBarrierInput); verify(mockedRequestContextStack).createRequestContext(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/NodeConfigServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/NodeConfigServiceImplTest.java index 6d35230058..fe39cfd7e9 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/NodeConfigServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/NodeConfigServiceImplTest.java @@ -29,14 +29,14 @@ public class NodeConfigServiceImplTest extends ServiceMocking { NodeConfigServiceImpl nodeConfigService; @Test - public void testSetConfig() throws Exception { + public void testSetConfig() { nodeConfigService = new NodeConfigServiceImpl(mockedRequestContextStack, mockedDeviceContext); nodeConfigService.setConfig(dummyConfigInput()); verify(mockedRequestContextStack).createRequestContext(); } @Test - public void testBuildRequest() throws Exception { + public void testBuildRequest() { nodeConfigService = new NodeConfigServiceImpl(mockedRequestContextStack, mockedDeviceContext); final OfHeader request = nodeConfigService.buildRequest(new Xid(DUMMY_XID_VALUE), dummyConfigInput()); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/PacketProcessingServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/PacketProcessingServiceImplTest.java index 16d1ba38a1..871ef12c99 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/PacketProcessingServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/PacketProcessingServiceImplTest.java @@ -56,14 +56,14 @@ public class PacketProcessingServiceImplTest extends ServiceMocking { } @Test - public void testTransmitPacket() throws Exception { + public void testTransmitPacket() { TransmitPacketInput transmitPacketInput = buildTransmitPacketInput(); packetProcessingService.transmitPacket(transmitPacketInput); verify(mockedRequestContextStack).createRequestContext(); } @Test - public void testBuildRequest() throws Exception { + public void testBuildRequest() { TransmitPacketInput transmitPacketInput = buildTransmitPacketInput(); final OfHeader request = packetProcessingService.buildRequest(new Xid(DUMMY_XID_VALUE), transmitPacketInput); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalAsyncConfigServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalAsyncConfigServiceImplTest.java index f904f83888..76bcaf5cfe 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalAsyncConfigServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalAsyncConfigServiceImplTest.java @@ -39,7 +39,7 @@ public class SalAsyncConfigServiceImplTest extends ServiceMocking { private SalAsyncConfigServiceImpl salAsyncConfigService; @Override - public void setup() throws Exception { + public void setup() { salAsyncConfigService = new SalAsyncConfigServiceImpl( mockedRequestContextStack, mockedDeviceContext); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalBundleServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalBundleServiceImplTest.java index 8af79bc7d2..74e9171694 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalBundleServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalBundleServiceImplTest.java @@ -91,7 +91,7 @@ public class SalBundleServiceImplTest { } @Test - public void testAddBundleMessages() throws Exception { + public void testAddBundleMessages() { final List innerMessages = createMessages(); final Messages messages = new MessagesBuilder().setMessage(innerMessages).build(); final AddBundleMessagesInput input = new AddBundleMessagesInputBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalExperimenterMessageServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalExperimenterMessageServiceImplTest.java index ecfe939247..e648341b54 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalExperimenterMessageServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalExperimenterMessageServiceImplTest.java @@ -56,7 +56,7 @@ public class SalExperimenterMessageServiceImplTest extends ServiceMocking { } @Test - public void testSendExperimenter() throws Exception { + public void testSendExperimenter() { SendExperimenterInput sendExperimenterInput = buildSendExperimenterInput(); salExperimenterMessageService.sendExperimenter(sendExperimenterInput); verify(mockedRequestContextStack).createRequestContext(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalExperimenterMpMessageServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalExperimenterMpMessageServiceImplTest.java index ecae3b0c2b..133ba53c61 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalExperimenterMpMessageServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalExperimenterMpMessageServiceImplTest.java @@ -33,7 +33,7 @@ public class SalExperimenterMpMessageServiceImplTest extends ServiceMocking { } @Test - public void sendExperimenterMpRequest() throws Exception { + public void sendExperimenterMpRequest() { final SendExperimenterMpRequestInput data = new SendExperimenterMpRequestInputBuilder() .setExperimenterMessageOfChoice(mockExperimenter()) .setNode(new NodeRef(mockedDeviceInfo.getNodeInstanceIdentifier())) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalFlatBatchServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalFlatBatchServiceImplTest.java index abbc7b8b1e..335af88e0f 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalFlatBatchServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalFlatBatchServiceImplTest.java @@ -116,14 +116,14 @@ public class SalFlatBatchServiceImplTest { private SalFlatBatchServiceImpl salFlatBatchService; @Before - public void setUp() throws Exception { + public void setUp() { salFlatBatchService = new SalFlatBatchServiceImpl(salFlowsBatchService, salGroupsBatchService, salMetersBatchService); } @After - public void tearDown() throws Exception { + public void tearDown() { Mockito.verifyNoMoreInteractions(salFlowsBatchService, salGroupsBatchService, salMetersBatchService); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalFlowsBatchServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalFlowsBatchServiceImplTest.java index 68413d99d6..692a43fd2d 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalFlowsBatchServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalFlowsBatchServiceImplTest.java @@ -95,7 +95,7 @@ public class SalFlowsBatchServiceImplTest { public static final String FLOW_ID_VALUE_2 = "ut-dummy-flow2"; @Before - public void setUp() throws Exception { + public void setUp() { salFlowsBatchService = new SalFlowsBatchServiceImpl(salFlowService, transactionService); Mockito.when(transactionService.sendBarrier(ArgumentMatchers.any())) @@ -103,7 +103,7 @@ public class SalFlowsBatchServiceImplTest { } @After - public void tearDown() throws Exception { + public void tearDown() { Mockito.verifyNoMoreInteractions(salFlowService, transactionService); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalGroupServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalGroupServiceImplTest.java index 3f3950635a..33ee1f8e71 100755 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalGroupServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalGroupServiceImplTest.java @@ -46,7 +46,7 @@ public class SalGroupServiceImplTest extends ServiceMocking { } @Test - public void testAddGroup() throws Exception { + public void testAddGroup() { addGroup(); } @@ -62,12 +62,12 @@ public class SalGroupServiceImplTest extends ServiceMocking { } @Test - public void testUpdateGroup() throws Exception { + public void testUpdateGroup() { updateGroup(); } @Test - public void testUpdateGroupWithItemLifecycle() throws Exception { + public void testUpdateGroupWithItemLifecycle() { updateGroup(); } @@ -84,16 +84,16 @@ public class SalGroupServiceImplTest extends ServiceMocking { } @Test - public void testRemoveGroup() throws Exception { + public void testRemoveGroup() { removeGroup(); } @Test - public void testRemoveGroupWithItemLifecycle() throws Exception { + public void testRemoveGroupWithItemLifecycle() { removeGroup(); } - private void removeGroup() throws Exception { + private void removeGroup() { final GroupId dummyGroupId = new GroupId(DUMMY_GROUP_ID); RemoveGroupInput removeGroupInput = new RemoveGroupInputBuilder().setGroupId(dummyGroupId).build(); this.mockSuccessfulFuture(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalGroupsBatchServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalGroupsBatchServiceImplTest.java index 754de68342..6aa8a111de 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalGroupsBatchServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalGroupsBatchServiceImplTest.java @@ -89,7 +89,7 @@ public class SalGroupsBatchServiceImplTest { @Before - public void setUp() throws Exception { + public void setUp() { salGroupsBatchService = new SalGroupsBatchServiceImpl(salGroupService, transactionService); Mockito.when(transactionService.sendBarrier(ArgumentMatchers.any())) @@ -97,7 +97,7 @@ public class SalGroupsBatchServiceImplTest { } @After - public void tearDown() throws Exception { + public void tearDown() { Mockito.verifyNoMoreInteractions(salGroupService, transactionService); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalMeterServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalMeterServiceImplTest.java index 68ca0c0bd3..001a6d2c99 100755 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalMeterServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalMeterServiceImplTest.java @@ -46,7 +46,7 @@ public class SalMeterServiceImplTest extends ServiceMocking { } @Test - public void testAddMeter() throws Exception { + public void testAddMeter() { addMeter(); } @@ -60,12 +60,12 @@ public class SalMeterServiceImplTest extends ServiceMocking { } @Test - public void testUpdateMeter() throws Exception { + public void testUpdateMeter() { updateMeter(); } - private void updateMeter() throws Exception { + private void updateMeter() { final UpdatedMeter dummyUpdatedMeter = new UpdatedMeterBuilder().setMeterId(new MeterId(DUMMY_METTER_ID)).build(); final OriginalMeter dummyOriginalMeter = @@ -80,12 +80,12 @@ public class SalMeterServiceImplTest extends ServiceMocking { } @Test - public void testRemoveMeter() throws Exception { + public void testRemoveMeter() { removeMeter(); } - private void removeMeter() throws Exception { + private void removeMeter() { final MeterId dummyMeterId = new MeterId(DUMMY_METER_ID); RemoveMeterInput removeMeterInput = new RemoveMeterInputBuilder().setMeterId(dummyMeterId).build(); this.mockSuccessfulFuture(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalMetersBatchServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalMetersBatchServiceImplTest.java index 32b5490ad6..b80738b345 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalMetersBatchServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalMetersBatchServiceImplTest.java @@ -90,7 +90,7 @@ public class SalMetersBatchServiceImplTest { private SalMetersBatchServiceImpl salMetersBatchService; @Before - public void setUp() throws Exception { + public void setUp() { salMetersBatchService = new SalMetersBatchServiceImpl(salMeterService, transactionService); Mockito.when(transactionService.sendBarrier(any())) @@ -98,7 +98,7 @@ public class SalMetersBatchServiceImplTest { } @After - public void tearDown() throws Exception { + public void tearDown() { Mockito.verifyNoMoreInteractions(salMeterService, transactionService); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalPortServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalPortServiceImplTest.java index d026b4e542..ee020f7092 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalPortServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalPortServiceImplTest.java @@ -45,13 +45,13 @@ public class SalPortServiceImplTest extends ServiceMocking { } @Test - public void testUpdatePort() throws Exception { + public void testUpdatePort() { salPortService.updatePort(dummyUpdatePortInput()); verify(mockedRequestContextStack).createRequestContext(); } @Test - public void testBuildRequest() throws Exception { + public void testBuildRequest() { final OfHeader ofHeader = salPortService.buildRequest(new Xid(DUMMY_XID), dummyUpdatePortInput()); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalTableServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalTableServiceImplTest.java index 96afe3df55..da24425e36 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalTableServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/SalTableServiceImplTest.java @@ -15,7 +15,6 @@ import com.google.common.util.concurrent.FutureCallback; import com.google.common.util.concurrent.SettableFuture; import java.util.Collections; import java.util.List; -import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; import org.junit.Assert; import org.junit.Test; @@ -68,7 +67,7 @@ public class SalTableServiceImplTest extends ServiceMocking { } @Test - public void testUpdateTableFail1() throws ExecutionException, InterruptedException { + public void testUpdateTableFail1() { Mockito.doAnswer((Answer) invocation -> { final RpcResult> rpcResult = RpcResultBuilder.>failed().build(); @@ -82,7 +81,7 @@ public class SalTableServiceImplTest extends ServiceMocking { } @Test - public void testUpdateTableFail2() throws ExecutionException, InterruptedException { + public void testUpdateTableFail2() { Mockito.doAnswer((Answer) invocation -> { final RpcResult> rpcResult = RpcResultBuilder.success(Collections.emptyList()) @@ -97,7 +96,7 @@ public class SalTableServiceImplTest extends ServiceMocking { } @Test - public void testUpdateTableSuccess() throws ExecutionException, InterruptedException { + public void testUpdateTableSuccess() { Mockito.doAnswer((Answer) invocation -> { TableFeaturesBuilder tableFeaturesBld = new TableFeaturesBuilder() .setTableId((short) 0) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerAggregateFlowMultipartServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerAggregateFlowMultipartServiceTest.java index 6ecbd795f9..10b2195b48 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerAggregateFlowMultipartServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerAggregateFlowMultipartServiceTest.java @@ -32,12 +32,12 @@ public class SingleLayerAggregateFlowMultipartServiceTest extends ServiceMocking private SingleLayerAggregateFlowMultipartService service; @Override - protected void setup() throws Exception { + protected void setup() { service = new SingleLayerAggregateFlowMultipartService(mockedRequestContextStack, mockedDeviceContext); } @Test - public void buildRequest() throws Exception { + public void buildRequest() { final GetAggregateFlowStatisticsFromFlowTableForGivenMatchInput input = new GetAggregateFlowStatisticsFromFlowTableForGivenMatchInputBuilder() .setTableId(TABLE_ID) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerExperimenterMultipartServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerExperimenterMultipartServiceTest.java index 8bdd20a47a..e331f2e2ad 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerExperimenterMultipartServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerExperimenterMultipartServiceTest.java @@ -28,14 +28,14 @@ public class SingleLayerExperimenterMultipartServiceTest extends ServiceMocking private SingleLayerExperimenterMultipartService service; @Override - protected void setup() throws Exception { + protected void setup() { service = new SingleLayerExperimenterMultipartService( mockedRequestContextStack, mockedDeviceContext, mockedExtensionConverterProvider); } @Test - public void buildRequest() throws Exception { + public void buildRequest() { final SendExperimenterMpRequestInput input = new SendExperimenterMpRequestInputBuilder() .setExperimenterMessageOfChoice(mockExperimenter()) .build(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerFlowServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerFlowServiceTest.java index 534538d6d2..c4b96e3110 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerFlowServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerFlowServiceTest.java @@ -24,13 +24,13 @@ public class SingleLayerFlowServiceTest extends ServiceMocking { private SingleLayerFlowService service; @Override - protected void setup() throws Exception { + protected void setup() { service = new SingleLayerFlowService<>(mockedRequestContextStack, mockedDeviceContext, AddFlowOutput.class); } @Test - public void buildRequest() throws Exception { + public void buildRequest() { final AddFlowInput input = new AddFlowInputBuilder() .setTableId(TABLE_ID) .build(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerGroupServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerGroupServiceTest.java index 22ba222767..363a8b1af6 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerGroupServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerGroupServiceTest.java @@ -25,13 +25,13 @@ public class SingleLayerGroupServiceTest extends ServiceMocking { private SingleLayerGroupService service; @Override - protected void setup() throws Exception { + protected void setup() { service = new SingleLayerGroupService<>(mockedRequestContextStack, mockedDeviceContext, AddGroupOutput.class); } @Test - public void buildRequest() throws Exception { + public void buildRequest() { final AddGroupInput input = new AddGroupInputBuilder() .setGroupId(new GroupId(GROUP_ID)) .build(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerMeterServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerMeterServiceTest.java index 3105d12bbc..984d3e76cb 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerMeterServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerMeterServiceTest.java @@ -25,13 +25,13 @@ public class SingleLayerMeterServiceTest extends ServiceMocking { private SingleLayerMeterService service; @Override - protected void setup() throws Exception { + protected void setup() { service = new SingleLayerMeterService<>(mockedRequestContextStack, mockedDeviceContext, AddMeterOutput.class); } @Test - public void buildRequest() throws Exception { + public void buildRequest() { final AddMeterInput input = new AddMeterInputBuilder() .setMeterId(new MeterId(METER_ID)) .build(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerPortServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerPortServiceTest.java index 5a6c917ec9..f82214baed 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerPortServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerPortServiceTest.java @@ -24,13 +24,13 @@ public class SingleLayerPortServiceTest extends ServiceMocking { private SingleLayerPortService service; @Override - protected void setup() throws Exception { + protected void setup() { service = new SingleLayerPortService<>(mockedRequestContextStack, mockedDeviceContext, UpdatePortOutput.class); } @Test - public void buildRequest() throws Exception { + public void buildRequest() { final Port input = new PortBuilder() .setPortNumber(new PortNumberUni(PORT_ID)) .build(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerTableMultipartServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerTableMultipartServiceTest.java index 2422bc445e..7b9f0c4d99 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerTableMultipartServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerTableMultipartServiceTest.java @@ -34,13 +34,13 @@ public class SingleLayerTableMultipartServiceTest extends ServiceMocking { private SingleLayerTableMultipartService service; @Override - protected void setup() throws Exception { + protected void setup() { service = new SingleLayerTableMultipartService(mockedRequestContextStack, mockedDeviceContext, MultipartWriterProviderFactory.createDefaultProvider(mockedDeviceContext)); } @Test - public void buildRequest() throws Exception { + public void buildRequest() { final UpdateTableInput input = new UpdateTableInputBuilder() .setUpdatedTable(new UpdatedTableBuilder() .setTableFeatures(Collections.singletonList(new TableFeaturesBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/util/RequestContextUtilTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/util/RequestContextUtilTest.java index 3354841307..70c700b3d6 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/util/RequestContextUtilTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/util/RequestContextUtilTest.java @@ -26,12 +26,12 @@ public class RequestContextUtilTest { private RequestContext requestContext; @After - public void tearDown() throws Exception { + public void tearDown() { verifyNoMoreInteractions(requestContext); } @Test - public void closeRequestContextWithRpcError() throws Exception { + public void closeRequestContextWithRpcError() { final String errorMessage = "Test error"; RequestContextUtil.closeRequestContextWithRpcError( requestContext, @@ -43,7 +43,7 @@ public class RequestContextUtilTest { } @Test - public void closeRequestContext() throws Exception { + public void closeRequestContext() { doThrow(new IllegalStateException()).when(requestContext).close(); RequestContextUtil.closeRequestContext(requestContext); verify(requestContext).close(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/util/RequestInputUtilsTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/util/RequestInputUtilsTest.java index 8686724b8f..46404a133c 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/util/RequestInputUtilsTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/util/RequestInputUtilsTest.java @@ -18,7 +18,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731 public class RequestInputUtilsTest { @Test - public void createMultipartHeader() throws Exception { + public void createMultipartHeader() { final Short version = OFConstants.OFP_VERSION_1_3; final Long xid = 42L; final MultipartType type = MultipartType.OFPMPDESC; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImplParamTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImplParamTest.java index 17672c9efe..915dd00938 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImplParamTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImplParamTest.java @@ -80,7 +80,7 @@ public class StatisticsContextImplParamTest extends StatisticsContextImpMockInit } @Test - public void gatherDynamicDataTest() throws InterruptedException { + public void gatherDynamicDataTest() { when(mockedDeviceState.isTableStatisticsAvailable()).thenReturn(Boolean.TRUE); when(mockedDeviceState.isFlowStatisticsAvailable()).thenReturn(Boolean.TRUE); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImplTest.java index 02962122f4..0b0db5a2da 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImplTest.java @@ -51,7 +51,7 @@ public class StatisticsContextImplTest extends StatisticsContextImpMockInitiatio Mockito.mock(OpenflowProviderConfig.class); @Before - public void setUp() throws Exception { + public void setUp() { convertorManager = ConvertorManagerFactory.createDefaultManager(); when(mockedDeviceInfo.reserveXidForDeviceMessage()).thenReturn(TEST_XID); Mockito.when(mockedDeviceContext.getDeviceState()).thenReturn(mockedDeviceState); @@ -93,7 +93,7 @@ public class StatisticsContextImplTest extends StatisticsContextImpMockInitiatio */ @Test @SuppressWarnings("checkstyle:IllegalCatch") - public void testClose() throws Exception { + public void testClose() { statisticsContext = new StatisticsContextImpl<>(mockedDeviceContext, convertorManager, @@ -118,13 +118,13 @@ public class StatisticsContextImplTest extends StatisticsContextImpMockInitiatio } @Test - public void testGatherDynamicData_none() throws Exception { + public void testGatherDynamicData_none() { statisticsContext.instantiateServiceInstance(); Mockito.verifyNoMoreInteractions(mockedStatisticsGatheringService, mockedStatisticsOnFlyGatheringService); } @Test - public void testGatherDynamicData_all() throws Exception { + public void testGatherDynamicData_all() { Mockito.reset(mockedDeviceState); when(mockedDeviceState.isTableStatisticsAvailable()).thenReturn(Boolean.TRUE); when(mockedDeviceState.isFlowStatisticsAvailable()).thenReturn(Boolean.TRUE); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsGatheringUtilsTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsGatheringUtilsTest.java index 7d0ae8f5fd..fe4e0e0ee8 100755 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsGatheringUtilsTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsGatheringUtilsTest.java @@ -169,7 +169,7 @@ public class StatisticsGatheringUtilsTest { private MultipartWriterProvider provider; @Before - public void setUp() throws Exception { + public void setUp() { when(deviceContext.getDeviceInfo()).thenReturn(deviceInfo); when(deviceContext.getDeviceFlowRegistry()).thenReturn(deviceFlowRegistry); when(deviceContext.getDeviceGroupRegistry()).thenReturn(deviceGroupRegistry); @@ -190,7 +190,7 @@ public class StatisticsGatheringUtilsTest { } @Test - public void testWriteFlowStatistics() throws Exception { + public void testWriteFlowStatistics() { final ArgumentCaptor dataStoreType = ArgumentCaptor.forClass(LogicalDatastoreType.class); final ArgumentCaptor flowPath = ArgumentCaptor.forClass(InstanceIdentifier.class); final ArgumentCaptor flow = ArgumentCaptor.forClass(Flow.class); @@ -530,7 +530,7 @@ public class StatisticsGatheringUtilsTest { } @Test - public void testDeleteAllKnownFlows() throws Exception { + public void testDeleteAllKnownFlows() { final short tableId = 0; final InstanceIdentifier nodePath = deviceInfo.getNodeInstanceIdentifier().augmentation(FlowCapableNode.class); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsManagerImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsManagerImplTest.java index ac53e5a2c8..c09f3e23f0 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsManagerImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsManagerImplTest.java @@ -223,7 +223,7 @@ public class StatisticsManagerImplTest { } @Test - public void testClose() throws Exception { + public void testClose() { statisticsManager.close(); verify(serviceControlRegistration).close(); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsPollingServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsPollingServiceTest.java index 605f16ed5a..20f37d1ae2 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsPollingServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsPollingServiceTest.java @@ -30,7 +30,7 @@ public class StatisticsPollingServiceTest { private StatisticsPollingService statisticsPollingService; @Before - public void setUp() throws Exception { + public void setUp() { when(timeCounter.getAverageTimeBetweenMarks()).thenReturn(15000L); when(gatheringSupplier.get()).thenReturn(Futures.immediateFuture(true)); statisticsPollingService = new StatisticsPollingService( @@ -39,7 +39,7 @@ public class StatisticsPollingServiceTest { } @Test - public void startUp() throws Exception { + public void startUp() { statisticsPollingService.startUp(); verify(timeCounter).markStart(); } @@ -52,7 +52,7 @@ public class StatisticsPollingServiceTest { } @Test - public void scheduler() throws Exception { + public void scheduler() { statisticsPollingService.scheduler(); verify(timeCounter).getAverageTimeBetweenMarks(); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/TimeCounterTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/TimeCounterTest.java index 1c4a9ff5ee..7080a4f0bb 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/TimeCounterTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/TimeCounterTest.java @@ -23,7 +23,7 @@ public class TimeCounterTest { private TimeCounter timeCounter; @Before - public void setUp() throws Exception { + public void setUp() { timeCounter = new TimeCounter(); } @@ -41,7 +41,7 @@ public class TimeCounterTest { * @throws Exception if interrupted */ @Test - public void testGetAverageTimeBetweenMarks() throws Exception { + public void testGetAverageTimeBetweenMarks() { Assert.assertEquals(0, timeCounter.getAverageTimeBetweenMarks()); timeCounter.markStart(); Assert.assertEquals(0, timeCounter.getAverageTimeBetweenMarks()); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightFlowStatisticsServiceImpl1Test.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightFlowStatisticsServiceImpl1Test.java index 4f9abf088b..9c68de8af6 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightFlowStatisticsServiceImpl1Test.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightFlowStatisticsServiceImpl1Test.java @@ -49,7 +49,7 @@ public class OpendaylightFlowStatisticsServiceImpl1Test extends AbstractStatsSer } @Test(expected = IllegalAccessError.class) - public void testGetAggregateFlowStatisticsFromFlowTableForAllFlows() throws Exception { + public void testGetAggregateFlowStatisticsFromFlowTableForAllFlows() { GetAggregateFlowStatisticsFromFlowTableForAllFlowsInputBuilder input = new GetAggregateFlowStatisticsFromFlowTableForAllFlowsInputBuilder() .setNode(createNodeRef("unitProt:123")) @@ -59,7 +59,7 @@ public class OpendaylightFlowStatisticsServiceImpl1Test extends AbstractStatsSer } @Test(expected = IllegalAccessError.class) - public void testGetAllFlowStatisticsFromFlowTable() throws Exception { + public void testGetAllFlowStatisticsFromFlowTable() { GetAllFlowStatisticsFromFlowTableInputBuilder input = new GetAllFlowStatisticsFromFlowTableInputBuilder() .setNode(createNodeRef("unitProt:123")) .setTableId(new TableId((short) 1)); @@ -68,7 +68,7 @@ public class OpendaylightFlowStatisticsServiceImpl1Test extends AbstractStatsSer } @Test(expected = IllegalAccessError.class) - public void testGetAllFlowsStatisticsFromAllFlowTables() throws Exception { + public void testGetAllFlowsStatisticsFromAllFlowTables() { GetAllFlowsStatisticsFromAllFlowTablesInputBuilder input = new GetAllFlowsStatisticsFromAllFlowTablesInputBuilder() .setNode(createNodeRef("unitProt:123")); @@ -77,7 +77,7 @@ public class OpendaylightFlowStatisticsServiceImpl1Test extends AbstractStatsSer } @Test(expected = IllegalAccessError.class) - public void testGetFlowStatisticsFromFlowTable() throws Exception { + public void testGetFlowStatisticsFromFlowTable() { GetFlowStatisticsFromFlowTableInputBuilder input = new GetFlowStatisticsFromFlowTableInputBuilder() .setNode(createNodeRef("unitProt:123")) .setPriority(5); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightFlowStatisticsServiceImpl3Test.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightFlowStatisticsServiceImpl3Test.java index bfc1fb19bf..9da86fb4a9 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightFlowStatisticsServiceImpl3Test.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightFlowStatisticsServiceImpl3Test.java @@ -42,7 +42,7 @@ public class OpendaylightFlowStatisticsServiceImpl3Test extends AbstractStatsSer } @Test - public void testGetAggregateFlowStatisticsFromFlowTableForAllFlows() throws Exception { + public void testGetAggregateFlowStatisticsFromFlowTableForAllFlows() { GetAggregateFlowStatisticsFromFlowTableForAllFlowsInput input = new GetAggregateFlowStatisticsFromFlowTableForAllFlowsInputBuilder() .setNode(createNodeRef("unitProt:123")) @@ -54,7 +54,7 @@ public class OpendaylightFlowStatisticsServiceImpl3Test extends AbstractStatsSer } @Test - public void testGetAllFlowStatisticsFromFlowTable() throws Exception { + public void testGetAllFlowStatisticsFromFlowTable() { GetAllFlowStatisticsFromFlowTableInput input = new GetAllFlowStatisticsFromFlowTableInputBuilder() .setNode(createNodeRef("unitProt:123")) .setTableId(new TableId((short) 1)) @@ -65,7 +65,7 @@ public class OpendaylightFlowStatisticsServiceImpl3Test extends AbstractStatsSer } @Test - public void testGetAllFlowsStatisticsFromAllFlowTables() throws Exception { + public void testGetAllFlowsStatisticsFromAllFlowTables() { GetAllFlowsStatisticsFromAllFlowTablesInput input = new GetAllFlowsStatisticsFromAllFlowTablesInputBuilder() .setNode(createNodeRef("unitProt:123")) .build(); @@ -75,7 +75,7 @@ public class OpendaylightFlowStatisticsServiceImpl3Test extends AbstractStatsSer } @Test - public void testGetFlowStatisticsFromFlowTable() throws Exception { + public void testGetFlowStatisticsFromFlowTable() { GetFlowStatisticsFromFlowTableInput input = new GetFlowStatisticsFromFlowTableInputBuilder() .setNode(createNodeRef("unitProt:123")) .setPriority(5) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightFlowTableStatisticsServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightFlowTableStatisticsServiceImplTest.java index edd81db795..23fd2ac06a 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightFlowTableStatisticsServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightFlowTableStatisticsServiceImplTest.java @@ -93,7 +93,7 @@ public class OpendaylightFlowTableStatisticsServiceImplTest extends AbstractSing } @Test - public void testBuildRequest() throws Exception { + public void testBuildRequest() { Xid xid = new Xid(42L); GetFlowTablesStatisticsInputBuilder input = new GetFlowTablesStatisticsInputBuilder() .setNode(createNodeRef("unitProt:123")); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightGroupStatisticsServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightGroupStatisticsServiceImplTest.java index 9ed65a9be4..848d03b06e 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightGroupStatisticsServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightGroupStatisticsServiceImplTest.java @@ -79,7 +79,7 @@ public class OpendaylightGroupStatisticsServiceImplTest extends AbstractSingleSt } @After - public void tearDown() throws Exception { + public void tearDown() { Mockito.verify(notificationPublishService).offerNotification(ArgumentMatchers.any()); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightMeterStatisticsServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightMeterStatisticsServiceImplTest.java index cb0ad0dbff..792ed116c9 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightMeterStatisticsServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightMeterStatisticsServiceImplTest.java @@ -79,7 +79,7 @@ public class OpendaylightMeterStatisticsServiceImplTest extends AbstractSingleSt } @After - public void tearDown() throws Exception { + public void tearDown() { Mockito.verify(notificationPublishService).offerNotification(ArgumentMatchers.any()); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightPortStatisticsServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightPortStatisticsServiceImplTest.java index 941fc2aa37..428f0d387e 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightPortStatisticsServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightPortStatisticsServiceImplTest.java @@ -57,7 +57,7 @@ public class OpendaylightPortStatisticsServiceImplTest extends AbstractSingleSta } @After - public void tearDown() throws Exception { + public void tearDown() { Mockito.verify(notificationPublishService).offerNotification(ArgumentMatchers.any()); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightQueueStatisticsServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightQueueStatisticsServiceImplTest.java index ce5bd48155..f3e60fef2b 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightQueueStatisticsServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightQueueStatisticsServiceImplTest.java @@ -57,7 +57,7 @@ public class OpendaylightQueueStatisticsServiceImplTest extends AbstractSingleSt } @After - public void tearDown() throws Exception { + public void tearDown() { Mockito.verify(notificationPublishService).offerNotification(ArgumentMatchers.any()); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/PortStatsServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/PortStatsServiceTest.java index 80a8b4f4a2..8cf5e207d1 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/PortStatsServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/PortStatsServiceTest.java @@ -31,7 +31,7 @@ public class PortStatsServiceTest extends AbstractStatsServiceTest { } @Test - public void testBuildRequest() throws Exception { + public void testBuildRequest() { Xid xid = new Xid(42L); GetNodeConnectorStatisticsInputBuilder input = new GetNodeConnectorStatisticsInputBuilder() .setNodeConnectorId(new NodeConnectorId("junitProto:11:12")) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/compatibility/AbstractCompatibleStatServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/compatibility/AbstractCompatibleStatServiceTest.java index 7dae97b3fa..062878b254 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/compatibility/AbstractCompatibleStatServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/compatibility/AbstractCompatibleStatServiceTest.java @@ -112,7 +112,7 @@ public class AbstractCompatibleStatServiceTest extends AbstractStatsServiceTest } @Test - public void testGetOfVersion() throws Exception { + public void testGetOfVersion() { Assert.assertEquals(OFConstants.OFP_VERSION_1_3, service.getOfVersion().getVersion()); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/compatibility/OpendaylightFlowStatisticsServiceDelegateImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/compatibility/OpendaylightFlowStatisticsServiceDelegateImplTest.java index c853add6a3..83574b6c67 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/compatibility/OpendaylightFlowStatisticsServiceDelegateImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/compatibility/OpendaylightFlowStatisticsServiceDelegateImplTest.java @@ -88,7 +88,7 @@ public class OpendaylightFlowStatisticsServiceDelegateImplTest extends AbstractS } @Test(expected = IllegalAccessError.class) - public void testGetAggregateFlowStatisticsFromFlowTableForGivenMatch() throws Exception { + public void testGetAggregateFlowStatisticsFromFlowTableForGivenMatch() { flowStatisticsServiceDelegate.getAggregateFlowStatisticsFromFlowTableForGivenMatch(null); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/dedicated/StatisticsGatheringOnTheFlyServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/dedicated/StatisticsGatheringOnTheFlyServiceTest.java index ab50f4030c..8cc1fd19b0 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/dedicated/StatisticsGatheringOnTheFlyServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/dedicated/StatisticsGatheringOnTheFlyServiceTest.java @@ -45,14 +45,14 @@ public class StatisticsGatheringOnTheFlyServiceTest extends ServiceMocking { } @Test - public void testGetStatisticsOfType() throws Exception { + public void testGetStatisticsOfType() { final EventIdentifier eventIdentifier = new EventIdentifier("ut-event", "ut-device-id:1"); statisticsGatheringService.getStatisticsOfType(eventIdentifier, MultipartType.OFPMPFLOW); Mockito.verify(mockedRequestContextStack).createRequestContext(); } @Test - public void testBuildRequest() throws Exception { + public void testBuildRequest() { final long xidValue = 21L; Xid xid = new Xid(xidValue); final OfHeader request = statisticsGatheringService.buildRequest(xid, MultipartType.OFPMPFLOW); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/dedicated/StatisticsGatheringServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/dedicated/StatisticsGatheringServiceTest.java index 6cc42d016a..b7a70d7e44 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/dedicated/StatisticsGatheringServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/dedicated/StatisticsGatheringServiceTest.java @@ -32,7 +32,7 @@ public class StatisticsGatheringServiceTest extends ServiceMocking { } @Test - public void testGetStatisticsOfType() throws Exception { + public void testGetStatisticsOfType() { final EventIdentifier eventIdentifier = new EventIdentifier("ut-event", "ut-device-id:1"); for (MultipartType mpType : MultipartType.values()) { statisticsGatheringService.getStatisticsOfType(eventIdentifier, mpType); @@ -42,7 +42,7 @@ public class StatisticsGatheringServiceTest extends ServiceMocking { } @Test - public void testBuildRequest() throws Exception { + public void testBuildRequest() { final long xidValue = 21L; Xid xid = new Xid(xidValue); for (MultipartType mpType : MultipartType.values()) { diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/AbstractDirectStatisticsServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/AbstractDirectStatisticsServiceTest.java index 1df959a2cc..e793c8fd9d 100755 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/AbstractDirectStatisticsServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/AbstractDirectStatisticsServiceTest.java @@ -97,7 +97,7 @@ public abstract class AbstractDirectStatisticsServiceTest { } @Before - public void init() throws Exception { + public void init() { nodeConnectorId = InventoryDataServiceUtil.nodeConnectorIdfromDatapathPortNo( DATAPATH_ID, PORT_NO, OpenflowVersion.get(OF_VERSION)); @@ -129,14 +129,14 @@ public abstract class AbstractDirectStatisticsServiceTest { setUp(); } - protected abstract void setUp() throws Exception; + protected abstract void setUp(); @Test - public abstract void testBuildRequestBody() throws Exception; + public abstract void testBuildRequestBody(); @Test - public abstract void testBuildReply() throws Exception; + public abstract void testBuildReply(); @Test - public abstract void testStoreStatistics() throws Exception; + public abstract void testStoreStatistics(); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/OpendaylightDirectStatisticsServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/OpendaylightDirectStatisticsServiceImplTest.java index 73ef8601bd..1524ce85a3 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/OpendaylightDirectStatisticsServiceImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/OpendaylightDirectStatisticsServiceImplTest.java @@ -60,7 +60,7 @@ public class OpendaylightDirectStatisticsServiceImplTest { private OpendaylightDirectStatisticsService emptyService; @Before - public void setUp() throws Exception { + public void setUp() { final OpendaylightDirectStatisticsServiceProvider provider = new OpendaylightDirectStatisticsServiceProvider(); provider.register(AbstractFlowDirectStatisticsService.class, flowDirectStatisticsService); provider.register(AbstractGroupDirectStatisticsService.class, groupDirectStatisticsService); @@ -73,7 +73,7 @@ public class OpendaylightDirectStatisticsServiceImplTest { } @Test - public void testGetGroupStatistics() throws Exception { + public void testGetGroupStatistics() { service.getGroupStatistics(getGroupStatisticsInput); verify(groupDirectStatisticsService).handleAndReply(getGroupStatisticsInput); } @@ -94,7 +94,7 @@ public class OpendaylightDirectStatisticsServiceImplTest { } @Test - public void testGetQueueStatistics() throws Exception { + public void testGetQueueStatistics() { service.getQueueStatistics(getQueueStatisticsInput); verify(queueDirectStatisticsService).handleAndReply(getQueueStatisticsInput); } @@ -115,7 +115,7 @@ public class OpendaylightDirectStatisticsServiceImplTest { } @Test - public void testGetFlowStatistics() throws Exception { + public void testGetFlowStatistics() { service.getFlowStatistics(getFlowStatisticsInput); verify(flowDirectStatisticsService).handleAndReply(getFlowStatisticsInput); } @@ -136,7 +136,7 @@ public class OpendaylightDirectStatisticsServiceImplTest { } @Test - public void testGetMeterStatistics() throws Exception { + public void testGetMeterStatistics() { service.getMeterStatistics(getMeterStatisticsInput); verify(meterDirectStatisticsService).handleAndReply(getMeterStatisticsInput); } @@ -157,7 +157,7 @@ public class OpendaylightDirectStatisticsServiceImplTest { } @Test - public void testGetNodeConnectorStatistics() throws Exception { + public void testGetNodeConnectorStatistics() { service.getNodeConnectorStatistics(getNodeConnectorStatisticsInput); verify(nodeConnectorDirectStatisticsService).handleAndReply(getNodeConnectorStatisticsInput); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/multilayer/FlowDirectStatisticsServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/multilayer/FlowDirectStatisticsServiceTest.java index 41efadf426..3fced71de2 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/multilayer/FlowDirectStatisticsServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/multilayer/FlowDirectStatisticsServiceTest.java @@ -45,7 +45,7 @@ public class FlowDirectStatisticsServiceTest extends AbstractDirectStatisticsSer private FlowDirectStatisticsService service; @Override - public void setUp() throws Exception { + public void setUp() { service = new FlowDirectStatisticsService(requestContextStack, deviceContext, convertorManager, @@ -56,7 +56,7 @@ public class FlowDirectStatisticsServiceTest extends AbstractDirectStatisticsSer } @Override - public void testBuildRequestBody() throws Exception { + public void testBuildRequestBody() { final GetFlowStatisticsInput input = mock(GetFlowStatisticsInput.class); when(input.getTableId()).thenReturn(TABLE_NO); @@ -71,7 +71,7 @@ public class FlowDirectStatisticsServiceTest extends AbstractDirectStatisticsSer } @Override - public void testBuildReply() throws Exception { + public void testBuildReply() { final MultipartReply reply = mock(MultipartReply.class); final MultipartReplyFlowCase flowCase = mock(MultipartReplyFlowCase.class); final MultipartReplyFlow flow = mock(MultipartReplyFlow.class); @@ -104,7 +104,7 @@ public class FlowDirectStatisticsServiceTest extends AbstractDirectStatisticsSer } @Override - public void testStoreStatistics() throws Exception { + public void testStoreStatistics() { final FlowAndStatisticsMapList stat = mock(FlowAndStatisticsMapList.class); when(stat.getTableId()).thenReturn(TABLE_NO); when(stat.getMatch()).thenReturn(new MatchBuilder().build()); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/multilayer/GroupDirectStatisticsServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/multilayer/GroupDirectStatisticsServiceTest.java index 5798df5881..c50f80cf5d 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/multilayer/GroupDirectStatisticsServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/multilayer/GroupDirectStatisticsServiceTest.java @@ -40,7 +40,7 @@ public class GroupDirectStatisticsServiceTest extends AbstractDirectStatisticsSe private GroupDirectStatisticsService service; @Override - public void setUp() throws Exception { + public void setUp() { service = new GroupDirectStatisticsService(requestContextStack, deviceContext, convertorManager, @@ -48,7 +48,7 @@ public class GroupDirectStatisticsServiceTest extends AbstractDirectStatisticsSe } @Override - public void testBuildRequestBody() throws Exception { + public void testBuildRequestBody() { final GetGroupStatisticsInput input = mock(GetGroupStatisticsInput.class); lenient().when(input.getNode()).thenReturn(createNodeRef(NODE_ID)); @@ -64,7 +64,7 @@ public class GroupDirectStatisticsServiceTest extends AbstractDirectStatisticsSe } @Override - public void testBuildReply() throws Exception { + public void testBuildReply() { final MultipartReply reply = mock(MultipartReply.class); final MultipartReplyGroupCase groupCase = mock(MultipartReplyGroupCase.class); final MultipartReplyGroup group = mock(MultipartReplyGroup.class); @@ -96,7 +96,7 @@ public class GroupDirectStatisticsServiceTest extends AbstractDirectStatisticsSe } @Override - public void testStoreStatistics() throws Exception { + public void testStoreStatistics() { final org.opendaylight.yang.gen.v1.urn .opendaylight.group.types.rev131018.group.statistics.reply.GroupStats stat = mock(org.opendaylight.yang.gen.v1.urn diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/multilayer/MeterDirectStatisticsServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/multilayer/MeterDirectStatisticsServiceTest.java index 4990c249ca..6faddacb79 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/multilayer/MeterDirectStatisticsServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/multilayer/MeterDirectStatisticsServiceTest.java @@ -39,13 +39,13 @@ public class MeterDirectStatisticsServiceTest extends AbstractDirectStatisticsSe private MeterDirectStatisticsService service; @Override - public void setUp() throws Exception { + public void setUp() { service = new MeterDirectStatisticsService(requestContextStack, deviceContext, convertorManager, multipartWriterProvider); } @Override - public void testBuildRequestBody() throws Exception { + public void testBuildRequestBody() { final GetMeterStatisticsInput input = mock(GetMeterStatisticsInput.class); when(input.getMeterId()).thenReturn(new MeterId(METER_NO)); @@ -59,7 +59,7 @@ public class MeterDirectStatisticsServiceTest extends AbstractDirectStatisticsSe } @Override - public void testBuildReply() throws Exception { + public void testBuildReply() { final MultipartReply reply = mock(MultipartReply.class); final MultipartReplyMeterCase MeterCase = mock(MultipartReplyMeterCase.class); final MultipartReplyMeter meter = mock(MultipartReplyMeter.class); @@ -85,7 +85,7 @@ public class MeterDirectStatisticsServiceTest extends AbstractDirectStatisticsSe } @Override - public void testStoreStatistics() throws Exception { + public void testStoreStatistics() { final org.opendaylight.yang.gen.v1.urn.opendaylight.meter.types.rev130918.meter.statistics.reply.MeterStats stat = mock( org.opendaylight.yang.gen.v1.urn.opendaylight.meter.types.rev130918.meter.statistics.reply.MeterStats diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/multilayer/NodeConnectorDirectStatisticsServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/multilayer/NodeConnectorDirectStatisticsServiceTest.java index 3ec5f6c3a5..321be4b1e6 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/multilayer/NodeConnectorDirectStatisticsServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/multilayer/NodeConnectorDirectStatisticsServiceTest.java @@ -38,7 +38,7 @@ public class NodeConnectorDirectStatisticsServiceTest extends AbstractDirectStat private PortDirectStatisticsService service; @Override - public void setUp() throws Exception { + public void setUp() { service = new PortDirectStatisticsService(requestContextStack, deviceContext, convertorManager, @@ -46,7 +46,7 @@ public class NodeConnectorDirectStatisticsServiceTest extends AbstractDirectStat } @Override - public void testBuildRequestBody() throws Exception { + public void testBuildRequestBody() { final GetNodeConnectorStatisticsInput input = mock(GetNodeConnectorStatisticsInput.class); lenient().when(input.getNode()).thenReturn(createNodeRef(NODE_ID)); @@ -62,7 +62,7 @@ public class NodeConnectorDirectStatisticsServiceTest extends AbstractDirectStat } @Override - public void testBuildReply() throws Exception { + public void testBuildReply() { final MultipartReply reply = mock(MultipartReply.class); final MultipartReplyPortStatsCase nodeConnectorCase = mock(MultipartReplyPortStatsCase.class); final MultipartReplyPortStats nodeConnector = mock(MultipartReplyPortStats.class); @@ -97,7 +97,7 @@ public class NodeConnectorDirectStatisticsServiceTest extends AbstractDirectStat } @Override - public void testStoreStatistics() throws Exception { + public void testStoreStatistics() { final NodeConnectorStatisticsAndPortNumberMap stat = mock(NodeConnectorStatisticsAndPortNumberMap.class); when(stat.getNodeConnectorId()).thenReturn(nodeConnectorId); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/multilayer/QueueDirectStatisticsServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/multilayer/QueueDirectStatisticsServiceTest.java index c2ce06a194..96df59863c 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/multilayer/QueueDirectStatisticsServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/multilayer/QueueDirectStatisticsServiceTest.java @@ -42,7 +42,7 @@ public class QueueDirectStatisticsServiceTest extends AbstractDirectStatisticsSe private QueueDirectStatisticsService service; @Override - public void setUp() throws Exception { + public void setUp() { service = new QueueDirectStatisticsService(requestContextStack, deviceContext, convertorManager, @@ -50,7 +50,7 @@ public class QueueDirectStatisticsServiceTest extends AbstractDirectStatisticsSe } @Override - public void testBuildRequestBody() throws Exception { + public void testBuildRequestBody() { final GetQueueStatisticsInput input = mock(GetQueueStatisticsInput.class); lenient().when(input.getNode()).thenReturn(createNodeRef(NODE_ID)); @@ -68,7 +68,7 @@ public class QueueDirectStatisticsServiceTest extends AbstractDirectStatisticsSe } @Override - public void testBuildReply() throws Exception { + public void testBuildReply() { final MultipartReply reply = mock(MultipartReply.class); final MultipartReplyQueueCase queueCase = mock(MultipartReplyQueueCase.class); final MultipartReplyQueue queue = mock(MultipartReplyQueue.class); @@ -95,7 +95,7 @@ public class QueueDirectStatisticsServiceTest extends AbstractDirectStatisticsSe } @Test - public void testStoreStatisticsBarePortNo() throws Exception { + public void testStoreStatisticsBarePortNo() { final QueueIdAndStatisticsMap map = mock(QueueIdAndStatisticsMap.class); when(map.getQueueId()).thenReturn(new QueueId(QUEUE_NO)); when(map.getNodeConnectorId()).thenReturn(new NodeConnectorId("1")); @@ -109,7 +109,7 @@ public class QueueDirectStatisticsServiceTest extends AbstractDirectStatisticsSe } @Override - public void testStoreStatistics() throws Exception { + public void testStoreStatistics() { final QueueIdAndStatisticsMap map = mock(QueueIdAndStatisticsMap.class); when(map.getQueueId()).thenReturn(new QueueId(QUEUE_NO)); when(map.getNodeConnectorId()).thenReturn(new NodeConnectorId("openflow:1:1")); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/FlowDirectStatisticsServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/FlowDirectStatisticsServiceTest.java index bcb761a8af..d0eee124fc 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/FlowDirectStatisticsServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/FlowDirectStatisticsServiceTest.java @@ -46,7 +46,7 @@ public class FlowDirectStatisticsServiceTest extends AbstractDirectStatisticsSer private FlowDirectStatisticsService service; @Override - public void setUp() throws Exception { + public void setUp() { service = new FlowDirectStatisticsService(requestContextStack, deviceContext, convertorManager, @@ -57,7 +57,7 @@ public class FlowDirectStatisticsServiceTest extends AbstractDirectStatisticsSer } @Override - public void testBuildRequestBody() throws Exception { + public void testBuildRequestBody() { final GetFlowStatisticsInput input = mock(GetFlowStatisticsInput.class); when(input.getTableId()).thenReturn(TABLE_NO); @@ -70,7 +70,7 @@ public class FlowDirectStatisticsServiceTest extends AbstractDirectStatisticsSer } @Override - public void testBuildReply() throws Exception { + public void testBuildReply() { final FlowAndStatisticsMapList flowStat = new FlowAndStatisticsMapListBuilder() .setDuration(new DurationBuilder() .setSecond(new Counter32(1L)) @@ -100,7 +100,7 @@ public class FlowDirectStatisticsServiceTest extends AbstractDirectStatisticsSer } @Override - public void testStoreStatistics() throws Exception { + public void testStoreStatistics() { final FlowAndStatisticsMapList stat = mock(FlowAndStatisticsMapList.class); when(stat.getTableId()).thenReturn(TABLE_NO); when(stat.getMatch()).thenReturn(new MatchBuilder().build()); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/GroupDirectStatisticsServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/GroupDirectStatisticsServiceTest.java index 72d2533b02..f43224e5a6 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/GroupDirectStatisticsServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/GroupDirectStatisticsServiceTest.java @@ -38,7 +38,7 @@ public class GroupDirectStatisticsServiceTest extends AbstractDirectStatisticsSe private GroupDirectStatisticsService service; @Override - public void setUp() throws Exception { + public void setUp() { service = new GroupDirectStatisticsService(requestContextStack, deviceContext, convertorManager, @@ -46,7 +46,7 @@ public class GroupDirectStatisticsServiceTest extends AbstractDirectStatisticsSe } @Override - public void testBuildRequestBody() throws Exception { + public void testBuildRequestBody() { final GetGroupStatisticsInput input = mock(GetGroupStatisticsInput.class); lenient().when(input.getNode()).thenReturn(createNodeRef(NODE_ID)); @@ -60,7 +60,7 @@ public class GroupDirectStatisticsServiceTest extends AbstractDirectStatisticsSe } @Override - public void testBuildReply() throws Exception { + public void testBuildReply() { final GroupStats groupStat = new GroupStatsBuilder() .setGroupId(new GroupId(GROUP_NO)) .build(); @@ -83,7 +83,7 @@ public class GroupDirectStatisticsServiceTest extends AbstractDirectStatisticsSe } @Override - public void testStoreStatistics() throws Exception { + public void testStoreStatistics() { final org.opendaylight.yang.gen.v1.urn .opendaylight.group.types.rev131018.group.statistics.reply.GroupStats stat = mock(org.opendaylight.yang.gen.v1.urn diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/MeterDirectStatisticsServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/MeterDirectStatisticsServiceTest.java index cb9d144aae..0e85f37114 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/MeterDirectStatisticsServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/MeterDirectStatisticsServiceTest.java @@ -43,7 +43,7 @@ public class MeterDirectStatisticsServiceTest extends AbstractDirectStatisticsSe private MeterDirectStatisticsService service; @Override - public void setUp() throws Exception { + public void setUp() { service = new MeterDirectStatisticsService(requestContextStack, deviceContext, convertorManager, @@ -51,7 +51,7 @@ public class MeterDirectStatisticsServiceTest extends AbstractDirectStatisticsSe } @Override - public void testBuildRequestBody() throws Exception { + public void testBuildRequestBody() { final GetMeterStatisticsInput input = mock(GetMeterStatisticsInput.class); lenient().when(input.getNode()).thenReturn(createNodeRef(NODE_ID)); @@ -65,7 +65,7 @@ public class MeterDirectStatisticsServiceTest extends AbstractDirectStatisticsSe } @Override - public void testBuildReply() throws Exception { + public void testBuildReply() { final MeterStats meterStat = new MeterStatsBuilder() .setMeterId(new MeterId(METER_NO)) .setByteInCount(new Counter64(BigInteger.ONE)) @@ -94,7 +94,7 @@ public class MeterDirectStatisticsServiceTest extends AbstractDirectStatisticsSe } @Override - public void testStoreStatistics() throws Exception { + public void testStoreStatistics() { final org.opendaylight.yang.gen.v1.urn .opendaylight.meter.types.rev130918.meter.statistics.reply.MeterStats stat = mock(org.opendaylight.yang.gen.v1.urn diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/NodeConnectorDirectStatisticsServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/NodeConnectorDirectStatisticsServiceTest.java index f5c5615055..22497a949a 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/NodeConnectorDirectStatisticsServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/NodeConnectorDirectStatisticsServiceTest.java @@ -36,7 +36,7 @@ public class NodeConnectorDirectStatisticsServiceTest extends AbstractDirectStat private PortDirectStatisticsService service; @Override - public void setUp() throws Exception { + public void setUp() { service = new PortDirectStatisticsService(requestContextStack, deviceContext, convertorManager, @@ -44,7 +44,7 @@ public class NodeConnectorDirectStatisticsServiceTest extends AbstractDirectStat } @Override - public void testBuildRequestBody() throws Exception { + public void testBuildRequestBody() { final GetNodeConnectorStatisticsInput input = mock(GetNodeConnectorStatisticsInput.class); lenient().when(input.getNode()).thenReturn(createNodeRef(NODE_ID)); @@ -58,7 +58,7 @@ public class NodeConnectorDirectStatisticsServiceTest extends AbstractDirectStat } @Override - public void testBuildReply() throws Exception { + public void testBuildReply() { final NodeConnectorStatisticsAndPortNumberMap portStat = new NodeConnectorStatisticsAndPortNumberMapBuilder() .setNodeConnectorId(nodeConnectorId) .build(); @@ -80,7 +80,7 @@ public class NodeConnectorDirectStatisticsServiceTest extends AbstractDirectStat } @Override - public void testStoreStatistics() throws Exception { + public void testStoreStatistics() { final NodeConnectorStatisticsAndPortNumberMap stat = mock(NodeConnectorStatisticsAndPortNumberMap.class); when(stat.getNodeConnectorId()).thenReturn(nodeConnectorId); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/QueueDirectStatisticsServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/QueueDirectStatisticsServiceTest.java index eda1e8e8b5..5383a96ac3 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/QueueDirectStatisticsServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/QueueDirectStatisticsServiceTest.java @@ -42,7 +42,7 @@ public class QueueDirectStatisticsServiceTest extends AbstractDirectStatisticsSe private QueueDirectStatisticsService service; @Override - public void setUp() throws Exception { + public void setUp() { service = new QueueDirectStatisticsService(requestContextStack, deviceContext, convertorManager, @@ -50,7 +50,7 @@ public class QueueDirectStatisticsServiceTest extends AbstractDirectStatisticsSe } @Override - public void testBuildRequestBody() throws Exception { + public void testBuildRequestBody() { final GetQueueStatisticsInput input = mock(GetQueueStatisticsInput.class); lenient().when(input.getNode()).thenReturn(createNodeRef(NODE_ID)); @@ -66,7 +66,7 @@ public class QueueDirectStatisticsServiceTest extends AbstractDirectStatisticsSe } @Override - public void testBuildReply() throws Exception { + public void testBuildReply() { final QueueIdAndStatisticsMap queueStats = new QueueIdAndStatisticsMapBuilder() .setQueueId(new QueueId(QUEUE_NO)) .setNodeConnectorId(new NodeConnectorId(PORT_NO.toString())) @@ -91,7 +91,7 @@ public class QueueDirectStatisticsServiceTest extends AbstractDirectStatisticsSe } @Test - public void testStoreStatisticsBarePortNo() throws Exception { + public void testStoreStatisticsBarePortNo() { final QueueIdAndStatisticsMap map = mock(QueueIdAndStatisticsMap.class); when(map.getQueueId()).thenReturn(new QueueId(QUEUE_NO)); when(map.getNodeConnectorId()).thenReturn(new NodeConnectorId("1")); @@ -105,7 +105,7 @@ public class QueueDirectStatisticsServiceTest extends AbstractDirectStatisticsSe } @Override - public void testStoreStatistics() throws Exception { + public void testStoreStatistics() { final QueueIdAndStatisticsMap map = mock(QueueIdAndStatisticsMap.class); when(map.getQueueId()).thenReturn(new QueueId(QUEUE_NO)); when(map.getNodeConnectorId()).thenReturn(new NodeConnectorId("openflow:1:1")); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/translator/AggregatedFlowStatisticsTranslatorTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/translator/AggregatedFlowStatisticsTranslatorTest.java index d36eb811ee..0e9077a014 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/translator/AggregatedFlowStatisticsTranslatorTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/translator/AggregatedFlowStatisticsTranslatorTest.java @@ -32,12 +32,12 @@ public class AggregatedFlowStatisticsTranslatorTest { private DeviceInfo deviceInfo; @Before - public void setUp() throws Exception { + public void setUp() { translator = new AggregatedFlowStatisticsTranslator(); } @Test - public void testTranslate() throws Exception { + public void testTranslate() { MultipartReplyAggregateBuilder aggregateStatsValueBld = new MultipartReplyAggregateBuilder() .setByteCount(BigInteger.valueOf(1L)) .setFlowCount(2L) diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/translator/FlowRemovedTranslatorTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/translator/FlowRemovedTranslatorTest.java index 278e00aabe..4bf6d176de 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/translator/FlowRemovedTranslatorTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/translator/FlowRemovedTranslatorTest.java @@ -64,7 +64,7 @@ public class FlowRemovedTranslatorTest { private FlowWildcardsV10 flowWildcards; @Before - public void setUp() throws Exception { + public void setUp() { final KeyedInstanceIdentifier nodeId = InstanceIdentifier.create(Nodes.class) .child(Node.class, new NodeKey(new NodeId("dummyNodeId"))); @@ -76,7 +76,7 @@ public class FlowRemovedTranslatorTest { } @Test - public void testTranslate() throws Exception { + public void testTranslate() { org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.FlowRemoved flowRemovedMessage = buildMessage(false); final FlowRemoved flowRemoved = translator.translate(flowRemovedMessage, deviceInfo, null); @@ -87,7 +87,7 @@ public class FlowRemovedTranslatorTest { } @Test - public void testTranslateV10() throws Exception { + public void testTranslateV10() { org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.FlowRemoved flowRemovedMessage = buildMessage(true); final FlowRemoved flowRemoved = translatorV10.translate(flowRemovedMessage, deviceInfo, null); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/translator/PacketReceivedTranslatorTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/translator/PacketReceivedTranslatorTest.java index d5487950ef..b0ae933a03 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/translator/PacketReceivedTranslatorTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/translator/PacketReceivedTranslatorTest.java @@ -78,7 +78,7 @@ public class PacketReceivedTranslatorTest { static final Long PORT_NUM_VALUE = 11L; @Before - public void setUp() throws Exception { + public void setUp() { final List phyPorts = Collections.singletonList(phyPort); convertorManager = ConvertorManagerFactory.createDefaultManager(); @@ -86,7 +86,7 @@ public class PacketReceivedTranslatorTest { } @Test - public void testTranslate() throws Exception { + public void testTranslate() { final KeyedInstanceIdentifier nodePath = KeyedInstanceIdentifier .create(Nodes.class) .child(Node.class, new NodeKey(new NodeId("openflow:10"))); @@ -124,7 +124,7 @@ public class PacketReceivedTranslatorTest { } @Test - public void testGetPacketInMatch() throws Exception { + public void testGetPacketInMatch() { MatchEntryBuilder matchEntryBuilder = assembleMatchEntryBld(PORT_NUM_VALUE); MatchBuilder packetInMatchBld = new MatchBuilder() .setMatchEntry(Lists.newArrayList(matchEntryBuilder.build())); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/translator/PortUpdateTranslatorTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/translator/PortUpdateTranslatorTest.java index 6c82e6dc57..af8a4b07d9 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/translator/PortUpdateTranslatorTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/translator/PortUpdateTranslatorTest.java @@ -47,7 +47,7 @@ public class PortUpdateTranslatorTest { private PortStatusMessageBuilder portBld; @Before - public void setUp() throws Exception { + public void setUp() { portUpdateTranslator = new PortUpdateTranslator(); portStateBld = new StateBuilder().setLive(true); @@ -58,7 +58,7 @@ public class PortUpdateTranslatorTest { } @Test - public void testTranslate_13() throws Exception { + public void testTranslate_13() { Mockito.when(deviceInfo.getVersion()).thenReturn(OFConstants.OFP_VERSION_1_3); final org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.port.rev130925.PortFeatures portFeatures = org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.port.rev130925.PortFeatures @@ -88,7 +88,7 @@ public class PortUpdateTranslatorTest { } @Test - public void testTranslate_10() throws Exception { + public void testTranslate_10() { Mockito.when(deviceInfo.getVersion()).thenReturn(OFConstants.OFP_VERSION_1_0); final org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.port.rev130925.PortFeatures portFeatures = new org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.port.rev130925.PortFeatures( diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/AddressNormalizationUtilTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/AddressNormalizationUtilTest.java index 8dcfe0e5c4..98e23ed0af 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/AddressNormalizationUtilTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/AddressNormalizationUtilTest.java @@ -24,7 +24,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.opendaylight.ipv6.arbitrary public class AddressNormalizationUtilTest { @Test - public void normalizeProtocolAgnosticPortOF10() throws Exception { + public void normalizeProtocolAgnosticPortOF10() { final Uri left = new Uri("openflow:1:INPORT"); final Uri right = new Uri("IN_PORT"); @@ -35,7 +35,7 @@ public class AddressNormalizationUtilTest { } @Test - public void normalizeProtocolAgnosticPortOF13() throws Exception { + public void normalizeProtocolAgnosticPortOF13() { final Uri left = new Uri("openflow:1:ANY"); final Uri right = new Uri("ANY"); @@ -46,7 +46,7 @@ public class AddressNormalizationUtilTest { } @Test - public void normalizeIpv6Prefix() throws Exception { + public void normalizeIpv6Prefix() { final Ipv6Prefix left = new Ipv6Prefix("1E3D:5678:9ABC::/24"); final Ipv6Prefix right = new Ipv6Prefix("1e3d:5600:0:0:0:0:0:0/24"); @@ -57,7 +57,7 @@ public class AddressNormalizationUtilTest { } @Test - public void normalizeIpv6Arbitrary() throws Exception { + public void normalizeIpv6Arbitrary() { final Ipv6Address leftAddress = new Ipv6Address("1E3D:5678:9ABC::"); final Ipv6ArbitraryMask leftMask = new Ipv6ArbitraryMask("FFFF:FF00::"); final Ipv6Prefix right = new Ipv6Prefix("1e3d:5600:0:0:0:0:0:0/24"); @@ -69,7 +69,7 @@ public class AddressNormalizationUtilTest { } @Test - public void normalizeIpv6AddressWithoutMask() throws Exception { + public void normalizeIpv6AddressWithoutMask() { final Ipv6Address left = new Ipv6Address("1E3D:5678:9ABC::"); final Ipv6Address right = new Ipv6Address("1e3d:5678:9abc:0:0:0:0:0"); @@ -80,7 +80,7 @@ public class AddressNormalizationUtilTest { } @Test - public void normalizeIpv4Prefix() throws Exception { + public void normalizeIpv4Prefix() { final Ipv4Prefix left = new Ipv4Prefix("192.168.72.1/16"); final Ipv4Prefix right = new Ipv4Prefix("192.168.0.0/16"); @@ -91,7 +91,7 @@ public class AddressNormalizationUtilTest { } @Test - public void normalizeIpv4Arbitrary() throws Exception { + public void normalizeIpv4Arbitrary() { final Ipv4Address leftAddress = new Ipv4Address("192.168.72.1"); final DottedQuad leftMask = new DottedQuad("255.255.0.0"); final Ipv4Prefix right = new Ipv4Prefix("192.168.0.0/16"); @@ -103,7 +103,7 @@ public class AddressNormalizationUtilTest { } @Test - public void normalizeMacAddress() throws Exception { + public void normalizeMacAddress() { final MacAddress left = new MacAddress("01:23:45:AB:CD:EF"); final MacAddress right = new MacAddress("01:23:45:ab:cd:ef"); @@ -114,7 +114,7 @@ public class AddressNormalizationUtilTest { } @Test - public void normalizeMacAddressMask() throws Exception { + public void normalizeMacAddressMask() { final MacAddress left = new MacAddress("FF:FF:FF:FF:FF:FF"); final MacAddress right = null; diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/BarrierUtilTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/BarrierUtilTest.java index 8cfd6bed96..6f24255584 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/BarrierUtilTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/BarrierUtilTest.java @@ -52,18 +52,18 @@ public class BarrierUtilTest { private ArgumentCaptor, RpcResult>> pairCpt; @Before - public void setUp() throws Exception { + public void setUp() { Mockito.when(transactionService.sendBarrier(ArgumentMatchers.any())) .thenReturn(RpcResultBuilder.success().buildFuture()); } @After - public void tearDown() throws Exception { + public void tearDown() { Mockito.verifyNoMoreInteractions(transactionService, compositeTransform); } @Test - public void testChainBarrier() throws Exception { + public void testChainBarrier() { final String data = "ut-data1"; final ListenableFuture> input = RpcResultBuilder.success(data).buildFuture(); final ListenableFuture> chainResult = @@ -81,7 +81,7 @@ public class BarrierUtilTest { } @Test - public void testCreateSendBarrierInput() throws Exception { + public void testCreateSendBarrierInput() { final SendBarrierInput barrierInput = BarrierUtil.createSendBarrierInput(NODE_REF); Assert.assertEquals(NODE_REF, barrierInput.getNode()); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/DeviceInitializationUtilTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/DeviceInitializationUtilTest.java index 1078df83c0..cbceb9e8f2 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/DeviceInitializationUtilTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/DeviceInitializationUtilTest.java @@ -69,7 +69,7 @@ public class DeviceInitializationUtilTest { private FeaturesReply featuresReply; @Before - public void setUp() throws Exception { + public void setUp() { when(deviceInfo.getNodeInstanceIdentifier()).thenReturn(NODE_II); doReturn(CommitInfo.emptyFluentFuture()).when(writeTransaction).commit(); when(dataBroker.newWriteOnlyTransaction()).thenReturn(writeTransaction); @@ -83,7 +83,7 @@ public class DeviceInitializationUtilTest { } @Test - public void makeEmptyNodes() throws Exception { + public void makeEmptyNodes() { DeviceInitializationUtil.makeEmptyNodes(dataBroker); verify(dataBroker).newWriteOnlyTransaction(); verify(writeTransaction).merge(LogicalDatastoreType.OPERATIONAL, InstanceIdentifier @@ -94,26 +94,26 @@ public class DeviceInitializationUtilTest { } @Test - public void makeEmptyTables() throws Exception { + public void makeEmptyTables() { DeviceInitializationUtil.makeEmptyTables(txFacade, deviceInfo, (short) 10); verify(txFacade, times(10)).writeToTransaction( eq(LogicalDatastoreType.OPERATIONAL), any(), any()); } @Test - public void getIpAddress() throws Exception { + public void getIpAddress() { final IpAddress ipAddress = DeviceInitializationUtil.getIpAddress(connectionContext, NODE_II); assertEquals(ipAddress, IetfInetUtil.INSTANCE.ipAddressFor(INET_SOCKET_ADDRESS.getAddress())); } @Test - public void getPortNumber() throws Exception { + public void getPortNumber() { final PortNumber portNumber = DeviceInitializationUtil.getPortNumber(connectionContext, NODE_II); assertEquals(portNumber, new PortNumber(PORT)); } @Test - public void getSwitchFeatures() throws Exception { + public void getSwitchFeatures() { final SwitchFeatures switchFeatures = DeviceInitializationUtil.getSwitchFeatures(connectionContext); assertEquals(TABLES, switchFeatures.getMaxTables().shortValue()); } diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/FlatBatchUtilTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/FlatBatchUtilTest.java index 47c6b3bd26..545066a0b6 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/FlatBatchUtilTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/FlatBatchUtilTest.java @@ -57,7 +57,7 @@ public class FlatBatchUtilTest { private static final Logger LOG = LoggerFactory.getLogger(FlatBatchUtilTest.class); @Test - public void testMarkBarriersWhereNeeded_noBarrier() throws Exception { + public void testMarkBarriersWhereNeeded_noBarrier() { final List batches = Lists.newArrayList( //general part - no flush required createBatch(BatchStepType.GROUP_REMOVE), @@ -87,7 +87,7 @@ public class FlatBatchUtilTest { } @Test - public void testMarkBarriersWhereNeeded_allBarriers() throws Exception { + public void testMarkBarriersWhereNeeded_allBarriers() { // need to flush G+/F+ checkBarriersBetween(BatchStepType.GROUP_ADD, BatchStepType.FLOW_ADD); // need to flush G+/F* @@ -129,7 +129,7 @@ public class FlatBatchUtilTest { } @Test - public void testMarkBarriersWhereNeeded_single() throws Exception { + public void testMarkBarriersWhereNeeded_single() { final List batches = Lists.newArrayList( //general part - no flush required createBatch(BatchStepType.GROUP_REMOVE) @@ -143,7 +143,7 @@ public class FlatBatchUtilTest { } @Test - public void testDecideBarrier() throws Exception { + public void testDecideBarrier() { Assert.assertTrue(FlatBatchUtil.decideBarrier(EnumSet.of(BatchStepType.GROUP_ADD), BatchStepType.FLOW_ADD)); Assert.assertTrue(FlatBatchUtil.decideBarrier(EnumSet.of(BatchStepType.GROUP_ADD), BatchStepType.FLOW_UPDATE)); @@ -162,7 +162,7 @@ public class FlatBatchUtilTest { } @Test - public void testAssembleBatchPlan() throws Exception { + public void testAssembleBatchPlan() { final List batches = Lists.newArrayList( createBatch(BatchStepType.GROUP_ADD), createBatch(BatchStepType.GROUP_REMOVE, 2), @@ -188,7 +188,7 @@ public class FlatBatchUtilTest { } @Test - public void testDetectBatchStepType() throws Exception { + public void testDetectBatchStepType() { for (BatchStepType stepType : BatchStepType.values()) { LOG.debug("checking detection of: {}", stepType); final Batch batch = createBatch(stepType); @@ -268,7 +268,7 @@ public class FlatBatchUtilTest { } @Test - public void testMergeJobsResultsFutures() throws Exception { + public void testMergeJobsResultsFutures() { final BatchFailure batchFailure = new BatchFailureBuilder() .setBatchOrder(9) .setBatchItemIdChoice(new FlatBatchFailureFlowIdCaseBuilder() diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/FlowUtilTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/FlowUtilTest.java index 261d05f96e..dc5034b5f3 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/FlowUtilTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/FlowUtilTest.java @@ -43,7 +43,7 @@ public class FlowUtilTest { public static final Short DUMMY_TABLE_ID = 1; @Test - public void testBuildFlowPath() throws Exception { + public void testBuildFlowPath() { final InstanceIdentifier nodePath = InstanceIdentifier .create(Nodes.class) .child(Node.class, new NodeKey(DUMMY_NODE_ID)); @@ -56,7 +56,7 @@ public class FlowUtilTest { } @Test - public void testCreateCumulatingFunction() throws Exception { + public void testCreateCumulatingFunction() { final Function>, RpcResult>> function = FlowUtil.createCumulatingFunction(Lists.newArrayList(createBatchFlowIdGrouping(DUMMY_FLOW_ID), createBatchFlowIdGrouping(DUMMY_FLOW_ID_2))); @@ -81,37 +81,37 @@ public class FlowUtilTest { } @Test - public void testFlowAddTransformFailure() throws Exception { + public void testFlowAddTransformFailure() { final RpcResult> input = createBatchOutcomeWithError(); checkBatchErrorOutcomeTransformation(FlowUtil.FLOW_ADD_TRANSFORM.apply(input)); } @Test - public void testFlowAddTransformSuccess() throws Exception { + public void testFlowAddTransformSuccess() { final RpcResult> input = createEmptyBatchOutcome(); checkBatchSuccessOutcomeTransformation(FlowUtil.FLOW_ADD_TRANSFORM.apply(input)); } @Test - public void testFlowRemoveTransformFailure() throws Exception { + public void testFlowRemoveTransformFailure() { final RpcResult> input = createBatchOutcomeWithError(); checkBatchErrorOutcomeTransformation(FlowUtil.FLOW_REMOVE_TRANSFORM.apply(input)); } @Test - public void testFlowRemoveTransformSuccess() throws Exception { + public void testFlowRemoveTransformSuccess() { final RpcResult> input = createEmptyBatchOutcome(); checkBatchSuccessOutcomeTransformation(FlowUtil.FLOW_REMOVE_TRANSFORM.apply(input)); } @Test - public void testFlowUpdateTransformFailure() throws Exception { + public void testFlowUpdateTransformFailure() { final RpcResult> input = createBatchOutcomeWithError(); checkBatchErrorOutcomeTransformation(FlowUtil.FLOW_UPDATE_TRANSFORM.apply(input)); } @Test - public void testFlowUpdateTransformSuccess() throws Exception { + public void testFlowUpdateTransformSuccess() { final RpcResult> input = createEmptyBatchOutcome(); checkBatchSuccessOutcomeTransformation(FlowUtil.FLOW_UPDATE_TRANSFORM.apply(input)); } @@ -148,7 +148,7 @@ public class FlowUtilTest { } @Test - public void testCreateComposingFunction_success_success() throws Exception { + public void testCreateComposingFunction_success_success() { final Function, RpcResult>, RpcResult> compositeFunction = FlowUtil.createComposingFunction(); @@ -164,7 +164,7 @@ public class FlowUtilTest { } @Test - public void testCreateComposingFunction_failure_success() throws Exception { + public void testCreateComposingFunction_failure_success() { final Function, RpcResult>, RpcResult> compositeFunction = FlowUtil.createComposingFunction(); @@ -180,7 +180,7 @@ public class FlowUtilTest { } @Test - public void testCreateComposingFunction_success_failure() throws Exception { + public void testCreateComposingFunction_success_failure() { final Function, RpcResult>, RpcResult> compositeFunction = FlowUtil.createComposingFunction(); @@ -196,7 +196,7 @@ public class FlowUtilTest { } @Test - public void testCreateComposingFunction_failure_failure() throws Exception { + public void testCreateComposingFunction_failure_failure() { final Function, RpcResult>, RpcResult> compositeFunction = FlowUtil.createComposingFunction(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/GroupUtilTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/GroupUtilTest.java index ccdf2e861b..7fde060327 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/GroupUtilTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/GroupUtilTest.java @@ -49,7 +49,7 @@ public class GroupUtilTest { 0b00000000000000000000000000000000000001111111111111001100000000001L; @Test - public void testBuildGroupPath() throws Exception { + public void testBuildGroupPath() { final InstanceIdentifier nodePath = InstanceIdentifier .create(Nodes.class) .child(Node.class, new NodeKey(DUMMY_NODE_ID)); @@ -61,7 +61,7 @@ public class GroupUtilTest { } @Test - public void testCreateCumulatingFunction() throws Exception { + public void testCreateCumulatingFunction() { final Function>, RpcResult>> function = GroupUtil.createCumulatingFunction(Lists.newArrayList(createBatchGroup(DUMMY_GROUP_ID), createBatchGroup(DUMMY_GROUP_ID_2))); @@ -84,37 +84,37 @@ public class GroupUtilTest { } @Test - public void testGroupAddTransformFailure() throws Exception { + public void testGroupAddTransformFailure() { final RpcResult> input = createBatchOutcomeWithError(); checkBatchErrorOutcomeTransformation(GroupUtil.GROUP_ADD_TRANSFORM.apply(input)); } @Test - public void testGroupAddTransformFailureSuccess() throws Exception { + public void testGroupAddTransformFailureSuccess() { final RpcResult> input = createEmptyBatchOutcome(); checkBatchSuccessOutcomeTransformation(GroupUtil.GROUP_ADD_TRANSFORM.apply(input)); } @Test - public void testGroupRemoveTransformFailure() throws Exception { + public void testGroupRemoveTransformFailure() { final RpcResult> input = createBatchOutcomeWithError(); checkBatchErrorOutcomeTransformation(GroupUtil.GROUP_REMOVE_TRANSFORM.apply(input)); } @Test - public void testFlowRemoveTransformSuccess() throws Exception { + public void testFlowRemoveTransformSuccess() { final RpcResult> input = createEmptyBatchOutcome(); checkBatchSuccessOutcomeTransformation(GroupUtil.GROUP_REMOVE_TRANSFORM.apply(input)); } @Test - public void testFlowUpdateTransformFailure() throws Exception { + public void testFlowUpdateTransformFailure() { final RpcResult> input = createBatchOutcomeWithError(); checkBatchErrorOutcomeTransformation(GroupUtil.GROUP_UPDATE_TRANSFORM.apply(input)); } @Test - public void testFlowUpdateTransformSuccess() throws Exception { + public void testFlowUpdateTransformSuccess() { final RpcResult> input = createEmptyBatchOutcome(); checkBatchSuccessOutcomeTransformation(GroupUtil.GROUP_UPDATE_TRANSFORM.apply(input)); } @@ -151,7 +151,7 @@ public class GroupUtilTest { } @Test - public void testCreateComposingFunction_success_success() throws Exception { + public void testCreateComposingFunction_success_success() { final Function, RpcResult>, RpcResult> compositeFunction = GroupUtil.createComposingFunction(); @@ -167,7 +167,7 @@ public class GroupUtilTest { } @Test - public void testCreateComposingFunction_failure_success() throws Exception { + public void testCreateComposingFunction_failure_success() { final Function, RpcResult>, RpcResult> compositeFunction = GroupUtil.createComposingFunction(); @@ -183,7 +183,7 @@ public class GroupUtilTest { } @Test - public void testCreateComposingFunction_success_failure() throws Exception { + public void testCreateComposingFunction_success_failure() { final Function, RpcResult>, RpcResult> compositeFunction = GroupUtil.createComposingFunction(); @@ -199,7 +199,7 @@ public class GroupUtilTest { } @Test - public void testCreateComposingFunction_failure_failure() throws Exception { + public void testCreateComposingFunction_failure_failure() { final Function, RpcResult>, RpcResult> compositeFunction = GroupUtil.createComposingFunction(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/MdSalRegistrationUtilsTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/MdSalRegistrationUtilsTest.java index bdf0a2a918..c1a619c5e1 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/MdSalRegistrationUtilsTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/MdSalRegistrationUtilsTest.java @@ -65,7 +65,7 @@ public class MdSalRegistrationUtilsTest { private ConvertorManager convertorManager; @Before - public void setUp() throws Exception { + public void setUp() { convertorManager = ConvertorManagerFactory.createDefaultManager(); when(mockedDeviceContext.getDeviceInfo()).thenReturn(mockedDeviceInfo); when(mockedConnectionContext.getFeatures()).thenReturn(mockedFeatures); @@ -84,7 +84,7 @@ public class MdSalRegistrationUtilsTest { } @Test - public void registerStatCompatibilityServices() throws Exception { + public void registerStatCompatibilityServices() { final OpendaylightFlowStatisticsService flowStatService = OpendaylightFlowStatisticsServiceImpl .createWithOook(mockedRpcContext, mockedDeviceContext, convertorManager); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/MeterUtilTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/MeterUtilTest.java index 74ee0b8b59..7fa7ebcb02 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/MeterUtilTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/MeterUtilTest.java @@ -44,7 +44,7 @@ public class MeterUtilTest { private static final MeterId DUMMY_METER_ID_2 = new MeterId(43L); @Test - public void testBuildGroupPath() throws Exception { + public void testBuildGroupPath() { final InstanceIdentifier nodePath = InstanceIdentifier .create(Nodes.class) .child(Node.class, new NodeKey(DUMMY_NODE_ID)); @@ -56,7 +56,7 @@ public class MeterUtilTest { } @Test - public void testCreateCumulatingFunction() throws Exception { + public void testCreateCumulatingFunction() { final Function>, RpcResult>> function = MeterUtil.createCumulativeFunction(Lists.newArrayList( createBatchMeter(DUMMY_METER_ID), @@ -82,37 +82,37 @@ public class MeterUtilTest { } @Test - public void testMeterAddTransformFailure() throws Exception { + public void testMeterAddTransformFailure() { final RpcResult> input = createBatchOutcomeWithError(); checkBatchErrorOutcomeTransformation(MeterUtil.METER_ADD_TRANSFORM.apply(input)); } @Test - public void testMeterAddTransformSuccess() throws Exception { + public void testMeterAddTransformSuccess() { final RpcResult> input = createEmptyBatchOutcome(); checkBatchSuccessOutcomeTransformation(MeterUtil.METER_ADD_TRANSFORM.apply(input)); } @Test - public void testMeterRemoveTransformFailure() throws Exception { + public void testMeterRemoveTransformFailure() { final RpcResult> input = createBatchOutcomeWithError(); checkBatchErrorOutcomeTransformation(MeterUtil.METER_REMOVE_TRANSFORM.apply(input)); } @Test - public void testFlowRemoveTransformSuccess() throws Exception { + public void testFlowRemoveTransformSuccess() { final RpcResult> input = createEmptyBatchOutcome(); checkBatchSuccessOutcomeTransformation(MeterUtil.METER_REMOVE_TRANSFORM.apply(input)); } @Test - public void testFlowUpdateTransformFailure() throws Exception { + public void testFlowUpdateTransformFailure() { final RpcResult> input = createBatchOutcomeWithError(); checkBatchErrorOutcomeTransformation(MeterUtil.METER_UPDATE_TRANSFORM.apply(input)); } @Test - public void testFlowUpdateTransformSuccess() throws Exception { + public void testFlowUpdateTransformSuccess() { final RpcResult> input = createEmptyBatchOutcome(); checkBatchSuccessOutcomeTransformation(MeterUtil.METER_UPDATE_TRANSFORM.apply(input)); } @@ -149,7 +149,7 @@ public class MeterUtilTest { } @Test - public void testCreateComposingFunction_success_success() throws Exception { + public void testCreateComposingFunction_success_success() { final Function, RpcResult>, RpcResult> compositeFunction = MeterUtil.createComposingFunction(); @@ -165,7 +165,7 @@ public class MeterUtilTest { } @Test - public void testCreateComposingFunction_failure_success() throws Exception { + public void testCreateComposingFunction_failure_success() { final Function, RpcResult>, RpcResult> compositeFunction = MeterUtil.createComposingFunction(); @@ -181,7 +181,7 @@ public class MeterUtilTest { } @Test - public void testCreateComposingFunction_success_failure() throws Exception { + public void testCreateComposingFunction_success_failure() { final Function, RpcResult>, RpcResult> compositeFunction = MeterUtil.createComposingFunction(); @@ -197,7 +197,7 @@ public class MeterUtilTest { } @Test - public void testCreateComposingFunction_failure_failure() throws Exception { + public void testCreateComposingFunction_failure_failure() { final Function, RpcResult>, RpcResult> compositeFunction = MeterUtil.createComposingFunction(); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/NodeConnectorRefToPortTranslatorTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/NodeConnectorRefToPortTranslatorTest.java index 75b499dd54..cd7920d2b7 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/NodeConnectorRefToPortTranslatorTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/NodeConnectorRefToPortTranslatorTest.java @@ -64,14 +64,14 @@ public class NodeConnectorRefToPortTranslatorTest extends TestCase { } @Test - public void testGetPortNoFromPacketIn() throws Exception { + public void testGetPortNoFromPacketIn() { PacketIn packetIn = createPacketIn(PORT_NO); Long portNo = NodeConnectorRefToPortTranslator.getPortNoFromPacketIn(packetIn); assertEquals(portNo, PORT_NO); } @Test - public void testNodeConnectorConversion() throws Exception { + public void testNodeConnectorConversion() { // Mock the packet in message PacketIn packetIn = createPacketIn(PORT_NO); diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/PathUtilTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/PathUtilTest.java index fc943e8ee0..39ae0f246f 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/PathUtilTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/PathUtilTest.java @@ -29,12 +29,12 @@ public class PathUtilTest { private static final NodeRef NODE_REF = new NodeRef(NODE_II); @Test - public void testExtractNodeId() throws Exception { + public void testExtractNodeId() { Assert.assertEquals(NODE_ID, PathUtil.extractNodeId(NODE_REF)); } @Test - public void testExtractNodeId2() throws Exception { + public void testExtractNodeId2() { Assert.assertEquals(NODE_ID, PathUtil.extractNodeId(NODE_II)); } } \ No newline at end of file diff --git a/openflowplugin/src/test/java/org/opendaylight/openflowplugin/openflow/md/core/sal/convertor/ConvertorManagerTest.java b/openflowplugin/src/test/java/org/opendaylight/openflowplugin/openflow/md/core/sal/convertor/ConvertorManagerTest.java index 27dc780976..955878bf39 100644 --- a/openflowplugin/src/test/java/org/opendaylight/openflowplugin/openflow/md/core/sal/convertor/ConvertorManagerTest.java +++ b/openflowplugin/src/test/java/org/opendaylight/openflowplugin/openflow/md/core/sal/convertor/ConvertorManagerTest.java @@ -31,7 +31,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti @RunWith(MockitoJUnitRunner.class) public class ConvertorManagerTest { @Test - public void testRegisterConvertor() throws Exception { + public void testRegisterConvertor() { final ConvertorManager convertorManager = new ConvertorManager(OFConstants.OFP_VERSION_1_3) .registerConvertor(OFConstants.OFP_VERSION_1_3, new Convertor() { @Override @@ -50,7 +50,7 @@ public class ConvertorManagerTest { } @Test - public void testConvert() throws Exception { + public void testConvert() { final ConvertorManager convertorManager = new ConvertorManager(OFConstants.OFP_VERSION_1_3) .registerConvertor(OFConstants.OFP_VERSION_1_3, new Convertor() { @Override @@ -77,7 +77,7 @@ public class ConvertorManagerTest { * Test for {@link ConvertorManager#convert(Collection, ConvertorData)}. */ @Test - public void testConvert1() throws Exception { + public void testConvert1() { final ConvertorManager convertorManager = new ConvertorManager(OFConstants.OFP_VERSION_1_3) .registerConvertor(OFConstants.OFP_VERSION_1_3, new Convertor, String, VersionConvertorData>() { diff --git a/openflowplugin/src/test/java/org/opendaylight/openflowplugin/openflow/md/core/sal/convertor/TableFeaturesConvertorTest.java b/openflowplugin/src/test/java/org/opendaylight/openflowplugin/openflow/md/core/sal/convertor/TableFeaturesConvertorTest.java index 203bf3b841..bb9f2dcdbb 100644 --- a/openflowplugin/src/test/java/org/opendaylight/openflowplugin/openflow/md/core/sal/convertor/TableFeaturesConvertorTest.java +++ b/openflowplugin/src/test/java/org/opendaylight/openflowplugin/openflow/md/core/sal/convertor/TableFeaturesConvertorTest.java @@ -373,7 +373,7 @@ public class TableFeaturesConvertorTest { } @Test - public void testToTableFeaturesRequest() throws Exception { + public void testToTableFeaturesRequest() { List tableFeaturesList = new ArrayList<>(); org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.table.features.TableFeaturesBuilder diff --git a/openflowplugin/src/test/java/org/opendaylight/openflowplugin/openflow/md/core/sal/convertor/common/IpConversionUtilTest.java b/openflowplugin/src/test/java/org/opendaylight/openflowplugin/openflow/md/core/sal/convertor/common/IpConversionUtilTest.java index c6a32918ac..de11d54db7 100644 --- a/openflowplugin/src/test/java/org/opendaylight/openflowplugin/openflow/md/core/sal/convertor/common/IpConversionUtilTest.java +++ b/openflowplugin/src/test/java/org/opendaylight/openflowplugin/openflow/md/core/sal/convertor/common/IpConversionUtilTest.java @@ -57,7 +57,7 @@ public class IpConversionUtilTest { } @Test - public void testCountBitsAsCIDRReplacement() throws Exception { + public void testCountBitsAsCIDRReplacement() { BigInteger maskSeed = new BigInteger("1ffffffffffffffffffffffffffffffff", 16); byte[] maskArray = new byte[16]; LOG.debug("maskSeed= {}", ByteBufUtils.bytesToHexString(maskSeed.toByteArray())); diff --git a/samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/SimpleClientFramer.java b/samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/SimpleClientFramer.java index dbf479c701..27c165de9e 100644 --- a/samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/SimpleClientFramer.java +++ b/samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/SimpleClientFramer.java @@ -36,13 +36,13 @@ public class SimpleClientFramer extends ByteToMessageDecoder { } @Override - public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws Exception { + public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) { LOG.warn("Unexpected exception from downstream.", cause); ctx.close(); } @Override - protected void decode(ChannelHandlerContext chc, ByteBuf bb, List list) throws Exception { + protected void decode(ChannelHandlerContext chc, ByteBuf bb, List list) { if (bb.readableBytes() < LENGTH_OF_HEADER) { LOG.debug("skipping bb - too few data for header: {}", bb.readableBytes()); return; diff --git a/samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/SimpleClientHandler.java b/samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/SimpleClientHandler.java index f4ff429859..cbff4822f3 100644 --- a/samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/SimpleClientHandler.java +++ b/samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/SimpleClientHandler.java @@ -41,7 +41,7 @@ public class SimpleClientHandler extends ChannelInboundHandlerAdapter { } @Override - public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception { + public void channelRead(ChannelHandlerContext ctx, Object msg) { ByteBuf bb = (ByteBuf) msg; if (LOG.isDebugEnabled()) { LOG.debug("Message {}", ByteBufUtils.byteBufToHexString(bb)); @@ -55,7 +55,7 @@ public class SimpleClientHandler extends ChannelInboundHandlerAdapter { } @Override - public void channelActive(ChannelHandlerContext ctx) throws Exception { + public void channelActive(ChannelHandlerContext ctx) { LOG.debug("Client is active"); if (isOnlineFuture != null) { isOnlineFuture.set(true); diff --git a/samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/SimpleClientInitializer.java b/samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/SimpleClientInitializer.java index fd3821e8c3..a94a1a5d59 100644 --- a/samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/SimpleClientInitializer.java +++ b/samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/SimpleClientInitializer.java @@ -39,7 +39,7 @@ public class SimpleClientInitializer extends ChannelInitializer { } @Override - public void initChannel(SocketChannel ch) throws Exception { + public void initChannel(SocketChannel ch) { ChannelPipeline pipeline = ch.pipeline(); if (secured) { SSLEngine engine = ClientSslContextFactory.getClientContext() diff --git a/samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/UdpSimpleClientFramer.java b/samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/UdpSimpleClientFramer.java index 287276fe9b..457927ab91 100644 --- a/samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/UdpSimpleClientFramer.java +++ b/samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/UdpSimpleClientFramer.java @@ -37,13 +37,13 @@ public class UdpSimpleClientFramer extends MessageToMessageDecoder list) throws Exception { + protected void decode(ChannelHandlerContext chc, DatagramPacket msg, List list) { ByteBuf bb = msg.content(); if (bb.readableBytes() < LENGTH_OF_HEADER) { LOG.debug("skipping bb - too few data for header: {}", bb.readableBytes()); diff --git a/samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/UdpSimpleClientInitializer.java b/samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/UdpSimpleClientInitializer.java index 4504eac413..04e4030b64 100644 --- a/samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/UdpSimpleClientInitializer.java +++ b/samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/UdpSimpleClientInitializer.java @@ -34,7 +34,7 @@ public class UdpSimpleClientInitializer extends ChannelInitializer